[PATCH 2/2] Revert "drm/i915: Propagate errors on awaiting already signaled fences"

2021-05-19 Thread Daniel Vetter
From: Jason Ekstrand This reverts commit 9e31c1fe45d555a948ff66f1f0e3fe1f83ca63f7. Ever since that commit, we've been having issues where a hang in one client can propagate to another. In particular, a hang in an app can propagate to the X server which causes the whole desktop to lock up. Sign

[PATCH 1/2] drm/i915/cmdparser: No-op failed batches on all platforms

2021-05-19 Thread Daniel Vetter
On gen9 for blt cmd parser we relied on the magic fence error propagation which: - doesn't work on gen7, because there's no scheduler with ringbuffers there yet - fence error propagation can be weaponized to attack other things, so not a good design idea Instead of magic, do the same thing on

Re: [RFC PATCH 1/3] drm/color: Add RGB Color encodings

2021-05-19 Thread Pekka Paalanen
On Tue, 18 May 2021 10:32:48 -0400 Harry Wentland wrote: > On 2021-05-17 4:34 a.m., Pekka Paalanen wrote: > > On Fri, 14 May 2021 17:04:51 -0400 > > Harry Wentland wrote: > > > >> On 2021-04-30 8:53 p.m., Sebastian Wick wrote: > >>> On 2021-04-26 20:56, Harry Wentland wrote: > > > > ..

[PATCH 1/3] gpu: drm: replace occurrences of invalid character

2021-05-19 Thread Mauro Carvalho Chehab
There are some places at drm that ended receiving a REPLACEMENT CHARACTER U+fffd ('�'), probably because of some bad charset conversion. Fix them by using what it seems to be the proper character. Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/amd/include/atombios.h | 10 +--

Re: [PATCH] drm/i915/gvt: remove local storage of debugfs file

2021-05-19 Thread Zhenyu Wang
On 2021.05.18 18:28:53 +0200, Greg Kroah-Hartman wrote: > On Tue, May 18, 2021 at 06:17:05PM +0200, Greg Kroah-Hartman wrote: > > There is no need to keep the dentry around for the debugfs kvmgt cache > > file, as we can just look it up when we want to remove it later on. > > Simplify the structure

[PATCH] drm/ttm: Explain why ttm_bo_add_move_fence uses a shared slot

2021-05-19 Thread Daniel Vetter
Motivated because I got confused and Christian confirmed why this works. I think this is non-obvious enough that it merits a slightly longer comment. Cc: Christian König Cc: Christian Koenig Cc: Huang Rui Cc: Thomas Hellström Signed-off-by: Daniel Vetter --- drivers/gpu/drm/ttm/ttm_bo.c | 4

Re: [PATCH] drm/i915/gvt: remove local storage of debugfs file

2021-05-19 Thread Greg Kroah-Hartman
On Wed, May 19, 2021 at 04:03:13PM +0800, Zhenyu Wang wrote: > On 2021.05.18 18:28:53 +0200, Greg Kroah-Hartman wrote: > > On Tue, May 18, 2021 at 06:17:05PM +0200, Greg Kroah-Hartman wrote: > > > There is no need to keep the dentry around for the debugfs kvmgt cache > > > file, as we can just look

Re: [PATCH] drm/i915/gvt: remove local storage of debugfs file

2021-05-19 Thread Zhenyu Wang
On 2021.05.19 10:31:18 +0200, Greg Kroah-Hartman wrote: > On Wed, May 19, 2021 at 04:03:13PM +0800, Zhenyu Wang wrote: > > On 2021.05.18 18:28:53 +0200, Greg Kroah-Hartman wrote: > > > On Tue, May 18, 2021 at 06:17:05PM +0200, Greg Kroah-Hartman wrote: > > > > There is no need to keep the dentry ar

[drm-rerere PATCH] nightly.conf: drop amd branches from drm-tip

2021-05-19 Thread Jani Nikula
We've had a stale repo for amd in drm-tip since around v4.15 i.e. for more than three years. Nobody seems to notice or care. Drop the amd branches from drm-tip. Having the current amd branches in drm-tip would be nice to have, if only to have a common drm integration tree. However, maintaining tha

[PATCH 08/10] docs: ABI: sysfs-class-backlight: unify ambient light zone nodes

2021-05-19 Thread Mauro Carvalho Chehab
./scripts/get_abi.pl is warning about duplicated symbol definition: Warning: /sys/class/backlight//l1_daylight_max is defined 2 times: ./Documentation/ABI/testing/sysfs-class-backlight-driver-adp8870:4 ./Documentation/ABI/testing/sysfs-class-backlight-adp8860:12 What happens is that 3

[PATCH 00/10] Documentation build warning fixes

2021-05-19 Thread Mauro Carvalho Chehab
Hi Jon, This small series contain a series of fixes for the documentation. it is against your docs-next branch. Three of the patches fix duplicated symbols at the ABI documents. There are still some ABI warnings from IIO, but all but one were already fixed at linux-next. So, hopefully, after havi

Re: [RFC PATCH 0/3] A drm_plane API to support HDR planes

2021-05-19 Thread Pekka Paalanen
On Tue, 18 May 2021 10:19:25 -0400 Harry Wentland wrote: > On 2021-05-18 3:56 a.m., Pekka Paalanen wrote: > > On Mon, 17 May 2021 15:39:03 -0400 > > Vitaly Prosyak wrote: > > > >> On 2021-05-17 12:48 p.m., Sebastian Wick wrote: ... > >>> I suspect that this is not about tone mapping at al

Re: New uAPI for color management proposal and feedback request

2021-05-19 Thread Pekka Paalanen
On Wed, 12 May 2021 16:04:16 +0300 Ville Syrjälä wrote: > On Wed, May 12, 2021 at 02:06:56PM +0200, Werner Sembach wrote: > > Hello, > > > > In addition to the existing "max bpc", and "Broadcast RGB/output_csc" drm > > properties I propose 4 new properties: > > "preferred pixel encoding", "acti

Re: [Intel-gfx] [PATCH v2 10/15] drm/i915/ttm: Introduce a TTM i915 gem object backend

2021-05-19 Thread Matthew Auld
On Tue, 18 May 2021 at 09:28, Thomas Hellström wrote: > > Most logical place to introduce TTM buffer objects is as an i915 > gem object backend. We need to add some ops to account for added > functionality like delayed delete and LRU list manipulation. > > Initially we support only LMEM and SYSTEM

Re: 回复: [RFC PATCH 1/2] drm/amdgpu: Fix memory corruption due to swapout and swapin

2021-05-19 Thread Christian König
I'm scratching my head how that is even possible. See when a BO is created in the system domain it is just an empty hull, e.g. without backing store and allocated pages. So the swapout function will just ignore it. Christian. Am 19.05.21 um 07:07 schrieb Pan, Xinhui: [AMD Official Use Only]

Re: [RFC PATCH 0/3] A drm_plane API to support HDR planes

2021-05-19 Thread Pekka Paalanen
On Wed, 19 May 2021 11:53:37 +0300 Pekka Paalanen wrote: ... > TL;DR: > > I would summarise my comments so far into these: > > - Telling the kernel the color spaces and letting it come up with > whatever color transformation formula from those is not enough, > because it puts the render in

Re: [Intel-gfx] [PATCH v2 11/15] drm/i915/lmem: Verify checks for lmem residency

2021-05-19 Thread Matthew Auld
On Tue, 18 May 2021 at 09:28, Thomas Hellström wrote: > > Since objects can be migrated or evicted when not pinned or locked, > update the checks for lmem residency or future residency so that > the value returned is not immediately stale. > > Signed-off-by: Thomas Hellström Reviewed-by: Matthew

Re: [drm-rerere PATCH] nightly.conf: drop amd branches from drm-tip

2021-05-19 Thread Daniel Vetter
On Wed, May 19, 2021 at 11:49:32AM +0300, Jani Nikula wrote: > We've had a stale repo for amd in drm-tip since around v4.15 i.e. for > more than three years. Nobody seems to notice or care. Drop the amd > branches from drm-tip. > > Having the current amd branches in drm-tip would be nice to have,

[PATCH] Revert "drm/i915: Propagate errors on awaiting already signaled fences"

2021-05-19 Thread Daniel Vetter
From: Jason Ekstrand This reverts commit 9e31c1fe45d555a948ff66f1f0e3fe1f83ca63f7. Ever since that commit, we've been having issues where a hang in one client can propagate to another. In particular, a hang in an app can propagate to the X server which causes the whole desktop to lock up. Erro

Re: [PATCH 3/3] drm: document minimum kernel version for DRM_CLIENT_CAP_*

2021-05-19 Thread Daniel Vetter
On Tue, May 18, 2021 at 11:14:52AM +, Simon Ser wrote: > The kernel versions including the following commits are referenced: > > DRM_CLIENT_CAP_STEREO_3D > 61d8e3282541 ("drm: Add a STEREO_3D capability to the SET_CLIENT_CAP ioctl") > > DRM_CLIENT_CAP_UNIVERSAL_PLANES > 681e7ec73044 ("drm: Al

Re: [PATCH -next] drm: Fix missing unlock and free on error in drm_legacy_addbufs_pci()

2021-05-19 Thread Daniel Vetter
On Tue, May 18, 2021 at 08:35:02PM +0800, Zou Wei wrote: > Add the missing unlock and free before return from function > drm_legacy_addbufs_pci() in the error handling case. > > Fixes: 70556e24e18e ("drm: remove usage of drm_pci_alloc/free") > Reported-by: Hulk Robot > Signed-off-by: Zou Wei Ap

Re: [PATCH 3/3] drm: document minimum kernel version for DRM_CLIENT_CAP_*

2021-05-19 Thread Daniel Stone
Hi Simon, On Tue, 18 May 2021 at 12:15, Simon Ser wrote: > The kernel versions including the following commits are referenced: > [...] Thanks a lot for writing this up! I trust your ability to drive git log/blame/describe so didn't bother double-checking the version numbers. So this is: Acked-by

Re: [PATCH v2 09/15] drm/ttm, drm/amdgpu: Allow the driver some control over swapping

2021-05-19 Thread Christian König
Am 19.05.21 um 08:27 schrieb Thomas Hellström: On 5/18/21 6:30 PM, Christian König wrote: Am 18.05.21 um 18:07 schrieb Thomas Hellström: On 5/18/21 5:42 PM, Christian König wrote: Am 18.05.21 um 17:38 schrieb Thomas Hellström: On 5/18/21 5:28 PM, Christian König wrote: Am 18.05.21 um 17:2

Re: [PATCH] drm/ttm: Explain why ttm_bo_add_move_fence uses a shared slot

2021-05-19 Thread Christian König
Am 19.05.21 um 10:24 schrieb Daniel Vetter: Motivated because I got confused and Christian confirmed why this works. I think this is non-obvious enough that it merits a slightly longer comment. Cc: Christian König Cc: Christian Koenig Cc: Huang Rui Cc: Thomas Hellström Signed-off-by: Daniel

Re: [PATCH v8 5/8] mm: Device exclusive memory access

2021-05-19 Thread Alistair Popple
On Wednesday, 19 May 2021 7:16:38 AM AEST Peter Xu wrote: > External email: Use caution opening links or attachments > > > On Wed, Apr 07, 2021 at 06:42:35PM +1000, Alistair Popple wrote: > > [...] > > > +static bool try_to_protect(struct page *page, struct mm_struct *mm, > > +

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-19 Thread Michel Dänzer
On 2021-05-19 12:06 a.m., Jason Ekstrand wrote: > On Tue, May 18, 2021 at 4:17 PM Daniel Vetter wrote: >> >> On Tue, May 18, 2021 at 7:40 PM Christian König >> wrote: >>> >>> Am 18.05.21 um 18:48 schrieb Daniel Vetter: On Tue, May 18, 2021 at 2:49 PM Christian König wrote: > A

Re: [PATCH] drm/ttm: Explain why ttm_bo_add_move_fence uses a shared slot

2021-05-19 Thread Huang Rui
On Wed, May 19, 2021 at 04:24:09PM +0800, Daniel Vetter wrote: > Motivated because I got confused and Christian confirmed why this > works. I think this is non-obvious enough that it merits a slightly > longer comment. > > Cc: Christian König > Cc: Christian Koenig > Cc: Huang Rui > Cc: Thomas

Re: [PATCH v7 13/16] drm/scheduler: Fix hang when sched_entity released

2021-05-19 Thread Christian König
Am 18.05.21 um 20:48 schrieb Andrey Grodzovsky: [SNIP] Would this be the right way to do it ? Yes, it is at least a start. Question is if we can wait blocking here or not. We install a callback a bit lower to avoid blocking, so I'm pretty sure that won't work as expected. Christian. I

[PATCH v2] backlight: Kconfig whitespace and indentation cleanups

2021-05-19 Thread Juerg Haefliger
Remove leading whitespaces, replace multi spaces with tabs, and fix help text indentation. Signed-off-by: Juerg Haefliger --- drivers/video/backlight/Kconfig | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/video/backlight/Kconfig b/drivers/vid

Re: [PATCH v7 13/16] drm/scheduler: Fix hang when sched_entity released

2021-05-19 Thread Andrey Grodzovsky
On 2021-05-19 6:57 a.m., Christian König wrote: Am 18.05.21 um 20:48 schrieb Andrey Grodzovsky: [SNIP] Would this be the right way to do it ? Yes, it is at least a start. Question is if we can wait blocking here or not. We install a callback a bit lower to avoid blocking, so I'm pretty

Re: [PATCH v8 5/8] mm: Device exclusive memory access

2021-05-19 Thread Alistair Popple
On Wednesday, 19 May 2021 9:45:05 AM AEST Peter Xu wrote: > External email: Use caution opening links or attachments > > On Tue, May 18, 2021 at 08:03:27PM -0300, Jason Gunthorpe wrote: > > Logically during fork all these device exclusive pages should be > > reverted back to their CPU pages, write

Re: [Intel-gfx] [RFC 2/2] drm/doc/rfc: i915 new parallel submission uAPI plan

2021-05-19 Thread Daniel Vetter
On Tue, May 18, 2021 at 04:58:30PM -0700, Matthew Brost wrote: > Add entry fpr i915 new parallel submission uAPI plan. > > v2: > (Daniel Vetter): > - Expand logical order explaination > - Add dummy header > - Only allow N BBs in execbuf IOCTL > - Configure parallel submission per slot not

Re: [GIT PULL] drm/imx: fixes, dma-fence annotation, and color encoding/range plane properties

2021-05-19 Thread Philipp Zabel
On Wed, 2021-05-19 at 09:19 +1000, Dave Airlie wrote: > On Wed, 12 May 2021 at 23:33, Philipp Zabel wrote: > > Hi Dave, Daniel, > > > > The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5: > > > > Linux 5.13-rc1 (2021-05-09 14:17:44 -0700) > > > > are available in the

Re: [V2][PATCH 2/2] drm: xlnx: consolidate the functions which programming AUDIO_VIDEO_SELECT register

2021-05-19 Thread Paul Cercueil
Hi, Le mar., mai 18 2021 at 17:50:19 +0800, quanyang.w...@windriver.com a écrit : From: Quanyang Wang For now, the functions zynqmp_disp_avbuf_enable/disable_audio and zynqmp_disp_avbuf_enable/disable_video are all programming the register AV_BUF_OUTPUT_AUDIO_VIDEO_SELECT to select the outpu

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-19 Thread Christian König
Am 18.05.21 um 23:17 schrieb Daniel Vetter: [SNIP] The problem in this case is not starting a new CS, but synchronizing to the existing ones. See a heavy TLB flush is made completely out of sync. E.g. it doesn't want to wait for any previous operation. In other words imagine the following exam

Re: [Intel-gfx] [PATCH v2 10/15] drm/i915/ttm: Introduce a TTM i915 gem object backend

2021-05-19 Thread Thomas Hellström
Thanks a lot for reviewing, Matthew! On 5/19/21 11:53 AM, Matthew Auld wrote: On Tue, 18 May 2021 at 09:28, Thomas Hellström wrote: Most logical place to introduce TTM buffer objects is as an i915 gem object backend. We need to add some ops to account for added functionality like delayed delet

Re: [PATCH v8 5/8] mm: Device exclusive memory access

2021-05-19 Thread Alistair Popple
On Wednesday, 19 May 2021 3:27:42 AM AEST Peter Xu wrote: > > > The odd part is the remote GUP should have walked the page table > > > already, so since the target here is the vaddr to replace, the 1st page > > > table walk should be able to both trylock/lock the page, then modify > > > the pte wit

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-19 Thread Christian König
Am 19.05.21 um 00:06 schrieb Jason Ekstrand: [SNIP] E.g. we can't add a fence which doesn't wait for the exclusive one as shared. Ok I think that's a real problem, and guess it's also related to all the ttm privatization tricks and all that. So essentially we'd need the opposite of ttm_bo->mov

Re: [Mesa-dev] [RFC 2/2] drm/doc/rfc: i915 new parallel submission uAPI plan

2021-05-19 Thread Christian König
Oh, yeah we call that gang submit on the AMD side. Had already some internal discussions how to implement this, but so far couldn't figure out how to cleanly introduce that into the DRM scheduler. Can you briefly describe in a few words how that is supposed to work on the Intel side? Thanks

Re: [PATCH v7 13/16] drm/scheduler: Fix hang when sched_entity released

2021-05-19 Thread Christian König
Am 19.05.21 um 13:03 schrieb Andrey Grodzovsky: On 2021-05-19 6:57 a.m., Christian König wrote: Am 18.05.21 um 20:48 schrieb Andrey Grodzovsky: [SNIP] Would this be the right way to do it ? Yes, it is at least a start. Question is if we can wait blocking here or not. We install a callb

Re: [PATCH v7 13/16] drm/scheduler: Fix hang when sched_entity released

2021-05-19 Thread Andrey Grodzovsky
On 2021-05-19 7:46 a.m., Christian König wrote: Am 19.05.21 um 13:03 schrieb Andrey Grodzovsky: On 2021-05-19 6:57 a.m., Christian König wrote: Am 18.05.21 um 20:48 schrieb Andrey Grodzovsky: [SNIP] Would this be the right way to do it ? Yes, it is at least a start. Question is if we

Re: [PATCH v7 13/16] drm/scheduler: Fix hang when sched_entity released

2021-05-19 Thread Christian König
Am 19.05.21 um 13:51 schrieb Andrey Grodzovsky: On 2021-05-19 7:46 a.m., Christian König wrote: Am 19.05.21 um 13:03 schrieb Andrey Grodzovsky: On 2021-05-19 6:57 a.m., Christian König wrote: Am 18.05.21 um 20:48 schrieb Andrey Grodzovsky: [SNIP] Would this be the right way to do it ?

Re: [PATCH 1/2] drm/doc: document how userspace should find out CRTC index

2021-05-19 Thread Leandro Ribeiro
On 5/12/21 10:04 AM, Pekka Paalanen wrote: > On Wed, 12 May 2021 09:50:14 -0300 > Leandro Ribeiro wrote: > >> On 5/6/21 5:50 AM, Pekka Paalanen wrote: >>> On Wed, 28 Apr 2021 18:36:50 -0300 >>> Leandro Ribeiro wrote: >>> In this patch we add a section to document what userspace should

Re: [PATCH v8 5/8] mm: Device exclusive memory access

2021-05-19 Thread Peter Xu
On Wed, May 19, 2021 at 09:04:53PM +1000, Alistair Popple wrote: > Failing fork() because we couldn't take a lock doesn't seem like the right > approach though, especially as there is already existing code that retries. I > get this adds complexity though, so would be happy to take a look at clea

Re: [PATCH] drivers/video/fbdev/core/fbmem.c: add pointer judgment

2021-05-19 Thread Matthew Wilcox
On Wed, May 19, 2021 at 08:00:28PM +0800, songqiang wrote: > Signed-off-by: songqiang > --- You need to explain: - Why you think this patch is needed - Did you observe a problem at runtime? - Is this the output from some checking tool? - Why this is the right way to address the problem

Re: [PATCH v8 5/8] mm: Device exclusive memory access

2021-05-19 Thread Peter Xu
On Wed, May 19, 2021 at 09:35:10PM +1000, Alistair Popple wrote: > I think the approach you are describing is similar to what > migrate_vma_collect()/migrate_vma_unamp() does now and I think it could be > made to work. I ended up going with the GUP+unmap approach in part because > Christoph sugg

Re: [PATCH v8 5/8] mm: Device exclusive memory access

2021-05-19 Thread Peter Xu
On Wed, May 19, 2021 at 08:49:01PM +1000, Alistair Popple wrote: > On Wednesday, 19 May 2021 7:16:38 AM AEST Peter Xu wrote: > > External email: Use caution opening links or attachments > > > > > > On Wed, Apr 07, 2021 at 06:42:35PM +1000, Alistair Popple wrote: > > > > [...] > > > > > +static

Re: [PATCH v8 3/8] mm/rmap: Split try_to_munlock from try_to_unmap

2021-05-19 Thread Alistair Popple
On Wednesday, 19 May 2021 6:04:51 AM AEST Liam Howlett wrote: > External email: Use caution opening links or attachments > > * Alistair Popple [210407 04:43]: > > The behaviour of try_to_unmap_one() is difficult to follow because it > > performs different operations based on a fairly large set of

Re: [PATCH v8 5/8] mm: Device exclusive memory access

2021-05-19 Thread Alistair Popple
On Wednesday, 19 May 2021 10:24:27 PM AEST Peter Xu wrote: > External email: Use caution opening links or attachments > > On Wed, May 19, 2021 at 08:49:01PM +1000, Alistair Popple wrote: > > On Wednesday, 19 May 2021 7:16:38 AM AEST Peter Xu wrote: > > > External email: Use caution opening links o

Re: [PATCH v8 5/8] mm: Device exclusive memory access

2021-05-19 Thread Alistair Popple
On Wednesday, 19 May 2021 10:21:08 PM AEST Peter Xu wrote: > External email: Use caution opening links or attachments > > On Wed, May 19, 2021 at 09:35:10PM +1000, Alistair Popple wrote: > > I think the approach you are describing is similar to what > > migrate_vma_collect()/migrate_vma_unamp() do

Re: [PATCH v8 5/8] mm: Device exclusive memory access

2021-05-19 Thread Alistair Popple
On Wednesday, 19 May 2021 10:15:41 PM AEST Peter Xu wrote: > External email: Use caution opening links or attachments > > On Wed, May 19, 2021 at 09:04:53PM +1000, Alistair Popple wrote: > > Failing fork() because we couldn't take a lock doesn't seem like the right > > approach though, especially

RE: [drm-rerere PATCH] nightly.conf: drop amd branches from drm-tip

2021-05-19 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: Jani Nikula > Sent: Wednesday, May 19, 2021 4:50 AM > To: dim-to...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org; > jani.nik...@intel.com; Deucher, Alexander > ; Koenig, Christian > ; Pan; Pan, X

Re: [PATCH v8 5/8] mm: Device exclusive memory access

2021-05-19 Thread Jason Gunthorpe
On Tue, May 18, 2021 at 07:45:05PM -0400, Peter Xu wrote: > On Tue, May 18, 2021 at 08:03:27PM -0300, Jason Gunthorpe wrote: > > Logically during fork all these device exclusive pages should be > > reverted back to their CPU pages, write protected and the CPU page PTE > > copied to the fork. > > >

Re: [PATCH 2/2] drm/doc: document drm_mode_get_plane

2021-05-19 Thread Leandro Ribeiro
On 5/6/21 6:10 AM, Pekka Paalanen wrote: > On Wed, 28 Apr 2021 18:36:51 -0300 > Leandro Ribeiro wrote: > >> Add a small description and document struct fields of >> drm_mode_get_plane. >> >> Signed-off-by: Leandro Ribeiro > > Hi, > > thanks a lot for revising these. > >> --- >> include/ua

Re: [PATCH 9/9] platform/x86/intel_cht_int33fe: Correct "displayport" fwnode reference

2021-05-19 Thread Hans de Goede
Hi, On 5/3/21 5:46 PM, Hans de Goede wrote: > The Type-C connector on these devices is connected to DP-2 not DP-1, > so the reference must be to the DD04 child-node of the GPU, rather > then the DD02 child-node. > > Signed-off-by: Hans de Goede Since this is pretty much independent from the res

Re: New uAPI for color management proposal and feedback request

2021-05-19 Thread Ville Syrjälä
On Wed, May 19, 2021 at 12:34:05PM +0300, Pekka Paalanen wrote: > On Wed, 12 May 2021 16:04:16 +0300 > Ville Syrjälä wrote: > > > On Wed, May 12, 2021 at 02:06:56PM +0200, Werner Sembach wrote: > > > Hello, > > > > > > In addition to the existing "max bpc", and "Broadcast RGB/output_csc" drm >

Re: [Mesa-dev] [RFC 2/2] drm/doc/rfc: i915 new parallel submission uAPI plan

2021-05-19 Thread Marcin Ślusarz
śr., 19 maj 2021 o 01:41 Matthew Brost napisał(a): > > Add entry fpr i915 new parallel submission uAPI plan. s/fpr/for/ > > v2: > (Daniel Vetter): > - Expand logical order explaination > - Add dummy header > - Only allow N BBs in execbuf IOCTL > - Configure parallel submission per slot

[PATCH] vgaarb: Use ACPI HID name to find integrated GPU

2021-05-19 Thread Kai-Heng Feng
Commit 3d42f1ddc47a ("vgaarb: Keep adding VGA device in queue") assumes the first device is an integrated GPU. However, on AMD platforms an integrated GPU can have higher PCI device number than a discrete GPU. Integrated GPU on ACPI platform generally has _DOD and _DOS method, so use that as predi

Re: [PATCH v8 5/8] mm: Device exclusive memory access

2021-05-19 Thread Peter Xu
On Wed, May 19, 2021 at 11:11:55PM +1000, Alistair Popple wrote: > On Wednesday, 19 May 2021 10:15:41 PM AEST Peter Xu wrote: > > External email: Use caution opening links or attachments > > > > On Wed, May 19, 2021 at 09:04:53PM +1000, Alistair Popple wrote: > > > Failing fork() because we couldn

Re: [PATCH v8 5/8] mm: Device exclusive memory access

2021-05-19 Thread Peter Xu
On Wed, May 19, 2021 at 10:28:42AM -0300, Jason Gunthorpe wrote: > On Tue, May 18, 2021 at 07:45:05PM -0400, Peter Xu wrote: > > On Tue, May 18, 2021 at 08:03:27PM -0300, Jason Gunthorpe wrote: > > > Logically during fork all these device exclusive pages should be > > > reverted back to their CPU p

[PATCH] drm/sched: Avoid data corruptions

2021-05-19 Thread Andrey Grodzovsky
Wait for all dependencies of a job to complete before killing it to avoid data corruptions. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/scheduler/sched_entity.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/schedule

Re: [PATCH] drm/sched: Avoid data corruptions

2021-05-19 Thread Christian König
Am 19.05.21 um 16:14 schrieb Andrey Grodzovsky: Wait for all dependencies of a job to complete before killing it to avoid data corruptions. Signed-off-by: Andrey Grodzovsky Reviewed-by: Christian König --- drivers/gpu/drm/scheduler/sched_entity.c | 5 + 1 file changed, 5 insertions

Re: [PATCH v1 1/1] backlight: lm3630a_bl: Put fwnode in error case during ->probe()

2021-05-19 Thread Lee Jones
On Mon, 10 May 2021, Andy Shevchenko wrote: > device_for_each_child_node() bumps a reference counting of a returned > variable. > We have to balance it whenever we return to the caller. > > Fixes: 8fbce8efe15cd ("backlight: lm3630a: Add firmware node support") > Cc: Brian Masney > Cc: Dan Murph

[Bug 213145] New: AMDGPU resets, timesout and crashes after "*ERROR* Waiting for fences timed out!"

2021-05-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213145 Bug ID: 213145 Summary: AMDGPU resets, timesout and crashes after "*ERROR* Waiting for fences timed out!" Product: Drivers Version: 2.5 Kernel Version: 5.10.37 and 5.10.38

[Bug 213145] AMDGPU resets, timesout and crashes after "*ERROR* Waiting for fences timed out!"

2021-05-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213145 --- Comment #1 from Tomas Gayoso (tgay...@gmail.com) --- Created attachment 296869 --> https://bugzilla.kernel.org/attachment.cgi?id=296869&action=edit lsmod output -- You may reply to this email to add a comment. You are receiving this mail

[Bug 213145] AMDGPU resets, timesout and crashes after "*ERROR* Waiting for fences timed out!"

2021-05-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213145 --- Comment #2 from Tomas Gayoso (tgay...@gmail.com) --- Created attachment 296871 --> https://bugzilla.kernel.org/attachment.cgi?id=296871&action=edit kernel configuration -- You may reply to this email to add a comment. You are receiving th

Re: [PATCH v7 1/4] mfd: rt4831: Adds support for Richtek RT4831

2021-05-19 Thread Lee Jones
On Mon, 17 May 2021, cy_huang wrote: > From: ChiYuan Huang > > This adds support Richtek RT4831 core. It includes four channel WLED driver > and Display Bias Voltage outputs. > > Signed-off-by: ChiYuan Huang > --- > - Send the patch series for the wrong mail subject. > > The RT4831 regulator

Re: [PATCH v7 2/4] backlight: rt4831: Adds DT binding document for Richtek RT4831 backlight

2021-05-19 Thread Lee Jones
On Mon, 17 May 2021, cy_huang wrote: > From: ChiYuan Huang > > Adds DT binding document for Richtek RT4831 backlight. > > Signed-off-by: ChiYuan Huang > Reviewed-by: Daniel Thompson > --- > since v7 > - Add allOf property refer to common.yaml. > - Remove default-brightness/max-brightness desc

Re: [PATCH v7 3/4] mfd: rt4831: Adds DT binding document for Richtek RT4831

2021-05-19 Thread Lee Jones
On Mon, 17 May 2021, cy_huang wrote: > From: ChiYuan Huang > > Adds DT binding document for Richtek RT4831. > > Signed-off-by: ChiYuan Huang > Reviewed-by: Rob Herring > --- > .../devicetree/bindings/mfd/richtek,rt4831.yaml| 90 > ++ > 1 file changed, 90 insertions(+

Re: [PATCH v7 4/4] backlight: rt4831: Adds support for Richtek RT4831 backlight

2021-05-19 Thread Lee Jones
On Mon, 17 May 2021, cy_huang wrote: > From: ChiYuan Huang > > Adds support for Richtek RT4831 backlight. > > Signed-off-by: ChiYuan Huang > Reviewed-by: Daniel Thompson > --- > since v7 > - Fix typo 'common' to 'commonly' in Kconfig description. > --- > drivers/video/backlight/Kconfig

Re: [Freedreno] [PATCH 0/4] drm/msm/dp: Add support for SC8180x eDP controller

2021-05-19 Thread Bjorn Andersson
On Tue 18 May 22:41 CDT 2021, abhin...@codeaurora.org wrote: > Hi Bjorn > > I had a quick glance on the series and before getting to other things wanted > to know how you are initializing two different connectors for > DP & EDP resp. > > The connector type for DP should be DRM_MODE_CONNECTOR_Dis

Re: [PATCH 1/2] drm/i915/cmdparser: No-op failed batches on all platforms

2021-05-19 Thread Jason Ekstrand
On Wed, May 19, 2021 at 2:43 AM Daniel Vetter wrote: > > On gen9 for blt cmd parser we relied on the magic fence error > propagation which: > - doesn't work on gen7, because there's no scheduler with ringbuffers > there yet > - fence error propagation can be weaponized to attack other things, so

Re: [PATCH] Revert "drm/i915: Propagate errors on awaiting already signaled fences"

2021-05-19 Thread Jason Ekstrand
Once we no longer rely on error propagation, I think there's a lot we can rip out. --Jason On Wed, May 19, 2021 at 5:15 AM Daniel Vetter wrote: > > From: Jason Ekstrand > > This reverts commit 9e31c1fe45d555a948ff66f1f0e3fe1f83ca63f7. Ever > since that commit, we've been having issues where a

Re: 回复: [RFC PATCH 1/2] drm/amdgpu: Fix memory corruption due to swapout and swapin

2021-05-19 Thread Felix Kuehling
Looks like we're creating the userptr BO as ttm_bo_type_device. I guess we should be using ttm_bo_type_sg? BTW, amdgpu_gem_userptr_ioctl also uses ttm_bo_type_device. Regards,   Felix Am 2021-05-19 um 6:01 a.m. schrieb Christian König: > I'm scratching my head how that is even possible. > > See

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-19 Thread Jason Ekstrand
On Wed, May 19, 2021 at 5:52 AM Michel Dänzer wrote: > > On 2021-05-19 12:06 a.m., Jason Ekstrand wrote: > > On Tue, May 18, 2021 at 4:17 PM Daniel Vetter wrote: > >> > >> On Tue, May 18, 2021 at 7:40 PM Christian König > >> wrote: > >>> > >>> Am 18.05.21 um 18:48 schrieb Daniel Vetter: > O

Re: [Intel-gfx] [RFC 2/2] drm/doc/rfc: i915 new parallel submission uAPI plan

2021-05-19 Thread Tvrtko Ursulin
On 19/05/2021 12:10, Daniel Vetter wrote: On Tue, May 18, 2021 at 04:58:30PM -0700, Matthew Brost wrote: Add entry fpr i915 new parallel submission uAPI plan. v2: (Daniel Vetter): - Expand logical order explaination - Add dummy header - Only allow N BBs in execbuf IOCTL - Config

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-19 Thread Jason Ekstrand
On Wed, May 19, 2021 at 6:43 AM Christian König wrote: > > Am 19.05.21 um 00:06 schrieb Jason Ekstrand: > > [SNIP] > >>> E.g. we can't add a fence which doesn't wait for the exclusive one as > >>> shared. > >> Ok I think that's a real problem, and guess it's also related to all > >> the ttm priva

Re: [PATCH v2] backlight: Kconfig whitespace and indentation cleanups

2021-05-19 Thread Daniel Thompson
On Wed, May 19, 2021 at 01:03:00PM +0200, Juerg Haefliger wrote: > Remove leading whitespaces, replace multi spaces with tabs, and fix help > text indentation. > > Signed-off-by: Juerg Haefliger Reviewed-by: Daniel Thompson Daniel. > --- > drivers/video/backlight/Kconfig | 22 +++---

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-19 Thread Michel Dänzer
On 2021-05-19 5:21 p.m., Jason Ekstrand wrote: > On Wed, May 19, 2021 at 5:52 AM Michel Dänzer wrote: >> >> On 2021-05-19 12:06 a.m., Jason Ekstrand wrote: >>> On Tue, May 18, 2021 at 4:17 PM Daniel Vetter wrote: On Tue, May 18, 2021 at 7:40 PM Christian König wrote: > > A

Re: [PATCH 1/3] gpu: drm: replace occurrences of invalid character

2021-05-19 Thread Randy Dunlap
On 5/19/21 1:15 AM, Mauro Carvalho Chehab wrote: > There are some places at drm that ended receiving a > REPLACEMENT CHARACTER U+fffd ('�'), probably because of > some bad charset conversion. > > Fix them by using what it seems to be the proper > character. > > Signed-off-by: Mauro Carvalho

Re: [PATCH 0/7] Per client engine busyness

2021-05-19 Thread Tvrtko Ursulin
On 18/05/2021 10:40, Tvrtko Ursulin wrote: On 18/05/2021 10:16, Daniel Stone wrote: Hi, On Tue, 18 May 2021 at 10:09, Tvrtko Ursulin wrote: I was just wondering if stat(2) and a chrdev major check would be a solid criteria to more efficiently (compared to parsing the text content) detect d

Re: [PATCH] drm/i915: Force DPCD backlight mode for Samsung 16727 panel

2021-05-19 Thread Lyude Paul
Seems reasonable to me: Reviewed-by: Lyude Paul On Wed, 2021-05-19 at 17:53 +0800, Aaron Ma wrote: > Another Samsung OLED panel needs DPCD to get control of backlight. > Kernel 5.12+ support the backlight via: > commit: <4a8d79901d5b> ("drm/i915/dp: Enable Intel's HDR backlight interface > (only

Re: [PATCH v4 1/3] drm/dp_mst: Add self-tests for up requests

2021-05-19 Thread Lyude Paul
On Wed, 2021-05-19 at 13:51 +1000, Sam McNally wrote: > On Wed, 19 May 2021 at 08:01, Lyude Paul wrote: > > > > Looks like these tests might still need to be fixed up a bit: > > > > [   34.785042]  (null): [drm:drm_dp_sideband_parse_req [drm_kms_helper]] > > connection status reply parse length

[PATCH v5 1/3] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-05-19 Thread Deepak Rawat
DRM driver for hyperv synthetic video device, based on hyperv_fb framebuffer driver. Also added config option "DRM_HYPERV" to enabled this driver. v2: - Add support for gen2 VM - Fixed review comments v3: - Split into multiple files as suggested by Thomas Zimmermann - Fixed hibernation issue as s

[PATCH v5 2/3] drm/hyperv: Handle feature change message from device

2021-05-19 Thread Deepak Rawat
Virtual device inform if screen update is needed or not with SYNTHVID_FEATURE_CHANGE message. Handle this message to set dirt_needed flag. Suggested-by: Dexuan Cui Signed-off-by: Deepak Rawat Acked-by: Thomas Zimmermann --- drivers/gpu/drm/hyperv/hyperv_drm.h | 1 + drivers/gpu/drm/hyper

[PATCH v5 3/3] MAINTAINERS: Add maintainer for hyperv video device

2021-05-19 Thread Deepak Rawat
Maintainer for hyperv synthetic video device. Signed-off-by: Deepak Rawat --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 41f2b2b85b6d..dbe4ed540e11 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6084,6 +6084,14 @@ T: git git://an

[PATCH] drm/i915: Force DPCD backlight mode for Samsung 16727 panel

2021-05-19 Thread Aaron Ma
Another Samsung OLED panel needs DPCD to get control of backlight. Kernel 5.12+ support the backlight via: commit: <4a8d79901d5b> ("drm/i915/dp: Enable Intel's HDR backlight interface (only SDR for now)") Only make backlight work on lower versions of kernel. Closes: https://gitlab.freedesktop.org

[PATCH] drivers/video/fbdev/core/fbmem.c: add pointer judgment

2021-05-19 Thread songqiang
Signed-off-by: songqiang --- drivers/video/fbdev/core/fbmem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index 072780b0e570..6036ab849475 100644 --- a/drivers/video/fbdev/core/fbmem.c +++ b/drivers/video/fbdev/core/fb

[PATCH -next] drm/rockchip: cdn-dp-core: add missing clk_disable_unprepare() on error in cdn_dp_grf_write()

2021-05-19 Thread Yang Yingliang
After calling clk_prepare_enable(), clk_disable_unprepare() need be called when calling regmap_write() failed. Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 1 + 1 fi

Re: [PATCH 1/3] gpu: drm: replace occurrences of invalid character

2021-05-19 Thread Alex Deucher
Pushed out to drm-misc-next. Also fixed up Michel's name. Alex On Wed, May 19, 2021 at 11:56 AM Randy Dunlap wrote: > > On 5/19/21 1:15 AM, Mauro Carvalho Chehab wrote: > > There are some places at drm that ended receiving a > > REPLACEMENT CHARACTER U+fffd ('�'), probably because of > > some b

Re: [PATCH] vgaarb: Use ACPI HID name to find integrated GPU

2021-05-19 Thread Alex Deucher
On Wed, May 19, 2021 at 9:57 AM Kai-Heng Feng wrote: > > Commit 3d42f1ddc47a ("vgaarb: Keep adding VGA device in queue") assumes > the first device is an integrated GPU. However, on AMD platforms an > integrated GPU can have higher PCI device number than a discrete GPU. > > Integrated GPU on ACPI

Re: [Mesa-dev] [RFC 2/2] drm/doc/rfc: i915 new parallel submission uAPI plan

2021-05-19 Thread Matthew Brost
On Wed, May 19, 2021 at 01:45:39PM +0200, Christian König wrote: > Oh, yeah we call that gang submit on the AMD side. > > Had already some internal discussions how to implement this, but so far > couldn't figure out how to cleanly introduce that into the DRM scheduler. > > Can you briefly describ

Re: [PATCH] Revert "drm/i915: Propagate errors on awaiting already signaled fences"

2021-05-19 Thread Daniel Vetter
On Wed, May 19, 2021 at 5:06 PM Jason Ekstrand wrote: > > Once we no longer rely on error propagation, I think there's a lot we > can rip out. I honestly did not find that much ... what did you uncover? -Daniel > > --Jason > > On Wed, May 19, 2021 at 5:15 AM Daniel Vetter wrote: > > > > From: J

Re: [Intel-gfx] [RFC 2/2] drm/doc/rfc: i915 new parallel submission uAPI plan

2021-05-19 Thread Matthew Brost
On Wed, May 19, 2021 at 01:10:04PM +0200, Daniel Vetter wrote: > On Tue, May 18, 2021 at 04:58:30PM -0700, Matthew Brost wrote: > > Add entry fpr i915 new parallel submission uAPI plan. > > > > v2: > > (Daniel Vetter): > > - Expand logical order explaination > > - Add dummy header > > - Onl

Re: [PATCH v8 5/8] mm: Device exclusive memory access

2021-05-19 Thread Jason Gunthorpe
> Sorry for the noise. Not at all, it is good that more people understand things! Jason

Re: [Intel-gfx] [PATCH 0/7] Per client engine busyness

2021-05-19 Thread Daniel Vetter
On Wed, May 19, 2021 at 6:16 PM Tvrtko Ursulin wrote: > > > On 18/05/2021 10:40, Tvrtko Ursulin wrote: > > > > On 18/05/2021 10:16, Daniel Stone wrote: > >> Hi, > >> > >> On Tue, 18 May 2021 at 10:09, Tvrtko Ursulin > >> wrote: > >>> I was just wondering if stat(2) and a chrdev major check would

[RFC 1/3] dma-fence: Add boost fence op

2021-05-19 Thread Rob Clark
From: Rob Clark Add a way to hint to the fence signaler that a fence waiter has missed a deadline waiting on the fence. In some cases, missing a vblank can result in lower gpu utilization, when really we want to go in the opposite direction and boost gpu freq. The boost callback gives some feedb

[RFC 2/3] drm/atomic: Call dma_fence_boost() when we've missed a vblank

2021-05-19 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/drm_atomic_helper.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 560aaecba31b..fe10fc2e7f86 100644 --- a/drivers/gpu/drm/drm_atomic_h

[RFC 0/3] dma-fence: Add a "boost" mechanism

2021-05-19 Thread Rob Clark
From: Rob Clark In some cases, like double-buffered rendering, missing vblanks can trick the GPU into running at a lower frequence, when really we want to be running at a higher frequency to not miss the vblanks in the first place. This is partially inspired by a trick i915 does, but implemented

[RFC 3/3] drm/msm: Wire up gpu boost

2021-05-19 Thread Rob Clark
From: Rob Clark Note, at this point I haven't given a lot of consideration into how much we should boost, and for how long. And perhaps we should only boost at less than 50% utilization? At this point, this is only an example of dma_fence_boost() implementation. Signed-off-by: Rob Clark ---

  1   2   >