Re: [PATCH v6 00/15] Restricted DMA

2021-05-18 Thread Claire Chang
v7: https://lore.kernel.org/patchwork/cover/1431031/ On Mon, May 10, 2021 at 5:50 PM Claire Chang wrote: > > From: Claire Chang > > This series implements mitigations for lack of DMA access control on > systems without an IOMMU, which could result in the DMA accessing the > system memory at unex

[PATCH v1 2/3] drm: panel-simple: Add support for the Innolux G070Y2-T02 panel

2021-05-18 Thread Oleksij Rempel
Add compatible and timings for the Innolux G070Y2-T02 panel. It is 7" WVGA (800x480) TFT LCD panel with TTL interface and a backlight unit. Co-Developed-by: Robin van der Gracht Signed-off-by: Robin van der Gracht Signed-off-by: Oleksij Rempel --- drivers/gpu/drm/panel/panel-simple.c | 16

[PATCH v1 0/3] add innolux, g070y2-t02 support for the Protonic VT7 board

2021-05-18 Thread Oleksij Rempel
Add Innolux G070Y2-T02 panel support for the Protonic VT7 board. Oleksij Rempel (3): dt-bindings: display: simple: add Innolux G070Y2-T02 panel drm: panel-simple: Add support for the Innolux G070Y2-T02 panel ARM: dts: imx6dl-prtvt7: Add display and panel nodes .../bindings/display/panel/pa

[PATCH v1 1/3] dt-bindings: display: simple: add Innolux G070Y2-T02 panel

2021-05-18 Thread Oleksij Rempel
Add binding for the Innolux G070Y2-T02 panel. It is 7" WVGA (800x480) TFT LCD panel with TTL interface and a backlight unit. Signed-off-by: Oleksij Rempel --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devic

[PATCH v1 3/3] ARM: dts: imx6dl-prtvt7: Add display and panel nodes

2021-05-18 Thread Oleksij Rempel
Add Innolux G070Y2-T02 panel to the Protonic VT7 board. Signed-off-by: Robin van der Gracht Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6dl-prtvt7.dts | 47 + 1 file changed, 47 insertions(+) diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts b/arch/arm/bo

Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix PM reference leak in cdns_mhdp_probe()

2021-05-18 Thread Johan Hovold
On Mon, May 17, 2021 at 11:27:38AM +0200, Robert Foss wrote: > Hey Yu, > > On Mon, 17 May 2021 at 10:08, Yu Kuai wrote: > > > > pm_runtime_get_sync will increment pm usage counter even it failed. > > Forgetting to putting operation will result in reference leak here. > > Fix it by replacing it wi

Re: [RFC PATCH 0/3] A drm_plane API to support HDR planes

2021-05-18 Thread Pekka Paalanen
On Mon, 17 May 2021 15:39:03 -0400 Vitaly Prosyak wrote: > On 2021-05-17 12:48 p.m., Sebastian Wick wrote: > > On 2021-05-17 10:57, Pekka Paalanen wrote: > >> On Fri, 14 May 2021 17:05:11 -0400 > >> Harry Wentland wrote: > >> > >>> On 2021-04-27 10:50 a.m., Pekka Paalanen wrote: > >>> > On

Re: [RFC PATCH v2 0/6] A drm_plane API to support HDR planes

2021-05-18 Thread Pekka Paalanen
On Fri, 14 May 2021 17:07:14 -0400 Harry Wentland wrote: > We are looking to enable HDR support for a couple of single-plane and > multi-plane scenarios. To do this effectively we recommend new interfaces > to drm_plane. The first patch gives a bit of background on HDR and why we > propose these

[PATCH v2 00/15] drm/i915: Move LMEM (VRAM) management over to TTM

2021-05-18 Thread Thomas Hellström
This is an initial patch series to move discrete memory management over to TTM. It will be followed up shortly with adding more functionality. The buddy allocator is temporarily removed along with its selftests and It is replaced with the TTM range manager and some selftests are adjusted to accoun

[PATCH v2 01/15] drm/i915: Untangle the vma pages_mutex

2021-05-18 Thread Thomas Hellström
From: Thomas Hellström Any sleeping dma_resv lock taken while the vma pages_mutex is held will cause a lockdep splat. Move the i915_gem_object_pin_pages() call out of the pages_mutex critical section. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/i915/i915_vma.c | 33 +++-

[PATCH v2 03/15] drm/i915: Fix i915_sg_page_sizes to record dma segments rather than physical pages

2021-05-18 Thread Thomas Hellström
All users of this function actually want the dma segment sizes, but that's not what's calculated. Fix that and rename the function to i915_sg_dma_sizes to reflect what's calculated. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 2 +- drivers/gpu/drm/i915/gem/

[PATCH v2 04/15] drm/ttm: Export functions to initialize and finalize the ttm range manager standalone

2021-05-18 Thread Thomas Hellström
i915 mock selftests are run without the device set up. In order to be able to run the region related mock selftests, export functions in order for the TTM range manager to be set up without a device to attach it to. Cc: Christian König Signed-off-by: Thomas Hellström --- drivers/gpu/drm/ttm/ttm

[PATCH v2 07/15] drm/ttm: Export ttm_bo_tt_destroy()

2021-05-18 Thread Thomas Hellström
For the upcoming kmapping i915 memcpy_move, export ttm_bo_tt_destroy(). A future change might be to move the new memcpy_move into ttm, replacing the old ioremapping one. Cc: Christian König Signed-off-by: Thomas Hellström --- drivers/gpu/drm/ttm/ttm_bo.c | 1 + 1 file changed, 1 insertion(+) d

[PATCH v2 08/15] drm/i915/ttm Add a generic TTM memcpy move for page-based iomem

2021-05-18 Thread Thomas Hellström
The internal ttm_bo_util memcpy uses vmap functionality, and while it probably might be possible to use it for copying in- and out of sglist represented io memory, using io_mem_reserve() / io_mem_free() callbacks, that would cause problems with fault(). Instead, implement a method mapping page-by-p

[PATCH v2 05/15] drm/i915/ttm Initialize the ttm device and memory managers

2021-05-18 Thread Thomas Hellström
Temporarily remove the buddy allocator and related selftests and hook up the TTM range manager for i915 regions. Also modify the mock region selftests somewhat to account for a fragmenting manager. Signed-off-by: Thomas Hellström --- v2: - Fix an error unwind in lmem_get_pages() (Reported by Mat

[PATCH v2 02/15] drm/i915: Don't free shared locks while shared

2021-05-18 Thread Thomas Hellström
We are currently sharing the VM reservation locks across a number of gem objects with page-table memory. Since TTM will individiualize the reservation locks when freeing objects, including accessing the shared locks, make sure that the shared locks are not freed until that is done. For PPGTT we add

[PATCH v2 06/15] drm/i915/ttm: Embed a ttm buffer object in the i915 gem object

2021-05-18 Thread Thomas Hellström
Embed a struct ttm_buffer_object into the i915 gem object, making sure we alias the gem object part. It's a bit unfortunate that the struct ttm_buffer_ojbect embeds a gem object since we otherwise could make the TTM part private to the TTM backend, and use the usual i915 gem object for the other ba

[PATCH v2 13/15] drm/ttm: Add BO and offset arguments for vm_access and vm_fault ttm handlers.

2021-05-18 Thread Thomas Hellström
From: Maarten Lankhorst This allows other drivers that may not setup the vma in the same way to use the ttm bo helpers. Also clarify the documentation a bit, especially related to VM_FAULT_RETRY. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 4 +- drivers/

[PATCH v2 09/15] drm/ttm, drm/amdgpu: Allow the driver some control over swapping

2021-05-18 Thread Thomas Hellström
We are calling the eviction_valuable driver callback at eviction time to determine whether we actually can evict a buffer object. The upcoming i915 TTM backend needs the same functionality for swapout, and that might actually be beneficial to other drivers as well. Add an eviction_valuable call al

[PATCH v2 14/15] drm/i915: Use ttm mmap handling for ttm bo's.

2021-05-18 Thread Thomas Hellström
From: Maarten Lankhorst Use the ttm handlers for servicing page faults, and vm_access. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 17 ++- drivers/gpu/drm/i915/gem/i915_gem_mman.h | 2 + .../gpu/drm/i915/gem/i915_gem_object_types.h | 1 + dri

[PATCH v2 12/15] drm/i915: Disable mmap ioctl for gen12+

2021-05-18 Thread Thomas Hellström
From: Maarten Lankhorst The paltform should exclusively use mmap_offset, one less path to worry about for discrete. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c

[PATCH v2 10/15] drm/i915/ttm: Introduce a TTM i915 gem object backend

2021-05-18 Thread Thomas Hellström
Most logical place to introduce TTM buffer objects is as an i915 gem object backend. We need to add some ops to account for added functionality like delayed delete and LRU list manipulation. Initially we support only LMEM and SYSTEM memory, but SYSTEM (which in this case means evicted LMEM objects

[PATCH v2 15/15] drm/i915/ttm: Add io sgt caching to i915_ttm_io_mem_pfn

2021-05-18 Thread Thomas Hellström
From: Maarten Lankhorst Instead of walking the sg table manually, use our caching helpers to do the sgt caching. To prevent lifetime issues of ttm_bo vs i915_gem_object, we will use a separate member, instead of re-using the dma page member. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm

[PATCH v2 11/15] drm/i915/lmem: Verify checks for lmem residency

2021-05-18 Thread Thomas Hellström
Since objects can be migrated or evicted when not pinned or locked, update the checks for lmem residency or future residency so that the value returned is not immediately stale. Signed-off-by: Thomas Hellström --- v2: Simplify i915_gem_object_migratable() (Reported by Mattew Auld) --- drivers/gp

Re: [Intel-gfx] [PATCH v2 12/15] drm/i915: Disable mmap ioctl for gen12+

2021-05-18 Thread Thomas Hellström
On 5/18/21 10:26 AM, Thomas Hellström wrote: From: Maarten Lankhorst The paltform should exclusively use mmap_offset, one less path to worry about for discrete. s/paltform/platform/ Signed-off-by: Maarten Lankhorst Otherwise, Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v2 03/15] drm/i915: Fix i915_sg_page_sizes to record dma segments rather than physical pages

2021-05-18 Thread Matthew Auld
On Tue, 18 May 2021 at 09:27, Thomas Hellström wrote: > > All users of this function actually want the dma segment sizes, but that's > not what's calculated. Fix that and rename the function to > i915_sg_dma_sizes to reflect what's calculated. > > Signed-off-by: Thomas Hellström Reviewed-by: Matt

Re: [Intel-gfx] [PATCH v2 13/15] drm/ttm: Add BO and offset arguments for vm_access and vm_fault ttm handlers.

2021-05-18 Thread Thomas Hellström
+ Christian König On 5/18/21 10:26 AM, Thomas Hellström wrote: From: Maarten Lankhorst This allows other drivers that may not setup the vma in the same way to use the ttm bo helpers. Also clarify the documentation a bit, especially related to VM_FAULT_RETRY. Signed-off-by: Maarten Lankhorst

Re: [PATCH v2 04/15] drm/ttm: Export functions to initialize and finalize the ttm range manager standalone

2021-05-18 Thread Daniel Vetter
On Tue, May 18, 2021 at 10:26:50AM +0200, Thomas Hellström wrote: > i915 mock selftests are run without the device set up. In order to be able > to run the region related mock selftests, export functions in order for the > TTM range manager to be set up without a device to attach it to. > > Cc: Ch

Re: [Intel-gfx] [PATCH v2 05/15] drm/i915/ttm Initialize the ttm device and memory managers

2021-05-18 Thread Matthew Auld
On Tue, 18 May 2021 at 09:27, Thomas Hellström wrote: > > Temporarily remove the buddy allocator and related selftests > and hook up the TTM range manager for i915 regions. > > Also modify the mock region selftests somewhat to account for a > fragmenting manager. > > Signed-off-by: Thomas Hellströ

[PATCH 2/5] video: fbdev: ssd1307fb: Simplify ssd1307fb_update_display()

2021-05-18 Thread Geert Uytterhoeven
Simplify the nested loops to handle conversion from linear frame buffer to ssd1307 page layout: 1. Move last page handling one level up, as the value of "m" is the same inside a page, 2. array->data[] is filled linearly, so there is no need to recalculate array_idx over and over again

[PATCH 3/5] video: fbdev: ssd1307fb: Extract ssd1307fb_set_address_range()

2021-05-18 Thread Geert Uytterhoeven
Extract the code to set the column and page ranges into a helper function. Signed-off-by: Geert Uytterhoeven --- drivers/video/fbdev/ssd1307fb.c | 61 +++-- 1 file changed, 36 insertions(+), 25 deletions(-) diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video

[PATCH] dt-bindings: display: ssd1307fb: Convert to json-schema

2021-05-18 Thread Geert Uytterhoeven
Convert the Solomon SSD1307 Framebuffer Device Tree binding documentation to json-schema. Fix the spelling of the "pwms" property. Document default values. Make properties with default values not required. Signed-off-by: Geert Uytterhoeven --- I have listed Maxime as the maintainer, as he wrote

[PATCH 1/5] video: fbdev: ssd1307fb: Propagate errors via ssd1307fb_update_display()

2021-05-18 Thread Geert Uytterhoeven
Make ssd1307fb_update_display() return an error code, so callers that can handle failures can propagate it. Signed-off-by: Geert Uytterhoeven --- drivers/video/fbdev/ssd1307fb.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/ssd1307fb.

[PATCH 0/5] video: fbdev: ssd1307fb: Optimizations and improvements

2021-05-18 Thread Geert Uytterhoeven
Hi all, This patch series optimizes console operations on ssd1307fb, after the customary fixes and cleanups. Currently, each screen update triggers an I2C transfer of all screen data, up to 1 KiB of data for a 128x64 display, which takes at least 20 ms in Fast mode. While many displays a

[PATCH 4/5] video: fbdev: ssd1307fb: Optimize screen updates

2021-05-18 Thread Geert Uytterhoeven
Currently, each screen update triggers an I2C transfer of all screen data, up to 1 KiB of data for a 128x64 display, which takes at least 20 ms in Fast mode. Reduce the amount of transferred data by only updating the rectangle that changed. Remove the call to ssd1307fb_set_address_range() during

[PATCH 5/5] video: fbdev: ssd1307fb: Cache address ranges

2021-05-18 Thread Geert Uytterhoeven
Cache the column and page ranges, to avoid doing unneeded I2C transfers when the values haven't changed. Signed-off-by: Geert Uytterhoeven --- drivers/video/fbdev/ssd1307fb.c | 52 +++-- 1 file changed, 36 insertions(+), 16 deletions(-) diff --git a/drivers/video/fbd

Re: [PATCH 0/7] Per client engine busyness

2021-05-18 Thread Tvrtko Ursulin
On 17/05/2021 20:03, Simon Ser wrote: On Monday, May 17th, 2021 at 8:16 PM, Nieto, David M wrote: Btw is DRM_MAJOR 226 consider uapi? I don't see it in uapi headers. It's not in the headers, but it's de facto uAPI, as seen in libdrm: > git grep 226 xf86drm.c 99:#define DRM

Re: [Intel-gfx] [PATCH v2 05/15] drm/i915/ttm Initialize the ttm device and memory managers

2021-05-18 Thread Matthew Auld
On Tue, 18 May 2021 at 09:27, Thomas Hellström wrote: > > Temporarily remove the buddy allocator and related selftests > and hook up the TTM range manager for i915 regions. > > Also modify the mock region selftests somewhat to account for a > fragmenting manager. > > Signed-off-by: Thomas Hellströ

Re: [Intel-gfx] [PATCH v2 05/15] drm/i915/ttm Initialize the ttm device and memory managers

2021-05-18 Thread Thomas Hellström
On 5/18/21 11:09 AM, Matthew Auld wrote: On Tue, 18 May 2021 at 09:27, Thomas Hellström wrote: Temporarily remove the buddy allocator and related selftests and hook up the TTM range manager for i915 regions. Also modify the mock region selftests somewhat to account for a fragmenting manager.

Re: [PATCH 0/7] Per client engine busyness

2021-05-18 Thread Daniel Stone
Hi, On Tue, 18 May 2021 at 10:09, Tvrtko Ursulin wrote: > I was just wondering if stat(2) and a chrdev major check would be a > solid criteria to more efficiently (compared to parsing the text > content) detect drm files while walking procfs. Maybe I'm missing something, but is the per-PID walk

Re: [Intel-gfx] [PATCH v2 14/15] drm/i915: Use ttm mmap handling for ttm bo's.

2021-05-18 Thread Thomas Hellström
On 5/18/21 10:27 AM, Thomas Hellström wrote: From: Maarten Lankhorst Use the ttm handlers for servicing page faults, and vm_access. Signed-off-by: Maarten Lankhorst LGTM. Just need to make sure we don't forget about the caching. Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i9

[PATCH] drm/bridge: ti-sn65dsi86: fix a ternary type promotion bug

2021-05-18 Thread Dan Carpenter
The ti_sn_aux_transfer() function returns ssize_t (signed long). It's supposed to return negative error codes or the number of bytes transferred. The "ret" variable is int and the "len" variable is unsigned int. The problem is that with a ternary like this, the negative int is first type promote

Re: [Intel-gfx] [PATCH v2 15/15] drm/i915/ttm: Add io sgt caching to i915_ttm_io_mem_pfn

2021-05-18 Thread Thomas Hellström
On 5/18/21 10:27 AM, Thomas Hellström wrote: From: Maarten Lankhorst Instead of walking the sg table manually, use our caching helpers to do the sgt caching. To prevent lifetime issues of ttm_bo vs i915_gem_object, we will use a separate member, instead of re-using the dma page member. Signe

Re: [PATCH 0/7] Per client engine busyness

2021-05-18 Thread Tvrtko Ursulin
On 17/05/2021 19:02, Nieto, David M wrote: [AMD Official Use Only] The format is simple: : % Hm what time period does the percent relate to? The i915 implementation uses accumulated nanoseconds active. That way who reads the file can calculate the percentage relative to the time period

Re: [PATCH 0/7] Per client engine busyness

2021-05-18 Thread Tvrtko Ursulin
On 18/05/2021 10:16, Daniel Stone wrote: Hi, On Tue, 18 May 2021 at 10:09, Tvrtko Ursulin wrote: I was just wondering if stat(2) and a chrdev major check would be a solid criteria to more efficiently (compared to parsing the text content) detect drm files while walking procfs. Maybe I'm mi

[V2][PATCH 0/2] drm: xlnx: add some functions

2021-05-18 Thread quanyang . wang
From: Quanyang Wang Hi all, The patch "drm: xlnx: add is_layer_vid() to simplify the code" is to simplify the code which judge the layer type. The patch "drm: xlnx: consolidate the functions which programming AUDIO_VIDEO_SELECT register" is to consolidate the code that can configure vid/gfx/au

[V2][PATCH 1/2] drm: xlnx: add is_layer_vid() to simplify the code

2021-05-18 Thread quanyang . wang
From: Quanyang Wang Add a new function is_layer_vid() to simplify the code that judges if a layer is the video layer. Acked-by: Paul Cercueil Signed-off-by: Quanyang Wang --- drivers/gpu/drm/xlnx/zynqmp_disp.c | 39 +- 1 file changed, 22 insertions(+), 17 deletions

[V2][PATCH 2/2] drm: xlnx: consolidate the functions which programming AUDIO_VIDEO_SELECT register

2021-05-18 Thread quanyang . wang
From: Quanyang Wang For now, the functions zynqmp_disp_avbuf_enable/disable_audio and zynqmp_disp_avbuf_enable/disable_video are all programming the register AV_BUF_OUTPUT_AUDIO_VIDEO_SELECT to select the output for audio or video. And in the future, many drm properties (like video_tpg, audio_tpg

Re: [PATCH 1/3] drm/virtio: Fixes a potential NULL pointer dereference on probe failure

2021-05-18 Thread Gerd Hoffmann
On Mon, May 17, 2021 at 04:49:11PM +0800, Xie Yongji wrote: > The dev->dev_private might not be allocated if virtio_gpu_pci_quirk() > or virtio_gpu_init() failed. In this case, we should avoid the cleanup > in virtio_gpu_release(). Pushed all three to drm-misc-next. thanks, Gerd

[PATCH v16 2/4] dt-bindings: msm: dsi: add yaml schemas for DSI bindings

2021-05-18 Thread Krishna Manikandan
Add YAML schema for the device tree bindings for DSI Signed-off-by: Krishna Manikandan Changes in v1: - Separate dsi controller bindings to a separate patch (Stephen Boyd) - Merge dsi-common-controller.yaml and dsi-controller-main.yaml to a single file (Stephen Boyd) - Drop sup

[PATCH v16 4/4] dt-bindings: msm/dp: Add bindings of MSM DisplayPort controller

2021-05-18 Thread Krishna Manikandan
Add bindings for Snapdragon DisplayPort controller driver. Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy Signed-off-by: Tanmay Shah Signed-off-by: Kuogee Hsieh Signed-off-by: Krishna Manikandan Changes in V2: -Provide details about sel-gpio Changes in V4: -Provide details about

[PATCH v16 3/4] dt-bindings: msm: dsi: add yaml schemas for DSI PHY bindings

2021-05-18 Thread Krishna Manikandan
Add YAML schema for the device tree bindings for DSI PHY. Signed-off-by: Krishna Manikandan Changes in v1: - Merge dsi-phy.yaml and dsi-phy-10nm.yaml (Stephen Boyd) - Remove qcom,dsi-phy-regulator-ldo-mode (Stephen Boyd) - Add clock cells properly (Stephen Boyd) - Remove unnecessary

[PATCH v16 1/4] dt-bindings: msm: disp: add yaml schemas for DPU bindings

2021-05-18 Thread Krishna Manikandan
MSM Mobile Display Subsystem (MDSS) encapsulates sub-blocks like DPU display controller, DSI etc. Add YAML schema for DPU device tree bindings. Signed-off-by: Krishna Manikandan Changes in v2: - Changed dpu to DPU (Sam Ravnborg) - Fixed indentation issues (Sam Ravnborg) - Added empty

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-18 Thread Daniel Vetter
On Tue, May 18, 2021 at 7:59 AM Daniel Vetter wrote: > > On Tue, May 18, 2021 at 12:49 AM Jason Ekstrand wrote: > > > > On Mon, May 17, 2021 at 3:15 PM Daniel Vetter wrote: > > > > > > On Mon, May 17, 2021 at 9:38 PM Christian König > > > wrote: > > > > > > > > Am 17.05.21 um 17:04 schrieb Dani

Re: [PATCH 19/27] drm/i915/gem: Use the proto-context to handle create parameters

2021-05-18 Thread Jani Nikula
On Mon, 17 May 2021, Daniel Vetter wrote: > On Mon, May 17, 2021 at 7:05 PM Jason Ekstrand wrote: >> >> On Mon, May 17, 2021 at 8:40 AM Daniel Vetter wrote: >> > >> > On Fri, May 14, 2021 at 02:13:57PM -0500, Jason Ekstrand wrote: >> > > I can add those. I just don't know where to put it. We d

Re: [PATCH] drm/i915: only disable default vga device

2021-05-18 Thread Emil Velikov
Hi Ville, On Mon, 17 May 2021 at 18:24, Ville Syrjälä wrote: > > On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > > From: Vivek Das Mohapatra > > > > This patch is to do with seamless handover, eg when the sequence is > > bootloader → plymouth → desktop. > > > > It switches the vg

Re: [PATCH v2 01/15] drm/i915: Untangle the vma pages_mutex

2021-05-18 Thread Maarten Lankhorst
Hey, This needs a small fix, otherwise looks good. Op 18-05-2021 om 10:26 schreef Thomas Hellström: > From: Thomas Hellström > > Any sleeping dma_resv lock taken while the vma pages_mutex is held > will cause a lockdep splat. > Move the i915_gem_object_pin_pages() call out of the pages_mutex >

[PATCH 2/3] drm: clarify and linkify DRM_CLIENT_CAP_WRITEBACK_CONNECTORS docs

2021-05-18 Thread Simon Ser
Make it clear that the client is responsible for enabling ATOMIC prior to enabling WRITEBACK_CONNECTORS. Linkify the reference to ATOMIC. Signed-off-by: Simon Ser Cc: Daniel Vetter Cc: Daniel Stone Cc: Pekka Paalanen --- include/uapi/drm/drm.h | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

[PATCH 3/3] drm: document minimum kernel version for DRM_CLIENT_CAP_*

2021-05-18 Thread Simon Ser
The kernel versions including the following commits are referenced: DRM_CLIENT_CAP_STEREO_3D 61d8e3282541 ("drm: Add a STEREO_3D capability to the SET_CLIENT_CAP ioctl") DRM_CLIENT_CAP_UNIVERSAL_PLANES 681e7ec73044 ("drm: Allow userspace to ask for universal plane list (v2)") c7dbc6c9ae5c ("drm:

[PATCH 1/3] drm: reference mode flags in DRM_CLIENT_CAP_* docs

2021-05-18 Thread Simon Ser
In the docs for DRM_CLIENT_CAP_STEREO_3D and DRM_CLIENT_CAP_ASPECT_RATIO, reference the DRM_MODE_FLAG_* defines that get set when the cap is enabled. Signed-off-by: Simon Ser Cc: Daniel Vetter Cc: Daniel Stone Cc: Pekka Paalanen --- include/uapi/drm/drm.h | 5 +++-- 1 file changed, 3 insertio

Re: [PATCH] drm/i915: only disable default vga device

2021-05-18 Thread Ville Syrjälä
On Tue, May 18, 2021 at 12:09:56PM +0100, Emil Velikov wrote: > Hi Ville, > > On Mon, 17 May 2021 at 18:24, Ville Syrjälä > wrote: > > > > On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > > > From: Vivek Das Mohapatra > > > > > > This patch is to do with seamless handover, eg when

Re: [PATCH v2 02/15] drm/i915: Don't free shared locks while shared

2021-05-18 Thread Maarten Lankhorst
Op 18-05-2021 om 10:26 schreef Thomas Hellström: > We are currently sharing the VM reservation locks across a number of > gem objects with page-table memory. Since TTM will individiualize the > reservation locks when freeing objects, including accessing the shared > locks, make sure that the shared

Re: [PATCH v2 01/15] drm/i915: Untangle the vma pages_mutex

2021-05-18 Thread Thomas Hellström
On 5/18/21 1:12 PM, Maarten Lankhorst wrote: Hey, This needs a small fix, otherwise looks good. Op 18-05-2021 om 10:26 schreef Thomas Hellström: From: Thomas Hellström Any sleeping dma_resv lock taken while the vma pages_mutex is held will cause a lockdep splat. Move the i915_gem_object_pi

Re: [Intel-gfx] [PATCH v2 02/15] drm/i915: Don't free shared locks while shared

2021-05-18 Thread Intel
On 5/18/21 1:18 PM, Maarten Lankhorst wrote: Op 18-05-2021 om 10:26 schreef Thomas Hellström: We are currently sharing the VM reservation locks across a number of gem objects with page-table memory. Since TTM will individiualize the reservation locks when freeing objects, including accessing t

Re: [PATCH v2 06/15] drm/i915/ttm: Embed a ttm buffer object in the i915 gem object

2021-05-18 Thread Maarten Lankhorst
Op 18-05-2021 om 10:26 schreef Thomas Hellström: > Embed a struct ttm_buffer_object into the i915 gem object, making sure > we alias the gem object part. It's a bit unfortunate that the > struct ttm_buffer_ojbect embeds a gem object since we otherwise could > make the TTM part private to the TTM ba

Re: [PATCH v2 07/15] drm/ttm: Export ttm_bo_tt_destroy()

2021-05-18 Thread Maarten Lankhorst
Op 18-05-2021 om 10:26 schreef Thomas Hellström: > For the upcoming kmapping i915 memcpy_move, export ttm_bo_tt_destroy(). > A future change might be to move the new memcpy_move into ttm, replacing > the old ioremapping one. > > Cc: Christian König > Signed-off-by: Thomas Hellström > --- > drive

Re: [PATCH v2 04/15] drm/ttm: Export functions to initialize and finalize the ttm range manager standalone

2021-05-18 Thread Christian König
Am 18.05.21 um 10:26 schrieb Thomas Hellström: i915 mock selftests are run without the device set up. In order to be able to run the region related mock selftests, export functions in order for the TTM range manager to be set up without a device to attach it to. From the code it looks good, but

Re: [PATCH v2 08/15] drm/i915/ttm Add a generic TTM memcpy move for page-based iomem

2021-05-18 Thread Christian König
Am 18.05.21 um 10:26 schrieb Thomas Hellström: The internal ttm_bo_util memcpy uses vmap functionality, and while it probably might be possible to use it for copying in- and out of sglist represented io memory, using io_mem_reserve() / io_mem_free() callbacks, that would cause problems with fa

Re: [PATCH v8 1/8] mm: Remove special swap entry functions

2021-05-18 Thread Alistair Popple
On Tuesday, 18 May 2021 12:17:32 PM AEST Peter Xu wrote: > On Wed, Apr 07, 2021 at 06:42:31PM +1000, Alistair Popple wrote: > > +static inline struct page *pfn_swap_entry_to_page(swp_entry_t entry) > > +{ > > + struct page *p = pfn_to_page(swp_offset(entry)); > > + > > + /* > > + * Any

Re: [Intel-gfx] [PATCH v2 13/15] drm/ttm: Add BO and offset arguments for vm_access and vm_fault ttm handlers.

2021-05-18 Thread Christian König
Can you send me the patch directly and not just on CC? Thanks, Christian. Am 18.05.21 um 10:59 schrieb Thomas Hellström: + Christian König On 5/18/21 10:26 AM, Thomas Hellström wrote: From: Maarten Lankhorst This allows other drivers that may not setup the vma in the same way to use the ttm

Re: [PATCH v2 07/15] drm/ttm: Export ttm_bo_tt_destroy()

2021-05-18 Thread Christian König
Am 18.05.21 um 10:26 schrieb Thomas Hellström: For the upcoming kmapping i915 memcpy_move, export ttm_bo_tt_destroy(). A future change might be to move the new memcpy_move into ttm, replacing the old ioremapping one. Well this is an upfront NAK for that approach. I've worked quite hard to not

Re: [PATCH v2 08/15] drm/i915/ttm Add a generic TTM memcpy move for page-based iomem

2021-05-18 Thread Thomas Hellström
On 5/18/21 1:55 PM, Christian König wrote: Am 18.05.21 um 10:26 schrieb Thomas Hellström: The internal ttm_bo_util memcpy uses vmap functionality, and while it probably might be possible to use it for copying in- and out of sglist represented io memory, using io_mem_reserve() / io_mem_free()

Re: [PATCH 0/7] Per client engine busyness

2021-05-18 Thread Christian König
Am 18.05.21 um 11:35 schrieb Tvrtko Ursulin: On 17/05/2021 19:02, Nieto, David M wrote: [AMD Official Use Only] The format is simple: : % Hm what time period does the percent relate to? The i915 implementation uses accumulated nanoseconds active. That way who reads the file can calculat

[Bug 213129] New: Tiny font

2021-05-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213129 Bug ID: 213129 Summary: Tiny font Product: Drivers Version: 2.5 Kernel Version: Tiny font during kernel boot with multihead Hardware: All OS: Linux Tree: Main

Re: [PATCH v2 08/15] drm/i915/ttm Add a generic TTM memcpy move for page-based iomem

2021-05-18 Thread Christian König
Am 18.05.21 um 14:04 schrieb Thomas Hellström: On 5/18/21 1:55 PM, Christian König wrote: Am 18.05.21 um 10:26 schrieb Thomas Hellström: The internal ttm_bo_util memcpy uses vmap functionality, and while it probably might be possible to use it for copying in- and out of sglist represented io

[PATCH -next] drm: Fix missing unlock and free on error in drm_legacy_addbufs_pci()

2021-05-18 Thread Zou Wei
Add the missing unlock and free before return from function drm_legacy_addbufs_pci() in the error handling case. Fixes: 70556e24e18e ("drm: remove usage of drm_pci_alloc/free") Reported-by: Hulk Robot Signed-off-by: Zou Wei --- drivers/gpu/drm/drm_bufs.c | 10 +- 1 file changed, 9 inser

Re: [Intel-gfx] [PATCH v2 09/15] drm/ttm, drm/amdgpu: Allow the driver some control over swapping

2021-05-18 Thread Maarten Lankhorst
Op 18-05-2021 om 10:26 schreef Thomas Hellström: > We are calling the eviction_valuable driver callback at eviction time to > determine whether we actually can evict a buffer object. > The upcoming i915 TTM backend needs the same functionality for swapout, > and that might actually be beneficial to

[PATCH v4 1/3] drm/dp_mst: Add self-tests for up requests

2021-05-18 Thread Sam McNally
Up requests are decoded by drm_dp_sideband_parse_req(), which operates on a drm_dp_sideband_msg_rx, unlike down requests. Expand the existing self-test helper sideband_msg_req_encode_decode() to copy the message contents and length from a drm_dp_sideband_msg_tx to drm_dp_sideband_msg_rx and use the

[PATCH v4 2/3] drm/dp_mst: Add support for sink event notify messages

2021-05-18 Thread Sam McNally
Sink event notify messages are used for MST CEC IRQs. Add parsing support for sink event notify messages in preparation for handling MST CEC IRQs. Signed-off-by: Sam McNally --- Changes in v4: - Changed logging to use drm_dbg_kms() - Added self-test drivers/gpu/drm/drm_dp_mst_topology.c

[PATCH v4 3/3] drm_dp_cec: add MST support

2021-05-18 Thread Sam McNally
With DP v2.0 errata E5, CEC tunneling can be supported through an MST topology. When tunneling CEC through an MST port, CEC IRQs are delivered via a sink event notify message; when a sink event notify message is received, trigger CEC IRQ handling - ESI1 is not used for remote CEC IRQs so its value

Re: [PATCH] drm/i915: only disable default vga device

2021-05-18 Thread Emil Velikov
On Tue, 18 May 2021 at 12:17, Ville Syrjälä wrote: > > On Tue, May 18, 2021 at 12:09:56PM +0100, Emil Velikov wrote: > > Hi Ville, > > > > On Mon, 17 May 2021 at 18:24, Ville Syrjälä > > wrote: > > > > > > On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > > > > From: Vivek Das Mohap

Re: [PATCH v7 02/10] dt-bindings: display: simple: List hpd properties in panel-simple

2021-05-18 Thread Rob Herring
On Mon, May 17, 2021 at 3:09 PM Douglas Anderson wrote: > > These are described in panel-common.yaml but if I don't list them in > panel-simple then I get yells when running 'dt_binding_check' in a > future patch. List them along with other properties that seem to be > listed in panel-simple for s

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-18 Thread Christian König
Hi Jason & Daniel, Am 18.05.21 um 07:59 schrieb Daniel Vetter: On Tue, May 18, 2021 at 12:49 AM Jason Ekstrand wrote: On Mon, May 17, 2021 at 3:15 PM Daniel Vetter wrote: On Mon, May 17, 2021 at 9:38 PM Christian König wrote: Am 17.05.21 um 17:04 schrieb Daniel Vetter: On Mon, May 17, 202

Re: [PATCH v2 08/15] drm/i915/ttm Add a generic TTM memcpy move for page-based iomem

2021-05-18 Thread Thomas Hellström
On 5/18/21 2:09 PM, Christian König wrote: Am 18.05.21 um 14:04 schrieb Thomas Hellström: On 5/18/21 1:55 PM, Christian König wrote: Am 18.05.21 um 10:26 schrieb Thomas Hellström: The internal ttm_bo_util memcpy uses vmap functionality, and while it probably might be possible to use it fo

Re: [PATCH v5 1/2] drm/bridge: anx7625: refactor power control to use runtime PM framework

2021-05-18 Thread Robert Foss
Series applied to drm-misc-next https://cgit.freedesktop.org/drm/drm-misc/commit/?id=60487584a79abd763570b54d59e6aad586d64c7b

Re: [PATCH 09/11] dma-buf: add shared fence usage flags

2021-05-18 Thread Christian König
Am 17.05.21 um 22:36 schrieb Daniel Vetter: On Mon, May 17, 2021 at 04:11:27PM +0200, Christian König wrote: Add usage flags for shared fences and improve the documentation. This allows driver to better specify what shared fences are doing with the resource. Signed-off-by: Christian König dif

Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix PM reference leak in cdns_mhdp_probe()

2021-05-18 Thread Robert Foss
On Tue, 18 May 2021 at 09:42, Johan Hovold wrote: > > On Mon, May 17, 2021 at 11:27:38AM +0200, Robert Foss wrote: > > Hey Yu, > > > > On Mon, 17 May 2021 at 10:08, Yu Kuai wrote: > > > > > > pm_runtime_get_sync will increment pm usage counter even it failed. > > > Forgetting to putting operation

Re: [PATCH] dt-bindings: display: bridge: lvds-codec: Fix spacing

2021-05-18 Thread Rob Herring
On Sun, May 16, 2021 at 12:48:05AM +0300, Laurent Pinchart wrote: > Hi Marek, > > Thank you for the patch. > > On Sat, May 15, 2021 at 10:39:32PM +0200, Marek Vasut wrote: > > Add missing spaces to make the diagrams readable, no functional change. > > Looks better indeed. The patch view looks ba

Re: [PATCH v2 04/15] drm/ttm: Export functions to initialize and finalize the ttm range manager standalone

2021-05-18 Thread Thomas Hellström
On 5/18/21 1:51 PM, Christian König wrote: Am 18.05.21 um 10:26 schrieb Thomas Hellström: i915 mock selftests are run without the device set up. In order to be able to run the region related mock selftests, export functions in order for the TTM range manager to be set up without a device to

Re: [PATCH v2 08/15] drm/i915/ttm Add a generic TTM memcpy move for page-based iomem

2021-05-18 Thread Christian König
Am 18.05.21 um 14:52 schrieb Thomas Hellström: On 5/18/21 2:09 PM, Christian König wrote: Am 18.05.21 um 14:04 schrieb Thomas Hellström: On 5/18/21 1:55 PM, Christian König wrote: Am 18.05.21 um 10:26 schrieb Thomas Hellström: The internal ttm_bo_util memcpy uses vmap functionality, and w

Re: [PATCH v2 04/15] drm/ttm: Export functions to initialize and finalize the ttm range manager standalone

2021-05-18 Thread Christian König
Am 18.05.21 um 15:06 schrieb Thomas Hellström: On 5/18/21 1:51 PM, Christian König wrote: Am 18.05.21 um 10:26 schrieb Thomas Hellström: i915 mock selftests are run without the device set up. In order to be able to run the region related mock selftests, export functions in order for the T

Re: [PATCH v8 5/8] mm: Device exclusive memory access

2021-05-18 Thread Alistair Popple
On Tuesday, 18 May 2021 12:08:34 PM AEST Peter Xu wrote: > > v6: > > * Fixed a bisectablity issue due to incorrectly applying the rename of > > > > migrate_pgmap_owner to the wrong patches for Nouveau and hmm_test. > > > > v5: > > * Renamed range->migrate_pgmap_owner to range->owner. > > May b

Re: [PATCH] drm/bridge: ti-sn65dsi86: fix a ternary type promotion bug

2021-05-18 Thread Robert Foss
Hey Dan, Thanks for submitting this. On Tue, 18 May 2021 at 11:20, Dan Carpenter wrote: > > The ti_sn_aux_transfer() function returns ssize_t (signed long). It's > supposed to return negative error codes or the number of bytes > transferred. The "ret" variable is int and the "len" variable is

Re: [PATCH V4 1/2] dt-bindings: display: bridge: lvds-codec: Document pixel data sampling edge select

2021-05-18 Thread Rob Herring
On Sat, May 15, 2021 at 10:43:15PM +0200, Marek Vasut wrote: > The OnSemi FIN3385 Parallel-to-LVDS encoder has a dedicated input line to > select input pixel data sampling edge. Add DT property "pclk-sample", not > the same as the one used by display timings but rather the same as used by > media,

Re: [PATCH AUTOSEL 5.12 5/5] tty: vt: always invoke vc->vc_sw->con_resize callback

2021-05-18 Thread Sasha Levin
On Tue, May 18, 2021 at 07:45:59AM +0200, Greg KH wrote: On Mon, May 17, 2021 at 06:35:24PM -0700, Linus Torvalds wrote: On Mon, May 17, 2021 at 6:09 PM Sasha Levin wrote: > > From: Tetsuo Handa > > [ Upstream commit ffb324e6f874121f7dce5bdae5e05d02baae7269 ] So I think the commit is fine, an

Re: [PATCH v2 08/15] drm/i915/ttm Add a generic TTM memcpy move for page-based iomem

2021-05-18 Thread Thomas Hellström
On 5/18/21 3:08 PM, Christian König wrote: Am 18.05.21 um 14:52 schrieb Thomas Hellström: On 5/18/21 2:09 PM, Christian König wrote: Am 18.05.21 um 14:04 schrieb Thomas Hellström: On 5/18/21 1:55 PM, Christian König wrote: Am 18.05.21 um 10:26 schrieb Thomas Hellström: The internal ttm_

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-18 Thread Daniel Stone
On Tue, 18 May 2021 at 13:49, Christian König wrote: > Am 18.05.21 um 07:59 schrieb Daniel Vetter: > > First step in fixing that is (and frankly was since years) to fix the > > amdgpu CS so winsys can pass along a bunch of flags about which CS > > should actually set the exclusive fence, so that y

Re: [PATCH v2 08/15] drm/i915/ttm Add a generic TTM memcpy move for page-based iomem

2021-05-18 Thread Christian König
Am 18.05.21 um 15:24 schrieb Thomas Hellström: On 5/18/21 3:08 PM, Christian König wrote: Am 18.05.21 um 14:52 schrieb Thomas Hellström: On 5/18/21 2:09 PM, Christian König wrote: Am 18.05.21 um 14:04 schrieb Thomas Hellström: On 5/18/21 1:55 PM, Christian König wrote: Am 18.05.21 um 10

Re: [PATCH] drm/bridge: ti-sn65dsi86: fix a ternary type promotion bug

2021-05-18 Thread Robert Foss
Since it fixes drm-misc-next, applied it there instead. On Tue, 18 May 2021 at 15:20, Robert Foss wrote: > > Hey Dan, > > Thanks for submitting this. > > On Tue, 18 May 2021 at 11:20, Dan Carpenter wrote: > > > > The ti_sn_aux_transfer() function returns ssize_t (signed long). It's > > supposed

Re: [Intel-gfx] [PATCH 4/4] i915: fix remap_io_sg to verify the pgprot

2021-05-18 Thread Thomas Hellström
On 5/18/21 3:24 PM, Christoph Hellwig wrote: On Tue, May 18, 2021 at 08:46:44AM +0200, Thomas Hellström wrote: And worse, if we prefault a user-space buffer object map using remap_io_sg() and then zap some ptes using madvise(), the next time those ptes are accessed, we'd trigger a new call to

  1   2   3   >