Re: [Intel-gfx] [PATCH 3/7] drm/i915/ttm, drm/ttm: Initialize the ttm device and memory managers.

On Wed, 2021-05-12 at 09:57 +0100, Matthew Auld wrote: > On Tue, 11 May 2021 at 14:26, Thomas Hellström > wrote: > > > > Temporarily remove the buddy allocator and related selftests > > and hook up the TTM range manager for i915 regions. > > > > In order to support some of the mock region-relate

Re: [Intel-gfx] [PATCH 3/7] drm/i915/ttm, drm/ttm: Initialize the ttm device and memory managers.

On Mon, 2021-05-17 at 09:18 +0200, Thomas Hellström wrote: > On Wed, 2021-05-12 at 09:57 +0100, Matthew Auld wrote: > > On Tue, 11 May 2021 at 14:26, Thomas Hellström > > wrote: > > > > > > Temporarily remove the buddy allocator and related selftests > > > and hook up the TTM range manager for i9

[PATCH] treewide: Remove leading spaces in Kconfig files

There are a few occurences of leading spaces before tabs in a couple of Kconfig files. Remove them by running the following command: $ find . -name 'Kconfig*' | xargs sed -r -i 's/^[ ]+\t/\t/' Signed-off-by: Juerg Haefliger --- arch/arm/mach-omap1/Kconfig | 12 ++-- arch/arm/mach-

[PATCH] video: hgafb: correctly handle card detect failure during probe

The return value of hga_card_detect() is not properly handled causing the probe to succeed even though hga_card_detect() failed. Since probe succeeds, hgafb_open() can be called which will end up operating on an unmapped hga_vram. This results in an out-of-bounds access as reported by kernel test r

Re: [Freedreno] [PATCH v2 5/6] drm/msm/dpu: drop unused lm_max_width from RM

Hi Dmitry, Le dim. 16 mai 2021 à 00:58, Dmitry Baryshkov a écrit : > > No code uses lm_max_width from resource manager, so drop it. I have a pending patch which uses this value to properly determine the number of LMs to use in the topology. Currently the code uses a hardcoded value of MAX_HDISPL

Re: [PATCH 4/4] i915: fix remap_io_sg to verify the pgprot

I have another problem with this patch since it landed in mainline. On my m3-6Y30 skylake HD Graphics 515 (rev 07), it causes visual artifacts that look like bunch of one pixel high horizontal streaks, seen most often in firefox while scrolling or in menu controls. Reverting this patch on top of c

[PATCH v5 2/2] drm/bridge: anx7625: add suspend / resume hooks

Add suspend / resume hooks for anx7625 driver, that power off the device on suspend and power on the device on resume if it was previously powered. Signed-off-by: Pi-Hsun Shih --- Changes in v5: * Disable irq and flush workqueue in suspend hook, so the irq handler won't be run during suspend.

Re: [PATCH v2] drm/rockchip: remove existing generic drivers to take over the device

On Sun, May 16, 2021 at 8:48 AM Javier Martinez Canillas wrote: > > There are drivers that register framebuffer devices very early in the boot > process and make use of the existing framebuffer as setup by the firmware. > > If one of those drivers has registered a fbdev, then the fallback fbdev of

[PATCH v5 1/2] drm/bridge: anx7625: refactor power control to use runtime PM framework

The driver originally use an atomic_t for keep track of the power status, which makes the driver more complicated than needed, and has some race condition as it's possible to have the power on and power off sequence going at the same time. This patch remove the usage of the atomic_t power_status,

Re: [PATCH v3 00/14] Driver of Intel(R) Gaussian & Neural Accelerator

On Fri, May 14, 2021 at 11:00:38AM +0200, Arnd Bergmann wrote: > On Fri, May 14, 2021 at 10:34 AM Greg Kroah-Hartman > wrote: > > On Thu, May 13, 2021 at 01:00:26PM +0200, Maciej Kwapulinski wrote: > > > Dear kernel maintainers, > > > > > > This submission is a kernel driver to support Intel(R) Ga

Re: [PATCH v3 00/14] Driver of Intel(R) Gaussian & Neural Accelerator

On Mon, May 17, 2021 at 09:40:53AM +0200, Daniel Vetter wrote: > On Fri, May 14, 2021 at 11:00:38AM +0200, Arnd Bergmann wrote: > > On Fri, May 14, 2021 at 10:34 AM Greg Kroah-Hartman > > wrote: > > > On Thu, May 13, 2021 at 01:00:26PM +0200, Maciej Kwapulinski wrote: > > > > Dear kernel maintaine

Re: [PATCH] treewide: Remove leading spaces in Kconfig files

On Mon, May 17, 2021 at 10:07:43AM +0200, Juerg Haefliger wrote: > On Mon, May 17, 2021 at 7:46 AM Greg KH wrote: > > > > On Sun, May 16, 2021 at 03:22:09PM +0200, Juerg Haefliger wrote: > > > There are a few occurences of leading spaces before tabs in a couple of > > > Kconfig files. Remove them

回复: [PATCH] drm/amdgpu: fix PM reference leak in amdgpu_debugfs_gfxoff_rea()

[AMD Official Use Only] thanks Kuai. But code below matches the other code block in this file. r = pm_runtime_get_sync(dev->dev); if (r < 0) { pm_runtime_put_autosuspend(dev->dev); return r; } 发件人: Y

Re: [RFC PATCH 1/3] drm/color: Add RGB Color encodings

On Fri, 14 May 2021 17:04:51 -0400 Harry Wentland wrote: > On 2021-04-30 8:53 p.m., Sebastian Wick wrote: > > On 2021-04-26 20:56, Harry Wentland wrote: ... > >> Another reason I'm proposing to define the color space (and gamma) of > >> a plane is to make this explicit. Up until the color spa

Re: [PATCH 1/2] drm: bridge: it66121: fix an error code in it66121_probe()

On 15/05/2021 11:50, Dan Carpenter wrote: > This code is passing the wrong variable to PTR_ERR() so it doesn't > return the correct error code. > > Fixes: 988156dc2fc9 ("drm: bridge: add it66121 driver") > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/bridge/ite-it66121.c | 2 +- > 1 file

Re: [PATCH 2/2] drm: bridge: it66121: fix a resource leak in probe

On 15/05/2021 11:50, Dan Carpenter wrote: > In the original code if the "ctx = devm_kzalloc()" allocation failed > then we should have called of_node_put(ep); before returning. It's > actually a bit easier to do the allocation first before assigning > ep = of_graph_get_endpoint_by_regs(). > > Fix

[PATCH] drm/i915/gem: Pin the L-shape quirked object as unshrinkable

From: Chris Wilson When instantiating a tiled object on an L-shaped memory machine, we mark the object as unshrinkable to prevent the shrinker from trying to swap out the pages. We have to do this as we do not know the swizzling on the individual pages, and so the data will be scrambled across sw

Re: [PATCH v3 00/14] Driver of Intel(R) Gaussian & Neural Accelerator

On Mon, May 17, 2021 at 10:00 AM Greg Kroah-Hartman wrote: > > On Mon, May 17, 2021 at 09:40:53AM +0200, Daniel Vetter wrote: > > On Fri, May 14, 2021 at 11:00:38AM +0200, Arnd Bergmann wrote: > > > On Fri, May 14, 2021 at 10:34 AM Greg Kroah-Hartman > > > wrote: > > > > On Thu, May 13, 2021 at 0

Re: [PATCH -next] drm/bridge: lt9611: Add missing MODULE_DEVICE_TABLE

Hey Zou, On Wed, 12 May 2021 at 08:29, Zou Wei wrote: > > This patch adds missing MODULE_DEVICE_TABLE definition which generates > correct modalias for automatic loading of this driver when it is built > as an external module. > > Reported-by: Hulk Robot > Signed-off-by: Zou Wei > --- > driver

[PATCH] hgafb: fix probe function

There is a reversed if statement in this probe function so the driver is completely broken. Fixes: dc13cac4862c ("video: hgafb: fix potential NULL pointer dereference") Signed-off-by: Dan Carpenter --- drivers/video/fbdev/hgafb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v3 00/14] Driver of Intel(R) Gaussian & Neural Accelerator

On Mon, May 17, 2021 at 10:49:09AM +0200, Daniel Vetter wrote: > On Mon, May 17, 2021 at 10:00 AM Greg Kroah-Hartman > wrote: > > > > On Mon, May 17, 2021 at 09:40:53AM +0200, Daniel Vetter wrote: > > > On Fri, May 14, 2021 at 11:00:38AM +0200, Arnd Bergmann wrote: > > > > On Fri, May 14, 2021 at

Re: [RFC PATCH 0/3] A drm_plane API to support HDR planes

On Fri, 14 May 2021 17:05:11 -0400 Harry Wentland wrote: > On 2021-04-27 10:50 a.m., Pekka Paalanen wrote: > > On Mon, 26 Apr 2021 13:38:49 -0400 > > Harry Wentland wrote: ... > >> ## Mastering Luminances > >> > >> Now we are able to use the PQ 2084 EOTF to define the luminance of > >> pixels

Re: [PATCH -next] drm: bridge: fix wrong pointer passed to PTR_ERR()

Hey Qiheng, Thanks for submitting this bugfix. The title of this patch should probably be: drm: bridge: it66121: fix wrong pointer passed to PTR_ERR() With this fixed, feel free to add my r-b. Reviewed-by: Robert Foss On Fri, 14 May 2021 at 09:03, Qiheng Lin wrote: > > PTR_ERR should access

Re: [PATCH] treewide: Remove leading spaces in Kconfig files

On Mon, 17 May 2021 10:17:38 +0200 Greg KH wrote: > On Mon, May 17, 2021 at 10:07:43AM +0200, Juerg Haefliger wrote: > > On Mon, May 17, 2021 at 7:46 AM Greg KH wrote: > > > > > > > > On Sun, May 16, 2021 at 03:22:09PM +0200, Juerg Haefliger wrote: > > > > There are a few occurences of lead

[PATCH] drm/amdgpu: fix PM reference leak in amdgpu_debugfs_gfxoff_rea()

pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Yu Kuai --- drivers/gpu/drm/amd/am

[PATCH 1/2] drm/v3d: Fix PM reference leak in v3d_get_param_ioctl()

pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Yu Kuai --- drivers/gpu/drm/v3d/v3

[PATCH] drm: bridge: cdns-mhdp8546: Fix PM reference leak in cdns_mhdp_probe()

pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Yu Kuai --- drivers/gpu/drm/bridge

[PATCH 1/3] drm/virtio: Fixes a potential NULL pointer dereference on probe failure

The dev->dev_private might not be allocated if virtio_gpu_pci_quirk() or virtio_gpu_init() failed. In this case, we should avoid the cleanup in virtio_gpu_release(). Signed-off-by: Xie Yongji --- drivers/gpu/drm/virtio/virtgpu_kms.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/

[PATCH 3/3] drm/virtio: free virtqueues on probe failure

We should call virtio_gpu_deinit() to free virtqueues when drm_dev_register() failed. Signed-off-by: Xie Yongji --- drivers/gpu/drm/virtio/virtgpu_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c b/drivers/gpu/drm/virtio/virtgpu_d

Re: [PATCH] treewide: Remove leading spaces in Kconfig files

On Mon, May 17, 2021 at 7:46 AM Greg KH wrote: > > On Sun, May 16, 2021 at 03:22:09PM +0200, Juerg Haefliger wrote: > > There are a few occurences of leading spaces before tabs in a couple of > > Kconfig files. Remove them by running the following command: > > > > $ find . -name 'Kconfig*' | xar

[PATCH 0/2] cleanup patches for PM reference leak

Yu Kuai (2): drm/v3d: Fix PM reference leak in v3d_get_param_ioctl() drm/v3d: Fix PM reference leak in v3d_v3d_debugfs_ident() drivers/gpu/drm/v3d/v3d_debugfs.c | 4 ++-- drivers/gpu/drm/v3d/v3d_drv.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.25.4

[PATCH 2/2] drm/v3d: Fix PM reference leak in v3d_v3d_debugfs_ident()

pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Yu Kuai --- drivers/gpu/drm/v3d/v3

[PATCH 2/3] drm/virtio: Fix double free on probe failure

The virtio_gpu_init() will free vgdev and vgdev->vbufs on failure. But such failure will be caught by virtio_gpu_probe() and then virtio_gpu_release() will be called to do some cleanup which will free vgdev and vgdev->vbufs again. So let's set dev->dev_private to NULL to avoid double free. Signed-

Re: [PATCH v3 00/14] Driver of Intel(R) Gaussian & Neural Accelerator

On Mon, May 17, 2021 at 10:55 AM Greg Kroah-Hartman wrote: > > On Mon, May 17, 2021 at 10:49:09AM +0200, Daniel Vetter wrote: > > On Mon, May 17, 2021 at 10:00 AM Greg Kroah-Hartman > > wrote: > > > > > > On Mon, May 17, 2021 at 09:40:53AM +0200, Daniel Vetter wrote: > > > > On Fri, May 14, 2021

Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix PM reference leak in cdns_mhdp_probe()

Hey Yu, On Mon, 17 May 2021 at 10:08, Yu Kuai wrote: > > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > counter balanced. > > Reported

Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

On Fri, Apr 30, 2021 at 08:20:10PM +0800, Kevin Tang wrote: > Cc Robin & Joerg This is just some GPU internal MMU being used here, it seems. It doesn't use the IOMMU core code, so no Ack needed from the IOMMU side. Regards, Joerg

[PATCH] backlight: Remove leading spaces in Kconfig

Remove leading spaces before tabs in Kconfig file(s) by running the following command: $ find drivers/video/backlight -name 'Kconfig*' | \ xargs sed -r -i 's/^[ ]+\t/\t/' Signed-off-by: Juerg Haefliger --- drivers/video/backlight/Kconfig | 10 +- 1 file changed, 5 insertions(+), 5

Re: [PATCH v13 0/4] drm/panfrost: Add support for mt8183 GPU

On 14/05/2021 17:27, Steven Price wrote: > On 14/05/2021 15:48, Neil Armstrong wrote: >> On 13/05/2021 16:55, Ezequiel Garcia wrote: >>> Hi Neil, >>> >>> On Mon, 26 Apr 2021 at 06:59, Neil Armstrong >>> wrote: Hi, On 21/04/2021 07:28, Nicolas Boichat wrote: > Hi! > >>>

Re: [Intel-gfx] [PATCH 5/7] drm/i915/ttm, drm/ttm: Add a generic TTM memcpy move for page-based iomem

On Tue, 11 May 2021, Thomas Hellström wrote: > The internal ttm_bo_util memcpy uses vmap functionality, and while it > probably might be possible to use it for copying in- and out of > sglist represented io memory, using io_mem_reserve() / io_mem_free() > callbacks, that would cause problems with

Re: [PATCH 0/3] drm: Remove some includes of drm_legacy.h

On Sun, 16 May 2021, Thomas Zimmermann wrote: > Remove include statements for DRM legacy headers. None of these > dependencies is required. Built-tested w/o CONFIG_DRM_LEGACY set. > > These patches should probably go through drm-misc, like the rest > of the legacy cleanups. Acked-by: Jani Nikula

[PATCH] dma-buf: fix unintended pin/unpin warnings

DMA-buf internal users call the pin/unpin functions without having a dynamic attachment. Avoid the warning and backtrace in the logs. Signed-off-by: Christian König Bugs: https://gitlab.freedesktop.org/drm/intel/-/issues/3481 Fixes: c545781e1c55 ("dma-buf: doc polish for pin/unpin") CC: sta...@ke

Re: [Intel-gfx] [PATCH 14/19] drm/i915/oprom: Basic sanitization

On Mon, 12 Apr 2021, Matthew Auld wrote: > From: Anshuman Gupta > > Sanitize OPROM header, CPD signature and OPROM PCI version. > OPROM_HEADER, EXPANSION_ROM_HEADER and OPROM_MEU_BLOB structures > and PCI struct offsets are provided by GSC counterparts. > These are yet to be Documented in B.Spec.

[PATCH v4 1/3] drm/hyperv: Add DRM driver for hyperv synthetic video device

DRM driver for hyperv synthetic video device, based on hyperv_fb framebuffer driver. Also added config option "DRM_HYPERV" to enabled this driver. v2: - Add support for gen2 VM - Fixed review comments v3: - Split into multiple files as suggested by Thomas Zimmermann - Fixed hibernation issue as s

[PATCH v4 2/3] drm/hyperv: Handle feature change message from device

Virtual device inform if screen update is needed or not with SYNTHVID_FEATURE_CHANGE message. Handle this message to set dirt_needed flag. Suggested-by: Dexuan Cui Signed-off-by: Deepak Rawat --- drivers/gpu/drm/hyperv/hyperv_drm.h | 1 + drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 2 ++

[PATCH v4 3/3] MAINTAINERS: Add maintainer for hyperv video device

Maintainer for hyperv synthetic video device. Signed-off-by: Deepak Rawat --- MAINTAINERS | 16 1 file changed, 16 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index bd7aff0c120f..261342551406 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6077,6 +6077,14 @@ T: gi

Re: [PATCH v4 3/3] MAINTAINERS: Add maintainer for hyperv video device

Sorry messed this patch during rebase. Will send this one again after fixing this. On Mon, May 17, 2021 at 4:59 AM Deepak Rawat wrote: > Maintainer for hyperv synthetic video device. > > Signed-off-by: Deepak Rawat > --- > MAINTAINERS | 16 > 1 file changed, 16 insertions(+) >

Re: [PATCH v3] drm/i915: Invoke another _DSM to enable MUX on HP Workstation laptops

On Fri, 14 May 2021, Kai-Heng Feng wrote: > On Wed, May 12, 2021 at 2:19 AM Ville Syrjälä > wrote: >> >> On Mon, Apr 26, 2021 at 11:24:10PM +0800, Kai-Heng Feng wrote: >> > On HP Fury G7 Workstations, graphics output is re-routed from Intel GFX >> > to discrete GFX after S3. This is not desirable

Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix PM reference leak in cdns_mhdp_probe()

On 2021/05/17 17:27, Robert Foss wrote: Hey Yu, On Mon, 17 May 2021 at 10:08, Yu Kuai wrote: pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep us

Re: [PATCH] MAINTAINERS: repair reference in DRM DRIVER FOR SIMPLE FRAMEBUFFERS

Hi Am 17.05.21 um 12:16 schrieb Lukas Bulwahn: Commit 11e8f5fd223b ("drm: Add simpledrm driver") adds the file ./drivers/gpu/drm/tiny/simpledrm.c, but refers to the file ./drivers/gpu/drm/tiny/simplekms.c with the new MAINTAINERS section DRM DRIVER FOR SIMPLE FRAMEBUFFERS. Hence, ./scripts/get_

Re: [PATCH] video: fbdev: vga16fb: fix OOB write in vga16fb_imageblit()

On Fri, May 14, 2021 at 10:33 PM Linus Torvalds wrote: > > On Fri, May 14, 2021 at 1:25 PM Maciej W. Rozycki wrote: > > > > Overall I think it does make sense to resize the text console at any > > time, even if the visible console (VT) chosen is in the graphics mode, > > It might make sense, but

Re: [PATCH] video: fbdev: vga16fb: fix OOB write in vga16fb_imageblit()

On Mon, May 17, 2021 at 3:07 PM Daniel Vetter wrote: > > On Fri, May 14, 2021 at 10:33 PM Linus Torvalds > wrote: > > > > On Fri, May 14, 2021 at 1:25 PM Maciej W. Rozycki wrote: > > > > > > Overall I think it does make sense to resize the text console at any > > > time, even if the visible con

Re: [PATCH v2] tty: vt: always invoke vc->vc_sw->con_resize callback

On Sat, May 15, 2021 at 6:42 PM Linus Torvalds wrote: > > On Sat, May 15, 2021 at 9:33 AM Maciej W. Rozycki wrote: > > > > NB I suggest that you request your change to be backported, i.e. post v3 > > with: > > > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > > Cc: sta...@vger.kernel.org # v2.6.12+

Re: [PATCH] drm/ingenic: Fix pixclock rate for 24-bit serial panels

On Thu, May 13, 2021 at 01:29:30PM +0100, Paul Cercueil wrote: > Hi, > > Almost two months later, Since you're committer it's expected that you go actively out to look for review or trade with someone else who has some patches that need a quick look. It will not happen automatically, this is on y

[PULL] drm-misc-next

Hi Dave and Daniel, here's this week's PR for drm-misc-next for what wil become v5.14. Panfrost gets support for Mediatek MT8381 chips. There are a number of fixes for resource leaks in various drivers. Unlocking on errors in aperture helpers gets fixes as well. Best regards Thomas drm-misc-next

Re: [V3, 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

Hi Marek, I'm testing your driver, some remarks below. Met vriendelijke groet / kind regards, Mike Looijmans System Expert TOPIC Embedded Products B.V. Materiaalweg 4, 5681 RJ Best The Netherlands T: +31 (0) 499 33 69 69 E: mike.looijm...@topicproducts.com W: www.topic.nl Please consider t

Re: [PULL] drm-misc-next

Hi Am 17.05.21 um 15:17 schrieb Thomas Zimmermann: Hi Dave and Daniel, here's this week's PR for drm-misc-next for what wil become v5.14. Panfrost gets support for Mediatek MT8381 chips. There are a number of fixes for resource leaks in various drivers. Unlocking on errors in aperture helpers g

Re: [PATCH 19/27] drm/i915/gem: Use the proto-context to handle create parameters

On Fri, May 14, 2021 at 02:13:57PM -0500, Jason Ekstrand wrote: > On Tue, May 4, 2021 at 3:33 PM Daniel Vetter wrote: > > > > On Mon, May 03, 2021 at 10:57:40AM -0500, Jason Ekstrand wrote: > > > This means that the proto-context needs to grow support for engine > > > configuration information as

Re: [PATCH v4 1/3] drm/hyperv: Add DRM driver for hyperv synthetic video device

Hi I only have a number of trivial changes listed below. With these fixed: Acked-by: Thomas Zimmermann Am 17.05.21 um 13:59 schrieb Deepak Rawat: DRM driver for hyperv synthetic video device, based on hyperv_fb framebuffer driver. Also added config option "DRM_HYPERV" to enabled this driver.

Re: [PATCH v4 2/3] drm/hyperv: Handle feature change message from device

Am 17.05.21 um 13:59 schrieb Deepak Rawat: Virtual device inform if screen update is needed or not with SYNTHVID_FEATURE_CHANGE message. Handle this message to set dirt_needed flag. Suggested-by: Dexuan Cui Signed-off-by: Deepak Rawat Acked-by: Thomas Zimmermann --- drivers/gpu/drm/hy

Re: [Intel-gfx] [RFC PATCH 4/5] drm/i915: Introduce 'set parallel submit' extension

On Fri, May 14, 2021 at 01:05:33PM -0700, Matthew Brost wrote: > On Wed, May 12, 2021 at 10:34:59AM +0200, Daniel Vetter wrote: > > On Tue, May 11, 2021 at 11:44:28AM -0700, Matthew Brost wrote: > > > On Tue, May 11, 2021 at 05:11:44PM +0200, Daniel Vetter wrote: > > > > On Thu, May 06, 2021 at 10:

Re: dual RX460 result in logspam about P2P DMA

On Sat, May 15, 2021 at 10:12 AM Richard Dietrich Wachler wrote: > > Excuse my novicesness, > > i use 2 RX460 on a KGPE-D16 server board to drive 4 displays. > > 02:00.0 VGA compatible controller: Advanced Micro Devices, Inc. > [AMD/ATI] Baffin [Radeon RX 460/560D / Pro > 450/455/460/555/555X/560/

Re: [PATCH] dma-buf: fix unintended pin/unpin warnings

On Mon, May 17, 2021 at 7:57 AM Christian König wrote: > > DMA-buf internal users call the pin/unpin functions without having a > dynamic attachment. Avoid the warning and backtrace in the logs. > > Signed-off-by: Christian König > Bugs: https://gitlab.freedesktop.org/drm/intel/-/issues/3481 > Fi

Re: [PATCH] drm:vkms: Add NULL value after free function In function vkms_exit, after kfree(default_config), give specific NULL value to pointer default_config to avoid wild pointer.

On Wed, May 12, 2021 at 07:55:54PM +0800, Hao Peng wrote: > Signed-off-by: Hao Peng > --- > drivers/gpu/drm/vkms/vkms_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c > index 2173b82606f6..6c63201db5d0 100644 > --- a

[PATCH 01/11] dma-buf: fix invalid debug print

The code tries to acquire the rcu protected fence list, but then ignores individual fences which has been modified while holding the rcu. Stop that madness and just note cleanly that the list was concurrently modified. Signed-off-by: Christian König --- drivers/dma-buf/dma-buf.c | 19 --

[RFC] Add DMA_RESV_USAGE flags

We had a long outstanding problem in amdgpu that buffers exported to user drivers by DMA-buf serialize all command submissions using them. In other words we can't compose the buffer with different engines and then send it to another driver for display further processing. This was added to work

[PATCH 02/11] dma-buf: add SPDX header and fix style in dma-resv.c

No functional change. Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 128 +++-- 1 file changed, 65 insertions(+), 63 deletions(-) diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c index 6ddbeb5dfbf6..87f5d82d992a 100644 --- a/d

[PATCH 03/11] dma-buf: cleanup dma-resv shared fence debugging a bit

Make that a function instead of inline. Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 18 ++ include/linux/dma-resv.h | 15 +++ 2 files changed, 25 insertions(+), 8 deletions(-) diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c

[PATCH 09/11] dma-buf: add shared fence usage flags

Add usage flags for shared fences and improve the documentation. This allows driver to better specify what shared fences are doing with the resource. Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c| 132 +- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_g

[PATCH 04/11] dma-buf: rename and cleanup dma_resv_get_excl

When the comment needs to state explicitly that this doesn't get a reference to the object then the function is named rather badly. Rename the function and use rcu_dereference_check(), this way it can be used from both rcu as well as lock protected critical sections. Signed-off-by: Christian Köni

[PATCH 11/11] drm/amdgpu: fix shared access to exported DMA-bufs

We are running into more and more problems with that approach since every command submission to the buffer in question is now serializing. Since the i915 where we originally added that for is now fixed we should be able to remove this. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdg

[PATCH 05/11] dma-buf: rename and cleanup dma_resv_get_list

When the comment needs to state explicitly that this is doesn't get a reference to the object then the function is named rather badly. Rename the function and use it in even more places. Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c| 32 +-- .

[PATCH 07/11] dma-buf: add dma_resv_replace_shared

This function allows to replace fences from the shared fence list when we can gurantee that the operation represented by the original fence has finished or no accesses to the resources protected by the dma_resv object any more when the new fence finishes. Signed-off-by: Christian König --- drive

[PATCH 08/11] dma-buf: improve shared fence abstraction

Put access to the shared fences behind an interator. This way we don't need to expose the internal implementation any more. Signed-off-by: Christian König --- drivers/dma-buf/dma-buf.c | 46 ++-- drivers/dma-buf/dma-resv.c | 61 +

[PATCH 10/11] drm/i915: also wait for shared dmabuf fences before flip

Add dependencies for implicit sync to shared fences as well to i915. This was lengthy discussed about four years ago, but since the workaround we did in amdgpu is now causing more and more problems we need to fix this properly. Signed-off-by: Christian König --- drivers/gpu/drm/i915/display/int

[PATCH 06/11] dma-buf: add dma_resv_list_fence helper

Instead of repeating the access check over and over again. Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 42 +++--- 1 file changed, 25 insertions(+), 17 deletions(-) diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c index b1a1

Re: [PATCH 0/7] Per client engine busyness

On Thu, May 13, 2021 at 11:48:08AM -0400, Alex Deucher wrote: > On Thu, May 13, 2021 at 7:00 AM Tvrtko Ursulin > wrote: > > > > From: Tvrtko Ursulin > > > > Resurrect of the previosuly merged per client engine busyness patches. In a > > nutshell it enables intel_gpu_top to be more top(1) like use

Re: New uAPI for color management proposal and feedback request

Am 12.05.21 um 14:06 schrieb Werner Sembach: > Hello, > > In addition to the existing "max bpc", and "Broadcast RGB/output_csc" drm > properties I propose 4 new properties: > "preferred pixel encoding", "active color depth", "active color range", and > "active pixel encoding" As an alternative/a

Re: [PATCH 0/7] Per client engine busyness

On Fri, May 14, 2021 at 05:10:29PM +0200, Christian König wrote: > Am 14.05.21 um 17:03 schrieb Tvrtko Ursulin: > > > > On 14/05/2021 15:56, Christian König wrote: > > > Am 14.05.21 um 16:47 schrieb Tvrtko Ursulin: > > > > > > > > On 14/05/2021 14:53, Christian König wrote: > > > > > > > > > > >

Re: [PATCH] drm/ingenic: Fix pixclock rate for 24-bit serial panels

Hi Daniel, Le lun., mai 17 2021 at 15:15:59 +0200, Daniel Vetter a écrit : On Thu, May 13, 2021 at 01:29:30PM +0100, Paul Cercueil wrote: Hi, Almost two months later, Since you're committer it's expected that you go actively out to look for review or trade with someone else who has some

[PATCH v7 1/4] mfd: rt4831: Adds support for Richtek RT4831

From: ChiYuan Huang This adds support Richtek RT4831 core. It includes four channel WLED driver and Display Bias Voltage outputs. Signed-off-by: ChiYuan Huang --- - Send the patch series for the wrong mail subject. The RT4831 regulator patches are already on main stream, and can be referred to

[PATCH v7 3/4] mfd: rt4831: Adds DT binding document for Richtek RT4831

From: ChiYuan Huang Adds DT binding document for Richtek RT4831. Signed-off-by: ChiYuan Huang Reviewed-by: Rob Herring --- .../devicetree/bindings/mfd/richtek,rt4831.yaml| 90 ++ 1 file changed, 90 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd

[PATCH v7 2/4] backlight: rt4831: Adds DT binding document for Richtek RT4831 backlight

From: ChiYuan Huang Adds DT binding document for Richtek RT4831 backlight. Signed-off-by: ChiYuan Huang Reviewed-by: Daniel Thompson --- since v7 - Add allOf property refer to common.yaml. - Remove default-brightness/max-brightness description and refer string. --- .../leds/backlight/richtek,

[PATCH v7 4/4] backlight: rt4831: Adds support for Richtek RT4831 backlight

From: ChiYuan Huang Adds support for Richtek RT4831 backlight. Signed-off-by: ChiYuan Huang Reviewed-by: Daniel Thompson --- since v7 - Fix typo 'common' to 'commonly' in Kconfig description. --- drivers/video/backlight/Kconfig| 8 ++ drivers/video/backlight/Makefile |

Re: [PATCH] drm/ingenic: Fix pixclock rate for 24-bit serial panels

On Mon, May 17, 2021 at 03:30:45PM +0100, Paul Cercueil wrote: > Hi Daniel, > > Le lun., mai 17 2021 at 15:15:59 +0200, Daniel Vetter a > écrit : > > On Thu, May 13, 2021 at 01:29:30PM +0100, Paul Cercueil wrote: > > > Hi, > > > > > > Almost two months later, > > > > Since you're committer it

Re: [PATCH 0/7] Per client engine busyness

[AMD Official Use Only] Maybe we could try to standardize how the different submission ring usage gets exposed in the fdinfo? We went the simple way of just adding name and index, but if someone has a suggestion on how else we could format them so there is commonality across vendors we could j

[PATCH] drm/amdgpu: Handle IOMMU enabled case.

Problem: Handle all DMA IOMMU group related dependencies before the group is removed. Those manifest themself in that when IOMMU enabled DMA map/unmap is dependent on the presence of IOMMU group the device belongs to but, this group is released once the device is removed from PCI topology. Fix: Ex

Re: [PATCH v7 12/16] drm/amdgpu: Fix hang on device removal.

Ping Andrey On 2021-05-14 10:42 a.m., Andrey Grodzovsky wrote: Ping Andrey On 2021-05-12 10:26 a.m., Andrey Grodzovsky wrote: If removing while commands in flight you cannot wait to flush the HW fences on a ring since the device is gone. Signed-off-by: Andrey Grodzovsky ---   drivers/gpu/d

Re: [PATCH v7 16/16] drm/amdgpu: Unmap all MMIO mappings

Ping Andrey On 2021-05-14 10:42 a.m., Andrey Grodzovsky wrote: Ping Andrey On 2021-05-12 10:26 a.m., Andrey Grodzovsky wrote: Access to those must be prevented post pci_remove v6: Drop BOs list, unampping VRAM BAR is enough. Signed-off-by: Andrey Grodzovsky ---   drivers/gpu/drm/amd/amdgp

Re: [PATCH] drm/amdgpu: Handle IOMMU enabled case.

Am 2021-05-17 um 10:38 a.m. schrieb Andrey Grodzovsky: > Problem: > Handle all DMA IOMMU group related dependencies before the > group is removed. Those manifest themself in that when IOMMU > enabled DMA map/unmap is dependent on the presence of IOMMU > group the device belongs to but, this group i

Re: [PATCH] drm: Remove unused branch in legacy PCI initialization

On Sun, May 16, 2021 at 09:19:18PM +0200, Thomas Zimmermann wrote: > The legacy PCI init code sets the drvdata for drivers with MODESET > flag, but none of the old UMS drivers sets the flag. Remove the branch. > > Signed-off-by: Thomas Zimmermann Yeah now that this is legacy-only it really doesn

Re: [PATCH] drm: Mark IRQ_BUSID ioctl as legacy

On Sun, May 16, 2021 at 09:51:35PM +0200, Thomas Zimmermann wrote: > The functionality is only implemented for legacy drivers. Mark the ioctl > as legacy and move the code behind CONFIG_DRM_LEGACY. If legacy drivers > are disabled, the ioctl call now returns -EINVAL instead of -EOPNOTSUPP. I think

Re: [PATCH] dma-buf: fix unintended pin/unpin warnings

On Mon, May 17, 2021 at 10:09:13AM -0400, Alex Deucher wrote: > On Mon, May 17, 2021 at 7:57 AM Christian König > wrote: > > > > DMA-buf internal users call the pin/unpin functions without having a > > dynamic attachment. Avoid the warning and backtrace in the logs. > > > > Signed-off-by: Christia

Re: [RFC] Add DMA_RESV_USAGE flags

On Mon, May 17, 2021 at 04:11:18PM +0200, Christian König wrote: > We had a long outstanding problem in amdgpu that buffers exported to > user drivers by DMA-buf serialize all command submissions using them. > > In other words we can't compose the buffer with different engines and > then send it t

Re: [PATCH] drm/i915: Stop propagating fence errors by default

On Tue, May 11, 2021 at 10:05:27AM +0100, Tvrtko Ursulin wrote: > > On 10/05/2021 16:55, Daniel Vetter wrote: > > On Fri, May 07, 2021 at 09:35:21AM +0100, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > This is an alternative proposed fix for the below references bug report > > > w

Re: [PATCH] backlight: Remove leading spaces in Kconfig

On Mon, May 17, 2021 at 11:58:39AM +0200, Juerg Haefliger wrote: > Remove leading spaces before tabs in Kconfig file(s) by running the > following command: > > $ find drivers/video/backlight -name 'Kconfig*' | \ > xargs sed -r -i 's/^[ ]+\t/\t/' > > Signed-off-by: Juerg Haefliger > --- >

Re: [PULL] topic/iomem-mmap-vs-gup

On Mon, May 10, 2021 at 9:30 AM Christoph Hellwig wrote: > > On Mon, May 10, 2021 at 09:16:58AM +0200, Daniel Vetter wrote: > > > End result: not pulling it, unless somebody can explain to me in small > > > words why I'm wrong and have the mental capacity of a damaged rodent. > > > > No rodents I

Re: [PATCH] drm/i915: Stop propagating fence errors by default

On 17/05/2021 16:12, Daniel Vetter wrote: On Tue, May 11, 2021 at 10:05:27AM +0100, Tvrtko Ursulin wrote: On 10/05/2021 16:55, Daniel Vetter wrote: On Fri, May 07, 2021 at 09:35:21AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin This is an alternative proposed fix for the below refere

Re: [PATCH] drm/i915: Stop propagating fence errors by default

On Mon, May 17, 2021 at 5:33 PM Tvrtko Ursulin wrote: > On 17/05/2021 16:12, Daniel Vetter wrote: > > On Tue, May 11, 2021 at 10:05:27AM +0100, Tvrtko Ursulin wrote: > >> > >> On 10/05/2021 16:55, Daniel Vetter wrote: > >>> On Fri, May 07, 2021 at 09:35:21AM +0100, Tvrtko Ursulin wrote: > Fro

Re: [PATCH 0/7] Per client engine busyness

On 17/05/2021 15:39, Nieto, David M wrote: [AMD Official Use Only] Maybe we could try to standardize how the different submission ring  usage gets exposed in the fdinfo? We went the simple way of just adding name and index, but if someone has a suggestion on how else we could format them

Re: [PATCH 4/4] i915: fix remap_io_sg to verify the pgprot

Christoph Hellwig writes: > As an ad-hoc experiment: can you replace the call to remap_pfn_range > with remap_pfn_range_notrack (and export it if you build i915 modular) > in remap_io_sg and see if that makes any difference? That worked, thanks -- no artifacts seen.

  1   2   3   >