Re: [PATCH 6/7] drm/i915/ttm, drm/ttm: Introduce a TTM i915 gem object backend

2021-05-12 Thread Thomas Hellström
On Wed, 2021-05-12 at 08:57 +0200, Christian König wrote: > Am 11.05.21 um 16:28 schrieb Thomas Hellström: > > > > On 5/11/21 4:09 PM, Christian König wrote: > > > > > > > > > Am 11.05.21 um 16:06 schrieb Thomas Hellström (Intel): > > > > > > > > On 5/11/21 3:58 PM, Christian König wrote: > > >

Re: [PATCH 6/7] drm/i915/ttm, drm/ttm: Introduce a TTM i915 gem object backend

2021-05-12 Thread Christian König
Am 12.05.21 um 09:05 schrieb Thomas Hellström: On Wed, 2021-05-12 at 08:57 +0200, Christian König wrote: Am 11.05.21 um 16:28 schrieb Thomas Hellström: On 5/11/21 4:09 PM, Christian König wrote: Am 11.05.21 um 16:06 schrieb Thomas Hellström (Intel): On 5/11/21 3:58 PM, Christian König wrote:

Re: [PATCH] drm/doc/rfc: drop the i915_gem_lmem.h header

2021-05-12 Thread Matthew Auld
On 11/05/2021 18:29, Daniel Vetter wrote: On Tue, May 11, 2021 at 07:28:08PM +0200, Daniel Vetter wrote: On Tue, May 11, 2021 at 06:03:56PM +0100, Matthew Auld wrote: The proper headers have now landed in include/uapi/drm/i915_drm.h, so we can drop i915_gem_lmem.h and instead just reference the

Re: [Intel-gfx] [PATCH 7/7] drm/i915/lmem: Verify checks for lmem residency

2021-05-12 Thread Matthew Auld
On Tue, 11 May 2021 at 14:26, Thomas Hellström wrote: > > Since objects can be migrated or evicted when not pinned or locked, > update the checks for lmem residency or future residency so that > the value returned is not immediately stale. > > Signed-off-by: Thomas Hellström > --- > drivers/gpu/

Re: [PATCH] drm/doc/rfc: drop the i915_gem_lmem.h header

2021-05-12 Thread Daniel Vetter
On Wed, May 12, 2021 at 08:38:55AM +0100, Matthew Auld wrote: > On 11/05/2021 18:29, Daniel Vetter wrote: > > On Tue, May 11, 2021 at 07:28:08PM +0200, Daniel Vetter wrote: > > > On Tue, May 11, 2021 at 06:03:56PM +0100, Matthew Auld wrote: > > > > The proper headers have now landed in include/uapi

Re: [RFC] Implicit vs explicit user fence sync

2021-05-12 Thread Daniel Vetter
On Tue, May 11, 2021 at 09:34:11PM +0200, Christian König wrote: > Am 11.05.21 um 18:48 schrieb Daniel Vetter: > > [SNIP] > > > Why? > > If you allow implicit fencing then you can end up with > > - an implicit userspace fence as the in-fence > > - but an explicit dma_fence as the out fence > > > >

Re: [RFC] Implicit vs explicit user fence sync

2021-05-12 Thread Christian König
Am 12.05.21 um 10:13 schrieb Daniel Vetter: On Tue, May 11, 2021 at 09:34:11PM +0200, Christian König wrote: Am 11.05.21 um 18:48 schrieb Daniel Vetter: [SNIP] Why? If you allow implicit fencing then you can end up with - an implicit userspace fence as the in-fence - but an explicit dma_fence

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-12 Thread Pekka Paalanen
On Tue, 11 May 2021 18:44:17 +0200 Daniel Vetter wrote: > On Mon, May 10, 2021 at 12:06:05PM -0700, Rob Clark wrote: > > On Mon, May 10, 2021 at 10:44 AM Daniel Vetter wrote: > > > > > > On Mon, May 10, 2021 at 6:51 PM Rob Clark wrote: > > > > > > > > On Mon, May 10, 2021 at 9:14 AM Daniel

Patch "drm: bridge: fix LONTIUM use of mipi_dsi_() functions" has been added to the 5.10-stable tree

2021-05-12 Thread gregkh
This is a note to let you know that I've just added the patch titled drm: bridge: fix LONTIUM use of mipi_dsi_() functions to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "drm: bridge: fix LONTIUM use of mipi_dsi_() functions" has been added to the 5.11-stable tree

2021-05-12 Thread gregkh
This is a note to let you know that I've just added the patch titled drm: bridge: fix LONTIUM use of mipi_dsi_() functions to the 5.11-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [Intel-gfx] [RFC PATCH 4/5] drm/i915: Introduce 'set parallel submit' extension

2021-05-12 Thread Daniel Vetter
On Tue, May 11, 2021 at 11:44:28AM -0700, Matthew Brost wrote: > On Tue, May 11, 2021 at 05:11:44PM +0200, Daniel Vetter wrote: > > On Thu, May 06, 2021 at 10:30:48AM -0700, Matthew Brost wrote: > > > i915_drm.h updates for 'set parallel submit' extension. > > > > > > Cc: Tvrtko Ursulin > > > Cc:

Patch "drm: bridge: fix LONTIUM use of mipi_dsi_() functions" has been added to the 5.12-stable tree

2021-05-12 Thread gregkh
This is a note to let you know that I've just added the patch titled drm: bridge: fix LONTIUM use of mipi_dsi_() functions to the 5.12-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [RFC PATCH 20/97] drm/i915/guc: Introduce unified HXG messages

2021-05-12 Thread Daniel Vetter
On Wed, May 12, 2021 at 12:11:40AM +0200, Michal Wajdeczko wrote: > > > On 11.05.2021 17:16, Daniel Vetter wrote: > > On Thu, May 06, 2021 at 12:13:34PM -0700, Matthew Brost wrote: > >> From: Michal Wajdeczko > >> > >> New GuC firmware will unify format of MMIO and CTB H2G messages. > >> Introdu

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-12 Thread Daniel Vetter
On Wed, May 12, 2021 at 11:23:30AM +0300, Pekka Paalanen wrote: > On Tue, 11 May 2021 18:44:17 +0200 > Daniel Vetter wrote: > > > On Mon, May 10, 2021 at 12:06:05PM -0700, Rob Clark wrote: > > > On Mon, May 10, 2021 at 10:44 AM Daniel Vetter wrote: > > > > > > > > On Mon, May 10, 2021 at 6:51

Re: [RFC] Implicit vs explicit user fence sync

2021-05-12 Thread Daniel Vetter
On Wed, May 12, 2021 at 10:23:04AM +0200, Christian König wrote: > Am 12.05.21 um 10:13 schrieb Daniel Vetter: > > On Tue, May 11, 2021 at 09:34:11PM +0200, Christian König wrote: > > > Am 11.05.21 um 18:48 schrieb Daniel Vetter: > > > > [SNIP] > > > > > Why? > > > > If you allow implicit fencing t

Re: [Intel-gfx] [PATCH 3/7] drm/i915/ttm, drm/ttm: Initialize the ttm device and memory managers.

2021-05-12 Thread Matthew Auld
On Tue, 11 May 2021 at 14:26, Thomas Hellström wrote: > > Temporarily remove the buddy allocator and related selftests > and hook up the TTM range manager for i915 regions. > > In order to support some of the mock region-related selftests, we need to > be able to initialize the TTM range-manager s

[PATCH] video: fbdev: udlfb: Remove redundant initialization of

2021-05-12 Thread Yang Li
Integer variable 'identical' is being initialized however this value is never read as 'identical' is assigned the result of 'start + (width - end)'. Remove the redundant assignment. At the same time, adjust the declarations order of variables to keep the "upside-down x-mas tree" look of them. Clea

Re: [PATCH] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

2021-05-12 Thread Daniel Vetter
On Thu, May 06, 2021 at 03:23:43PM +0200, Daniel Vetter wrote: > It's very confusing for userspace to have to deal with inconsistencies > here, and some drivers screwed this up a bit. Most just ommitted the > format list when they meant to say that only linear modifier is > allowed, but some also m

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-12 Thread Pekka Paalanen
On Wed, 12 May 2021 10:44:29 +0200 Daniel Vetter wrote: > On Wed, May 12, 2021 at 11:23:30AM +0300, Pekka Paalanen wrote: > > On Tue, 11 May 2021 18:44:17 +0200 > > Daniel Vetter wrote: > > > > > On Mon, May 10, 2021 at 12:06:05PM -0700, Rob Clark wrote: > > > > On Mon, May 10, 2021 at 10:4

Patch "drm: bridge: fix ANX7625 use of mipi_dsi_() functions" has been added to the 5.11-stable tree

2021-05-12 Thread gregkh
This is a note to let you know that I've just added the patch titled drm: bridge: fix ANX7625 use of mipi_dsi_() functions to the 5.11-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "drm: bridge: fix ANX7625 use of mipi_dsi_() functions" has been added to the 5.12-stable tree

2021-05-12 Thread gregkh
This is a note to let you know that I've just added the patch titled drm: bridge: fix ANX7625 use of mipi_dsi_() functions to the 5.12-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

[PATCH] drm/amd/display: Fix duplicate included hubp.h

2021-05-12 Thread Jiapeng Chong
Clean up the following includecheck warning: ./drivers/gpu/drm/amd/display/dc/core/dc.c: hubp.h is included more than once. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/dc/core/dc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/

Re: [5.12 regression] ttm->pages NULL dereference with radeon driver

2021-05-12 Thread Christian König
Hi guys, adding a few people who ran into the problem as well and opened a kernel bug. Am 07.05.21 um 17:11 schrieb Christian König: Hi Takashi, Am 07.05.21 um 17:08 schrieb Takashi Iwai: Hi, we've received a regression report showing NULL dereference Oops with radeon driver on 5.12 kernel

[PATCH] drm/i915/gem: Pin the L-shape quirked object as unshrinkable

2021-05-12 Thread Matthew Auld
From: Chris Wilson When instantiating a tiled object on an L-shaped memory machine, we mark the object as unshrinkable to prevent the shrinker from trying to swap out the pages. We have to do this as we do not know the swizzling on the individual pages, and so the data will be scrambled across sw

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-12 Thread Daniel Vetter
On Wed, May 12, 2021 at 11:46 AM Pekka Paalanen wrote: > > On Wed, 12 May 2021 10:44:29 +0200 > Daniel Vetter wrote: > > > On Wed, May 12, 2021 at 11:23:30AM +0300, Pekka Paalanen wrote: > > > On Tue, 11 May 2021 18:44:17 +0200 > > > Daniel Vetter wrote: > > > > > > > On Mon, May 10, 2021 at 12:

Re: [Intel-gfx] [PATCH 6/7] drm/i915/ttm, drm/ttm: Introduce a TTM i915 gem object backend

2021-05-12 Thread Matthew Auld
On Tue, 11 May 2021 at 14:26, Thomas Hellström wrote: > > Most logical place to introduce TTM buffer objects is as an i915 > gem object backend. We need to add some ops to account for added > functionality like delayed delete and LRU list manipulation. > > Initially we support only LMEM and SYSTEM

Re: [Intel-gfx] [PATCH 6/7] drm/i915/ttm, drm/ttm: Introduce a TTM i915 gem object backend

2021-05-12 Thread Thomas Hellström
Hi, Matthew, Thanks for reviewing! On 5/12/21 1:45 PM, Matthew Auld wrote: On Tue, 11 May 2021 at 14:26, Thomas Hellström wrote: Most logical place to introduce TTM buffer objects is as an i915 gem object backend. We need to add some ops to account for added functionality like delayed delete

New uAPI for color management proposal and feedback request

2021-05-12 Thread Werner Sembach
Hello, In addition to the existing "max bpc", and "Broadcast RGB/output_csc" drm properties I propose 4 new properties: "preferred pixel encoding", "active color depth", "active color range", and "active pixel encoding" Motivation: Current monitors have a variety pixel encodings available: RG

Re: [PATCH] video/logo: protect against divide by zero when reading image

2021-05-12 Thread Geert Uytterhoeven
Hi Yiyuan, CC dri-devel, linux-fbdev On Wed, 12 May 2021, Yiyuan GUO wrote: In video/logo/pnmtologo.c, the function read_image can read from the image file an integer 0 and pass it to function get_number255, leading to a divide by zero problem. Signed-off-by: Yiyuan GUO Thanks for y

[PATCH] drm:vkms: Add NULL value after free function In function vkms_exit, after kfree(default_config), give specific NULL value to pointer default_config to avoid wild pointer.

2021-05-12 Thread Hao Peng
Signed-off-by: Hao Peng --- drivers/gpu/drm/vkms/vkms_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c index 2173b82606f6..6c63201db5d0 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.c +++ b/drivers/gpu/drm/vkms/vkms_drv.c @@

Re: dri-devel Digest, Vol 134, Issue 309

2021-05-12 Thread chatzem
Sent from ProtonMail mobile Original Message On May 12, 2021, 08:57, wrote: > Send dri-devel mailing list submissions to > dri-devel@lists.freedesktop.org > > To subscribe or unsubscribe via the World Wide Web, visit > https://lists.freedesktop.org/mailman/listinfo/dri-devel > o

Re: dri-devel Digest, Vol 134, Issue 309

2021-05-12 Thread chatzem
Sent from ProtonMail mobile Original Message On May 12, 2021, 08:57, wrote: > Send dri-devel mailing list submissions to > dri-devel@lists.freedesktop.org > > To subscribe or unsubscribe via the World Wide Web, visit > https://lists.freedesktop.org/mailman/listinfo/dri-devel > o

Re: dri-devel Digest, Vol 134, Issue 309

2021-05-12 Thread chatzem
Sent from ProtonMail mobile Original Message On May 12, 2021, 08:57, wrote: > Send dri-devel mailing list submissions to > dri-devel@lists.freedesktop.org > > To subscribe or unsubscribe via the World Wide Web, visit > https://lists.freedesktop.org/mailman/listinfo/dri-devel > o

Re: [PATCH 1/2] drm/doc: document how userspace should find out CRTC index

2021-05-12 Thread Leandro Ribeiro
On 5/6/21 5:50 AM, Pekka Paalanen wrote: > On Wed, 28 Apr 2021 18:36:50 -0300 > Leandro Ribeiro wrote: > >> In this patch we add a section to document what userspace should do to >> find out the CRTC index. This is important as there are multiple places >> in the documentation that need this,

[PATCH v2 32/40] docs: gpu: Use ASCII subset instead of UTF-8 alternate symbols

2021-05-12 Thread Mauro Carvalho Chehab
The conversion tools used during DocBook/LaTeX/Markdown->ReST conversion and some automatic rules which exists on certain text editors like LibreOffice turned ASCII characters into some UTF-8 alternatives that are better displayed on html and PDF. While it is OK to use UTF-8 characters in Linux, i

[PATCH v2 00/40] Use ASCII subset instead of UTF-8 alternate symbols

2021-05-12 Thread Mauro Carvalho Chehab
This series contain basically a cleanup from all those years of converting files to ReST. During the conversion period, several tools like LaTeX, pandoc, DocBook and some specially-written scripts were used in order to convert existing documents. Such conversion tools - plus some text editor like

Re: [PATCH 6/7] drm/i915/ttm, drm/ttm: Introduce a TTM i915 gem object backend

2021-05-12 Thread Thomas Hellström
On Wed, 2021-05-12 at 09:09 +0200, Christian König wrote: > Am 12.05.21 um 09:05 schrieb Thomas Hellström: > > On Wed, 2021-05-12 at 08:57 +0200, Christian König wrote: > > > Am 11.05.21 um 16:28 schrieb Thomas Hellström: > > > > On 5/11/21 4:09 PM, Christian König wrote: > > > > > > > > > > Am 11

Re: [PATCH 1/2] drm/doc: document how userspace should find out CRTC index

2021-05-12 Thread Pekka Paalanen
On Wed, 12 May 2021 09:50:14 -0300 Leandro Ribeiro wrote: > On 5/6/21 5:50 AM, Pekka Paalanen wrote: > > On Wed, 28 Apr 2021 18:36:50 -0300 > > Leandro Ribeiro wrote: > > > >> In this patch we add a section to document what userspace should do to > >> find out the CRTC index. This is importan

Re: New uAPI for color management proposal and feedback request

2021-05-12 Thread Ville Syrjälä
On Wed, May 12, 2021 at 02:06:56PM +0200, Werner Sembach wrote: > Hello, > > In addition to the existing "max bpc", and "Broadcast RGB/output_csc" drm > properties I propose 4 new properties: > "preferred pixel encoding", "active color depth", "active color range", and > "active pixel encoding"

Re: [PATCH 6/7] drm/i915/ttm, drm/ttm: Introduce a TTM i915 gem object backend

2021-05-12 Thread Christian König
Am 12.05.21 um 15:02 schrieb Thomas Hellström: On Wed, 2021-05-12 at 09:09 +0200, Christian König wrote: Am 12.05.21 um 09:05 schrieb Thomas Hellström: On Wed, 2021-05-12 at 08:57 +0200, Christian König wrote: Am 11.05.21 um 16:28 schrieb Thomas Hellström: On 5/11/21 4:09 PM, Christian König

Re: New uAPI for color management proposal and feedback request

2021-05-12 Thread Simon Ser
On Wednesday, May 12th, 2021 at 3:04 PM, Ville Syrjälä wrote: > > Adoption: > > > > A KDE dev wants to implement the settings in the KDE settings GUI: > > > > https://gitlab.freedesktop.org/drm/amd/-/issues/476#note_912370 > > > > Tuxedo Computers (my employer) wants to implement the settings de

[PATCH 2/2] drm: panel-orientation-quirks: Add quirk for KD Kurio Smart C15200 2-in-1

2021-05-12 Thread Hans de Goede
The KD Kurio Smart C15200 2-in-1 uses a panel which has been mounted 90 degrees rotated. Add a quirk for this. Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.

[PATCH 0/2] drm: panel-orientation-quirks: Update / Add 2 quirks

2021-05-12 Thread Hans de Goede
Hi All, The first patch in this series is a resend of one which I submitted a couple of days ago, the other patch is new. These are pretty simple/straightforward patches if someone can give me a quick ack for these then I can push them to drm-misc-next. Regards, Hans Hans de Goede (2): drm:

[PATCH 1/2] drm: panel-orientation-quirks: Update the Lenovo Ideapad D330 quirk (v2)

2021-05-12 Thread Hans de Goede
2 improvements to the Lenovo Ideapad D330 panel-orientation quirks: 1. Some versions of the Lenovo Ideapad D330 have a DMI_PRODUCT_NAME of "81H3" and others have "81MD". Testing has shown that the "81MD" also has a 90 degree mounted panel. Drop the DMI_PRODUCT_NAME from the existing quirk so that

Re: [PATCH 6/7] drm/i915/ttm, drm/ttm: Introduce a TTM i915 gem object backend

2021-05-12 Thread Thomas Hellström
On 5/12/21 3:05 PM, Christian König wrote: Am 12.05.21 um 15:02 schrieb Thomas Hellström: On Wed, 2021-05-12 at 09:09 +0200, Christian König wrote: Am 12.05.21 um 09:05 schrieb Thomas Hellström: On Wed, 2021-05-12 at 08:57 +0200, Christian König wrote: Am 11.05.21 um 16:28 schrieb Thomas He

[GIT PULL] drm/imx: fixes, dma-fence annotation, and color encoding/range plane properties

2021-05-12 Thread Philipp Zabel
Hi Dave, Daniel, The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5: Linux 5.13-rc1 (2021-05-09 14:17:44 -0700) are available in the Git repository at: git://git.pengutronix.de/git/pza/linux.git tags/imx-drm-next-2021-05-12 for you to fetch changes up to fc1e985b67

Re: [PATCH v5 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver

2021-05-12 Thread Kevin Tang
Maxime Ripard 于2021年4月30日周五 下午5:35写道: > > Hi, > > On Sun, Apr 25, 2021 at 08:36:07PM +0800, Kevin Tang wrote: > > Adds dsi host controller support for the Unisoc's display subsystem. > > Adds dsi phy support for the Unisoc's display subsystem. > > Only MIPI DSI Displays supported, DP/TV/HMDI will

Re: [PATCH v6 10/16] drm/amdgpu: Guard against write accesses after device removal

2021-05-12 Thread Andrey Grodzovsky
Ping - need a confirmation it's ok to keep this as a single patch given my explanation bellow. Andrey On 2021-05-11 1:52 p.m., Andrey Grodzovsky wrote: On 2021-05-11 2:50 a.m., Christian König wrote: Am 10.05.21 um 18:36 schrieb Andrey Grodzovsky: This should prevent writing to memory or IO

Re: [PATCH v6 10/16] drm/amdgpu: Guard against write accesses after device removal

2021-05-12 Thread Christian König
Am 12.05.21 um 16:01 schrieb Andrey Grodzovsky: Ping - need a confirmation it's ok to keep this as a single patch given my explanation bellow. It was just an suggestion. Key point is the approach sounds sane to me, but I can't say much about the psp code for example. So maximum I can give yo

Re: [PATCH v6 10/16] drm/amdgpu: Guard against write accesses after device removal

2021-05-12 Thread Andrey Grodzovsky
Hopefyllu Alex can chime in on this. I will respin V7 soon. Andrey On 2021-05-12 10:06 a.m., Christian König wrote: Am 12.05.21 um 16:01 schrieb Andrey Grodzovsky: Ping - need a confirmation it's ok to keep this as a single patch given my explanation bellow. It was just an suggestion. Key po

Re: [PATCH v2 00/40] Use ASCII subset instead of UTF-8 alternate symbols

2021-05-12 Thread Theodore Ts'o
On Wed, May 12, 2021 at 02:50:04PM +0200, Mauro Carvalho Chehab wrote: > v2: > - removed EM/EN DASH conversion from this patchset; Are you still thinking about doing the EN DASH --> "--" EM DASH --> "---" conversion? That's not going to change what the documentation will look like in the HTML a

[PULL] drm-misc-next

2021-05-12 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the first PR for drm-misc-next for what will go into v5.14. Some noteable changes are * consistency between the plane formats and allow_fb_modifiers in UAPI, * overlay support in vkms, * proper HDR support in vc4, * SVGA3 support in vmwgfx, * many TTM fixes and a d

[PATCH v7 00/16] RFC Support hot device unplug in amdgpu

2021-05-12 Thread Andrey Grodzovsky
Until now extracting a card either by physical extraction (e.g. eGPU with thunderbolt connection or by emulation through  sysfs -> /sys/bus/pci/devices/device_id/remove) would cause random crashes in user apps. The random crashes in apps were mostly due to the app having mapped a device backed

[PATCH v7 01/16] drm/ttm: Remap all page faults to per process dummy page.

2021-05-12 Thread Andrey Grodzovsky
On device removal reroute all CPU mappings to dummy page. v3: Remove loop to find DRM file and instead access it by vma->vm_file->private_data. Move dummy page installation into a separate function. v4: Map the entire BOs VA space into on demand allocated dummy page on the first fault for that BO

[PATCH v7 03/16] drm/amdkfd: Split kfd suspend from device exit

2021-05-12 Thread Andrey Grodzovsky
Helps to expdite HW related stuff to amdgpu_pci_remove Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_device.c| 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-)

[PATCH v7 02/16] drm/amdgpu: Split amdgpu_device_fini into early and late

2021-05-12 Thread Andrey Grodzovsky
Some of the stuff in amdgpu_device_fini such as HW interrupts disable and pending fences finilization must be done right away on pci_remove while most of the stuff which relates to finilizing and releasing driver data structures can be kept until drm_driver.release hook is called, i.e. when the las

[PATCH v7 04/16] drm/amdgpu: Add early fini callback

2021-05-12 Thread Andrey Grodzovsky
Use it to call disply code dependent on device->drv_data before it's set to NULL on device unplug v5: Move HW finilization into this callback to prevent MMIO accesses post cpi remove. Signed-off-by: Andrey Grodzovsky Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

[PATCH v7 05/16] drm/amdgpu: Handle IOMMU enabled case.

2021-05-12 Thread Andrey Grodzovsky
Handle all DMA IOMMU gropup related dependencies before the group is removed. v5: Drop IOMMU notifier and switch to lockless call to ttm_tt_unpopulate v6: Drop the BO unamp list v7: Drop amdgpu_gart_fini In amdgpu_ih_ring_fini do uncinditional check (!ih->ring) to avoid freeing uniniitalized ring

[PATCH v7 06/16] drm/amdgpu: Remap all page faults to per process dummy page.

2021-05-12 Thread Andrey Grodzovsky
On device removal reroute all CPU mappings to dummy page per drm_file instance or imported GEM object. v4: Update for modified ttm_bo_vm_dummy_page Signed-off-by: Andrey Grodzovsky Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 21 - 1 file chang

[PATCH v7 07/16] PCI: Add support for dev_groups to struct pci_driver

2021-05-12 Thread Andrey Grodzovsky
This helps converting PCI drivers sysfs attributes to static. Analogous to' commit b71b283e3d6d ("USB: add support for dev_groups to struct usb_driver")' Signed-off-by: Andrey Grodzovsky Suggested-by: Greg Kroah-Hartman Acked-by: Bjorn Helgaas --- drivers/pci/pci-driver.c | 1 + include/linux

[PATCH v7 08/16] drm/amdgpu: Convert driver sysfs attributes to static attributes

2021-05-12 Thread Andrey Grodzovsky
This allows to remove explicit creation and destruction of those attrs and by this avoids warnings on device finalizing post physical device extraction. v5: Use newly added pci_driver.dev_groups directly Signed-off-by: Andrey Grodzovsky Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/

[PATCH v7 09/16] drm/amdgpu: Guard against write accesses after device removal

2021-05-12 Thread Andrey Grodzovsky
This should prevent writing to memory or IO ranges possibly already allocated for other uses after our device is removed. v5: Protect more places wher memcopy_to/form_io takes place Protect IB submissions v6: Switch to !drm_dev_enter instead of scoping entire code with brackets. v7: Drop guard o

[PATCH v7 11/16] drm/amdgpu: Prevent any job recoveries after device is unplugged.

2021-05-12 Thread Andrey Grodzovsky
Return DRM_TASK_STATUS_ENODEV back to the scheduler when device is not present so they timeout timer will not be rearmed. v5: Update to match updated return values in enum drm_gpu_sched_stat Signed-off-by: Andrey Grodzovsky Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_job

[PATCH v7 10/16] drm/sched: Make timeout timer rearm conditional.

2021-05-12 Thread Andrey Grodzovsky
We don't want to rearm the timer if driver hook reports that the device is gone. v5: Update drm_gpu_sched_stat values in code. Signed-off-by: Andrey Grodzovsky Reviewed-by: Christian König --- drivers/gpu/drm/scheduler/sched_main.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions

[PATCH v7 13/16] drm/scheduler: Fix hang when sched_entity released

2021-05-12 Thread Andrey Grodzovsky
Problem: If scheduler is already stopped by the time sched_entity is released and entity's job_queue not empty I encountred a hang in drm_sched_entity_flush. This is because drm_sched_entity_is_idle never becomes false. Fix: In drm_sched_fini detach all sched_entities from the scheduler's run queu

[PATCH v7 15/16] drm/amdgpu: Verify DMA opearations from device are done

2021-05-12 Thread Andrey Grodzovsky
In case device remove is just simualted by sysfs then verify device doesn't keep doing DMA to the released memory after pci_remove is done. Signed-off-by: Andrey Grodzovsky Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ++ 1 file changed, 6 insertions(+) diff --

[PATCH v7 12/16] drm/amdgpu: Fix hang on device removal.

2021-05-12 Thread Andrey Grodzovsky
If removing while commands in flight you cannot wait to flush the HW fences on a ring since the device is gone. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH v7 16/16] drm/amdgpu: Unmap all MMIO mappings

2021-05-12 Thread Andrey Grodzovsky
Access to those must be prevented post pci_remove v6: Drop BOs list, unampping VRAM BAR is enough. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 24 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_tt

[PATCH v7 14/16] drm/amd/display: Remove superfluous drm_mode_config_cleanup

2021-05-12 Thread Andrey Grodzovsky
It's already being released by DRM core through devm Signed-off-by: Andrey Grodzovsky Reviewed-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/d

Re: New uAPI for color management proposal and feedback request

2021-05-12 Thread Werner Sembach
Am 12.05.21 um 14:06 schrieb Werner Sembach: > Hello, > > In addition to the existing "max bpc", and "Broadcast RGB/output_csc" drm > properties I propose 4 new properties: > "preferred pixel encoding", "active color depth", "active color range", and > "active pixel encoding" > > > Motivation: >

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-12 Thread Rob Clark
On Wed, May 12, 2021 at 1:23 AM Pekka Paalanen wrote: > > On Tue, 11 May 2021 18:44:17 +0200 > Daniel Vetter wrote: > > > On Mon, May 10, 2021 at 12:06:05PM -0700, Rob Clark wrote: > > > On Mon, May 10, 2021 at 10:44 AM Daniel Vetter wrote: > > > > > > > > On Mon, May 10, 2021 at 6:51 PM Rob Cla

[PATCH 5.10 015/530] drm: bridge: fix LONTIUM use of mipi_dsi_() functions

2021-05-12 Thread Greg Kroah-Hartman
From: Randy Dunlap commit ad085b3a712a89e4a48472121b231add7a8362e4 upstream. The Lontium DRM bridge drivers use mipi_dsi_() function interfaces so they need to select DRM_MIPI_DSI to prevent build errors. ERROR: modpost: "mipi_dsi_attach" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined

[PATCH 5.10 278/530] drm/stm: Fix bus_flags handling

2021-05-12 Thread Greg Kroah-Hartman
From: Marek Vasut [ Upstream commit 99e360442f223dd40fc23ae07c7a263836fd27e6 ] The drm_display_mode_to_videomode() does not populate DISPLAY_FLAGS_DE_LOW or DISPLAY_FLAGS_PIXDATA_NEGEDGE flags in struct videomode. Therefore, no matter what polarity the next bridge or display might require, these

Re: [PATCH v2 00/40] Use ASCII subset instead of UTF-8 alternate symbols

2021-05-12 Thread Mauro Carvalho Chehab
Em Wed, 12 May 2021 10:14:44 -0400 "Theodore Ts'o" escreveu: > On Wed, May 12, 2021 at 02:50:04PM +0200, Mauro Carvalho Chehab wrote: > > v2: > > - removed EM/EN DASH conversion from this patchset; > > Are you still thinking about doing the > > EN DASH --> "--" > EM DASH --> "---" > > conver

[PATCH v7 3/4] mfd: rt4831: Adds DT binding document for Richtek RT4831

2021-05-12 Thread cy_huang
From: ChiYuan Huang Adds DT binding document for Richtek RT4831. Signed-off-by: ChiYuan Huang Reviewed-by: Rob Herring --- .../devicetree/bindings/mfd/richtek,rt4831.yaml| 90 ++ 1 file changed, 90 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd

[PATCH v7 4/4] backlight: rt4831: Adds support for Richtek RT4831 backlight

2021-05-12 Thread cy_huang
From: ChiYuan Huang Adds support for Richtek RT4831 backlight. Signed-off-by: ChiYuan Huang Reviewed-by: Daniel Thompson --- since v7 - Fix typo 'common' to 'commonly' in Kconfig description. --- drivers/video/backlight/Kconfig| 8 ++ drivers/video/backlight/Makefile |

[PATCH v7 1/4] mfd: rt4831: Adds support for Richtek RT4831

2021-05-12 Thread cy_huang
From: ChiYuan Huang This adds support Richtek RT4831 core. It includes four channel WLED driver and Display Bias Voltage outputs. Signed-off-by: ChiYuan Huang --- The RT4831 regulator patches are already on main stream, and can be referred to 9351ab8b0cb6 regulator: rt4831: Adds support for Ric

[PATCH v7 2/4] backlight: rt4831: Adds DT binding document for Richtek RT4831 backlight

2021-05-12 Thread cy_huang
From: ChiYuan Huang Adds DT binding document for Richtek RT4831 backlight. Signed-off-by: ChiYuan Huang Reviewed-by: Daniel Thompson --- since v7 - Add allOf property refer to common.yaml. - Remove default-brightness/max-brightness description and refer string. --- .../leds/backlight/richtek,

Re: [PATCH -next] drm/panfrost: Fix PM reference leak in panfrost_job_hw_submit()

2021-05-12 Thread Steven Price
On 11/05/2021 07:29, Zou Wei wrote: pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by

[PATCH] drm/panfrost: Handle failure in panfrost_job_hw_submit()

2021-05-12 Thread Steven Price
Currently panfrost_job_hw_submit() returns void and therefore cannot propagate failures to it's caller, which is a shame because it has two failure paths. Currently these are handled by waiting for a job timeout on the job even though it was never submitted. But we can do better. Refactor to retur

[PATCH 5.11 015/601] drm: bridge: fix LONTIUM use of mipi_dsi_() functions

2021-05-12 Thread Greg Kroah-Hartman
From: Randy Dunlap commit ad085b3a712a89e4a48472121b231add7a8362e4 upstream. The Lontium DRM bridge drivers use mipi_dsi_() function interfaces so they need to select DRM_MIPI_DSI to prevent build errors. ERROR: modpost: "mipi_dsi_attach" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined

[PATCH 5.11 069/601] drm: bridge: fix ANX7625 use of mipi_dsi_() functions

2021-05-12 Thread Greg Kroah-Hartman
From: Randy Dunlap commit ed01fca38717169fcb61bd45ad1c3750d9c40d59 upstream. The Analogix DRM ANX7625 bridge driver uses mips_dsi_() function interfaces so it should select DRM_MIPI_DSI to prevent build errors. ERROR: modpost: "mipi_dsi_attach" [drivers/gpu/drm/bridge/analogix/anx7625.ko] unde

Re: [PATCH 1/1] drm/panfrost: Remove redundant error printing in panfrost_device_init()

2021-05-12 Thread Steven Price
On 11/05/2021 10:04, Zhen Lei wrote: When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printi

[PATCH 5.11 308/601] drm/stm: Fix bus_flags handling

2021-05-12 Thread Greg Kroah-Hartman
From: Marek Vasut [ Upstream commit 99e360442f223dd40fc23ae07c7a263836fd27e6 ] The drm_display_mode_to_videomode() does not populate DISPLAY_FLAGS_DE_LOW or DISPLAY_FLAGS_PIXDATA_NEGEDGE flags in struct videomode. Therefore, no matter what polarity the next bridge or display might require, these

[PATCH 5.12 019/677] drm: bridge: fix LONTIUM use of mipi_dsi_() functions

2021-05-12 Thread Greg Kroah-Hartman
From: Randy Dunlap commit ad085b3a712a89e4a48472121b231add7a8362e4 upstream. The Lontium DRM bridge drivers use mipi_dsi_() function interfaces so they need to select DRM_MIPI_DSI to prevent build errors. ERROR: modpost: "mipi_dsi_attach" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined

[PATCH 5.12 078/677] drm: bridge: fix ANX7625 use of mipi_dsi_() functions

2021-05-12 Thread Greg Kroah-Hartman
From: Randy Dunlap commit ed01fca38717169fcb61bd45ad1c3750d9c40d59 upstream. The Analogix DRM ANX7625 bridge driver uses mips_dsi_() function interfaces so it should select DRM_MIPI_DSI to prevent build errors. ERROR: modpost: "mipi_dsi_attach" [drivers/gpu/drm/bridge/analogix/anx7625.ko] unde

[PATCH 5.12 342/677] drm/stm: Fix bus_flags handling

2021-05-12 Thread Greg Kroah-Hartman
From: Marek Vasut [ Upstream commit 99e360442f223dd40fc23ae07c7a263836fd27e6 ] The drm_display_mode_to_videomode() does not populate DISPLAY_FLAGS_DE_LOW or DISPLAY_FLAGS_PIXDATA_NEGEDGE flags in struct videomode. Therefore, no matter what polarity the next bridge or display might require, these

[PATCH RESEND] video: ssd1307fb: Enable charge pump only on displays that actually have it

2021-05-12 Thread Michal Vokáč
A note in the datasheet says: "Patterns other than those given in the Command Table are prohibited to enter the chip as a command; as unexpected results can occur." So do not send the charge pump command to displays that do not support it. Signed-off-by: Michal Vokáč --- drivers/video/fbdev

Re: [5.12 regression] ttm->pages NULL dereference with radeon driver

2021-05-12 Thread Dennis Foster
Hi Christian, I can confirm that the patch provided fixes the issue in kernel version 5.12.2 Thank you. On Wed, May 12, 2021 at 6:21 AM Christian König wrote: > > Hi guys, > > adding a few people who ran into the problem as well and opened a kernel > bug. > > Am 07.05.21 um 17:11 schrieb Christ

Re: [PATCH v2 00/40] Use ASCII subset instead of UTF-8 alternate symbols

2021-05-12 Thread David Woodhouse
Your title 'Use ASCII subset' is now at least a bit *closer* to describing what the patches are actually doing, but it's still a bit misleading because you're only doing it for *some* characters. And the wording is still indicative of a fundamentally *misguided* motivation for doing any of this. Y

Re: [PATCH v2 00/40] Use ASCII subset instead of UTF-8 alternate symbols

2021-05-12 Thread David Woodhouse
On Wed, 2021-05-12 at 17:17 +0200, Mauro Carvalho Chehab wrote: > Em Wed, 12 May 2021 10:14:44 -0400 > "Theodore Ts'o" escreveu: > > > On Wed, May 12, 2021 at 02:50:04PM +0200, Mauro Carvalho Chehab wrote: > > > v2: > > > - removed EM/EN DASH conversion from this patchset; > > > > Are you stil

Re: New uAPI for color management proposal and feedback request

2021-05-12 Thread Alex Deucher
On Wed, May 12, 2021 at 9:04 AM Ville Syrjälä wrote: > > On Wed, May 12, 2021 at 02:06:56PM +0200, Werner Sembach wrote: > > Hello, > > > > In addition to the existing "max bpc", and "Broadcast RGB/output_csc" drm > > properties I propose 4 new properties: > > "preferred pixel encoding", "active

[PATCH AUTOSEL 5.12 27/37] amdgpu/pm: Prevent force of DCEFCLK on NAVI10 and SIENNA_CICHLID

2021-05-12 Thread Sasha Levin
From: Darren Powell [ Upstream commit b117b3964f38a988cb79825950dbd607c02237f3 ] Writing to dcefclk causes the gpu to become unresponsive, and requires a reboot. Patch ignores a .force_clk_levels(SMU_DCEFCLK) call and issues an info message. Signed-off-by: Darren Powell Reviewed-by: Kenneth Fe

[PATCH AUTOSEL 5.12 31/37] drm/amd/display: Fix two cursor duplication when using overlay

2021-05-12 Thread Sasha Levin
From: Rodrigo Siqueira [ Upstream commit 16e9b3e58bc3fce7391539e0eb3fd167cbf9951f ] Our driver supports overlay planes, and as expected, some userspace compositor takes advantage of these features. If the userspace is not enabling the cursor, they can use multiple planes as they please. Neverthe

[PATCH AUTOSEL 5.11 25/35] amdgpu/pm: Prevent force of DCEFCLK on NAVI10 and SIENNA_CICHLID

2021-05-12 Thread Sasha Levin
From: Darren Powell [ Upstream commit b117b3964f38a988cb79825950dbd607c02237f3 ] Writing to dcefclk causes the gpu to become unresponsive, and requires a reboot. Patch ignores a .force_clk_levels(SMU_DCEFCLK) call and issues an info message. Signed-off-by: Darren Powell Reviewed-by: Kenneth Fe

[PATCH AUTOSEL 5.11 29/35] drm/amd/display: Fix two cursor duplication when using overlay

2021-05-12 Thread Sasha Levin
From: Rodrigo Siqueira [ Upstream commit 16e9b3e58bc3fce7391539e0eb3fd167cbf9951f ] Our driver supports overlay planes, and as expected, some userspace compositor takes advantage of these features. If the userspace is not enabling the cursor, they can use multiple planes as they please. Neverthe

[PATCH AUTOSEL 5.10 24/34] amdgpu/pm: Prevent force of DCEFCLK on NAVI10 and SIENNA_CICHLID

2021-05-12 Thread Sasha Levin
From: Darren Powell [ Upstream commit b117b3964f38a988cb79825950dbd607c02237f3 ] Writing to dcefclk causes the gpu to become unresponsive, and requires a reboot. Patch ignores a .force_clk_levels(SMU_DCEFCLK) call and issues an info message. Signed-off-by: Darren Powell Reviewed-by: Kenneth Fe

[PATCH AUTOSEL 5.10 28/34] drm/amd/display: Fix two cursor duplication when using overlay

2021-05-12 Thread Sasha Levin
From: Rodrigo Siqueira [ Upstream commit 16e9b3e58bc3fce7391539e0eb3fd167cbf9951f ] Our driver supports overlay planes, and as expected, some userspace compositor takes advantage of these features. If the userspace is not enabling the cursor, they can use multiple planes as they please. Neverthe

[PATCH AUTOSEL 5.4 18/23] drm/amd/display: Fix two cursor duplication when using overlay

2021-05-12 Thread Sasha Levin
From: Rodrigo Siqueira [ Upstream commit 16e9b3e58bc3fce7391539e0eb3fd167cbf9951f ] Our driver supports overlay planes, and as expected, some userspace compositor takes advantage of these features. If the userspace is not enabling the cursor, they can use multiple planes as they please. Neverthe

[PATCH] drm/nouveau: Remove invalid reference to struct drm_device.pdev

2021-05-12 Thread Thomas Zimmermann
The pdev field got removed from struct drm_device recently. Replace the invalid reference with an upcast from the struct's dev field. Signed-off-by: Thomas Zimmermann Reported-by: Stephen Rothwell Fixes: b347e04452ff ("drm: Remove pdev field from struct drm_device") Cc: Thomas Zimmermann Cc: Ma

  1   2   >