[PATCH v6 15/16] drm/amd/display: Remove superflous drm_mode_config_cleanup

2021-05-10 Thread Andrey Grodzovsky
It's already being released by DRM core through devm Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c in

[PATCH v6 03/16] drm/amdgpu: Split amdgpu_device_fini into early and late

2021-05-10 Thread Andrey Grodzovsky
Some of the stuff in amdgpu_device_fini such as HW interrupts disable and pending fences finilization must be done right away on pci_remove while most of the stuff which relates to finilizing and releasing driver data structures can be kept until drm_driver.release hook is called, i.e. when the las

[PATCH v6 04/16] drm/amdkfd: Split kfd suspend from devie exit

2021-05-10 Thread Andrey Grodzovsky
Helps to expdite HW related stuff to amdgpu_pci_remove Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_device.c| 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-)

[PATCH v6 06/16] drm/amdgpu: Handle IOMMU enabled case.

2021-05-10 Thread Andrey Grodzovsky
Handle all DMA IOMMU gropup related dependencies before the group is removed. v5: Drop IOMMU notifier and switch to lockless call to ttm_tt_unpopulate v6: Drop the BO unamp list Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/

[PATCH v6 08/16] PCI: Add support for dev_groups to struct pci_device_driver

2021-05-10 Thread Andrey Grodzovsky
This helps converting PCI drivers sysfs attributes to static. Analogous to b71b283e3d6d ("USB: add support for dev_groups to struct usb_driver") Signed-off-by: Andrey Grodzovsky Suggested-by: Greg Kroah-Hartman --- drivers/pci/pci-driver.c | 1 + include/linux/pci.h | 3 +++ 2 files chang

[PATCH v6 07/16] drm/amdgpu: Remap all page faults to per process dummy page.

2021-05-10 Thread Andrey Grodzovsky
On device removal reroute all CPU mappings to dummy page per drm_file instance or imported GEM object. v4: Update for modified ttm_bo_vm_dummy_page Signed-off-by: Andrey Grodzovsky Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 21 - 1 file chang

[PATCH v6 09/16] drm/amdgpu: Convert driver sysfs attributes to static attributes

2021-05-10 Thread Andrey Grodzovsky
This allows to remove explicit creation and destruction of those attrs and by this avoids warnings on device finalizing post physical device extraction. v5: Use newly added pci_driver.dev_groups directly Signed-off-by: Andrey Grodzovsky Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/

[PATCH v6 11/16] drm/sched: Make timeout timer rearm conditional.

2021-05-10 Thread Andrey Grodzovsky
We don't want to rearm the timer if driver hook reports that the device is gone. v5: Update drm_gpu_sched_stat values in code. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/scheduler/sched_main.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/

[PATCH v6 12/16] drm/amdgpu: Prevent any job recoveries after device is unplugged.

2021-05-10 Thread Andrey Grodzovsky
Return DRM_TASK_STATUS_ENODEV back to the scheduler when device is not present so they timeout timer will not be rearmed. v5: Update to match updated return values in enum drm_gpu_sched_stat Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 19 --- 1

[PATCH v6 13/16] drm/amdgpu: Fix hang on device removal.

2021-05-10 Thread Andrey Grodzovsky
If removing while commands in flight you cannot wait to flush the HW fences on a ring since the device is gone. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH v6 10/16] drm/amdgpu: Guard against write accesses after device removal

2021-05-10 Thread Andrey Grodzovsky
This should prevent writing to memory or IO ranges possibly already allocated for other uses after our device is removed. v5: Protect more places wher memcopy_to/form_io takes place Protect IB submissions v6: Switch to !drm_dev_enter instead of scoping entire code with brackets. Signed-off-by: A

[PATCH v6 14/16] drm/scheduler: Fix hang when sched_entity released

2021-05-10 Thread Andrey Grodzovsky
Problem: If scheduler is already stopped by the time sched_entity is released and entity's job_queue not empty I encountred a hang in drm_sched_entity_flush. This is because drm_sched_entity_is_idle never becomes false. Fix: In drm_sched_fini detach all sched_entities from the scheduler's run queu

[PATCH v6 16/16] drm/amdgpu: Verify DMA opearations from device are done

2021-05-10 Thread Andrey Grodzovsky
In case device remove is just simualted by sysfs then verify device doesn't keep doing DMA to the released memory after pci_remove is done. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/a

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-10 Thread Rob Clark
On Mon, May 10, 2021 at 9:14 AM Daniel Vetter wrote: > > On Sat, May 08, 2021 at 12:56:38PM -0700, Rob Clark wrote: > > From: Rob Clark > > > > drm_atomic_helper_dirtyfb() will end up stalling for vblank on "video > > mode" type displays, which is pointless and unnecessary. Add an > > optional h

Re: [PATCH v2 1/1] drm/msm/dpu: Fix error return code in dpu_mdss_init()

2021-05-10 Thread Stephen Boyd
Quoting Zhen Lei (2021-05-09 23:38:05) > The error code returned by platform_get_irq() is stored in 'irq', it's > forgotten to be copied to 'ret' before being returned. As a result, the > value 0 of 'ret' is returned incorrectly. > > After the above fix is completed, initializing the local variable

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-10 Thread Daniel Vetter
On Mon, May 10, 2021 at 6:51 PM Rob Clark wrote: > > On Mon, May 10, 2021 at 9:14 AM Daniel Vetter wrote: > > > > On Sat, May 08, 2021 at 12:56:38PM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > drm_atomic_helper_dirtyfb() will end up stalling for vblank on "video > > > mode" type di

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-10 Thread Stephen Boyd
Quoting Daniel Vetter (2021-05-10 09:05:21) > On Sat, May 08, 2021 at 12:41:18AM -0700, Stephen Boyd wrote: > > The device lists are poorly ordered when the component device code is > > used. This is because component_master_add_with_match() returns 0 > > regardless of component devices calling com

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-10 Thread Dave Stevenson
On Mon, 10 May 2021 at 12:16, Marek Vasut wrote: > > On 5/10/21 11:58 AM, Dave Stevenson wrote: > > On Sat, 8 May 2021 at 21:26, Marek Vasut wrote: > >> > >> On 5/7/21 2:48 PM, Dave Stevenson wrote: > >> > >> [...] > >> > +static void sn65dsi83_enable(struct drm_bridge *bridge) > +{ > >

Re: [RFC] Implicit vs explicit user fence sync

2021-05-10 Thread Christian König
Am 04.05.21 um 17:11 schrieb Daniel Vetter: On Tue, May 04, 2021 at 04:26:42PM +0200, Christian König wrote: Hi Daniel, Am 04.05.21 um 16:15 schrieb Daniel Vetter: Hi Christian, On Tue, May 04, 2021 at 03:27:17PM +0200, Christian König wrote: Hi guys, with this patch set I want to look into

Re: [PULL] topic/iomem-mmap-vs-gup

2021-05-10 Thread Paolo Bonzini
On 10/05/21 19:57, Sean Christopherson wrote: +Paolo On Mon, May 10, 2021, Jason Gunthorpe wrote: On Mon, May 10, 2021 at 04:55:39PM +0200, Daniel Vetter wrote: yeah vfio is still broken for the case I care about. I think there's also some questions open still about whether kvm really uses mm

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-10 Thread Daniel Vetter
On Mon, May 10, 2021 at 7:52 PM Stephen Boyd wrote: > > Quoting Daniel Vetter (2021-05-10 09:05:21) > > On Sat, May 08, 2021 at 12:41:18AM -0700, Stephen Boyd wrote: > > > The device lists are poorly ordered when the component device code is > > > used. This is because component_master_add_with_ma

Re: [PATCH v6 02/16] drm/ttm: Expose ttm_tt_unpopulate for driver use

2021-05-10 Thread Felix Kuehling
Am 2021-05-10 um 12:36 p.m. schrieb Andrey Grodzovsky: > It's needed to drop iommu backed pages on device unplug > before device's IOMMU group is released. I don't see any calls to ttm_tt_unpopulate in the rest of the series now. Is that an accident, or can this patch be dropped? Regards,   Felix

Re: [PATCH v6 02/16] drm/ttm: Expose ttm_tt_unpopulate for driver use

2021-05-10 Thread Andrey Grodzovsky
On 2021-05-10 2:27 p.m., Felix Kuehling wrote: Am 2021-05-10 um 12:36 p.m. schrieb Andrey Grodzovsky: It's needed to drop iommu backed pages on device unplug before device's IOMMU group is released. I don't see any calls to ttm_tt_unpopulate in the rest of the series now. Is that an accident,

Re: [Intel-gfx] [RFC PATCH 00/97] Basic GuC submission support in the i915

2021-05-10 Thread Francisco Jerez
Daniel Vetter writes: > On Mon, May 10, 2021 at 3:55 PM Martin Peres wrote: >> >> On 10/05/2021 02:11, Jason Ekstrand wrote: >> > On May 9, 2021 12:12:36 Martin Peres wrote: >> > >> >> Hi, >> >> >> >> On 06/05/2021 22:13, Matthew Brost wrote: >> >>> Basic GuC submission support. This is the fir

Re: [PATCH] drm/dp: Fix bogus DPCD version check in drm_dp_read_downstream_info()

2021-05-10 Thread Ville Syrjälä
On Fri, May 07, 2021 at 05:42:09PM -0400, Lyude Paul wrote: > Ville pointed this out to me when fixing some issues in > drm_dp_read_downstream_info() - the DPCD version check here is bogus as > there's no DisplayPort versions prior to 1.0. The original code from i915 > that this was extracted from

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-10 Thread Rob Clark
On Mon, May 10, 2021 at 10:44 AM Daniel Vetter wrote: > > On Mon, May 10, 2021 at 6:51 PM Rob Clark wrote: > > > > On Mon, May 10, 2021 at 9:14 AM Daniel Vetter wrote: > > > > > > On Sat, May 08, 2021 at 12:56:38PM -0700, Rob Clark wrote: > > > > From: Rob Clark > > > > > > > > drm_atomic_helpe

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-10 Thread Stephen Boyd
Quoting Daniel Vetter (2021-05-10 11:26:40) > On Mon, May 10, 2021 at 7:52 PM Stephen Boyd wrote: > > The device list now has msm, i2c, bridge in that order. When we go to > > system wide shutdown the bridge is shutdown first, then the i2c bus, and > > then msm calls drm_atomic_helper_shutdown().

Re: [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

2021-05-10 Thread Theodore Ts'o
On Mon, May 10, 2021 at 02:49:44PM +0100, David Woodhouse wrote: > On Mon, 2021-05-10 at 13:55 +0200, Mauro Carvalho Chehab wrote: > > This patch series is doing conversion only when using ASCII makes > > more sense than using UTF-8. > > > > See, a number of converted documents ended with weird c

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-10 Thread Marek Vasut
On 5/10/21 8:04 PM, Dave Stevenson wrote: Hi, [...] +static void sn65dsi83_enable(struct drm_bridge *bridge) +{ + struct sn65dsi83 *ctx = bridge_to_sn65dsi83(bridge); + unsigned int pval; + u16 val; + int ret; + + /* Clear reset, disable PLL */ + regmap_write(

[PATCH] drm/amd/pm: Fix out-of-bounds bug

2021-05-10 Thread Gustavo A. R. Silva
Create new structure SISLANDS_SMC_SWSTATE_SINGLE, as initialState.levels and ACPIState.levels are never actually used as flexible arrays. Those arrays can be used as simple objects of type SISLANDS_SMC_HW_PERFORMANCE_LEVEL, instead. Currently, the code fails because flexible array _levels_ in stru

Re: [PATCH] drm/amd/display: remove unused function dc_link_perform_link_training

2021-05-10 Thread Alex Deucher
Applied. Thanks! Alex On Sun, May 9, 2021 at 11:42 AM Rouven Czerwinski wrote: > > This function is not used anywhere, remove it. It was added in > 40dd6bd376a4 ("drm/amd/display: Linux Set/Read link rate and lane count > through debugfs") and moved in fe798de53a7a ("drm/amd/display: Move link

Re: [PATCH v6 08/16] PCI: Add support for dev_groups to struct pci_device_driver

2021-05-10 Thread Bjorn Helgaas
In subject: PCI: Add support for dev_groups to struct pci_driver (not "struct pci_device_driver," which does not exist) On Mon, May 10, 2021 at 12:36:17PM -0400, Andrey Grodzovsky wrote: > This helps converting PCI drivers sysfs attributes to static. > > Analogous to b71b283e3d6d ("USB: add s

Re: [PATCH] drm/amd/amdgpu: Fix errors in function documentation

2021-05-10 Thread Alex Deucher
Applied. Thanks! Alex On Sun, May 9, 2021 at 12:30 PM Christian König wrote: > > Am 09.05.21 um 16:49 schrieb Dwaipayan Ray: > > Fix a couple of syntax errors and removed one excess > > parameter in the function documentations which lead > > to kernel docs build warning. > > > > Signed-off-by:

[Bug 213007] [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22)

2021-05-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213007 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

Re: [PATCH] drm/radeon/ni_dpm: Fix booting bug

2021-05-10 Thread Alex Deucher
On Sun, May 9, 2021 at 6:48 PM Gustavo A. R. Silva wrote: > > Create new structure NISLANDS_SMC_SWSTATE_SINGLE, as initialState.levels > and ACPIState.levels are never actually used as flexible arrays. Those > arrays can be used as simple objects of type > NISLANDS_SMC_HW_PERFORMANCE_LEVEL, instea

Re: [PATCH] drm/radeon/si_dpm: Fix SMU power state load

2021-05-10 Thread Alex Deucher
Applied. Thanks! Alex On Mon, May 10, 2021 at 1:51 AM Kai-Heng Feng wrote: > > On Mon, May 10, 2021 at 6:54 AM Gustavo A. R. Silva > wrote: > > > > Create new structure SISLANDS_SMC_SWSTATE_SINGLE, as initialState.levels > > and ACPIState.levels are never actually used as flexible arrays. Thos

Re: [PATCH] drm/amd/pm: Fix out-of-bounds bug

2021-05-10 Thread Alex Deucher
On Mon, May 10, 2021 at 4:45 PM Gustavo A. R. Silva wrote: > > Create new structure SISLANDS_SMC_SWSTATE_SINGLE, as initialState.levels > and ACPIState.levels are never actually used as flexible arrays. Those > arrays can be used as simple objects of type > SISLANDS_SMC_HW_PERFORMANCE_LEVEL, inste

Re: [PATCH 1/1] drm/amd/display: Delete several unneeded bool conversions

2021-05-10 Thread Alex Deucher
Applied. Thanks! Alex On Mon, May 10, 2021 at 8:16 AM Zhen Lei wrote: > > The result of an expression consisting of a single relational operator is > already of the bool type and does not need to be evaluated explicitly. > > No functional change. > > Signed-off-by: Zhen Lei > --- > drivers/gp

Re: [PATCH 1/1] drm/amdgpu: Delete two unneeded bool conversions

2021-05-10 Thread Alex Deucher
Applied. Thanks! Alex On Mon, May 10, 2021 at 8:24 AM Zhen Lei wrote: > > The result of an expression consisting of a single relational operator is > already of the bool type and does not need to be evaluated explicitly. > > No functional change. > > Signed-off-by: Zhen Lei > --- > drivers/gp

Re: [PATCH] drm/amd/display: remove unused function dc_link_perform_link_training

2021-05-10 Thread Rodrigo Siqueira
LGTM, Jay, any comment? Reviewed-by: Rodrigo Siqueira On 05/08, Rouven Czerwinski wrote: > This function is not used anywhere, remove it. It was added in > 40dd6bd376a4 ("drm/amd/display: Linux Set/Read link rate and lane count > through debugfs") and moved in fe798de53a7a ("drm/amd/display: Mo

Re: [PATCH v6 15/16] drm/amd/display: Remove superflous drm_mode_config_cleanup

2021-05-10 Thread Rodrigo Siqueira
lgtm, Reviewed-by: Rodrigo Siqueira On 05/10, Andrey Grodzovsky wrote: > It's already being released by DRM core through devm > > Signed-off-by: Andrey Grodzovsky > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm

Re: [PATCH] drm/amd/display: Expose active display color configurations to userspace

2021-05-10 Thread Alex Deucher
On Fri, May 7, 2021 at 3:27 PM Werner Sembach wrote: > > xrandr --prop and other userspace info tools have currently no way of > telling which color configuration is used on HDMI and DP ports. > > The ongoing transsition from HDMI 1.4 to 2.0 and the different bandwidth > requirements of YCbCr 4:2:

Re: [PATCH] drm/radeon/ni_dpm: Fix booting bug

2021-05-10 Thread Gustavo A. R. Silva
Hi Alex, On 5/10/21 16:17, Alex Deucher wrote: > On Sun, May 9, 2021 at 6:48 PM Gustavo A. R. Silva > wrote: [..] >> >> Bug: >> https://lore.kernel.org/dri-devel/3eedbe78-1fbd-4763-a7f3-ac5665e76...@xenosoft.de/ >> Fixes: 434fb1e7444a ("drm/radeon/nislands_smc.h: Replace one-element array >> w

RE: [PATCH v2 02/10] drm/amdgpu: Rename kfd_bo_va_list to kfd_mem_attachment

2021-05-10 Thread Errabolu, Ramesh
[AMD Official Use Only - Internal Distribution Only] Acked-by: Ramesh Errabolu -Original Message- From: amd-gfx On Behalf Of Kuehling, Felix Sent: Wednesday, April 21, 2021 8:31 PM To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: [PATCH v2 02/10] drm/amdgpu:

RE: [PATCH v2 03/10] drm/amdgpu: Keep a bo-reference per-attachment

2021-05-10 Thread Errabolu, Ramesh
[AMD Official Use Only - Internal Distribution Only] Acked-by: Ramesh Errabolu -Original Message- From: amd-gfx On Behalf Of Kuehling, Felix Sent: Wednesday, April 21, 2021 8:31 PM To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: [PATCH v2 03/10] drm/amdgpu:

RE: [PATCH v2 04/10] drm/amdgpu: Simplify AQL queue mapping

2021-05-10 Thread Errabolu, Ramesh
[AMD Official Use Only - Internal Distribution Only] Acked-by: Ramesh Errabolu -Original Message- From: amd-gfx On Behalf Of Kuehling, Felix Sent: Friday, April 23, 2021 2:23 AM To: Zeng, Oak ; amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 04/10

RE: [PATCH v2 05/10] drm/amdgpu: Add multi-GPU DMA mapping helpers

2021-05-10 Thread Errabolu, Ramesh
[AMD Official Use Only - Internal Distribution Only] Acked-by: Ramesh Errabolu -Original Message- From: amd-gfx On Behalf Of Kuehling, Felix Sent: Monday, April 26, 2021 10:41 PM To: Zeng, Oak ; amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 05/1

RE: [PATCH v2 06/10] drm/amdgpu: DMA map/unmap when updating GPU mappings

2021-05-10 Thread Errabolu, Ramesh
[AMD Official Use Only - Internal Distribution Only] Acked-by: Ramesh Errabolu -Original Message- From: amd-gfx On Behalf Of Kuehling, Felix Sent: Monday, April 26, 2021 10:48 PM To: Zeng, Oak ; amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 06/1

RE: [PATCH v2 07/10] drm/amdgpu: Move kfd_mem_attach outside reservation

2021-05-10 Thread Errabolu, Ramesh
[AMD Official Use Only - Internal Distribution Only] Acked-by: Ramesh Errabolu -Original Message- From: amd-gfx On Behalf Of Kuehling, Felix Sent: Wednesday, April 21, 2021 8:31 PM To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: [PATCH v2 07/10] drm/amdgpu:

RE: [PATCH v2 08/10] drm/amdgpu: Add DMA mapping of GTT BOs

2021-05-10 Thread Errabolu, Ramesh
[AMD Official Use Only - Internal Distribution Only] Acked-by: Ramesh Errabolu -Original Message- From: amd-gfx On Behalf Of Kuehling, Felix Sent: Tuesday, April 27, 2021 10:09 AM To: Zeng, Oak ; amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 08/

RE: [PATCH v2 09/10] drm/ttm: Don't count pages in SG BOs against pages_limit

2021-05-10 Thread Errabolu, Ramesh
[AMD Official Use Only - Internal Distribution Only] Acked-by: Ramesh Errabolu -Original Message- From: amd-gfx On Behalf Of Kuehling, Felix Sent: Wednesday, April 21, 2021 8:31 PM To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: [PATCH v2 09/10] drm/ttm: Don

RE: [PATCH v2 10/10] drm/amdgpu: Move dmabuf attach/detach to backend_(un)bind

2021-05-10 Thread Errabolu, Ramesh
[AMD Official Use Only - Internal Distribution Only] Acked-by: Ramesh Errabolu -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Thursday, April 22, 2021 6:20 AM To: Kuehling, Felix ; amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: Re: [PATCH

Re: [PATCH v2] drm: Declare drm_send_event_helper static.

2021-05-10 Thread Guenter Roeck
On Mon, May 10, 2021 at 06:46:16PM +0530, Rajat Asthana wrote: > Declare drm_send_event_helper as static to fix sparse warning: > > > warning: symbol 'drm_send_event_helper' was not declared. > > Should it be static? > > Signed-off-by: Rajat Asthana > --- > Changes in v2: > Provide full name

[PATCH v17 0/2] Add memory bandwidth management to NVIDIA Tegra DRM driver

2021-05-10 Thread Dmitry Osipenko
This series adds memory bandwidth management to the NVIDIA Tegra DRM driver, which is done using interconnect framework. It fixes display corruption that happens due to insufficient memory bandwidth. Changelog: v17: - No changes, re-sending for v5.14. v16: - Implemented suggestions that were giv

[PATCH v17 2/2] drm/tegra: dc: Extend debug stats with total number of events

2021-05-10 Thread Dmitry Osipenko
It's useful to know the total number of underflow events and currently the debug stats are getting reset each time CRTC is being disabled. Let's account the overall number of events that doesn't get a reset. Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/d

[PATCH v17 1/2] drm/tegra: dc: Support memory bandwidth management

2021-05-10 Thread Dmitry Osipenko
Display controller (DC) performs isochronous memory transfers, and thus, has a requirement for a minimum memory bandwidth that shall be fulfilled, otherwise framebuffer data can't be fetched fast enough and this results in a DC's data-FIFO underflow that follows by a visual corruption. The Memory

Re: [PATCH] drm/amd/display: remove unused function dc_link_perform_link_training

2021-05-10 Thread Aurabindo Pillai
On 2021-05-10 5:33 p.m., Rodrigo Siqueira wrote: LGTM, Jay, any comment? None, LGTM, and this applied already. Reviewed-by: Rodrigo Siqueira On 05/08, Rouven Czerwinski wrote: This function is not used anywhere, remove it. It was added in 40dd6bd376a4 ("drm/amd/display: Linux Set/Read

Re: [PATCH v6 03/16] drm/amdgpu: Split amdgpu_device_fini into early and late

2021-05-10 Thread kernel test robot
Hi Andrey, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.13-rc1 next-20210510] [cannot apply to pci/next drm/drm

[Bug 212959] [drm:dm_helpers_dp_write_dpcd [amdgpu]] *ERROR* Failed to find connector for link!

2021-05-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212959 --- Comment #3 from tob88...@gmail.com --- Created attachment 296713 --> https://bugzilla.kernel.org/attachment.cgi?id=296713&action=edit Dmesg output -- You may reply to this email to add a comment. You are receiving this mail because: You a

[Bug 212959] [drm:dm_helpers_dp_write_dpcd [amdgpu]] *ERROR* Failed to find connector for link!

2021-05-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212959 --- Comment #4 from tob88...@gmail.com --- (In reply to Alex Deucher from comment #2) > Please attach the dmesg output for your system. Other than the error, is > the GPU otherwise working correctly? The GPU otherwise is working correctly. On ot

[Bug 212959] [drm:dm_helpers_dp_write_dpcd [amdgpu]] *ERROR* Failed to find connector for link! - Exclusively an issue by booting from mounted ISOs of respective OS.

2021-05-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212959 tob88...@gmail.com changed: What|Removed |Added Summary|[drm:dm_helpers_dp_write_dp |[drm:dm_helpers_dp_write_dp

[Bug 212959] [drm:dm_helpers_dp_write_dpcd [amdgpu]] *ERROR* Failed to find connector for link! - Exclusively an issue by booting from mounted ISOs of respective OS.

2021-05-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212959 tob88...@gmail.com changed: What|Removed |Added Severity|blocking|normal -- You may reply to this ema

[PATCH RFC 0/3] Add virtio-gpu modifiers support

2021-05-10 Thread Tina Zhang
This patchset introduces the modifiers support to virtio-gpu. This RFC version tries to add a new virtio-gpu command to let front-end driver query the modifiers' info from the backend. Besides, the front-end driver may also need a new drm helper function to add the supported modifiers to a plane

[PATCH RFC 2/3] drm/virtio: Add modifier support

2021-05-10 Thread Tina Zhang
Add a command to get modifier info from the backend. Signed-off-by: Tina Zhang --- drivers/gpu/drm/virtio/virtgpu_drv.h | 3 ++ drivers/gpu/drm/virtio/virtgpu_kms.c | 3 ++ drivers/gpu/drm/virtio/virtgpu_plane.c | 16 ++ drivers/gpu/drm/virtio/virtgpu_vq.c| 42 +

[PATCH RFC 3/3] drm/virtio: Include modifier as part of set_scanout_blob

2021-05-10 Thread Tina Zhang
From: Vivek Kasireddy With new use-cases coming up that include virtio-gpu: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9592 the FB associated with a Guest blob may have a modifier. Therefore, this modifier info needs to be included as part of set_scanout_blob. v2: (Tina) * Use dr

[PATCH RFC 1/3] drm: Add drm_plane_add_modifiers()

2021-05-10 Thread Tina Zhang
Add a function to add modifiers to a plane. Signed-off-by: Tina Zhang --- drivers/gpu/drm/drm_plane.c | 41 + include/drm/drm_plane.h | 3 +++ 2 files changed, 44 insertions(+) diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index

[Bug 211875] CPU frequency scaling lost after "WARNING: CPU: 2 PID: 2358578 at smu8_send_msg_to_smc_with_parameter+0xfe/0x140 [amdgpu]"

2021-05-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211875 --- Comment #10 from Erhard F. (erhar...@mailbox.org) --- Created attachment 296715 --> https://bugzilla.kernel.org/attachment.cgi?id=296715&action=edit dmesg (kernel 5.13-rc1, A10-9700E) Some locking stacktrace on kernel v5.13-rc1 before the u

[Bug 211875] CPU frequency scaling lost after "WARNING: CPU: 2 PID: 2358578 at smu8_send_msg_to_smc_with_parameter+0xfe/0x140 [amdgpu]"

2021-05-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211875 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added Attachment #296147|0 |1 is obsolete|

Re: [RFC PATCH 00/97] Basic GuC submission support in the i915

2021-05-10 Thread Dixit, Ashutosh
On Sun, 09 May 2021 16:11:43 -0700, Jason Ekstrand wrote: > > Yes, landing GuC support may be the first step in removing execlist > support. The inevitable reality is that GPU scheduling is coming and > likely to be there only path in the not-too-distant future. (See also > the ongoing thread with

Re: [PATCH v2] drm/radeon/dpm: Disable sclk switching on Oland when two 4K 60Hz monitors are connected

2021-05-10 Thread Kai-Heng Feng
On Fri, Apr 30, 2021 at 12:57 PM Kai-Heng Feng wrote: > > Screen flickers rapidly when two 4K 60Hz monitors are in use. This issue > doesn't happen when one monitor is 4K 60Hz (pixelclock 594MHz) and > another one is 4K 30Hz (pixelclock 297MHz). > > The issue is gone after setting "power_dpm_force

Re: [PATCH v3] drm/i915: Invoke another _DSM to enable MUX on HP Workstation laptops

2021-05-10 Thread Kai-Heng Feng
On Mon, Apr 26, 2021 at 11:24 PM Kai-Heng Feng wrote: > > On HP Fury G7 Workstations, graphics output is re-routed from Intel GFX > to discrete GFX after S3. This is not desirable, because userspace will > treat connected display as a new one, losing display settings. > > The expected behavior is

[PATCH 0/4] drm/msm/dpu: Qualcomm SC8180x MDSS/DPU support

2021-05-10 Thread Bjorn Andersson
These patches adds MDSS and DPU support for the Qualcomm SC8180x platform. The platform supports running 2 pixels per pixel clock cycle and the bootloader enables this, so the first patch adds enough support to the DPU driver to disable this again. The second patch shoots down the data path confi

[PATCH 1/4] drm/msm/dpu: Introduce knowledge of widebus feature

2021-05-10 Thread Bjorn Andersson
Some hardware supports clocking 2 pixels per pixel clock pulse, known as "widebus". The configuration needs to match between the DPU and the interface controller, and the timing parameters must be adjusted. As a first step towards supporting this, start by adding a INTF mask flag to signal the tim

[PATCH 2/4] drm/msm/dpu: Clear boot loader configured data paths

2021-05-10 Thread Bjorn Andersson
It's typical for the bootloader to configure CTL_0 for the boot splash or EFIFB, but for non-DSI use cases the DPU driver tend to pick another CTL and the system might end up with two configured data paths producing data on the same INTF - with resulting graphical artifacts. Naturally the end goal

[PATCH 4/4] dpu: hack up the irq table for 8180 intf_5

2021-05-10 Thread Bjorn Andersson
Signed-off-by: Bjorn Andersson --- This is a hack and as discussed on IRC this should be replaced by some sane mechanism for dealing with the old and new IRQ layout. Including it in the series for completeness. drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 14 ++ 1 file change

[PATCH 3/4] drm/msm/dpu: Add SC8180x to hw catalog

2021-05-10 Thread Bjorn Andersson
From: Rob Clark Add SC8180x to the hardware catalog, for initial support for the platform. Due to limitations in the DP driver only one of the four DP interfaces is left enabled. The SC8180x platform supports the newly added DPU_INTF_WIDEBUS flag and the Windows-on-Snapdragon bootloader leaves t

[PATCH 0/4] drm/msm/dp: Add support for SC8180x eDP controller

2021-05-10 Thread Bjorn Andersson
The first patch in the series is somewhat unrelated to the support, but simplifies reasoning and debugging of timing related issues. The second patch introduces support for dealing with different register block layouts, which is used in the forth patch to describe the hardware blocks found in the

[PATCH 1/4] drm/msm/dp: Simplify the mvid/nvid calculation

2021-05-10 Thread Bjorn Andersson
In the search for causes to timing issues seen during implementation of eDP support for SC8180x a fair amount of time was spent concluding why the calculated mvid/nvid values where wrong. The overall conclusion is that the ratio of MVID/NVID describes, and should match, the ratio between the pixel

[PATCH 2/4] drm/msm/dp: Store each subblock in the io region

2021-05-10 Thread Bjorn Andersson
Not all platforms has DP_P0 at offset 0x1000 from the beginning of the DP block. So move the offsets into dss_io_data, to make it possible in the next patch to specify alternative offsets and sizes of these segments. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_catalog.c | 57 +++

[PATCH 3/4] drm/msm/dp: Initialize the INTF_CONFIG register

2021-05-10 Thread Bjorn Andersson
Some bootloaders set the widebus enable bit in the INTF_CONFIG register, but configuration of widebus isn't yet supported ensure that the register has a known value, with widebus disabled. Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") Signed-off-by: Bjorn Andersson --- drive

[PATCH 4/4] drm/msm/dp: Add support for SC8180x eDP

2021-05-10 Thread Bjorn Andersson
The eDP controller found in SC8180x is at large compatible with the current implementation, but has its register blocks at slightly different offsets. Add the compatible and the new register layout. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_display.c | 1 + drivers/gpu/drm/m

Re: [PATCH v3 1/2] drm/bridge: anx7625: refactor power control to use runtime PM framework

2021-05-10 Thread Hsin-Yi Wang
On Mon, May 10, 2021 at 1:31 PM Pi-Hsun Shih wrote: > > The driver originally use an atomic_t for keep track of the power > status, which makes the driver more complicated than needed, and has > some race condition as it's possible to have the power on and power off > sequence going at the same ti

Re: [PATCH v3 2/2] drm/bridge: anx7625: add suspend / resume hooks

2021-05-10 Thread Hsin-Yi Wang
On Mon, May 10, 2021 at 1:31 PM Pi-Hsun Shih wrote: > > Add suspend / resume hooks for anx7625 driver, that power off the device > on suspend and power on the device on resume if it was previously > powered. > > Signed-off-by: Pi-Hsun Shih Tested-by: Hsin-Yi Wang Tested on a mt8183 juniper dev

Re: [PATCH v1 0/3] Add support for next gen eDP driver on SnapDragon

2021-05-10 Thread Bjorn Andersson
On Mon 10 May 07:16 CDT 2021, sbill...@codeaurora.org wrote: > On 2021-05-06 20:32, Rob Clark wrote: > > On Wed, May 5, 2021 at 11:47 PM wrote: > > > > > > On 2021-05-05 15:31, Dmitry Baryshkov wrote: > > > > Hi, > > > > > > > > On Wed, 5 May 2021 at 11:17, Sankeerth Billakanti > > > > wrote: >

[PATCH -next] drm/panfrost: Fix PM reference leak in panfrost_job_hw_submit()

2021-05-10 Thread Zou Wei
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Zou Wei --- drivers/gpu/drm/panfro

Re: [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

2021-05-10 Thread Adam Borowski
On Mon, May 10, 2021 at 12:26:12PM +0200, Mauro Carvalho Chehab wrote: > There are several UTF-8 characters at the Kernel's documentation. [...] > Other UTF-8 characters were added along the time, but they're easily > replaceable by ASCII chars. > > As Linux developers are all around the globe, an

Re: [PATCH v6 01/16] drm/ttm: Remap all page faults to per process dummy page.

2021-05-10 Thread Christian König
Am 10.05.21 um 18:36 schrieb Andrey Grodzovsky: On device removal reroute all CPU mappings to dummy page. v3: Remove loop to find DRM file and instead access it by vma->vm_file->private_data. Move dummy page installation into a separate function. v4: Map the entire BOs VA space into on demand a

Re: [PATCH v6 04/16] drm/amdkfd: Split kfd suspend from devie exit

2021-05-10 Thread Christian König
Am 10.05.21 um 18:36 schrieb Andrey Grodzovsky: Helps to expdite HW related stuff to amdgpu_pci_remove Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_device.c| 3 ++

Re: [PATCH v6 05/16] drm/amdgpu: Add early fini callback

2021-05-10 Thread Christian König
Am 10.05.21 um 18:36 schrieb Andrey Grodzovsky: Use it to call disply code dependent on device->drv_data before it's set to NULL on device unplug v5: Move HW finilization into this callback to prevent MMIO accesses post cpi remove. Signed-off-by: Andrey Grodzovsky Acked-by: Christian Kö

Re: [PATCH v6 06/16] drm/amdgpu: Handle IOMMU enabled case.

2021-05-10 Thread Christian König
Am 10.05.21 um 18:36 schrieb Andrey Grodzovsky: Handle all DMA IOMMU gropup related dependencies before the group is removed. v5: Drop IOMMU notifier and switch to lockless call to ttm_tt_unpopulate v6: Drop the BO unamp list Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/am

Re: [PATCH v6 10/16] drm/amdgpu: Guard against write accesses after device removal

2021-05-10 Thread Christian König
Am 10.05.21 um 18:36 schrieb Andrey Grodzovsky: This should prevent writing to memory or IO ranges possibly already allocated for other uses after our device is removed. v5: Protect more places wher memcopy_to/form_io takes place Protect IB submissions v6: Switch to !drm_dev_enter instead of sc

Re: [PATCH v6 11/16] drm/sched: Make timeout timer rearm conditional.

2021-05-10 Thread Christian König
Am 10.05.21 um 18:36 schrieb Andrey Grodzovsky: We don't want to rearm the timer if driver hook reports that the device is gone. v5: Update drm_gpu_sched_stat values in code. Signed-off-by: Andrey Grodzovsky Reviewed-by: Christian König --- drivers/gpu/drm/scheduler/sched_main.c | 11 ++

Re: [PATCH v6 12/16] drm/amdgpu: Prevent any job recoveries after device is unplugged.

2021-05-10 Thread Christian König
Am 10.05.21 um 18:36 schrieb Andrey Grodzovsky: Return DRM_TASK_STATUS_ENODEV back to the scheduler when device is not present so they timeout timer will not be rearmed. v5: Update to match updated return values in enum drm_gpu_sched_stat Signed-off-by: Andrey Grodzovsky Reviewed-by: Christi

Re: [PATCH v6 13/16] drm/amdgpu: Fix hang on device removal.

2021-05-10 Thread Christian König
Am 10.05.21 um 18:36 schrieb Andrey Grodzovsky: If removing while commands in flight you cannot wait to flush the HW fences on a ring since the device is gone. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 16 ++-- 1 file changed, 10 insertio

Re: [PATCH 7/8] usb: typec: altmodes/displayport: Make dp_altmode_notify() more generic

2021-05-10 Thread Heikki Krogerus
On Wed, May 05, 2021 at 06:24:14PM +0200, Hans de Goede wrote: > Make dp_altmode_notify() handle the dp->data.conf == 0 case too, > rather then having separate code-paths for this in various places > which call it. > > Signed-off-by: Hans de Goede Reviewed-by: Heikki Krogerus > --- > drivers/

Re: [PATCH v6 16/16] drm/amdgpu: Verify DMA opearations from device are done

2021-05-10 Thread Christian König
Am 10.05.21 um 18:36 schrieb Andrey Grodzovsky: In case device remove is just simualted by sysfs then verify device doesn't keep doing DMA to the released memory after pci_remove is done. Signed-off-by: Andrey Grodzovsky Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv

Re: [PATCH 8/8] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

2021-05-10 Thread Heikki Krogerus
On Wed, May 05, 2021 at 06:24:15PM +0200, Hans de Goede wrote: > Use the new drm_connector_oob_hotplug_event() functions to let drm/kms > drivers know about DisplayPort over Type-C hotplug events. > > Signed-off-by: Hans de Goede Reviewed-by: Heikki Krogerus > --- > Changes in v3: > - Only cal

<    1   2