Re: [PULL] topic/iomem-mmap-vs-gup

2021-05-10 Thread Daniel Vetter
On Sat, May 8, 2021 at 6:47 PM Linus Torvalds wrote: > > [ Daniel, please fix your broken email setup. You have this insane > "Reply-to" list that just duplicates all the participants. Very > broken, very annoying ] > > On Fri, May 7, 2021 at 8:53 AM Daniel Vetter wrote: > > > > So personally I t

Re: [PATCH v2 0/1] drm/msm/dpu: Fix error return code in dpu_mdss_init()

2021-05-10 Thread Anton Ivanov
On 10/05/2021 04:16, Zhen Lei wrote: v1 --> v2: According to Anton Ivanov's review comments, detele the unnecessary local variable initialization "ret = 0". Zhen Lei (1): drm/msm/dpu: Fix error return code in dpu_mdss_init() drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 8 +--- 1 file c

[PATCH v3 2/2] drm/bridge: anx7625: add suspend / resume hooks

2021-05-10 Thread Pi-Hsun Shih
Add suspend / resume hooks for anx7625 driver, that power off the device on suspend and power on the device on resume if it was previously powered. Signed-off-by: Pi-Hsun Shih --- Changes from v2: * No change. --- drivers/gpu/drm/bridge/analogix/anx7625.c | 27 +++ 1 file c

[PATCH] drm/amd/display: remove unused function dc_link_perform_link_training

2021-05-10 Thread Rouven Czerwinski
This function is not used anywhere, remove it. It was added in 40dd6bd376a4 ("drm/amd/display: Linux Set/Read link rate and lane count through debugfs") and moved in fe798de53a7a ("drm/amd/display: Move link functions from dc to dc_link"), but a user is missing. Signed-off-by: Rouven Czerwinski -

Re: [Intel-gfx] [PATCH 4/4] i915: fix remap_io_sg to verify the pgprot

2021-05-10 Thread youling257
This patch cause "x86/PAT : surfaceflinger:1440 map pfn RAM range req write-combining for [mem 0x064a2000-0x064a2fff], got write-back" problem. my 2GB ram Bay trail z3735f tablet runing on android-x86, "i915: fix remap_io_sg to verify the pgprot" cause this problem. 05-09 02:59:25.099 0

[PATCH] drm/amd/amdgpu: Fix errors in function documentation

2021-05-10 Thread Dwaipayan Ray
Fix a couple of syntax errors and removed one excess parameter in the function documentations which lead to kernel docs build warning. Signed-off-by: Dwaipayan Ray --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 - 2 files changed, 3 insertions(+)

Re: [v3, 5/5] drm/vc4: hdmi: Signal the proper colorimetry info in the infoframe

2021-05-10 Thread Jernej Škrabec
Hi! Dne petek, 30. april 2021 ob 11:44:51 CEST je Maxime Ripard napisal(a): > Our driver while supporting HDR didn't send the proper colorimetry info > in the AVI infoframe. > > Let's add the property needed so that the userspace can let us know what > the colorspace is supposed to be. > > Signe

Re: [v3, 4/5] drm/connector: Add a helper to attach the colorspace property

2021-05-10 Thread Jernej Škrabec
Hi! Dne petek, 30. april 2021 ob 11:44:50 CEST je Maxime Ripard napisal(a): > The intel driver uses the same logic to attach the Colorspace property > in multiple places and we'll need it in vc4 too. Let's move that common > code in a helper. > > Signed-off-by: Maxime Ripard > --- > > Changes f

[PATCH v3 1/2] drm/bridge: anx7625: refactor power control to use runtime PM framework

2021-05-10 Thread Pi-Hsun Shih
The driver originally use an atomic_t for keep track of the power status, which makes the driver more complicated than needed, and has some race condition as it's possible to have the power on and power off sequence going at the same time. This patch remove the usage of the atomic_t power_status,

[PATCH] drm: Declare drm_send_event_helper static.

2021-05-10 Thread Rajat Asthana
From: Rajat Declare drm_send_event_helper as static to fix sparse warning: > warning: symbol 'drm_send_event_helper' was not declared. > Should it be static? Signed-off-by: Rajat --- drivers/gpu/drm/drm_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

Tested

2021-05-10 Thread houdek . ryan
I have tested this on my end and it resolves the 120hz problem. Tested-By: Ryan Houdek

Re: [PATCH v2] drm/amdgpu: Ensure that the modifier requested is supported by plane.

2021-05-10 Thread youling257
I using amd 3400g running with android-x86, this patch is a bad commit when i use android-x86 on amdgpu.

Re: [PATCH V4 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-10 Thread Frieder Schrempf
On 08.05.21 22:22, Marek Vasut wrote: > Add driver for TI SN65DSI83 Single-link DSI to Single-link LVDS bridge > and TI SN65DSI84 Single-link DSI to Dual-link or 2x Single-link LVDS > bridge. TI SN65DSI85 is unsupported due to lack of hardware to test on, > but easy to add. > > The driver operates

Re: dri-devel Digest, Vol 134, Issue 221

2021-05-10 Thread chatzem
Sent from ProtonMail mobile Original Message On May 10, 2021, 10:49, wrote: > Send dri-devel mailing list submissions to > dri-devel@lists.freedesktop.org > > To subscribe or unsubscribe via the World Wide Web, visit > https://lists.freedesktop.org/mailman/listinfo/dri-devel > o

Re: [Intel-gfx] [PATCH] drm/i915/stolen: shuffle around init_memory_region

2021-05-10 Thread Tvrtko Ursulin
On 07/05/2021 10:59, Matthew Auld wrote: We generally want to first call i915_gem_object_init_memory_region() before calling into get_pages(), since this sets up various bits of state which might be needed there. Currently for stolen this doesn't matter much, but it might in the future, and at

Re: New warnings with gcc-11

2021-05-10 Thread Jani Nikula
On Sat, 08 May 2021, Linus Torvalds wrote: > I have heard nothing about this, and it remains the only warning from > my allmodconfig build (I have another one for drm compiled with clang, > but there I at least heard back that a fix exists). > > Since I am going to release rc1 tomorrow, and I don'

Re: [PATCH v3 1/5] drm/connector: Create a helper to attach the hdr_output_metadata property

2021-05-10 Thread Maxime Ripard
Hi, On Fri, Apr 30, 2021 at 11:44:47AM +0200, Maxime Ripard wrote: > All the drivers that implement HDR output call pretty much the same > function to initialise the hdr_output_metadata property, and while the > creation of that property is in a helper, every driver uses the same > code to attach

[PATCH v6 00/15] Restricted DMA

2021-05-10 Thread Claire Chang
From: Claire Chang This series implements mitigations for lack of DMA access control on systems without an IOMMU, which could result in the DMA accessing the system memory at unexpected times and/or unexpected addresses, possibly leading to data leakage or corruption. For example, we plan to use

[PATCH v6 01/15] swiotlb: Refactor swiotlb init functions

2021-05-10 Thread Claire Chang
Add a new function, swiotlb_init_io_tlb_mem, for the io_tlb_mem struct initialization to make the code reusable. Note that we now also call set_memory_decrypted in swiotlb_init_with_tbl. Signed-off-by: Claire Chang --- kernel/dma/swiotlb.c | 51 ++-- 1 fi

[PATCH v6 02/15] swiotlb: Refactor swiotlb_create_debugfs

2021-05-10 Thread Claire Chang
Split the debugfs creation to make the code reusable for supporting different bounce buffer pools, e.g. restricted DMA pool. Signed-off-by: Claire Chang --- kernel/dma/swiotlb.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/kernel/dma/swiotlb.c b/ker

[PATCH v6 03/15] swiotlb: Add DMA_RESTRICTED_POOL

2021-05-10 Thread Claire Chang
Add a new kconfig symbol, DMA_RESTRICTED_POOL, for restricted DMA pool. Signed-off-by: Claire Chang --- kernel/dma/Kconfig | 14 ++ 1 file changed, 14 insertions(+) diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig index 77b405508743..3e961dc39634 100644 --- a/kernel/dma/Kconfig

[PATCH v6 04/15] swiotlb: Add restricted DMA pool initialization

2021-05-10 Thread Claire Chang
Add the initialization function to create restricted DMA pools from matching reserved-memory nodes. Signed-off-by: Claire Chang --- include/linux/device.h | 4 +++ include/linux/swiotlb.h | 3 +- kernel/dma/swiotlb.c| 79 + 3 files changed, 85 inser

[PATCH v6 05/15] swiotlb: Add a new get_io_tlb_mem getter

2021-05-10 Thread Claire Chang
Add a new getter, get_io_tlb_mem, to help select the io_tlb_mem struct. The restricted DMA pool is preferred if available. Signed-off-by: Claire Chang --- include/linux/swiotlb.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h in

[PATCH v6 06/15] swiotlb: Update is_swiotlb_buffer to add a struct device argument

2021-05-10 Thread Claire Chang
Update is_swiotlb_buffer to add a struct device argument. This will be useful later to allow for restricted DMA pool. Signed-off-by: Claire Chang --- drivers/iommu/dma-iommu.c | 12 ++-- drivers/xen/swiotlb-xen.c | 2 +- include/linux/swiotlb.h | 6 +++--- kernel/dma/direct.c |

[PATCH v6 07/15] swiotlb: Update is_swiotlb_active to add a struct device argument

2021-05-10 Thread Claire Chang
Update is_swiotlb_active to add a struct device argument. This will be useful later to allow for restricted DMA pool. Signed-off-by: Claire Chang --- drivers/gpu/drm/i915/gem/i915_gem_internal.c | 2 +- drivers/gpu/drm/nouveau/nouveau_ttm.c| 2 +- drivers/pci/xen-pcifront.c

[PATCH v6 08/15] swiotlb: Bounce data from/to restricted DMA pool if available

2021-05-10 Thread Claire Chang
Regardless of swiotlb setting, the restricted DMA pool is preferred if available. The restricted DMA pools provide a basic level of protection against the DMA overwriting buffer contents at unexpected times. However, to protect against general data leakage and system memory corruption, the system

[PATCH v6 09/15] swiotlb: Move alloc_size to find_slots

2021-05-10 Thread Claire Chang
Move the maintenance of alloc_size to find_slots for better code reusability later. Signed-off-by: Claire Chang --- kernel/dma/swiotlb.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index 3f1ad080a4bc..ef04d8f7708f 100

[PATCH v6 10/15] swiotlb: Refactor swiotlb_tbl_unmap_single

2021-05-10 Thread Claire Chang
Add a new function, release_slots, to make the code reusable for supporting different bounce buffer pools, e.g. restricted DMA pool. Signed-off-by: Claire Chang --- kernel/dma/swiotlb.c | 35 --- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/kern

[PATCH v6 11/15] dma-direct: Add a new wrapper __dma_direct_free_pages()

2021-05-10 Thread Claire Chang
Add a new wrapper __dma_direct_free_pages() that will be useful later for swiotlb_free(). Signed-off-by: Claire Chang --- kernel/dma/direct.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c index 078f7087e466..eb409832

[PATCH v6 13/15] dma-direct: Allocate memory from restricted DMA pool if available

2021-05-10 Thread Claire Chang
The restricted DMA pool is preferred if available. The restricted DMA pools provide a basic level of protection against the DMA overwriting buffer contents at unexpected times. However, to protect against general data leakage and system memory corruption, the system needs to provide a way to lock

[PATCH v6 12/15] swiotlb: Add restricted DMA alloc/free support.

2021-05-10 Thread Claire Chang
Add the functions, swiotlb_{alloc,free} to support the memory allocation from restricted DMA pool. Signed-off-by: Claire Chang --- include/linux/swiotlb.h | 4 kernel/dma/swiotlb.c| 35 +-- 2 files changed, 37 insertions(+), 2 deletions(-) diff --git a/

[PATCH v6 14/15] dt-bindings: of: Add restricted DMA pool

2021-05-10 Thread Claire Chang
Introduce the new compatible string, restricted-dma-pool, for restricted DMA. One can specify the address and length of the restricted DMA memory region by restricted-dma-pool in the reserved-memory node. Signed-off-by: Claire Chang --- .../reserved-memory/reserved-memory.txt | 27

[PATCH v6 15/15] of: Add plumbing for restricted DMA pool

2021-05-10 Thread Claire Chang
If a device is not behind an IOMMU, we look up the device node and set up the restricted DMA when the restricted-dma-pool is presented. Signed-off-by: Claire Chang --- drivers/of/address.c| 25 + drivers/of/device.c | 3 +++ drivers/of/of_private.h | 5 + 3

Re: [PATCH v5 00/16] Restricted DMA

2021-05-10 Thread Claire Chang
v6: https://lore.kernel.org/patchwork/cover/1423201/

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-10 Thread Dave Stevenson
On Sat, 8 May 2021 at 21:26, Marek Vasut wrote: > > On 5/7/21 2:48 PM, Dave Stevenson wrote: > > [...] > > >> +static void sn65dsi83_enable(struct drm_bridge *bridge) > >> +{ > >> + struct sn65dsi83 *ctx = bridge_to_sn65dsi83(bridge); > >> + unsigned int pval; > >> + u16 val; > >

[PATCH v1 1/1] backlight: lm3630a_bl: Put fwnode in error case during ->probe()

2021-05-10 Thread Andy Shevchenko
device_for_each_child_node() bumps a reference counting of a returned variable. We have to balance it whenever we return to the caller. Fixes: 8fbce8efe15cd ("backlight: lm3630a: Add firmware node support") Cc: Brian Masney Cc: Dan Murphy Signed-off-by: Andy Shevchenko --- drivers/video/backli

[PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

2021-05-10 Thread Mauro Carvalho Chehab
There are several UTF-8 characters at the Kernel's documentation. Several of them were due to the process of converting files from DocBook, LaTeX, HTML and Markdown. They were probably introduced by the conversion tools used on that time. Other UTF-8 characters were added along the time, but they

[PATCH 44/53] docs: gpu: avoid using UTF-8 chars

2021-05-10 Thread Mauro Carvalho Chehab
While UTF-8 characters can be used at the Linux documentation, the best is to use them only when ASCII doesn't offer a good replacement. So, replace the occurences of the following UTF-8 characters: - U+2019 ('’'): RIGHT SINGLE QUOTATION MARK Signed-off-by: Mauro Carvalho Chehab --- Doc

[PATCH 5.4 093/184] drm/vkms: fix misuse of WARN_ON

2021-05-10 Thread Greg Kroah-Hartman
From: Dmitry Vyukov [ Upstream commit b4142fc4d52d051d4d8df1fb6c569e5b445d369e ] vkms_vblank_simulate() uses WARN_ON for timing-dependent condition (timer overrun). This is a mis-use of WARN_ON, WARN_ON must be used to denote kernel bugs. Use pr_warn() instead. Signed-off-by: Dmitry Vyukov Rep

[PATCH 5.10 122/299] drm/amd/display/dc/dce/dce_aux: Remove duplicate line causing field overwritten issue

2021-05-10 Thread Greg Kroah-Hartman
From: Lee Jones [ Upstream commit 89adc10178fd6cb68c8ef1905d269070a4d3bd64 ] Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:59: drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_11_2_sh_mask.h:100

[PATCH 5.10 149/299] drm/vkms: fix misuse of WARN_ON

2021-05-10 Thread Greg Kroah-Hartman
From: Dmitry Vyukov [ Upstream commit b4142fc4d52d051d4d8df1fb6c569e5b445d369e ] vkms_vblank_simulate() uses WARN_ON for timing-dependent condition (timer overrun). This is a mis-use of WARN_ON, WARN_ON must be used to denote kernel bugs. Use pr_warn() instead. Signed-off-by: Dmitry Vyukov Rep

[PATCH 5.11 140/342] drm/amd/display/dc/dce/dce_aux: Remove duplicate line causing field overwritten issue

2021-05-10 Thread Greg Kroah-Hartman
From: Lee Jones [ Upstream commit 89adc10178fd6cb68c8ef1905d269070a4d3bd64 ] Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:59: drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_11_2_sh_mask.h:100

[PATCH 5.11 176/342] drm/vkms: fix misuse of WARN_ON

2021-05-10 Thread Greg Kroah-Hartman
From: Dmitry Vyukov [ Upstream commit b4142fc4d52d051d4d8df1fb6c569e5b445d369e ] vkms_vblank_simulate() uses WARN_ON for timing-dependent condition (timer overrun). This is a mis-use of WARN_ON, WARN_ON must be used to denote kernel bugs. Use pr_warn() instead. Signed-off-by: Dmitry Vyukov Rep

Re: [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

2021-05-10 Thread David Woodhouse
On Mon, 2021-05-10 at 12:26 +0200, Mauro Carvalho Chehab wrote: > There are several UTF-8 characters at the Kernel's documentation. > > Several of them were due to the process of converting files from > DocBook, LaTeX, HTML and Markdown. They were probably introduced > by the conversion tools used

[PATCH 5.12 153/384] drm/amd/display/dc/dce/dce_aux: Remove duplicate line causing field overwritten issue

2021-05-10 Thread Greg Kroah-Hartman
From: Lee Jones [ Upstream commit 3e3527f5b765c6f479ba55e5a570ee9538589a74 ] Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:59: drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_11_2_sh_mask.h:100

[PATCH 5.12 197/384] drm/vkms: fix misuse of WARN_ON

2021-05-10 Thread Greg Kroah-Hartman
From: Dmitry Vyukov [ Upstream commit b4142fc4d52d051d4d8df1fb6c569e5b445d369e ] vkms_vblank_simulate() uses WARN_ON for timing-dependent condition (timer overrun). This is a mis-use of WARN_ON, WARN_ON must be used to denote kernel bugs. Use pr_warn() instead. Signed-off-by: Dmitry Vyukov Rep

Re: [PATCH 44/53] docs: gpu: avoid using UTF-8 chars

2021-05-10 Thread Jani Nikula
On Mon, 10 May 2021, Mauro Carvalho Chehab wrote: > While UTF-8 characters can be used at the Linux documentation, > the best is to use them only when ASCII doesn't offer a good replacement. > So, replace the occurences of the following UTF-8 characters: > > - U+2019 ('’'): RIGHT SINGLE QUOT

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-10 Thread Marek Vasut
On 5/10/21 11:58 AM, Dave Stevenson wrote: On Sat, 8 May 2021 at 21:26, Marek Vasut wrote: On 5/7/21 2:48 PM, Dave Stevenson wrote: [...] +static void sn65dsi83_enable(struct drm_bridge *bridge) +{ + struct sn65dsi83 *ctx = bridge_to_sn65dsi83(bridge); + unsigned int pval; +

Re: [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

2021-05-10 Thread Mauro Carvalho Chehab
Em Mon, 10 May 2021 12:52:44 +0200 Thorsten Leemhuis escreveu: > On 10.05.21 12:26, Mauro Carvalho Chehab wrote: > > > > As Linux developers are all around the globe, and not everybody has UTF-8 > > as their default charset, better to use UTF-8 only on cases where it is > > really > > needed. >

Re: [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

2021-05-10 Thread Mauro Carvalho Chehab
Hi David, Em Mon, 10 May 2021 11:54:02 +0100 David Woodhouse escreveu: > On Mon, 2021-05-10 at 12:26 +0200, Mauro Carvalho Chehab wrote: > > There are several UTF-8 characters at the Kernel's documentation. > > > > Several of them were due to the process of converting files from > > DocBook, La

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-10 Thread Rafael J. Wysocki
On Sat, May 8, 2021 at 9:41 AM Stephen Boyd wrote: > > The device lists are poorly ordered when the component device code is > used. This is because component_master_add_with_match() returns 0 > regardless of component devices calling component_add() first. It can > really only fail if an allocati

Re: [PATCH v1 0/3] Add support for next gen eDP driver on SnapDragon

2021-05-10 Thread sbillaka
On 2021-05-06 20:32, Rob Clark wrote: On Wed, May 5, 2021 at 11:47 PM wrote: On 2021-05-05 15:31, Dmitry Baryshkov wrote: > Hi, > > On Wed, 5 May 2021 at 11:17, Sankeerth Billakanti > wrote: >> >> These patches add support for the next generation eDP driver on >> SnapDragon >> with dpu suppor

[PATCH 1/1] drm/amd/display: Delete several unneeded bool conversions

2021-05-10 Thread Zhen Lei
The result of an expression consisting of a single relational operator is already of the bool type and does not need to be evaluated explicitly. No functional change. Signed-off-by: Zhen Lei --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dpp_cm.c | 4 ++-- drivers/gpu/drm/amd/display/dc/dcn30/d

[PATCH 1/1] drm/amdgpu: Delete two unneeded bool conversions

2021-05-10 Thread Zhen Lei
The result of an expression consisting of a single relational operator is already of the bool type and does not need to be evaluated explicitly. No functional change. Signed-off-by: Zhen Lei --- drivers/gpu/drm/amd/amdgpu/mmhub_v2_3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) d

Re: [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

2021-05-10 Thread Mauro Carvalho Chehab
Em Mon, 10 May 2021 13:19:50 +0200 Mauro Carvalho Chehab escreveu: > Em Mon, 10 May 2021 12:52:44 +0200 > Thorsten Leemhuis escreveu: > > > On 10.05.21 12:26, Mauro Carvalho Chehab wrote: > > > > > > As Linux developers are all around the globe, and not everybody has UTF-8 > > > as their defa

Re: [PATCH] drm: Declare drm_send_event_helper static.

2021-05-10 Thread Maxime Ripard
Hi, On Sun, May 09, 2021 at 07:12:52PM +0530, Rajat Asthana wrote: > From: Rajat > > Declare drm_send_event_helper as static to fix sparse warning: > > > warning: symbol 'drm_send_event_helper' was not declared. > > Should it be static? > > Signed-off-by: Rajat Both the Author and Signed-off

Re: [PATCH 44/53] docs: gpu: avoid using UTF-8 chars

2021-05-10 Thread Liviu Dudau
On Mon, May 10, 2021 at 12:26:56PM +0200, Mauro Carvalho Chehab wrote: > While UTF-8 characters can be used at the Linux documentation, > the best is to use them only when ASCII doesn't offer a good replacement. > So, replace the occurences of the following UTF-8 characters: > > - U+2019 ('’

[PATCH v7 0/3] drm/i915/display: Try YCbCr420 color when RGB fails

2021-05-10 Thread Werner Sembach
When encoder validation of a display mode fails, retry with less bandwidth heavy YCbCr420 color mode, if available. This enables some HDMI 1.4 setups to support 4k60Hz output, which previously failed silently. AMDGPU had nearly the exact same issue. This problem description is therefore copied fro

[PATCH v7 1/3] drm/i915/display: New function to avoid duplicate code in upcomming commits

2021-05-10 Thread Werner Sembach
Moves some checks that later will be performed 2 times to an own function. This avoids duplicate code later on. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_hdmi.c | 42 +++ 1 file changed, 27 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/dr

[PATCH v7 3/3] drm/i915/display: Use YCbCr420 as fallback when RGB fails

2021-05-10 Thread Werner Sembach
When encoder validation of a display mode fails, retry with less bandwidth heavy YCbCr420 color mode, if available. This enables some HDMI 1.4 setups to support 4k60Hz output, which previously failed silently. AMDGPU had nearly the exact same issue. This problem description is therefore copied fro

[PATCH v7 2/3] drm/i915/display: Restructure output format computation for better expandability

2021-05-10 Thread Werner Sembach
Couples the decission between RGB and YCbCr420 mode and the check if the port clock can archive the required frequency. Other checks and configuration steps that where previously done in between can also be done before or after. This allows for are cleaner implementation of retrying different colo

Re: [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

2021-05-10 Thread Mauro Carvalho Chehab
Em Mon, 10 May 2021 14:16:16 +0100 Edward Cree escreveu: > On 10/05/2021 12:55, Mauro Carvalho Chehab wrote: > > The main point on this series is to replace just the occurrences > > where ASCII represents the symbol equally well > > > - U+2014 ('—'): EM DASH > Em dash is not the same thi

Re: [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

2021-05-10 Thread David Woodhouse
On Mon, 2021-05-10 at 13:55 +0200, Mauro Carvalho Chehab wrote: > This patch series is doing conversion only when using ASCII makes > more sense than using UTF-8. > > See, a number of converted documents ended with weird characters > like ZERO WIDTH NO-BREAK SPACE (U+FEFF) character. This specifi

Re: [PULL] topic/iomem-mmap-vs-gup

2021-05-10 Thread Jason Gunthorpe
On Sat, May 08, 2021 at 09:46:41AM -0700, Linus Torvalds wrote: > I think follow_pfn() is ok for the actual "this is not a 'struct page' > backed area", and disabling that case is wrong even going forward. Every place we've audited using follow_pfn() has been shown to have some use-after-free bug

Re: [RFC PATCH 00/97] Basic GuC submission support in the i915

2021-05-10 Thread Martin Peres
On 10/05/2021 02:11, Jason Ekstrand wrote: On May 9, 2021 12:12:36 Martin Peres wrote: Hi, On 06/05/2021 22:13, Matthew Brost wrote: Basic GuC submission support. This is the first bullet point in the upstreaming plan covered in the following RFC [1]. At a very high level the GuC is a piece

Re: [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

2021-05-10 Thread Matthew Wilcox
On Mon, May 10, 2021 at 02:16:16PM +0100, Edward Cree wrote: > On 10/05/2021 12:55, Mauro Carvalho Chehab wrote: > > The main point on this series is to replace just the occurrences > > where ASCII represents the symbol equally well > > > - U+2014 ('—'): EM DASH > Em dash is not the same thing

Re: [PATCH 3/3] [RFC] drm/exynos: Add basic i.MX8MM support code

2021-05-10 Thread Adam Ford
On Mon, Oct 5, 2020 at 8:48 AM Marek Vasut wrote: > > This adds basic i.MX8MM glue code for the Samsung DSIM PHY. > There are still a couple of items which need to be sorted out > in drivers/gpu/drm/bridge/samsung-dsim.c before this can even > be merged, specifically: > > - The dsi->out_bridge is

[PATCH] drm/imx: ipuv3-plane: use drm managed resources

2021-05-10 Thread Lucas Stach
The conversion to drm managed resources introduced two bugs: the plane is now always initialized with the linear-only list, while the list with the Vivante GPU modifiers should have been used when the PRG/PRE engines are present. This masked another issue, as ipu_plane_format_mod_supported() is now

Re: [PATCHv2 2/5] drm/imx: Add 8 pixel alignment fix

2021-05-10 Thread Philipp Zabel
Hi Sebastian, On Thu, 2021-04-29 at 00:29 +0200, Sebastian Reichel wrote: > Some standard resolutions like 1366x768 do not work properly with > i.MX6 SoCs, since the horizontal resolution needs to be aligned > to 8 pixels (so 1360x768 or 1368x768 would work). > > This patch allocates framebuffers

Re: [PATCH] drm/imx: ipuv3-plane: use drm managed resources

2021-05-10 Thread Philipp Zabel
Hi Lucas, On Mon, 2021-05-10 at 16:29 +0200, Lucas Stach wrote: > The conversion to drm managed resources introduced two bugs: the plane is now > always initialized with the linear-only list, while the list with the Vivante > GPU modifiers should have been used when the PRG/PRE engines are present

[PATCH] drm: Include iff CONFIG_AGP is set

2021-05-10 Thread Thomas Zimmermann
Platforms without AGP don't provide the AGP header. Only include it if CONFIG_AGP is set. Signed-off-by: Thomas Zimmermann Cc: Alex Deucher Cc: Christian König Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: David Airlie Cc: Daniel Vetter Cc: "Christian König" Cc: Christophe JAILLET Cc: Jason

Re: [PULL] topic/iomem-mmap-vs-gup

2021-05-10 Thread Daniel Vetter
On Mon, May 10, 2021 at 3:50 PM Jason Gunthorpe wrote: > > On Sat, May 08, 2021 at 09:46:41AM -0700, Linus Torvalds wrote: > > > I think follow_pfn() is ok for the actual "this is not a 'struct page' > > backed area", and disabling that case is wrong even going forward. > > Every place we've audit

[PATCH v2] drm/imx: ipuv3-plane: fix PRG modifiers after drm managed resource conversion

2021-05-10 Thread Lucas Stach
The conversion to drm managed resources introduced two bugs: the plane is now always initialized with the linear-only list, while the list with the Vivante GPU modifiers should have been used when the PRG/PRE engines are present. This masked another issue, as ipu_plane_format_mod_supported() is now

Re: [PATCH v2] drm/imx: ipuv3-plane: fix PRG modifiers after drm managed resource conversion

2021-05-10 Thread Philipp Zabel
On Mon, 2021-05-10 at 16:59 +0200, Lucas Stach wrote: > The conversion to drm managed resources introduced two bugs: the plane is now > always initialized with the linear-only list, while the list with the Vivante > GPU modifiers should have been used when the PRG/PRE engines are present. This > ma

Re: Tested

2021-05-10 Thread Alex Deucher
Sorry, what patch are you referring to? Alex On Mon, May 10, 2021 at 4:04 AM wrote: > > I have tested this on my end and it resolves the 120hz problem. > > Tested-By: Ryan Houdek

Re: [PATCH] drm: Include iff CONFIG_AGP is set

2021-05-10 Thread Alex Deucher
On Mon, May 10, 2021 at 10:52 AM Thomas Zimmermann wrote: > > Platforms without AGP don't provide the AGP header. Only include it > if CONFIG_AGP is set. > > Signed-off-by: Thomas Zimmermann Fixes: 04dfe19a5ed6 ("drm: Mark AGP implementation and ioctls as legacy") > Cc: Thomas Zimmermann > Cc: A

Re: [PULL] topic/iomem-mmap-vs-gup

2021-05-10 Thread Jason Gunthorpe
On Mon, May 10, 2021 at 04:55:39PM +0200, Daniel Vetter wrote: > yeah vfio is still broken for the case I care about. I think there's > also some questions open still about whether kvm really uses > mmu_notifier in all cases correctly, IIRC kvm doesn't either. > > Daniel I suppose we missed thi

Re: [RFC PATCH 8/9] drm/gem: Associate GEM objects with drm cgroup

2021-05-10 Thread Daniel Vetter
The other thread about how to manage gpu compute resources reminded me of this one about gpu memory splitting. On Thu, Mar 18, 2021 at 8:20 PM Brian Welty wrote: > > > On 3/18/2021 3:16 AM, Daniel Vetter wrote: > > On Sat, Mar 6, 2021 at 1:44 AM Brian Welty wrote: > >> > >> > >> On 2/11/2021 7:3

Re: [PATCH] drm/panel: s6e63m0: Depromote debug prints

2021-05-10 Thread Daniel Vetter
On Mon, May 10, 2021 at 01:09:27AM +0200, Linus Walleij wrote: > On Sun, Mar 14, 2021 at 12:09 AM Linus Walleij > wrote: > > > The dev_info():s in the DSI driver are very talkative, > > depromote these to dev_dbg(). > > > > Signed-off-by: Linus Walleij > > Could someone show mercy on this patc

Re: [PATCH v5 20/27] drm: Scope all DRM IOCTLs with drm_dev_enter/exit

2021-05-10 Thread Daniel Vetter
On Fri, May 07, 2021 at 02:00:14PM -0400, Andrey Grodzovsky wrote: > > > On 2021-05-07 12:24 p.m., Daniel Vetter wrote: > > On Fri, May 07, 2021 at 11:39:49AM -0400, Andrey Grodzovsky wrote: > > > > > > > > > On 2021-05-07 5:11 a.m., Daniel Vetter wrote: > > > > On Thu, May 06, 2021 at 12:25:06

Re: [PATCH] drm/i915: Stop propagating fence errors by default

2021-05-10 Thread Daniel Vetter
On Fri, May 07, 2021 at 09:35:21AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > This is an alternative proposed fix for the below references bug report > where dma fence error propagation is causing undesirable change in > behaviour post GPU hang/reset. > > Approach in this patch is t

Re: [PATCH v1 1/1] backlight: lm3630a_bl: Put fwnode in error case during ->probe()

2021-05-10 Thread Brian Masney
On Mon, May 10, 2021 at 12:57:16PM +0300, Andy Shevchenko wrote: > device_for_each_child_node() bumps a reference counting of a returned > variable. > We have to balance it whenever we return to the caller. > > Fixes: 8fbce8efe15cd ("backlight: lm3630a: Add firmware node support") > Cc: Brian Mas

[PATCH v2] drm: Declare drm_send_event_helper static.

2021-05-10 Thread Rajat Asthana
Declare drm_send_event_helper as static to fix sparse warning: > warning: symbol 'drm_send_event_helper' was not declared. > Should it be static? Signed-off-by: Rajat Asthana --- Changes in v2: Provide full name in Author and Signed-off. drivers/gpu/drm/drm_file.c | 2 +- 1 file changed, 1

Re: [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

2021-05-10 Thread Thorsten Leemhuis
On 10.05.21 12:26, Mauro Carvalho Chehab wrote: > > As Linux developers are all around the globe, and not everybody has UTF-8 > as their default charset, better to use UTF-8 only on cases where it is really > needed. > […] > The remaining patches on series address such cases on *.rst files and >

Re: [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

2021-05-10 Thread Edward Cree
On 10/05/2021 12:55, Mauro Carvalho Chehab wrote: > The main point on this series is to replace just the occurrences > where ASCII represents the symbol equally well > - U+2014 ('—'): EM DASH Em dash is not the same thing as hyphen-minus, and the latter does not serve 'equally well'. Peopl

Re: [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

2021-05-10 Thread Edward Cree
On 10/05/2021 14:59, Matthew Wilcox wrote: > Most of these > UTF-8 characters come from latex conversions and really aren't > necessary (and are being used incorrectly). I fully agree with fixing those. The cover-letter, however, gave the impression that that was not the main purpose of this serie

Re: [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

2021-05-10 Thread Ben Boeckel
On Mon, May 10, 2021 at 13:55:18 +0200, Mauro Carvalho Chehab wrote: > $ git grep "CPU 0 has been" Documentation/RCU/ > Documentation/RCU/Design/Data-Structures/Data-Structures.rst:| #. CPU 0 > has been in dyntick-idle mode for quite some time. When it | > Documentation/RCU/Desig

Re: [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

2021-05-10 Thread Edward Cree
On 10/05/2021 14:38, Mauro Carvalho Chehab wrote: > Em Mon, 10 May 2021 14:16:16 +0100 > Edward Cree escreveu: >> But what kinds of things with × or — in are going to be grept for? > > Actually, on almost all places, those aren't used inside math formulae, but > instead, they describe video some

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-10 Thread Daniel Vetter
On Sat, May 08, 2021 at 12:41:18AM -0700, Stephen Boyd wrote: > The device lists are poorly ordered when the component device code is > used. This is because component_master_add_with_match() returns 0 > regardless of component devices calling component_add() first. It can > really only fail if an

Re: [RFC PATCH 8/9] drm/gem: Associate GEM objects with drm cgroup

2021-05-10 Thread Tamminen, Eero T
Hi, Mon, 2021-05-10 at 17:36 +0200, Daniel Vetter wrote: > ... > > If DRM allows user-space to exhaust all of system memory, this seems > > to be a gap in enforcement of MEMCG limits for system memory. > > I tried to look into it when this was discussed in the past > > My guess is that shmem_

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-10 Thread Daniel Vetter
On Sat, May 08, 2021 at 12:56:38PM -0700, Rob Clark wrote: > From: Rob Clark > > drm_atomic_helper_dirtyfb() will end up stalling for vblank on "video > mode" type displays, which is pointless and unnecessary. Add an > optional helper vfunc to determine if a plane is attached to a CRTC > that ac

Re: [PATCH V4 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings

2021-05-10 Thread Rob Herring
On Sat, 08 May 2021 22:22:50 +0200, Marek Vasut wrote: > Add DT binding document for TI SN65DSI83 and SN65DSI84 DSI to LVDS bridge. > > Reviewed-by: Linus Walleij > Signed-off-by: Marek Vasut > Cc: Douglas Anderson > Cc: Jagan Teki > Cc: Laurent Pinchart > Cc: Linus Walleij > Cc: Rob Herring

Re: [PATCH 1/2] drm: Fix dirtyfb stalls

2021-05-10 Thread Daniel Vetter
On Mon, May 10, 2021 at 06:14:20PM +0200, Daniel Vetter wrote: > On Sat, May 08, 2021 at 12:56:38PM -0700, Rob Clark wrote: > > From: Rob Clark > > > > drm_atomic_helper_dirtyfb() will end up stalling for vblank on "video > > mode" type displays, which is pointless and unnecessary. Add an > > op

Re: [PATCH 3/3] [RFC] drm/exynos: Add basic i.MX8MM support code

2021-05-10 Thread Tim Harvey
On Mon, May 10, 2021 at 7:12 AM Adam Ford wrote: > > On Mon, Oct 5, 2020 at 8:48 AM Marek Vasut wrote: > > > > This adds basic i.MX8MM glue code for the Samsung DSIM PHY. > > There are still a couple of items which need to be sorted out > > in drivers/gpu/drm/bridge/samsung-dsim.c before this can

Re: [RFC PATCH 00/97] Basic GuC submission support in the i915

2021-05-10 Thread Jason Ekstrand
On May 10, 2021 08:55:55 Martin Peres wrote: On 10/05/2021 02:11, Jason Ekstrand wrote: On May 9, 2021 12:12:36 Martin Peres wrote: Hi, On 06/05/2021 22:13, Matthew Brost wrote: Basic GuC submission support. This is the first bullet point in the upstreaming plan covered in the following R

Re: [RFC PATCH 00/97] Basic GuC submission support in the i915

2021-05-10 Thread Daniel Vetter
On Mon, May 10, 2021 at 3:55 PM Martin Peres wrote: > > On 10/05/2021 02:11, Jason Ekstrand wrote: > > On May 9, 2021 12:12:36 Martin Peres wrote: > > > >> Hi, > >> > >> On 06/05/2021 22:13, Matthew Brost wrote: > >>> Basic GuC submission support. This is the first bullet point in the > >>> upstr

[PATCH v6 00/16] RFC Support hot device unplug in amdgpu

2021-05-10 Thread Andrey Grodzovsky
Until now extracting a card either by physical extraction (e.g. eGPU with thunderbolt connection or by emulation through  sysfs -> /sys/bus/pci/devices/device_id/remove) would cause random crashes in user apps. The random crashes in apps were mostly due to the app having mapped a device backed

[PATCH v6 01/16] drm/ttm: Remap all page faults to per process dummy page.

2021-05-10 Thread Andrey Grodzovsky
On device removal reroute all CPU mappings to dummy page. v3: Remove loop to find DRM file and instead access it by vma->vm_file->private_data. Move dummy page installation into a separate function. v4: Map the entire BOs VA space into on demand allocated dummy page on the first fault for that BO

[PATCH v6 02/16] drm/ttm: Expose ttm_tt_unpopulate for driver use

2021-05-10 Thread Andrey Grodzovsky
It's needed to drop iommu backed pages on device unplug before device's IOMMU group is released. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/ttm/ttm_tt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c index 539e0232cb3b..d

[PATCH v6 05/16] drm/amdgpu: Add early fini callback

2021-05-10 Thread Andrey Grodzovsky
Use it to call disply code dependent on device->drv_data before it's set to NULL on device unplug v5: Move HW finilization into this callback to prevent MMIO accesses post cpi remove. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 59 +--

  1   2   >