[PATCH] drm/meson: fix shutdown crash when component not probed

2021-04-30 Thread Neil Armstrong
When main component is not probed, by example when the dw-hdmi module is not loaded yet or in probe defer, the following crash appears on shutdown: Unable to handle kernel NULL pointer dereference at virtual address 0038 ... pc : meson_drv_shutdown+0x24/0x50 lr : platform_drv_shutdown

Re: [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-04-30 Thread Neil Armstrong
On 29/04/2021 18:27, Frieder Schrempf wrote: > On 28.04.21 16:16, Marek Vasut wrote: >> On 4/28/21 11:24 AM, Neil Armstrong wrote: >> [...] >> >>> +static int sn65dsi83_probe(struct i2c_client *client, >>> +   const struct i2c_device_id *id) >>> +{ >>> +    struct device

Re: [PATCH v3 1/3] drm/bridge: nwl-dsi: Force a full modeset when crtc_state->active is changed to be true

2021-04-30 Thread Neil Armstrong
On 23/04/2021 11:26, Liu Ying wrote: > This patch replaces ->mode_fixup() with ->atomic_check() so that > a full modeset can be requested from there when crtc_state->active > is changed to be true(which implies only connector's DPMS is brought > out of "Off" status, though not necessarily). Bridge

Re: [PATCH v3 2/3] drm/bridge: nwl-dsi: Remove a check on unchanged HS clock rate from ->mode_set()

2021-04-30 Thread Neil Armstrong
On 23/04/2021 11:26, Liu Ying wrote: > The check on unchanged HS clock rate in ->mode_set() improves > the callback's performance a bit by early return. However, > the up-coming patch would get MIPI DSI controller and PHY ready > in ->mode_set() after that check, thus likely skipped. > So, this pa

Re: [PATCH v3 3/3] drm/bridge: nwl-dsi: Get MIPI DSI controller and PHY ready in ->mode_set()

2021-04-30 Thread Neil Armstrong
On 23/04/2021 11:26, Liu Ying wrote: > Some MIPI DSI panel drivers like 'raydium,rm68200' send > MIPI_DCS_SET_DISPLAY_ON commands in panel_funcs->prepare(), which > requires the MIPI DSI controller and PHY to be ready beforehand. > Without this patch, the nwl-dsi driver gets the MIPI DSI controller

Re: [PATCH v3 0/3] drm/bridge: nwl-dsi: Get MIPI DSI controller and PHY ready in ->mode_set()

2021-04-30 Thread Neil Armstrong
On 23/04/2021 11:26, Liu Ying wrote: > Hi, > > This series aims to make the nwl-dsi bridge be able to connect with > more MIPI DSI panels. Some MIPI DSI panel drivers like 'raydium,rm68200' > send MIPI_DCS_SET_DISPLAY_ON commands in panel_funcs->prepare(), which > requires the MIPI DSI controller

Re: [PATCH 0/2] clk: Implement a clock request API

2021-04-30 Thread Maxime Ripard
Hi Mike, Stephen, On Tue, Apr 13, 2021 at 12:13:18PM +0200, Maxime Ripard wrote: > Hi, > > This is a follow-up of the discussion here: > https://lore.kernel.org/linux-clk/20210319150355.xzw7ikwdaga2dwhv@gilmour/ > > This implements a mechanism to raise and lower clock rates based on consumer > w

Re: [PATCH] SPI: meson-spifc add missed calls to remove function

2021-04-30 Thread Art Nikpal
Yep! but if i try call spi_master_put(master) or spi_unregister_controller(master); it's made Segmentation fault for me what's wrong - may be somebody can help me On Mon, Apr 26, 2021 at 7:57 PM Mark Brown wrote: > > On Sat, Apr 24, 2021 at 07:57:19AM +0800, Art Nikpal wrote: > > > > I would e

Re: [Mesa-dev] [RFC] Linux Graphics Next: Explicit fences everywhere and no BO fences - initial proposal

2021-04-30 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 1:12 PM Daniel Vetter wrote: > > On Wed, Apr 28, 2021 at 04:39:24PM -0400, Alex Deucher wrote: > > On Wed, Apr 28, 2021 at 10:35 AM Daniel Vetter wrote: > > > > > > On Wed, Apr 28, 2021 at 03:37:49PM +0200, Christian König wrote: > > > > Am 28.04.21 um 15:34 schrieb Daniel

Re: [RFC PATCH 1/3] drm/color: Add RGB Color encodings

2021-04-30 Thread Pekka Paalanen
On Mon, 26 Apr 2021 22:08:55 +0300 Ville Syrjälä wrote: > On Mon, Apr 26, 2021 at 02:56:26PM -0400, Harry Wentland wrote: > > On 2021-04-26 2:07 p.m., Ville Syrjälä wrote: > > > On Mon, Apr 26, 2021 at 01:38:50PM -0400, Harry Wentland wrote: > > >> From: Bhawanpreet Lakha > > >> > > >> Add t

[PULL] drm-intel-next-fixes for the merge window #2

2021-04-30 Thread Jani Nikula
Hi Dave & Daniel - One more fix for -rc1. drm-intel-next-fixes-2021-04-30: drm/i915 GVT fixes for v5.13-rc1: - Fix a possible division by zero in vgpu display rate calculation BR, Jani. The following changes since commit 270e3cc5aa382f63ea20b93c3d20162a891dc638: drm/i915: Fix docbook descr

Re: [Mesa-dev] [RFC] Linux Graphics Next: Explicit fences everywhere and no BO fences - initial proposal

2021-04-30 Thread Christian König
Am 30.04.21 um 10:58 schrieb Daniel Vetter: [SNIP] When the user allocates usermode queues, the kernel driver sets up a queue descriptor in the kernel which defines the location of the queue in memory, what priority it has, what page tables it should use, etc. User mode can then start writing co

Re: [PATCH v5 1/6] dt-bindings: display: add Unisoc's drm master bindings

2021-04-30 Thread Maxime Ripard
On Sun, Apr 25, 2021 at 08:36:02PM +0800, Kevin Tang wrote: > From: Kevin Tang > > The Unisoc DRM master device is a virtual device needed to list all > DPU devices or other display interface nodes that comprise the > graphics subsystem > > Unisoc's display pipeline have several components as be

[PATCH] drm/mgag200: Remove redundant assignment to status and clock

2021-04-30 Thread Jiapeng Chong
Variable status is set to zero but this value is never read as it is overwritten with a new value later on,clock is being assigned a value from a calculation however the variable is never read,hence these are redundant assignments that can be removed. Clean up the following clang-analyzer warning:

Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-30 Thread Maxime Ripard
On Sun, Apr 25, 2021 at 08:36:05PM +0800, Kevin Tang wrote: > Adds DPU(Display Processor Unit) support for the Unisoc's display > subsystem. > It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. > > v2: > - Use drm_xxx to replace all DRM_XXX. > - Use kzalloc to replace d

Re: [PATCH v3 0/3] drm/bridge: nwl-dsi: Get MIPI DSI controller and PHY ready in ->mode_set()

2021-04-30 Thread Guido Günther
Hi Liu, On Fri, Apr 23, 2021 at 05:26:40PM +0800, Liu Ying wrote: > Hi, > > This series aims to make the nwl-dsi bridge be able to connect with > more MIPI DSI panels. Some MIPI DSI panel drivers like 'raydium,rm68200' > send MIPI_DCS_SET_DISPLAY_ON commands in panel_funcs->prepare(), which > req

[PATCH 01/13] drm/ttm: add ttm_sys_manager v2

2021-04-30 Thread Christian König
Add a separate manager for the system domain and make function tables mandatory. v2: debug is still optional Signed-off-by: Christian König --- drivers/gpu/drm/ttm/Makefile | 2 +- drivers/gpu/drm/ttm/ttm_device.c | 17 +--- drivers/gpu/drm/ttm/ttm_module.h | 3 ++

[PATCH 02/13] drm/ttm: always initialize the full ttm_resource

2021-04-30 Thread Christian König
Init all fields in ttm_resource_alloc() when we create a new resource. Signed-off-by: Christian König Reviewed-by: Matthew Auld --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 -- drivers/gpu/drm/ttm/ttm_bo.c| 26 - drivers/gpu/drm/ttm/ttm_bo_util.c |

[PATCH 04/13] drm/ttm: rename bo->mem and make it a pointer

2021-04-30 Thread Christian König
When we want to decouble resource management from buffer management we need to be able to handle resources separately. Add a resource pointer and rename bo->mem so that all code needs to change to access the pointer instead. No functional change. Signed-off-by: Christian König Reviewed-by: Matt

[PATCH 03/13] drm/ttm: properly allocate sys resource during swapout

2021-04-30 Thread Christian König
Drop the special handling here. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 55f1ddcf22b6..ca1b098b6a56 100644 --- a/drivers/gpu/d

[PATCH 05/13] drm/ttm: allocate resource object instead of embedding it

2021-04-30 Thread Christian König
To improve the handling we want the establish the resource object as base class for the backend allocations. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 54 +++ drivers/gpu/drm/nouveau/nouveau_bo.

[PATCH 06/13] drm/ttm: flip over the range manager to self allocated nodes

2021-04-30 Thread Christian König
Start with the range manager to make the resource object the base class for the allocated nodes. While at it cleanup a lot of the code around that. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 1 + drivers/gpu/drm/drm_gem_vram_helper.c | 2 + drivers/gpu/drm/

[PATCH 11/13] drm/nouveau: switch the TTM backends to self alloc

2021-04-30 Thread Christian König
Similar to the TTM range manager. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_mem.h | 1 + drivers/gpu/drm/nouveau/nouveau_ttm.c | 4 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_mem.h b/drivers/gpu/drm/nouveau/nouveau_mem.h index 7d

[PATCH 12/13] drm/vmwgfx: switch the TTM backends to self alloc

2021-04-30 Thread Christian König
Similar to the TTM range manager. Signed-off-by: Christian König --- drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 18 + drivers/gpu/drm/vmwgfx/vmwgfx_thp.c | 37 ++- 2 files changed, 31 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgf

[PATCH 08/13] drm/amdgpu: revert "drm/amdgpu: stop allocating dummy GTT nodes"

2021-04-30 Thread Christian König
TTM is going to need this again since we are moving the resource allocation into the backend. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 68 - 1 file changed, 39 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdg

[PATCH 07/13] drm/ttm: flip over the sys manager to self allocated nodes

2021-04-30 Thread Christian König
Make sure to allocate a resource object here. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_sys_manager.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_sys_manager.c b/drivers/gpu/drm/ttm/ttm_sys_manager.c index ed92615214e3..a926114edfe5 100644

[PATCH 13/13] drm/ttm: flip the switch for driver allocated resources

2021-04-30 Thread Christian König
Instead of both driver and TTM allocating memory finalize embedding the ttm_resource object as base into the driver backends. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 44 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_object.c| 2 +- .../gpu/drm/a

[PATCH 09/13] drm/amdgpu: switch the GTT backend to self alloc

2021-04-30 Thread Christian König
Similar to the TTM range manager. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 36 + 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c

[PATCH 10/13] drm/amdgpu: switch the VRAM backend to self alloc

2021-04-30 Thread Christian König
Similar to the TTM range manager. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 51 1 file changed, 30 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.

Re: [PATCH v5 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver

2021-04-30 Thread Maxime Ripard
Hi, On Sun, Apr 25, 2021 at 08:36:07PM +0800, Kevin Tang wrote: > Adds dsi host controller support for the Unisoc's display subsystem. > Adds dsi phy support for the Unisoc's display subsystem. > Only MIPI DSI Displays supported, DP/TV/HMDI will be support > in the feature. > > v1: > - Remove d

Re: [Mesa-dev] [RFC] Linux Graphics Next: Explicit fences everywhere and no BO fences - initial proposal

2021-04-30 Thread Daniel Vetter
On Fri, Apr 30, 2021 at 11:08 AM Christian König wrote: > > Am 30.04.21 um 10:58 schrieb Daniel Vetter: > > [SNIP] > >>> When the user allocates usermode queues, the kernel driver sets up a > >>> queue descriptor in the kernel which defines the location of the queue > >>> in memory, what priority

Re: [RFC PATCH 0/3] A drm_plane API to support HDR planes

2021-04-30 Thread Pekka Paalanen
On Wed, 28 Apr 2021 13:24:27 +0530 Shashank Sharma wrote: > Assuming these details, A compositor will look for DRM color properties like > these: > > 1. Degamma plane property : To make buffers linear for Gamut mapping > > 2. Gamut mapping plane property:  To gamut map SRGB buffer to BT2020 >

[PATCH v3 1/5] drm/connector: Create a helper to attach the hdr_output_metadata property

2021-04-30 Thread Maxime Ripard
All the drivers that implement HDR output call pretty much the same function to initialise the hdr_output_metadata property, and while the creation of that property is in a helper, every driver uses the same code to attach it. Provide a helper for it as well Reviewed-by: Harry Wentland Reviewed-

[PATCH v3 2/5] drm/connector: Add helper to compare HDR metadata

2021-04-30 Thread Maxime Ripard
All the drivers that support the HDR metadata property have a similar function to compare the metadata from one connector state to the next, and force a mode change if they differ. All these functions run pretty much the same code, so let's turn it into an helper that can be shared across those dr

[PATCH v3 3/5] drm/vc4: Add HDR metadata property to the VC5 HDMI connectors

2021-04-30 Thread Maxime Ripard
From: Dave Stevenson Now that we can export deeper colour depths, add in the signalling for HDR metadata. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard --- Changes from v2: - Rebased on current drm-misc-next Changes from v1: - Rebased on latest drm-misc-next tag --- driver

[PATCH v3 4/5] drm/connector: Add a helper to attach the colorspace property

2021-04-30 Thread Maxime Ripard
The intel driver uses the same logic to attach the Colorspace property in multiple places and we'll need it in vc4 too. Let's move that common code in a helper. Signed-off-by: Maxime Ripard --- Changes from v2: - Rebased on current drm-misc-next Changes from v1: - New patch --- drivers/gp

[PATCH v3 5/5] drm/vc4: hdmi: Signal the proper colorimetry info in the infoframe

2021-04-30 Thread Maxime Ripard
Our driver while supporting HDR didn't send the proper colorimetry info in the AVI infoframe. Let's add the property needed so that the userspace can let us know what the colorspace is supposed to be. Signed-off-by: Maxime Ripard --- Changes from v2: - Rebased on current drm-misc-next Chang

Re: [PATCH v3 1/3] drm/bridge: nwl-dsi: Force a full modeset when crtc_state->active is changed to be true

2021-04-30 Thread Robert Foss
Hey Liu, This patch does not apply on upstream-drm-misc/drm-misc-next. When it passes local testing & building, I'm ready to merge it. On Fri, 23 Apr 2021 at 11:42, Liu Ying wrote: > This patch replaces ->mode_fixup() with ->atomic_check() so that > a full modeset can be requested from there wh

Re: [PATCH 01/13] drm/ttm: add ttm_sys_manager v2

2021-04-30 Thread Matthew Auld
On Fri, 30 Apr 2021 at 10:25, Christian König wrote: > > Add a separate manager for the system domain and make function tables > mandatory. > > v2: debug is still optional > > Signed-off-by: Christian König > --- > drivers/gpu/drm/ttm/Makefile | 2 +- > drivers/gpu/drm/ttm/ttm_device.c

Re: [Intel-gfx] [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

2021-04-30 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 09:03:48PM -0700, Matthew Brost wrote: > On Thu, Apr 29, 2021 at 02:14:19PM +0200, Daniel Vetter wrote: > > On Wed, Apr 28, 2021 at 01:17:27PM -0500, Jason Ekstrand wrote: > > > On Wed, Apr 28, 2021 at 1:02 PM Matthew Brost > > > wrote: > > > > > > > > On Wed, Apr 28, 2021

Re: [Mesa-dev] [RFC] Linux Graphics Next: Explicit fences everywhere and no BO fences - initial proposal

2021-04-30 Thread Daniel Stone
Hi, On Fri, 30 Apr 2021 at 10:35, Daniel Vetter wrote: > On Fri, Apr 30, 2021 at 11:08 AM Christian König > wrote: > > This doesn't work in hardware. We at least need to setup a few registers > > and memory locations from inside the VM which userspace shouldn't have > > access to when we want th

Re: [PATCH 03/13] drm/ttm: properly allocate sys resource during swapout

2021-04-30 Thread Matthew Auld
On Fri, 30 Apr 2021 at 10:25, Christian König wrote: > > Drop the special handling here. > > Signed-off-by: Christian König Reviewed-by: Matthew Auld ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listi

Re: [PATCH v5 20/27] drm: Scope all DRM IOCTLs with drm_dev_enter/exit

2021-04-30 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 04:34:55PM -0400, Andrey Grodzovsky wrote: > > > On 2021-04-29 3:05 p.m., Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 12:04:33PM -0400, Andrey Grodzovsky wrote: > > > > > > > > > On 2021-04-29 7:32 a.m., Daniel Vetter wrote: > > > > On Thu, Apr 29, 2021 at 01:23:19P

Re: [RFC PATCH 0/3] A drm_plane API to support HDR planes

2021-04-30 Thread Shashank Sharma
Hello Pekka, On 30/04/21 15:13, Pekka Paalanen wrote: > On Wed, 28 Apr 2021 13:24:27 +0530 > Shashank Sharma wrote: > >> Assuming these details, A compositor will look for DRM color properties like >> these: >> >> 1. Degamma plane property : To make buffers linear for Gamut mapping >> >> 2. Gamu

[PATCH v5 1/9] drm/format-helper: Pass destination pitch to drm_fb_memcpy_dstclip()

2021-04-30 Thread Thomas Zimmermann
The memcpy's destination buffer might have a different pitch than the source. Support different pitches as function argument. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Acked-by: Maxime Ripard Tested-by: nerdopolis --- drivers/gpu/drm/drm_format_helper.c| 9 + dri

[PATCH v5 0/9] drm: Support simple-framebuffer devices and firmware fbs

2021-04-30 Thread Thomas Zimmermann
This patchset adds support for simple-framebuffer platform devices and a handover mechanism for native drivers to take-over control of the hardware. The new driver, called simpledrm, binds to a simple-framebuffer platform device. The kernel's boot code creates such devices for firmware-provided fr

[PATCH v5 6/9] drm/simpledrm: Initialize framebuffer data from device-tree node

2021-04-30 Thread Thomas Zimmermann
A firmware framebuffer might also be specified via device-tree files. If no device platform data is given, try the DT device node. v2: * add Device Tree match table * clean-up parser wrappers Signed-off-by: Thomas Zimmermann Acked-by: Maxime Ripard Tested-by: nerdopolis --- dr

[PATCH v5 5/9] drm/simpledrm: Add fbdev emulation

2021-04-30 Thread Thomas Zimmermann
This displays a console on simpledrm's framebuffer. The default framebuffer format is being used. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Acked-by: Maxime Ripard Tested-by: nerdopolis --- drivers/gpu/drm/tiny/simpledrm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v5 9/9] drm/simpledrm: Acquire memory aperture for framebuffer

2021-04-30 Thread Thomas Zimmermann
We register the simplekms device with the DRM platform helpers. A native driver for the graphics hardware will kick-out the simpledrm driver before taking over the device. The original generic platform device from the simple-framebuffer boot code will be unregistered. The native driver will use wh

[PATCH v5 2/9] drm/format-helper: Add blitter functions

2021-04-30 Thread Thomas Zimmermann
The blitter functions copy a framebuffer to I/O memory using one of the existing conversion functions. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Acked-by: Maxime Ripard Tested-by: nerdopolis --- drivers/gpu/drm/drm_format_helper.c | 87 + include/

[PATCH v5 8/9] drm/simpledrm: Acquire regulators from DT device node

2021-04-30 Thread Thomas Zimmermann
Make sure required hardware regulators are enabled while the firmware framebuffer is in use. The basic code has been taken from the simplefb driver and adapted to DRM. Regulators are released automatically via devres helpers. v2: * use strscpy() Signed-off-by: Thomas Zimmermann Acked-by

[PATCH v5 4/9] drm: Add simpledrm driver

2021-04-30 Thread Thomas Zimmermann
The simpledrm driver is a DRM driver for simple-framebuffer framebuffers as provided by the kernel's boot code. This driver enables basic graphical output on many different graphics devices that are provided by the platform (e.g., EFI, VESA, embedded framebuffers). With the kernel's simple-framebu

[PATCH v5 7/9] drm/simpledrm: Acquire clocks from DT device node

2021-04-30 Thread Thomas Zimmermann
Make sure required hardware clocks are enabled while the firmware framebuffer is in use. The basic code has been taken from the simplefb driver and adapted to DRM. Clocks are released automatically via devres helpers. Signed-off-by: Thomas Zimmermann Acked-by: Maxime Ripard Tested-by: nerdopoli

[PATCH v5 3/9] drm/aperture: Add infrastructure for aperture ownership

2021-04-30 Thread Thomas Zimmermann
Platform devices might operate on firmware framebuffers, such as VESA or EFI. Before a native driver for the graphics hardware can take over the device, it has to remove any platform driver that operates on the firmware framebuffer. Aperture helpers provide the infrastructure for platform drivers t

Re: [PATCH] SPI: meson-spifc add missed calls to remove function

2021-04-30 Thread Mark Brown
On Fri, Apr 30, 2021 at 04:49:35PM +0800, Art Nikpal wrote: > Yep! but Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is bei

Re: [Intel-gfx] [PATCH 1/2] drm/i915/overlay: Fix active retire callback alignment

2021-04-30 Thread Tvrtko Ursulin
On 29/04/2021 18:31, Ville Syrjälä wrote: On Thu, Apr 29, 2021 at 07:31:43PM +0300, Ville Syrjälä wrote: On Thu, Apr 29, 2021 at 09:35:29AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin __i915_active_call annotation is required on the retire callback to ensure correct function alignment.

Re: [Intel-gfx] [PATCH 03/21] drm/i915/gem: Set the watchdog timeout directly in intel_context_set_gem

2021-04-30 Thread Tvrtko Ursulin
On 29/04/2021 15:54, Jason Ekstrand wrote: On Thu, Apr 29, 2021 at 3:04 AM Tvrtko Ursulin wrote: On 28/04/2021 18:24, Jason Ekstrand wrote: On Wed, Apr 28, 2021 at 10:55 AM Tvrtko Ursulin wrote: On 23/04/2021 23:31, Jason Ekstrand wrote: Instead of handling it like a context param, unco

Re: [PATCH 05/13] drm/ttm: allocate resource object instead of embedding it

2021-04-30 Thread Matthew Auld
On Fri, 30 Apr 2021 at 10:25, Christian König wrote: > > To improve the handling we want the establish the resource object as base > class for the backend allocations. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +- > drivers/gpu/drm/amd/amdgpu/amdg

Re: [PATCH 1/9] drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector

2021-04-30 Thread Hans de Goede
Hi, On 4/29/21 9:09 PM, Daniel Vetter wrote: > On Thu, Apr 29, 2021 at 02:33:17PM +0200, Hans de Goede wrote: >> Hi, >> >> On 4/29/21 2:04 PM, Daniel Vetter wrote: >>> On Thu, Apr 29, 2021 at 01:54:46PM +0200, Greg Kroah-Hartman wrote: On Thu, Apr 29, 2021 at 01:40:28PM +0200, Daniel Vetter w

Re: [PATCH 1/9] drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector

2021-04-30 Thread Daniel Vetter
On Fri, Apr 30, 2021 at 1:28 PM Hans de Goede wrote: > > Hi, > > On 4/29/21 9:09 PM, Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 02:33:17PM +0200, Hans de Goede wrote: > >> Hi, > >> > >> On 4/29/21 2:04 PM, Daniel Vetter wrote: > >>> On Thu, Apr 29, 2021 at 01:54:46PM +0200, Greg Kroah-Hartma

Re: [Intel-gfx] [PATCH 09/21] drm/i915/gem: Disallow creating contexts with too many engines

2021-04-30 Thread Tvrtko Ursulin
On 29/04/2021 20:16, Jason Ekstrand wrote: On Thu, Apr 29, 2021 at 3:01 AM Tvrtko Ursulin wrote: On 28/04/2021 18:09, Jason Ekstrand wrote: On Wed, Apr 28, 2021 at 9:26 AM Tvrtko Ursulin wrote: On 28/04/2021 15:02, Daniel Vetter wrote: On Wed, Apr 28, 2021 at 11:42:31AM +0100, Tvrtko Ursu

Re: [PATCH v3 1/3] drm/bridge: nwl-dsi: Force a full modeset when crtc_state->active is changed to be true

2021-04-30 Thread Liu Ying
Hi Robert, On Fri, 2021-04-30 at 11:56 +0200, Robert Foss wrote: > Hey Liu, > > This patch does not apply on upstream-drm-misc/drm-misc-next. When it > passes local testing & building, I'm ready to merge it. I see Neil has already pushed this entire patch series to drm-misc-next. https://cgit.

Re: [Intel-gfx] [PATCH] drm/i915: Be more gentle with exiting non-persistent context

2021-04-30 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 10:46:40AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > When a non-persistent context exits we currently mark it as banned in > order to trigger fast termination of any outstanding GPU jobs it may have > left running. > > In doing so we apply a very strict 1ms

Re: [PATCH v3 1/3] drm/bridge: nwl-dsi: Force a full modeset when crtc_state->active is changed to be true

2021-04-30 Thread Robert Foss
Even better :) On Fri, Apr 30, 2021, 13:46 Liu Ying wrote: > Hi Robert, > > On Fri, 2021-04-30 at 11:56 +0200, Robert Foss wrote: > > Hey Liu, > > > > This patch does not apply on upstream-drm-misc/drm-misc-next. When it > > passes local testing & building, I'm ready to merge it. > > I see Neil

Re: [PATCH 1/2] drm/i915/overlay: Fix active retire callback alignment

2021-04-30 Thread Daniel Vetter
On Thu, Apr 29, 2021 at 06:34:51PM +0100, Tvrtko Ursulin wrote: > > On 29/04/2021 17:31, Ville Syrjälä wrote: > > On Thu, Apr 29, 2021 at 09:35:29AM +0100, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > __i915_active_call annotation is required on the retire callback to ensure > >

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-30 Thread Tvrtko Ursulin
On 30/04/2021 07:53, Daniel Vetter wrote: On Thu, Apr 29, 2021 at 11:35 PM Jason Ekstrand wrote: On Thu, Apr 29, 2021 at 2:07 PM Daniel Vetter wrote: On Thu, Apr 29, 2021 at 02:01:16PM -0500, Jason Ekstrand wrote: On Thu, Apr 29, 2021 at 1:56 PM Daniel Vetter wrote: On Thu, Apr 29, 202

Re: [PATCH 02/13] drm/ttm: always initialize the full ttm_resource

2021-04-30 Thread Matthew Auld
On Fri, 30 Apr 2021 at 10:25, Christian König wrote: > > Init all fields in ttm_resource_alloc() when we create a new resource. > > Signed-off-by: Christian König > Reviewed-by: Matthew Auld > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 -- > drivers/gpu/drm/ttm/ttm_bo.c| 26

Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-30 Thread Kevin Tang
Cc Robin & Joerg Maxime Ripard 于2021年4月30日周五 下午5:22写道: > > On Sun, Apr 25, 2021 at 08:36:05PM +0800, Kevin Tang wrote: > > Adds DPU(Display Processor Unit) support for the Unisoc's display > > subsystem. > > It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. > > > > v2:

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-30 Thread Daniel Vetter
On Fri, Apr 30, 2021 at 1:58 PM Tvrtko Ursulin wrote: > > > On 30/04/2021 07:53, Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 11:35 PM Jason Ekstrand > > wrote: > >> > >> On Thu, Apr 29, 2021 at 2:07 PM Daniel Vetter wrote: > >>> > >>> On Thu, Apr 29, 2021 at 02:01:16PM -0500, Jason Ekstran

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-30 Thread Tvrtko Ursulin
On 30/04/2021 13:30, Daniel Vetter wrote: On Fri, Apr 30, 2021 at 1:58 PM Tvrtko Ursulin wrote: On 30/04/2021 07:53, Daniel Vetter wrote: On Thu, Apr 29, 2021 at 11:35 PM Jason Ekstrand wrote: On Thu, Apr 29, 2021 at 2:07 PM Daniel Vetter wrote: On Thu, Apr 29, 2021 at 02:01:16PM -050

Re: [PATCH 02/13] drm/ttm: always initialize the full ttm_resource

2021-04-30 Thread Christian König
Am 30.04.21 um 14:05 schrieb Matthew Auld: On Fri, 30 Apr 2021 at 10:25, Christian König wrote: Init all fields in ttm_resource_alloc() when we create a new resource. Signed-off-by: Christian König Reviewed-by: Matthew Auld --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 -- drivers/gpu/

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-30 Thread Daniel Vetter
On Fri, Apr 30, 2021 at 2:44 PM Tvrtko Ursulin wrote: > > > > On 30/04/2021 13:30, Daniel Vetter wrote: > > On Fri, Apr 30, 2021 at 1:58 PM Tvrtko Ursulin > > wrote: > >> On 30/04/2021 07:53, Daniel Vetter wrote: > >>> On Thu, Apr 29, 2021 at 11:35 PM Jason Ekstrand > >>> wrote: > > O

Re: [PATCH 06/13] drm/ttm: flip over the range manager to self allocated nodes

2021-04-30 Thread Matthew Auld
On Fri, 30 Apr 2021 at 10:25, Christian König wrote: > > Start with the range manager to make the resource object the base > class for the allocated nodes. > > While at it cleanup a lot of the code around that. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c |

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-30 Thread Tvrtko Ursulin
On 30/04/2021 14:07, Daniel Vetter wrote: On Fri, Apr 30, 2021 at 2:44 PM Tvrtko Ursulin wrote: On 30/04/2021 13:30, Daniel Vetter wrote: On Fri, Apr 30, 2021 at 1:58 PM Tvrtko Ursulin wrote: On 30/04/2021 07:53, Daniel Vetter wrote: On Thu, Apr 29, 2021 at 11:35 PM Jason Ekstrand wrote:

Re: [PATCH 07/13] drm/ttm: flip over the sys manager to self allocated nodes

2021-04-30 Thread Matthew Auld
On Fri, 30 Apr 2021 at 10:25, Christian König wrote: > > Make sure to allocate a resource object here. > > Signed-off-by: Christian König Ok, I guess I have to keep reading, Reviewed-by: Matthew Auld > --- > drivers/gpu/drm/ttm/ttm_sys_manager.c | 7 +++ > 1 file changed, 7 insertions(+)

Re: [Intel-gfx] [PATCH] drm/i915: Be more gentle with exiting non-persistent context

2021-04-30 Thread Tvrtko Ursulin
On 30/04/2021 12:48, Daniel Vetter wrote: On Thu, Apr 29, 2021 at 10:46:40AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin When a non-persistent context exits we currently mark it as banned in order to trigger fast termination of any outstanding GPU jobs it may have left running. In doi

Re: [PATCH 1/9] drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector

2021-04-30 Thread Hans de Goede
Hi, On 4/30/21 1:38 PM, Daniel Vetter wrote: > On Fri, Apr 30, 2021 at 1:28 PM Hans de Goede wrote: >> >> Hi, >> >> On 4/29/21 9:09 PM, Daniel Vetter wrote: >>> On Thu, Apr 29, 2021 at 02:33:17PM +0200, Hans de Goede wrote: Hi, On 4/29/21 2:04 PM, Daniel Vetter wrote: > On Thu,

Re: [PATCH 1/9] drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector

2021-04-30 Thread Hans de Goede
p.s. On 4/30/21 1:38 PM, Daniel Vetter wrote: Offtopic: > I'm also not sure why we have to use the kdev stuff here. For other > random objects we need to look up we're building that functionality on > that object. It means you need to keep another list_head around for > that lookup, but that's r

[PATCH v2] drm/i915: Be more gentle with exiting non-persistent context

2021-04-30 Thread Tvrtko Ursulin
From: Tvrtko Ursulin When a non-persistent context exits we currently mark it as banned in order to trigger fast termination of any outstanding GPU jobs it may have left running. In doing so we apply a very strict 1ms limit in which the left over job has to preempt before we issues an engine res

Re: [PATCH 1/9] drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector

2021-04-30 Thread Daniel Vetter
On Fri, Apr 30, 2021 at 3:32 PM Hans de Goede wrote: > > Hi, > > On 4/30/21 1:38 PM, Daniel Vetter wrote: > > On Fri, Apr 30, 2021 at 1:28 PM Hans de Goede wrote: > >> > >> Hi, > >> > >> On 4/29/21 9:09 PM, Daniel Vetter wrote: > >>> On Thu, Apr 29, 2021 at 02:33:17PM +0200, Hans de Goede wrote:

Re: [Intel-gfx] [PATCH] drm/i915: Be more gentle with exiting non-persistent context

2021-04-30 Thread Daniel Vetter
On Fri, Apr 30, 2021 at 3:27 PM Tvrtko Ursulin wrote: > On 30/04/2021 12:48, Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 10:46:40AM +0100, Tvrtko Ursulin wrote: > >> From: Tvrtko Ursulin > >> > >> When a non-persistent context exits we currently mark it as banned in > >> order to trigger fas

[PATCH] drm: log errors in drm_gem_fb_init_with_funcs

2021-04-30 Thread Simon Ser
Let the user know what went wrong in drm_gem_fb_init_with_funcs failure paths. Signed-off-by: Simon Ser Cc: Daniel Vetter Cc: Sam Ravnborg Cc: Noralf Trønnes Cc: Andrzej Pietrasiewicz --- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-)

Re: [PATCH 09/13] drm/amdgpu: switch the GTT backend to self alloc

2021-04-30 Thread Matthew Auld
On Fri, 30 Apr 2021 at 10:25, Christian König wrote: > > Similar to the TTM range manager. > > Signed-off-by: Christian König Reviewed-by: Matthew Auld ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/lis

Re: [PATCH] drm: log errors in drm_gem_fb_init_with_funcs

2021-04-30 Thread Michel Dänzer
On 2021-04-30 4:40 p.m., Simon Ser wrote: > Let the user know what went wrong in drm_gem_fb_init_with_funcs > failure paths. > > Signed-off-by: Simon Ser > Cc: Daniel Vetter > Cc: Sam Ravnborg > Cc: Noralf Trønnes > Cc: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/drm_gem_framebuffer_helper

Re: [PATCH 10/13] drm/amdgpu: switch the VRAM backend to self alloc

2021-04-30 Thread Matthew Auld
On Fri, 30 Apr 2021 at 10:25, Christian König wrote: > > Similar to the TTM range manager. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 51 > 1 file changed, 30 insertions(+), 21 deletions(-) > > diff --git a/drivers/gpu/drm/amd/a

Re: [PATCH 11/13] drm/nouveau: switch the TTM backends to self alloc

2021-04-30 Thread Matthew Auld
On Fri, 30 Apr 2021 at 10:25, Christian König wrote: > > Similar to the TTM range manager. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/nouveau/nouveau_mem.h | 1 + > drivers/gpu/drm/nouveau/nouveau_ttm.c | 4 > 2 files changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm

Re: [PATCH 07/13] drm/ttm: flip over the sys manager to self allocated nodes

2021-04-30 Thread Matthew Auld
On Fri, 30 Apr 2021 at 10:25, Christian König wrote: > > Make sure to allocate a resource object here. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/ttm/ttm_sys_manager.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/ttm/ttm_sys_manager.c > b/drive

Re: [v3 1/2] dt-bindings: backlight: add DisplayPort aux backlight

2021-04-30 Thread rajeevny
On 30-04-2021 02:33, Doug Anderson wrote: Hi, On Thu, Apr 29, 2021 at 11:04 AM Rob Herring wrote: On Mon, Apr 26, 2021 at 11:29:15AM +0530, Rajeev Nandan wrote: > Add bindings for DisplayPort aux backlight driver. > > Changes in v2: > - New > > Signed-off-by: Rajeev Nandan > --- > .../bindi

RE: Radeon NI: GIT kernel with the nislands_smc commit doesn't boot on a Freescale P5040 board and P.A.Semi Nemo board

2021-04-30 Thread Deucher, Alexander
[AMD Public Use] + Gustavo, amd-gfx > -Original Message- > From: Christian Zigotzky > Sent: Friday, April 30, 2021 8:00 AM > To: gustavo...@kernel.org; Deucher, Alexander > > Cc: R.T.Dickinson ; Darren Stevens zone.net>; mad skateman ; linuxppc-dev > ; Olof Johansson ; > Maling list

Re: [PATCH] drm: log errors in drm_gem_fb_init_with_funcs

2021-04-30 Thread Ville Syrjälä
On Fri, Apr 30, 2021 at 02:40:02PM +, Simon Ser wrote: > Let the user know what went wrong in drm_gem_fb_init_with_funcs > failure paths. > > Signed-off-by: Simon Ser > Cc: Daniel Vetter > Cc: Sam Ravnborg > Cc: Noralf Trønnes > Cc: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/drm_gem_f

Re: [Intel-gfx] [PATCH 03/21] drm/i915/gem: Set the watchdog timeout directly in intel_context_set_gem

2021-04-30 Thread Jason Ekstrand
On Fri, Apr 30, 2021 at 6:18 AM Tvrtko Ursulin wrote: > > > On 29/04/2021 15:54, Jason Ekstrand wrote: > > On Thu, Apr 29, 2021 at 3:04 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 28/04/2021 18:24, Jason Ekstrand wrote: > >>> On Wed, Apr 28, 2021 at 10:55 AM Tvrtko Ursulin > >>> wrote: >

Re: [Intel-gfx] [PATCH 09/21] drm/i915/gem: Disallow creating contexts with too many engines

2021-04-30 Thread Jason Ekstrand
On Fri, Apr 30, 2021 at 6:40 AM Tvrtko Ursulin wrote: > > > On 29/04/2021 20:16, Jason Ekstrand wrote: > > On Thu, Apr 29, 2021 at 3:01 AM Tvrtko Ursulin > > wrote: > >> On 28/04/2021 18:09, Jason Ekstrand wrote: > >>> On Wed, Apr 28, 2021 at 9:26 AM Tvrtko Ursulin > >>> wrote: > On 28/04/2

Re: [PATCH v5 15/27] drm/scheduler: Fix hang when sched_entity released

2021-04-30 Thread Andrey Grodzovsky
On 2021-04-30 2:47 a.m., Christian König wrote: Am 29.04.21 um 19:06 schrieb Andrey Grodzovsky: On 2021-04-29 3:18 a.m., Christian König wrote: I need to take another look at this part when I don't have a massive headache any more. Maybe split the patch set up into different parts, some

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-30 Thread Jason Ekstrand
On Fri, Apr 30, 2021 at 1:53 AM Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 11:35 PM Jason Ekstrand wrote: > > > > On Thu, Apr 29, 2021 at 2:07 PM Daniel Vetter wrote: > > > > > > On Thu, Apr 29, 2021 at 02:01:16PM -0500, Jason Ekstrand wrote: > > > > On Thu, Apr 29, 2021 at 1:56 PM Daniel

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-30 Thread Daniel Vetter
On Fri, Apr 30, 2021 at 6:27 PM Jason Ekstrand wrote: > > On Fri, Apr 30, 2021 at 1:53 AM Daniel Vetter wrote: > > > > On Thu, Apr 29, 2021 at 11:35 PM Jason Ekstrand > > wrote: > > > > > > On Thu, Apr 29, 2021 at 2:07 PM Daniel Vetter wrote: > > > > > > > > On Thu, Apr 29, 2021 at 02:01:16PM

Re: [PATCH v3 10/11] drm: Use state helper instead of the plane state pointer

2021-04-30 Thread Rob Clark
On Thu, Apr 8, 2021 at 6:20 AM Maxime Ripard wrote: > > Hi Stephen, > > On Tue, Mar 30, 2021 at 11:56:15AM -0700, Stephen Boyd wrote: > > Quoting Maxime Ripard (2021-03-30 08:35:27) > > > Hi Stephen, > > > > > > On Mon, Mar 29, 2021 at 06:52:01PM -0700, Stephen Boyd wrote: > > > > Trimming Cc list

Re: [PATCH] drm/i915/display Try YCbCr420 color when RGB fails

2021-04-30 Thread Ville Syrjälä
On Thu, Apr 29, 2021 at 02:05:53PM +0200, Werner Sembach wrote: > When encoder validation of a display mode fails, retry with less bandwidth > heavy YCbCr420 color mode, if available. This enables some HDMI 1.4 setups > to support 4k60Hz output, which previously failed silently. > > AMDGPU had nea

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-30 Thread Jason Ekstrand
On Fri, Apr 30, 2021 at 11:33 AM Daniel Vetter wrote: > > On Fri, Apr 30, 2021 at 6:27 PM Jason Ekstrand wrote: > > > > On Fri, Apr 30, 2021 at 1:53 AM Daniel Vetter wrote: > > > > > > On Thu, Apr 29, 2021 at 11:35 PM Jason Ekstrand > > > wrote: > > > > > > > > On Thu, Apr 29, 2021 at 2:07 PM

Re: Radeon NI: GIT kernel with the nislands_smc commit doesn't boot on a Freescale P5040 board and P.A.Semi Nemo board

2021-04-30 Thread Gustavo A. R. Silva
On 4/30/21 10:26, Deucher, Alexander wrote: > [AMD Public Use] > > + Gustavo, amd-gfx > >> -Original Message- >> From: Christian Zigotzky >> Sent: Friday, April 30, 2021 8:00 AM >> To: gustavo...@kernel.org; Deucher, Alexander >> >> Cc: R.T.Dickinson ; Darren Stevens > zone.net>; mad

Re: [Intel-gfx] [PATCH 16/21] drm/i915/gem: Delay context creation

2021-04-30 Thread Daniel Vetter
On Fri, Apr 30, 2021 at 6:57 PM Jason Ekstrand wrote: > > On Fri, Apr 30, 2021 at 11:33 AM Daniel Vetter wrote: > > > > On Fri, Apr 30, 2021 at 6:27 PM Jason Ekstrand wrote: > > > > > > On Fri, Apr 30, 2021 at 1:53 AM Daniel Vetter wrote: > > > > > > > > On Thu, Apr 29, 2021 at 11:35 PM Jason E

  1   2   >