Re: [PATCH] drm: bridge: add missing word in Analogix help text

2021-04-26 Thread Neil Armstrong
Le 24/04/2021 à 08:18, Randy Dunlap a écrit : > Insert a missing word "power" in Kconfig help text. > > Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support") > Signed-off-by: Randy Dunlap > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Robert Foss > Cc: David Airlie > Cc: Daniel V

[RESEND PATCH v6 1/4] mfd: rt4831: Adds support for Richtek RT4831

2021-04-26 Thread cy_huang
From: ChiYuan Huang This adds support Richtek RT4831 core. It includes four channel WLED driver and Display Bias Voltage outputs. Signed-off-by: ChiYuan Huang --- Resend this v6 patch series to loop devicetree reviewers. The RT4831 regulator patches are already on main stream, and can be refer

[RESEND PATCH v6 3/4] mfd: rt4831: Adds DT binding document for Richtek RT4831

2021-04-26 Thread cy_huang
From: ChiYuan Huang Adds DT binding document for Richtek RT4831. Signed-off-by: ChiYuan Huang --- Resend this v6 patch series to loop devicetree reviewers. --- .../devicetree/bindings/mfd/richtek,rt4831.yaml| 90 ++ 1 file changed, 90 insertions(+) create mode 100644 D

[RESEND PATCH v6 2/4] backlight: rt4831: Adds DT binding document for Richtek RT4831 backlight

2021-04-26 Thread cy_huang
From: ChiYuan Huang Adds DT binding document for Richtek RT4831 backlight. Signed-off-by: ChiYuan Huang Reviewed-by: Daniel Thompson --- Resend this v6 patch series to loop devicetree reviewers. For next, need to add the below line Reviewed-by: Daniel Thompson --- .../leds/backlight/richtek

[RESEND PATCH v6 4/4] backlight: rt4831: Adds support for Richtek RT4831 backlight

2021-04-26 Thread cy_huang
From: ChiYuan Huang Adds support for Richtek RT4831 backlight. Signed-off-by: ChiYuan Huang Reviewed-by: Daniel Thompson --- Resend this v6 patch series to loop devicetree reviewers. For next, if the typo in Kconfig 'common' to 'commonly' can be added the below line Reviewed-by: Daniel Thomp

Re: [PULL] drm-misc-next-fixes

2021-04-26 Thread Maxime Ripard
Hi Alex, On Thu, Apr 22, 2021 at 12:40:10PM -0400, Alex Deucher wrote: > On Thu, Apr 22, 2021 at 12:33 PM Maxime Ripard wrote: > > > > Hi Dave, Daniel, > > > > Here's this week drm-misc-next-fixes PR, for the next merge window > > > > Can we also cherry-pick this patch: > https://cgit.freedeskto

Re: [PATCH v2 1/1] drm/doc: document drm_mode_get_plane

2021-04-26 Thread Pekka Paalanen
On Fri, 23 Apr 2021 18:30:33 -0300 Leandro Ribeiro wrote: > On 4/23/21 8:11 AM, Pekka Paalanen wrote: > > On Thu, 22 Apr 2021 15:10:04 -0300 > > Leandro Ribeiro wrote: > > > >> Add a small description and document struct fields of > >> drm_mode_get_plane. > >> > >> Signed-off-by: Leandro Ribe

Re: [PATCH 1/2] drm/tegra: Get ref for DP AUX channel, not its ddc adapter

2021-04-26 Thread Thierry Reding
On Fri, Apr 23, 2021 at 02:21:45PM -0400, Lyude Paul wrote: > While we're taking a reference of the DDC adapter for a DP AUX channel in > tegra_sor_probe() because we're going to be using that adapter with the > SOR, now that we've moved where AUX registration happens the actual device > structure

Re: [PATCH] drm: bridge: add missing word in Analogix help text

2021-04-26 Thread Robert Foss
On Mon, Apr 26, 2021, 09:15 Neil Armstrong wrote: > > > Le 24/04/2021 à 08:18, Randy Dunlap a écrit : > > Insert a missing word "power" in Kconfig help text. > > > > Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support") > > Signed-off-by: Randy Dunlap > > Cc: Andrzej Hajda > > Cc: Ne

Re: [PATCH v3 0/3] drm/bridge: nwl-dsi: Get MIPI DSI controller and PHY ready in ->mode_set()

2021-04-26 Thread Neil Armstrong
Hi, On 23/04/2021 11:26, Liu Ying wrote: > Hi, > > This series aims to make the nwl-dsi bridge be able to connect with > more MIPI DSI panels. Some MIPI DSI panel drivers like 'raydium,rm68200' > send MIPI_DCS_SET_DISPLAY_ON commands in panel_funcs->prepare(), which > requires the MIPI DSI contr

Re: [PATCH] drm/vkms: update the current status of todo list

2021-04-26 Thread Melissa Wen
On 04/25, Simon Ser wrote: > On Saturday, April 24th, 2021 at 3:57 PM, Melissa Wen > wrote: > > > -- Real overlay planes, not just cursor. > > Maybe we should mention "multiple overlay planes" as a good task? Sure. I'll include it. Thanks for taking a look and pointing it out. Melissa > >

Re: [PATCH v4 3/4] drm/vkms: add XRGB planes composition

2021-04-26 Thread Pekka Paalanen
On Sat, 24 Apr 2021 05:25:31 -0300 Melissa Wen wrote: > Add support for composing XRGB888 planes in addition to the ARGB > format. In the case of an XRGB plane at the top, the composition consists > of copying the RGB values of a pixel from src to dst and clearing alpha > channel, without the

Re: [PATCH v4 4/4] drm/vkms: add overlay support

2021-04-26 Thread Pekka Paalanen
On Sat, 24 Apr 2021 05:26:10 -0300 Melissa Wen wrote: > Add support to overlay plane, in addition to primary and cursor > planes. In this approach, the plane composition still requires an > active primary plane and planes are composed associatively in the > order: (primary <- overlay) <- cursor >

Re: [Intel-gfx] [PATCH 11/19] drm/i915: Update the helper to set correct mapping

2021-04-26 Thread Matthew Auld
On Wed, 21 Apr 2021 at 20:13, Matthew Auld wrote: > > On Wed, 21 Apr 2021 at 16:41, Tvrtko Ursulin > wrote: > > > > > > On 21/04/2021 12:42, Matthew Auld wrote: > > > On 19/04/2021 16:01, Tvrtko Ursulin wrote: > > >> > > >> On 19/04/2021 15:37, Matthew Auld wrote: > > >>> On 19/04/2021 15:07, Tvr

Re: [PATCH] drm: bridge: add missing word in Analogix help text

2021-04-26 Thread Neil Armstrong
On 26/04/2021 09:42, Robert Foss wrote: > > > On Mon, Apr 26, 2021, 09:15 Neil Armstrong > wrote: > > > > Le 24/04/2021 à 08:18, Randy Dunlap a écrit : > > Insert a missing word "power" in Kconfig help text. > > > > Fixes: 6aa192698089 ("drm/bri

Re: [Intel-gfx] [PATCH 11/19] drm/i915: Update the helper to set correct mapping

2021-04-26 Thread Tvrtko Ursulin
On 26/04/2021 09:57, Matthew Auld wrote: On Wed, 21 Apr 2021 at 20:13, Matthew Auld wrote: On Wed, 21 Apr 2021 at 16:41, Tvrtko Ursulin wrote: On 21/04/2021 12:42, Matthew Auld wrote: On 19/04/2021 16:01, Tvrtko Ursulin wrote: On 19/04/2021 15:37, Matthew Auld wrote: On 19/04/2021 15

[Bug 212469] plymouth animation freezes during shutdown

2021-04-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212469 DieKleene (mail2021a...@detlef-pogrzeba.de) changed: What|Removed |Added CC||mail2021ac62

[PATCH 1/9] drm/doc/rfc: i915 DG1 uAPI

2021-04-26 Thread Matthew Auld
Add an entry for the new uAPI needed for DG1. Also add the overall upstream plan, including some notes for the TTM conversion. v2(Daniel): - include the overall upstreaming plan - add a note for mmap, there are differences here for TTM vs i915 - bunch of other suggestions from Daniel v3: (D

[PATCH 5/9] drm/i915/uapi: introduce drm_i915_gem_create_ext

2021-04-26 Thread Matthew Auld
Same old gem_create but with now with extensions support. This is needed to support various upcoming usecases. v2:(Chris) - Use separate ioctl number for gem_create_ext, instead of hijacking the existing gem_create ioctl, otherwise we run into the issue with being unable to detect

[PATCH 4/9] drm/i915: rework gem_create flow for upcoming extensions

2021-04-26 Thread Matthew Auld
With the upcoming gem_create_ext we want to be able create a "vanilla" object upfront and pass that directly to the extensions, before actually initialising the object. Functionally this should be the same expect we now feed the object into the lower-level region specific init_object. Signed-off-b

[PATCH 2/9] drm/i915: mark stolen as private

2021-04-26 Thread Matthew Auld
In the next patch we want to expose the supported regions to userspace, which can then be fed into the gem_create_ext placement extensions. For now treat stolen memory as private from userspace pov. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Thomas Hellström Cc: Daniele Ceraolo Spurio

[PATCH 6/9] drm/i915/uapi: implement object placement extension

2021-04-26 Thread Matthew Auld
Add new extension to support setting an immutable-priority-list of potential placements, at creation time. If we use the normal gem_create or gem_create_ext without the extensions/placements then we still get the old behaviour with only placing the object in system memory. v2(Daniel & Jason):

[PATCH 3/9] drm/i915/query: Expose memory regions through the query uAPI

2021-04-26 Thread Matthew Auld
From: Abdiel Janulgue Returns the available memory region areas supported by the HW. v2(Daniel & Jason): - Add some kernel-doc, including example usage. - Drop all the extra rsvd Signed-off-by: Abdiel Janulgue Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Thomas Hellström Cc:

[PATCH 7/9] drm/i915/lmem: support optional CPU clearing for special internal use

2021-04-26 Thread Matthew Auld
For some internal device local-memory objects it would be useful to have an option to CPU clear the pages upon gathering the backing store. Note that this might be before the blitter is useable, which is the case for some internal GuC objects. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc:

[PATCH 8/9] drm/i915/gem: clear userspace buffers for LMEM

2021-04-26 Thread Matthew Auld
All userspace objects must be cleared when allocating the backing store, before they are potentially visible to userspace. For now use simple CPU based clearing to do this for device local-memory objects, note that in the near future this will instead use the blitter engine. Signed-off-by: Matthe

[PATCH 9/9] drm/i915/gem: hide new uAPI behind CONFIG_BROKEN

2021-04-26 Thread Matthew Auld
Treat it the same as the fake local-memory stuff, where it is disabled for normal kernels, in case some random UMD is tempted to use this. Once we have all the other bits and pieces in place, like the TTM conversion, we can turn this on for real. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen C

Re: Split render/display SoCs, Mesa's renderonly, and Wayland dmabuf hints

2021-04-26 Thread Simon Ser
Thanks for the feedback! Replying to both Daniels below. On Tuesday, April 20th, 2021 at 1:14 PM, Daniel Vetter wrote: > On Tue, Apr 20, 2021 at 12:18 PM Daniel Stone wrote: > > >> There are a few solutions: > >> > >> 1. Require compositors to discover the render device by trying to import > >

Re: [v3 2/2] backlight: Add DisplayPort aux backlight driver

2021-04-26 Thread Jani Nikula
On Mon, 26 Apr 2021, Rajeev Nandan wrote: > Add backlight driver for the panels supporting backlight control > using DPCD registers on the DisplayPort aux channel. No, please don't do this. I wrote you last week in reply to v1 why I thought merging this would not be a good idea [1]. Why have you

Re: [PATCH v13 0/4] drm/panfrost: Add support for mt8183 GPU

2021-04-26 Thread Neil Armstrong
Hi, On 21/04/2021 07:28, Nicolas Boichat wrote: > Hi! > > This is just a rebase of the v11, untested (but it seems like > Neil Armstrong recently tested it), with small changes in > binding and dts. v11 cover follows: > > Follow-up on the v5 [1], things have gotten significantly > better in the

Re: [RESEND PATCH v6 4/4] backlight: rt4831: Adds support for Richtek RT4831 backlight

2021-04-26 Thread Daniel Thompson
On Mon, Apr 26, 2021 at 03:18:11PM +0800, cy_huang wrote: > From: ChiYuan Huang > > Adds support for Richtek RT4831 backlight. > > Signed-off-by: ChiYuan Huang > Reviewed-by: Daniel Thompson > --- > Resend this v6 patch series to loop devicetree reviewers. > > For next, if the typo in Kconfig

[PATCH 2/7] drm/i915: Update the helper to set correct mapping

2021-04-26 Thread Matthew Auld
From: Venkata Sandeep Dhanalakota Determine the possible coherent map type based on object location, and if target has llc or if user requires an always coherent mapping. Cc: Matthew Auld Cc: CQ Tang Suggested-by: Michal Wajdeczko Signed-off-by: Venkata Sandeep Dhanalakota Signed-off-by: Mat

[PATCH 1/7] drm/i915/dg1: Fix mapping type for default state object

2021-04-26 Thread Matthew Auld
From: Venkata Ramana Nayana Use I915_MAP_WC when default state object is allocated in LMEM. Signed-off-by: Venkata Ramana Nayana Reviewed-by: Matthew Auld Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gt/shmem_utils.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --gi

[PATCH 4/7] drm/i915/gtt/dgfx: place the PD in LMEM

2021-04-26 Thread Matthew Auld
It's a requirement that for dgfx we place all the paging structures in device local-memory. v2: use i915_coherent_map_type() Signed-off-by: Matthew Auld Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 5 - drivers/gpu/drm/i915/gt/intel_gtt.c | 21 +++-- driv

[PATCH 3/7] drm/i915/gtt: map the PD up front

2021-04-26 Thread Matthew Auld
We need to general our accessor for the page directories and tables from using the simple kmap_atomic to support local memory, and this setup must be done on acquisition of the backing storage prior to entering fence execution contexts. Here we replace the kmap with the object maping code that for

[PATCH 5/7] drm/i915/fbdev: Use lmem physical addresses for fb_mmap() on discrete

2021-04-26 Thread Matthew Auld
From: Mohammed Khajapasha Use local memory io BAR address for fbdev's fb_mmap() operation on discrete, fbdev uses the physical address of our framebuffer for its fb_mmap() fn. Signed-off-by: Mohammed Khajapasha Reviewed-by: Matthew Auld Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/di

[PATCH 6/7] drm/i915/lmem: Bypass aperture when lmem is available

2021-04-26 Thread Matthew Auld
From: Anusha Srivatsa In the scenario where local memory is available, we have rely on CPU access via lmem directly instead of aperture. v2: gmch is only relevant for much older hw, therefore we can drop the has_aperture check since it should always be present on such platforms. (Chris) Cc: Vil

[PATCH 7/7] drm/i915: Return error value when bo not in LMEM for discrete

2021-04-26 Thread Matthew Auld
From: Mohammed Khajapasha Return EREMOTE value when frame buffer object is not backed by LMEM for discrete. If Local memory is supported by hardware the framebuffer backing gem objects should be from local memory. Signed-off-by: Mohammed Khajapasha Signed-off-by: Matthew Auld Reviewed-by: Tvrt

[PATCH v2] drm/amdgpu: Register VGA clients after init can no longer fail

2021-04-26 Thread Kai-Heng Feng
When an amdgpu device fails to init, it makes another VGA device cause kernel splat: kernel: amdgpu :08:00.0: amdgpu: amdgpu_device_ip_init failed kernel: amdgpu :08:00.0: amdgpu: Fatal error during GPU init kernel: amdgpu: probe of :08:00.0 failed with error -110 ... kernel: amdgpu 000

Re: [RESEND PATCH v6 4/4] backlight: rt4831: Adds support for Richtek RT4831 backlight

2021-04-26 Thread ChiYuan Huang
Hi, Daniel Thompson 於 2021年4月26日 週一 下午6:19寫道: > > On Mon, Apr 26, 2021 at 03:18:11PM +0800, cy_huang wrote: > > From: ChiYuan Huang > > > > Adds support for Richtek RT4831 backlight. > > > > Signed-off-by: ChiYuan Huang > > Reviewed-by: Daniel Thompson > > --- > > Resend this v6 patch series t

Re: [PATCH v2 1/1] drm/doc: document drm_mode_get_plane

2021-04-26 Thread Simon Ser
On Monday, April 26th, 2021 at 9:36 AM, Pekka Paalanen wrote: > > > This should probably explain what the bits in the mask correspond to. > > > As in, which CRTC does bit 0 refer to, and so on. > > > > What about: > > > > "possible_crtcs: Bitmask of CRTC's compatible with the plane. CRTC's are >

Re: [PATCH v2] drm/i915: Invoke BXT _DSM to enable MUX on HP Workstation laptops

2021-04-26 Thread Kai-Heng Feng
On Fri, Apr 23, 2021 at 3:35 PM Jani Nikula wrote: > > On Fri, 23 Apr 2021, Kai-Heng Feng wrote: > > On HP Fury G7 Workstations, graphics output is re-routed from Intel GFX > > to discrete GFX after S3. This is not desirable, because userspace will > > treat connected display as a new one, losing

Re: [REGRESSION] drm/etnaviv: command buffer outside valid memory window

2021-04-26 Thread Primoz Fiser
Hi all, we are still affected by this issue from 2019 on 5.10. For example when setting "cma=256M" on phycore imx6q with 2G ram we get: [   12.573276] etnaviv etnaviv: command buffer outside valid memory window [   12.616460] etnaviv etnaviv: command buffer outside valid memory window [   12.6

Re: [PATCH v2] drm/i915: Invoke BXT _DSM to enable MUX on HP Workstation laptops

2021-04-26 Thread Kai-Heng Feng
On Fri, Apr 23, 2021 at 8:41 PM Ville Syrjälä wrote: > > On Fri, Apr 23, 2021 at 12:46:54PM +0800, Kai-Heng Feng wrote: > > On HP Fury G7 Workstations, graphics output is re-routed from Intel GFX > > to discrete GFX after S3. This is not desirable, because userspace will > > treat connected displa

Re: [v2 2/2] backlight: Add DisplayPort aux backlight driver

2021-04-26 Thread Daniel Thompson
On Sat, Apr 24, 2021 at 03:25:04AM +0530, Rajeev Nandan wrote: > Add backlight driver for the panels supporting backlight control > using DPCD registers on the DisplayPort aux channel. > > Changes in v2: > - New (most of the code reused from drm_dp_aux_backlight.c of v1) Did you respond to Jani's

Re: [PATCH 2/2] drm/ttm: optimize the pool shrinker a bit v2

2021-04-26 Thread Christian König
Just a gentle ping? Are you ok with this explanation Andrew or should I look for a different approach? Thanks, Christian. Am 16.04.21 um 09:08 schrieb Christian König: Am 15.04.21 um 22:33 schrieb Andrew Morton: On Thu, 15 Apr 2021 13:56:24 +0200 "Christian König" wrote: @@ -530,6 +525,

Re: [PATCH v2] drm/i915: Invoke BXT _DSM to enable MUX on HP Workstation laptops

2021-04-26 Thread Jani Nikula
On Mon, 26 Apr 2021, Kai-Heng Feng wrote: > On Fri, Apr 23, 2021 at 3:35 PM Jani Nikula > wrote: >> >> On Fri, 23 Apr 2021, Kai-Heng Feng wrote: >> > On HP Fury G7 Workstations, graphics output is re-routed from Intel GFX >> > to discrete GFX after S3. This is not desirable, because userspace w

Re: [PATCH] SPI: meson-spifc add missed calls to remove function

2021-04-26 Thread Mark Brown
On Sat, Apr 24, 2021 at 07:57:19AM +0800, Art Nikpal wrote: > > I would expect the driver to unregister the controller at the start of > > the remove function, suspend doesn't really make sense here > It's strange - But without spi_master_suspend i have randomly stucks when i > try unload this mo

[PATCH][next] drm/amdkfd: Fix spelling mistake "unregisterd" -> "unregistered"

2021-04-26 Thread Colin King
From: Colin Ian King There is a spelling mistake in a pr_debug message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.

Re: [PATCH][next] drm/amdkfd: Fix spelling mistake "unregisterd" -> "unregistered"

2021-04-26 Thread Nirmoy
Reviewed-by: Nirmoy Das On 4/26/21 2:13 PM, Colin King wrote: From: Colin Ian King There is a spelling mistake in a pr_debug message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH v4 0/9] drm: Support simple-framebuffer devices and firmware fbs

2021-04-26 Thread Thomas Zimmermann
Hi Am 20.04.21 um 10:46 schrieb Daniel Vetter: On Mon, Apr 19, 2021 at 10:00:56AM +0200, Geert Uytterhoeven wrote: Hi Thomas, On Fri, Apr 16, 2021 at 11:00 AM Thomas Zimmermann wrote: This patchset adds support for simple-framebuffer platform devices and a handover mechanism for native drive

Re: [PATCH v4 0/9] drm: Support simple-framebuffer devices and firmware fbs

2021-04-26 Thread Thomas Zimmermann
Hi Am 20.04.21 um 11:27 schrieb Geert Uytterhoeven: Hi Gerd, On Tue, Apr 20, 2021 at 11:22 AM Gerd Hoffmann wrote: Patches 4 to 8 add the simpledrm driver. It's build on simple DRM helpers and SHMEM. It supports 16-bit, 24-bit and 32-bit RGB framebuffers. During if support for 8-bit fr

Re: [RESEND PATCH v6 4/4] backlight: rt4831: Adds support for Richtek RT4831 backlight

2021-04-26 Thread Daniel Thompson
On Mon, Apr 26, 2021 at 06:50:15PM +0800, ChiYuan Huang wrote: > Hi, > > Daniel Thompson 於 2021年4月26日 週一 下午6:19寫道: > > > > On Mon, Apr 26, 2021 at 03:18:11PM +0800, cy_huang wrote: > > > From: ChiYuan Huang > > > > > > Adds support for Richtek RT4831 backlight. > > > > > > Signed-off-by: ChiYuan

Re: [drm-intel:drm-intel-next 3/4] drivers/gpu/drm/i915/display/intel_dp_hdcp.c:582 intel_dp_hdcp2_read_msg() error: uninitialized symbol 'msg_end'.

2021-04-26 Thread Jani Nikula
On Fri, 02 Apr 2021, Dan Carpenter wrote: > tree: git://anongit.freedesktop.org/drm-intel drm-intel-next > head: b29854ec3b9ca6512a783e2153465f27a777a654 > commit: 989cf9a93892409cf8e84c30c0faaa522ac83807 [3/4] drm/i915/hdcp: Add DP > HDCP2.2 timeout to read entire msg > config: i386-randconf

Re: [PATCH] display: Fix typo issue

2021-04-26 Thread Jani Nikula
On Wed, 17 Mar 2021, zuoqil...@163.com wrote: > From: zuoqilin > > Change 'befor' to 'before'. > > Signed-off-by: zuoqilin Thanks, pushed, sorry for the delay. BR, Jani. > --- > drivers/gpu/drm/i915/display/vlv_dsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dri

[PATCH] drm/omap: Fix issue with clocks left on after resume

2021-04-26 Thread Tony Lindgren
On resume, dispc pm_runtime_force_resume() is not enabling the hardware as we pass the pm_runtime_need_not_resume() test as the device is suspended with no child devices. As the resume continues, omap_atomic_comit_tail() calls dispc_runtime_get() that calls rpm_resume() enabling the hardware, and

Re: [v3 2/2] backlight: Add DisplayPort aux backlight driver

2021-04-26 Thread rajeevny
On 26-04-2021 15:19, Jani Nikula wrote: On Mon, 26 Apr 2021, Rajeev Nandan wrote: Add backlight driver for the panels supporting backlight control using DPCD registers on the DisplayPort aux channel. No, please don't do this. I wrote you last week in reply to v1 why I thought merging this wo

Re: [PATCH v4 0/9] drm: Support simple-framebuffer devices and firmware fbs

2021-04-26 Thread Daniel Vetter
On Mon, Apr 26, 2021 at 02:18:05PM +0200, Thomas Zimmermann wrote: > Hi > > Am 20.04.21 um 10:46 schrieb Daniel Vetter: > > On Mon, Apr 19, 2021 at 10:00:56AM +0200, Geert Uytterhoeven wrote: > > > Hi Thomas, > > > > > > On Fri, Apr 16, 2021 at 11:00 AM Thomas Zimmermann > > > wrote: > > > > Th

Re: [PATCH 1/9] drm/doc/rfc: i915 DG1 uAPI

2021-04-26 Thread Jason Ekstrand
On Mon, Apr 26, 2021 at 4:42 AM Matthew Auld wrote: > > Add an entry for the new uAPI needed for DG1. Also add the overall > upstream plan, including some notes for the TTM conversion. > > v2(Daniel): > - include the overall upstreaming plan > - add a note for mmap, there are differences here

Re: [PATCH 3/7] drm/i915/gtt: map the PD up front

2021-04-26 Thread Tvrtko Ursulin
On 26/04/2021 11:18, Matthew Auld wrote: We need to general our accessor for the page directories and tables from Generalise? using the simple kmap_atomic to support local memory, and this setup must be done on acquisition of the backing storage prior to entering fence execution contexts. H

Re: [Mesa-dev] [PATCH v3 4/4] drm/doc/rfc: i915 DG1 uAPI

2021-04-26 Thread Jason Ekstrand
On Wed, Apr 21, 2021 at 2:23 PM Daniel Vetter wrote: > > On Wed, Apr 21, 2021 at 8:28 PM Tvrtko Ursulin > wrote: > > On 21/04/2021 18:17, Jason Ekstrand wrote: > > > On Wed, Apr 21, 2021 at 9:25 AM Tvrtko Ursulin > > > wrote: > > >> On 21/04/2021 14:54, Jason Ekstrand wrote: > > >>> On Wed, Apr

Re: [PATCH 4/7] drm/i915/gtt/dgfx: place the PD in LMEM

2021-04-26 Thread Tvrtko Ursulin
On 26/04/2021 11:18, Matthew Auld wrote: It's a requirement that for dgfx we place all the paging structures in device local-memory. v2: use i915_coherent_map_type() Signed-off-by: Matthew Auld Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 5 - drivers/gpu/drm/i915/g

[PATCH v3] drm/i915: Invoke another _DSM to enable MUX on HP Workstation laptops

2021-04-26 Thread Kai-Heng Feng
On HP Fury G7 Workstations, graphics output is re-routed from Intel GFX to discrete GFX after S3. This is not desirable, because userspace will treat connected display as a new one, losing display settings. The expected behavior is to let discrete GFX drives all external displays. The platform in

Re: [PATCH 1/9] drm/doc/rfc: i915 DG1 uAPI

2021-04-26 Thread Matthew Auld
On 26/04/2021 16:11, Jason Ekstrand wrote: On Mon, Apr 26, 2021 at 4:42 AM Matthew Auld wrote: Add an entry for the new uAPI needed for DG1. Also add the overall upstream plan, including some notes for the TTM conversion. v2(Daniel): - include the overall upstreaming plan - add a note f

Re: [PATCH v2 1/2] gpu: drm: init set panel orientation property earlier

2021-04-26 Thread Ville Syrjälä
On Mon, Apr 26, 2021 at 01:18:47PM +0800, Hsin-Yi Wang wrote: > drm_dev_register() sets connector->registration_state to > DRM_CONNECTOR_REGISTERED and dev->registered to true. If > drm_connector_set_panel_orientation() is first called after > drm_dev_register(), it will fail several checks and res

Re: [PATCH v2] drm/i915: Invoke BXT _DSM to enable MUX on HP Workstation laptops

2021-04-26 Thread Ville Syrjälä
On Mon, Apr 26, 2021 at 07:10:06PM +0800, Kai-Heng Feng wrote: > On Fri, Apr 23, 2021 at 8:41 PM Ville Syrjälä > wrote: > > > > On Fri, Apr 23, 2021 at 12:46:54PM +0800, Kai-Heng Feng wrote: > > > On HP Fury G7 Workstations, graphics output is re-routed from Intel GFX > > > to discrete GFX after S

Re: [PATCH 08/12] vfio/gvt: Convert to use vfio_register_group_dev()

2021-04-26 Thread Jason Gunthorpe
On Mon, Apr 26, 2021 at 04:13:55PM +0200, Christoph Hellwig wrote: > > diff --git a/drivers/vfio/mdev/Makefile b/drivers/vfio/mdev/Makefile > > index ff9ecd80212503..7c236ba1b90eb1 100644 > > +++ b/drivers/vfio/mdev/Makefile > > @@ -1,5 +1,5 @@ > > # SPDX-License-Identifier: GPL-2.0-only > > > >

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Rewrite CL/CTG L-shaped memory detection

2021-04-26 Thread Daniel Vetter
On Thu, Apr 22, 2021 at 04:11:22PM +0300, Ville Syrjälä wrote: > On Thu, Apr 22, 2021 at 11:49:43AM +0200, Daniel Vetter wrote: > > On Wed, Apr 21, 2021 at 06:34:01PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Currently we try to detect a symmetric memory configurations > >

Re: [Outreachy kernel] Re: [PATCH] drm/amd/amdgpu/amdgpu_drv.c: Replace drm_modeset_lock_all with drm_modeset_lock

2021-04-26 Thread Daniel Vetter
On Thu, Apr 22, 2021 at 05:50:34PM +0100, Matthew Wilcox wrote: > On Thu, Apr 22, 2021 at 05:59:51PM +0200, Fabio M. De Francesco wrote: > > - drm_modeset_lock_all(drm_dev); > > - > > drm_for_each_crtc(crtc, drm_dev) { > > + drm_modeset_lock(&crtc->mutex, NUL

Re: [PATCH] drm/drm_file.c: Define drm_send_event_helper() as 'static'

2021-04-26 Thread Daniel Vetter
On Thu, Apr 22, 2021 at 07:51:46PM +0200, Fabio M. De Francesco wrote: > drm_send_event_helper() has not prototype, it has internal linkage and > therefore it should be defined with storage class 'static'. > > Signed-off-by: Fabio M. De Francesco > --- > drivers/gpu/drm/drm_file.c | 2 +- > 1 fi

Re: [PATCH 3/7] drm/i915/gtt: map the PD up front

2021-04-26 Thread Matthew Auld
On 26/04/2021 16:20, Tvrtko Ursulin wrote: On 26/04/2021 11:18, Matthew Auld wrote: We need to general our accessor for the page directories and tables from Generalise? using the simple kmap_atomic to support local memory, and this setup must be done on acquisition of the backing storage pr

Re: [PATCH 1/9] drm/doc/rfc: i915 DG1 uAPI

2021-04-26 Thread Jason Ekstrand
On Mon, Apr 26, 2021 at 10:31 AM Matthew Auld wrote: > > On 26/04/2021 16:11, Jason Ekstrand wrote: > > On Mon, Apr 26, 2021 at 4:42 AM Matthew Auld wrote: > >> > >> Add an entry for the new uAPI needed for DG1. Also add the overall > >> upstream plan, including some notes for the TTM conversion.

Re: [PATCH v4 3/4] drm/vkms: add XRGB planes composition

2021-04-26 Thread Daniel Vetter
On Mon, Apr 26, 2021 at 11:03:15AM +0300, Pekka Paalanen wrote: > On Sat, 24 Apr 2021 05:25:31 -0300 > Melissa Wen wrote: > > > Add support for composing XRGB888 planes in addition to the ARGB > > format. In the case of an XRGB plane at the top, the composition consists > > of copying the RGB

Re: [PATCH 1/9] drm/doc/rfc: i915 DG1 uAPI

2021-04-26 Thread Daniel Vetter
On Mon, Apr 26, 2021 at 11:25:09AM -0500, Jason Ekstrand wrote: > On Mon, Apr 26, 2021 at 10:31 AM Matthew Auld wrote: > > > > On 26/04/2021 16:11, Jason Ekstrand wrote: > > > On Mon, Apr 26, 2021 at 4:42 AM Matthew Auld > > > wrote: > > >> > > >> Add an entry for the new uAPI needed for DG1. Al

Re: [PATCH v5 05/16] swiotlb: Add restricted DMA pool initialization

2021-04-26 Thread Claire Chang
On Fri, Apr 23, 2021 at 7:34 PM Steven Price wrote: > > On 22/04/2021 09:14, Claire Chang wrote: > > Add the initialization function to create restricted DMA pools from > > matching reserved-memory nodes. > > > > Signed-off-by: Claire Chang > > --- > > include/linux/device.h | 4 +++ > > inc

Re: [PATCH 4/7] drm/i915/gtt/dgfx: place the PD in LMEM

2021-04-26 Thread Matthew Auld
On 26/04/2021 16:22, Tvrtko Ursulin wrote: On 26/04/2021 11:18, Matthew Auld wrote: It's a requirement that for dgfx we place all the paging structures in device local-memory. v2: use i915_coherent_map_type() Signed-off-by: Matthew Auld Cc: Tvrtko Ursulin ---   drivers/gpu/drm/i915/gt/gen8_

Re: [PATCH v5 16/16] of: Add plumbing for restricted DMA pool

2021-04-26 Thread Claire Chang
On Fri, Apr 23, 2021 at 9:35 PM Robin Murphy wrote: > > On 2021-04-22 09:15, Claire Chang wrote: > > If a device is not behind an IOMMU, we look up the device node and set > > up the restricted DMA when the restricted-dma-pool is presented. > > > > Signed-off-by: Claire Chang > > --- > > driver

Re: [PATCH v5 08/16] swiotlb: Update is_swiotlb_active to add a struct device argument

2021-04-26 Thread Claire Chang
On Fri, Apr 23, 2021 at 9:31 PM Robin Murphy wrote: > > On 2021-04-22 09:15, Claire Chang wrote: > > Update is_swiotlb_active to add a struct device argument. This will be > > useful later to allow for restricted DMA pool. > > > > Signed-off-by: Claire Chang > > --- > > drivers/gpu/drm/i915/gem

[PATCH] drm/i9i5/gt: Fix a double free in gen8_preallocate_top_level_pdp

2021-04-26 Thread Lv Yunlong
Our code analyzer reported a double free bug. In gen8_preallocate_top_level_pdp, pde and pde->pt.base are allocated via alloc_pd(vm) with one reference. If pin_pt_dma() failed, pde->pt.base is freed by i915_gem_object_put() with a reference dropped. Then free_pd calls free_px() defined in intel_pp

Re: [PATCH v4 4/4] drm/vkms: add overlay support

2021-04-26 Thread Melissa Wen
On 04/26, Pekka Paalanen wrote: > On Sat, 24 Apr 2021 05:26:10 -0300 > Melissa Wen wrote: > > > Add support to overlay plane, in addition to primary and cursor > > planes. In this approach, the plane composition still requires an > > active primary plane and planes are composed associatively in t

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Rewrite CL/CTG L-shaped memory detection

2021-04-26 Thread Ville Syrjälä
On Mon, Apr 26, 2021 at 06:08:59PM +0200, Daniel Vetter wrote: > On Thu, Apr 22, 2021 at 04:11:22PM +0300, Ville Syrjälä wrote: > > On Thu, Apr 22, 2021 at 11:49:43AM +0200, Daniel Vetter wrote: > > > On Wed, Apr 21, 2021 at 06:34:01PM +0300, Ville Syrjala wrote: > > > > From: Ville Syrjälä > > >

Re: [PATCH v2 1/1] drm/doc: document drm_mode_get_plane

2021-04-26 Thread Leandro Ribeiro
On 4/26/21 7:58 AM, Simon Ser wrote: > On Monday, April 26th, 2021 at 9:36 AM, Pekka Paalanen > wrote: > This should probably explain what the bits in the mask correspond to. As in, which CRTC does bit 0 refer to, and so on. >>> >>> What about: >>> >>> "possible_crtcs: Bitmask of CR

Re: [PATCH v4 3/4] drm/vkms: add XRGB planes composition

2021-04-26 Thread Melissa Wen
On 04/26, Daniel Vetter wrote: > On Mon, Apr 26, 2021 at 11:03:15AM +0300, Pekka Paalanen wrote: > > On Sat, 24 Apr 2021 05:25:31 -0300 > > Melissa Wen wrote: > > > > > Add support for composing XRGB888 planes in addition to the ARGB > > > format. In the case of an XRGB plane at the top, the

Re: [PATCH 00/12] Remove vfio_mdev.c, mdev_parent_ops and more

2021-04-26 Thread Christian Borntraeger
On 24.04.21 01:02, Jason Gunthorpe wrote: Prologue This is series #3 in part of a larger work that arose from the minor remark that the mdev_parent_ops indirection shim is useless and complicates things. It applies on top of Alex's current tree and requires the prior two series. D

[RFC PATCH 0/3] A drm_plane API to support HDR planes

2021-04-26 Thread Harry Wentland
## Introduction We are looking to enable HDR support for a couple of single-plane and multi-plane scenarios. To do this effectively we recommend new interfaces to drm_plane. Below I'll give a bit of background on HDR and why we propose these interfaces. ## Defining a pixel's luminance Curr

[RFC PATCH 1/3] drm/color: Add RGB Color encodings

2021-04-26 Thread Harry Wentland
From: Bhawanpreet Lakha Add the following color encodings - RGB versions for BT601, BT709, BT2020 - DCI-P3: Used for digital movies Signed-off-by: Bhawanpreet Lakha Signed-off-by: Harry Wentland --- drivers/gpu/drm/drm_color_mgmt.c | 4 include/drm/drm_color_mgmt.h | 4 2 files

[RFC PATCH 3/3] drm/color: Add sdr boost property

2021-04-26 Thread Harry Wentland
From: Bhawanpreet Lakha SDR is typically mastered at 200 nits and HDR is mastered at up to 10,000 nits. Due to this luminance range difference if we blend a SDR and HDR plane together, we can run into problems where the HDR plane is too bright or the SDR plane is too dim A common solution to thi

[RFC PATCH 2/3] drm/color: Add Color transfer functions for HDR/SDR

2021-04-26 Thread Harry Wentland
From: Bhawanpreet Lakha Due to the way displays and human vision work it is most effective to encode luminance information in a non-linear space. For SDR this non-linear mapping is assumed to roughly use a gamma 2.2 curve. This was due to the way CRTs worked and was fine for SDR content with a l

Re: [PATCH 00/12] Remove vfio_mdev.c, mdev_parent_ops and more

2021-04-26 Thread Jason Gunthorpe
On Mon, Apr 26, 2021 at 06:43:14PM +0200, Christian Borntraeger wrote: > On 24.04.21 01:02, Jason Gunthorpe wrote: > > Prologue > > > > > > This is series #3 in part of a larger work that arose from the minor > > remark that the mdev_parent_ops indirection shim is useless and > > complica

[PATCH] drm/ttm: cleanup ttm_agp_backend

2021-04-26 Thread Christian König
Audit the includes and stop accessing the internal drm_mm_node. The ttm_resource::start should be the same value as the drm_mm_node::start. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_agp_backend.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/driver

Re: [PATCH] drm/ast: Fix missing conversions to managed API

2021-04-26 Thread Thomas Zimmermann
Am 21.04.21 um 19:04 schrieb Takashi Iwai: The commit 7cbb93d89838 ("drm/ast: Use managed pci functions") converted a few PCI accessors to the managed API and dropped the manual pci_iounmap() calls, but it seems to have forgotten converting pci_iomap() to the managed one. It resulted in the le

Re: [RFC PATCH 1/3] drm/color: Add RGB Color encodings

2021-04-26 Thread Ville Syrjälä
On Mon, Apr 26, 2021 at 01:38:50PM -0400, Harry Wentland wrote: > From: Bhawanpreet Lakha > > Add the following color encodings > - RGB versions for BT601, BT709, BT2020 > - DCI-P3: Used for digital movies > > Signed-off-by: Bhawanpreet Lakha > Signed-off-by: Harry Wentland > --- > drivers/gp

Re: [PATCH 01/12] vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE

2021-04-26 Thread Jason Gunthorpe
On Fri, Apr 23, 2021 at 05:08:10PM -0700, Randy Dunlap wrote: > On 4/23/21 4:02 PM, Jason Gunthorpe wrote: > > @@ -171,7 +171,7 @@ config SAMPLE_VFIO_MDEV_MDPY_FB > > > > config SAMPLE_VFIO_MDEV_MBOCHS > > tristate "Build VFIO mdpy example mediated device sample code -- > > loadable modules

Re: [PATCH 10/12] vfio/mdev: Remove mdev_parent_ops

2021-04-26 Thread Jason Gunthorpe
On Mon, Apr 26, 2021 at 04:19:11PM +0200, Christoph Hellwig wrote: > > +The mediated bus driver's probe function should create a vfio_device on > > top of > > +the mdev_device and connect it to an appropriate implementation of > > vfio_device_ops. > > Overly long line. > > > +This will provide

[PATCH] drm: i915: fix build when ACPI is disabled and BACKLIGHT=m

2021-04-26 Thread Randy Dunlap
ainline (5.12). drivers/gpu/drm/i915/display/intel_panel.c |2 +- drivers/gpu/drm/i915/display/intel_panel.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- linux-next-20210426.orig/drivers/gpu/drm/i915/display/intel_panel.c +++ linux-next-20210426/drivers/g

Re: [PATCH v2] drm/bochs: Add screen blanking support

2021-04-26 Thread Thomas Zimmermann
Hi Am 21.04.21 um 10:08 schrieb Takashi Iwai: On bochs DRM driver, the execution of "setterm --blank force" results in a frozen screen instead of a blank screen. It's due to the lack of the screen blanking support in its code. Actually, the QEMU bochs vga side can switch to the blanking mode w

Re: [PATCH][next] drm/amdkfd: Fix spelling mistake "unregisterd" -> "unregistered"

2021-04-26 Thread Felix Kuehling
On 2021-04-26 8:15, Nirmoy wrote: > Reviewed-by: Nirmoy Das > > On 4/26/21 2:13 PM, Colin King wrote: >> From: Colin Ian King >> >> There is a spelling mistake in a pr_debug message. Fix it. >> >> Signed-off-by: Colin Ian King Applied to amd-staging-drm-next. Thanks,   Felix >> --- >>   driv

Re: [RFC PATCH 1/3] drm/color: Add RGB Color encodings

2021-04-26 Thread Harry Wentland
On 2021-04-26 2:07 p.m., Ville Syrjälä wrote: On Mon, Apr 26, 2021 at 01:38:50PM -0400, Harry Wentland wrote: From: Bhawanpreet Lakha Add the following color encodings - RGB versions for BT601, BT709, BT2020 - DCI-P3: Used for digital movies Signed-off-by: Bhawanpreet Lakha Signed-off-by: Ha

Re: [PATCH v4 0/9] drm: Support simple-framebuffer devices and firmware fbs

2021-04-26 Thread Geert Uytterhoeven
Hi Thomas, On Mon, Apr 26, 2021 at 2:22 PM Thomas Zimmermann wrote: > Am 20.04.21 um 11:27 schrieb Geert Uytterhoeven: > > On Tue, Apr 20, 2021 at 11:22 AM Gerd Hoffmann wrote: > > Patches 4 to 8 add the simpledrm driver. It's build on simple DRM > > helpers > > and SHMEM. It suppor

Re: [Outreachy kernel] Re: [PATCH] drm/amd/amdgpu/amdgpu_drv.c: Replace drm_modeset_lock_all with drm_modeset_lock

2021-04-26 Thread Fabio M. De Francesco
On Monday, April 26, 2021 6:11:11 PM CEST Daniel Vetter wrote: > On Thu, Apr 22, 2021 at 05:50:34PM +0100, Matthew Wilcox wrote: > > On Thu, Apr 22, 2021 at 05:59:51PM +0200, Fabio M. De Francesco wrote: > > > - drm_modeset_lock_all(drm_dev); > > > - > > > > > > drm_for_each_crtc

Re: [RFC PATCH 1/3] drm/color: Add RGB Color encodings

2021-04-26 Thread Ville Syrjälä
On Mon, Apr 26, 2021 at 02:56:26PM -0400, Harry Wentland wrote: > On 2021-04-26 2:07 p.m., Ville Syrjälä wrote: > > On Mon, Apr 26, 2021 at 01:38:50PM -0400, Harry Wentland wrote: > >> From: Bhawanpreet Lakha > >> > >> Add the following color encodings > >> - RGB versions for BT601, BT709, BT2020

  1   2   >