Re: [PATCH v3 5/7] drm/vmwgfx: Inline ttm_bo_mmap() into vmwgfx driver

2021-04-21 Thread Christian König
Am 20.04.21 um 22:53 schrieb Daniel Vetter: On Tue, Apr 20, 2021 at 10:23 PM Felix Kuehling wrote: Am 2021-04-20 um 4:51 a.m. schrieb Daniel Vetter: Whole series is Reviewed-by: Christian König Thanks a lot. If I'm not mistaken, the patches at [1] need to go in first. So it could take a a b

Re: [PATCH 23/40] drm/ttm/ttm_bo: Fix incorrectly documented function 'ttm_bo_cleanup_refs'

2021-04-21 Thread Christian König
Am 20.04.21 um 23:27 schrieb Alex Deucher: On Fri, Apr 16, 2021 at 11:32 AM Christian König wrote: Am 16.04.21 um 16:37 schrieb Lee Jones: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/ttm/ttm_bo.c:293: warning: expecting prototype for function ttm_bo_cleanup_refs(). Pr

Re: [PATCH] drm/bochs: Add screen blanking support

2021-04-21 Thread Gerd Hoffmann
> > However, a tricky part is that the QEMU vga code does treat VGA_ATT_IW > > register always as "flip-flop"; the first write is for index and the > > second write is for the data like palette. Meanwhile, in the current > > bochs DRM driver, the flip-flop wasn't considered, and it calls only > >

Re: [PATCH] drm/bochs: Add screen blanking support

2021-04-21 Thread Takashi Iwai
On Tue, 20 Apr 2021 19:47:31 +0200, Thomas Zimmermann wrote: > > Hi > > Am 20.04.21 um 18:56 schrieb Takashi Iwai: > > On bochs DRM driver, the execution of "setterm --blank force" results > > in a frozen screen instead of a blank screen. It's due to the lack of > > the screen blanking support i

Re: [PATCH] drm/bochs: Add screen blanking support

2021-04-21 Thread Takashi Iwai
On Wed, 21 Apr 2021 09:19:42 +0200, Gerd Hoffmann wrote: > > > > However, a tricky part is that the QEMU vga code does treat VGA_ATT_IW > > > register always as "flip-flop"; the first write is for index and the > > > second write is for the data like palette. Meanwhile, in the current > > > bochs

[PATCH v2] drm/bochs: Add screen blanking support

2021-04-21 Thread Takashi Iwai
On bochs DRM driver, the execution of "setterm --blank force" results in a frozen screen instead of a blank screen. It's due to the lack of the screen blanking support in its code. Actually, the QEMU bochs vga side can switch to the blanking mode when the bit 0x20 is cleared on VGA_ATT_IW registe

Re: [PATCH v3 4/4] drm/doc/rfc: i915 DG1 uAPI

2021-04-21 Thread Tvrtko Ursulin
On 20/04/2021 18:00, Jason Ekstrand wrote: On Tue, Apr 20, 2021 at 11:34 AM Tvrtko Ursulin wrote: On 19/04/2021 16:19, Jason Ekstrand wrote: On Mon, Apr 19, 2021 at 7:02 AM Matthew Auld wrote: On 16/04/2021 17:38, Jason Ekstrand wrote: On Thu, Apr 15, 2021 at 11:04 AM Matthew Auld wro

Re: [PATCH] drm/vc4: remove unused function

2021-04-21 Thread Maxime Ripard
On Thu, Apr 15, 2021 at 04:45:25PM +0800, Jiapeng Chong wrote: > Fix the following clang warning: > > drivers/gpu/drm/vc4/vc4_vec.c:201:1: warning: unused function > 'to_vc4_vec_connector' [-Wunused-function]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Merged, thanks! Maxime

[PATCH v5] drm/ast: Fixed CVE for DP501

2021-04-21 Thread KuoHsiang Chou
[Bug][DP501] If ASPEED P2A (PCI to AHB) bridge is disabled and disallowed for CVE_2019_6260 item3, and then the monitor's EDID is unable read through Parade DP501. The reason is the DP501's FW is mapped to BMC addressing space rather than Host addressing space. The resolution is that using "pci_iom

Re: [PATCH v3 5/7] drm/vmwgfx: Inline ttm_bo_mmap() into vmwgfx driver

2021-04-21 Thread Daniel Vetter
On Wed, Apr 21, 2021 at 09:01:00AM +0200, Christian König wrote: > Am 20.04.21 um 22:53 schrieb Daniel Vetter: > > On Tue, Apr 20, 2021 at 10:23 PM Felix Kuehling > > wrote: > > > > > > Am 2021-04-20 um 4:51 a.m. schrieb Daniel Vetter: > > > > > > Whole series is Reviewed-by: Christian König >

Re: [PATCH v5] dma-buf: Add DmaBufTotal counter in meminfo

2021-04-21 Thread Daniel Vetter
On Tue, Apr 20, 2021 at 11:37:41AM +, peter.enderb...@sony.com wrote: > On 4/20/21 1:14 PM, Daniel Vetter wrote: > > On Tue, Apr 20, 2021 at 09:26:00AM +, peter.enderb...@sony.com wrote: > >> On 4/20/21 10:58 AM, Daniel Vetter wrote: > >>> On Sat, Apr 17, 2021 at 06:38:35PM +0200, Peter End

Re: [PATCH v4 2/3] drm: bridge: add it66121 driver

2021-04-21 Thread Neil Armstrong
Hi Paul, On 19/04/2021 09:12, Neil Armstrong wrote: > From: Phong LE > > This commit is a simple driver for bridge HMDI it66121. > The input format is RBG and there is no color conversion. > Audio, HDCP and CEC are not supported yet. Did you manage to get it working on your platform with all th

Re: [PATCH v4 5/6] dt-bindings: display: add Unisoc's mipi dsi controller bindings

2021-04-21 Thread Maxime Ripard
Hi, On Mon, Apr 19, 2021 at 12:33:42AM +0800, Kevin Tang wrote: > Maxime Ripard 于2021年4月15日周四 下午4:42写道: > > > > On Fri, Apr 09, 2021 at 08:23:19AM +0800, Kevin Tang wrote: > > > Maxime Ripard 于2021年4月7日周三 下午6:46写道: > > > > > > > On Wed, Mar 31, 2021 at 09:49:14AM +0800, Kevin Tang wrote: > > > >

Re: [PATCH 1/5] drm/i915: Create stolen memory region from local memory

2021-04-21 Thread Matthew Auld
On 20/04/2021 17:06, Tvrtko Ursulin wrote: On 20/04/2021 14:18, Matthew Auld wrote: From: CQ Tang Add "REGION_STOLEN" device info to dg1, create stolen memory region from upper portion of local device memory, starting from DSMBASE. v2: - s/drm_info/drm_dbg; userspace likely doesn't care

Re: [PATCH 4/5] drm/i915/stolen: pass the allocation flags

2021-04-21 Thread Matthew Auld
On 20/04/2021 17:14, Tvrtko Ursulin wrote: On 20/04/2021 14:18, Matthew Auld wrote: From: CQ Tang Stolen memory is always allocated as physically contiguous pages, mark the object flags as such. v2: move setting I915_BO_ALLOC_CONTIGUOUS into create_stolen Signed-off-by: CQ Tang Signed-off-

Re: [PATCH v4 2/3] drm: bridge: add it66121 driver

2021-04-21 Thread Paul Cercueil
Hi Neil, Le mer. 21 avril 2021 à 11:25, Neil Armstrong a écrit : Hi Paul, On 19/04/2021 09:12, Neil Armstrong wrote: From: Phong LE This commit is a simple driver for bridge HMDI it66121. The input format is RBG and there is no color conversion. Audio, HDCP and CEC are not supported ye

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-21 Thread Maxime Ripard
On Mon, Apr 19, 2021 at 07:01:00AM +0800, Kevin Tang wrote: > Maxime Ripard 于2021年4月15日周四 下午5:03写道: > > On Thu, Apr 15, 2021 at 08:18:52AM +0800, Kevin Tang wrote: > > > Maxime Ripard 于2021年3月24日周三 下午7:10写道: > > > > > +static struct sprd_dpu *sprd_crtc_init(struct drm_device *drm, > > > > > +

[PATCH] drm/vc4: fix argument ordering in vc4_crtc_get_margins()

2021-04-21 Thread Dan Carpenter
Cppcheck complains that the declaration doesn't match the function definition. Obviously "left" should come before "right". The caller and the function implementation are done this way, it's just the declaration which is wrong so this doesn't affect runtime. Reported-by: kernel test robot Signe

Re: [PATCH v5] dma-buf: Add DmaBufTotal counter in meminfo

2021-04-21 Thread Peter.Enderborg
On 4/21/21 11:15 AM, Daniel Vetter wrote: > On Tue, Apr 20, 2021 at 11:37:41AM +, peter.enderb...@sony.com wrote: >> On 4/20/21 1:14 PM, Daniel Vetter wrote: >>> On Tue, Apr 20, 2021 at 09:26:00AM +, peter.enderb...@sony.com wrote: On 4/20/21 10:58 AM, Daniel Vetter wrote: > On Sat

[PATCH v2 1/4] drm/i915: Create stolen memory region from local memory

2021-04-21 Thread Matthew Auld
From: CQ Tang Add "REGION_STOLEN" device info to dg1, create stolen memory region from upper portion of local device memory, starting from DSMBASE. v2: - s/drm_info/drm_dbg; userspace likely doesn't care about stolen. - mem->type is only setup after the region probe, so setting the name

[PATCH v2 2/4] drm/i915/stolen: treat stolen local as normal local memory

2021-04-21 Thread Matthew Auld
Underneath it's the same stuff, so things like the PTE_LM bits for the GTT should just keep working as-is. Signed-off-by: Matthew Auld Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_lmem.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH v2 4/4] drm/i915/stolen: actually mark as contiguous

2021-04-21 Thread Matthew Auld
Stolen memory is always allocated as physically contiguous pages, so mark the object flags as such. It looks like the flags were previously just ignored so this had no effect. In the future we might to add the proper plumbing for passing the flags all over the way down from the caller, but for now

[PATCH v2 3/4] drm/i915/stolen: enforce the min_page_size contract

2021-04-21 Thread Matthew Auld
From: CQ Tang Since stolen can now be device local-memory underneath, we should try to enforce any min_page_size restrictions when allocating pages. Signed-off-by: CQ Tang Signed-off-by: Matthew Auld Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 7 --- 1 fi

Re: [PATCH v9 6/6] MAINTAINERS: add maintainer for i.MX8qxp DPU DRM driver

2021-04-21 Thread Laurentiu Palcu
Hi, On Mon, Mar 29, 2021 at 01:57:26PM +0800, Liu Ying wrote: > Add myself as the maintainer of the i.MX8qxp DPU DRM driver. > > Signed-off-by: Liu Ying Acked-by: Laurentiu Palcu Thanks, laurentiu > --- > v8->v9: > * No change. > > v7->v8: > * No change. > > v6->v7: > * No change. > > v5-

[PATCH v3 0/2] drm/amd/amdgpu/amdgpu_drv.c: Replace drm_modeset_*_all() with DRM_MODESET_LOCK_ALL_*()

2021-04-21 Thread Fabio M. De Francesco
Replace the deprecated API with new helpers, according to the TODO list of the DRM subsystem. The new API has been introduced with commit b7ea04d299c7: DRM_MODESET_LOCK_ALL_BEGIN() simplifies grabbing all modeset locks using a local context. This has the advantage of reducing boilerplate. The wo

[PATCH v3 1/2] drm/amd/amdgpu/amdgpu_drv.c: Replace drm_modeset_lock_all() with drm_modeset_lock_all_ctx()

2021-04-21 Thread Fabio M. De Francesco
Replace the deprecated API with new helpers, according to the TODO list of the DRM subsystem. In this first patch drm_modeset_lock_all() is replaced with drm_modeset_lock_all_ctx(). Unlike drm_modeset_lock_all(), the latter doesn’t take the global drm_mode_config.mutex since that lock isn’t requir

[PATCH v3 2/2] drm/amd/amdgpu/amdgpu_drv.c: Replace drm_modeset_*_all_ctx() with DRM_MODESET_LOCK_ALL_*()

2021-04-21 Thread Fabio M. De Francesco
This second patch makes use of the API that has been introduced with commit b7ea04d299c7: DRM_MODESET_LOCK_ALL_BEGIN() simplifies grabbing all modeset locks using a local context and has the advantage of reducing boilerplate. Signed-off-by: Fabio M. De Francesco --- Changes from v2: The work is

Re: [Intel-gfx] [PATCH 11/19] drm/i915: Update the helper to set correct mapping

2021-04-21 Thread Matthew Auld
On 19/04/2021 16:01, Tvrtko Ursulin wrote: On 19/04/2021 15:37, Matthew Auld wrote: On 19/04/2021 15:07, Tvrtko Ursulin wrote: On 19/04/2021 12:30, Matthew Auld wrote: On 15/04/2021 12:05, Tvrtko Ursulin wrote: On 15/04/2021 10:23, Matthew Auld wrote: On Thu, 15 Apr 2021 at 09:21, Tvrtko

Re: [PATCH v4 2/3] drm: bridge: add it66121 driver

2021-04-21 Thread Neil Armstrong
Hi, On 21/04/2021 11:58, Paul Cercueil wrote: > Hi Neil, > > Le mer. 21 avril 2021 à 11:25, Neil Armstrong a > écrit : >> Hi Paul, >> >> On 19/04/2021 09:12, Neil Armstrong wrote: >>>  From: Phong LE >>> >>>  This commit is a simple driver for bridge HMDI it66121. >>>  The input format is RBG

Re: [PATCH 1/2] drm/i915: Remove asynchronous vma binding

2021-04-21 Thread Daniel Vetter
On Tue, Apr 20, 2021 at 12:34:50PM +0200, Maarten Lankhorst wrote: > Commit e3793468b466 ("drm/i915: Use the async worker to avoid reclaim > tainting the ggtt->mutex") moves the vma binding to dma_fence_work, > but dma_fence_work has has signalling fence semantics. > > On braswell, we can call sto

Re: [PATCH v4 0/3] drm/bridge: Add it66121 driver

2021-04-21 Thread Neil Armstrong
On 19/04/2021 09:12, Neil Armstrong wrote: > The IT66121 is a high-performance and low-power single channel HDMI > transmitter, fully compliant with HDMI 1.3a, HDCP 1.2 and backward > compatible to DVI 1.0 specifications. > It supports pixel rates from 25MHz to 165MHz. > > This series contains doc

[PATCH] drm/i915: Fix docbook descriptions for i915_cmd_parser

2021-04-21 Thread Maarten Lankhorst
Fixes the following htmldocs warnings: drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser' drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'jump_whitelist' not described in 'intel_

[PATCH] drm/i915: Fix docbook descriptions for i915_gem_shrinker

2021-04-21 Thread Maarten Lankhorst
Fixes the following htmldocs warning: drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not described in 'i915_gem_shrink' Fixes: cf41a8f1dc1e ("drm/i915: Finally remove obj->mm.lock.") Reported-by: Stephen Rothwell Signed-off-by: Maarten Lankhorst ---

Re: [PATCH v5] dma-buf: Add DmaBufTotal counter in meminfo

2021-04-21 Thread Pekka Paalanen
On Wed, 21 Apr 2021 10:37:11 + wrote: > On 4/21/21 11:15 AM, Daniel Vetter wrote: > > On Tue, Apr 20, 2021 at 11:37:41AM +, peter.enderb...@sony.com wrote: > >> But I dont think they will. dma-buf does not have to be mapped to a > >> process, > >> and the case of vram, it is not cover

Re: [PATCH v13 4/4] drm/panfrost: Add mt8183-mali compatible string

2021-04-21 Thread Alyssa Rosenzweig
Not that you need it but this patch is Reviewed-by: Alyssa Rosenzweig On Wed, Apr 21, 2021 at 01:28:55PM +0800, Nicolas Boichat wrote: > Add support for MT8183's G72 Bifrost. > > Signed-off-by: Nicolas Boichat > Reviewed-by: Tomeu Vizoso > Reviewed-by: Steven Price > --- > > (no changes sinc

[PATCH 1/2] coda: fix reference counting in coda_file_mmap error path

2021-04-21 Thread Christian König
mmap_region() now calls fput() on the vma->vm_file. So we need to drop the extra reference on the coda file instead of the host file. Signed-off-by: Christian König Fixes: 1527f926fd04 ("mm: mmap: fix fput in error path v2") CC: sta...@vger.kernel.org # 5.11+ --- fs/coda/file.c | 6 +++--- 1 fi

[PATCH 2/2] ovl: fix reference counting in ovl_mmap error path

2021-04-21 Thread Christian König
mmap_region() now calls fput() on the vma->vm_file. Fix this by using vma_set_file() so it doesn't need to be handled manually here any more. Signed-off-by: Christian König Fixes: 1527f926fd04 ("mm: mmap: fix fput in error path v2") CC: sta...@vger.kernel.org # 5.11+ --- fs/overlayfs/file.c | 1

Re: [PATCH] drm/ttm: fix error handling if no BO can be swapped out

2021-04-21 Thread Christian König
Am 20.04.21 um 16:32 schrieb Shiwu Zhang: In case that all pre-allocated BOs are busy, just continue to populate BOs since likely half of system memory in total is still free. Signed-off-by: Shiwu Zhang --- drivers/gpu/drm/ttm/ttm_device.c | 4 ++-- drivers/gpu/drm/ttm/ttm_tt.c | 2 ++

Re: [RFC PATCH] drm/i915: Simplify userptr locking

2021-04-21 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 7:51 PM Thomas Hellström wrote: > > Use an rwlock instead of spinlock for the global notifier lock > to reduce risk of contention in execbuf. > > Protect object state with the object lock whenever possible rather > than with the global notifier lock > > Don't take an explic

Re: [PATCH v3 4/4] drm/doc/rfc: i915 DG1 uAPI

2021-04-21 Thread Jason Ekstrand
On Wed, Apr 21, 2021 at 3:22 AM Tvrtko Ursulin wrote: > > On 20/04/2021 18:00, Jason Ekstrand wrote: > > On Tue, Apr 20, 2021 at 11:34 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 19/04/2021 16:19, Jason Ekstrand wrote: > >>> On Mon, Apr 19, 2021 at 7:02 AM Matthew Auld > >>> wrote: > >

Re: [PATCH v3 01/20] drm/amdgpu: Add error handling to amdgpu_dm_initialize_dp_connector()

2021-04-21 Thread Mikita Lipski
Thanks for the change! Reviewed-by: Mikita Lipski On 2021-04-19 6:55 p.m., Lyude Paul wrote: While working on moving i2c device registration into drm_dp_aux_init() - I realized that in order to do so we need to make sure that drivers calling drm_dp_aux_init() handle any errors it could possibl

Re: [PATCH v3 4/4] drm/doc/rfc: i915 DG1 uAPI

2021-04-21 Thread Tvrtko Ursulin
On 21/04/2021 14:54, Jason Ekstrand wrote: On Wed, Apr 21, 2021 at 3:22 AM Tvrtko Ursulin wrote: On 20/04/2021 18:00, Jason Ekstrand wrote: On Tue, Apr 20, 2021 at 11:34 AM Tvrtko Ursulin wrote: On 19/04/2021 16:19, Jason Ekstrand wrote: On Mon, Apr 19, 2021 at 7:02 AM Matthew Auld wr

Re: [PATCH v2 4/4] drm/i915/stolen: actually mark as contiguous

2021-04-21 Thread Tvrtko Ursulin
On 21/04/2021 11:46, Matthew Auld wrote: Stolen memory is always allocated as physically contiguous pages, so mark the object flags as such. It looks like the flags were previously just ignored so this had no effect. In the future we might to add the proper plumbing for passing the flags all ov

Re: [PATCH] drm/i915: Fix docbook descriptions for i915_cmd_parser

2021-04-21 Thread Daniel Vetter
On Wed, Apr 21, 2021 at 2:03 PM Maarten Lankhorst wrote: > > Fixes the following htmldocs warnings: > drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function > parameter 'trampoline' description in 'intel_engine_cmd_parser' > drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Fun

Re: [PATCH] drm/i915: Fix docbook descriptions for i915_gem_shrinker

2021-04-21 Thread Daniel Vetter
On Wed, Apr 21, 2021 at 2:09 PM Maarten Lankhorst wrote: > > Fixes the following htmldocs warning: > drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter > or member 'ww' not described in 'i915_gem_shrink' > > Fixes: cf41a8f1dc1e ("drm/i915: Finally remove obj->mm.lock.")

Re: [PATCH v2 1/4] drm/i915: Create stolen memory region from local memory

2021-04-21 Thread Tvrtko Ursulin
On 21/04/2021 11:46, Matthew Auld wrote: From: CQ Tang Add "REGION_STOLEN" device info to dg1, create stolen memory region from upper portion of local device memory, starting from DSMBASE. v2: - s/drm_info/drm_dbg; userspace likely doesn't care about stolen. - mem->type is only set

Re: [PATCH] drm/i915: Fix docbook descriptions for i915_cmd_parser

2021-04-21 Thread Maarten Lankhorst
Op 21-04-2021 om 16:32 schreef Daniel Vetter: > On Wed, Apr 21, 2021 at 2:03 PM Maarten Lankhorst > wrote: >> Fixes the following htmldocs warnings: >> drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function >> parameter 'trampoline' description in 'intel_engine_cmd_parser' >> drive

Re: [PATCH v5] dma-buf: Add DmaBufTotal counter in meminfo

2021-04-21 Thread Michal Hocko
On Wed 21-04-21 10:37:11, peter.enderb...@sony.com wrote: > On 4/21/21 11:15 AM, Daniel Vetter wrote: [...] > > We need to understand what the "correct" value is. Not in terms of kernel > > code, but in terms of semantics. Like if userspace allocates a GL texture, > > is this supposed to show up in

Re: [PATCH v3 01/20] drm/amdgpu: Add error handling to amdgpu_dm_initialize_dp_connector()

2021-04-21 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] I'm fine with having these changes go through drm-misc. Alex From: Lipski, Mikita Sent: Wednesday, April 21, 2021 10:23 AM To: Lyude Paul ; dri-devel@lists.freedesktop.org ; intel-...@lists.freedesktop.org ;

[PATCH] drm/todo: Add link to old debugfs RFC

2021-04-21 Thread Daniel Vetter
I always forget where it was, store it until this gets picked up by an internship again. Cc: Wambui Karuga Cc: Melissa Wen Signed-off-by: Daniel Vetter --- Documentation/gpu/todo.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst i

Re: [PATCH v5] dma-buf: Add DmaBufTotal counter in meminfo

2021-04-21 Thread Mike Rapoport
On Wed, Apr 21, 2021 at 10:37:11AM +, peter.enderb...@sony.com wrote: > On 4/21/21 11:15 AM, Daniel Vetter wrote: > > > > We need to understand what the "correct" value is. Not in terms of kernel > > code, but in terms of semantics. Like if userspace allocates a GL texture, > > is this supposed

[PATCH 0/4] drm/i915: Fix older platforms

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä Fix a div-by-zero on gen2, and make the L-shaped memory detection actually work on cl/ctg. Atm the SWIZZLE_UNKNOWN stuff just trips some GEM_BUG_ONs. This doesn't fix those but since I populate all my memory channels symmetrically I get to avoid the GEM_BUG_ONs by correctly de

[PATCH 1/4] drm/i915: Avoid div-by-zero on gen2

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä Gen2 tiles are 2KiB in size so i915_gem_object_get_tile_row_size() can in fact return <4KiB, which leads to div-by-zero here. Avoid that. Not sure i915_gem_object_get_tile_row_size() is entirely sane anyway since it doesn't account for the different tile layouts on i8xx/i915.

[PATCH 2/4] drm/i915: Read C0DRB3/C1DRB3 as 16 bits again

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä We've defined C0DRB3/C0DRB3 as 16 bit registers, so access them as such. Fixes: 1c8242c3a4b2 ("drm/i915: Use unchecked writes for setting up the fences") Reviewed-by: Chris Wilson Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++-- 1 fil

[PATCH 3/4] drm/i915: Give C0DRB3/C1DRB3 a _BW suffix

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä These are the 965g/g45/g33 specific DRB registers. Give them a suitable suffix so we can add their counterparts for other platforms. Reviewed-by: Chris Wilson Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++-- drivers/gpu/drm/i915/i915_

[PATCH 4/4] drm/i915: Rewrite CL/CTG L-shaped memory detection

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä Currently we try to detect a symmetric memory configurations using a magic DCC2_MODIFIED_ENHANCED_DISABLE bit. That bit is either only set on a very specific subset of machines or it just does not exist (it's not mentioned in any public chipset datasheets I've found). As it ha

Re: [Intel-gfx] [PATCH 11/19] drm/i915: Update the helper to set correct mapping

2021-04-21 Thread Tvrtko Ursulin
On 21/04/2021 12:42, Matthew Auld wrote: On 19/04/2021 16:01, Tvrtko Ursulin wrote: On 19/04/2021 15:37, Matthew Auld wrote: On 19/04/2021 15:07, Tvrtko Ursulin wrote: On 19/04/2021 12:30, Matthew Auld wrote: On 15/04/2021 12:05, Tvrtko Ursulin wrote: On 15/04/2021 10:23, Matthew Auld wr

Re: [PATCH] drm/todo: Add link to old debugfs RFC

2021-04-21 Thread Melissa Wen
On 04/21, Daniel Vetter wrote: > I always forget where it was, store it until this gets picked up by an > internship again. > > Cc: Wambui Karuga > Cc: Melissa Wen > Signed-off-by: Daniel Vetter > --- > Documentation/gpu/todo.rst | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Docu

[PATCH] drm/amd/display: Fix build warnings

2021-04-21 Thread Guenter Roeck
Fix the following build warnings. drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function ‘dm_update_mst_vcpi_slots_for_dsc’: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:6242:46: warning: variable ‘old_con_state’ set but not used drivers/gpu/drm/am

[PATCH v1 5/7] drm/ili9341: Avoid spamming logs if probe is deferred

2021-04-21 Thread Andy Shevchenko
The GPIO request can fail and probe may be deferred. Thus, the error message may be printed again and again. Avoid this by replacing DRM_DEV_ERROR() by dev_err_probe(). Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/tiny/ili9341.c | 12 1 file changed, 4 insertions(+), 8 deletio

[PATCH v1 4/7] drm/ili9486: Avoid spamming logs if probe is deferred

2021-04-21 Thread Andy Shevchenko
The GPIO request can fail and probe may be deferred. Thus, the error message may be printed again and again. Avoid this by replacing DRM_DEV_ERROR() by dev_err_probe(). Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/tiny/ili9486.c | 12 1 file changed, 4 insertions(+), 8 deletio

[PATCH v1 1/7] drm/st7735r: Avoid spamming logs if probe is deferred

2021-04-21 Thread Andy Shevchenko
The GPIO request can fail and probe may be deferred. Thus, the error message may be printed again and again. Avoid this by replacing DRM_DEV_ERROR() by dev_err_probe(). Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/tiny/st7735r.c | 12 1 file changed, 4 insertions(+), 8 deletio

[PATCH v1 6/7] drm/ili9225: Avoid spamming logs if probe is deferred

2021-04-21 Thread Andy Shevchenko
The GPIO request can fail and probe may be deferred. Thus, the error message may be printed again and again. Avoid this by replacing DRM_DEV_ERROR() by dev_err_probe(). Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/tiny/ili9225.c | 12 1 file changed, 4 insertions(+), 8 deletio

[PATCH v1 2/7] drm/st7586: Avoid spamming logs if probe is deferred

2021-04-21 Thread Andy Shevchenko
The GPIO request can fail and probe may be deferred. Thus, the error message may be printed again and again. Avoid this by replacing DRM_DEV_ERROR() by dev_err_probe(). Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/tiny/st7586.c | 12 1 file changed, 4 insertions(+), 8 deletion

[PATCH v1 3/7] drm/mi0283qt: Avoid spamming logs if probe is deferred

2021-04-21 Thread Andy Shevchenko
The GPIO request can fail and probe may be deferred. Thus, the error message may be printed again and again. Avoid this by replacing DRM_DEV_ERROR() by dev_err_probe(). Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/tiny/mi0283qt.c | 12 1 file changed, 4 insertions(+), 8 deleti

[PATCH v1 7/7] drm/hx8357d: Avoid spamming logs if probe is deferred

2021-04-21 Thread Andy Shevchenko
The GPIO request can fail and probe may be deferred. Thus, the error message may be printed again and again. Avoid this by replacing DRM_DEV_ERROR() by dev_err_probe(). Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/tiny/hx8357d.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)

Re: [PATCH v13 1/4] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183

2021-04-21 Thread Rob Herring
On Wed, 21 Apr 2021 13:28:52 +0800, Nicolas Boichat wrote: > Define a compatible string for the Mali Bifrost GPU found in > Mediatek's MT8183 SoCs. > > Signed-off-by: Nicolas Boichat > --- > > (no changes since v12) > > Changes in v12: > - binding: Fix min/maxItems logic (Rob Herring) > > Cha

Re: [git pull] drm/vmwgfx fixes for 5.12-rc8

2021-04-21 Thread Zack Rusin
On 4/17/21 7:02 PM, Dave Airlie wrote: Hi Zack, Please make sure to always cc dri-devel and/or Daniel on these so if I'm away they don't get lost, but also so that they make it into patchwork for processing. If you have a chance can you resend it, I'll see if we can process this out of band and

[PATCH] drm/ast: Fix missing conversions to managed API

2021-04-21 Thread Takashi Iwai
The commit 7cbb93d89838 ("drm/ast: Use managed pci functions") converted a few PCI accessors to the managed API and dropped the manual pci_iounmap() calls, but it seems to have forgotten converting pci_iomap() to the managed one. It resulted in the leftover resources after the driver unbind. Let'

Re: [PATCH v3 4/4] drm/doc/rfc: i915 DG1 uAPI

2021-04-21 Thread Jason Ekstrand
On Wed, Apr 21, 2021 at 9:25 AM Tvrtko Ursulin wrote: > > > On 21/04/2021 14:54, Jason Ekstrand wrote: > > On Wed, Apr 21, 2021 at 3:22 AM Tvrtko Ursulin > > wrote: > >> > >> On 20/04/2021 18:00, Jason Ekstrand wrote: > >>> On Tue, Apr 20, 2021 at 11:34 AM Tvrtko Ursulin > >>> wrote: > > >>

Re: [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending

2021-04-21 Thread khsieh
On 2021-04-20 15:01, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-04-16 13:27:57) Some dongle may generate more than one irq_hpd events in a short period of time. This patch will treat those irq_hpd events as single one and service only one irq_hpd event. Why is it bad to get multiple irq_

Re: [PATCH 000/190] Revertion of all of the umn.edu commits

2021-04-21 Thread Daniel Vetter
On Wed, Apr 21, 2021 at 3:01 PM Greg Kroah-Hartman wrote: > > I have been meaning to do this for a while, but recent events have > finally forced me to do so. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to revie

Re: [PATCH v5] dma-buf: Add DmaBufTotal counter in meminfo

2021-04-21 Thread Peter.Enderborg
On 4/21/21 5:31 PM, Mike Rapoport wrote: > On Wed, Apr 21, 2021 at 10:37:11AM +, peter.enderb...@sony.com wrote: >> On 4/21/21 11:15 AM, Daniel Vetter wrote: >>> We need to understand what the "correct" value is. Not in terms of kernel >>> code, but in terms of semantics. Like if userspace allo

[PATCH] drm/amdgpu: Register VGA clients after init can no longer fail

2021-04-21 Thread Kai-Heng Feng
When an amdgpu device fails to init, it makes another VGA device cause kernel splat: kernel: amdgpu :08:00.0: amdgpu: amdgpu_device_ip_init failed kernel: amdgpu :08:00.0: amdgpu: Fatal error during GPU init kernel: amdgpu: probe of :08:00.0 failed with error -110 ... kernel: amdgpu 000

Re: [PATCH v3 3/3] drm/msm/dp: check main link status before start aux read

2021-04-21 Thread khsieh
On 2021-04-20 16:38, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-04-16 10:38:51) Maybe when the cable is disconnected the DP phy should be shutdown and some bit in the phy could effectively "cut off" the aux channel and then NAKs would start coming through here in the DP controller I/O regi

Re: [PATCH v3 4/4] drm/doc/rfc: i915 DG1 uAPI

2021-04-21 Thread Tvrtko Ursulin
On 21/04/2021 18:17, Jason Ekstrand wrote: On Wed, Apr 21, 2021 at 9:25 AM Tvrtko Ursulin wrote: On 21/04/2021 14:54, Jason Ekstrand wrote: On Wed, Apr 21, 2021 at 3:22 AM Tvrtko Ursulin wrote: On 20/04/2021 18:00, Jason Ekstrand wrote: On Tue, Apr 20, 2021 at 11:34 AM Tvrtko Ursulin

Re: [PATCH] drm/i915/dp: Use slow and wide link training for everything

2021-04-21 Thread Ville Syrjälä
On Wed, Apr 21, 2021 at 01:20:31PM +0800, Kai-Heng Feng wrote: > Screen flickers on Innolux eDP 1.3 panel when clock rate 54 is in use. > > According to the panel vendor, though clock rate 54 is advertised, > but the max clock rate it really supports is 27. > > Ville Syrjälä mentioned

umn experiment patches fallout in drm

2021-04-21 Thread Dave Airlie
Looking at the umn.edu patches for drm in the last while, all the refcount ones look bogus, 2020-06-13 20:48 -0500 Aditya Pakki o drm/nouveau: fix reference count leak in nouveau_debugfs_strap_peek 2020-06-13 20:22 -0500 Aditya Pakki o drm/nouveau: Fix reference count leak in nouveau_connector_det

Re: [git pull] drm/vmwgfx fixes for 5.12-rc8

2021-04-21 Thread Daniel Vetter
On Wed, Apr 21, 2021 at 7:00 PM Zack Rusin wrote: > > On 4/17/21 7:02 PM, Dave Airlie wrote: > > Hi Zack, > > > > Please make sure to always cc dri-devel and/or Daniel on these so if > > I'm away they don't get lost, but also so that they make it into > > patchwork for processing. > > > > If you h

Re: [Intel-gfx] [PATCH 11/19] drm/i915: Update the helper to set correct mapping

2021-04-21 Thread Matthew Auld
On Wed, 21 Apr 2021 at 16:41, Tvrtko Ursulin wrote: > > > On 21/04/2021 12:42, Matthew Auld wrote: > > On 19/04/2021 16:01, Tvrtko Ursulin wrote: > >> > >> On 19/04/2021 15:37, Matthew Auld wrote: > >>> On 19/04/2021 15:07, Tvrtko Ursulin wrote: > > On 19/04/2021 12:30, Matthew Auld wrot

Re: [Mesa-dev] [PATCH v3 4/4] drm/doc/rfc: i915 DG1 uAPI

2021-04-21 Thread Daniel Vetter
On Wed, Apr 21, 2021 at 8:28 PM Tvrtko Ursulin wrote: > On 21/04/2021 18:17, Jason Ekstrand wrote: > > On Wed, Apr 21, 2021 at 9:25 AM Tvrtko Ursulin > > wrote: > >> On 21/04/2021 14:54, Jason Ekstrand wrote: > >>> On Wed, Apr 21, 2021 at 3:22 AM Tvrtko Ursulin > >>> wrote: > On 20/04/2021

RE: [PATCH 1/1] video: hyperv_fb: Add ratelimit on error message

2021-04-21 Thread Michael Kelley
From: Joe Perches Sent: Tuesday, April 20, 2021 12:59 PM > > On Tue, 2021-04-20 at 08:44 -0700, Michael Kelley wrote: > > Due to a full ring buffer, the driver may be unable to send updates to > > the Hyper-V host. But outputing the error message can make the problem > > worse because console ou

[PATCH 0/3] drm: Use tabs for code indents

2021-04-21 Thread Beatriz Martins de Carvalho
Remove space and use tabs for indent the code to follow the Linux kernel coding conventions. Problem found by checkpatch Beatriz Martins de Carvalho (3): drm: drm_atomic_uapi.c: Use tabs for code indents drm: drm_blend.c: Use tabs for code indents drm: drm_connector.c: Use tabs for code inde

[PATCH 1/3] drm: drm_atomic_uapi.c: Use tabs for code indents

2021-04-21 Thread Beatriz Martins de Carvalho
Remove space and use tabs for indent the code to follow the Linux kernel coding conventions. Problem found by checkpatch. Signed-off-by: Beatriz Martins de Carvalho --- drivers/gpu/drm/drm_atomic_uapi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm

[PATCH 2/3] drm: drm_blend.c: Use tabs for code indents

2021-04-21 Thread Beatriz Martins de Carvalho
Remove space and use tabs for indent the code to follow the Linux kernel coding conventions. Problem found by checkpatch. Signed-off-by: Beatriz Martins de Carvalho --- drivers/gpu/drm/drm_blend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_blend.c

[PATCH 3/3] drm: drm_connector.c: Use tabs for code indents

2021-04-21 Thread Beatriz Martins de Carvalho
Remove space and use tabs for indent the code to follow the Linux kernel coding conventions. Problem found by checkpatch Signed-off-by: Beatriz Martins de Carvalho --- drivers/gpu/drm/drm_connector.c | 38 - 1 file changed, 19 insertions(+), 19 deletions(-) diff

[PATCH 0/5] drm: Adjust end of block comment

2021-04-21 Thread Beatriz Martins de Carvalho
Add a new line with */ on the last line of a block comment to follow the Linux kernel coding conventions. Problem found by checkpatch. in tree dpu/drm Beatriz Martins de Carvalho (5): drm: drm_atomic.c: Adjust end of block comment drm: drm_auth.c: Adjust end of block comment drm: drm_bufs.

[PATCH 1/5] drm: drm_atomic.c: Adjust end of block comment

2021-04-21 Thread Beatriz Martins de Carvalho
Add a new line with */ on the last line of a block comment to follow the Linux kernel coding conventions. Problem found by checkpatch. Signed-off-by: Beatriz Martins de Carvalho --- drivers/gpu/drm/drm_atomic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH 3/5] drm: drm_bufs.c: Adjust end of block comment

2021-04-21 Thread Beatriz Martins de Carvalho
Add a new line with */ on the last line of a block comment to follow the Linux kernel coding conventions. Problem found by checkpatch. Signed-off-by: Beatriz Martins de Carvalho --- drivers/gpu/drm/drm_bufs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/d

[PATCH 2/5] drm: drm_auth.c: Adjust end of block comment

2021-04-21 Thread Beatriz Martins de Carvalho
Add a new line with */ on the last line of a block comment to follow the Linux kernel coding conventions. Problem found by checkpatch. Signed-off-by: Beatriz Martins de Carvalho --- drivers/gpu/drm/drm_auth.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/d

[PATCH 4/5] drm: drm_connector.c: Adjust end of block comment

2021-04-21 Thread Beatriz Martins de Carvalho
Add a new line with */ on the last line of a block comment to follow the Linux kernel coding conventions. Problem found by checkpatch. Signed-off-by: Beatriz Martins de Carvalho --- drivers/gpu/drm/drm_connector.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drive

[PATCH 5/5] drm: drm_context.c: Adjust end of block comment

2021-04-21 Thread Beatriz Martins de Carvalho
Add a new line with */ on the last line of a block comment to follow the Linux kernel coding conventions. Problem found by checkpatch. Signed-off-by: Beatriz Martins de Carvalho --- drivers/gpu/drm/drm_context.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/dr

[PATCH v2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending

2021-04-21 Thread Kuogee Hsieh
irq_hpd is an asynchronous event generated by panel to bring up attention of host. It could only be generated at run time of normal operation and it is not possible to be generated while main link is down. Therefore no need to handle irq_hpd if main link is down, such as cable unplug or system susp

[PATCH v2 0/9] drm: Add privacy-screen class and connector properties

2021-04-21 Thread Hans de Goede
Hi All, Here is v2 of my series to add a privacy-screen class and connector properties. The only significantly changed patch in this v2 is: [2/9] drm: Add privacy-screen class (v2) which was modified to fix the dependency issues which the lkp kernel test robot, see the patches changelog for detail

[PATCH v2 2/9] drm: Add privacy-screen class (v2)

2021-04-21 Thread Hans de Goede
On some new laptops the LCD panel has a builtin electronic privacy-screen. We want to export this functionality as a property on the drm connector object. But often this functionality is not exposed on the GPU but on some other (ACPI) device. This commit adds a privacy-screen class allowing the dr

[PATCH v2 1/9] drm/connector: Add support for privacy-screen properties (v4)

2021-04-21 Thread Hans de Goede
From: Rajat Jain Add support for generic electronic privacy screen properties, that can be added by systems that have an integrated EPS. Changes in v2 (Hans de Goede) - Create 2 properties, "privacy-screen sw-state" and "privacy-screen hw-state", to deal with devices where the OS might be lo

[PATCH v2 3/9] drm/privacy-screen: Add X86 specific arch init code

2021-04-21 Thread Hans de Goede
Add X86 specific arch init code, which fills the privacy-screen lookup table by checking for various vendor specific ACPI interfaces for controlling the privacy-screen. This initial version only checks for the Lenovo Thinkpad specific ACPI methods for privacy-screen control. Signed-off-by: Hans d

[PATCH v2 4/9] drm/privacy-screen: Add notifier support

2021-04-21 Thread Hans de Goede
Add support for privacy-screen consumers to register a notifier to be notified of external (e.g. done by the hw itself on a hotkey press) state changes. Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_privacy_screen.c | 67 +++ include/drm/drm_privacy_screen_consume

[PATCH v2 6/9] platform/x86: thinkpad_acpi: Add hotkey_notify_extended_hotkey() helper

2021-04-21 Thread Hans de Goede
Factor the extended hotkey handling out of hotkey_notify_hotkey() and into a new hotkey_notify_extended_hotkey() helper. This is a preparation patch for adding support the privacy-screen hotkey toggle (which needs some special handling, it should NOT send an evdev key-event to userspace...). Sign

[PATCH v2 7/9] platform/x86: thinkpad_acpi: Get privacy-screen / lcdshadow ACPI handles only once

2021-04-21 Thread Hans de Goede
Get the privacy-screen / lcdshadow ACPI handles once and cache them, instead of retrieving them every time we need them. Signed-off-by: Hans de Goede --- drivers/platform/x86/thinkpad_acpi.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/platform/

  1   2   >