Re: [PATCH 2/2] drm/ttm: optimize the pool shrinker a bit v2

2021-04-16 Thread Christian König
Am 15.04.21 um 22:33 schrieb Andrew Morton: On Thu, 15 Apr 2021 13:56:24 +0200 "Christian König" wrote: @@ -530,6 +525,11 @@ void ttm_pool_fini(struct ttm_pool *pool) for (j = 0; j < MAX_ORDER; ++j) ttm_pool_type_fini(&pool->caching[i].o

[PATCH v3] drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-16 Thread Jisheng Zhang
I met below error during boot with i915 builtin if pass "i915.mitigations=off": [0.015589] Booting kernel: `off' invalid for parameter `i915.mitigations' The reason is slab subsystem isn't ready at that time, so kstrdup() returns NULL. Fix this issue by using stack var instead of kstrdup(). F

Re: [PATCH 00/57] Rid W=1 warnings from Staging

2021-04-16 Thread Greg Kroah-Hartman
On Fri, Apr 16, 2021 at 09:27:51AM +0200, Fabio Aiuto wrote: > On Wed, Apr 14, 2021 at 07:10:32PM +0100, Lee Jones wrote: > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > Lee Jo

Re: [PATCHv2 1/6] drm: drm_bridge: add connector_attach/detach bridge ops

2021-04-16 Thread Tomi Valkeinen
Hi Hans, On 02/03/2021 18:23, Hans Verkuil wrote: Add bridge connector_attach/detach ops. These ops are called when a bridge is attached or detached to a drm_connector. These ops can be used to register and unregister an HDMI CEC adapter for a bridge that supports CEC. Signed-off-by: Hans Verku

Re: [PATCH v5, 1/4] soc: mediatek: mmsys: add component OVL_2L2

2021-04-16 Thread Enric Balletbo Serra
Hi Yongqiang, Thank you for your patch. Missatge de Yongqiang Niu del dia dl., 12 d’abr. 2021 a les 16:04: > > This patch add component OVL_2L2 > > Signed-off-by: Yongqiang Niu > Reviewed-by: Chun-Kuang Hu Reviewed-by: Enric Balletbo i Serra > --- > include/linux/soc/mediatek/mtk-mmsys.h |

Re: [PATCH v5, 2/4] soc: mediatek: mmsys: add component POSTMASK

2021-04-16 Thread Enric Balletbo Serra
Hi Yongqiang, Thank you for your patch. Missatge de Yongqiang Niu del dia dl., 12 d’abr. 2021 a les 16:05: > > This patch add component POSTMASK > > Signed-off-by: Yongqiang Niu Reviewed-by: Enric Balletbo i Serra > --- > include/linux/soc/mediatek/mtk-mmsys.h | 1 + > 1 file changed, 1 ins

Re: [PATCHv2 2/6] drm/omapdrm/dss/hdmi4: switch to the connector bridge ops

2021-04-16 Thread Tomi Valkeinen
On 02/03/2021 18:23, Hans Verkuil wrote: Implement the new connector_attach/detach bridge ops. This makes it possible to associate a CEC adapter with a drm connector, which helps userspace determine which cec device node belongs to which drm connector. Signed-off-by: Hans Verkuil --- drivers/

Re: [Intel-gfx] [PATCH v3 3/4] drm/i915/uapi: convert i915_query and friend to kernel doc

2021-04-16 Thread Tvrtko Ursulin
On 15/04/2021 16:59, Matthew Auld wrote: Add a note about the two-step process. Suggested-by: Daniel Vetter Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Jordan Justen Cc: Daniel Vetter Cc: Kenneth Graunke Cc: Jason Ekstrand Cc: Dave Airlie Cc: dri-devel@lists.freedesktop.org Cc:

Re: [PATCH -next] drm: bridge: fix ANX7625 use of mipi_dsi_() functions

2021-04-16 Thread Robert Foss
Thanks Randy! Reviewed-by: Robert Foss On Thu, 15 Apr 2021 at 20:36, Randy Dunlap wrote: > > The Analogix DRM ANX7625 bridge driver uses mips_dsi_() function > interfaces so it should select DRM_MIPI_DSI to prevent build errors. > > > ERROR: modpost: "mipi_dsi_attach" > [drivers/gpu/drm/bridge

Re: [PATCH v2 04/10] drm/aperture: Add infrastructure for aperture ownership

2021-04-16 Thread Daniel Vetter
On Thu, Apr 15, 2021 at 09:12:14PM +0200, Thomas Zimmermann wrote: > Hi > > Am 15.04.21 um 14:57 schrieb Daniel Vetter: > > On Thu, Apr 15, 2021 at 08:56:20AM +0200, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 09.04.21 um 11:22 schrieb Daniel Vetter: > > > > > Is it that easy? simepldrm's de

Re: [PATCH v3 1/4] drm/i915/uapi: hide kernel doc warnings

2021-04-16 Thread Daniel Vetter
On Thu, Apr 15, 2021 at 04:59:55PM +0100, Matthew Auld wrote: > It's not properly formatted kernel doc, just nerf the warnings for now. > > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Jordan Justen > Cc: Daniel Vetter > Cc: Kenneth Graunke > Cc: Jason Ekstrand > Cc: Dave Airlie

Re: [PATCH v3 2/4] drm/i915/uapi: convert i915_user_extension to kernel doc

2021-04-16 Thread Daniel Vetter
On Thu, Apr 15, 2021 at 04:59:56PM +0100, Matthew Auld wrote: > Add some example usage for the extension chaining also, which is quite > nifty. > > Suggested-by: Daniel Vetter > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Jordan Justen > Cc: Daniel Vetter > Cc: Kenneth Graunke >

Re: [PATCH v3 3/4] drm/i915/uapi: convert i915_query and friend to kernel doc

2021-04-16 Thread Daniel Vetter
On Thu, Apr 15, 2021 at 04:59:57PM +0100, Matthew Auld wrote: > Add a note about the two-step process. > > Suggested-by: Daniel Vetter > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Jordan Justen > Cc: Daniel Vetter > Cc: Kenneth Graunke > Cc: Jason Ekstrand > Cc: Dave Airlie >

Re: [PATCH v3 1/4] drm/i915/uapi: hide kernel doc warnings

2021-04-16 Thread Daniel Vetter
On Fri, Apr 16, 2021 at 10:44:28AM +0200, Daniel Vetter wrote: > On Thu, Apr 15, 2021 at 04:59:55PM +0100, Matthew Auld wrote: > > It's not properly formatted kernel doc, just nerf the warnings for now. > > > > Signed-off-by: Matthew Auld > > Cc: Joonas Lahtinen > > Cc: Jordan Justen > > Cc: Da

Re: [Mesa-dev] [PATCH v3 3/4] drm/i915/uapi: convert i915_query and friend to kernel doc

2021-04-16 Thread Daniel Vetter
On Fri, Apr 16, 2021 at 12:25 AM Ian Romanick wrote: > On 4/15/21 8:59 AM, Matthew Auld wrote: > > Add a note about the two-step process. > > > > Suggested-by: Daniel Vetter > > Signed-off-by: Matthew Auld > > Cc: Joonas Lahtinen > > Cc: Jordan Justen > > Cc: Daniel Vetter > > Cc: Kenneth Gra

[PATCH v4 0/9] drm: Support simple-framebuffer devices and firmware fbs

2021-04-16 Thread Thomas Zimmermann
This patchset adds support for simple-framebuffer platform devices and a handover mechanism for native drivers to take-over control of the hardware. The new driver, called simpledrm, binds to a simple-frambuffer platform device. The kernel's boot code creates such devices for firmware-provided fra

[PATCH v4 1/9] drm/format-helper: Pass destination pitch to drm_fb_memcpy_dstclip()

2021-04-16 Thread Thomas Zimmermann
The memcpy's destination buffer might have a different pitch than the source. Support different pitches as function argument. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Tested-by: nerdopolis --- drivers/gpu/drm/drm_format_helper.c| 9 + drivers/gpu/drm/mgag200/mgag

[PATCH v4 3/9] drm/aperture: Add infrastructure for aperture ownership

2021-04-16 Thread Thomas Zimmermann
Platform devices might operate on firmware framebuffers, such as VESA or EFI. Before a native driver for the graphics hardware can take over the device, it has to remove any platform driver that operates on the firmware framebuffer. Aperture helpers provide the infrastructure for platform drivers t

[PATCH v4 7/9] drm/simpledrm: Acquire clocks from DT device node

2021-04-16 Thread Thomas Zimmermann
Make sure required hardware clocks are enabled while the firmware framebuffer is in use. The basic code has been taken from the simplefb driver and adapted to DRM. Clocks are released automatically via devres helpers. Signed-off-by: Thomas Zimmermann Tested-by: nerdopolis --- drivers/gpu/drm/t

[PATCH v4 6/9] drm/simpledrm: Initialize framebuffer data from device-tree node

2021-04-16 Thread Thomas Zimmermann
A firmware framebuffer might also be specified via device-tree files. If no device platform data is given, try the DT device node. v2: * add Device Tree match table * clean-up parser wrappers Signed-off-by: Thomas Zimmermann Tested-by: nerdopolis --- drivers/gpu/drm/tiny/simple

[PATCH v4 5/9] drm/simpledrm: Add fbdev emulation

2021-04-16 Thread Thomas Zimmermann
This displays a console on simpledrm's framebuffer. The default framebuffer format is being used. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Tested-by: nerdopolis --- drivers/gpu/drm/tiny/simpledrm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/tiny/s

[PATCH v4 2/9] drm/format-helper: Add blitter functions

2021-04-16 Thread Thomas Zimmermann
The blitter functions copy a framebuffer to I/O memory using one of the existing conversion functions. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Tested-by: nerdopolis --- drivers/gpu/drm/drm_format_helper.c | 87 + include/drm/drm_format_helper.h

[PATCH v4 9/9] drm/simpledrm: Acquire memory aperture for framebuffer

2021-04-16 Thread Thomas Zimmermann
We register the simplekms device with the DRM platform helpers. A native driver for the graphics hardware will kick-out the simpledrm driver before taking over the device. The original generic platform device from the simple-framebuffer boot code will be unregistered. The native driver will use wh

[PATCH v4 4/9] drm: Add simpledrm driver

2021-04-16 Thread Thomas Zimmermann
The simpledrm driver is a DRM driver for simple-framebuffer framebuffers as provided by the kernel's boot code. This driver enables basic graphical output on many different graphics devices that are provided by the platform (e.g., EFI, VESA, embedded framebuffers). With the kernel's simple-framebu

[PATCH v4 8/9] drm/simpledrm: Acquire regulators from DT device node

2021-04-16 Thread Thomas Zimmermann
Make sure required hardware regulators are enabled while the firmware framebuffer is in use. The basic code has been taken from the simplefb driver and adapted to DRM. Regulators are released automatically via devres helpers. v2: * use strscpy() Signed-off-by: Thomas Zimmermann Tested-b

Re: [PATCH] drm/omap: dsi: Add missing IRQF_ONESHOT

2021-04-16 Thread Krzysztof Kozlowski
On Mon, 22 Mar 2021 at 09:53, Yang Li wrote: > > fixed the following coccicheck: > ./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with > no primary handler requested without IRQF_ONESHOT > > Make sure threaded IRQs without a primary handler are always request > with IRQF_ONESHO

[V3] drm/i915/gt: Fix a lockdep warning with interrupts enabled

2021-04-16 Thread Jun Miao
Don`t simplely disable local interrupt delivery of CPU hardware irq, should race the region inside signal_irq_work, include intel_breadcrumbs_disarm_irq/intel_breadcrumbs_arm_irq. RT complains about might sleep inside signal_irq_work() because spin_lock will be invoked after disabling interrupts.

Re: [PATCH -next] drm: bridge: fix LONTIUM use of mipi_dsi_() functions

2021-04-16 Thread Robert Foss
Merged for 5.13 in drm-misc-next-fixes On Thu, 15 Apr 2021 at 21:36, Adrien Grassein wrote: > > Reviewed-by: Adren Grassein > > Le jeu. 15 avr. 2021 à 20:36, Randy Dunlap a écrit : > > > > The Lontium DRM bridge drivers use mipi_dsi_() function interfaces so > > they need to select DRM_MIPI_DSI

Re: [PATCH -next] drm: bridge: fix ANX7625 use of mipi_dsi_() functions

2021-04-16 Thread Robert Foss
Merged for 5.13 in drm-misc-next-fixes On Fri, 16 Apr 2021 at 10:41, Robert Foss wrote: > > Thanks Randy! > > Reviewed-by: Robert Foss > > On Thu, 15 Apr 2021 at 20:36, Randy Dunlap wrote: > > > > The Analogix DRM ANX7625 bridge driver uses mips_dsi_() function > > interfaces so it should selec

Re: [PATCH v3 4/4] drm/doc/rfc: i915 DG1 uAPI

2021-04-16 Thread Daniel Vetter
On Thu, Apr 15, 2021 at 04:59:58PM +0100, Matthew Auld wrote: > Add an entry for the new uAPI needed for DG1. > > v2(Daniel): > - include the overall upstreaming plan > - add a note for mmap, there are differences here for TTM vs i915 > - bunch of other suggestions from Daniel > v3: > (Dani

[PATCH 0/2] drm/bridge: dw-hdmi: disable loading of DW-HDMI CEC sub-driver

2021-04-16 Thread Neil Armstrong
This adds DW-HDMI driver a glue option to disable loading of the CEC sub-driver. On some SoCs, the CEC functionality is enabled in the IP config bits, but the CEC bus is non-functional like on Amlogic SoCs, where the CEC config bit is set but the DW-HDMI CEC signal is not connected to a physical p

[PATCH 1/2] drm/bridge/synopsys: dw-hdmi: Add an option to suppress loading CEC driver

2021-04-16 Thread Neil Armstrong
From: Jernej Skrabec This adds DW-HDMI driver a glue option to disable loading of the CEC sub-driver. On some SoCs, the CEC functionality is enabled in the IP config bits, but the CEC bus is non-functional like on Amlogic SoCs, where the CEC config bit is set but the DW-HDMI CEC signal is not co

[PATCH 2/2] drm/meson: dw-hdmi: disable DW-HDMI CEC sub-driver

2021-04-16 Thread Neil Armstrong
On the Amlogic SoCs, the DW-HDMI HW support is here but the DW-HDMI CEC signal is not connected to a physical pin, leading to confusion when the dw-hdmi cec controller can't communicate on the bus. Disable it to avoid exposing a non-functinal bus. Signed-off-by: Neil Armstrong --- drivers/gpu/d

[PATCH] drm/bridge: nwl-dsi: Get MIPI DSI controller and PHY ready in ->mode_set()

2021-04-16 Thread Liu Ying
Some MIPI DSI panel drivers like 'raydium,rm68200' send MIPI_DCS_SET_DISPLAY_ON commands in panel_funcs->prepare(), which requires the MIPI DSI controller and PHY to be ready beforehand. Without this patch, the nwl-dsi driver gets the MIPI DSI controller and PHY ready in bridge_funcs->pre_enable(),

Re: [PATCH 0/2] drm/bridge: dw-hdmi: disable loading of DW-HDMI CEC sub-driver

2021-04-16 Thread Laurent Pinchart
Hi Neil, On Fri, Apr 16, 2021 at 11:27:35AM +0200, Neil Armstrong wrote: > This adds DW-HDMI driver a glue option to disable loading of the CEC > sub-driver. > > On some SoCs, the CEC functionality is enabled in the IP config bits, but the > CEC bus is non-functional like on Amlogic SoCs, where

Re: [PATCH 00/57] Rid W=1 warnings from Staging

2021-04-16 Thread Fabio Aiuto
On Wed, Apr 14, 2021 at 07:10:32PM +0100, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Lee Jones (57): > staging: r8192U_core: Remove two unused variables 'ret' and

[PATCH] dma-buf: Add DmaBufTotal counter in meminfo

2021-04-16 Thread Peter Enderborg
This adds a total used dma-buf memory. Details can be found in debugfs, however it is not for everyone and not always available. Signed-off-by: Peter Enderborg --- drivers/dma-buf/dma-buf.c | 12 fs/proc/meminfo.c | 2 ++ include/linux/dma-buf.h | 1 + 3 files changed, 1

回复:[PATCH] drm/omap: dsi: Add missing IRQF_ONESHOT

2021-04-16 Thread Yang.Lee
I am so sorry for my mistakes. I am a newbie trying to learn how to fix errors found by Coccinelle. Currently, I just run scripts/checkpatch.pl. I will do basic build with the patch before sending it in the next time. Thank you for your advice.

[PATCH] drm/amdgpu/pm: use linux/processor.h instead of asm/processor.h

2021-04-16 Thread Colin King
From: Colin Ian King Checkpatch reported that linux/processor.h should be included instead of the asm variant. Fix this to clean up the warning. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/

[PATCH 1/4] drm/i915/uapi: fix kernel doc warnings

2021-04-16 Thread Matthew Auld
Fix the cases where it is almost already valid kernel doc, for the others just nerf the warnings for now. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Jordan Justen Cc: Daniel Vetter Cc: Kenneth Graunke Cc: Jason Ekstrand Cc: Dave Airlie Cc: dri-devel@lists.freedesktop.org Cc: mesa-.

[PATCH 2/4] drm/doc: add section for driver uAPI

2021-04-16 Thread Matthew Auld
Add section for drm/i915 uAPI and pull in i915_drm.h. Suggested-by: Daniel Vetter Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Jordan Justen Cc: Daniel Vetter Cc: Kenneth Graunke Cc: Jason Ekstrand Cc: Dave Airlie Cc: dri-devel@lists.freedesktop.org Cc: mesa-...@lists.freedesktop.or

[PATCH 3/4] drm/i915/uapi: convert i915_user_extension to kernel doc

2021-04-16 Thread Matthew Auld
Add some example usage for the extension chaining also, which is quite nifty. v2: (Daniel) - clarify that the name is just some integer, also document that the name space is not global Suggested-by: Daniel Vetter Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Jordan Justen Cc: Dani

[PATCH 4/4] drm/i915/uapi: convert i915_query and friend to kernel doc

2021-04-16 Thread Matthew Auld
Add a note about the two-step process. v2(Tvrtko): - Also document the other method of just passing in a buffer which is large enough, which avoids two ioctl calls. Can make sense for smaller query items. Suggested-by: Daniel Vetter Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc:

Re: [PATCH 1/4] drm/vmwgfx: Make console emulation depend on DRM_FBDEV_EMULATION

2021-04-16 Thread Thomas Zimmermann
Am 15.04.21 um 20:50 schrieb Thomas Zimmermann: Hi Am 15.04.21 um 20:21 schrieb Zack Rusin: On 4/15/21 7:00 AM, Thomas Zimmermann wrote: Respect DRM's kconfig setting for fbdev console emulation. If enabled, it will select all required config options. So remove them from vmwgfx's Kconfig fil

Re: [PATCH] dma-buf: Add DmaBufTotal counter in meminfo

2021-04-16 Thread Matthew Wilcox
On Fri, Apr 16, 2021 at 11:37:19AM +0200, Peter Enderborg wrote: > diff --git a/fs/proc/meminfo.c b/fs/proc/meminfo.c > index 6fa761c9cc78..3c1a82b51a6f 100644 > --- a/fs/proc/meminfo.c > +++ b/fs/proc/meminfo.c > @@ -16,6 +16,7 @@ > #ifdef CONFIG_CMA > #include > #endif > +#include > #includ

Re: [PATCH] dma-buf: Add DmaBufTotal counter in meminfo

2021-04-16 Thread Christian König
Am 16.04.21 um 11:37 schrieb Peter Enderborg: This adds a total used dma-buf memory. Details can be found in debugfs, however it is not for everyone and not always available. Well you are kind of missing the intention here. I mean knowing this is certainly useful in some case, but you need to

Re: [PATCH] drm/rockchip: Cope with endpoints that haven't been registered yet

2021-04-16 Thread Jonathan McDowell
On Sun, Mar 21, 2021 at 07:58:13PM +0100, Heiko Stuebner wrote: > Am Dienstag, 16. März 2021, 19:27:53 CET schrieb Jonathan McDowell: > > The Rockchip RGB CRTC output driver attempts to avoid probing Rockchip > > subdrivers to see if they're a connected panel or bridge. However part > > of its chec

Re: [PATCH 0/2] drm/bridge: dw-hdmi: disable loading of DW-HDMI CEC sub-driver

2021-04-16 Thread Neil Armstrong
On 16/04/2021 11:58, Laurent Pinchart wrote: > Hi Neil, > > On Fri, Apr 16, 2021 at 11:27:35AM +0200, Neil Armstrong wrote: >> This adds DW-HDMI driver a glue option to disable loading of the CEC >> sub-driver. >> >> On some SoCs, the CEC functionality is enabled in the IP config bits, but the >>

Re: [PATCH v5 1/1] drm/bridge: lt8912b: fix incorrect handling of of_* return values

2021-04-16 Thread Adrien Grassein
Hi Robert, Could you please have a look at this patch? It has been reviewed by the bug reporter and another person. I don't receive any "merged" message. Thanks a lot, Adrien Le mer. 31 mars 2021 à 16:42, Dan Carpenter a écrit : > > On Wed, Mar 31, 2021 at 03:33:13PM +0200, Adrien Grassein wro

[PATCH v1 2/2] fbtft: Don't spam logs when probe is deferred

2021-04-16 Thread Andy Shevchenko
When requesting GPIO line the probe can be deferred. In such case don't spam logs with an error message. This can be achieved by switching to dev_err_probe(). Signed-off-by: Andy Shevchenko --- drivers/staging/fbtft/fbtft-core.c | 12 1 file changed, 4 insertions(+), 8 deletions(-)

[PATCH v1 1/2] fbtft: Rectify GPIO handling

2021-04-16 Thread Andy Shevchenko
The infamous commit c440eee1a7a1 ("Staging: fbtft: Switch to the GPIO descriptor interface") broke GPIO handling completely. It has already four commits to rectify and it seems not enough. In order to fix the mess here we: 1) Set default to "inactive" for all requested pins 2) Fix CS, RD, and

[PATCH v2] dma-buf: Add DmaBufTotal counter in meminfo

2021-04-16 Thread Peter Enderborg
This adds a total used dma-buf memory. Details can be found in debugfs, however it is not for everyone and not always available. dma-buf are indirect allocated by userspace. So with this value we can monitor and detect userspace applications that have problems. Signed-off-by: Peter Enderborg ---

Re: [PATCH v2] dma-buf: Add DmaBufTotal counter in meminfo

2021-04-16 Thread Christian König
Am 16.04.21 um 14:33 schrieb Peter Enderborg: This adds a total used dma-buf memory. Details can be found in debugfs, however it is not for everyone and not always available. dma-buf are indirect allocated by userspace. So with this value we can monitor and detect userspace applications that h

Re: [PATCH v1 1/2] fbtft: Rectify GPIO handling

2021-04-16 Thread Greg Kroah-Hartman
On Fri, Apr 16, 2021 at 03:31:16PM +0300, Andy Shevchenko wrote: > The infamous commit c440eee1a7a1 ("Staging: fbtft: Switch to > the GPIO descriptor interface") broke GPIO handling completely. > It has already four commits to rectify and it seems not enough. > In order to fix the mess here we: >

[PATCH] drm: Fix fbcon blank on QEMU graphics drivers

2021-04-16 Thread Takashi Iwai
Currently the DRM fbcon helper for console blank, drm_fb_helper_blank(), simply calls drm_fb_helper_dpms() and always returns zero, supposing the driver dealing with DPMS or atomic crtc->active flip to handle blanking the screen. It works on most of devices, but broken on most of KVM/QEMU graphics

Re: [PATCH 1/3] drm/amdgpu: make sure we unpin the UVD BO

2021-04-16 Thread Christian König
Ping? Am 15.04.21 um 10:47 schrieb Christian König: Releasing pinned BOs is illegal now. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.

[PATCH v3 0/7] drm: Clean up mmap for TTM-based GEM drivers

2021-04-16 Thread Thomas Zimmermann
Implement mmap via struct drm_gem_object_functions.mmap in amdgpu, radeon and nouveau. This allows for using common DRM helpers for the mmap-related callbacks in struct file_operations and struct drm_driver. The drivers have their own vm_ops, which are now set automatically by the DRM core function

[PATCH v3 2/7] drm/amdgpu: Implement mmap as GEM object function

2021-04-16 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. This change resolves several inconsistencies between regular mmap and prime-based mmap. The vm_ops field in vma is now set for all mmap'ed areas. Previously it way only set for

[PATCH v3 1/7] drm/ttm: Don't override vm_ops callbacks, if set

2021-04-16 Thread Thomas Zimmermann
Drivers may want to set their own callbacks for a VM area. Only set TTM's callbacks if the vm_ops field is clear. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drive

[PATCH v3 4/7] drm/nouveau: Implement mmap as GEM object function

2021-04-16 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The GEM object function is provided by GEM TTM helpers. Nouveau's implementation of verify_access is unused and has been removed. Access permissions are validated by the DRM hel

[PATCH v3 6/7] drm/vmwgfx: Inline vmw_verify_access()

2021-04-16 Thread Thomas Zimmermann
Vmwgfx is the only user of the TTM's verify_access callback. Inline the call and avoid the indirection through the function pointer. Signed-off-by: Thomas Zimmermann Reviewed-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 9 - drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c

[PATCH v3 3/7] drm/radeon: Implement mmap as GEM object function

2021-04-16 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. This change also allows to support prime-based mmap via DRM's helper drm_gem_prime_mmap(). Permission checks are implemented by drm_gem_mmap(), with an additional check for rad

[PATCH v3 5/7] drm/vmwgfx: Inline ttm_bo_mmap() into vmwgfx driver

2021-04-16 Thread Thomas Zimmermann
The vmwgfx driver is the only remaining user of ttm_bo_mmap(). Inline the code. The internal helper ttm_bo_vm_lookup() is now also part of vmwgfx as vmw_bo_vm_lookup(). v2: * replace pr_err() with drm_err() (Zack) Signed-off-by: Thomas Zimmermann Reviewed-by: Zack Rusin --- drivers/gpu

[PATCH v3 7/7] drm/ttm: Remove ttm_bo_mmap() and friends

2021-04-16 Thread Thomas Zimmermann
The function ttm_bo_mmap is unused. Remove it and it's helpers; including the verify_access callback in struct ttm_device_funcs. Signed-off-by: Thomas Zimmermann Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 53 - include/drm/ttm/ttm_bo_api.h

[PULL] drm-fixes

2021-04-16 Thread Daniel Vetter
Hi Linus, I pinged the usual suspects, only intel fixes pending. drm-next also looks ready, minus the big pull request summary Dave will have to type next week. Cheers, Daniel drm-fixes-2021-04-16: drm/i915 fixes Cheers, Daniel The following changes since commit d434405aaab7d0ebc516b68a8fc4100

Re: [PATCH v1 1/2] fbtft: Rectify GPIO handling

2021-04-16 Thread Andy Shevchenko
On Fri, Apr 16, 2021 at 02:51:59PM +0200, Greg Kroah-Hartman wrote: > On Fri, Apr 16, 2021 at 03:31:16PM +0300, Andy Shevchenko wrote: > > The infamous commit c440eee1a7a1 ("Staging: fbtft: Switch to > > the GPIO descriptor interface") broke GPIO handling completely. > > It has already four commits

Re: [PATCH v1 1/2] fbtft: Rectify GPIO handling

2021-04-16 Thread Andy Shevchenko
On Fri, Apr 16, 2021 at 04:37:48PM +0300, Andy Shevchenko wrote: > On Fri, Apr 16, 2021 at 02:51:59PM +0200, Greg Kroah-Hartman wrote: > > On Fri, Apr 16, 2021 at 03:31:16PM +0300, Andy Shevchenko wrote: > > > The infamous commit c440eee1a7a1 ("Staging: fbtft: Switch to > > > the GPIO descriptor in

Re: [PATCH v3 0/7] drm: Clean up mmap for TTM-based GEM drivers

2021-04-16 Thread Christian König
Patches #1-#4 are Reviewed-by: Christian König One more comment on the vmw patches. Regards, Christian. Am 16.04.21 um 15:31 schrieb Thomas Zimmermann: Implement mmap via struct drm_gem_object_functions.mmap in amdgpu, radeon and nouveau. This allows for using common DRM helpers for the mmap-

Re: [PATCH v3 5/7] drm/vmwgfx: Inline ttm_bo_mmap() into vmwgfx driver

2021-04-16 Thread Christian König
Am 16.04.21 um 15:31 schrieb Thomas Zimmermann: The vmwgfx driver is the only remaining user of ttm_bo_mmap(). Inline the code. The internal helper ttm_bo_vm_lookup() is now also part of vmwgfx as vmw_bo_vm_lookup(). v2: * replace pr_err() with drm_err() (Zack) Signed-off-by: Thomas Zim

Re: [PATCH v3 5/7] drm/vmwgfx: Inline ttm_bo_mmap() into vmwgfx driver

2021-04-16 Thread Christian König
Am 16.04.21 um 15:46 schrieb Christian König: Am 16.04.21 um 15:31 schrieb Thomas Zimmermann: The vmwgfx driver is the only remaining user of ttm_bo_mmap(). Inline the code. The internal helper ttm_bo_vm_lookup() is now also part of vmwgfx as vmw_bo_vm_lookup(). v2: * replace pr_err() with

Re: [Intel-gfx] [PATCH 06/19] drm/i915/stolen: pass the allocation flags

2021-04-16 Thread Matthew Auld
On 14/04/2021 16:09, Tvrtko Ursulin wrote: On 12/04/2021 10:05, Matthew Auld wrote: From: CQ Tang Stolen memory is always allocated as physically contiguous pages, mark the object flags as such. Signed-off-by: CQ Tang Signed-off-by: Matthew Auld ---   drivers/gpu/drm/i915/gem/i915_gem_stol

Re: [PATCH v3 5/7] drm/vmwgfx: Inline ttm_bo_mmap() into vmwgfx driver

2021-04-16 Thread Thomas Zimmermann
Hi Am 16.04.21 um 15:46 schrieb Christian König: Am 16.04.21 um 15:31 schrieb Thomas Zimmermann: The vmwgfx driver is the only remaining user of ttm_bo_mmap(). Inline the code. The internal helper ttm_bo_vm_lookup() is now also part of vmwgfx as vmw_bo_vm_lookup(). v2: * replace pr_err() w

Re: [PATCH 2/4] drm/doc: add section for driver uAPI

2021-04-16 Thread Daniel Vetter
On Fri, Apr 16, 2021 at 12:37 PM Matthew Auld wrote: > > Add section for drm/i915 uAPI and pull in i915_drm.h. > > Suggested-by: Daniel Vetter > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Jordan Justen > Cc: Daniel Vetter > Cc: Kenneth Graunke > Cc: Jason Ekstrand > Cc: Dave Ai

[PATCH v2 4/4] fbtft: Update TODO

2021-04-16 Thread Andy Shevchenko
Now, after a few fixes we may consider the conversion to the GPIO descriptor API is done. Signed-off-by: Andy Shevchenko --- v2: new patch split from the bigger fix (Greg) drivers/staging/fbtft/TODO | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/fbtft/TODO b/drivers/stag

[PATCH v2 2/4] fbtft: Rectify GPIO handling

2021-04-16 Thread Andy Shevchenko
The infamous commit c440eee1a7a1 ("Staging: fbtft: Switch to the GPIO descriptor interface") broke GPIO handling completely. It has already four commits to rectify and it seems not enough. In order to fix the mess here we: 1) Set default to "inactive" for all requested pins 2) Fix CS, RD, and

[PATCH v2 1/4] fbtft: Replace custom ->reset() with generic one

2021-04-16 Thread Andy Shevchenko
The custom ->reset() repeats the generic one, replace it. Note, in newer kernels the context of the function is a sleeping one, it's fine to switch over to the sleeping functions. Keeping the reset line asserted longer than 20 microseconds is also okay, it's an idling state of the hardware. Fixes

[PATCH v2 3/4] fbtft: Don't spam logs when probe is deferred

2021-04-16 Thread Andy Shevchenko
When requesting GPIO line the probe can be deferred. In such case don't spam logs with an error message. This can be achieved by switching to dev_err_probe(). Signed-off-by: Andy Shevchenko --- v2: no changes drivers/staging/fbtft/fbtft-core.c | 12 1 file changed, 4 insertions(+),

Re: [PATCH v1 1/2] fbtft: Rectify GPIO handling

2021-04-16 Thread Andy Shevchenko
On Fri, Apr 16, 2021 at 02:51:59PM +0200, Greg Kroah-Hartman wrote: > On Fri, Apr 16, 2021 at 03:31:16PM +0300, Andy Shevchenko wrote: > > The infamous commit c440eee1a7a1 ("Staging: fbtft: Switch to > > the GPIO descriptor interface") broke GPIO handling completely. > > It has already four commits

Re: [Intel-gfx] [PATCH 12/19] drm/i915/lmem: Bypass aperture when lmem is available

2021-04-16 Thread Matthew Auld
On 14/04/2021 16:33, Tvrtko Ursulin wrote: On 12/04/2021 10:05, Matthew Auld wrote: From: Anusha Srivatsa In the scenario where local memory is available, we have rely on CPU access via lmem directly instead of aperture. v2: gmch is only relevant for much older hw, therefore we can drop the

Re: [PATCH 1/3] drm/amdgpu: make sure we unpin the UVD BO

2021-04-16 Thread Leo Liu
Acked-by: Leo Liu On 2021-04-16 8:54 a.m., Christian König wrote: Ping? Am 15.04.21 um 10:47 schrieb Christian König: Releasing pinned BOs is illegal now. Signed-off-by: Christian König ---   drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 1 +   1 file changed, 1 insertion(+) diff --git a/drivers/

[PATCH 00/40] [Set 16] Rid W=1 warnings from GPU!

2021-04-16 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (40): drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc drm/nouveau/dispnv50/disp: Remove unused variable 'ret'

[PATCH 01/40] drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc

2021-04-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function parameter or member 'init' not described in 'init_reserved' drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:611: warning: Function parameter or member 'init' not described in

[PATCH 03/40] drm/msm/dp/dp_display: Remove unused variable 'hpd'

2021-04-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/dp/dp_display.c: In function ‘dp_display_usbpd_attention_cb’: drivers/gpu/drm/msm/dp/dp_display.c:496:19: warning: variable ‘hpd’ set but not used [-Wunused-but-set-variable] Cc: Rob Clark Cc: Sean Paul Cc: David Airlie C

[PATCH 04/40] include: drm: drm_atomic: Make use of 'new_plane_state'

2021-04-16 Thread Lee Jones
In the macro for_each_oldnew_plane_in_state() 'new_plane_state' is provided as a container for state->planes[i].new_state, but is not utilised in some use-cases, so we fake-use it instead. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.

[PATCH 07/40] drm/nouveau/nouveau_bo: Remove unused variables 'dev'

2021-04-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_bo.c: In function ‘nouveau_ttm_tt_populate’: drivers/gpu/drm/nouveau/nouveau_bo.c:1228:17: warning: variable ‘dev’ set but not used [-Wunused-but-set-variable] drivers/gpu/drm/nouveau/nouveau_bo.c: In function ‘no

[PATCH 05/40] drm/nouveau/nvkm/subdev/volt/gk20a: Demote non-conformant kernel-doc headers

2021-04-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:53: warning: Function parameter or member 'speedo' not described in 'gk20a_volt_get_cvb_voltage' drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:53: warning: Function parameter or member 's_scale

[PATCH 10/40] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' from function returning void

2021-04-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv50/disp.c: In function ‘nv50_mstm_cleanup’: drivers/gpu/drm/nouveau/dispnv50/disp.c:1357:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter C

[PATCH 02/40] drm/nouveau/dispnv50/disp: Remove unused variable 'ret'

2021-04-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv50/disp.c:1381:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org Signed

[PATCH 09/40] drm/nouveau/dispnv04/crtc: Demote non-conforming kernel-doc headers

2021-04-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv04/crtc.c:462: warning: Function parameter or member 'crtc' not described in 'nv_crtc_mode_set_regs' drivers/gpu/drm/nouveau/dispnv04/crtc.c:462: warning: Function parameter or member 'mode' not described in 'nv_crt

[PATCH 06/40] drm/nouveau/nvkm/engine/gr/gf100: Demote non-conformant kernel-doc header

2021-04-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:992: warning: Function parameter or member 'gr' not described in 'gf100_gr_wait_idle' Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouv...@lists.freede

[PATCH 08/40] drm/nouveau/nouveau_display: Remove set but unused variable 'width'

2021-04-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_display.c: In function ‘nouveau_framebuffer_new’: drivers/gpu/drm/nouveau/nouveau_display.c:309:15: warning: variable ‘width’ set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs Cc: David Airlie Cc: Dan

[PATCH 12/40] drm/nouveau/nv50_display: Remove superfluous prototype for local static functions

2021-04-16 Thread Lee Jones
Fixes the following build error: drivers/gpu/drm/nouveau/dispnv50/disp.c:2530:1: error: conflicting types for ‘nv50_display_fini’ In file included from drivers/gpu/drm/nouveau/dispnv50/disp.c:71: drivers/gpu/drm/nouveau/nv50_display.h:36:6: note: previous declaration of ‘nv50_display_fini’ wa

[PATCH 11/40] drm/nouveau/dispnv50/headc57d: Make local function 'headc57d_olut' static

2021-04-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv50/headc57d.c:173:1: warning: no previous prototype for ‘headc57d_olut’ [-Wmissing-prototypes] Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: Lyude Paul Cc: dri-devel@lists.freedesktop.org Cc: nouv...@list

[PATCH 16/40] drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment block

2021-04-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or member 'filp' not described in 'nouveau_compat_ioctl' drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or member 'cmd' not described in 'nouveau_co

[PATCH 14/40] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc

2021-04-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_ioc32.c:2: warning: Cannot understand * file mga_ioc32.c Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org Signed-off-by: Lee Jones --- dr

[PATCH 20/40] drm/xlnx/zynqmp_disp: Fix incorrectly documented enum 'zynqmp_disp_id'

2021-04-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/xlnx/zynqmp_disp.c:101: warning: expecting prototype for enum zynqmp_disp_id. Prototype was for enum zynqmp_disp_layer_id instead Cc: Hyun Kwon Cc: Laurent Pinchart Cc: David Airlie Cc: Daniel Vetter Cc: Michal Simek Cc: dri-

[PATCH 18/40] drm/omapdrm/omap_irq: Fix a couple of incorrectly documented functions

2021-04-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/omapdrm/omap_irq.c:114: warning: expecting prototype for enable_vblank(). Prototype was for omap_irq_enable_vblank() instead drivers/gpu/drm/omapdrm/omap_irq.c:140: warning: expecting prototype for disable_vblank(). Prototype was

[PATCH 15/40] drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void function

2021-04-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_svm.c: In function ‘nouveau_pfns_map’: drivers/gpu/drm/nouveau/nouveau_svm.c:810:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri

[PATCH 13/40] drm/nouveau/dispnv50/disp: Include header containing our prototypes

2021-04-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv50/disp.c:2599:1: warning: no previous prototype for ‘nv50_display_create’ [-Wmissing-prototypes] Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouv...@lists.freedesktop

[PATCH 19/40] drm/omapdrm/omap_gem: Properly document omap_gem_dumb_map_offset()

2021-04-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/omapdrm/omap_gem.c:619: warning: expecting prototype for omap_gem_dumb_map(). Prototype was for omap_gem_dumb_map_offset() instead Cc: Tomi Valkeinen Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" C

  1   2   >