Re: [PATCH] vt_ioctl: make VT_RESIZEX behave like VT_RESIZE

2021-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 12:15 AM Linus Torvalds wrote: > > On Sun, Apr 11, 2021 at 2:43 PM Maciej W. Rozycki wrote: > > > > So it does trigger with vgacon and my old server, which I have started > > experimenting with and for a start I have switched to a new kernel for an > > unrelated purpose (

adjust rdma fifo threshold calculate formula

2021-04-12 Thread Yongqiang Niu
This patch base Linux 5.12-rc2 provide one patch Yongqiang Niu (1): drm/mediatek: adjust rdma fifo threshold calculate formula drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.1.1.dirty ___ dri-

[PATCH v1] drm/mediatek: adjust rdma fifo threshold calculate formula

2021-04-12 Thread Yongqiang Niu
the orginal formula will caused rdma fifo threshold config overflow Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c i

Re: [Intel-gfx] [PATCH v2 15/18] vfio/gvt: Make DRM_I915_GVT depend on VFIO_MDEV

2021-04-12 Thread Zhenyu Wang
On 2021.04.06 16:40:38 -0300, Jason Gunthorpe wrote: > At some point there may have been some reason for this weird split in this > driver, but today only the VFIO side is actually implemented. > > However, it got messed up at some point and mdev code was put in gvt.c and > is pretending to be "ge

Re: [PATCH v4] drm/ast: Fixed CVE for DP501

2021-04-12 Thread Thomas Zimmermann
Hi this patch produces a NULL-ptr deref as shown below. The chip is detected as AST 2100. Best regards Thomas == [ 23.641896] BUG: KASAN: null-ptr-deref in ast_device_create.cold+0x137/0x210 [ast] [ 23.642257] Read of siz

Re: [PATCH v2 16/18] vfio/gvt: Use mdev_get_type_group_id()

2021-04-12 Thread Zhenyu Wang
On 2021.04.06 16:40:39 -0300, Jason Gunthorpe wrote: > intel_gvt_init_vgpu_type_groups() makes gvt->types 1:1 with the > supported_type_groups array, so the type_group_id is also the index into > gvt->types. Use it directly and remove the string matching. > > Reviewed-by: Kevin Tian > Reviewed-by

Re: [PATCH] gpu/drm: mediatek: hdmi: check for valid modes on MT8167

2021-04-12 Thread Neil Armstrong
On 10/04/2021 00:41, Chun-Kuang Hu wrote: > Hi, Neil: > > Neil Armstrong 於 2021年4月9日 週五 下午4:43寫道: >> >> On MT8167, only CEA modes and anything using a clock below 148500 is >> supported for HDMI. This change adds some checks to make sure the >> video format is OK for MT8167. > > I think this pat

Re: [PATCH v1, 1/3] drm/mediatek: Separate aal module

2021-04-12 Thread CK Hu
Hi, Yongqiang: On Mon, 2021-04-12 at 14:35 +0800, Yongqiang Niu wrote: > mt8183 aal has no gamma function Separate this patch to two patch: one is add has_gamma config in aal. another one is add mt8183 aal support. Regards, CK > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek

Re: [PATCH v1, 3/3] drm/mediatek: gamma set with cmdq

2021-04-12 Thread CK Hu
Hi, Yongqiang: On Mon, 2021-04-12 at 14:35 +0800, Yongqiang Niu wrote: > gamma lut set in vsync active will caused display flash issue > set gamma lut with cmdq In MT8173, it's ok to set gammma out of vblank period. Why do you setting gamma in vblank in this patch? Regards, CK > > Signed-off-

Re: [PATCH v1] drm/mediatek: adjust rdma fifo threshold calculate formula

2021-04-12 Thread CK Hu
Hi, Yongqiang: On Mon, 2021-04-12 at 15:25 +0800, Yongqiang Niu wrote: > the orginal formula will caused rdma fifo threshold config overflow > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v1, 3/3] drm/mediatek: gamma set with cmdq

2021-04-12 Thread Yongqiang Niu
On Mon, 2021-04-12 at 16:28 +0800, CK Hu wrote: > Hi, Yongqiang: > > On Mon, 2021-04-12 at 14:35 +0800, Yongqiang Niu wrote: > > gamma lut set in vsync active will caused display flash issue > > set gamma lut with cmdq > > In MT8173, it's ok to set gammma out of vblank period. Why do you > setti

[PATCH 3/3] drm/aperture: Inline fbdev conflict helpers into aperture helpers

2021-04-12 Thread Thomas Zimmermann
Fbdev's helpers for handling conflicting framebuffer drivers are related to framebuffer apertures, not console emulation. Therefore remove them from drm_fb_helper.h and inline them into the aperture helpers. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Daniel Vetter --- dri

[PATCH 0/3] drm: Add aperture helpers

2021-04-12 Thread Thomas Zimmermann
Adds helpers for maintaining aperture ownership. Currently wraps the infrastructure around fbdev's remove_conflicting_framebuffers(). For adding generic drivers to DRM, we need a hand-over mechanism that unloads the generic driver before loading the hardware's native driver. So far, this was suppo

[PATCH 1/3] drm/aperture: Add infrastructure for aperture ownership

2021-04-12 Thread Thomas Zimmermann
Platform devices might operate on firmware framebuffers, such as VESA or EFI. Before a native driver for the graphics hardware can take over the device, it has to remove any platform driver that operates on the firmware framebuffer. Aperture helpers provide the infrastructure for native drivers to

[PATCH 2/3] drm/aperture: Convert drivers to aperture interfaces

2021-04-12 Thread Thomas Zimmermann
Mass-convert all drivers from FB helpers to aperture interfaces. No functional changes besides checking for returned errno codes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- drivers/gpu/drm/armada/armada_drv.c | 5 ++-- drivers/gpu/drm/

Re: [PATCH v1, 3/3] drm/mediatek: gamma set with cmdq

2021-04-12 Thread CK Hu
Hi, Yongqiang: On Mon, 2021-04-12 at 16:45 +0800, Yongqiang Niu wrote: > On Mon, 2021-04-12 at 16:28 +0800, CK Hu wrote: > > Hi, Yongqiang: > > > > On Mon, 2021-04-12 at 14:35 +0800, Yongqiang Niu wrote: > > > gamma lut set in vsync active will caused display flash issue > > > set gamma lut with

[PATCH 00/19] More DG1 enabling

2021-04-12 Thread Matthew Auld
Next batch of DG1 patches. With this we should now get a booting DG1 system with the kernel selftests passing. Anshuman Gupta (1): drm/i915/oprom: Basic sanitization Anusha Srivatsa (1): drm/i915/lmem: Bypass aperture when lmem is available CQ Tang (3): drm/i915: Create stolen memory regio

[PATCH 01/19] drm/i915/gt: Skip aperture remapping selftest where there is no aperture

2021-04-12 Thread Matthew Auld
From: Chris Wilson If there is no mappable aperture, we cannot remap it for access, and the selftest is void. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld Reviewed-by: Imre Deak --- drivers/gpu/drm/i915/selftests/i915_vma.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/driv

[PATCH 07/19] drm/i915/fbdev: Use lmem physical addresses for fb_mmap() on discrete

2021-04-12 Thread Matthew Auld
From: Mohammed Khajapasha use local memory io BAR address for fbdev's fb_mmap() operation on discrete, fbdev uses the physical address of our framebuffer for its fb_mmap() fn. Signed-off-by: Mohammed Khajapasha --- drivers/gpu/drm/i915/display/intel_fbdev.c | 29 +- 1 file

[PATCH 03/19] drm/i915: Create stolen memory region from local memory

2021-04-12 Thread Matthew Auld
From: CQ Tang Add "REGION_STOLEN" device info to dg1, create stolen memory region from upper portion of local device memory, starting from DSMBASE. v2: - s/drm_info/drm_dbg; userspace likely doesn't care about stolen. - mem->type is only setup after the region probe, so setting the name

[PATCH 02/19] drm/i915/selftests: Only query RAPL for integrated power measurements

2021-04-12 Thread Matthew Auld
From: Chris Wilson RAPL provides an on-package power measurements which does not encompass discrete graphics, so let's avoid using the igfx masurements when testing dgfx. Later we will abstract the simple librapl interface over hwmon so that we can verify basic power consumption scenarios. Signe

[PATCH 05/19] drm/i915/stolen: enforce the min_page_size contract

2021-04-12 Thread Matthew Auld
From: CQ Tang Since stolen can now be device local-memory underneath, we should try to enforce any min_page_size restrictions when allocating pages. Signed-off-by: CQ Tang Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 7 --- 1 file changed, 4 insertions(+),

[PATCH 06/19] drm/i915/stolen: pass the allocation flags

2021-04-12 Thread Matthew Auld
From: CQ Tang Stolen memory is always allocated as physically contiguous pages, mark the object flags as such. Signed-off-by: CQ Tang Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH 09/19] drm/i915/lmem: Fail driver init if LMEM training failed

2021-04-12 Thread Matthew Auld
From: Matt Roper Boot firmware performs memory training and health assessment during startup. If the memory training fails, the firmware will consider the GPU unusable and will instruct the punit to keep the GT powered down. If this happens, our driver will be unable to communicate with the GT (

[PATCH 04/19] drm/i915/stolen: treat stolen local as normal local memory

2021-04-12 Thread Matthew Auld
Underneath it's the same stuff, so things like the PTE_LM bits for the GTT should just keep working as-is. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_lmem.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_lmem.c b/

[PATCH 08/19] drm/i915: Return error value when bo not in LMEM for discrete

2021-04-12 Thread Matthew Auld
From: Mohammed Khajapasha Return EREMOTE value when frame buffer object is not backed by LMEM for discrete. If Local memory is supported by hardware the framebuffer backing gem objects should be from local memory. Signed-off-by: Mohammed Khajapasha --- drivers/gpu/drm/i915/display/intel_displa

[PATCH 10/19] drm/i915/dg1: Fix mapping type for default state object

2021-04-12 Thread Matthew Auld
From: Venkata Ramana Nayana Use I915_MAP_WC when default state object is allocated in LMEM. Signed-off-by: Venkata Ramana Nayana Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gt/shmem_utils.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/s

[PATCH 11/19] drm/i915: Update the helper to set correct mapping

2021-04-12 Thread Matthew Auld
From: Venkata Sandeep Dhanalakota Determine the possible coherent map type based on object location, and if target has llc or if user requires an always coherent mapping. Cc: Matthew Auld Cc: CQ Tang Suggested-by: Michal Wajdeczko Signed-off-by: Venkata Sandeep Dhanalakota --- drivers/gpu/d

[PATCH 12/19] drm/i915/lmem: Bypass aperture when lmem is available

2021-04-12 Thread Matthew Auld
From: Anusha Srivatsa In the scenario where local memory is available, we have rely on CPU access via lmem directly instead of aperture. v2: gmch is only relevant for much older hw, therefore we can drop the has_aperture check since it should always be present on such platforms. (Chris) Cc: Vil

[PATCH 13/19] drm/i915/dg1: Read OPROM via SPI controller

2021-04-12 Thread Matthew Auld
From: Clint Taylor Read OPROM SPI through MMIO and find VBT entry since we can't use OpRegion and PCI mapping may not work on some systems due to the BIOS not leaving the Option ROM mapped. v2 by Jani: - switch to intel_uncore_read/intel_uncore_write Cc: Ville Syrjälä Cc: Tomas Winkler Cc: Jo

[PATCH 14/19] drm/i915/oprom: Basic sanitization

2021-04-12 Thread Matthew Auld
From: Anshuman Gupta Sanitize OPROM header, CPD signature and OPROM PCI version. OPROM_HEADER, EXPANSION_ROM_HEADER and OPROM_MEU_BLOB structures and PCI struct offsets are provided by GSC counterparts. These are yet to be Documented in B.Spec. After successful sanitization, extract VBT from opre

[PATCH 15/19] drm/i915: WA for zero memory channel

2021-04-12 Thread Matthew Auld
From: José Roberto de Souza Commit c457d9cf256e ("drm/i915: Make sure we have enough memory bandwidth on ICL") assumes that we always have a non-zero dram_info->channels and uses it as a divisor. We need num memory channels to be at least 1 for sane bw limits checking, even when PCode returns 0,

[PATCH 16/19] drm/i915/dg1: Compute MEM Bandwidth using MCHBAR

2021-04-12 Thread Matthew Auld
From: Clint Taylor The PUNIT FW is currently returning 0 for all memory bandwidth parameters. Read the values directly from MCHBAR offsets 0x5918 and 0x4000(4). This is a temporary WA until the PUNIT FW returns valid values. v2 (Lucas): Add error to log since this is fixed in new pcode available

[PATCH 17/19] drm/i915/dg1: Double memory bandwidth available

2021-04-12 Thread Matthew Auld
From: Clint Taylor Use MCHBAR Gear_type information to compute memory bandwidth available during MCHBAR calculations. v2 by Jani: - switch to intel_uncore_read/intel_uncore_write Tested-by: Swati Sharma Cc: Swati Sharma Cc: Ville Syrjälä Signed-off-by: Clint Taylor Signed-off-by: Jani Nikul

[PATCH 19/19] drm/i915/gtt/dgfx: place the PD in LMEM

2021-04-12 Thread Matthew Auld
It's a requirement that for dgfx we place all the paging structures in device local-memory. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 5 - drivers/gpu/drm/i915/gt/intel_gtt.c | 27 +-- drivers/gpu/drm/i915/gt/intel_gtt.h | 1 + 3 files

[PATCH 18/19] drm/i915/gtt: map the PD up front

2021-04-12 Thread Matthew Auld
We need to general our accessor for the page directories and tables from using the simple kmap_atomic to support local memory, and this setup must be done on acquisition of the backing storage prior to entering fence execution contexts. Here we replace the kmap with the object maping code that for

Re: [PATCH 1/2] drm/i915/display/vlv_dsi: Do not skip panel_pwr_cycle_delay when disabling the panel

2021-04-12 Thread Hans de Goede
Hi, On 4/7/21 3:57 PM, Ville Syrjälä wrote: > On Wed, Apr 07, 2021 at 03:50:35PM +0200, Hans de Goede wrote: >> Hi, >> >> On 4/7/21 2:34 PM, Ville Syrjälä wrote: >>> On Tue, Apr 06, 2021 at 03:57:32PM +0200, Hans de Goede wrote: Hi, On 3/25/21 12:48 PM, Hans de Goede wrote: > Af

Re: [PATCH 1/3] drm/aperture: Add infrastructure for aperture ownership

2021-04-12 Thread Jani Nikula
On Mon, 12 Apr 2021, Thomas Zimmermann wrote: > + * DRM drivers should call drm_aperture_remove_conflicting_framebuffers() > + * at the top of their probe function. The function removes any generic > + * driver that is currently associated with the given framebuffer memory. > + * If the framebuffe

[PATCH v2 0/5] mediatek: hdmi: add MT8167 configuration

2021-04-12 Thread Neil Armstrong
The MT8167 SoC have a hard limit on the maximal supported HDMI TMDS clock, and is not validated and supported for HDMI modes out of HDMI CEA modes. To achieve this: - switch the mediatek HDMI bindings to YAML - add the MT8167 compatible - add a boolean to discard the non-CEA modes - add a value to

[PATCH v2 5/5] gpu/drm: mediatek: hdmi: add MT8167 configuration

2021-04-12 Thread Neil Armstrong
The MT8167 SoC have a hard limit on the maximal supported HDMI TMDS clock, and is not validated and supported for HDMI modes out of HDMI CEA modes, so add a configuration entry linked to the MT8167 compatible. Signed-off-by: Fabien Parent Signed-off-by: Neil Armstrong --- drivers/gpu/drm/mediat

[PATCH v2 2/5] dt-bindings: mediatek: add mt8167 to hdmi, hdmi-ddc and cec bindings

2021-04-12 Thread Neil Armstrong
Add mt8167 SoC compatible to Mediatek hdmi, hdmi-ddc and cec schema bindings. Signed-off-by: Neil Armstrong --- .../devicetree/bindings/display/mediatek/mediatek,cec.yaml | 1 + .../devicetree/bindings/display/mediatek/mediatek,hdmi-ddc.yaml | 1 + .../devicetree/bindings/display/mediatek

[PATCH v2 1/5] dt-bindings: display: mediatek, hdmi: Convert to use graph schema

2021-04-12 Thread Neil Armstrong
Update the mediatek,dpi binding to use the graph schema. Signed-off-by: Neil Armstrong --- .../display/mediatek/mediatek,cec.yaml| 51 +++ .../display/mediatek/mediatek,hdmi-ddc.yaml | 57 .../display/mediatek/mediatek,hdmi.txt| 136 -- .../displa

[PATCH v2 3/5] gpu/drm: mediatek: hdmi: add check for CEA modes only

2021-04-12 Thread Neil Armstrong
Some SoCs like the MT8167 are not validated and supported for HDMI modes out of HDMI CEA modes, so add a configuration boolean to filter out non-CEA modes. Signed-off-by: Fabien Parent Signed-off-by: Neil Armstrong --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 4 1 file changed, 4 insertions(+

[PATCH v2 4/5] gpu/drm: mediatek: hdmi: add optional limit on maximal HDMI mode clock

2021-04-12 Thread Neil Armstrong
Some SoCs like the MT8167 have a hard limit on the maximal supported HDMI TMDS clock, so add a configuration value to filter out those modes. Signed-off-by: Fabien Parent Signed-off-by: Neil Armstrong --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [PATCH v2 4/5] drm/vc4: hdmi: Enable the scrambler

2021-04-12 Thread Dave Stevenson
Hi Maxime On Fri, 9 Apr 2021 at 13:36, Maxime Ripard wrote: > > Hi Dave, > > On Thu, Apr 01, 2021 at 12:30:45PM +0100, Dave Stevenson wrote: > > > Signed-off-by: Maxime Ripard > > > --- > > > drivers/gpu/drm/vc4/vc4_hdmi.c | 56 + > > > drivers/gpu/drm/vc4/vc4_h

Re: [PATCH 07/18] drm/vc4: hdmi: Add full range RGB helper

2021-04-12 Thread Thomas Zimmermann
Am 17.03.21 um 16:43 schrieb Maxime Ripard: We're going to need to tell whether we want to run with a full or limited range RGB output in multiple places in the code, so let's create a helper that will return whether we need with full range or not. Signed-off-by: Maxime Ripard Acked-by: Tho

Re: [PATCH 08/18] drm/vc4: hdmi: Use full range helper in csc functions

2021-04-12 Thread Thomas Zimmermann
Am 17.03.21 um 16:43 schrieb Maxime Ripard: The CSC callbacks takes a boolean as an argument to tell whether we're using the full range or limited range RGB. However, with the upcoming YUV support, the logic will be a bit more complex. In order to address this, let's make the callbacks take th

Re: [PATCH 09/18] drm/vc4: hdmi: Remove limited_rgb_range

2021-04-12 Thread Thomas Zimmermann
Am 17.03.21 um 16:43 schrieb Maxime Ripard: The limited_rgb_range field in the vc4_hdmi_encoder structure is used to tell whether we're supposed to output with a full or limited RGB range. This is redundant with the new helper we introduced, so let's convert to that helper and drop that field.

Re: [PATCH 10/18] drm/vc4: hdmi: Convert to bridge

2021-04-12 Thread Thomas Zimmermann
Am 17.03.21 um 16:43 schrieb Maxime Ripard: Converting the HDMI controller to a bridge seems like the preferred way to support an YUV output, so let's do this. Signed-off-by: Maxime Ripard Acked-by: Thomas Zimmermann --- drivers/gpu/drm/vc4/vc4_crtc.c | 37 ++- drivers/gpu/dr

Re: [PATCH 11/18] drm/vc4: hdmi: Move XBAR setup to csc_setup

2021-04-12 Thread Thomas Zimmermann
Am 17.03.21 um 16:43 schrieb Maxime Ripard: On the BCM2711, the HDMI_VEC_INTERFACE_XBAR register configuration depends on whether we're using an RGB or YUV output. Let's move that configuration to the CSC setup. Signed-off-by: Maxime Ripard Acked-by: Thomas Zimmermann --- drivers/gpu/d

Re: [PATCH 12/18] drm/vc4: hdmi: Replace CSC_CTL hardcoded value by defines

2021-04-12 Thread Thomas Zimmermann
Am 17.03.21 um 16:43 schrieb Maxime Ripard: On BCM2711, the HDMI_CSC_CTL register value has been hardcoded to an opaque value. Let's replace it with properly defined values. Signed-off-by: Maxime Ripard Acked-by: Thomas Zimmermann --- drivers/gpu/drm/vc4/vc4_hdmi.c | 5 ++--- drivers/

Re: [PATCH 1/3] drm/aperture: Add infrastructure for aperture ownership

2021-04-12 Thread Thomas Zimmermann
Hi Am 12.04.21 um 11:36 schrieb Jani Nikula: On Mon, 12 Apr 2021, Thomas Zimmermann wrote: + * DRM drivers should call drm_aperture_remove_conflicting_framebuffers() + * at the top of their probe function. The function removes any generic + * driver that is currently associated with the given

Re: [PATCH 1/3] drm/aperture: Add infrastructure for aperture ownership

2021-04-12 Thread Jani Nikula
On Mon, 12 Apr 2021, Thomas Zimmermann wrote: > Hi > > Am 12.04.21 um 11:36 schrieb Jani Nikula: >> Please test the documentation build before applying. > > I did and I'm pretty sure it looked correct. But I'll double check. Cool, maybe someone added more smarts to kernel-doc. :) BR, Jani. --

[PATCH] gpu: drm: Replace bare "unsigned" with "unsigned int"

2021-04-12 Thread Fabio M. De Francesco
Replaced the type "unsigned" with "unsigned int" because it is preferred. Issue detected by checkpatch.pl. Signed-off-by: Fabio M. De Francesco --- drivers/gpu/drm/drm_atomic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/

Re: [PATCH 1/3] drm/aperture: Add infrastructure for aperture ownership

2021-04-12 Thread Thomas Zimmermann
Hi Am 12.04.21 um 12:41 schrieb Jani Nikula: On Mon, 12 Apr 2021, Thomas Zimmermann wrote: Hi Am 12.04.21 um 11:36 schrieb Jani Nikula: Please test the documentation build before applying. I did and I'm pretty sure it looked correct. But I'll double check. Cool, maybe someone added more

[PATCH v2, 1/5] Revert "drm/mediatek: Make sure previous message done or be aborted before send"

2021-04-12 Thread Yongqiang Niu
This reverts commit 839cbf0531428f3f9535077a461b8631359c1165. Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index 8b0de90..c76f446 1006

[PATCH v2, 3/5] Revert "dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value"

2021-04-12 Thread Yongqiang Niu
This reverts commit f83b03fc727ab56a77e68713d6e40299698f3c9f. Signed-off-by: Yongqiang Niu --- Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetr

[PATCH v2, 4/5] Revert "arm64: dts: mediatek: mt8183: fix gce incorrect mbox-cells value"

2021-04-12 Thread Yongqiang Niu
This reverts commit e55c56df43dd11de4a6c08e3ea52ca45b51c8800. Signed-off-by: Yongqiang Niu --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index 8

[PATCH v2, 0/5] Revert "mailbox: mediatek: remove implementation related to atomic_exec"

2021-04-12 Thread Yongqiang Niu
This series base linux 5.12-rc2 these patches will cause home ui flick when cursor moved, there is no fix solution yet, revert these patches first. change since v1: add mtk-gce.txt and dts modification Yongqiang Niu (5): Revert "drm/mediatek: Make sure previous message done or be aborted be

[PATCH v2, 5/5] arm64: dts: mediatek: mt8183: add gce information for mmsys

2021-04-12 Thread Yongqiang Niu
add gce information for mmsys Signed-off-by: Yongqiang Niu --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index bc89283..e3a8b10 100644 --- a/arch/arm64/boot/

[PATCH v2, 2/5] Revert "mailbox: mediatek: remove implementation related to atomic_exec"

2021-04-12 Thread Yongqiang Niu
This reverts commit c9ea564f3d9dd20d88bd34f40a6ff6d31a0d7e8c. Signed-off-by: Yongqiang Niu --- drivers/mailbox/mtk-cmdq-mailbox.c | 80 +- 1 file changed, 71 insertions(+), 9 deletions(-) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-

Re: [PATCH v1, 3/3] drm/mediatek: gamma set with cmdq

2021-04-12 Thread kernel test robot
submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Yongqiang-Niu/gamma-set-with-cmdq/20210412-143659 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next con

[PATCH v4, 0/3] support gce on mt8192 platform

2021-04-12 Thread Yongqiang Niu
Change since v3: -fix review comment in v2 Change since v2: - add controy_by_sw for mt8192 Change since v1: - move out shift jump patch - remove useless patch Yongqiang Niu (3): dt-binding: gce: add gce header file for mt8192 arm64: dts: mt8192: add gce node mailbox: cmdq: add mt8192 suppo

[PATCH v4, 1/3] dt-binding: gce: add gce header file for mt8192

2021-04-12 Thread Yongqiang Niu
Add documentation for the mt8192 gce. Add gce header file defined the gce hardware event, subsys number and constant for mt8192. Signed-off-by: Yongqiang Niu Reviewed-by: Rob Herring Signed-off-by: Hsin-Yi Wang --- .../devicetree/bindings/mailbox/mtk-gce.txt| 7 +- include/dt-bindin

[PATCH v4, 3/3] mailbox: cmdq: add mt8192 support

2021-04-12 Thread Yongqiang Niu
add mt8192 support Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/mailbox/mtk-cmdq-mailbox.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index e0d9a86..8da700a 100644 --- a/drivers

[PATCH v4, 2/3] arm64: dts: mt8192: add gce node

2021-04-12 Thread Yongqiang Niu
add gce node for mt8192 Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi index 9757138..1afa6

Re: [PATCH] gpu: drm: Replace bare "unsigned" with "unsigned int"

2021-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 12:53:09PM +0200, Fabio M. De Francesco wrote: > Replaced the type "unsigned" with "unsigned int" because it is > preferred. Issue detected by checkpatch.pl. Huh, I didn't know that, TIL. > Signed-off-by: Fabio M. De Francesco Thanks for your patche, merged to drm-misc-n

[RFC PATCH] drm/doc/rfc: i915 DG1 uAPI

2021-04-12 Thread Matthew Auld
Add an entry for the new uAPI needed for DG1. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Daniel Vetter Cc: Dave Airlie --- Documentation/gpu/rfc/i915_create_ext.c | 48 ++ .../gpu/rfc/i915_create_ext_placements.c | 19 Documentation/gpu/rfc/i915_region_query.c

[PATCH 1/2] gpu: drm: Replace "unsigned" with "unsigned int"

2021-04-12 Thread Fabio M. De Francesco
Replaced "unsigned with "unsigned int" since the latter is preferred. Signed-off-by: Fabio M. De Francesco --- drivers/gpu/drm/drm_atomic_helper.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.

[PATCH 0/2] gpu: drm: Change types and format comments

2021-04-12 Thread Fabio M. De Francesco
Replaced "unsigned" with "unsigned int" and formatted comments according to the Linux style guidelines. Issues detected by checkpatch.pl. Fabio M. De Francesco (2): gpu: drm: Replace "unsigned" with "unsigned int" gpu: drm: Correct comments format drivers/gpu/drm/drm_atomic_helper.c | 40 +++

[PATCH 2/2] gpu: drm: Correct comments format

2021-04-12 Thread Fabio M. De Francesco
Corrected comments format in accordance to the Linux style guides. Signed-off-by: Fabio M. De Francesco --- drivers/gpu/drm/drm_atomic_helper.c | 32 +++-- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/d

Re: [PATCH] gpu: drm: Replace bare "unsigned" with "unsigned int"

2021-04-12 Thread Fabio M. De Francesco
On Monday, April 12, 2021 2:11:59 PM CEST Daniel Vetter wrote: > On Mon, Apr 12, 2021 at 12:53:09PM +0200, Fabio M. De Francesco wrote: > > Replaced the type "unsigned" with "unsigned int" because it is > > preferred. Issue detected by checkpatch.pl. > > Huh, I didn't know that, TIL. > > > Signed

Re: [RFC PATCH] drm/doc/rfc: i915 DG1 uAPI

2021-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 2:18 PM Matthew Auld wrote: > > Add an entry for the new uAPI needed for DG1. > > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Daniel Vetter > Cc: Dave Airlie > --- > Documentation/gpu/rfc/i915_create_ext.c | 48 ++ > .../gpu/rfc/i915_create_ex

Re: [PATCH 1/2] gpu: drm: Replace "unsigned" with "unsigned int"

2021-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 2:21 PM Fabio M. De Francesco wrote: > > Replaced "unsigned with "unsigned int" since the latter is preferred. > > Signed-off-by: Fabio M. De Francesco Nit for the subjects: In drm we generally don't have the gpu prefix, but just the level below + what component. So for t

[PATCH v2 0/2] drm: drm_atomic_helper.c: Change types and format comments

2021-04-12 Thread Fabio M. De Francesco
Replaced "unsigned" with "unsigned int" and formatted comments according to the Linux style guidelines. Issues detected by checkpatch.pl. Changes from v1: Rewrote the "Subject" of the patches in the series. Fabio M. De Francesco (2): gpu: drm: Replace "unsigned" with "unsigned int" gpu: drm:

[PATCH v2 1/2] drm: drm_atomic_helper.c: Replace "unsigned" with "unsigned int"

2021-04-12 Thread Fabio M. De Francesco
Replaced "unsigned with "unsigned int" since the latter is preferred. Signed-off-by: Fabio M. De Francesco --- Changes from v1: Rewrote the "Subject" of the patches in the series drivers/gpu/drm/drm_atomic_helper.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dri

[PATCH v2 2/2] drm: drm_atomic_helper.c: Correct comments format

2021-04-12 Thread Fabio M. De Francesco
Corrected comments format in accordance to the Linux style guides. Signed-off-by: Fabio M. De Francesco --- Changes from v1: Rewrote the "Subject" of the patches in the series drivers/gpu/drm/drm_atomic_helper.c | 32 +++-- 1 file changed, 21 insertions(+), 11 deletions

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-12 Thread Kevin Tang
Hi Thomas, Thomas Zimmermann 于2021年4月8日周四 下午6:53写道: > Hi, > > please see my comments below. > > Best regards > Thomas > > Am 22.02.21 um 14:28 schrieb Kevin Tang: > > Adds DPU(Display Processor Unit) support for the Unisoc's display > subsystem. > > It's support multi planes, scaler, rotation, P

[PATCH v2 0/3] drm: Add aperture helpers

2021-04-12 Thread Thomas Zimmermann
Adds helpers for maintaining aperture ownership. Currently wraps the infrastructure around fbdev's remove_conflicting_framebuffers(). For adding generic drivers to DRM, we need a hand-over mechanism that unloads the generic driver before loading the hardware's native driver. So far, this was suppo

[PATCH v2 3/3] drm/aperture: Inline fbdev conflict helpers into aperture helpers

2021-04-12 Thread Thomas Zimmermann
Fbdev's helpers for handling conflicting framebuffer drivers are related to framebuffer apertures, not console emulation. Therefore remove them from drm_fb_helper.h and inline them into the aperture helpers. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Daniel Vetter Acked-by

[PATCH v2 2/3] drm/aperture: Convert drivers to aperture interfaces

2021-04-12 Thread Thomas Zimmermann
Mass-convert all drivers from FB helpers to aperture interfaces. No functional changes besides checking for returned errno codes. Signed-off-by: Thomas Zimmermann Acked-by: Jani Nikula --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- drivers/gpu/drm/armada/armada_drv.c | 5

[PATCH v2 1/3] drm/aperture: Add infrastructure for aperture ownership

2021-04-12 Thread Thomas Zimmermann
Platform devices might operate on firmware framebuffers, such as VESA or EFI. Before a native driver for the graphics hardware can take over the device, it has to remove any platform driver that operates on the firmware framebuffer. Aperture helpers provide the infrastructure for native drivers to

Re: [PATCH v3] drivers: introduce and use WANT_DMA_CMA for soft dependencies on DMA_CMA

2021-04-12 Thread Robin Murphy
On 2021-04-09 14:39, David Hildenbrand wrote: On 09.04.21 15:35, Arnd Bergmann wrote: On Fri, Apr 9, 2021 at 1:21 PM David Hildenbrand wrote: Random drivers should not override a user configuration of core knobs (e.g., CONFIG_DMA_CMA=n). Applicable drivers would like to use DMA_CMA, which dep

Re: [PATCH 2/2] drm/doc: emphasize difference between plane formats and IN_FORMATS blob

2021-04-12 Thread Daniel Vetter
On Thu, Apr 08, 2021 at 05:39:22PM +0300, Ville Syrjälä wrote: > On Thu, Apr 08, 2021 at 04:57:51PM +0300, Pekka Paalanen wrote: > > On Thu, 8 Apr 2021 13:30:16 +0200 > > Daniel Vetter wrote: > > > > > On Thu, Apr 08, 2021 at 12:59:19PM +0300, Pekka Paalanen wrote: > > > > > > The point of these

[RFC PATCH] drm/ttm: Simplify the delayed destroy locking

2021-04-12 Thread Thomas Hellström
This RFC needs some decent testing on a driver with bos that share reservation objects, and of course a check for whether I missed something obvious. The locking around delayed destroy is rather complex due to the fact that we want to individualize dma_resv pointers before putting the object on th

Re: [PATCH v3] drivers: introduce and use WANT_DMA_CMA for soft dependencies on DMA_CMA

2021-04-12 Thread David Hildenbrand
On 12.04.21 15:12, Robin Murphy wrote: On 2021-04-09 14:39, David Hildenbrand wrote: On 09.04.21 15:35, Arnd Bergmann wrote: On Fri, Apr 9, 2021 at 1:21 PM David Hildenbrand wrote: Random drivers should not override a user configuration of core knobs (e.g., CONFIG_DMA_CMA=n). Applicable driv

Re: [PATCH v2 1/5] dt-bindings: display: mediatek, hdmi: Convert to use graph schema

2021-04-12 Thread Rob Herring
On Mon, 12 Apr 2021 11:39:24 +0200, Neil Armstrong wrote: > Update the mediatek,dpi binding to use the graph schema. > > Signed-off-by: Neil Armstrong > --- > .../display/mediatek/mediatek,cec.yaml| 51 +++ > .../display/mediatek/mediatek,hdmi-ddc.yaml | 57 > .../displa

Re: [PATCH] vt_ioctl: make VT_RESIZEX behave like VT_RESIZE

2021-04-12 Thread Maciej W. Rozycki
On Mon, 12 Apr 2021, Daniel Vetter wrote: > > Note that it's entirely possible that things continue to work well > > despite this warning. It's unclear to me from your email if you > > actually see any difference (and apparently you're not able to see it > > right now due to not being close to the

Re: [PATCH 0/2] Document how userspace should use plane format list and IN_FORMATS

2021-04-12 Thread Daniel Vetter
On Thu, Apr 08, 2021 at 07:24:30PM -0300, Leandro Ribeiro wrote: > > > On 4/8/21 8:35 AM, Daniel Vetter wrote: > > On Tue, Apr 06, 2021 at 04:21:16PM -0300, Leandro Ribeiro wrote: > >> This patch is to emphasize how userspace should use the plane format list > >> and > >> the IN_FORMATS blob. Th

Re: [RFC PATCH] drm/ttm: Simplify the delayed destroy locking

2021-04-12 Thread Christian König
Hi Thomas, well in general a good idea, but I'm working on a different plan for a while now. My idea here is that instead of the BO the resource object is kept on a double linked lru list. The resource objects then have a pointer to either the BO or a fence object. When it is a fence objec

[PATCH v5, 2/4] soc: mediatek: mmsys: add component POSTMASK

2021-04-12 Thread Yongqiang Niu
This patch add component POSTMASK Signed-off-by: Yongqiang Niu --- include/linux/soc/mediatek/mtk-mmsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h index f6b58f9..7718cd6 100644 --- a/include/linux/soc/med

[PATCH v5, 3/4] soc: mediatek: mmsys: add component RDMA4

2021-04-12 Thread Yongqiang Niu
This patch add component RDMA4 Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu --- include/linux/soc/mediatek/mtk-mmsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h index 7718cd6..4bba275 100644 --

[PATCH v5, 1/4] soc: mediatek: mmsys: add component OVL_2L2

2021-04-12 Thread Yongqiang Niu
This patch add component OVL_2L2 Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu --- include/linux/soc/mediatek/mtk-mmsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h index 2228bf6..f6b58f9 100644

[PATCH v5, 4/4] soc: mediatek: mmsys: Add mt8192 mmsys routing table

2021-04-12 Thread Yongqiang Niu
mt8192 has different routing registers than mt8183 Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mt8192-mmsys.h | 68 + drivers/soc/mediatek/mtk-mmsys.c| 7 2 files changed, 75 insertions(+) create mode 100644 drivers/soc/mediatek/mt8192-mms

[PATCH v5, 0/4] soc: mediatek: mmsys: add mt8192 mmsys support

2021-04-12 Thread Yongqiang Niu
base 5.12-rc2 and https://patchwork.kernel.org/project/linux-mediatek/patch/20210330110423.3542163-1-hsi...@chromium.org/ Change since v4: - use routing table Yongqiang Niu (4): soc: mediatek: mmsys: add component OVL_2L2 soc: mediatek: mmsys: add component POSTMASK soc: mediatek: mmsys: ad

Re: [RFC PATCH] drm/ttm: Simplify the delayed destroy locking

2021-04-12 Thread Thomas Hellström
Hi, Christian, On 4/12/21 4:01 PM, Christian König wrote: Hi Thomas, well in general a good idea, but I'm working on a different plan for a while now. My idea here is that instead of the BO the resource object is kept on a double linked lru list. The resource objects then have a pointer t

[PATCH v7, 0/5] drm/mediatek: add support for mediatek SOC MT8192

2021-04-12 Thread Yongqiang Niu
This series are based on Linux v5.12-rc2 and following patch: https://patchwork.kernel.org/project/linux-mediatek/cover/1618236288-1617-1-git-send-email-yongqiang@mediatek.com/ Change since v6: - rebase Yongqiang Niu (5): drm/mediatek: add component OVL_2L2 drm/mediatek: add component PO

[PATCH v7, 3/5] drm/mediatek: add component RDMA4

2021-04-12 Thread Yongqiang Niu
This patch add component RDMA4 Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm

[PATCH v7, 5/5] drm/mediatek: add support for mediatek SOC MT8192

2021-04-12 Thread Yongqiang Niu
add support for mediatek SOC MT8192 Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 6 + drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 20 +++ drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 + driver

[PATCH v7, 4/5] soc: mediatek: add mtk mutex support for MT8192

2021-04-12 Thread Yongqiang Niu
Add mtk mutex support for MT8192 SoC. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/soc/mediatek/mtk-mutex.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediate

  1   2   >