Hi
Am 31.03.21 um 08:56 schrieb Kuo-Hsiang Chou:
Message-ID: <20201228030823.294147-1-kuohsiang_c...@aspeedtech.com>
-Original Message-
From: Thomas Zimmermann [mailto:tzimmerm...@suse.de]
Sent: Monday, March 29, 2021 5:17 PM
To: Kuo-Hsiang Chou ;
dri-devel@lists.freedesktop.org; linux
https://bugzilla.kernel.org/show_bug.cgi?id=211425
--- Comment #15 from Andreas (icedragon...@web.de) ---
I setup the automatic power management for the GPU/display down to 3 minutes.
After the 3 minutes the desktop manager blanks the display. I pressed a key to
wake up, but the monitor stays blan
On Tue, Mar 30, 2021 at 08:04:38PM -0700, Vivek Kasireddy wrote:
> If support for Blob resources is available, then dumb BOs created
> by the driver can be considered as guest Blobs. And, for guest
> Blobs, there is no need to do any transfers or flushes
No. VIRTGPU_BLOB_FLAG_USE_SHAREABLE means
Hi,
> -#define MAX_INLINE_CMD_SIZE 96
> +#define MAX_INLINE_CMD_SIZE 112
Separate patch please.
> --- a/include/uapi/linux/virtio_gpu.h
> +++ b/include/uapi/linux/virtio_gpu.h
> @@ -409,6 +409,7 @@ struct virtio_gpu_set_scanout_blob {
> __le32 width;
> __le32 height;
> __
Hello Adrien Grassein,
The patch 30e2ae943c26: "drm/bridge: Introduce LT8912B DSI to HDMI
bridge" from Mar 26, 2021, leads to the following static checker
warning:
drivers/gpu/drm/bridge/lontium-lt8912b.c:638 lt8912_parse_dt()
warn: 'endpoint' isn't an ERR_PTR
drivers/gpu/drm/bri
On Wed, Mar 31, 2021 at 11:12:38AM +0300, Dan Carpenter wrote:
>644 of_node_put(endpoint);
>645
>646 lt->host_node = of_graph_get_remote_node(dev->of_node, 0, -1);
>647 if (!lt->host_node) {
>648 dev_err(lt->dev, "%s: Failed to get r
https://bugzilla.kernel.org/show_bug.cgi?id=212499
Bug ID: 212499
Summary: nouveau locking issue - WARNING: possible circular
locking dependency detected
Product: Drivers
Version: 2.5
Kernel Version: 5.12-rc5
Hardware:
https://bugzilla.kernel.org/show_bug.cgi?id=212499
--- Comment #1 from Erhard F. (erhar...@mailbox.org) ---
Created attachment 296157
--> https://bugzilla.kernel.org/attachment.cgi?id=296157&action=edit
kernel .config (kernel 5.12-rc5, A10-9700E)
--
You may reply to this email to add a comment
Hi Douglas,
W dniu 30.03.2021 o 04:53, Douglas Anderson pisze:
> The drm_bridge_chain_pre_enable() is not the proper opposite of
> drm_bridge_chain_post_disable(). It continues along the chain to
> _before_ the starting bridge. Let's fix that.
>
> Fixes: 05193dc38197 ("drm/bridge: Make the bridge
Hello,
thanks for your review.
I will publish a patch soon.
What tag should I add to my commit to mention that you find bugs
(Suggested-by for example)?
Thanks;
Le mer. 31 mars 2021 à 10:14, Dan Carpenter a écrit :
>
> On Wed, Mar 31, 2021 at 11:12:38AM +0300, Dan Carpenter wrote:
> >644
W dniu 30.03.2021 o 04:53, Douglas Anderson pisze:
> The clock framework makes it simple to deal with an optional clock.
> You can call clk_get_optional() and if the clock isn't specified it'll
> just return NULL without complaint. It's valid to pass NULL to
> enable/disable/prepare/unprepare. Let
W dniu 30.03.2021 o 04:53, Douglas Anderson pisze:
> A random comment inside a function had "/**" in front of it. That
> doesn't make sense. Remove.
>
> Signed-off-by: Douglas Anderson
Reviewed-by: Andrzej Hajda
Regards
Andrzej
> ---
>
> (no changes since v1)
>
> drivers/gpu/drm/bridge/ti-sn6
Maxime Ripard 于2021年3月24日周三 下午6:53写道：
> Hi
>
> On Mon, Feb 22, 2021 at 09:28:18PM +0800, Kevin Tang wrote:
> > Adds drm support for the Unisoc's display subsystem.
> >
> > This is drm kms driver, this driver provides support for the
> > application framework in Android, Yocto and more.
> >
> > Ap
This is v3 of the series.
Changelog:
v2 -> v3:
* Turn Documentation into yaml format
v3 -> v4:
* Fix reference error in yaml file
v4 -> v5:
* More yaml file documentation fixes
v5 -> v6:
* More yaml file documentation fixes
v6 -> v7:
* Fix ordering of p
This patch adds support for Newhaven's NHD-1.8-128160EF display, featuring
an Ilitek ILI9163 controller.
Signed-off-by: Daniel Mack
Acked-by: Daniel Vetter
---
drivers/gpu/drm/tiny/Kconfig | 13 ++
drivers/gpu/drm/tiny/Makefile | 1 +
drivers/gpu/drm/tiny/ili9163.c | 224 +
This adds documentation for a new ILI9163 based, SPI connected display.
Signed-off-by: Daniel Mack
---
.../display/panel/ilitek,ili9163.yaml | 69 +++
1 file changed, 69 insertions(+)
create mode 100644
Documentation/devicetree/bindings/display/panel/ilitek,ili9163.yaml
Hi Maxime,
Maxime Ripard 于2021年3月24日周三 下午7:10写道：
> Hi,
>
> On Mon, Feb 22, 2021 at 09:28:20PM +0800, Kevin Tang wrote:
> > Adds DPU(Display Processor Unit) support for the Unisoc's display
> subsystem.
> > It's support multi planes, scaler, rotation, PQ(Picture Quality) and
> more.
> >
> > Cc: O
On Wed, Mar 31, 2021 at 11:17:20AM +0200, Adrien Grassein wrote:
> Hello,
>
> thanks for your review.
>
> I will publish a patch soon.
>
> What tag should I add to my commit to mention that you find bugs
> (Suggested-by for example)?
If there is a bug fix then please could you use Reported-by?
Le mer. 31 mars 2021 à 11:27, Dan Carpenter a écrit :
>
> On Wed, Mar 31, 2021 at 11:17:20AM +0200, Adrien Grassein wrote:
> > Hello,
> >
> > thanks for your review.
> >
> > I will publish a patch soon.
> >
> > What tag should I add to my commit to mention that you find bugs
> > (Suggested-by for
Hi,
This patch fixes issues found by a static checker.
Thanks,
Adrien Grassein (1):
drm/bridge: lt8912b: Fix issues found during static analysis
drivers/gpu/drm/bridge/lontium-lt8912b.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
--
2.25.1
_
Some issues where found during static analysis of this driver.
Reported-by: Dan Carpenter
Suggested-by: Dan Carpenter
Signed-off-by: Adrien Grassein
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/g
Hi Maxime,
Maxime Ripard 于2021年3月24日周三 下午7:13写道：
> On Mon, Feb 22, 2021 at 09:28:21PM +0800, Kevin Tang wrote:
> > From: Kevin Tang
> >
> > Adds MIPI DSI Controller
> > support for Unisoc's display subsystem.
> >
> > Cc: Orson Zhai
> > Cc: Chunyan Zhang
> > Signed-off-by: Kevin Tang
> > Revi
W dniu 30.03.2021 o 04:53, Douglas Anderson pisze:
> Let's make the remove() function strictly the reverse of the probe()
> function so it's easier to reason about.
>
> NOTES:
> - The MIPI calls probably belong in detach() but will be moved in a
>separate patch.
The mipi is incorrectly handl
W dniu 30.03.2021 o 04:53, Douglas Anderson pisze:
> The register() / attach() for MIPI happen in the bridge's
> attach(). That means that the inverse belongs in the bridge's
> detach().
As I commented in previous patch, it would be better to fix mipi/bridge
registration order in host and this
W dniu 30.03.2021 o 04:53, Douglas Anderson pisze:
> We prepared the panel in pre_enable() so we should unprepare it in
> post_disable() to match.
>
> This becomes important once we start using pre_enable() and
> post_disable() to make sure things are powered on (and then off again)
> when reading
W dniu 30.03.2021 o 04:53, Douglas Anderson pisze:
> If we just leave the detect() function as NULL then the upper layers
> assume we're always connected. There's no reason for a stub.
>
> Signed-off-by: Douglas Anderson
Reviewed-by: Andrzej Hajda
Regards
Andrzej
> ---
>
> (no changes since v1)
W dniu 30.03.2021 o 04:53, Douglas Anderson pisze:
> As of commit 5186421cbfe2 ("drm: Introduce epoch counter to
> drm_connector") the drm_get_edid() function calls
> drm_connector_update_edid_property() for us. There's no reason for us
> to call it again.
>
> Signed-off-by: Douglas Anderson
Revi
W dniu 30.03.2021 o 04:53, Douglas Anderson pisze:
> Now that we have the patch ("drm/edid: Use the cached EDID in
> drm_get_edid() if eDP") we no longer need to maintain our own
> cache. Drop this code.
>
> Signed-off-by: Douglas Anderson
Reviewed-by: Andrzej Hajda
Regards
Andrzej
> ---
>
> (n
https://bugzilla.kernel.org/show_bug.cgi?id=211501
Jan Klos (honza.k...@gmail.com) changed:
What|Removed |Added
CC||honza.k...@gmail.com
--
From: Tvrtko Ursulin
RC6 support cannot be simply established by looking at the static device
HAS_RC6() flag. There are cases which disable RC6 at driver load time so
use the status of those check when deciding whether to enumerate the rc6
counter.
Signed-off-by: Tvrtko Ursulin
Reported-by: Eer
On Fri, 26 Mar 2021, Maxime Ripard wrote:
> Hi,
>
> On Fri, Mar 26, 2021 at 11:47:58AM +0200, Jani Nikula wrote:
>> On Tue, 23 Mar 2021, Ankit Nautiyal wrote:
>> > Currently the FRL training mode (Concurrent, Sequential) and
>> > training type (Normal, Extended) are not defined properly and
>> >
On Thu, 25 Mar 2021, Jani Nikula wrote:
> On Wed, 24 Mar 2021, Anshuman Gupta wrote:
>> HDCP DP 2.2 errata is part of HDCP DP 2.3 specs
>> as well.
>>
>> Anshuman Gupta (2):
>> drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
>> drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16
>>
>> d
On Wed, Mar 31, 2021 at 11:38:22AM +0200, Adrien Grassein wrote:
> Some issues where found during static analysis of this driver.
>
> Reported-by: Dan Carpenter
> Suggested-by: Dan Carpenter
> Signed-off-by: Adrien Grassein
> ---
> drivers/gpu/drm/bridge/lontium-lt8912b.c | 20 ---
Le mer. 31 mars 2021 à 12:29, Dan Carpenter a écrit :
>
> On Wed, Mar 31, 2021 at 11:38:22AM +0200, Adrien Grassein wrote:
> > Some issues where found during static analysis of this driver.
> >
> > Reported-by: Dan Carpenter
> > Suggested-by: Dan Carpenter
> > Signed-off-by: Adrien Grassein
>
Hi,
This patch fixes issues found by a static checker.
Thanks,
Adrien Grassein (1):
drm/bridge: lt8912b: Fix issues found during static analysis
drivers/gpu/drm/bridge/lontium-lt8912b.c | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
--
2.25.1
_
Some issues where found during static analysis of this driver.
Reported-by: Dan Carpenter
Suggested-by: Dan Carpenter
Signed-off-by: Adrien Grassein
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/drive
Restructure MSM DSI PHY drivers. What started as an attempt to grok the
overcomplicated PHY drivers, has lead up to the idea of merging PHY and
PLL code, reducing abstractions, code duplication, dropping dead code,
etc.
The patches were mainly tested on RB5 (sm8250, 7nm) and DB410c (apq8016,
28nm-
Add devm_clk_hw_register_divider() - devres version of
clk_hw_register_divider().
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
Acked-by: Stephen Boyd
---
include/linux/clk-provider.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/include/linux/clk-provider
Use devm_of_clk_add_hw_provider() to register provided clocks. This
allows dropping the remove function alltogether.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
Tested-by: Stephen Boyd # on sc7180 lazor
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 22 +-
1 fil
msm_dsi_pll_set_usecase() function is not used outside of individual DSI
PHY drivers, so drop it in favour of calling the the respective
set_usecase functions directly.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
Tested-by: Stephen Boyd # on sc7180 lazor
---
drivers/gpu/drm/msm/
Add devm_clk_hw_register_mux() - devres-managed version of
clk_hw_register_mux().
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
Acked-by: Stephen Boyd
---
drivers/clk/clk-mux.c| 35 +++
include/linux/clk-provider.h | 13 +
2 file
With the current upstream driver the msm_dsi_phy_type enum does not make
much sense: all DSI PHYs are probed using the dt bindings, the phy type
is not passed between drivers. Use quirks in phy individual PHY drivers
to differentiate minor harware differences and drop the enum.
Signed-off-by: Dmit
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
Tested-by: Stephen Boyd # on sc7180 lazor
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 3 +++
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 6 --
drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 6 --
drivers/gp
The only PLL using multiple enable sequences is the 28nm PLL, which just
does the single step in the loop. Push that support back into the PLL
code.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
Tested-by: Stephen Boyd # on sc7180 lazor
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm
DSI PHY init callback would either map dsi_phy_regulator or dsi_phy_lane
depending on the PHY type. Replace those callbacks with configuration
options governing mapping those regions.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
Tested-by: Stephen Boyd # on sc7180 lazor
---
drive
Move all PLL-related callbacks into struct msm_dsi_phy_cfg. This limits
the amount of data in the struct msm_dsi_pll.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
Tested-by: Stephen Boyd # on sc7180 lazor
---
drivers/gpu/drm/msm/dsi/dsi.h | 6 --
drivers/gpu/drm/
Use devres-enabled version of clock registration functions. This lets us
remove dsi_pll destroy callbacks completely.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
Tested-by: Stephen Boyd # on sc7180 lazor
---
drivers/gpu/drm/msm/dsi/dsi.h | 4 -
drivers/gpu/drm/m
These drivers do not use vco_delay variable, so drop it from all of
them.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
Tested-by: Stephen Boyd # on sc7180 lazor
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 3 ---
drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 4
drivers/gp
Morph msm_dsi_pll_save/restore_state() into msm_dsi_phy_save/restore_state(),
thus removing last bits of knowledge about msm_dsi_pll from dsi_manager.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
Tested-by: Stephen Boyd # on sc7180 lazor
---
drivers/gpu/drm/msm/dsi/dsi.h
Instead of setting the variable and then using it just in the one place,
determine vco_delay directly at the PLL configuration time.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
Tested-by: Stephen Boyd # on sc7180 lazor
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c | 12
Drop duplicate fields pdev and id from dsi_pll_Nnm instances. Reuse
those fields from the provided msm_dsi_phy.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
Tested-by: Stephen Boyd # on sc7180 lazor
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c| 72 +--
drive
The src_truthtable config is not used for some of phys, which use other
means of configuring the master/slave usecases. Inline this function
with the goal of removing src_pll_id argument in the next commit.
Signed-off-by: Dmitry Baryshkov
Tested-by: Stephen Boyd # on sc7180 lazor
---
drivers/gp
Replace PLL accessor functions (pll_read/pll_write*) with the DSI PHY
accessors, reducing duplication.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
Tested-by: Stephen Boyd # on sc7180 lazor
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 24 +--
drivers/gpu/drm/msm/dsi/phy/d
All MSM DSI PHYs provide two clocks: byte and pixel ones.
Register/unregister provided clocks from the generic place, removing
boilerplate code from all MSM DSI PHY drivers.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
Tested-by: Stephen Boyd # on sc7180 lazor
---
drivers/gpu/drm
All PHY drivers would map dsi_pll area. Some PHY drivers would also
map dsi_phy area again (a leftover from old PHY/PLL separation). Move
all ioremaps to the common dsi_phy driver code and drop individual
ioremapped areas from PHY drivers.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kuma
Drop the struct msm_dsi_pll abstraction, by including vco's clk_hw
directly into struct msm_dsi_phy.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
Tested-by: Stephen Boyd # on sc7180 lazor
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/Kconfig | 8 --
Make save_state/restore callbacks accept struct msm_dsi_phy rather than
struct msm_dsi_pll. This moves them to struct msm_dsi_phy_ops, allowing
us to drop struct msm_dsi_pll_ops.
Signed-off-by: Dmitry Baryshkov
Tested-by: Stephen Boyd # on sc7180 lazor
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy.c
Phy driver already knows the source PLL id basing on the set usecase and
the current PLL id. Stop passing it to the phy_enable call. As a
reminder, dsi manager will always use DSI 0 as a clock master in a slave
mode, so PLL 0 is always a clocksource for DSI 0 and it is always a
clocksource for DSI
10nm and 7nm already do not use these helpers, as they handle setting
slave DSI clocks after enabling VCO. Modify the rest of PHY drivers to
remove unnecessary indirection and drop enable_seq/disable_seq PLL
callbacks.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
Tested-by: Stephen
The 7nm, 10nm and 14nm drivers would store interim data used during
VCO/PLL rate setting in the global dsi_pll_Nnm structure. Move this data
structures to the onstack storage. While we are at it, drop
unused/static 'config' data, unused config fields, etc.
Signed-off-by: Dmitry Baryshkov
Reviewed
On Wed, Mar 31, 2021 at 12:43:12PM +0200, Adrien Grassein wrote:
> @@ -635,13 +636,16 @@ static int lt8912_parse_dt(struct lt8912 *lt)
> lt->gp_reset = gp_reset;
>
> endpoint = of_graph_get_endpoint_by_regs(dev->of_node, 0, -1);
> - if (IS_ERR(endpoint)) {
> - ret = PT
W dniu 30.03.2021 o 04:53, Douglas Anderson pisze:
> eDP panels won't provide their EDID unless they're powered on. Let's
> chain a power-on before we read the EDID. This roughly matches what
> was done in 'parade-ps8640.c'.
>
> NOTE: The old code attempted to call pm_runtime_get_sync() before
> r
Hi,
This patch fixes issues found by a static checker.
Thanks,
Adrien Grassein (1):
drm/bridge: lt8912b: Fix issues found during static analysis
drivers/gpu/drm/bridge/lontium-lt8912b.c | 27 +++-
1 file changed, 17 insertions(+), 10 deletions(-)
--
2.25.1
Some issues where found during static analysis of this driver.
Reported-by: Dan Carpenter
Suggested-by: Dan Carpenter
Signed-off-by: Adrien Grassein
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 27 +++-
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/driv
WARN_ON was introduced by the below commit to catch runtime resumes
that are getting triggered before icc path was set.
"drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume"
For the targets where the bw scaling is not enabled, this WARN_ON is
a false alarm. Fix the WARN conditio
On Wed, Mar 31, 2021 at 01:21:37PM +0200, Adrien Grassein wrote:
> - lt->data_lanes = of_property_count_u32_elems(endpoint, "data-lanes");
> + data_lanes = of_property_count_u32_elems(endpoint, "data-lanes");
> of_node_put(endpoint);
> + if (data_lanes < 0) {
> + dev_e
On Thu, 25 Mar 2021, "Nautiyal, Ankit K" wrote:
> LGTM.
>
> Reviewed-by: Ankit Nautiyal
Both patches pushed to drm-intel-next with Maxime's irc ack.
BR,
Jani.
>
> On 3/24/2021 5:00 PM, Anshuman Gupta wrote:
>> As documented in HDCP 2.2 DP Errata spec transmitter should abort the
>> authentica
Hi, Enric:
Enric Balletbo i Serra 於 2021年3月30日 週二 下午5:43寫道：
>
> Hi,
>
> On 3/2/21 12:07, Enric Balletbo i Serra wrote:
> > From: Boris Brezillon
> >
> > This patch adds the missing MODULE_DEVICE_TABLE definitions on different
> > Mediatek drivers which generates correct modalias for automatic lo
Le mer. 31 mars 2021 à 13:36, Dan Carpenter a écrit :
>
> On Wed, Mar 31, 2021 at 01:21:37PM +0200, Adrien Grassein wrote:
> > - lt->data_lanes = of_property_count_u32_elems(endpoint, "data-lanes");
> > + data_lanes = of_property_count_u32_elems(endpoint, "data-lanes");
> > of_node_p
Hi,
This patch fixes issues found by a static checker.
Thanks,
Adrien Grassein (1):
drm/bridge: lt8912b: Fix issues found during static analysis
drivers/gpu/drm/bridge/lontium-lt8912b.c | 27 +++-
1 file changed, 17 insertions(+), 10 deletions(-)
--
2.25.1
Some issues where found during static analysis of this driver.
Reported-by: Dan Carpenter
Suggested-by: Dan Carpenter
Signed-off-by: Adrien Grassein
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 27 +++-
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/driv
On Tue, Mar 30, 2021 at 05:28:19PM +0100, Robin Murphy wrote:
> On 2021-03-30 14:58, Will Deacon wrote:
> > On Tue, Mar 30, 2021 at 02:19:38PM +0100, Robin Murphy wrote:
> > > On 2021-03-30 14:11, Will Deacon wrote:
> > > > On Tue, Mar 16, 2021 at 04:38:22PM +0100, Christoph Hellwig wrote:
> > > >
On Wed, Mar 31, 2021 at 03:15:47PM +1100, Alistair Popple wrote:
> On Wednesday, 31 March 2021 2:56:38 PM AEDT John Hubbard wrote:
> > On 3/30/21 3:56 PM, Alistair Popple wrote:
> > ...
> > >> +1 for renaming "munlock*" items to "mlock*", where applicable. good
> grief.
> > >
> > > At least the s
Thanks!
regards,
dan carpenter
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
The display core files rely on FPU operation, which requires to be
compiled with special flags. Ideally, we don't want these FPU operations
to get spread around the DC code; nevertheless, it happens in the
current source. This commit introduces a new directory named
fpu_operations that intends to c
DC invokes DC_FPU_START/END in multiple parts of the code; this can
create a situation where we invoke this FPU operation in a nested way.
For avoiding this situation, this commit adds a mechanism where
dc_fpu_begin/end manages the access to kernel_fpu_begin/end.
Signed-off-by: Rodrigo Siqueira
A
We don't have any mechanism for tracing FPU operations inside the
display core, making the debug work a little bit tricky. For trying to
alleviate this problem, this commit introduces a trace mechanism inside
our DC_FP_START/END macros.
Signed-off-by: Rodrigo Siqueira
Acked-by: Rodrigo Siqueira
Hi,
In the display core, we utilize floats and doubles units for calculating
modesetting parameters. One side effect of our approach to use double-precision
is the fact that we spread multiple FPU access across our driver, which means
that we can accidentally clobber user space FPU state.
# Chall
To fully isolate FPU operations in a single place, we must avoid
situations where compilers spill FP values to registers due to FP enable
in a specific C file. Note that even if we isolate all FPU functions in
a single file and call its interface from other files, the compiler
might enable the use
On 2021-03-31 00:04, Steev Klimaszewski wrote:
On 3/22/21 4:17 AM, Kalyan Thota wrote:
From: Kalyan Thota
DPU runtime resume will request for a min vote on the AXI bus as
it is a necessary step before turning ON the AXI clock.
The change does below
1) Move the icc path set before requesting r
On Wed, 31 Mar 2021 at 08:41, Liu Ying wrote:
>
> Hi Robert,
>
> On Tue, 2021-03-30 at 12:05 +0200, Robert Foss wrote:
> > Hey Liu,
> >
> > checkpatch --strict lists some nits for this patch with those and the
> > below warning fixed, feel free to add my r-b.
>
> Thanks for your review.
>
> Will f
Am 31.03.21 um 14:25 schrieb Rodrigo Siqueira:
DC invokes DC_FPU_START/END in multiple parts of the code; this can
create a situation where we invoke this FPU operation in a nested way.
For avoiding this situation, this commit adds a mechanism where
dc_fpu_begin/end manages the access to kernel_f
Am 31.03.21 um 14:25 schrieb Rodrigo Siqueira:
To fully isolate FPU operations in a single place, we must avoid
situations where compilers spill FP values to registers due to FP enable
in a specific C file. Note that even if we isolate all FPU functions in
a single file and call its interface fro
Hi Rodrigo,
I'm not so happy about the whole recursion thing, but I think that is
something which can be worked on later on.
Apart from that the approach sounds solid to me.
Regards,
Christian.
Am 31.03.21 um 14:24 schrieb Rodrigo Siqueira:
Hi,
In the display core, we utilize floats and do
W dniu 31.03.2021 o 13:49, Adrien Grassein pisze:
> Some issues where found during static analysis of this driver.
Subject should describe what has been fixed, description why. If there
is multiple different issues maybe patch split would be better.
>
> Reported-by: Dan Carpenter
> Suggested
On Wednesday, 31 March 2021 6:32:34 AM AEDT Jason Gunthorpe wrote:
> On Fri, Mar 26, 2021 at 11:08:02AM +1100, Alistair Popple wrote:
> > diff --git a/mm/memory.c b/mm/memory.c
> > index 3a5705cfc891..33d11527ef77 100644
> > +++ b/mm/memory.c
> > @@ -781,6 +781,27 @@ copy_nonpresent_pte(struct mm_s
On 2021-03-31 12:49, Will Deacon wrote:
On Tue, Mar 30, 2021 at 05:28:19PM +0100, Robin Murphy wrote:
On 2021-03-30 14:58, Will Deacon wrote:
On Tue, Mar 30, 2021 at 02:19:38PM +0100, Robin Murphy wrote:
On 2021-03-30 14:11, Will Deacon wrote:
On Tue, Mar 16, 2021 at 04:38:22PM +0100, Christo
Am 31.03.21 um 15:12 schrieb Bernard Zhao:
Fix sparse warning:
drivers/gpu/drm/ttm/ttm_bo.c:52:1: warning: symbol 'ttm_global_mutex' was not
declared. Should it be static?
drivers/gpu/drm/ttm/ttm_bo.c:53:10: warning: symbol 'ttm_bo_glob_use_count' was
not declared. Should it be static?
Signed-
On Wed, Mar 31, 2021 at 11:59:28PM +1100, Alistair Popple wrote:
> I guess that makes sense as the split could go either way at the
> moment but I should add a check to make sure this isn't used with
> pinned pages anyway.
Is it possible to have a pinned page under one of these things? If I
pin i
Hi,
This patch fixes issues found by a static checker:
- Bad handling of handling of of_* return values.
Thanks,
Adrien Grassein (1):
drm/bridge: lt8912b: fix incorrect handling of of_* return values
drivers/gpu/drm/bridge/lontium-lt8912b.c | 32 +---
1 file changed, 17
A static analysis shows several issues in the driver code at
probing time.
DT parsing errors were bad handled and could lead to bugs:
- Bad error detection;
- Bad release of ressources
Reported-by: Dan Carpenter
Suggested-by: Dan Carpenter
Signed-off-by: Adrien Grassein
Reviewed-by: Andrz
On Tue, 30 Mar 2021 08:15:05 +, Carlis wrote:
> From: "Xuezhi Zhang"
>
> Document support for the Waveshare 2inch LCD module display, which is a
> 240x320 2" TFT display driven by a Sitronix ST7789V TFT Controller.
>
> Signed-off-by: Xuezhi Zhang
> ---
> v2:change compatible name.
> v3:chan
From: Colin Ian King
The variable status is being initialized with a value that is
never read and it is being updated later with a new value.
The initialization is redundant and can be removed. Also clean
up an indentation.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King
---
Hello,
On 10/02/2021 03:52, Jordan Crouse wrote:
Most a6xx targets have security issues that were fixed with new versions
of the microcode(s). Make sure that we are booting with a safe version of
the microcode for the target and print a message and error if not.
v2: Add more informative error m
On Wed, 31 Mar 2021 14:33:18 +0800, Liu Ying wrote:
> This patch adds bindings for i.MX8qm/qxp Control and Status Registers module.
>
> Reviewed-by: Rob Herring
> Signed-off-by: Liu Ying
> ---
> v6->v7:
> * Add Rob's R-b tag.
>
> v5->v6:
> * Drop 'select' schema. (Rob)
>
> v4->v5:
> * Newly in
On Thursday, 1 April 2021 12:18:54 AM AEDT Jason Gunthorpe wrote:
> On Wed, Mar 31, 2021 at 11:59:28PM +1100, Alistair Popple wrote:
>
> > I guess that makes sense as the split could go either way at the
> > moment but I should add a check to make sure this isn't used with
> > pinned pages anyway.
On Thu, Apr 01, 2021 at 12:27:52AM +1100, Alistair Popple wrote:
> On Thursday, 1 April 2021 12:18:54 AM AEDT Jason Gunthorpe wrote:
> > On Wed, Mar 31, 2021 at 11:59:28PM +1100, Alistair Popple wrote:
> >
> > > I guess that makes sense as the split could go either way at the
> > > moment but I sh
I suppose the microcode version check for a650 is incorrect. It checks
for the version 1.95, while the firmware released have major version of 0:
0.91 (vulnerable), 0.99 (fixing the issue).
Lower version requirements to accept firmware 0.99.
Fixes: 8490f02a3ca4 ("drm/msm: a6xx: Make sure the SQE
Hi,
On Wed, Mar 31, 2021 at 3:12 AM Andrzej Hajda wrote:
>
>
> W dniu 30.03.2021 o 04:53, Douglas Anderson pisze:
> > Now that we have the patch ("drm/edid: Use the cached EDID in
> > drm_get_edid() if eDP") we no longer need to maintain our own
> > cache. Drop this code.
> >
> > Signed-off-by: D
On Wed, Mar 31, 2021 at 02:57:31PM +0200, Andrzej Hajda wrote:
> >
> > if (!of_device_is_compatible(port_node, "hdmi-connector")) {
> > dev_err(lt->dev, "%s: Failed to get hdmi port\n", __func__);
> > + of_node_put(port_node);
> > ret = -EINVAL;
> > +
1 - 100 of 211 matches
Mail list logo
