Re: [PATCH v2 00/10] drm: Support simple-framebuffer devices and firmware fbs

2021-03-30 Thread Thomas Zimmermann
Hi Am 29.03.21 um 16:50 schrieb Hans de Goede: Hi, On 3/29/21 2:31 PM, Thomas Zimmermann wrote: Hi Am 25.03.21 um 12:29 schrieb Hans de Goede: Hi, On 3/18/21 11:29 AM, Thomas Zimmermann wrote: This patchset adds support for simple-framebuffer platform devices and a handover mechanism for n

[PATCH] drm/hisilicon/kirin: Use the correct HiSilicon copyright

2021-03-30 Thread Hao Fang
s/Hisilicon/HiSilicon/g. It should use capital S, according to https://www.hisilicon.com/en/terms-of-use. Signed-off-by: Hao Fang --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c| 2 +- drivers/gpu/drm/hisilicon/kirin/dw_dsi_reg.h| 2 +- drivers/gpu/drm/hisilicon/kirin/kirin_ade_reg.h |

Re: [PATCH v2] staging: fbtft: fix a typo

2021-03-30 Thread carlis
On Fri, 26 Mar 2021 14:03:34 +0100 Greg KH wrote: > On Fri, Mar 26, 2021 at 08:55:51PM +0800, Carlis wrote: > > From: Xuezhi Zhang > > > > Change 'tft' to 'TFT' > > That says what you did, but not _why_ you did it. > > And this is not a "typo", as it is not misspelled and really is just > f

Re: [PATCH] staging: fbtft: change '16 bit' to '16-bit'

2021-03-30 Thread carlis
On Fri, 26 Mar 2021 15:12:07 +0100 Greg KH wrote: > On Fri, Mar 26, 2021 at 10:09:30PM +0800, Carlis wrote: > > From: "carlis.zhang_cp" > > > > Change '16 bit' to '16-bit' for a same style. > > Why? This is up to the author. > > > > > Signed-off-by: carlis.zhang_cp > > Please use a re

Re: [PATCH 1/2] drm/ingenic: Switch IPU plane to type OVERLAY

2021-03-30 Thread Simon Ser
> It should have been an OVERLAY from the beginning. The documentation > stipulates that there should be an unique PRIMARY plane per CRTC. Thanks for the quick patch! One comment below… > Fixes: fc1acf317b01 ("drm/ingenic: Add support for the IPU") > Cc: # 5.8+ > Signed-off-by: Paul Cercueil >

Re: linux-next: manual merge of the drm tree with Linus' tree

2021-03-30 Thread Geert Uytterhoeven
Hi Stephen, On Mon, Mar 29, 2021 at 4:16 AM Stephen Rothwell wrote: > Today's linux-next merge of the drm tree got a conflict in: > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > > between commits: > > 9adb125dde69 ("drm/amdgpu: re-enable suspend phase 2 for S0ix") > 4021229e32bd ("drm/amdg

Re: [PATCH v4 3/4] drm/msm: add compatibles for sm8150/sm8250 display

2021-03-30 Thread Dmitry Baryshkov
On Tue, 30 Mar 2021 at 06:16, Bjorn Andersson wrote: > > On Mon 29 Mar 07:00 CDT 2021, Dmitry Baryshkov wrote: > > > From: Jonathan Marek > > > > The driver already has support for sm8150/sm8250, but the compatibles were > > never added. > > > > Also inverse the non-mdp4 condition in add_display_

[PATCH 1/2] drm/panel: simple: Add support for EDT ETMV570G2DHU panel

2021-03-30 Thread Yunus Bas
From: Stefan Riedmueller This patch adds support for the EDT ETMV570G2DHU 5.7" (640x480) lcd panel to DRM simple panel driver. Signed-off-by: Stefan Riedmueller Signed-off-by: Yunus Bas --- .../bindings/display/panel/panel-simple.yaml | 3 ++ drivers/gpu/drm/panel/panel-simple.c |

[PATCH 2/2] drm/panel: simple: Add support for EDT ETM0350G0DH6 panel

2021-03-30 Thread Yunus Bas
From: Stefan Riedmueller This patch adds support for the EDT ETM0350G0DH6 3.5" (320x240) lcd panel to DRM simple panel driver. Signed-off-by: Stefan Riedmueller Signed-off-by: Yunus Bas --- .../bindings/display/panel/panel-simple.yaml | 3 ++ drivers/gpu/drm/panel/panel-simple.c |

[PATCH v3 0/1] drm/tiny: add support for Waveshare 2inch LCD module

2021-03-30 Thread Carlis
From: Xuezhi Zhang This adds a new module for the ST7789V controller with parameters for the Waveshare 2inch LCD module. Signed-off-by: Xuezhi Zhang --- v2:change compatible value. v3:change author name. --- MAINTAINERS| 8 + drivers/gpu/drm/tiny/Kconfig | 14 ++ drive

[PATCH v3 1/1] dt-bindings: display: sitronix, st7789v-dbi: Add Waveshare 2inch LCD module

2021-03-30 Thread Carlis
From: "Xuezhi Zhang" Document support for the Waveshare 2inch LCD module display, which is a 240x320 2" TFT display driven by a Sitronix ST7789V TFT Controller. Signed-off-by: Xuezhi Zhang --- v2:change compatible name. v3:change auther name. --- .../display/sitronix,st7789v-dbi.yaml |

[GIT PULL] exynos-drm-next

2021-03-30 Thread Inki Dae
Hi Dave, Just one patch to clean up the use of request_irq funtion. This patch has a dependency of one patch[1] so merged it on top of tag 'irq-no-autoen-2021-03-25' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip after top of drm next branch. Please kindly let me know if

Re: [PATCH v2 00/10] drm: Support simple-framebuffer devices and firmware fbs

2021-03-30 Thread Hans de Goede
Hi, On 3/30/21 9:09 AM, Thomas Zimmermann wrote: > Hi > > Am 29.03.21 um 16:50 schrieb Hans de Goede: >> Hi, >> >> On 3/29/21 2:31 PM, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 25.03.21 um 12:29 schrieb Hans de Goede: Hi, On 3/18/21 11:29 AM, Thomas Zimmermann wrote: > This pa

Re: [PATCH] dt-bindings: bcm2711-hdmi: Fix broken schema

2021-03-30 Thread Maxime Ripard
Hi Stephen, On Sat, Mar 27, 2021 at 10:00:26AM +1100, Stephen Rothwell wrote: > Hi Rob, > > On Fri, 26 Mar 2021 15:01:34 -0600 Rob Herring wrote: > > > > On Tue, Feb 23, 2021 at 2:26 PM Rob Herring wrote: > > > > > > On Thu, 18 Feb 2021 16:28:37 +0100, Maxime Ripard wrote: > > > > For some re

Re: [PATCH 06/11] cgroup: fix -Wzero-length-bounds warnings

2021-03-30 Thread Arnd Bergmann
On Tue, Mar 30, 2021 at 10:41 AM Michal Koutný wrote: > > On Mon, Mar 22, 2021 at 05:02:44PM +0100, Arnd Bergmann > wrote: > > I'm not sure what is expected to happen for such a configuration, > > presumably these functions are never calls in that case. > Yes, the functions you patched would onl

[Bug 211875] CPU frequency scaling lost after "WARNING: CPU: 2 PID: 2358578 at smu8_send_msg_to_smc_with_parameter+0xfe/0x140 [amdgpu]"

2021-03-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211875 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added Attachment #295381|0 |1 is obsolete|

[Bug 211875] CPU frequency scaling lost after "WARNING: CPU: 2 PID: 2358578 at smu8_send_msg_to_smc_with_parameter+0xfe/0x140 [amdgpu]"

2021-03-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211875 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added Attachment #295573|0 |1 is obsolete|

[PATCH] drm: xlnx: zynqmp: fix a memset in zynqmp_dp_train()

2021-03-30 Thread Dan Carpenter
The dp->train_set[] for this driver is only two characters, not four so this memsets too much. Fortunately, this ends up corrupting a struct hole and not anything important. Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem") Signed-off-by: Dan Carpenter --

Re: [PATCH 1/2] iommu/arm-smmu-qcom: Skip the TTBR1 quirk for db820c.

2021-03-30 Thread Will Deacon
On Mon, Mar 29, 2021 at 09:02:50PM -0700, Rob Clark wrote: > On Mon, Mar 29, 2021 at 7:47 AM Will Deacon wrote: > > > > On Fri, Mar 26, 2021 at 04:13:02PM -0700, Eric Anholt wrote: > > > db820c wants to use the qcom smmu path to get HUPCF set (which keeps > > > the GPU from wedging and then someti

Re: [PATCH v6 09/14] drm/bridge: imx: Add i.MX8qxp pixel link to DPI support

2021-03-30 Thread Robert Foss
Hey Liu, checkpatch --strict had some complaints, with those fixed feel free to add my r-b. Reviewed-by: Robert Foss On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote: > > This patch adds a drm bridge driver for i.MX8qxp pixel link to display > pixel interface(PXL2DPI). The PXL2DPI interfaces the

Re: [PATCH] drm/mediatek: Add missing MODULE_DEVICE_TABLE()

2021-03-30 Thread Enric Balletbo i Serra
Hi, On 3/2/21 12:07, Enric Balletbo i Serra wrote: > From: Boris Brezillon > > This patch adds the missing MODULE_DEVICE_TABLE definitions on different > Mediatek drivers which generates correct modalias for automatic loading > when these drivers are compiled as an external module. > > Signed-o

Re: [PATCH v2 2/3] drm/mediatek: Don't support hdmi connector creation

2021-03-30 Thread Dafna Hirschfeld
Hi, On 30.03.21 02:08, Laurent Pinchart wrote: Hi Dafna, Thank you for the patch. On Mon, Mar 29, 2021 at 05:36:31PM +0200, Dafna Hirschfeld wrote: commit f01195148967 ("drm/mediatek: mtk_dpi: Create connector for bridges") broke the display support for elm device since mtk_dpi calls drm_brid

Re: [PATCH v6 10/14] drm/bridge: imx: Add LDB driver helper support

2021-03-30 Thread Robert Foss
Hey Liu, checkpatch --strict is listing some nits for this patch, with those fixed feel free to add my r-b. Reviewed-by: Robert Foss On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote: > > This patch adds a helper to support LDB drm bridge drivers for > i.MX SoCs. Helper functions supported by this

Re: [PATCH v6 14/14] MAINTAINERS: add maintainer for DRM bridge drivers for i.MX SoCs

2021-03-30 Thread Robert Foss
Hey Liu, Reviewed-by: Robert Foss On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote: > > Add myself as the maintainer of DRM bridge drivers for i.MX SoCs. > > Signed-off-by: Liu Ying > --- > v5->v6: > * No change. > > v4->v5: > * No change. > > v3->v4: > * No change. > > v2->v3: > * No change. > >

Re: [PATCH v6 12/14] drm/bridge: imx: Add LDB support for i.MX8qxp

2021-03-30 Thread Robert Foss
Hey Liu, checkpatch --strict lists some nit and a warning. With those fixed feel free to add my r-b. On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote: > > This patch adds a drm bridge driver for i.MX8qxp LVDS display bridge(LDB) > which is officially named as pixel mapper. The LDB has two channels.

Re: [PATCH v6 12/14] drm/bridge: imx: Add LDB support for i.MX8qxp

2021-03-30 Thread Robert Foss
Hey Liu, checkpatch --strict lists some nits and a warning. I think the kconfig warning can be ignored. With the rest fixed, feel free to add my r-b. Reviewed-by: Robert Foss On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote: > > This patch adds a drm bridge driver for i.MX8qxp LVDS display bridge(

Re: [PATCH v6 13/14] drm/bridge: imx: Add LDB support for i.MX8qm

2021-03-30 Thread Robert Foss
Hey Liu, checkpatch --strict lists some nits for this patch with those and the below warning fixed, feel free to add my r-b. On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote: > > This patch adds a drm bridge driver for i.MX8qm LVDS display bridge(LDB) > which is officially named as pixel mapper. Th

Re: [PATCH v2 07/20] drm/print: Fixup DRM_DEBUG_KMS_RATELIMITED()

2021-03-30 Thread Robert Foss
Hey Lyude, I'm seeing no issues with this patch and the reasoning behind the patch is sound to me. Reviewed-by: Robert Foss On Fri, 26 Mar 2021 at 21:39, Lyude Paul wrote: > > Since we're about to move drm_dp_helper.c over to drm_dbg_*(), we'll want > to make sure that we can also add ratelimi

Re: [PATCH] drm/mediatek: Add missing MODULE_DEVICE_TABLE()

2021-03-30 Thread Hsin-Yi Wang
On Tue, Mar 30, 2021 at 5:43 PM Enric Balletbo i Serra wrote: > > Hi, > > On 3/2/21 12:07, Enric Balletbo i Serra wrote: > > From: Boris Brezillon > > > > This patch adds the missing MODULE_DEVICE_TABLE definitions on different > > Mediatek drivers which generates correct modalias for automatic l

Re: [PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning

2021-03-30 Thread Hans de Goede
Hi, On 3/22/21 5:02 PM, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 warns that intel_dp_check_mst_status() has a local array of > fourteen bytes and passes the last four bytes into a function that > expects a six-byte array: > > drivers/gpu/drm/i915/display/intel_dp.c: In function >

Re: [PATCH v2 17/20] drm/dp: Convert drm_dp_helper.c to using drm_err/drm_dbg_*()

2021-03-30 Thread Robert Foss
Hey Lyude, Looks good to me. Reviewed-by: Robert Foss On Fri, 26 Mar 2021 at 21:40, Lyude Paul wrote: > > Now that we've added a back-pointer to drm_device to drm_dp_aux, made > drm_dp_aux available to any functions in drm_dp_helper.c which need to > print to the kernel log, and ensured all o

Re: [PATCH v2 19/20] drm/dp_mst: Drop DRM_ERROR() on kzalloc() fail in drm_dp_mst_handle_up_req()

2021-03-30 Thread Robert Foss
Hey Lyude, This patch looks good to me. Reviewed-by: Robert Foss On Fri, 26 Mar 2021 at 21:40, Lyude Paul wrote: > > Checkpatch was complaining about this - there's no need for us to print > errors when kzalloc() fails, as kzalloc() will already WARN for us. So, > let's fix that before convert

[PATCH v3 1/2] drm/mediatek: Switch the hdmi bridge ops to the atomic versions

2021-03-30 Thread Dafna Hirschfeld
The bridge operation '.enable' and the audio cb '.get_eld' access hdmi->conn. In the future we will want to support the flag DRM_BRIDGE_ATTACH_NO_CONNECTOR and then we will not have direct access to the connector. The atomic version '.atomic_enable' allows accessing the current connector from the s

[PATCH v3 0/2] drm/mediatek: Don't support hdmi connector creation

2021-03-30 Thread Dafna Hirschfeld
commit f01195148967 ("drm/mediatek: mtk_dpi: Create connector for bridges") broke the display support for elm device since mtk_dpi calls drm_bridge_attach with the flag DRM_BRIDGE_ATTACH_NO_CONNECTOR while mtk_hdmi does not yet support this flag. These three patches fix that by adding support for

[PATCH v3 2/2] drm/mediatek: Don't support hdmi connector creation

2021-03-30 Thread Dafna Hirschfeld
commit f01195148967 ("drm/mediatek: mtk_dpi: Create connector for bridges") broke the display support for elm device since mtk_dpi calls drm_bridge_attach with the flag DRM_BRIDGE_ATTACH_NO_CONNECTOR while mtk_hdmi does not yet support this flag. Fix this by accepting DRM_BRIDGE_ATTACH_NO_CONNECTO

Re: [PATCH v2 20/20] drm/dp_mst: Convert drm_dp_mst_topology.c to drm_err()/drm_dbg*()

2021-03-30 Thread Robert Foss
Hey Lyude, This patch looks good, but I have one question below. With it addressed, feel free to add my r-b. Reviewed-by: Robert Foss > > -static bool drm_dp_sideband_parse_req(struct drm_dp_sideband_msg_rx *raw, > +static bool drm_dp_sideband_parse_req(const struct drm_dp_mst_topology_mgr > *

Re: [PATCH 24/30] Kconfig: Change Synopsys to Synopsis

2021-03-30 Thread Robin Murphy
On 2021-03-29 00:53, Bhaskar Chowdhury wrote: s/Synopsys/Synopsis/ .two different places. Erm, that is definitely not a typo... :/ ..and for some unknown reason it introduce a empty line deleted and added back. Presumably your editor is configured to trim trailing whitespace on save.

[PATCH] drm: bridge: rename the function drm_bridge_hpd_notify to drm_bridge_hpd_cb

2021-03-30 Thread Dafna Hirschfeld
drm_bridge_funcs has a function called 'hpd_notify'. The function drm_bridge_hpd_notify does not call 'hpd_notify' but it calls 'hpd_cb'. This is rather confusing. Rename the function to fix this confusion. Signed-off-by: Dafna Hirschfeld --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c|

Re: [PATCH 1/2] drm/ingenic: Switch IPU plane to type OVERLAY

2021-03-30 Thread Paul Cercueil
Hi Simon, Le mar. 30 mars 2021 à 7:23, Simon Ser a écrit : It should have been an OVERLAY from the beginning. The documentation stipulates that there should be an unique PRIMARY plane per CRTC. Thanks for the quick patch! One comment below… Fixes: fc1acf317b01 ("drm/ingenic: Add support

Re: [PATCH 01/18] iommu: remove the unused domain_window_disable method

2021-03-30 Thread Will Deacon
On Tue, Mar 16, 2021 at 04:38:07PM +0100, Christoph Hellwig wrote: > domain_window_disable is wired up by fsl_pamu, but never actually called. > > Signed-off-by: Christoph Hellwig > Acked-by: Li Yang > --- > drivers/iommu/fsl_pamu_domain.c | 48 - > include/linux

Re: [PATCH 02/18] iommu/fsl_pamu: remove fsl_pamu_get_domain_attr

2021-03-30 Thread Will Deacon
On Tue, Mar 16, 2021 at 04:38:08PM +0100, Christoph Hellwig wrote: > None of the values returned by this function are ever queried. Also > remove the DOMAIN_ATTR_FSL_PAMUV1 enum value that is not otherwise used. > > Signed-off-by: Christoph Hellwig > Acked-by: Li Yang > --- > drivers/iommu/fsl

Re: [PATCH 03/18] iommu/fsl_pamu: remove support for setting DOMAIN_ATTR_GEOMETRY

2021-03-30 Thread Will Deacon
On Tue, Mar 16, 2021 at 04:38:09PM +0100, Christoph Hellwig wrote: > The default geometry is the same as the one set by qman_port given > that FSL_PAMU depends on having 64-bit physical and thus DMA addresses. > > Remove the support to update the geometry and remove the now pointless > geom_size f

Re: [PATCH 04/18] iommu/fsl_pamu: merge iommu_alloc_dma_domain into fsl_pamu_domain_alloc

2021-03-30 Thread Will Deacon
On Tue, Mar 16, 2021 at 04:38:10PM +0100, Christoph Hellwig wrote: > Keep the functionality to allocate the domain together. > > Signed-off-by: Christoph Hellwig > Acked-by: Li Yang > --- > drivers/iommu/fsl_pamu_domain.c | 34 ++--- > 1 file changed, 10 insertions(+

Re: [PATCH 05/18] iommu/fsl_pamu: remove support for multiple windows

2021-03-30 Thread Will Deacon
On Tue, Mar 16, 2021 at 04:38:11PM +0100, Christoph Hellwig wrote: > The only domains allocated forces use of a single window. Remove all > the code related to multiple window support, as well as the need for > qman_portal to force a single window. > > Remove the now unused DOMAIN_ATTR_WINDOWS io

Re: [PATCH] drm: bridge: rename the function drm_bridge_hpd_notify to drm_bridge_hpd_cb

2021-03-30 Thread Robert Foss
Hey Dafna, Thanks for submitting a cleanup patch, it is much appreciated. It looks good to me, feel free to add my r-b. I'm not going to merge this right away, but will let this patch soak for a while to let other people have a look at it. On Tue, 30 Mar 2021 at 13:52, Dafna Hirschfeld wrote: >

Re: [PATCH 06/18] iommu/fsl_pamu: remove ->domain_window_enable

2021-03-30 Thread Will Deacon
On Tue, Mar 16, 2021 at 04:38:12PM +0100, Christoph Hellwig wrote: > The only thing that fsl_pamu_window_enable does for the current caller > is to fill in the prot value in the only dma_window structure, and to > propagate a few values from the iommu_domain_geometry struture into the > dma_window.

Re: [PATCH 07/18] iommu/fsl_pamu: replace DOMAIN_ATTR_FSL_PAMU_STASH with a direct call

2021-03-30 Thread Will Deacon
On Tue, Mar 16, 2021 at 04:38:13PM +0100, Christoph Hellwig wrote: > Add a fsl_pamu_configure_l1_stash API that qman_portal can call directly > instead of indirecting through the iommu attr API. > > Signed-off-by: Christoph Hellwig > Acked-by: Li Yang > --- > arch/powerpc/include/asm/fsl_pamu_s

Re: [PATCH 08/18] iommu/fsl_pamu: merge pamu_set_liodn and map_liodn

2021-03-30 Thread Will Deacon
On Tue, Mar 16, 2021 at 04:38:14PM +0100, Christoph Hellwig wrote: > Merge the two fuctions that configure the ppaace into a single coherent > function. I somehow doubt we need the two pamu_config_ppaace calls, > but keep the existing behavior just to be on the safe side. > > Signed-off-by: Chris

Re: [PATCH 09/18] iommu/fsl_pamu: merge handle_attach_device into fsl_pamu_attach_device

2021-03-30 Thread Will Deacon
On Tue, Mar 16, 2021 at 04:38:15PM +0100, Christoph Hellwig wrote: > No good reason to split this functionality over two functions. > > Signed-off-by: Christoph Hellwig > Acked-by: Li Yang > --- > drivers/iommu/fsl_pamu_domain.c | 59 +++-- > 1 file changed, 20 inser

Re: [PATCH 10/18] iommu/fsl_pamu: enable the liodn when attaching a device

2021-03-30 Thread Will Deacon
On Tue, Mar 16, 2021 at 04:38:16PM +0100, Christoph Hellwig wrote: > Instead of a separate call to enable all devices from the list, just > enablde the liodn one the device is attached to the iommu domain. (typos: "enablde" and "one" probably needs to be "once"?) > This also remove the DOMAIN_ATT

Re: [PATCH] drm/amdgpu: fix an underflow on non-4KB-page systems

2021-03-30 Thread Christian König
Am 30.03.21 um 14:04 schrieb Xi Ruoyao: On 2021-03-30 03:40 +0800, Xi Ruoyao wrote: On 2021-03-29 21:36 +0200, Christian König wrote: Am 29.03.21 um 21:27 schrieb Xi Ruoyao: Hi Christian, I don't think there is any constraint implemented to ensure `num_entries % AMDGPU_GPU_PAGES_IN_CPU_PAGE =

Re: [PATCH 11/18] iommu/fsl_pamu: remove the snoop_id field

2021-03-30 Thread Will Deacon
On Tue, Mar 16, 2021 at 04:38:17PM +0100, Christoph Hellwig wrote: > The snoop_id is always set to ~(u32)0. > > Signed-off-by: Christoph Hellwig > Acked-by: Li Yang > --- > drivers/iommu/fsl_pamu_domain.c | 5 ++--- > drivers/iommu/fsl_pamu_domain.h | 1 - > 2 files changed, 2 insertions(+), 4

Re: [PATCH 12/18] iommu: remove DOMAIN_ATTR_PAGING

2021-03-30 Thread Will Deacon
On Tue, Mar 16, 2021 at 04:38:18PM +0100, Christoph Hellwig wrote: > DOMAIN_ATTR_PAGING is never used. > > Signed-off-by: Christoph Hellwig > Acked-by: Li Yang > --- > drivers/iommu/iommu.c | 5 - > include/linux/iommu.h | 1 - > 2 files changed, 6 deletions(-) Acked-by: Will Deacon Will

Re: [PATCH 1/2] drm/ingenic: Switch IPU plane to type OVERLAY

2021-03-30 Thread Simon Ser
On Tuesday, March 30th, 2021 at 1:53 PM, Paul Cercueil wrote: > > I don't know about this driver but… is this really the same as the > > previous > > condition? The previous condition would match two planes, this one > > seems to > > match only a single plane. What am I missing? > > There are th

Re: [PATCH 13/18] iommu: remove DOMAIN_ATTR_GEOMETRY

2021-03-30 Thread Will Deacon
On Tue, Mar 16, 2021 at 04:38:19PM +0100, Christoph Hellwig wrote: > The geometry information can be trivially queried from the iommu_domain > struture. > > Signed-off-by: Christoph Hellwig > Acked-by: Li Yang > --- > drivers/iommu/iommu.c | 20 +++- > drivers/vfio/vfi

Re: [PATCH] drm/amdgpu: fix an underflow on non-4KB-page systems

2021-03-30 Thread Christian König
Am 30.03.21 um 15:00 schrieb Dan Horák: On Tue, 30 Mar 2021 14:55:01 +0200 Christian König wrote: Am 30.03.21 um 14:04 schrieb Xi Ruoyao: On 2021-03-30 03:40 +0800, Xi Ruoyao wrote: On 2021-03-29 21:36 +0200, Christian König wrote: Am 29.03.21 um 21:27 schrieb Xi Ruoyao: Hi Christian, I d

Re: [PATCH 14/18] iommu: remove DOMAIN_ATTR_NESTING

2021-03-30 Thread Will Deacon
On Tue, Mar 16, 2021 at 04:38:20PM +0100, Christoph Hellwig wrote: > Use an explicit enable_nesting method instead. > > Signed-off-by: Christoph Hellwig > Acked-by: Li Yang > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 43 - > drivers/iommu/arm/arm-smmu/arm-smmu.c

Re: [PATCH 15/18] iommu: remove iommu_set_cmd_line_dma_api and iommu_cmd_line_dma_api

2021-03-30 Thread Will Deacon
On Tue, Mar 16, 2021 at 04:38:21PM +0100, Christoph Hellwig wrote: > Don't obsfucate the trivial bit flag check. > > Signed-off-by: Christoph Hellwig > --- > drivers/iommu/iommu.c | 23 +-- > 1 file changed, 5 insertions(+), 18 deletions(-) Acked-by: Will Deacon Will _

Re: [PATCH v7 1/2] dt-bindings: display: add bindings for newhaven, 1.8-128160EF

2021-03-30 Thread Rob Herring
On Mon, 29 Mar 2021 21:14:13 +0200, Daniel Mack wrote: > This adds documentation for a new ILI9163 based, SPI connected display. > > Signed-off-by: Daniel Mack > --- > .../display/panel/ilitek,ili9163.yaml | 69 +++ > 1 file changed, 69 insertions(+) > create mode 100644

Re: [PATCH 16/18] iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE

2021-03-30 Thread Will Deacon
On Tue, Mar 16, 2021 at 04:38:22PM +0100, Christoph Hellwig wrote: > From: Robin Murphy > > Instead make the global iommu_dma_strict paramete in iommu.c canonical by > exporting helpers to get and set it and use those directly in the drivers. > > This make sure that the iommu.strict parameter al

Re: [PATCH 17/18] iommu: remove DOMAIN_ATTR_IO_PGTABLE_CFG

2021-03-30 Thread Will Deacon
On Tue, Mar 16, 2021 at 04:38:23PM +0100, Christoph Hellwig wrote: > Use an explicit set_pgtable_quirks method instead that just passes > the actual quirk bitmask instead. > > Signed-off-by: Christoph Hellwig > Acked-by: Li Yang > --- > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 5 +- > drivers

Re: [PATCH 18/18] iommu: remove iommu_domain_{get,set}_attr

2021-03-30 Thread Will Deacon
On Tue, Mar 16, 2021 at 04:38:24PM +0100, Christoph Hellwig wrote: > Remove the now unused iommu attr infrastructure. > > Signed-off-by: Christoph Hellwig > --- > drivers/iommu/iommu.c | 26 -- > include/linux/iommu.h | 36 > 2 files c

Re: [PATCH 16/18] iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE

2021-03-30 Thread Robin Murphy
On 2021-03-30 14:11, Will Deacon wrote: On Tue, Mar 16, 2021 at 04:38:22PM +0100, Christoph Hellwig wrote: From: Robin Murphy Instead make the global iommu_dma_strict paramete in iommu.c canonical by exporting helpers to get and set it and use those directly in the drivers. This make sure tha

Re: [PATCH] drm/amdgpu: fix an underflow on non-4KB-page systems

2021-03-30 Thread Christian König
Am 30.03.21 um 15:23 schrieb Dan Horák: On Tue, 30 Mar 2021 21:09:12 +0800 Xi Ruoyao wrote: On 2021-03-30 21:02 +0800, Xi Ruoyao wrote: On 2021-03-30 14:55 +0200, Christian König wrote: I rather see this as a kernel bug. Can you test if this code fragment fixes your issue: diff --git a/dr

Re: [PATCH v5 1/2] dt-bindings: usb: add analogix,anx7688.yaml

2021-03-30 Thread Dafna Hirschfeld
Hi, On 05.03.21 16:19, Laurent Pinchart wrote: Hi Dafna, On Fri, Mar 05, 2021 at 04:14:03PM +0100, Dafna Hirschfeld wrote: On 05.03.21 15:34, Laurent Pinchart wrote: On Fri, Mar 05, 2021 at 01:43:50PM +0100, Dafna Hirschfeld wrote: ANX7688 is a USB Type-C port controller with a MUX. It conve

Re: [Freedreno] [PATCH v3 24/25] drm/msm/dsi: inline msm_dsi_phy_set_src_pll

2021-03-30 Thread Dmitry Baryshkov
On 30/03/2021 06:34, abhin...@codeaurora.org wrote: On 2021-03-27 04:03, Dmitry Baryshkov wrote: The src_truthtable config is not used for some of phys, which use other means of configuring the master/slave usecases. Inline this function with the goal of removing src_pll_id argument in the next

Re: [PATCH 16/18] iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE

2021-03-30 Thread Will Deacon
On Tue, Mar 30, 2021 at 02:19:38PM +0100, Robin Murphy wrote: > On 2021-03-30 14:11, Will Deacon wrote: > > On Tue, Mar 16, 2021 at 04:38:22PM +0100, Christoph Hellwig wrote: > > > From: Robin Murphy > > > > > > Instead make the global iommu_dma_strict paramete in iommu.c canonical by > > > expor

Re: [PATCH v2 09/14] drm/edid: Use the cached EDID in drm_get_edid() if eDP

2021-03-30 Thread Ville Syrjälä
On Mon, Mar 29, 2021 at 07:53:40PM -0700, Douglas Anderson wrote: > Each time we call drm_get_edid() we: > 1. Go out to the bus and ask for the EDID. > 2. Cache the EDID. > > We can improve this to actually use the cached EDID so that if > drm_get_edid() is called multiple times then we don't need

Re: [PATCH] drm/amdgpu: fix an underflow on non-4KB-page systems

2021-03-30 Thread Xi Ruoyao
On 2021-03-30 14:55 +0200, Christian König wrote: > Am 30.03.21 um 14:04 schrieb Xi Ruoyao: > > On 2021-03-30 03:40 +0800, Xi Ruoyao wrote: > > > On 2021-03-29 21:36 +0200, Christian König wrote: > > > > Am 29.03.21 um 21:27 schrieb Xi Ruoyao: > > > > > Hi Christian, > > > > > > > > > > I don't th

Re: [PATCH] drm/amdgpu: fix an underflow on non-4KB-page systems

2021-03-30 Thread Xi Ruoyao
On 2021-03-30 21:02 +0800, Xi Ruoyao wrote: > On 2021-03-30 14:55 +0200, Christian König wrote: > > > > I rather see this as a kernel bug. Can you test if this code fragment > > fixes your issue: > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c > > b/drivers/gpu/drm/amd/amdgpu/amdgp

Re: [PATCH] drm/amdgpu: fix an underflow on non-4KB-page systems

2021-03-30 Thread Dan Horák
On Tue, 30 Mar 2021 21:09:12 +0800 Xi Ruoyao wrote: > On 2021-03-30 21:02 +0800, Xi Ruoyao wrote: > > On 2021-03-30 14:55 +0200, Christian König wrote: > > > > > > I rather see this as a kernel bug. Can you test if this code fragment > > > fixes your issue: > > > > > > diff --git a/drivers/gpu

Re: [PATCH] drm/amdgpu: fix an underflow on non-4KB-page systems

2021-03-30 Thread Dan Horák
On Tue, 30 Mar 2021 14:55:01 +0200 Christian König wrote: > Am 30.03.21 um 14:04 schrieb Xi Ruoyao: > > On 2021-03-30 03:40 +0800, Xi Ruoyao wrote: > >> On 2021-03-29 21:36 +0200, Christian König wrote: > >>> Am 29.03.21 um 21:27 schrieb Xi Ruoyao: > Hi Christian, > > I don't think

Re: [PATCH] drm/amdgpu: fix an underflow on non-4KB-page systems

2021-03-30 Thread Xi Ruoyao
On 2021-03-30 03:40 +0800, Xi Ruoyao wrote: > On 2021-03-29 21:36 +0200, Christian König wrote: > > Am 29.03.21 um 21:27 schrieb Xi Ruoyao: > > > Hi Christian, > > > > > > I don't think there is any constraint implemented to ensure `num_entries % > > > AMDGPU_GPU_PAGES_IN_CPU_PAGE == 0`.  For exam

Re: [PATCH v3 0/1] drm/tiny: add support for Waveshare 2inch LCD module

2021-03-30 Thread David Lechner
On 3/30/21 3:08 AM, Carlis wrote: From: Xuezhi Zhang This adds a new module for the ST7789V controller with parameters for the Waveshare 2inch LCD module. Signed-off-by: Xuezhi Zhang --- v2:change compatible value. v3:change author name. --- MAINTAINERS| 8 + drivers/

Re: [PATCH 1/2] iommu/arm-smmu-qcom: Skip the TTBR1 quirk for db820c.

2021-03-30 Thread Rob Clark
On Tue, Mar 30, 2021 at 2:34 AM Will Deacon wrote: > > On Mon, Mar 29, 2021 at 09:02:50PM -0700, Rob Clark wrote: > > On Mon, Mar 29, 2021 at 7:47 AM Will Deacon wrote: > > > > > > On Fri, Mar 26, 2021 at 04:13:02PM -0700, Eric Anholt wrote: > > > > db820c wants to use the qcom smmu path to get H

[PATCH] drm/i915/pmu: Do not report 100% RC6 if not supported

2021-03-30 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We use GT parked status to estimate RC6 while not in use, however if RC6 is not supported to start with that does not work very well and produces a false 100% RC6 readout. Fix by not advancing the estimated RC6 counter when feature is not supported. Signed-off-by: Tvrtko Ur

Re: [PATCH v5 1/2] dt-bindings: usb: add analogix,anx7688.yaml

2021-03-30 Thread Enric Balletbo i Serra
Hi Dafna, Many thanks to take this challenge and work on this. On 30/3/21 15:35, Dafna Hirschfeld wrote: > Hi, > > On 05.03.21 16:19, Laurent Pinchart wrote: >> Hi Dafna, >> >> On Fri, Mar 05, 2021 at 04:14:03PM +0100, Dafna Hirschfeld wrote: >>> On 05.03.21 15:34, Laurent Pinchart wrote: O

Re: [RESEND 00/19] Rid GPU from W=1 warnings

2021-03-30 Thread Lee Jones
On Wed, 24 Mar 2021, Lee Jones wrote: > Daniel, > > > MIME-Version: 1.0 > > Content-Type: text/plain; charset=UTF-8 > > Content-Transfer-Encoding: 8bit > > > > This is a resend of the remaining patches. > > > > All of these patches have been sent before. > > Are you still keen to 'hoover these

Re: [Freedreno] [PATCH v3 23/25] drm/msm/dsi: remove temp data from global pll structure

2021-03-30 Thread Dmitry Baryshkov
On 30/03/2021 06:26, abhin...@codeaurora.org wrote: On 2021-03-27 04:03, Dmitry Baryshkov wrote: The 7nm, 10nm and 14nm drivers would store interim data used during VCO/PLL rate setting in the global dsi_pll_Nnm structure. Move this data structures to the onstack storage. While we are at it, dro

Re: [PATCH v5 2/2] drm/bridge: anx7688: Add ANX7688 bridge driver support

2021-03-30 Thread Enric Balletbo i Serra
Hi Dafna, Thank you for your patch and to work on this. On 5/3/21 13:43, Dafna Hirschfeld wrote: > From: Enric Balletbo i Serra > > This driver adds support for the ANX7688 HDMI to DP converter block of the > ANX7688 device. > > For our use case, the only reason the Linux kernel driver is nece

Re: [PATCH 1/2] iommu/arm-smmu-qcom: Skip the TTBR1 quirk for db820c.

2021-03-30 Thread Will Deacon
On Tue, Mar 30, 2021 at 08:03:36AM -0700, Rob Clark wrote: > On Tue, Mar 30, 2021 at 2:34 AM Will Deacon wrote: > > > > On Mon, Mar 29, 2021 at 09:02:50PM -0700, Rob Clark wrote: > > > On Mon, Mar 29, 2021 at 7:47 AM Will Deacon wrote: > > > > > > > > On Fri, Mar 26, 2021 at 04:13:02PM -0700, Eri

[PATCH 0/2] ensure alignment on CPU page for bo mapping

2021-03-30 Thread Xℹ Ruoyao
In AMDGPU driver, the bo mapping should always align to CPU page or the page table is corrupted. The first patch is cherry-picked from Loongson community, which sets a suitable dev_info.gart_page_size so Mesa will handle the alignment correctly. The second patch is added to ensure an ioctl with u

[PATCH 1/2] drm/amdgpu: Set a suitable dev_info.gart_page_size

2021-03-30 Thread Xℹ Ruoyao
From: Huacai Chen In Mesa, dev_info.gart_page_size is used for alignment and it was set to AMDGPU_GPU_PAGE_SIZE(4KB). However, the page table of AMDGPU driver requires an alignment on CPU pages. So, for non-4KB page system, gart_page_size should be max_t(u32, PAGE_SIZE, AMDGPU_GPU_PAGE_SIZE). S

Re: [PATCH v3 10/11] drm: Use state helper instead of the plane state pointer

2021-03-30 Thread Maxime Ripard
Hi Stephen, On Mon, Mar 29, 2021 at 06:52:01PM -0700, Stephen Boyd wrote: > Trimming Cc list way down, sorry if that's too much. > > Quoting Maxime Ripard (2021-02-19 04:00:30) > > Many drivers reference the plane->state pointer in order to get the > > current plane state in their atomic_update o

[PATCH 2/2] drm/amdgpu: check alignment on CPU page for bo map

2021-03-30 Thread Xℹ Ruoyao
The page table of AMDGPU requires an alignment to CPU page so we should check ioctl parameters for it. Return -EINVAL if some parameter is unaligned to CPU page, instead of corrupt the page table sliently. Signed-off-by: Xi Ruoyao --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 8 1 file

Re: [PATCH] drm/amdgpu: fix an underflow on non-4KB-page systems

2021-03-30 Thread Xi Ruoyao
On 2021-03-30 15:24 +0200, Christian König wrote: > Am 30.03.21 um 15:23 schrieb Dan Horák: > > On Tue, 30 Mar 2021 21:09:12 +0800 > > Xi Ruoyao wrote: > > > > > On 2021-03-30 21:02 +0800, Xi Ruoyao wrote: > > > > On 2021-03-30 14:55 +0200, Christian König wrote: > > > > > I rather see this as a

[PATCH 3/3] drm/mediatek: dpi: add bus format negociation

2021-03-30 Thread Jitao Shi
Add the atomic_get_output_bus_fmts, atomic_get_input_bus_fmts to negociate the possible output and input formats for the current mode and monitor, and use the negotiated formats in a basic atomic_check callback. Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/mtk_dpi.c | 96 +++

[PATCH 2/3] drm/mediatek: config mt8183 driver data to support dual edge sample

2021-03-30 Thread Jitao Shi
Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/mtk_dpi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index ccd681a2a4c2..87bb27649c4c 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/media

[PATCH 0/3] mt8183 dpi supports dual edge

2021-03-30 Thread Jitao Shi
DPI can sample on falling, rising or both edge. When DPI sample the data both rising and falling edge. It can reduce half data io pins. Jitao Shi (3): drm/mediatek: dpi dual edge sample mode support drm/mediatek: config mt8183 driver data to support dual edge sample drm/mediatek: dpi: add bu

[PATCH 1/3] drm/mediatek: dpi dual edge sample mode support

2021-03-30 Thread Jitao Shi
DPI can sample on falling, rising or both edge. When DPI sample the data both rising and falling edge. It can reduce half data io pins. Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/mtk_dpi.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_d

Re: [PATCH 1/2] iommu/arm-smmu-qcom: Skip the TTBR1 quirk for db820c.

2021-03-30 Thread Rob Clark
On Tue, Mar 30, 2021 at 8:31 AM Will Deacon wrote: > > On Tue, Mar 30, 2021 at 08:03:36AM -0700, Rob Clark wrote: > > On Tue, Mar 30, 2021 at 2:34 AM Will Deacon wrote: > > > > > > On Mon, Mar 29, 2021 at 09:02:50PM -0700, Rob Clark wrote: > > > > On Mon, Mar 29, 2021 at 7:47 AM Will Deacon wrot

Re: [PATCH 0/2] ensure alignment on CPU page for bo mapping

2021-03-30 Thread Christian König
Reviewed-by: Christian König for the entire series. Alex will probably pick them up for the next feature pull request. Regards, Christian. Am 30.03.21 um 17:33 schrieb Xℹ Ruoyao: In AMDGPU driver, the bo mapping should always align to CPU page or the page table is corrupted. The first patch

Re: [PATCH 16/18] iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE

2021-03-30 Thread Robin Murphy
On 2021-03-30 14:58, Will Deacon wrote: On Tue, Mar 30, 2021 at 02:19:38PM +0100, Robin Murphy wrote: On 2021-03-30 14:11, Will Deacon wrote: On Tue, Mar 16, 2021 at 04:38:22PM +0100, Christoph Hellwig wrote: From: Robin Murphy Instead make the global iommu_dma_strict paramete in iommu.c can

Re: [PATCH 17/18] vfio/mdev: Remove kobj from mdev_parent_ops->create()

2021-03-30 Thread Cornelia Huck
On Tue, 23 Mar 2021 14:55:34 -0300 Jason Gunthorpe wrote: > The kobj here is a type-erased version of mdev_type, which is already > stored in the struct mdev_device being passed in. It was only ever used to > compute the type_group_id, which is now extracted directly from the mdev. > > Signed-of

Re: [PATCH 18/18] vfio/mdev: Correct the function signatures for the mdev_type_attributes

2021-03-30 Thread Cornelia Huck
On Tue, 23 Mar 2021 14:55:35 -0300 Jason Gunthorpe wrote: > The driver core standard is to pass in the properly typed object, the > properly typed attribute and the buffer data. It stems from the root > kobject method: > > ssize_t (*show)(struct kobject *kobj, struct kobj_attribute *attr,..) >

Re: [PATCH 14/30] Revert "s3c24xx-dma.c: Fix a typo"

2021-03-30 Thread Vinod Koul
On 29-03-21, 05:23, Bhaskar Chowdhury wrote: > s/transferred/transfered/ > > This reverts commit a2ddb8aea8106bd5552f8516ad7a8a26b9282a8f. This is not upstream, why not squash in. Also would make sense to write sensible changelog and not phrases and use the right subsystem conventions! Droped th

Re: [Freedreno] [PATCH v3 24/25] drm/msm/dsi: inline msm_dsi_phy_set_src_pll

2021-03-30 Thread abhinavk
On 2021-03-30 06:42, Dmitry Baryshkov wrote: On 30/03/2021 06:34, abhin...@codeaurora.org wrote: On 2021-03-27 04:03, Dmitry Baryshkov wrote: The src_truthtable config is not used for some of phys, which use other means of configuring the master/slave usecases. Inline this function with the go

Re: [PATCH 06/11] cgroup: fix -Wzero-length-bounds warnings

2021-03-30 Thread Michal Koutný
On Mon, Mar 22, 2021 at 05:02:44PM +0100, Arnd Bergmann wrote: > I'm not sure what is expected to happen for such a configuration, > presumably these functions are never calls in that case. Yes, the functions you patched would only be called from subsystems or there should be no way to obtain a st

Re: [PATCH v7 1/8] mm: Remove special swap entry functions

2021-03-30 Thread Jason Gunthorpe
On Fri, Mar 26, 2021 at 11:07:58AM +1100, Alistair Popple wrote: > Remove multiple similar inline functions for dealing with different > types of special swap entries. > > Both migration and device private swap entries use the swap offset to > store a pfn. Instead of multiple inline functions to o

Re: [PATCH 06/11] cgroup: fix -Wzero-length-bounds warnings

2021-03-30 Thread Michal Koutný
On Tue, Mar 30, 2021 at 11:00:36AM +0200, Arnd Bergmann wrote: > Would it be possible to enclose most or all of kernel/cgroup/cgroup.c > in an #ifdef CGROUP_SUBSYS_COUNT block? Even without any controllers, there can still be named hierarchies (v1) or the default hierarchy (v2) (for instance) for

  1   2   >