RE: [PATCH 18/18] vfio/mdev: Correct the function signatures for the mdev_type_attributes

2021-03-26 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Wednesday, March 24, 2021 1:56 AM > > The driver core standard is to pass in the properly typed object, the > properly typed attribute and the buffer data. It stems from the root > kobject method: > > ssize_t (*show)(struct kobject *kobj, struct kobj_attribute *

Re: [PATCH] drm/omap: fix misleading indentation in pixinc()

2021-03-26 Thread Tomi Valkeinen
On 22/03/2021 18:41, Arnd Bergmann wrote: From: Arnd Bergmann An old patch added a 'return' statement after each BUG() in this driver, which was necessary at the time, but has become redundant after the BUG() definition was updated to handle this properly. gcc-11 now warns about one such insta

Re: [PATCH v2] drm/omap: dsi: Add missing IRQF_ONESHOT

2021-03-26 Thread Tomi Valkeinen
On 23/03/2021 13:15, Sebastian Reichel wrote: Hi, On Tue, Mar 23, 2021 at 05:34:53PM +0800, Yang Li wrote: fixed the following coccicheck: ./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Reported-by: Abaci Robot Signed-

Re: [PATCH] [v2] drivers: gpu: drm: Remove duplicate declaration

2021-03-26 Thread Tomi Valkeinen
On 25/03/2021 15:05, Laurent Pinchart wrote: Hi Wan, Thank you for the patch. On Thu, Mar 25, 2021 at 07:10:24PM +0800, Wan Jiabing wrote: struct dss_device has been declared. Remove the duplicate. And sort these forward declarations alphabetically. Signed-off-by: Wan Jiabing Reviewed-by:

Re: [PATCH] drm/bridge: adv7511: fix support for large EDIDs

2021-03-26 Thread Niklas Söderlund
Hi Hans, Thanks for your patch. On 2021-03-24 09:53:32 +0100, Hans Verkuil wrote: > While testing support for large (> 256 bytes) EDIDs on the Renesas > Koelsch board I noticed that the adv7511 bridge driver only read the > first two blocks. > > The media V4L2 version for the adv7511 (drivers/me

[PATCH] staging: fbtft: fix a typo

2021-03-26 Thread Carlis
From: "Carlis" Change 'tft' to 'TFT' Signed-off-by: Carlis --- drivers/staging/fbtft/fbtft-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index 4f362da..44e7acb 100644 --- a/drivers/staging

Re: [PATCH] drm/doc: Add RFC section

2021-03-26 Thread Daniel Vetter
On Thu, Mar 25, 2021 at 11:58:59PM +0100, Daniel Vetter wrote: > Motivated by the pre-review process for i915 gem/gt features, but > probably useful in general for complex stuff. > > v2: Add reminder to not forget userspace projects in the discussion > (Simon, Jason) > > v3: Actually put this int

Re: [PATCH] staging: fbtft: fix a typo

2021-03-26 Thread Greg KH
On Fri, Mar 26, 2021 at 04:05:15PM +0800, Carlis wrote: > From: "Carlis" > > Change 'tft' to 'TFT' Why? What is wrong with "tft"? > > Signed-off-by: Carlis Full name please. thanks, greg k-h ___ dri-devel mailing list dri-devel@lists.freedesktop

[bug report] drm/ttm: switch to per device LRU lock

2021-03-26 Thread Dan Carpenter
Hello Christian König, This is a semi-automatic email about new static checker warnings. The patch a1f091f8ef2b: "drm/ttm: switch to per device LRU lock" from Oct 6, 2020, leads to the following Smatch complaint: drivers/gpu/drm/ttm/ttm_bo.c:665 ttm_mem_evict_first() error: we previously

linux-next: build warning after merge of the drm-intel-fixes tree

2021-03-26 Thread Stephen Rothwell
Hi all, After merging the drm-intel-fixes tree, today's linux-next build (htmldocs) produced this warning: Documentation/gpu/i915:22: /drivers/gpu/drm/i915/intel_runtime_pm.c:423: WARNING: Inline strong start-string without end-string. Introduced by commit 8840e3bd981f ("drm/i915: Fix the GT

Re: [PATCH v3] drm/scheduler re-insert Bailing job to avoid memleak

2021-03-26 Thread Christian König
Hi guys, Am 26.03.21 um 03:23 schrieb Zhang, Jack (Jian): [AMD Official Use Only - Internal Distribution Only] Hi, Andrey, how u handle non guilty singnaled jobs in drm_sched_stop, currently looks like you don't call put for them and just explicitly free them as before Good point, I missed

Re: [PATCH v3] drm/scheduler re-insert Bailing job to avoid memleak

2021-03-26 Thread Steven Price
On 26/03/2021 02:04, Zhang, Jack (Jian) wrote: [AMD Official Use Only - Internal Distribution Only] Hi, Steve, Thank you for your detailed comments. But currently the patch is not finalized. We found some potential race condition even with this patch. The solution is under discussion and hope

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-26 Thread Intel
On 3/25/21 7:24 PM, Jason Gunthorpe wrote: On Thu, Mar 25, 2021 at 07:13:33PM +0100, Thomas Hellström (Intel) wrote: On 3/25/21 6:55 PM, Jason Gunthorpe wrote: On Thu, Mar 25, 2021 at 06:51:26PM +0100, Thomas Hellström (Intel) wrote: On 3/24/21 9:25 PM, Dave Hansen wrote: On 3/24/21 1:22 PM,

Re: [Intel-gfx] [PATCH v4 0/7] Default request/fence expiry + watchdog

2021-03-26 Thread Daniel Vetter
On Wed, Mar 24, 2021 at 12:13:28PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > "Watchdog" aka "restoring hangcheck" aka default request/fence expiry - second > post of a somewhat controversial feature, now upgraded to patch status. > > I quote the "watchdog" becuase in classical sens

Re: [PATCH] staging: fbtft: fix a typo

2021-03-26 Thread carlis
On Fri, 26 Mar 2021 09:37:48 +0100 Greg KH wrote: > On Fri, Mar 26, 2021 at 04:05:15PM +0800, Carlis wrote: > > From: "Carlis" > > > > Change 'tft' to 'TFT' > > Why? What is wrong with "tft"? > I think abbreviations should be capitalized. > > > > Signed-off-by: Carlis > > Full name pl

Re: [PATCH] staging: fbtft: fix a typo

2021-03-26 Thread Greg KH
On Fri, Mar 26, 2021 at 05:16:34PM +0800, carlis wrote: > On Fri, 26 Mar 2021 09:37:48 +0100 > Greg KH wrote: > > > On Fri, Mar 26, 2021 at 04:05:15PM +0800, Carlis wrote: > > > From: "Carlis" > > > > > > Change 'tft' to 'TFT' > > > > Why? What is wrong with "tft"? > > > I think abbreviati

Re: [PATCH] drm/amdkfd: dqm fence memory corruption

2021-03-26 Thread Qu Huang
On 2021/1/28 5:50, Felix Kuehling wrote: Am 2021-01-27 um 7:33 a.m. schrieb Qu Huang: Amdgpu driver uses 4-byte data type as DQM fence memory, and transmits GPU address of fence memory to microcode through query status PM4 message. However, query status PM4 message definition and microcode proce

Re: [Intel-gfx] [PATCH v5 1/2] drm/dp_helper: Define options for FRL training for HDMI2.1 PCON

2021-03-26 Thread Jani Nikula
On Tue, 23 Mar 2021, Ankit Nautiyal wrote: > Currently the FRL training mode (Concurrent, Sequential) and > training type (Normal, Extended) are not defined properly and > are passed as bool values in drm_helpers for pcon > configuration for FRL training. > > This patch: > -Add register masks for

Re: [PATCH] staging: fbtft: fix a typo

2021-03-26 Thread carlis
On Fri, 26 Mar 2021 10:33:57 +0100 Greg KH wrote: > On Fri, Mar 26, 2021 at 05:16:34PM +0800, carlis wrote: > > On Fri, 26 Mar 2021 09:37:48 +0100 > > Greg KH wrote: > > > > > On Fri, Mar 26, 2021 at 04:05:15PM +0800, Carlis wrote: > > > > From: "Carlis" > > > > > > > > Change 'tft' to 'T

[Bug 212449] New: DDC requires amdgpu.dc=0, HDMI sound requires amdgpu.dc=1. Make them work together!

2021-03-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212449 Bug ID: 212449 Summary: DDC requires amdgpu.dc=0, HDMI sound requires amdgpu.dc=1. Make them work together! Product: Drivers Version: 2.5 Kernel Version: 5.4.107 Hardwa

Re: [Intel-gfx] [PATCH v4 0/7] Default request/fence expiry + watchdog

2021-03-26 Thread Tvrtko Ursulin
On 26/03/2021 09:10, Daniel Vetter wrote: On Wed, Mar 24, 2021 at 12:13:28PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin "Watchdog" aka "restoring hangcheck" aka default request/fence expiry - second post of a somewhat controversial feature, now upgraded to patch status. I quote the "

Re: [PATCH 5/7] drm/i915: Request watchdog infrastructure

2021-03-26 Thread Tvrtko Ursulin
On 26/03/2021 00:00, Daniel Vetter wrote: On Wed, Mar 24, 2021 at 12:13:33PM +, Tvrtko Ursulin wrote: [snip] +static enum hrtimer_restart __rq_watchdog_expired(struct hrtimer *hrtimer) +{ + struct i915_request *rq = + container_of(hrtimer, struct i915_request, watchd

[PATCH 1/2] drm: Fix 3 typos in the inline doc

2021-03-26 Thread Dafna Hirschfeld
Fix the following typos: 1. When mentioning a list of functions, the function drm_atomic_helper_disable_plane is mentioned twice. 2. drop the word 'afterwards': s/afterwards after that/after that/' 3. drop extra 'the': s/but do not the support the full/but do not support the full/ Signed-off-by

[PATCH 2/2] drm/bridge: fix typo in Kconfig

2021-03-26 Thread Dafna Hirschfeld
fix 's/controller/controllers/' in the sentence: Most display controller handle display connectors... Signed-off-by: Dafna Hirschfeld --- drivers/gpu/drm/bridge/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kc

Re: [PATCH 1/2] drm: Fix 3 typos in the inline doc

2021-03-26 Thread Simon Ser
Reviewed-by: Simon Ser I'll push this shortly to drm-misc-next. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/i915: Take request reference before arming the watchdog timer

2021-03-26 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Reference needs to be taken before arming the timer. Luckily, given the default timer period of 20s, the potential to hit the race is extremely unlikely. Signed-off-by: Tvrtko Ursulin Fixes: 9b4d0598ee94 ("drm/i915: Request watchdog infrastructure") Cc: Daniel Vetter --- T

回复: [PATCH v3] drm/scheduler re-insert Bailing job to avoid memleak

2021-03-26 Thread Liu, Monk
[AMD Official Use Only - Internal Distribution Only] Hi Christian This is not correct or correct perspective, any design comes with its pros and cons, otherwise it wouldn't comes to kernel tree in the very beginning , it is just with time passed we have more and more requirement and feature nee

Re: [Intel-gfx] [PATCH] drm/i915: Take request reference before arming the watchdog timer

2021-03-26 Thread Mika Kuoppala
Tvrtko Ursulin writes: > From: Tvrtko Ursulin > > Reference needs to be taken before arming the timer. Luckily, given the > default timer period of 20s, the potential to hit the race is extremely > unlikely. > > Signed-off-by: Tvrtko Ursulin > Fixes: 9b4d0598ee94 ("drm/i915: Request watchdog in

Re: [PATCH 00/25] Rid W=1 warnings from HID

2021-03-26 Thread Jonathan Cameron
On Wed, 24 Mar 2021 17:33:39 + Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. Lee, it's a bit novel to cc linux-iio on the cover letter but none of the actual patches

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-26 Thread Jason Gunthorpe
On Fri, Mar 26, 2021 at 10:08:09AM +0100, Thomas Hellström (Intel) wrote: > > On 3/25/21 7:24 PM, Jason Gunthorpe wrote: > > On Thu, Mar 25, 2021 at 07:13:33PM +0100, Thomas Hellström (Intel) wrote: > > > On 3/25/21 6:55 PM, Jason Gunthorpe wrote: > > > > On Thu, Mar 25, 2021 at 06:51:26PM +0100,

[PATCH v9 1/2] dt-bindings: display: bridge: Add documentation for LT8912B

2021-03-26 Thread Adrien Grassein
Lontium LT8912B is a DSI to HDMI bridge. Signed-off-by: Adrien Grassein Reviewed-by: Rob Herring --- .../display/bridge/lontium,lt8912b.yaml | 102 ++ MAINTAINERS | 5 + 2 files changed, 107 insertions(+) create mode 100644 Documentati

[PATCH v9 0/2] Add support of Lontium lt8912 MIPI to HDMI bridge

2021-03-26 Thread Adrien Grassein
Hi, this patch set adds the support of the Lontium lt8912 MIPI to HDMI bridge in the kernel. It's only support the video part, not the audio part yet since I don't have the datasheet of this component. I get the current i2c configuration from Digi and Boundary drivers. Developed using the DB_DSIHD

[PATCH v9 2/2] drm/bridge: Introduce LT8912B DSI to HDMI bridge

2021-03-26 Thread Adrien Grassein
Lontium LT8912B is a DSI to HDMI bridge. Signed-off-by: Adrien Grassein Reported-by: kernel test robot Reviewed-by: Robert Foss --- MAINTAINERS | 1 + drivers/gpu/drm/bridge/Kconfig | 14 + drivers/gpu/drm/bridge/Makefile | 1 + drivers/gpu/

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-26 Thread Intel
On 3/26/21 12:46 PM, Jason Gunthorpe wrote: On Fri, Mar 26, 2021 at 10:08:09AM +0100, Thomas Hellström (Intel) wrote: On 3/25/21 7:24 PM, Jason Gunthorpe wrote: On Thu, Mar 25, 2021 at 07:13:33PM +0100, Thomas Hellström (Intel) wrote: On 3/25/21 6:55 PM, Jason Gunthorpe wrote: On Thu, Mar 25

Re: [PATCH] drm/bridge: adv7511: fix support for large EDIDs

2021-03-26 Thread Laurent Pinchart
Hi Hans, On Fri, Mar 26, 2021 at 07:31:09AM +0100, Hans Verkuil wrote: > On 26/03/2021 02:00, Laurent Pinchart wrote: > > On Wed, Mar 24, 2021 at 09:53:32AM +0100, Hans Verkuil wrote: > >> While testing support for large (> 256 bytes) EDIDs on the Renesas > >> Koelsch board I noticed that the adv7

Re: [RFC PATCH 1/3] dt-bindings: display: simple: Add the panel on sc7180-trogdor-pompom

2021-03-26 Thread Thierry Reding
On Wed, Mar 17, 2021 at 06:53:04PM -0700, Rob Clark wrote: > On Wed, Mar 17, 2021 at 4:27 PM Matthias Kaehlcke wrote: > > > > On Tue, Mar 16, 2021 at 02:08:19PM -0700, Douglas Anderson wrote: > > > The sc7180-trogdor-pompom board might be attached to any number of a > > > pile of eDP panels. At th

[PATCH v2] staging: fbtft: fix a typo

2021-03-26 Thread Carlis
From: Xuezhi Zhang Change 'tft' to 'TFT' Signed-off-by: Xuezhi Zhang --- v2: use full name. drivers/staging/fbtft/fbtft-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index 4f362da..44e7acb

Re: [PATCH v2] staging: fbtft: fix a typo

2021-03-26 Thread Greg KH
On Fri, Mar 26, 2021 at 08:55:51PM +0800, Carlis wrote: > From: Xuezhi Zhang > > Change 'tft' to 'TFT' That says what you did, but not _why_ you did it. And this is not a "typo", as it is not misspelled and really is just fine as-is. thanks, greg k-h __

[PULL] topic/i915-gem-next

2021-03-26 Thread Daniel Vetter
Hi Dave, topic/i915-gem-next-2021-03-26: special i915-gem-next pull as requested - Conversion to dma_resv_locking, obj->mm.lock is gone (Maarten, with help from Thomas Hellström) - watchdog (Tvrtko, one patch to cancel individual request from Chris) - legacy ioctl cleanup (Jason+Ashutosh) - i91

[PATCHv2] drm/bridge: adv7511: fix support for large EDIDs

2021-03-26 Thread Hans Verkuil
While testing support for large (> 256 bytes) EDIDs on the Renesas Koelsch board I noticed that the adv7511 bridge driver only read the first two blocks. The media V4L2 version for the adv7511 (drivers/media/i2c/adv7511-v4l2.c) handled this correctly. Besides a simple bug when setting the segment

[Bug 212449] DDC requires amdgpu.dc=0, HDMI sound requires amdgpu.dc=1. Make them work together!

2021-03-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212449 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

Re: [PULL] topic/i915-gem-next

2021-03-26 Thread Jani Nikula
On Fri, 26 Mar 2021, Daniel Vetter wrote: > The rough plan we discussed somewhat ad-hoc with Jani&Rodrigo (Joonas was > out this week, but back next) is that they send out a pull with what's > there right now. Then once both this branch here and the -gt-next pull are > in drm-next they will backme

[PATCH] staging: fbtft: change '16 bit' to '16-bit'

2021-03-26 Thread Carlis
From: "carlis.zhang_cp" Change '16 bit' to '16-bit' for a same style. Signed-off-by: carlis.zhang_cp --- drivers/staging/fbtft/fbtft-bus.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c index 63c6

Re: [PATCH] staging: fbtft: change '16 bit' to '16-bit'

2021-03-26 Thread Greg KH
On Fri, Mar 26, 2021 at 10:09:30PM +0800, Carlis wrote: > From: "carlis.zhang_cp" > > Change '16 bit' to '16-bit' for a same style. Why? This is up to the author. > > Signed-off-by: carlis.zhang_cp Please use a real name, not an email-alias as a name. thanks, greg k-h

Re: [PULL] topic/i915-gem-next

2021-03-26 Thread Daniel Vetter
On Fri, Mar 26, 2021 at 2:31 PM Jani Nikula wrote: > > On Fri, 26 Mar 2021, Daniel Vetter wrote: > > The rough plan we discussed somewhat ad-hoc with Jani&Rodrigo (Joonas was > > out this week, but back next) is that they send out a pull with what's > > there right now. Then once both this branch

Re: [PATCH 00/25] Rid W=1 warnings from HID

2021-03-26 Thread Lee Jones
On Fri, 26 Mar 2021, Jonathan Cameron wrote: > On Wed, 24 Mar 2021 17:33:39 + > Lee Jones wrote: > > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > Lee, it's a bit novel to c

Re: [PATCH 00/25] Rid W=1 warnings from HID

2021-03-26 Thread Lee Jones
On Fri, 26 Mar 2021, Lee Jones wrote: > On Fri, 26 Mar 2021, Jonathan Cameron wrote: > > > On Wed, 24 Mar 2021 17:33:39 + > > Lee Jones wrote: > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > kernel builds, which are currently overwhelmingly riddled with > > >

Re: [PATCH v5 03/21] gpu: host1x: Show number of pending waiters in debugfs

2021-03-26 Thread Mikko Perttunen
On 3/23/21 12:16 PM, Thierry Reding wrote: On Mon, Jan 11, 2021 at 03:00:01PM +0200, Mikko Perttunen wrote: Show the number of pending waiters in the debugfs status file. This is useful for testing to verify that waiters do not leak or accumulate incorrectly. Signed-off-by: Mikko Perttunen ---

[RESEND 00/25] Rid W=1 warnings from HID

2021-03-26 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (25): HID: intel-ish-hid: Remove unused variable 'err' HID: ishtp-hid-client: Move variable to where it's actually used HID: intel-i

[RESEND 00/25] Rid W=1 warnings from HID

2021-03-26 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. [RESEND] contains no functional changes. Only 18 of 25 patches actually made it to the list during the first attempt. Lee Jones (25): HID: intel

[PATCH 24/25] HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues

2021-03-26 Thread Lee Jones
And demote non-conformant header Fixes the following W=1 kernel build warning(s): drivers/hid/intel-ish-hid/ishtp-fw-loader.c:46: warning: Enum value 'LOADER_CMD_XFER_QUERY' not described in enum 'ish_loader_commands' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:46: warning: Enum value 'LOADER

Re: [PATCH v5 09/10] drm: rcar-du: Perform group setup from the atomic tail handler

2021-03-26 Thread Maxime Ripard
Hi Kieran, On Mon, Mar 22, 2021 at 04:35:34PM +, Kieran Bingham wrote: > Create rcar_du_group_atomic_check() and rcar_du_group_atomic_setup() > functions to track and apply group state through the DRM atomic state. > The use_count field is moved from the rcar_du_group structure to an > enabled

Re: [PATCH v9 0/2] Add support of Lontium lt8912 MIPI to HDMI bridge

2021-03-26 Thread Robert Foss
Pushed: https://cgit.freedesktop.org/drm/drm-misc/commit/?id=3aa6031deefa9a2c056af2182af02d3dc5df1067 On Fri, 26 Mar 2021 at 13:20, Adrien Grassein wrote: > > Hi, > this patch set adds the support of the Lontium lt8912 MIPI to HDMI > bridge in the kernel. > > It's only support the video part, no

[PATCH v2 00/10] drm/tegra: Various improvements

2021-03-26 Thread Thierry Reding
From: Thierry Reding Hi, this fixes a couple of oddities like slightly off DMA masks and add support for hardware cursors on newer chips as well as support for the sector layout bit in NVIDIA framebuffer modifiers. The first patch in this set is a small helper that I think might be useful to ot

[PATCH v2 01/10] drm/fourcc: Add macros to determine the modifier vendor

2021-03-26 Thread Thierry Reding
From: Thierry Reding When working with framebuffer modifiers, it can be useful to extract the vendor identifier or check a modifier against a given vendor identifier. Add one macro that extracts the vendor identifier and a helper to check a modifier against a given vendor identifier. v2: add mac

Re: 回复: [PATCH v3] drm/scheduler re-insert Bailing job to avoid memleak

2021-03-26 Thread Christian König
Hi Monk, I can't disagree more. The fundamental problem here is that we have pushed a design without validating if it really fits into the concepts the Linux kernel mandates here. My mistake was that I haven't pushed back hard enough on the initial design resulting in numerous cycles of try

[PATCH v2 02/10] drm/arm: malidp: Use fourcc_mod_is_vendor() helper

2021-03-26 Thread Thierry Reding
From: Thierry Reding Rather than open-coding the vendor extraction operation, use the newly introduced helper macro. Signed-off-by: Thierry Reding --- drivers/gpu/drm/arm/malidp_planes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/

[PATCH v2 03/10] drm/tegra: dc: Inherit DMA mask

2021-03-26 Thread Thierry Reding
From: Thierry Reding Inherit the DMA mask from host1x (on Tegra210 and earlier) or the display hub (on Tegra186 and later). This is necessary in order to properly map buffers without SMMU support and use the maximum IOVA space available with SMMU support. Signed-off-by: Thierry Reding --- driv

[PATCH v2 04/10] drm/tegra: dc: Parameterize maximum resolution

2021-03-26 Thread Thierry Reding
From: Thierry Reding Tegra186 and later support a higher maximum resolution than earlier chips, so make sure to reflect that in the mode configuration. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dc.c | 6 ++ drivers/gpu/drm/tegra/drm.c | 13 ++--- drivers/gpu/drm/teg

[PATCH v2 05/10] drm/tegra: dc: Implement hardware cursor on Tegra186 and later

2021-03-26 Thread Thierry Reding
From: Thierry Reding The hardware cursor on Tegra186 differs slightly from the implementation on older SoC generations. In particular the new implementation relies on software for clipping the cursor against the screen. Fortunately, atomic KMS already computes clipped coordinates for (cursor) pla

[PATCH v2 06/10] drm/tegra: fb: Add diagnostics for framebuffer modifiers

2021-03-26 Thread Thierry Reding
From: Thierry Reding Add a debug message to let the user know when a framebuffer modifier is not supported. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/fb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c index 01939c57fc7

[PATCH v2 08/10] gpu: host1x: Add early init and late exit callbacks

2021-03-26 Thread Thierry Reding
From: Thierry Reding These callbacks can be used by client drivers to run code during early init and during late exit. Early init callbacks are run prior to the regular init callbacks while late exit callbacks run after the regular exit callbacks. Signed-off-by: Thierry Reding --- drivers/gpu/

[PATCH v2 09/10] drm/tegra: Count number of display controllers at runtime

2021-03-26 Thread Thierry Reding
From: Thierry Reding In order to be able to attach planes to all possible display controllers the exact number of CRTCs must be known. Keep track of the number of the display controllers that register during initialization. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dc.c | 22 +++

[PATCH v2 10/10] drm/tegra: Support sector layout on Tegra194

2021-03-26 Thread Thierry Reding
From: Thierry Reding Tegra194 has a special physical address bit that enables some memory swizzling logic to support different sector layouts. Support the bit that selects the sector layout which is passed in the framebuffer modifier. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dc.

[PATCH v2 07/10] drm/tegra: gem: Add a clarifying comment

2021-03-26 Thread Thierry Reding
From: Thierry Reding Clarify when a fixed IOV address can be used and when a buffer has to be mapped before the IOVA can be used. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/plane.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/tegra/plane.c b/drivers/

Re: [PATCH v2 01/10] drm/fourcc: Add macros to determine the modifier vendor

2021-03-26 Thread Simon Ser
LGTM, thanks! Reviewed-by: Simon Ser Let me know if you need me to push this to drm-misc-next. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v5 01/21] gpu: host1x: Use different lock classes for each client

2021-03-26 Thread Mikko Perttunen
On 3/22/21 5:19 PM, Mikko Perttunen wrote: On 22.3.2021 16.48, Dmitry Osipenko wrote: 22.03.2021 17:46, Thierry Reding пишет: On Mon, Jan 11, 2021 at 02:59:59PM +0200, Mikko Perttunen wrote: To avoid false lockdep warnings, give each client lock a different lock class, passed from the initiali

Re: [PATCH] drm/amd/display: Try YCbCr420 color when YCbCr444 fails

2021-03-26 Thread Harry Wentland
On 2021-03-24 4:23 p.m., Alex Deucher wrote: On Wed, Mar 17, 2021 at 11:25 AM Werner Sembach wrote: When encoder validation of a display mode fails, retry with less bandwidth heavy YCbCr420 color mode, if available. This enables some HDMI 1.4 setups to support 4k60Hz output, which previous

Re: [Intel-gfx] [PATCH v5 1/2] drm/dp_helper: Define options for FRL training for HDMI2.1 PCON

2021-03-26 Thread Maxime Ripard
Hi, On Fri, Mar 26, 2021 at 11:47:58AM +0200, Jani Nikula wrote: > On Tue, 23 Mar 2021, Ankit Nautiyal wrote: > > Currently the FRL training mode (Concurrent, Sequential) and > > training type (Normal, Extended) are not defined properly and > > are passed as bool values in drm_helpers for pcon >

Re: [RFC PATCH 1/3] dt-bindings: display: simple: Add the panel on sc7180-trogdor-pompom

2021-03-26 Thread Rob Clark
On Fri, Mar 26, 2021 at 5:38 AM Thierry Reding wrote: > > On Wed, Mar 17, 2021 at 06:53:04PM -0700, Rob Clark wrote: > > On Wed, Mar 17, 2021 at 4:27 PM Matthias Kaehlcke wrote: > > > > > > On Tue, Mar 16, 2021 at 02:08:19PM -0700, Douglas Anderson wrote: > > > > The sc7180-trogdor-pompom board m

Re: [RFC PATCH 1/3] dt-bindings: display: simple: Add the panel on sc7180-trogdor-pompom

2021-03-26 Thread Rob Clark
On Fri, Mar 26, 2021 at 8:18 AM Rob Clark wrote: > > On Fri, Mar 26, 2021 at 5:38 AM Thierry Reding > wrote: > > > > On Wed, Mar 17, 2021 at 06:53:04PM -0700, Rob Clark wrote: > > > On Wed, Mar 17, 2021 at 4:27 PM Matthias Kaehlcke > > > wrote: > > > > > > > > On Tue, Mar 16, 2021 at 02:08:19P

Re: [PATCH v2 05/10] drm/tegra: dc: Implement hardware cursor on Tegra186 and later

2021-03-26 Thread Dmitry Osipenko
26.03.2021 17:51, Thierry Reding пишет: > From: Thierry Reding > > The hardware cursor on Tegra186 differs slightly from the implementation > on older SoC generations. In particular the new implementation relies on > software for clipping the cursor against the screen. Fortunately, atomic > KMS a

Re: [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-26 Thread Ville Syrjälä
On Thu, Mar 25, 2021 at 03:01:29PM -0700, Navare, Manasi wrote: > On Fri, Mar 19, 2021 at 11:27:59PM +0200, Ville Syrjälä wrote: > > On Fri, Mar 19, 2021 at 02:26:24PM -0700, Navare, Manasi wrote: > > > On Fri, Mar 19, 2021 at 11:12:41PM +0200, Ville Syrjälä wrote: > > > > On Fri, Mar 19, 2021 at 0

Re: [PATCH v2 01/10] drm/fourcc: Add macros to determine the modifier vendor

2021-03-26 Thread Thierry Reding
On Fri, Mar 26, 2021 at 02:54:22PM +, Simon Ser wrote: > LGTM, thanks! > > Reviewed-by: Simon Ser > > Let me know if you need me to push this to drm-misc-next. I do have commit access for drm-misc-next, but I was thinking that I could take this through the drm/tegra tree along with the subs

Re: [PATCH 6/9] drm/tegra: gem: Add a clarifying comment

2021-03-26 Thread Thierry Reding
On Wed, Mar 24, 2021 at 07:50:01PM +0300, Dmitry Osipenko wrote: > 24.03.2021 19:42, Thierry Reding пишет: > > On Wed, Mar 24, 2021 at 06:45:30PM +0300, Dmitry Osipenko wrote: > >> 24.03.2021 18:02, Thierry Reding пишет: > >>> On Wed, Mar 24, 2021 at 05:41:08PM +0300, Dmitry Osipenko wrote: >

Re: [PATCH] drm: Update MST First Link Slot Information Based on Encoding Format

2021-03-26 Thread Lyude Paul
On Thu, 2021-03-25 at 23:14 -0400, Fangzhi Zuo wrote: > 8b/10b encoding format requires to reserve the first slot for > recording metadata. Real data transmission starts from the second slot, > with a total of available 63 slots available. > > In 128b/132b encoding format, metadata is transmitted

Re: [RFC PATCH 1/3] dt-bindings: display: simple: Add the panel on sc7180-trogdor-pompom

2021-03-26 Thread Bjorn Andersson
On Fri 26 Mar 10:24 CDT 2021, Rob Clark wrote: > On Fri, Mar 26, 2021 at 8:18 AM Rob Clark wrote: > > > > On Fri, Mar 26, 2021 at 5:38 AM Thierry Reding > > wrote: > > > > > > On Wed, Mar 17, 2021 at 06:53:04PM -0700, Rob Clark wrote: > > > > On Wed, Mar 17, 2021 at 4:27 PM Matthias Kaehlcke

Re: [Freedreno] [PATCH v2 01/28] clk: fixed: add devm helper for clk_hw_register_fixed_factor()

2021-03-26 Thread abhinavk
Hi Dmitry On 2021-03-24 08:18, Dmitry Baryshkov wrote: From: Daniel Palmer Add a devm helper for clk_hw_register_fixed_factor() so that drivers that internally register fixed factor clocks for things like dividers don't need to manually unregister them on remove or if probe fails. Signed-off-

Re: [Freedreno] [PATCH v2 06/28] drm/msm/dsi: drop multiple pll enable_seq support

2021-03-26 Thread abhinavk
On 2021-03-24 08:18, Dmitry Baryshkov wrote: The only PLL using multiple enable sequences is the 28nm PLL, which just does the single step in the loop. Push that support back into the PLL code. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/phy/dsi_p

Re: [Freedreno] [PATCH v2 02/28] clk: mux: provide devm_clk_hw_register_mux()

2021-03-26 Thread abhinavk
On 2021-03-24 08:18, Dmitry Baryshkov wrote: Add devm_clk_hw_register_mux() - devres-managed version of clk_hw_register_mux(). Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/clk/clk-mux.c| 35 +++ include/linux/clk-provider.h |

Re: [Freedreno] [PATCH v2 03/28] clk: divider: add devm_clk_hw_register_divider

2021-03-26 Thread abhinavk
On 2021-03-24 08:18, Dmitry Baryshkov wrote: Add devm_clk_hw_register_divider() - devres version of clk_hw_register_divider(). Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- include/linux/clk-provider.h | 17 + 1 file changed, 17 insertions(+) diff --git a/i

Re: [Freedreno] [PATCH v2 07/28] drm/msm/dsi: move all PLL callbacks into PHY config struct

2021-03-26 Thread abhinavk
On 2021-03-24 08:18, Dmitry Baryshkov wrote: Move all PLL-related callbacks into struct msm_dsi_phy_cfg. This limits the amount of data in the struct msm_dsi_pll. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi.h | 6 -- drivers/gp

Re: [Freedreno] [PATCH v2 04/28] drm/msm/dsi: replace PHY's init callback with configurable data

2021-03-26 Thread abhinavk
On 2021-03-24 08:18, Dmitry Baryshkov wrote: DSI PHY init callback would either map dsi_phy_regulator or dsi_phy_lane depending on the PHY type. Replace those callbacks with configuration options governing mapping those regions. Signed-off-by: Dmitry Baryshkov This is a nice cleanup which wil

Re: [Freedreno] [PATCH v2 08/28] drm/msm/dsi: drop global msm_dsi_phy_type enumaration

2021-03-26 Thread abhinavk
On 2021-03-24 08:18, Dmitry Baryshkov wrote: With the current upstream driver the msm_dsi_phy_type enum does not make much sense: all DSI PHYs are probed using the dt bindings, the phy type is not passed between drivers. Use quirks in phy individual PHY drivers to differentiate minor harware dif

Re: [Freedreno] [PATCH v2 09/28] drm/msm/dsi: move min/max PLL rate to phy config

2021-03-26 Thread abhinavk
On 2021-03-24 08:18, Dmitry Baryshkov wrote: Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 3 +++ drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 6 -- drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 6 -- driv

Re: [Freedreno] [PATCH v2 10/28] drm/msm/dsi: remove msm_dsi_pll_set_usecase

2021-03-26 Thread abhinavk
On 2021-03-24 08:18, Dmitry Baryshkov wrote: msm_dsi_pll_set_usecase() function is not used outside of individual DSI PHY drivers, so drop it in favour of calling the the respective set_usecase functions directly. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/d

Re: [Freedreno] [PATCH v2 11/28] drm/msm/dsi: stop setting clock parents manually

2021-03-26 Thread abhinavk
Hi Dmitry On 2021-03-24 08:18, Dmitry Baryshkov wrote: There is no reason to set clock parents manually, use device tree to assign DSI/display clock parents to DSI PHY clocks. Dropping this manual setup allows us to drop repeating code and to move registration of hw clock providers to generic

Re: [pull] amdgpu, amdkfd, radeon drm-next-5.12

2021-03-26 Thread Daniel Vetter
On Thu, Feb 18, 2021 at 11:15 PM Alex Deucher wrote: > > Hi Dave, Daniel, > > Fixes for 5.12. > > The following changes since commit 4c3a3292730c56591472717d8c5c0faf74f6c6bb: > > drm/amd/display: fix unused variable warning (2021-02-05 09:49:44 +1000) > > are available in the Git repository at:

Re: [PATCH v2] drm/mst: Enhance MST topology logging

2021-03-26 Thread Brol, Eryk
[AMD Official Use Only - Internal Distribution Only] Hi Lyude, Yes, I would appreciate it if you could push this to drm-misc-next for me. Thank you for your comments and review! Best, Eryk From: Lyude Paul Sent: Thursday, March 25, 2021 6:30 PM To: Brol, Eryk ;

Re: [PATCH v5 01/21] gpu: host1x: Use different lock classes for each client

2021-03-26 Thread Dmitry Osipenko
26.03.2021 17:54, Mikko Perttunen пишет: > > Lockdep doesn't seem to be liking dev_name() for the name, and I think > allocating a string for this purpose seems a bit overkill, so I'll keep > the lock name as is if there are no objections. What does "liking" mean?

Re: [git pull] drm fixes for 5.12-rc5

2021-03-26 Thread pr-tracker-bot
The pull request you sent on Fri, 26 Mar 2021 13:34:03 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2021-03-26 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/f944d061f847b0ccf0ebc095b5a6ba9ea9caec4e Thank you! -- Deet-doot-dot, I am a bot. https://k

Re: [PATCH v5 01/21] gpu: host1x: Use different lock classes for each client

2021-03-26 Thread Mikko Perttunen
On 3/26/21 8:31 PM, Dmitry Osipenko wrote: 26.03.2021 17:54, Mikko Perttunen пишет: Lockdep doesn't seem to be liking dev_name() for the name, and I think allocating a string for this purpose seems a bit overkill, so I'll keep the lock name as is if there are no objections. What does "liking"

RE: [pull] amdgpu, amdkfd, radeon drm-next-5.12

2021-03-26 Thread Zhuo, Qingqing
[AMD Public Use] On Thu, Feb 18, 2021 at 11:15 PM Alex Deucher wrote: >> >> Hi Dave, Daniel, >> >> Fixes for 5.12. >> >> The following changes since commit 4c3a3292730c56591472717d8c5c0faf74f6c6bb: >> >> drm/amd/display: fix unused variable warning (2021-02-05 09:49:44 >> +1000) >> >> are avai

Re: [PATCH] drm/amdkfd: dqm fence memory corruption

2021-03-26 Thread Felix Kuehling
Am 2021-03-26 um 5:38 a.m. schrieb Qu Huang: > On 2021/1/28 5:50, Felix Kuehling wrote: >> Am 2021-01-27 um 7:33 a.m. schrieb Qu Huang: >>> Amdgpu driver uses 4-byte data type as DQM fence memory, >>> and transmits GPU address of fence memory to microcode >>> through query status PM4 message. Howev

Re: [RFC PATCH 1/3] dt-bindings: display: simple: Add the panel on sc7180-trogdor-pompom

2021-03-26 Thread Rob Herring
On Fri, Mar 26, 2021 at 9:20 AM Rob Clark wrote: > > On Fri, Mar 26, 2021 at 8:18 AM Rob Clark wrote: > > > > On Fri, Mar 26, 2021 at 5:38 AM Thierry Reding > > wrote: > > > > > > On Wed, Mar 17, 2021 at 06:53:04PM -0700, Rob Clark wrote: > > > > On Wed, Mar 17, 2021 at 4:27 PM Matthias Kaehlck

[PATCH] drm/amdgpu/display: fix merge breakage

2021-03-26 Thread Alex Deucher
Looks like this got accidently dropped. Fixes: 2cbcb78c9ee5 ("Merge tag 'amd-drm-next-5.13-2021-03-23' of https://gitlab.freedesktop.org/agd5f/linux into drm-next") Signed-off-by: Alex Deucher Cc: daniel.vet...@ffwll.ch --- drivers/gpu/drm/amd/display/dc/irq/dcn21/irq_service_dcn21.c | 4

Re: [PATCH] drm/amdgpu/display: fix merge breakage

2021-03-26 Thread Alex Deucher
Nevermind, I think I screwed this up locally. Alex On Fri, Mar 26, 2021 at 4:07 PM Alex Deucher wrote: > > Looks like this got accidently dropped. > > Fixes: 2cbcb78c9ee5 ("Merge tag 'amd-drm-next-5.13-2021-03-23' of > https://gitlab.freedesktop.org/agd5f/linux into drm-next") > Signed-off-by:

[Bug 212077] AMD GPU discrete card memory at highest frequency even while not in use

2021-03-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212077 --- Comment #14 from Bat Malin (bat_ma...@abv.bg) --- Thank you Alex for your engagement! Could you please include the patch in the next 5.11.11 release so I could test the patch, sorry but I am not allowed to compile a kernel on this machine. --

Re: [Freedreno] [PATCH v2 11/28] drm/msm/dsi: stop setting clock parents manually

2021-03-26 Thread Dmitry Baryshkov
On 26/03/2021 21:05, abhin...@codeaurora.org wrote: Hi Dmitry On 2021-03-24 08:18, Dmitry Baryshkov wrote: There is no reason to set clock parents manually, use device tree to assign DSI/display clock parents to DSI PHY clocks. Dropping this manual setup allows us to drop repeating code and to

[PATCH v2 00/20] drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers

2021-03-26 Thread Lyude Paul
Since it's been asked quite a few times on some of the various DP related patch series I've submitted to use the new DRM printk helpers, and it technically wasn't really trivial to do this before due to the lack of a consistent way to find a drm_device for an AUX channel, this patch series aims to

  1   2   >