Re: [PATCH v2 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg

2021-03-25 Thread Nautiyal, Ankit K
LGTM. Reviewed-by: Ankit Nautiyal On 3/24/2021 5:00 PM, Anshuman Gupta wrote: As documented in HDCP 2.2 DP Errata spec transmitter should abort the authentication protocol in case transmitter has not received the entire {AKE_Send_Cert, AKE_Send_H_prime, AKE_Send_Paring_Info} msg within {110,7,

Re: [PATCH] drm/imx: fix memory leak when fails to init

2021-03-25 Thread Philipp Zabel
On Wed, Jan 20, 2021 at 01:16:08AM -0800, Pan Bian wrote: > Put DRM device on initialization failure path rather than directly > return error code. > > Fixes: a67d5088ceb8 ("drm/imx: drop explicit drm_mode_config_cleanup") > Signed-off-by: Pan Bian Thank you, applied to imx-drm/fixes. regards P

Re: [PATCH] drm/imx: imx-ldb: Register LDB channel1 when it is the only channel to be used

2021-03-25 Thread Philipp Zabel
On Mon, Mar 22, 2021 at 10:56:40AM +0800, Liu Ying wrote: > LDB channel1 should be registered if it is the only channel to be used. > Without this patch, imx_ldb_bind() would skip registering LDB channel1 > if LDB channel0 is not used, no matter LDB channel1 needs to be used or > not. > > Fixes: 8

Re: [PATCH] [v3] drm/imx: imx-ldb: fix out of bounds array access warning

2021-03-25 Thread Philipp Zabel
On Thu, Mar 25, 2021 at 10:03:23AM +0800, Liu Ying wrote: > On Wed, 2021-03-24 at 17:47 +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > When CONFIG_OF is disabled, building with 'make W=1' produces warnings > > about out of bounds array access: > > > > drivers/gpu/drm/imx/imx-ldb.c:

Re: [PATCH v4 2/5] phy: Add LVDS configuration options

2021-03-25 Thread Vinod Koul
On 18-03-21, 10:22, Liu Ying wrote: > > Can we have these in kernel-doc style please, similar to style in > > linux/phy/phy.h > > I take this way of in-line member documentation comment for the below 3 > reasons: > > 1) Members of struct phy_configure_opts_mipi_dphy and > struct phy_configure_o

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-25 Thread Intel
On 3/25/21 12:14 AM, Jason Gunthorpe wrote: On Wed, Mar 24, 2021 at 09:07:53PM +0100, Thomas Hellström (Intel) wrote: On 3/24/21 7:31 PM, Christian König wrote: Am 24.03.21 um 17:38 schrieb Jason Gunthorpe: On Wed, Mar 24, 2021 at 04:50:14PM +0100, Thomas Hellström (Intel) wrote: On 3/24/21

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-25 Thread Christian König
Am 25.03.21 um 00:14 schrieb Jason Gunthorpe: On Wed, Mar 24, 2021 at 09:07:53PM +0100, Thomas Hellström (Intel) wrote: On 3/24/21 7:31 PM, Christian König wrote: Am 24.03.21 um 17:38 schrieb Jason Gunthorpe: On Wed, Mar 24, 2021 at 04:50:14PM +0100, Thomas Hellström (Intel) wrote: On 3/24/2

[Bug 212425] Kernel warning at drivers/gpu/drm/ttm/ttm_bo.c:517

2021-03-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212425 --- Comment #3 from Christian König (christian.koe...@amd.com) --- Yeah, Alex is right this patch should have never been backported in the first place. -- You may reply to this email to add a comment. You are receiving this mail because: You ar

Re: [PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning

2021-03-25 Thread Jani Nikula
On Mon, 22 Mar 2021, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 warns that intel_dp_check_mst_status() has a local array of > fourteen bytes and passes the last four bytes into a function that > expects a six-byte array: > > drivers/gpu/drm/i915/display/intel_dp.c: In function > ‘inte

Re: [PATCH] drm/ttm: switch back to static allocation limits for now

2021-03-25 Thread Christian König
Am 24.03.21 um 20:29 schrieb Daniel Vetter: On Wed, Mar 24, 2021 at 02:48:45PM +0100, Christian König wrote: The shrinker based approach still has some flaws. Especially that we need temporary pages to free up the pages allocated to the driver is problematic in a shrinker. Signed-off-by: Christ

Re: [PATCH v3 14/15] media: venus: Convert to use resource-managed OPP API

2021-03-25 Thread Stanimir Varbanov
Hi, On 3/14/21 6:34 PM, Dmitry Osipenko wrote: > From: Yangtao Li > > Use resource-managed OPP API to simplify code. > > Signed-off-by: Yangtao Li > Signed-off-by: Dmitry Osipenko > --- > drivers/media/platform/qcom/venus/core.h | 1 - > .../media/platform/qcom/venus/pm_helpers.c|

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-25 Thread Christian König
Am 25.03.21 um 08:48 schrieb Thomas Hellström (Intel): On 3/25/21 12:14 AM, Jason Gunthorpe wrote: On Wed, Mar 24, 2021 at 09:07:53PM +0100, Thomas Hellström (Intel) wrote: On 3/24/21 7:31 PM, Christian König wrote: Am 24.03.21 um 17:38 schrieb Jason Gunthorpe: On Wed, Mar 24, 2021 at 04:50

Re: WARNING: AMDGPU DRM warning in 5.11.9

2021-03-25 Thread Christian König
Hi, Am 25.03.21 um 09:17 schrieb Oleksandr Natalenko: Hello. On Thu, Mar 25, 2021 at 07:57:33AM +0200, Ilkka Prusi wrote: On 24.3.2021 16.16, Chris Rankin wrote: Hi, Theee warnings ares not present in my dmesg log from 5.11.8: [ 43.390159] [ cut here ] [ 43.39357

Re: [PATCH] drm/ttm: switch back to static allocation limits for now

2021-03-25 Thread Daniel Vetter
On Thu, Mar 25, 2021 at 9:07 AM Christian König wrote: > > Am 24.03.21 um 20:29 schrieb Daniel Vetter: > > On Wed, Mar 24, 2021 at 02:48:45PM +0100, Christian König wrote: > >> The shrinker based approach still has some flaws. Especially that we need > >> temporary pages to free up the pages alloc

linux-next: please do not base your tree on v5.12-rc1-dontuse

2021-03-25 Thread Stephen Rothwell
Hi all, The latest version of the drm-misc tree consists of just 2 commits on top of Linus' v5.12-rc1-dontuse tag. -- Cheers, Stephen Rothwell pgp7PGU4oMTWd.pgp Description: OpenPGP digital signature ___ dri-devel mailing list dri-devel@lists.freedes

[PATCH] drm/amd/amdgpu/gfx_v7_0: Trivial typo fixes

2021-03-25 Thread Bhaskar Chowdhury
s/acccess/access/ s/inferface/interface/ s/sequnce/sequence/ .two different places. s/retrive/retrieve/ s/sheduling/scheduling/ s/independant/independent/ s/wether/whether/ ..two different places. s/emmit/emit/ s/synce/sync/ Signed-off-by: Bhaskar Chowdhury --- drivers/gpu/drm/amd/amdg

Re: [PATCH] drivers: gpu: drm: Remove duplicate declaration

2021-03-25 Thread Laurent Pinchart
Hi Wan, Thank you for the patch. On Thu, Mar 25, 2021 at 12:50:19PM +0800, Wan Jiabing wrote: > struct dss_device has been declared at 51st line. > Remove the duplicate. > > Signed-off-by: Wan Jiabing > --- > drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 - > 1 file changed, 1 deletion(-) > > di

Re: [PATCH v3 14/15] media: venus: Convert to use resource-managed OPP API

2021-03-25 Thread Viresh Kumar
On 25-03-21, 10:13, Stanimir Varbanov wrote: > Hi, > > On 3/14/21 6:34 PM, Dmitry Osipenko wrote: > > From: Yangtao Li > > > > Use resource-managed OPP API to simplify code. > > > > Signed-off-by: Yangtao Li > > Signed-off-by: Dmitry Osipenko > > --- > > drivers/media/platform/qcom/venus/cor

[PATCH v5 0/5] phy: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2021-03-25 Thread Liu Ying
Hi, This series adds i.MX8qxp LVDS PHY mode support for the Mixel PHY in the Freescale i.MX8qxp SoC. The Mixel PHY is MIPI DPHY + LVDS PHY combo, which can works in either MIPI DPHY mode or LVDS PHY mode. The PHY mode is controlled by i.MX8qxp SCU firmware. The PHY driver would call a SCU funct

[PATCH v5 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_enable()

2021-03-25 Thread Liu Ying
The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp works with a Mixel MIPI DPHY + LVDS PHY combo to support either a MIPI DSI display or a LVDS display. So, this patch calls phy_set_mode() from nwl_dsi_enable() to set PHY mode to MIPI DPHY explicitly. Cc: Guido Günther Cc: Robert

[PATCH v5 2/5] phy: Add LVDS configuration options

2021-03-25 Thread Liu Ying
This patch allows LVDS PHYs to be configured through the generic functions and through a custom structure added to the generic union. The parameters added here are based on common LVDS PHY implementation practices. The set of parameters should cover all potential users. Cc: Kishon Vijay Abraham

[PATCH v5 3/5] dt-bindings: phy: Convert mixel, mipi-dsi-phy to json-schema

2021-03-25 Thread Liu Ying
This patch converts the mixel,mipi-dsi-phy binding to DT schema format using json-schema. Comparing to the plain text version, the new binding adds the 'assigned-clocks', 'assigned-clock-parents' and 'assigned-clock-rates' properites, otherwise 'make dtbs_check' would complain that there are mis-m

[PATCH v5 4/5] dt-bindings: phy: mixel: mipi-dsi-phy: Add Mixel combo PHY support for i.MX8qxp

2021-03-25 Thread Liu Ying
Add support for Mixel MIPI DPHY + LVDS PHY combo IP as found on Freescale i.MX8qxp SoC. Cc: Guido Günther Cc: Kishon Vijay Abraham I Cc: Vinod Koul Cc: Rob Herring Cc: NXP Linux Team Reviewed-by: Rob Herring Reviewed-by: Guido Günther Signed-off-by: Liu Ying --- v4->v5: * No change. v3->v

[PATCH v5 5/5] phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2021-03-25 Thread Liu Ying
i.MX8qxp SoC embeds a Mixel MIPI DPHY + LVDS PHY combo which supports either a MIPI DSI display or a LVDS display. The PHY mode is controlled by SCU firmware and the driver would call a SCU firmware function to configure the PHY mode. The single LVDS PHY has 4 data lanes to support a LVDS display

Re: [PATCH] drivers: gpu: drm: xen_drm_front_drm_info is declared twice

2021-03-25 Thread Daniel Vetter
On Thu, Mar 25, 2021 at 7:53 AM Oleksandr Andrushchenko wrote: > > Hi, > > On 3/25/21 8:19 AM, Wan Jiabing wrote: > > struct xen_drm_front_drm_info has been declared. > > Remove the duplicate. > > > > Signed-off-by: Wan Jiabing > > Thank you for the patch, > > Reviewed-by: Oleksandr Andrushchenko

Re: linux-next: please do not base your tree on v5.12-rc1-dontuse

2021-03-25 Thread Daniel Vetter
On Thu, Mar 25, 2021 at 9:48 AM Stephen Rothwell wrote: > > Hi all, > > The latest version of the drm-misc tree consists of just 2 commits on > top of Linus' v5.12-rc1-dontuse tag. Yeah committer pushed patches to the wrong tree, which meant you get the wrong tree. We'll fix for tomorrow. -Daniel

Re: [PATCH] drivers: gpu: drm: xen_drm_front_drm_info is declared twice

2021-03-25 Thread Daniel Vetter
On Thu, Mar 25, 2021 at 10:16 AM Daniel Vetter wrote: > > On Thu, Mar 25, 2021 at 7:53 AM Oleksandr Andrushchenko > wrote: > > > > Hi, > > > > On 3/25/21 8:19 AM, Wan Jiabing wrote: > > > struct xen_drm_front_drm_info has been declared. > > > Remove the duplicate. > > > > > > Signed-off-by: Wan J

Re: [PATCH] drm/amd/amdgpu/gfx_v7_0: Trivial typo fixes

2021-03-25 Thread Nirmoy
Reviewed-by: Nirmoy Das On 3/25/21 9:53 AM, Bhaskar Chowdhury wrote: s/acccess/access/ s/inferface/interface/ s/sequnce/sequence/ .two different places. s/retrive/retrieve/ s/sheduling/scheduling/ s/independant/independent/ s/wether/whether/ ..two different places. s/emmit/emit/ s/syn

Re: [PATCH] drm/ttm: switch back to static allocation limits for now

2021-03-25 Thread Christian König
Am 25.03.21 um 09:31 schrieb Daniel Vetter: On Thu, Mar 25, 2021 at 9:07 AM Christian König wrote: Am 24.03.21 um 20:29 schrieb Daniel Vetter: On Wed, Mar 24, 2021 at 02:48:45PM +0100, Christian König wrote: The shrinker based approach still has some flaws. Especially that we need temporary p

Re: [PATCH v5 1/6] mfd: rt4831: Adds support for Richtek RT4831 core

2021-03-25 Thread ChiYuan Huang
HI, Lee: ChiYuan Huang 於 2021年1月13日 週三 下午10:09寫道: > > Lee Jones 於 2021年1月13日 週三 下午8:21寫道: > > > > On Thu, 17 Dec 2020, cy_huang wrote: > > > > > From: ChiYuan Huang > > > > > > This adds support Richtek RT4831 core. It includes four channel WLED > > > driver > > > and Display Bias Voltage outp

Re: [PATCH v5 5/6] backlight: rt4831: Adds support for Richtek RT4831 backlight

2021-03-25 Thread ChiYuan Huang
Dear reviewers: Didn't get any response about this backlight patch. Is there any part need to be refined? cy_huang 於 2020年12月17日 週四 下午11:01寫道: > > From: ChiYuan Huang > > Adds support for Richtek RT4831 backlight. > > Signed-off-by: ChiYuan Huang > --- > drivers/video/backlight/Kco

[PATCH] drm/virtio: check the return value of virtio_gpu_alloc_cmd_resp()

2021-03-25 Thread Liu Xiang
Now there is no check with the return value of virtio_gpu_alloc_cmd_resp(). If it fails, the following operation will cause a fault. Signed-off-by: Liu Xiang --- drivers/gpu/drm/virtio/virtgpu_vq.c | 89 + 1 file changed, 89 insertions(+) diff --git a/drivers/gpu/drm

Re: [PATCH 03/11] security: commoncap: fix -Wstringop-overread warning

2021-03-25 Thread James Morris
On Mon, 22 Mar 2021, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 introdces a harmless warning for cap_inode_getsecurity: > > security/commoncap.c: In function ‘cap_inode_getsecurity’: > security/commoncap.c:440:33: error: ‘memcpy’ reading 16 bytes from a region > of size 0 [-Werror=s

Re: [PATCH 00/25] Rid W=1 warnings from HID

2021-03-25 Thread Srinivas Pandruvada
On Wed, 2021-03-24 at 17:33 +, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > For changes in drivers/hid/intel-ish-hid folder Acked-by: Srinivas Pandruvada > Lee

[PATCH] drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v8.

2021-03-25 Thread Maarten Lankhorst
Instead of doing what we do currently, which will never work with PROVE_LOCKING, do the same as AMD does, and something similar to relocation slowpath. When all locks are dropped, we acquire the pages for pinning. When the locks are taken, we transfer those pages in .get_pages() to the bo. As a fin

[PULL] drm-intel-fixes

2021-03-25 Thread Rodrigo Vivi
Hi Dave and Daniel, with GT fence revocation runtime PM logic targeting 4.12+ stable, here goes drm-intel-fixes-2021-03-25-1: - DisplayPort LTTPR fixes around link training and limiting it according to supported spec version. (Imre) - Fix enabled_planes bitmask to really represent only logicall

Re: [PATCH v4 2/5] phy: Add LVDS configuration options

2021-03-25 Thread Liu Ying
Hi Vinod, On Thu, 2021-03-25 at 12:58 +0530, Vinod Koul wrote: > On 18-03-21, 10:22, Liu Ying wrote: > > > > Can we have these in kernel-doc style please, similar to style in > > > linux/phy/phy.h > > > > I take this way of in-line member documentation comment for the below 3 > > reasons: > >

Re: [PATCH] drm/ttm: switch back to static allocation limits for now

2021-03-25 Thread Daniel Vetter
On Thu, Mar 25, 2021 at 10:27 AM Christian König wrote: > > Am 25.03.21 um 09:31 schrieb Daniel Vetter: > > On Thu, Mar 25, 2021 at 9:07 AM Christian König > > wrote: > >> Am 24.03.21 um 20:29 schrieb Daniel Vetter: > >>> On Wed, Mar 24, 2021 at 02:48:45PM +0100, Christian König wrote: > The

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-25 Thread Daniel Vetter
On Thu, Mar 25, 2021 at 8:50 AM Christian König wrote: > > Am 25.03.21 um 00:14 schrieb Jason Gunthorpe: > > On Wed, Mar 24, 2021 at 09:07:53PM +0100, Thomas Hellström (Intel) wrote: > >> On 3/24/21 7:31 PM, Christian König wrote: > >>> > >>> Am 24.03.21 um 17:38 schrieb Jason Gunthorpe: > On

Re: [PATCH 2/2] drm/doc: Add RFC section

2021-03-25 Thread Simon Ser
Acked-by: Simon Ser ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PULL] drm-misc-next

2021-03-25 Thread Maxime Ripard
Hi Dave, Daniel, It's still a fairly quiet week, but here's this week's drm-misc-next PR maxime drm-misc-next-2021-03-25: drm-misc-next for 5.13: UAPI Changes: - New USB connector type Cross-subsystem Changes: Core Changes: - ttm: Introduce a per-device LRU lock, remove swap LRU Driver C

Re: [Intel-gfx] [PATCH] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v2)

2021-03-25 Thread Tvrtko Ursulin
On 24/03/2021 17:18, Jason Ekstrand wrote: On Wed, Mar 24, 2021 at 6:36 AM Tvrtko Ursulin wrote: On 24/03/2021 09:52, Daniel Vetter wrote: On Wed, Mar 24, 2021 at 09:28:58AM +, Tvrtko Ursulin wrote: On 23/03/2021 17:51, Jason Ekstrand wrote: This API is entirely unnecessary and I'd

RE: [PATCH v3] drm/scheduler re-insert Bailing job to avoid memleak

2021-03-25 Thread Zhang, Jack (Jian)
[AMD Official Use Only - Internal Distribution Only] Hi, Andrey Thank you for your good opinions. I literally agree with you that the refcount could solve the get_clean_up_up cocurrent job gracefully, and no need to re-insert the job back anymore. I quickly made a draft for this idea as follows

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-25 Thread Intel
On 3/25/21 9:27 AM, Christian König wrote: Am 25.03.21 um 08:48 schrieb Thomas Hellström (Intel): On 3/25/21 12:14 AM, Jason Gunthorpe wrote: On Wed, Mar 24, 2021 at 09:07:53PM +0100, Thomas Hellström (Intel) wrote: On 3/24/21 7:31 PM, Christian König wrote: Am 24.03.21 um 17:38 schrieb Ja

Re: [PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning

2021-03-25 Thread Arnd Bergmann
On Thu, Mar 25, 2021 at 9:05 AM Jani Nikula wrote: > > Clearly something is wrong here, but I can't quite figure out what. > > Changing the array size to 16 bytes avoids the warning, but is > > probably the wrong solution here. > > Ugh. drm_dp_channel_eq_ok() does not actually require more than >

Re: [Intel-gfx] [PATCH] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v2)

2021-03-25 Thread Daniel Vetter
On Thu, Mar 25, 2021 at 10:48 AM Tvrtko Ursulin wrote: > > > On 24/03/2021 17:18, Jason Ekstrand wrote: > > On Wed, Mar 24, 2021 at 6:36 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 24/03/2021 09:52, Daniel Vetter wrote: > >>> On Wed, Mar 24, 2021 at 09:28:58AM +, Tvrtko Ursulin wrote: > >>

Re: [PATCH] drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v8.

2021-03-25 Thread Intel
On 3/25/21 10:23 AM, Maarten Lankhorst wrote: Instead of doing what we do currently, which will never work with PROVE_LOCKING, do the same as AMD does, and something similar to relocation slowpath. When all locks are dropped, we acquire the pages for pinning. When the locks are taken, we transf

Re: [PATCH] drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v8.

2021-03-25 Thread Daniel Vetter
On Thu, Mar 25, 2021 at 10:55:11AM +0100, Thomas Hellström (Intel) wrote: > > On 3/25/21 10:23 AM, Maarten Lankhorst wrote: > > Instead of doing what we do currently, which will never work with > > PROVE_LOCKING, do the same as AMD does, and something similar to > > relocation slowpath. When all l

Re: [PATCH] drivers: gpu: drm: xen_drm_front_drm_info is declared twice

2021-03-25 Thread Oleksandr Andrushchenko
Hi, On 3/25/21 8:19 AM, Wan Jiabing wrote: > struct xen_drm_front_drm_info has been declared. > Remove the duplicate. > > Signed-off-by: Wan Jiabing Thank you for the patch, Reviewed-by: Oleksandr Andrushchenko Will apply to drm-misc-next-fixes Thank you, Oleksandr > --- > drivers/gpu/dr

Re: [PATCH] gpu/xen: Fix a use after free in xen_drm_drv_init

2021-03-25 Thread Oleksandr Andrushchenko
Hi, good catch On 3/23/21 3:46 AM, Lv Yunlong wrote: > In function displback_changed, has the call chain > displback_connect(front_info)->xen_drm_drv_init(front_info). > We can see that drm_info is assigned to front_info->drm_info > and drm_info is freed in fail branch in xen_drm_drv_init(). > >

[PATCH] [v2] drivers: gpu: drm: Remove duplicate declaration

2021-03-25 Thread Wan Jiabing
struct dss_device has been declared. Remove the duplicate. And sort these forward declarations alphabetically. Signed-off-by: Wan Jiabing --- Changelog: v2: - Sort forward declarations alphabetically. --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 9 - 1 file changed, 4 insertions(+), 5 del

[PATCH AUTOSEL 5.11 39/44] nouveau: Skip unvailable ttm page entries

2021-03-25 Thread Sasha Levin
From: Tobias Klausmann [ Upstream commit e94c55b8e0a0bbe9a026250cf31e2fa45957d776 ] Starting with commit f295c8cfec833c2707ff1512da10d65386dde7af ("drm/nouveau: fix dma syncing warning with debugging on.") the following oops occures: BUG: kernel NULL pointer dereference, address: 000

Re: [PATCH v2 00/10] drm: Support simple-framebuffer devices and firmware fbs

2021-03-25 Thread Hans de Goede
Hi, On 3/18/21 11:29 AM, Thomas Zimmermann wrote: > This patchset adds support for simple-framebuffer platform devices and > a handover mechanism for native drivers to take-over control of the > hardware. > > The new driver, called simpledrm, binds to a simple-frambuffer platform > device. The ke

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-25 Thread Jason Gunthorpe
On Thu, Mar 25, 2021 at 10:51:35AM +0100, Thomas Hellström (Intel) wrote: > > Please explain that further. Why do we need the mmap lock to insert PMDs > > but not when insert PTEs? > > We don't. But once you've inserted a PMD directory you can't remove it > unless you have the mmap lock (and prob

[PATCH] drm/tegra: Remove useless error message

2021-03-25 Thread Tian Tao
Fix the following coccicheck report: drivers/gpu/drm/tegra/dpaux.c:471:2-9: line 471 is redundant because platform_get_irq() already prints an error drivers/gpu/drm/tegra/sor.c:3793:2-9: line 3793 is redundant because platform_get_irq() already prints an error Remove dev_err() messages after plat

[PULL] drm-misc-fixes

2021-03-25 Thread Maarten Lankhorst
drm-misc-fixes-2021-03-25: drm-misc-fixes for v5.12: - Use FOLL_FORCE and FOLL_LONGTERM in etnaviv The following changes since commit 6909115442759efef3d4bc5d9c54d7943f1afc14: drm/omap: dsi: fix unsigned expression compared with zero (2021-03-17 13:59:23 +0200) are available in the Git reposit

[PATCH 1/2] drm/i915/display/vlv_dsi: Do not skip panel_pwr_cycle_delay when disabling the panel

2021-03-25 Thread Hans de Goede
After the recently added commit fe0f1e3bfdfe ("drm/i915: Shut down displays gracefully on reboot"), the DSI panel on a Cherry Trail based Predia Basic tablet would no longer properly light up after reboot. I've managed to reproduce this without rebooting by doing: chvt 3; echo 1 > /sys/class/graph

[PATCH 2/2] drm/i915/display/vlv_dsi: Move panel_pwr_cycle_delay to next panel-on

2021-03-25 Thread Hans de Goede
Instead of sleeping panel_pwr_cycle_delay ms when turning the panel off, record the time it is turned off and if necessary wait any (remaining) time when the panel is turned on again. Also sleep the remaining time on shutdown, because on reboot the GOP will immediately turn on the panel again. Cc

Re: [PATCH v5 5/6] backlight: rt4831: Adds support for Richtek RT4831 backlight

2021-03-25 Thread Daniel Thompson
On Thu, Dec 17, 2020 at 11:00:43PM +0800, cy_huang wrote: > From: ChiYuan Huang > > Adds support for Richtek RT4831 backlight. > > Signed-off-by: ChiYuan Huang Looks ok but there are a few minor niggles. > --- > drivers/video/backlight/Kconfig| 8 ++ > drivers/video/backlight/Ma

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-25 Thread Intel
On 3/25/21 12:30 PM, Jason Gunthorpe wrote: On Thu, Mar 25, 2021 at 10:51:35AM +0100, Thomas Hellström (Intel) wrote: Please explain that further. Why do we need the mmap lock to insert PMDs but not when insert PTEs? We don't. But once you've inserted a PMD directory you can't remove it unles

Re: [PATCH v5 5/6] backlight: rt4831: Adds support for Richtek RT4831 backlight

2021-03-25 Thread Daniel Thompson
On Thu, Mar 25, 2021 at 04:22:11PM +0800, ChiYuan Huang wrote: > Dear reviewers: > >Didn't get any response about this backlight patch. > Is there any part need to be refined? Thanks for the reminders and sorry for the delay. Have just replied to the original message! Daniel. __

Re: [PATCH] drm/vkms: fix misuse of WARN_ON

2021-03-25 Thread Melissa Wen
On 03/25, Dmitry Vyukov wrote: > On Wed, Mar 24, 2021 at 11:00 PM Melissa Wen wrote: > > > > On 03/20, Dmitry Vyukov wrote: > > > vkms_vblank_simulate() uses WARN_ON for timing-dependent condition > > > (timer overrun). This is a mis-use of WARN_ON, WARN_ON must be used > > > to denote kernel bugs

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-25 Thread Jason Gunthorpe
On Thu, Mar 25, 2021 at 12:53:15PM +0100, Thomas Hellström (Intel) wrote: > Nope. The point here was that in this case, to make sure mmap uses the > correct VA to give us a reasonable chance of alignement, the driver might > need to be aware of and do trickery with the huge page-table-entry sizes

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-25 Thread Christian König
Am 25.03.21 um 13:01 schrieb Jason Gunthorpe: On Thu, Mar 25, 2021 at 12:53:15PM +0100, Thomas Hellström (Intel) wrote: Nope. The point here was that in this case, to make sure mmap uses the correct VA to give us a reasonable chance of alignement, the driver might need to be aware of and do tri

[PATCH] drm/etnaviv: Remove useless error message

2021-03-25 Thread Tian Tao
Fix the following coccicheck report: drivers/gpu/drm/etnaviv/etnaviv_gpu.c:1775:2-9: line 1775 is redundant because platform_get_irq() already prints an error Remove dev_err() messages after platform_get_irq() failures. Signed-off-by: Tian Tao Signed-off-by: Zihao Tang Signed-off-by: Jay Fang

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-25 Thread Intel
On 3/25/21 1:09 PM, Christian König wrote: Am 25.03.21 um 13:01 schrieb Jason Gunthorpe: On Thu, Mar 25, 2021 at 12:53:15PM +0100, Thomas Hellström (Intel) wrote: Nope. The point here was that in this case, to make sure mmap uses the correct VA to give us a reasonable chance of alignement, t

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-25 Thread Jason Gunthorpe
On Thu, Mar 25, 2021 at 01:09:14PM +0100, Christian König wrote: > Am 25.03.21 um 13:01 schrieb Jason Gunthorpe: > > On Thu, Mar 25, 2021 at 12:53:15PM +0100, Thomas Hellström (Intel) wrote: > > > > > Nope. The point here was that in this case, to make sure mmap uses the > > > correct VA to give u

Re: [PATCH 1/2] drm/mediatek: Switch the hdmi bridge ops to the atomic versions

2021-03-25 Thread Dafna Hirschfeld
Hi, On 25.03.21 11:43, Enric Balletbo i Serra wrote: Hi Dafna, Thank you for your patch. It'd be nice if you can cc the linux-mediatek ML for next version, so Mediatek people is more aware of this change. IMHO cc'ing the lkml is also a good practice. ok, I added all the mails from get_maintai

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-25 Thread Christian König
Am 25.03.21 um 13:36 schrieb Thomas Hellström (Intel): On 3/25/21 1:09 PM, Christian König wrote: Am 25.03.21 um 13:01 schrieb Jason Gunthorpe: On Thu, Mar 25, 2021 at 12:53:15PM +0100, Thomas Hellström (Intel) wrote: Nope. The point here was that in this case, to make sure mmap uses the

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-25 Thread Christian König
Am 25.03.21 um 13:42 schrieb Jason Gunthorpe: On Thu, Mar 25, 2021 at 01:09:14PM +0100, Christian König wrote: Am 25.03.21 um 13:01 schrieb Jason Gunthorpe: On Thu, Mar 25, 2021 at 12:53:15PM +0100, Thomas Hellström (Intel) wrote: Nope. The point here was that in this case, to make sure mma

Re: [PATCH] [v2] drivers: gpu: drm: Remove duplicate declaration

2021-03-25 Thread Laurent Pinchart
Hi Wan, Thank you for the patch. On Thu, Mar 25, 2021 at 07:10:24PM +0800, Wan Jiabing wrote: > struct dss_device has been declared. Remove the duplicate. > And sort these forward declarations alphabetically. > > Signed-off-by: Wan Jiabing Reviewed-by: Laurent Pinchart Tomi, I assume you'll

[PATCH] MAINTAINERS: Add linux-mediatek ML for drm Mediatek drivers

2021-03-25 Thread Dafna Hirschfeld
Add the linux-mediatek mailing list to drm Mediatek drivers Signed-off-by: Dafna Hirschfeld --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9e876927c60d..8260bc5afe66 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5963,6 +5963,7 @@ DRM DRIVERS

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-25 Thread Jason Gunthorpe
On Thu, Mar 25, 2021 at 02:05:14PM +0100, Christian König wrote: > > > Am 25.03.21 um 13:42 schrieb Jason Gunthorpe: > > On Thu, Mar 25, 2021 at 01:09:14PM +0100, Christian König wrote: > > > Am 25.03.21 um 13:01 schrieb Jason Gunthorpe: > > > > On Thu, Mar 25, 2021 at 12:53:15PM +0100, Thomas He

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-25 Thread Christian König
Am 25.03.21 um 14:17 schrieb Jason Gunthorpe: On Thu, Mar 25, 2021 at 02:05:14PM +0100, Christian König wrote: Am 25.03.21 um 13:42 schrieb Jason Gunthorpe: On Thu, Mar 25, 2021 at 01:09:14PM +0100, Christian König wrote: Am 25.03.21 um 13:01 schrieb Jason Gunthorpe: On Thu, Mar 25, 2021 at

Re: [PATCH] drivers: gpu: drm: xen_drm_front_drm_info is declared twice

2021-03-25 Thread Oleksandr Andrushchenko
Hi, Daniel! On 3/25/21 11:16 AM, Daniel Vetter wrote: > On Thu, Mar 25, 2021 at 7:53 AM Oleksandr Andrushchenko > wrote: >> Hi, >> >> On 3/25/21 8:19 AM, Wan Jiabing wrote: >>> struct xen_drm_front_drm_info has been declared. >>> Remove the duplicate. >>> >>> Signed-off-by: Wan Jiabing >> Thank

Re: [PATCH v2] video: hyperv_fb: Fix a double free in hvfb_probe

2021-03-25 Thread Wei Liu
On Wed, Mar 24, 2021 at 01:46:39PM +, Michael Kelley wrote: > From: Lv Yunlong Sent: Wednesday, March 24, 2021 > 3:37 AM > > > > In function hvfb_probe in hyperv_fb.c, it calls hvfb_getmem(hdev, info) > > and return err when info->apertures is freed. > > > > In the error1 label of hvfb_prob

Re: WARNING: AMDGPU DRM warning in 5.11.9

2021-03-25 Thread Oleksandr Natalenko
Hello. On Thu, Mar 25, 2021 at 07:57:33AM +0200, Ilkka Prusi wrote: > On 24.3.2021 16.16, Chris Rankin wrote: > > Hi, > > > > Theee warnings ares not present in my dmesg log from 5.11.8: > > > > [ 43.390159] [ cut here ] > > [ 43.393574] WARNING: CPU: 2 PID: 1268 at >

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-25 Thread Intel
Hi, On 3/25/21 2:02 PM, Christian König wrote: Am 25.03.21 um 13:36 schrieb Thomas Hellström (Intel): On 3/25/21 1:09 PM, Christian König wrote: Am 25.03.21 um 13:01 schrieb Jason Gunthorpe: On Thu, Mar 25, 2021 at 12:53:15PM +0100, Thomas Hellström (Intel) wrote: Nope. The point here wa

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-25 Thread Jason Gunthorpe
On Thu, Mar 25, 2021 at 02:26:50PM +0100, Christian König wrote: > Am 25.03.21 um 14:17 schrieb Jason Gunthorpe: > > On Thu, Mar 25, 2021 at 02:05:14PM +0100, Christian König wrote: > > > > > > Am 25.03.21 um 13:42 schrieb Jason Gunthorpe: > > > > On Thu, Mar 25, 2021 at 01:09:14PM +0100, Christia

Re: [Intel-gfx] [PATCH v2 0/2] HDCP 2.2 DP errata

2021-03-25 Thread Jani Nikula
On Wed, 24 Mar 2021, Anshuman Gupta wrote: > HDCP DP 2.2 errata is part of HDCP DP 2.3 specs > as well. > > Anshuman Gupta (2): > drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg > drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16 > > drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 45 ++

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-25 Thread Christian König
Am 25.03.21 um 14:33 schrieb Jason Gunthorpe: On Thu, Mar 25, 2021 at 02:26:50PM +0100, Christian König wrote: Am 25.03.21 um 14:17 schrieb Jason Gunthorpe: On Thu, Mar 25, 2021 at 02:05:14PM +0100, Christian König wrote: Am 25.03.21 um 13:42 schrieb Jason Gunthorpe: On Thu, Mar 25, 2021 at 0

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-25 Thread Jason Gunthorpe
On Thu, Mar 25, 2021 at 02:54:31PM +0100, Christian König wrote: > > The goal is to optimize large page size usage in the page tables. > > > > There are three critera that impact this: > > 1) The possible CPU page table sizes > > 2) The useful contiguity the device can create in its iomemory

[Bug 203905] amdgpu:actual_brightness has unreal/wrong value

2021-03-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203905 --- Comment #26 from Paulo Nascimento (paulo.ul...@googlemail.com) --- laptop: Lenovo Legion 5, amd ryzen 5 4600h Graphics: Device-1: NVIDIA TU116M [GeForce GTX 1660 Ti Mobile] driver: nouveau Device-2: Advanced Micro Devices [AMD/ATI]

[Bug 203905] amdgpu:actual_brightness has unreal/wrong value

2021-03-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203905 --- Comment #27 from kurmi...@libero.it --- For me the only workaround to avoid this bug is disabling systemd backlight restoration. Then use brillo and enable a specific service to restore the brightness at startup. -- You may reply to this ema

[Bug 212425] Kernel warning at drivers/gpu/drm/ttm/ttm_bo.c:517

2021-03-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212425 --- Comment #4 from Alex Deucher (alexdeuc...@gmail.com) --- Reverted in stable: commit bec771b5e0901f4b0bc861bcb58056de5151ae3a Author: Greg Kroah-Hartman Date: Thu Mar 25 09:52:40 2021 +0100 Revert "drm/ttm: Warn on pinning without hold

[Bug 212427] [AMDGPU] Multiple ttm_bo_release warnings

2021-03-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212427 --- Comment #3 from Alex Deucher (alexdeuc...@gmail.com) --- Reverted in stable: commit bec771b5e0901f4b0bc861bcb58056de5151ae3a Author: Greg Kroah-Hartman Date: Thu Mar 25 09:52:40 2021 +0100 Revert "drm/ttm: Warn on pinning without hold

Re: [PATCH v5 1/6] mfd: rt4831: Adds support for Richtek RT4831 core

2021-03-25 Thread Lee Jones
On Thu, 25 Mar 2021, ChiYuan Huang wrote: > HI, Lee: > > ChiYuan Huang 於 2021年1月13日 週三 下午10:09寫道: > > > > Lee Jones 於 2021年1月13日 週三 下午8:21寫道: > > > > > > On Thu, 17 Dec 2020, cy_huang wrote: > > > > > > > From: ChiYuan Huang > > > > > > > > This adds support Richtek RT4831 core. It includes fo

Re: [PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning

2021-03-25 Thread Martin Sebor
On 3/25/21 3:53 AM, Arnd Bergmann wrote: On Thu, Mar 25, 2021 at 9:05 AM Jani Nikula wrote: Clearly something is wrong here, but I can't quite figure out what. Changing the array size to 16 bytes avoids the warning, but is probably the wrong solution here. Ugh. drm_dp_channel_eq_ok() does not

Re: [PATCH] MAINTAINERS: Add linux-mediatek ML for drm Mediatek drivers

2021-03-25 Thread Chun-Kuang Hu
Hi, Dafna: Dafna Hirschfeld 於 2021年3月25日 週四 下午9:07寫道: > > Add the linux-mediatek mailing list to drm Mediatek drivers > Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > Signed-

[PATCH v2] MAINTAINERS: Update Maintainers of DRM Bridge Drivers

2021-03-25 Thread Robert Foss
Add myself as co-maintainer of DRM Bridge Drivers. Repository commit access has already been granted. https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/338 Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Andrzej Hajda Cc: Jernej Škrabec Cc: Daniel Vetter Signed-o

re: drm/ttm: switch to per device LRU lock

2021-03-25 Thread Colin Ian King
Hi, Static analysis with Coverity in linux-next has detected an issue in drivers/gpu/drm/ttm/ttm_bo.c with the follow commit: commit a1f091f8ef2b680a5184db065527612247cb4cae Author: Christian König Date: Tue Oct 6 17:26:42 2020 +0200 drm/ttm: switch to per device LRU lock Instead of

Re: drm/ttm: switch to per device LRU lock

2021-03-25 Thread Christian König
Thanks! Just a copy&paste issue. Patch to fix this is on the mailing list. Christian. Am 25.03.21 um 16:00 schrieb Colin Ian King: Hi, Static analysis with Coverity in linux-next has detected an issue in drivers/gpu/drm/ttm/ttm_bo.c with the follow commit: commit a1f091f8ef2b680a5184db065527

[PATCH] drm/ttm: switch back to static allocation limits for now

2021-03-25 Thread Christian König
The shrinker based approach still has some flaws. Especially that we need temporary pages to free up the pages allocated to the driver is problematic in a shrinker. Signed-off-by: Christian König Acked-by: Daniel Vetter --- drivers/gpu/drm/ttm/ttm_device.c | 14 ++-- drivers/gpu/drm/ttm/ttm_tt

[PATCH] drm/ttm: switch back to static allocation limits for now

2021-03-25 Thread Christian König
The shrinker based approach still has some flaws. Especially that we need temporary pages to free up the pages allocated to the driver is problematic in a shrinker. Signed-off-by: Christian König Acked-by: Daniel Vetter --- drivers/gpu/drm/ttm/ttm_device.c | 14 ++-- drivers/gpu/drm/ttm/ttm_tt

[PATCH] drm/ttm: fix invalid NULL deref

2021-03-25 Thread Christian König
The BO might be NULL in this function, use the bdev directly. Signed-off-by: Christian König Reported-by: Colin Ian King Fixes: a1f091f8ef2b ("drm/ttm: switch to per device LRU lock") --- drivers/gpu/drm/ttm/ttm_bo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/driv

Re: [PATCH] drm/ttm: fix invalid NULL deref

2021-03-25 Thread Colin Ian King
On 25/03/2021 15:27, Christian König wrote: > The BO might be NULL in this function, use the bdev directly. > > Signed-off-by: Christian König > Reported-by: Colin Ian King > Fixes: a1f091f8ef2b ("drm/ttm: switch to per device LRU lock") > --- > drivers/gpu/drm/ttm/ttm_bo.c | 6 +++--- > 1 file

Re: [PATCH] drm/radeon/radeon_pm: Convert sysfs sprintf/snprintf family to sysfs_emit

2021-03-25 Thread Alex Deucher
On Wed, Mar 24, 2021 at 2:47 AM Tian Tao wrote: > > Fix the following coccicheck warning: > drivers/gpu//drm/radeon/radeon_pm.c:521:9-17: WARNING: use scnprintf or > sprintf > drivers/gpu//drm/radeon/radeon_pm.c:475:8-16: WARNING: use scnprintf or > sprintf > drivers/gpu//drm/radeon/radeon_pm.c:41

Re: Color mode exposed to user space?

2021-03-25 Thread Alex Deucher
+ dri-devel I don't think it's currently exposed anywhere. Alex On Wed, Mar 24, 2021 at 5:11 AM Werner Sembach wrote: > > Hello, > > is the information which color mode is currently in used for a display (RGB, > YCbCr444, or YCbCr420) exposed to user space somewhere? > > If no: Where would be

Re: [PATCH drm/amdgpu 0/2] Convert sysfs sprintf/snprintf family to sysfs_emit

2021-03-25 Thread Alex Deucher
Applied the series. Thanks! Alex On Wed, Mar 24, 2021 at 5:17 AM Tian Tao wrote: > > Use the generic sysfs_emit() function to take place of > snprintf/scnprintf, to avoid buffer overrun. > > Tian Tao (2): > drm/amdgpu: Convert sysfs sprintf/snprintf family to sysfs_emit > drm/amd/pm: Conver

Re: [PATCH] drm: bridge: convert sysfs sprintf/snprintf family to sysfs_emit

2021-03-25 Thread Robert Foss
Pushed to drm-misc-next https://cgit.freedesktop.org/drm/drm-misc/commit/?id=fffa69aa6b1c89853cd00dea969e4754633596d7 On Sun, 7 Feb 2021 at 10:12, Jiapeng Chong wrote: > > Fix the following coccicheck warning: > > drivers/gpu/drm/bridge/lontium-lt9611uxc.c:858:8-16: WARNING: use > scnprintf or s

  1   2   >