Re: [RFC PATCH 01/11] dt-bindings: drm/bridge: ti-sn65dsi8: Make enable GPIO optional

2021-03-23 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-03-21 20:01:18) > The SN65DSI86 EN pin can be hardwired to a high level, or connected to a > global reset signal, not controllable by the kernel. Make it optional in > those cases. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Stephen Boyd ___

Re: [RFC PATCH 02/11] drm/bridge: ti-sn65dsi86: Make enable GPIO optional

2021-03-23 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-03-21 20:01:19) > The enable signal may not be controllable by the kernel. Make it > optional. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedesktop.or

Re: [RFC PATCH 03/11] drm/bridge: ti-sn65dsi86: Unregister AUX adapter in remove()

2021-03-23 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-03-21 20:01:20) > The AUX adapter registered in probe() need to be unregistered in > remove(). Do so. > > Fixes: b814ec6d4535 ("drm/bridge: ti-sn65dsi86: Implement AUX channel") > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Stephen Boyd

Re: [RFC PATCH 04/11] drm/bridge: ti-sn65dsi86: Use bitmask to store valid rates

2021-03-23 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-03-21 20:01:21) > The valid rates are stored in an array of 8 booleans. Replace it with a > bitmask to save space. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@

Re: [RFC PATCH 05/11] drm/bridge: ti-sn65dsi86: Wrap panel with panel-bridge

2021-03-23 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-03-21 20:01:22) > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index 1d1be791d5ba..c21a7f7d452b 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -418,8 +420,18 @@

Re: [RFC PATCH 06/11] drm/bridge: ti-sn65dsi86: Group code in sections

2021-03-23 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-03-21 20:01:23) > Reorganize the functions in sections, related to connector operations, > bridge operations, AUX adapter, GPIO controller and probe & remove. > > This prepares for proper support of DRM_BRIDGE_ATTACH_NO_CONNECTOR that > will add more functions, to en

Re: [RFC PATCH 07/11] drm/bridge: ti-sn65dsi86: Split connector creation to a function

2021-03-23 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-03-21 20:01:24) > To prepare for making connector creation option, move connector creation > out of ti_sn_bridge_attach to a separate function. > > No functional change intended. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Stephen Boyd

Re: [RFC PATCH 08/11] drm/bridge: ti-sn65dsi86: Implement bridge connector operations

2021-03-23 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-03-21 20:01:25) > Implement the bridge connector-related .get_edid() operation, and report > the related bridge capabilities and type. The .get_edid() operation is > implemented with the same backend as the EDID retrieval from the > connector .get_modes() operation. >

Re: [RFC PATCH 11/11] drm/bridge: ti-sn65dsi86: Support hotplug detection

2021-03-23 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-03-21 20:01:28) > When the SN65DSI86 is used in DisplayPort mode, its output is likely > routed to a DisplayPort connector, which can benefit from hotplug > detection. Support it in such cases, with polling mode only for now. > > The implementation is limited to the

[PATCH -next] drm: Markdrm_send_event_helper with static keyword

2021-03-23 Thread Zou Wei
Fix the following sparse warning: drivers/gpu/drm/drm_file.c:789:6: warning: symbol 'drm_send_event_helper' was not declared. Should it be static? Signed-off-by: Zou Wei --- drivers/gpu/drm/drm_file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_f

[PATCH] gpu/xen: Fix a use after free in xen_drm_drv_init

2021-03-23 Thread Lv Yunlong
In function displback_changed, has the call chain displback_connect(front_info)->xen_drm_drv_init(front_info). We can see that drm_info is assigned to front_info->drm_info and drm_info is freed in fail branch in xen_drm_drv_init(). Later displback_disconnect(front_info) is called and it calls xen_

[PATCH -next] drm/nouveau/core/client: Mark nvkm_uclient_sclass with static keyword

2021-03-23 Thread Zou Wei
Fix the following sparse warning: drivers/gpu/drm/nouveau/nvkm/core/client.c:64:1: warning: symbol 'nvkm_uclient_sclass' was not declared. Should it be static? Signed-off-by: Zou Wei --- drivers/gpu/drm/nouveau/nvkm/core/client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

Re: [PATCH v2 0/4] drm/bridge: ti-sn65dsi86: Support EDID reading

2021-03-23 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-03-22 17:00:23) > Hi Stephen, > > On Mon, Nov 02, 2020 at 05:15:24PM -0800, Stephen Boyd wrote: > > Quoting Sam Ravnborg (2020-11-01 09:37:41) > > > Hi Stephen. > > > > > > On Thu, Oct 29, 2020 at 06:17:34PM -0700, Stephen Boyd wrote: > > > > This patch series clean

[PATCH] drm/nouveau/mc: make tu102_mc_intr_unarm static

2021-03-23 Thread Jiapeng Chong
Fix the following sparse warning: drivers/gpu/drm/nouveau/nvkm/subdev/mc/tu102.c:74:1: warning: symbol 'tu102_mc_intr_mask' was not declared. Should it be static? drivers/gpu/drm/nouveau/nvkm/subdev/mc/tu102.c:62:1: warning: symbol 'tu102_mc_intr_rearm' was not declared. Should it be static? Rep

[PATCH v2] drm/nouveau/mc: make tu102_mc_intr_mask and tu102_mc_intr_rearm static

2021-03-23 Thread Jiapeng Chong
Fix the following sparse warning: drivers/gpu/drm/nouveau/nvkm/subdev/mc/tu102.c:74:1: warning: symbol 'tu102_mc_intr_mask' was not declared. Should it be static? drivers/gpu/drm/nouveau/nvkm/subdev/mc/tu102.c:62:1: warning: symbol 'tu102_mc_intr_rearm' was not declared. Should it be static? Rep

Re: [PATCH 2/2] video: backlight: qcom-wled: Add PMI8994 compatible

2021-03-23 Thread Lee Jones
On Mon, 22 Mar 2021, Daniel Thompson wrote: > On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: > > Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP. > > > > Signed-off-by: Konrad Dybcio > > Reviewed-by: Daniel Thompson Why are you Reviewing/Acking a patch that was ap

[PATCH 1/2] drm/i915: add gem/gt TODO

2021-03-23 Thread Daniel Vetter
We've discussed a bit how to get the gem/gt team better integrated and collaborate more with the wider community and agreed to the following: - all gem/gt patches are reviewed on dri-devel for now. That's overkill, but in the past there was definitely too little of that. - i915-gem folks are en

[PATCH 2/2] drm/doc: Add RFC section

2021-03-23 Thread Daniel Vetter
Motivated by the pre-review process for i915 gem/gt features, but probably useful in general for complex stuff. Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Jason Ekstrand Cc: Dave Airlie Signed-off-by: Daniel Vetter --- Documentation/gpu/index.rst | 1 + Documentation/gpu/rfc.

Re: [PATCH] drm/i915: A typo fix

2021-03-23 Thread Jani Nikula
On Tue, 23 Mar 2021, Bhaskar Chowdhury wrote: > s/nothign/nothing/ > > Signed-off-by: Bhaskar Chowdhury You've sent the same patch before? I've already pushed it. BR, Jani. > --- > drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Restrict sentinel requests further

2021-03-23 Thread Tvrtko Ursulin
On 22/03/2021 17:12, Matthew Auld wrote: On Thu, 18 Mar 2021 at 17:04, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Disallow sentinel requests follow previous sentinels to make request cancellation work better when faced with a chain of requests which have all been marked as in error. Coul

Re: [PATCH v7 2/2] drm/bridge: Introduce LT8912B DSI to HDMI bridge

2021-03-23 Thread Robert Foss
Hey Adrien, Sorry about the slow reply, but I just received the documentation from the vendor. So let's dig in to the HPD issue. > +static enum drm_connector_status lt8912_check_cable_status(struct lt8912 *lt) > +{ > + int ret; > + unsigned int reg_val; > + > + ret = regmap_read

Re: [PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2021-03-23 Thread Liu Ying
On Tue, 2021-03-23 at 01:03 +, Marcel Ziswiler wrote: > Hi Liu > > Some further discrepancy with them binding examples: > > arch/arm64/boot/dts/freescale/imx8qxp.dtsi:335.9-36: Warning (reg_format): > /dpu@5618:reg: property has > invalid length (8 bytes) (#address-cells == 2, #size-cell

Re: [PATCH] drm/i915: A typo fix

2021-03-23 Thread Bhaskar Chowdhury
On 10:53 Tue 23 Mar 2021, Jani Nikula wrote: On Tue, 23 Mar 2021, Bhaskar Chowdhury wrote: s/nothign/nothing/ Signed-off-by: Bhaskar Chowdhury You've sent the same patch before? I've already pushed it. Apologies and thanks. BR, Jani. --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Drop the CONTEXT_CLONE API

2021-03-23 Thread Tvrtko Ursulin
On 22/03/2021 16:43, Daniel Vetter wrote: On Mon, Mar 22, 2021 at 4:31 PM Tvrtko Ursulin wrote: On 22/03/2021 14:57, Daniel Vetter wrote: On Mon, Mar 22, 2021 at 3:33 PM Tvrtko Ursulin wrote: On 22/03/2021 14:09, Daniel Vetter wrote: On Mon, Mar 22, 2021 at 11:22:01AM +, Tvrtko Ur

Re: [PATCH] backlight: journada720: fix Wmisleading-indentation warning

2021-03-23 Thread Daniel Thompson
On Mon, Mar 22, 2021 at 05:41:28PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > With gcc-11, we get a warning about code that looks correct > but badly indented: > > drivers/video/backlight/jornada720_bl.c: In function > ‘jornada_bl_update_status’: > drivers/video/backlight/jornada720_

[PATCH v2] drm/omap: dsi: Add missing IRQF_ONESHOT

2021-03-23 Thread Yang Li
fixed the following coccicheck: ./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Reported-by: Abaci Robot Signed-off-by: Yang Li --- Change in v2: -Modify the fourth parameter, not the first drivers/gpu/drm/omapdrm/dss/d

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Implement SINGLE_TIMELINE with a syncobj

2021-03-23 Thread Tvrtko Ursulin
On 22/03/2021 16:10, Jason Ekstrand wrote: On Mon, Mar 22, 2021 at 7:28 AM Tvrtko Ursulin [snip] diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c index 96403130a373d..2c56796f6a71b 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_ex

Re: [PATCH 2/2] video: backlight: qcom-wled: Add PMI8994 compatible

2021-03-23 Thread Daniel Thompson
On Tue, Mar 23, 2021 at 08:39:35AM +, Lee Jones wrote: > On Mon, 22 Mar 2021, Daniel Thompson wrote: > > > On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: > > > Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP. > > > > > > Signed-off-by: Konrad Dybcio > > > > Revi

Re: [PATCH 1/2] drm/gud: fix sizeof use

2021-03-23 Thread Noralf Trønnes
Den 22.03.2021 18.44, skrev Noralf Trønnes: > From: kernel test robot > > drivers/gpu/drm/gud/gud_connector.c:710:37-43: ERROR: application of sizeof > to pointer > > sizeof when applied to a pointer typed expression gives the size of > the pointer > > Generated by: scripts/coccinelle/misc

Re: [PATCH V5 2/2] backlight: qcom-wled: Correct the sync_toggle sequence

2021-03-23 Thread Lee Jones
On Thu, 18 Mar 2021, Kiran Gunda wrote: > As per the current implementation, after FSC (Full Scale Current) > and brightness update the sync bits are set-then-cleared. > But, the FSC and brightness sync takes place when the sync bits are > set (e.g. on a rising edge). So the hardware team recommen

Re: [PATCH 2/2] video: backlight: qcom-wled: Add PMI8994 compatible

2021-03-23 Thread Lee Jones
On Tue, 23 Mar 2021, Daniel Thompson wrote: > On Tue, Mar 23, 2021 at 08:39:35AM +, Lee Jones wrote: > > On Mon, 22 Mar 2021, Daniel Thompson wrote: > > > > > On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: > > > > Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP. >

Re: [PATCH] backlight: journada720: fix Wmisleading-indentation warning

2021-03-23 Thread Lee Jones
On Mon, 22 Mar 2021, Arnd Bergmann wrote: > From: Arnd Bergmann > > With gcc-11, we get a warning about code that looks correct > but badly indented: > > drivers/video/backlight/jornada720_bl.c: In function > ‘jornada_bl_update_status’: > drivers/video/backlight/jornada720_bl.c:66:11: error: t

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Drop the CONTEXT_CLONE API

2021-03-23 Thread Tvrtko Ursulin
On 22/03/2021 16:24, Jason Ekstrand wrote: Ugh... timezones. On Mon, Mar 22, 2021 at 10:31 AM Tvrtko Ursulin wrote: On 22/03/2021 14:57, Daniel Vetter wrote: On Mon, Mar 22, 2021 at 3:33 PM Tvrtko Ursulin wrote: On 22/03/2021 14:09, Daniel Vetter wrote: On Mon, Mar 22, 2021 at 11:22

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Individual request cancellation

2021-03-23 Thread Tvrtko Ursulin
On 22/03/2021 15:38, Matthew Auld wrote: On Thu, 18 Mar 2021 at 17:04, Tvrtko Ursulin wrote: From: Chris Wilson Currently, we cancel outstanding requests within a context when the context is closed. We may also want to cancel individual requests using the same graceful preemption mechanism

Re: [PATCH v7 2/2] drm/bridge: Introduce LT8912B DSI to HDMI bridge

2021-03-23 Thread Adrien Grassein
Hey Robert, Thanks for the update. Le mar. 23 mars 2021 à 10:10, Robert Foss a écrit : > > Hey Adrien, > > Sorry about the slow reply, but I just received the documentation from > the vendor. So let's dig in to the HPD issue. No problem :) > > > +static enum drm_connector_status lt8912_check_ca

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Handle async cancellation in sentinel assert

2021-03-23 Thread Matthew Auld
On Thu, 18 Mar 2021 at 17:04, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > With the watchdog cancelling requests asynchronously to preempt-to-busy we > need to relax one assert making it apply only to requests not in error. > > v2: > * Check against the correct request! > > Signed-off-by:

Re: [PATCH v5 02/21] gpu: host1x: Allow syncpoints without associated client

2021-03-23 Thread Thierry Reding
On Mon, Jan 11, 2021 at 03:00:00PM +0200, Mikko Perttunen wrote: > Syncpoints don't need to be associated with any client, > so remove the property, and expose host1x_syncpt_alloc. > This will allow allocating syncpoints without prior knowledge > of the engine that it will be used with. > > Signed

Re: [PATCH 1/2] drm/i915: add gem/gt TODO

2021-03-23 Thread Jani Nikula
On Tue, 23 Mar 2021, Daniel Vetter wrote: > We've discussed a bit how to get the gem/gt team better integrated > and collaborate more with the wider community and agreed to the > following: > > - all gem/gt patches are reviewed on dri-devel for now. That's > overkill, but in the past there was d

Re: [PATCH v5 03/21] gpu: host1x: Show number of pending waiters in debugfs

2021-03-23 Thread Thierry Reding
On Mon, Jan 11, 2021 at 03:00:01PM +0200, Mikko Perttunen wrote: > Show the number of pending waiters in the debugfs status file. > This is useful for testing to verify that waiters do not leak > or accumulate incorrectly. > > Signed-off-by: Mikko Perttunen > --- > drivers/gpu/host1x/debug.c | 1

Re: [PATCH v5 01/21] gpu: host1x: Use different lock classes for each client

2021-03-23 Thread Thierry Reding
On Mon, Mar 22, 2021 at 07:01:34PM +0300, Dmitry Osipenko wrote: > 22.03.2021 18:19, Mikko Perttunen пишет: > > On 22.3.2021 16.48, Dmitry Osipenko wrote: > >> 22.03.2021 17:46, Thierry Reding пишет: > >>> On Mon, Jan 11, 2021 at 02:59:59PM +0200, Mikko Perttunen wrote: > To avoid false lockde

Re: [PATCH v5 04/21] gpu: host1x: Remove cancelled waiters immediately

2021-03-23 Thread Thierry Reding
On Wed, Jan 13, 2021 at 12:20:38AM +0200, Mikko Perttunen wrote: > On 1/13/21 12:07 AM, Dmitry Osipenko wrote: > > 11.01.2021 16:00, Mikko Perttunen пишет: > > > -void host1x_intr_put_ref(struct host1x *host, unsigned int id, void *ref) > > > +void host1x_intr_put_ref(struct host1x *host, unsigned

Re: [PATCH v5 05/21] gpu: host1x: Use HW-equivalent syncpoint expiration check

2021-03-23 Thread Thierry Reding
On Mon, Jan 11, 2021 at 03:00:03PM +0200, Mikko Perttunen wrote: > Make syncpoint expiration checks always use the same logic used by > the hardware. This ensures that there are no race conditions that > could occur because of the hardware triggering a syncpoint interrupt > and then the driver disa

Re: [PATCH v5 02/21] gpu: host1x: Allow syncpoints without associated client

2021-03-23 Thread Mikko Perttunen
On 3/23/21 12:10 PM, Thierry Reding wrote: On Mon, Jan 11, 2021 at 03:00:00PM +0200, Mikko Perttunen wrote: Syncpoints don't need to be associated with any client, so remove the property, and expose host1x_syncpt_alloc. This will allow allocating syncpoints without prior knowledge of the engine

Re: [PATCH v5 06/21] gpu: host1x: Cleanup and refcounting for syncpoints

2021-03-23 Thread Thierry Reding
On Mon, Jan 11, 2021 at 03:00:04PM +0200, Mikko Perttunen wrote: > Add reference counting for allocated syncpoints to allow keeping > them allocated while jobs are referencing them. Additionally, > clean up various places using syncpoint IDs to use host1x_syncpt > pointers instead. > > Signed-off-

Re: [Intel-gfx] [PATCH resend 2/2] drm/i915/display: Make vlv_find_free_pps() skip pipes which are in use for non DP purposes

2021-03-23 Thread Hans de Goede
Hi, On 3/2/21 3:51 PM, Ville Syrjälä wrote: > On Tue, Mar 02, 2021 at 01:00:40PM +0100, Hans de Goede wrote: >> As explained by a long comment block, on VLV intel_setup_outputs() >> sometimes thinks there might be an eDP panel connected while there is none. >> In this case intel_setup_outputs() wi

Re: [PATCH v7 2/2] drm/bridge: Introduce LT8912B DSI to HDMI bridge

2021-03-23 Thread Robert Foss
On Tue, 23 Mar 2021 at 11:01, Adrien Grassein wrote: > > Hey Robert, > > Thanks for the update. > > Le mar. 23 mars 2021 à 10:10, Robert Foss a écrit : > > > > Hey Adrien, > > > > Sorry about the slow reply, but I just received the documentation from > > the vendor. So let's dig in to the HPD iss

Re: [PATCH v5 06/21] gpu: host1x: Cleanup and refcounting for syncpoints

2021-03-23 Thread Mikko Perttunen
On 3/23/21 12:36 PM, Thierry Reding wrote: On Mon, Jan 11, 2021 at 03:00:04PM +0200, Mikko Perttunen wrote: Add reference counting for allocated syncpoints to allow keeping them allocated while jobs are referencing them. Additionally, clean up various places using syncpoint IDs to use host1x_syn

Re: [PATCH v5 07/21] gpu: host1x: Introduce UAPI header

2021-03-23 Thread Thierry Reding
On Mon, Jan 11, 2021 at 03:00:05PM +0200, Mikko Perttunen wrote: > Add the userspace interface header, specifying interfaces > for allocating and accessing syncpoints from userspace, > and for creating sync_file based fences based on syncpoint > thresholds. > > Signed-off-by: Mikko Perttunen > --

Re: [Intel-gfx] [PATCH v3 4/6] drm/i915: Request watchdog infrastructure

2021-03-23 Thread Matthew Auld
On Mon, 22 Mar 2021 at 13:29, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Prepares the plumbing for setting request/fence expiration time. All code > is put in place but is never activeted due yet missing ability to actually activated > configure the timer. > > Outline o

Re: [PATCH v5 08/21] gpu: host1x: Implement /dev/host1x device node

2021-03-23 Thread Thierry Reding
On Mon, Jan 11, 2021 at 03:00:06PM +0200, Mikko Perttunen wrote: > Add the /dev/host1x device node, implementing the following > functionality: > > - Reading syncpoint values > - Allocating syncpoints (providing syncpoint FDs) > - Incrementing syncpoints (based on syncpoint FD) > > Signed-off-by:

Re: [PATCH v7 2/2] drm/bridge: Introduce LT8912B DSI to HDMI bridge

2021-03-23 Thread Adrien Grassein
Le mar. 23 mars 2021 à 11:42, Robert Foss a écrit : > > On Tue, 23 Mar 2021 at 11:01, Adrien Grassein > wrote: > > > > Hey Robert, > > > > Thanks for the update. > > > > Le mar. 23 mars 2021 à 10:10, Robert Foss a écrit : > > > > > > Hey Adrien, > > > > > > Sorry about the slow reply, but I jus

Re: [Intel-gfx] [PATCH v3 4/6] drm/i915: Request watchdog infrastructure

2021-03-23 Thread Tvrtko Ursulin
On 23/03/2021 10:54, Matthew Auld wrote: On Mon, 22 Mar 2021 at 13:29, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Prepares the plumbing for setting request/fence expiration time. All code is put in place but is never activeted due yet missing ability to actually activat

Re: [PATCH v5 07/21] gpu: host1x: Introduce UAPI header

2021-03-23 Thread Mikko Perttunen
On 3/23/21 12:52 PM, Thierry Reding wrote: On Mon, Jan 11, 2021 at 03:00:05PM +0200, Mikko Perttunen wrote: Add the userspace interface header, specifying interfaces for allocating and accessing syncpoints from userspace, and for creating sync_file based fences based on syncpoint thresholds. Si

Re: [PATCH v5 09/21] gpu: host1x: DMA fences and userspace fence creation

2021-03-23 Thread Thierry Reding
On Mon, Jan 11, 2021 at 03:00:07PM +0200, Mikko Perttunen wrote: > Add an implementation of dma_fences based on syncpoints. Syncpoint > interrupts are used to signal fences. Additionally, after > software signaling has been enabled, a 30 second timeout is started. > If the syncpoint threshold is no

Re: [PATCH v2] drm/omap: dsi: Add missing IRQF_ONESHOT

2021-03-23 Thread Sebastian Reichel
Hi, On Tue, Mar 23, 2021 at 05:34:53PM +0800, Yang Li wrote: > fixed the following coccicheck: > ./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with > no primary handler requested without IRQF_ONESHOT > > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- Reviewed-by:

Re: [PATCH v5 08/21] gpu: host1x: Implement /dev/host1x device node

2021-03-23 Thread Mikko Perttunen
On 3/23/21 1:02 PM, Thierry Reding wrote: On Mon, Jan 11, 2021 at 03:00:06PM +0200, Mikko Perttunen wrote: Add the /dev/host1x device node, implementing the following functionality: - Reading syncpoint values - Allocating syncpoints (providing syncpoint FDs) - Incrementing syncpoints (based on

Re: [PATCH v5 06/21] gpu: host1x: Cleanup and refcounting for syncpoints

2021-03-23 Thread Thierry Reding
On Tue, Mar 23, 2021 at 12:44:28PM +0200, Mikko Perttunen wrote: > On 3/23/21 12:36 PM, Thierry Reding wrote: > > On Mon, Jan 11, 2021 at 03:00:04PM +0200, Mikko Perttunen wrote: > > > Add reference counting for allocated syncpoints to allow keeping > > > them allocated while jobs are referencing t

Re: [PATCH v6 03/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding

2021-03-23 Thread Marcel Ziswiler
On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > This patch adds bindings for i.MX8qm/qxp pixel combiner. > > Reviewed-by: Rob Herring > Signed-off-by: Liu Ying > --- > v5->v6: > * No change. > > v4->v5: > * No change. > > v3->v4: > * No change. > > v2->v3: > * Add Rob's R-b tag. > > v1-

Re: [PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2021-03-23 Thread Marcel Ziswiler
Hi Liu Some further discrepancy with them binding examples: arch/arm64/boot/dts/freescale/imx8qxp.dtsi:335.9-36: Warning (reg_format): /dpu@5618:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 2) arch/arm64/boot/dts/freescale/imx8qxp.dtsi:508.9-35: Warning (re

Re: [PATCH v6 01/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2021-03-23 Thread Marcel Ziswiler
On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > This patch adds RGB666_1X30_CPADLO, RGB888_1X30_CPADLO, RGB666_1X36_CPADLO > and RGB888_1X36_CPADLO bus formats used by i.MX8qm/qxp pixel combiner. > The RGB pixels with padding low per component are transmitted on a 30-bit > input bus(10-bit per

Re: [PATCH v6 05/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding

2021-03-23 Thread Marcel Ziswiler
On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > This patch adds bindings for i.MX8qm/qxp display pixel link. > > Reviewed-by: Rob Herring > Signed-off-by: Liu Ying > --- > v5->v6: > * No change. > > v4->v5: > * No change. > > v3->v4: > * No change. > > v2->v3: > * Add Rob's R-b tag. > >

Re: [PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2021-03-23 Thread Marcel Ziswiler
Hi Liu I gave this a try however I believe I am still missing some piece as it throws the following during compilation of the device tree: arch/arm64/boot/dts/freescale/imx8qxp.dtsi:333.18-439.7: ERROR (phandle_references): /dpu@5618: Reference to non-existent node or label "dc0_irqsteer"

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-23 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 08:38:33AM +0100, Michal Hocko wrote: > On Mon 22-03-21 20:34:25, Christian König wrote: > > Am 22.03.21 um 18:02 schrieb Daniel Vetter: > > > On Mon, Mar 22, 2021 at 5:06 PM Michal Hocko wrote: > > > > On Mon 22-03-21 14:05:48, Matthew Wilcox wrote: > > > > > On Mon, Mar 2

Re: [PATCH] video/fbdev: Fix a double free in hvfb_probe

2021-03-23 Thread Wei Liu
Thanks for your patch. I would like to change the prefix to "video: hyperv_fb:" to be more specific. On Tue, Mar 23, 2021 at 12:33:50AM -0700, Lv Yunlong wrote: > In function hvfb_probe in hyperv_fb.c, it calls hvfb_getmem(hdev, info) > and return err when info->apertures is freed. > > In the er

[PATCH v5 0/2] HDMI2.1 PCON Misc Fixes

2021-03-23 Thread Ankit Nautiyal
Patch1: Tweaks the drm_helpers for PCON configuration. Patch2: Removes unwanted code not applicable for older platforms. [Merged] Patch3: Fixes condition for starting FRL link training. rev3: Patch-1 from rev2 [Read PCON DSC ENC caps only for DPCD rev >= 1.4] is dropped as it mixes DPCD and DP re

[PATCH v5 2/2] drm/i915/display: Configure HDMI2.1 Pcon for FRL only if Src-Ctl mode is available

2021-03-23 Thread Ankit Nautiyal
Add the check if source control mode is supported by the PCON, before starting configuring PCON for FRL training, as per spec VESA DP2.0-HDMI2.1 PCON Draft-1 Sec-7. v2: Added spec details for the change. (Uma) Signed-off-by: Ankit Nautiyal Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/disp

[PATCH v5 1/2] drm/dp_helper: Define options for FRL training for HDMI2.1 PCON

2021-03-23 Thread Ankit Nautiyal
Currently the FRL training mode (Concurrent, Sequential) and training type (Normal, Extended) are not defined properly and are passed as bool values in drm_helpers for pcon configuration for FRL training. This patch: -Add register masks for Sequential and Normal FRL training options. -Fixes the dr

[PATCH] video/fbdev: Fix a double free in hvfb_probe

2021-03-23 Thread Lv Yunlong
In function hvfb_probe in hyperv_fb.c, it calls hvfb_getmem(hdev, info) and return err when info->apertures is freed. In the error1 label of hvfb_probe, info->apertures will be freed twice by framebuffer_release(info). My patch sets info->apertures to NULL after it was freed to avoid double free.

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-23 Thread Daniel Vetter
On Sun, Mar 21, 2021 at 07:45:28PM +0100, Thomas Hellström (Intel) wrote: > TTM sets up huge page-table-entries both to system- and device memory, > and we don't want gup to assume there are always valid backing struct > pages for these. For PTEs this is handled by setting the pte_special bit, > bu

Re: [PATCH] drm/etnaviv: Remove redundant NULL check

2021-03-23 Thread Christian Gmeiner
Am Di., 23. März 2021 um 03:46 Uhr schrieb Jiapeng Chong : > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:622:2-8: WARNING: NULL > check before some freeing functions is not needed. > > ./drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:618:2-8: WARNING: N

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-23 Thread Michal Hocko
On Mon 22-03-21 20:34:25, Christian König wrote: > Am 22.03.21 um 18:02 schrieb Daniel Vetter: > > On Mon, Mar 22, 2021 at 5:06 PM Michal Hocko wrote: > > > On Mon 22-03-21 14:05:48, Matthew Wilcox wrote: > > > > On Mon, Mar 22, 2021 at 02:49:27PM +0100, Daniel Vetter wrote: > > > > > On Sun, Mar

Re: [Intel-gfx] [PATCH v3 4/6] drm/i915: Request watchdog infrastructure

2021-03-23 Thread Matthew Auld
On Tue, 23 Mar 2021 at 11:09, Tvrtko Ursulin wrote: > > > On 23/03/2021 10:54, Matthew Auld wrote: > > On Mon, 22 Mar 2021 at 13:29, Tvrtko Ursulin > > wrote: > >> > >> From: Tvrtko Ursulin > >> > >> Prepares the plumbing for setting request/fence expiration time. All code > >> is put in place b

Re: [PATCH v5 07/21] gpu: host1x: Introduce UAPI header

2021-03-23 Thread Thierry Reding
On Tue, Mar 23, 2021 at 01:12:36PM +0200, Mikko Perttunen wrote: > On 3/23/21 12:52 PM, Thierry Reding wrote: > > On Mon, Jan 11, 2021 at 03:00:05PM +0200, Mikko Perttunen wrote: [...] > > > +struct host1x_fence_extract_fence { > > > + __u32 id; > > > + __u32 threshold; > > > +}; > > > + > > > +str

Re: [RFC PATCH 2/2] mm,drm/ttm: Use VM_PFNMAP for TTM vmas

2021-03-23 Thread Daniel Vetter
On Sun, Mar 21, 2021 at 07:45:29PM +0100, Thomas Hellström (Intel) wrote: > To block fast gup we need to make sure TTM ptes are always special. > With MIXEDMAP we, on architectures that don't support pte_special, > insert normal ptes, but OTOH on those architectures, fast is not > supported. > At t

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-23 Thread Christian König
Am 23.03.21 um 12:28 schrieb Daniel Vetter: On Tue, Mar 23, 2021 at 08:38:33AM +0100, Michal Hocko wrote: On Mon 22-03-21 20:34:25, Christian König wrote: Am 22.03.21 um 18:02 schrieb Daniel Vetter: On Mon, Mar 22, 2021 at 5:06 PM Michal Hocko wrote: On Mon 22-03-21 14:05:48, Matthew Wilcox

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-23 Thread Christian König
Am 23.03.21 um 12:46 schrieb Michal Hocko: On Tue 23-03-21 12:28:20, Daniel Vetter wrote: On Tue, Mar 23, 2021 at 08:38:33AM +0100, Michal Hocko wrote: [...] fs_reclaim_acquire is there to make sure lockdep understands that this is a shrinker and that it checks all the dependencies for us l

Re: [PATCH v5 11/21] gpu: host1x: Add job release callback

2021-03-23 Thread Thierry Reding
On Mon, Jan 11, 2021 at 03:00:09PM +0200, Mikko Perttunen wrote: > Add a callback field to the job structure, to be called just before > the job is to be freed. This allows the job's submitter to clean > up any of its own state, like decrement runtime PM refcounts. > > Signed-off-by: Mikko Perttun

Re: [PATCH 1/2] drm/i915: add gem/gt TODO

2021-03-23 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 12:13:11PM +0200, Jani Nikula wrote: > On Tue, 23 Mar 2021, Daniel Vetter wrote: > > We've discussed a bit how to get the gem/gt team better integrated > > and collaborate more with the wider community and agreed to the > > following: > > > > - all gem/gt patches are review

Re: [RFC PATCH 2/2] mm,drm/ttm: Use VM_PFNMAP for TTM vmas

2021-03-23 Thread Christian König
Am 22.03.21 um 09:13 schrieb Thomas Hellström (Intel): Hi! On 3/22/21 8:47 AM, Christian König wrote: Am 21.03.21 um 19:45 schrieb Thomas Hellström (Intel): To block fast gup we need to make sure TTM ptes are always special. With MIXEDMAP we, on architectures that don't support pte_special,

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-23 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 12:51:13PM +0100, Christian König wrote: > > > Am 23.03.21 um 12:46 schrieb Michal Hocko: > > On Tue 23-03-21 12:28:20, Daniel Vetter wrote: > > > On Tue, Mar 23, 2021 at 08:38:33AM +0100, Michal Hocko wrote: > > [...] > > > > > > fs_reclaim_acquire is there to make sure l

Re: [PATCH v3 0/3] drm/tilcdc: fix LCD pixel clock setting

2021-03-23 Thread Jyri Sarha
Thanks, Reviewed-by: Jyri Sarha for the series. I'll merge these later today. Best regards, Jyri On 2021-03-22 23:33, Dario Binacchi wrote: The series was born from a patch to fix the LCD pixel clock setting. Two additional patches have been added to this. One renames a misleading variable

[PATCH -next] drm/vmwgfx/vmwgfx_validation: Use flexible-array member instead of zero-length array

2021-03-23 Thread Zou Wei
Suppresses the following coccinelle warning: drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:85:15-22: WARNING use flexible-array member instead Signed-off-by: Zou Wei --- drivers/gpu/drm/vmwgfx/vmwgfx_validation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-23 Thread Christian König
Am 23.03.21 um 13:04 schrieb Michal Hocko: On Tue 23-03-21 12:48:58, Christian König wrote: Am 23.03.21 um 12:28 schrieb Daniel Vetter: On Tue, Mar 23, 2021 at 08:38:33AM +0100, Michal Hocko wrote: On Mon 22-03-21 20:34:25, Christian König wrote: [...] My only concern is that if I could rely

Re: [PATCH v5 15/21] drm/tegra: Add new UAPI to header

2021-03-23 Thread Thierry Reding
On Thu, Jan 14, 2021 at 12:34:22PM +0200, Mikko Perttunen wrote: > On 1/14/21 10:36 AM, Dmitry Osipenko wrote: > > 13.01.2021 21:56, Mikko Perttunen пишет: > > > On 1/13/21 8:14 PM, Dmitry Osipenko wrote: > > > > 11.01.2021 16:00, Mikko Perttunen пишет: > > > > > +struct drm_tegra_submit_buf { > >

Re: [PATCH 1/2] drm/i915: add gem/gt TODO

2021-03-23 Thread Rodrigo Vivi
On Tue, Mar 23, 2021 at 12:57:39PM +0100, Daniel Vetter wrote: > On Tue, Mar 23, 2021 at 12:13:11PM +0200, Jani Nikula wrote: > > On Tue, 23 Mar 2021, Daniel Vetter wrote: > > > We've discussed a bit how to get the gem/gt team better integrated > > > and collaborate more with the wider community a

Re: [PATCH v5 18/21] drm/tegra: Allocate per-engine channel in core code

2021-03-23 Thread Thierry Reding
On Mon, Jan 11, 2021 at 03:00:16PM +0200, Mikko Perttunen wrote: > To avoid duplication, allocate the per-engine shared channel in the > core code instead. Once MLOCKs are implemented on Host1x side, we > can also update this to avoid allocating a shared channel when > MLOCKs are enabled. > > Sign

Re: [PATCH 2/2] drm/doc: Add RFC section

2021-03-23 Thread Rodrigo Vivi
On Tue, Mar 23, 2021 at 09:44:53AM +0100, Daniel Vetter wrote: > Motivated by the pre-review process for i915 gem/gt features, but > probably useful in general for complex stuff. > > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Jason Ekstrand > Cc: Dave Airlie > Signed-off-b

[PATCH] amdgpu: fix gcc -Wrestrict warning

2021-03-23 Thread Arnd Bergmann
From: Arnd Bergmann gcc warns about an sprintf() that uses the same buffer as source and destination, which is undefined behavior in C99: drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c: In function 'amdgpu_securedisplay_debugfs_write': drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c:141:6:

[PATCH] drm/imx: fix out of bounds array access warning

2021-03-23 Thread Arnd Bergmann
From: Arnd Bergmann When CONFIG_OF is disabled, building with 'make W=1' produces warnings about out of bounds array access: drivers/gpu/drm/imx/imx-ldb.c: In function 'imx_ldb_set_clock.constprop': drivers/gpu/drm/imx/imx-ldb.c:186:8: error: array subscript -22 is below array bounds of 'struct

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-23 Thread Christian König
Am 23.03.21 um 13:37 schrieb Michal Hocko: On Tue 23-03-21 13:21:32, Christian König wrote: Am 23.03.21 um 13:04 schrieb Michal Hocko: On Tue 23-03-21 12:48:58, Christian König wrote: Am 23.03.21 um 12:28 schrieb Daniel Vetter: On Tue, Mar 23, 2021 at 08:38:33AM +0100, Michal Hocko wrote: On

Re: [PATCH 2/2] drm/doc: Add RFC section

2021-03-23 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 08:37:07AM -0400, Rodrigo Vivi wrote: > On Tue, Mar 23, 2021 at 09:44:53AM +0100, Daniel Vetter wrote: > > Motivated by the pre-review process for i915 gem/gt features, but > > probably useful in general for complex stuff. > > > > Cc: Jani Nikula > > Cc: Joonas Lahtinen >

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-23 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 01:04:03PM +0100, Michal Hocko wrote: > On Tue 23-03-21 12:48:58, Christian König wrote: > > Am 23.03.21 um 12:28 schrieb Daniel Vetter: > > > On Tue, Mar 23, 2021 at 08:38:33AM +0100, Michal Hocko wrote: > > > > I think this is where I don't get yet what Christian tries to

Re: [PATCH v5 18/21] drm/tegra: Allocate per-engine channel in core code

2021-03-23 Thread Mikko Perttunen
On 3/23/21 2:35 PM, Thierry Reding wrote: On Mon, Jan 11, 2021 at 03:00:16PM +0200, Mikko Perttunen wrote: To avoid duplication, allocate the per-engine shared channel in the core code instead. Once MLOCKs are implemented on Host1x side, we can also update this to avoid allocating a shared chann

Re: [PATCH 1/2] drm/i915: add gem/gt TODO

2021-03-23 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 09:44:52AM +0100, Daniel Vetter wrote: > We've discussed a bit how to get the gem/gt team better integrated > and collaborate more with the wider community and agreed to the > following: > > - all gem/gt patches are reviewed on dri-devel for now. That's > overkill, but in

Re: [PATCH 1/2] drm/i915: add gem/gt TODO

2021-03-23 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 08:34:55AM -0400, Rodrigo Vivi wrote: > On Tue, Mar 23, 2021 at 12:57:39PM +0100, Daniel Vetter wrote: > > On Tue, Mar 23, 2021 at 12:13:11PM +0200, Jani Nikula wrote: > > > On Tue, 23 Mar 2021, Daniel Vetter wrote: > > > > We've discussed a bit how to get the gem/gt team b

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Drop the CONTEXT_CLONE API

2021-03-23 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 09:14:36AM +, Tvrtko Ursulin wrote: > > On 22/03/2021 16:43, Daniel Vetter wrote: > > On Mon, Mar 22, 2021 at 4:31 PM Tvrtko Ursulin > > wrote: > > > > > > > > > On 22/03/2021 14:57, Daniel Vetter wrote: > > > > On Mon, Mar 22, 2021 at 3:33 PM Tvrtko Ursulin > > > >

Re: [PATCH v5 01/21] gpu: host1x: Use different lock classes for each client

2021-03-23 Thread Dmitry Osipenko
23.03.2021 13:20, Thierry Reding пишет: > On Mon, Mar 22, 2021 at 07:01:34PM +0300, Dmitry Osipenko wrote: >> 22.03.2021 18:19, Mikko Perttunen пишет: >>> On 22.3.2021 16.48, Dmitry Osipenko wrote: 22.03.2021 17:46, Thierry Reding пишет: > On Mon, Jan 11, 2021 at 02:59:59PM +0200, Mikko Pe

Re: [PATCH v5 19/21] drm/tegra: Implement new UAPI

2021-03-23 Thread Thierry Reding
On Mon, Jan 11, 2021 at 03:00:17PM +0200, Mikko Perttunen wrote: > Implement the non-submission parts of the new UAPI, including > channel management and memory mapping. The UAPI is under the > CONFIG_DRM_TEGRA_STAGING config flag for now. > > Signed-off-by: Mikko Perttunen > --- > v5: > * Set io

Re: [PATCH v5 20/21] drm/tegra: Implement job submission part of new UAPI

2021-03-23 Thread Thierry Reding
On Mon, Jan 11, 2021 at 03:00:18PM +0200, Mikko Perttunen wrote: > Implement the job submission IOCTL with a minimum feature set. > > Signed-off-by: Mikko Perttunen > --- > v5: > * Add 16K size limit to copies from userspace. > * Guard RELOC_BLOCKLINEAR flag handling to only exist in ARM64 > to

Re: [PATCH 2/2] drm/doc: Add RFC section

2021-03-23 Thread Rodrigo Vivi
On Tue, Mar 23, 2021 at 02:10:17PM +0100, Daniel Vetter wrote: > On Tue, Mar 23, 2021 at 08:37:07AM -0400, Rodrigo Vivi wrote: > > On Tue, Mar 23, 2021 at 09:44:53AM +0100, Daniel Vetter wrote: > > > Motivated by the pre-review process for i915 gem/gt features, but > > > probably useful in general

  1   2   3   4   >