[PATCH] drm/tegra: dc: Restore coupling of display controllers

2021-03-19 Thread Thierry Reding
From: Thierry Reding Coupling of display controllers used to rely on runtime PM to take the companion controller out of reset. Commit fd67e9c6ed5a ("drm/tegra: Do not implement runtime PM") accidentally broke this when runtime PM was removed. Restore this functionality by reusing the hierarchica

[PATCH] drm/amd/display: Set AMDGPU_DM_DEFAULT_MIN_BACKLIGHT to 0

2021-03-19 Thread Evan Benn
AMDGPU_DM_DEFAULT_MIN_BACKLIGHT was set to the value of 12 to ensure no display backlight will flicker at low user brightness settings. However this value is quite bright, so for devices that do not implement the ACPI ATIF ATIF_FUNCTION_QUERY_BRIGHTNESS_TRANSFER_CHARACTERISTICS functionality the us

Re: [PATCH] dma-buf: use wake_up_process() instead of wake_up_state()

2021-03-19 Thread Christian König
Am 19.03.21 um 03:58 schrieb Wang Qing: Using wake_up_process() is more simpler and friendly, and it is more convenient for analysis and statistics Signed-off-by: Wang Qing Reviewed-by: Christian König Should I pick it up or do you want to push it through some other tree than DRM? Thanks

[Bug 212281] AMDGPU warning stack trace in dmesg (dcn20_validate_bandwidth_fp)

2021-03-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212281 --- Comment #4 from Tomas Sandven (tomas@sandven.email) --- Forgot to add, I'm using Sway (Wayland) and not X, so I don't have X logs to share. -- You may reply to this email to add a comment. You are receiving this mail because: You are watchi

Re: [RESEND 00/53] Rid GPU from W=1 warnings

2021-03-19 Thread Lee Jones
On Thu, 18 Mar 2021, Daniel Vetter wrote: > On Wed, Mar 17, 2021 at 9:32 PM Daniel Vetter wrote: > > > > On Wed, Mar 17, 2021 at 9:17 AM Lee Jones wrote: > > > > > > On Thu, 11 Mar 2021, Lee Jones wrote: > > > > > > > On Thu, 11 Mar 2021, Daniel Vetter wrote: > > > > > > > > > On Mon, Mar 08, 20

[RESEND 00/19] Rid GPU from W=1 warnings

2021-03-19 Thread Lee Jones
MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is a resend of the remaining patches. All of these patches have been sent before. Lee Jones (19): drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc drm/nouveau/dispnv50/disp: Re

[PATCH 01/19] drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc

2021-03-19 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function parameter or member 'init' not described in 'init_reserved' drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:611: warning: Function parameter or member 'init' not described in

[PATCH 02/19] drm/nouveau/dispnv50/disp: Remove unused variable 'ret'

2021-03-19 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv50/disp.c:1381:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org Signed

[PATCH 04/19] include: drm: drm_atomic: Make use of 'new_plane_state'

2021-03-19 Thread Lee Jones
In the macro for_each_oldnew_plane_in_state() 'new_plane_state' is provided as a container for state->planes[i].new_state, but is not utilised in some use-cases, so we fake-use it instead. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.

[PATCH 03/19] drm/msm/dp/dp_display: Remove unused variable 'hpd'

2021-03-19 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/dp/dp_display.c: In function ‘dp_display_usbpd_attention_cb’: drivers/gpu/drm/msm/dp/dp_display.c:496:19: warning: variable ‘hpd’ set but not used [-Wunused-but-set-variable] Cc: Rob Clark Cc: Sean Paul Cc: David Airlie C

[PATCH 05/19] drm/nouveau/nvkm/subdev/volt/gk20a: Demote non-conformant kernel-doc headers

2021-03-19 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:53: warning: Function parameter or member 'speedo' not described in 'gk20a_volt_get_cvb_voltage' drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:53: warning: Function parameter or member 's_scale

[PATCH 06/19] drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the stack to the heap

2021-03-19 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function ‘calculate_bandwidth’: drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2016:1: warning: the frame size of 1216 bytes is larger than 1024 bytes [-Wframe-larger-tha

[PATCH 09/19] drm/nouveau/nvkm/engine/gr/gf100: Demote non-conformant kernel-doc header

2021-03-19 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:992: warning: Function parameter or member 'gr' not described in 'gf100_gr_wait_idle' Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouv...@lists.freede

[PATCH 08/19] drm/amd/display/dc/dce80/dce80_resource: Make local functions static

2021-03-19 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:527:17: warning: no previous prototype for ‘dce80_aux_engine_create’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:565:20: warning: no prev

[PATCH 10/19] drm/nouveau/nouveau_bo: Remove unused variables 'dev'

2021-03-19 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_bo.c: In function ‘nouveau_ttm_tt_populate’: drivers/gpu/drm/nouveau/nouveau_bo.c:1228:17: warning: variable ‘dev’ set but not used [-Wunused-but-set-variable] drivers/gpu/drm/nouveau/nouveau_bo.c: In function ‘no

[PATCH 15/19] drm/nouveau/nv50_display: Remove superfluous prototype for local static functions

2021-03-19 Thread Lee Jones
Fixes the following build error: drivers/gpu/drm/nouveau/dispnv50/disp.c:2530:1: error: conflicting types for ‘nv50_display_fini’ In file included from drivers/gpu/drm/nouveau/dispnv50/disp.c:71: drivers/gpu/drm/nouveau/nv50_display.h:36:6: note: previous declaration of ‘nv50_display_fini’ wa

[PATCH 13/19] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' from function returning void

2021-03-19 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv50/disp.c: In function ‘nv50_mstm_cleanup’: drivers/gpu/drm/nouveau/dispnv50/disp.c:1357:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter C

[PATCH 11/19] drm/nouveau/nouveau_display: Remove set but unused variable 'width'

2021-03-19 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_display.c: In function ‘nouveau_framebuffer_new’: drivers/gpu/drm/nouveau/nouveau_display.c:309:15: warning: variable ‘width’ set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs Cc: David Airlie Cc: Dan

Re: [PATCH v2 0/5] drm/vc4: hdmi: Support the 4k @ 60Hz modes

2021-03-19 Thread Thomas Zimmermann
Hi, I looked through the patches. I can't say much about the technical side, but for the patches themselves Acked-by: Thomas Zimmermann Just one nit: I've seen the pattern (mode->clock * 1000) < HDMI_14_MAX_TMDS_CLK in several places. I suggest to add a little helper with a descriptive n

[PATCH 07/19] drm/amd/display/dc/calcs/dce_calcs: Remove some large variables from the stack

2021-03-19 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function ‘bw_calcs_init’: drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2726:1: warning: the frame size of 1336 bytes is larger than 1024 bytes [-Wframe-larger-than=] C

[PATCH 19/19] drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment block

2021-03-19 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or member 'filp' not described in 'nouveau_compat_ioctl' drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or member 'cmd' not described in 'nouveau_co

[PATCH 17/19] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc

2021-03-19 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_ioc32.c:2: warning: Cannot understand * file mga_ioc32.c Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org Signed-off-by: Lee Jones --- dr

[PATCH 12/19] drm/nouveau/dispnv04/crtc: Demote non-conforming kernel-doc headers

2021-03-19 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv04/crtc.c:462: warning: Function parameter or member 'crtc' not described in 'nv_crtc_mode_set_regs' drivers/gpu/drm/nouveau/dispnv04/crtc.c:462: warning: Function parameter or member 'mode' not described in 'nv_crt

[PATCH 14/19] drm/nouveau/dispnv50/headc57d: Make local function 'headc57d_olut' static

2021-03-19 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv50/headc57d.c:173:1: warning: no previous prototype for ‘headc57d_olut’ [-Wmissing-prototypes] Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: Lyude Paul Cc: dri-devel@lists.freedesktop.org Cc: nouv...@list

[PATCH 16/19] drm/nouveau/dispnv50/disp: Include header containing our prototypes

2021-03-19 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv50/disp.c:2599:1: warning: no previous prototype for ‘nv50_display_create’ [-Wmissing-prototypes] Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouv...@lists.freedesktop

[PATCH 18/19] drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void function

2021-03-19 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_svm.c: In function ‘nouveau_pfns_map’: drivers/gpu/drm/nouveau/nouveau_svm.c:810:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri

[PATCH] drm/nouveau: Remove unused variable ret

2021-03-19 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./drivers/gpu/drm/nouveau/nouveau_bios.c:2048:5-8: Unneeded variable: "ret". Return "0" on line 2061. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/nouveau/nouveau_bios.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [PATCH v2] drm/loongson: Add DDC support for loongson display controller

2021-03-19 Thread lichenyang
Hi, sunhao. > > Add GPIO and I2C driver to detect connector and fetch EDID via DDC. > It's even better to add what V2 has changed. > Signed-off-by: Hao Sun > --- > drivers/gpu/drm/loongson/Makefile | 3 +- > drivers/gpu/drm/loongson/loongson_connector.c | 120 +++- >

[PATCH v5 0/2] enable HDCP in Cadence MHDP bridge driver

2021-03-19 Thread Parshuram Thombare
This patch series enables HDCP in Cadence MHDP DPI/DP bridge driver. Changes since v1: - Move sapb reg block right after apb reg block - Corresponding changes in binding and example Changes since v2: - Revert reg resource sequence in binding and use resource mapping by name - Remove hdcp_confi

[PATCH v5 1/2] dt-bindings: drm/bridge: MHDP8546 bridge binding changes for HDCP

2021-03-19 Thread Parshuram Thombare
Add binding changes for HDCP in the MHDP8546 DPI/DP bridge binding. Signed-off-by: Parshuram Thombare --- .../display/bridge/cdns,mhdp8546.yaml | 34 --- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/Documentation/devicetree/bindings/display/bridge/cdns

[PATCH v5 2/2] drm: bridge: cdns-mhdp8546: Enable HDCP

2021-03-19 Thread Parshuram Thombare
This patch enable HDCP in MHDP driver. Signed-off-by: Parshuram Thombare Reviewed-by: Robert Foss --- drivers/gpu/drm/bridge/cadence/Makefile | 2 +- .../drm/bridge/cadence/cdns-mhdp8546-core.c | 113 +++- .../drm/bridge/cadence/cdns-mhdp8546-core.h | 21 + .../drm/bridge/cadence/c

Re: [PATCH] drm/meson: Fix few typo

2021-03-19 Thread Neil Armstrong
On 18/03/2021 12:00, Bhaskar Chowdhury wrote: > > s/initialy/initially/ > s/desined/designed/ > > Signed-off-by: Bhaskar Chowdhury > --- > drivers/gpu/drm/meson/meson_venc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/meson/meson_venc.c > b/drivers

Re: [PATCH 1/3] drm/ttm: move swapout logic around

2021-03-19 Thread kernel test robot
Hi "Christian, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on next-20210319] [cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.12-rc3] [If

Re: [PATCH 1/3] drm/ttm: move swapout logic around v2

2021-03-19 Thread Matthew Auld
On Thu, 18 Mar 2021 at 12:47, Christian König wrote: > > Move the iteration of the global lru into the new function > ttm_global_swapout() and use that instead in drivers. > > v2: consistently return int > > Signed-off-by: Christian König For the series, Reviewed-by: Matthew Auld __

Re: [PATCH 02/18] drm/bridge: Add HDMI output fmt helper

2021-03-19 Thread Neil Armstrong
On 18/03/2021 19:31, Jernej Škrabec wrote: > Dne sreda, 17. marec 2021 ob 17:08:07 CET je Neil Armstrong napisal(a): >> On 17/03/2021 16:43, Maxime Ripard wrote: >>> The atomic_get_output_bus_fmts bridge callback is there to list the >>> available formats for output by decreasing order of preferenc

[PATCH V3] drm/ast: Disable fast reset after DRAM initial

2021-03-19 Thread KuoHsiang Chou
[Bug][AST2500] V1: When AST2500 acts as stand-alone VGA so that DRAM and DVO initialization have to be achieved by VGA driver with P2A (PCI to AHB) enabling. However, HW suggests disable Fast reset mode after DRAM initializaton, because fast reset mode is mainly designed for ARM ICE debugger. Once

Re: [PATCH 01/19] drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc

2021-03-19 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Mar 19, 2021 at 9:24 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function > parameter or member 'init' not described in 'init_reserved' > drivers/gpu/drm/nouveau/nv

Re: [PATCH 05/19] drm/nouveau/nvkm/subdev/volt/gk20a: Demote non-conformant kernel-doc headers

2021-03-19 Thread Karol Herbst
On Fri, Mar 19, 2021 at 9:24 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:53: warning: Function > parameter or member 'speedo' not described in 'gk20a_volt_get_cvb_voltage' > drivers/gpu/drm/nouveau/nvkm/subdev/vol

Re: [PATCH 09/19] drm/nouveau/nvkm/engine/gr/gf100: Demote non-conformant kernel-doc header

2021-03-19 Thread Karol Herbst
On Fri, Mar 19, 2021 at 9:25 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:992: warning: Function > parameter or member 'gr' not described in 'gf100_gr_wait_idle' > > Cc: Ben Skeggs > Cc: David Airlie > Cc: Daniel Ve

Re: [PATCH 15/19] drm/nouveau/nv50_display: Remove superfluous prototype for local static functions

2021-03-19 Thread Karol Herbst
On Fri, Mar 19, 2021 at 9:25 AM Lee Jones wrote: > > Fixes the following build error: > > drivers/gpu/drm/nouveau/dispnv50/disp.c:2530:1: error: conflicting types for > ‘nv50_display_fini’ > In file included from drivers/gpu/drm/nouveau/dispnv50/disp.c:71: > drivers/gpu/drm/nouveau/nv50_displa

Re: [PATCH 10/19] drm/nouveau/nouveau_bo: Remove unused variables 'dev'

2021-03-19 Thread Karol Herbst
On Fri, Mar 19, 2021 at 9:25 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nouveau_bo.c: In function ‘nouveau_ttm_tt_populate’: > drivers/gpu/drm/nouveau/nouveau_bo.c:1228:17: warning: variable ‘dev’ set > but not used [-Wunused-but-set-var

Re: [PATCH 19/19] drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment block

2021-03-19 Thread Karol Herbst
On Fri, Mar 19, 2021 at 9:25 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or > member 'filp' not described in 'nouveau_compat_ioctl' > drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Fun

Re: [PATCH 17/19] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc

2021-03-19 Thread Karol Herbst
On Fri, Mar 19, 2021 at 9:25 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nouveau_ioc32.c:2: warning: Cannot understand * > file mga_ioc32.c > > Cc: Ben Skeggs > Cc: David Airlie > Cc: Daniel Vetter > Cc: dri-devel@lists.freedesktop.org

Re: [PATCH 12/19] drm/nouveau/dispnv04/crtc: Demote non-conforming kernel-doc headers

2021-03-19 Thread Karol Herbst
On Fri, Mar 19, 2021 at 9:25 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/dispnv04/crtc.c:462: warning: Function parameter or > member 'crtc' not described in 'nv_crtc_mode_set_regs' > drivers/gpu/drm/nouveau/dispnv04/crtc.c:462: warning:

Re: [PATCH 14/19] drm/nouveau/dispnv50/headc57d: Make local function 'headc57d_olut' static

2021-03-19 Thread Karol Herbst
On Fri, Mar 19, 2021 at 9:25 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/dispnv50/headc57d.c:173:1: warning: no previous > prototype for ‘headc57d_olut’ [-Wmissing-prototypes] > > Cc: Ben Skeggs > Cc: David Airlie > Cc: Daniel Vetter >

Re: [PATCH 02/18] drm/bridge: Add HDMI output fmt helper

2021-03-19 Thread Maxime Ripard
On Fri, Mar 19, 2021 at 10:44:56AM +0100, Neil Armstrong wrote: > On 18/03/2021 19:31, Jernej Škrabec wrote: > > Dne sreda, 17. marec 2021 ob 17:08:07 CET je Neil Armstrong napisal(a): > >> On 17/03/2021 16:43, Maxime Ripard wrote: > >>> The atomic_get_output_bus_fmts bridge callback is there to li

Re: [PATCH] drm: i915: Fix a typo

2021-03-19 Thread Jani Nikula
On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote: > s/nothign/nothing/ > > Signed-off-by: Bhaskar Chowdhury Thanks, pushed. BR, Jani. > --- > drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_d

Re: [PATCH 00/18] drm/vc4: hdmi: Add Support for the YUV output

2021-03-19 Thread Maxime Ripard
Hi Jernej, On Thu, Mar 18, 2021 at 07:16:33PM +0100, Jernej Škrabec wrote: > Dne sreda, 17. marec 2021 ob 16:43:34 CET je Maxime Ripard napisal(a): > > Hi, > > > > Here's an attempt at support the HDMI YUV output on the BCM2711 SoC found on > > the RaspberryPi4. > > > > I took the same approach

Re: [PATCH 18/30] drm/print: Fixup DRM_DEBUG_KMS_RATELIMITED()

2021-03-19 Thread Robert Foss
Hey Lyude, Thanks for the patch, On Fri, 19 Feb 2021 at 22:59, Lyude Paul wrote: > > Since we're about to move drm_dp_helper.c over to drm_dbg_*(), we'll want > to make sure that we can also add ratelimited versions of these macros in > order to retain some of the previous debugging output behav

Re: [PATCH 27/30] drm/dp_mst: Pass drm_dp_mst_topology_mgr to drm_dp_get_vc_payload_bw()

2021-03-19 Thread Robert Foss
Hey Lyude, Thanks for the patch. On Fri, 19 Feb 2021 at 23:03, Lyude Paul wrote: > > Since this is one of the few functions in drm_dp_mst_topology.c that > doesn't have any way of getting access to a drm_device, let's pass the > drm_dp_mst_topology_mgr down to this function so that it can use >

Re: [PATCH 28/30] drm/dp: Convert drm_dp_helper.c to using drm_err/drm_dbg_*()

2021-03-19 Thread Robert Foss
Hey Lyude, Thanks for the patch. On Fri, 19 Feb 2021 at 23:03, Lyude Paul wrote: > > Now that we've added a back-pointer to drm_device to drm_dp_aux, made > drm_dp_aux available to any functions in drm_dp_helper.c which need to > print to the kernel log, and ensured all of our logging uses a con

Re: [PATCH 30/30] drm/dp_mst: Convert drm_dp_mst_topology.c to drm_err()/drm_dbg*()

2021-03-19 Thread Robert Foss
Hey Lyude, Thanks for the patch On Fri, 19 Feb 2021 at 23:03, Lyude Paul wrote: > > And finally, convert all of the code in drm_dp_mst_topology.c over to using > drm_err() and drm_dbg*(). Note that this refactor would have been a lot > more complicated to have tried writing a coccinelle script f

Re: [PATCH] drm/tegra: dc: Restore coupling of display controllers

2021-03-19 Thread Dmitry Osipenko
19.03.2021 10:06, Thierry Reding пишет: > From: Thierry Reding > > Coupling of display controllers used to rely on runtime PM to take the > companion controller out of reset. Commit fd67e9c6ed5a ("drm/tegra: Do > not implement runtime PM") accidentally broke this when runtime PM was > removed. >

Re: [PATCH 1/3] drm/ttm: move swapout logic around v2

2021-03-19 Thread Christian König
General question for the audience: Is there any way to silence the build bot here? This is a well known false positive. Regards, Christian. Am 18.03.21 um 19:13 schrieb kernel test robot: Hi "Christian, I love your patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip]

Re: [PATCH] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

2021-03-19 Thread Fabio Estevam
Hi Dmitry, On Mon, Mar 1, 2021 at 6:41 PM Dmitry Baryshkov wrote: > diff --git a/drivers/gpu/drm/msm/msm_atomic.c > b/drivers/gpu/drm/msm/msm_atomic.c > index 6a326761dc4a..2fd0cf6421ad 100644 > --- a/drivers/gpu/drm/msm/msm_atomic.c > +++ b/drivers/gpu/drm/msm/msm_atomic.c > @@ -207,7 +207,12

Re: [PATCH 3/3] drm/ttm: switch to per device LRU lock

2021-03-19 Thread Christian König
Am 19.03.21 um 05:32 schrieb Huang Rui: On Thu, Mar 18, 2021 at 08:47:19PM +0800, Christian König wrote: Instead of having a global lock. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 8 ++--- drivers/gpu/drm/qxl/qxl_release.c | 5 +-- drivers/gpu/drm/t

[PATCH 3/3] drm/vc4: Add HDR metadata property to the VC5 HDMI connectors

2021-03-19 Thread Maxime Ripard
From: Dave Stevenson Now that we can export deeper colour depths, add in the signalling for HDR metadata. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 53 ++ drivers/gpu/drm/vc4/vc4_hdmi.h | 3 ++ 2 files chan

[PATCH 1/3] drm/connector: Create a helper to attach the hdr_output_metadata property

2021-03-19 Thread Maxime Ripard
All the drivers that implement HDR output call pretty much the same function to initialise the hdr_output_metadata property, and while the creation of that property is in a helper, every driver uses the same code to attach it. Provide a helper for it as well Signed-off-by: Maxime Ripard --- ...

[PATCH 2/3] drm/connector: Add helper to compare HDR metadata

2021-03-19 Thread Maxime Ripard
All the drivers that support the HDR metadata property have a similar function to compare the metadata from one connector state to the next, and force a mode change if they differ. All these functions run pretty much the same code, so let's turn it into an helper that can be shared across those dr

[v1] drm/msm/disp/dpu1: fix display underruns during modeset.

2021-03-19 Thread Kalyan Thota
During crtc disable, display perf structures are reset to 0 which includes state varibles which are immutable. On crtc enable, we use the same structures and they don't refelect the actual values 1) Fix is to avoid updating the state structures during disable. 2) Reset the perf structures during a

Re: [PATCH] drm/tilcdc: fix LCD pixel clock setting

2021-03-19 Thread Jyri Sarha
On 2021-03-18 23:47, Dario Binacchi wrote: Il 17/03/2021 09:19 Tomi Valkeinen ha scritto: On 14/03/2021 17:13, Dario Binacchi wrote: > As reported by TI spruh73x RM, the LCD pixel clock (LCD_PCLK) frequency > is obtained by dividing LCD_CLK, the LCD controller reference clock, > for CLKDIV: >

[PATCH] drm/tegra: sor: Grab runtime PM reference across reset

2021-03-19 Thread Thierry Reding
From: Thierry Reding The SOR resets are exclusively shared with the SOR power domain. This means that exclusive access can only be granted temporarily and in order for that to work, a rigorous sequence must be observed. To ensure that a single consumer gets exclusive access to a reset, each consu

[Bug 212361] New: WARNING: CPU: 0 PID: 411 at drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21/rn_clk_mgr.c:833 rn_clk_mgr_construct+0x2dd/0x440 [amdgpu]

2021-03-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212361 Bug ID: 212361 Summary: WARNING: CPU: 0 PID: 411 at drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21 /rn_clk_mgr.c:833 rn_clk_mgr_construct+0x2dd/0x440 [amdgp

Re: [PATCH 04/19] include: drm: drm_atomic: Make use of 'new_plane_state'

2021-03-19 Thread Ville Syrjälä
On Fri, Mar 19, 2021 at 08:24:13AM +, Lee Jones wrote: > In the macro for_each_oldnew_plane_in_state() 'new_plane_state' is provided > as a container for state->planes[i].new_state, but is not utilised in > some use-cases, so we fake-use it instead. > > Fixes the following W=1 kernel build war

[PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-19 Thread Christian König
Don't print a warning when we fail to allocate a page for swapping things out. Also rely on memalloc_nofs_save/memalloc_nofs_restore instead of GFP_NOFS. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_tt.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drive

Re: [PATCH] drm/amd/display: Set AMDGPU_DM_DEFAULT_MIN_BACKLIGHT to 0

2021-03-19 Thread Alex Deucher
On Fri, Mar 19, 2021 at 3:23 AM Evan Benn wrote: > > AMDGPU_DM_DEFAULT_MIN_BACKLIGHT was set to the value of 12 > to ensure no display backlight will flicker at low user brightness > settings. However this value is quite bright, so for devices that do not > implement the ACPI ATIF > ATIF_FUNCTION_

Re: [PATCH 04/30] drm/bridge/tc358767: Don't register DP AUX channel until bridge is attached

2021-03-19 Thread Robert Foss
Hey Lyude, This patch looks good to me. Reviewed-by: Robert Foss On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote: > > Since this is a bridge, we don't start out with a respective DRM device. > Likewise this means we don't have a connector, which also means that we > should be following drm_dp_a

Re: [PATCH 07/30] drm/bridge/analogix/anx78xx: Add missing drm_dp_aux_unregister() call

2021-03-19 Thread Robert Foss
Hey Lyude, Thanks for the patch, it looks good to me. Reviewed-by: Robert Foss On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote: > > Surprisingly, this bridge actually registers it's AUX adapter at the > correct time already. Nice job! However, it does forget to actually > unregister the AUX ada

Re: [PATCH 08/30] drm/bridge/analogix/anx78xx: Setup encoder before registering connector

2021-03-19 Thread Robert Foss
Hey Lyude, Thanks for the patch, it looks good to me. Reviewed-by: Robert Foss On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote: > > Since encoder mappings for connectors are exposed to userspace, we should > be attaching the encoder before exposing the connector to userspace. Just a > drive-by

Re: [PATCH 09/30] drm/bridge/analogix/anx78xx: Cleanup on error in anx78xx_bridge_attach()

2021-03-19 Thread Robert Foss
Hey Lyude, Thanks for the patch, it looks good to me. Reviewed-by: Robert Foss On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote: > > Just another issue I noticed while correcting usages of > drm_dp_aux_init()/drm_dp_aux_register() around the tree. If any of the > steps in anx78xx_bridge_attach()

Re: [PATCH 10/30] drm/bridge/analogix/anx6345: Add missing drm_dp_aux_unregister() call

2021-03-19 Thread Robert Foss
Hey Lyude, Thanks for the patch, it looks good to me. Reviewed-by: Robert Foss On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote: > > Another driver I found that seems to forget to unregister it's DP AUX > device. Let's fix this by adding anx6345_bridge_detach(). > > Signed-off-by: Lyude Paul >

Re: [PATCH 11/30] drm/bridge/analogix/anx6345: Don't link encoder until after connector registration

2021-03-19 Thread Robert Foss
Hey Lyude, Thanks for the patch, it looks good to me. Reviewed-by: Robert Foss On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote: > > Another case of linking an encoder to a connector after the connector's > been registered. The proper place to do this is before connector > registration, so let's

Re: [PATCH 12/30] drm/bridge/analogix/anx6345: Cleanup on errors in anx6345_bridge_attach()

2021-03-19 Thread Robert Foss
Hey Lyude, Thanks for the patch, it looks good to me. Reviewed-by: Robert Foss On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote: > > Another drive-by fix I found when fixing DP AUX adapter across the kernel > tree - make sure we don't leak resources (and by proxy-AUX adapters) on > failures in a

Re: [PATCH] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

2021-03-19 Thread Rob Clark
On Fri, Mar 19, 2021 at 5:09 AM Fabio Estevam wrote: > > Hi Dmitry, > > On Mon, Mar 1, 2021 at 6:41 PM Dmitry Baryshkov > wrote: > > > diff --git a/drivers/gpu/drm/msm/msm_atomic.c > > b/drivers/gpu/drm/msm/msm_atomic.c > > index 6a326761dc4a..2fd0cf6421ad 100644 > > --- a/drivers/gpu/drm/msm/ms

Re: [PATCH 13/30] drm/bridge/analogix/dp_core: Unregister DP AUX channel on error in analogix_dp_probe()

2021-03-19 Thread Robert Foss
Hey Lyude, Thanks for the patch, it looks good to me. Reviewed-by: Robert Foss On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote: > > Just another drive-by fix I noticed while going through the tree to cleanup > DP aux adapter registration - make sure we unregister the DP AUX dev if > analogix_dp

Re: [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-19 Thread Ville Syrjälä
On Thu, Mar 18, 2021 at 04:01:26PM -0700, Navare, Manasi wrote: > So basically we see this warning only in case of bigjoiner when > drm_atomic_check gets called without setting the state->allow_modeset flag. Considering the code is 'WARN(!state->allow_modeset, ...' that fact should be rather obvio

Re: [PATCH 2/3] drm/connector: Add helper to compare HDR metadata

2021-03-19 Thread kernel test robot
Hi Maxime, I love your patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip linus/master v5.12-rc3 next-20210319] [cannot apply to anholt/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: [PATCH] drm/gma500: use NULL instead of using plain integer as pointer

2021-03-19 Thread Patrik Jakobsson
On Wed, Mar 17, 2021 at 9:27 AM Yang Li wrote: > > This fixes the following sparse warnings: > drivers/gpu/drm/gma500/psb_drv.c:303:56: warning: Using plain integer as > NULL pointer > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Applied to drm-misc-next Thanks Patrik > --- > drivers/

Re: [PATCH] drm/amd/display: Set AMDGPU_DM_DEFAULT_MIN_BACKLIGHT to 0

2021-03-19 Thread Harry Wentland
On 2021-03-19 10:22 a.m., Alex Deucher wrote: On Fri, Mar 19, 2021 at 3:23 AM Evan Benn wrote: AMDGPU_DM_DEFAULT_MIN_BACKLIGHT was set to the value of 12 to ensure no display backlight will flicker at low user brightness settings. However this value is quite bright, so for devices that do n

Re: [PATCH] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

2021-03-19 Thread Fabio Estevam
Hi Rob, On Fri, Mar 19, 2021 at 11:44 AM Rob Clark wrote: > I think that might not help if something fails to probe due to (for > example) a missing dependency, so !priv->kms is probably a better > check to cover both cases. But the 2nd patch makes a good point, that > the suspend/resume path p

Re: [PATCH] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

2021-03-19 Thread Rob Clark
On Fri, Mar 19, 2021 at 8:13 AM Fabio Estevam wrote: > > Hi Rob, > > On Fri, Mar 19, 2021 at 11:44 AM Rob Clark wrote: > > > I think that might not help if something fails to probe due to (for > > example) a missing dependency, so !priv->kms is probably a better > > check to cover both cases. Bu

[PATCH] drm/rockchip: Remove unused variable

2021-03-19 Thread Maxime Ripard
Commit 977697e20b3d ("drm/atomic: Pass the full state to planes atomic disable and update") added the old_state variable instead of what used to be a parameter, but it also removed the sole user of that variable in the vop_plane_atomic_update function leading to an usused variable. Remove it. Fixe

Re: [PATCH] drm/i915/display/vlv_dsi: Do no shut down displays on reboot if a DSI panel is used

2021-03-19 Thread Hans de Goede
Hi, On 3/1/21 4:43 PM, Hans de Goede wrote: > After the recently added commit fe0f1e3bfdfe ("drm/i915: Shut down > displays gracefully on reboot"), the DSI panel on a Cherry Trail based > Predia Basic tablet would no longer properly light up after reboot. > > The backlight still turns back on aft

Re: [PATCH] drm: bridge: adv7511: Support I2S IEC958 encoded PCM format

2021-03-19 Thread Robert Foss
Hey Sia, Thanks for the patch, it looks good to me. Reviewed-by: Robert Foss On Fri, 12 Mar 2021 at 10:09, Sia Jee Heng wrote: > > Support IEC958 encoded PCM format for ADV7511 so that ADV7511 HDMI > audio driver can accept the IEC958 data from the I2S input. > > Signed-off-by: Sia Jee Heng >

[PATCH 1/2] drm/msm: fix shutdown hook in case GPU components failed to bind

2021-03-19 Thread Fabio Estevam
From: Dmitry Baryshkov If GPU components have failed to bind, shutdown callback would fail with the following backtrace. Add safeguard check to stop that oops from happening and allow the board to reboot. [ 66.617046] Unable to handle kernel NULL pointer dereference at virtual address 000

[PATCH 2/2] drm/msm: Fix suspend/resume on i.MX5

2021-03-19 Thread Fabio Estevam
When putting iMX5 into suspend, the following flow is observed: [ 70.023427] [] (msm_atomic_commit_tail) from [] (commit_tail+0x9c/0x18c) [ 70.031890] [] (commit_tail) from [] (drm_atomic_helper_commit+0x1a0/0x1d4) [ 70.040627] [] (drm_atomic_helper_commit) from [] (drm_atomic_helper_disable

Re: [PATCH] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

2021-03-19 Thread Fabio Estevam
On Fri, Mar 19, 2021 at 12:13 PM Fabio Estevam wrote: > Thanks for the feedback. > I will follow the same approach for fixing the suspend/resume path then. > > Let me test it and then I will re-submit Dmitry's patch and the one > for suspend/resume as part of a patch series. This approach works

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-19 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] + Leo From: amd-gfx on behalf of Christian König Sent: Friday, March 19, 2021 10:08 AM To: Liu, Leo ; amd-...@lists.freedesktop.org ; dri-devel@lists.freedesktop.org Subject: [PATCH] drm/ttm: stop warning o

Re: [PATCH 14/19] drm/nouveau/dispnv50/headc57d: Make local function 'headc57d_olut' static

2021-03-19 Thread Lyude Paul
Reviewed-by: Lyude Paul On Fri, 2021-03-19 at 08:24 +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > >  drivers/gpu/drm/nouveau/dispnv50/headc57d.c:173:1: warning: no previous > prototype for ‘headc57d_olut’ [-Wmissing-prototypes] > > Cc: Ben Skeggs > Cc: David Airl

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-19 Thread Daniel Vetter
On Fri, Mar 19, 2021 at 03:08:57PM +0100, Christian König wrote: > Don't print a warning when we fail to allocate a page for swapping things out. > > Also rely on memalloc_nofs_save/memalloc_nofs_restore instead of GFP_NOFS. Uh this part doesn't make sense. Especially since you only do it for the

Re: [RESEND 00/53] Rid GPU from W=1 warnings

2021-03-19 Thread Daniel Vetter
On Fri, Mar 19, 2021 at 08:24:07AM +, Lee Jones wrote: > On Thu, 18 Mar 2021, Daniel Vetter wrote: > > > On Wed, Mar 17, 2021 at 9:32 PM Daniel Vetter wrote: > > > > > > On Wed, Mar 17, 2021 at 9:17 AM Lee Jones wrote: > > > > > > > > On Thu, 11 Mar 2021, Lee Jones wrote: > > > > > > > > > O

Re: [PATCH 06/19] drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the stack to the heap

2021-03-19 Thread Alex Deucher
+ Harry, Nick On Fri, Mar 19, 2021 at 4:24 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function > ‘calculate_bandwidth’: > drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2016:1: warning:

Re: [PATCH V2] drm/bridge: lvds-codec: Add support for pixel data sampling edge select

2021-03-19 Thread Marek Vasut
On 1/24/21 6:04 PM, Marek Vasut wrote: On 12/24/20 7:18 AM, Marek Vasut wrote: The OnSemi FIN3385 Parallel-to-LVDS encoder has a dedicated input line to select input pixel data sampling edge. Add DT property "pixelclk-active", same as the one used by display timings, and configure bus flags base

Re: [PATCH 08/19] drm/amd/display/dc/dce80/dce80_resource: Make local functions static

2021-03-19 Thread Alex Deucher
On Fri, Mar 19, 2021 at 4:24 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:527:17: > warning: no previous prototype for ‘dce80_aux_engine_create’ > [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu

Re: [PATCH 08/19] drm/amd/display/dc/dce80/dce80_resource: Make local functions static

2021-03-19 Thread Harry Wentland
On 2021-03-19 4:24 a.m., Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:527:17: warning: no previous prototype for ‘dce80_aux_engine_create’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/

Re: [PATCH 06/19] drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the stack to the heap

2021-03-19 Thread Harry Wentland
On 2021-03-19 2:13 p.m., Alex Deucher wrote: + Harry, Nick On Fri, Mar 19, 2021 at 4:24 AM Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function ‘calculate_bandwidth’: drivers/gpu/drm/amd/amdgpu/../displ

Re: [PATCH 06/19] drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the stack to the heap

2021-03-19 Thread Alex Deucher
On Fri, Mar 19, 2021 at 2:26 PM Harry Wentland wrote: > > On 2021-03-19 2:13 p.m., Alex Deucher wrote: > > + Harry, Nick > > > > On Fri, Mar 19, 2021 at 4:24 AM Lee Jones wrote: > >> > >> Fixes the following W=1 kernel build warning(s): > >> > >> drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/d

Re: [PATCH 06/19] drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the stack to the heap

2021-03-19 Thread Christian König
Am 19.03.21 um 19:26 schrieb Harry Wentland: On 2021-03-19 2:13 p.m., Alex Deucher wrote: + Harry, Nick On Fri, Mar 19, 2021 at 4:24 AM Lee Jones wrote: Fixes the following W=1 kernel build warning(s):   drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function ‘calculate_b

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-19 Thread Christian König
Am 19.03.21 um 18:52 schrieb Daniel Vetter: On Fri, Mar 19, 2021 at 03:08:57PM +0100, Christian König wrote: Don't print a warning when we fail to allocate a page for swapping things out. Also rely on memalloc_nofs_save/memalloc_nofs_restore instead of GFP_NOFS. Uh this part doesn't make sense

[PATCH v2] drm/etnaviv: add HWDB entry for GC7000 rev 6204

2021-03-19 Thread Lucas Stach
From: Sascha Hauer This is the 3D GPU found on the i.MX8MP SoC. The feature bits are taken from the NXP downstream kernel driver 6.4.3.p1.305572. Signed-off-by: Sascha Hauer Signed-off-by: Lucas Stach --- drivers/gpu/drm/etnaviv/etnaviv_hwdb.c | 31 ++ 1 file changed,

  1   2   >