Re: [PATCH] devfreq: Register devfreq as a cooling device

2021-03-05 Thread Steven Price
On 04/03/2021 12:50, Daniel Lezcano wrote: Currently the default behavior is to manually having the devfreq backend to register themselves as a devfreq cooling device. There are no so many and actually it makes more sense to register the devfreq device when adding it. Consequently, every devfre

Re: [PATCH] drm/uapi: document kernel capabilities

2021-03-05 Thread Pekka Paalanen
On Thu, 4 Mar 2021 23:10:57 +0100 Simon Ser wrote: > Document all of the DRM_CAP_* defines. > > Signed-off-by: Simon Ser > Cc: Daniel Vetter > Cc: Pekka Paalanen > --- > include/uapi/drm/drm.h | 100 +++-- > 1 file changed, 96 insertions(+), 4 deletions(-

[patch 2/7] drm/vmgfx: Replace kmap_atomic()

2021-03-05 Thread Thomas Gleixner
From: Thomas Gleixner There is no reason to disable pagefaults and preemption as a side effect of kmap_atomic_prot(). Use kmap_local_page_prot() instead and document the reasoning for the mapping usage with the given pgprot. Remove the NULL pointer check for the map. These functions return a va

Re: cleanup unused or almost unused IOMMU APIs and the FSL PAMU driver

2021-03-05 Thread Joerg Roedel
On Mon, Mar 01, 2021 at 09:42:40AM +0100, Christoph Hellwig wrote: > Diffstat: > arch/powerpc/include/asm/fsl_pamu_stash.h | 12 > drivers/gpu/drm/msm/adreno/adreno_gpu.c |2 > drivers/iommu/amd/iommu.c | 23 > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 85 -

[patch 0/7] drm, highmem: Cleanup io/kmap_atomic*() usage

2021-03-05 Thread Thomas Gleixner
None of the DRM usage sites of temporary mappings requires the side effects of io/kmap_atomic(), i.e. preemption and pagefault disable. Replace them with the io/kmap_local() variants, simplify the copy_to/from_user() error handling and remove the atomic variants. Thanks, tglx --- Docume

[patch 5/7] drm/nouveau/device: Replace io_mapping_map_atomic_wc()

2021-03-05 Thread Thomas Gleixner
From: Thomas Gleixner Neither fbmem_peek() nor fbmem_poke() require to disable pagefaults and preemption as a side effect of io_mapping_map_atomic_wc(). Use io_mapping_map_local_wc() instead. Signed-off-by: Thomas Gleixner Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@list

Re: [PATCH] devfreq: Register devfreq as a cooling device

2021-03-05 Thread Daniel Lezcano
On 04/03/2021 16:06, Chanwoo Choi wrote: > Hi Daniel, > > As Lukasz's comment, actually some devfreq devices like memory bus > might not affect the thermal critically. In the mainline, > there are four types devfreq as following: > 1. GPU > 2. UFS Storage > 3. DMC (Memory Controller) > 4. Memory b

[PATCH] video: Fix typo issue

2021-03-05 Thread zuoqilin1
From: zuoqilin Change 'frequncy' to 'frequency'. Signed-off-by: zuoqilin --- drivers/video/fbdev/aty/atyfb_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c index e946903a..83b76d3 100644 ---

[patch 3/7] highmem: Remove kmap_atomic_prot()

2021-03-05 Thread Thomas Gleixner
From: Thomas Gleixner No more users. Signed-off-by: Thomas Gleixner Cc: Andrew Morton Cc: linux...@kvack.org --- include/linux/highmem-internal.h | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) --- a/include/linux/highmem-internal.h +++ b/include/linux/highmem-interna

[patch 7/7] io-mapping: Remove io_mapping_map_atomic_wc()

2021-03-05 Thread Thomas Gleixner
From: Thomas Gleixner No more users. Get rid of it and remove the traces in documentation. Signed-off-by: Thomas Gleixner Cc: Andrew Morton Cc: linux...@kvack.org --- Documentation/driver-api/io-mapping.rst | 22 +--- include/linux/io-mapping.h | 42 +-

[PATCH] devfreq: Register devfreq as a cooling device

2021-03-05 Thread Daniel Lezcano
Currently the default behavior is to manually having the devfreq backend to register themselves as a devfreq cooling device. There are no so many and actually it makes more sense to register the devfreq device when adding it. Consequently, every devfreq becomes a cooling device like cpufreq is.

[patch 1/7] drm/ttm: Replace kmap_atomic() usage

2021-03-05 Thread Thomas Gleixner
From: Thomas Gleixner There is no reason to disable pagefaults and preemption as a side effect of kmap_atomic_prot(). Use kmap_local_page_prot() instead and document the reasoning for the mapping usage with the given pgprot. Remove the NULL pointer check for the map. These functions return a va

[PATCH] gpu: drm: swsmu: fix error return code of smu_v11_0_set_allowed_mask()

2021-03-05 Thread Jia-Ju Bai
When bitmap_empty() or feature->feature_num triggers an error, no error return code of smu_v11_0_set_allowed_mask() is assigned. To fix this bug, ret is assigned with -EINVAL as error return code. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_

Re: [PATCH] devfreq: Register devfreq as a cooling device

2021-03-05 Thread Daniel Lezcano
Hi Lukasz, thanks for commenting this patch, On 04/03/2021 14:47, Lukasz Luba wrote: > Hi Daniel, > > On 3/4/21 12:50 PM, Daniel Lezcano wrote: >> Currently the default behavior is to manually having the devfreq >> backend to register themselves as a devfreq cooling device. >> >> There are no s

[patch 6/7] drm/i915: Replace io_mapping_map_atomic_wc()

2021-03-05 Thread Thomas Gleixner
From: Thomas Gleixner None of these mapping requires the side effect of disabling pagefaults and preemption. Use io_mapping_map_local_wc() instead, and clean up gtt_user_read() and gtt_user_write() to use a plain copy_from_user() as the local maps are not disabling pagefaults. Signed-off-by: Th

[patch 4/7] drm/qxl: Replace io_mapping_map_atomic_wc()

2021-03-05 Thread Thomas Gleixner
From: Thomas Gleixner None of these mapping requires the side effect of disabling pagefaults and preemption. Use io_mapping_map_local_wc() instead, rename the related functions accordingly and clean up qxl_process_single_command() to use a plain copy_from_user() as the local maps are not disabli

Re: [PATCH] devfreq: Register devfreq as a cooling device

2021-03-05 Thread Daniel Lezcano
On 05/03/2021 09:12, Steven Price wrote: > On 04/03/2021 12:50, Daniel Lezcano wrote: >> Currently the default behavior is to manually having the devfreq >> backend to register themselves as a devfreq cooling device. >> >> There are no so many and actually it makes more sense to register the >> dev

Re: [PATCH v4 1/2] dt-bindings: display: bridge: Add Chipone ICN6211 bindings

2021-03-05 Thread Robert Foss
Hey Jagan, This looks good to me, feel free to add my r-b. Reviewed-by: Robert Foss On Thu, 4 Mar 2021 at 10:21, Jagan Teki wrote: > > ICN6211 is MIPI-DSI to RGB Converter bridge from Chipone. > > It has a flexible configuration of MIPI DSI signal input and > produces RGB565, RGB666, RGB888 ou

Re: [PATCH v4 2/2] drm: bridge: Add Chipone ICN6211 MIPI-DSI to RGB bridge

2021-03-05 Thread Robert Foss
Hey Jagan, This patch also looks good to me. Reviewed-by: Robert Foss On Thu, 4 Mar 2021 at 10:22, Jagan Teki wrote: > > ICN6211 is MIPI-DSI to RGB Converter bridge from Chipone. > > It has a flexible configuration of MIPI DSI signal input and > produce RGB565, RGB666, RGB888 output format. >

Re: [PATCH] qxl: Fix uninitialised struct field head.surface_id

2021-03-05 Thread Gerd Hoffmann
On Thu, Mar 04, 2021 at 09:49:28AM +, Colin King wrote: > From: Colin Ian King > > The surface_id struct field in head is not being initialized and > static analysis warns that this is being passed through to > dev->monitors_config->heads[i] on an assignment. Clear up this > warning by initia

[PATCH RESEND][next] drm/i915/gem: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a return statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/i915/gem/i915_gem_shri

[PATCH RESEND][next] drm/nouveau/clk: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/nouveau/nvkm/subdev/clk

[PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple of warnings by explicitly adding a couple of break statements instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/n

[PATCH RESEND][next] drm/nouveau/therm: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/nouveau/nvkm/subdev/the

Re: [PATCH v8 1/5] drm: Add a sharable drm page-pool implementation

2021-03-05 Thread Christian König
Am 05.03.21 um 00:20 schrieb John Stultz: This adds a shrinker controlled page pool, extracted out of the ttm_pool logic, and abstracted out a bit so it can be used by other non-ttm drivers. In general please keep the kernel doc which is in TTMs pool. Cc: Daniel Vetter Cc: Christian Koenig

Re: [Freedreno] [PATCH 16/17] iommu: remove DOMAIN_ATTR_IO_PGTABLE_CFG

2021-03-05 Thread Will Deacon
On Thu, Mar 04, 2021 at 03:11:08PM -0800, Rob Clark wrote: > On Thu, Mar 4, 2021 at 7:48 AM Robin Murphy wrote: > > > > On 2021-03-01 08:42, Christoph Hellwig wrote: > > > Signed-off-by: Christoph Hellwig > > > > Moreso than the previous patch, where the feature is at least relatively > > generic

Re: [PATCH 1/3] drm/bridge: ti-sn65dsi86: Simplify refclk handling

2021-03-05 Thread Robert Foss
Hey Douglas, Thanks for submitting this cleanup, it looks good to me. Reviewed-by: Robert Foss On Fri, 5 Mar 2021 at 00:53, Douglas Anderson wrote: > > The clock framework makes it simple to deal with an optional clock. > You can call clk_get_optional() and if the clock isn't specified it'll

Re: [PATCH 2/3] drm/bridge: ti-sn65dsi86: Move code in prep for EDID read fix

2021-03-05 Thread Robert Foss
Hey Douglas, Thanks for splitting this out into its own patch. Reviewed-by: Robert Foss On Fri, 5 Mar 2021 at 00:53, Douglas Anderson wrote: > > This patch is _only_ code motion to prepare for the patch > ("drm/bridge: ti-sn65dsi86: Properly get the EDID, but only if > refclk") and make it eas

Re: [PATCH 0/2] Fix purging buffers in the shmem helpers

2021-03-05 Thread Steven Price
On 23/02/2021 15:51, Neil Roberts wrote: These two patches fix a problem with the madvise purging code for the shmem helpers where the mmaping for a purged buffer wouldn't get invalidated correctly. This presumably ends up as a security hole where the mapping can be accessed from user-space to re

Re: [PATCH 1/3] drm/msm: Fix speed-bin support not to access outside valid memory

2021-03-05 Thread Srinivas Kandagatla
On 27/02/2021 00:26, Douglas Anderson wrote: When running the latest kernel on an sc7180 with KASAN I got this splat: BUG: KASAN: slab-out-of-bounds in a6xx_gpu_init+0x618/0x644 Read of size 4 at addr ff8088f36100 by task kworker/7:1/58 CPU: 7 PID: 58 Comm: kworker/7:1 Not tainted

Re: [PATCH v8 2/5] drm: ttm_pool: Rework ttm_pool to use drm_page_pool

2021-03-05 Thread Christian König
Am 05.03.21 um 00:20 schrieb John Stultz: This patch reworks the ttm_pool logic to utilize the recently added drm_page_pool code. This adds drm_page_pool structures to the ttm_pool_type structures, and then removes all the ttm_pool_type shrinker logic (as its handled in the drm_page_pool shrinke

Re: [PATCH v8 3/5] dma-buf: heaps: Add deferred-free-helper library code

2021-03-05 Thread Christian König
Am 05.03.21 um 00:20 schrieb John Stultz: This patch provides infrastructure for deferring buffer frees. This is a feature ION provided which when used with some form of a page pool, provides a nice performance boost in an allocation microbenchmark. The reason it helps is it allows the page-zero

[PATCH] dma-buf: Fix confusion of dynamic dma-buf vs dynamic attachment

2021-03-05 Thread Chris Wilson
Commit c545781e1c55 ("dma-buf: doc polish for pin/unpin") disagrees with the introduction of dynamism in commit: bb42df4662a4 ("dma-buf: add dynamic DMA-buf handling v15") resulting in warning spew on importing dma-buf. Silence the warning from the latter by only pinning the attachment if the attac

Re: [PATCH] dma-buf: Fix confusion of dynamic dma-buf vs dynamic attachment

2021-03-05 Thread Christian König
Am 05.03.21 um 11:51 schrieb Chris Wilson: Commit c545781e1c55 ("dma-buf: doc polish for pin/unpin") disagrees with the introduction of dynamism in commit: bb42df4662a4 ("dma-buf: add dynamic DMA-buf handling v15") resulting in warning spew on importing dma-buf. Silence the warning from the latte

[PATCH i-g-t 0/2] panfrost: Test accessing a purged buffer via mmap

2021-03-05 Thread Neil Roberts
This adds a test for Panfrost to make sure that accessing a buffer that has been madvised and then purged causes a bus fault. It is intended to test the fix provided by this series: https://patchwork.freedesktop.org/series/87324/ The series has now been merged into drm-misc-fixes (thanks!) In or

[PATCH i-g-t 1/2] lib/panfrost: Add a utility to madvise a buffer

2021-03-05 Thread Neil Roberts
Signed-off-by: Neil Roberts --- lib/igt_panfrost.c | 12 lib/igt_panfrost.h | 1 + 2 files changed, 13 insertions(+) diff --git a/lib/igt_panfrost.c b/lib/igt_panfrost.c index 8b0c2b77..ffce66a2 100644 --- a/lib/igt_panfrost.c +++ b/lib/igt_panfrost.c @@ -127,6 +127,18 @@ void igt_

[PATCH i-g-t 2/2] tests/panfrost: Add a test for accessing a purged buffer

2021-03-05 Thread Neil Roberts
The test creates a buffer, sets it as DONTNEED via madvise, tries to trigger a purge of buffers and then accesses the buffer via a user-space mapping. This should generate a bus error, but due to a bug in the kernel driver it fails to invalidate the mapping when the buffer is purged. Signed-off-by

[PATCH 1/2] drm/sched: select new rq even if there is only one v3

2021-03-05 Thread Christian König
This is necessary when changing priorities of an entity. v2: test the sched_list instead of num_sched. v3: set the sched_list to NULL when there is only one entry Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/sched_entity.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions

[PATCH 2/2] drm/amdgpu: load balance VCN3 decode as well v8

2021-03-05 Thread Christian König
Add VCN3 IB parsing to figure out to which instance we can send the stream for decode. v2: remove VCN instance limit as well, fix amdgpu_cs_find_mapping, check supported formats instead of unsupported. v3: fix typo and error handling v4: make sure the message BO is CPU accessible v5: fix addr

[PATCH v5 2/2] drm/bridge: anx7688: Add ANX7688 bridge driver support

2021-03-05 Thread Dafna Hirschfeld
From: Enric Balletbo i Serra This driver adds support for the ANX7688 HDMI to DP converter block of the ANX7688 device. For our use case, the only reason the Linux kernel driver is necessary is to reject resolutions that require more bandwidth than what is available on the DP side. DP bandwidth

[PATCH v5 0/2] Add support for ANX7688

2021-03-05 Thread Dafna Hirschfeld
ANX7688 is a typec port controller that also converts HDMI to DP. ANX7688 is found on Acer Chromebook R13 (elm) and on Pine64 PinePhone. On Acer Chromebook R13, the device is powered-up and controller by the Embedded Controller. Therefore the dt-bindings requires only the 'compatible' and 'reg' pr

[PATCH v5 1/2] dt-bindings: usb: add analogix,anx7688.yaml

2021-03-05 Thread Dafna Hirschfeld
ANX7688 is a USB Type-C port controller with a MUX. It converts HDMI 2.0 to DisplayPort 1.3 Ultra-HDi (4096x2160p60). The integrated crosspoint switch (the MUX) supports USB 3.1 data transfer along with the DisplayPort Alternate Mode signaling over USB Type-C. Additionally, an on-chip microcontroll

[PATCH 1/3] drm/amdgpu: introduce struct amdgpu_bo_user

2021-03-05 Thread Nirmoy Das
Implement a new struct amdgpu_bo_user as subclass of struct amdgpu_bo and a function to created amdgpu_bo_user bo with a flag to identify the owner. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 44 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_object.h |

[PATCH 3/3] drm/amdgpu: use tiling_flags of struct amdgpu_bo_user

2021-03-05 Thread Nirmoy Das
This flag is only needed for BOs created by amdgpu_gem_object_create(), so we can remove tiling_flags from the base class. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 19 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 1 - 2 files changed, 17 ins

[PATCH 2/3] drm/amdgpu: use amdgpu_bo_create_user() for gem object

2021-03-05 Thread Nirmoy Das
GEM objects encapsulate amdgpu_bo for userspace applications. Now that we have a new amdgpu_bo_user subclass for that purpose, let's use that instead. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/driv

Re: [PATCH 1/3] drm/amdgpu: introduce struct amdgpu_bo_user

2021-03-05 Thread Christian König
Am 05.03.21 um 13:56 schrieb Nirmoy Das: Implement a new struct amdgpu_bo_user as subclass of struct amdgpu_bo and a function to created amdgpu_bo_user bo with a flag to identify the owner. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 44 ++

Re: [PATCH 3/3] drm/amdgpu: use tiling_flags of struct amdgpu_bo_user

2021-03-05 Thread Christian König
Am 05.03.21 um 13:56 schrieb Nirmoy Das: This flag is only needed for BOs created by amdgpu_gem_object_create(), so we can remove tiling_flags from the base class. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 19 +-- drivers/gpu/drm/amd/amdgpu/am

Re: [PATCH 3/3] drm/amdgpu: use tiling_flags of struct amdgpu_bo_user

2021-03-05 Thread Nirmoy
On 3/5/21 2:08 PM, Christian König wrote: Am 05.03.21 um 13:56 schrieb Nirmoy Das: This flag is only needed for BOs created by amdgpu_gem_object_create(), so we can remove tiling_flags from the base class. Signed-off-by: Nirmoy Das ---   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 19 +++

Re: [PATCH 1/2] drm/sched: select new rq even if there is only one v3

2021-03-05 Thread Jiang, Sonny
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Sonny Jiang From: Christian König Sent: Friday, March 5, 2021 7:51 AM To: dri-devel@lists.freedesktop.org ; amd-...@lists.freedesktop.org Cc: Liu, Leo ; Jiang, Sonny Subject: [PATCH 1/2] drm/sch

Re: [PATCH 2/2] drm/amdgpu: load balance VCN3 decode as well v8

2021-03-05 Thread Jiang, Sonny
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Sonny Jiang From: Christian König Sent: Friday, March 5, 2021 7:51 AM To: dri-devel@lists.freedesktop.org ; amd-...@lists.freedesktop.org Cc: Liu, Leo ; Jiang, Sonny Subject: [PATCH 2/2] drm/amd

Re: [PATCH v5 1/2] dt-bindings: usb: add analogix,anx7688.yaml

2021-03-05 Thread Laurent Pinchart
Hi Dafna, Thank you for the patch. On Fri, Mar 05, 2021 at 01:43:50PM +0100, Dafna Hirschfeld wrote: > ANX7688 is a USB Type-C port controller with a MUX. It converts HDMI 2.0 to > DisplayPort 1.3 Ultra-HDi (4096x2160p60). > The integrated crosspoint switch (the MUX) supports USB 3.1 data transfe

[Bug 209457] AMDGPU resume fail with RX 580 GPU

2021-03-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209457 Sven Neumann (ker...@svenfoo.org) changed: What|Removed |Added CC||ker...@svenfoo.org --

Re: [PATCH v5 2/2] drm/bridge: anx7688: Add ANX7688 bridge driver support

2021-03-05 Thread Laurent Pinchart
Hi Dafna, Thank you for the patch. On Fri, Mar 05, 2021 at 01:43:51PM +0100, Dafna Hirschfeld wrote: > From: Enric Balletbo i Serra > > This driver adds support for the ANX7688 HDMI to DP converter block of the > ANX7688 device. > > For our use case, the only reason the Linux kernel driver is

Re: [PATCH 1/3] drm/msm: Fix speed-bin support not to access outside valid memory

2021-03-05 Thread Doug Anderson
Hi, On Fri, Mar 5, 2021 at 2:28 AM Srinivas Kandagatla wrote: > > > > On 27/02/2021 00:26, Douglas Anderson wrote: > > When running the latest kernel on an sc7180 with KASAN I got this > > splat: > >BUG: KASAN: slab-out-of-bounds in a6xx_gpu_init+0x618/0x644 > >Read of size 4 at addr

[Bug 211277] sometimes crash at s2ram-wake (Ryzen 3500U): amdgpu, drm, commit_tail, amdgpu_dm_atomic_commit_tail

2021-03-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211277 --- Comment #12 from kolAflash (kolafl...@kolahilft.de) --- I've tried doing a bisect using this script. Unfortunately I couldn't reproduce the bug this way. So I bisecting will take a lot longer. for i in {0..19}; do echo -e "\n${i}" /usr/sb

Re: [PATCH v3 2/5] phy: Add LVDS configuration options

2021-03-05 Thread Robert Foss
Hey Liu, This patch seems to be included in both this series and the "Add some DRM bridge drivers support for i.MX8qm/qxp SoCs" series. Instead of having the two series have a conflict I would suggest either merging them (if that makes sense) or removing this patch from one of them and explicitly

[Bug 211277] sometimes crash at s2ram-wake (Ryzen 3500U): amdgpu, drm, commit_tail, amdgpu_dm_atomic_commit_tail

2021-03-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211277 --- Comment #13 from Jerome C (m...@jeromec.com) --- (In reply to kolAflash from comment #12) > I've tried doing a bisect using this script. Unfortunately I couldn't > reproduce the bug this way. So I bisecting will take a lot longer. > > for i i

Re: [PATCH v5 1/2] dt-bindings: usb: add analogix,anx7688.yaml

2021-03-05 Thread Dafna Hirschfeld
Hi On 05.03.21 15:34, Laurent Pinchart wrote: Hi Dafna, Thank you for the patch. On Fri, Mar 05, 2021 at 01:43:50PM +0100, Dafna Hirschfeld wrote: ANX7688 is a USB Type-C port controller with a MUX. It converts HDMI 2.0 to DisplayPort 1.3 Ultra-HDi (4096x2160p60). The integrated crosspoint sw

Re: [PATCH v5 2/2] drm/bridge: anx7688: Add ANX7688 bridge driver support

2021-03-05 Thread Dafna Hirschfeld
Adding meg...@megous.com and linux-...@vger.kernel.org to the list Thanks, Dafna On 05.03.21 13:43, Dafna Hirschfeld wrote: From: Enric Balletbo i Serra This driver adds support for the ANX7688 HDMI to DP converter block of the ANX7688 device. For our use case, the only reason the Linux kern

Re: [PATCH v5 1/2] dt-bindings: usb: add analogix,anx7688.yaml

2021-03-05 Thread Laurent Pinchart
Hi Dafna, On Fri, Mar 05, 2021 at 04:14:03PM +0100, Dafna Hirschfeld wrote: > On 05.03.21 15:34, Laurent Pinchart wrote: > > On Fri, Mar 05, 2021 at 01:43:50PM +0100, Dafna Hirschfeld wrote: > >> ANX7688 is a USB Type-C port controller with a MUX. It converts HDMI 2.0 to > >> DisplayPort 1.3 Ultra

Re: [PATCH v3 0/5] phy: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2021-03-05 Thread Robert Foss
Hey Liu, Looking at this series[1], all but patch#2 has been reviewed, and #2 looks good to me. So I think this series is ready to have v4 re-spun and and all of the r-bs from v3 added to the relevant patches. [1] https://patchwork.kernel.org/project/dri-devel/cover/1607651182-12307-1-git-send-e

Re: [PATCH v3 2/5] phy: Add LVDS configuration options

2021-03-05 Thread Robert Foss
On Fri, 5 Mar 2021 at 16:03, Robert Foss wrote: > > Hey Liu, > > This patch seems to be included in both this series and the "Add some > DRM bridge drivers support for i.MX8qm/qxp SoCs" series. Instead of > having the two series have a conflict I would suggest either merging > them (if that makes

Re: [RESEND 00/53] Rid GPU from W=1 warnings

2021-03-05 Thread Roland Scheidegger
The vmwgfx ones look all good to me, so for 23-53: Reviewed-by: Roland Scheidegger That said, they were already signed off by Zack, so not sure what happened here. Roland On 03.03.21 14:42, Lee Jones wrote: > This is a resend. All of these patches have been sent before. > > The vmwgfx ones wer

[Bug 209457] AMDGPU resume fail with RX 580 GPU

2021-03-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209457 --- Comment #21 from Alex Deucher (alexdeuc...@gmail.com) --- Unless you have a polaris board please file your own bug. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the b

Re: [patch 2/7] drm/vmgfx: Replace kmap_atomic()

2021-03-05 Thread Roland Scheidegger
On 03.03.21 14:20, Thomas Gleixner wrote: > From: Thomas Gleixner > > There is no reason to disable pagefaults and preemption as a side effect of > kmap_atomic_prot(). > > Use kmap_local_page_prot() instead and document the reasoning for the > mapping usage with the given pgprot. > > Remove the

Re: [PATCH v2 0/5] drm/panel-simple: Patches for N116BCA-EA1

2021-03-05 Thread Doug Anderson
Hi folks, On Fri, Jan 15, 2021 at 2:44 PM Douglas Anderson wrote: > > This series is to get the N116BCA-EA1 panel working. Most of the > patches are simple, but on hardware I have in front of me the panel > sometimes doesn't come up. I'm still working with the hardware > manufacturer to get to th

Re: Query regarding DRM mastership sharing between multiple process

2021-03-05 Thread Pekka Paalanen
On Thu, 4 Mar 2021 09:43:22 +0530 Hardik Panchal wrote: > Hello Sir/Madam, > > I am trying to render some stuff using DRM with Qt GUI application and > decoded stream from Intel H/w decoder. > > I have two applications one is for GUI content and another one is for > decoded video streams. While

Re: [PATCH 1/3] drm/msm: Fix speed-bin support not to access outside valid memory

2021-03-05 Thread Srinivas Kandagatla
On 05/03/2021 14:45, Doug Anderson wrote: Hi, On Fri, Mar 5, 2021 at 2:28 AM Srinivas Kandagatla wrote: On 27/02/2021 00:26, Douglas Anderson wrote: When running the latest kernel on an sc7180 with KASAN I got this splat: BUG: KASAN: slab-out-of-bounds in a6xx_gpu_init+0x618/0x644

[PATCH v7 1/3] drm/uapi: Add USB connector type

2021-03-05 Thread Noralf Trønnes
Add a connector type for USB connected display panels. Some examples of what current userspace will name the connector: - Weston: "UNNAMED-%d" - Mutter: "Unknown20-%d" - X: "Unknown20-%d" v2: - Update drm_connector_enum_list - Add examples to commit message Acked-by: Daniel Vetter Signed-off-by

[PATCH v7 2/3] drm/probe-helper: Check epoch counter in output_poll_execute()

2021-03-05 Thread Noralf Trønnes
drm_helper_hpd_irq_event() checks the epoch counter to determine connector status change. This was introduced in commit 5186421cbfe2 ("drm: Introduce epoch counter to drm_connector"). Do the same for output_poll_execute() so it can detect other changes beside connection status value changes. v2: -

[PATCH v7 0/3] GUD USB Display driver

2021-03-05 Thread Noralf Trønnes
Hi, A while back I had the idea to turn a Raspberry Pi Zero into a $5 USB to HDMI/SDTV/DPI display adapter. The protocol is open so people are free to make displays implementing it and use this driver, all that's needed is to add a USB vid:pid to the driver for the display. See the wiki[1] for m

[PATCH v7 3/3] drm: Add GUD USB Display driver

2021-03-05 Thread Noralf Trønnes
This adds a USB display driver with the intention that it can be used with future USB interfaced low end displays/adapters. The Linux gadget device driver will serve as the canonical device implementation. The following DRM properties are supported: - Plane rotation - Connector TV properties Ther

[PATCH] drm/komeda: Fix off-by-1 when with readback conn due to rounding

2021-03-05 Thread carsten . haitzler
From: Carsten Haitzler When setting up a readback conenctor that writes data back to memory rather than to an actual output device (HDMI etc.), rounding was ses to round-down. As the DPU uses a higher internal number of bits when generating a color value, this round-down back to 8bit ended up wit

[PATCH v2 2/4] devfreq/drivers/lima: Use devfreq cooling device registration

2021-03-05 Thread Daniel Lezcano
The devfreq core code is able to register the devfreq device as a cooling device if the 'is_cooling_device' flag is set in the profile. Use this flag and remove the cooling device registering code. Signed-off-by: Daniel Lezcano --- drivers/gpu/drm/lima/lima_devfreq.c | 14 +- driver

[PATCH v2 4/4] devfreq/drivers/panfrost: Use devfreq cooling device registration

2021-03-05 Thread Daniel Lezcano
The devfreq core code is able to register the devfreq device as a cooling device if the 'is_cooling_device' flag is set in the profile. Use this flag and remove the cooling device registering code. Tested on rock960. Signed-off-by: Daniel Lezcano --- drivers/gpu/drm/panfrost/panfrost_devfreq.c

[PATCH v2 3/4] devfreq/drivers/msm: Use devfreq cooling device registration

2021-03-05 Thread Daniel Lezcano
The devfreq core code is able to register the devfreq device as a cooling device if the 'is_cooling_device' flag is set in the profile. Use this flag and remove the cooling device registering code. Tested on dragonboard 845c Signed-off-by: Daniel Lezcano --- drivers/gpu/drm/msm/msm_gpu.c | 12

[PATCH] Revert "drm/i915: Propagate errors on awaiting already signaled fences"

2021-03-05 Thread Jason Ekstrand
This reverts commit 9e31c1fe45d555a948ff66f1f0e3fe1f83ca63f7. Ever since that commit, we've been having issues where a hang in one client can propagate to another. In particular, a hang in an app can propagate to the X server which causes the whole desktop to lock up. Signed-off-by: Jason Ekstra

Re: [PATCH] Revert "drm/i915: Propagate errors on awaiting already signaled fences"

2021-03-05 Thread Chris Wilson
Quoting Jason Ekstrand (2021-03-05 17:05:46) > This reverts commit 9e31c1fe45d555a948ff66f1f0e3fe1f83ca63f7. Ever > since that commit, we've been having issues where a hang in one client > can propagate to another. In particular, a hang in an app can propagate > to the X server which causes the w

Re: [PATCH 1/1] drm/ttm: Ignore signaled move fences

2021-03-05 Thread Felix Kuehling
It fixed an intermittent failure to allocate page tables in the page fault handler (turning retry faults into no-retry faults). I'm not sure if this caused real problems. I think it could potentially result in fault storms and a failure to report page faults properly. I'm not sure if it's a regress

Re: [PATCH] drm/amdgpu/display: Remove unnecessary conversion to bool

2021-03-05 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Mar 4, 2021 at 3:02 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:956:52-57: WARNING: > conversion to bool not needed here. > > ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:8311:16-

Re: [Freedreno] [PATCH] drm/msm/dp: Fix warnings reported by kbot in DP driver

2021-03-05 Thread abhinavk
Hi Stephen Thanks for the review. I will break this up into patches according to the class of warning to show the warning in the commit text and resend the patches. Abhinav On 2021-03-04 23:23, Dan Carpenter wrote: On Thu, Mar 04, 2021 at 10:55:58PM -0800, Stephen Boyd wrote: > @@ -368,44 +3

Re: [PATCH][next] drm/amd/display: remove redundant initialization of variable status

2021-03-05 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Mar 3, 2021 at 9:07 AM Colin King wrote: > > From: Colin Ian King > > The variable status is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Co

[PATCH 0/7] Microship SAMA5D4 VPU support et al

2021-03-05 Thread Emil Velikov
Hi all, This series adds support for the Microchip SAMA5D4 VPU, which it based on the Hantro G1. The hardware can support up-to 1280x720 for each of the MPEG2, VP8 and H264 codecs. There is only a single decoder and no encoders on the SoC. To minimise duplication, the series starts with a few sm

[PATCH 1/7] media: hantro: use G1_REG_INTERRUPT directly for the mpeg2

2021-03-05 Thread Emil Velikov
From: Emil Velikov Use the register directly over the existing SWREG(). Ideally we'll port the driver away from the local registers, but for now this is enough. For context - I was reading through the IRQ register handling across the variants. Cc: Ezequiel Garcia Cc: Philipp Zabel Cc: linux-m

[PATCH 2/7] media: hantro: imx: reuse MB_DIM define

2021-03-05 Thread Emil Velikov
From: Emil Velikov Swap the hardcoded 16 with MB_DIM define. Cc: Ezequiel Garcia Cc: Philipp Zabel Cc: linux-me...@vger.kernel.org Cc: linux-rockc...@lists.infradead.org Signed-off-by: Emil Velikov --- drivers/staging/media/hantro/imx8m_vpu_hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 d

[PATCH 3/7] media: hantro: imx: remove duplicate dec_base init

2021-03-05 Thread Emil Velikov
From: Emil Velikov The vpu->dec_base is already set by the hantro driver itself. Cc: Ezequiel Garcia Cc: Philipp Zabel Cc: linux-me...@vger.kernel.org Cc: linux-rockc...@lists.infradead.org Signed-off-by: Emil Velikov --- drivers/staging/media/hantro/imx8m_vpu_hw.c | 1 - 1 file changed, 1 d

[PATCH 4/7] media: hantro: imx: remove unused include

2021-03-05 Thread Emil Velikov
From: Emil Velikov The current imx8 code does not use the jpeg encoder. Remove the unnecessary include. Cc: Ezequiel Garcia Cc: Philipp Zabel Cc: linux-me...@vger.kernel.org Cc: linux-rockc...@lists.infradead.org Signed-off-by: Emil Velikov --- drivers/staging/media/hantro/imx8m_vpu_hw.c | 1

[PATCH 6/7] ARM: configs: at91: sama5: update with savedefconfig

2021-03-05 Thread Emil Velikov
From: Emil Velikov While enabling an extra config, I've noticed that savedefconfig produced a notable delta. Split out the no-op changes for clarity sake. Cc: Ezequiel Garcia Cc: Philipp Zabel Cc: linux-me...@vger.kernel.org Cc: linux-rockc...@lists.infradead.org Signed-off-by: Emil Velikov -

[PATCH 7/7] ARM: dts: at91: sama5d4: add vdec0 component

2021-03-05 Thread Emil Velikov
From: Emil Velikov The SoC features a Hantro G1 compatible video decoder. Cc: Ezequiel Garcia Cc: Philipp Zabel Cc: linux-me...@vger.kernel.org Cc: linux-rockc...@lists.infradead.org Signed-off-by: Emil Velikov --- arch/arm/boot/dts/sama5d4.dtsi| 9 ++ arch/arm/configs/sama

[PATCH 5/7] media: hantro: introduce hantro_g1.c for common API

2021-03-05 Thread Emil Velikov
From: Emil Velikov The Hantro G1 IRQ and reset handling it pretty standard. I was this close to duplicating it, yet again, before reconsidering and refactoring it to a separate file. Cc: Ezequiel Garcia Cc: Philipp Zabel Cc: linux-me...@vger.kernel.org Cc: linux-rockc...@lists.infradead.org Si

Re: [PATCH][next] drm/amdgpu/display: remove redundant continue statement

2021-03-05 Thread Alex Deucher
Applied. thanks. Alex On Wed, Mar 3, 2021 at 8:25 AM Colin King wrote: > > From: Colin Ian King > > The continue statement in a for-loop is redudant and can be removed. > Clean up the code to address this. > > Addresses-Coverity: ("Continue as no effect") > Fixes: b6f91fc183f7 ("drm/amdgpu/dis

Re: [PATCH][next] drm/radeon/si_dpm: Replace one-element array with flexible-array in struct SISLANDS_SMC_SWSTATE

2021-03-05 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Mar 3, 2021 at 2:05 PM Gustavo A. R. Silva wrote: > > There is a regular need in the kernel to provide a way to declare having > a dynamically sized set of trailing elements in a structure. Kernel code > should always use “flexible array members”[1] for these cases

Re: [PATCH] drm/amd/display: Remove unnecessary conversion to bool

2021-03-05 Thread Alex Deucher
The same patch was already applied a while ago. Thanks, Alex On Fri, Mar 5, 2021 at 1:41 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:8257:16-21: WARNING: > conversion to bool not needed here. > > Reported-by: Abaci R

Re: [PATCH v7] dt-bindings: display: panel: one file of all simple LVDS panels with dual ports

2021-03-05 Thread Rob Herring
On Thu, 11 Feb 2021 12:27:52 +0800, Liu Ying wrote: > To complement panel-simple.yaml, create panel-simple-lvds-dual-ports.yaml. > panel-simple-lvds-dual-ports.yaml is for all simple LVDS panels that > have dual LVDS ports and require only a single power-supply. > The first port receives odd pixels

[PATCH 2/3] drm/msm/dp: Fix incorrect NULL check kbot warnings in DP driver

2021-03-05 Thread Abhinav Kumar
Fix an incorrect NULL check reported by kbot in the MSM DP driver smatch warnings: drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect() error: we previously assumed 'hpd_priv->dp_cb' could be null (see line 37) Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Abhinav Kuma

[PATCH 1/3] drm/msm/dp: Fix indentation kbot warnings in DP driver

2021-03-05 Thread Abhinav Kumar
Fix a couple of indentation warnings reported by kbot across MSM DP driver: New smatch warnings: drivers/gpu/drm/msm/dp/dp_debug.c:229 dp_test_data_show() warn: inconsistent indenting drivers/gpu/drm/msm/dp/dp_power.c:203 dp_power_clk_enable() warn: inconsistent indenting Reported-by: kernel tes

[PATCH 3/3] drm/msm/dp: delete unnecessary debugfs error handling

2021-03-05 Thread Abhinav Kumar
Currently the error checking logic in the dp_debug module could pass zero to PTR_ERR and it causes the below kbot warnings: drivers/gpu/drm/msm/dp/dp_debug.c:378 dp_debug_init() warn: passing zero to 'PTR_ERR' drivers/gpu/drm/msm/dp/dp_debug.c:387 dp_debug_init() warn: passing zero to 'PTR_ERR' dr

Re: [PATCH][next] drm/radeon/si_dpm: Replace one-element array with flexible-array in struct SISLANDS_SMC_SWSTATE

2021-03-05 Thread Gustavo A. R. Silva
On Fri, Mar 05, 2021 at 02:10:44PM -0500, Alex Deucher wrote: > Applied. Thanks! Awesome. :) Thanks, Alex. -- Gustavo ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 212077] New: AMD GPU at highest frequency even not in use

2021-03-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212077 Bug ID: 212077 Summary: AMD GPU at highest frequency even not in use Product: Drivers Version: 2.5 Kernel Version: 5.11.3 Hardware: All OS: Linux Tree: Mainli

[Bug 212077] AMD GPU discrete card memory at highest frequency even not in use

2021-03-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212077 Bat Malin (bat_ma...@abv.bg) changed: What|Removed |Added Summary|AMD GPU at highest |AMD GPU discrete card

  1   2   >