Re: [PATCH 00/31] Introduce devm_pm_opp_* API

2021-03-03 Thread Dmitry Osipenko
03.03.2021 07:01, Viresh Kumar пишет: > On 02-03-21, 16:40, Dmitry Osipenko wrote: >> 20.01.2021 19:01, Dmitry Osipenko пишет: >>> 01.01.2021 19:54, Yangtao Li пишет: Hi, This patchset add devm_pm_opp_set_clkname, devm_pm_opp_put_clkname, devm_pm_opp_set_regulators, devm_pm_opp_

[PATCH v7] drm: Use USB controller's DMA mask when importing dmabufs

2021-03-03 Thread Thomas Zimmermann
USB devices cannot perform DMA and hence have no dma_mask set in their device structure. Therefore importing dmabuf into a USB-based driver fails, which breaks joining and mirroring of display in X11. For USB devices, pick the associated USB controller as attachment device. This allows the DRM imp

Re: [PATCH 1/8] clk: Add range accessors

2021-03-03 Thread Maxime Ripard
Hi Stephen, On Tue, Mar 02, 2021 at 03:18:58PM -0800, Stephen Boyd wrote: > Quoting Maxime Ripard (2021-02-25 07:59:02) > > Some devices might need to access the current available range of a clock > > to discover their capabilities. Let's add those accessors. > > This needs more than two sentence

Re: [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-03 Thread Pekka Paalanen
On Tue, 2 Mar 2021 12:41:32 -0800 Manasi Navare wrote: > In case of a modeset where a mode gets split across mutiple CRTCs > in the driver specific implementation (bigjoiner in i915) we wrongly count > the affected CRTCs based on the drm_crtc_mask and indicate the stolen CRTC as > an affected CR

Re: [PATCH] drm/ttm: ioremap buffer according to TTM mem caching setting

2021-03-03 Thread Thomas Zimmermann
Hi Am 01.03.21 um 23:43 schrieb Oak Zeng: If tbo.mem.bus.caching is cached, buffer is intended to be mapped as cached from CPU. Map it with ioremap_cache. Just a question for my understanding: This is on-device memory? Accessing device memory is usually slow. If that memory can be mapped wit

[PATCH] drm/tilcdc: panel: fix platform_no_drv_owner.cocci warnings

2021-03-03 Thread Yang Li
./drivers/gpu/drm/tilcdc/tilcdc_panel.c:402:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 1 - 1 file changed, 1 deletion(-) dif

Re: [PATCH] drm: fix drm_mode_create_blob comment

2021-03-03 Thread Lionel Landwerlin
On 02/03/2021 20:48, Simon Ser wrote: On Tuesday, March 2nd, 2021 at 7:47 PM, Lionel Landwerlin wrote: Thanks Simon. Do you have the rights to push this patch? Ah, since you're asking about this, it probably means you don't have the rights. I'll push the patch now to drm-misc-next. Thanks

[PATCH] drm/amdgpu: Remove unnecessary conversion to bool

2021-03-03 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:2252:40-45: WARNING: conversion to bool not needed here. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 1/1] drm/scheduler: fix typos

2021-03-03 Thread Nirmoy Das
Fix two typos in struct drm_sched_entity doc Signed-off-by: Nirmoy Das --- include/drm/gpu_scheduler.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h index 1c815e0a14ed..3782a49568b0 100644 --- a/include/drm/gpu_s

[PULL] drm-misc-next

2021-03-03 Thread Maxime Ripard
Hi Dave, Daniel, Here's the first round of drm-misc-next changes for 5.13. Maxime drm-misc-next-2021-03-03: drm-misc-next for 5.13: UAPI Changes: Cross-subsystem Changes: Core Changes: - %p4cc printk format modifier - atomic: introduce drm_crtc_commit_wait, rework atomic plane state h

re: drm/amd/display: Implement dmub trace event

2021-03-03 Thread Colin Ian King
Hi, Static analysis on linux-next wit Coverity has found a potential null pointer dereference in commit: commit 70732504c53b2d3aae2cebc457515a304672d5bb Author: Yongqiang Sun Date: Fri Feb 19 14:50:23 2021 -0500 drm/amd/display: Implement dmub trace event The analysis is as follows: 400

Re: [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

2021-03-03 Thread Nicolas Boichat
On Mon, Mar 1, 2021 at 4:59 PM Linus Walleij wrote: > > On Thu, Feb 11, 2021 at 4:34 AM Nicolas Boichat wrote: > > > Many of the DSI flags have names opposite to their actual effects, > > e.g. MIPI_DSI_MODE_EOT_PACKET means that EoT packets will actually > > be disabled. Fix this by including _NO

Re: [PATCH] drm/ttm: ioremap buffer according to TTM mem caching setting

2021-03-03 Thread Christian König
Hi Thomas, Am 03.03.21 um 09:49 schrieb Thomas Zimmermann: Hi Am 01.03.21 um 23:43 schrieb Oak Zeng: If tbo.mem.bus.caching is cached, buffer is intended to be mapped as cached from CPU. Map it with ioremap_cache. Just a question for my understanding: This is on-device memory? Accessing dev

Re: [PATCH] drm/ttm: ioremap buffer according to TTM mem caching setting

2021-03-03 Thread Christian König
Hi Oak, config: parisc-randconfig-r012-20210302 (attached as .config) It's not the Intel driver build which fails here, but the build bot is just hosted by Intel. The problem is that the parisc architecture doesn't defines the ioremap_cache() function. I've looked at using memremap() ins

Re: [PATCH v7] drm: Use USB controller's DMA mask when importing dmabufs

2021-03-03 Thread Noralf Trønnes
Den 03.03.2021 09.45, skrev Thomas Zimmermann: > USB devices cannot perform DMA and hence have no dma_mask set in their > device structure. Therefore importing dmabuf into a USB-based driver > fails, which breaks joining and mirroring of display in X11. > > For USB devices, pick the associated U

[PATCH V2 0/2] Add virtual hardware module

2021-03-03 Thread Sumera Priyadarsini
This patchset adds support for emulating virtual hardware with VKMS. The virtual hardware mode can be enabled by using the following command while loading the module: sudo modprobe vkms enable_virtual_hw=1 The first patch adds virtual hardware support as a module option. The second patch a

[PATCH V2 1/2] drm/vkms: Add support for virtual hardware mode

2021-03-03 Thread Sumera Priyadarsini
Add a virtual hardware or vblank-less mode as a module to enable VKMS to emulate virtual graphic drivers. Two new functions vkms_composer_common() and vkms_crtc_composer() have been added. The actual plane composition work has been moved to vkms_composer_common() which is called by both vkms_compo

[PATCH V2 2/2] drm/vkms: Add crtc atomic helper functions for virtual mode

2021-03-03 Thread Sumera Priyadarsini
Add a new drm_crtc_helper_funcs struct, vkms_virtual_crtc_helper_funcs() which holds the atomic helpers for virtual hardware mode. Change the existing vkms_crtc_helper_funcs struct to vkms_vblank_crtc_helper_funcs which holds atomic helpers for the vblank mode. This patch makes the code flow clear

[PATCH][next] drm/amdgpu/display: remove redundant continue statement

2021-03-03 Thread Colin King
From: Colin Ian King The continue statement in a for-loop is redudant and can be removed. Clean up the code to address this. Addresses-Coverity: ("Continue as no effect") Fixes: b6f91fc183f7 ("drm/amdgpu/display: buffer INTERRUPT_LOW_IRQ_CONTEXT interrupt work") Signed-off-by: Colin Ian King -

Re: [PATCH v7] drm: Use USB controller's DMA mask when importing dmabufs

2021-03-03 Thread Thomas Zimmermann
Hi, thanks for reviewing. This will be fixed in the next iteration. Best regards Thomas Am 03.03.21 um 11:58 schrieb Noralf Trønnes: Den 03.03.2021 09.45, skrev Thomas Zimmermann: USB devices cannot perform DMA and hence have no dma_mask set in their device structure. Therefore importing dm

[PATCH v8] drm: Use USB controller's DMA mask when importing dmabufs

2021-03-03 Thread Thomas Zimmermann
USB devices cannot perform DMA and hence have no dma_mask set in their device structure. Therefore importing dmabuf into a USB-based driver fails, which breaks joining and mirroring of display in X11. For USB devices, pick the associated USB controller as attachment device. This allows the DRM imp

[RESEND 00/53] Rid GPU from W=1 warnings

2021-03-03 Thread Lee Jones
This is a resend. All of these patches have been sent before. The vmwgfx ones were even applied, but were dropped for some reason. Lee Jones (53): drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc drm/nouveau/dispnv50/disp: Remove unused variable 'ret' drm/msm/dp/dp_dis

[PATCH 01/53] drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function parameter or member 'init' not described in 'init_reserved' drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:611: warning: Function parameter or member 'init' not described in

[PATCH 02/53] drm/nouveau/dispnv50/disp: Remove unused variable 'ret'

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv50/disp.c:1381:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org Signed

[PATCH 04/53] drm/amd/display/dc/bios/command_table: Remove unused variable

2021-03-03 Thread Lee Jones
None of the surrounding code was removed just in case even a small fraction of it was functional. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c: In function ‘adjust_display_pll_v2’: drivers/gpu/drm/amd/amdgpu/../display/dc/bios/c

[PATCH 05/53] include: drm: drm_atomic: Make use of 'new_plane_state'

2021-03-03 Thread Lee Jones
In the macro for_each_oldnew_plane_in_state() 'new_plane_state' is provided as a container for state->planes[i].new_state, but is not utilised in some use-cases, so we fake-use it instead. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.

[PATCH 03/53] drm/msm/dp/dp_display: Remove unused variable 'hpd'

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/dp/dp_display.c: In function ‘dp_display_usbpd_attention_cb’: drivers/gpu/drm/msm/dp/dp_display.c:496:19: warning: variable ‘hpd’ set but not used [-Wunused-but-set-variable] Cc: Rob Clark Cc: Sean Paul Cc: David Airlie C

[PATCH 06/53] drm/nouveau/nvkm/subdev/volt/gk20a: Demote non-conformant kernel-doc headers

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:53: warning: Function parameter or member 'speedo' not described in 'gk20a_volt_get_cvb_voltage' drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:53: warning: Function parameter or member 's_scale

[PATCH 08/53] drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the stack to the heap

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function ‘calculate_bandwidth’: drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2016:1: warning: the frame size of 1216 bytes is larger than 1024 bytes [-Wframe-larger-tha

[PATCH 07/53] drm/amd/display/dc/bios/command_table: Remove unused variable and associated comment

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c: In function ‘adjust_display_pll_v2’: drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1462:11: warning: unused variable ‘pixel_clock_10KHz_in’ [-Wunused-variable] Cc: H

[PATCH 09/53] drm/amd/display/dc/calcs/dce_calcs: Remove some large variables from the stack

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function ‘bw_calcs_init’: drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2726:1: warning: the frame size of 1336 bytes is larger than 1024 bytes [-Wframe-larger-than=] C

[PATCH 10/53] drm/amd/display/dc/dce/dce_aux: Remove duplicate line causing 'field overwritten' issue

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:59: drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_11_2_sh_mask.h:10014:58: warning: initialized field overwritten [-Woverride-init] drivers/gpu/dr

[PATCH 11/53] drm/amd/display/dc/dce80/dce80_resource: Make local functions static

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:527:17: warning: no previous prototype for ‘dce80_aux_engine_create’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:565:20: warning: no prev

[PATCH 12/53] drm/nouveau/nvkm/engine/gr/gf100: Demote non-conformant kernel-doc header

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:992: warning: Function parameter or member 'gr' not described in 'gf100_gr_wait_idle' Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouv...@lists.freede

[PATCH 13/53] drm/nouveau/nouveau_bo: Remove unused variables 'dev'

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_bo.c: In function ‘nouveau_ttm_tt_populate’: drivers/gpu/drm/nouveau/nouveau_bo.c:1228:17: warning: variable ‘dev’ set but not used [-Wunused-but-set-variable] drivers/gpu/drm/nouveau/nouveau_bo.c: In function ‘no

[PATCH 14/53] drm/nouveau/nouveau_display: Remove set but unused variable 'width'

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_display.c: In function ‘nouveau_framebuffer_new’: drivers/gpu/drm/nouveau/nouveau_display.c:309:15: warning: variable ‘width’ set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs Cc: David Airlie Cc: Dan

[PATCH 15/53] drm/nouveau/dispnv04/crtc: Demote non-conforming kernel-doc headers

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv04/crtc.c:462: warning: Function parameter or member 'crtc' not described in 'nv_crtc_mode_set_regs' drivers/gpu/drm/nouveau/dispnv04/crtc.c:462: warning: Function parameter or member 'mode' not described in 'nv_crt

[PATCH 16/53] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' from function returning void

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv50/disp.c: In function ‘nv50_mstm_cleanup’: drivers/gpu/drm/nouveau/dispnv50/disp.c:1357:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter C

[PATCH 17/53] drm/nouveau/dispnv50/headc57d: Make local function 'headc57d_olut' static

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv50/headc57d.c:173:1: warning: no previous prototype for ‘headc57d_olut’ [-Wmissing-prototypes] Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: Lyude Paul Cc: dri-devel@lists.freedesktop.org Cc: nouv...@list

[PATCH 18/53] drm/nouveau/nv50_display: Remove superfluous prototype for local static functions

2021-03-03 Thread Lee Jones
Fixes the following build error: drivers/gpu/drm/nouveau/dispnv50/disp.c:2530:1: error: conflicting types for ‘nv50_display_fini’ In file included from drivers/gpu/drm/nouveau/dispnv50/disp.c:71: drivers/gpu/drm/nouveau/nv50_display.h:36:6: note: previous declaration of ‘nv50_display_fini’ wa

[PATCH 19/53] drm/nouveau/dispnv50/disp: Include header containing our prototypes

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv50/disp.c:2599:1: warning: no previous prototype for ‘nv50_display_create’ [-Wmissing-prototypes] Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouv...@lists.freedesktop

[PATCH 21/53] drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void function

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_svm.c: In function ‘nouveau_pfns_map’: drivers/gpu/drm/nouveau/nouveau_svm.c:810:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri

[PATCH 20/53] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_ioc32.c:2: warning: Cannot understand * file mga_ioc32.c Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org Signed-off-by: Lee Jones --- dr

[PATCH 22/53] drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment block

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or member 'filp' not described in 'nouveau_compat_ioctl' drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or member 'cmd' not described in 'nouveau_co

[PATCH 23/53] drm/vmwgfx/vmwgfx_execbuf: Fix some kernel-doc related issues

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:89: warning: Enum value 'vmw_res_rel_max' not described in enum 'vmw_resource_relocation_type' drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:136: warning: Function parameter or member 'func' not described in 'vm

[PATCH 25/53] drm/vmwgfx/vmwgfx_kms: Mark vmw_{cursor, primary}_plane_formats as __maybe_unused

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:256:23: warning: ‘vmw_cursor_plane_formats’ defined but not used [-Wunused-const-variable=] drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:248:23: warning: ‘vmw_primary_plane_formats’ defined but not used [-Wunused-const

[PATCH 24/53] drm/vmwgfx/vmwgfx_kms: Remove unused variable 'ret' from 'vmw_du_primary_plane_atomic_check()'

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_kms.c: In function ‘vmw_du_primary_plane_atomic_check’: drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:460:31: warning: variable ‘vcs’ set but not used [-Wunused-but-set-variable] Cc: VMware Graphics Cc: Roland Scheidegger

[PATCH 26/53] drm/vmwgfx/vmwgfx_drv: Fix some kernel-doc misdemeanours

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:164: warning: Function parameter or member 'ioctl' not described in 'VMW_IOCTL_DEF' drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:164: warning: Function parameter or member 'func' not described in 'VMW_IOCTL_DEF' drive

[PATCH 27/53] drm/vmwgfx/vmwgfx_ioctl: Provide missing '@' sign required by kernel-doc

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c:30: drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c:448: warning: Function parameter or member 'offset' not described in 'vmw_fops_read' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Air

[PATCH 29/53] drm/vmwgfx/vmwgfx_ttm_buffer: Supply some missing parameter descriptions

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c:275: warning: Function parameter or member 'p_offset' not described in 'vmw_piter_start' drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c:676: warning: Function parameter or member 'evict' not described in 'v

[PATCH 30/53] drm/vmwgfx/vmwgfx_fifo: Demote non-conformant kernel-doc header

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c:299: warning: Function parameter or member 'dev_priv' not described in 'vmw_local_fifo_reserve' drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c:299: warning: Function parameter or member 'bytes' not described in 'vmw_lo

[PATCH 28/53] drm/vmwgfx/vmwgfx_resource: Fix worthy function headers demote some others

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:215: warning: Excess function parameter 'obj_type' description in 'vmw_resource_init' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:303: warning: Excess function parameter 'p_res' description in 'vmw_user_reso

[PATCH 31/53] drm/vmwgfx/vmwgfx_ldu: Supply descriptions for 'state' function parameter

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c:55: warning: cannot understand function prototype: 'struct vmw_legacy_display_unit ' drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c:218: warning: Function parameter or member 'state' not described in 'vmw_ldu_crtc_atomic

[PATCH 32/53] drm/vmwgfx/vmwgfx_kms: Update worthy function headers and demote others

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:37: drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:483: warning: Function parameter or member 'new_state' not described in 'vmw_du_cursor_plane_atomic_check' drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:483:

[PATCH 33/53] drm/vmwgfx/vmwgfx_overlay: Demote kernel-doc abuses to standard comment blocks

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:48: warning: cannot understand function prototype: 'struct vmw_overlay ' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:98: warning: Function parameter or member 'dev_priv' not described in 'vmw_overlay_send_put'

[PATCH 34/53] drm/vmwgfx/vmwgfx_fence: Add, remove and demote various documentation params/headers

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:82: warning: Function parameter or member 'event' not described in 'vmw_event_fence_action' drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:113: warning: Function parameter or member 'f' not described in 'vmw_fence_ob

[PATCH 35/53] drm/vmwgfx/vmwgfx_bo: Remove superfluous param description and supply another

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_bo.c:142: warning: Excess function parameter 'pin' description in 'vmw_bo_pin_in_vram_or_gmr' drivers/gpu/drm/vmwgfx/vmwgfx_bo.c:647: warning: Function parameter or member 'p_base' not described in 'vmw_user_bo_allo

[PATCH 37/53] drm/vmwgfx/vmwgfx_scrn: Demote unworthy kernel-doc headers and update others

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:90: warning: cannot understand function prototype: 'struct vmw_screen_object_unit ' drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:122: warning: Function parameter or member 'dev_priv' not described in 'vmw_sou_fifo_cr

[PATCH 36/53] drm/vmwgfx/vmwgfx_context: Demote kernel-doc abuses

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_context.c:121: warning: Function parameter or member 'dev_priv' not described in 'vmw_context_cotables_unref' drivers/gpu/drm/vmwgfx/vmwgfx_context.c:121: warning: Function parameter or member 'uctx' not described i

[PATCH 38/53] drm/vmwgfx/vmwgfx_surface: Fix some kernel-doc related issues

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:55: warning: Function parameter or member 'prime' not described in 'vmw_user_surface' drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:55: warning: Function parameter or member 'backup_base' not described in 'vmw_u

[PATCH 39/53] drm/vmwgfx/vmwgfx_cmdbuf_res: Rename param description and remove another

2021-03-03 Thread Lee Jones
Also fix a small formatting issue. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c:83: warning: Function parameter or member 'res_type' not described in 'vmw_cmdbuf_res_lookup' drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c:83: warning: Excess function

[PATCH 42/53] drm/vmwgfx/vmwgfx_cmdbuf_res: Remove unused variable 'ret'

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c: In function ‘vmw_cmdbuf_res_revert’: drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c:162:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: VMware Graphics Cc: Roland Scheidegger

[PATCH 40/53] drm/vmwgfx/vmwgfx_shader: Demote kernel-doc abuses and fix-up worthy headers

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_shader.c:134: warning: Function parameter or member 'res' not described in 'vmw_res_to_shader' drivers/gpu/drm/vmwgfx/vmwgfx_shader.c:663: warning: Function parameter or member 'base' not described in 'vmw_user_shad

[PATCH 41/53] drm/vmwgfx/vmwgfx_cmdbuf: Fix a bunch of missing or incorrectly formatted/named params

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:58: warning: Function parameter or member 'block_submission' not described in 'vmw_cmdbuf_context' drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:109: warning: cannot understand function prototype: 'struct vmw_cmdb

[PATCH 45/53] drm/vmwgfx/vmwgfx_cotable: Fix a couple of simple documentation problems

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c:72: warning: Function parameter or member 'unbind_func' not described in 'vmw_cotable_info' drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c:308: warning: Function parameter or member 'val_buf' not described in 'vm

[PATCH 44/53] drm/vmwgfx/vmwgfx_cmdbuf: Fix misnaming of 'headers' should be plural

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:137: warning: Function parameter or member 'headers' not described in 'vmw_cmdbuf_man' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.fr

[PATCH 43/53] drm/vmwgfx/vmwgfx_stdu: Add some missing param/member descriptions

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:77: warning: Function parameter or member 'pitch' not described in 'vmw_stdu_dirty' drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:125: warning: Function parameter or member 'content_fb_type' not described in 'vmw_scre

[PATCH 46/53] drm/vmwgfx/vmwgfx_so: Add description for 'vmw_view's 'rcu' member

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_so.c:73: warning: Function parameter or member 'rcu' not described in 'vmw_view' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org S

[PATCH 47/53] drm/vmwgfx/vmwgfx_binding: Provide some missing param descriptions and remove others

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:340: warning: Function parameter or member 'shader_slot' not described in 'vmw_binding_add' drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:340: warning: Function parameter or member 'slot' not described in 'vmw_b

[PATCH 48/53] drm/vmwgfx/vmwgfx_msg: Fix misspelling of 'msg'

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_msg.c:261: warning: Function parameter or member 'msg' not described in 'vmw_send_msg' drivers/gpu/drm/vmwgfx/vmwgfx_msg.c:261: warning: Excess function parameter 'logmsg' description in 'vmw_send_msg' Cc: VMware G

[PATCH 49/53] drm/vmwgfx/vmwgfx_blit: Add description for 'vmw_bo_cpu_blit's 'diff' param

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:452: warning: Function parameter or member 'diff' not described in 'vmw_bo_cpu_blit' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freede

[PATCH 50/53] drm/vmwgfx/vmwgfx_validation: Add some missing struct member/function param descriptions

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:85: warning: Function parameter or member 'dirty' not described in 'vmw_validation_res_node' drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:85: warning: Function parameter or member 'dirty_set' not describe

[PATCH 51/53] drm/vmwgfx/ttm_object: Demote half-assed headers and fix-up another

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/ttm_object.c:60: error: Cannot parse struct or union! drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'mem_glob' not described in 'ttm_object_device' drivers/gpu/drm/vmwgfx/ttm_object.c:97: wa

[PATCH 52/53] drm/vmwgfx/vmwgfx_thp: Add description for 'vmw_thp_manager's member 'manager'

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_thp.c:21: warning: Function parameter or member 'manager' not described in 'vmw_thp_manager' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freed

[PATCH 53/53] drm/vmwgfx/ttm_object: Reorder header to immediately precede its struct

2021-03-03 Thread Lee Jones
Also add missing description for 'refcount' Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/ttm_object.c:60: error: Cannot parse struct or union! Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Chri

Re: [PATCH 08/53] drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the stack to the heap

2021-03-03 Thread Christian König
Hi Lee, I'm not an expert for the DC code base, but I think that this won't work. This function is not allowed to sleep and the structures are a bit large to be allocated on the heap in an atomic context. Regards, Christian. Am 03.03.21 um 14:42 schrieb Lee Jones: Fixes the following W=1 ke

Re: [PATCH v8] drm: Use USB controller's DMA mask when importing dmabufs

2021-03-03 Thread Noralf Trønnes
Den 03.03.2021 14.32, skrev Thomas Zimmermann: > USB devices cannot perform DMA and hence have no dma_mask set in their > device structure. Therefore importing dmabuf into a USB-based driver > fails, which breaks joining and mirroring of display in X11. > > For USB devices, pick the associated U

[PATCH][next] drm/amd/display: remove redundant initialization of variable status

2021-03-03 Thread Colin King
From: Colin Ian King The variable status is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/display/

Re: drm/ttm: ttm_bo_release called without lock

2021-03-03 Thread Christian König
Hi Petr, yes that is a known bug in qxl and yes the patch you mentioned makes it worse. Going to reduce the warning into a WARN_ON_ONCE(). Regards, Christian. Am 03.03.21 um 15:34 schrieb Petr Mladek: Hi, the following warning is filling my kernel log buffer with 5.12-rc1+ kernels: [ 941

Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211

2021-03-03 Thread Jagan Teki
On Wed, Feb 24, 2021 at 6:44 PM Laurent Pinchart wrote: > > Hi Jagan, > > On Wed, Feb 24, 2021 at 06:07:43PM +0530, Jagan Teki wrote: > > On Mon, Feb 15, 2021 at 5:48 PM Laurent Pinchart wrote: > > > On Sun, Feb 14, 2021 at 11:22:10PM +0530, Jagan Teki wrote: > > > > ICN6211 is MIPI-DSI to RGB Con

[PATCH 00/30] [Set 1] Rid W=1 warnings in SCSI

2021-03-03 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (30): scsi: megaraid: megaraid_mm: Fix incorrect function name in header scsi: megaraid: megaraid_sas_base: Fix a bunch of misnamed fu

[PATCH 17/30] scsi: lpfc: lpfc_sli: Fix a bunch of kernel-doc issues

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/scsi/lpfc/lpfc_sli.c:9654: warning: expecting prototype for lpfc_sli_iocb2wqe(). Prototype was for lpfc_sli4_iocb2wqe() instead drivers/scsi/lpfc/lpfc_sli.c:10439: warning: Function parameter or member 'phba' not described in 'lpfc_sli_i

[PATCH 16/30] scsi: aacraid: commsup: Repair formatting issue in aac_handle_sa_aif()'s header

2021-03-03 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/scsi/aacraid/commsup.c:334: warning: expecting prototype for fib_deallocate(). Prototype was for fib_dealloc() instead drivers/scsi/aacraid/commsup.c:1961: warning: expecting prototype for aac_handle_sa_aif Handle a message from th

[Bug 211981] AMDGPU: without cable attached videocard shuts down and does not wake up again, log prints "[drm] Cannot find any crtc or sizes"

2021-03-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211981 --- Comment #2 from raul (raulvior@gmail.com) --- (In reply to Alex Deucher from comment #1) > Does setting amdgpu.runpm=0 fix it? Yes, it does. -- You may reply to this email to add a comment. You are receiving this mail because: You are

Re: [PATCH] drm/amdgpu: Remove unnecessary conversion to bool

2021-03-03 Thread Alex Deucher
On Wed, Mar 3, 2021 at 4:18 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:2252:40-45: WARNING: conversion > to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Applied. Thanks! Alex > --- > dr

Re: [PATCH] drm/radeon: fix copy of uninitialized variable back to userspace

2021-03-03 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Mar 3, 2021 at 2:42 AM Christian König wrote: > > Am 03.03.21 um 01:27 schrieb Colin King: > > From: Colin Ian King > > > > Currently the ioctl command RADEON_INFO_SI_BACKEND_ENABLED_MASK can > > copy back uninitialised data in value_tmp that pointer *value points

Re: [PATCH] drm/amd/display: Fix off by one in hdmi_14_process_transaction()

2021-03-03 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Mar 2, 2021 at 2:26 PM Lakha, Bhawanpreet wrote: > > [AMD Official Use Only - Internal Distribution Only] > > > Thanks > > Reviewed-by: Bhawanpreet Lakha > > From: Dan Carpenter > Sent: March 2, 2021 6:15 AM > To: Wentland, Harry

Re: [PATCH 04/53] drm/amd/display/dc/bios/command_table: Remove unused variable

2021-03-03 Thread Alex Deucher
On Wed, Mar 3, 2021 at 8:43 AM Lee Jones wrote: > > None of the surrounding code was removed just in case even a small > fraction of it was functional. > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c: In function > ‘adjust_di

Re: [PATCH 07/53] drm/amd/display/dc/bios/command_table: Remove unused variable and associated comment

2021-03-03 Thread Alex Deucher
On Wed, Mar 3, 2021 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c: In function > ‘adjust_display_pll_v2’: > drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1462:11: > warning: unu

Re: [PATCH 10/53] drm/amd/display/dc/dce/dce_aux: Remove duplicate line causing 'field overwritten' issue

2021-03-03 Thread Alex Deucher
On Wed, Mar 3, 2021 at 8:44 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > In file included from > drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:59: > > drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_11_2_sh_mask.h:10014:58: > warning:

Re: [PATCH v4 10/14] drm/bridge: imx: Add LDB driver helper support

2021-03-03 Thread Robert Foss
On Wed, 3 Mar 2021 at 08:23, Liu Ying wrote: > > Hi Robert, > > On Tue, 2021-03-02 at 15:22 +0100, Robert Foss wrote: > > Hey Liu, > > > > Thanks for submitting this patch. > > Thanks for reviewing this patch. > > > > > On Thu, 18 Feb 2021 at 04:59, Liu Ying wrote: > > > This patch adds a helper

Re: KMSAN: kernel-infoleak in compat_drm_wait_vblank

2021-03-03 Thread Michel Dänzer
On 2021-02-22 10:15 a.m., syzbot wrote: Hello, syzbot found the following issue on: HEAD commit:29ad81a1 arch/x86: add missing include to sparsemem.h git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=111e6312d0 kernel co

Re: [PATCH] drm/stm: ltdc: Use simple encoder

2021-03-03 Thread yannick Fertre
Thanks Jagan for the patch. Tested-by: Yannick Fertre On 3/2/21 6:57 PM, Jagan Teki wrote: STM ltdc driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by: Jagan Teki --- drivers/gpu/drm/stm/ltdc.c | 12 ++-- 1 file ch

[PATCH] drm/ttm: soften TTM warnings

2021-03-03 Thread Christian König
QXL indeed unrefs pinned BOs and the warnings are spamming peoples log files. Make sure we warn only once until the QXL driver is fixed. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/t

Re: [PATCH -next v2] fbdev: atyfb: use LCD management functions for PPC_PMAC also

2021-03-03 Thread Ville Syrjälä
On Fri, Feb 26, 2021 at 09:30:08AM -0800, Randy Dunlap wrote: > Include PPC_PMAC in the configs that use aty_ld_lcd() and > aty_st_lcd() implementations so that the PM code may work > correctly for PPC_PMAC. > > Suggested-by: Ville Syrjälä > Signed-off-by: Randy Dunlap > Cc: Daniel Vetter > Cc:

Re: [PATCH 17/53] drm/nouveau/dispnv50/headc57d: Make local function 'headc57d_olut' static

2021-03-03 Thread Lyude Paul
Reviewed-by: Lyude Paul Thanks! On Wed, 2021-03-03 at 13:42 +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > >  drivers/gpu/drm/nouveau/dispnv50/headc57d.c:173:1: warning: no previous > prototype for ‘headc57d_olut’ [-Wmissing-prototypes] > > Cc: Ben Skeggs > Cc: D

Re: [PATCH] drm/ttm: soften TTM warnings

2021-03-03 Thread Daniel Vetter
On Wed, Mar 3, 2021 at 4:57 PM Christian König wrote: > > QXL indeed unrefs pinned BOs and the warnings are spamming peoples log files. > > Make sure we warn only once until the QXL driver is fixed. > > Signed-off-by: Christian König Can you pls add FIXME comments to each that qxl is broken and

drm/ttm: ttm_bo_release called without lock

2021-03-03 Thread Petr Mladek
Hi, the following warning is filling my kernel log buffer with 5.12-rc1+ kernels: [ 941.070598] WARNING: CPU: 0 PID: 11 at drivers/gpu/drm/ttm/ttm_bo.c:139 ttm_bo_move_to_lru_tail+0x1ba/0x210 [ 941.070601] Modules linked in: [ 941.070603] CPU: 0 PID: 11 Comm: kworker/0:1 Kdump: loaded Tainted

[PATCH][next] drm/radeon/si_dpm: Replace one-element array with flexible-array in struct SISLANDS_SMC_SWSTATE

2021-03-03 Thread Gustavo A. R. Silva
There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2]. Refacto

Re: drm/ttm: ttm_bo_release called without lock

2021-03-03 Thread Petr Mladek
On Wed 2021-03-03 15:34:09, Petr Mladek wrote: > Hi, > > the following warning is filling my kernel log buffer > with 5.12-rc1+ kernels: > > [ 941.070598] WARNING: CPU: 0 PID: 11 at drivers/gpu/drm/ttm/ttm_bo.c:139 > ttm_bo_move_to_lru_tail+0x1ba/0x210 > [ 941.070601] Modules linked in: > [ 9

  1   2   >