Re: udldrmfb: causes WARN in i915 on X60 (x86-32)

2021-02-25 Thread Thomas Zimmermann
Hi Am 24.02.21 um 21:09 schrieb Pavel Machek: Hi! This is in -next, but I get same behaviour on 5.11; and no, udl does Thanks for reporting. We are in the process of fixing the issue. The latest patch is at [1]. Best regards Thomas [1] https://lore.kernel.org/dri-devel/b44307cf-25f9-acd0

Re: [PATCH] drm/shmem-helpers: vunmap: Don't put pages for dma-buf

2021-02-25 Thread Thomas Zimmermann
Hi Am 24.02.21 um 18:14 schrieb Noralf Trønnes: Den 19.02.2021 14.54, skrev Thomas Zimmermann: Hi Am 19.02.21 um 13:22 schrieb Noralf Trønnes: dma-buf importing was reworked in commit 7d2cd72a9aa3 ("drm/shmem-helpers: Simplify dma-buf importing"). Before that commit drm_gem_shmem_prime_impo

Re: [PATCH v4] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-25 Thread Takashi Iwai
On Thu, 25 Feb 2021 08:57:14 +0100, Thomas Zimmermann wrote: > > Hi > > Am 24.02.21 um 16:21 schrieb Alan Stern: > > On Wed, Feb 24, 2021 at 10:23:04AM +0100, Thomas Zimmermann wrote: > >> USB devices cannot perform DMA and hence have no dma_mask set in their > >> device structure. Therefore impo

[PATCH v1] drm/nouveau/kms: delete an useless function call in nouveau_framebuffer_new()

2021-02-25 Thread Luo Jiaxing
nouveau_framebuffer_new() call drm_format_info_plane_width() to get a width of plane, but width is not used then, so it's a useless function call here. Signed-off-by: Luo Jiaxing --- drivers/gpu/drm/nouveau/nouveau_display.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a

[PATCH v1 1/2] drm/nouveau/kms/nv50-: Remove several set but not used variables "ret" in disp.c

2021-02-25 Thread Luo Jiaxing
Fixes the following warning when using W=1 to build kernel: drivers/gpu/drm/nouveau/dispnv50/disp.c: In function ‘nv50_mstm_cleanup’: drivers/gpu/drm/nouveau/dispnv50/disp.c:1389:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] 1389 | int ret; | ^~~ drivers/gpu

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-25 Thread Huang Jiachai
Hi Daniel,     RK3399 and px30 can support YTR afbc format[RGB only], there is an hidden control bit to control this. Hi Alyssa,     Can you add the following patch to test on your platform? thanks. diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip

[PATCH v1] drm/nouveau: delete unused variables "dev" in nouveau_ttm_tt_populate()

2021-02-25 Thread Luo Jiaxing
After switch to new allocator, dev is no longer used here and should be deleted. Fixes: 461619f5c324 ("drm/nouveau: switch to new allocator") Signed-off-by: Luo Jiaxing --- drivers/gpu/drm/nouveau/nouveau_bo.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouvea

Re: [PULL] drm-misc-fixes

2021-02-25 Thread Maxime Ripard
Hi, On Thu, Feb 25, 2021 at 08:53:42AM +0100, Thomas Zimmermann wrote: > Am 25.02.21 um 02:55 schrieb Dave Airlie: > > On Wed, 24 Feb 2021 at 20:27, Thomas Zimmermann wrote: > > > > > > Hi Dave and Daniel, > > > > > > here's this week's PR for drm-misc-fixes. One of the patches is a memory > >

Re: [PULL] drm-misc-fixes

2021-02-25 Thread Daniel Vetter
On Thu, Feb 25, 2021 at 8:53 AM Thomas Zimmermann wrote: > > Hi > > Am 25.02.21 um 02:55 schrieb Dave Airlie: > > On Wed, 24 Feb 2021 at 20:27, Thomas Zimmermann wrote: > >> > >> Hi Dave and Daniel, > >> > >> here's this week's PR for drm-misc-fixes. One of the patches is a memory > >> leak; the

[PATCH] drm/amdgpu: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-02-25 Thread Yang Li
Fix the following coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1589:0-23: WARNING: fops_ib_preempt should be defined with DEFINE_DEBUGFS_ATTRIBUTE ./drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1592:0-23: WARNING: fops_sclk_set should be defined with DEFINE_DEBUGFS_ATTRIBUTE Re

Re: [RFC PATCH] drm/vkms: Add support for virtual hardware mode

2021-02-25 Thread Daniel Vetter
On Wed, Feb 24, 2021 at 11:55 AM Sumera Priyadarsini wrote: > > Add a virtual hardware or vblank-less mode as a module to enable > VKMS to emulate virtual graphic drivers. This mode can be enabled > by setting enable_virtual_hw=1 at the time of loading VKMS. > > A new function vkms_crtc_composer()

[PATCH] drm/amd/display: remove unnecessary conversion to bool

2021-02-25 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c:243:67-72: WARNING: conversion to bool not needed here. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH v4] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-25 Thread Christian König
Am 24.02.21 um 10:23 schrieb Thomas Zimmermann: USB devices cannot perform DMA and hence have no dma_mask set in their device structure. Therefore importing dmabuf into a USB-based driver fails, which breaks joining and mirroring of display in X11. For USB devices, pick the associated USB contro

[PULL] drm-misc-next-fixes

2021-02-25 Thread Maarten Lankhorst
drm-misc-next-fixes-2021-02-25: drm-misc-next tasty fixes for v5.12: - Cherry pick of drm-misc-fixes pull: "here's this week's PR for drm-misc-fixes. One of the patches is a memory leak; the rest is for hardware issues." - Fix dt bindings for dp connector. - Fix build error in atyfb. - Improve erro

Re: [PATCH] drm/shmem-helpers: vunmap: Don't put pages for dma-buf

2021-02-25 Thread Noralf Trønnes
Den 25.02.2021 09.12, skrev Thomas Zimmermann: > Hi > > Am 24.02.21 um 18:14 schrieb Noralf Trønnes: >> >> >> Den 19.02.2021 14.54, skrev Thomas Zimmermann: >>> Hi >>> >>> Am 19.02.21 um 13:22 schrieb Noralf Trønnes: dma-buf importing was reworked in commit 7d2cd72a9aa3 ("drm/shmem-hel

Re: [PATCH v4] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-25 Thread Daniel Vetter
On Wed, Feb 24, 2021 at 10:23 AM Thomas Zimmermann wrote: > > USB devices cannot perform DMA and hence have no dma_mask set in their > device structure. Therefore importing dmabuf into a USB-based driver > fails, which breaks joining and mirroring of display in X11. > > For USB devices, pick the a

Re: [PATCH] drm/shmem-helpers: vunmap: Don't put pages for dma-buf

2021-02-25 Thread Thomas Zimmermann
Am 25.02.21 um 10:25 schrieb Noralf Trønnes: Den 25.02.2021 09.12, skrev Thomas Zimmermann: Hi Am 24.02.21 um 18:14 schrieb Noralf Trønnes: Den 19.02.2021 14.54, skrev Thomas Zimmermann: Hi Am 19.02.21 um 13:22 schrieb Noralf Trønnes: dma-buf importing was reworked in commit 7d2cd72a9

Re: [PATCH] drm/shmem-helpers: vunmap: Don't put pages for dma-buf

2021-02-25 Thread Daniel Vetter
On Wed, Feb 24, 2021 at 6:14 PM Noralf Trønnes wrote: > > > > Den 19.02.2021 14.54, skrev Thomas Zimmermann: > > Hi > > > > Am 19.02.21 um 13:22 schrieb Noralf Trønnes: > >> dma-buf importing was reworked in commit 7d2cd72a9aa3 > >> ("drm/shmem-helpers: Simplify dma-buf importing"). Before that co

Re: [PATCH v4] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-25 Thread Pavel Machek
Hi! > USB devices cannot perform DMA and hence have no dma_mask set in their > device structure. Therefore importing dmabuf into a USB-based driver > fails, which breaks joining and mirroring of display in X11. > > For USB devices, pick the associated USB controller as attachment device. > This a

Re: [PATCH] drm/shmem-helpers: vunmap: Don't put pages for dma-buf

2021-02-25 Thread Thomas Zimmermann
Hi Am 25.02.21 um 10:43 schrieb Daniel Vetter: On Wed, Feb 24, 2021 at 6:14 PM Noralf Trønnes wrote: Den 19.02.2021 14.54, skrev Thomas Zimmermann: Hi Am 19.02.21 um 13:22 schrieb Noralf Trønnes: dma-buf importing was reworked in commit 7d2cd72a9aa3 ("drm/shmem-helpers: Simplify dma-buf

udldrm does not recover from powersave? Re: udldrmfb: causes WARN in i915 on X60 (x86-32)

2021-02-25 Thread Pavel Machek
Hi! > >This is in -next, but I get same behaviour on 5.11; and no, udl does > > Thanks for reporting. We are in the process of fixing the issue. The latest > patch is at [1]. > Thank you, that fixes the DMA issue, and I can use the udl. ...for a while. Then screensaver blanks laptop screen, udl

Re: [PATCH v6 3/3] drm: Add GUD USB Display driver

2021-02-25 Thread Peter Stuge
Hi Noralf, Noralf Trønnes wrote: > The driver supports a one bit monochrome transfer format: R1. This is not > implemented in the gadget driver. It is added in preparation for future > monochrome e-ink displays. I forgot, but I have a two-tone (black/red) e-ink display here, and I also have a 3-b

Re: udldrm does not recover from powersave? Re: udldrmfb: causes WARN in i915 on X60 (x86-32)

2021-02-25 Thread Thomas Zimmermann
Hi Am 25.02.21 um 10:53 schrieb Pavel Machek: Hi! This is in -next, but I get same behaviour on 5.11; and no, udl does Thanks for reporting. We are in the process of fixing the issue. The latest patch is at [1]. Thank you, that fixes the DMA issue, and I can use the udl. ...for a while.

Re: udldrm does not recover from powersave? Re: udldrmfb: causes WARN in i915 on X60 (x86-32)

2021-02-25 Thread Pavel Machek
Hi! > > Thank you, that fixes the DMA issue, and I can use the udl. > > > > ...for a while. Then screensaver blanks laptop screen, udl screen > > blanks too. Upon hitting a key, internal screen shows up, udl does > > not. > > > > I try rerunning xrandr ... --auto, but could not recover it. > >

[PATCH] drm/vgem: use shmem helpers

2021-02-25 Thread Daniel Vetter
Aside from deleting lots of code the real motivation here is to switch the mmap over to VM_PFNMAP, to be more consistent with what real gpu drivers do. They're all VM_PFNMP, which means get_user_pages doesn't work, and even if you try and there's a struct page behind that, touching it and mucking a

Re: [RFC PATCH] drm/vkms: Add support for virtual hardware mode

2021-02-25 Thread Gerd Hoffmann
On Thu, Feb 25, 2021 at 10:09:42AM +0100, Daniel Vetter wrote: > On Wed, Feb 24, 2021 at 11:55 AM Sumera Priyadarsini > wrote: > > > > Add a virtual hardware or vblank-less mode as a module to enable > > VKMS to emulate virtual graphic drivers. This mode can be enabled > > by setting enable_virtua

Re: [PATCH v4 00/14] RFC Support hot device unplug in amdgpu

2021-02-25 Thread Daniel Vetter
On Wed, Feb 24, 2021 at 11:30:50AM -0500, Andrey Grodzovsky wrote: > > On 2021-02-19 5:24 a.m., Daniel Vetter wrote: > > On Thu, Feb 18, 2021 at 9:03 PM Andrey Grodzovsky > > wrote: > > > Looked a bit into it, I want to export sync_object to FD and import from > > > that FD > > > such that I wi

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-25 Thread Christian König
Am 24.02.21 um 10:31 schrieb Daniel Vetter: On Wed, Feb 24, 2021 at 10:16 AM Thomas Hellström (Intel) wrote: On 2/24/21 9:45 AM, Daniel Vetter wrote: On Wed, Feb 24, 2021 at 8:46 AM Thomas Hellström (Intel) wrote: On 2/23/21 11:59 AM, Daniel Vetter wrote: tldr; DMA buffers aren't normal me

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-25 Thread Christian König
Am 24.02.21 um 19:46 schrieb Jason Gunthorpe: On Wed, Feb 24, 2021 at 09:45:51AM +0100, Daniel Vetter wrote: Hm I figured everyone just uses MAP_SHARED for buffer objects since COW really makes absolutely no sense. How would we enforce this? In RDMA we test drivers/infiniband/core/ib_core_

Re: [RFC PATCH] drm/vkms: Add support for virtual hardware mode

2021-02-25 Thread Daniel Vetter
On Thu, Feb 25, 2021 at 11:25:20AM +0100, Gerd Hoffmann wrote: > On Thu, Feb 25, 2021 at 10:09:42AM +0100, Daniel Vetter wrote: > > On Wed, Feb 24, 2021 at 11:55 AM Sumera Priyadarsini > > wrote: > > > > > > Add a virtual hardware or vblank-less mode as a module to enable > > > VKMS to emulate vir

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-25 Thread Daniel Vetter
On Thu, Feb 25, 2021 at 11:28:31AM +0100, Christian König wrote: > Am 24.02.21 um 10:31 schrieb Daniel Vetter: > > On Wed, Feb 24, 2021 at 10:16 AM Thomas Hellström (Intel) > > wrote: > > > > > > On 2/24/21 9:45 AM, Daniel Vetter wrote: > > > > On Wed, Feb 24, 2021 at 8:46 AM Thomas Hellström (In

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-25 Thread Daniel Vetter
On Thu, Feb 25, 2021 at 11:30:23AM +0100, Christian König wrote: > > > Am 24.02.21 um 19:46 schrieb Jason Gunthorpe: > > On Wed, Feb 24, 2021 at 09:45:51AM +0100, Daniel Vetter wrote: > > > > > Hm I figured everyone just uses MAP_SHARED for buffer objects since > > > COW really makes absolutely

Re: [PATCH] drm/shmem-helpers: vunmap: Don't put pages for dma-buf

2021-02-25 Thread Daniel Vetter
On Thu, Feb 25, 2021 at 10:52:14AM +0100, Thomas Zimmermann wrote: > Hi > > Am 25.02.21 um 10:43 schrieb Daniel Vetter: > > On Wed, Feb 24, 2021 at 6:14 PM Noralf Trønnes wrote: > > > > > > > > > > > > Den 19.02.2021 14.54, skrev Thomas Zimmermann: > > > > Hi > > > > > > > > Am 19.02.21 um 13

Re: [PATCH 07/15] drm/arc: Use drmm_mode_config_cleanup

2021-02-25 Thread Daniel Vetter
On Tue, Jan 12, 2021 at 12:29:59PM +0100, Thomas Zimmermann wrote: > Hi > > Am 12.01.21 um 09:43 schrieb Daniel Vetter: > > With autocleanup through drm_device management we can delete all the > > code. Possible now that there's no confusion against devm_kzalloc'ed > > structures anymore. > > > >

[PATCH v1] drm/nouveau/device: append a NUL-terminated character for the string which filled by strncpy()

2021-02-25 Thread Luo Jiaxing
Following warning is found when using W=1 to build kernel: In function ‘nvkm_udevice_info’, inlined from ‘nvkm_udevice_mthd’ at drivers/gpu/drm/nouveau/nvkm/engine/device/user.c:195:10: drivers/gpu/drm/nouveau/nvkm/engine/device/user.c:164:2: warning: ‘strncpy’ specified bound 16 equals dest

Re: [PATCH 01/15] drm/arc: Switch to devm_drm_dev_alloc

2021-02-25 Thread Daniel Vetter
On Tue, Jan 12, 2021 at 12:42:16PM +0100, Thomas Zimmermann wrote: > Hi > > Am 12.01.21 um 09:43 schrieb Daniel Vetter: > > - Need to embedded the drm_device, but for now we keep the usual > >pointer chasing. > > - No more devm_kzalloc, which fixes a lifetime issues on driver > >remove. >

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-25 Thread Daniel Stone
Hi Sandy, On Thu, 25 Feb 2021 at 02:17, Huang Jiachai wrote: > RK3399 and px30 can support YTR afbc format[RGB only], there is an > hidden control bit to control this. Great, thanks for providing this information! > Hi Alyssa, > > Can you add the following patch to test on your platfo

Re: [PATCH v4 24/80] drm/omap: dsi: move TE GPIO handling into core

2021-02-25 Thread Tony Lindgren
* Tomi Valkeinen [210222 08:47]: > On 18/02/2021 07:57, Tony Lindgren wrote: > > Oh cool that you have those running again/still :) In this case there > > is no te-gpios if that might make a difference. > > No, GPIO TE is not used on OMAP4 SDP either. OK > >> So these errors start from the boot

[PATCH] drm/nouveau/pci: rework AGP dependency

2021-02-25 Thread Arnd Bergmann
From: Arnd Bergmann I noticed a warning from 'nm' when CONFIG_TRIM_UNUSED_KSYMS is set and IS_REACHABLE(CONFIG_AGP) is false: drivers/gpu/drm/nouveau/nvkm/subdev/pci/agp.o: no symbols I later found this is completely harmless and we should find a way to suppress the warning, but at that point I

Re: [PATCH] drm/nouveau/pci: rework AGP dependency

2021-02-25 Thread Christian König
Am 25.02.21 um 13:52 schrieb Arnd Bergmann: From: Arnd Bergmann I noticed a warning from 'nm' when CONFIG_TRIM_UNUSED_KSYMS is set and IS_REACHABLE(CONFIG_AGP) is false: drivers/gpu/drm/nouveau/nvkm/subdev/pci/agp.o: no symbols I later found this is completely harmless and we should find a wa

Re: [RFC PATCH] drm/vkms: Add support for virtual hardware mode

2021-02-25 Thread Gerd Hoffmann
On Thu, Feb 25, 2021 at 11:32:08AM +0100, Daniel Vetter wrote: > On Thu, Feb 25, 2021 at 11:25:20AM +0100, Gerd Hoffmann wrote: > > On Thu, Feb 25, 2021 at 10:09:42AM +0100, Daniel Vetter wrote: > > > On Wed, Feb 24, 2021 at 11:55 AM Sumera Priyadarsini > > > wrote: > > > > > > > > Add a virtual h

[PATCH] drm/amd/display: fix 64-bit integer division

2021-02-25 Thread Arnd Bergmann
From: Arnd Bergmann The new display synchronization code caused a regression on all 32-bit architectures: ld.lld: error: undefined symbol: __aeabi_uldivmod >>> referenced by dce_clock_source.c >>> >>> gpu/drm/amd/display/dc/dce/dce_clock_source.o:(get_pixel_clk_frequency_100hz) >>

[PULL] drm-intel-next-fixes

2021-02-25 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-next-fixes-2021-02-25: A fix for color format check from Ville, plus the re-enable of -Wuninitialized from Nathan, and the GVT fixes including fixes for ww locking, cmd parser and a general cleanup of dev_priv->gt. Thanks, Rodrigo. The following changes s

[PATCH RESEND] drm/vc4: Fix an error code vc4_create_object()

2021-02-25 Thread Dan Carpenter
The vc4_create_object() needs to return NULL on error, not error pointers. If it returns an error pointer then that will lead to an Oops in the callers. Fortunately, in current kernels small allocations always succed so this will never happen. Fixes: c826a6e10644 ("drm/vc4: Add a BO cache.") Sig

Re: [PATCH RESEND] drm/vc4: Fix an error code vc4_create_object()

2021-02-25 Thread Neil Roberts
Dan Carpenter writes: > The vc4_create_object() needs to return NULL on error, not error > pointers. If it returns an error pointer then that will lead to an > Oops in the callers. Fortunately, in current kernels small allocations > always succed so this will never happen. > > Fixes: c826a6e106

[PATCH] drm/amd/display: Fix an uninitialized index variable

2021-02-25 Thread Arnd Bergmann
From: Arnd Bergmann clang points out that the new logic uses an always-uninitialized array index: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9810:38: warning: variable 'i' is uninitialized when used here [-Wuninitialized] timing = &edid->detailed_timing

Re: [RFC PATCH] drm/vkms: Add support for virtual hardware mode

2021-02-25 Thread Daniel Vetter
On Thu, Feb 25, 2021 at 2:27 PM Gerd Hoffmann wrote: > > On Thu, Feb 25, 2021 at 11:32:08AM +0100, Daniel Vetter wrote: > > On Thu, Feb 25, 2021 at 11:25:20AM +0100, Gerd Hoffmann wrote: > > > On Thu, Feb 25, 2021 at 10:09:42AM +0100, Daniel Vetter wrote: > > > > On Wed, Feb 24, 2021 at 11:55 AM S

Re: [PATCH] drm/nouveau/pci: rework AGP dependency

2021-02-25 Thread Daniel Vetter
On Thu, Feb 25, 2021 at 1:59 PM Christian König wrote: > > Am 25.02.21 um 13:52 schrieb Arnd Bergmann: > > From: Arnd Bergmann > > > > I noticed a warning from 'nm' when CONFIG_TRIM_UNUSED_KSYMS is set > > and IS_REACHABLE(CONFIG_AGP) is false: > > > > drivers/gpu/drm/nouveau/nvkm/subdev/pci/agp.

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-25 Thread Daniel Vetter
On Thu, Feb 25, 2021 at 11:44 AM Daniel Vetter wrote: > > On Thu, Feb 25, 2021 at 11:28:31AM +0100, Christian König wrote: > > Am 24.02.21 um 10:31 schrieb Daniel Vetter: > > > On Wed, Feb 24, 2021 at 10:16 AM Thomas Hellström (Intel) > > > wrote: > > > > > > > > On 2/24/21 9:45 AM, Daniel Vetter

[PATCH 0/8] drm/vc4: hdmi: Support the 4k @ 60Hz modes

2021-02-25 Thread Maxime Ripard
Hi, Here is a series that enables the higher resolutions on the HDMI0 Controller found in the BCM2711 (RPi4). In order to work it needs a few adjustments to config.txt, most notably to enable the enable_hdmi_4kp60 and force_turbo options. The firmware also has a glitch at the moment and will not

[PATCH 7/8] drm/vc4: plane: Fix typo in scaler width and height

2021-02-25 Thread Maxime Ripard
Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_plane.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c index 4a075294ff4c..5e8b7f72dc05 100644 --- a/drivers/gpu/drm/vc4/vc4_plane.c +++ b/drivers/gp

[PATCH 2/8] drm/vc4: hvs: Make the HVS bind first

2021-02-25 Thread Maxime Ripard
We'll need to have the HVS binding before the HDMI controllers so that we can check whether the firmware allows to run in 4kp60. Reorder a bit the component list, and document the current constraints we're aware of. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_drv.c | 11 ++-

[PATCH 1/8] clk: Add range accessors

2021-02-25 Thread Maxime Ripard
Some devices might need to access the current available range of a clock to discover their capabilities. Let's add those accessors. Signed-off-by: Maxime Ripard --- drivers/clk/clk.c | 30 ++ include/linux/clk.h | 16 2 files changed, 46 insertions(

[PATCH 3/8] drm/vc4: hdmi: Properly compute the BVB clock rate

2021-02-25 Thread Maxime Ripard
The BVB clock rate computation doesn't take into account a mode clock of 594MHz that we're going to need to support 4k60. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c

[PATCH 8/8] drm/vc4: plane: Remove redundant assignment

2021-02-25 Thread Maxime Ripard
Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_plane.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c index 5e8b7f72dc05..201831e924d9 100644 --- a/drivers/gpu/drm/vc4/vc4_plane.c +++ b/drivers/gpu/drm/vc4/vc4_plane.c

[PATCH 6/8] drm/vc4: hdmi: Raise the maximum clock rate

2021-02-25 Thread Maxime Ripard
Now that we have the infrastructure in place, we can raise the maximum pixel rate we can reach for HDMI0 on the BCM2711. HDMI1 is left untouched since its pixelvalve has a smaller FIFO and would need a clock faster than what we can provide to support the same modes. Signed-off-by: Maxime Ripard

[PATCH 5/8] drm/vc4: hdmi: Enable the scrambler

2021-02-25 Thread Maxime Ripard
The HDMI controller on the BCM2711 includes a scrambler in order to reach the modes that require it. Let's add the support for it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 58 + drivers/gpu/drm/vc4/vc4_hdmi_regs.h | 3 ++ 2 files changed

[PATCH 4/8] drm/vc4: hdmi: Check and warn if we can't reach 4kp60 frequencies

2021-02-25 Thread Maxime Ripard
In order to reach the frequencies needed to output at 594MHz, the firmware needs to be configured with the appropriate parameters in the config.txt file (enable_hdmi_4kp60 and force_turbo). Let's detect it at bind time, warn the user if we can't, and filter out the relevant modes. Signed-off-by:

Re: [PATCH v2] drm/scheduler: Fix hang when sched_entity released

2021-02-25 Thread Andrey Grodzovsky
On 2021-02-25 2:53 a.m., Christian König wrote: Am 24.02.21 um 16:13 schrieb Andrey Grodzovsky: Ping Sorry, I've been on vacation this week. Andrey On 2021-02-20 7:12 a.m., Andrey Grodzovsky wrote: On 2/20/21 3:38 AM, Christian König wrote: Am 18.02.21 um 17:41 schrieb Andrey Grodzov

Re: [PATCH v4 00/14] RFC Support hot device unplug in amdgpu

2021-02-25 Thread Andrey Grodzovsky
On 2021-02-25 5:25 a.m., Daniel Vetter wrote: On Wed, Feb 24, 2021 at 11:30:50AM -0500, Andrey Grodzovsky wrote: On 2021-02-19 5:24 a.m., Daniel Vetter wrote: On Thu, Feb 18, 2021 at 9:03 PM Andrey Grodzovsky wrote: Looked a bit into it, I want to export sync_object to FD and import from t

Re: [PATCH v4] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-25 Thread Alan Stern
On Thu, Feb 25, 2021 at 09:23:05AM +0100, Takashi Iwai wrote: > On Thu, 25 Feb 2021 08:57:14 +0100, > Thomas Zimmermann wrote: > > > > Hi > > > > Am 24.02.21 um 16:21 schrieb Alan Stern: > > > On Wed, Feb 24, 2021 at 10:23:04AM +0100, Thomas Zimmermann wrote: > > >> USB devices cannot perform DMA

Re: [RFC PATCH] drm/vkms: Add support for virtual hardware mode

2021-02-25 Thread Zack Rusin
On 2/25/21 4:09 AM, Daniel Vetter wrote: On Wed, Feb 24, 2021 at 11:55 AM Sumera Priyadarsini wrote: Add a virtual hardware or vblank-less mode as a module to enable VKMS to emulate virtual graphic drivers. This mode can be enabled by setting enable_virtual_hw=1 at the time of loading VKMS. A

Re: [PATCH 5/8] drm/vc4: hdmi: Enable the scrambler

2021-02-25 Thread Dave Stevenson
Hi Maxime On Thu, 25 Feb 2021 at 15:59, Maxime Ripard wrote: > > The HDMI controller on the BCM2711 includes a scrambler in order to > reach the modes that require it. Let's add the support for it. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 58 +++

Re: [PATCH 4/8] drm/vc4: hdmi: Check and warn if we can't reach 4kp60 frequencies

2021-02-25 Thread Dave Stevenson
Hi Maxime On Thu, 25 Feb 2021 at 15:59, Maxime Ripard wrote: > > In order to reach the frequencies needed to output at 594MHz, the > firmware needs to be configured with the appropriate parameters in the > config.txt file (enable_hdmi_4kp60 and force_turbo). force_turbo isn't the right way to go

Re: [PATCH 3/8] drm/vc4: hdmi: Properly compute the BVB clock rate

2021-02-25 Thread Dave Stevenson
Hi Maxime On Thu, 25 Feb 2021 at 15:59, Maxime Ripard wrote: > > The BVB clock rate computation doesn't take into account a mode clock of > 594MHz that we're going to need to support 4k60. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 11 +++ > 1 file changed

Re: [PATCH 6/8] drm/vc4: hdmi: Raise the maximum clock rate

2021-02-25 Thread Dave Stevenson
On Thu, 25 Feb 2021 at 15:59, Maxime Ripard wrote: > > Now that we have the infrastructure in place, we can raise the maximum > pixel rate we can reach for HDMI0 on the BCM2711. > > HDMI1 is left untouched since its pixelvalve has a smaller FIFO and > would need a clock faster than what we can pro

Re: [PATCH 8/8] drm/vc4: plane: Remove redundant assignment

2021-02-25 Thread Dave Stevenson
On Thu, 25 Feb 2021 at 15:59, Maxime Ripard wrote: > > Signed-off-by: Maxime Ripard Other than no commit text body (which is hardly needed in this case) Reviewed-by: Dave Stevenson > --- > drivers/gpu/drm/vc4/vc4_plane.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm

Re: [PATCH] drm/compat: more dummy implementations

2021-02-25 Thread Maxime Ripard
On Mon, Feb 22, 2021 at 11:06:08AM +0100, Daniel Vetter wrote: > drm_noop really doesnt do much, and who cares about the permission checks. ^ doesn't > So let's delete some code. With the typo fixed, Acked-by: Maxime Ripard Maxime > > Signed-off-by: Daniel Vetter > --- >

Re: [PATCH] drm/compat: Clear bounce structures

2021-02-25 Thread Maxime Ripard
On Mon, Feb 22, 2021 at 11:06:43AM +0100, Daniel Vetter wrote: > Some of them have gaps, or fields we don't clear. Native ioctl code > does full copies plus zero-extends on size mismatch, so nothing can > leak. But compat is more hand-rolled so need to be careful. > > None of these matter for perf

Re: [PATCH 7/8] drm/vc4: plane: Fix typo in scaler width and height

2021-02-25 Thread Dave Stevenson
On Thu, 25 Feb 2021 at 15:59, Maxime Ripard wrote: > > Signed-off-by: Maxime Ripard Again no commit text body, but possibly not warranted Reviewed-by: Dave Stevenson > --- > drivers/gpu/drm/vc4/vc4_plane.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/g

Re: [PATCH 2/8] drm/vc4: hvs: Make the HVS bind first

2021-02-25 Thread Dave Stevenson
On Thu, 25 Feb 2021 at 15:59, Maxime Ripard wrote: > > We'll need to have the HVS binding before the HDMI controllers so that > we can check whether the firmware allows to run in 4kp60. Reorder a bit > the component list, and document the current constraints we're aware of. > > Signed-off-by: Maxi

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-25 Thread Christian König
Am 25.02.21 um 16:49 schrieb Daniel Vetter: On Thu, Feb 25, 2021 at 11:44 AM Daniel Vetter wrote: On Thu, Feb 25, 2021 at 11:28:31AM +0100, Christian König wrote: Am 24.02.21 um 10:31 schrieb Daniel Vetter: On Wed, Feb 24, 2021 at 10:16 AM Thomas Hellström (Intel) wrote: On 2/24/21 9:45 A

Re: udldrm does not recover from powersave? Re: udldrmfb: causes WARN in i915 on X60 (x86-32)

2021-02-25 Thread Pavel Machek
Hi! > > > > This is in -next, but I get same behaviour on 5.11; and no, udl does > > > > > > Thanks for reporting. We are in the process of fixing the issue. The > > > latest > > > patch is at [1]. > > > > > > > Thank you, that fixes the DMA issue, and I can use the udl. > > > > ...for a whil

Re: [PATCH 3/8] drm/vc4: hdmi: Properly compute the BVB clock rate

2021-02-25 Thread Dave Stevenson
On Thu, 25 Feb 2021 at 16:44, Dave Stevenson wrote: > > Hi Maxime > > On Thu, 25 Feb 2021 at 15:59, Maxime Ripard wrote: > > > > The BVB clock rate computation doesn't take into account a mode clock of > > 594MHz that we're going to need to support 4k60. > > > > Signed-off-by: Maxime Ripard > >

Re: [PATCH v6 3/3] drm/amd/display: Skip modeset for front porch change

2021-02-25 Thread Kazlauskas, Nicholas
On 2021-02-12 8:08 p.m., Aurabindo Pillai wrote: [Why] A seamless transition between modes can be performed if the new incoming mode has the same timing parameters as the optimized mode on a display with a variable vtotal min/max. Smooth video playback usecases can be enabled with this seamless

[PATCH v3 0/3] iommu/arm-smmu: adreno-smmu page fault handling

2021-02-25 Thread Jordan Crouse
(resending for the 5.13 cycle) This is a stack to add an Adreno GPU specific handler for pagefaults. The first patch starts by wiring up report_iommu_fault for arm-smmu. The next patch adds a adreno-smmu-priv function hook to capture a handful of important debugging registers such as TTBR0, CONTEX

[PATCH v3 3/3] drm/msm: Improve the a6xx page fault handler

2021-02-25 Thread Jordan Crouse
Use the new adreno-smmu-priv fault info function to get more SMMU debug registers and print the current TTBR0 to debug per-instance pagetables and figure out which GPU block generated the request. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 4 +- drivers/gpu/drm/ms

Re: [PATCH v6 3/3] drm: Add GUD USB Display driver

2021-02-25 Thread Noralf Trønnes
Den 25.02.2021 10.58, skrev Peter Stuge: > Hi Noralf, > > Noralf Trønnes wrote: >> The driver supports a one bit monochrome transfer format: R1. This is not >> implemented in the gadget driver. It is added in preparation for future >> monochrome e-ink displays. > > I forgot, but I have a two-to

Re: [PATCH v2] drm/scheduler: Fix hang when sched_entity released

2021-02-25 Thread Christian König
Am 25.02.21 um 17:03 schrieb Andrey Grodzovsky: On 2021-02-25 2:53 a.m., Christian König wrote: Am 24.02.21 um 16:13 schrieb Andrey Grodzovsky: Ping Sorry, I've been on vacation this week. Andrey On 2021-02-20 7:12 a.m., Andrey Grodzovsky wrote: On 2/20/21 3:38 AM, Christian König wr

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-25 Thread Sudip Mukherjee
On Tue, Feb 23, 2021 at 02:09:58PM +0100, Greg KH wrote: > On Tue, Feb 23, 2021 at 01:51:09PM +0100, Thomas Zimmermann wrote: > > Hi > > > > Am 23.02.21 um 13:24 schrieb Greg KH: > > > On Tue, Feb 23, 2021 at 01:14:30PM +0100, Daniel Vetter wrote: > > > > On Tue, Feb 23, 2021 at 1:02 PM Greg KH

[git pull] drm fixes + msm-next for 5.12-rc1

2021-02-25 Thread Dave Airlie
Hi Linus, Hope power/internet are back on fully! This is fixes but I missed msm-next pull last week. It's been in drm-next anyways so shouldn't be a problem. Otherwise it's a selection of i915, amdgpu and misc fixes, one TTM memory leak, nothing really major stands out otherwise. Dave. drm-nex

Re: [git pull] drm fixes + msm-next for 5.12-rc1

2021-02-25 Thread pr-tracker-bot
The pull request you sent on Fri, 26 Feb 2021 05:23:53 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2021-02-26 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/fdce29602f865b016012eadeaec99800da916d3d Thank you! -- Deet-doot-dot, I am a bot. https://ko

[Bug 211649] "drm/amd/display: reuse current context instead of recreating one" cause hdmi hotplug blackscreen on amdgpu

2021-02-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211649 --- Comment #15 from Alex Deucher (alexdeuc...@gmail.com) --- Reverted: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=efc8278eecfd5e6fa36c5d41e71d038f534fe107 -- You may reply to this email to add a comment. You

Re: [PATCH v2] drm/scheduler: Fix hang when sched_entity released

2021-02-25 Thread Andrey Grodzovsky
On 2021-02-25 1:42 p.m., Christian König wrote: Am 25.02.21 um 17:03 schrieb Andrey Grodzovsky: On 2021-02-25 2:53 a.m., Christian König wrote: Am 24.02.21 um 16:13 schrieb Andrey Grodzovsky: Ping Sorry, I've been on vacation this week. Andrey On 2021-02-20 7:12 a.m., Andrey Grodzovs

Re: [PATCH] drm/amdgpu: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-02-25 Thread Alex Deucher
On Thu, Feb 25, 2021 at 4:02 AM Yang Li wrote: > > Fix the following coccicheck warning: > ./drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1589:0-23: WARNING: > fops_ib_preempt should be defined with DEFINE_DEBUGFS_ATTRIBUTE > ./drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1592:0-23: WARNING: > fops_

Re: [PATCH] drm/amd/display: remove unnecessary conversion to bool

2021-02-25 Thread Alex Deucher
On Thu, Feb 25, 2021 at 4:19 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c:243:67-72: > WARNING: conversion to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Applied. Thanks! Alex

Re: [PATCH] drm/amd/display: fix 64-bit integer division

2021-02-25 Thread Arnd Bergmann
On Thu, Feb 25, 2021 at 3:33 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > The new display synchronization code caused a regression > on all 32-bit architectures: > > ld.lld: error: undefined symbol: __aeabi_uldivmod > >>> referenced by dce_clock_source.c > >>> > >>> gpu/drm/

Re: [PATCH v6 3/3] drm: Add GUD USB Display driver

2021-02-25 Thread Peter Stuge
Noralf Trønnes wrote: > > I forgot, but I have a two-tone (black/red) e-ink display here, and I > > also have a 3-bpp RGB TFT display. > > I've been anticipating the need for more formats, but I didn't want to > add them without having a user. Otherwise I could end up adding stuff > that would nev

[PATCH v3] drm/scheduler: Fix hang when sched_entity released

2021-02-25 Thread Andrey Grodzovsky
Problem: If scheduler is already stopped by the time sched_entity is released and entity's job_queue not empty I encountred a hang in drm_sched_entity_flush. This is because drm_sched_entity_is_idle never becomes false. Fix: In drm_sched_fini detach all sched_entities from the scheduler's run queu

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-25 Thread Salvatore Bonaccorso
Hi, On Thu, Feb 25, 2021 at 07:01:57PM +, Sudip Mukherjee wrote: > On Tue, Feb 23, 2021 at 02:09:58PM +0100, Greg KH wrote: > > On Tue, Feb 23, 2021 at 01:51:09PM +0100, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 23.02.21 um 13:24 schrieb Greg KH: > > > > On Tue, Feb 23, 2021 at 01:14:3

Re: [PATCH] drm/amd/display: fix 64-bit integer division

2021-02-25 Thread Stempen, Vladimir
[AMD Official Use Only - Internal Distribution Only] Hi Arnd, I have all the patches ready and I have tested them with the feature/platform I'm working on and Bindu helped to test the 32bit build. I'm in process of submitting the latest change. Thanks, Vladimir. On 2021-02-25, 4:36 PM, "Arnd Be

Re: [PATCH] drm/amd/display: Fix an uninitialized index variable

2021-02-25 Thread Arnd Bergmann
On Thu, Feb 25, 2021 at 10:34 PM 'Nick Desaulniers' via Clang Built Linux wrote: > return parse_edid_cea(aconnector, edid_ext, EDID_LENGTH, vsdb_info) ? i : > -ENODEV; > > would suffice, but the patch is still fine as is. Right, I did not want to change more than necessary here, and the original

Re: [PATCH] drm/amd/display: Fix an uninitialized index variable

2021-02-25 Thread Alex Deucher
On Thu, Feb 25, 2021 at 10:01 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > clang points out that the new logic uses an always-uninitialized > array index: > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9810:38: warning: > variable 'i' is uninitialized when used here [-Wun

[Bug 211277] sometimes crash at s2ram-wake (Ryzen 3500U): amdgpu, drm, commit_tail, amdgpu_dm_atomic_commit_tail

2021-02-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211277 --- Comment #11 from kolAflash (kolafl...@kolahilft.de) --- (In reply to Alex Deucher from comment #10) > Can you bisect? > https://www.kernel.org/doc/html/latest/admin-guide/bug-bisect.html I will try to. But it will definitely need some time

[PATCH -next] fbdev: atyfb: use LCD management functions for PPC_PMAC also

2021-02-25 Thread Randy Dunlap
Include PPC_PMAC in the configs that use aty_ld_lcd() and aty_st_lcd() implementations so that the PM code may work correctly for PPC_PMAC. Suggested-by: Ville Syrjälä Signed-off-by: Randy Dunlap Cc: Daniel Vetter Cc: Nick Desaulniers Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedes

Re: [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-25 Thread John Stultz
On Tue, Feb 23, 2021 at 3:00 AM Daniel Vetter wrote: > > tldr; DMA buffers aren't normal memory, expecting that you can use > them like that (like calling get_user_pages works, or that they're > accounting like any other normal memory) cannot be guaranteed. > > Since some userspace only runs on in

[PATCH] dma-buf: heaps: Set VM_PFNMAP in mmap for system and cma heaps

2021-02-25 Thread John Stultz
Per discussion and patches here: https://lore.kernel.org/dri-devel/20210223105951.912577-1-daniel.vet...@ffwll.ch/ Daniel is planning on making VM_PFNMAP required on dmabufs. Thus to avoid the warn_on noise, set the VM_PFNMAP in the system and cma heap's mmap handler. Cc: Daniel Vetter Cc: J

RE: [PATCH][next] drm/i915/hdcp: Fix null pointer dereference of connector->encoder

2021-02-25 Thread Gupta, Anshuman
> -Original Message- > From: Colin King > Sent: Wednesday, February 24, 2021 12:49 AM > To: Jani Nikula ; Joonas Lahtinen > ; Vivi, Rodrigo ; > David Airlie ; Daniel Vetter ; C, > Ramalingam > ; Gupta, Anshuman ; > intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc:

[PATCH] radeon: ERROR: space prohibited before that ','

2021-02-25 Thread wangjingyu
drm_property_create_range(rdev->ddev, 0 , "coherent", 0, 1); Signed-off-by: wangjingyu --- drivers/gpu/drm/radeon/radeon_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c index 3a6fedad

Re: [PATCH V1 1/2] backlight: qcom-wled: Fix FSC update issue for WLED5

2021-02-25 Thread kgunda
On 2021-02-24 16:45, Daniel Thompson wrote: On Wed, Feb 24, 2021 at 09:20:47AM +0530, Kiran Gunda wrote: Currently, for WLED5, after FSC register update MOD_SYNC_BIT is toggled instead of SYNC_BIT. MOD_SYNC_BIT has to be toggled after the brightness update and SYNC_BIT has to be toggled after FS

  1   2   >