[PATCH] mutex: nuke mutex_trylock_recursive

2021-02-16 Thread Christian König
The last user went away in the 5.11 cycle. Signed-off-by: Christian König --- include/linux/mutex.h | 25 - kernel/locking/mutex.c | 10 -- scripts/checkpatch.pl | 6 -- 3 files changed, 41 deletions(-) diff --git a/include/linux/mutex.h b/include/linux/mu

Re: [PATCH v3 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-02-16 Thread Thomas Zimmermann
Hi, fantastic. Thanks for sending an update. There's been a some bitrot meanwhile. Review below. Am 16.02.21 um 01:39 schrieb Deepak Rawat: DRM driver for hyperv synthetic video device, based on hyperv_fb framebuffer driver. Also added config option "DRM_HYPERV" to enabled this driver. v2: -

Re: [PATCH 0/3] video: Remove in_interrupt() usage.

2021-02-16 Thread Sebastian Andrzej Siewior
On 2021-02-08 23:38:07 [+0100], To linux-fb...@vger.kernel.org wrote: > Folks, > > in the discussion about preempt count consistency across kernel > configurations: > > https://lore.kernel.org/r/20200914204209.256266...@linutronix.de/ > > it was concluded that the usage of in_interrupt() and re

Re: [PATCH v7 3/3] drm: Switch to %p4cc format modifier

2021-02-16 Thread Thomas Zimmermann
Hi Am 15.02.21 um 12:40 schrieb Sakari Ailus: Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a large number of temporary variables at the same time. Signed-off-by: Sakari Ailus --- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c| 5 ++-- drivers/gpu/drm/amd/amdgpu/

Re: [PATCH 0/3] video: Remove in_interrupt() usage.

2021-02-16 Thread Greg Kroah-Hartman
On Tue, Feb 16, 2021 at 09:35:00AM +0100, Sebastian Andrzej Siewior wrote: > On 2021-02-08 23:38:07 [+0100], To linux-fb...@vger.kernel.org wrote: > > Folks, > > > > in the discussion about preempt count consistency across kernel > > configurations: > > > > https://lore.kernel.org/r/202009142042

Re: [PATCH v7 3/3] drm: Switch to %p4cc format modifier

2021-02-16 Thread Sakari Ailus
Hi Thomas, Thanks for the review. On Tue, Feb 16, 2021 at 09:37:45AM +0100, Thomas Zimmermann wrote: > Hi > > Am 15.02.21 um 12:40 schrieb Sakari Ailus: > > Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a > > large number of temporary variables at the same time. > > >

Re: [PATCH v3] kcmp: Support selection of SYS_kcmp without CHECKPOINT_RESTORE

2021-02-16 Thread Daniel Vetter
On Mon, Feb 08, 2021 at 02:12:00PM -0800, Kees Cook wrote: > On Fri, Feb 05, 2021 at 10:00:12PM +, Chris Wilson wrote: > > Userspace has discovered the functionality offered by SYS_kcmp and has > > started to depend upon it. In particular, Mesa uses SYS_kcmp for > > os_same_file_description() i

Re: [PATCH 0/3] video: Remove in_interrupt() usage.

2021-02-16 Thread Daniel Vetter
On Tue, Feb 16, 2021 at 09:43:02AM +0100, Greg Kroah-Hartman wrote: > On Tue, Feb 16, 2021 at 09:35:00AM +0100, Sebastian Andrzej Siewior wrote: > > On 2021-02-08 23:38:07 [+0100], To linux-fb...@vger.kernel.org wrote: > > > Folks, > > > > > > in the discussion about preempt count consistency acro

Re: DMA-buf and uncached system memory

2021-02-16 Thread Daniel Vetter
On Mon, Feb 15, 2021 at 09:58:08AM +0100, Christian König wrote: > Hi guys, > > we are currently working an Freesync and direct scan out from system memory > on AMD APUs in A+A laptops. > > On problem we stumbled over is that our display hardware needs to scan out > from uncached system memory an

Re: [PATCH] mutex: nuke mutex_trylock_recursive

2021-02-16 Thread Daniel Vetter
On Tue, Feb 16, 2021 at 09:21:46AM +0100, Christian König wrote: > The last user went away in the 5.11 cycle. > > Signed-off-by: Christian König Nice. Reviewed-by: Daniel Vetter I think would be good to still stuff this into 5.12 before someone resurrects this zombie. -Daniel > --- > inclu

Re: [PATCH] mutex: nuke mutex_trylock_recursive

2021-02-16 Thread Peter Zijlstra
On Tue, Feb 16, 2021 at 10:29:00AM +0100, Daniel Vetter wrote: > On Tue, Feb 16, 2021 at 09:21:46AM +0100, Christian König wrote: > > The last user went away in the 5.11 cycle. > > > > Signed-off-by: Christian König > > Nice. > > Reviewed-by: Daniel Vetter > > I think would be good to still s

[PATCH v8 0/4] Add %p4cc printk modifier for V4L2 and DRM fourcc codes

2021-02-16 Thread Sakari Ailus
Hi all, On merging --- it would seem everyone is happy with merging this through the drm-misc tree. The last patch should wait until all users are gone for sure, probably to the next kernel release. There are no users of drm_get_format_name() in linux-next c

[PATCH v8 3/4] drm: Switch to %p4cc format modifier

2021-02-16 Thread Sakari Ailus
Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a large number of temporary variables at the same time. Signed-off-by: Sakari Ailus Reviewed-by: Petr Mladek Reviewed-by: Andy Shevchenko Acked-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c| 5

[PATCH v8 4/4] drm: Remove drm_get_format_name()

2021-02-16 Thread Sakari Ailus
The %p4cc printk format modifier was recently added to print fourcc codes, replacing drm_get_format_name(). The function is no longer needed, so remove it. Signed-off-by: Sakari Ailus Reviewed-by: Petr Mladek Reviewed-by: Andy Shevchenko --- drivers/gpu/drm/drm_fourcc.c | 25 --

[PATCH v8 2/4] v4l: ioctl: Use %p4cc printk modifier to print FourCC codes

2021-02-16 Thread Sakari Ailus
Now that we can print FourCC codes directly using printk, make use of the feature in V4L2 core. Signed-off-by: Sakari Ailus Acked-by: Mauro Carvalho Chehab Reviewed-by: Petr Mladek Reviewed-by: Andy Shevchenko --- drivers/media/v4l2-core/v4l2-ioctl.c | 85 +++- 1 file

[PATCH v8 1/4] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2021-02-16 Thread Sakari Ailus
Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM pixel formats denoted by fourccs. The fourcc encoding is the same for both so the same implementation can be used. Suggested-by: Mauro Carvalho Chehab Signed-off-by: Sakari Ailus Reviewed-by: Petr Mladek Reviewed-by: Serge

Re: [PATCH v8 3/4] drm: Switch to %p4cc format modifier

2021-02-16 Thread Andy Shevchenko
On Tue, Feb 16, 2021 at 12:19:30PM +0200, Sakari Ailus wrote: > Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a > large number of temporary variables at the same time. ... > - seq_printf(m, "\t\tuapi: [FB:%d] %s,0x%llx,%dx%d, visible=%s, src=" > DRM_RECT_FP_FMT ",

[PATCH 02/10] drm/qxl: more fence wait rework

2021-02-16 Thread Gerd Hoffmann
Move qxl_io_notify_oom() call into wait condition. That way the driver will call it again if one call wasn't enough. Also allows to remove the extra dma_fence_is_signaled() check and the goto. Fixes: 5a838e5d5825 ("drm/qxl: simplify qxl_fence_wait") Signed-off-by: Gerd Hoffmann --- drivers/gpu/

[PATCH 00/10] drm/qxl: a collection of fixes

2021-02-16 Thread Gerd Hoffmann
Mostly around locking. Gerd Hoffmann (10): drm/qxl: properly handle device init failures drm/qxl: more fence wait rework drm/qxl: use ttm bo priorities drm/qxl: fix lockdep issue in qxl_alloc_release_reserved drm/qxl: rename qxl_bo_kmap -> qxl_bo_kmap_locked drm/qxl: add qxl_bo_kmap/qx

[PATCH 04/10] drm/qxl: fix lockdep issue in qxl_alloc_release_reserved

2021-02-16 Thread Gerd Hoffmann
Call qxl_bo_unpin (which does a reservation) without holding the release_mutex lock. Fixes lockdep (correctly) warning on a possible deadlock. Fixes: 65ffea3c6e73 ("drm/qxl: unpin release objects") Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_release.c | 13 ++--- 1 file cha

[PATCH 03/10] drm/qxl: use ttm bo priorities

2021-02-16 Thread Gerd Hoffmann
Allow to set priorities for buffer objects. Use priority 1 for surface and cursor command releases. Use priority 0 for drawing command releases. That way the short-living drawing commands are first in line when it comes to eviction, making it *much* less likely that ttm_bo_mem_force_space() pick

[PATCH 06/10] drm/qxl: add qxl_bo_kmap/qxl_bo_kunmap

2021-02-16 Thread Gerd Hoffmann
Add kmap/kunmap variants which reserve (and pin) the bo. They can be used in case the caller doesn't hold a reservation for the bo. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_object.h | 2 ++ drivers/gpu/drm/qxl/qxl_object.c | 36 2 files changed,

[PATCH 07/10] drm/qxl: fix prime kmap

2021-02-16 Thread Gerd Hoffmann
Use the correct kmap variant. We don't have a reservation here, so we can't use the _locked version. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_prime.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_prime.c b/drivers/gpu/drm/qxl/qxl

[PATCH 10/10] drm/qxl: add lock asserts to qxl_bo_kmap_locked + qxl_bo_kunmap_locked

2021-02-16 Thread Gerd Hoffmann
Try avoid re-introducing locking bugs. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_object.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/qxl/qxl_object.c b/drivers/gpu/drm/qxl/qxl_object.c index 22748b9566af..90d5e5b7f927 100644 --- a/drivers/gpu/drm/qxl/q

[PATCH 08/10] drm/qxl: fix monitors object kmap

2021-02-16 Thread Gerd Hoffmann
Use the correct kmap variant. We don't hold a reservation here, so we can't use the _locked variant. We can drop the pin because qxl_bo_kmap will do that for us. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_display.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) dif

[PATCH 09/10] drm/qxl: map/unmap framebuffers in prepare_fb+cleanup_fb callbacks.

2021-02-16 Thread Gerd Hoffmann
We don't have to map in atomic_update callback then, making locking a bit less complicated. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_display.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/q

[PATCH 05/10] drm/qxl: rename qxl_bo_kmap -> qxl_bo_kmap_locked

2021-02-16 Thread Gerd Hoffmann
Make clear that these functions should be called with reserved bo's only. No functional change. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_object.h | 4 ++-- drivers/gpu/drm/qxl/qxl_display.c | 14 +++--- drivers/gpu/drm/qxl/qxl_draw.c| 8 drivers/gpu/drm/q

[PATCH 01/10] drm/qxl: properly handle device init failures

2021-02-16 Thread Gerd Hoffmann
Specifically do not try release resources which where not allocated in the first place. Cc: Tong Zhang Tested-by: Tong Zhang Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_display.c | 3 +++ drivers/gpu/drm/qxl/qxl_kms.c | 4 2 files changed, 7 insertions(+) diff --git a/dr

Re: [PATCH] drm/i915: Remove unused function pointer typedef long_pulse_detect_func

2021-02-16 Thread Ville Syrjälä
On Mon, Feb 15, 2021 at 07:30:19PM +0800, Chen Lin wrote: > From: Chen Lin > > Remove the 'long_pulse_detect_func' typedef as it is not used. > > Signed-off-by: Chen Lin > --- > drivers/gpu/drm/i915/i915_irq.c |1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i91

RE: [Intel-gfx] [PATCH] drm/i915/gem: Add a check for object size for corner cases

2021-02-16 Thread Ram Moon, AnandX
Hi Chris, -Original Message- From: dri-devel On Behalf Of Chris Wilson Sent: Monday, February 15, 2021 6:10 PM To: Auld, Matthew ; Ram Moon, AnandX ; Surendrakumar Upadhyay, TejaskumarX ; Ursulin, Tvrtko ; Jani Nikula ; dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org

Re: [Intel-gfx] [PATCH] drm/i915/gem: Add a check for object size for corner cases

2021-02-16 Thread Chris Wilson
Quoting Ram Moon, AnandX (2021-02-16 12:05:23) > Hi Chris, > > -Original Message- > From: dri-devel On Behalf Of Chris > Wilson > Sent: Monday, February 15, 2021 6:10 PM > To: Auld, Matthew ; Ram Moon, AnandX > ; Surendrakumar Upadhyay, TejaskumarX > ; Ursulin, Tvrtko > ; Jani Nikula

[PATCH] drm/dp_mst: Tune down the WARN modesetting a port with full_pbn=0

2021-02-16 Thread Imre Deak
It's possible to modeset a connector/mst port that has a 0 full_pbn value: if the sink on the port deasserts its HPD and a branch device reports this via a CSN with the port's ddps=0 and pdt!=NONE the driver clears full_pbn, but the corresponding connector can be still modesetted. This happened on

Re: [PATCH] mutex: nuke mutex_trylock_recursive

2021-02-16 Thread Christian König
Am 16.02.21 um 11:13 schrieb Peter Zijlstra: On Tue, Feb 16, 2021 at 10:29:00AM +0100, Daniel Vetter wrote: On Tue, Feb 16, 2021 at 09:21:46AM +0100, Christian König wrote: The last user went away in the 5.11 cycle. Signed-off-by: Christian König Nice. Reviewed-by: Daniel Vetter I think

Re: [PATCH] mutex: nuke mutex_trylock_recursive

2021-02-16 Thread Peter Zijlstra
On Tue, Feb 16, 2021 at 01:38:49PM +0100, Christian König wrote: > > > Am 16.02.21 um 11:13 schrieb Peter Zijlstra: > > On Tue, Feb 16, 2021 at 10:29:00AM +0100, Daniel Vetter wrote: > > > On Tue, Feb 16, 2021 at 09:21:46AM +0100, Christian König wrote: > > > > The last user went away in the 5.11

Re: [RFC PATCH 1/8] of/device: Allow specifying a custom iommu_spec to of_dma_configure

2021-02-16 Thread Robin Murphy
Hi Mikko, On 2021-02-08 16:38, Mikko Perttunen wrote: To allow for more customized device tree bindings that point to IOMMUs, allow manual specification of iommu_spec to of_dma_configure. The initial use case for this is with Host1x, where the driver manages a set of device tree-defined IOMMU c

Re: [PATCH 01/10] drm/qxl: properly handle device init failures

2021-02-16 Thread Thomas Zimmermann
Am 16.02.21 um 12:37 schrieb Gerd Hoffmann: Specifically do not try release resources which where not allocated in the first place. I still think this should eventually be resolved by using managed code. But for now Acked-by: Thomas Zimmermann Cc: Tong Zhang Tested-by: Tong Zhang Sig

Re: [PATCH v7 3/3] drm: Switch to %p4cc format modifier

2021-02-16 Thread Petr Mladek
On Tue 2021-02-16 09:37:45, Thomas Zimmermann wrote: > Hi > > Am 15.02.21 um 12:40 schrieb Sakari Ailus: > > Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a > > large number of temporary variables at the same time. > > > > Signed-off-by: Sakari Ailus > > --- > > driv

Re: [PATCH 05/10] drm/qxl: rename qxl_bo_kmap -> qxl_bo_kmap_locked

2021-02-16 Thread Thomas Zimmermann
Hi Am 16.02.21 um 12:37 schrieb Gerd Hoffmann: Make clear that these functions should be called with reserved bo's only. No functional change. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_object.h | 4 ++-- drivers/gpu/drm/qxl/qxl_display.c | 14 +++--- drivers/gpu/d

Re: [PATCH 07/10] drm/qxl: fix prime kmap

2021-02-16 Thread Thomas Zimmermann
Hi Am 16.02.21 um 12:37 schrieb Gerd Hoffmann: Use the correct kmap variant. We don't have a reservation here, so we can't use the _locked version. I'd merge this change into patch 6. So the new functions come with a caller. Best regards Thomas Signed-off-by: Gerd Hoffmann --- drivers/

Re: [PATCH 06/10] drm/qxl: add qxl_bo_kmap/qxl_bo_kunmap

2021-02-16 Thread Thomas Zimmermann
Hi Am 16.02.21 um 12:37 schrieb Gerd Hoffmann: Add kmap/kunmap variants which reserve (and pin) the bo. They can be used in case the caller doesn't hold a reservation for the bo. Again, these functions should rather be called vmap/vunamp. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/

Re: [PATCH 08/10] drm/qxl: fix monitors object kmap

2021-02-16 Thread Thomas Zimmermann
Am 16.02.21 um 12:37 schrieb Gerd Hoffmann: Use the correct kmap variant. We don't hold a reservation here, so we can't use the _locked variant. We can drop the pin because qxl_bo_kmap will do that for us. Signed-off-by: Gerd Hoffmann Acked-by: Thomas Zimmermann --- drivers/gpu/drm/q

Re: [PATCH v5 3/3] drm: Add Generic USB Display driver

2021-02-16 Thread Noralf Trønnes
Den 15.02.2021 12.58, skrev Peter Stuge: > Hi Noralf, > > I was happy to see v4 - thanks for accepting so much of my feedback - > and I have to say that the new recursive acronym makes me smile! :) > Yeah I also had to smile when Simon Ser suggested it. > > Noralf Trønnes wrote: >> +++ b/dri

Re: [RFC PATCH 1/8] of/device: Allow specifying a custom iommu_spec to of_dma_configure

2021-02-16 Thread Mikko Perttunen
On 2/16/21 2:47 PM, Robin Murphy wrote: Hi Mikko, On 2021-02-08 16:38, Mikko Perttunen wrote: To allow for more customized device tree bindings that point to IOMMUs, allow manual specification of iommu_spec to of_dma_configure. The initial use case for this is with Host1x, where the driver man

Re: [PATCH 09/10] drm/qxl: map/unmap framebuffers in prepare_fb+cleanup_fb callbacks.

2021-02-16 Thread Thomas Zimmermann
Hi this is a shadow-buffered plane. Did you consider using the new helpers for shadow-buffered planes? They will map the user BO for you and provide the mapping in the plane state. From there, you should implement your own plane state on top of struct drm_shadow_plane_state, and also move al

Re: [PATCH 10/10] drm/qxl: add lock asserts to qxl_bo_kmap_locked + qxl_bo_kunmap_locked

2021-02-16 Thread Thomas Zimmermann
Hi Am 16.02.21 um 12:37 schrieb Gerd Hoffmann: Try avoid re-introducing locking bugs. Signed-off-by: Gerd Hoffmann Acked-by: Thomas Zimmermann IMHO this should eventually be done in the rsp TTM functions. But so far, I'd expect this to break some drivers. Best regards Thomas --- dri

Re: [PATCH 09/10] drm/qxl: map/unmap framebuffers in prepare_fb+cleanup_fb callbacks.

2021-02-16 Thread Thomas Zimmermann
Am 16.02.21 um 14:27 schrieb Thomas Zimmermann: Hi this is a shadow-buffered plane. Did you consider using the new helpers for shadow-buffered planes? They will map the user BO for you and provide the mapping in the plane state. From there, you should implement your own plane state on top

Re: [PATCH v3 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-02-16 Thread Robin Murphy
On 2021-01-05 13:46, Kevin Tang wrote: Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang v2: - Use drm_xxx to replace all DRM_XX

Re: [PATCH v5 3/3] drm: Add Generic USB Display driver

2021-02-16 Thread Oliver Neukum
Am Freitag, den 12.02.2021, 18:46 +0100 schrieb Noralf Trønnes: > +static void gud_connector_early_unregister(struct drm_connector *connector) > +{ > + struct gud_connector *gconn = to_gud_connector(connector); > + > + backlight_device_unregister(gconn->backlight); > + cancel_work

Re: [PATCH 3/3] drm/tegra: Add NVDEC driver

2021-02-16 Thread Jon Hunter
On 13/02/2021 10:15, Mikko Perttunen wrote: > Add support for booting and using NVDEC on Tegra210, Tegra186 > and Tegra194 to the Host1x and TegraDRM drivers. Booting in > secure mode is not currently supported. > > Signed-off-by: Mikko Perttunen > --- > drivers/gpu/drm/tegra/Makefile | 3 +-

Re: [Freedreno] [v2] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu driver

2021-02-16 Thread kalyan_t
On 2021-02-12 23:19, Rob Clark wrote: On Thu, Feb 11, 2021 at 7:31 AM wrote: On 2021-02-11 01:56, Rob Clark wrote: > On Wed, Feb 10, 2021 at 3:41 AM wrote: >> >> On 2021-02-01 00:46, Rob Clark wrote: >> > On Fri, Dec 18, 2020 at 2:27 AM Kalyan Thota >> > wrote: >> >> >> >> Set the flag vblan

[v2] drm/i915: Use function pointer typedef long_pulse_detect_func in intel_get_hpd_pins

2021-02-16 Thread Chen Lin
From: Chen Lin Use function pointer typedef long_pulse_detect_func in intel_get_hpd_pins. Signed-off-by: Chen Lin --- drivers/gpu/drm/i915/i915_irq.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 6

[Bug 209713] amdgpu drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_link_encoder.c:483 dcn10_get_dig_frontend+0x9e/0xc0 [amdgpu] when resuming from S3 state

2021-02-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209713 Erik Quaeghebeur (kernelb...@equaeghe.nospammail.net) changed: What|Removed |Added CC||ke

[PATCH v9 4/4] drm: Remove drm_get_format_name()

2021-02-16 Thread Sakari Ailus
The %p4cc printk format modifier was recently added to print fourcc codes, replacing drm_get_format_name(). The function is no longer needed, so remove it. Signed-off-by: Sakari Ailus Reviewed-by: Petr Mladek Reviewed-by: Andy Shevchenko --- drivers/gpu/drm/drm_fourcc.c | 25 --

[PATCH v9 1/4] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2021-02-16 Thread Sakari Ailus
Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM pixel formats denoted by fourccs. The fourcc encoding is the same for both so the same implementation can be used. Suggested-by: Mauro Carvalho Chehab Signed-off-by: Sakari Ailus Reviewed-by: Petr Mladek Reviewed-by: Serge

[PATCH v9 0/4] Add %p4cc printk modifier for V4L2 and DRM fourcc codes

2021-02-16 Thread Sakari Ailus
Hi all, On merging --- it would seem everyone is happy with merging this through the drm-misc tree. The last patch should wait until all users are gone for sure, probably to the next kernel release. There are no users of drm_get_format_name() in linux-next c

[PATCH v9 2/4] v4l: ioctl: Use %p4cc printk modifier to print FourCC codes

2021-02-16 Thread Sakari Ailus
Now that we can print FourCC codes directly using printk, make use of the feature in V4L2 core. Signed-off-by: Sakari Ailus Acked-by: Mauro Carvalho Chehab Reviewed-by: Petr Mladek Reviewed-by: Andy Shevchenko --- drivers/media/v4l2-core/v4l2-ioctl.c | 85 +++- 1 file

[PATCH v9 3/4] drm: Switch to %p4cc format modifier

2021-02-16 Thread Sakari Ailus
Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a large number of temporary variables at the same time. Signed-off-by: Sakari Ailus Reviewed-by: Petr Mladek Reviewed-by: Andy Shevchenko Acked-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c| 5

Re: [Freedreno] [v2] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu driver

2021-02-16 Thread Rob Clark
On Tue, Feb 16, 2021 at 7:21 AM wrote: > > On 2021-02-12 23:19, Rob Clark wrote: > > On Thu, Feb 11, 2021 at 7:31 AM wrote: > >> > >> On 2021-02-11 01:56, Rob Clark wrote: > >> > On Wed, Feb 10, 2021 at 3:41 AM wrote: > >> >> > >> >> On 2021-02-01 00:46, Rob Clark wrote: > >> >> > On Fri, Dec 18

[PATCH v2] drm/nouveau/pmu: fix timeout on GP108

2021-02-16 Thread Diego Viola
This code times out on GP108, probably because the BIOS puts it into a bad state. Since we reset the PMU on driver load anyway, we are at no risk from missing a response from it since we are not waiting for one to begin with. Signed-off-by: Diego Viola --- drivers/gpu/drm/nouveau/nvkm/subdev/pm

Re: [PATCH v5 3/3] drm: Add Generic USB Display driver

2021-02-16 Thread Noralf Trønnes
Den 16.02.2021 14.36, skrev Oliver Neukum: > Am Freitag, den 12.02.2021, 18:46 +0100 schrieb Noralf Trønnes: >> +static void gud_connector_early_unregister(struct drm_connector *connector) >> +{ >> + struct gud_connector *gconn = to_gud_connector(connector); >> + >> + backlight_device

Re: [PATCH v5 3/3] drm: Add Generic USB Display driver

2021-02-16 Thread Noralf Trønnes
Den 16.02.2021 17.40, skrev Noralf Trønnes: > > > Den 16.02.2021 14.36, skrev Oliver Neukum: >> Am Freitag, den 12.02.2021, 18:46 +0100 schrieb Noralf Trønnes: >>> +static void gud_connector_early_unregister(struct drm_connector *connector) >>> +{ >>> + struct gud_connector *gconn = to_gu

[PATCH] drm/scheduler: Fix hang when sched_entity released

2021-02-16 Thread Andrey Grodzovsky
Problem: If scheduler is already stopped by the time sched_entity is released and entity's job_queue not empty I encountred a hang in drm_sched_entity_flush. This is because drm_sched_entity_is_idle never becomes false. Fix: In drm_sched_fini detach all sched_entities from the scheduler's run queu

Re: [PATCH] Revert "ARM: dts: bcm2711: Add the BSC interrupt controller"

2021-02-16 Thread Nicolas Saenz Julienne
On Fri, 2021-02-12 at 11:11 -0800, Florian Fainelli wrote: > As Dave reported: > > This seems to have unintended side effects. GIC interrupt 117 is shared > between the standard I2C controllers (i2c-bcm2835) and the l2-intc block > handling the HDMI I2C interrupts. > > There is not a great way t

Re: [PATCH v2 1/2] drm/msm: add compatibles for sm8150/sm8250 display

2021-02-16 Thread Dmitry Baryshkov
On Mon, 15 Feb 2021 at 19:25, Jonathan Marek wrote: > > The driver already has support for sm8150/sm8250, but the compatibles were > never added. > > Also inverse the non-mdp4 condition in add_display_components() to avoid > having to check every new compatible in the condition. > > Signed-off-by:

[Bug 211425] [drm:atom_op_jump] *ERROR* atombios stuck in loop for more than 20secs aborting

2021-02-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211425 --- Comment #9 from Andreas (icedragon...@web.de) --- This was my first patch bisection - after 14 rebuilds and reboots it says: 9555152beb1143c85c03f9b9de59863cbbe89f4b is the first bad commit commit 9555152beb1143c85c03f9b9de59863cbbe89f4b Merg

Re: [PATCH v2 1/2] drm/msm: add compatibles for sm8150/sm8250 display

2021-02-16 Thread Jonathan Marek
On 2/16/21 11:54 AM, Dmitry Baryshkov wrote: On Mon, 15 Feb 2021 at 19:25, Jonathan Marek wrote: The driver already has support for sm8150/sm8250, but the compatibles were never added. Also inverse the non-mdp4 condition in add_display_components() to avoid having to check every new compatibl

Re: [Intel-gfx] [PATCH v2] drm/i915/gen9bc: Handle TGP PCH during suspend/resume

2021-02-16 Thread Imre Deak
Hi, thanks for respinning this patchset, some comments below. On Fri, Feb 12, 2021 at 01:50:53PM -0500, Lyude Paul wrote: > From: Tejas Upadhyay > > For Legacy S3 suspend/resume GEN9 BC needs to enable and > setup TGP PCH. > > v2: > * Move Wa_14010685332 into it's own function - vsyrjala > * A

Re: [RFC PATCH 1/2] drm/dp: Make number of AUX retries configurable by display drivers.

2021-02-16 Thread Lyude Paul
On Sat, 2021-02-13 at 10:26 +, Almahallawy, Khaled wrote: > On Fri, 2021-02-12 at 21:01 -0500, Lyude Paul wrote: > > (adding danvet to here, as I'd imagine they might be interested in > > seeing some > > of this) > > > > Thank you for the descriptive write up. I think we can solve some of > >

Re: [PATCH 2/2] drm/amdkfd: Cleanup kfd_process if init_cwsr_apu fails

2021-02-16 Thread philip yang
Reviewed-by: Philip Yang for the series. On 2021-02-12 1:40 a.m., Felix Kuehling wrote: If init_cwsr_apu fails, we currently leave the kfd_process structure in place anyway. The next kfd_open will then succeed, using the existing kfd_process structure. Fix that by

[PATCH] drm/msm/a6xx: fix for kernels without CONFIG_NVMEM

2021-02-16 Thread Jonathan Marek
Ignore nvmem_cell_get() EOPNOTSUPP error in the same way as a ENOENT error, to fix the case where the kernel was compiled without CONFIG_NVMEM. Fixes: fe7952c629da ("drm/msm: Add speed-bin support to a618 gpu") Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 +++--- 1

[PATCH 1/1] drm/amdkfd: Fix recursive lock warnings

2021-02-16 Thread Felix Kuehling
memalloc_nofs_save/restore are no longer sufficient to prevent recursive lock warnings when holding locks that can be taken in MMU notifiers. Use memalloc_noreclaim_save/restore instead. Fixes: f920e413ff9c ("mm: track mmu notifiers in fs_reclaim_acquire/release") CC: Daniel Vetter Signed-off-by:

[Bug 211807] New: [drm:drm_dp_mst_dpcd_read] *ERROR* mstb 000000004e6288dd port 3: DPCD read on addr 0x60 for 1 bytes NAKed

2021-02-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211807 Bug ID: 211807 Summary: [drm:drm_dp_mst_dpcd_read] *ERROR* mstb 4e6288dd port 3: DPCD read on addr 0x60 for 1 bytes NAKed Product: Drivers Version: 2.5

Re: [PATCH v2 1/2] drm/msm: add compatibles for sm8150/sm8250 display

2021-02-16 Thread Dmitry Baryshkov
On Tue, 16 Feb 2021 at 21:06, Jonathan Marek wrote: > > On 2/16/21 11:54 AM, Dmitry Baryshkov wrote: > > On Mon, 15 Feb 2021 at 19:25, Jonathan Marek wrote: > >> > >> The driver already has support for sm8150/sm8250, but the compatibles were > >> never added. > >> > >> Also inverse the non-mdp4 c

[PATCH] drm/i915: Enable -Wuninitialized

2021-02-16 Thread Nathan Chancellor
-Wunintialized was disabled in commit c5627461490e ("drm/i915: Disable -Wuninitialized") because there were two warnings that were false positives. The first was due to DECLARE_WAIT_QUEUE_HEAD_ONSTACK, which was fixed in LLVM 9.0.0. The second was in busywait_stop, which was fixed in LLVM 10.0.0 (i

Re: [PATCH v2 1/2] drm/msm: add compatibles for sm8150/sm8250 display

2021-02-16 Thread Rob Clark
On Tue, Feb 16, 2021 at 10:06 AM Jonathan Marek wrote: > > On 2/16/21 11:54 AM, Dmitry Baryshkov wrote: > > On Mon, 15 Feb 2021 at 19:25, Jonathan Marek wrote: > >> > >> The driver already has support for sm8150/sm8250, but the compatibles were > >> never added. > >> > >> Also inverse the non-mdp

[RESEND PATCH] drm/tilcdc: fix raster control register setting

2021-02-16 Thread Dario Binacchi
The fdd property of the tilcdc_panel_info structure must set the reqdly bit field (bit 12 to 19) of the raster control register. The previous statement set the least significant bit instead. Signed-off-by: Dario Binacchi --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +- 1 file changed, 1 inser

[RESEND PATCH] drm/tilcdc: fix raster control register setting

2021-02-16 Thread Dario Binacchi
The fdd property of the tilcdc_panel_info structure must set the reqdly bit field (bit 12 to 19) of the raster control register. The previous statement set the least significant bit instead. Signed-off-by: Dario Binacchi --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +- 1 file changed, 1 inser

Re: [PATCH] Revert "ARM: dts: bcm2711: Add the BSC interrupt controller"

2021-02-16 Thread Florian Fainelli
On 2/12/2021 11:11 AM, Florian Fainelli wrote: > As Dave reported: > > This seems to have unintended side effects. GIC interrupt 117 is shared > between the standard I2C controllers (i2c-bcm2835) and the l2-intc block > handling the HDMI I2C interrupts. > > There is not a great way to share a

Re: [Intel-gfx] [PATCH v2] drm/i915/gen9bc: Handle TGP PCH during suspend/resume

2021-02-16 Thread Lyude Paul
On Tue, 2021-02-16 at 20:08 +0200, Imre Deak wrote: > Hi, > > thanks for respinning this patchset, some comments below. > > On Fri, Feb 12, 2021 at 01:50:53PM -0500, Lyude Paul wrote: > > From: Tejas Upadhyay > > > > For Legacy S3 suspend/resume GEN9 BC needs to enable and > > setup TGP PCH. >

Re: [Intel-gfx] [PATCH v2] drm/i915/gen9bc: Handle TGP PCH during suspend/resume

2021-02-16 Thread Lyude Paul
On Tue, 2021-02-16 at 21:36 -0500, Lyude Paul wrote: > On Tue, 2021-02-16 at 20:08 +0200, Imre Deak wrote: > > Hi, > > > > thanks for respinning this patchset, some comments below. > > > > On Fri, Feb 12, 2021 at 01:50:53PM -0500, Lyude Paul wrote: > > > From: Tejas Upadhyay > > > > > > For Leg

Re: [PATCH 1/1] drm/amdkfd: Fix recursive lock warnings

2021-02-16 Thread philip yang
On 2021-02-16 3:22 p.m., Felix Kuehling wrote: memalloc_nofs_save/restore are no longer sufficient to prevent recursive lock warnings when holding locks that can be taken in MMU notifiers. Use memalloc_noreclaim_save/restore instead. Fixes: f920e413ff9c ("mm

[PATCH v3 2/2] drm/i915/icp+: Use icp_hpd_irq_setup() instead of spt_hpd_irq_setup()

2021-02-16 Thread Lyude Paul
While reviewing patches for handling workarounds related to gen9 bc, Imre from Intel discovered that we're using spt_hpd_irq_setup() on ICP+ PCHs despite it being almost the same as icp_hpd_irq_setup(). Since we need to be calling icp_hpd_irq_setup() to ensure that CML-S/TGP platforms function corr

[PATCH v3 1/2] drm/i915/gen9bc: Handle TGP PCH during suspend/resume

2021-02-16 Thread Lyude Paul
From: Tejas Upadhyay For Legacy S3 suspend/resume GEN9 BC needs to enable and setup TGP PCH. v2: * Move Wa_14010685332 into it's own function - vsyrjala * Add TODO comment about figuring out if we can move this workaround - imre v3: * Rename cnp_irq_post_reset() to cnp_display_clock_wa() * Add T

Re: [PATCH] drm/msm/a6xx: fix for kernels without CONFIG_NVMEM

2021-02-16 Thread Rob Clark
On Tue, Feb 16, 2021 at 12:10 PM Jonathan Marek wrote: > > Ignore nvmem_cell_get() EOPNOTSUPP error in the same way as a ENOENT error, > to fix the case where the kernel was compiled without CONFIG_NVMEM. > > Fixes: fe7952c629da ("drm/msm: Add speed-bin support to a618 gpu") > Signed-off-by: Jonat

Re: [PATCH v2] drm/nouveau/pmu: fix timeout on GP108

2021-02-16 Thread Alexandre Courbot
On Wed, Feb 17, 2021 at 1:20 AM Diego Viola wrote: > > This code times out on GP108, probably because the BIOS puts it into a > bad state. > > Since we reset the PMU on driver load anyway, we are at no risk from > missing a response from it since we are not waiting for one to begin > with. This l

Re: [PATCH] drm-buf: Add debug option

2021-02-16 Thread John Stultz
On Wed, Jan 13, 2021 at 6:06 AM Daniel Vetter wrote: > > We have too many people abusing the struct page they can get at but > really shouldn't in importers. Aside from that the backing page might > simply not exist (for dynamic p2p mappings) looking at it and using it > e.g. for mmap can also wre

Re: [PATCH] drm-buf: Add debug option

2021-02-16 Thread John Stultz
On Tue, Feb 16, 2021 at 7:30 PM John Stultz wrote: > > On Wed, Jan 13, 2021 at 6:06 AM Daniel Vetter wrote: > > > > We have too many people abusing the struct page they can get at but > > really shouldn't in importers. Aside from that the backing page might > > simply not exist (for dynamic p2p m

Re: [RESEND PATCH] drm/tilcdc: fix raster control register setting

2021-02-16 Thread Tomi Valkeinen
On 16/02/2021 22:22, Dario Binacchi wrote: > The fdd property of the tilcdc_panel_info structure must set the reqdly > bit field (bit 12 to 19) of the raster control register. The previous > statement set the least significant bit instead. > > Signed-off-by: Dario Binacchi > > --- > > drivers

Re: [PATCH v4 24/80] drm/omap: dsi: move TE GPIO handling into core

2021-02-16 Thread Tomi Valkeinen
On 11/02/2021 19:35, Tony Lindgren wrote: > * Tomi Valkeinen [210211 07:35]: >> On 08/02/2021 19:55, Tony Lindgren wrote: >>> Hi, >>> >>> * Tomi Valkeinen [201124 12:47]: From: Sebastian Reichel In preparation for removing custom DSS calls from the DSI panel driver, this move

Re: [Intel-gfx] [PATCH v2] drm/i915/gen9bc: Handle TGP PCH during suspend/resume

2021-02-16 Thread Imre Deak
On Tue, Feb 16, 2021 at 09:36:01PM -0500, Lyude Paul wrote: > On Tue, 2021-02-16 at 20:08 +0200, Imre Deak wrote: > > Hi, > > > > thanks for respinning this patchset, some comments below. > > > > On Fri, Feb 12, 2021 at 01:50:53PM -0500, Lyude Paul wrote: > > > From: Tejas Upadhyay > > > > > >