Re: [RFC v3 2/3] virtio: Introduce Vdmabuf driver

2021-02-10 Thread Christian König
Hi Vivek, Am 10.02.21 um 05:47 schrieb Kasireddy, Vivek: Hi Gerd, -Original Message- From: Gerd Hoffmann Sent: Tuesday, February 09, 2021 12:45 AM To: Kasireddy, Vivek Cc: Daniel Vetter ; virtualizat...@lists.linux-foundation.org; dri- de...@lists.freedesktop.org; Vetter, Daniel ; d

Re: [PATCH] video: use getter/setter functions

2021-02-10 Thread Lee Jones
On Tue, 09 Feb 2021, Julia Lawall wrote: > Use getter and setter functions, for platform_device structures and a > spi_device structure. > > Signed-off-by: Julia Lawall > > --- > drivers/video/backlight/qcom-wled.c |2 > +- This patch is fine. Could you p

[RFC PATCH 1/2] drm/dp: Make number of AUX retries configurable by display drivers.

2021-02-10 Thread Khaled Almahallawy
The number of AUX retries specified in the DP specs is 7. Currently, to make Dell 4k monitors happier, the number of retries are 32. i915 also retries 5 times (intel_dp_aux_xfer) which means in the case of AUX timeout we actually retries 32 * 5 = 160 times. So making the number of aux retires a

[RFC PATCH 2/2] drm/i915/dp: Retry AUX requests 7 times.

2021-02-10 Thread Khaled Almahallawy
Given that intel_dp_aux_xfer retries 5 times, so configure drm_dpcd_access to retry only 7 times, which means the max number of retries for i915 = 7 * 5 = 35 times. Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/i915/display/intel_dp_aux.c | 2 ++ 1 file changed, 2 insertions(+) diff --

Re: [RFC PATCH 1/2] drm/dp: Make number of AUX retries configurable by display drivers.

2021-02-10 Thread Thomas Zimmermann
Hi Am 10.02.21 um 09:33 schrieb Khaled Almahallawy: The number of AUX retries specified in the DP specs is 7. Currently, to make Dell 4k monitors happier, the number of retries are 32. i915 also retries 5 times (intel_dp_aux_xfer) which means in the case of AUX timeout we actually retries 32 *

Re: [PATCH v2 10/16] drm/exynos: implement a drm bridge

2021-02-10 Thread Frieder Schrempf
On 04.02.21 18:46, Daniel Vetter wrote: On Thu, Feb 4, 2021 at 6:26 PM Laurent Pinchart wrote: Hi Daniel, On Thu, Feb 04, 2021 at 06:19:22PM +0100, Daniel Vetter wrote: On Thu, Feb 4, 2021 at 5:28 PM Andrzej Hajda wrote: W dniu 04.02.2021 o 17:05, Daniel Vetter pisze: On Thu, Feb 04, 2021

Re: [RFC v3 2/3] virtio: Introduce Vdmabuf driver

2021-02-10 Thread Gerd Hoffmann
> > You don't have to use the rendering pipeline. You can let the i915 gpu > > render into a dma-buf shared with virtio-gpu, then use virtio-gpu only for > > buffer sharing with the host. > [Kasireddy, Vivek] Is this the most viable path forward? I am not sure how > complex or > feasible it woul

Re: [RFC PATCH 1/2] drm/dp: Make number of AUX retries configurable by display drivers.

2021-02-10 Thread Almahallawy, Khaled
On Wed, 2021-02-10 at 09:55 +0100, Thomas Zimmermann wrote: > Hi > > Am 10.02.21 um 09:33 schrieb Khaled Almahallawy: > > The number of AUX retries specified in the DP specs is 7. > > Currently, to make Dell 4k monitors happier, the number of retries > > are 32. > > i915 also retries 5 times (inte

Re: [PATCH v5 0/2] Implement DE2.0 and DE3.0 per-plane alpha support

2021-02-10 Thread Maxime Ripard
On Thu, Jan 28, 2021 at 01:39:38PM +0200, Roman Stratiienko wrote: > > Please review/merge. > > v2: > Initial patch > > v3: > - Skip adding & applying alpha property if VI count > 1 (v3s case) > > v4: > Resend (author's email changed) > > v5: > Resend Applied, thanks Maxime signature.asc De

Re: [PATCH v3 1/5] clk: sunxi-ng: mp: fix parent rate change flag check

2021-02-10 Thread Maxime Ripard
Hi Mike, Stephen, On Tue, Feb 09, 2021 at 06:58:56PM +0100, Jernej Skrabec wrote: > CLK_SET_RATE_PARENT flag is checked on parent clock instead of current > one. Fix that. > > Fixes: 3f790433c3cb ("clk: sunxi-ng: Adjust MP clock parent rate when > allowed") > Reviewed-by: Chen-Yu Tsai > Tested-

Re: [PATCH v3 0/5] sunxi: fix H6 HDMI related issues

2021-02-10 Thread Maxime Ripard
On Tue, Feb 09, 2021 at 06:58:55PM +0100, Jernej Skrabec wrote: > Over the year I got plenty of reports of troubles with H6 HDMI signal. > Sometimes monitor flickers, sometimes there was no image at all and > sometimes it didn't play well with AVR. > > It turns out there are multiple issues. Patch

Re: [Intel-gfx] [PATCH] drm/i915/gem: Add a check for object size for corner cases

2021-02-10 Thread Chris Wilson
Quoting Anand Moon (2021-02-10 07:59:29) > Add check for object size to return appropriate error -E2BIG or -EINVAL > to avoid WARM_ON and sucessfull return for some testcase. No. You miss the point of having those warnings. We need to inspect the code to remove the last remaining "int pagenum", an

[PATCH v2 0/6] Support second Image Signal Processor on rk3399

2021-02-10 Thread Heiko Stuebner
The rk3399 has two ISPs and right now only the first one is usable. The second ISP is connected to the TXRX dphy on the soc. The phy of ISP1 is only accessible through the DSI controller's io-memory, so this series adds support for simply using the dsi controller is a phy if needed. That solution

[PATCH 5/6] arm64: dts: rockchip: add cif clk-control pinctrl for rk3399

2021-02-10 Thread Heiko Stuebner
From: Heiko Stuebner This enables variant a of the clkout signal for camera applications and also the cifclkin pinctrl setting. Signed-off-by: Heiko Stuebner Tested-by: Sebastian Fricke --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 12 1 file changed, 12 insertions(+) diff --gi

[PATCH v2 1/6] drm/rockchip: dsi: add own additional pclk handling

2021-02-10 Thread Heiko Stuebner
From: Heiko Stuebner In a followup patch, we'll need to access the pclk ourself to enable some functionality, so get and store it in the rockchip dw-dsi variant as well. Clocks are refcounted, so possible cascading enablements are no problem. Signed-off-by: Heiko Stuebner Tested-by: Sebastian

[PATCH 3/6] drm/rockchip: dsi: add ability to work as a phy instead of full dsi

2021-02-10 Thread Heiko Stuebner
From: Heiko Stuebner SoCs like the rk3288 and rk3399 have 3 mipi dphys on them. One is TX- only, one is RX-only and one can be configured to do either TX or RX. The RX phy is statically connected to the first Image Signal Processor, the TX phy is statically connected to the first DSI controller

[PATCH 4/6] arm64: dts: rockchip: add #phy-cells to mipi-dsi1

2021-02-10 Thread Heiko Stuebner
From: Heiko Stuebner The dsi controller includes access to the dphy which might be used not only for dsi output but also for csi input on dsi1, so add the necessary #phy-cells to allow it to be used as phy. Signed-off-by: Heiko Stuebner Tested-by: Sebastian Fricke --- arch/arm64/boot/dts/rock

[PATCH 6/6] arm64: dts: rockchip: add isp1 node on rk3399

2021-02-10 Thread Heiko Stuebner
From: Heiko Stuebner ISP1 is supplied by the tx1rx1 dphy, that is controlled from inside the dsi1 controller, so include the necessary phy-link for it. Signed-off-by: Heiko Stuebner Tested-by: Sebastian Fricke --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 26 1 file

[PATCH v2 2/6] dt-bindings: display: rockchip-dsi: add optional #phy-cells property

2021-02-10 Thread Heiko Stuebner
From: Heiko Stuebner The Rockchip DSI controller on some SoCs also controls a bidrectional dphy, which would be connected to an Image Signal Processor as a phy in the rx configuration. So allow a #phy-cells property for the dsi controller. Signed-off-by: Heiko Stuebner Acked-by: Rob Herring T

Re: [PATCH v2 0/6] Support second Image Signal Processor on rk3399

2021-02-10 Thread Heiko Stübner
Am Mittwoch, 10. Februar 2021, 12:10:14 CET schrieb Heiko Stuebner: > The rk3399 has two ISPs and right now only the first one is usable. > The second ISP is connected to the TXRX dphy on the soc. > > The phy of ISP1 is only accessible through the DSI controller's > io-memory, so this series adds

Re: [PATCH 0/6] Support second Image Signal Processor on rk3399

2021-02-10 Thread Heiko Stübner
Hi Sebastian, Am Freitag, 5. Februar 2021, 15:55:56 CET schrieb Heiko Stübner: > Hi Sebastian, > > I did some tests myself today as well and can confirm your > hdmi related finding - at least when plugged in on boot. > > I tried some combinations of camera vs. hdmi and it seems > really only whe

[Bug 210263] brightness device returns ENXIO (?) on brightness restore at boot, with bootoption "quiet"

2021-02-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210263 --- Comment #2 from ninel...@protonmail.com --- I just found out that this Issue does NOT occur when you additionally add the fbcon=nodefer kernel parameter. -- You may reply to this email to add a comment. You are receiving this mail because:

Re: [PATCH] drm/vblank: Document drm_crtc_vblank_restore constraints

2021-02-10 Thread Daniel Vetter
On Tue, Feb 09, 2021 at 05:36:07PM +0200, Ville Syrjälä wrote: > On Tue, Feb 09, 2021 at 11:15:23AM +0100, Daniel Vetter wrote: > > I got real badly confused when trying to review a fix from Ville for > > this. Let's try to document better what's required for this, and check > > the minimal setting

[PATCH] drm/i915/adl_s: Add gmbus pin mapping

2021-02-10 Thread Anand Moon
Add table to map the GMBUS pin pairs to GPIO registers and port to DDC mapping for ADL_S as per below Bspec. Bspec:20124, 53597. Cc: Aditya Swarup Cc: Matt Roper Cc: Lucas De Marchi Signed-off-by: Anand Moon --- drivers/gpu/drm/i915/display/intel_gmbus.c | 16 ++-- 1 file changed

Re: [PATCH v4, 01/10] soc: mediatek: mmsys: create mmsys folder

2021-02-10 Thread Matthias Brugger
On 09/02/2021 16:38, Enric Balletbo Serra wrote: > Hi Yongqiang Niu, > > Thank you for your patch. > > Missatge de Yongqiang Niu del dia dt., 5 > de gen. 2021 a les 4:07: >> >> the mmsys will more and more complicated after support >> more and more SoCs, add an independent folder will be >> m

[PATCH][next] drm/amd/pm: fix spelling mistake in various messages "power_dpm_force_perfomance_level"

2021-02-10 Thread Colin King
From: Colin Ian King There are spelling mistakes in error and warning messages, the text power_dpm_force_perfomance_level is missing a letter r and should be power_dpm_force_performance_level. Fix them. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c | 2

Re: [PATCH v13 7/8] soc: mediatek: add mtk mutex support for MT8183

2021-02-10 Thread Matthias Brugger
On 09/02/2021 15:48, Enric Balletbo Serra wrote: > Hi Hsin-Yi, > > Thank you for your patch. > > Missatge de Hsin-Yi Wang del dia dv., 29 de gen. > 2021 a les 10:23: >> >> From: Yongqiang Niu >> >> Add mtk mutex support for MT8183 SoC. >> >> Signed-off-by: Yongqiang Niu >> Signed-off-by: Hs

Re: [Freedreno] [v2] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu driver

2021-02-10 Thread kalyan_t
On 2021-02-01 00:46, Rob Clark wrote: On Fri, Dec 18, 2020 at 2:27 AM Kalyan Thota wrote: Set the flag vblank_disable_immediate = true to turn off vblank irqs immediately as soon as drm_vblank_put is requested so that there are no irqs triggered during idle state. This will reduce cpu wakeups

Re: [PATCH 5.10 078/120] drm/dp/mst: Export drm_dp_get_vc_payload_bw()

2021-02-10 Thread Pavel Machek
Hi! > commit 83404d581471775f37f85e5261ec0d09407d8bed upstream. > > This function will be needed by the next patch where the driver > calculates the BW based on driver specific parameters, so export it. > > At the same time sanitize the function params, passing the more natural > link rate inste

Re: [RFC PATCH 8/9] drm/gem: Associate GEM objects with drm cgroup

2021-02-10 Thread Daniel Vetter
On Wed, Feb 10, 2021 at 08:52:29AM +0100, Thomas Zimmermann wrote: > Hi > > Am 09.02.21 um 11:54 schrieb Daniel Vetter: > > *: vmwgfx is the only non-gem driver, but there's plans to move at least > > vmwgfx internals (maybe not the uapi, we'll see) over to gem. Once that's > > done it's truly all

Re: [PATCH 5.10 078/120] drm/dp/mst: Export drm_dp_get_vc_payload_bw()

2021-02-10 Thread Imre Deak
Hi, On Wed, Feb 10, 2021 at 01:25:17PM +0100, Pavel Machek wrote: > Hi! > > > commit 83404d581471775f37f85e5261ec0d09407d8bed upstream. > > > > This function will be needed by the next patch where the driver > > calculates the BW based on driver specific parameters, so export it. > > > > At the

Re: [PATCH 1/9] mm/migrate.c: Always allow device private pages to migrate

2021-02-10 Thread Jason Gunthorpe
On Wed, Feb 10, 2021 at 02:40:10PM +1100, Alistair Popple wrote: > On Wednesday, 10 February 2021 12:39:32 AM AEDT Jason Gunthorpe wrote: > > On Tue, Feb 09, 2021 at 12:07:14PM +1100, Alistair Popple wrote: > > > Device private pages are used to represent device memory that is not > > > directly ac

Re: [PATCH 0/9] Add support for SVM atomics in Nouveau

2021-02-10 Thread Daniel Vetter
On Tue, Feb 09, 2021 at 12:53:27PM -0800, John Hubbard wrote: > On 2/9/21 5:37 AM, Daniel Vetter wrote: > > On Tue, Feb 9, 2021 at 1:57 PM Alistair Popple wrote: > > > > > > On Tuesday, 9 February 2021 9:27:05 PM AEDT Daniel Vetter wrote: > > > > > > > > > > Recent changes to pin_user_pages() pr

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-10 Thread Daniel Vetter
On Tue, Feb 09, 2021 at 12:16:51PM -0800, Suren Baghdasaryan wrote: > On Tue, Feb 9, 2021 at 12:03 PM Daniel Vetter wrote: > > > > On Tue, Feb 9, 2021 at 6:46 PM Christian König > > wrote: > > > > > > > > > > > > Am 09.02.21 um 18:33 schrieb Suren Baghdasaryan: > > > > On Tue, Feb 9, 2021 at 4:5

Re: [PATCH] drm/gem: Move drm_gem_fb_prepare_fb() to GEM atomic helpers

2021-02-10 Thread Daniel Vetter
On Tue, Feb 09, 2021 at 11:29:13AM +0100, Thomas Zimmermann wrote: > The function drm_gem_fb_prepare_fb() is a helper for atomic modesetting, > but currently located next to framebuffer helpers. Move it to GEM atomic > helpers, rename it slightly and adopt the drivers. Same for the rsp > simple-pip

Re: [PATCH] drm: use getter/setter functions

2021-02-10 Thread Daniel Vetter
On Tue, Feb 09, 2021 at 10:13:04PM +0100, Julia Lawall wrote: > Use getter and setter functions, for platform_device structures and a > mipi_dsi_device structure. > > Signed-off-by: Julia Lawall Applied to drm-misc-next, thanks for the patch. -Daniel > > --- > drivers/gpu/drm/aspeed/aspeed_gfx

Re: [PATCH] video: use getter/setter functions

2021-02-10 Thread Daniel Vetter
On Wed, Feb 10, 2021 at 08:23:41AM +, Lee Jones wrote: > On Tue, 09 Feb 2021, Julia Lawall wrote: > > > Use getter and setter functions, for platform_device structures and a > > spi_device structure. > > > > Signed-off-by: Julia Lawall > > > > --- > > drivers/video/backlight/qcom-wled.c

Re: [PATCH 0/3] drm/ttm: constify static vm_operations_structs

2021-02-10 Thread Daniel Vetter
On Wed, Feb 10, 2021 at 08:45:56AM +0100, Christian König wrote: > Reviewed-by: Christian König for the series. Smash it into -misc? -Daniel > > Am 10.02.21 um 00:48 schrieb Rikard Falkeborn: > > Constify a few static vm_operations_struct that are never modified. Their > > only usage is to assi

Re: [PATCH] video: use getter/setter functions

2021-02-10 Thread Julia Lawall
On Wed, 10 Feb 2021, Daniel Vetter wrote: > On Wed, Feb 10, 2021 at 08:23:41AM +, Lee Jones wrote: > > On Tue, 09 Feb 2021, Julia Lawall wrote: > > > > > Use getter and setter functions, for platform_device structures and a > > > spi_device structure. > > > > > > Signed-off-by: Julia Lawall

Re: [Intel-gfx] [PATCH] Revert "drm/atomic: document and enforce rules around "spurious" EBUSY"

2021-02-10 Thread Daniel Vetter
On Tue, Feb 09, 2021 at 04:14:01PM -0800, Manasi Navare wrote: > This reverts commit fb6473a48b635c55d04eb94e579eede52ef39550. > > These additional checks added to avoid EBUSY give unnecessary WARN_ON > in case of big joiner used in i915 in which case even if the modeset > is requested on a single

Re: [Intel-gfx] [PATCH] Revert "drm/atomic: document and enforce rules around "spurious" EBUSY"

2021-02-10 Thread Simon Ser
On Wednesday, February 10th, 2021 at 2:16 PM, Daniel Vetter wrote: > On Tue, Feb 09, 2021 at 04:14:01PM -0800, Manasi Navare wrote: > > > These additional checks added to avoid EBUSY give unnecessary WARN_ON > > in case of big joiner used in i915 in which case even if the modeset > > is requeste

[PULL] drm-misc-fixes

2021-02-10 Thread Thomas Zimmermann
Hi Dave and Daniel, here's this week's PR for drm-misc-fixes. There's a buffer overflow in vc4 and a memory leak in xlnx. The rest appear to be mere bug fixes. Best regards Thomas drm-misc-fixes-2021-02-10: * dp_mst: Don't report un-attached ports as connected * sun4i: tcon1 sync polarity fix;

Re: [PATCH] drm/gem: Move drm_gem_fb_prepare_fb() to GEM atomic helpers

2021-02-10 Thread Thomas Zimmermann
Hi Am 10.02.21 um 14:10 schrieb Daniel Vetter: On Tue, Feb 09, 2021 at 11:29:13AM +0100, Thomas Zimmermann wrote: The function drm_gem_fb_prepare_fb() is a helper for atomic modesetting, but currently located next to framebuffer helpers. Move it to GEM atomic helpers, rename it slightly and ado

Re: linux-next: build failure after merge of the drm-misc tree

2021-02-10 Thread Maarten Lankhorst
Op 2021-02-10 om 04:11 schreef Stephen Rothwell: > Hi all, > > After merging the drm-misc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/gpu/drm/v3d/v3d_sched.c:263:1: error: return type is an incomplete > type > 263 | v3d_gpu_reset_for_timeout(struct v3d_de

[Bug 211649] "drm/amd/display: reuse current context instead of recreating one" cause hdmi hotplug blackscreen on amdgpu

2021-02-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211649 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

Re: [PATCH v2 14/15] ARM: dts: bcm2711: Add the BSC interrupt controller

2021-02-10 Thread Maxime Ripard
Hi Dave, On Tue, Feb 09, 2021 at 09:49:05AM +, Dave Stevenson wrote: > On Mon, 11 Jan 2021 at 14:23, Maxime Ripard wrote: > > > > The BSC controllers used for the HDMI DDC have an interrupt controller > > shared between both instances. Let's add it to avoid polling. > > This seems to have un

[Bug 211649] "drm/amd/display: reuse current context instead of recreating one" cause hdmi hotplug blackscreen on amdgpu

2021-02-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211649 Nicholas Kazlauskas (nicholas.kazlaus...@amd.com) changed: What|Removed |Added CC||nichol

Re: [Intel-gfx] [PATCH] Revert "drm/atomic: document and enforce rules around "spurious" EBUSY"

2021-02-10 Thread Ville Syrjälä
On Wed, Feb 10, 2021 at 01:38:45PM +, Simon Ser wrote: > On Wednesday, February 10th, 2021 at 2:16 PM, Daniel Vetter > wrote: > > > On Tue, Feb 09, 2021 at 04:14:01PM -0800, Manasi Navare wrote: > > > > > These additional checks added to avoid EBUSY give unnecessary WARN_ON > > > in case of

[PATCH 1/3] drm/ttm: move swapout logic around

2021-02-10 Thread Christian König
Move the iteration of the global lru into the new function ttm_global_swapout() and use that instead in drivers. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c| 57 - drivers/gpu/drm/ttm/ttm_device.c| 29 +++ drivers/gpu/drm/tt

[PATCH 3/3] drm/ttm: switch to per device LRU lock

2021-02-10 Thread Christian König
Instead of having a global lock. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 8 ++--- drivers/gpu/drm/qxl/qxl_release.c | 5 +-- drivers/gpu/drm/ttm/ttm_bo.c | 49 -- drivers/gpu/drm/ttm/ttm_device.c | 12 +++ dri

[PATCH 2/3] drm/ttm: remove swap LRU

2021-02-10 Thread Christian König
Instead evict round robin from each devices SYSTEM and TT domain. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c| 31 ++- drivers/gpu/drm/ttm/ttm_bo_util.c | 1 - drivers/gpu/drm/ttm/ttm_device.c| 59 + drivers/gpu/drm/vmwgf

Re: [PATCH v2 14/15] ARM: dts: bcm2711: Add the BSC interrupt controller

2021-02-10 Thread Marc Zyngier
Hi Maxime, On 2021-02-10 14:40, Maxime Ripard wrote: Hi Dave, On Tue, Feb 09, 2021 at 09:49:05AM +, Dave Stevenson wrote: On Mon, 11 Jan 2021 at 14:23, Maxime Ripard wrote: > > The BSC controllers used for the HDMI DDC have an interrupt controller > shared between both instances. Let's ad

Re: [PATCH v2 14/15] ARM: dts: bcm2711: Add the BSC interrupt controller

2021-02-10 Thread Dave Stevenson
Hi Marc. On Wed, 10 Feb 2021 at 15:30, Marc Zyngier wrote: > > Hi Maxime, > > On 2021-02-10 14:40, Maxime Ripard wrote: > > Hi Dave, > > > > On Tue, Feb 09, 2021 at 09:49:05AM +, Dave Stevenson wrote: > >> On Mon, 11 Jan 2021 at 14:23, Maxime Ripard wrote: > >> > > >> > The BSC controllers u

[PATCH] drm/ttm: make sure pool pages are cleared

2021-02-10 Thread Christian König
The old implementation wasn't consistend on this. But it looks like we depend on this so better bring it back. Signed-off-by: Christian König Reported-and-tested-by: Mike Galbraith Fixes: d099fc8f540a ("drm/ttm: new TT backend allocation pool v3") --- drivers/gpu/drm/ttm/ttm_pool.c | 10 ++

[Bug 210263] brightness device returns ENXIO (?) on brightness restore at boot, with bootoption "quiet"

2021-02-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210263 --- Comment #3 from Fabian (plusf...@gmail.com) --- (In reply to ninelore from comment #2) > I just found out that this Issue does NOT occur when you additionally add > the fbcon=nodefer kernel parameter. This workaround works for me too. -- Yo

Re: [PATCH] video: use getter/setter functions

2021-02-10 Thread Lee Jones
On Wed, 10 Feb 2021, Daniel Vetter wrote: > On Wed, Feb 10, 2021 at 08:23:41AM +, Lee Jones wrote: > > On Tue, 09 Feb 2021, Julia Lawall wrote: > > > > > Use getter and setter functions, for platform_device structures and a > > > spi_device structure. > > > > > > Signed-off-by: Julia Lawall

[Bug 211649] "drm/amd/display: reuse current context instead of recreating one" cause hdmi hotplug blackscreen on amdgpu

2021-02-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211649 --- Comment #3 from youling...@gmail.com --- replug hdmi, [drm:drm_atomic_helper_wait_for_flip_done [drm_kms_helper]] *ERROR* [CRTC:67:crtc-0] flip_done timed out [ 252.377374] [drm:drm_atomic_helper_wait_for_flip_done [drm_kms_helper]] *ERROR*

Re: [PATCH 3/9] drm: Add simplekms driver

2021-02-10 Thread Thomas Zimmermann
Hi Am 29.06.20 um 11:06 schrieb Daniel Vetter: + ARRAY_SIZE(simplekms_formats), + simplekms_format_modifiers, + connector); + if (ret) + return ret; +

Re: [PATCH] drm/i915/adl_s: Add gmbus pin mapping

2021-02-10 Thread Aditya Swarup
On 2/10/21 3:54 AM, Anand Moon wrote: > Add table to map the GMBUS pin pairs to GPIO registers and port to DDC > mapping for ADL_S as per below Bspec. Has this patch been tested on an ADLS system? Upstream CI AFAIK doesn't have support for ADL-S. Also comments below.. > > Bspec:20124, 53597. >

[PATCH] pinctrl/sunxi: adding input-debounce-ns property

2021-02-10 Thread Marjan Pascolo
On Allwinner SoC interrupt debounce can be controlled by two oscillator (32KHz and 24MHz) and a prescale divider. Oscillator and prescale divider are set through device tree property "input-debounce" which have 1uS accuracy. For acheive nS precision a new device tree poperty is made named "input-d

[Bug 211649] "drm/amd/display: reuse current context instead of recreating one" cause hdmi hotplug blackscreen on amdgpu

2021-02-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211649 --- Comment #4 from youling...@gmail.com --- Created attachment 295189 --> https://bugzilla.kernel.org/attachment.cgi?id=295189&action=edit dmesg.txt echo 6 > /sys/module/drm/parameters/debug replug hdmi dmesg. -- You may reply to this email

[Bug 211649] "drm/amd/display: reuse current context instead of recreating one" cause hdmi hotplug blackscreen on amdgpu

2021-02-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211649 --- Comment #5 from Nicholas Kazlauskas (nicholas.kazlaus...@amd.com) --- It would be good to know what OS/Userspace this is, I don't think I've seen anything that has atomic check failures on nearly every flip, eg: [ 179.142898] [drm:amdgpu_dm_

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-10 Thread Daniel Vetter
On Wed, Feb 10, 2021 at 5:39 PM Suren Baghdasaryan wrote: > > On Wed, Feb 10, 2021 at 5:06 AM Daniel Vetter wrote: > > > > On Tue, Feb 09, 2021 at 12:16:51PM -0800, Suren Baghdasaryan wrote: > > > On Tue, Feb 9, 2021 at 12:03 PM Daniel Vetter wrote: > > > > > > > > On Tue, Feb 9, 2021 at 6:46 PM

[Bug 211649] "drm/amd/display: reuse current context instead of recreating one" cause hdmi hotplug blackscreen on amdgpu

2021-02-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211649 --- Comment #6 from youling...@gmail.com --- Created attachment 295193 --> https://bugzilla.kernel.org/attachment.cgi?id=295193&action=edit amdgpu_dm_dtn_log I using amd 3400g running on androidx86 7 with mesa21.0 cat /sys/kernel/debug/dri/0/a

Re: [PATCH] PCI: Also set up legacy files only after sysfs init

2021-02-10 Thread Daniel Vetter
Hi Bjorn, Can you ack this for merging through my topic branch with the other follow_pfn/iomem revoke fixes for 5.12? If not, what's the plan for getting this (or equivalent functionality) in for 5.13? I have more of these follow_pfn/iomem revoke patches on top, so I'd like to get the first cut m

Re: [PATCH 0/9] Add support for SVM atomics in Nouveau

2021-02-10 Thread Jason Gunthorpe
On Tue, Feb 09, 2021 at 04:17:38PM -0500, Jerome Glisse wrote: > > > Yes, I would like to avoid the long term pin constraints as well if > > > possible I > > > just haven't found a solution yet. Are you suggesting it might be > > > possible to > > > add a callback in the page migration logic to

Re: [PATCH 0/9] Add support for SVM atomics in Nouveau

2021-02-10 Thread Jason Gunthorpe
On Tue, Feb 09, 2021 at 12:53:27PM -0800, John Hubbard wrote: > This direction sounds at least...possible. Using MMU notifiers instead of pins > is definitely appealing. I'm not quite clear on the callback idea above, but > overall it seems like taking advantage of the ZONE_DEVICE tracking of page

Re: [RFC PATCH 1/2] drm/dp: Make number of AUX retries configurable by display drivers.

2021-02-10 Thread Lyude Paul
On Wed, 2021-02-10 at 00:33 -0800, Khaled Almahallawy wrote: > The number of AUX retries specified in the DP specs is 7. Currently, to make > Dell 4k monitors happier, the number of retries are 32. > i915 also retries 5 times (intel_dp_aux_xfer) which means in the case of AUX > timeout we actually

Re: [PATCH] drm/ttm: make sure pool pages are cleared

2021-02-10 Thread Daniel Vetter
On Wed, Feb 10, 2021 at 5:05 PM Christian König wrote: > > The old implementation wasn't consistend on this. > > But it looks like we depend on this so better bring it back. > > Signed-off-by: Christian König > Reported-and-tested-by: Mike Galbraith > Fixes: d099fc8f540a ("drm/ttm: new TT backen

Re: [PATCH 3/3] drm/v3d: Add job timeout module param

2021-02-10 Thread Chema Casanova
On 5/2/21 13:28, Yukimasa Sugizaki wrote: On 05/02/2021, Eric Anholt wrote: On Thu, Feb 4, 2021 at 10:09 AM Chema Casanova wrote: On 3/9/20 18:48, Yukimasa Sugizaki wrote: From: Yukimasa Sugizaki The default timeout is 500 ms which is too short for some workloads including Piglit. Adding

[Bug 211649] "drm/amd/display: reuse current context instead of recreating one" cause hdmi hotplug blackscreen on amdgpu

2021-02-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211649 --- Comment #7 from Nicholas Kazlauskas (nicholas.kazlaus...@amd.com) --- That makes more sense then, that's the behavior I'd expect on CrOS/Android. Also explains why we haven't seen this on X/Wayland based compositors like GNOME on Ubuntu. One

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-10 Thread Christian König
Am 10.02.21 um 17:39 schrieb Suren Baghdasaryan: On Wed, Feb 10, 2021 at 5:06 AM Daniel Vetter wrote: On Tue, Feb 09, 2021 at 12:16:51PM -0800, Suren Baghdasaryan wrote: On Tue, Feb 9, 2021 at 12:03 PM Daniel Vetter wrote: On Tue, Feb 9, 2021 at 6:46 PM Christian König wrote: Am 09.02.

Re: [PATCH v6] dt-bindings: display: panel: one file of all simple LVDS panels with dual ports

2021-02-10 Thread Rob Herring
On Tue, Feb 09, 2021 at 10:13:12PM +0800, Liu Ying wrote: > To complement panel-simple.yaml, create panel-simple-lvds-dual-ports.yaml. > panel-simple-lvds-dual-ports.yaml is for all simple LVDS panels that > have dual LVDS ports and require only a single power-supply. > The first port receives odd

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-10 Thread Christian König
Am 10.02.21 um 20:12 schrieb Suren Baghdasaryan: On Wed, Feb 10, 2021 at 10:32 AM Christian König wrote: Am 10.02.21 um 17:39 schrieb Suren Baghdasaryan: On Wed, Feb 10, 2021 at 5:06 AM Daniel Vetter wrote: On Tue, Feb 09, 2021 at 12:16:51PM -0800, Suren Baghdasaryan wrote: On Tue, Feb

[Bug 211649] "drm/amd/display: reuse current context instead of recreating one" cause hdmi hotplug blackscreen on amdgpu

2021-02-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211649 --- Comment #8 from youling...@gmail.com --- (In reply to Nicholas Kazlauskas from comment #7) > That makes more sense then, that's the behavior I'd expect on CrOS/Android. > > Also explains why we haven't seen this on X/Wayland based compositors

[Bug 211649] "drm/amd/display: reuse current context instead of recreating one" cause hdmi hotplug blackscreen on amdgpu

2021-02-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211649 --- Comment #9 from youling...@gmail.com --- Created attachment 295197 --> https://bugzilla.kernel.org/attachment.cgi?id=295197&action=edit dmesg.txt I delete "read -n 1", can output dmesg.txt and trace.txt. trace.txt, # tracer: function # # en

[Bug 211649] "drm/amd/display: reuse current context instead of recreating one" cause hdmi hotplug blackscreen on amdgpu

2021-02-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211649 --- Comment #10 from Nicholas Kazlauskas (nicholas.kazlaus...@amd.com) --- I don't expect the trace log to be completely empty. You'll need to leave the trace log running after enabling it as well (with tracing on/trace). You'll also need variou

[Bug 211649] "drm/amd/display: reuse current context instead of recreating one" cause hdmi hotplug blackscreen on amdgpu

2021-02-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211649 --- Comment #11 from youling...@gmail.com --- Created attachment 295201 --> https://bugzilla.kernel.org/attachment.cgi?id=295201&action=edit trace.txt cat /sys/kernel/debug/tracing/trace -- You may reply to this email to add a comment. You a

[Bug 211649] "drm/amd/display: reuse current context instead of recreating one" cause hdmi hotplug blackscreen on amdgpu

2021-02-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211649 --- Comment #12 from Nicholas Kazlauskas (nicholas.kazlaus...@amd.com) --- Thanks, this was what I'm looking for. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. __

Re: [PATCH v3 3/3] dt-bindings: mediatek,dpi: add mt8192 to mediatek,dpi

2021-02-10 Thread Rob Herring
On Mon, 08 Feb 2021 09:42:21 +0800, Jitao Shi wrote: > Add compatible "mediatek,mt8192-dpi" for the mt8192 dpi. > > Signed-off-by: Jitao Shi > --- > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring ___

Re: [Freedreno] [v2] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu driver

2021-02-10 Thread Rob Clark
On Wed, Feb 10, 2021 at 3:41 AM wrote: > > On 2021-02-01 00:46, Rob Clark wrote: > > On Fri, Dec 18, 2020 at 2:27 AM Kalyan Thota > > wrote: > >> > >> Set the flag vblank_disable_immediate = true to turn off vblank irqs > >> immediately as soon as drm_vblank_put is requested so that there are > >

Re: [PATCH] drm/ttm: make sure pool pages are cleared

2021-02-10 Thread Christian König
Am 10.02.21 um 19:15 schrieb Daniel Vetter: On Wed, Feb 10, 2021 at 5:05 PM Christian König wrote: The old implementation wasn't consistend on this. But it looks like we depend on this so better bring it back. Signed-off-by: Christian König Reported-and-tested-by: Mike Galbraith Fixes: d0

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-10 Thread Suren Baghdasaryan
On Wed, Feb 10, 2021 at 5:06 AM Daniel Vetter wrote: > > On Tue, Feb 09, 2021 at 12:16:51PM -0800, Suren Baghdasaryan wrote: > > On Tue, Feb 9, 2021 at 12:03 PM Daniel Vetter wrote: > > > > > > On Tue, Feb 9, 2021 at 6:46 PM Christian König > > > wrote: > > > > > > > > > > > > > > > > Am 09.02.

Re: [PATCH] drm: Fix HDMI_STATIC_METADATA_TYPE1 constant.

2021-02-10 Thread Mario Kleiner
Ping! Anybody wanna review the most trivial, obviously correct, and non-intrusive patch ever to fix a real bug? The Kodi devs changed their broken constant and as if by magic, some LG TV now has working HDR support, so we now know the constant is actually expected to be correct by at least some rea

Re: [PATCH 2/2] drm/amd/display: Fix HDMI deep color output for DCE 6-11.

2021-02-10 Thread Mario Kleiner
Ping. Any bit of info appreciated wrt. the DCE-11.2+ situation. -mario On Mon, Jan 25, 2021 at 8:24 PM Mario Kleiner wrote: > Thanks Alex and Nicholas! Brings quite a bit of extra shiny to those older > asics :) > > Nicholas, any thoughts on my cover-letter wrt. why a similar patch (that I > wro

Re: [PATCH] drm: Fix HDMI_STATIC_METADATA_TYPE1 constant.

2021-02-10 Thread Simon Ser
On Wednesday, February 10th, 2021 at 10:04 PM, Mario Kleiner wrote: > Ping! I now understand the problem better. Reviewed-by: Simon Ser I'll push to drm-misc-next in a few days if no-one complains. Ping me again if I forget. ___ dri-devel mailing l

[PATCH][next] drm/amd/display: Fix potential integer overflow

2021-02-10 Thread Gustavo A. R. Silva
Fix potential integer overflow by casting actual_calculated_clock_100hz to u64, in order to give the compiler complete information about the proper arithmetic to use. Notice that such variable is used in a context that expects an expression of type u64 (64 bits, unsigned) and the following express

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-10 Thread Suren Baghdasaryan
On Wed, Feb 10, 2021 at 9:21 AM Daniel Vetter wrote: > > On Wed, Feb 10, 2021 at 5:39 PM Suren Baghdasaryan wrote: > > > > On Wed, Feb 10, 2021 at 5:06 AM Daniel Vetter wrote: > > > > > > On Tue, Feb 09, 2021 at 12:16:51PM -0800, Suren Baghdasaryan wrote: > > > > On Tue, Feb 9, 2021 at 12:03 PM

Re: [PATCH] PCI: Also set up legacy files only after sysfs init

2021-02-10 Thread Bjorn Helgaas
On Fri, Feb 05, 2021 at 02:36:32PM +0100, Daniel Vetter wrote: > We are already doing this for all the regular sysfs files on PCI > devices, but not yet on the legacy io files on the PCI buses. Thus far > no problem, but in the next patch I want to wire up iomem revoke > support. That needs the vfs

Re: [RFC PATCH 8/9] drm/gem: Associate GEM objects with drm cgroup

2021-02-10 Thread Brian Welty
On 2/9/2021 2:54 AM, Daniel Vetter wrote: > On Tue, Jan 26, 2021 at 01:46:25PM -0800, Brian Welty wrote: >> This patch adds tracking of which cgroup to make charges against for a >> given GEM object. We associate the current task's cgroup with GEM objects >> as they are created. First user of t

Re: [PATCH v4 11/14] drm/amdgpu: Guard against write accesses after device removal

2021-02-10 Thread Andrey Grodzovsky
On 2/9/21 10:40 AM, Christian König wrote: Am 09.02.21 um 15:30 schrieb Andrey Grodzovsky: [SNIP] Question - Why can't we just set those PTEs to point to system memory (another RO dummy page) filled with 1s ? Then writes are not discarded. E.g. the 1s would change to something else. Chris

Re: [PATCH] drm: Fix HDMI_STATIC_METADATA_TYPE1 constant.

2021-02-10 Thread Mario Kleiner
On Wed, Feb 10, 2021 at 10:14 PM Simon Ser wrote: > On Wednesday, February 10th, 2021 at 10:04 PM, Mario Kleiner < > mario.kleiner...@gmail.com> wrote: > > > Ping! > > I now understand the problem better. > > Reviewed-by: Simon Ser > > I'll push to drm-misc-next in a few days if no-one complains

[Bug 211651] Dual screen not working with Nvidia GTX 1050ti in a notebook

2021-02-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211651 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

Re: [PATCH 2/2] PCI: Revoke mappings like devmem

2021-02-10 Thread Bjorn Helgaas
I see I already acked this, but if you haven't merged it yet there are a few typos in the commit log: On Thu, Feb 04, 2021 at 05:58:31PM +0100, Daniel Vetter wrote: > Since 3234ac664a87 ("/dev/mem: Revoke mappings when a driver claims > the region") /dev/kmem zaps ptes when the kernel requests exc

[pull] amdgpu drm-fixes-5.11

2021-02-10 Thread Alex Deucher
Hi Dave, Daniel, Just a single revert to fix a blank screen. The following changes since commit 92bf22614b21a2706f4993b278017e437f7785b3: Linux 5.11-rc7 (2021-02-07 13:57:38 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.

[PATCH][next] drm/amd/pm: Replace one-element array with flexible-array in struct SISLANDS_SMC_SWSTATE

2021-02-10 Thread Gustavo A. R. Silva
There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2]. Refacto

Re: [RFC/PATCH v2 11/16] dt-bindings: gpu: v3d: Add BCM2711's compatible

2021-02-10 Thread Rob Herring
On Tue, 09 Feb 2021 13:59:07 +0100, Nicolas Saenz Julienne wrote: > BCM2711, Raspberry Pi 4's SoC, contains a V3D core. So add its specific > compatible to the bindings. > > Signed-off-by: Nicolas Saenz Julienne > --- > Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 1 + > 1 file chan

Re: [RFC][PATCH v6 1/7] drm: Add a sharable drm page-pool implementation

2021-02-10 Thread Suren Baghdasaryan
On Wed, Feb 10, 2021 at 10:32 AM Christian König wrote: > > > > Am 10.02.21 um 17:39 schrieb Suren Baghdasaryan: > > On Wed, Feb 10, 2021 at 5:06 AM Daniel Vetter wrote: > >> On Tue, Feb 09, 2021 at 12:16:51PM -0800, Suren Baghdasaryan wrote: > >>> On Tue, Feb 9, 2021 at 12:03 PM Daniel Vetter w

Re: [Intel-gfx] [PATCH] Revert "drm/atomic: document and enforce rules around "spurious" EBUSY"

2021-02-10 Thread Navare, Manasi
On Wed, Feb 10, 2021 at 05:07:03PM +0200, Ville Syrjälä wrote: > On Wed, Feb 10, 2021 at 01:38:45PM +, Simon Ser wrote: > > On Wednesday, February 10th, 2021 at 2:16 PM, Daniel Vetter > > wrote: > > > > > On Tue, Feb 09, 2021 at 04:14:01PM -0800, Manasi Navare wrote: > > > > > > > These addi

[PATCH][next] drm/amd/pm: Replace one-element array with flexible-array in struct _ATOM_Vega10_GFXCLK_Dependency_Table

2021-02-10 Thread Gustavo A. R. Silva
There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2]. Use fle

  1   2   >