Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas

2021-02-03 Thread Geert Uytterhoeven
Hi Rob, On Tue, Feb 2, 2021 at 9:55 PM Rob Herring wrote: > Properties in if/then schemas weren't getting checked by the meta-schemas. > Enabling meta-schema checks finds several errors. > > The use of an 'items' schema (as opposed to the list form) is wrong in > some cases as it applies to all e

Re: fbcon: remove soft scrollback code (missing Doc. patch)

2021-02-03 Thread Thomas Zimmermann
Hi Am 15.01.21 um 09:06 schrieb Geert Uytterhoeven: Hi Daniel, On Thu, Jan 14, 2021 at 5:11 PM Daniel Vetter wrote: On Thu, Jan 14, 2021 at 4:56 PM Geert Uytterhoeven wrote: On Tue, Jan 12, 2021 at 5:00 PM Daniel Vetter wrote: On Sat, Jan 9, 2021 at 12:11 AM Linus Torvalds wrote: On Fri

Re: [PATCH v2 2/2] dma-buf: heaps: Map system heap pages as managed by linux vm

2021-02-03 Thread Christian König
Am 03.02.21 um 03:02 schrieb Suren Baghdasaryan: On Tue, Feb 2, 2021 at 5:39 PM Minchan Kim wrote: On Tue, Feb 02, 2021 at 04:31:34PM -0800, Suren Baghdasaryan wrote: Currently system heap maps its buffers with VM_PFNMAP flag using remap_pfn_range. This results in such buffers not being accoun

Re: [PATCH 3/5] drm/msm/dsi_pll_10nm: Fix bad VCO rate calculation and prescaler

2021-02-03 Thread AngeloGioacchino Del Regno
Il 01/02/21 18:31, Rob Clark ha scritto: On Mon, Feb 1, 2021 at 9:18 AM Rob Clark wrote: On Mon, Feb 1, 2021 at 9:05 AM Rob Clark wrote: On Mon, Feb 1, 2021 at 7:47 AM Rob Clark wrote: On Mon, Feb 1, 2021 at 2:11 AM AngeloGioacchino Del Regno wrote: Il 31/01/21 20:50, Rob Clark ha scr

[PATCH] drm/msm/adreno: fix debugfs_simple_attr.cocci warnings

2021-02-03 Thread Tian Tao
fixed the below warning: ./drivers/gpu/drm/msm/adreno/a5xx_debugfs.c:141:0-23: WARNING: reset_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE. Signed-off-by: Tian Tao --- drivers/gpu/drm/msm/adreno/a5xx_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gp

Re: [PATCH 13/13] module: remove EXPORT_UNUSED_SYMBOL*

2021-02-03 Thread Miroslav Benes
On Tue, 2 Feb 2021, Christoph Hellwig wrote: > EXPORT_UNUSED_SYMBOL* is not actually used anywhere. Remove the > unused functionality as we generally just remove unused code anyway. > > Signed-off-by: Christoph Hellwig Reviewed-by: Miroslav Benes M ___

Re: [PATCH 12/13] module: remove EXPORT_SYMBOL_GPL_FUTURE

2021-02-03 Thread Miroslav Benes
On Tue, 2 Feb 2021, Christoph Hellwig wrote: > As far as I can tell this has never been used at all, and certainly > not any time recently. Right, I've always wondered about this one. > Signed-off-by: Christoph Hellwig Reviewed-by: Miroslav Benes M __

Re: [PATCH] drm/lima: Use delayed timer as default in devfreq profile

2021-02-03 Thread Lukasz Luba
On 2/2/21 1:01 AM, Qiang Yu wrote: Hi Lukasz, Thanks for the explanation. So the deferred timer option makes a mistake that when GPU goes from idle to busy for only one poll periodic, in this case 50ms, right? Not exactly. Driver sets the polling interval to 50ms (in this case) because it n

Re: [PATCH] drm/fourcc: introduce DRM_FOURCC_STANDALONE guard

2021-02-03 Thread James Park
On Tue, Feb 2, 2021 at 4:57 PM Emil Velikov wrote: > On Tue, 2 Feb 2021 at 23:25, James Park > wrote: > > > > On Tue, Feb 2, 2021 at 2:47 PM Emil Velikov > wrote: > > > > > > Currently, the drm_fourcc.h header depends on drm.h for __u32 and > __u64. > > > At the same time drm.h pulls a lot of u

[PATCH] drm/bridge/analogix: remove redundant when devm_kzalloc failed

2021-02-03 Thread Bernard Zhao
Line 1590 DRM_ERROR is redundant because devm_kzalloc() already prints an error. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers

Re: [PATCH] drm: drm_basic_types.h, DRM_FOURCC_STANDALONE

2021-02-03 Thread James Park
I'm not sure what your suggestion is. Move which #ifdef block where? I don't think everyone is of the opinion that adding drm.h and pulling in unnecessary kernel structures is fine. If I'm not mistaken, the reason people are making me jump through hoops in the first place is to avoid that. I appr

Re: fbcon: remove soft scrollback code (missing Doc. patch)

2021-02-03 Thread Phillip Susi
Daniel Vetter writes: > Just a quick comment on this: Since most framebuffers are write-combining, > and reads from that tend to be ~3 orders of magnitude slower than writes > (at least on the pile of machines I looked at here, there's big > differences, and some special streaming cpu instructio

[PATCH] drm/amdgpu: convert sysfs sprintf/snprintf family to sysfs_emit

2021-02-03 Thread Jiapeng Chong
Fix the following coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c:220:8-16: WARNING: use scnprintf or sprintf. ./drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c:249:8-16: WARNING: use scnprintf or sprintf. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/am

Re: [PATCH] drm/vc4: remove unneeded variable: "ret"

2021-02-03 Thread Maxime Ripard
On Tue, Feb 02, 2021 at 04:23:38AM -0800, Bernard Zhao wrote: > remove unneeded variable: "ret". > > Signed-off-by: Bernard Zhao Applied, thanks maxime signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.o

[PATCH v3] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-02-03 Thread Oliver Graute
Add support for the Solomon Goldentek Display Model: GKTW70SDAD1SD to panel-simple. The panel spec from Variscite can be found at: https://www.variscite.com/wp-content/uploads/2017/12/VLCD-CAP-GLD-RGB.pdf Signed-off-by: Oliver Graute Cc: Marco Felsch Cc: Fabio Estevam --- v3: - added flags -

Re: [PATCH 09/13] module: merge each_symbol_section into find_symbol

2021-02-03 Thread Miroslav Benes
On Tue, 2 Feb 2021, Christoph Hellwig wrote: > each_symbol_section is only called by find_symbol, so merge the two > functions. > > Signed-off-by: Christoph Hellwig Reviewed-by: Miroslav Benes M ___ dri-devel mailing list dri-devel@lists.freedesktop

Re: [PATCH v4 2/2] arm: dts: sc7180: Add support for gpu fuse

2021-02-03 Thread Bjorn Andersson
On Fri 08 Jan 12:15 CST 2021, Akhil P Oommen wrote: Please align the $subject prefix with other changes in the same file. I fixed it up while picking up the patch this time. Regards, Bjorn > Add support for gpu fuse to help identify the supported opps. > > Signed-off-by: Akhil P Oommen > --- >

[PATCH] drm/amdgpu: convert sysfs sprintf/snprintf family to sysfs_emit

2021-02-03 Thread Jiapeng Chong
Fix the following coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:207:8-16: WARNING: use scnprintf or sprintf. ./drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:185:8-16: WARNING: use scnprintf or sprintf. ./drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:163:8-16: WARNING: use scnprintf

Re: [PATCH 10/13] module: pass struct find_symbol_args to find_symbol

2021-02-03 Thread Miroslav Benes
> void *__symbol_get(const char *symbol) > { > - struct module *owner; > - const struct kernel_symbol *sym; > + struct find_symbol_arg fsa = { > + .name = symbol, > + .gplok = true, > + .warn = true, > + }; > > preempt_disable(); >

[PATCH] drm/vc4: remove unneeded variable: "ret"

2021-02-03 Thread Bernard Zhao
remove unneeded variable: "ret". Signed-off-by: Bernard Zhao --- drivers/gpu/drm/vc4/vc4_gem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_gem.c b/drivers/gpu/drm/vc4/vc4_gem.c index b641252939d8..445d3bab89e0 100644 --- a/drivers/gpu/drm/vc4/vc4

[PATCH] drm/tegra: remove unneeded variable: "ret"

2021-02-03 Thread Bernard Zhao
remove unneeded variable: "ret". Signed-off-by: Bernard Zhao --- drivers/gpu/drm/tegra/dpaux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c index 105fb9cdbb3b..b8abd55f3ef8 100644 --- a/drivers/gpu/drm/tegra/d

Re: [PATCH 06/13] kallsyms: only build {, module_}kallsyms_on_each_symbol when required

2021-02-03 Thread Miroslav Benes
On Tue, 2 Feb 2021, Christoph Hellwig wrote: > kallsyms_on_each_symbol and module_kallsyms_on_each_symbol are only used > by the livepatching code, so don't build them if livepatching is not > enabled. > > Signed-off-by: Christoph Hellwig Reviewed-by: Miroslav Benes M

Re: [PATCH] drm/vc4: hvs: Fix buffer overflow with the dlist handling

2021-02-03 Thread Maxime Ripard
On Fri, Jan 29, 2021 at 05:06:47PM +0100, Maxime Ripard wrote: > Commit 0a038c1c29a7 ("drm/vc4: Move LBM creation out of > vc4_plane_mode_set()") changed the LBM allocation logic from first > allocating the LBM memory for the plane to running mode_set, > adding a gap in the LBM, and then running th

Re: [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error

2021-02-03 Thread Miaohe Lin
Hi: On 2021/2/3 8:31, Suren Baghdasaryan wrote: > Replace BUG_ON(vma->vm_flags & VM_PFNMAP) in vm_insert_page with > WARN_ON_ONCE and returning an error. This is to ensure users of the > vm_insert_page that set VM_PFNMAP are notified of the wrong flag usage > and get an indication of an error witho

Re: [PATCH 07/13] module: mark module_mutex static

2021-02-03 Thread Miroslav Benes
On Tue, 2 Feb 2021, Christoph Hellwig wrote: > Except for two lockdep asserts module_mutex is only used in module.c. > Remove the two asserts given that the functions they are in are not > exported and just called from the module code, and mark module_mutex > static. > > Signed-off-by: Christoph

Re: [PATCH 1/3] printk: use CONFIG_CONSOLE_LOGLEVEL_* directly

2021-02-03 Thread John Ogness
On 2021-02-02, Masahiro Yamada wrote: > CONSOLE_LOGLEVEL_DEFAULT is nothing more than a shorthand of > CONFIG_CONSOLE_LOGLEVEL_DEFAULT. > > When you change CONFIG_CONSOLE_LOGLEVEL_DEFAULT from Kconfig, almost > all objects are rebuilt because CONFIG_CONSOLE_LOGLEVEL_DEFAULT is > used in , which is

Re: [PATCH 08/13] module: remove each_symbol_in_section

2021-02-03 Thread Miroslav Benes
On Tue, 2 Feb 2021, Christoph Hellwig wrote: > each_symbol_in_section just contains a trivial loop over its arguments. > Just open code the loop in the two callers. > > Signed-off-by: Christoph Hellwig Reviewed-by: Miroslav Benes M ___ dri-devel mai

Re: [PATCH] drm/fourcc: introduce DRM_FOURCC_STANDALONE guard

2021-02-03 Thread James Park
On Tue, Feb 2, 2021 at 2:47 PM Emil Velikov wrote: > > Currently, the drm_fourcc.h header depends on drm.h for __u32 and __u64. > At the same time drm.h pulls a lot of unneeded symbols. > > Add new guard DRM_FOURCC_STANDALONE, which when set will use local > declaration of said symbols. > > When u

Re: [PATCH] backlight: pcf50633: pdata may be a null pointer, null pointer dereference cause crash

2021-02-03 Thread FUZZ DR
Sorry about the missing description, I have a description at my local commit. But the commit description disappeared when I used git send-email to submit this patch. backlight: pcf50633: pdata may be a null pointer, null pointer dereference causes crash pdata has been checked at line 120 before d

Re: [PATCH] mailbox: arm_mhuv2: make remove callback return void

2021-02-03 Thread Viresh Kumar
On 02-02-21, 20:43, Uwe Kleine-König wrote: > My build tests failed to catch that amba driver that would have needed > adaption in commit 3fd269e74f2f ("amba: Make the remove callback return > void"). Change the remove function to make the driver build again. > > Reported-by: kernel test robot >

[PATCH] drm/msm/dpu: remove unneeded semicolon

2021-02-03 Thread Yang Li
Eliminate the following coccicheck warning: ./drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c:752:2-3: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/d

Re: [PATCH 05/13] kallsyms: refactor {,module_}kallsyms_on_each_symbol

2021-02-03 Thread Miroslav Benes
On Mon, 1 Feb 2021, Christoph Hellwig wrote: > On Mon, Feb 01, 2021 at 02:37:12PM +0100, Miroslav Benes wrote: > > > > This change is not needed. (objname == NULL) means that we are > > > > interested only in symbols in "vmlinux". > > > > > > > > module_kallsyms_on_each_symbol(klp_find_callback,

[PATCH] gpu/drm/msm: remove redundant when devm_kzalloc failed

2021-02-03 Thread Bernard Zhao
Line 1826 pr_err is redundant because memory alloc already prints an error when failed. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index ab281cba0

[PATCH] amd/display: remove unneeded variable: "pattern"

2021-02-03 Thread Bernard Zhao
Remove unneeded variable: "pattern". Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c index

Re: [PATCH] drm/msm: remove unneeded variable: "rc"

2021-02-03 Thread Stephen Boyd
Quoting Bernard Zhao (2021-02-02 04:32:03) > remove unneeded variable: "rc". > > Signed-off-by: Bernard Zhao > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-

[PATCH] drm/hisilicon: remove redundant when devm_kzalloc failed

2021-02-03 Thread Bernard Zhao
Line 852 DRM_ERROR is redundant because memory alloc already prints an error when failed. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/

Re: [PATCH 11/13] module: move struct symsearch to module.c

2021-02-03 Thread Miroslav Benes
On Tue, 2 Feb 2021, Christoph Hellwig wrote: > struct symsearch is only used inside of module.h, so move the definition > out of module.h. > > Signed-off-by: Christoph Hellwig Reviewed-by: Miroslav Benes M ___ dri-devel mailing list dri-devel@lists.

Re: [PATCH 3/5] drm/msm/dsi_pll_10nm: Fix bad VCO rate calculation and prescaler

2021-02-03 Thread AngeloGioacchino Del Regno
Il 02/02/21 19:45, Rob Clark ha scritto: On Tue, Feb 2, 2021 at 6:32 AM AngeloGioacchino Del Regno wrote: Il 01/02/21 18:31, Rob Clark ha scritto: On Mon, Feb 1, 2021 at 9:18 AM Rob Clark wrote: On Mon, Feb 1, 2021 at 9:05 AM Rob Clark wrote: On Mon, Feb 1, 2021 at 7:47 AM Rob Clark wr

[PATCH v1] drm/qxl: do not run release if qxl failed to init

2021-02-03 Thread Tong Zhang
if qxl_device_init() fail, drm device will not be registered, in this case, do not run qxl_drm_release() [5.258534] == [5.258931] BUG: KASAN: user-memory-access in qxl_destroy_monitors_object+0x42/0xa0 [qxl] [5.259388] W

[PATCH] drm/msm: remove unneeded variable: "rc"

2021-02-03 Thread Bernard Zhao
remove unneeded variable: "rc". Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/dp/dp_panel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c index d1780bcac8cc..9cc816663668 100644 --- a/drivers/gpu

[PATCH] video: udlfb: convert sysfs sprintf/snprintf family to sysfs_emit

2021-02-03 Thread Jiapeng Chong
Fix the following coccicheck warning: ./drivers/video/fbdev/udlfb.c:1452:8-16: WARNING: use scnprintf or sprintf. ./drivers/video/fbdev/udlfb.c:1444:8-16: WARNING: use scnprintf or sprintf. ./drivers/video/fbdev/udlfb.c:1436:8-16: WARNING: use scnprintf or sprintf. ./drivers/video/fbdev/udlfb.c

[PATCH] drm/msm/dp: remove unneeded semicolon

2021-02-03 Thread Yang Li
Eliminate the following coccicheck warning: ./drivers/gpu/drm/msm/dp/dp_ctrl.c:1161:2-3: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b

Re: [PATCH 2/3] fix the out-of-bounds access of dramsr13

2021-02-03 Thread FUZZ DR
The patch in previous email is a stupid mistake, please ignore it. Thanks. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error

2021-02-03 Thread Matthew Wilcox
On Tue, Feb 02, 2021 at 04:31:33PM -0800, Suren Baghdasaryan wrote: > Replace BUG_ON(vma->vm_flags & VM_PFNMAP) in vm_insert_page with > WARN_ON_ONCE and returning an error. This is to ensure users of the > vm_insert_page that set VM_PFNMAP are notified of the wrong flag usage > and get an indicati

Re: [PATCH] drm/nouveau: remove set but not used variable ‘pdev’ in nouveau_bios_init

2021-02-03 Thread Thomas Zimmermann
Applied to drm-misc-next. Thanks for the patch! Am 23.01.21 um 02:30 schrieb Ye Bin: Fix follow warning: drivers/gpu/drm/nouveau/nouveau_bios.c:2086:18: warning: variable ‘pdev’ set but not used [-Wunused-but-set-variable] struct pci_dev *pdev; ^~~~ Reported-by: Hulk Robo

Re: [Linux-graphics-maintainer] [PATCH 2/3] drm/ttm: move memory accounting into vmwgfx v3

2021-02-03 Thread Christian König
Hi Zack, thanks I can take over again from here on. Quite busy today, but I think I can go over the code once more tomorrow. Thanks for the help, Christian. Am 03.02.21 um 03:45 schrieb Zack Rusin: Just had a quick peek. The issue is that you can’t attach to the drm device (card0) because it

[amdgpu] deadlock

2021-02-03 Thread Daniel Gomez
Hi all, I have a deadlock with the amdgpu mainline driver when running in parallel two OpenCL applications. So far, we've been able to replicate it easily by executing clinfo and MatrixMultiplication (from AMD opencl-samples). It's quite old the opencl-samples so, if you have any other suggestion

Re: [amdgpu] deadlock

2021-02-03 Thread Christian König
Hi Daniel, this is not a deadlock, but rather a hardware lockup. Which OpenCl stack are you using? Regards, Christian. Am 03.02.21 um 09:33 schrieb Daniel Gomez: Hi all, I have a deadlock with the amdgpu mainline driver when running in parallel two OpenCL applications. So far, we've been abl

Re: [amdgpu] deadlock

2021-02-03 Thread Daniel Vetter
On Wed, Feb 3, 2021 at 9:36 AM Christian König wrote: > > Hi Daniel, > > this is not a deadlock, but rather a hardware lockup. Are you sure? Ime getting stuck in dma_fence_wait has generally good chance of being a dma_fence deadlock. GPU hang should never result in a forever stuck dma_fence. Dan

Re: [amdgpu] deadlock

2021-02-03 Thread Christian König
Am 03.02.21 um 09:48 schrieb Daniel Vetter: On Wed, Feb 3, 2021 at 9:36 AM Christian König wrote: Hi Daniel, this is not a deadlock, but rather a hardware lockup. Are you sure? Ime getting stuck in dma_fence_wait has generally good chance of being a dma_fence deadlock. GPU hang should never r

Re: [Linaro-mm-sig] [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error

2021-02-03 Thread Daniel Vetter
On Wed, Feb 3, 2021 at 2:57 AM Matthew Wilcox wrote: > > On Tue, Feb 02, 2021 at 04:31:33PM -0800, Suren Baghdasaryan wrote: > > Replace BUG_ON(vma->vm_flags & VM_PFNMAP) in vm_insert_page with > > WARN_ON_ONCE and returning an error. This is to ensure users of the > > vm_insert_page that set VM_P

Re: [amdgpu] deadlock

2021-02-03 Thread Daniel Gomez
On Wed, 3 Feb 2021 at 09:51, Christian König wrote: > > Am 03.02.21 um 09:48 schrieb Daniel Vetter: > > On Wed, Feb 3, 2021 at 9:36 AM Christian König > > wrote: > >> Hi Daniel, > >> > >> this is not a deadlock, but rather a hardware lockup. > > Are you sure? Ime getting stuck in dma_fence_wait

[PATCH] drm/i915/adl_s: ADL-S platform Update PCI ids for Mobile BGA

2021-02-03 Thread Anand Moon
As per Bspec: 53655 Update PCI ids for Mobile BGA. Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: David Airlie Cc: Daniel Vetter Signed-off-by: Anand Moon diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index ebd0dd1c35b3..3be25768321d 100644 --- a/include/drm/i

[PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe

2021-02-03 Thread Jagan Teki
Usual I2C configured DSI bridge drivers have drm_bridge_add in probe and mipi_dsi_attach in bridge attach functions. With, this approach the drm pipeline is unable to find the dsi bridge in stm drm drivers since the dw-mipi-dsi bridge is adding drm bridge during bridge attach operations instead of

Re: [amdgpu] deadlock

2021-02-03 Thread Daniel Vetter
On Wed, Feb 3, 2021 at 9:51 AM Christian König wrote: > > Am 03.02.21 um 09:48 schrieb Daniel Vetter: > > On Wed, Feb 3, 2021 at 9:36 AM Christian König > > wrote: > >> Hi Daniel, > >> > >> this is not a deadlock, but rather a hardware lockup. > > Are you sure? Ime getting stuck in dma_fence_wai

Re: [PATCH] drm/fourcc: introduce DRM_FOURCC_STANDALONE guard

2021-02-03 Thread Simon Ser
On Wednesday, February 3rd, 2021 at 1:56 AM, Emil Velikov wrote: > As summed in the commit message the burden is only applicable when all > of the following are set: > - non-linux > - force DRM_FOURCC_STANDALONE > - c99 -pedantic > > Even then, we're talking about a compilation warning. So ye

Re: [PATCH] drm/fourcc: introduce DRM_FOURCC_STANDALONE guard

2021-02-03 Thread Simon Ser
On Wednesday, February 3rd, 2021 at 1:56 AM, Emil Velikov emil.l.veli...@gmail.com wrote: > As summed in the commit message the burden is only applicable when all > of the following are set: > - non-linux > - force DRM_FOURCC_STANDALONE > - c99 -pedantic Oh, and FWIW, this is not a theoretica

Re: [RFC][PATCH 2/3] dma-buf: system_heap: Add pagepool support to system heap

2021-02-03 Thread Daniel Vetter
On Tue, Feb 02, 2021 at 09:56:14PM -0800, John Stultz wrote: > On Tue, Feb 2, 2021 at 6:04 AM Daniel Vetter wrote: > > > > On Fri, Jan 22, 2021 at 05:28:32PM -0800, John Stultz wrote: > > > On Mon, Dec 21, 2020 at 2:09 PM Daniel Vetter wrote: > > > > > > > > On Fri, Dec 18, 2020 at 05:16:56PM -08

Re: [amdgpu] deadlock

2021-02-03 Thread Daniel Gomez
On Wed, 3 Feb 2021 at 10:17, Daniel Vetter wrote: > > On Wed, Feb 3, 2021 at 9:51 AM Christian König > wrote: > > > > Am 03.02.21 um 09:48 schrieb Daniel Vetter: > > > On Wed, Feb 3, 2021 at 9:36 AM Christian König > > > wrote: > > >> Hi Daniel, > > >> > > >> this is not a deadlock, but rather

[PATCH] drm/virtio: fix an error code in virtio_gpu_init()

2021-02-03 Thread Dan Carpenter
If devm_request_mem_region() fails this code currently returns success but it should return -EBUSY. Fixes: 6076a9711dc5 ("drm/virtio: implement blob resources: probe for host visible region") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/virtio/virtgpu_kms.c | 1 + 1 file changed, 1 insertio

Re: [GIT PULL] ib-drm-gpio-pdx86-rtc-wdt-v5.12-1

2021-02-03 Thread Andy Shevchenko
On Tue, Jan 26, 2021 at 4:23 PM Hans de Goede wrote: > On 1/26/21 1:38 PM, Andy Shevchenko wrote: > > Hi guys, > > > > This is first part of Intel MID outdated platforms removal. It's collected > > into > > immutable branch with a given tag, please pull to yours subsystems. > > > > (All changes a

Re: [PATCH v3 1/4] dp/dp_mst: Add support for sink event notify messages

2021-02-03 Thread Hans Verkuil
Hi Sam, Are you able to work on a v4? I haven't heard from you for some time now. I would be willing to take over this series if it wasn't for the fact that I do not have any hardware to test this with. Regards, Hans On 01/02/2021 22:56, Lyude Paul wrote: > On Wed, 2020-09-23 at 12:13

Re: [GIT PULL] ib-drm-gpio-pdx86-rtc-wdt-v5.12-1

2021-02-03 Thread Andy Shevchenko
On Tue, Jan 26, 2021 at 2:41 PM Andy Shevchenko wrote: > > Hi guys, > > This is first part of Intel MID outdated platforms removal. It's collected > into > immutable branch with a given tag, please pull to yours subsystems. > > (All changes are tagged by the respective maintainers) Bart, can you

Re: linux-next: Signed-off-by missing for commit in the drm-intel-fixes tree

2021-02-03 Thread Jani Nikula
On Wed, 03 Feb 2021, Stephen Rothwell wrote: > Hi all, > > Commit > > 44c5bd08518c ("*** HAX FOR CI *** Revert "rtc: mc146818: Detect and handle > broken RTCs"") > > is missing a Signed-off-by from its author and committer. > > Reverts are commits as well. It's a hack on top of the tree to unb

Re: [PATCH] drm/fourcc: introduce DRM_FOURCC_STANDALONE guard

2021-02-03 Thread Emil Velikov
On Wed, 3 Feb 2021 at 09:27, Simon Ser wrote: > > On Wednesday, February 3rd, 2021 at 1:56 AM, Emil Velikov > emil.l.veli...@gmail.com wrote: > > > As summed in the commit message the burden is only applicable when all > > of the following are set: > > - non-linux > > - force DRM_FOURCC_STANDAL

Re: [PATCH] drm/msm/kms: Make a lock_class_key for each crtc mutex

2021-02-03 Thread Daniel Vetter
On Tue, Feb 02, 2021 at 08:51:25AM -0800, Rob Clark wrote: > On Tue, Feb 2, 2021 at 7:46 AM Daniel Vetter wrote: > > > > On Mon, Jan 25, 2021 at 03:49:01PM -0800, Stephen Boyd wrote: > > > Lockdep complains about an AA deadlock when rebooting the device. > > > > > > ===

Re: [PATCH] drm/fourcc: introduce DRM_FOURCC_STANDALONE guard

2021-02-03 Thread Simon Ser
On Wednesday, February 3rd, 2021 at 11:08 AM, Emil Velikov wrote: > On Wed, 3 Feb 2021 at 09:27, Simon Ser wrote: > > > > On Wednesday, February 3rd, 2021 at 1:56 AM, Emil Velikov > > emil.l.veli...@gmail.com wrote: > > > > > As summed in the commit message the burden is only applicable when a

Re: [PATCH v4 5/5] drm/qxl: properly free qxl releases

2021-02-03 Thread Daniel Vetter
On Tue, Jan 26, 2021 at 05:58:12PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/qxl/qxl_drv.h | 1 + > drivers/gpu/drm/qxl/qxl_kms.c | 22 -- > drivers/gpu/drm/qxl/qxl_release.c | 2 ++ > 3 files changed, 23 insertions(+), 2 dele

Re: [RFC PATCH 0/9] cgroup support for GPU devices

2021-02-03 Thread Daniel Vetter
On Mon, Feb 01, 2021 at 03:21:35PM -0800, Brian Welty wrote: > > On 1/28/2021 7:00 PM, Xingyou Chen wrote: > > On 2021/1/27 上午5:46, Brian Welty wrote: > > > >> We'd like to revisit the proposal of a GPU cgroup controller for managing > >> GPU devices but with just a basic set of controls. This s

Re: [PATCH] procfs/dmabuf: Add /proc//task//dmabuf_fds

2021-02-03 Thread Daniel Vetter
On Fri, Jan 29, 2021 at 03:22:06PM +0100, Christian König wrote: > Am 29.01.21 um 15:17 schrieb Simon Ser: > > On Friday, January 29th, 2021 at 3:13 PM, Pekka Paalanen > > wrote: > > > > > > Re-importing it adds quite a huge CPU overhead to both userspace as well > > > > as the kernel. > > > Per

Re: [Linaro-mm-sig] [PATCH v3] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2021-02-03 Thread Daniel Vetter
On Mon, Feb 01, 2021 at 01:02:30PM -0800, Hridya Valsaraju wrote: > On Mon, Feb 1, 2021 at 10:37 AM Daniel Vetter wrote: > > > > On Thu, Jan 28, 2021 at 1:03 PM Sumit Semwal > > wrote: > > > > > > On Thu, 28 Jan 2021 at 17:23, Christian König > > > wrote: > > > > > > > > Am 28.01.21 um 12:00 sc

Re: [PATCH] drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb

2021-02-03 Thread Daniel Vetter
On Wed, Jan 27, 2021 at 03:05:03PM +0100, Thomas Zimmermann wrote: > Functions in the atomic commit tail are not allowed to acquire the > dmabuf's reservation lock. So we cannot legally call the GEM object's > vmap functionality in atomic_update. > > Instead vmap the cursor BO in prepare_fb and vu

Re: [PATCH] drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb

2021-02-03 Thread Thomas Zimmermann
Hi Am 03.02.21 um 11:29 schrieb Daniel Vetter: On Wed, Jan 27, 2021 at 03:05:03PM +0100, Thomas Zimmermann wrote: Functions in the atomic commit tail are not allowed to acquire the dmabuf's reservation lock. So we cannot legally call the GEM object's vmap functionality in atomic_update. Instea

Re: [PATCH 02/13] drm: remove drm_fb_helper_modinit

2021-02-03 Thread Daniel Vetter
On Thu, Jan 28, 2021 at 07:14:10PM +0100, Christoph Hellwig wrote: > drm_fb_helper_modinit has a lot of boilerplate for what is not very > simple functionality. Just open code it in the only caller using > IS_ENABLED and IS_MODULE, and skip the find_module check as a > request_module is harmless i

Re: [GIT PULL] ib-drm-gpio-pdx86-rtc-wdt-v5.12-1

2021-02-03 Thread Hans de Goede
Hi, On 2/3/21 10:54 AM, Andy Shevchenko wrote: > On Tue, Jan 26, 2021 at 4:23 PM Hans de Goede wrote: >> On 1/26/21 1:38 PM, Andy Shevchenko wrote: >>> Hi guys, >>> >>> This is first part of Intel MID outdated platforms removal. It's collected >>> into >>> immutable branch with a given tag, plea

Re: [PATCH] drm/v3d: Fix incorrect return type to timedout_job

2021-02-03 Thread Daniel Vetter
On Fri, Jan 29, 2021 at 04:54:39PM +0100, Patrik Jakobsson wrote: > The commit a6a1f036c74e ("drm/scheduler: Job timeout handler returns > status (v3)") incorrectly uses "enum drm_task_status" for v3d and causes > a build failure. "enum drm_task_status" got changed into "enum > drm_gpu_sched_status

Re: [PATCH] drm/xlnx: fix kmemleak by sending vblank_event in atomic_disable

2021-02-03 Thread Daniel Vetter
On Tue, Feb 02, 2021 at 02:41:21PM +0800, quanyang.w...@windriver.com wrote: > From: Quanyang Wang > > When running xrandr to change resolution of DP, the kmemleak as below > can be observed: > > unreferenced object 0x00080a351000 (size 256): > comm "Xorg", pid 248, jiffies 4294899614 (age

Re: [PATCH] drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb

2021-02-03 Thread Daniel Vetter
On Wed, Feb 03, 2021 at 11:34:21AM +0100, Thomas Zimmermann wrote: > Hi > > Am 03.02.21 um 11:29 schrieb Daniel Vetter: > > On Wed, Jan 27, 2021 at 03:05:03PM +0100, Thomas Zimmermann wrote: > > > Functions in the atomic commit tail are not allowed to acquire the > > > dmabuf's reservation lock. S

Re: [PATCH] drm/fourcc: introduce DRM_FOURCC_STANDALONE guard

2021-02-03 Thread Emil Velikov
On Wed, 3 Feb 2021 at 10:15, Simon Ser wrote: > > On Wednesday, February 3rd, 2021 at 11:08 AM, Emil Velikov > wrote: > > > On Wed, 3 Feb 2021 at 09:27, Simon Ser wrote: > > > > > > On Wednesday, February 3rd, 2021 at 1:56 AM, Emil Velikov > > > emil.l.veli...@gmail.com wrote: > > > > > > > As

[PATCH][next] drm/i915/display: fix spelling mistake "Couldnt" -> "Couldn't"

2021-02-03 Thread Colin King
From: Colin Ian King There is a spelling mistake in a drm_dbg message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/i

Re: [GIT PULL] ib-drm-gpio-pdx86-rtc-wdt-v5.12-1

2021-02-03 Thread Andy Shevchenko
On Wed, Feb 03, 2021 at 11:35:59AM +0100, Hans de Goede wrote: > On 2/3/21 10:54 AM, Andy Shevchenko wrote: > > On Tue, Jan 26, 2021 at 4:23 PM Hans de Goede wrote: > >> On 1/26/21 1:38 PM, Andy Shevchenko wrote: > >>> Hi guys, > >>> > >>> This is first part of Intel MID outdated platforms removal

Re: [RFC] Add BPF_PROG_TYPE_CGROUP_IOCTL

2021-02-03 Thread Daniel Vetter
On Mon, Feb 01, 2021 at 11:51:07AM -0500, Kenny Ho wrote: > [Resent in plain text.] > > On Mon, Feb 1, 2021 at 9:49 AM Daniel Vetter wrote: > > - there's been a pile of cgroups proposal to manage gpus at the drm > > subsystem level, some by Kenny, and frankly this at least looks a bit > > lik

Re: [PATCH] drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb

2021-02-03 Thread Thomas Zimmermann
Hi Am 03.02.21 um 11:44 schrieb Daniel Vetter: On Wed, Feb 03, 2021 at 11:34:21AM +0100, Thomas Zimmermann wrote: Hi Am 03.02.21 um 11:29 schrieb Daniel Vetter: On Wed, Jan 27, 2021 at 03:05:03PM +0100, Thomas Zimmermann wrote: Functions in the atomic commit tail are not allowed to acquire t

Re: [PATCH v5 00/21] Host1x sync point UAPI should not be used for tracking DRM jobs

2021-02-03 Thread Mikko Perttunen
On 1/29/21 7:30 PM, Dmitry Osipenko wrote: 28.01.2021 19:58, Thierry Reding пишет: On Thu, Jan 28, 2021 at 01:08:54PM +0200, Mikko Perttunen wrote: On 1/27/21 11:20 PM, Dmitry Osipenko wrote: 26.01.2021 05:45, Mikko Perttunen пишет: 2. We will probably need a dedicated drm_tegra_submit_cmd fo

Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas

2021-02-03 Thread Vinod Koul
On 02-02-21, 14:55, Rob Herring wrote: > Properties in if/then schemas weren't getting checked by the meta-schemas. > Enabling meta-schema checks finds several errors. > > The use of an 'items' schema (as opposed to the list form) is wrong in > some cases as it applies to all entries. 'contains' i

Re: [PATCH 1/3] drm/ttm: rework ttm_tt page limit v3

2021-02-03 Thread Daniel Vetter
On Thu, Jan 28, 2021 at 02:16:02PM +0100, Christian König wrote: > TTM implements a rather extensive accounting of allocated memory. > > There are two reasons for this: > 1. It tries to block userspace allocating a huge number of very small >BOs without accounting for the kmalloced memory. >

Re: [PATCH 3/3] drm/ttm: drop sysfs directory

2021-02-03 Thread Daniel Vetter
On Thu, Jan 28, 2021 at 02:16:04PM +0100, Christian König wrote: > Not used any more. > > Signed-off-by: Christian König Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/ttm/ttm_module.c | 50 > drivers/gpu/drm/ttm/ttm_module.h | 2 -- > 2 files changed, 52

Re: [PATCH] backlight: pcf50633: pdata may be a null pointer, null pointer dereference cause crash

2021-02-03 Thread Daniel Thompson
On Tue, Feb 02, 2021 at 03:25:49PM -0600, FUZZ DR wrote: > Sorry about the missing description, I have a description at my local > commit. But the commit description disappeared when I used git send-email > to submit this patch. > > backlight: pcf50633: pdata may be a null pointer, null pointer de

Re: [amdgpu] deadlock

2021-02-03 Thread Daniel Gomez
On Wed, 3 Feb 2021 at 10:47, Daniel Gomez wrote: > > On Wed, 3 Feb 2021 at 10:17, Daniel Vetter wrote: > > > > On Wed, Feb 3, 2021 at 9:51 AM Christian König > > wrote: > > > > > > Am 03.02.21 um 09:48 schrieb Daniel Vetter: > > > > On Wed, Feb 3, 2021 at 9:36 AM Christian König > > > > wrote

Re: [PATCH] drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb

2021-02-03 Thread Hans de Goede
Hi, On 2/3/21 12:14 PM, Thomas Zimmermann wrote: > Hi > > Am 03.02.21 um 11:44 schrieb Daniel Vetter: >> On Wed, Feb 03, 2021 at 11:34:21AM +0100, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 03.02.21 um 11:29 schrieb Daniel Vetter: On Wed, Jan 27, 2021 at 03:05:03PM +0100, Thomas Zimmermann w

Re: [PATCH] drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb

2021-02-03 Thread Thomas Zimmermann
Hi Am 03.02.21 um 12:50 schrieb Hans de Goede: Hi, On 2/3/21 12:14 PM, Thomas Zimmermann wrote: Hi Am 03.02.21 um 11:44 schrieb Daniel Vetter: On Wed, Feb 03, 2021 at 11:34:21AM +0100, Thomas Zimmermann wrote: Hi Am 03.02.21 um 11:29 schrieb Daniel Vetter: On Wed, Jan 27, 2021 at 03:05:03

Re: [GIT PULL] ib-drm-gpio-pdx86-rtc-wdt-v5.12-1

2021-02-03 Thread Andy Shevchenko
On Tue, Jan 26, 2021 at 5:25 PM Patrik Jakobsson wrote: > On Tue, Jan 26, 2021 at 1:37 PM Andy Shevchenko > wrote: > > > > Hi guys, > > > > This is first part of Intel MID outdated platforms removal. It's collected > > into > > immutable branch with a given tag, please pull to yours subsystems.

Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe

2021-02-03 Thread Heiko Stübner
Am Mittwoch, 3. Februar 2021, 10:13:06 CET schrieb Jagan Teki: > Usual I2C configured DSI bridge drivers have drm_bridge_add > in probe and mipi_dsi_attach in bridge attach functions. > > With, this approach the drm pipeline is unable to find the > dsi bridge in stm drm drivers since the dw-mipi-d

[PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error

2021-02-03 Thread Suren Baghdasaryan
Replace BUG_ON(vma->vm_flags & VM_PFNMAP) in vm_insert_page with WARN_ON_ONCE and returning an error. This is to ensure users of the vm_insert_page that set VM_PFNMAP are notified of the wrong flag usage and get an indication of an error without panicing the kernel. This will help identifying drive

Re: [PATCH] drm/msm: remove unneeded variable: "rc"

2021-02-03 Thread Guenter Roeck
On Tue, Feb 2, 2021 at 4:32 AM Bernard Zhao wrote: > > remove unneeded variable: "rc". > > Signed-off-by: Bernard Zhao Reviewed-by: Guenter Roeck > > --- > drivers/gpu/drm/msm/dp/dp_panel.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_pa

Re: [PATCH v2 2/2] dma-buf: heaps: Map system heap pages as managed by linux vm

2021-02-03 Thread Suren Baghdasaryan
On Tue, Feb 2, 2021 at 5:39 PM Minchan Kim wrote: > > On Tue, Feb 02, 2021 at 04:31:34PM -0800, Suren Baghdasaryan wrote: > > Currently system heap maps its buffers with VM_PFNMAP flag using > > remap_pfn_range. This results in such buffers not being accounted > > for in PSS calculations because v

Re: [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error

2021-02-03 Thread Suren Baghdasaryan
On Tue, Feb 2, 2021 at 5:31 PM Minchan Kim wrote: > > On Tue, Feb 02, 2021 at 04:31:33PM -0800, Suren Baghdasaryan wrote: > > Replace BUG_ON(vma->vm_flags & VM_PFNMAP) in vm_insert_page with > > WARN_ON_ONCE and returning an error. This is to ensure users of the > > vm_insert_page that set VM_PFNM

Re: [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error

2021-02-03 Thread Suren Baghdasaryan
On Tue, Feb 2, 2021 at 5:55 PM Matthew Wilcox wrote: > > On Tue, Feb 02, 2021 at 04:31:33PM -0800, Suren Baghdasaryan wrote: > > Replace BUG_ON(vma->vm_flags & VM_PFNMAP) in vm_insert_page with > > WARN_ON_ONCE and returning an error. This is to ensure users of the > > vm_insert_page that set VM_P

Re: [PATCH 1/3] drm/ttm: rework ttm_tt page limit v3

2021-02-03 Thread Christian König
Am 03.02.21 um 12:26 schrieb Daniel Vetter: On Thu, Jan 28, 2021 at 02:16:02PM +0100, Christian König wrote: TTM implements a rather extensive accounting of allocated memory. There are two reasons for this: 1. It tries to block userspace allocating a huge number of very small BOs without ac

Re: [amdgpu] deadlock

2021-02-03 Thread Christian König
Am 03.02.21 um 12:45 schrieb Daniel Gomez: On Wed, 3 Feb 2021 at 10:47, Daniel Gomez wrote: On Wed, 3 Feb 2021 at 10:17, Daniel Vetter wrote: On Wed, Feb 3, 2021 at 9:51 AM Christian König wrote: Am 03.02.21 um 09:48 schrieb Daniel Vetter: On Wed, Feb 3, 2021 at 9:36 AM Christian König wr

  1   2   >