Re: [PATCH v4 04/13] drm/shmem-helper: Provide a vmap function for short-term mappings

2021-01-11 Thread Daniel Vetter
On Fri, Jan 08, 2021 at 10:43:31AM +0100, Thomas Zimmermann wrote: > Implementations of the vmap/vunmap GEM callbacks may perform pinning > of the BO and may acquire the associated reservation object's lock. > Callers that only require a mapping of the contained memory can thus > interfere with oth

[Bug 211033] [bisected][regression] amdgpu: *ERROR* Restoring old state failed with -12

2021-01-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211033 Andreas (icedragon...@web.de) changed: What|Removed |Added CC||icedragon...@web.de --- C

Re: [PATCH v4 13/13] drm/vram-helper: Remove unused drm_gem_vram_{vmap,vunmap}()

2021-01-11 Thread Daniel Vetter
On Fri, Jan 08, 2021 at 10:43:40AM +0100, Thomas Zimmermann wrote: > VRAM-helper BO's cannot be exported, so calls for vmap and vunmap > can only come from the BO's drivers or a kernel client. These are > supposed use vmap_local functionality. ^to > > The vmap and vunmap operations in

Re: [PATCH v4 05/13] drm/mgag200: Use drm_gem_shmem_vmap_local() in damage handling

2021-01-11 Thread Daniel Vetter
On Fri, Jan 08, 2021 at 10:43:32AM +0100, Thomas Zimmermann wrote: > Damage handling in mgag200 requires a short-term mapping of the source > BO. Use drm_gem_shmem_vmap_local(). > > Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/mgag200/mgag200_mode.c | 16

[Bug 211033] [bisected][regression] amdgpu: *ERROR* Restoring old state failed with -12

2021-01-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211033 --- Comment #12 from Andreas (icedragon...@web.de) --- Sorry wrong BUG channel. How can I remove my last comment above? -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the b

Re: [PATCH v4 05/13] drm/mgag200: Use drm_gem_shmem_vmap_local() in damage handling

2021-01-11 Thread Daniel Vetter
On Mon, Jan 11, 2021 at 05:53:41PM +0100, Daniel Vetter wrote: > On Fri, Jan 08, 2021 at 10:43:32AM +0100, Thomas Zimmermann wrote: > > Damage handling in mgag200 requires a short-term mapping of the source > > BO. Use drm_gem_shmem_vmap_local(). > > > > Signed-off-by: Thomas Zimmermann > > Revi

[Bug 211033] [bisected][regression] amdgpu: *ERROR* Restoring old state failed with -12

2021-01-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211033 --- Comment #13 from Andreas (icedragon...@web.de) --- Wrong channel above, but the trigger was the same - simply 1) switch monitor off, 2) wakeup the system from standby/suspend and then 3) switch the monitor on -> (blank screen - no signal). --

Re: [PATCH v4 07/13] drm/gm12u320: Use drm_gem_shmem_vmap_local() in damage handling

2021-01-11 Thread Daniel Vetter
On Fri, Jan 08, 2021 at 10:43:34AM +0100, Thomas Zimmermann wrote: > Damage handling in gm12u320 requires a short-term mapping of the source > BO. Use drm_gem_shmem_vmap_local(). > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/tiny/gm12u320.c | 14 +++--- > 1 file changed, 1

Re: [PATCH v4 06/13] drm/cirrus: Use drm_gem_shmem_vmap_local() in damage handling

2021-01-11 Thread Daniel Vetter
On Fri, Jan 08, 2021 at 10:43:33AM +0100, Thomas Zimmermann wrote: > Damage handling in cirrus requires a short-term mapping of the source > BO. Use drm_gem_shmem_vmap_local(). > > Signed-off-by: Thomas Zimmermann Hm more possible errors that we don't report to userspace ... Why don't we vmap/vu

Re: [PATCH v4 06/13] drm/cirrus: Use drm_gem_shmem_vmap_local() in damage handling

2021-01-11 Thread Daniel Vetter
On Mon, Jan 11, 2021 at 06:00:42PM +0100, Daniel Vetter wrote: > On Fri, Jan 08, 2021 at 10:43:33AM +0100, Thomas Zimmermann wrote: > > Damage handling in cirrus requires a short-term mapping of the source > > BO. Use drm_gem_shmem_vmap_local(). > > > > Signed-off-by: Thomas Zimmermann > > Hm mo

Re: [PATCH v4 11/13] drm/vboxvideo: Use drm_gem_vram_vmap_local() in cursor update

2021-01-11 Thread Daniel Vetter
On Fri, Jan 08, 2021 at 10:43:38AM +0100, Thomas Zimmermann wrote: > Cursor updates in vboxvideo require a short-term mapping of the > source BO. Use drm_gem_vram_vmap_local() and avoid the pinning > operations. > > Signed-off-by: Thomas Zimmermann All these drivers patches break the dma_resv_lo

Re: [PATCH v5 19/21] drm/tegra: Implement new UAPI

2021-01-11 Thread kernel test robot
Hi Mikko, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20210111] [cannot apply to tegra-drm/drm/tegra/for-next tegra/for-next linus/master v5.11-rc3 v5.11-rc2 v5.11-rc1 v5.11-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: [PATCH v3 01/12] drm: Add dummy page per device or GEM object

2021-01-11 Thread Andrey Grodzovsky
On 1/11/21 11:15 AM, Daniel Vetter wrote: On Mon, Jan 11, 2021 at 05:13:56PM +0100, Daniel Vetter wrote: On Fri, Jan 08, 2021 at 04:49:55PM +, Grodzovsky, Andrey wrote: Ok then, I guess I will proceed with the dummy pages list implementation then. Andrey

RE: [PATCH v16 0/4] RDMA: Add dma-buf support

2021-01-11 Thread Xiong, Jianxin
> -Original Message- > From: Jason Gunthorpe > Sent: Monday, January 11, 2021 7:43 AM > To: Xiong, Jianxin > Cc: linux-r...@vger.kernel.org; dri-devel@lists.freedesktop.org; Doug Ledford > ; Leon Romanovsky > ; Sumit Semwal ; Christian Koenig > ; Vetter, Daniel > > Subject: Re: [PATCH

Re: [PATCH v16 0/4] RDMA: Add dma-buf support

2021-01-11 Thread Alex Deucher
On Mon, Jan 11, 2021 at 12:44 PM Xiong, Jianxin wrote: > > > -Original Message- > > From: Jason Gunthorpe > > Sent: Monday, January 11, 2021 7:43 AM > > To: Xiong, Jianxin > > Cc: linux-r...@vger.kernel.org; dri-devel@lists.freedesktop.org; Doug > > Ledford ; Leon Romanovsky > > ; Sumit

RE: [PATCH rdma-core v4 0/6] Add user space dma-buf support

2021-01-11 Thread Xiong, Jianxin
Does this series look fine now? I would like to try resolving any remaining issues so we Can catch the window for kernel 5.12. Edward, do you have more opinions on the pyverbs related changes? Thanks, Jianxin > -Original Message- > From: Xiong, Jianxin > Sent: Wednesday, December 02, 2

RE: [PATCH v16 0/4] RDMA: Add dma-buf support

2021-01-11 Thread Xiong, Jianxin
> -Original Message- > From: Alex Deucher > Sent: Monday, January 11, 2021 9:47 AM > To: Xiong, Jianxin > Cc: Jason Gunthorpe ; Leon Romanovsky ; > linux-r...@vger.kernel.org; dri-devel@lists.freedesktop.org; > Doug Ledford ; Vetter, Daniel ; > Christian Koenig > Subject: Re: [PATCH v1

Re: [PATCH] drm/bridge: nwl-dsi: Avoid potential multiplication overflow on 32-bit

2021-01-11 Thread Fabio Estevam
Hi Geert, On Mon, Jan 11, 2021 at 10:02 AM Geert Uytterhoeven wrote: > > As nwl_dsi.lanes is u32, and NSEC_PER_SEC is 10L, the second > multiplication in > > dsi->lanes * 8 * NSEC_PER_SEC > > will overflow on a 32-bit platform. Fix this by making the constant > unsigned long long, fo

[ANNOUNCE] libdrm 2.4.104

2021-01-11 Thread Simon Ser
This release brings updated kernel headers and converts man pages to reStructuredText. Antonin Décimo (1): headers: drm: Sync with drm-next Emmanuel Vadot (1): tests/amdgpu: Fix on FreeBSD Luben Tuikov (1): tests/amdgpu: Fix a typo Lubomir Rintel (3): tests/etnaviv_2d_te

Re: [PATCH v3 01/12] drm: Add dummy page per device or GEM object

2021-01-11 Thread Andrey Grodzovsky
On 1/11/21 12:41 PM, Andrey Grodzovsky wrote: On 1/11/21 11:15 AM, Daniel Vetter wrote: On Mon, Jan 11, 2021 at 05:13:56PM +0100, Daniel Vetter wrote: On Fri, Jan 08, 2021 at 04:49:55PM +, Grodzovsky, Andrey wrote: Ok then, I guess I will proceed with the dummy pages list implementation

Re: [PATCH v5 1/4] drm/i915: Keep track of pwm-related backlight hooks separately

2021-01-11 Thread Jani Nikula
On Thu, 07 Jan 2021, Lyude Paul wrote: > Currently, every different type of backlight hook that i915 supports is > pretty straight forward - you have a backlight, probably through PWM > (but maybe DPCD), with a single set of platform-specific hooks that are > used for controlling it. > > HDR backl

[PATCH V5 0/3] Decouple config data for configfs

2021-01-11 Thread Sumera Priyadarsini
This patchset aims to lay down some prep work before configfs can be implemented for the vkms driver. The first patch in the series adds a new type vkms_config to track device configuration. The second and third patch add module testing support for writeback operations. The first patch is develope

Re: [PATCH v5 2/4] drm/i915/dp: Enable Intel's HDR backlight interface (only SDR for now)

2021-01-11 Thread Jani Nikula
On Thu, 07 Jan 2021, Lyude Paul wrote: > So-recently a bunch of laptops on the market have started using DPCD > backlight controls instead of the traditional DDI backlight controls. > Originally we thought we had this handled by adding VESA backlight > control support to i915, but the story ended

[PATCH V5 1/3] drm/vkms: Add vkms_config type

2021-01-11 Thread Sumera Priyadarsini
Currently, data for the device instance is held by vkms_device. Add a separate type, vkms_config to contain configuration details for the device and various modes to be later used by configfs. This config data stays constant once the device is created. Accordingly, add vkms_create and vkms_destroy

[PATCH V5 2/3] drm/vkms: Add support for writeback module

2021-01-11 Thread Sumera Priyadarsini
Add enable_writeback feature to vkms_config as a module. Signed-off-by: Sumera Priyadarsini --- drivers/gpu/drm/vkms/vkms_drv.c| 5 + drivers/gpu/drm/vkms/vkms_drv.h| 1 + drivers/gpu/drm/vkms/vkms_output.c | 9 ++--- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v5 3/4] drm/i915/dp: Allow forcing specific interfaces through enable_dpcd_backlight

2021-01-11 Thread Jani Nikula
On Thu, 07 Jan 2021, Lyude Paul wrote: > Since we now support controlling panel backlights through DPCD using > both the standard VESA interface, and Intel's proprietary HDR backlight > interface, we should allow the user to be able to explicitly choose > between one or the other in the event that

Re: [PATCH v5 4/4] drm/dp: Revert "drm/dp: Introduce EDID-based quirks"

2021-01-11 Thread Jani Nikula
On Thu, 07 Jan 2021, Lyude Paul wrote: > This reverts commit 0883ce8146ed6074c76399f4e70dbed788582e12. Originally > these quirks were added because of the issues with using the eDP > backlight interfaces on certain laptop panels, which made it impossible > to properly probe for DPCD backlight supp

[PATCH V5 3/3] drm/vkms: Add information about module options

2021-01-11 Thread Sumera Priyadarsini
Update vkms documentation to contain usage of `modinfo` command and steps to load vkms with module options enabled. Signed-off-by: Sumera Priyadarsini --- Documentation/gpu/vkms.rst | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/v

Re: [PATCH v5 4/4] drm/dp: Revert "drm/dp: Introduce EDID-based quirks"

2021-01-11 Thread Jani Nikula
On Mon, 11 Jan 2021, Jani Nikula wrote: > On Thu, 07 Jan 2021, Lyude Paul wrote: >> This reverts commit 0883ce8146ed6074c76399f4e70dbed788582e12. Originally >> these quirks were added because of the issues with using the eDP >> backlight interfaces on certain laptop panels, which made it impossib

[PATCH 00/40] [Set 12] Rid W=1 warnings from GPU

2021-01-11 Thread Lee Jones
MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (40): drm/amd/display/dc/dce/dce_aux: Mark 'd

[PATCH 01/40] drm/amd/display/dc/dce/dce_aux: Mark 'dce_aux_transfer_raw' as __maybe_unused

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.c: In function ‘dce_aux_transfer_raw’: drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.c:579:7: warning: variable ‘bytes_replied’ set but not used [-Wunused-but-set-variable] Cc: Harry W

[PATCH 02/40] drm/amd/display/dc/dce/dce_link_encoder: Remove unused variable 'value0'

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_link_encoder.c: In function ‘dce110_link_encoder_update_mst_stream_allocation_table’: drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_link_encoder.c:1506:11: warning: variable ‘value0’ set but no

[PATCH 05/40] drm/amd/display/dc/dce/dce_transform: Demote kernel-doc abuse

2021-01-11 Thread Lee Jones
The header doesn't provide any additional parameter descriptions. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.c:1104: warning: Cannot understand * Cc: H

[PATCH 04/40] drm/amd/display/dc/dce/dce_opp: Demote non-compliant kernel-doc headers

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:109: warning: Function parameter or member 'opp110' not described in 'set_truncation' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:109: warning: Function parameter or member 'param

[PATCH 06/40] drm/amd/display/dc/gpio/diagnostics/hw_translate_diag: Include our own header containing prototypes

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_translate_diag.c:37:6: warning: no previous prototype for ‘dal_hw_translate_diag_fpga_init’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian Kön

[PATCH 07/40] drm/amd/display/dc/irq/irq_service: Make local function static

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/irq/irq_service.c:82:31: warning: no previous prototype for ‘find_irq_source_info’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Dani

[PATCH 03/40] drm/amd/display/dc/gpio/hw_ddc: Remove unused variable 'reg2'

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/hw_ddc.c: In function ‘set_config’: drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/hw_ddc.c:110:13: warning: variable ‘reg2’ set but not used [-Wunused-but-set-variable] Cc: Harry Wentland Cc: Leo L

[PATCH 09/40] drm/amd/display/dc/gpio/diagnostics/hw_factory_diag: Include our own header containing prototypes

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_diag.c:50:6: warning: no previous prototype for ‘dal_hw_factory_diag_fpga_init’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König"

[PATCH 10/40] drm/amd/display/dc/dce120/dce120_hw_sequencer: Encompass defines in same clause as their use

2021-01-11 Thread Lee Jones
Ideally someone should strip-out all these garbage 'if 0's. Tempted to carry out the work myself on principle! Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_hw_sequencer.c:53:47: warning: ‘reg_offsets’ defined but not used [-Wunused-con

[PATCH 11/40] drm/amd/display/dc/dce120/dce120_timing_generator:

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_timing_generator.c:101:6: warning: no previous prototype for ‘dce120_timing_generator_validate_timing’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_timing_

[PATCH 12/40] drm/amd/display/dc/dce120/Makefile: Ignore -Woverride-init warning

2021-01-11 Thread Lee Jones
This file uses a complex abstracted set of hierarchical macros to setup its applicable register lists within constant structures. However in the case of TMDS_CNTL we wish to mark it as not applicable for this use-case. One method would be to de-const all of the definitions and users, then manually

[PATCH 13/40] drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the stack to the heap

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function ‘calculate_bandwidth’: drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2016:1: warning: the frame size of 1216 bytes is larger than 1024 bytes [-Wframe-larger-tha

[PATCH 08/40] drm/amd/display/dc/gpio/diagnostics/hw_factory_diag: Fix struct declared inside parameter list error

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_diag.h:30:43: warning: ‘struct hw_factory’ declared inside parameter list will not be visible outside of this definition or declaration drivers/gpu/drm/amd/amdgpu/../display/

[PATCH 14/40] drm/amd/display/dc/calcs/dce_calcs: Remove some large variables from the stack

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function ‘bw_calcs_init’: drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2726:1: warning: the frame size of 1336 bytes is larger than 1024 bytes [-Wframe-larger-than=] C

[PATCH 16/40] drm/amd/display/dc/dce120/dce120_timing_generator: Demote non-kerneldoc headers

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_timing_generator.c:602:13: warning: ‘dce120_timing_generator_get_position’ defined but not used [-Wunused-function] drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_timing_generator.c

[PATCH 17/40] drm/amd/display/dc/dce/dce_aux: Remove duplicate line causing 'field overwritten' issue

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:59: drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_11_2_sh_mask.h:10014:58: warning: initialized field overwritten [-Woverride-init] drivers/gpu/dr

[PATCH 15/40] drm/amd/display/dc/dce120/dce120_resource: Staticify local functions

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_resource.c:426:32: warning: no previous prototype for ‘dce120_opp_create’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_resource.c:440:17: warning: no previou

[PATCH 18/40] drm/amd/display/dc/dce112/Makefile: Ignore -Woverride-init warning

2021-01-11 Thread Lee Jones
This file uses a complex abstracted set of hierarchical macros to setup its applicable register lists within constant structures. However in the case of TMDS_CNTL we wish to mark it as not applicable for this use-case. One method would be to de-const all of the definitions and users, then manually

[PATCH 20/40] drm/amd/display/dc/dce110/dce110_timing_generator: Remove unused variable 'value_crtc_vtotal'

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c: In function ‘dce110_timing_generator_tear_down_global_swap_lock’: drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1354:12: warning: variable ‘v

[PATCH 22/40] drm/amd/display/dc/dce110/dce110_hw_sequencer: Demote non-conformant kernel-doc header

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:1639: warning: Function parameter or member 'dc' not described in 'dce110_enable_accelerated_mode' drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:1639:

[PATCH 19/40] drm/amd/display/dc/dce/dce_opp: Remove duplicate entries causing 'field overwritten' issues

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:59: drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_11_2_sh_mask.h:10480:62: warning: initialized field overwritten [-Woverride-init] drivers/gpu/dr

[PATCH 21/40] drm/amd/display/dc/dce110/dce110_compressor: Remove unused function 'dce110_get_required_compressed_surfacesize

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_compressor.c:415:6: warning: no previous prototype for ‘dce110_get_required_compressed_surfacesize’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian Kö

[PATCH 24/40] drm/amd/pm/swsmu/smu11/vangogh_ppt: Make local function 'vangogh_clk_dpm_is_enabled' static

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:613:6: warning: no previous prototype for ‘vangogh_clk_dpm_is_enabled’ [-Wmissing-prototypes] Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Xiaojian Du

[PATCH 23/40] drm/amd/display/dc/dce110/dce110_mem_input_v: Make local functions static

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:471:6: warning: no previous prototype for ‘dce_mem_input_v_is_surface_pending’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:486:6

[PATCH 25/40] drm/amd/display/dc/dce120/dce120_timing_generator: Remove unused function 'dce120_timing_generator_get_position'

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_timing_generator.c:602:13: warning: ‘dce120_timing_generator_get_position’ defined but not used [-Wunused-function] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König"

[PATCH 28/40] drm/amd/display/dc/calcs/dce_calcs: Demote non-conformant kernel-doc function headers

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2753: warning: Function parameter or member 'vbios' not described in 'is_display_configuration_supported' drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2753: warning: Funct

[PATCH 30/40] drm/amd/display/dc/dce110/dce110_timing_generator_v: Demote kernel-doc abuse and line up comments

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator_v.c:54: warning: Function parameter or member 'tg' not described in 'dce110_timing_generator_v_enable_crtc' drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_g

[PATCH 27/40] drm/amd/display/dc/dce110/dce110_compressor: Strip out unused function 'controller_id_to_index'

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_compressor.c:429:14: warning: no previous prototype for ‘controller_id_to_index’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Air

[PATCH 29/40] drm/amd/display/dc/dce112/dce112_resource: Make local functions and ones called by reference static

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:620:22: warning: no previous prototype for ‘dce112_link_encoder_create’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:674:32: warning:

[PATCH 31/40] drm/amd/display/dc/dce110/dce110_mem_input_v: Include our own header, containing prototypes

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:1034:6: warning: no previous prototype for ‘dce110_mem_input_v_construct’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: Da

[PATCH 26/40] drm/amd/display/dc/dce110/dce110_timing_generator: Demote kernel-doc abuses to standard function headers

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:79: warning: Cannot understand * drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing

[PATCH 37/40] drm/amd/display/dc/dce60/dce60_resource: Make local functions static

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:522:17: warning: no previous prototype for ‘dce60_aux_engine_create’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:560:20: warning: no prev

[PATCH 35/40] drm/amd/display/dc/dce60/dce60_timing_generator: Make 'dce60_configure_crc' invoked by reference static

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_timing_generator.c:192:6: warning: no previous prototype for ‘dce60_configure_crc’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airl

[PATCH 33/40] drm/amd/display/dc/dce110/dce110_resource: Make local functions invoked by reference static

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_resource.c:262:15: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_resource.c:266:2: note: in expansion of macro ‘stream_enc_r

[PATCH 38/40] drm/amd/display/dc/dce80/dce80_resource: Make local functions static

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:527:17: warning: no previous prototype for ‘dce80_aux_engine_create’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:565:20: warning: no prev

[PATCH 32/40] drm/amd/display/dc/dce110/Makefile: Ignore -Woverride-init warning

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_resource.c:66: drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_11_0_sh_mask.h:5936:51: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/

[PATCH 36/40] drm/amd/display/dc/dce100/dce100_resource: Make local functions and ones called by reference static

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:54: drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:614:22: warning: no previous prototype for ‘dce100_link_encoder_create’ [-Wmissing-pro

[PATCH 34/40] drm/amd/display/dc/dce110/dce110_transform_v: Demote kernel-doc abuse

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_transform_v.c:228: warning: bad line:void drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_transform_v.c:233: warning: Function parameter or member 'xfm_dce' not described in 'pro

[PATCH 39/40] drm/amd/display/dc/core/dc_surface: Demote kernel-doc abuse

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_surface.c:119: warning: Cannot understand * Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc

[PATCH 40/40] drm/amd/display/dc/core/dc_stream: Demote non-conformant kernel-doc headers

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stream.c:253: warning: Function parameter or member 'pStream' not described in 'dc_optimize_timing_for_fsft' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stream.c:253: warning: Function param

Re: [drm:dm_plane_helper_prepare_fb [amdgpu]] *ERROR* Failed to pin framebuffer with error -12

2021-01-11 Thread Mikhail Gavrilov
On Mon, 11 Jan 2021 at 19:01, Christian König wrote: > Changing the page table attributes while releasing memory might sleep. > So we can't use a spinlock here. > > Thanks for the report, a patch to fix this is on the mailing list now. Can you look also the first trace? Here a same error message

Re: [PATCH] drm/ttm: Fix address passed to dma_mapping_error() in ttm_pool_map()

2021-01-11 Thread Christian König
Am 11.01.21 um 17:40 schrieb Jeremy Cline: check_unmap() is producing a warning about a missing map error check. The return value from dma_map_page() should be checked for an error, not the caller-provided dma_addr. Fixes: d099fc8f540a ("drm/ttm: new TT backend allocation pool v3") Signed-off-by

Re: [PATCH] drm/ttm: Fix address passed to dma_mapping_error() in ttm_pool_map()

2021-01-11 Thread Jeremy Cline
On Mon, Jan 11, 2021 at 09:21:48PM +0100, Christian König wrote: > Am 11.01.21 um 17:40 schrieb Jeremy Cline: > > check_unmap() is producing a warning about a missing map error check. > > The return value from dma_map_page() should be checked for an error, not > > the caller-provided dma_addr. > >

Re: [PATCH v3 01/12] drm: Add dummy page per device or GEM object

2021-01-11 Thread Andrey Grodzovsky
On 1/11/21 11:15 AM, Daniel Vetter wrote: On Mon, Jan 11, 2021 at 05:13:56PM +0100, Daniel Vetter wrote: On Fri, Jan 08, 2021 at 04:49:55PM +, Grodzovsky, Andrey wrote: Ok then, I guess I will proceed with the dummy pages list implementation then. Andrey

Re: [drm:dm_plane_helper_prepare_fb [amdgpu]] *ERROR* Failed to pin framebuffer with error -12

2021-01-11 Thread Christian König
Hi Mike, Am 11.01.21 um 20:23 schrieb Mikhail Gavrilov: On Mon, 11 Jan 2021 at 19:01, Christian König wrote: Changing the page table attributes while releasing memory might sleep. So we can't use a spinlock here. Thanks for the report, a patch to fix this is on the mailing list now. Can you

[PATCH v2] drm/amdkfd: Fix out-of-bounds read in kdf_create_vcrat_image_cpu()

2021-01-11 Thread Jeremy Cline
KASAN reported a slab-out-of-bounds read of size 1 in kdf_create_vcrat_image_cpu(). This occurs when, for example, when on an x86_64 with a single NUMA node because kfd_fill_iolink_info_for_cpu() is a no-op, but afterwards the sub_type_hdr->length, which is out-of-bounds, is read and multiplied by

[Bug 209713] amdgpu drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_link_encoder.c:483 dcn10_get_dig_frontend+0x9e/0xc0 [amdgpu] when resuming from S3 state

2021-01-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209713 --- Comment #5 from Klaus Mueller (kmuel...@justmail.de) --- Seems to be fixed for me since the last firmware update for the Picasso driver: - xf86-video-amdgpu-19.1.0-lp152.67.5.x86_64 - kernel-firmware-20201218-lp152.36.1.noarch -- You may rep

Re: [PATCH v2] drm: Check actual format for legacy pageflip.

2021-01-11 Thread Alex Deucher
On Mon, Jan 11, 2021 at 11:39 AM Bas Nieuwenhuizen wrote: > > On Mon, Jan 11, 2021 at 4:02 PM Alex Deucher wrote: > > > > On Sat, Jan 9, 2021 at 9:11 PM Bas Nieuwenhuizen > > wrote: > > > > > > With modifiers one can actually have different format_info structs > > > for the same format, which no

Re: [PATCH v8] backlight: lms283gf05: Convert to GPIO descriptors

2021-01-11 Thread Linus Walleij
On Mon, Jan 11, 2021 at 5:19 PM Lee Jones wrote: > > ChangeLog v7->v8: > > - Rebase onto v5.11-rc1 > > - I wonder why this never seems to get merged...? > > Because you need SPI & PXA Acks and a merge plan. Ah you're right I completely missed that the include is down in include/spi/... Mark, ca

Re: [PATCH 1/2] dt-bindings: panel-simple: add samsung,s6e3fa2 panel

2021-01-11 Thread Rob Herring
On Wed, 30 Dec 2020 17:17:10 +0200, Iskren Chernev wrote: > Add samsung,s6e3fa2 in the allowed simple-panel compat strings. > > Signed-off-by: Iskren Chernev > --- > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herrin

Re: [PATCH v2] drm/amdkfd: Fix out-of-bounds read in kdf_create_vcrat_image_cpu()

2021-01-11 Thread Felix Kuehling
Am 2021-01-11 um 4:05 p.m. schrieb Jeremy Cline: > KASAN reported a slab-out-of-bounds read of size 1 in > kdf_create_vcrat_image_cpu(). > > This occurs when, for example, when on an x86_64 with a single NUMA node > because kfd_fill_iolink_info_for_cpu() is a no-op, but afterwards the > sub_type_hd

Re: [drm:dm_plane_helper_prepare_fb [amdgpu]] *ERROR* Failed to pin framebuffer with error -12

2021-01-11 Thread Mikhail Gavrilov
Hi Christian, On Tue, 12 Jan 2021 at 01:45, Christian König wrote: > > Hi Mike, > > Unfortunately not, that's DC stuff. Easiest is to assign this as a bug > tracker to our DC team. Ok > At least some progress. Any objections that I add your e-mail address as > tested-by tag? Yes, feel free add m

Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting

2021-01-11 Thread Rob Herring
On Thu, Dec 31, 2020 at 10:21:12AM +0800, Xin Ji wrote: > Add DPI flag for distinguish MIPI input signal type, DSI or DPI. Add > swing setting for adjusting DP tx PHY swing > > Signed-off-by: Xin Ji > --- > .../bindings/display/bridge/analogix,anx7625.yaml | 25 > -- > 1 fi

Re: [PATCH] drm/bridge: ti-sn65dsi86: rename GPIO register bits

2021-01-11 Thread Doug Anderson
Hi, On Thu, Dec 10, 2020 at 12:19 AM Shawn Guo wrote: > > From: Shawn Guo > > It renames GPIO register bits to drop 'SN_' prefix, so that they are > consistent to other definitions - prefixing register name with 'SN_' but > not for bit fields. > > Signed-off-by: Shawn Guo > --- > drivers/gpu/d

Re: [PATCH] dt-bindings: display: Augment s6e63m0 bindings

2021-01-11 Thread Rob Herring
On Fri, 01 Jan 2021 12:45:22 +0100, Linus Walleij wrote: > This fixes the following problems with the s6e63m0 display > bindings: > > - When used on the DSI bus, the panel is listed directly as > a subnode on the DSI host so the "port" node is not > compulsory. Remove "port" from required prop

Re: [PATCH] drm/bridge: ti-sn65dsi86: rename GPIO register bits

2021-01-11 Thread Doug Anderson
Hi, On Mon, Jan 11, 2021 at 2:16 PM Doug Anderson wrote: > > Hi, > > On Thu, Dec 10, 2020 at 12:19 AM Shawn Guo wrote: > > > > From: Shawn Guo > > > > It renames GPIO register bits to drop 'SN_' prefix, so that they are > > consistent to other definitions - prefixing register name with 'SN_' bu

Re: [PATCH v3 1/6] dt-bindings: display: bridge: Add YAML schema for Synopsys DW-HDMI

2021-01-11 Thread Rob Herring
On Tue, Jan 05, 2021 at 08:08:13AM +0200, Laurent Pinchart wrote: > Add a .yaml schema containing the common properties for the Synopsys > DesignWare HDMI TX controller. This isn't a full device tree binding > specification, but is meant to be referenced by platform-specific > bindings for the IP c

Re: [PATCH v3 2/6] dt-bindings: display: bridge: renesas,dw-hdmi: Convert binding to YAML

2021-01-11 Thread Rob Herring
On Tue, Jan 05, 2021 at 08:08:14AM +0200, Laurent Pinchart wrote: > Convert the Renesas R-Car DWC HDMI TX text binding to YAML. > > Signed-off-by: Laurent Pinchart > --- > Changes since v2: > > - Update MAINTAINERS > > Changes since v1: > > - Drop the part numbers in comments, only keep the So

Re: [PATCH v8] backlight: lms283gf05: Convert to GPIO descriptors

2021-01-11 Thread Mark Brown
On Mon, Jan 11, 2021 at 10:40:46PM +0100, Linus Walleij wrote: > Mark, can I have your ACK for deleting > include/linux/spi/lms283gf05.h > As part of this patch sets? Acked-by: Mark Brown signature.asc Description: PGP signature ___ dri-devel mailing

Re: [PATCH v3 3/6] dt-bindings: display: imx: hdmi: Convert binding to YAML

2021-01-11 Thread Rob Herring
On Tue, Jan 05, 2021 at 08:08:15AM +0200, Laurent Pinchart wrote: > Convert the i.MX6 HDMI TX text binding to YAML. > > Signed-off-by: Laurent Pinchart > --- > Changes since v1: > > - Only specify maxItems for clocks > - Drop reg and interrupts as they're checked in the base schema > - Rebase on

Re: [PATCH v3 4/6] dt-bindings: display: rockchip: dw-hdmi: Convert binding to YAML

2021-01-11 Thread Rob Herring
On Wed, Jan 06, 2021 at 05:17:55PM +0200, Laurent Pinchart wrote: > Hi Rob, > > Given that the maintainers property is mandatory in the schema, what's > the procedure when no maintainer steps up for a converter YAML binding ? Delete it if no one cares... Typically we just put a subsystem or plat

Re: [PATCH v3 4/6] dt-bindings: display: rockchip: dw-hdmi: Convert binding to YAML

2021-01-11 Thread Laurent Pinchart
Hi Rob, On Mon, Jan 11, 2021 at 05:01:36PM -0600, Rob Herring wrote: > On Wed, Jan 06, 2021 at 05:17:55PM +0200, Laurent Pinchart wrote: > > Hi Rob, > > > > Given that the maintainers property is mandatory in the schema, what's > > the procedure when no maintainer steps up for a converter YAML bi

Re: [PATCH v3 4/6] dt-bindings: display: rockchip: dw-hdmi: Convert binding to YAML

2021-01-11 Thread Rob Herring
On Tue, Jan 05, 2021 at 08:08:16AM +0200, Laurent Pinchart wrote: > Convert the Rockchip HDMI TX text binding to YAML. > > Signed-off-by: Laurent Pinchart > --- > Changes since v2: > > - Use Mark's @gmail.com e-mail address as the @rock-chips.com address > bounces > > Changes since v1: > > -

Re: [PATCH v3, 01/15] dt-bindings: mediatek: add description for postmask

2021-01-11 Thread Chun-Kuang Hu
Yongqiang Niu 於 2021年1月11日 週一 下午3:44寫道: > > add description for postmask > postmask is used control round corner for display frame After changing to 'used to control', Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > --- > Documentation/devicetree/bindings/display/mediatek/media

Re: [PATCH v3, 02/15] dt-bindings: mediatek: add description for mt8192 display

2021-01-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:48寫道: > > add description for mt8192 display Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Yongqiang Niu >

Re: [PATCH v3, 03/15] arm64: dts: mt8192: add display node

2021-01-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:48寫道: > > add display node > > Signed-off-by: Yongqiang Niu > --- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 134 > +++ > 1 file changed, 134 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi

Re: [PATCH v3, 04/15] drm/mediatek: add component OVL_2L2

2021-01-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:44寫道: > > This patch add component OVL_2L2 Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dr

Re: [PATCH v3, 05/15] drm/mediatek: add component POSTMASK

2021-01-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:44寫道: > > This patch add component POSTMASK, This patch has conflicts with the series "Decouple Mediatek DRM sub driver" [1] which has been applied to mediatek-drm-next, so please rebase this patch onto mediatek-drm-next. [1] https://patchwork.ke

Re: [PATCH v3, 06/15] drm/mediatek: add component RDMA4

2021-01-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:44寫道: > > This patch add component RDMA4 Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_

Re: [PATCH v3, 07/15] drm/mediatek: enable OVL_LAYER_SMI_ID_EN for multi-layer usecase

2021-01-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:44寫道: > > enable OVL_LAYER_SMI_ID_EN for multi-layer usecase Could you describe more information? Without this patch, what would happen? > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 12 > 1 fil

<    1   2   3   >