Re: [patch V3 13/37] mips/mm/highmem: Switch to generic kmap atomic

2021-01-11 Thread Paul Cercueil
Hi Thomas, Le sam. 9 janv. 2021 à 1:33, Thomas Bogendoerfer a écrit : On Sat, Jan 09, 2021 at 12:58:05AM +0100, Thomas Bogendoerfer wrote: On Fri, Jan 08, 2021 at 08:20:43PM +, Paul Cercueil wrote: > Hi Thomas, > > 5.11 does not boot anymore on Ingenic SoCs, I bisected it to this com

[PATCH v3, 00/15] drm/mediatek: add support for mediatek SOC MT8192

2021-01-11 Thread Yongqiang Niu
This series are based on 5.11-rc1 and SoC MT8183, and provide 15 patch to support mediatek SOC MT8192 Changes since v2: - fix review comment in v2 - add pm runtime for gamma and color - move ddp path select patch to mmsys series - remove some useless patch Yongqiang Niu (15): dt-bindings: medi

[PATCH v3, 15/15] drm/mediatek: add support for mediatek SOC MT8192

2021-01-11 Thread Yongqiang Niu
add support for mediatek SOC MT8192 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c| 6 drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 20 + drivers/gpu/drm/mediatek/mtk_disp_postmask.c | 1 + drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 +++

[PATCH 2/3] drm/sun4i: de2/de3: Remove redundant CSC matrices

2021-01-11 Thread Jernej Skrabec
YUV to RGB matrices are almost identical to YVU to RGB matrices. They only have second and third column reversed. Do that reversion in code in order to lower amount of static data and redundancy. Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun8i_csc.c | 99 +++

[PATCH 1/3] drm/sun4i: csc: Rework DE3 CSC macros

2021-01-11 Thread Jernej Skrabec
Rework DE3 CSC macros to take just one coordinate instead of two. This will make its usage easier in subsequent commit. Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun8i_csc.c | 2 +- drivers/gpu/drm/sun4i/sun8i_mixer.h | 6 ++ 2 files changed, 3 insertions(+), 5 deletions(-)

[PATCH v3, 12/15] drm/mediatek: separate ccorr module

2021-01-11 Thread Yongqiang Niu
ccorr ctm matrix bits will be different in mt8192 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/Makefile | 3 +- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 222 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 92 +--- drivers/gpu/drm

[PATCH v3, 03/15] arm64: dts: mt8192: add display node

2021-01-11 Thread Yongqiang Niu
add display node Signed-off-by: Yongqiang Niu --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 134 +++ 1 file changed, 134 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi index e12e024..dcf9fdf 100644 ---

Re: [PATCH v1] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-01-11 Thread Oliver Graute
On 09/01/21, Fabio Estevam wrote: > Hi Oliver, > > On Fri, Jan 8, 2021 at 7:24 PM Oliver Graute wrote: > > > > On 19/12/20, Oliver Graute wrote: > > > Add support for the Solomon Goldentek Display Model: GKTW70SDAD1SD > > > to panel-simple. > > > > > > The panel spec from Variscite can be found a

Re: [patch V3 13/37] mips/mm/highmem: Switch to generic kmap atomic

2021-01-11 Thread H. Nikolaus Schaller
> Am 10.01.2021 um 12:35 schrieb Paul Cercueil : > > Hi Thomas, > > Le sam. 9 janv. 2021 à 1:33, Thomas Bogendoerfer > a écrit : >> On Sat, Jan 09, 2021 at 12:58:05AM +0100, Thomas Bogendoerfer wrote: >>> On Fri, Jan 08, 2021 at 08:20:43PM +, Paul Cercueil wrote: >>> > Hi Thomas, >>> > >>

[PATCH] drm/hisilicon: Use drm_crtc_mask()

2021-01-11 Thread Tian Tao
Use drm_crtc_mask() where appropriate. Signed-off-by: Tian Tao --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c index c76

[PATCH v3, 04/15] drm/mediatek: add component OVL_2L2

2021-01-11 Thread Yongqiang Niu
This patch add component OVL_2L2 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index 81ed076..a715127 100644 --- a/drivers

Re: [PATCH v8] backlight: lms283gf05: Convert to GPIO descriptors

2021-01-11 Thread Daniel Mack
Hi Linus, On 10/1/2021 1:09 pm, Linus Walleij wrote: > This converts the lms283gf05 backlight driver to use GPIO > descriptors and switches the single PXA Palm Z2 device > over to defining these. > > Since the platform data was only used to convey GPIO > information we can delete the platform dat

[PATCH v3, 06/15] drm/mediatek: add component RDMA4

2021-01-11 Thread Yongqiang Niu
This patch add component RDMA4 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index bc6b10a..fc01fea 100644 --- a/drivers/g

[PATCH v3, 05/15] drm/mediatek: add component POSTMASK

2021-01-11 Thread Yongqiang Niu
This patch add component POSTMASK, Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/Makefile| 1 + drivers/gpu/drm/mediatek/mtk_disp_postmask.c | 160 +++ drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 + drivers/gpu/drm/mediatek/mtk_drm_ddp_com

[PATCH v3, 08/15] drm/mediatek: check if fb is null

2021-01-11 Thread Yongqiang Niu
It's possible that state->base.fb is null. Add a check before access its format. Fixes: b6b1bb980ec4 ( drm/mediatek: Turn off Alpha bit when plane format has no alpha) Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v3, 09/15] drm/mediatek: Add pm runtime support for gamma

2021-01-11 Thread Yongqiang Niu
gamma power domain need controled in the device. Signed-off-by: Yongqiang Niu Signed-off-by: Yidi Lin --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c ind

[PATCH v3, 01/15] dt-bindings: mediatek: add description for postmask

2021-01-11 Thread Yongqiang Niu
add description for postmask postmask is used control round corner for display frame Signed-off-by: Yongqiang Niu --- Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/mediatek/media

[PATCH v3, 13/15] drm/mediatek: add matrix bits private data for ccorr

2021-01-11 Thread Yongqiang Niu
matrix bits of mt8183 is 12 matrix bits of mt8192 is 13 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c b/drivers/gpu/drm/mediatek/mt

[PATCH v3, 11/15] drm/mediatek: fix aal size config

2021-01-11 Thread Yongqiang Niu
the orginal setting is not correct, fix it follow hardware data sheet. if keep this error setting, mt8173/mt8183 display ok but mt8192 display abnormal. Fixes: 0664d1392c26 (drm/mediatek: Add AAL engine basic function) Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c

[PATCH v3, 07/15] drm/mediatek: enable OVL_LAYER_SMI_ID_EN for multi-layer usecase

2021-01-11 Thread Yongqiang Niu
enable OVL_LAYER_SMI_ID_EN for multi-layer usecase Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c index b47c238..4934bee

Re: [PATCH v1] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-01-11 Thread Oliver Graute
On 10/01/21, Fabio Estevam wrote: > Hi Oliver, > > On Sun, Jan 10, 2021 at 12:35 PM Oliver Graute > wrote: > > > the first two errors are gone. But I still get this: > > > > [ 42.387107] mxsfb 21c8000.lcdif: Cannot connect bridge: -517 > > > > The panel is still off perhaps I miss something e

Re: [Freedreno] [PATCH] drm/msm: Only enable A6xx LLCC code on A6xx

2021-01-11 Thread Sai Prakash Ranjan
Hi Rob, On 2021-01-08 22:16, Rob Clark wrote: On Fri, Jan 8, 2021 at 6:05 AM Sai Prakash Ranjan wrote: On 2021-01-08 19:09, Konrad Dybcio wrote: >> Konrad, can you please test this below change without your change? > > This brings no difference, a BUG still happens. We're still calling > to_a

[PATCH v3, 14/15] drm/mediatek: add DDP support for MT8192

2021-01-11 Thread Yongqiang Niu
Add DDP support for MT8192 SoC. Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 35 ++ 1 file changed, 35 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c index 1308046..7aa7fc3

[PATCH v3, 02/15] dt-bindings: mediatek: add description for mt8192 display

2021-01-11 Thread Yongqiang Niu
add description for mt8192 display Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu Acked-by: Rob Herring --- Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/displ

[PATCH v3, 10/15] drm/mediatek: Add pm runtime support for color

2021-01-11 Thread Yongqiang Niu
color power domain need controled in the device. Signed-off-by: Yongqiang Niu Signed-off-by: Yidi Lin --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_color.c b/drivers/gpu/drm/mediatek/mtk_disp_color.c ind

[PATCH 0/3] drm/sun4i: de2/de3: CSC improvements

2021-01-11 Thread Jernej Skrabec
This short series reworks CSC handling to remove duplicated constants (patch 1 and 2) and adds BT2020 encoding to DE3 (patch 3). Please take a look. Best regards, Jernej Jernej Skrabec (3): drm/sun4i: csc: Rework DE3 CSC macros drm/sun4i: de2/de3: Remove redundant CSC matrices drm/sun4i: A

[PATCH 3/3] drm/sun4i: Add support for BT2020 to DE3

2021-01-11 Thread Jernej Skrabec
DE3 supports 10-bit formats, so it's only naturally to also support BT2020 encoding. Add support for it. Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun8i_csc.c | 12 +++- drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 2 ++ 2 files changed, 13 insertions(+), 1 deletion(-)

[PATCH v9 00/19] HDCP 2.2 and HDCP 1.4 Gen12 DP MST support

2021-01-11 Thread Anshuman Gupta
This v9 version has fixed crome-os NULL pointer dereference by just reordering connector status condition. It has been tested manually with below IGT series on TGL and ICL. https://patchwork.freedesktop.org/series/82987/ [PATCH v9 12/19] misc/mei/hdcp: Fix AUTH_STREAM_REQ cmd buffer len has an A

[PATCH v9 01/19] drm/i915/hdcp: Update CP property in update_pipe

2021-01-11 Thread Anshuman Gupta
When crtc state need_modeset is true it is not necessary it is going to be a real modeset, it can turns to be a fastset instead of modeset. This turns content protection property to be DESIRED and hdcp update_pipe left with property to be in DESIRED state but actual hdcp->value was ENABLED. This i

[PATCH v9 02/19] drm/i915/hdcp: Get conn while content_type changed

2021-01-11 Thread Anshuman Gupta
Get DRM connector reference count while scheduling a prop work to avoid any possible destroy of DRM connector when it is in DRM_CONNECTOR_REGISTERED state. Fixes: a6597faa2d59 ("drm/i915: Protect workers against disappearing connectors") Cc: Sean Paul Cc: Ramalingam C Reviewed-by: Uma Shankar

[PATCH v9 03/19] drm/i915/hotplug: Handle CP_IRQ for DP-MST

2021-01-11 Thread Anshuman Gupta
Handle CP_IRQ in DEVICE_SERVICE_IRQ_VECTOR_ESI0 It requires to call intel_hdcp_handle_cp_irq() in case of CP_IRQ is triggered by a sink in DP-MST topology. Cc: "Ville Syrjälä" Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gu

[PATCH v9 04/19] drm/i915/hdcp: No HDCP when encoder is't initialized

2021-01-11 Thread Anshuman Gupta
There can be situation when DP MST connector is created without mst modeset being done, in those cases connector->encoder will be NULL. MST connector->encoder initializes after modeset. Don't enable HDCP in such cases to prevent any crash. Cc: Ramalingam C Cc: Juston Li Tested-by: Karthik B S R

[PATCH v9 05/19] drm/i915/hdcp: DP MST transcoder for link and stream

2021-01-11 Thread Anshuman Gupta
Gen12 has H/W delta with respect to HDCP{1.x,2.x} display engine instances lies in Transcoder instead of DDI as in Gen11. This requires hdcp driver to use mst_master_transcoder for link authentication and stream transcoder for stream encryption separately. This will be used for both HDCP 1.4 and

[PATCH v9 06/19] drm/i915/hdcp: Move HDCP enc status timeout to header

2021-01-11 Thread Anshuman Gupta
DP MST stream encryption status requires time of a link frame in order to change its status, but as there were some HDCP encryption timeout observed earlier, it is safer to use ENCRYPT_STATUS_CHANGE_TIMEOUT_MS timeout for stream status too, it requires to move the macro to a header. It will be used

[PATCH v9 07/19] drm/i915/hdcp: HDCP stream encryption support

2021-01-11 Thread Anshuman Gupta
Both HDCP_{1.x,2.x} requires to select/deselect Multistream HDCP bit in TRANS_DDI_FUNC_CTL in order to enable/disable stream HDCP encryption over DP MST Transport Link. HDCP 1.4 stream encryption requires to validate the stream encryption status in HDCP_STATUS_{TRANSCODER,PORT} register driving th

[PATCH v9 08/19] drm/i915/hdcp: Configure HDCP1.4 MST steram encryption status

2021-01-11 Thread Anshuman Gupta
Enable HDCP 1.4 DP MST stream encryption. Enable stream encryption once encryption is enabled on the DP transport driving the link for each stream which has requested encryption. Disable stream encryption for each stream that no longer requires encryption before disabling HDCP encryption on the l

[PATCH v9 09/19] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2021-01-11 Thread Anshuman Gupta
Enable HDCP 1.4 over DP MST for Gen12. v2: - Enable HDCP for <= Gen12 platforms. [Ram] v3: - Connector detials in debug msg. [Ram] Cc: Ramalingam C Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 7 +++ 1 fi

[PATCH v9 10/19] drm/i915/hdcp: Pass dig_port to intel_hdcp_init

2021-01-11 Thread Anshuman Gupta
Pass dig_port as an argument to intel_hdcp_init() and intel_hdcp2_init(). This will be required for HDCP 2.2 stream encryption. Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_dp_h

[PATCH v9 11/19] drm/i915/hdcp: Encapsulate hdcp_port_data to dig_port

2021-01-11 Thread Anshuman Gupta
hdcp_port_data is specific to a port on which HDCP encryption is getting enabled, so encapsulate it to intel_digital_port. This will be required to enable HDCP 2.2 stream encryption. v2: - 's/port_data/hdcp_port_data'. [Ram] Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C T

[PATCH v9 12/19] misc/mei/hdcp: Fix AUTH_STREAM_REQ cmd buffer len

2021-01-11 Thread Anshuman Gupta
Fix the size of WIRED_REPEATER_AUTH_STREAM_REQ cmd buffer size. It is based upon the actual number of MST streams and size of wired_cmd_repeater_auth_stream_req_in. Excluding the size of hdcp_cmd_header. v2: - hdcp_cmd_header size annotation nitpick. [Tomas] Cc: Tomas Winkler Cc: Ramalingam C A

[PATCH v9 13/19] drm/hdcp: Max MST content streams

2021-01-11 Thread Anshuman Gupta
Let's define Maximum MST content streams up to four generically which can be supported by modern display controllers. Cc: Sean Paul Cc: Ramalingam C Acked-by: Maarten Lankhorst Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- inclu

[PATCH v9 14/19] drm/i915/hdcp: MST streams support in hdcp port_data

2021-01-11 Thread Anshuman Gupta
Add support for multiple mst stream in hdcp port data which will be used by RepeaterAuthStreamManage msg and HDCP 2.2 security f/w for m' validation. Security f/w doesn't have any provision to mark the stream_type for each stream separately, it just take single input of stream_type while authentic

[PATCH v9 15/19] drm/i915/hdcp: Pass connector to check_2_2_link

2021-01-11 Thread Anshuman Gupta
This requires for HDCP 2.2 MST check link. As for DP/HDMI shims check_2_2_link retrieves the connector from dig_port, this is not sufficient or DP MST connector, there can be multiple DP MST topology connector associated with same dig_port. Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by:

[PATCH v9 16/19] drm/i915/hdcp: Add HDCP 2.2 stream register

2021-01-11 Thread Anshuman Gupta
Add HDCP 2.2 DP MST HDCP2_STREAM_STATUS and HDCP2_AUTH_STREAM register in i915_reg header. B.Spec: 21780 B.Spec: 14410 B.Spec: 50573 v2 - Modified naming convention of HDCP2_STREAM_STATUS for pre-gen12 platforms inline with B.Spec. Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramal

[PATCH v9 17/19] drm/i915/hdcp: Support for HDCP 2.2 MST shim callbacks

2021-01-11 Thread Anshuman Gupta
Add support for HDCP 2.2 DP MST shim callback. This adds existing DP HDCP shim callback for Link Authentication and Encryption and HDCP 2.2 stream encryption callback. v2: - Added a WARN_ON() instead of drm_err. [Uma] - Cosmetic changes. [Uma] v3: - 's/port_data/hdcp_port_data' [Ram] - skip redund

[PATCH v9 18/19] drm/i915/hdcp: Configure HDCP2.2 MST steram encryption status

2021-01-11 Thread Anshuman Gupta
Authenticate and enable port encryption only once for an active HDCP 2.2 session, once port is authenticated and encrypted enable encryption for each stream that requires encryption on this port. Similarly disable the stream encryption for each encrypted stream, once all encrypted stream encryptio

[PATCH v9 19/19] drm/i915/hdcp: Enable HDCP 2.2 MST support

2021-01-11 Thread Anshuman Gupta
Enable HDCP 2.2 MST support till Gen12. Cc: Ramalingam C Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c

Re: [PATCH] amdgpu: Avoid sleeping during FPU critical sections

2021-01-11 Thread Christian König
Am 08.01.21 um 22:58 schrieb Jeremy Cline: dcn20_resource_construct() includes a number of kzalloc(GFP_KERNEL) calls which can sleep, but kernel_fpu_begin() disables preemption and sleeping in this context is invalid. The only places the FPU appears to be required is in the init_soc_bounding_box

Re: [drm:dm_plane_helper_prepare_fb [amdgpu]] *ERROR* Failed to pin framebuffer with error -12

2021-01-11 Thread Christian König
Hi Mikhail Am 10.01.21 um 23:26 schrieb Mikhail Gavrilov: Hi folks, today I joined to testing Kernel 5.11 and saw that the kernel log was flooded with BUG messages: BUG: sleeping function called from invalid context at mm/vmalloc.c:1756 in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 266,

Re: [PATCH] MAINTAINERS: update radeon/amdgpu/amdkfd git trees

2021-01-11 Thread Christian König
Am 08.01.21 um 22:33 schrieb Alex Deucher: On Fri, Jan 8, 2021 at 3:52 PM Abramov, Slava wrote: [AMD Official Use Only - Internal Distribution Only] Why not just https://gitlab.freedesktop.org/agd5f/linux ? I guess that works too. Either works for me. Reviewed-by: Christian König Christ

Re: [PATCH V4 3/3] drm/vkms: Add information about module options

2021-01-11 Thread Daniel Vetter
On Sun, Jan 10, 2021 at 07:35:41PM +0530, Sumera Priyadarsini wrote: > Update vkms documentation to contain usage of `modinfo` > command and steps to load vkms with module options enabled. > > Signed-off-by: Sumera Priyadarsini > --- > Documentation/gpu/vkms.rst | 10 ++ > 1 file changed

Re: [PATCH] drm/ttm: Remove pinned bos from LRU in ttm_bo_move_to_lru_tail() v2

2021-01-11 Thread Christian König
Am 08.01.21 um 19:49 schrieb Mike Lothian: Hi This breaks things for me on my Prime system https://gitlab.freedesktop.org/drm/misc/-/issues/23 This is most likely not correct. The patch just fixes another bug which would break prime before it hits the issue in the i915 driver. Christian.

Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool

2021-01-11 Thread Christian König
Am 08.01.21 um 16:53 schrieb Daniel Vetter: On Fri, Jan 8, 2021 at 3:36 PM Christian König wrote: Am 08.01.21 um 15:31 schrieb Daniel Vetter: On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote: Am 07.01.21 um 19:07 schrieb Daniel Vetter: On Tue, Jan 05, 2021 at 07:23:08PM +0100,

[PATCH][next] drm/amdgpu: Add missing BOOTUP_DEFAULT to profile_name[]

2021-01-11 Thread Colin King
From: Colin Ian King A recent change added a new BOOTUP_DEFAULT power profile mode to the PP_SMC_POWER_PROFILE enum but omitted updating the corresponding profile_name array. Fix this by adding in the missing BOOTUP_DEFAULT to profile_name[]. Addresses-Coverity: ("Out-of-bounds read") Fixes: c2

[PATCH v5 05/21] gpu: host1x: Use HW-equivalent syncpoint expiration check

2021-01-11 Thread Mikko Perttunen
Make syncpoint expiration checks always use the same logic used by the hardware. This ensures that there are no race conditions that could occur because of the hardware triggering a syncpoint interrupt and then the driver disagreeing. One situation where this could occur is if a job incremented a

[PATCH v5 10/21] gpu: host1x: Add no-recovery mode

2021-01-11 Thread Mikko Perttunen
Add a new property for jobs to enable or disable recovery i.e. CPU increments of syncpoints to max value on job timeout. This allows for a more solid model for hanged jobs, where userspace doesn't need to guess if a syncpoint increment happened because the job completed, or because job timeout was

[PATCH v5 04/21] gpu: host1x: Remove cancelled waiters immediately

2021-01-11 Thread Mikko Perttunen
Before this patch, cancelled waiters would only be cleaned up once their threshold value was reached. Make host1x_intr_put_ref process the cancellation immediately to fix this. Signed-off-by: Mikko Perttunen --- v5: * Add parameter to flush, i.e. wait for all pending waiters to complete before

[PATCH v5 02/21] gpu: host1x: Allow syncpoints without associated client

2021-01-11 Thread Mikko Perttunen
Syncpoints don't need to be associated with any client, so remove the property, and expose host1x_syncpt_alloc. This will allow allocating syncpoints without prior knowledge of the engine that it will be used with. Signed-off-by: Mikko Perttunen --- v3: * Clean up host1x_syncpt_alloc signature to

[PATCH v5 11/21] gpu: host1x: Add job release callback

2021-01-11 Thread Mikko Perttunen
Add a callback field to the job structure, to be called just before the job is to be freed. This allows the job's submitter to clean up any of its own state, like decrement runtime PM refcounts. Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/job.c | 3 +++ include/linux/host1x.h | 4 +++

[PATCH v5 19/21] drm/tegra: Implement new UAPI

2021-01-11 Thread Mikko Perttunen
Implement the non-submission parts of the new UAPI, including channel management and memory mapping. The UAPI is under the CONFIG_DRM_TEGRA_STAGING config flag for now. Signed-off-by: Mikko Perttunen --- v5: * Set iova_end in both mapping paths v4: * New patch, split out from combined UAPI + subm

[PATCH v5 09/21] gpu: host1x: DMA fences and userspace fence creation

2021-01-11 Thread Mikko Perttunen
Add an implementation of dma_fences based on syncpoints. Syncpoint interrupts are used to signal fences. Additionally, after software signaling has been enabled, a 30 second timeout is started. If the syncpoint threshold is not reached within this period, the fence is signalled with an -ETIMEDOUT e

[PATCH v5 00/21] Host1x/TegraDRM UAPI

2021-01-11 Thread Mikko Perttunen
Hi all, here's the fifth revision of the Host1x/TegraDRM UAPI proposal, containing primarily small bug fixes. It has also been rebased on top of recent linux-next. vaapi-tegra-driver has been updated to support the new UAPI as well as Tegra186: https://github.com/cyndis/vaapi-tegra-driver The

[PATCH v5 14/21] gpu: host1x: Reserve VBLANK syncpoints at initialization

2021-01-11 Thread Mikko Perttunen
On T20-T148 chips, the bootloader can set up a boot splash screen with DC configured to increment syncpoint 26/27 at VBLANK. Because of this we shouldn't allow these syncpoints to be allocated until DC has been reset and will no longer increment them in the background. As such, on these chips, res

[PATCH v5 15/21] drm/tegra: Add new UAPI to header

2021-01-11 Thread Mikko Perttunen
Update the tegra_drm.h UAPI header, adding the new proposed UAPI. The old staging UAPI is left in for now, with minor modification to avoid name collisions. Signed-off-by: Mikko Perttunen --- v4: * Remove features that are not strictly necessary * Remove padding/reserved fields in IOCTL structs w

[PATCH v5 20/21] drm/tegra: Implement job submission part of new UAPI

2021-01-11 Thread Mikko Perttunen
Implement the job submission IOCTL with a minimum feature set. Signed-off-by: Mikko Perttunen --- v5: * Add 16K size limit to copies from userspace. * Guard RELOC_BLOCKLINEAR flag handling to only exist in ARM64 to prevent oversized shift on 32-bit platforms. v4: * Remove all features that are

[PATCH v5 16/21] drm/tegra: Boot VIC during runtime PM resume

2021-01-11 Thread Mikko Perttunen
With the new UAPI implementation, engines are powered on and off when there are active jobs, and the core code handles channel allocation. To accommodate that, boot the engine as part of runtime PM instead of using the open_channel callback, which is not used by the new submit path. Signed-off-by:

[PATCH v5 01/21] gpu: host1x: Use different lock classes for each client

2021-01-11 Thread Mikko Perttunen
To avoid false lockdep warnings, give each client lock a different lock class, passed from the initialization site by macro. Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/bus.c | 7 --- include/linux/host1x.h | 9 - 2 files changed, 12 insertions(+), 4 deletions(-) diff --

[PATCH v5 21/21] drm/tegra: Add job firewall

2021-01-11 Thread Mikko Perttunen
Add a firewall that validates jobs before submission to ensure they don't do anything they aren't allowed to do, like accessing memory they should not access. The firewall is functionality-wise a copy of the firewall already implemented in gpu/host1x. It is copied here as it makes more sense for i

[PATCH v5 18/21] drm/tegra: Allocate per-engine channel in core code

2021-01-11 Thread Mikko Perttunen
To avoid duplication, allocate the per-engine shared channel in the core code instead. Once MLOCKs are implemented on Host1x side, we can also update this to avoid allocating a shared channel when MLOCKs are enabled. Signed-off-by: Mikko Perttunen --- drivers/gpu/drm/tegra/drm.c | 11 +++

[PATCH v5 03/21] gpu: host1x: Show number of pending waiters in debugfs

2021-01-11 Thread Mikko Perttunen
Show the number of pending waiters in the debugfs status file. This is useful for testing to verify that waiters do not leak or accumulate incorrectly. Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/debug.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git

[PATCH v5 17/21] drm/tegra: Set resv fields when importing/exporting GEMs

2021-01-11 Thread Mikko Perttunen
To allow sharing of implicit fences when exporting/importing dma_buf objects, set the 'resv' fields when importing or exporting GEM objects. Signed-off-by: Mikko Perttunen --- drivers/gpu/drm/tegra/gem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/

[PATCH v5 12/21] gpu: host1x: Add support for syncpoint waits in CDMA pushbuffer

2021-01-11 Thread Mikko Perttunen
Add support for inserting syncpoint waits in the CDMA pushbuffer. These waits need to be done in HOST1X class, while gather submitted by the application execute in engine class. Support is added by converting the gather list of job into a command list that can include both gathers and waits. When

[PATCH v5 13/21] gpu: host1x: Reset max value when freeing a syncpoint

2021-01-11 Thread Mikko Perttunen
With job recovery becoming optional, syncpoints may have a mismatch between their value and max value when freed. As such, when freeing, set the max value to the current value of the syncpoint so that it is in a sane state for the next user. Signed-off-by: Mikko Perttunen --- v3: * Use host1x_syn

[PATCH v5 07/21] gpu: host1x: Introduce UAPI header

2021-01-11 Thread Mikko Perttunen
Add the userspace interface header, specifying interfaces for allocating and accessing syncpoints from userspace, and for creating sync_file based fences based on syncpoint thresholds. Signed-off-by: Mikko Perttunen --- include/uapi/linux/host1x.h | 134 1 fi

[PATCH v5 06/21] gpu: host1x: Cleanup and refcounting for syncpoints

2021-01-11 Thread Mikko Perttunen
Add reference counting for allocated syncpoints to allow keeping them allocated while jobs are referencing them. Additionally, clean up various places using syncpoint IDs to use host1x_syncpt pointers instead. Signed-off-by: Mikko Perttunen --- v5: - Remove host1x_syncpt_put in submit code, as jo

[PATCH v5 08/21] gpu: host1x: Implement /dev/host1x device node

2021-01-11 Thread Mikko Perttunen
Add the /dev/host1x device node, implementing the following functionality: - Reading syncpoint values - Allocating syncpoints (providing syncpoint FDs) - Incrementing syncpoints (based on syncpoint FD) Signed-off-by: Mikko Perttunen --- v4: * Put UAPI under CONFIG_DRM_TEGRA_STAGING v3: * Pass pr

[PATCH] drm/bridge: nwl-dsi: Avoid potential multiplication overflow on 32-bit

2021-01-11 Thread Geert Uytterhoeven
As nwl_dsi.lanes is u32, and NSEC_PER_SEC is 10L, the second multiplication in dsi->lanes * 8 * NSEC_PER_SEC will overflow on a 32-bit platform. Fix this by making the constant unsigned long long, forcing 64-bit arithmetic. While iMX8 is arm64, this driver is currently used on 64-bi

Re: [PATCH] drm/fourcc: fix Amlogic format modifier masks

2021-01-11 Thread Neil Armstrong
Hi, On 10/01/2021 13:51, Simon Ser wrote: > The comment says the layout and options use 8 bits, and the shift > uses 8 bits. However the mask is 0xf, ie. 0b (4 bits). > > This could be surprising when introducing new layouts or options > that take more than 4 bits, as this would silently

[PATCH] drm/ttm: make the pool shrinker lock a mutex

2021-01-11 Thread Christian König
set_pages_wb() might sleep and so we can't do this in an atomic context. Signed-off-by: Christian König Reported-by: Mikhail Gavrilov Fixes: d099fc8f540a ("drm/ttm: new TT backend allocation pool v3") --- drivers/gpu/drm/ttm/ttm_pool.c | 20 ++-- 1 file changed, 10 insertions(+)

Re: [drm:dm_plane_helper_prepare_fb [amdgpu]] *ERROR* Failed to pin framebuffer with error -12

2021-01-11 Thread Christian König
Am 11.01.21 um 10:03 schrieb Christian König: Hi Mikhail Am 10.01.21 um 23:26 schrieb Mikhail Gavrilov: Hi folks, today I joined to testing Kernel 5.11 and saw that the kernel log was flooded with BUG messages: BUG: sleeping function called from invalid context at mm/vmalloc.c:1756 in_atomic():

[PATCH v2] drm/i915: selftest_lrc: Fix error code in live_preempt_user()

2021-01-11 Thread Dan Carpenter
This error path should return a negative error code instead of success. Fixes: c92724de6db1 ("drm/i915/selftests: Try to detect rollback during batchbuffer preemption") Signed-off-by: Dan Carpenter Reviewed-by: Chris Wilson --- v2: The first version of the patch fixed some other error paths but

Re: [PATCH v2] drm: Check actual format for legacy pageflip.

2021-01-11 Thread Alex Deucher
On Sat, Jan 9, 2021 at 9:11 PM Bas Nieuwenhuizen wrote: > > With modifiers one can actually have different format_info structs > for the same format, which now matters for AMDGPU since we convert > implicit modifiers to explicit modifiers with multiple planes. > > I checked other drivers and it do

RE: [PATCH v16 0/4] RDMA: Add dma-buf support

2021-01-11 Thread Xiong, Jianxin
Jason, will this series be able to get into 5.12? > -Original Message- > From: Xiong, Jianxin > Sent: Tuesday, December 15, 2020 1:27 PM > To: linux-r...@vger.kernel.org; dri-devel@lists.freedesktop.org > Cc: Xiong, Jianxin ; Doug Ledford > ; Jason Gunthorpe ; Leon Romanovsky > ; Sumit S

Re: [PATCH v2] drm/i915: selftest_lrc: Fix error code in live_preempt_user()

2021-01-11 Thread Andi Shyti
Hi Dan, On Mon, Jan 11, 2021 at 05:18:08PM +0300, Dan Carpenter wrote: > This error path should return a negative error code instead of success. > > Fixes: c92724de6db1 ("drm/i915/selftests: Try to detect rollback during > batchbuffer preemption") > Signed-off-by: Dan Carpenter > Reviewed-by: C

Re: [PATCH] amdgpu: Avoid sleeping during FPU critical sections

2021-01-11 Thread Jeremy Cline
Hi, On Mon, Jan 11, 2021 at 09:53:56AM +0100, Christian König wrote: > Am 08.01.21 um 22:58 schrieb Jeremy Cline: > > dcn20_resource_construct() includes a number of kzalloc(GFP_KERNEL) > > calls which can sleep, but kernel_fpu_begin() disables preemption and > > sleeping in this context is invali

Re: [PATCH v2 02/10] drm: uapi: amd: Use SPDX in DRM drivers uAPI headers

2021-01-11 Thread Alex Deucher
On Tue, Dec 15, 2020 at 9:44 PM Laurent Pinchart wrote: > > The AMD DRM drivers uAPI headers are licensed under the MIT license, > and carry copies of the license with slight variations. Replace them > with SPDX headers. > > Signed-off-by: Laurent Pinchart Acked-by: Alex Deucher > --- > inclu

Re: [PATCH -next] drm/amd/display: tweak the kerneldoc for active_vblank_irq_count

2021-01-11 Thread Lakha, Bhawanpreet
ies on amdgpu's -next and next-20210111 Bhawanpreet, Nick, please review and ack. Alex, Christian, please pick on top of the commit above. drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm

Re: [PATCH -next] drm/amd/display: tweak the kerneldoc for active_vblank_irq_count

2021-01-11 Thread Alex Deucher
rq_count > 379: warning: Function parameter or member 'active_vblank_irq_count' not > described in 'amdgpu_display_manager' > > Tweak the kerneldoc for active_vblank_irq_count. > > Signed-off-by: Lukas Bulwahn > --- > applies on amdgpu's -ne

Re: [Freedreno] [PATCH] drm/msm: Only enable A6xx LLCC code on A6xx

2021-01-11 Thread Jordan Crouse
On Mon, Jan 11, 2021 at 09:54:12AM +0530, Sai Prakash Ranjan wrote: > Hi Rob, > > On 2021-01-08 22:16, Rob Clark wrote: > >On Fri, Jan 8, 2021 at 6:05 AM Sai Prakash Ranjan > > wrote: > >> > >>On 2021-01-08 19:09, Konrad Dybcio wrote: > Konrad, can you please test this below change without yo

Re: [PATCH v3 01/12] drm: Add dummy page per device or GEM object

2021-01-11 Thread Daniel Vetter
On Fri, Jan 08, 2021 at 04:49:55PM +, Grodzovsky, Andrey wrote: > Ok then, I guess I will proceed with the dummy pages list implementation then. > > Andrey > > > From: Koenig, Christian > Sent: 08 January 2021 09:52 > To: Grodzovsky, Andrey ; Daniel Vetter >

Re: [PATCH v3 01/12] drm: Add dummy page per device or GEM object

2021-01-11 Thread Daniel Vetter
On Mon, Jan 11, 2021 at 05:13:56PM +0100, Daniel Vetter wrote: > On Fri, Jan 08, 2021 at 04:49:55PM +, Grodzovsky, Andrey wrote: > > Ok then, I guess I will proceed with the dummy pages list implementation > > then. > > > > Andrey > > > > > > From: Koenig, Ch

Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool

2021-01-11 Thread Daniel Vetter
On Mon, Jan 11, 2021 at 11:16:13AM +0100, Christian König wrote: > Am 08.01.21 um 16:53 schrieb Daniel Vetter: > > On Fri, Jan 8, 2021 at 3:36 PM Christian König > > wrote: > > > Am 08.01.21 um 15:31 schrieb Daniel Vetter: > > > > On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote: >

Re: [PATCH] drm/panel: panel-simple: add bus-format and connector-type to Innolux n116bge

2021-01-11 Thread Doug Anderson
Hi, On Sat, Jan 9, 2021 at 5:10 AM Heiko Stuebner wrote: > > From: Heiko Stuebner > > The Innolux n116bge panel has an eDP connector and 3*6 bits bus format. > > Signed-off-by: Heiko Stuebner > --- > drivers/gpu/drm/panel/panel-simple.c | 2 ++ > 1 file changed, 2 insertions(+) This looks rig

Re: [PATCH v8] backlight: lms283gf05: Convert to GPIO descriptors

2021-01-11 Thread Lee Jones
On Sun, 10 Jan 2021, Linus Walleij wrote: > This converts the lms283gf05 backlight driver to use GPIO > descriptors and switches the single PXA Palm Z2 device > over to defining these. > > Since the platform data was only used to convey GPIO > information we can delete the platform data header. >

Re: [PATCH][next] drm/amdgpu: Add missing BOOTUP_DEFAULT to profile_name[]

2021-01-11 Thread Alex Deucher
On Mon, Jan 11, 2021 at 6:46 AM Colin King wrote: > > From: Colin Ian King > > A recent change added a new BOOTUP_DEFAULT power profile mode > to the PP_SMC_POWER_PROFILE enum but omitted updating the > corresponding profile_name array. Fix this by adding in the > missing BOOTUP_DEFAULT to profi

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-11 Thread Daniel Vetter
On Fri, Jan 08, 2021 at 12:56:24PM -0500, Felix Kuehling wrote: > > Am 2021-01-08 um 11:53 a.m. schrieb Daniel Vetter: > > On Fri, Jan 8, 2021 at 5:36 PM Felix Kuehling > > wrote: > >> > >> Am 2021-01-08 um 11:06 a.m. schrieb Daniel Vetter: > >>> On Fri, Jan 8, 2021 at 4:58 PM Felix Kuehling >

Re: [PATCH] amdgpu: Avoid sleeping during FPU critical sections

2021-01-11 Thread Daniel Vetter
On Mon, Jan 11, 2021 at 09:53:56AM +0100, Christian König wrote: > Am 08.01.21 um 22:58 schrieb Jeremy Cline: > > dcn20_resource_construct() includes a number of kzalloc(GFP_KERNEL) > > calls which can sleep, but kernel_fpu_begin() disables preemption and > > sleeping in this context is invalid. >

Re: [PATCH v2] drm: Check actual format for legacy pageflip.

2021-01-11 Thread Bas Nieuwenhuizen
On Mon, Jan 11, 2021 at 4:02 PM Alex Deucher wrote: > > On Sat, Jan 9, 2021 at 9:11 PM Bas Nieuwenhuizen > wrote: > > > > With modifiers one can actually have different format_info structs > > for the same format, which now matters for AMDGPU since we convert > > implicit modifiers to explicit mo

[PATCH] drm/ttm: Fix address passed to dma_mapping_error() in ttm_pool_map()

2021-01-11 Thread Jeremy Cline
check_unmap() is producing a warning about a missing map error check. The return value from dma_map_page() should be checked for an error, not the caller-provided dma_addr. Fixes: d099fc8f540a ("drm/ttm: new TT backend allocation pool v3") Signed-off-by: Jeremy Cline --- drivers/gpu/drm/ttm/ttm_

Re: [PATCH v4 1/2] drm/msm: Add speed-bin support to a618 gpu

2021-01-11 Thread Jordan Crouse
On Fri, Jan 08, 2021 at 11:45:30PM +0530, Akhil P Oommen wrote: > Some GPUs support different max frequencies depending on the platform. > To identify the correct variant, we should check the gpu speedbin > fuse value. Add support for this speedbin detection to a6xx family > along with the required

  1   2   3   >