Re: [kbuild-all] Re: [PATCH v3 8/8] drm: Upcast struct drm_device.dev to struct pci_device; replace pdev

2021-01-08 Thread Thomas Zimmermann
Hi Am 08.01.21 um 02:25 schrieb Rong Chen: Hi Thomas, Thanks for the feedback, do you mean the patch was applied to a wrong base? I'm on drm-tip, which already has the patches that fix these issues. I think I should start using git's --base option when sending out patchsets. Best regards T

Re: [RFC] drm/connector: Set the default callback function for drm_connector_funcs

2021-01-08 Thread Thomas Zimmermann
Hi Am 08.01.21 um 08:54 schrieb Tian Tao: The member functions of drm_connector_funcs are not specific to each manufacturer's driver, so drm_connector_funcs is allowed to use default values, which prevents all drivers from setting the same member functions for drm_connector_funcs. I don't thin

Re: [pull] drm/msm: drm-msm-fixes-2021-01-07

2021-01-08 Thread Daniel Vetter
On Thu, Jan 07, 2021 at 01:54:59PM -0800, Rob Clark wrote: > Hi Dave, > > A few misc fixes > > The following changes since commit e319a1b956f785f618611857cd946dca2bb68542: > > drm/msm: add IOMMU_SUPPORT dependency (2020-12-05 08:25:52 -0800) > > are available in the Git repository at: > >

[Patch] fbcon: i want fbcon soft scrollback feature come back

2021-01-08 Thread xuhuijie
This commit 50145474f6ef(fbcon: remove soft scrollback code) remove soft scrollback in fbcon. So the shift+PageDown and shift+PageUp is missing. But PageUp is a vary important feature when system panic or reset. I can get log by PageUp before, but now there is no way to get. Especially on the se

[Patch] fbcon: i want fbcon soft scrollback feature come back

2021-01-08 Thread xuhuijie
___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: Tree for Jan 7 (drivers/gpu/drm/imx/parallel-display.o)

2021-01-08 Thread Randy Dunlap
On 1/6/21 7:01 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20210106: > on x86_64: ld: drivers/gpu/drm/imx/parallel-display.o: in function `imx_pd_connector_get_modes': parallel-display.c:(.text+0x8d): undefined reference to `of_get_drm_display_mode' Full randconfig file is attac

[PATCH 2/2] drm/msm/dp: unplug interrupt missed after irq_hpd handler

2021-01-08 Thread Kuogee Hsieh
There is HPD unplug interrupts missed at scenario of an irq_hpd followed by unplug interrupts with around 10 ms in between. Since both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts, irq_hpd handler should not issues either aux or sw reset to avoid following unplug interrupt be cleared a

Re: [PATCH v2] soc: mediatek: cmdq: add address shift in jump

2021-01-08 Thread Yongqiang Niu
On Wed, 2020-12-23 at 16:34 +0800, Yongqiang Niu wrote: > Add address shift when compose jump instruction > to compatible with 35bit format. > > Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform") > > Signed-off-by: Yongqiang Niu > Reviewed-by: Nicolas Boichat > --- > d

[PATCH 0/2] *** fix missing unplug interrupt problem ***

2021-01-08 Thread Kuogee Hsieh
Both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts. Therefore irq_hpd handler should not issues either aux or sw reset to avoid following unplug interrupt be cleared accidentally. Kuogee Hsieh (2): drm/msm/dp: postpone irq_hpd event during connection pending state drm/msm/dp: unp

Re: [PATCH v2 00/48] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2021-01-08 Thread Dmitry Osipenko
05.01.2021 20:11, Krzysztof Kozlowski пишет: > On Thu, Dec 17, 2020 at 09:05:50PM +0300, Dmitry Osipenko wrote: >> Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs, which reduces >> power consumption and heating of the Tegra chips. Tegra SoC has multiple >> hardware units which belong to a

[PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state

2021-01-08 Thread Kuogee Hsieh
irq_hpd event can only be executed at connected state. Therefore irq_hpd event should be postponed if it happened at connection pending state. This patch also make sure both link rate and lane are valid before start link training. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display

Re: [PATCH] dt-bindings: bcm2835-vec: Add power-domains property

2021-01-08 Thread Florian Fainelli
On 1/7/2021 6:42 PM, Rob Herring wrote: > On Wed, 23 Dec 2020 20:24:33 +0100, Stefan Wahren wrote: >> Adding the missing property power-domains to the bcm2835-vec schema to fix >> the following dtbs_check issue: >> >> vec@7e806000: 'power-domains' does not match any of the regexes: ... >> >> Sig

[RFC] drm/connector: Set the default callback function for drm_connector_funcs

2021-01-08 Thread Tian Tao
The member functions of drm_connector_funcs are not specific to each manufacturer's driver, so drm_connector_funcs is allowed to use default values, which prevents all drivers from setting the same member functions for drm_connector_funcs. Signed-off-by: Tian Tao --- drivers/gpu/drm/drm_connecto

Re: [Patch] fbcon: i want fbcon soft scrollback feature come back

2021-01-08 Thread Tetsuo Handa
On 2021/01/08 0:48, xuhuijie wrote: > This commit 50145474f6ef(fbcon: remove soft scrollback code) remove soft > scrollback in > fbcon. So the shift+PageDown and shift+PageUp is missing. But PageUp is a > vary important > feature when system panic or reset. I can get log by PageUp before, but now

Re: [RFC] drm/connector: Set the default callback function for drm_connector_funcs

2021-01-08 Thread Daniel Vetter
On Fri, Jan 8, 2021 at 9:12 AM Thomas Zimmermann wrote: > > Hi > > Am 08.01.21 um 08:54 schrieb Tian Tao: > > The member functions of drm_connector_funcs are not specific to each > > manufacturer's driver, so drm_connector_funcs is allowed to use default > > values, which prevents all drivers from

Re: [kbuild-all] Re: [PATCH v3 8/8] drm: Upcast struct drm_device.dev to struct pci_device; replace pdev

2021-01-08 Thread Daniel Vetter
On Fri, Jan 08, 2021 at 09:04:44AM +0100, Thomas Zimmermann wrote: > Hi > > Am 08.01.21 um 02:25 schrieb Rong Chen: > > Hi Thomas, > > > > Thanks for the feedback, do you mean the patch was applied to a wrong base? > > I'm on drm-tip, which already has the patches that fix these issues. I think

Re: linux-next: Tree for Jan 7 (drivers/gpu/drm/imx/parallel-display.o)

2021-01-08 Thread Daniel Vetter
On Fri, Jan 8, 2021 at 9:55 AM Randy Dunlap wrote: > > On 1/6/21 7:01 PM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20210106: > > > > on x86_64: > > ld: drivers/gpu/drm/imx/parallel-display.o: in function > `imx_pd_connector_get_modes': > parallel-display.c:(.text+0x8d): undefined

[PULL] drm-misc-fixes

2021-01-08 Thread Thomas Zimmermann
Hi Dave and Daniel, sorry for being a bit late. Here's this week's PR for drm-misc-fixes. Best regards Thomas drm-misc-fixes-2021-01-08: * dma-buf: fix a use-after-free * radeon: don't init the TTM page pool manually * ttm: unexport ttm_pool_{init,fini}() The following changes since commit e71ba

[PATCH v4 00/13] drm: Support short-term vmap via vmap_local

2021-01-08 Thread Thomas Zimmermann
GEM VRAM helpers used to pin the BO in their implementation of vmap, so that they could not be relocated. In recent discussions, [1][2] it became clear that this is incorrect for in-kernel use cases, such as fbdev emulation; which should rather depend on the reservation lock to prevent relocation.

[PATCH v4 02/13] drm/gem: Create infrastructure for GEM vmap_local

2021-01-08 Thread Thomas Zimmermann
This patch adds vmap_local and vunmap_local to struct drm_gem_object_funcs; including the PRIME helpers to connect with dma-buf's related interfaces. Besides the generic DRM core, this will become relevant for fbdev emulation with virtio, so we update it as well. v4: * update documentatio

[PATCH v4 01/13] dma-buf: Add vmap_local and vnumap_local operations

2021-01-08 Thread Thomas Zimmermann
The existing dma-buf calls dma_buf_vmap() and dma_buf_vunmap() are allowed to pin the buffer or acquire the buffer's reservation object lock. This is a problem for callers that only require a short-term mapping of the buffer without the pinning, or callers that have special locking requirements. T

[PATCH v4 07/13] drm/gm12u320: Use drm_gem_shmem_vmap_local() in damage handling

2021-01-08 Thread Thomas Zimmermann
Damage handling in gm12u320 requires a short-term mapping of the source BO. Use drm_gem_shmem_vmap_local(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/gm12u320.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tiny/gm12u320.c b/d

[PATCH v4 03/13] drm/cma-helper: Provide a vmap function for short-term mappings

2021-01-08 Thread Thomas Zimmermann
Implementations of the vmap/vunmap GEM callbacks may perform pinning of the BO and may acquire the associated reservation object's lock. Callers that only require a mapping of the contained memory can thus interfere with other tasks that require exact pinning, such as scanout. This is less of an is

[PATCH v4 05/13] drm/mgag200: Use drm_gem_shmem_vmap_local() in damage handling

2021-01-08 Thread Thomas Zimmermann
Damage handling in mgag200 requires a short-term mapping of the source BO. Use drm_gem_shmem_vmap_local(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_mode.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mga

[PATCH v4 06/13] drm/cirrus: Use drm_gem_shmem_vmap_local() in damage handling

2021-01-08 Thread Thomas Zimmermann
Damage handling in cirrus requires a short-term mapping of the source BO. Use drm_gem_shmem_vmap_local(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/cirrus.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tiny/cirrus.c b/drivers/gpu/

[PATCH v4 04/13] drm/shmem-helper: Provide a vmap function for short-term mappings

2021-01-08 Thread Thomas Zimmermann
Implementations of the vmap/vunmap GEM callbacks may perform pinning of the BO and may acquire the associated reservation object's lock. Callers that only require a mapping of the contained memory can thus interfere with other tasks that require exact pinning, such as scanout. This is less of an is

[PATCH v4 08/13] drm/udl: Use drm_gem_shmem_vmap_local() in damage handling

2021-01-08 Thread Thomas Zimmermann
Damage handling in udl requires a short-term mapping of the source BO. Use drm_gem_shmem_vmap_local(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/udl/udl_modeset.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/udl/udl_modeset.c

[PATCH v4 10/13] drm/ast: Use drm_gem_vram_vmap_local() in cursor update

2021-01-08 Thread Thomas Zimmermann
Cursor updates in ast require a short-term mapping of the source and destination BO. Use drm_gem_vram_vmap_local() and avoid the pinning operations. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_cursor.c | 37 +++- 1 file changed, 27 insertions(+), 10 d

[PATCH v4 09/13] drm/vram-helper: Provide a vmap function for short-term mappings

2021-01-08 Thread Thomas Zimmermann
Implementations of the vmap/vunmap GEM callbacks may perform pinning of the BO and may acquire the associated reservation object's lock. It's somewhat inconvenient to callers that simply require a mapping of the contained memory; and also ipmplies a certain overhead. Therefore provide drm_gem_vram

[PATCH v4 11/13] drm/vboxvideo: Use drm_gem_vram_vmap_local() in cursor update

2021-01-08 Thread Thomas Zimmermann
Cursor updates in vboxvideo require a short-term mapping of the source BO. Use drm_gem_vram_vmap_local() and avoid the pinning operations. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vboxvideo/vbox_mode.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git

[PATCH v4 13/13] drm/vram-helper: Remove unused drm_gem_vram_{vmap, vunmap}()

2021-01-08 Thread Thomas Zimmermann
VRAM-helper BO's cannot be exported, so calls for vmap and vunmap can only come from the BO's drivers or a kernel client. These are supposed use vmap_local functionality. The vmap and vunmap operations in VRAM helpers are therefore unused and can be removed. Signed-off-by: Thomas Zimmermann ---

[PATCH v4 12/13] drm/fb-helper: Move BO locking from DRM client to fbdev damage worker

2021-01-08 Thread Thomas Zimmermann
Fbdev emulation has to lock the BO into place while flushing the shadow buffer into the BO's memory. Remove any interference with pinning by using vmap_local functionality (instead of full vmap). This requires BO reservation locking in fbdev's damage worker. The new DRM client functions for lockin

Re: [PULL] drm-misc-fixes

2021-01-08 Thread Daniel Vetter
On Fri, Jan 08, 2021 at 10:34:34AM +0100, Thomas Zimmermann wrote: > Hi Dave and Daniel, > > sorry for being a bit late. Here's this week's PR for drm-misc-fixes. No worries, Dave's out anyway so this is all in time for me to do the pull :-) > > Best regards > Thomas > > drm-misc-fixes-2021-01

[PATCH] drm/modes: add non-OF stub for of_get_drm_display_mode

2021-01-08 Thread Philipp Zabel
If CONFIG_OF is disabled, of_get_drm_display_mode is not compiled in, and drivers using it fail to build: ld: drivers/gpu/drm/imx/parallel-display.o: in function `imx_pd_connector_get_modes': parallel-display.c:(.text+0x8d): undefined reference to `of_get_drm_display_mode' Add an inline stu

Re: linux-next: Tree for Jan 7 (drivers/gpu/drm/imx/parallel-display.o)

2021-01-08 Thread Philipp Zabel
On Fri, 2021-01-08 at 10:03 +0100, Daniel Vetter wrote: > On Fri, Jan 8, 2021 at 9:55 AM Randy Dunlap wrote: > > On 1/6/21 7:01 PM, Stephen Rothwell wrote: > > > Hi all, > > > > > > Changes since 20210106: > > > > > > > on x86_64: > > > > ld: drivers/gpu/drm/imx/parallel-display.o: in function

Re: [RFC] drm/connector: Set the default callback function for drm_connector_funcs

2021-01-08 Thread Jani Nikula
On Fri, 08 Jan 2021, Thomas Zimmermann wrote: > Drivers cannot legally declare the funcs instance as static const. > Having static const allows for write protected pages. This. I've done quite a bit of refactoring all over the place to be ablet to move to the complete opposite direction. We want

Re: [PULL] topic/dp-hdmi-2.1-pcon for drm-misc-next

2021-01-08 Thread Jani Nikula
On Thu, 07 Jan 2021, Daniel Vetter wrote: > On Wed, Dec 23, 2020 at 10:14:58AM +0200, Jani Nikula wrote: >> >> Hi Maarten, Maxime, and Thomas - >> >> Here's the DP-HDMI2.1 PCON support topic pull consisting of the series >> [1]. The series is split roughly 50-50 between drm helpers and i915, so

[PATCH 1/3] drm/vc4: Use drm_gem_cma_vmap() directly

2021-01-08 Thread Thomas Zimmermann
Validated shaders cannot be exported. There's no need for testing this in the BO's vmap implementation. Call drm_gem_cma_vmap() directly instead. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vc4/vc4_bo.c | 14 +- drivers/gpu/drm/vc4/vc4_drv.h | 1 - 2 files changed, 1 inser

[PATCH 3/3] drm/vc4: Move mmap implementation into GEM object function

2021-01-08 Thread Thomas Zimmermann
Moving vc4's mmap code from vc4_mmap() into a GEM object function allows for the use drm_gem_mmap() and drm_gem_prime_mmap(). The content of vc4_drm_fpos can then be generated by DEFINE_DRM_GEM_FOPS(). The actual mmap implementation is just a check if the BO is a validated shader plus the default

[PATCH 2/3] drm/vc4: Make several BO functions static

2021-01-08 Thread Thomas Zimmermann
Rearrange the code to make BO functions static. This will also help with streamlining the BO's mmap implementation. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vc4/vc4_bo.c | 34 +- drivers/gpu/drm/vc4/vc4_drv.h | 2 -- 2 files changed, 17 insertions(+)

[PATCH 0/3] drm/vc4: Streamline the vmap and mmap code

2021-01-08 Thread Thomas Zimmermann
Daniel recently pointed out that vc4 has test in it's vmap code that cannot really fail. [1] I took the opportunity to cleanup vc'4 vmap and mmap implementations. The patches got smoke-tested by running fbdev and Xorg on an RPi3. [1] https://lore.kernel.org/dri-devel/20201211094000.GK401619@phen

Re: [PATCH v3 01/12] drm: Add dummy page per device or GEM object

2021-01-08 Thread Andrey Grodzovsky
Hey Christian, just a ping. Andrey On 1/7/21 11:37 AM, Andrey Grodzovsky wrote: On 1/7/21 11:30 AM, Daniel Vetter wrote: On Thu, Jan 07, 2021 at 11:26:52AM -0500, Andrey Grodzovsky wrote: On 1/7/21 11:21 AM, Daniel Vetter wrote: On Tue, Jan 05, 2021 at 04:04:16PM -0500, Andrey Grodzovsky wr

Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool

2021-01-08 Thread Daniel Vetter
On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote: > Am 07.01.21 um 19:07 schrieb Daniel Vetter: > > On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote: > > > Drivers are not supposed to init the page pool directly any more. > > > > > > Signed-off-by: Christian König >

Re: [PATCH v3 01/12] drm: Add dummy page per device or GEM object

2021-01-08 Thread Christian König
Am 08.01.21 um 15:26 schrieb Andrey Grodzovsky: Hey Christian, just a ping. Was there any question for me here? As far as I can see the best approach would still be to fill the VMA with a single dummy page and avoid pointers in the GEM object. Christian. Andrey On 1/7/21 11:37 AM, Andre

Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool

2021-01-08 Thread Christian König
Am 08.01.21 um 15:31 schrieb Daniel Vetter: On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote: Am 07.01.21 um 19:07 schrieb Daniel Vetter: On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote: Drivers are not supposed to init the page pool directly any more. Signed-of

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-08 Thread Daniel Vetter
On Thu, Jan 07, 2021 at 11:25:41AM -0500, Felix Kuehling wrote: > Am 2021-01-07 um 4:23 a.m. schrieb Daniel Vetter: > > On Wed, Jan 06, 2021 at 10:00:52PM -0500, Felix Kuehling wrote: > >> This is the first version of our HMM based shared virtual memory manager > >> for KFD. There are still a numbe

Re: [PATCH 0/3] Revert "drm/amd/display: Expose new CRC window property" and changes associated with this commit

2021-01-08 Thread Daniel Vetter
On Thu, Jan 07, 2021 at 03:53:18PM -0500, Rodrigo Siqueira wrote: > Hi, > > A couple of weeks ago, Daniel highlighted [1] some issue related to a > patch entitle "drm/amd/display: Expose new CRC window property". After > discussion, we realize that we can revert that patch because we will > need

Re: [PATCH] drm/modes: add non-OF stub for of_get_drm_display_mode

2021-01-08 Thread Daniel Vetter
On Fri, Jan 08, 2021 at 11:13:43AM +0100, Philipp Zabel wrote: > If CONFIG_OF is disabled, of_get_drm_display_mode is not compiled in, > and drivers using it fail to build: > > ld: drivers/gpu/drm/imx/parallel-display.o: in function > `imx_pd_connector_get_modes': > parallel-display.c:(.text+

Re: [PATCH] drm/hisilicon: Delete the empty function mode_valid

2021-01-08 Thread Daniel Vetter
On Fri, Jan 08, 2021 at 06:41:05PM +0800, Tian Tao wrote: > Based on the drm_connector_mode_valid, if the hibmc implementation > of mode_valid only returns MODE_OK, then we can not implement the s/can not/need not/ > mode_valid function. > > Signed-off-by: Tian Tao Reviewed-by: Daniel Vetter

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-08 Thread Christian König
Am 08.01.21 um 15:40 schrieb Daniel Vetter: On Thu, Jan 07, 2021 at 11:25:41AM -0500, Felix Kuehling wrote: Am 2021-01-07 um 4:23 a.m. schrieb Daniel Vetter: On Wed, Jan 06, 2021 at 10:00:52PM -0500, Felix Kuehling wrote: This is the first version of our HMM based shared virtual memory manager

Re: [PATCH v3 01/12] drm: Add dummy page per device or GEM object

2021-01-08 Thread Andrey Grodzovsky
Daniel had some objections to this (see bellow) and so I guess I need you both to agree on the approach before I proceed. Andrey On 1/8/21 9:33 AM, Christian König wrote: Am 08.01.21 um 15:26 schrieb Andrey Grodzovsky: Hey Christian, just a ping. Was there any question for me here? As far

Re: [PATCH v3 01/12] drm: Add dummy page per device or GEM object

2021-01-08 Thread Christian König
Mhm, I'm not aware of any let over pointer between TTM and GEM and we worked quite hard on reducing the size of the amdgpu_bo, so another extra pointer just for that corner case would suck quite a bit. Christian. Am 08.01.21 um 15:46 schrieb Andrey Grodzovsky: Daniel had some objections to thi

Re: [PATCH v5 1/4] drm/i915: Keep track of pwm-related backlight hooks separately

2021-01-08 Thread Jani Nikula
On Thu, 07 Jan 2021, Lyude Paul wrote: > @@ -1628,37 +1633,32 @@ static int lpt_setup_backlight(struct intel_connector > *connector, enum pipe unus > panel->backlight.active_low_pwm = pch_ctl1 & BLM_PCH_POLARITY; > > pch_ctl2 = intel_de_read(dev_priv, BLC_PWM_PCH_CTL2); > - pane

Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool

2021-01-08 Thread Daniel Vetter
On Fri, Jan 8, 2021 at 3:36 PM Christian König wrote: > > Am 08.01.21 um 15:31 schrieb Daniel Vetter: > > On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote: > >> Am 07.01.21 um 19:07 schrieb Daniel Vetter: > >>> On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote: >

Re: [PATCH v2 2/2] arm64: dts: mt8192: Add node for the Mali GPU

2021-01-08 Thread Steven Price
On 05/01/2021 05:36, Nick Fan wrote: Add a basic GPU node for mt8192. Signed-off-by: Nick Fan --- This patch depends on Mediatek power and regulator support. Listed as following. [1]https://lore.kernel.org/patchwork/patch/1336293/ [2]https://patchwork.kernel.org/project/linux-mediatek/list/?s

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-08 Thread Felix Kuehling
Am 2021-01-08 um 9:40 a.m. schrieb Daniel Vetter: > On Thu, Jan 07, 2021 at 11:25:41AM -0500, Felix Kuehling wrote: >> Am 2021-01-07 um 4:23 a.m. schrieb Daniel Vetter: >>> On Wed, Jan 06, 2021 at 10:00:52PM -0500, Felix Kuehling wrote: This is the first version of our HMM based shared virtual

[PULL] drm-fixes

2021-01-08 Thread Daniel Vetter
Hi Linus, Looks like people are back from the break, usual small pile of fixes all over. Next week Dave should be back. Only thing pending I'm aware of is a "this shouldn't have become uapi" reverts for amdgpu, but they're already on the list and not that important really so can wait another week.

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-08 Thread Daniel Vetter
On Fri, Jan 8, 2021 at 4:58 PM Felix Kuehling wrote: > > Am 2021-01-08 um 9:40 a.m. schrieb Daniel Vetter: > > On Thu, Jan 07, 2021 at 11:25:41AM -0500, Felix Kuehling wrote: > >> Am 2021-01-07 um 4:23 a.m. schrieb Daniel Vetter: > >>> On Wed, Jan 06, 2021 at 10:00:52PM -0500, Felix Kuehling wrote

RE: [PATCH v4 01/13] dma-buf: Add vmap_local and vnumap_local operations

2021-01-08 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Thomas Zimmermann >Sent: Friday, January 8, 2021 4:43 AM >To: sumit.sem...@linaro.org; christian.koe...@amd.com; >airl...@redhat.com; dan...@ffwll.ch; maarten.lankho...@linux.intel.com; >mrip...@kernel.org; kra...@redhat.com; hdego...@redh

[PATCH] drm/amdkfd: Fix out-of-bounds read in kdf_create_vcrat_image_cpu()

2021-01-08 Thread Jeremy Cline
KASAN reported a slab-out-of-bounds read of size 1 in kdf_create_vcrat_image_cpu(). This occurs when, for example, when on an x86_64 with a single NUMA node because kfd_fill_iolink_info_for_cpu() is a no-op, but afterwards the sub_type_hdr->length, which is out-of-bounds, is read and multiplied by

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-08 Thread Felix Kuehling
Am 2021-01-08 um 11:06 a.m. schrieb Daniel Vetter: > On Fri, Jan 8, 2021 at 4:58 PM Felix Kuehling wrote: >> Am 2021-01-08 um 9:40 a.m. schrieb Daniel Vetter: >>> On Thu, Jan 07, 2021 at 11:25:41AM -0500, Felix Kuehling wrote: Am 2021-01-07 um 4:23 a.m. schrieb Daniel Vetter: > On Wed, J

Re: [Freedreno] [PATCH] drm/msm: Only enable A6xx LLCC code on A6xx

2021-01-08 Thread Rob Clark
On Fri, Jan 8, 2021 at 6:05 AM Sai Prakash Ranjan wrote: > > On 2021-01-08 19:09, Konrad Dybcio wrote: > >> Konrad, can you please test this below change without your change? > > > > This brings no difference, a BUG still happens. We're still calling > > to_a6xx_gpu on ANY device that's probed! To

Re: [PATCH v3 01/12] drm: Add dummy page per device or GEM object

2021-01-08 Thread Grodzovsky, Andrey
Ok then, I guess I will proceed with the dummy pages list implementation then. Andrey From: Koenig, Christian Sent: 08 January 2021 09:52 To: Grodzovsky, Andrey ; Daniel Vetter Cc: amd-...@lists.freedesktop.org ; dri-devel@lists.freedesktop.org ; daniel.vet..

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-08 Thread Daniel Vetter
On Fri, Jan 8, 2021 at 5:36 PM Felix Kuehling wrote: > > > Am 2021-01-08 um 11:06 a.m. schrieb Daniel Vetter: > > On Fri, Jan 8, 2021 at 4:58 PM Felix Kuehling > > wrote: > >> Am 2021-01-08 um 9:40 a.m. schrieb Daniel Vetter: > >>> On Thu, Jan 07, 2021 at 11:25:41AM -0500, Felix Kuehling wrote:

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-08 Thread Felix Kuehling
Am 2021-01-08 um 11:53 a.m. schrieb Daniel Vetter: > On Fri, Jan 8, 2021 at 5:36 PM Felix Kuehling wrote: >> >> Am 2021-01-08 um 11:06 a.m. schrieb Daniel Vetter: >>> On Fri, Jan 8, 2021 at 4:58 PM Felix Kuehling >>> wrote: Am 2021-01-08 um 9:40 a.m. schrieb Daniel Vetter: > On Thu, Ja

[PATCH v4 1/2] drm/msm: Add speed-bin support to a618 gpu

2021-01-08 Thread Akhil P Oommen
Some GPUs support different max frequencies depending on the platform. To identify the correct variant, we should check the gpu speedbin fuse value. Add support for this speedbin detection to a6xx family along with the required fuse details for a618 gpu. Signed-off-by: Akhil P Oommen --- Changes

[PATCH v4 2/2] arm: dts: sc7180: Add support for gpu fuse

2021-01-08 Thread Akhil P Oommen
Add support for gpu fuse to help identify the supported opps. Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 6678

[GIT PULL] drm/imx: compile test fixes

2021-01-08 Thread Philipp Zabel
Hi Dave, Daniel, this PR includes two fixes for x86_64 COMPILE_TEST builds with CONFIG_OF disabled. The following changes since commit 16da8e9a7767ac77720f49bfa870def61a250cda: drm/imx: ipuv3-crtc: use drm managed resources (2021-01-04 12:59:34 +0100) are available in the Git repository at:

Re: [PATCH] drm/ttm: Remove pinned bos from LRU in ttm_bo_move_to_lru_tail() v2

2021-01-08 Thread Mike Lothian
Hi This breaks things for me on my Prime system https://gitlab.freedesktop.org/drm/misc/-/issues/23 Cheers Mike ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[drm-intel:topic/dp-hdmi-2.1-pcon 15/15] drivers/gpu/drm/i915/display/intel_dp.c:6909:42: error: use of logical '||' with constant operand

2021-01-08 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm-intel topic/dp-hdmi-2.1-pcon head: 522508b665df3bbfdf40381d4e61777844b1703f commit: 522508b665df3bbfdf40381d4e61777844b1703f [15/15] drm/i915/display: Let PCON convert from RGB to YCbCr if it can config: x86_64-randconfig-r011-20210108 (attached as

Re: [PATCH] MAINTAINERS: update radeon/amdgpu/amdkfd git trees

2021-01-08 Thread Alex Deucher
On Tue, Jan 5, 2021 at 3:15 PM Alex Deucher wrote: > > FDO is out of space, so move to gitlab. > > Signed-off-by: Alex Deucher Ping? Any objections? Alex > --- > MAINTAINERS | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index eb18459

Re: [PATCH RESEND v2 1/2] dma-fence: allow signaling drivers to set fence timestamp

2021-01-08 Thread John Stultz
On Thu, Jan 7, 2021 at 12:53 AM Veera Sundaram Sankaran wrote: > > Some drivers have hardware capability to get the precise timestamp of > certain events based on which the fences are triggered. This allows it to > set accurate timestamp factoring out any software and IRQ latencies. Add > a timest

Re: [PATCHv1] video: omapfb2: Make standard and custom DSI command mode panel driver mutually exclusive

2021-01-08 Thread Sam Ravnborg
Hi Sebatian, On Fri, Jan 08, 2021 at 12:24:41PM +0100, Sebastian Reichel wrote: > Standard DRM panel driver for DSI command mode panel used by omapfb2 is also > available now. Just like the other panels its module name clashes with the > module from drivers/video/fbdev/omap2/omapfb/displays, part

Re: [PATCH RESEND v2 2/2] drm/drm_vblank: set the dma-fence timestamp during send_vblank_event

2021-01-08 Thread John Stultz
On Thu, Jan 7, 2021 at 12:54 AM Veera Sundaram Sankaran wrote: > > The explicit out-fences in crtc are signaled as part of vblank event, > indicating all framebuffers present on the Atomic Commit request are > scanned out on the screen. Though the fence signal and the vblank event > notification h

[PATCH 00/40] [Set 11] Rid W=1 warnings from GPU

2021-01-08 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. 300 out of 5000 left! Lee Jones (40): drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc drm/nouveau/dispnv50/disp: Remove u

[PATCH 01/40] drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function parameter or member 'init' not described in 'init_reserved' drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:611: warning: Function parameter or member 'init' not described in

[PATCH 02/40] drm/nouveau/dispnv50/disp: Remove unused variable 'ret'

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv50/disp.c:1381:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org Signed

[PATCH 03/40] drm/msm/dp/dp_display: Remove unused variable 'hpd'

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/dp/dp_display.c: In function ‘dp_display_usbpd_attention_cb’: drivers/gpu/drm/msm/dp/dp_display.c:496:19: warning: variable ‘hpd’ set but not used [-Wunused-but-set-variable] Cc: Rob Clark Cc: Sean Paul Cc: David Airlie C

[PATCH 04/40] drm/amd/amdgpu/amdgpu_ih: Update 'amdgpu_ih_decode_iv_helper()'s function header

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c:220: warning: Function parameter or member 'ih' not described in 'amdgpu_ih_decode_iv_helper' drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c:220: warning: Function parameter or member 'entry' not described in 'amdg

[PATCH 05/40] drm/amd/amdgpu/vega20_ih: Add missing descriptions for 'ih' and fix spelling error

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/vega20_ih.c:378: warning: Function parameter or member 'ih' not described in 'vega20_ih_get_wptr' drivers/gpu/drm/amd/amdgpu/vega20_ih.c:421: warning: Function parameter or member 'ih' not described in 'vega20_ih_irq_r

[PATCH 06/40] drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0: Provide description of 'call_back_func'

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/process_pptables_v1_0.c:1371: warning: Function parameter or member 'call_back_func' not described in 'get_powerplay_table_entry_v1_0' Cc: Evan Quan Cc: Alex Deucher Cc: "Christian König" Cc: D

[PATCH 08/40] drm/amd/pm/powerplay/hwmgr/vega12_hwmgr: Fix legacy function header formatting

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega12_hwmgr.c:728: warning: Function parameter or member 'hwmgr' not described in 'vega12_init_smc_table' Cc: Evan Quan Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vette

[PATCH 12/40] drm/amd/pm/powerplay/hwmgr/vega10_hwmgr: Fix a bunch of kernel-doc formatting issues

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:5474:5: warning: no previous prototype for ‘vega10_hwmgr_init’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:551: warning: Function paramete

[PATCH 13/40] drm/amd/display/dc/basics/conversion: Demote obvious kernel-doc abuse

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/basics/conversion.c:86: warning: Function parameter or member 'matrix' not described in 'convert_float_matrix' drivers/gpu/drm/amd/amdgpu/../display/dc/basics/conversion.c:86: warning: Function parameter

[PATCH 14/40] drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs: Demote non-kernel-doc comment blocks

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:699: warning: Function parameter or member 'm' not described in 'dmub_tracebuffer_show' drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:699: warning: Functi

[PATCH 16/40] drm/amd/display/dc/bios/command_table_helper2: Fix legacy formatting problems

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table_helper2.c:145: warning: Function parameter or member 't' not described in 'dal_cmd_table_helper_transmitter_bp_to_atom2' Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian

[PATCH 15/40] drm/amd/display/dc/bios/command_table_helper: Fix kernel-doc formatting

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table_helper.c:131: warning: Function parameter or member 't' not described in 'dal_cmd_table_helper_transmitter_bp_to_atom' Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian K

[PATCH 17/40] drm/amd/display/dc/bios/bios_parser: Make local functions static

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2588:16: warning: no previous prototype for ‘update_slot_layout_info’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2692:16: warning: no previous pr

[PATCH 18/40] drm/amd/display/dc/bios/bios_parser: Fix a whole bunch of legacy doc formatting

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2588:16: warning: no previous prototype for ‘update_slot_layout_info’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2692:16: warning: no previous pr

[PATCH 07/40] drm/amd/pm/powerplay/hwmgr/ppatomctrl: Fix documentation for 'mpll_param'

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomctrl.c:290: warning: Function parameter or member 'mpll_param' not described in 'atomctrl_get_memory_pll_dividers_si' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomctrl.c:290: warni

[PATCH 23/40] drm/amd/display/dc/dce/dce_audio: Make function invoked by reference static

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_audio.c:871:6: warning: no previous prototype for ‘dce60_aud_wall_dto_setup’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Da

[PATCH 10/40] drm/amd/pm/powerplay/hwmgr/smu7_hwmgr: Fix formatting and spelling issues

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_hwmgr.c:242: warning: Function parameter or member 'hwmgr' not described in 'smu7_enable_smc_voltage_controller' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_hwmgr.c:4508: warning:

[PATCH 09/40] drm/amd/pm/powerplay/hwmgr/vega20_hwmgr: Fix legacy function header formatting

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_hwmgr.c:781: warning: Function parameter or member 'hwmgr' not described in 'vega20_init_smc_table' Cc: Evan Quan Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vette

[PATCH 25/40] drm/amd/display/dc/dce/dce_link_encoder: Make functions invoked by reference static

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_link_encoder.c:1200:6: warning: no previous prototype for ‘dce60_link_encoder_enable_dp_output’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_link_encoder.c:1239:6: warn

[PATCH 26/40] drm/amd/display/dc/dce/dce_clock_source: Fix formatting/spelling of worthy function headers

2021-01-08 Thread Lee Jones
Demote the one that provides no param descriptions. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:142: warning: Function parameter or member 'calc_pll_cs' not described in 'calculate_fb_and_fractional_fb_divider' drivers/gpu/d

[PATCH 11/40] drm/amd/pm/powerplay/hwmgr/hwmgr: Move prototype into shared header

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:5474:5: warning: no previous prototype for ‘vega10_hwmgr_init’ [-Wmissing-prototypes] Cc: Evan Quan Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc:

[PATCH 31/40] drm/amd/display/dc/dce/dce_opp: Make local functions and ones invoked by reference static

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:427:6: warning: no previous prototype for ‘dce60_opp_set_clamping’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:548:6: warning: no previous prototype for ‘dc

[PATCH 29/40] drm/amd/display/dc/dce/dce_dmcu: Staticify local function call 'dce_dmcu_load_iram'

2021-01-08 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.c:74:6: warning: no previous prototype for ‘dce_dmcu_load_iram’ [-Wmissing-prototypes] In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.c:31: Cc: Harry Wentland C

[PATCH 19/40] drm/amd/display/dc/bios/command_table: Remove unused variable

2021-01-08 Thread Lee Jones
None of the surrounding code was removed just in case even a small fraction of it was functional. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c: In function ‘adjust_display_pll_v2’: drivers/gpu/drm/amd/amdgpu/../display/dc/bios/c

[PATCH 30/40] drm/amd/display/dc/dce/dce_dmcu: Move 'abm_gain_stepsize' to only source file it's used in

2021-01-08 Thread Lee Jones
And only declare it if it's to be used. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning: ‘abm_gain_stepsize’ defined but not used [-Wunused-const-variable=] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23:

  1   2   >