Re: [PATCH v2] drm/hisilicon: Add load and unload callback functions

Hi, and a happy new year. Am 24.12.20 um 09:45 schrieb Tian Tao: Add the callback functions of drm_driver structure member functions load and unload, no need to call load in the hibmc_pci_probe function and unload in the hibmc_pci_remove function. The load and unload callbacks are left over f

Re: [PULL] drm-misc-next-fixes

Hi, it looks like this PR has not been merged yet. Best regard Thomas Am 22.12.20 um 20:13 schrieb Thomas Zimmermann: Hi Dave and Daniel, here's this week's PR for drm-misc-next-fixes. Best regards Thomas drm-misc-next-fixes-2020-12-22: Short summary of fixes pull: * dma-buf: Include fo

[PATCH 12/31] mmc: sdhci-msm: convert to use devm_pm_opp_* API

Use devm_pm_opp_* API to simplify code, and remove opp_table from sdhci_msm_host. Signed-off-by: Yangtao Li --- drivers/mmc/host/sdhci-msm.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index

Re: [PATCH 07/31] serial: qcom_geni_serial: convert to use devm_pm_opp_* API

Dropped lots of people from cc list On 04-01-21, 12:49, Viresh Kumar wrote: > On 01-01-21, 16:54, Yangtao Li wrote: > > Use devm_pm_opp_* API to simplify code, and we don't need > > to make opp_table glabal. > > > > Let's remove opp_table from geni_se later. > > > > Signed-off-by: Yangtao Li >

[PATCH 16/31] drm/msm: convert to use devm_pm_opp_* API and remove dp_ctrl_put

1. Use devm_pm_opp_* to simplif code and avoid mem leak. 2. Remove opp_table from dpu_kms, dp_ctrl_private and msm_dsi_host, since it does not need a global scope. 3. Remove dp_ctrl_put. Signed-off-by: Yangtao Li --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/a6x

[PATCH 01/31] opp: Add devres wrapper for dev_pm_opp_set_clkname and dev_pm_opp_put_clkname

Add devres wrapper for dev_pm_opp_set_clkname() and dev_pm_opp_put_clkname() to simplify driver code. Signed-off-by: Yangtao Li --- drivers/opp/core.c | 47 ++ include/linux/pm_opp.h | 9 2 files changed, 56 insertions(+) diff --git a/driver

[PATCH 03/31] opp: Add devres wrapper for dev_pm_opp_set_supported_hw

Add devres wrapper for dev_pm_opp_set_supported_hw() to simplify driver code. Signed-off-by: Yangtao Li --- drivers/opp/core.c | 38 ++ include/linux/pm_opp.h | 8 2 files changed, 46 insertions(+) diff --git a/drivers/opp/core.c b/drivers/opp/c

[PATCH 00/31] Introduce devm_pm_opp_* API

Hi, This patchset add devm_pm_opp_set_clkname, devm_pm_opp_put_clkname, devm_pm_opp_set_regulators, devm_pm_opp_put_regulators, devm_pm_opp_set_supported_hw, devm_pm_opp_of_add_table and devm_pm_opp_register_notifier. Yangtao Li (31): opp: Add devres wrapper for dev_pm_opp_set_clkname and d

Re: [PATCH 00/31] Introduce devm_pm_opp_* API

HI, On Sun, Jan 3, 2021 at 8:52 PM Dmitry Osipenko wrote: > > 01.01.2021 19:54, Yangtao Li пишет: > > Hi, > > > > This patchset add devm_pm_opp_set_clkname, devm_pm_opp_put_clkname, > > devm_pm_opp_set_regulators, devm_pm_opp_put_regulators, > > devm_pm_opp_set_supported_hw, devm_pm_opp_of_add_ta

[PATCH 06/31] serial: qcom_geni_serial: fix potential mem leak in qcom_geni_serial_probe()

We should use dev_pm_opp_put_clkname() to free opp table each time dev_pm_opp_of_add_table() got error. Signed-off-by: Yangtao Li --- drivers/tty/serial/qcom_geni_serial.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/qcom_geni_serial.c b/driv

[PATCH 23/31] memory: samsung: exynos5422-dmc: convert to use devm_pm_opp_* API

Use devm_pm_opp_* API to simplify code. Signed-off-by: Yangtao Li --- drivers/memory/samsung/exynos5422-dmc.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c index 62a836

Re: amdgpu does not support 3840x2160@30Hz on kaveri apu

Cool, thanks! Il Dom 3 Gen 2021, 12:06 Mike Lothian ha scritto: > Hi > > You're probably best reporting the bug here: > > https://gitlab.freedesktop.org/drm/amd/-/issues > > Attach the output of dmesg from both Radeon and AMDGPU and the compositor > / Wayland logs (as you're not using X) > > Che

Re: [PATCH 31/31] PM / devfreq: convert to devm_pm_opp_register_notifier and remove unused API

On 03-01-21, 03:57, Yangtao Li wrote: > Use devm_pm_opp_* API to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/devfreq/devfreq.c | 66 +-- > include/linux/devfreq.h | 23 -- > 2 files changed, 1 insertion(+), 88 deletions(-) Remo

[PATCH 08/31] spi: spi-qcom-qspi: fix potential mem leak in spi_geni_probe()

We should use dev_pm_opp_put_clkname() to free opp table each time dev_pm_opp_of_add_table() got error. Signed-off-by: Yangtao Li --- drivers/spi/spi-geni-qcom.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom

Re: [PATCH v3, 1/8] soc: mediatek: mmsys: create mmsys folder

On Thu, 2020-12-31 at 09:21 +0800, Nicolas Boichat wrote: > On Mon, Dec 28, 2020 at 4:38 PM Yongqiang Niu > wrote: > > > > the mmsys will more and more complicated after support > > more and more SoCs, add an independent folder will be > > more clear > > > > Signed-off-by: Yongqiang Niu > > --- >

[PATCH] drm/mipi-dbi: Switch to new kerneldoc syntax for named variable macro argument

The syntax without dots is available since commit 43756e347f21 ("scripts/kernel-doc: Add support for named variable macro arguments"). The same HTML output is produced with and without this patch. Signed-off-by: Jonathan Neuschäfer --- include/drm/drm_mipi_dbi.h | 2 +- 1 file changed, 1 insert

[PATCH 26/31] PM / devfreq: tegra30: convert to use devm_pm_opp_* API

Use devm_pm_opp_* API to simplify code, and remove opp_table from tegra_devfreq. Signed-off-by: Yangtao Li --- drivers/devfreq/tegra30-devfreq.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30

[PATCH 15/31] drm/msm: fix potential mem leak

We should use dev_pm_opp_put_clkname() to free opp table each time dev_pm_opp_of_add_table() got error. Signed-off-by: Yangtao Li --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 10 ++ drivers/gpu/drm/msm/dsi/dsi_host.c | 8 +--- 2 files changed, 11 insertions(+), 7 deletions(-)

[PATCH 07/31] serial: qcom_geni_serial: convert to use devm_pm_opp_* API

Use devm_pm_opp_* API to simplify code, and we don't need to make opp_table glabal. Let's remove opp_table from geni_se later. Signed-off-by: Yangtao Li --- drivers/tty/serial/qcom_geni_serial.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers

[PATCH 14/31] spi: spi-qcom-qspi: convert to use devm_pm_opp_* API

Use devm_pm_opp_* API to simplify code, and remove opp_table from qcom_qspi. Signed-off-by: Yangtao Li --- drivers/spi/spi-qcom-qspi.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c index 915ae115d8c

[PATCH 05/31] opp: Add devres wrapper for dev_pm_opp_register_notifier

Add devres wrapper for dev_pm_opp_register_notifier() to simplify driver code. Signed-off-by: Yangtao Li --- drivers/opp/core.c | 38 ++ include/linux/pm_opp.h | 6 ++ 2 files changed, 44 insertions(+) diff --git a/drivers/opp/core.c b/drivers/opp/co

[PATCH 09/31] spi: spi-qcom-qspi: fix potential mem leak in spi_geni_probe()

Use devm_pm_opp_* API to simplify code, and we don't need to make opp_table glabal. Let's remove opp_table from geni_se later. Signed-off-by: Yangtao Li --- drivers/spi/spi-geni-qcom.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/spi/spi-geni-qcom.

[PATCH 20/31] media: venus: fix error check in core_get_v4()

Don't call dev_pm_opp_put_clkname() when got invalid OPP table in device tree, since we do this in core_put_v4(). Signed-off-by: Yangtao Li --- drivers/media/platform/qcom/venus/pm_helpers.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/p

[PATCH 31/31] PM / devfreq: convert to devm_pm_opp_register_notifier and remove unused API

Use devm_pm_opp_* API to simplify code. Signed-off-by: Yangtao Li --- drivers/devfreq/devfreq.c | 66 +-- include/linux/devfreq.h | 23 -- 2 files changed, 1 insertion(+), 88 deletions(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq

amdgpu does not support 3840x2160@30Hz on kaveri apu

hello, I'd like to report this issue that I am having since I updated my display (samsung U28E590). The amdgpu does not support the native resolution of my new monitor, which is 3840x2160*.* Using a HDMI or DVI connection (I tried both, same results), the maximum supported refresh is 30Hz, so I'm s

[PATCH 11/31] mmc: sdhci-msm: fix potential mem leak in sdhci_msm_probe()

We should use dev_pm_opp_put_clkname() to free opp table each time dev_pm_opp_of_add_table() got error. Signed-off-by: Yangtao Li --- drivers/mmc/host/sdhci-msm.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-

[PATCH 30/31] PM / devfreq: exynos: convert to use devm_pm_opp_* API

Use devm_pm_opp_* API to simplify code, and remove opp_table from exynos_bus. Signed-off-by: Yangtao Li --- drivers/devfreq/exynos-bus.c | 42 1 file changed, 9 insertions(+), 33 deletions(-) diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos

Re: [PATCH 1/2] drm/msm: Call msm_init_vram before binding the gpu

Tested these patches on Samsung Galaxy S5 along with other patches that add panel driver and enable GPU support on this device. Tested-by: Alexey Minnekhanov On 12/30/20 6:29 PM, Iskren Chernev wrote: From: Craig Tatlor vram.size is needed when binding a gpu without an iommu and is defined

[PATCH 10/31] qcom-geni-se: remove opp_table

opp_table isn't used anymore, remove it. Signed-off-by: Yangtao Li --- include/linux/qcom-geni-se.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/qcom-geni-se.h b/include/linux/qcom-geni-se.h index ec2ad4b0fe14..cddef864a760 100644 --- a/include/linux/qcom-geni-se.h +++ b/in

[PATCH 17/31] drm/lima: convert to use devm_pm_opp_* API

Use devm_pm_opp_* API to simplify code, and remove opp_table from lima_devfreq. Signed-off-by: Yangtao Li --- drivers/gpu/drm/lima/lima_devfreq.c | 40 - drivers/gpu/drm/lima/lima_devfreq.h | 2 -- 2 files changed, 10 insertions(+), 32 deletions(-) diff --git a/driv

Re: [PATCH 00/31] Introduce devm_pm_opp_* API

On 01-01-21, 16:54, Yangtao Li wrote: > Hi, > > This patchset add devm_pm_opp_set_clkname, devm_pm_opp_put_clkname, > devm_pm_opp_set_regulators, devm_pm_opp_put_regulators, > devm_pm_opp_set_supported_hw, devm_pm_opp_of_add_table and > devm_pm_opp_register_notifier. You can't put so many names i

Re: [PATCH 00/31] Introduce devm_pm_opp_* API

01.01.2021 19:54, Yangtao Li пишет: > Hi, > > This patchset add devm_pm_opp_set_clkname, devm_pm_opp_put_clkname, > devm_pm_opp_set_regulators, devm_pm_opp_put_regulators, > devm_pm_opp_set_supported_hw, devm_pm_opp_of_add_table and > devm_pm_opp_register_notifier. > > Yangtao Li (31): > opp: A

[PATCH 04/31] opp: Add devres wrapper for dev_pm_opp_of_add_table

Add devres wrapper for dev_pm_opp_of_add_table() to simplify driver code. Signed-off-by: Yangtao Li --- drivers/opp/of.c | 36 include/linux/pm_opp.h | 6 ++ 2 files changed, 42 insertions(+) diff --git a/drivers/opp/of.c b/drivers/opp/of.c index

[PATCH 13/31] spi: spi-qcom-qspi: fix potential mem leak in qcom_qspi_probe()

We should use dev_pm_opp_put_clkname() to free opp table each time dev_pm_opp_of_add_table() got error. Signed-off-by: Yangtao Li --- drivers/spi/spi-qcom-qspi.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qsp

[PATCH 21/31] media: venus: convert to use devm_pm_opp_* API

Use devm_pm_opp_* API to simplify code. Signed-off-by: Yangtao Li --- .../media/platform/qcom/venus/pm_helpers.c| 21 --- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_help

[PATCH v1 2/2] arm64: dts: mt8192: Add node for the Mali GPU

Add a basic GPU node for mt8192. Signed-off-by: Nick Fan --- This patch depends on Mediatek power and regulator support. Listed as following. [1]https://lore.kernel.org/patchwork/patch/1336293/ [2]https://patchwork.kernel.org/project/linux-mediatek/list/?series=374013 [3]https://lore.kernel.org

Re: [PATCH 26/31] PM / devfreq: tegra30: convert to use devm_pm_opp_* API

On 03-01-21, 03:54, Yangtao Li wrote: > Use devm_pm_opp_* API to simplify code, and remove opp_table > from tegra_devfreq. Patches starting this one didn't appear in the same thread and it is a nightmare to apply these now. Please send everything properly next time. -- viresh ___

[PATCH] drm/loongson: Add DDC support for loongson display controller

Add GPIO and I2C driver to detect connector and fetch EDID via DDC. Signed-off-by: Hao Sun --- drivers/gpu/drm/loongson/Makefile | 3 +- drivers/gpu/drm/loongson/loongson_connector.c | 121 +++- drivers/gpu/drm/loongson/loongson_drv.c | 16 +- drivers/gpu/drm/loongson/lo

Re: [PATCH 01/31] opp: Add devres wrapper for dev_pm_opp_set_clkname and dev_pm_opp_put_clkname

On 01-01-21, 16:54, Yangtao Li wrote: > +/** > + * devm_pm_opp_put_clkname() - Releases resources blocked for clk. > + * @dev: Device for which we do this operation. > + * @opp_table: OPP table returned from devm_pm_opp_set_clkname(). > + */ > +void devm_pm_opp_put_clkname(struct device *dev, struc

Re: [PATCH] drm/msm: Fix MSM_INFO_GET_IOVA with carveout

Kind reminder that MSM8974, 8994, 8992 and friends are held back by the lack of IOMMU support upstream. There has been an attempt back in 2014(!) [1], but it was either overlooked or forgotten about ever since. I'd be more than happy to see someone look into this, as I have some other bits (almo

Re: [PATCH 2/2] drm/panel: simple: add samsung,s6e3fa2 panel

Tested this on Samsung Galaxy S5 along with other patches that enable GPU support on this device. Tested-by: Alexey Minnekhanov On 12/30/20 6:17 PM, Iskren Chernev wrote: From: Samuel Pascua This panel is used on the Samsung Galaxy S5 (klte). Signed-off-by: Samuel Pascua --- drivers/gpu

[PATCH v1 1/2] dt-bindings: Convert Arm Mali Valhall GPU to DT schema

Convert the Arm Valhall GPU binding to DT schema format. Define a compatible string for the Mali Valhall GPU for Mediatek's SoC platform. Signed-off-by: Nick Fan --- .../bindings/gpu/arm,mali-valhall.yaml| 252 ++ 1 file changed, 252 insertions(+) create mode 100644 Doc

Re: [PATCH] drm/msm: Fix MSM_INFO_GET_IOVA with carveout

I've tested all recent GPU bring-up patches on msm8974pro samsung-klte (a330v2) and with this patch everything is OK. But without this we're getting the following in dmesg while running kmscube (which is rendering nothing except black screen): [ 94.969272] msm fd90.mdss: [drm:hangcheck_h

[PATCH 28/31] PM / devfreq: imx8m-ddrc: convert to use devm_pm_opp_* API

Use devm_pm_opp_* API to simplify code. Signed-off-by: Yangtao Li --- drivers/devfreq/imx8m-ddrc.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c index bc82d3653bff..9383d6e5538b 100644 --- a/driver

[PATCH 27/31] PM / devfreq: rk3399_dmc: convert to use devm_pm_opp_* API

Use devm_pm_opp_* API to simplify code. Since devres release can guarantee the order, let's remove devm_devfreq_unregister_opp_notifier(). Signed-off-by: Yangtao Li --- drivers/devfreq/rk3399_dmc.c | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/driver

Re: [PATCH 00/31] Introduce devm_pm_opp_* API

03.01.2021 17:30, Frank Lee пишет: > HI, > > On Sun, Jan 3, 2021 at 8:52 PM Dmitry Osipenko wrote: >> >> 01.01.2021 19:54, Yangtao Li пишет: >>> Hi, >>> >>> This patchset add devm_pm_opp_set_clkname, devm_pm_opp_put_clkname, >>> devm_pm_opp_set_regulators, devm_pm_opp_put_regulators, >>> devm_pm_

[PATCH 18/31] drm/lima: remove unneeded devm_devfreq_remove_device()

There is no need to manually release devm related resources. Signed-off-by: Yangtao Li --- drivers/gpu/drm/lima/lima_devfreq.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/lima/lima_devfreq.c b/drivers/gpu/drm/lima/lima_devfreq.c index d5937cf86504..7690c5c69f9f 10064

Re: [PATCH 05/31] opp: Add devres wrapper for dev_pm_opp_register_notifier

On 01-01-21, 16:54, Yangtao Li wrote: > Add devres wrapper for dev_pm_opp_register_notifier() to simplify driver > code. > > Signed-off-by: Yangtao Li > --- > drivers/opp/core.c | 38 ++ > include/linux/pm_opp.h | 6 ++ > 2 files changed, 44 insertion

[PATCH 19/31] drm/panfrost: convert to use devm_pm_opp_* API

Use devm_pm_opp_* API to simplify code, and remove opp_table from panfrost_devfreq. Signed-off-by: Yangtao Li --- drivers/gpu/drm/panfrost/panfrost_devfreq.c | 34 ++--- drivers/gpu/drm/panfrost/panfrost_devfreq.h | 1 - 2 files changed, 10 insertions(+), 25 deletions(-) diff -

[PATCH 22/31] memory: samsung: exynos5422-dmc: fix return error in exynos5_init_freq_table

We can't always return -EINVAL, let's fix it. Signed-off-by: Yangtao Li --- drivers/memory/samsung/exynos5422-dmc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c index c5ee4121a4d2

[PATCH 24/31] memory: tegra20: convert to use devm_pm_opp_* API

Use devm_pm_opp_* API to simplify code. Signed-off-by: Yangtao Li --- drivers/memory/tegra/tegra20-emc.c | 29 + 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c index 686aaf477d8a.

[PATCH 02/31] opp: Add devres wrapper for dev_pm_opp_set_regulators and dev_pm_opp_put_regulators

Add devres wrapper for dev_pm_opp_set_regulators() dev_pm_opp_put_regulators () to simplify driver code. Signed-off-by: Yangtao Li --- drivers/opp/core.c | 50 ++ include/linux/pm_opp.h | 9 2 files changed, 59 insertions(+) diff --git a/dri

[PATCH] drm/msm: Fix MSM_INFO_GET_IOVA with carveout

The msm_gem_get_iova should be guarded with gpu != NULL and not aspace != NULL, because aspace is NULL when using vram carveout. Fixes: 933415e24bd0d ("drm/msm: Add support for private address space instances") Signed-off-by: Iskren Chernev --- drivers/gpu/drm/msm/msm_drv.c | 3 ++- 1 file cha

Re: [PATCH 06/31] serial: qcom_geni_serial: fix potential mem leak in qcom_geni_serial_probe()

On 01-01-21, 16:54, Yangtao Li wrote: > We should use dev_pm_opp_put_clkname() to free opp table each time > dev_pm_opp_of_add_table() got error. > > Signed-off-by: Yangtao Li > --- > drivers/tty/serial/qcom_geni_serial.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > di

Re: [PATCH v3, 1/8] soc: mediatek: mmsys: create mmsys folder

On Thu, 2020-12-31 at 09:21 +0800, Nicolas Boichat wrote: > On Mon, Dec 28, 2020 at 4:38 PM Yongqiang Niu > wrote: > > > > the mmsys will more and more complicated after support > > more and more SoCs, add an independent folder will be > > more clear > > > > Signed-off-by: Yongqiang Niu > > --- >

Re: [PATCH 00/31] Introduce devm_pm_opp_* API

On 01-01-21, 16:54, Yangtao Li wrote: > Hi, > > This patchset add devm_pm_opp_set_clkname, devm_pm_opp_put_clkname, > devm_pm_opp_set_regulators, devm_pm_opp_put_regulators, > devm_pm_opp_set_supported_hw, devm_pm_opp_of_add_table and > devm_pm_opp_register_notifier. Please also mention next time

[PATCH 29/31] PM / devfreq: imx-bus: convert to use devm_pm_opp_* API

Use devm_pm_opp_* API to simplify code. Signed-off-by: Yangtao Li --- drivers/devfreq/imx-bus.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c index 4f38455ad742..ff26ef049b1b 100644 --- a/drivers/devfreq/

Re: [PATCH 18/31] drm/lima: remove unneeded devm_devfreq_remove_device()

On 01-01-21, 16:54, Yangtao Li wrote: > There is no need to manually release devm related resources. > > Signed-off-by: Yangtao Li > --- > drivers/gpu/drm/lima/lima_devfreq.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/lima/lima_devfreq.c > b/drivers/gpu/drm/li

Re: [PATCH 07/31] serial: qcom_geni_serial: convert to use devm_pm_opp_* API

On 01-01-21, 16:54, Yangtao Li wrote: > Use devm_pm_opp_* API to simplify code, and we don't need > to make opp_table glabal. > > Let's remove opp_table from geni_se later. > > Signed-off-by: Yangtao Li > --- > drivers/tty/serial/qcom_geni_serial.c | 23 +-- > 1 file changed

[PATCH 25/31] memory: tegra30: convert to use devm_pm_opp_* API

Use devm_pm_opp_* API to simplify code. Signed-off-by: Yangtao Li --- drivers/memory/tegra/tegra30-emc.c | 29 + 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegra30-emc.c index 44ac155936aa.

Re: [PATCH -next] video: backlight: use DEFINE_MUTEX (and mutex_init() had been too late)

On Wed, Dec 23, 2020 at 10:10:35PM +0800, Zheng Yongjun wrote: > Signed-off-by: Zheng Yongjun Can you explain the Subject for this patch in more detail? If this patch is required to correct a bug then it looks to me like it is incomplete. Daniel. > --- > drivers/video/backlight/backlight.c

Re: [PATCH] drm: Check actual format for legacy pageflip.

Hi Bas, On 02/01/2021 15:02, Bas Nieuwenhuizen wrote: > With modifiers one can actually have different format_info structs > for the same format, which now matters for AMDGPU since we convert > implicit modifiers to explicit modifiers with multiple planes. > > I checked other drivers and it doesn

Re: [PATCH] drm: Check actual format for legacy pageflip.

Am 02.01.21 um 15:02 schrieb Bas Nieuwenhuizen: With modifiers one can actually have different format_info structs for the same format, which now matters for AMDGPU since we convert implicit modifiers to explicit modifiers with multiple planes. I checked other drivers and it doesn't look like th

Re: [PATCH v2 -next] video: backlight: use DEFINE_MUTEX() for mutex lock

On Thu, Dec 24, 2020 at 09:26:01PM +0800, Zheng Yongjun wrote: > mutex lock can be initialized automatically with DEFINE_MUTEX() > rather than explicitly calling mutex_init(). > > Signed-off-by: Zheng Yongjun > --- > drivers/video/backlight/backlight.c | 3 +-- > 1 file changed, 1 insertion(+),

Re: 5.11-rc1 TTM list corruption

On Fri, Jan 01, 2021 at 03:34:28PM +0100, Christian König wrote: > Going to double check the code, but can you reproduce this issue > reliable? Lemme find a test box which can trigger it too - the splat happened on my workstation and I'd like to avoid debugging there for obvious reasons. Thx. --

Re: amdgpu does not support 3840x2160@30Hz on kaveri apu

Hi Davide, adding a few of our AMD display people. In general as already suggested by others opening a bug report to track this is the right thing to do. In the past we had a few bug reports like this because amdgpu is more strict in checking hardware limitations. For example it can be tha

Re: Couple of issues with amdgpu on my WX4100

Hi Maxim, I can't help with the display related stuff. Probably best approach to get this fixes would be to open up a bug tracker for this on FDO. But I'm the one who implemented the resizeable BAR support and your analysis of the problem sounds about correct to me. The reason why this work

Re: [Linaro-mm-sig] [PATCH] dmabuf: fix use-after-free of dmabuf's file->f_inode

Am 04.01.21 um 12:36 schrieb Charan Teja Reddy: It is observed 'use-after-free' on the dmabuf's file->f_inode with the race between closing the dmabuf file and reading the dmabuf's debug info. Consider the below scenario where P1 is closing the dma_buf file and P2 is reading the dma_buf's debug

Re: [PATCH] drm/hisilicon: Use simple encoder

Hi Am 28.12.20 um 08:35 schrieb Tian Tao: The hibmc driver uses empty implementations for its encoders. Replace the code with the generic simple encoder. Signed-off-by: Tian Tao Reviewed-by: Thomas Zimmermann Thanks for the patch. --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c |

Re: amdgpu does not support 3840x2160@30Hz on kaveri apu

Yes, absolutely. Do you only get a black screen? That would certainly be a rather big bug. Christian. Am 04.01.21 um 13:37 schrieb Davide Corrado: Btw, should the driver switch to the lower supported resolution then? Il Lun 4 Gen 2021, 13:04 Davide Corrado > ha

RE: [PATCH] drm/amd/display: Fix unused variable warning

[AMD Official Use Only - Internal Distribution Only] Thanks Arnd. Reviewed-by: Wayne Lin -Original Message- From: Arnd Bergmann Sent: Sunday, January 3, 2021 10:03 PM To: Wentland, Harry ; Li, Sun peng (Leo) ; Deucher, Alexander ; Koenig, Christian ; David Airlie ; Daniel Vetter ; R

Re: [PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

Hi, I've been looking forward to this patchset. :) The code is really nice already. Am 02.01.21 um 07:03 schrieb Deepak Rawat: DRM driver for hyperv synthetic video device, based on hyperv_fb framebuffer driver. Also added config option "DRM_HYPERV" to enabled this driver. IIRC, this isn't

Re: discussion: re-structuring of the Amlogic Meson VPU DRM driver

Hi, Sorry for the delay... On 31/12/2020 00:24, Martin Blumenstingl wrote: > Hi Neil and all interested people, > > in the past there were concerns about how some of the components are > coupled in our Meson DRM driver(s). > With this discussion I would like to achieve four things: > 1. understa

Re: [PATCH 08/31] spi: spi-qcom-qspi: fix potential mem leak in spi_geni_probe()

On Fri, Jan 01, 2021 at 04:54:44PM +, Yangtao Li wrote: > We should use dev_pm_opp_put_clkname() to free opp table each time > dev_pm_opp_of_add_table() got error. Acked-by: Mark Brown signature.asc Description: PGP signature ___ dri-devel mailing

Re: amdgpu does not support 3840x2160@30Hz on kaveri apu

[AMD Official Use Only - Internal Distribution Only] You might try enabling DC (the newer modesetting infrastructure). Append amdgpu.dc=1 to the kernel command line in grub. Alex From: Davide Corrado Sent: Saturday, January 2, 2021 1:50 PM To: Deucher, Alexand

Re: [PATCH 09/31] spi: spi-qcom-qspi: fix potential mem leak in spi_geni_probe()

On Fri, Jan 01, 2021 at 04:54:45PM +, Yangtao Li wrote: > Use devm_pm_opp_* API to simplify code, and we don't need > to make opp_table glabal. Acked-by: Mark brown signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@list

Re: [PATCH 13/31] spi: spi-qcom-qspi: fix potential mem leak in qcom_qspi_probe()

On Fri, Jan 01, 2021 at 04:54:49PM +, Yangtao Li wrote: > We should use dev_pm_opp_put_clkname() to free opp table each time > dev_pm_opp_of_add_table() got error. Acked-by: Mark Brown signature.asc Description: PGP signature ___ dri-devel mailing

Re: [PATCH 14/31] spi: spi-qcom-qspi: convert to use devm_pm_opp_* API

On Fri, Jan 01, 2021 at 04:54:50PM +, Yangtao Li wrote: > Use devm_pm_opp_* API to simplify code, and remove opp_table > from qcom_qspi. Acked-by: Mark Brown signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freed

Re: 5.11-rc1 TTM list corruption

Am 04.01.21 um 11:58 schrieb Borislav Petkov: On Fri, Jan 01, 2021 at 03:34:28PM +0100, Christian König wrote: Going to double check the code, but can you reproduce this issue reliable? Lemme find a test box which can trigger it too - the splat happened on my workstation and I'd like to avoid d

Re: [PATCH v1 2/2] drm/bridge: anx7625: add MIPI DPI input feature support

On Fri, Dec 25, 2020 at 07:02:15PM +0800, Xin Ji wrote: > +static int anx7625_aux_dpcd_read(struct anx7625_data *ctx, > + u8 addrh, u8 addrm, u8 addrl, > + u8 len, u8 *buf) > +{ > + struct device *dev = &ctx->client->dev; > + int ret

Re: [PATCH v2 3/6] dt-bindings: display: imx: hdmi: Convert binding to YAML

On Sun, 2020-12-20 at 21:50 +0200, Laurent Pinchart wrote: > Convert the i.MX6 HDMI TX text binding to YAML. > > Signed-off-by: Laurent Pinchart > --- > Changes since v1: > > - Only specify maxItems for clocks > - Drop reg and interrupts as they're checked in the base schema > - Rebase on top of

Re: [PATCH v2 1/6] dt-bindings: display: bridge: Add YAML schema for Synopsys DW-HDMI

On Sun, 2020-12-20 at 21:50 +0200, Laurent Pinchart wrote: > Add a .yaml schema containing the common properties for the Synopsys > DesignWare HDMI TX controller. This isn't a full device tree binding > specification, but is meant to be referenced by platform-specific > bindings for the IP core. >

Re: [PATCH v1 1/2] dt-bindings: Convert Arm Mali Valhall GPU to DT schema

On Mon, Jan 4, 2021 at 12:11 AM Nick Fan wrote: > > Convert the Arm Valhall GPU binding to DT schema format. This is the 2nd v1 you've sent. Please address my comments on the 1st v1. > > Define a compatible string for the Mali Valhall GPU > for Mediatek's SoC platform. > > Signed-off-by: Nick Fa

Re: [PATCH] drm/amd/display: Revert "add DCN support for aarch64"

On Tue, Dec 29, 2020 at 8:17 AM Ard Biesheuvel wrote: > > On Wed, 16 Dec 2020 at 23:26, Ard Biesheuvel wrote: > > > > On Wed, 16 Dec 2020 at 19:00, Alex Deucher wrote: > > > > > > On Mon, Dec 14, 2020 at 12:53 PM Ard Biesheuvel wrote: > > > > > > > > This reverts commit c38d444e44badc557cf29fdf

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

Hey Daniel, back from vacation and going over our last long thread i think you didn't reply to my last question bellow (Or at least I can't find it). Andrey On 12/17/20 4:13 PM, Andrey Grodzovsky wrote: Ok, so I assumed that with vmap_local you were trying to solve the problem of quick reinser

Re: [PATCH] drm/amd/display: Revert "add DCN support for aarch64"

On Mon, 4 Jan 2021 at 17:27, Alex Deucher wrote: > > On Tue, Dec 29, 2020 at 8:17 AM Ard Biesheuvel wrote: > > > > On Wed, 16 Dec 2020 at 23:26, Ard Biesheuvel wrote: > > > > > > On Wed, 16 Dec 2020 at 19:00, Alex Deucher wrote: > > > > > > > > On Mon, Dec 14, 2020 at 12:53 PM Ard Biesheuvel w

Re: Couple of issues with amdgpu on my WX4100

On Mon, 4 Jan 2021 12:34:34 +0100 Christian König wrote: > Hi Maxim, > > I can't help with the display related stuff. Probably best approach to > get this fixes would be to open up a bug tracker for this on FDO. > > But I'm the one who implemented the resizeable BAR support and your > analysi

Re: [PATCH] drm/amd/display: remove unused including

On Thu, Dec 31, 2020 at 5:42 AM Tian Tao wrote: > > Remove including that don't need it. > > Signed-off-by: Tian Tao Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 1 - > driver

Re: [PATCH] drm/amd/display: remove useless else if

On Mon, Dec 21, 2020 at 9:40 AM Tian Tao wrote: > > Fix the following coccinelle report: > drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c:1357:6-8: > WARNING: possible condition with no effect (if == else) > > Signed-off-by: Tian Tao Applied. Thanks! Alex > --- > drivers/gpu/drm/amd

Re: [PATCH] drm/radeon:avoid null pointer dereference when dev is not bound

On Sun, Dec 27, 2020 at 3:56 PM Defang Bo wrote: > > [Why] > Similar to commit<0fa375e6>. If the set_state/can_switch code access the > drm_device when dev is not bound, > a null pointer dereference can happen. > > [How] > Add sanity checks to prevent it. > > Signed-off-by: Defang Bo Are you ac

Re: [PATCH -next] gpu/drm/radeon: use DIV_ROUND_UP macro to do calculation

On Wed, Dec 23, 2020 at 2:06 AM Zheng Yongjun wrote: > > Don't open-code DIV_ROUND_UP() kernel macro. > > Signed-off-by: Zheng Yongjun Applied. Thanks! Alex > --- > drivers/gpu/drm/radeon/r600_cs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/

[GIT PULL] drm/imx: fixes and drm managed resources

Hi Dave, Daniel, this PR includes the drmm encoder/plane/crtc allocation functions and converts the imx-drm driver to use them. The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: Linux 5.11-rc1 (2020-12-27 15:30:22 -0800) are available in the Git repository at: gi

Re: Enable fp16 display support for DCE8+, next try.

On Mon, Dec 28, 2020 at 1:51 PM Mario Kleiner wrote: > > Hi and happy post-christmas! > > I wrote a patch 1/1 that now checks plane scaling factors against > the pixel-format specific limits in the asic specific dc_plane_cap > structures during atomic check and other appropriate places. > > This s

Re: [PATCH] drm/amd/display: fix comparison pointer to bool warning in dc.c

On Tue, Dec 29, 2020 at 4:42 AM Tian Tao wrote: > > Fixes coccicheck warning: > drivers/gpu/drm/amd/display/dc/core/dc.c:1543:12-19: WARNING: Comparison > to bool > drivers/gpu/drm/amd/display/dc/core/dc.c:1496:14-42: WARNING: Comparison > to bool > drivers/gpu/drm/amd/display/dc/core/dc.c:971:15-

Re: [PATCH] drm: Check actual format for legacy pageflip.

On Sat, Jan 2, 2021 at 9:02 AM Bas Nieuwenhuizen wrote: > > With modifiers one can actually have different format_info structs > for the same format, which now matters for AMDGPU since we convert > implicit modifiers to explicit modifiers with multiple planes. > > I checked other drivers and it do

Re: [PATCH] drm/amd/display: Fix unused variable warning

Applied. Thanks! Alex On Mon, Jan 4, 2021 at 7:58 AM Lin, Wayne wrote: > > [AMD Official Use Only - Internal Distribution Only] > > Thanks Arnd. > > Reviewed-by: Wayne Lin > > -Original Message- > From: Arnd Bergmann > Sent: Sunday, January 3, 2021 10:03 PM > To: Wentland, Harry ; Li,

[Bug 211033] New: [bisected][regression] amdgpu: *ERROR* Restoring old state failed with -12

https://bugzilla.kernel.org/show_bug.cgi?id=211033 Bug ID: 211033 Summary: [bisected][regression] amdgpu: *ERROR* Restoring old state failed with -12 Product: Drivers Version: 2.5 Kernel Version: 5.10.4 Hardware: x86-64

[Bug 211033] [bisected][regression] amdgpu: *ERROR* Restoring old state failed with -12

https://bugzilla.kernel.org/show_bug.cgi?id=211033 Žilvinas Žaltiena (zal...@inbox.ru) changed: What|Removed |Added Regression|No |Yes -- You may rep

Re: Couple of issues with amdgpu on my WX4100

Am 04.01.21 um 17:45 schrieb Alex Williamson: On Mon, 4 Jan 2021 12:34:34 +0100 Christian König wrote: Hi Maxim, I can't help with the display related stuff. Probably best approach to get this fixes would be to open up a bug tracker for this on FDO. But I'm the one who implemented the resize

Re: [PATCH 22/31] memory: samsung: exynos5422-dmc: fix return error in exynos5_init_freq_table

On Fri, Jan 01, 2021 at 04:54:58PM +, Yangtao Li wrote: > We can't always return -EINVAL, let's fix it. > > Signed-off-by: Yangtao Li > --- > drivers/memory/samsung/exynos5422-dmc.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) Reviewed-by: Krzysztof Kozlowski I see t

  1   2   >