Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-12-16 Thread Christian König
Am 15.12.20 um 21:18 schrieb Andrey Grodzovsky: [SNIP] While we can't control user application accesses to the mapped buffers explicitly and hence we use page fault rerouting I am thinking that in this  case we may be able to sprinkle drm_dev_enter/exit in any such sensitive place were we mig

Re: [kbuild-all] Re: [radeon-alex:amd-20.45 2127/2427] drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1880:39: sparse: sparse: incorrect type in argument 1 (different base types)

2020-12-16 Thread Rong Chen
Hi Alex, We have ignored the amd-20.xx branches: https://github.com/intel/lkp-tests/commit/acb8d1f213ec6841900e0d7e9737f8ea0960e4d3 Best Regards, Rong Chen On 12/15/20 10:24 PM, Deucher, Alexander wrote: [AMD Public Use] The test robot should probably not be testing the amd-20.xx branches

[PATCH drm/hisilicon 0/2] Add the new api to enable msi

2020-12-16 Thread Tian Tao
patch #1 add the new api to enable pci mis. patch #2 is hibmc driver uses the newly added api to enable msi. Tian Tao (2): drm/irq: Add the new api to enable pci msi drm/hisilicon: Use the new api devm_drm_msi_install drivers/gpu/drm/drm_irq.c | 33 +

Re: linux-next: manual merge of the drm tree with the crypto tree

2020-12-16 Thread mark gross
On Tue, Dec 15, 2020 at 10:58:52AM +0100, Geert Uytterhoeven wrote: > On Mon, Dec 14, 2020 at 2:44 PM Stephen Rothwell > wrote: > > Today's linux-next merge of the drm tree got a conflict in: > > > > MAINTAINERS > > > > between commit: > > > > 885743324513 ("crypto: keembay - Add support for

Re: [PATCH v7 5/9] drm/vc4: hdmi: Create a custom connector state

2020-12-16 Thread Maxime Ripard
Hi Dave, On Tue, Dec 15, 2020 at 04:25:46PM +, Dave Stevenson wrote: > Hi Maxime > > On Tue, 15 Dec 2020 at 15:42, Maxime Ripard wrote: > > > > When run with a higher bpc than 8, the clock of the HDMI controller needs > > to be adjusted. Let's create a connector state that will be used at >

Re: [radeon-alex:amd-20.45 2127/2427] drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1880:39: sparse: sparse: incorrect type in argument 1 (different base types)

2020-12-16 Thread Qinglang Miao
Hi Alex, I think it's not a valid report from kernel test robot, for __le16 ought to be the right type for cpu_to_le16. The sparse warnings seems not right so I did't try effort to reproduce it. otherwise, when I take a carful look at this patch, an unconditional braces exists and I'm not su

[PATCH v7 6/9] drm/vc4: hdmi: Store pixel frequency in the connector state

2020-12-16 Thread Maxime Ripard
The pixel rate is for now quite simple to compute, but with more features (30 and 36 bits output, YUV output, etc.) will depend on a bunch of connectors properties. Let's store the rate we have to run the pixel clock at in our custom connector state, and compute it in atomic_check. Acked-by: Thom

Re: [PATCH] drm/hisilicon: Fix rmmod hibmc_drm failed

2020-12-16 Thread tiantao (H)
在 2020/12/15 20:01, Daniel Vetter 写道: On Tue, Dec 15, 2020 at 12:59:53PM +0100, Daniel Vetter wrote: On Tue, Dec 15, 2020 at 11:01:39AM +0800, Tian Tao wrote: drm_irq_uninstall should be called before pci_disable_msi, if use devm_drm_irq_install to register the interrupt, the system will call

Re: [PATCH] drm/sun4i: hdmi: Use PTR_ERR_OR_ZERO() to simplify code

2020-12-16 Thread Maxime Ripard
Hi, On Tue, Dec 15, 2020 at 10:16:11AM +0800, Tian Tao wrote: > Fixes coccicheck warning: > drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c:281:1-3: WARNING: PTR_ERR_OR_ZERO > can be used > > Signed-off-by: Tian Tao That script shouldn't be there anymore, see: https://lore.kernel.org/cocci/alpine.DEB.2.

WARNING: suspicious RCU usage in modeset_lock

2020-12-16 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:94801e5c Merge tag 'pinctrl-v5.10-3' of git://git.kernel.o.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=130558c550 kernel config: https://syzkaller.appspot.com/x/.config?x=ee8a1012a5314210 das

[PATCH v7 1/9] drm/vc4: hvs: Align the HVS atomic hooks to the new API

2020-12-16 Thread Maxime Ripard
Since the CRTC setup in vc4 is split between the PixelValves/TXP and the HVS, only the PV/TXP atomic hooks were updated in the previous commits, but it makes sense to update the HVS ones too. Reviewed-by: Thomas Zimmermann Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 6 ++-

[PATCH v7 2/9] drm/vc4: Pass the atomic state to encoder hooks

2020-12-16 Thread Maxime Ripard
We'll need to access the connector state in our encoder setup, so let's just pass the whole DRM state to our private encoder hooks. Acked-by: Thomas Zimmermann Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 18 ++ drivers/gpu/drm/vc4/vc4_drv.h | 10 +-

Re: [PATCH v7 2/5] dma-buf: heaps: Move heap-helper logic into the cma_heap implementation

2020-12-16 Thread Guenter Roeck
On Sat, Nov 21, 2020 at 11:49:59PM +, John Stultz wrote: > Since the heap-helpers logic ended up not being as generic as > hoped, move the heap-helpers dma_buf_ops implementations into > the cma_heap directly. > > This will allow us to remove the heap_helpers code in a following > patch. > m

[PATCH v7 0/9] drm/vc4: hdmi: Support the 10/12 bit output

2020-12-16 Thread Maxime Ripard
Hi, Here's some patches to enable the HDR output in the RPi4/BCM2711 HDMI controller. Let me know what you think, Maxime Changes from v6: - Addressed the issues pointed out by Dave - Rebased on current drm-misc-next Changes from v5: - Fixed the connector->state access in the connector sta

[PATCH v7 7/9] drm/vc4: hdmi: Use the connector state pixel rate for the PHY

2020-12-16 Thread Maxime Ripard
The PHY initialisation parameters are not based on the pixel clock but the TMDS clock rate which can be the pixel clock in the standard case, but could be adjusted based on some parameters like the bits per color. Since the TMDS clock rate is stored in our custom connector state already, let's reu

[PATCH drm/hisilicon 2/2] drm/hisilicon: Use the new api devm_drm_msi_install

2020-12-16 Thread Tian Tao
Use devm_drm_msi_install to enable pci msi so that pci_disable_msi is not called when hibmc is removed. Signed-off-by: Tian Tao --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.

Re: [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-12-16 Thread Viresh Kumar
On 07-12-20, 11:46, Viresh Kumar wrote: > On 19-11-20, 11:35, Viresh Kumar wrote: > > On 18-11-20, 08:53, Rob Clark wrote: > > > On Tue, Nov 17, 2020 at 9:28 PM Viresh Kumar > > > wrote: > > > > > > > > On 17-11-20, 09:02, Rob Clark wrote: > > > > > With that on top of the previous patch, > > > >

[PATCH v7 5/9] drm/vc4: hdmi: Create a custom connector state

2020-12-16 Thread Maxime Ripard
When run with a higher bpc than 8, the clock of the HDMI controller needs to be adjusted. Let's create a connector state that will be used at atomic_check and atomic_enable to compute and store the clock rate associated to the state. Acked-by: Thomas Zimmermann Signed-off-by: Maxime Ripard ---

[PATCH v7 8/9] drm/vc4: hdmi: Limit the BCM2711 to the max without scrambling

2020-12-16 Thread Maxime Ripard
Unlike the previous generations, the HSM clock limitation is way above what we can reach without scrambling, so let's move the maximum frequency we support to the maximum clock frequency without scrambling. Reviewed-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdm

Re: [PATCH v2 0/7] vc4: Convert to drm_atomic_helper_commit

2020-12-16 Thread Maxime Ripard
On Fri, Dec 04, 2020 at 04:11:31PM +0100, Maxime Ripard wrote: > Hi, > > Here's a conversion of vc4 to remove the hand-rolled atomic_commit helper from > vc4 in favour of the generic one. > > This requires some rework of vc4, but also a new hook and some documentation > for corner-cases in the DR

[PATCH drm/hisilicon 1/2] drm/irq: Add the new api to enable pci msi

2020-12-16 Thread Tian Tao
Add new api devm_drm_msi_install() to register interrupts, no need to call pci_disable_msi() when the drm module is removed. Signed-off-by: Tian Tao --- drivers/gpu/drm/drm_irq.c | 33 + include/drm/drm_irq.h | 1 + 2 files changed, 34 insertions(+) diff --g

[PATCH v7 4/9] drm/vc4: hdmi: Don't access the connector state in reset if kmalloc fails

2020-12-16 Thread Maxime Ripard
drm_atomic_helper_connector_reset uses kmalloc which, from an API standpoint, can fail, and thus setting connector->state to NULL. However, our reset hook then calls drm_atomic_helper_connector_tv_reset that will access connector->state without checking if it's a valid pointer or not. Make sure we

Re: [PATCH 3/4] drm: vc4: Remove unnecessary drm_plane_cleanup() wrapper

2020-12-16 Thread Maxime Ripard
On Tue, Dec 15, 2020 at 09:37:54PM +0200, Laurent Pinchart wrote: > Use the drm_plane_cleanup() function directly as the drm_plane_funcs > .destroy() handler without creating an unnecessary wrapper around it. > > Signed-off-by: Laurent Pinchart Acked-by: Maxime Ripard Maxime signature.asc De

[PATCH v7 3/9] drm/vc4: hdmi: Take into account the clock doubling flag in atomic_check

2020-12-16 Thread Maxime Ripard
Commit 63495f6b4aed ("drm/vc4: hdmi: Make sure our clock rate is within limits") was intended to compute the pixel rate to make sure we remain within the boundaries of what the hardware can provide. However, unlike what mode_valid was checking for, we forgot to take into account the clock doubling

[PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-16 Thread Chen Li
When using e8860(gcn1) on arm64, the kernel crashed on drm/radeon: [ 11.240414] pc : __memset+0x4c/0x188 [ 11.244101] lr : radeon_uvd_get_create_msg+0x114/0x1d0 [radeon] [ 11.249995] sp : 0d7eb700 [ 11.253295] x29: 0d7eb700 x28: 8001f632a868 [ 11.258585] x27: 00

[PATCH v2] drm/hisilicon: Fix rmmod hibmc_drm failed

2020-12-16 Thread Tian Tao
drm_irq_uninstall should be called before pci_disable_msi, if use devm_drm_irq_install to register the interrupt, the system will call pci_disable_msi first and then call drm_irq_uninstall, which will result in the following callstack. This reverts commit e4401247070a37c2fce62b2773a4eb7757983938.

[PATCH v7 9/9] drm/vc4: hdmi: Enable 10/12 bpc output

2020-12-16 Thread Maxime Ripard
The BCM2711 supports higher bpc count than just 8, so let's support it in our driver. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 70 - drivers/gpu/drm/vc4/vc4_hdmi.h | 1 + drivers/gpu/drm/vc4/vc4_hdmi_regs.h | 9 3 files change

Re: [PATCH 14/65] drm/rcar-du: Annotate dma-fence critical section in commit path

2020-12-16 Thread Daniel Vetter
On Wed, Dec 16, 2020 at 2:29 AM Laurent Pinchart wrote: > > Hi Daniel, > > Thank you for the patch. > > On Fri, Oct 23, 2020 at 02:21:25PM +0200, Daniel Vetter wrote: > > Ends right after drm_atomic_helper_commit_hw_done(), absolutely > > nothing fancy going on here. > > > > Signed-off-by: Daniel

Re: WARNING: suspicious RCU usage in modeset_lock

2020-12-16 Thread Daniel Vetter
On Wed, Dec 16, 2020 at 2:14 AM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:94801e5c Merge tag 'pinctrl-v5.10-3' of git://git.kernel.o.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=130558c550 > kernel config:

Re: [PATCH 1/4] dma-buf: Remove kmap kerneldoc vestiges

2020-12-16 Thread Daniel Vetter
On Tue, Dec 15, 2020 at 03:18:49PM +0100, Christian König wrote: > Am 14.12.20 um 17:01 schrieb Daniel Vetter: > > On Mon, Dec 14, 2020 at 11:33:10AM +0100, Christian König wrote: > > > Am 11.12.20 um 16:58 schrieb Daniel Vetter: > > > > Also try to clarify a bit when dma_buf_begin/end_cpu_access s

[PATCH v6 15/15] drm/i915/display: Let PCON convert from RGB to YUV if it can

2020-12-16 Thread Ankit Nautiyal
If PCON has capability to convert RGB->YUV colorspace and also to 444->420 downsampling then for any YUV420 only mode, we can let the PCON do all the conversion. v2: As suggested by Uma Shankar, considered case for colorspace BT709 and BT2020, and default to BT609. Also appended dir 'display' in c

[PATCH] drm/etnaviv: provide more ID values via GET_PARAM ioctl.

2020-12-16 Thread Christian Gmeiner
Make it possible for the user space to access these ID values. Signed-off-by: Christian Gmeiner --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 12 include/uapi/drm/etnaviv_drm.h| 3 +++ 2 files changed, 15 insertions(+) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/dr

Re: [PATCH] dt-bindings: display: bridge: tc358768: Remove maintainer information

2020-12-16 Thread Peter Ujfalusi
On 15/12/2020 16.26, Rob Herring wrote: > On Tue, 15 Dec 2020 14:42:27 +0200, Peter Ujfalusi wrote: >> My employment with TI is coming to an end and I will not have access to >> the board where this bridge is connected to. >> >> It is better to remove a soon bouncing email address. >> >> Signed-of

Re: [PATCH v2 4/4] drm: rcar-du: Use drm_bridge_connector_init() helper

2020-12-16 Thread Jacopo Mondi
Hi Laurent, On Wed, Dec 16, 2020 at 02:50:21AM +0200, Laurent Pinchart wrote: > Use the drm_bridge_connector_init() helper to create a drm_connector for > each output, instead of relying on the bridge drivers doing so. Attach > the bridges with the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag to instruct >

[PATCH] MAINTAINERS: Update addresses for TI display drivers

2020-12-16 Thread Tomi Valkeinen
Update the maintainer email addresses for TI display drivers. Signed-off-by: Tomi Valkeinen --- MAINTAINERS | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 281de213ef47..c21471497a18 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -593

[kbuild] Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-16 Thread Dan Carpenter
Hi Chen, url: https://github.com/0day-ci/linux/commits/Chen-Li/drm-amdgpu-radeon-fix-memset-on-io-mem/20201216-165835 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git d01e7f10dae29eba0f9ada82b65d24e035d5b2f9 config: x86_64-randconfig-m001-20201216 (attached as

Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-16 Thread kernel test robot
documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Chen-Li/drm-amdgpu-radeon-fix-memset-on-io-mem/20201216-165835 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git d01e7f10dae29eba0f9ada82b65d24e035d5b2f9 conf

Re: [PATCH v2 1/4] drm: rcar-du: lvds: Convert to DRM panel bridge helper

2020-12-16 Thread Jacopo Mondi
Hi Laurent, On Wed, Dec 16, 2020 at 02:50:18AM +0200, Laurent Pinchart wrote: > Replace the manual panel handling with usage of the DRM panel bridge > helper. This simplifies the driver, and brings support for > DRM_BRIDGE_ATTACH_NO_CONNECTOR as an added bonus. > > Signed-off-by: Laurent Pinchart

Re: [PATCH v2 1/4] drm: rcar-du: lvds: Convert to DRM panel bridge helper

2020-12-16 Thread Laurent Pinchart
Hi Jacopo, On Wed, Dec 16, 2020 at 02:16:56PM +0100, Jacopo Mondi wrote: > On Wed, Dec 16, 2020 at 02:50:18AM +0200, Laurent Pinchart wrote: > > Replace the manual panel handling with usage of the DRM panel bridge > > helper. This simplifies the driver, and brings support for > > DRM_BRIDGE_ATTACH

Re: [PATCH] drm: rcar-du: Fix leak of CMM platform device reference

2020-12-16 Thread Jacopo Mondi
Hi Laurent, I wonder if 'leaked' is correct in subject. It probably is, un-balanced ref-counting will prevent the device from being released. It should however happen only at system tear-down, doesn't it ? On Wed, Dec 16, 2020 at 03:22:18AM +0200, Laurent Pinchart wrote: > The device references a

Re: [PATCH] dt-bindings: display: bridge: renesas, lvds: RZ/G2E needs renesas,companion too

2020-12-16 Thread Jacopo Mondi
Hi Laurent, Fabrizio On Wed, Dec 16, 2020 at 12:59:27AM +0200, Laurent Pinchart wrote: > From: Fabrizio Castro > > Document RZ/G2E support for property renesas,companion. > > Signed-off-by: Fabrizio Castro > Reviewed-by: Laurent Pinchart > Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo M

Re: [PATCH v2 4/4] drm: rcar-du: Use drm_bridge_connector_init() helper

2020-12-16 Thread Laurent Pinchart
Hi Jacopo, On Wed, Dec 16, 2020 at 12:53:19PM +0100, Jacopo Mondi wrote: > On Wed, Dec 16, 2020 at 02:50:21AM +0200, Laurent Pinchart wrote: > > Use the drm_bridge_connector_init() helper to create a drm_connector for > > each output, instead of relying on the bridge drivers doing so. Attach > > t

Re: [PATCH] drm: rcar-du: Fix leak of CMM platform device reference

2020-12-16 Thread Laurent Pinchart
Hi Jacopo, On Wed, Dec 16, 2020 at 02:51:34PM +0100, Jacopo Mondi wrote: > Hi Laurent, > > I wonder if 'leaked' is correct in subject. It probably is, > un-balanced ref-counting will prevent the device from being released. > It should however happen only at system tear-down, doesn't it ? As the

[PATCH 1/2] drm/ttm: rework ttm_tt page limit v2

2020-12-16 Thread Christian König
TTM implements a rather extensive accounting of allocated memory. There are two reasons for this: 1. It tries to block userspace allocating a huge number of very small BOs without accounting for the kmalloced memory. 2. Make sure we don't over allocate and run into an OOM situation during s

[PATCH 2/2] drm/ttm: move memory accounting into vmwgfx

2020-12-16 Thread Christian König
This is just another feature which is only used by VMWGFX, so move it into the driver instead. I've tried to add the accounting sysfs file to the kobject of the drm minor, but I'm not 100% sure if this works as expected. Signed-off-by: Christian König --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gp

[PATCH v2] drm: rcar-du: Fix leak of CMM platform device reference

2020-12-16 Thread Laurent Pinchart
The device references acquired by of_find_device_by_node() are not released by the driver. Fix this by registering a cleanup action. Fixes: 8de707aeb452 ("drm: rcar-du: kms: Initialize CMM instances") Signed-off-by: Laurent Pinchart --- Changes since v1: - Only set rcdu->cmms[] if the CMM config

Re: [PATCH] drm/bridge: use devm_add_action_or_reset() to handle failed condition

2020-12-16 Thread Laurent Pinchart
Hi Tian, Thank you for the patch. On Wed, Dec 16, 2020 at 08:22:32PM +0800, Tian Tao wrote: > switch to using devm_add_action_or_reset() instead of devm_add_action to > avoid call the cec_delete_adapter,when devm_add_action_or_reset return > failed. > > Signed-off-by: Tian Tao Reviewed-by: Lau

Re: [PATCH v2] drm: rcar-du: Fix leak of CMM platform device reference

2020-12-16 Thread Jacopo Mondi
Hi Laurent, On Wed, Dec 16, 2020 at 04:08:36PM +0200, Laurent Pinchart wrote: > The device references acquired by of_find_device_by_node() are not > released by the driver. Fix this by registering a cleanup action. > > Fixes: 8de707aeb452 ("drm: rcar-du: kms: Initialize CMM instances") > Signed-of

Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-16 Thread Christian König
Am 16.12.20 um 14:48 schrieb Chen Li: On Wed, 16 Dec 2020 15:59:37 +0800, Christian König wrote: Am 16.12.20 um 06:41 schrieb Chen Li: When using e8860(gcn1) on arm64, the kernel crashed on drm/radeon: [SNIP] Obviously, the __memset call is generated by gcc(8.3.1). It optimizes this for loop in

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-12-16 Thread Daniel Vetter
On Wed, Dec 16, 2020 at 9:04 AM Christian König wrote: > > Am 15.12.20 um 21:18 schrieb Andrey Grodzovsky: > > [SNIP] > >>> > >>> While we can't control user application accesses to the mapped > >>> buffers explicitly and hence we use page fault rerouting > >>> I am thinking that in this case we

Re: [PATCH 4/4] drm: zte: Remove unnecessary drm_plane_cleanup() wrapper

2020-12-16 Thread Daniel Vetter
On Tue, Dec 15, 2020 at 09:37:55PM +0200, Laurent Pinchart wrote: > Use the drm_plane_cleanup() function directly as the drm_plane_funcs > .destroy() handler without creating an unnecessary wrapper around it. > > Signed-off-by: Laurent Pinchart On the series: Acked-by: Daniel Vetter I'm assum

Re: [PATCH] drm: Don't export the drm_gem_dumb_destroy() function

2020-12-16 Thread Daniel Vetter
On Tue, Dec 15, 2020 at 09:51:47PM +0200, Laurent Pinchart wrote: > The drm_gem_dumb_destroy() isn't used in drivers, don't export it. > > Signed-off-by: Laurent Pinchart Reviewed-by: Daniel Vetter Again I'm assuming you'll apply this somewhere. -Daniel > --- > Changes since v1: > > - Move f

Re: [PATCH v2] drm: rcar-du: Fix leak of CMM platform device reference

2020-12-16 Thread Laurent Pinchart
Hi Jacopo, On Wed, Dec 16, 2020 at 03:16:28PM +0100, Jacopo Mondi wrote: > On Wed, Dec 16, 2020 at 04:08:36PM +0200, Laurent Pinchart wrote: > > The device references acquired by of_find_device_by_node() are not > > released by the driver. Fix this by registering a cleanup action. > > > > Fixes: 8

Re: [PATCH 4/4] drm: zte: Remove unnecessary drm_plane_cleanup() wrapper

2020-12-16 Thread Laurent Pinchart
Hi Daniel, On Wed, Dec 16, 2020 at 03:22:59PM +0100, Daniel Vetter wrote: > On Tue, Dec 15, 2020 at 09:37:55PM +0200, Laurent Pinchart wrote: > > Use the drm_plane_cleanup() function directly as the drm_plane_funcs > > .destroy() handler without creating an unnecessary wrapper around it. > > > >

Re: [PATCH v2 1/3] drm: Move legacy device list out of drm_driver

2020-12-16 Thread Daniel Vetter
On Tue, Dec 15, 2020 at 10:31:24PM +0200, Laurent Pinchart wrote: > The drm_driver structure contains a single field (legacy_dev_list) that > is modified by the DRM core, used to store a linked list of legacy DRM > devices associated with the driver. In order to make the structure > const, move the

Re: [PATCH v2 2/3] drm: Use a const drm_driver for legacy PCI devices

2020-12-16 Thread Daniel Vetter
On Tue, Dec 15, 2020 at 10:31:25PM +0200, Laurent Pinchart wrote: > Now that the legacy PCI support code doesn't need to write to the > drm_driver structure, it can be treated as const through the whole DRM > core, unconditionally. This allows declaring the structure as const in > all drivers, remo

Re: [PATCH v2 2/3] drm: Use a const drm_driver for legacy PCI devices

2020-12-16 Thread Laurent Pinchart
On Wed, Dec 16, 2020 at 03:29:00PM +0100, Daniel Vetter wrote: > On Tue, Dec 15, 2020 at 10:31:25PM +0200, Laurent Pinchart wrote: > > Now that the legacy PCI support code doesn't need to write to the > > drm_driver structure, it can be treated as const through the whole DRM > > core, unconditional

Re: [PATCH v2 3/3] drm: Constify drm_driver in drivers that don't modify it

2020-12-16 Thread Daniel Vetter
On Tue, Dec 15, 2020 at 10:31:26PM +0200, Laurent Pinchart wrote: > A non-const structure containing function pointers is a possible attack > vector. The drm_driver structure is already const in most drivers, but > there are a few exceptions. Constify the structure in the drivers that > don't need

Re: [PATCH v2] drm: rcar-du: Fix leak of CMM platform device reference

2020-12-16 Thread Jacopo Mondi
Hi Laurent On Wed, Dec 16, 2020 at 04:24:11PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > On Wed, Dec 16, 2020 at 03:16:28PM +0100, Jacopo Mondi wrote: > > On Wed, Dec 16, 2020 at 04:08:36PM +0200, Laurent Pinchart wrote: > > > The device references acquired by of_find_device_by_node() are not

Re: [PATCH v2 01/10] drm: uapi: Use SPDX in DRM core uAPI headers

2020-12-16 Thread Daniel Vetter
On Wed, Dec 16, 2020 at 04:43:50AM +0200, Laurent Pinchart wrote: > The DRM core uAPI headers are licensed under the MIT license, and carry > copies of the license with slight variations. Replace them with SPDX > headers. > > Following a discussion with Daniel Vetter on this topic, add a > clarifi

Re: [PATCH] MAINTAINERS: Update addresses for TI display drivers

2020-12-16 Thread Daniel Vetter
On Wed, Dec 16, 2020 at 09:59:17AM +0200, Tomi Valkeinen wrote: > Update the maintainer email addresses for TI display drivers. > > Signed-off-by: Tomi Valkeinen Acked-by: Daniel Vetter > --- > MAINTAINERS | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/MA

Re: [PATCH -next] backlight: sky81452-backlight: convert comma to semicolon

2020-12-16 Thread Lee Jones
On Mon, 14 Dec 2020, Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun > --- > drivers/video/backlight/sky81452-backlight.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- Lee Jones [李琼斯] Senior T

Re: [PATCH v2 1/4] drm: rcar-du: lvds: Convert to DRM panel bridge helper

2020-12-16 Thread Jacopo Mondi
Hi Laurent, On Wed, Dec 16, 2020 at 03:49:24PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > > > + if (lvds->panel) { > > > + lvds->next_bridge = devm_drm_panel_bridge_add(lvds->dev, > > > + lvds->panel); > > > > Reading the devm_drm_

RE: [PATCH 2/3] drm: uapi: Use SPDX in DRM drivers uAPI headers

2020-12-16 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: Laurent Pinchart > Sent: Tuesday, December 15, 2020 9:15 PM > To: Koenig, Christian > Cc: Daniel Vetter ; Laurent Pinchart > ; dri- > de...@lists.freedesktop.org; Dave Airlie ; Greg Kroah- > Hartman ; Thomas Gleixner > ; Deucher, Alexander ;

Re: [PATCH v2 01/10] drm: uapi: Use SPDX in DRM core uAPI headers

2020-12-16 Thread Laurent Pinchart
Hi Daniel, On Wed, Dec 16, 2020 at 03:34:35PM +0100, Daniel Vetter wrote: > On Wed, Dec 16, 2020 at 04:43:50AM +0200, Laurent Pinchart wrote: > > The DRM core uAPI headers are licensed under the MIT license, and carry > > copies of the license with slight variations. Replace them with SPDX > > hea

Re: [PATCH 1/2] drm/ttm: rework ttm_tt page limit v2

2020-12-16 Thread Daniel Vetter
On Wed, Dec 16, 2020 at 03:04:26PM +0100, Christian König wrote: > TTM implements a rather extensive accounting of allocated memory. > > There are two reasons for this: > 1. It tries to block userspace allocating a huge number of very small >BOs without accounting for the kmalloced memory. >

Re: [PATCH v2, 10/17] drm/mediatek: fix aal size config

2020-12-16 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年12月12日 週六 下午12:22寫道: > > fix aal size config > > Fixes: 0664d1392c26 (drm/mediatek: Add AAL engine basic function) > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 11 ++- > 1 file changed, 10 insertions(+), 1 delet

Re: [PATCH v2 01/10] drm: uapi: Use SPDX in DRM core uAPI headers

2020-12-16 Thread Daniel Vetter
On Wed, Dec 16, 2020 at 05:03:25PM +0200, Laurent Pinchart wrote: > Hi Daniel, > > On Wed, Dec 16, 2020 at 03:34:35PM +0100, Daniel Vetter wrote: > > On Wed, Dec 16, 2020 at 04:43:50AM +0200, Laurent Pinchart wrote: > > > The DRM core uAPI headers are licensed under the MIT license, and carry > >

Re: [PATCH v2 01/10] drm: uapi: Use SPDX in DRM core uAPI headers

2020-12-16 Thread Laurent Pinchart
On Wed, Dec 16, 2020 at 04:12:14PM +0100, Daniel Vetter wrote: > On Wed, Dec 16, 2020 at 05:03:25PM +0200, Laurent Pinchart wrote: > > On Wed, Dec 16, 2020 at 03:34:35PM +0100, Daniel Vetter wrote: > > > On Wed, Dec 16, 2020 at 04:43:50AM +0200, Laurent Pinchart wrote: > > > > The DRM core uAPI hea

Re: [PATCH v2, 02/17] dt-bindings: mediatek: add CLK_MM_DISP_CONFIG control description for mt8192 display

2020-12-16 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年12月12日 週六 下午12:12寫道: > > add CLK_MM_DISP_CONFIG control description for mt8192 displa display > > Signed-off-by: Yongqiang Niu > --- > Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff -

Re: [PATCH v3 4/4] drm: require each CRTC to have a unique primary plane

2020-12-16 Thread Simon Ser
On Monday, December 14th, 2020 at 9:41 AM, Pekka Paalanen wrote: > On Fri, 11 Dec 2020 14:39:35 + > Simon Ser wrote: > > > On Friday, December 11th, 2020 at 2:50 PM, Pekka Paalanen > > wrote: > > > > > is there a reason why one cannot have more primary planes than CRTCs in > > > existence

Re: [PATCH 2/2] drm/ttm: move memory accounting into vmwgfx

2020-12-16 Thread Daniel Vetter
On Wed, Dec 16, 2020 at 03:04:27PM +0100, Christian König wrote: > This is just another feature which is only used by VMWGFX, so move > it into the driver instead. > > I've tried to add the accounting sysfs file to the kobject of the drm > minor, but I'm not 100% sure if this works as expected. >

Re: [PATCH 2/3] drm: uapi: Use SPDX in DRM drivers uAPI headers

2020-12-16 Thread Greg Kroah-Hartman
On Wed, Dec 16, 2020 at 02:52:25PM +, Deucher, Alexander wrote: > [AMD Public Use] > > > -Original Message- > > From: Laurent Pinchart > > Sent: Tuesday, December 15, 2020 9:15 PM > > To: Koenig, Christian > > Cc: Daniel Vetter ; Laurent Pinchart > > ; dri- > > de...@lists.freedeskto

Re: [PATCH] drm/ttm: fix unused function warning

2020-12-16 Thread Christian König
Am 08.12.20 um 10:43 schrieb Christian König: Am 08.12.20 um 09:18 schrieb Martin Peres: On 04/12/2020 18:51, Arnd Bergmann wrote: From: Arnd Bergmann ttm_pool_type_count() is not used when debugfs is disabled: drivers/gpu/drm/ttm/ttm_pool.c:243:21: error: unused function 'ttm_pool_type_cou

Re: [PATCH] MAINTAINERS: Update addresses for TI display drivers

2020-12-16 Thread Jyri Sarha
On 2020-12-16 9:59, Tomi Valkeinen wrote: Update the maintainer email addresses for TI display drivers. Signed-off-by: Tomi Valkeinen Acked-by: Jyri Sarha --- MAINTAINERS | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 281de21

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-12-16 Thread Andrey Grodzovsky
On 12/16/20 9:21 AM, Daniel Vetter wrote: On Wed, Dec 16, 2020 at 9:04 AM Christian König wrote: Am 15.12.20 um 21:18 schrieb Andrey Grodzovsky: [SNIP] While we can't control user application accesses to the mapped buffers explicitly and hence we use page fault rerouting I am thinking that i

Re: WARNING: suspicious RCU usage in modeset_lock

2020-12-16 Thread Paul E. McKenney
On Wed, Dec 16, 2020 at 10:52:06AM +0100, Daniel Vetter wrote: > On Wed, Dec 16, 2020 at 2:14 AM syzbot > wrote: > > > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit:94801e5c Merge tag 'pinctrl-v5.10-3' of git://git.kernel.o.. > > git tree: upstream > > console

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-12-16 Thread Christian König
Am 16.12.20 um 17:13 schrieb Andrey Grodzovsky: On 12/16/20 9:21 AM, Daniel Vetter wrote: On Wed, Dec 16, 2020 at 9:04 AM Christian König wrote: Am 15.12.20 um 21:18 schrieb Andrey Grodzovsky: [SNIP] While we can't control user application accesses to the mapped buffers explicitly and hence

Re: [kbuild-all] Re: [radeon-alex:amd-20.45 2127/2427] drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1880:39: sparse: sparse: incorrect type in argument 1 (different base types)

2020-12-16 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] You can add amd-21.xx as well, since they will coming up next year. Maybe amd-2*? Alex From: Rong Chen Sent: Wednesday, December 16, 2020 3:48 AM To: Deucher, Alexander ; Qinglang Miao ; kernel test robot

Re: [PATCH 2/2] drm/ttm: move memory accounting into vmwgfx

2020-12-16 Thread kernel test robot
tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Christian-K-nig/drm-ttm-rework-ttm_tt-page-limit-v2/20201216-221614 base: git://anongit.free

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-12-16 Thread Daniel Vetter
On Wed, Dec 16, 2020 at 5:18 PM Christian König wrote: > > Am 16.12.20 um 17:13 schrieb Andrey Grodzovsky: > > > > On 12/16/20 9:21 AM, Daniel Vetter wrote: > >> On Wed, Dec 16, 2020 at 9:04 AM Christian König > >> wrote: > >>> Am 15.12.20 um 21:18 schrieb Andrey Grodzovsky: > [SNIP] > >

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-12-16 Thread Daniel Vetter
On Wed, Dec 16, 2020 at 6:12 PM Daniel Vetter wrote: > > On Wed, Dec 16, 2020 at 5:18 PM Christian König > wrote: > > > > Am 16.12.20 um 17:13 schrieb Andrey Grodzovsky: > > > > > > On 12/16/20 9:21 AM, Daniel Vetter wrote: > > >> On Wed, Dec 16, 2020 at 9:04 AM Christian König > > >> wrote: > >

[PATCH v7 1/5] drm: Add function to convert rect in 16.16 fixed format to regular format

2020-12-16 Thread José Roberto de Souza
Much more clear to read one function call than four lines doing this conversion. v7: - function renamed - calculating width and height before truncate - inlined Cc: Ville Syrjälä Cc: dri-devel@lists.freedesktop.org Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- include/drm/drm_r

Re: [PATCH] dma-buf: cma_heap: Include linux/vmalloc.h to fix build failures on MIPS

2020-12-16 Thread Sumit Semwal
Hi John, On Wed, 16 Dec 2020 at 06:19, John Stultz wrote: > > We need to include in order for MIPS to find > vmap(), as it doesn't otherwise get included there. > > Without this patch, one can hit the following build error: > drivers/dma-buf/heaps/cma_heap.c: In function 'cma_heap_do_vmap': >

Re: [PATCH] drm/amd/display: Revert "add DCN support for aarch64"

2020-12-16 Thread Alex Deucher
On Mon, Dec 14, 2020 at 12:53 PM Ard Biesheuvel wrote: > > This reverts commit c38d444e44badc557cf29fdfdfb823604890ccfa. > > Simply disabling -mgeneral-regs-only left and right is risky, given that > the standard AArch64 ABI permits the use of FP/SIMD registers anywhere, > and GCC is known to use

Re: [PATCH 2/2] drm/ttm: move memory accounting into vmwgfx

2020-12-16 Thread kernel test robot
tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Christian-K-nig/drm-ttm-rework-ttm_tt-page-limit-v2/20201216-221614 base: git://anongit.free

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-12-16 Thread Andrey Grodzovsky
On 12/16/20 12:12 PM, Daniel Vetter wrote: On Wed, Dec 16, 2020 at 5:18 PM Christian König wrote: Am 16.12.20 um 17:13 schrieb Andrey Grodzovsky: On 12/16/20 9:21 AM, Daniel Vetter wrote: On Wed, Dec 16, 2020 at 9:04 AM Christian König wrote: Am 15.12.20 um 21:18 schrieb Andrey Grodzovsky:

RE: [PATCH v5 07/15] drm/dp_helper: Add helpers to configure PCONs RGB-YCbCr Conversion

2020-12-16 Thread Shankar, Uma
> -Original Message- > From: Nautiyal, Ankit K > Sent: Wednesday, December 16, 2020 11:01 AM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; > airl...@linux.ie; jani.nik...@linux.intel.com; ville.syrj...@linux.intel.com; > Kulkarni, Vandita ;

[pull] amdgpu, amdkfd, radeon drm-fixes-5.11

2020-12-16 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.11. The following changes since commit b10733527bfd864605c33ab2e9a886eec317ec39: Merge tag 'amd-drm-next-5.11-2020-12-09' of git://people.freedesktop.org/~agd5f/linux into drm-next (2020-12-10 16:55:53 +1000) are available in the Git repository at: git://peop

RE: [PATCH v6 15/15] drm/i915/display: Let PCON convert from RGB to YUV if it can

2020-12-16 Thread Shankar, Uma
> -Original Message- > From: Nautiyal, Ankit K > Sent: Wednesday, December 16, 2020 5:01 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; > airl...@linux.ie; jani.nik...@linux.intel.com; ville.syrj...@linux.intel.com; > Kulkarni, Vandita ; S

[PATCH 1/8] drm/doc: rename FB_DAMAGE_CLIPS section

2020-12-16 Thread Simon Ser
Make it more human-readable. Signed-off-by: Simon Ser Cc: Daniel Vetter Cc: Pekka Paalanen --- Documentation/gpu/drm-kms.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-kms.rst index 3c5ae4f6dfd2..76cf6acc23a5 10

[PATCH 6/8] drm/doc: introduce new section for standard plane properties

2020-12-16 Thread Simon Ser
Introduce a new "Standard Plane Properties" section for properties defined in drm_plane.c. Move the mis-placed IN_FORMATS docs there. Signed-off-by: Simon Ser Cc: Daniel Vetter Cc: Pekka Paalanen --- Documentation/gpu/drm-kms.rst | 6 ++ drivers/gpu/drm/drm_blend.c | 6 -- drivers/

[PATCH 3/8] drm/doc: move damage tracking functions to new section

2020-12-16 Thread Simon Ser
Move drm_damage_helper function reference from the KMS properties section to the plane abstraction section. This makes the KMS properties section more readable for user-space developers. Signed-off-by: Simon Ser Cc: Daniel Vetter Cc: Pekka Paalanen --- Documentation/gpu/drm-kms.rst | 15 ++

[PATCH 7/8] drm/doc: fix drm_plane_type docs

2020-12-16 Thread Simon Ser
The docs for enum drm_plane_type mention legacy IOCTLs, however the plane type is not tied to legacy IOCTLs, the drm_cursor.primary and cursor fields are. Add a small paragraph to reference these. Instead, document expectations for primary and cursor planes for non-legacy userspace. Note that thes

[PATCH 5/8] drm/doc: the KMS properties section is for user-space devs

2020-12-16 Thread Simon Ser
State that the "KMS Properties" section is mainly for user-space developers. Signed-off-by: Simon Ser Cc: Daniel Vetter Cc: Pekka Paalanen --- Documentation/gpu/drm-kms.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-kms.rst inde

[PATCH 2/8] drm/doc: move composition function docs to new section

2020-12-16 Thread Simon Ser
Move drm_blend.c function reference from the KMS properties section to the plane abstraction section. This makes the KMS properties section more readable for user-space developers. Signed-off-by: Simon Ser Cc: Daniel Vetter Cc: Pekka Paalanen --- Documentation/gpu/drm-kms.rst | 9 ++--- 1

[PATCH 8/8] drm/doc: document the type plane property

2020-12-16 Thread Simon Ser
Add a new entry for "type" in the section for standard plane properties. Signed-off-by: Simon Ser Cc: Daniel Vetter Cc: Pekka Paalanen --- drivers/gpu/drm/drm_plane.c | 39 + 1 file changed, 35 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_

[PATCH 0/8] drm/doc: improve plane property docs

2020-12-16 Thread Simon Ser
Re-organize and improve plane property docs. Simon Ser (8): drm/doc: rename FB_DAMAGE_CLIPS section drm/doc: move composition function docs to new section drm/doc: move damage tracking functions to new section drm/doc: move color management functions under CRTC section drm/doc: the KMS p

[PATCH 4/8] drm/doc: move color management functions under CRTC section

2020-12-16 Thread Simon Ser
Move drm_color_mgmt function reference from the KMS properties section to the CRTC abstraction section. This makes the KMS properties section more readable for user-space developers. Signed-off-by: Simon Ser Cc: Daniel Vetter Cc: Pekka Paalanen --- Documentation/gpu/drm-kms.rst | 15 +-

Re: [PATCH 4/8] drm/doc: move color management functions under CRTC section

2020-12-16 Thread Daniel Vetter
On Wed, Dec 16, 2020 at 09:22:18PM +0100, Simon Ser wrote: > Move drm_color_mgmt function reference from the KMS properties > section to the CRTC abstraction section. This makes the KMS > properties section more readable for user-space developers. > > Signed-off-by: Simon Ser > Cc: Daniel Vetter

  1   2   >