Re: [PATCH -next] backlight: sky81452-backlight: convert comma to semicolon

2020-12-15 Thread Lee Jones
On Mon, 14 Dec 2020, Daniel Thompson wrote: > On Mon, Dec 14, 2020 at 09:34:58PM +0800, Zheng Yongjun wrote: > > Replace a comma between expression statements by a semicolon. > > > > Signed-off-by: Zheng Yongjun > > Weird! I guess it was harmless but still seriously weird ;-) One of these was

Re: [PATCH v3 0/9] Xilinx AI engine kernel driver

2020-12-15 Thread Jiaying Liang
On 12/11/20 11:39 AM, Daniel Vetter wrote: Hi all On Fri, Dec 11, 2020 at 8:03 PM Alex Deucher wrote: On Mon, Nov 30, 2020 at 3:25 AM Wendy Liang wrote: AI engine is the acceleration engine provided by Xilinx. These engines provide high compute density for vector-based algorithms, and flexi

[PATCH -next] backlight: sky81452-backlight: convert comma to semicolon

2020-12-15 Thread Zheng Yongjun
Replace a comma between expression statements by a semicolon. Signed-off-by: Zheng Yongjun --- drivers/video/backlight/sky81452-backlight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlig

Re: [PATCH v3] drm: rockchip: hdmi: enable higher resolutions than FHD

2020-12-15 Thread Vicente Bergas
On Tue, Dec 1, 2020 at 5:06 PM Vicente Bergas wrote: > This patch enables a QHD HDMI monitor to work at native resolution. Please, anybody? ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-dev

memory leak in dlfb_usb_probe

2020-12-15 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:a68a0262 mm/madvise: remove racy mm ownership check git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1538046b50 kernel config: https://syzkaller.appspot.com/x/.config?x=4305fa9ea70c7a9f dashboard li

[v1] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu driver

2020-12-15 Thread Kalyan Thota
Turn off vblank irqs immediately as soon as drm_vblank_put is requested so that there are no irqs triggered during idle state. This will reduce cpu wakeups and help in power saving. The change also enable driver timestamp for vblanks. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu

Re: [PATCH v3 6/7] drm: Validate encoder->possible_crtcs

2020-12-15 Thread Jan Kiszka
On 03.12.20 22:30, Alex Deucher wrote: > On Tue, Sep 29, 2020 at 4:04 PM Alex Deucher wrote: >> >> On Tue, Sep 29, 2020 at 8:31 AM Jan Kiszka wrote: >>> >>> On 10.09.20 20:18, Deucher, Alexander wrote: [AMD Public Use] > -Original Message- > From: amd-gfx On B

[PATCH -next] fbdev: imsttfb: convert comma to semicolon

2020-12-15 Thread Zheng Yongjun
Replace a comma between expression statements by a semicolon. Signed-off-by: Zheng Yongjun --- drivers/video/fbdev/imsttfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/imsttfb.c b/drivers/video/fbdev/imsttfb.c index 3ac053b88495..6794770873f5 100644 -

[PATCH] drm/tegra: Use PTR_ERR_OR_ZERO() to simplify code

2020-12-15 Thread Tian Tao
Fixes coccicheck warning: drivers/gpu/drm/tegra/drm.c:350:1-3: WARNING: PTR_ERR_OR_ZERO can be used Signed-off-by: Tian Tao --- drivers/gpu/drm/tegra/drm.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index 19ff

[PATCH] drm/sun4i: hdmi: Use PTR_ERR_OR_ZERO() to simplify code

2020-12-15 Thread Tian Tao
Fixes coccicheck warning: drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c:281:1-3: WARNING: PTR_ERR_OR_ZERO can be used Signed-off-by: Tian Tao --- drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c b/drive

[PATCH] dma-buf: system_heap: Use PTR_ERR_OR_ZERO() to simplify code

2020-12-15 Thread Tian Tao
Fixes coccicheck warning: drivers/dma-buf/heaps/system_heap.c:437:1-3: WARNING: PTR_ERR_OR_ZERO can be used Signed-off-by: Tian Tao --- drivers/dma-buf/heaps/system_heap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/dma-buf/heaps/system_heap.c b/drivers/dma-bu

[PATCH] drm/hisilicon: Fix rmmod hibmc_drm failed

2020-12-15 Thread Tian Tao
drm_irq_uninstall should be called before pci_disable_msi, if use devm_drm_irq_install to register the interrupt, the system will call pci_disable_msi first and then call drm_irq_uninstall, which will result in the following callstack. kernel BUG at drivers/pci/msi.c:376! Internal error: Oops - B

[PATCH -next] fbdev: s3c2410fb: convert comma to semicolon

2020-12-15 Thread Zheng Yongjun
Replace a comma between expression statements by a semicolon. Signed-off-by: Zheng Yongjun --- drivers/video/fbdev/s3c2410fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/s3c2410fb.c b/drivers/video/fbdev/s3c2410fb.c index d8ae5258de46..d8da6bf3775d 10

KASAN: vmalloc-out-of-bounds Read in drm_fb_helper_dirty_work (2)

2020-12-15 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:a2f5ea9e Merge tag 'arm-soc-fixes-v5.10-4b' of git://git.k.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=167b497b50 kernel config: https://syzkaller.appspot.com/x/.config?x=868cd1c95c02180 dash

[PATCH] drm/hisilicon: Fix use-after-free

2020-12-15 Thread Tian Tao
Fix the problem of dev being released twice. [ cut here ] refcount_t: underflow; use-after-free. WARNING: CPU: 75 PID: 15700 at lib/refcount.c:28 refcount_warn_saturate+0xd4/0x150 CPU: 75 PID: 15700 Comm: rmmod Tainted: GE 5.10.0-rc3+ #3 Hardware name: Huawe

Re: Using Etnaviv with mxsfb-drm

2020-12-15 Thread Frieder Schrempf
Hi Lucas, On 14.12.20 14:06, Lucas Stach wrote: Hi Frieder, Am Montag, den 14.12.2020, 13:33 +0100 schrieb Frieder Schrempf: Hi Lucas, hi Marek, while doing some tests on i.MX8MM with Etnaviv and mxsfb-drm (using the patches for DSIM, GPC, BLK-CTL, etc., see branch at [1]), I noticed that I d

Using Etnaviv with mxsfb-drm

2020-12-15 Thread Frieder Schrempf
Hi Lucas, hi Marek, while doing some tests on i.MX8MM with Etnaviv and mxsfb-drm (using the patches for DSIM, GPC, BLK-CTL, etc., see branch at [1]), I noticed that I don't seem to be able to run glmark2: ~# glmark2-es2-drm === glmark2 2

[PATCH] udlfb: Fix memory leak in dlfb_usb_probe

2020-12-15 Thread qiang . zhang
From: Zqiang The dlfb_alloc_urb_list function is called in dlfb_usb_probe function, after that if an error occurs, the dlfb_free_urb_list function need to be called. BUG: memory leak unreferenced object 0x88810adde100 (size 32): comm "kworker/1:0", pid 17, jiffies 4294947788 (age 19.520s)

[PATCH -next] drm: omapdrm: Delete useless kfree code

2020-12-15 Thread Zheng Yongjun
The parameter of kfree function is NULL, so kfree code is useless, delete it. Signed-off-by: Zheng Yongjun --- drivers/gpu/drm/omapdrm/tcm-sita.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/tcm-sita.c b/drivers/gpu/drm/omapdrm/tcm-sita.c index 817be3c41863..af59e9

[PATCH v2 -next] drm/rockchip: cdn-dp-core: fix function not used when PM_SLEEP is not set

2020-12-15 Thread Randy Dunlap
Fix build warning when CONFIG_PM_SLEEP is not enabled. ../drivers/gpu/drm/rockchip/cdn-dp-core.c:1124:12: warning: ‘cdn_dp_resume’ defined but not used [-Wunused-function] static int cdn_dp_resume(struct device *dev) Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/res

Re: [PATCH 01/15] irqchip: Allow to compile bcmstb on other platforms

2020-12-15 Thread Maxime Ripard
Hi Marc, On Thu, Dec 10, 2020 at 05:59:09PM +, Marc Zyngier wrote: > On 2020-12-10 13:46, Maxime Ripard wrote: > > The BCM2711 uses a number of instances of the bcmstb-l2 controller in > > its > > display engine. Let's allow the driver to be enabled through KConfig. > > > > Signed-off-by: Max

[PATCH v1 1/1] drm: mxsfb: Silence -EPROBE_DEFER while waiting for bridge

2020-12-15 Thread Guido Günther
It can take multiple iterations until all components for an attached DSI bridge are up leading to several: [3.796425] mxsfb 3032.lcd-controller: Cannot connect bridge: -517 [3.816952] mxsfb 3032.lcd-controller: [drm:mxsfb_probe [mxsfb]] *ERROR* failed to attach bridge: -517 Silen

[PATCH v1 0/1] drm: mxsfb: Silence -EPROBE_DEFER while waiting for bridge

2020-12-15 Thread Guido Günther
It can take multiple iterations until all components for an attached DSI bridge are up leading to several: [3.796425] mxsfb 3032.lcd-controller: Cannot connect bridge: -517 [3.816952] mxsfb 3032.lcd-controller: [drm:mxsfb_probe [mxsfb]] *ERROR* failed to attach bridge: -517 Silen

Re: [PATCH 1/4] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_enable()

2020-12-15 Thread Guido Günther
Hi, On Tue, Dec 08, 2020 at 10:04:57AM +0100, Guido Günther wrote: > Hi, > On Fri, Dec 04, 2020 at 03:33:41PM +0800, Liu Ying wrote: > > The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp > > works with a Mixel MIPI DPHY + LVDS PHY combo to support either > > a MIPI DSI display or a

Re: linux-next: build warnings after merge of the drm tree

2020-12-15 Thread Daniel Vetter
On Tue, Dec 15, 2020 at 3:47 AM Stephen Rothwell wrote: > > Hi all, > > On Tue, 15 Dec 2020 06:50:45 +1100 Stephen Rothwell > wrote: > > > > On Mon, 16 Nov 2020 10:44:44 +1100 Stephen Rothwell > > wrote: > > > > > > On Thu, 5 Nov 2020 17:50:31 +1100 Stephen Rothwell > > > wrote: > > > > > >

Re: [PATCH v3 0/9] Xilinx AI engine kernel driver

2020-12-15 Thread Daniel Vetter
On Mon, Dec 14, 2020 at 04:24:17PM -0800, Jiaying Liang wrote: > > On 12/11/20 11:39 AM, Daniel Vetter wrote: > > Hi all > > > > On Fri, Dec 11, 2020 at 8:03 PM Alex Deucher wrote: > > > On Mon, Nov 30, 2020 at 3:25 AM Wendy Liang > > > wrote: > > > > AI engine is the acceleration engine provi

Re: [PATCH] udlfb: Fix memory leak in dlfb_usb_probe

2020-12-15 Thread Daniel Vetter
On Tue, Dec 15, 2020 at 02:30:22PM +0800, qiang.zh...@windriver.com wrote: > From: Zqiang > > The dlfb_alloc_urb_list function is called in dlfb_usb_probe function, > after that if an error occurs, the dlfb_free_urb_list function need to > be called. > > BUG: memory leak > unreferenced object 0x

Re: linux-next: manual merge of the drm tree with the crypto tree

2020-12-15 Thread Geert Uytterhoeven
On Mon, Dec 14, 2020 at 2:44 PM Stephen Rothwell wrote: > Today's linux-next merge of the drm tree got a conflict in: > > MAINTAINERS > > between commit: > > 885743324513 ("crypto: keembay - Add support for Keem Bay OCS AES/SM4") > > from the crypto tree and commit: > > ed794057b052 ("drm/km

Re: [PATCH v1 1/1] drm: mxsfb: Silence -EPROBE_DEFER while waiting for bridge

2020-12-15 Thread Daniel Vetter
On Tue, Dec 15, 2020 at 09:23:38AM +0100, Guido Günther wrote: > It can take multiple iterations until all components for an attached DSI > bridge are up leading to several: > > [3.796425] mxsfb 3032.lcd-controller: Cannot connect bridge: -517 > [3.816952] mxsfb 3032.lcd-controller

[radeon-alex:amd-20.45 1953/2427] drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dce60/dce60_clk_mgr.c:83:5: warning: no previous prototype for function 'dce60_get_dp_ref_freq_khz'

2020-12-15 Thread kernel test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-20.45 head: a3950d94b046fb206e58fd3ec717f071c0203ba3 commit: e809646e73921328d66a2fbfddf067b9cdb30998 [1953/2427] drm/amd/display: enable SI support in the Kconfig (v2) config: x86_64-randconfig-a001-20201214 (attached as .config) compile

[radeon-alex:amd-20.45 198/2427] ./usr/include/drm/amdgpu_drm.h:314:2: error: unknown type name 'int32_t'

2020-12-15 Thread kernel test robot
Hi Kevin, FYI, the error/warning still remains. tree: git://people.freedesktop.org/~agd5f/linux.git amd-20.45 head: a3950d94b046fb206e58fd3ec717f071c0203ba3 commit: 641803ba0aabf8d823eb6cf6667dda3fdca58872 [198/2427] drm/amdgpu: [hybrid] add semaphore object support config: x86_64-randconfig

[PATCH] drm/amdgpu: Fix spelling mistake "Heterogenous" -> "Heterogeneous"

2020-12-15 Thread Colin King
From: Colin Ian King There is a spelling mistake in a comment in the Kconfig. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdkfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfi

Re: [PATCH v6 5/9] drm/vc4: hdmi: Create a custom connector state

2020-12-15 Thread Dave Stevenson
Hi Maxime On Thu, 10 Dec 2020 at 14:23, Maxime Ripard wrote: > > When run with a higher bpc than 8, the clock of the HDMI controller needs > to be adjusted. Let's create a connector state that will be used at > atomic_check and atomic_enable to compute and store the clock rate > associated to the

Re: [PATCH v6 9/9] drm/vc4: hdmi: Enable 10/12 bpc output

2020-12-15 Thread Dave Stevenson
Hi Maxime On Thu, 10 Dec 2020 at 14:23, Maxime Ripard wrote: > > The BCM2711 supports higher bpc count than just 8, so let's support it in > our driver. > > Signed-off-by: Maxime Ripard Looks good to me, but is impacted by the comment I've just made on 5/9. Dave > --- > drivers/gpu/drm/vc

Re: [PATCH v2 5/9] drm: rcar-du: Use DRM-managed allocation for encoders

2020-12-15 Thread Jacopo Mondi
Hi Laurent, On Mon, Dec 14, 2020 at 10:52:04PM +0200, Laurent Pinchart wrote: > devm_kzalloc() is the wrong API to allocate encoders, as the lifetime of > the encoders is tied to the DRM device, not the device to driver > binding. drmm_kzalloc() isn't a good option either, as it would result > in

Re: [PATCH v2 4/9] drm: rcar-du: Use DRM-managed allocation for VSP planes

2020-12-15 Thread Jacopo Mondi
Hi Laurent, On Mon, Dec 14, 2020 at 10:52:03PM +0200, Laurent Pinchart wrote: > devm_kcalloc() is the wrong API to allocate planes, as the lifetime of > the planes is tied to the DRM device, not the device to driver > binding. drmm_kcalloc() isn't a good option either, as it would result > in the

Re: [PATCH 03/15] drm/vc4: hdmi: Fix register offset with longer CEC messages

2020-12-15 Thread Dave Stevenson
Hi Dom & Maxime On Thu, 10 Dec 2020 at 13:46, Maxime Ripard wrote: > > From: Dom Cobley > > The code prior to 311e305fdb4e ("drm/vc4: hdmi: Implement a register > layout abstraction") was relying on the fact that the register offset > was incremented by 4 for each readl call. That worked since t

Re: [PATCH] drm: rcar-du: fix reference leak in rcar_cmm_enable

2020-12-15 Thread Jacopo Mondi
Hello Qinglang, On Fri, Nov 27, 2020 at 05:44:44PM +0800, Qinglang Miao wrote: > pm_runtime_get_sync will increment pm usage counter even it > failed. Forgetting to putting operation will result in a > reference leak here. > > A new function pm_runtime_resume_and_get is introduced in > [0] to keep

Re: [PATCH drm/hisilicon 1/2] drm/irq: Add the new api to enable pci msi

2020-12-15 Thread Daniel Vetter
On Tue, Dec 15, 2020 at 07:48:52PM +0800, Tian Tao wrote: > Add new api devm_drm_msi_install() to register interrupts, > no need to call pci_disable_msi() when the drm module is removed. > > Signed-off-by: Tian Tao > --- > drivers/gpu/drm/drm_irq.c | 33 + > inclu

Re: [PATCH] drm/hisilicon: Fix rmmod hibmc_drm failed

2020-12-15 Thread Daniel Vetter
On Tue, Dec 15, 2020 at 11:01:39AM +0800, Tian Tao wrote: > drm_irq_uninstall should be called before pci_disable_msi, if use > devm_drm_irq_install to register the interrupt, the system will > call pci_disable_msi first and then call drm_irq_uninstall, which > will result in the following callsta

Re: [PATCH] drm/hisilicon: Fix rmmod hibmc_drm failed

2020-12-15 Thread Daniel Vetter
On Tue, Dec 15, 2020 at 12:59:53PM +0100, Daniel Vetter wrote: > On Tue, Dec 15, 2020 at 11:01:39AM +0800, Tian Tao wrote: > > drm_irq_uninstall should be called before pci_disable_msi, if use > > devm_drm_irq_install to register the interrupt, the system will > > call pci_disable_msi first and the

Re: [PATCH v6 1/5] drm: Add function to convert rect in 16.16 fixed format to regular format

2020-12-15 Thread Mun, Gwan-gyeong
On Mon, 2020-12-14 at 09:49 -0800, José Roberto de Souza wrote: > Much more clear to read one function call than four lines doing this > conversion. > > Cc: dri-devel@lists.freedesktop.org > Cc: Gwan-gyeong Mun > Signed-off-by: José Roberto de Souza > --- > drivers/gpu/drm/drm_rect.c | 15 +

[PULL] drm-misc-next-fixes

2020-12-15 Thread Thomas Zimmermann
Hi Dave and Daniel, here's this week's PR for drm-misc-next-fixes. IIRC the radeon fix is already in drm-misc-next. Best regards Thomas drm-misc-next-fixes-2020-12-15: Short summary of fixes pull (less than what git shortlog provides): * dma-buf: Fix docs * mxsfb: Silence invalid error messag

Re: [PATCH v6 1/5] drm: Add function to convert rect in 16.16 fixed format to regular format

2020-12-15 Thread Souza, Jose
On Tue, 2020-12-15 at 12:52 +, Mun, Gwan-gyeong wrote: > On Mon, 2020-12-14 at 09:49 -0800, José Roberto de Souza wrote: > > Much more clear to read one function call than four lines doing this > > conversion. > > > > Cc: dri-devel@lists.freedesktop.org > > Cc: Gwan-gyeong Mun > > Signed-off-

Re: [PATCH v2, 07/17] drm/mediatek: add disp config and mm 26mhz clock into mutex device

2020-12-15 Thread Nicolas Boichat
On Sat, Dec 12, 2020 at 12:12 PM Yongqiang Niu wrote: > > there are 2 more clock need enable for display. > parser these clock when mutex device probe, > enable and disable when mutex on/off > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 49 > +

Re: [PATCH v2, 14/17] soc: mediatek: mmsys: Use function call for setting mmsys ovl mout register

2020-12-15 Thread Nicolas Boichat
On Sat, Dec 12, 2020 at 12:13 PM Yongqiang Niu wrote: > > Use function call for setting mmsys ovl mout register > > Signed-off-by: Yongqiang Niu > --- > drivers/soc/mediatek/mmsys/mtk-mmsys.c | 18 ++ > include/linux/soc/mediatek/mtk-mmsys.h | 3 +++ > 2 files changed, 21 insert

Re: [PATCH v5 29/29] drm/omap: dsi: allow DSI commands to be sent early

2020-12-15 Thread Tomi Valkeinen
Hi Sebastian, On 14/12/2020 19:17, Sebastian Reichel wrote: Hi, On Tue, Dec 08, 2020 at 02:28:55PM +0200, Tomi Valkeinen wrote: Panel drivers can send DSI commands in panel's prepare(), which happens before the bridge's enable() is called. The OMAP DSI driver currently only sets up the DSI int

Re: [PATCH v3 2/3] drm/amd/display: Add freesync video modes based on preferred modes

2020-12-15 Thread Aurabindo Pillai
On Tue, 2020-12-15 at 08:32 +0530, Shashank Sharma wrote: > > On 15/12/20 3:50 am, Aurabindo Pillai wrote: > > [Why&How] > > If experimental freesync video mode module parameter is enabled, > > add > > few extra display modes into the driver's mode list corresponding > > to common > > video frame

Re: [PATCH] dma-buf: begin/end_cpu might lock the dma_resv lock

2020-12-15 Thread Christian König
Am 14.12.20 um 18:16 schrieb Daniel Vetter: At least amdgpu and i915 do, so lets just document this as the rule. v2: Works better with less typos (intel-gfx-ci) Signed-off-by: Daniel Vetter Cc: Thomas Zimmermann Cc: Sumit Semwal Cc: "Christian König" Cc: linux-me...@vger.kernel.org Cc: lina

Re: [PATCH 1/4] dma-buf: Remove kmap kerneldoc vestiges

2020-12-15 Thread Christian König
Am 14.12.20 um 17:01 schrieb Daniel Vetter: On Mon, Dec 14, 2020 at 11:33:10AM +0100, Christian König wrote: Am 11.12.20 um 16:58 schrieb Daniel Vetter: Also try to clarify a bit when dma_buf_begin/end_cpu_access should be called. Signed-off-by: Daniel Vetter Cc: Thomas Zimmermann Cc: Sumit

Re: [radeon-alex:amd-20.45 2127/2427] drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1880:39: sparse: sparse: incorrect type in argument 1 (different base types)

2020-12-15 Thread Deucher, Alexander
[AMD Public Use] The test robot should probably not be testing the amd-20.xx branches in the first place. They are just mirrors of our packaged drivers so they contain a bunch of stuff that will never go upstream like kernel compatibility layers and dkms support. Alex ___

Re: [PATCH] dt-bindings: display: bridge: tc358768: Remove maintainer information

2020-12-15 Thread Rob Herring
On Tue, 15 Dec 2020 14:42:27 +0200, Peter Ujfalusi wrote: > My employment with TI is coming to an end and I will not have access to > the board where this bridge is connected to. > > It is better to remove a soon bouncing email address. > > Signed-off-by: Peter Ujfalusi > --- > .../devicetree/b

[PATCH] drm/amdgpu: remove h from printk format specifier

2020-12-15 Thread trix
From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. Signed-off-by: Tom Rix --- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 +

[PATCH] drm/i915: remove h from printk format specifier

2020-12-15 Thread trix
From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. Signed-off-by: Tom Rix --- drivers/gpu/drm/i915/gt/intel_sseu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_sseu.c

[PATCH] drm/radeon: remove h from printk format specifier

2020-12-15 Thread trix
From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. Signed-off-by: Tom Rix --- drivers/gpu/drm/radeon/radeon_uvd.c | 2 +- drivers/gpu/drm/radeon/radeon_vce.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH v6 1/5] drm: Add function to convert rect in 16.16 fixed format to regular format

2020-12-15 Thread Ville Syrjälä
On Mon, Dec 14, 2020 at 09:49:08AM -0800, José Roberto de Souza wrote: > Much more clear to read one function call than four lines doing this > conversion. > > Cc: dri-devel@lists.freedesktop.org > Cc: Gwan-gyeong Mun > Signed-off-by: José Roberto de Souza > --- > drivers/gpu/drm/drm_rect.c | 1

Re: [PATCH v2, 15/17] soc: mediatek: mmsys: add mt8192 mmsys support

2020-12-15 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年12月14日 週一 上午8:39寫道: > > On Mon, 2020-12-14 at 00:02 +0800, Chun-Kuang Hu wrote: > > Hi, Yongqiang: > > > > Yongqiang Niu 於 2020年12月12日 週六 下午12:22寫道: > > > > > > add mt8192 mmsys support > > > > > > Signed-off-by: Yongqiang Niu > > > --- > > > drivers/soc/med

[PATCH v6 04/84] drm/omap: constify write buffers

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel The write buffers are not modified, so they can be constant. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/dsi.c | 24 drivers/gpu/drm/omapdrm/dss/omapdss.h | 1

[PATCH v6 21/84] drm/omap: dsi: use pixel-format and mode from attach

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel In order to reduce the amount of custom functionality, this moves handling of pixel format and DSI mode from set_config() to dsi attach. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 2 -- drivers/gp

[PATCH v6 07/84] drm/omap: dsi: unexport specific data transfer functions

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel After converting all DSI drivers, unexport the specific transfer functions. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/dsi.c | 12 drivers/gpu/drm/omapdrm/dss/omapdss.h

[PATCH v6 03/84] drm/omap: dsi: use MIPI_DSI_FMT_* instead of OMAP_DSS_DSI_FMT_*

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel This replaces OMAP specific enum for pixel format with common implementation. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 2 +- drivers/gpu/drm/omapdrm/dss/dsi.c

[PATCH v6 01/84] Revert "drm/omap: dss: Remove unused omap_dss_device operations"

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel This reverts commit e086558ae923 ("drm/omap: dss: Remove unused omap_dss_device operations") This is still needed by DSI. E.g. unloading modules without this will cause a crash. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchar

[PATCH v6 14/84] drm/omap: dsi: request VC via mipi_dsi_attach

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel Drop custom request_vc/release_vc callbacks by using the generic mipi_dsi_attach/mipi_dsi_detach functions. To use mipi_dsi_attach() we need to fill in the mipi_dsi_device fields, and some of these fields overlap with the fields in omap_dss_dsi_config. In later patches th

[PATCH v6 22/84] drm/omap: panel-dsi-cm: use bulk regulator API

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel Use bulk regulator API to simplify the code. This also switches from _optional variant to normal variant, which will provide a dummy regulator (i.e. if some always-enabled regulator is not described in DT). Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen

[PATCH v6 24/84] drm/omap: dsi: move TE GPIO handling into core

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel In preparation for removing custom DSS calls from the DSI panel driver, this moves support for external tearing event GPIOs into the DSI host driver. This way tearing events are always handled in the core resulting in simplification of the panel drivers. The TE GPIO acqui

[PATCH v6 09/84] drm/omap: dsi: simplify write function

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel Simplify the write related messages handling by using the functionality provided by CONFIG_DRM_MIPI_DSI. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/Kconfig | 1 + drivers/gpu/drm/omapd

[PATCH v6 16/84] drm/omap: panel-dsi-cm: use common MIPI DCS 1.3 defines

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel Drop local definition of common MIPI DCS 1.3 defines. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff

[PATCH v6 11/84] drm/omap: dsi: switch dsi_vc_send_long/short to mipi_dsi_msg

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel Simplify the DSI encoder by using mipi_dsi_msg for dsi_vc_send_long and dsi_vc_send_short. Further improvements require cleaning up the channel allocation code first. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- driv

[PATCH v6 08/84] drm/omap: dsi: drop virtual channel logic

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel This drops the virtual channel logic. Afterwards DSI clients request their channel number and get the virtual channel with the same number or -EBUSY if already in use. The change here is not strictly speaking correct, as it combines the VC (DSI's "configuration block") an

[PATCH v6 13/84] drm/omap: panel-dsi-cm: use DSI helpers

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel After converting the driver to mipi_dsi_device we can use the generic message helpers to simplify the driver a lot. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 125 +++

[PATCH v6 00/84] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-12-15 Thread Tomi Valkeinen
Hi, This is the sixth and hopefully last version of the OMAP DSI conversion series. The previous version is here: https://www.spinics.net/lists/linux-omap/msg157795.html This version has only cosmetic changes and added reviewed-bys, and I'm mainly sending this so that I'm able to dim apply it. b

[PATCH v6 02/84] drm/omap: drop unused dsi.configure_pins

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel The panel-dsi-cm's ddata->pin_config is always NULL, so this callback is never called. Instead the DSI encoder gets the pin configuration directly from DT. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm

[PATCH v6 05/84] drm/omap: dsi: add generic transfer function

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel This prepares the driver for becoming a mipi_dsi_host implementation, which provides a generic transfer function instead of all kind of different read/write functions. The implementation will become more elegant after unexporting the specific functions in the following pat

[PATCH v6 10/84] drm/omap: dsi: simplify read functions

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel Simplify the read related message handling by using the functionality provided by CONFIG_DRM_MIPI_DSI. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/dsi.c | 110 +---

[PATCH v6 12/84] drm/omap: dsi: introduce mipi_dsi_host

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel This moves from custom platform driver infrastructure to mipi_dsi_host and mipi_dsi_device. Note, that this is a graduate step and the driver only uses the devices types and transfer function, but not yet the new device binding style or drm_panel. Signed-off-by: Sebastian

[PATCH v6 15/84] drm/omap: panel-dsi-cm: drop hardcoded VC

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel Use dsi->channel everywhere, which originates from DT. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 20 +++ 1 file changed, 7 insertions(+), 13 deletion

[PATCH v6 06/84] drm/omap: panel-dsi-cm: convert to transfer API

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel This converts the panel-dsi-cm driver to use the transfer API instead of specific functions, so that the specific functions can be unexported and squashed into the generic transfer function. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Acked-by: Lauren

[PATCH v6 19/84] drm/omap: dsi: drop unused enable_te()

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel enable_te() is not used, so the custom API can be dropped. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 39 --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 - 2 files changed,

[PATCH v6 25/84] drm/omap: dsi: drop custom enable_te() API

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel Instead of using the custom enable_te() API, this automatically enables/disables TE core support when a matching packet is sent to the panel. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- .../gpu/drm/omapdrm/displays/

Re: [PATCH] drm/amdgpu: remove h from printk format specifier

2020-12-15 Thread Christian König
Am 15.12.20 um 15:38 schrieb t...@redhat.com: From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. In general looks valid to me, but my question is how does that work? I mean we specify h here because it is a short int. A

[PATCH v6 29/84] drm/omap: dsi: move panel refresh function to host

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel This moves the panel refresh/update function from the panel driver into the DSI host driver to prepare for common drm_panel support. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 68 -- dr

[PATCH v6 48/84] drm/omap: dsi: simplify pin config

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel Simplify DSI pin config, which always originates from DT nowadays. With the code being fully contained in the DSI encoder, we can drop the public structure. Since the function is no longer exposed, it now directly takes the private DSI data pointer. This drops a pointless

[PATCH v6 41/84] drm/omap: remove legacy DSS device operations

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel All DSS devices have been converted to bridge API, so the device operations are always NULL. This removes the device ops function pointers and all code using it. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/g

[PATCH v6 52/84] drm/omap: drop unused owner field

2020-12-15 Thread Tomi Valkeinen
dssdev->owner is set, but never used. We can drop the field. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart Reviewed-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/dpi.c | 1 - drivers/gpu/drm/omapdrm/dss/dsi.c | 1 - drivers/gpu/drm/omapdrm/dss/hdmi4.c | 1 - dri

[PATCH v6 18/84] drm/omap: dsi: drop unused get_te()

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel The get_te() callback is not used, so we can drop the custom API. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 13 - drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 - 2 files chan

[PATCH v6 23/84] drm/omap: dsi: lp/hs switching support for transfer()

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel Integrate low-power / high-speed bus switching into transfer function and drop the omapdrm specific enable_hs() callback. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c |

[PATCH v6 35/84] drm/omap: panel-dsi-cm: use DEVICE_ATTR_RO

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel Use DEVICE_ATTR_RO helper instead of plain DEVICE_ATTR, which makes the code a bit shorter and easier to read. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 8

[PATCH v6 56/84] drm/panel: panel-dsi-cm: cleanup tear enable

2020-12-15 Thread Tomi Valkeinen
Simplify the code by moving code from _dsicm_enable_te() into dsicm_power_on(). Signed-off-by: Tomi Valkeinen Reviewed-by: Sam Ravnborg Reviewed-by: Laurent Pinchart Reviewed-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-dsi-cm.c | 23 --- 1 file changed, 4 inserti

[PATCH v6 43/84] drm/omap: simplify omap_display_id

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel We no longer need to check for the DSS API, since all encoders, panels and connectors have been converted to the bridge API. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_drv.c | 9 +--

[PATCH v6 37/84] drm/omap: panel-dsi-cm: fix remove()

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel Do not try to reset the panel after DSI has been detached, since the DSI clocks may have been disabled at this point. The panel will be disabled and unprepared before being removed and a reset will be done when being probed again. Signed-off-by: Sebastian Reichel Signed-

[PATCH v6 59/84] drm/omap: dsi: set trans_mode according to client mode_flags

2020-12-15 Thread Tomi Valkeinen
The DSI host driver currently ignores the video mode flags in client->mode_flags. Add the code to take the transfer mode from client's mode_flags. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart Reviewed-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/dsi.c | 7 +++ 1 fil

[PATCH v6 26/84] drm/omap: dsi: do bus locking in host driver

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel This moves the bus locking into the host driver and unexports the custom API in preparation for drm_panel support. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 44 +-- drivers/gpu/drm

[PATCH v6 50/84] drm/omap: squash omapdrm sub-modules into one

2020-12-15 Thread Tomi Valkeinen
At the moment we have three different modules: omapdss-base, omapdss, omapdrm. This setup is finally obsolete, as the last omapdrm specific panel has been converted to DRM panel. We can thus remove omapdss-base and omapdss, and just compile everything into omapdrm.ko. Signed-off-by: Tomi Valkeine

[PATCH v6 32/84] drm/omap: dsi: convert to drm_panel

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel This converts the DSI module to expect common drm_panel display drivers instead of dssdev based ones. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 203 +++--- drivers/gpu/drm/omapdrm/dss/

[PATCH v6 31/84] drm/omap: dsi: drop custom panel capability support

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel Due to previous changes the DSI encoder gets the capabilities via DSI client's mode_flags and no longer needs the omapdss specific caps. The core code now checks if the DSI encoder is actually configured into command mode instead of just checking the panel capabilities. S

[PATCH v6 20/84] drm/omap: dsi: drop useless sync()

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel The DSI sync() function only locks the bus and then releases it again. Currently the only invocation is directly before update(), which locks the bus anyways. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c

[PATCH v6 34/84] drm/omap: dsi: implement check timings

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel Implement check timings, which will check if it's possible to configure the clocks for the provided mode using the same code as the set_config() hook. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c | 70

[PATCH v6 44/84] drm/omap: drop unused DSS next pointer

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel Since all encoders and panels are using the bridge API now, we next pointer is no longer useful and can be dropped. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/base.c | 2 +- drivers

[PATCH v6 33/84] drm/omap: drop omapdss-boot-init

2020-12-15 Thread Tomi Valkeinen
From: Sebastian Reichel The table of compatible values needed to be prefixed with "omapdss," is empty, so all of this code is doing nothing now. Let's drop it. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/Kconfig

[PATCH v6 54/84] drm/omap: remove dss_mgr_ops

2020-12-15 Thread Tomi Valkeinen
dss_mgr_ops was needed with the multi-module architecture, but is no longer needed. We can thus remove it and use direct calls. Signed-off-by: Tomi Valkeinen Acked-by: Laurent Pinchart Reviewed-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/dss.h | 1 - drivers/gpu/drm/omapdrm/dss/

  1   2   3   >