Re: [PATCH drm/hisilicon 1/2] drm/hisilicon: Use managed mode-config init

2020-12-07 Thread Thomas Zimmermann
Hi Am 07.12.20 um 01:49 schrieb Tian Tao: Using drmm_mode_config_init() sets up managed release of modesetting resources. Signed-off-by: Tian Tao --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/gpu

Re: [PATCH drm/hisilicon 2/2] drm/hisilicon: Delete unused local parameters

2020-12-07 Thread Thomas Zimmermann
Am 07.12.20 um 01:49 schrieb Tian Tao: delete unused variable ‘priv’ to avoid warning. Signed-off-by: Tian Tao Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/his

Re: [PATCH 1/9] drm: rcar-du: Fix crash when using LVDS1 clock for CRTC

2020-12-07 Thread Geert Uytterhoeven
Hi Laurent, On Fri, Dec 4, 2020 at 11:02 PM Laurent Pinchart wrote: > On D3 and E3 platforms, the LVDS encoder includes a PLL that can > generate a clock for the corresponding CRTC, used even when the CRTC > output to a non-LVDS port. This mechanism is supported by the driver, > but the implement

Re: [PATCH v3 02/13] video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify

2020-12-07 Thread Thomas Zimmermann
Hi Am 06.12.20 um 20:37 schrieb Randy Dunlap: On 12/6/20 11:02 AM, Sam Ravnborg wrote: Fix kernel-doc warnings reported when using W=1 v2: - Improve subject (Lee) v3: - Add RETURNS documentation (Thomas) Hi Sam, Yes, RETURNS: will work. It just looks like any kernel-doc section name,

Re: [PATCH v3 03/13] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core

2020-12-07 Thread Thomas Zimmermann
Am 06.12.20 um 20:02 schrieb Sam Ravnborg: Fix a few W=1 warnings about unused assignments. Drop the unused error code. v2: - Subject updated (Lee) Signed-off-by: Sam Ravnborg Cc: Sam Ravnborg Cc: Qilong Zhang Cc: "Alexander A. Klimov" Cc: Daniel Vetter Cc: Lee Jones Acked-by: Thom

Re: [PATCH v3 04/13] video: fbdev: uvesafb: Fix set but not used warning

2020-12-07 Thread Thomas Zimmermann
Am 06.12.20 um 20:02 schrieb Sam Ravnborg: Fix W=1 warning by deleting unused local variable. v2: - Updated subject (Lee) v3: - Return early in case of an error (Thomas) Signed-off-by: Sam Ravnborg Cc: Michal Januszewski Cc: linux-fb...@vger.kernel.org Cc: Lee Jones Acked-by: Thom

Re: [PATCH v3 05/13] sh: Fix set but not used warnings with !CONFIG_MMU

2020-12-07 Thread Thomas Zimmermann
Am 06.12.20 um 20:02 schrieb Sam Ravnborg: Building fbdev drivers for sh with W=1 produces the following warning: tmiofb.c: In function ‘tmiofb_remove’: tmiofb.c:805:21: warning: variable ‘par’ set but not used This is with allmodconfig and ARCH=sh This boiled down to iounmap() def

Re: [PATCH v3 06/13] video: fbdev: sparc drivers: fix kernel-doc warnings for blank_mode

2020-12-07 Thread Thomas Zimmermann
Am 06.12.20 um 20:02 schrieb Sam Ravnborg: Fix kernel-doc warnings caused by a wrong parameter name blank_mode => blank Signed-off-by: Sam Ravnborg Cc: Sam Ravnborg Acked-by: Thomas Zimmermann --- drivers/video/fbdev/bw2.c | 2 +- drivers/video/fbdev/cg3.c | 2 +- drivers/video/

Re: [PATCH] drm: drivers may provide multiple primary planes per CRTC

2020-12-07 Thread Pekka Paalanen
On Sun, 06 Dec 2020 15:24:29 + Simon Ser wrote: > Sorry, I think I lost track of this thread at some point and forgot > about it. That said… > > On Friday, August 7th, 2020 at 3:06 PM, Daniel Vetter wrote: > > > On Fri, Aug 07, 2020 at 12:38:02PM +0300, Pekka Paalanen wrote: > > > On Fri

Re: [PATCH] drm: Fix drm.h uapi header for Windows

2020-12-07 Thread Pekka Paalanen
On Fri, 4 Dec 2020 11:07:41 -0800 James Park wrote: > I could adjust the block to look like this: > > #ifdef DRM_FOURCC_STANDALONE > #if defined(__linux__) > #include > #else > #include > typedef uint32_t __u32; > typedef uint64_t __u64; > #endif > #else > #include "drm.h" > #endif > > Altern

[PATCH v2 5/7] drm/vc4: kms: Remove unassigned_channels from the HVS state

2020-12-07 Thread Maxime Ripard
The HVS state now has both unassigned_channels that reflects the channels that are not used in the associated state, and the in_use boolean for each channel that says whether or not a particular channel is in use. Both express pretty much the same thing, and we need the in_use variable to properly

Re: [PATCH 1/1] dt-bindings: eliminate yamllint warnings

2020-12-07 Thread Leizhen (ThunderTown)
On 2020/12/5 1:41, Mark Brown wrote: > On Fri, Dec 04, 2020 at 10:42:26AM +0800, Zhen Lei wrote: >> All warnings are related only to "wrong indentation", except one: >> Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml:4:1: \ >> [error] missing document start "---" (document-start) > >

Re: [PATCH 2/2] drm/ingenic: depend on COMMON_CLK to fix compile tests

2020-12-07 Thread Paul Cercueil
Hi Krzysztof, Le ven. 4 déc. 2020 à 10:18, Krzysztof Kozlowski a écrit : On Mon, Nov 16, 2020 at 07:54:03PM +, Paul Cercueil wrote: Hi Krzysztof, Le lun. 16 nov. 2020 à 18:53, Krzysztof Kozlowski a écrit : > The Ingenic DRM uses Common Clock Framework thus it cannot be built on

[PATCH v6 3/5] ARM: dts: rockchip: rk3066a: add #sound-dai-cells to hdmi node

2020-12-07 Thread Johan Jonker
'#sound-dai-cells' is required to properly interpret the list of DAI specified in the 'sound-dai' property, so add them to the 'hdmi' node for 'rk3066a.dtsi'. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/rk30

Re: [PATCH v3 1/4] irq: export kstat_irqs

2020-12-07 Thread Thomas Gleixner
Jerry, On Fri, Dec 04 2020 at 18:43, Jerry Snitselaar wrote: The proper prefix is 'genirq:' git log kernel/irq/irqdesc.c would have told you. > To try and detect potential interrupt storms that > have been occurring with tpm_tis devices it was suggested > to use kstat_irqs() to get the number o

[PATCH v2 0/1] dt-bindings: display: eliminate yamllint warnings

2020-12-07 Thread Zhen Lei
This patch is based on the latest linux-next code. v1 --> v2: Extract the modification of the Documentation/devicetree/bindings/display/ parts and send the patch separately. https://www.spinics.net/lists/arm-kernel/msg860713.html v1: There're too many people, I just send to the maintainer, revi

Re: [PATCH v3 2/4] drm/i915/pmu: Use kstat_irqs to get interrupt count

2020-12-07 Thread Thomas Gleixner
On Sun, Dec 06 2020 at 14:47, Jerry Snitselaar wrote: > Thomas Gleixner @ 2020-12-06 09:38 MST: > > I don't know the history behind this bit. I stumbled across it in cscope > when looking for places using kstat_irqs. I'm not ranting at you. The i915 people are on Cc. __

[PATCH v6 2/5] drm: rockchip: add sound support to rk3066 hdmi driver

2020-12-07 Thread Johan Jonker
From: Zheng Yang Add sound support to the rk3066 HDMI driver. The I2S input of the HDMI TX allows transmission of DVD-Audio and decoded Dolby Digital to A/V Receivers and high-end displays. The interface supports 2 to 8 channels audio up to 192 kHz. The HDMI TX supports variable word length of 1

[PATCH v3 2/6] dt-bindings: display: imx: Add i.MX8qxp/qm PRG binding

2020-12-07 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Gasket. Signed-off-by: Liu Ying --- Note that this depends on the 'two cell binding' clock patch set which has already landed in Shawn's i.MX clk/imx git branch. Otherwise, imx8-lpcg.h won't be found. v2->v3: * No change. v1->v2

Re: [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-12-07 Thread Viresh Kumar
On 19-11-20, 11:35, Viresh Kumar wrote: > On 18-11-20, 08:53, Rob Clark wrote: > > On Tue, Nov 17, 2020 at 9:28 PM Viresh Kumar > > wrote: > > > > > > On 17-11-20, 09:02, Rob Clark wrote: > > > > With that on top of the previous patch, > > > > > > Don't you still have this ? Which fixed the lockd

Re: [PATCH v3 1/4] irq: export kstat_irqs

2020-12-07 Thread Thomas Gleixner
On Sat, Dec 05 2020 at 12:39, Jarkko Sakkinen wrote: > On Fri, Dec 04, 2020 at 06:43:37PM -0700, Jerry Snitselaar wrote: >> To try and detect potential interrupt storms that >> have been occurring with tpm_tis devices it was suggested >> to use kstat_irqs() to get the number of interrupts. >> Since

[PATCH v6 4/5] ARM: dts: rockchip: add hdmi-sound node to rk3066a.dtsi

2020-12-07 Thread Johan Jonker
Add hdmi-sound node to rk3066a.dtsi, so that it can be reused by boards with HDMI support. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/rk3066a.dtsi b/arch/arm/boot/dts/rk3066a.dtsi index 67

Re: [PATCH v3 02/13] video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify

2020-12-07 Thread Randy Dunlap
On 12/6/20 11:02 AM, Sam Ravnborg wrote: > Fix kernel-doc warnings reported when using W=1 > > v2: > - Improve subject (Lee) > > v3: > - Add RETURNS documentation (Thomas) Hi Sam, Yes, RETURNS: will work. It just looks like any kernel-doc section name, such as Context: or Note:. However, th

[PATCH v3 4/6] drm/atomic: Avoid unused-but-set-variable warning on for_each_old_plane_in_state

2020-12-07 Thread Liu Ying
Artifically use 'plane' and 'old_plane_state' to avoid 'not used' warning. The precedent has already been set by other macros in the same file. Signed-off-by: Liu Ying --- v2->v3: * Add a missing blank line. v1->v2: * No change. include/drm/drm_atomic.h | 5 - 1 file changed, 4 insertions(

[PATCH v2 7/7] drm/vc4: kms: Convert to atomic helpers

2020-12-07 Thread Maxime Ripard
Now that the semaphore is gone, our atomic_commit implementation is basically drm_atomic_helper_commit with a somewhat custom commit_tail, the main difference being that we're using wait_for_flip_done instead of wait_for_vblanks used in the drm_atomic_helper_commit_tail helper. Let's switch to usi

Re: [RFC PATCH 1/2] drm: RFC add choice to use dynamic debug in drm-debug

2020-12-07 Thread jim . cromie
On Fri, Dec 4, 2020 at 8:42 AM Ville Syrjälä wrote: > > On Thu, Dec 03, 2020 at 08:53:17PM -0700, Jim Cromie wrote: > > drm's debug system uses distinct categories of debug messages, mapped > > to bits in drm.debug. Currently, code does a lot of unlikely bit-mask > > checks on drm.debug (in drm_d

Re: [PATCH] drm: Allow drm_fourcc.h without including drm.h

2020-12-07 Thread James Park
The typedefs might also conflict on Linux if DRM_FOURCC_STANDALONE is enabled with whatever LInux declared __u32/__u64 as, but I think the implication is that once DRM_FOURCC_STANDALONE has been declared, that's kind of a promise not to include drm.h. I'm fine with this, but I'm not married to it

[PATCH v3 6/6] MAINTAINERS: add maintainer for i.MX8qxp DPU DRM driver

2020-12-07 Thread Liu Ying
Add myself as the maintainer of the i.MX8qxp DPU DRM driver. Signed-off-by: Liu Ying --- v2->v3: * No change. v1->v2: * No change. MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 970d9ce..dee4586 100644 --- a/MAINTAINERS +++ b/MAINTAINER

[PATCH v2 6/7] drm/vc4: kms: Remove async modeset semaphore

2020-12-07 Thread Maxime Ripard
Now that we have proper ordering guaranteed by the previous patch, the semaphore is redundant and can be removed. Acked-by: Thomas Zimmermann Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 13 - drivers/gpu/drm/vc4/vc4_drv.h | 2 -- drivers/gpu/drm/vc4/vc4_kms.c

[PATCH v3 1/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPU binding

2020-12-07 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Processing Unit. Signed-off-by: Liu Ying --- Note that this depends on the 'two cell binding' clock patch set which has already landed in Shawn's i.MX clk/imx git branch. Otherwise, imx8-lpcg.h won't be found. v2->v3: * No change. v1->v2: * Fix

[RFC PATCH v1 06/12] omap: Replace strstarts() by str_has_prefix().

2020-12-07 Thread laniel_francis
From: Francis Laniel The two functions indicates if a string begins with a given prefix. The only difference is that strstarts() returns a bool while str_has_prefix() returns the length of the prefix if the string begins with it or 0 otherwise. Signed-off-by: Francis Laniel --- drivers/gpu/drm

Re: [PATCH v11 04/10] memory: tegra124-emc: Make driver modular

2020-12-07 Thread Dmitry Osipenko
04.12.2020 19:41, Thierry Reding пишет: ... >> +bool tegra124_clk_emc_driver_available(struct clk_hw *hw) >> +{ >> +struct tegra_clk_emc *tegra = container_of(hw, struct tegra_clk_emc, >> hw); >> + >> +return tegra->prepare_timing_change && tegra->complete_timing_change; >> +} > > This lo

[PATCH v2 3/7] drm/vc4: Simplify a bit the global atomic_check

2020-12-07 Thread Maxime Ripard
When we can't allocate a new channel, we can simply return instead of having to handle both cases, and that simplifies a bit the code. Reviewed-by: Thomas Zimmermann Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_kms.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-

[PATCH v3 3/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPR channel binding

2020-12-07 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel. Signed-off-by: Liu Ying --- Note that this depends on the 'two cell binding' clock patch set which has already landed in Shawn's i.MX clk/imx git branch. Otherwise, imx8-lpcg.h won't be found. v2->v3: * No change. v1->v

[PATCH v2 4/7] drm/vc4: kms: Wait on previous FIFO users before a commit

2020-12-07 Thread Maxime Ripard
If we're having two subsequent, non-blocking, commits on two different CRTCs that share no resources, there's no guarantee on the order of execution of both commits. However, the second one will consider the first one as the old state, and will be in charge of freeing it once that second commit is

[PATCH v2 1/7] drm: Introduce an atomic_commit_setup function

2020-12-07 Thread Maxime Ripard
Private objects storing a state shared across all CRTCs need to be carefully handled to avoid a use-after-free issue. The proper way to do this to track all the commits using that shared state and wait for the previous commits to be done before going on with the current one to avoid the reordering

[PATCH v3 0/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2020-12-07 Thread Liu Ying
Hi, This patch set introduces i.MX8qm/qxp Display Processing Unit(DPU) DRM support. DPU is comprised of a blit engine for 2D graphics, a display controller and a command sequencer. Outside of DPU, optional prefetch engines can fetch data from memory prior to some DPU fetchunits of blit engine a

[PATCH v2 2/7] drm: Document use-after-free gotcha with private objects

2020-12-07 Thread Maxime Ripard
The private objects have a gotcha that could result in a use-after-free, make sure it's properly documented. Reviewed-by: Daniel Vetter Signed-off-by: Maxime Ripard --- include/drm/drm_atomic.h | 20 1 file changed, 20 insertions(+) diff --git a/include/drm/drm_atomic.h b/

Re: [PATCH v3 2/4] drm/i915/pmu: Use kstat_irqs to get interrupt count

2020-12-07 Thread Thomas Gleixner
On Sun, Dec 06 2020 at 17:38, Thomas Gleixner wrote: > On Fri, Dec 04 2020 at 18:43, Jerry Snitselaar wrote: >> Now that kstat_irqs is exported, get rid of count_interrupts in >> i915_pmu.c > > May I ask why this has been merged in the first place? > > Nothing in a driver has ever to fiddle with th

Re: [PATCH v3 1/4] irq: export kstat_irqs

2020-12-07 Thread Thomas Gleixner
On Sun, Dec 06 2020 at 09:40, James Bottomley wrote: > On Sun, 2020-12-06 at 17:40 +0100, Thomas Gleixner wrote: >> On Sat, Dec 05 2020 at 12:39, Jarkko Sakkinen wrote: >> > On Fri, Dec 04, 2020 at 06:43:37PM -0700, Jerry Snitselaar wrote: >> > > To try and detect potential interrupt storms that >>

Re: [PATCH v3 2/4] drm/i915/pmu: Use kstat_irqs to get interrupt count

2020-12-07 Thread Thomas Gleixner
On Fri, Dec 04 2020 at 18:43, Jerry Snitselaar wrote: > Now that kstat_irqs is exported, get rid of count_interrupts in > i915_pmu.c > --- a/drivers/gpu/drm/i915/i915_pmu.c > +++ b/drivers/gpu/drm/i915/i915_pmu.c > @@ -423,22 +423,6 @@ static enum hrtimer_restart i915_sample(struct hrtimer > *hrt

[PATCH] drm/drv: switch to using devm_add_action_or_reset()

2020-12-07 Thread Tian Tao
switch to using devm_add_action_or_reset() instead of devm_add_action. Signed-off-by: Tian Tao --- drivers/gpu/drm/drm_drv.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 7343038..b92f7fd 100644 --- a/driver

Re: [PATCH] drm: Allow drm_fourcc.h without including drm.h

2020-12-07 Thread James Park
I suppose I should do this to avoid fighting with #ifdef DRM_FOURCC_STANDALONE #if defined(__linux__) #include #else #include typedef uint32_t __u32; typedef uint64_t __u64; #endif #else #include "drm.h" #endif I'll wait for more feedback before updating the patch though. On Fri, Dec 4, 2020

[PATCH drm/hisilicon 2/2] drm/hisilicon: Delete unused local parameters

2020-12-07 Thread Tian Tao
delete unused variable ‘priv’ to avoid warning. Signed-off-by: Tian Tao --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c i

Re: [PATCH v3 3/4] tpm_tis: Disable interrupts if interrupt storm detected

2020-12-07 Thread Thomas Gleixner
Jerry, On Fri, Dec 04 2020 at 18:43, Jerry Snitselaar wrote: > @@ -715,9 +717,23 @@ static irqreturn_t tis_int_handler(int dummy, void > *dev_id) > { > struct tpm_chip *chip = dev_id; > struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev); > + static bool check_storm = true; >

[PATCH drm/hisilicon 1/2] drm/hisilicon: Use managed mode-config init

2020-12-07 Thread Tian Tao
Using drmm_mode_config_init() sets up managed release of modesetting resources. Signed-off-by: Tian Tao --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers

[RFC PATCH v1 00/12] Replace strstarts() by str_has_prefix()

2020-12-07 Thread laniel_francis
From: Francis Laniel Hi. First, I hope you are fine and the same for your relatives. In this patch set, I replaced all calls to strstarts() by calls to str_has_prefix(). Indeed, the kernel has two functions to test if a string begins with an other: 1. strstarts() which returns a bool, so 1 if

[PATCH v6 1/5] dt-bindings: display: add #sound-dai-cells property to rockchip rk3066 hdmi

2020-12-07 Thread Johan Jonker
'#sound-dai-cells' is required to properly interpret the list of DAI specified in the 'sound-dai' property. Add it to rockchip,rk3066-hdmi.yaml to document that the rk3066 HDMI TX also can be used to transmit some audio. Signed-off-by: Johan Jonker --- .../devicetree/bindings/display/rockchip/ro

Re: [PATCH] drm: Fix drm.h uapi header for Windows

2020-12-07 Thread James Park
I could adjust the block to look like this: #ifdef DRM_FOURCC_STANDALONE #if defined(__linux__) #include #else #include typedef uint32_t __u32; typedef uint64_t __u64; #endif #else #include "drm.h" #endif Alternatively, I could create a new common header to be included from both drm.h and drm_f

[PATCH] Revert "xen: add helpers to allocate unpopulated memory"

2020-12-07 Thread Marek Marczykowski-Górecki
This reverts commit 9e2369c06c8a181478039258a4598c1ddd2cadfa. On a Xen PV dom0, with NVME disk, this makes the dom0 crash when starting a domain. This looks like some bad interaction between xen-blkback and NVME driver, both using ZONE_DEVICE. Since the author is on leave now, revert the change un

Re: [PATCH v3 02/13] video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify

2020-12-07 Thread Randy Dunlap
On 12/6/20 12:52 PM, Sam Ravnborg wrote: > Hi Randy. > > On Sun, Dec 06, 2020 at 11:37:17AM -0800, Randy Dunlap wrote: >> On 12/6/20 11:02 AM, Sam Ravnborg wrote: >>> Fix kernel-doc warnings reported when using W=1 >>> >>> v2: >>> - Improve subject (Lee) >>> >>> v3: >>> - Add RETURNS documenta

[RFC PATCH v1 05/12] renesas: Replace strstarts() by str_has_prefix().

2020-12-07 Thread laniel_francis
From: Francis Laniel The two functions indicates if a string begins with a given prefix. The only difference is that strstarts() returns a bool while str_has_prefix() returns the length of the prefix if the string begins with it or 0 otherwise. Signed-off-by: Francis Laniel --- drivers/gpu/drm

[PATCH drm/hisilicon 0/2] Code refactoring

2020-12-07 Thread Tian Tao
patch #1 is used drmm_mode_config_init() to do code refactoring. patch #2 is deleted unused variable ‘priv’ to avoid warning. Tian Tao (2): drm/hisilicon: Use managed mode-config init drm/hisilicon: Delete unused local parameters drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 18 -

Re: [PATCH v3 01/13] video: fbdev: hgafb: Fix kernel-doc warnings

2020-12-07 Thread Randy Dunlap
On 12/6/20 11:02 AM, Sam Ravnborg wrote: > Fix kernel-doc comments. > > v2: > - Updated subject (Lee) > > v3: > - Add space after ':' (Randy) > - Fix name of function in comment > > Signed-off-by: Sam Ravnborg > Cc: Ferenc Bakonyi > Cc: linux-nvi...@lists.surfsouth.com > Cc: Lee Jones >

[PATCH v2 0/7] vc4: Convert to drm_atomic_helper_commit

2020-12-07 Thread Maxime Ripard
Hi, Here's a conversion of vc4 to remove the hand-rolled atomic_commit helper from vc4 in favour of the generic one. This requires some rework of vc4, but also a new hook and some documentation for corner-cases in the DRM core that have been reported and explained by Daniel recently. Let me know

[PATCH v6 0/5] Enable rk3066a HDMI sound

2020-12-07 Thread Johan Jonker
Update the rk3066a HDMI documents with a #sound-dai-cells property. Include the code for sound in the HDMI driver. Add a simple-sound-card compatible node to rk3066a.dtsi, because I2S0 and HDMI TX are connected internally. And as last enable rk3066a HDMI sound in the rk3066a-mk808.dts file. make A

[PATCH] drm: drm_basic_types.h, DRM_FOURCC_STANDALONE

2020-12-07 Thread James Park
Create drm_basic_types.h to define types previously defined by drm.h. Use DRM_FOURCC_STANDALONE to include drm_fourcc.h, replacing drm.h dependency with drm_basic_types.h. This will allow Mesa to port code to Windows more easily. Signed-off-by: James Park James Park (1): drm: drm_basic_types

Re: [PATCH] drm/msm/dpu: enable DSPP support on SM8[12]50

2020-12-07 Thread Dmitry Baryshkov
On Tue, 3 Nov 2020 at 08:21, Dmitry Baryshkov wrote: > > Add support for color correction sub block on SM8150 and SM8250. Gracious ping for this patch > > Signed-off-by: Dmitry Baryshkov > --- > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 26 +++ > drivers/gpu/drm/msm/disp/

[PATCH] drm: drm_basic_types.h, DRM_FOURCC_STANDALONE

2020-12-07 Thread James Park
Create drm_basic_types.h to define types previously defined by drm.h. Use DRM_FOURCC_STANDALONE to include drm_fourcc.h, replacing drm.h dependency with drm_basic_types.h. This will allow Mesa to port code to Windows more easily. Signed-off-by: James Park --- include/uapi/drm/drm.h

[PATCH v6 5/5] ARM: dts: rockchip: enable hdmi_sound and i2s0 for rk3066a-mk808

2020-12-07 Thread Johan Jonker
Make some noise with mk808. Enable the hdmi_sound node and add i2s0 as sound source for hdmi. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a-mk808.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/rk3066a-mk808.dts b/arch/arm/boot/dts/rk3066a-mk808.dts

[PATCH] drivers: gpu: drm: virtio: fix dependency of DRM_VIRTIO_GPU on VIRTIO

2020-12-07 Thread Enrico Weigelt, metux IT consult
VIRTIO itself has no dependencies and therefore can easily be just select'ed, instead of depending on it. The current depends on causes any others trying to select VIRTIO to fail like this: drivers/gpu/drm/Kconfig:74:error: recursive dependency detected! drivers/gpu/drm/Kconfig:74: symbol D

[PATCH v2 1/1] dt-bindings: display: eliminate yamllint warnings

2020-12-07 Thread Zhen Lei
Eliminate the following yamllint warnings: ./Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml :52:9: [warning] wrong indentation: expected 6 but found 8 (indentation) ./Documentation/devicetree/bindings/display/bridge/intel,keembay-dsi.yaml :42:8: [warning] wrong indentation:

Re: [PATCH] drm: drivers may provide multiple primary planes per CRTC

2020-12-07 Thread Simon Ser
On Monday, December 7th, 2020 at 9:45 AM, Pekka Paalanen wrote: > > > > > > - * Cursor and overlay planes are optional. All drivers should > > > > > > provide one > > > > > > - * primary plane per CRTC to avoid surprising userspace too much. > > > > > > See enum > > > > > > + * Cursor and over

Re: [PATCH drm/hisilicon v2 1/2] drm/hisilicon: Use managed mode-config init

2020-12-07 Thread Thomas Zimmermann
Hi Am 07.12.20 um 10:05 schrieb Tian Tao: Using drmm_mode_config_init() sets up managed release of modesetting resources. Individual patches usually contain a changelog to highlight the difference to previous versions. Please add one before committing the patch. Your cover letter for the s

Re: [PATCH] Revert "xen: add helpers to allocate unpopulated memory"

2020-12-07 Thread Jürgen Groß
On 06.12.20 18:22, Marek Marczykowski-Górecki wrote: This reverts commit 9e2369c06c8a181478039258a4598c1ddd2cadfa. On a Xen PV dom0, with NVME disk, this makes the dom0 crash when starting a domain. This looks like some bad interaction between xen-blkback and xen-scsiback has the same use patt

Re: [PATCH] drm: drm_basic_types.h, DRM_FOURCC_STANDALONE

2020-12-07 Thread Simon Ser
On Sunday, December 6th, 2020 at 1:39 AM, James Park wrote: > Create drm_basic_types.h to define types previously defined by drm.h. > > Use DRM_FOURCC_STANDALONE to include drm_fourcc.h, replacing drm.h > dependency with drm_basic_types.h. This approach looks better to me than the other alterna

Re: [PATCH] drm: Fix drm.h uapi header for Windows

2020-12-07 Thread Simon Ser
On Monday, December 7th, 2020 at 9:57 AM, James Park wrote: > I could adjust the block to look like this: > > #ifdef DRM_FOURCC_STANDALONE > #if defined(__linux__) > #include > #else > #include > typedef uint32_t __u32; > typedef uint64_t __u64; > #endif > #else > #include "drm.h" > #endif Th

Re: [PATCH drm/hisilicon v2 1/2] drm/hisilicon: Use managed mode-config init

2020-12-07 Thread Thomas Zimmermann
Hi Am 07.12.20 um 10:29 schrieb tiantao (H): 在 2020/12/7 17:22, Thomas Zimmermann 写道: Hi Am 07.12.20 um 10:05 schrieb Tian Tao: Using drmm_mode_config_init() sets up managed release of modesetting resources. Individual patches usually contain a changelog to highlight the difference to p

Re: [PATCH] drm: drm_basic_types.h, DRM_FOURCC_STANDALONE

2020-12-07 Thread Simon Ser
On Monday, December 7th, 2020 at 10:55 AM, James Park wrote: > I'd noticed the #if could be combined, but they weren't in drm,h when > they could have been, so I didn't want to depart from the existing > pattern. I see. The original code really needed the two branches and drm_basic_types.h does

Re: [PATCH] drm: Fix drm.h uapi header for Windows

2020-12-07 Thread Simon Ser
On Monday, December 7th, 2020 at 11:00 AM, James Park wrote: > Not to make too big a deal of it, but the idea was that if you went > out of your way to define DRM_FOURCC_STANDALONE in your code base, > that you would also go through the pain of removing drm.h includes > elsewhere. It's too annoy

[Bug 203905] amdgpu:actual_brightness has unreal/wrong value

2020-12-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203905 kurmi...@libero.it changed: What|Removed |Added CC||kurmi...@libero.it --- Comment #19 f

Re: [PATCH] drm: drm_basic_types.h, DRM_FOURCC_STANDALONE

2020-12-07 Thread Simon Ser
On Monday, December 7th, 2020 at 11:05 AM, James Park wrote: > The original code blocks in drm.h look identical to me. I see: > > #include > #include > typedef unsigned int drm_handle_t; Hmm. Actually you're completely right, it turns out it's necessary to duplicate the branches like this to

Re: [PATCH] drm: Fix drm.h uapi header for Windows

2020-12-07 Thread Pekka Paalanen
On Mon, 7 Dec 2020 01:08:58 -0800 James Park wrote: > I'm not completely sure what you're saying, but doesn't drm_base_types.h > (now drm_basic_types.h) make things robust to header order? The patch is in > another email. You can also see it here: > https://github.com/jpark37/linux/commit/0cc8ae7

[PATCH v3 2/2] arm: dts: sc7180: Add support for gpu fuse

2020-12-07 Thread Akhil P Oommen
Add support for gpu fuse to help identify the supported opps. Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 6678

[PATCH v3 1/2] drm/msm: Add speed-bin support to a618 gpu

2020-12-07 Thread Akhil P Oommen
Some GPUs support different max frequencies depending on the platform. To identify the correct variant, we should check the gpu speedbin fuse value. Add support for this speedbin detection to a6xx family along with the required fuse details for a618 gpu. Signed-off-by: Akhil P Oommen --- Changes

Re: [PATCH] drm: Fix drm.h uapi header for Windows

2020-12-07 Thread Pekka Paalanen
On Mon, 7 Dec 2020 12:35:14 +0200 Pekka Paalanen wrote: > On Mon, 7 Dec 2020 01:08:58 -0800 > James Park wrote: > > > I'm not completely sure what you're saying, but doesn't drm_base_types.h > > (now drm_basic_types.h) make things robust to header order? The patch is in > > another email. You c

Re: [PATCH] drm: Fix drm.h uapi header for Windows

2020-12-07 Thread Simon Ser
On Monday, December 7th, 2020 at 11:44 AM, Pekka Paalanen wrote: > But then, the code in the header should be literally > > #ifndef DRM_FOURCC_STANDALONE > #include "drm.h" > #endif > > without an #else branch. As long as there is a #include "drm_basic_types.h" right before (drm_fourcc.h needs

Re: [PATCH] drm: Fix drm.h uapi header for Windows

2020-12-07 Thread Simon Ser
On Monday, December 7th, 2020 at 11:49 AM, James Park wrote: > That would work, but that's kind of an annoying requirement. I would > prefer the header to be self-sufficient. I don't want to make it more confusing than before, but here Pekka (I think) suggests to replace this: diff --git a/inc

Re: [PATCH 4/5] drm/scheduler: Job timeout handler returns status (v2)

2020-12-07 Thread Christian König
Am 04.12.20 um 16:10 schrieb Andrey Grodzovsky: On 12/4/20 3:13 AM, Christian König wrote: Thinking more about that I came to the conclusion that the whole approach here isn't correct. See even when the job has been completed or canceled we still want to restart the timer. The reason for t

Re: [PATCH] drm: Fix drm.h uapi header for Windows

2020-12-07 Thread Pekka Paalanen
On Mon, 07 Dec 2020 10:53:49 + Simon Ser wrote: > On Monday, December 7th, 2020 at 11:49 AM, James Park > wrote: > > > That would work, but that's kind of an annoying requirement. I would > > prefer the header to be self-sufficient. > > I don't want to make it more confusing than before

Re: [Intel-gfx] [RFC PATCH 113/162] drm/i915: Create stolen memory region from local memory

2020-12-07 Thread Jani Nikula
On Fri, 27 Nov 2020, Matthew Auld wrote: > From: CQ Tang > > Add "REGION_STOLEN" device info to dg1, create stolen memory > region from upper portion of local device memory, starting > from DSMBASE. > > The memory region is marked with "is_devmem=true". > > Cc: Joonas Lahtinen > Cc: Matthew Auld

Re: [PATCH] drivers: gpu: drm: virtio: fix dependency of DRM_VIRTIO_GPU on VIRTIO

2020-12-07 Thread Anthoine Bourgeois
On Fri, Dec 04, 2020 at 02:12:21PM +0100, Enrico Weigelt, metux IT consult wrote: VIRTIO itself has no dependencies and therefore can easily be just select'ed, instead of depending on it. The current depends on causes any others trying to select VIRTIO to fail like this: drivers/gpu/drm/Kconf

Re: [PATCH v3 07/13] video: fbdev: mmp: Fix kernel-doc warning for lcd_spi_write

2020-12-07 Thread Thomas Zimmermann
Am 06.12.20 um 20:02 schrieb Sam Ravnborg: Add missing parameter and drop parameter that is not present Signed-off-by: Sam Ravnborg Cc: Sam Ravnborg Cc: Andrzej Hajda Cc: Bartlomiej Zolnierkiewicz Acked-by: Thomas Zimmermann --- drivers/video/fbdev/mmp/hw/mmp_spi.c | 2 +- 1 file c

Re: [PATCH v3 08/13] video: fbdev: wmt_ge_rops: Fix function not declared warnings

2020-12-07 Thread Thomas Zimmermann
Am 06.12.20 um 20:02 schrieb Sam Ravnborg: Include own header to fix "function not declared" warnings. Signed-off-by: Sam Ravnborg Cc: Tony Prisk Cc: linux-arm-ker...@lists.infradead.org Acked-by: Thomas Zimmermann --- drivers/video/fbdev/wmt_ge_rops.c | 1 + 1 file changed, 1 insert

Re: [PATCH v3 09/13] video: fbdev: goldfishfb: Fix defined but not used warning

2020-12-07 Thread Thomas Zimmermann
Am 06.12.20 um 20:02 schrieb Sam Ravnborg: The goldfish_fb_acpi_match table is only used with ACPI enabled. Ifdef it out unless it is needed. This is a similar fix to what other acpi drivers do. Signed-off-by: Sam Ravnborg Cc: Sam Ravnborg Acked-by: Thomas Zimmermann --- drivers/video

Re: [PATCH v2 2/2] drm: panel: add Khadas TS050 panel driver

2020-12-07 Thread Neil Armstrong
Hi, On 05/12/2020 20:15, Sam Ravnborg wrote: > Hi Neil, > >> + >> +static int khadas_ts050_panel_probe(struct mipi_dsi_device *dsi) >> +{ >> +struct khadas_ts050_panel *khadas_ts050; >> +int err; >> + >> +dsi->lanes = 4; >> +dsi->format = MIPI_DSI_FMT_RGB888; >> +dsi->mode_fla

Re: [PATCH v3 10/13] video: fbdev: gbefb: Fix set but not used warning

2020-12-07 Thread Thomas Zimmermann
Am 06.12.20 um 20:02 schrieb Sam Ravnborg: The variable "x" was set but never used. Drop the redundant assignments. Signed-off-by: Sam Ravnborg Cc: Sam Ravnborg Acked-by: Thomas Zimmermann --- drivers/video/fbdev/gbefb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

Re: [PATCH v3 11/13] video: fbdev: efifb: Fix set but not used warning for screen_pitch

2020-12-07 Thread Thomas Zimmermann
Am 06.12.20 um 20:02 schrieb Sam Ravnborg: screen_pitch was asssigned a value which was never used. Drop it to fix the warning Signed-off-by: Sam Ravnborg Cc: Peter Jones Cc: linux-fb...@vger.kernel.org Acked-by: Thomas Zimmermann --- drivers/video/fbdev/efifb.c | 3 +-- 1 file chang

Re: [PATCH v3 12/13] video: fbdev: controlfb: Fix set but not used warnings

2020-12-07 Thread Thomas Zimmermann
Am 06.12.20 um 20:02 schrieb Sam Ravnborg: The controlfb driver has a number of dummy defines for IO operations. They were introduced in commit a07a63b0e24d ("video: fbdev: controlfb: add COMPILE_TEST support"). The write variants did not use their value parameter in the dummy versions, result

Re: [PATCH v3 13/13] video: fbdev: sis: Drop useless call to SiS_GetResInfo()

2020-12-07 Thread Thomas Zimmermann
Am 06.12.20 um 20:02 schrieb Sam Ravnborg: Coverity reported: Useless call (USELESS_CALL) side_effect_free: Calling SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex) is only useful for its return value, which is ignored. And this is correct - so drop the call. Signed-off-by: Sam Ra

Re: [PATCH v4 3/8] drm/vc4: hdmi: Don't access the connector state in reset if kmalloc fails

2020-12-07 Thread Thomas Zimmermann
Am 07.12.20 um 14:39 schrieb Maxime Ripard: drm_atomic_helper_connector_reset uses kmalloc which, from an API standpoint, can fail, and thus setting connector->state to NULL. However, our reset hook then calls drm_atomic_helper_connector_tv_reset that will access connector->state without checki

Re: [PATCH v4 4/8] drm/vc4: hdmi: Create a custom connector state

2020-12-07 Thread Thomas Zimmermann
Am 07.12.20 um 14:39 schrieb Maxime Ripard: When run with a higher bpc than 8, the clock of the HDMI controller needs to be adjusted. Let's create a connector state that will be used at atomic_check and atomic_enable to compute and store the clock rate associated to the state. Signed-off-by: M

Re: [PATCH v4 5/8] drm/vc4: hdmi: Store pixel frequency in the connector state

2020-12-07 Thread Thomas Zimmermann
Hi Am 07.12.20 um 14:39 schrieb Maxime Ripard: The pixel rate is for now quite simple to compute, but with more features (30 and 36 bits output, YUV output, etc.) will depend on a bunch of connectors properties. Let's store the rate we have to run the pixel clock at in our custom connector stat

Re: [PATCH v4 2/8] drm/vc4: Pass the atomic state to encoder hooks

2020-12-07 Thread Thomas Zimmermann
Am 07.12.20 um 14:39 schrieb Maxime Ripard: We'll need to access the connector state in our encoder setup, so let's just pass the whole DRM state to our private encoder hooks. Signed-off-by: Maxime Ripard This becomes relevant in patch 5, I guess? If so Acked-by: Thomas Zimmermann ---

Re: [PATCH v4 6/8] drm/vc4: hdmi: Use the connector state pixel rate for the PHY

2020-12-07 Thread Thomas Zimmermann
Am 07.12.20 um 14:39 schrieb Maxime Ripard: The PHY initialisation parameters are not based on the pixel clock but the TMDS clock rate which can be the pixel clock in the standard case, but could be adjusted based on some parameters like the bits per color. Since the TMDS clock rate is stored

[PATCH][next] drm/mediatek: avoid dereferencing a null hdmi_phy on an error message

2020-12-07 Thread Colin King
From: Colin Ian King Currently there is a null pointer check for hdmi_phy that implies it may be null, however a dev_err messages dereferences this potential null pointer. Avoid a null pointer dereference by only emitting the dev_err message if hdmi_phy is non-null. It is a moot point if the er

Re: [PATCH 1/2] drm: add legacy support for using degamma for gamma

2020-12-07 Thread Ville Syrjälä
On Sat, Dec 05, 2020 at 12:35:25AM +0200, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Thu, Dec 03, 2020 at 01:48:44PM +0200, Tomi Valkeinen wrote: > > We currently have drm_atomic_helper_legacy_gamma_set() helper which can > > be used to handle legacy gamma-set ioctl. >

Re: [PATCH 4/5] drm/scheduler: Job timeout handler returns status (v2)

2020-12-07 Thread Andrey Grodzovsky
On 12/7/20 6:13 AM, Christian König wrote: Am 04.12.20 um 16:10 schrieb Andrey Grodzovsky: On 12/4/20 3:13 AM, Christian König wrote: Thinking more about that I came to the conclusion that the whole approach here isn't correct. See even when the job has been completed or canceled we still w

[PATCH] drm/ttm: cleanup BO size handling

2020-12-07 Thread Christian König
Based on an idea from Dave, but cleaned up a bit. We had multiple fields for essentially the same thing. Now bo->size is the original size of the BO in arbitrary units, usually bytes. bo->mem.num_pages is the size in number of pages in the resource domain of bo->mem.mem_type. Signed-off-by: Chr

Re: [PATCH v3 1/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPU binding

2020-12-07 Thread Rob Herring
On Mon, 07 Dec 2020 11:20:55 +0800, Liu Ying wrote: > This patch adds bindings for i.MX8qxp/qm Display Processing Unit. > > Signed-off-by: Liu Ying > --- > Note that this depends on the 'two cell binding' clock patch set which has > already landed in Shawn's i.MX clk/imx git branch. Otherwise, i

  1   2   >