Re: [PATCH] fbdev: Remove udlfb driver

2020-12-01 Thread Thomas Zimmermann
Hi Am 30.11.20 um 15:31 schrieb Mikulas Patocka: On Mon, 30 Nov 2020, Thomas Zimmermann wrote: Udlfb has been superseded by DRM's udl. The DRM driver is better by any means and actively maintained. Remove udlfb. Hi I am using udlfb and it's definitely better than the DRM driver. The DRM d

Re: [PATCH] fbdev: Remove udlfb driver

2020-12-01 Thread Thomas Zimmermann
Hi Am 30.11.20 um 19:39 schrieb Mikulas Patocka: On Mon, 30 Nov 2020, Daniel Vetter wrote: On Mon, Nov 30, 2020 at 09:31:15AM -0500, Mikulas Patocka wrote: The framebuffer driver supports programs running full-screen directly on the framebuffer console, such as web browser "links -g", imag

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Thomas Zimmermann
Am 30.11.20 um 16:30 schrieb Daniel Vetter: On Mon, Nov 30, 2020 at 01:04:26PM +0100, Thomas Zimmermann wrote: Mapping a GEM object's buffer into kernel address space prevents the buffer from being evicted from VRAM, which in turn may result in out-of-memory errors. It's therefore required to

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-12-01 Thread Gustavo A. R. Silva
On Tue, Dec 01, 2020 at 12:52:27AM -0500, Martin K. Petersen wrote: > > Gustavo, > > > This series aims to fix almost all remaining fall-through warnings in > > order to enable -Wimplicit-fallthrough for Clang. > > Applied 20-22,54,120-124 to 5.11/scsi-staging, thanks. Awesome! :) Thanks, Mart

[PATCH 1/6] dt-bindings: display: add Unisoc's drm master bindings

2020-12-01 Thread Kevin Tang
From: Kevin Tang The Unisoc DRM master device is a virtual device needed to list all DPU devices or other display interface nodes that comprise the graphics subsystem Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- .../display/sprd/sprd,display-subsystem.yaml | 39 ++

Re: [PATCH 2/4] dt-bindings: display: Add ABT Y030XX067A panel bindings

2020-12-01 Thread Paul Cercueil
Hi Rob, Le lun. 30 nov. 2020 à 7:32, Rob Herring a écrit : On Mon, Nov 2, 2020 at 3:19 AM Paul Cercueil wrote: Le dim. 1 nov. 2020 à 13:29, Sam Ravnborg a écrit : > On Sun, Nov 01, 2020 at 09:31:48AM +, Paul Cercueil wrote: >> The Asia Better Technology (ABT) Y030XX067A panel i

[PATCH 2/3] drm/rockchip: vop: fix reference leak when pm_runtime_get_sync fails

2020-12-01 Thread Qinglang Miao
pm_runtime_get_sync will increment pm usage counter even failed. Forgetting to putting operation will result in a reference leak here. Replace it with pm_runtime_resume_and_get to keep usage counter balanced. Fixes: 5e570373c015 ("drm/rockchip: vop: Enable pm domain before vop_initial") Reported-

Re: [PATCH 1/6] dt-bindings: display: add Unisoc's drm master bindings

2020-12-01 Thread Kevin Tang
Hi Rob Rob Herring 于2020年12月1日周二 上午4:29写道: > > On Mon, Nov 30, 2020 at 7:28 AM Kevin Tang wrote: > > > > From: Kevin Tang > > Once again, DT patches must Cc the DT list if you want them reviewed. Ok, i will add DT list to my Cc list. > > > > > The Unisoc DRM master device is a virtual device ne

[PATCH 0/6] Add Unisoc's drm kms module

2020-12-01 Thread Kevin Tang
ChangeList: RFC v1: 1. only upstream modeset and atomic at first commit. 2. remove some unused code; 3. use alpha and blend_mode properties; 3. add yaml support; 4. remove auto-adaptive panel driver; 5. bugfix RFC v2: 1. add sprd crtc and plane module for KMS, preparing for multi crtc&encoder 2.

[PATCH 3/6] dt-bindings: display: add Unisoc's dpu bindings

2020-12-01 Thread Kevin Tang
From: Kevin Tang DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs which transfers the image data from a video memory buffer to an internal LCD interface. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- .../bindings/display/sprd/sprd,sharkl3-dpu.yaml

Re: [PATCH 2/4] dt-bindings: display: Add ABT Y030XX067A panel bindings

2020-12-01 Thread Paul Cercueil
Le lun. 30 nov. 2020 à 13:18, Rob Herring a écrit : On Mon, Nov 30, 2020 at 12:39 PM Paul Cercueil wrote: Hi Rob, Le lun. 30 nov. 2020 à 7:32, Rob Herring a écrit : > On Mon, Nov 2, 2020 at 3:19 AM Paul Cercueil > wrote: >> >> >> >> Le dim. 1 nov. 2020 à 13:29, Sam Ravnbo

[PATCH 1/3] drm/rockchip: cdn-dp: fix reference leak when pm_runtime_get_sync fails

2020-12-01 Thread Qinglang Miao
pm_runtime_get_sync will increment pm usage counter even failed. Forgetting to putting operation will result in a reference leak here. Replace it with pm_runtime_resume_and_get to keep usage counter balanced. Fixes: efe0220fc2d2 ("drm/rockchip: cdn-dp: Fix error handling") Reported-by: Hulk Robot

[PATCH v2 0/3] drm/mipi-dbi: Type B bus support, drm/tiny: MRB2801

2020-12-01 Thread mdurnev
From: Mikhail Durnev Hi All, This patch series is aiming at extending the mipi-dbi bus driver to support Intel 8080 type parallel bus (Type B) over GPIO and adding a new driver for ILI9341 display panels with 8- or 16-bit parallel interface. It was tested with the MRB2801 display module [1] tha

[PATCH 0/3] drm/rockchip: fix reference leak of pm_runtime_get_sync

2020-12-01 Thread Qinglang Miao
Replace pm_runtime_get_sync with pm_runtime_resume_and_get to keep usage counter balanced. Qinglang Miao (3): drm/rockchip: cdn-dp: fix reference leak when pm_runtime_get_sync fails drm/rockchip: vop: fix reference leak when pm_runtime_get_sync fails drm/rockchip: lvds: fix reference le

Re: [PATCH rdma-core v3 4/6] pyverbs: Add dma-buf based MR support

2020-12-01 Thread Jason Gunthorpe
On Fri, Nov 27, 2020 at 12:55:41PM -0800, Jianxin Xiong wrote: > > +function(rdma_multifile_module PY_MODULE MODULE_NAME LINKER_FLAGS) I think just replace rdma_cython_module with this? No good reason I can see to have two APIs? > + set(ALL_CFILES "") > + foreach(SRC_FILE ${ARGN}) > +get_

Re: [PATCH v10 01/19] dt-bindings: memory: tegra20: emc: Document opp-supported-hw property

2020-12-01 Thread Dmitry Osipenko
30.11.2020 21:23, Krzysztof Kozlowski пишет: > On Mon, Nov 30, 2020 at 11:48:18AM +0200, Georgi Djakov wrote: >> On 23.11.20 2:27, Dmitry Osipenko wrote: >>> Document opp-supported-hw property, which is not strictly necessary to >>> have on Tegra20, but it's very convenient to have because all othe

[PATCH 4/6] drm/sprd: add Unisoc's drm display controller driver

2020-12-01 Thread Kevin Tang
Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/sprd/Kconfig| 1 + drivers/gpu/drm/sprd/Makefile | 6

Re: [PATCH] drm/panfrost: fix reference leak in panfrost_job_hw_submit

2020-12-01 Thread Qinglang Miao
在 2020/11/27 18:06, Steven Price 写道: On 27/11/2020 09:44, Qinglang Miao wrote: pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in a reference leak here. A new function pm_runtime_resume_and_get is introduced in [0] to keep usage

[PATCH v2 1/3] drm/mipi-dbi: Add support for Type B

2020-12-01 Thread mdurnev
From: Mikhail Durnev Intel 8080 type (Type B) parallel bus over GPIO. The parallel bus is implemented partially. It supports only write operations from the host to the display. Read operations would require switching GPIO mode between input and output back and forth. But this implementation is v

[PATCH v5] drm/bridge: add it6505 driver

2020-12-01 Thread allen
This adds support for the iTE IT6505. This device can convert DPI signal to DP output. From: Allen Chen Signed-off-by: Jitao Shi Signed-off-by: Pi-Hsun Shih Signed-off-by: Yilun Lin Signed-off-by: Hermes Wu Signed-off-by: Allen Chen --- drivers/gpu/drm/bridge/Kconfig |7 + drivers/

Re: [PATCH rdma-core v3 4/6] pyverbs: Add dma-buf based MR support

2020-12-01 Thread Jason Gunthorpe
On Mon, Nov 30, 2020 at 03:57:41PM +0100, Daniel Vetter wrote: > > + err = ioctl(dri->fd, DRM_IOCTL_AMDGPU_GEM_CREATE, &gem_create); > > + if (err) > > + return err; > > + > > + *handle = gem_create.out.handle; > > + return 0; > > +} > > + > > +static int radeon_alloc(struct dri *

[PATCH 3/3] drm/rockchip: lvds: fix reference leak when pm_runtime_get_sync fails

2020-12-01 Thread Qinglang Miao
pm_runtime_get_sync will increment pm usage counter even failed. Forgetting to putting operation will result in a reference leak here. Replace it with pm_runtime_resume_and_get to keep usage counter balanced. Fixes: cca1705c3d89 ("drm/rockchip: lvds: Add PX30 support") Reported-by: Hulk Robot Si

[PATCH 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver

2020-12-01 Thread Kevin Tang
Adds dsi host controller support for the Unisoc's display subsystem. Adds dsi phy support for the Unisoc's display subsystem. Only MIPI DSI Displays supported, DP/TV/HMDI will be support in the feature. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/sprd/Makefil

Re: [PATCH] Revert "i2c: qcom-geni: Disable DMA processing on the Lenovo Yoga C630"

2020-12-01 Thread Steev Klimaszewski
On 11/24/20 12:57 PM, Bjorn Andersson wrote: > A combination of recent bug fixes by Doug Anderson and the proper > definition of iommu streams means that this hack is no longer needed. > Let's clean up the code by reverting '127068abe85b ("i2c: qcom-geni: > Disable DMA processing on the Lenovo Yo

Re: [REGRESSION] omapdrm/N900 display broken

2020-12-01 Thread H . Nikolaus Schaller
Hi Ivaylo, > Am 27.11.2020 um 19:44 schrieb Ivaylo Dimitrov : > > Hi, > > On 27.11.20 г. 19:30 ч., Tomi Valkeinen wrote: >> On 27/11/2020 17:37, Ivaylo Dimitrov wrote: >>> With 5.9.11 and the patch on top, n900 boots fine, albeit display remains >>> blank, could be related to >>> brightness, we

[PATCH v5] dt-bindings: display: panel: one file of all simple LVDS panels with dual ports

2020-12-01 Thread Liu Ying
To complement panel-simple.yaml, create panel-simple-lvds-dual-ports.yaml. panel-simple-lvds-dual-ports.yaml is for all simple LVDS panels that have dual LVDS ports and require only a single power-supply. The first port receives odd pixels, and the second port receives even pixels. Optionally, a ba

[PATCH 2/6] drm/sprd: add Unisoc's drm kms master

2020-12-01 Thread Kevin Tang
Adds drm support for the Unisoc's display subsystem. This is drm kms driver, this driver provides support for the application framework in Android, Yocto and more. Application framework can access Unisoc's display internel peripherals through libdrm or libkms, it's test ok by modetest (DRM/KMS te

[PATCH] drm/nouveau/svm: Only map migrating pages

2020-12-01 Thread Alistair Popple
Only pages which were actually migrated should be mapped on the GPU. migrate_vma_pages() clears MIGRATE_PFN_MIGRATE in the src_pfn array, so test this prior to mapping the pages on the GPU. If any pages failed to migrate don't install any mappings - the GPU will demand fault any as required. Fixes

Re: [PATCH rdma-core v3 4/6] pyverbs: Add dma-buf based MR support

2020-12-01 Thread Jason Gunthorpe
On Mon, Nov 30, 2020 at 05:04:43PM +0100, Daniel Vetter wrote: > On Mon, Nov 30, 2020 at 11:55:44AM -0400, Jason Gunthorpe wrote: > > On Mon, Nov 30, 2020 at 03:57:41PM +0100, Daniel Vetter wrote: > > > > + err = ioctl(dri->fd, DRM_IOCTL_AMDGPU_GEM_CREATE, &gem_create); > > > > + if (er

Re: [PATCH v10 01/19] dt-bindings: memory: tegra20: emc: Document opp-supported-hw property

2020-12-01 Thread Georgi Djakov
On 23.11.20 2:27, Dmitry Osipenko wrote: Document opp-supported-hw property, which is not strictly necessary to have on Tegra20, but it's very convenient to have because all other SoC core devices will use hardware versioning, and thus, it's good to maintain the consistency. Hi Dmitry, I belie

[PATCH v2 3/3] dt-bindings: panel: Add bindings for MRB2801

2020-12-01 Thread mdurnev
From: Mikhail Durnev Add binding for Ronbo MRB2801 display module. This binding is for display panels using an Ilitek ILI9341 controller in parallel mode. Signed-off-by: Mikhail Durnev --- .../devicetree/bindings/display/ronbo,mrb2801.txt | 42 ++ 1 file changed, 42 inser

GPU-side memory protection landscape

2020-12-01 Thread Alexander Monakov
Hi, On #dri-devel Daniel invited me to chime in on the topic of clearing GPU memory handed to userspace, so here I go. I was asking how information leak from giving userspace dirty memory previously used by another process is not seen as a security issue. I was pointed to a recent thread, which o

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-12-01 Thread Martin K. Petersen
Gustavo, > This series aims to fix almost all remaining fall-through warnings in > order to enable -Wimplicit-fallthrough for Clang. Applied 20-22,54,120-124 to 5.11/scsi-staging, thanks. -- Martin K. Petersen Oracle Linux Engineering ___ dri-d

Re: [PATCH v10 17/19] ARM: tegra: Add EMC OPP properties to Tegra20 device-trees

2020-12-01 Thread Dmitry Osipenko
01.12.2020 00:17, Jon Hunter пишет: > Hi Dmitry, > > On 23/11/2020 00:27, Dmitry Osipenko wrote: >> Add EMC OPP DVFS tables and update board device-trees by removing >> unsupported OPPs. >> >> Signed-off-by: Dmitry Osipenko > This change is generating the following warning on Tegra20 Ventana > an

general protection fault in drm_client_buffer_vunmap

2020-12-01 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:6147c83f Add linux-next specific files for 20201126 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=109130a550 kernel config: https://syzkaller.appspot.com/x/.config?x=9b91566da897c24f dashboard

[PATCH v2 2/3] drm/tiny: Add driver for ili9341 with parallel bus

2020-12-01 Thread mdurnev
From: Mikhail Durnev MRB2801 display module [1] is an example of ILI9341 display that connects to Intel 8080 parallel bus. Its connector is compatible with the ALIENTEK STM32 development board. It can be used with the drm/mipi-dbi bus driver if the bus is emulated with GPIO. [1] http://www.lcdw

[PATCH 5/6] dt-bindings: display: add Unisoc's mipi dsi&dphy bindings

2020-12-01 Thread Kevin Tang
From: Kevin Tang Adds MIPI DSI Master and MIPI DSI-PHY (D-PHY) support for Unisoc's display subsystem. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- .../display/sprd/sprd,sharkl3-dsi-host.yaml| 107 + .../display/sprd/sprd,sharkl3-dsi-phy.yaml

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Thomas Zimmermann
Hi Am 30.11.20 um 16:33 schrieb Christian König: Am 30.11.20 um 16:30 schrieb Daniel Vetter: On Mon, Nov 30, 2020 at 01:04:26PM +0100, Thomas Zimmermann wrote: Mapping a GEM object's buffer into kernel address space prevents the buffer from being evicted from VRAM, which in turn may result in

Re: [PATCH] drm/vkms: detect modes during output initialization

2020-12-01 Thread Pekka Paalanen
On Mon, 30 Nov 2020 12:20:08 + Simon Ser wrote: > CC Daniel and Ville > > On Monday, November 30, 2020 12:24 PM, Pekka Paalanen > wrote: > > > > > Please record the justitication for that patch in its commit message. > > > > "Can't" does not explain anything. > > > > > > Yeah, sorry abo

Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings

2020-12-01 Thread Lee Jones
On Mon, 30 Nov 2020, Sam Ravnborg wrote: > On Mon, Nov 30, 2020 at 01:14:52PM +0100, Thomas Zimmermann wrote: > > > > > > Am 28.11.20 um 23:40 schrieb Sam Ravnborg: > > > Fix W=1 warnings: > > > - Fix kernel-doc > > > - Drop unused variables/code > > > > > > v2: > > >- Updated subject (Lee)

Re: [PATCH] drm/vkms: detect modes during output initialization

2020-12-01 Thread Simon Ser
On Tuesday, December 1, 2020 9:46 AM, Pekka Paalanen wrote: > On Mon, 30 Nov 2020 12:20:08 + > Simon Ser cont...@emersion.fr wrote: > > > CC Daniel and Ville > > On Monday, November 30, 2020 12:24 PM, Pekka Paalanen ppaala...@gmail.com > > wrote: > > > > > > > Please record the justiticatio

Re: [PATCH v2] drm: document that user-space should force-probe connectors

2020-12-01 Thread Pekka Paalanen
On Mon, 30 Nov 2020 16:26:12 + Simon Ser wrote: > It seems like we can't have nice things, so let's just document the > disappointing behaviour instead. > > The previous version assumed the kernel would perform the probing work > when appropriate, however this is not the case today. Update t

Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings

2020-12-01 Thread Sam Ravnborg
Hi Lee, > > Cop-out! > > Do what I do and make something up (joke)! :'D If I thought anyone would actually read the comments then maybe yes. But I assume that apart from this thread no-one will read it. > > > > Well, it fixes the warning ;) > > > > Yeah, I could not dig up anything useful to

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Daniel Vetter
On Tue, Dec 1, 2020 at 9:32 AM Thomas Zimmermann wrote: > > Hi > > Am 30.11.20 um 16:33 schrieb Christian König: > > Am 30.11.20 um 16:30 schrieb Daniel Vetter: > >> On Mon, Nov 30, 2020 at 01:04:26PM +0100, Thomas Zimmermann wrote: > >>> Mapping a GEM object's buffer into kernel address space pre

[PATCH 5.9 129/152] drm/nouveau: fix relocations applying logic and a double-free

2020-12-01 Thread Greg Kroah-Hartman
From: Matti Hamalainen [ Upstream commit 2be65641642ef423f82162c3a5f28c754d1637d2 ] Commit 03e0d26fcf79 ("drm/nouveau: slowpath for pushbuf ioctl") included a logic-bug which results in the relocations not actually getting applied at all as the call to nouveau_gem_pushbuf_reloc_apply() is never

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Christian König
Am 01.12.20 um 09:32 schrieb Thomas Zimmermann: Hi Am 30.11.20 um 16:33 schrieb Christian König: Am 30.11.20 um 16:30 schrieb Daniel Vetter: On Mon, Nov 30, 2020 at 01:04:26PM +0100, Thomas Zimmermann wrote: Mapping a GEM object's buffer into kernel address space prevents the buffer from bein

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Thomas Zimmermann
Hi Am 01.12.20 um 10:13 schrieb Christian König: Am 01.12.20 um 09:32 schrieb Thomas Zimmermann: Hi Am 30.11.20 um 16:33 schrieb Christian König: Am 30.11.20 um 16:30 schrieb Daniel Vetter: On Mon, Nov 30, 2020 at 01:04:26PM +0100, Thomas Zimmermann wrote: Mapping a GEM object's buffer into

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Thomas Zimmermann
Hi Am 01.12.20 um 10:10 schrieb Daniel Vetter: On Tue, Dec 1, 2020 at 9:32 AM Thomas Zimmermann wrote: Hi Am 30.11.20 um 16:33 schrieb Christian König: Am 30.11.20 um 16:30 schrieb Daniel Vetter: On Mon, Nov 30, 2020 at 01:04:26PM +0100, Thomas Zimmermann wrote: Mapping a GEM object's buf

Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings

2020-12-01 Thread Lee Jones
On Tue, 01 Dec 2020, Sam Ravnborg wrote: > Hi Lee, > > > > > Cop-out! > > > > Do what I do and make something up (joke)! :'D > > If I thought anyone would actually read the comments then maybe yes. > But I assume that apart from this thread no-one will read it. > > > > > > > Well, it fixes t

Re: [PATCH 09/15] drm/nouveau: Remove references to struct drm_device.pdev

2020-12-01 Thread Thomas Zimmermann
Hi Sam Am 24.11.20 um 22:42 schrieb Sam Ravnborg: Hi Thomas. On Tue, Nov 24, 2020 at 12:38:18PM +0100, Thomas Zimmermann wrote: Using struct drm_device.pdev is deprecated. Convert nouveau to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Ben Skeggs Sugg

Re: [PATCH v2 08/28] video: fbdev: sis: Fix defined but not used warning of SiS_TVDelay

2020-12-01 Thread Thomas Zimmermann
Hi Am 30.11.20 um 20:01 schrieb Sam Ravnborg: Hi Thomas. On Mon, Nov 30, 2020 at 10:13:05AM +0100, Thomas Zimmermann wrote: Am 28.11.20 um 23:40 schrieb Sam Ravnborg: Fix W=1 warning by commenting unused SiS_TVDelay* variables. The SiS_TVDelay* variables seem to contain some magic numbers

Re: [PATCH v5] drm/bridge: add it6505 driver

2020-12-01 Thread Sam Ravnborg
Hi Allen. On Tue, Dec 01, 2020 at 01:44:41PM +0800, allen wrote: > This adds support for the iTE IT6505. > This device can convert DPI signal to DP output. > > From: Allen Chen > Signed-off-by: Jitao Shi > Signed-off-by: Pi-Hsun Shih > Signed-off-by: Yilun Lin > Signed-off-by: Hermes Wu > Sig

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Daniel Vetter
On Tue, Dec 1, 2020 at 10:40 AM Thomas Zimmermann wrote: > > Hi > > Am 01.12.20 um 10:10 schrieb Daniel Vetter: > > On Tue, Dec 1, 2020 at 9:32 AM Thomas Zimmermann > > wrote: > >> > >> Hi > >> > >> Am 30.11.20 um 16:33 schrieb Christian König: > >>> Am 30.11.20 um 16:30 schrieb Daniel Vetter: >

Re: [PATCH v2 22/28] video: fbdev: omapfb: Fix set but not used warnings in dsi

2020-12-01 Thread Thomas Zimmermann
Am 28.11.20 um 23:41 schrieb Sam Ravnborg: Fix several W=1 warnings. This removes unused code and avoids an assignment by moving the use inside the conditional block. The register read FLD_GET(r, 15, 8) could be dropped as it was done a few lines before too. v2: - Updated subject (Lee) Si

Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings

2020-12-01 Thread Daniel Vetter
On Tue, Dec 1, 2020 at 10:46 AM Lee Jones wrote: > > On Tue, 01 Dec 2020, Sam Ravnborg wrote: > > > Hi Lee, > > > > > > > > Cop-out! > > > > > > Do what I do and make something up (joke)! :'D > > > > If I thought anyone would actually read the comments then maybe yes. > > But I assume that apart f

Re: [PATCH v2 23/28] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core

2020-12-01 Thread Thomas Zimmermann
Hi Am 28.11.20 um 23:41 schrieb Sam Ravnborg: Fix a few W=1 warnings about unused assignments. Drop the unused error code. v2: - Subject updated (Lee) Signed-off-by: Sam Ravnborg Cc: Sam Ravnborg Cc: Qilong Zhang Cc: "Alexander A. Klimov" Cc: Daniel Vetter Cc: Lee Jones --- drivers/

Re: [PATCH v2 24/28] video: fbdev: s3c-fb: Fix kernel-doc and set but not used warnings

2020-12-01 Thread Thomas Zimmermann
Am 28.11.20 um 23:41 schrieb Sam Ravnborg: Fix several W=1 warnings - Updated kernel-doc as needed - Deleted unused local variable, it was assigned but never used v2: - Updated subject (Lee) Signed-off-by: Sam Ravnborg Cc: Jingoo Han Cc: linux-fb...@vger.kernel.org Cc: Lee Jones Acked

Re: [PATCH v2 25/28] video: fbdev: uvesafb: Fix set but not used warning

2020-12-01 Thread Thomas Zimmermann
Hi Am 28.11.20 um 23:41 schrieb Sam Ravnborg: Fix W=1 warning by deleting unused local variable. v2: - Updated subject (Lee) Signed-off-by: Sam Ravnborg Cc: Michal Januszewski Cc: linux-fb...@vger.kernel.org Cc: Lee Jones --- drivers/video/fbdev/uvesafb.c | 4 ++-- 1 file changed, 2 i

Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings

2020-12-01 Thread Lee Jones
On Tue, 01 Dec 2020, Daniel Vetter wrote: > On Tue, Dec 1, 2020 at 10:46 AM Lee Jones wrote: > > > > On Tue, 01 Dec 2020, Sam Ravnborg wrote: > > > > > Hi Lee, > > > > > > > > > > > Cop-out! > > > > > > > > Do what I do and make something up (joke)! :'D > > > > > > If I thought anyone would actua

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Thomas Zimmermann
Hi Am 01.12.20 um 11:00 schrieb Daniel Vetter: On Tue, Dec 1, 2020 at 10:40 AM Thomas Zimmermann wrote: Hi Am 01.12.20 um 10:10 schrieb Daniel Vetter: On Tue, Dec 1, 2020 at 9:32 AM Thomas Zimmermann wrote: Hi Am 30.11.20 um 16:33 schrieb Christian König: Am 30.11.20 um 16:30 schrieb D

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Christian König
Am 01.12.20 um 11:27 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 11:00 schrieb Daniel Vetter: On Tue, Dec 1, 2020 at 10:40 AM Thomas Zimmermann wrote: Hi Am 01.12.20 um 10:10 schrieb Daniel Vetter: On Tue, Dec 1, 2020 at 9:32 AM Thomas Zimmermann wrote: Hi Am 30.11.20 um 16:33 schrieb

[PATCH v2 00/20] drm: Move struct drm_device.pdev to legacy

2020-12-01 Thread Thomas Zimmermann
The pdev field in struct drm_device points to a PCI device structure and goes back to UMS-only days when all DRM drivers were for PCI devices. Meanwhile we also support USB, SPI and platform devices. Each of those uses the generic device stored in struct drm_device.dev. To reduce duplication and r

[PATCH v2 02/20] drm/amdgpu: Remove references to struct drm_device.pdev

2020-12-01 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert amdgpu to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Alex Deucher Acked-by: Sam Ravnborg Cc: Alex Deucher Cc: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 17 ---

[PATCH v2 01/20] drm/amdgpu: Fix trailing whitespaces

2020-12-01 Thread Thomas Zimmermann
Adhere to kernel coding style. Signed-off-by: Thomas Zimmermann Acked-by: Alex Deucher Acked-by: Sam Ravnborg Cc: Alex Deucher Cc: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdg

[PATCH v2 06/20] drm/gma500: Fix trailing whitespaces

2020-12-01 Thread Thomas Zimmermann
Adhere to kernel coding style. Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg Cc: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_device.c | 8 drivers/gpu/drm/gma500/intel_bios.c | 4 ++-- drivers/gpu/drm/gma500/oaktrail_device.c | 2 +- drivers/gpu/drm/gma500/psb_

[PATCH v2 03/20] drm/ast: Remove references to struct drm_device.pdev

2020-12-01 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert ast to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg --- drivers/gpu/drm/ast/ast_drv.c | 4 ++-- drivers/gpu/drm/ast/ast_main.c | 25 + drivers/gpu/drm/ast/ast_m

[PATCH v2 04/20] drm/bochs: Remove references to struct drm_device.pdev

2020-12-01 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert bochs to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg Cc: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_drv.c | 1 - drivers/gpu/drm/bochs/bochs_hw.c | 4 ++-- 2 files changed, 2 inser

[PATCH v2 08/20] drm/hibmc: Remove references to struct drm_device.pdev

2020-12-01 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert hibmc to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg Cc: Xinliang Liu Cc: Tian Tao Cc: John Stultz Cc: Xinwei Kong Cc: Chen Feng --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.

[PATCH v2 05/20] drm/cirrus: Remove references to struct drm_device.pdev

2020-12-01 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert cirrus to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg Cc: Gerd Hoffmann --- drivers/gpu/drm/tiny/cirrus.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/tiny/cirrus

[PATCH v2 13/20] drm/nouveau: Remove references to struct drm_device.pdev

2020-12-01 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert nouveau to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Ben Skeggs --- drivers/gpu/drm/nouveau/dispnv04/arb.c | 12 +++- drivers/gpu/drm/nouveau/dispnv04/disp.h | 14 -- driver

[PATCH v2 10/20] drm/i915/gt: Remove references to struct drm_device.pdev

2020-12-01 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert i915 to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- drivers/gpu/drm/i915/gt/intel_ggtt.c | 10

[PATCH v2 09/20] drm/i915: Remove references to struct drm_device.pdev

2020-12-01 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert i915 to struct drm_device.dev. No functional changes. v2: * move gt/ and gvt/ changes into separate patches Signed-off-by: Thomas Zimmermann Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi --- drivers/gpu/drm/i915/display/intel

[PATCH v2 11/20] drm/i915/gvt: Remove references to struct drm_device.pdev

2020-12-01 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert i915 to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi --- drivers/gpu/drm/i915/gvt/cfg_space.c | 5 +++-- drivers/gpu/drm/i915/gvt/firmware.c | 10 +-

[PATCH v2 07/20] drm/gma500: Remove references to struct drm_device.pdev

2020-12-01 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert gma500 to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg Cc: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_device.c| 22 - drivers/gpu/drm/gma500/cdv_intel_crt.c

[PATCH v2 12/20] drm/mgag200: Remove references to struct drm_device.pdev

2020-12-01 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert mgag200 to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg --- drivers/gpu/drm/mgag200/mgag200_drv.c | 20 +++- drivers/gpu/drm/mgag200/mgag200_i2c.c | 2 +- drivers/gpu/dr

[PATCH v2 14/20] drm/qxl: Remove references to struct drm_device.pdev

2020-12-01 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert qxl to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg Cc: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_drv.c | 2 +- drivers/gpu/drm/qxl/qxl_ioctl.c | 3 ++- drivers/gpu/drm/qxl/qxl_irq.c

[PATCH v2 15/20] drm/radeon: Fix trailing whitespaces

2020-12-01 Thread Thomas Zimmermann
Adhere to kernel coding style. Signed-off-by: Thomas Zimmermann Acked-by: Alex Deucher Cc: Alex Deucher Cc: Christian König --- drivers/gpu/drm/radeon/r100.c | 2 +- drivers/gpu/drm/radeon/radeon_kms.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/dr

[PATCH v2 16/20] drm/radeon: Remove references to struct drm_device.pdev

2020-12-01 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert radeon to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Alex Deucher Cc: Alex Deucher Cc: Christian König --- drivers/gpu/drm/radeon/atombios_encoders.c| 6 +- drivers/gpu/drm/radeon/r100.c

[PATCH v2 18/20] drm/virtgpu: Remove references to struct drm_device.pdev

2020-12-01 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert virtgpu to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg Cc: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/vir

[PATCH v2 19/20] drm/vmwgfx: Remove references to struct drm_device.pdev

2020-12-01 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert vmwgfx to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Zack Rusin Acked-by: Sam Ravnborg Cc: Roland Scheidegger --- drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c | 8 drivers/gpu/drm/vmwgfx/v

[PATCH v2 20/20] drm: Upcast struct drm_device.dev to struct pci_device; replace pdev

2020-12-01 Thread Thomas Zimmermann
We have DRM drivers based on USB, SPI and platform devices. All of them are fine with storing their device reference in struct drm_device.dev. PCI devices should be no exception. Therefore struct drm_device.pdev is deprecated. Instead upcast from struct drm_device.dev with to_pci_dev(). PCI-specif

[PATCH v2 17/20] drm/vboxvideo: Remove references to struct drm_device.pdev

2020-12-01 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert vboxvideo to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg Cc: Hans de Goede --- drivers/gpu/drm/vboxvideo/vbox_drv.c | 11 ++- drivers/gpu/drm/vboxvideo/vbox_irq.c | 4 +++-

Re: [PATCH v2 01/20] drm/amdgpu: Fix trailing whitespaces

2020-12-01 Thread Christian König
Reviewed-by: Christian König on patch #1 and #15. Acked-by: Christian König on patch #2 and #16. Regards, Christian. Am 01.12.20 um 11:35 schrieb Thomas Zimmermann: Adhere to kernel coding style. Signed-off-by: Thomas Zimmermann Acked-by: Alex Deucher Acked-by: Sam Ravnborg Cc: Alex Deuc

Re: [PATCH] fbdev: Remove udlfb driver

2020-12-01 Thread Mikulas Patocka
On Tue, 1 Dec 2020, Thomas Zimmermann wrote: > Hi > > Am 30.11.20 um 15:31 schrieb Mikulas Patocka: > > > > > > On Mon, 30 Nov 2020, Thomas Zimmermann wrote: > > > > > Udlfb has been superseded by DRM's udl. The DRM driver is better by > > > any means and actively maintained. Remove udlfb.

Re: GPU-side memory protection landscape

2020-12-01 Thread Michel Dänzer
On 2020-11-30 3:07 p.m., Alexander Monakov wrote: My other concern is how easy it is to cause system instability or hangs by out-of-bounds writes from the GPU (via compute shaders or copy commands). In my experience of several years doing GPU computing with NVIDIA tech, I don't recall needing to

Re: [PATCH] drm: mxsfb: Add interconnect path request

2020-12-01 Thread Lucas Stach
Am Dienstag, den 01.12.2020, 11:37 +0100 schrieb Martin Kepplinger: > Add interconnect support to mxsfb so that it is able to request enough > bandwidth to DDR for display output to work. > > Signed-off-by: Martin Kepplinger > --- >  drivers/gpu/drm/mxsfb/mxsfb_drv.c | 33

Re: [PATCH] fbdev: Remove udlfb driver

2020-12-01 Thread Mikulas Patocka
On Tue, 1 Dec 2020, Thomas Zimmermann wrote: > Hi > > Am 30.11.20 um 19:39 schrieb Mikulas Patocka: > > > > > > On Mon, 30 Nov 2020, Daniel Vetter wrote: > > > > > On Mon, Nov 30, 2020 at 09:31:15AM -0500, Mikulas Patocka wrote: > > > > > > > > The framebuffer driver supports programs runn

Re: [PATCH] fbdev: Remove udlfb driver

2020-12-01 Thread Mikulas Patocka
On Mon, 30 Nov 2020, Daniel Vetter wrote: > On Mon, Nov 30, 2020 at 01:39:17PM -0500, Mikulas Patocka wrote: > > > > > > On Mon, 30 Nov 2020, Daniel Vetter wrote: > > > > > On Mon, Nov 30, 2020 at 09:31:15AM -0500, Mikulas Patocka wrote: > > > > > > > > The framebuffer driver supports progr

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Thomas Zimmermann
Hi Am 01.12.20 um 11:34 schrieb Christian König: [...] In patch 6 of this series, there's ast cursor code that acquires two BO's reservation locks and vmaps them afterwards. That's probably how you intend to use dma_buf_vmap_local. However, I think it's more logically to have a vmap callback

[PATCH v1 0/1] drm/imx/dcss: Add interconnect support

2020-12-01 Thread Guido Günther
This allows us to raise DRAM bandiwth to a high enough value for a stable picture on i.mx8mq. We pick a bandwidth that should be sufficient for 4k@60Hz. This was tested on a Librem 5 with the (not yet) mainline mhdp DP controller. Without that initial boot works fine but e.g. fb unblank results in

[PATCH v1 1/1] drm/imx/dcss: Add interconnect support

2020-12-01 Thread Guido Günther
This allows us to raise DRAM bandiwth to a high enough value for a stable picture on i.mx8mq. We pick a bandwidth that should be sufficient for 4k@60Hz. Modelled like mdp5_kms. Signed-off-by: Guido Günther --- drivers/gpu/drm/imx/dcss/dcss-dev.c | 47 +++-- drivers/gpu/d

Re: [PATCH v1 1/1] drm/imx/dcss: Add interconnect support

2020-12-01 Thread Lucas Stach
Am Dienstag, den 01.12.2020, 12:34 +0100 schrieb Guido Günther: > This allows us to raise DRAM bandiwth to a high enough value for a > stable picture on i.mx8mq. We pick a bandwidth that should be sufficient > for 4k@60Hz. > > Modelled like mdp5_kms. > > Signed-off-by: Guido Günther > --- >  dri

Re: [PATCH v5 1/6] dt-bindings: display: simple: Add EDT ETM0700G0BDH6 display

2020-12-01 Thread Sam Ravnborg
Hi Oleksij On Tue, Dec 01, 2020 at 10:27:37AM +0100, Oleksij Rempel wrote: > This display is already supported by the panel-simple driver, so add it > to the bindings documentation. > > This patch is needed to fix checkpatch warnings for the PLYM2M dts. > > Signed-off-by: Oleksij Rempel > --- >

Re: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color

2020-12-01 Thread Imre Deak
Hi Nanley, thanks for the review. +Ville, Chris. On Tue, Dec 01, 2020 at 02:18:26AM +0200, Chery, Nanley G wrote: > Hi Imre, > > I have a question and a couple comments: > > Is the map of the clear color address creating a new synchronization > point between the GPU and CPU? If so, I wonder h

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Thomas Zimmermann
Hi Am 01.12.20 um 11:00 schrieb Daniel Vetter: [...] For my POV, the current interfaces have no clear policy or semantics. Looking through the different GEM implementations, each one seems to have its own interpretation. Yup, that's the problem really. In the past we've had vmap exclusively fo

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Christian König
Am 01.12.20 um 12:30 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 11:34 schrieb Christian König: [...] In patch 6 of this series, there's ast cursor code that acquires two BO's reservation locks and vmaps them afterwards. That's probably how you intend to use dma_buf_vmap_local. However, I

Re: [PATCH drm/hisilicon v2 1/4] drm/hisilicon: Assgin local variable to drm_device

2020-12-01 Thread Thomas Zimmermann
Hi Am 01.12.20 um 12:55 schrieb Tian Tao: Assign local variable to struct drm_device *dev because they are used multiple times within a function. Signed-off-by: Tian Tao --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 2 +- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 30 +

Re: [PATCH v7 17/17] mm: add mmu_notifier argument to follow_pfn

2020-12-01 Thread Nick Desaulniers
On Mon, Nov 30, 2020 at 6:28 AM Daniel Vetter wrote: > > So I guess kvm platforms that don't set KVM_ARCH_WANT_MMU_NOTIFIER exist, > and at least on powerpc they're consistent with KVM_CAP_SYNC_MMU > signalling that the guest pagetables stays in sync automatically with any > updates. So for that c

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Thomas Zimmermann
Hi Am 01.12.20 um 13:14 schrieb Christian König: Am 01.12.20 um 12:30 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 11:34 schrieb Christian König: [...] In patch 6 of this series, there's ast cursor code that acquires two BO's reservation locks and vmaps them afterwards. That's probably how

Re: [PATCH drm/hisilicon v2 1/4] drm/hisilicon: Assgin local variable to drm_device

2020-12-01 Thread Thomas Zimmermann
Hi Am 01.12.20 um 13:26 schrieb tiantao (H): 在 2020/12/1 20:17, Thomas Zimmermann 写道: Hi Am 01.12.20 um 12:55 schrieb Tian Tao: Assign local variable to struct drm_device *dev because they are used multiple times within a function. Signed-off-by: Tian Tao ---   drivers/gpu/drm/hisilicon/h

  1   2   >