On Fri, 27 Nov 2020, Sam Ravnborg wrote:
> Fix trivial W=1 warnings.
> Update kernel-doc to avoid the warnings.
Can you put what's being fixed in the subject line please?
"fix w=1 warnings" is very bland and this it is unlikely to be the
only w=1 warning that gets fixed in these files, so has a
On Thu, 26 Nov 2020 17:59:49 +0100,
Uwe Kleine-König wrote:
>
> The remove callback is only called for devices that were probed
> successfully before. As the matching probe function cannot complete
> without error if dev->match_id != PS3_MATCH_ID_SOUND, we don't have to
> check this here.
>
> Sig
On Thu, 26 Nov 2020 17:59:50 +0100,
Uwe Kleine-König wrote:
>
> The driver core ignores the return value of struct device_driver::remove
> because there is only little that can be done. For the shutdown callback
> it's ps3_system_bus_shutdown() which ignores the return value.
>
> To simplify the
Hi, Enric:
Enric Balletbo i Serra 於 2020年11月27日 週五 下午7:02寫道：
>
> Aliases property name must include only lowercase and '-', so fix this
> in the driver, so we're not tempted to do "ovl_2l0 = &ovl_2l0" in the
> device-tree instead of the right one which is "ovl-2l0 = &ovl_2l0".
>
Applied to media
Hi Lee,
On Sat, Nov 28, 2020 at 08:28:20AM +, Lee Jones wrote:
> On Fri, 27 Nov 2020, Sam Ravnborg wrote:
>
> > Fix trivial W=1 warnings.
> > Update kernel-doc to avoid the warnings.
>
> Can you put what's being fixed in the subject line please?
>
> "fix w=1 warnings" is very bland and this
Hi Paul.
On Sat, Nov 28, 2020 at 05:16:06PM +, Paul Cercueil wrote:
> Call drm_mode_config_helper_suspend() and
> drm_mode_config_helper_resume() on suspend and resume, respectively.
>
> This makes sure that the display stack is properly disabled when the
> hardware is put to sleep.
>
> Sign
Hi Tomi,
Thank you for the patch.
On Fri, Nov 27, 2020 at 10:52:41AM +0200, Tomi Valkeinen wrote:
> When the SDI output was converted to DRM bridge, the atomic versions of
> enable and disable funcs were used. This was not intended, as that would
> require implementing other atomic funcs too. Thi
Hi Sebastian,
Thank you for the patch.
On Fri, Nov 27, 2020 at 09:04:29PM +0100, Sebastian Reichel wrote:
> The probe routine acquires the reset GPIO using GPIOD_OUT_LOW. Directly
> afterwards it calls acx565akm_detect(), which sets the GPIO value to
> HIGH. If the bootloader initialized the GPIO
Following the great work of Lee Jones in other subsystems
here is a set of patches that address all remaining W=1
warnings in drivers/video/.
Lee Jones already fixed all warnings in video/backlight/ so
this is mostly fbdev related fixes.
The general approach used were:
- Fix kernel-doc, this is of
Fix kernel-doc warnings reported when using W=1.
v2:
- Improve subject (Lee)
Signed-off-by: Sam Ravnborg
Cc: Lee Jones
Cc: linux-fb...@vger.kernel.org
---
drivers/video/of_display_timing.c | 1 +
drivers/video/of_videomode.c | 8
2 files changed, 5 insertions(+), 4 deletions(-)
Fix kernel-doc warnings reported when using W=1
v2:
- Improve subject (Lee)
Signed-off-by: Sam Ravnborg
Cc: Lee Jones
Cc: Sam Ravnborg
Cc: Randy Dunlap
Cc: Bartlomiej Zolnierkiewicz
Cc: Daniel Vetter
Cc: "Alexander A. Klimov"
---
drivers/video/fbdev/core/fb_notify.c | 3 ++-
drivers/vid
Fix warning about variable that is asssigned a value but never used.
The variable was indeed never used so delete it.
Keep the call to radeon_probe_i2c_connector() as it may have
side-effects. It is unlikely but I could not verify that is was safe to
drop the call.
Signed-off-by: Sam Ravnborg
Cc
Replacing DPRINTK() statements with pr_debug fixes set but not used
warnings. And moves to a more standard logging setup at the same time.
v2:
- Fix indent (Joe)
Signed-off-by: Sam Ravnborg
Cc: Joe Perches
Cc: Greg Kroah-Hartman
Cc: Daniel Vetter
Cc: Bartlomiej Zolnierkiewicz
Cc: Sam Ravn
Fix W=1 warnings about variables assigned but never used.
- Drop variables that was set but never used
- Make variable definition conditional om ATARI
v2:
- Fix m68k build error (kernel test robot)
- Improve subject (Lee Jones)
Signed-off-by: Sam Ravnborg
Reported-by: kernel test robot # m
Fix W=1 warning by commenting unused SiS_TVDelay* variables.
The SiS_TVDelay* variables seem to contain some magic numbers
so looks like data worth keeping around but not as code we build.
v2:
- Update subject (Lee)
Signed-off-by: Sam Ravnborg
Cc: Thomas Winischhofer
Cc: Lee Jones
---
driv
Fix warnings by dropping unused variable and the
unused assignments.
v2:
- Update subject (Lee)
Signed-off-by: Sam Ravnborg
Cc: Thomas Winischhofer
Cc: Lee Jones
---
drivers/video/fbdev/sis/sis_main.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/video
Fix W=1 warnings about variables assigned but never used.
- One variable is only used when CONFIG_FB_ATY_GENERIC_LCD is defined
Fix so variable is only defined with CONFIG_FB_ATY_GENERIC_LCD
- Several variables was only assigned by a call to aty_ld_le32().
Drop the variables but keep the call t
Fix warning by deleting the variable. The function call
viafb_get_best_mode() were verified to have no side-effects,
and thus could be dropped too.
v2:
- Update subject (Lee)
Signed-off-by: Sam Ravnborg
Cc: Florian Tobias Schandinat
Cc: linux-fb...@vger.kernel.org
Cc: Lee Jones
---
drivers/
Fix W=1 warnings by removing unused code
v2:
- Updated subject (Lee)
Signed-off-by: Sam Ravnborg
Cc: Bartlomiej Zolnierkiewicz
Cc: Sam Ravnborg
Cc: Andrew Morton
Cc: Evgeny Novikov
Cc: Jani Nikula
Cc: Mike Rapoport
Cc: Lee Jones
---
drivers/video/fbdev/neofb.c | 4
1 file changed,
Fix kernel-doc comments.
v2:
- Updated subject (Lee)
Signed-off-by: Sam Ravnborg
Cc: Ferenc Bakonyi
Cc: linux-nvi...@lists.surfsouth.com
Cc: Lee Jones
---
drivers/video/fbdev/hgafb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/hgafb.c b/driver
Fixed a few kernel-doc issues to fix the warnings.
v2:
- Updated subject (Lee)
Signed-off-by: Sam Ravnborg
Cc: Sam Ravnborg
Cc: "Gustavo A. R. Silva"
Cc: Randy Dunlap
Cc: Arnd Bergmann
Cc: Bartlomiej Zolnierkiewicz
Cc: Jani Nikula
Cc: Lee Jones
---
drivers/video/fbdev/pm2fb.c | 8 -
Fix W=1 warnings:
- Fix kernel-doc
- Drop unused code
v2:
- Updated subject (Lee)
Signed-off-by: Sam Ravnborg
Cc: Sam Ravnborg
Cc: Jani Nikula
Cc: Bartlomiej Zolnierkiewicz
Cc: Daniel Vetter
Cc: Arnd Bergmann
Cc: Joe Perches
Cc: Lee Jones
---
drivers/video/fbdev/tgafb.c | 7 +++
1
The tmp variable were assigned but the result was never used,
so delete the tmp variable.
v2:
- Update subject (Lee)
Signed-off-by: Sam Ravnborg
Cc: "Gustavo A. R. Silva"
Cc: Sam Ravnborg
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Arnd Bergmann
Cc: Lee Jones
---
drivers/video/fbdev/tdfxfb.c
Fix W=1 warnings:
- Fix kernel-doc
- Drop unused code/variables
- Use memcpy to copy a string without zero-termination
strncpy() generates a warning
v2:
- Updated subject (Lee)
Signed-off-by: Sam Ravnborg
Cc: Sam Ravnborg
Cc: Jani Nikula
Cc: Laurent Pinchart
Cc: Daniel Vetter
Cc: Xiaofei
Fix set bit not used warnings by removing the code the assign the
variables and the definition of the variables.
A register read is kept as it may have unknown side-effects.
This removes a lot of unused code - which is always a good thing to do.
v2:
- Updated subject (Lee)
Signed-off-by: Sam R
Fix W=1 warnings:
- Fix kernel-doc
- Drop unused variables/code
v2:
- Updated subject (Lee)
Signed-off-by: Sam Ravnborg
Cc: Antonino Daplas
Cc: linux-fb...@vger.kernel.org
Cc: Lee Jones
---
drivers/video/fbdev/riva/fbdev.c | 9 -
drivers/video/fbdev/riva/riva_hw.c | 28 --
Fix warnings by deleting unused code. The register reads are
kept as it is unknown if there are any hidden side-effects.
v2:
- Update subject (Lee)
Signed-off-by: Sam Ravnborg
Cc: Antonino Daplas
Cc: linux-fb...@vger.kernel.org
Cc: Lee Jones
---
drivers/video/fbdev/nvidia/nv_setup.c | 7 ++-
Fix several W=1 warnings.
This removes unused code and avoids an assignment by moving
the use inside the conditional block.
The register read FLD_GET(r, 15, 8) could be dropped as it was done a
few lines before too.
v2:
- Updated subject (Lee)
Signed-off-by: Sam Ravnborg
Cc: Aditya Pakki
Cc:
Fix a few W=1 warnings about unused assignments.
Drop the unused error code.
v2:
- Subject updated (Lee)
Signed-off-by: Sam Ravnborg
Cc: Sam Ravnborg
Cc: Qilong Zhang
Cc: "Alexander A. Klimov"
Cc: Daniel Vetter
Cc: Lee Jones
---
drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c | 4 ++--
Fix warnings:
- drop kernel-doc for the two debug functions to avoid the warnings
- delete unused code
v2:
- Updated subject (Lee)
Signed-off-by: Sam Ravnborg
Cc: Thomas Zimemrmann
Cc: Sam Ravnborg
Cc: "Gustavo A. R. Silva"
Cc: Daniel Vetter
Cc: Saeed Mirzamohammadi
Cc: Jani Nikula
Cc: M
Fix W=1 warnings by avoiding local variables and use direct references.
v2:
- Updated subject (Lee)
Signed-off-by: Sam Ravnborg
Cc: Daniel Vetter
Cc: Sam Ravnborg
Cc: Jani Nikula
Cc: Lee Jones
---
drivers/video/fbdev/tmiofb.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
di
Fix set but not used warnings by introducing no_printk variants
for the internal logging system for this driver.
Fix a new warning that popped up now that logging was checked for
correct printf format strings.
A more invasive fix had been to replace all the internal logging with
standard logging
init.h define static symbols, so should only be included
once. Drop the include from sis.h as it is not needed.
This fixes a lot of warnings seen with a W=1 build.
v2:
- Update subject (Lee)
Signed-off-by: Sam Ravnborg
Cc: Thomas Winischhofer
Cc: Lee Jones
---
drivers/video/fbdev/sis/sis.h
Two W=1 string related warnings.
- Using strncpy to copy string without null-termination generates a
warning. Use memcpy to copy only the relevant chars
- Fix a potential bug with a very long string, subtract one from the
length to make room for the termination null.
Signed-off-by: Sam Ravnb
Fix W=1 warning by deleting unused local variable.
v2:
- Updated subject (Lee)
Signed-off-by: Sam Ravnborg
Cc: Michal Januszewski
Cc: linux-fb...@vger.kernel.org
Cc: Lee Jones
---
drivers/video/fbdev/uvesafb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/v
Fix several W=1 warnings
- Updated kernel-doc as needed
- Deleted unused local variable, it was assigned but never used
v2:
- Updated subject (Lee)
Signed-off-by: Sam Ravnborg
Cc: Jingoo Han
Cc: linux-fb...@vger.kernel.org
Cc: Lee Jones
---
drivers/video/fbdev/s3c-fb.c | 11 ++-
1 f
Fix following W=1 warnings:
- Fix set but not nused variables which was used only for logging.
Fixed by introducing no_printk() to trick compiler to think variables
are used
- Fix kernel-doc warning by deleting an empty comment line
v2:
- Subject updated (Lee)
Signed-off-by: Sam Ravnborg
C
Hi, Dave & Daniel:
This includes:
1. Add MT8167 support
2. Cleanup function
3. Convert the dpi bindings to yaml
4. Drop local dma_parms
5. Fix formatting and provide missing member description
6. Introduce GEM object functions
7. Fix aliases name
Regards,
Chun-Kuang.
The following changes since
Hi Laurent,
On Sun, Nov 29, 2020 at 12:08:47AM +0200, Laurent Pinchart wrote:
> On Fri, Nov 27, 2020 at 09:04:29PM +0100, Sebastian Reichel wrote:
> > The probe routine acquires the reset GPIO using GPIOD_OUT_LOW. Directly
> > afterwards it calls acx565akm_detect(), which sets the GPIO value to
>
39 matches
Mail list logo
