Re: [PATCH rdma-core 3/5] pyverbs: Add dma-buf based MR support

2020-11-25 Thread Jason Gunthorpe
On Tue, Nov 24, 2020 at 04:16:58PM +0100, Daniel Vetter wrote: > Compute is the worst, because opencl is widely considered a mistake (maybe > opencl 3 is better, but nvidia is stuck on 1.2). The actually used stuff is > cuda (nvidia-only), rocm (amd-only) and now with intel also playing we > have

RE: Linux 5.10-rc4; graphics alignment

2020-11-25 Thread David Laight
From: David Laight > Sent: 20 November 2020 15:39 > > From: Thomas Zimmermann > > Sent: 20 November 2020 13:42 > ... > > I did a diff from v5.10-rc4 to drm-tip to look for suspicious changes. > > Some candidates are > > > >8e3784dfef8a ("drm/ast: Reload gamma LUT after changing primary > > pla

Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-25 Thread Miguel Ojeda
On Tue, Nov 24, 2020 at 11:24 PM Finn Thain wrote: > > These statements are not "missing" unless you presume that code written > before the latest de facto language spec was written should somehow be > held to that spec. There is no "language spec" the kernel adheres to. Even if it did, kernel co

[PATCHv10 5/9] drm/msm: rearrange the gpu_rmw() function

2020-11-25 Thread Sai Prakash Ranjan
From: Sharat Masetty The register read-modify-write construct is generic enough that it can be used by other subsystems as needed, create a more generic rmw() function and have the gpu_rmw() use this new function. Signed-off-by: Sharat Masetty Reviewed-by: Jordan Crouse Signed-off-by: Sai Prak

Re: [Freedreno] [PATCH 3/3] drm/msm/dpu: add support for clk and bw scaling for display

2020-11-25 Thread kalyan_t
On 2020-11-08 23:25, Amit Pundir wrote: On Tue, 4 Aug 2020 at 21:09, Rob Clark wrote: On Thu, Jul 16, 2020 at 4:36 AM Kalyan Thota wrote: > > This change adds support to scale src clk and bandwidth as > per composition requirements. > > Interconnect registration for bw has been moved to mdp

Re: [PATCH rdma-core 1/5] verbs: Support dma-buf based memory region

2020-11-25 Thread Yishai Hadas
On 11/23/2020 7:53 PM, Jianxin Xiong wrote: Add new API function and new provider method for registering dma-buf based memory region. Update the man page and bump the API version. Signed-off-by: Jianxin Xiong --- kernel-headers/rdma/ib_user_ioctl_cmds.h | 14 libibverbs/cmd_mr.c

[PATCHv10 0/9] System Cache support for GPU and required SMMU support

2020-11-25 Thread Sai Prakash Ranjan
Some hardware variants contain a system cache or the last level cache(llc). This cache is typically a large block which is shared by multiple clients on the SOC. GPU uses the system cache to cache both the GPU data buffers(like textures) as well the SMMU pagetables. This helps with improved render

[PATCH] drm/i915: fix error return code in check_partial_mapping()

2020-11-25 Thread Luo Meng
Fix to return a negative error code from the error handling case instead of 0 in function check_partial_mapping(), as done elsewhere in this function. Fixes: 07e98eb0a174 ("drm/i915/selftests: Tighten the timeout testing for partial mmaps") Reported-by: Hulk Robot Signed-off-by: Luo Meng --- d

Re: [REGRESSION] omapdrm/N900 display broken

2020-11-25 Thread Ivaylo Dimitrov
Hi, On 25.08.20 г. 16:16 ч., Tomi Valkeinen wrote: Hi Laurent, On 23/08/2020 19:26, Aaro Koskinen wrote: Hi, On Tue, Aug 04, 2020 at 03:39:37PM +0300, Tomi Valkeinen wrote: On 04/08/2020 15:13, Tomi Valkeinen wrote: Can you try to pinpoint a bit where the hang happens? Maybe add DRM/omapd

[PATCHv10 2/9] iommu/io-pgtable-arm: Add support to use system cache

2020-11-25 Thread Sai Prakash Ranjan
Add a quirk IO_PGTABLE_QUIRK_ARM_OUTER_WBWA to override the outer-cacheability attributes set in the TCR for a non-coherent page table walker when using system cache. Signed-off-by: Sai Prakash Ranjan --- drivers/iommu/io-pgtable-arm.c | 10 -- include/linux/io-pgtable.h | 4 2

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-25 Thread Miguel Ojeda
On Mon, Nov 23, 2020 at 9:38 PM James Bottomley wrote: > > So you think a one line patch should take one minute to produce ... I > really don't think that's grounded in reality. No, I have not said that. Please don't put words in my mouth (again). I have said *authoring* lines of *this* kind tak

Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-25 Thread Miguel Ojeda
On Wed, Nov 25, 2020 at 12:53 AM Finn Thain wrote: > > I'm saying that supporting the official language spec makes more sense > than attempting to support a multitude of divergent interpretations of the > spec (i.e. gcc, clang, coverity etc.) Making the kernel strictly conforming is a ship that s

[PATCH 2/2] dt-bindings: display/panel: add Innolux N125HCE-GN1

2020-11-25 Thread Lukas F. Hartmann
The Innolux N125HCE-GN1 display is used in the MNT Reform 2.0 laptop, attached via eDP to a SN65DSI86 MIPI-DSI to eDP bridge. This patch contains the DT binding for "innolux,n125hce-gn1". Signed-off-by: Lukas F. Hartmann --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++

Re: [Freedreno] [PATCH 3/3] drm/msm/dpu: add support for clk and bw scaling for display

2020-11-25 Thread Amit Pundir
Hi Kalyan, On Tue, 24 Nov 2020 at 18:27, wrote: > > On 2020-11-08 23:25, Amit Pundir wrote: > > On Tue, 4 Aug 2020 at 21:09, Rob Clark wrote: > >> > >> On Thu, Jul 16, 2020 at 4:36 AM Kalyan Thota > >> wrote: > >> > > >> > This change adds support to scale src clk and bandwidth as > >> > per co

Re: [Intel-gfx] [PATCH] dma-buf/dma-resv: Respect num_fences when initializing the shared fence list.

2020-11-25 Thread Thomas Hellström
On 11/24/20 12:57 PM, Maarten Lankhorst wrote: We hardcode the maximum number of shared fences to 4, instead of respecting num_fences. Use a minimum of 4, but more if num_fences is higher. This seems to have been an oversight when first implementing the api. Fixes: 04a5faa8cbe5 ("reservation:

[PATCHv10 1/9] iommu/io-pgtable: Add a domain attribute for pagetable configuration

2020-11-25 Thread Sai Prakash Ranjan
Add a new iommu domain attribute DOMAIN_ATTR_IO_PGTABLE_CFG for pagetable configuration which initially will be used to set quirks like for system cache aka last level cache to be used by client drivers like GPU to set right attributes for caching the hardware pagetables into the system cache and l

[PATCHv10 3/9] iommu/arm-smmu: Add support for pagetable config domain attribute

2020-11-25 Thread Sai Prakash Ranjan
Add support for domain attribute DOMAIN_ATTR_IO_PGTABLE_CFG to get/set pagetable configuration data which initially will be used to set quirks and later can be extended to include other pagetable configuration data. Signed-off-by: Sai Prakash Ranjan --- drivers/iommu/arm/arm-smmu/arm-smmu.c | 20

[PATCH 1/2] panel-simple: add Innolux N125HCE-GN1

2020-11-25 Thread Lukas F. Hartmann
The Innolux N125HCE-GN1 display is used in the MNT Reform 2.0 laptop, attached via eDP to a SN65DSI86 MIPI-DSI to eDP bridge. Signed-off-by: Lukas F. Hartmann --- drivers/gpu/drm/panel/panel-simple.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/gpu/dr

Re: [PATCH 2/3] mm: Extract might_alloc() debug check

2020-11-25 Thread Jason Gunthorpe
On Tue, Nov 24, 2020 at 03:34:11PM +0100, Daniel Vetter wrote: > On Fri, Nov 20, 2020 at 02:07:19PM -0400, Jason Gunthorpe wrote: > > On Fri, Nov 20, 2020 at 10:54:43AM +0100, Daniel Vetter wrote: > > > diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h > > > index d5ece7a9a403..f9440

Re: [PATCHv9 3/8] iommu/arm-smmu: Move non-strict mode to use io_pgtable_domain_attr

2020-11-25 Thread Sai Prakash Ranjan
On 2020-11-25 03:09, Will Deacon wrote: On Mon, Nov 23, 2020 at 10:35:56PM +0530, Sai Prakash Ranjan wrote: Now that we have a struct io_pgtable_domain_attr with quirks, use that for non_strict mode as well thereby removing the need for more members of arm_smmu_domain in the future. Signed-off-

[PATCHv10 6/9] drm/msm/a6xx: Add support for using system cache(LLC)

2020-11-25 Thread Sai Prakash Ranjan
From: Sharat Masetty The last level system cache can be partitioned to 32 different slices of which GPU has two slices preallocated. One slice is used for caching GPU buffers and the other slice is used for caching the GPU SMMU pagetables. This talks to the core system cache driver to acquire the

Re: [PATCH v2 2/9] misc: Add Xilinx AI engine device driver

2020-11-25 Thread Wendy Liang
On 11/19/20 12:12 PM, Dave Airlie wrote: diff --git a/MAINTAINERS b/MAINTAINERS index 5cc595a..40e3351 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19283,6 +19283,14 @@ T: git https://github.com/Xilinx/linux-xlnx.git F: Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml

Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-25 Thread Finn Thain
On Wed, 25 Nov 2020, Miguel Ojeda wrote: > > The C standard has nothing to do with this. We use compiler extensions > of several kinds, for many years. Even discounting those extensions, the > kernel is not even conforming to C due to e.g. strict aliasing. I am not > sure what you are trying

[PATCH] Revert "i2c: qcom-geni: Disable DMA processing on the Lenovo Yoga C630"

2020-11-25 Thread Bjorn Andersson
A combination of recent bug fixes by Doug Anderson and the proper definition of iommu streams means that this hack is no longer needed. Let's clean up the code by reverting '127068abe85b ("i2c: qcom-geni: Disable DMA processing on the Lenovo Yoga C630")'. Signed-off-by: Bjorn Andersson --- drive

[PATCHv10 9/9] iommu: arm-smmu-impl: Add a space before open parenthesis

2020-11-25 Thread Sai Prakash Ranjan
Fix the checkpatch warning for space required before the open parenthesis. Signed-off-by: Sai Prakash Ranjan Acked-by: Will Deacon --- drivers/iommu/arm/arm-smmu/arm-smmu-impl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-impl.c b/dri

Re: [PATCH v11 1/4] RDMA/umem: Support importing dma-buf as user memory region

2020-11-25 Thread Jason Gunthorpe
On Tue, Nov 24, 2020 at 06:24:43PM +, Xiong, Jianxin wrote: > > From: Christoph Hellwig > > Sent: Tuesday, November 24, 2020 1:34 AM > > To: Xiong, Jianxin > > Cc: linux-r...@vger.kernel.org; dri-devel@lists.freedesktop.org; Doug > > Ledford ; Jason Gunthorpe ; > > Leon Romanovsky ; Sumit Se

[RFC] dcss: fix attaching to sn56dsi86 bridge

2020-11-25 Thread Lukas F. Hartmann
The sn56dsi86 DSI to eDP bridge driver does not support attaching without a drm connector. This patch makes the attachment work. Required for the display chain in MNT Reform 2.0 (DCSS->NWL DSI->SN56DSI86->EDP). Signed-off-by: Lukas F. Hartmann --- drivers/gpu/drm/imx/dcss/dcss-kms.c | 15 +++

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-11-25 Thread Christophe Leroy
Le 21/05/2020 à 12:38, Christophe Leroy a écrit : Le 21/05/2020 à 09:02, Michael Ellerman a écrit : Arnd Bergmann writes: +On Wed, Apr 8, 2020 at 2:04 PM Michael Ellerman wrote: Benjamin Herrenschmidt writes: On Fri, 2020-04-03 at 15:59 +1100, Michael Ellerman wrote: Benjamin Herrensc

Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-25 Thread Finn Thain
On Tue, 24 Nov 2020, Kees Cook wrote: > On Mon, Nov 23, 2020 at 08:31:30AM -0800, James Bottomley wrote: > > Really, no ... something which produces no improvement has no value at > > all ... we really shouldn't be wasting maintainer time with it because > > it has a cost to merge. I'm not sure

nwl-dsi: fixup mode only for LCDIF input, not DCSS

2020-11-25 Thread Lukas F. Hartmann
The fixup of HSYNC and VSYNC should not be done when the input source is DCSS, or internal display does not work on MNT Reform 2 (open hardware laptop based on NXP i.MX8M using DCSS->DSI->eDP for internal display). Signed-off-by: Lukas F. Hartmann --- drivers/gpu/drm/bridge/nwl-dsi.c | 12 +

Re: [PATCHv9 2/8] iommu/arm-smmu: Add domain attribute for pagetable configuration

2020-11-25 Thread Sai Prakash Ranjan
On 2020-11-25 03:11, Will Deacon wrote: On Mon, Nov 23, 2020 at 10:35:55PM +0530, Sai Prakash Ranjan wrote: Add iommu domain attribute for pagetable configuration which initially will be used to set quirks like for system cache aka last level cache to be used by client drivers like GPU to set ri

[PATCHv10 8/9] iommu: arm-smmu-impl: Use table to list QCOM implementations

2020-11-25 Thread Sai Prakash Ranjan
Use table and of_match_node() to match qcom implementation instead of multiple of_device_compatible() calls for each QCOM SMMU implementation. Signed-off-by: Sai Prakash Ranjan Acked-by: Will Deacon --- drivers/iommu/arm/arm-smmu/arm-smmu-impl.c | 9 + drivers/iommu/arm/arm-smmu/arm-sm

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-25 Thread Miguel Ojeda
On Tue, Nov 24, 2020 at 1:58 AM Finn Thain wrote: > > What I meant was that you've used pessimism as if it was fact. "future mistakes that it might prevent" is neither pessimism nor states a fact. > For example, "There is no way to guess what the effect would be if the > compiler trained program

Re: [PATCH v6 17/17] RFC: mm: add mmu_notifier argument to follow_pfn

2020-11-25 Thread Jason Gunthorpe
On Tue, Nov 24, 2020 at 03:28:14PM +0100, Daniel Vetter wrote: > On Fri, Nov 20, 2020 at 02:30:29PM -0400, Jason Gunthorpe wrote: > > On Thu, Nov 19, 2020 at 03:41:46PM +0100, Daniel Vetter wrote: > > > @@ -4805,21 +4824,15 @@ EXPORT_SYMBOL(follow_pte_pmd); > > > * Return: zero and the pfn at @pf

Re: [PATCH rdma-core v2 2/6] verbs: Support dma-buf based memory region

2020-11-25 Thread Yishai Hadas
On 11/24/2020 11:38 PM, Jianxin Xiong wrote: Add new API function and new provider method for registering dma-buf based memory region. Update the man page and bump the API version. Signed-off-by: Jianxin Xiong I don't see that this  V2 fixes the notes that I published on V1 (fork handling ,

[PATCHv10 7/9] drm/msm/a6xx: Add support for using system cache on MMU500 based targets

2020-11-25 Thread Sai Prakash Ranjan
From: Jordan Crouse GPU targets with an MMU-500 attached have a slightly different process for enabling system cache. Use the compatible string on the IOMMU phandle to see if an MMU-500 is attached and modify the programming sequence accordingly. Signed-off-by: Jordan Crouse Signed-off-by: Sai

[PATCHv10 4/9] iommu/arm-smmu: Move non-strict mode to use io_pgtable_domain_attr

2020-11-25 Thread Sai Prakash Ranjan
Now that we have a struct io_pgtable_domain_attr with quirks, use that for non_strict mode as well thereby removing the need for more members of arm_smmu_domain in the future. Signed-off-by: Sai Prakash Ranjan --- drivers/iommu/arm/arm-smmu/arm-smmu.c | 15 +-- drivers/iommu/arm/arm-

Re: Linux 5.10-rc4; graphics alignment

2020-11-25 Thread Thomas Zimmermann
Hi Am 24.11.20 um 17:27 schrieb David Laight: From: David Laight Sent: 20 November 2020 15:39 From: Thomas Zimmermann Sent: 20 November 2020 13:42 ... I did a diff from v5.10-rc4 to drm-tip to look for suspicious changes. Some candidates are 8e3784dfef8a ("drm/ast: Reload gamma LUT aft

Re: [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed

2020-11-25 Thread Thomas Zimmermann
Hi Am 24.11.20 um 15:06 schrieb Christian König: Am 24.11.20 um 14:56 schrieb Thomas Zimmermann: Hi Am 24.11.20 um 14:36 schrieb Christian König: Am 24.11.20 um 13:15 schrieb Thomas Zimmermann: [SNIP] First I wanted to put this into drm_gem_ttm_vmap/vunmap(), but then wondered why ttm_bo_vm

Re: [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed

2020-11-25 Thread Thomas Zimmermann
Hi Am 24.11.20 um 15:09 schrieb Daniel Vetter: On Tue, Nov 24, 2020 at 02:56:51PM +0100, Thomas Zimmermann wrote: Hi Am 24.11.20 um 14:36 schrieb Christian König: Am 24.11.20 um 13:15 schrieb Thomas Zimmermann: [SNIP] First I wanted to put this into drm_gem_ttm_vmap/vunmap(), but then wonde

Re: nwl-dsi: fixup mode only for LCDIF input, not DCSS

2020-11-25 Thread Guido Günther
Hi Lukas, On Tue, Nov 24, 2020 at 06:12:17PM +0100, Lukas F. Hartmann wrote: > The fixup of HSYNC and VSYNC should not be done when the input source is > DCSS, or internal display does not work on MNT Reform 2 (open hardware > laptop based on NXP i.MX8M using DCSS->DSI->eDP for internal display).

Re: [PATCH v6 17/17] RFC: mm: add mmu_notifier argument to follow_pfn

2020-11-25 Thread Daniel Vetter
On Wed, Nov 25, 2020 at 9:13 AM Jason Gunthorpe wrote: > > On Tue, Nov 24, 2020 at 03:28:14PM +0100, Daniel Vetter wrote: > > On Fri, Nov 20, 2020 at 02:30:29PM -0400, Jason Gunthorpe wrote: > > > On Thu, Nov 19, 2020 at 03:41:46PM +0100, Daniel Vetter wrote: > > > > @@ -4805,21 +4824,15 @@ EXPORT

Re: [PATCH v3 10/12] drm/amdgpu: Avoid sysfs dirs removal post device unplug

2020-11-25 Thread Daniel Vetter
On Tue, Nov 24, 2020 at 11:27 PM Andrey Grodzovsky wrote: > > > On 11/24/20 9:49 AM, Daniel Vetter wrote: > > On Sat, Nov 21, 2020 at 12:21:20AM -0500, Andrey Grodzovsky wrote: > >> Avoids NULL ptr due to kobj->sd being unset on device removal. > >> > >> Signed-off-by: Andrey Grodzovsky > >> ---

Re: [REGRESSION] omapdrm/N900 display broken

2020-11-25 Thread Daniel Vetter
On Tue, Aug 25, 2020 at 3:16 PM Tomi Valkeinen wrote: > > Hi Laurent, > > On 23/08/2020 19:26, Aaro Koskinen wrote: > > Hi, > > > > On Tue, Aug 04, 2020 at 03:39:37PM +0300, Tomi Valkeinen wrote: > >> On 04/08/2020 15:13, Tomi Valkeinen wrote: > > > >>> Can you try to pinpoint a bit where the hang

[PATCH] drm/ast: Fixed CVE for DP501

2020-11-25 Thread KuoHsiang Chou
[Bug][DP501] 1. For security concerning, P2A have to be disabled by CVE regulation. 2. FrameBuffer reverses last 2MB used for the image of DP501. 3. If P2A is disallowed, the default "ioremap()" behavior is non-cached and could be an alternative accessing on the image of DP501. --- drivers/gpu/

Re: [Intel-gfx] [PATCH] drm/i915: fix error return code in check_partial_mapping()

2020-11-25 Thread Chris Wilson
Quoting Luo Meng (2020-11-25 01:29:38) > Fix to return a negative error code from the error handling case > instead of 0 in function check_partial_mapping(), as done elsewhere > in this function. It's not an error, just the end of testing. -Chris ___ dri

Re: [PATCH 1/6] drm/scheduler: "node" --> "list"

2020-11-25 Thread Christian König
Am 25.11.20 um 04:17 schrieb Luben Tuikov: Rename "node" to "list" in struct drm_sched_job, in order to make it consistent with what we see being used throughout gpu_scheduler.h, for instance in struct drm_sched_entity, as well as the rest of DRM and the kernel. Signed-off-by: Luben Tuikov Re

Re: [PATCH 1/3] drm/virtio: virtio_{blah} --> virtio_gpu_{blah}

2020-11-25 Thread Anthoine Bourgeois
On Mon, Nov 23, 2020 at 06:19:00PM -0800, Gurchetan Singh wrote: virtio_gpu typically uses the prefix virtio_gpu, but there are a few places where the virtio prefix is used. Modify this for consistency. Signed-off-by: Gurchetan Singh Reviewed-by: Anthoine Bourgeois --- drivers/gpu/drm/virti

Re: [PATCH 2/6] gpu/drm: ring_mirror_list --> pending_list

2020-11-25 Thread Christian König
Am 25.11.20 um 04:17 schrieb Luben Tuikov: Rename "ring_mirror_list" to "pending_list", to describe what something is, not what it does, how it's used, or how the hardware implements it. This also abstracts the actual hardware implementation, i.e. how the low-level driver communicates with the d

Re: [PATCH 2/3] drm/virtio: rework virtio_fence_signaled

2020-11-25 Thread Anthoine Bourgeois
On Mon, Nov 23, 2020 at 06:19:01PM -0800, Gurchetan Singh wrote: virtio_gpu_fence_event_process sets the last_fence_id and subsequently calls dma_fence_signal_locked(..). dma_fence_signal_locked(..) sets DMA_FENCE_FLAG_SIGNALED_BIT, which is actually checked before &dma_fence_ops.(*signaled) is

Re: [PATCH 3/3] drm/virtio: consider dma-fence context when signaling

2020-11-25 Thread Anthoine Bourgeois
On Mon, Nov 23, 2020 at 06:28:17PM -0800, Gurchetan Singh wrote: This an incremental refactor towards multiple dma-fence contexts in virtio-gpu. Since all fences are still allocated using &virtio_gpu_fence_driver.context, nothing should break and every processed fence will be signaled. The over

Re: [Intel-gfx] [PATCH] dma-buf/dma-resv: Respect num_fences when initializing the shared fence list.

2020-11-25 Thread Maarten Lankhorst
Op 24-11-2020 om 14:10 schreef Thomas Hellström: > > On 11/24/20 12:57 PM, Maarten Lankhorst wrote: >> We hardcode the maximum number of shared fences to 4, instead of >> respecting num_fences. Use a minimum of 4, but more if num_fences >> is higher. >> >> This seems to have been an oversight when

Re: [PATCH 3/6] drm/scheduler: Job timeout handler returns status

2020-11-25 Thread Christian König
Am 25.11.20 um 04:17 schrieb Luben Tuikov: The job timeout handler now returns status indicating back to the DRM layer whether the job was successfully cancelled or whether more time should be given to the job to complete. Signed-off-by: Luben Tuikov --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.

Re: [PATCH 4/6] drm/scheduler: Essentialize the job done callback

2020-11-25 Thread Christian König
Am 25.11.20 um 04:17 schrieb Luben Tuikov: The job done callback is called from various places, in two ways: in job done role, and as a fence callback role. Essentialize the callback to an atom function to just complete the job, and into a second function as a prototype of fence callback which c

Re: [PATCH 5/6] drm/amdgpu: Don't hardcode thread name length

2020-11-25 Thread Christian König
Am 25.11.20 um 04:17 schrieb Luben Tuikov: Introduce a macro DRM_THREAD_NAME_LEN and use that to define ring name size, instead of hardcoding it to 16. Signed-off-by: Luben Tuikov --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 2 +- include/drm/gpu_scheduler.h | 2 ++ 2 files c

Re: [PATCH 6/6] drm/sched: Make use of a "done" thread

2020-11-25 Thread Christian König
Am 25.11.20 um 04:17 schrieb Luben Tuikov: Add a "done" list to which all completed jobs are added to be freed. The drm_sched_job_done() callback is the producer of jobs to this list. Add a "done" thread which consumes from the done list and frees up jobs. Now, the main scheduler thread only pus

Re: [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed

2020-11-25 Thread Christian König
Am 25.11.20 um 09:37 schrieb Thomas Zimmermann: Hi Am 24.11.20 um 15:09 schrieb Daniel Vetter: On Tue, Nov 24, 2020 at 02:56:51PM +0100, Thomas Zimmermann wrote: Hi Am 24.11.20 um 14:36 schrieb Christian König: Am 24.11.20 um 13:15 schrieb Thomas Zimmermann: [SNIP] First I wanted to put th

Re: [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed

2020-11-25 Thread Daniel Vetter
On Wed, Nov 25, 2020 at 11:13:13AM +0100, Christian König wrote: > Am 25.11.20 um 09:37 schrieb Thomas Zimmermann: > > Hi > > > > Am 24.11.20 um 15:09 schrieb Daniel Vetter: > > > On Tue, Nov 24, 2020 at 02:56:51PM +0100, Thomas Zimmermann wrote: > > > > Hi > > > > > > > > Am 24.11.20 um 14:36 sc

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-25 Thread Andy Shevchenko
On Mon, Nov 23, 2020 at 10:39 PM James Bottomley wrote: > On Mon, 2020-11-23 at 19:56 +0100, Miguel Ojeda wrote: > > On Mon, Nov 23, 2020 at 4:58 PM James Bottomley > > wrote: ... > > But if we do the math, for an author, at even 1 minute per line > > change and assuming nothing can be automate

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-11-25 Thread Daniel Vetter
On Tue, Nov 24, 2020 at 05:44:07PM +0100, Christian König wrote: > Am 24.11.20 um 17:22 schrieb Andrey Grodzovsky: > > > > On 11/24/20 2:41 AM, Christian König wrote: > > > Am 23.11.20 um 22:08 schrieb Andrey Grodzovsky: > > > > > > > > On 11/23/20 3:41 PM, Christian König wrote: > > > > > Am 23.

Re: [PATCH v3 08/12] drm/amdgpu: Split amdgpu_device_fini into early and late

2020-11-25 Thread Daniel Vetter
On Tue, Nov 24, 2020 at 10:51:57AM -0500, Andrey Grodzovsky wrote: > > On 11/24/20 9:53 AM, Daniel Vetter wrote: > > On Sat, Nov 21, 2020 at 12:21:18AM -0500, Andrey Grodzovsky wrote: > > > Some of the stuff in amdgpu_device_fini such as HW interrupts > > > disable and pending fences finilization

Re: [PATCH rdma-core 3/5] pyverbs: Add dma-buf based MR support

2020-11-25 Thread Daniel Vetter
On Tue, Nov 24, 2020 at 06:45:06PM +, Xiong, Jianxin wrote: > > -Original Message- > > From: Daniel Vetter > > Sent: Tuesday, November 24, 2020 7:17 AM > > To: Jason Gunthorpe > > Cc: Xiong, Jianxin ; Leon Romanovsky > > ; linux-r...@vger.kernel.org; dri- > > de...@lists.freedesktop.

Re: [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed

2020-11-25 Thread Christian König
Am 25.11.20 um 11:36 schrieb Daniel Vetter: On Wed, Nov 25, 2020 at 11:13:13AM +0100, Christian König wrote: Am 25.11.20 um 09:37 schrieb Thomas Zimmermann: Hi Am 24.11.20 um 15:09 schrieb Daniel Vetter: On Tue, Nov 24, 2020 at 02:56:51PM +0100, Thomas Zimmermann wrote: Hi Am 24.11.20 um 14

Re: [PATCH 3/6] drm/scheduler: Job timeout handler returns status

2020-11-25 Thread Steven Price
On 25/11/2020 03:17, Luben Tuikov wrote: The job timeout handler now returns status indicating back to the DRM layer whether the job was successfully cancelled or whether more time should be given to the job to complete. I'm not sure I understand in what circumstances you would want to give th

Re: [PATCH 6/6] drm/sched: Make use of a "done" thread

2020-11-25 Thread Steven Price
On 25/11/2020 03:17, Luben Tuikov wrote: Add a "done" list to which all completed jobs are added to be freed. The drm_sched_job_done() callback is the producer of jobs to this list. Add a "done" thread which consumes from the done list and frees up jobs. Now, the main scheduler thread only pushe

Re: [PATCH 3/6] drm/scheduler: Job timeout handler returns status

2020-11-25 Thread Lucas Stach
Am Mittwoch, den 25.11.2020, 11:04 + schrieb Steven Price: > On 25/11/2020 03:17, Luben Tuikov wrote: > > The job timeout handler now returns status > > indicating back to the DRM layer whether the job > > was successfully cancelled or whether more time > > should be given to the job to complet

Re: [PATCH 3/6] drm/scheduler: Job timeout handler returns status

2020-11-25 Thread Steven Price
On 25/11/2020 11:15, Lucas Stach wrote: Am Mittwoch, den 25.11.2020, 11:04 + schrieb Steven Price: On 25/11/2020 03:17, Luben Tuikov wrote: The job timeout handler now returns status indicating back to the DRM layer whether the job was successfully cancelled or whether more time should be g

Re: [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed

2020-11-25 Thread Thomas Zimmermann
Hi Am 25.11.20 um 11:36 schrieb Daniel Vetter: On Wed, Nov 25, 2020 at 11:13:13AM +0100, Christian König wrote: Am 25.11.20 um 09:37 schrieb Thomas Zimmermann: Hi Am 24.11.20 um 15:09 schrieb Daniel Vetter: On Tue, Nov 24, 2020 at 02:56:51PM +0100, Thomas Zimmermann wrote: Hi Am 24.11.20 u

Re: [PATCH 3/6] drm/scheduler: Job timeout handler returns status

2020-11-25 Thread Lucas Stach
Am Mittwoch, den 25.11.2020, 11:22 + schrieb Steven Price: > On 25/11/2020 11:15, Lucas Stach wrote: > > Am Mittwoch, den 25.11.2020, 11:04 + schrieb Steven Price: > > > On 25/11/2020 03:17, Luben Tuikov wrote: > > > > The job timeout handler now returns status > > > > indicating back to th

RE: [PATCH] video: hyperv_fb: Directly use the MMIO VRAM

2020-11-25 Thread Dexuan Cui
Hi Wei Liu, Please do not pick up this patch, because actually MMIO VRAM can not work with fb_deferred_io. Previously I didn't test Xorg -- sorry. As soon as I tested it, I got the below warning and the Xorg program ternimated immediately: [ 28.148432] WARNING: CPU: 19 PID: 1410 at mm/vmalloc.c

Re: [PATCH 3/6] drm/scheduler: Job timeout handler returns status

2020-11-25 Thread Christian König
Am 25.11.20 um 12:04 schrieb Steven Price: On 25/11/2020 03:17, Luben Tuikov wrote: The job timeout handler now returns status indicating back to the DRM layer whether the job was successfully cancelled or whether more time should be given to the job to complete. I'm not sure I understand in w

Re: [PATCH v4 55/80] drm/panel: panel-dsi-cm: use MIPI_DCS_GET_ERROR_COUNT_ON_DSI

2020-11-25 Thread Tomi Valkeinen
On 24/11/2020 18:38, Sam Ravnborg wrote: >>> IMO you should get all the patches at least up including this patch applied. >>> They are all reviewed/acked. And then you have a much smaller stack of >>> patches to spam us with. >> >> Yes, I think that makes sense. I did not want to merge them earlie

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-11-25 Thread Christian König
Am 25.11.20 um 11:40 schrieb Daniel Vetter: On Tue, Nov 24, 2020 at 05:44:07PM +0100, Christian König wrote: Am 24.11.20 um 17:22 schrieb Andrey Grodzovsky: On 11/24/20 2:41 AM, Christian König wrote: Am 23.11.20 um 22:08 schrieb Andrey Grodzovsky: On 11/23/20 3:41 PM, Christian König wrote:

[PATCH 1/7] drm/radeon: stop using pages with drm_prime_sg_to_page_addr_arrays v2

2020-11-25 Thread Christian König
This is deprecated. v2: also use ttm_sg_tt_init to avoid allocating the page array. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_ttm.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeo

[PATCH 5/7] drm/qxl: switch to ttm_sg_tt_init

2020-11-25 Thread Christian König
The function qxl_gem_prime_import_sg_table is not fully implemented. Signed-off-by: Christian König --- drivers/gpu/drm/qxl/qxl_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c index 128c38c8a837..d42e750cbdd3

[PATCH 4/7] drm/vmwgfx: switch to ttm_sg_tt_init

2020-11-25 Thread Christian König
According to Daniel VMWGFX doesn't support DMA-buf anyway. Signed-off-by: Christian König --- drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.

[PATCH 3/7] drm/nouveau: stop using pages with drm_prime_sg_to_page_addr_arrays v2

2020-11-25 Thread Christian König
This is deprecated, also drop the comment about faults. v2: also use ttm_sg_tt_init to avoid allocating the page array. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c| 6 +++--- drivers/gpu/drm/nouveau/nouveau_sgdma.c | 2 +- 2 files changed, 4 insertions(+), 4 dele

[PATCH 2/7] drm/amdgpu: stop using pages with drm_prime_sg_to_page_addr_arrays

2020-11-25 Thread Christian König
This is deprecated. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index c438d290a6db..02748e030322 100644 ---

[PATCH 6/7] drm/ttm: nuke ttm_dma_tt_init

2020-11-25 Thread Christian König
Not used any more. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_tt.c | 13 - include/drm/ttm/ttm_tt.h | 2 -- 2 files changed, 15 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c index da9eeffe0c6d..77ba784425dd 100644 --- a/dr

[PATCH 7/7] drm/prime: split array import functions v4

2020-11-25 Thread Christian König
Mapping the imported pages of a DMA-buf into an userspace process doesn't work as expected. But we have reoccurring requests on this approach, so split the functions for this and document that dma_buf_mmap() needs to be used instead. v2: split it into two functions v3: rebased on latest changes

Re: [PATCHv10 0/9] System Cache support for GPU and required SMMU support

2020-11-25 Thread Will Deacon
On Wed, 25 Nov 2020 12:30:09 +0530, Sai Prakash Ranjan wrote: > Some hardware variants contain a system cache or the last level > cache(llc). This cache is typically a large block which is shared > by multiple clients on the SOC. GPU uses the system cache to cache > both the GPU data buffers(like t

Re: [PATCHv10 0/9] System Cache support for GPU and required SMMU support

2020-11-25 Thread Will Deacon
On Wed, 25 Nov 2020 12:30:09 +0530, Sai Prakash Ranjan wrote: > Some hardware variants contain a system cache or the last level > cache(llc). This cache is typically a large block which is shared > by multiple clients on the SOC. GPU uses the system cache to cache > both the GPU data buffers(like t

Re: [PATCH 01/15] drm/amdgpu: Remove references to struct drm_device.pdev

2020-11-25 Thread Alex Deucher
On Tue, Nov 24, 2020 at 6:38 AM Thomas Zimmermann wrote: > > Using struct drm_device.pdev is deprecated. Convert amdgpu to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Alex Deucher > Cc: Christian König There are a few unrelated whitespace changes.

Re: [PATCH 11/15] drm/radeon: Remove references to struct drm_device.pdev

2020-11-25 Thread Alex Deucher
On Tue, Nov 24, 2020 at 6:39 AM Thomas Zimmermann wrote: > > Using struct drm_device.pdev is deprecated. Convert radeon to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Alex Deucher > Cc: Christian König There are a few unrelated whitespace changes.

[PATCH][next] drm/amdgpu: Fix sizeof() mismatch in bps_bo kmalloc_array creation

2020-11-25 Thread Colin King
From: Colin Ian King An incorrect sizeof() is being used, sizeof((*data)->bps_bo) is not correct, it should be sizeof(*(*data)->bps_bo). It just so happens to work because the sizes are the same. Fix it. Addresses-Coverity: ("Sizeof not portable (SIZEOF_MISMATCH)") Fixes: 5278a159cf35 ("drm/am

Re: [PATCH][next] drm/amdgpu: Fix sizeof() mismatch in bps_bo kmalloc_array creation

2020-11-25 Thread Christian König
Am 25.11.20 um 15:18 schrieb Colin King: From: Colin Ian King An incorrect sizeof() is being used, sizeof((*data)->bps_bo) is not correct, it should be sizeof(*(*data)->bps_bo). It just so happens to work because the sizes are the same. Fix it. Addresses-Coverity: ("Sizeof not portable (SIZE

[PATCH] drm/radeon: fix check order in radeon_bo_move

2020-11-25 Thread Christian König
Reorder the code to fix checking if blitting is available. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_ttm.c | 54 + 1 file changed, 24 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/rade

RE: [PATCH][next] drm/amdgpu: Fix sizeof() mismatch in bps_bo kmalloc_array creation

2020-11-25 Thread Chen, Guchun
[AMD Public Use] Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: Colin King Sent: Wednesday, November 25, 2020 10:18 PM To: Deucher, Alexander ; Koenig, Christian ; David Airlie ; Daniel Vetter ; Zhou1, Tao ; Chen, Guchun ; amd-...@lists.freedesktop.org; dri-deve

[pull] amdgpu drm-fixes-5.10

2020-11-25 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.10. The following changes since commit 6600f9d52213b5c3455481b5c9e61cf5e305c0e6: Merge tag 'drm-intel-fixes-2020-11-19' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes (2020-11-20 11:21:54 +1000) are available in the Git repository at: git://peo

Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-25 Thread Jakub Kicinski
On Wed, 25 Nov 2020 04:24:27 -0800 Nick Desaulniers wrote: > I even agree that most of the churn comes from > > case 0: > ++x; > default: > break; And just to spell it out, case ENUM_VALUE1: bla(); break; case ENUM_VALUE2: bla(); default: break; is a fairly i

[PATCH v4 1/3] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-11-25 Thread Daniel Vetter
fs_reclaim_acquire/release nicely catch recursion issues when allocating GFP_KERNEL memory against shrinkers (which gpu drivers tend to use to keep the excessive caches in check). For mmu notifier recursions we do have lockdep annotations since 23b68395c7c7 ("mm/mmu_notifiers: add a lockdep map for

[PATCH v4 2/3] mm: Extract might_alloc() debug check

2020-11-25 Thread Daniel Vetter
Extracted from slab.h, which seems to have the most complete version including the correct might_sleep() check. Roll it out to slob.c. Motivated by a discussion with Paul about possibly changing call_rcu behaviour to allocate memory, but only roughly every 500th call. There are a lot fewer places

[PATCH v4 0/3] mmu_notifier vs fs_reclaim lockdep annotations

2020-11-25 Thread Daniel Vetter
Hi all, Just resending with the polish applied, no functional changes at all. Previous versions. v3: https://lore.kernel.org/dri-devel/20201120095445.1195585-1-daniel.vet...@ffwll.ch/ v2: https://lore.kernel.org/dri-devel/20200610194101.1668038-1-daniel.vet...@ffwll.ch/ Changes since v3: - mo

[PATCH] drm/ttm: don't set page->mapping

2020-11-25 Thread Daniel Vetter
Random observation while trying to review Christian's patch series to stop looking at struct page for dma-buf imports. This was originally added in commit 58aa6622d32af7d2c08d45085f44c54554a16ed7 Author: Thomas Hellstrom Date: Fri Jan 3 11:47:23 2014 +0100 drm/ttm: Correctly set page mapp

[PATCH v4 3/3] locking/selftests: Add testcases for fs_reclaim

2020-11-25 Thread Daniel Vetter
Since I butchered this I figured better to make sure we have testcases for this now. Since we only have a locking context for __GFP_FS that's the only thing we're testing right now. Acked-by: Peter Zijlstra (Intel) Cc: linux-fsde...@vger.kernel.org Cc: Dave Chinner Cc: Qian Cai Cc: linux-...@vg

Re: [PATCH] drm/ttm: don't set page->mapping

2020-11-25 Thread Daniel Vetter
On Wed, Nov 25, 2020 at 5:25 PM Daniel Vetter wrote: > > Random observation while trying to review Christian's patch series to > stop looking at struct page for dma-buf imports. > > This was originally added in > > commit 58aa6622d32af7d2c08d45085f44c54554a16ed7 > Author: Thomas Hellstrom > Date:

Re: [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed

2020-11-25 Thread Daniel Vetter
On Wed, Nov 25, 2020 at 12:38:01PM +0100, Thomas Zimmermann wrote: > Hi > > Am 25.11.20 um 11:36 schrieb Daniel Vetter: > > On Wed, Nov 25, 2020 at 11:13:13AM +0100, Christian König wrote: > > > Am 25.11.20 um 09:37 schrieb Thomas Zimmermann: > > > > Hi > > > > > > > > Am 24.11.20 um 15:09 schrie

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-11-25 Thread Daniel Vetter
On Wed, Nov 25, 2020 at 01:57:40PM +0100, Christian König wrote: > Am 25.11.20 um 11:40 schrieb Daniel Vetter: > > On Tue, Nov 24, 2020 at 05:44:07PM +0100, Christian König wrote: > > > Am 24.11.20 um 17:22 schrieb Andrey Grodzovsky: > > > > On 11/24/20 2:41 AM, Christian König wrote: > > > > > Am

Re: [PATCH 2/6] gpu/drm: ring_mirror_list --> pending_list

2020-11-25 Thread Luben Tuikov
On 2020-11-25 04:47, Christian König wrote: > Am 25.11.20 um 04:17 schrieb Luben Tuikov: >> Rename "ring_mirror_list" to "pending_list", >> to describe what something is, not what it does, >> how it's used, or how the hardware implements it. >> >> This also abstracts the actual hardware >> implemen

[pull] amdgpu, radeon drm-next-5.11

2020-11-25 Thread Alex Deucher
Hi Dave, Daniel, More updates for 5.11. The following changes since commit 178631700f9dc40df754acbe766b55753ddcbfec: drm/amd/pm: fix spelling mistakes in dev_warn messages (2020-11-17 14:07:26 -0500) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux tags/am

  1   2   >