Re: [PATCH 10/10] drm/fb-helper: Acquire modeset lock around shadow-buffer flushing

2020-11-17 Thread Christian König
Am 16.11.20 um 21:48 schrieb Daniel Vetter: On Mon, Nov 16, 2020 at 09:04:37PM +0100, Thomas Zimmermann wrote: Flushing the fbdev's shadow buffer requires vmap'ing the BO memory, which in turn requires pinning the BO. While being pinned, the BO cannot be moved into VRAM for scanout. Consequently

Re: [PATCH 29/42] drm/selftests/test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap

2020-11-17 Thread Lee Jones
On Mon, 16 Nov 2020, Lyude Paul wrote: > Huh-could have sworn I had reviewed this one already. > > Reviewed-by: Lyude Paul Yes, you're right. It was masked by the discussion with Ville. Apologies. > On Mon, 2020-11-16 at 17:40 +, Lee Jones wrote:V > > The stack is too full. > > > > Fixe

Re: [PATCH 32/42] drm/ttm/ttm_tt: Demote kernel-doc header format abuses

2020-11-17 Thread Lee Jones
On Mon, 16 Nov 2020, Christian König wrote: > Am 16.11.20 um 18:41 schrieb Lee Jones: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/ttm/ttm_tt.c:45: warning: Function parameter or member > > 'bo' not described in 'ttm_tt_create' > > drivers/gpu/drm/ttm/ttm_tt.c

Re: [PATCH 01/43] drm/radeon/atombios_encoders: Move 'radeon_atom_get_tv_timings()'s prototype into shared location

2020-11-17 Thread Lee Jones
On Mon, 16 Nov 2020, Alex Deucher wrote: > On Mon, Nov 16, 2020 at 12:30 PM Lee Jones wrote: > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/radeon/radeon_atombios.c:1791:6: warning: no previous > > prototype for ‘radeon_atom_get_tv_timings’ [-Wmissing-prototype

Re: [PATCH 0/4] drm/meson: Module removal fixes

2020-11-17 Thread Neil Armstrong
Hi Marc, On 16/11/2020 21:07, Marc Zyngier wrote: > Hi all, > > Having recently moved over to a top-of-the-tree u-boot on one of my > VIM3L systems in order to benefit from unrelated improvements > (automatic PCIe detection, EFI...), I faced the issue that my kernel > would hang like this: > > [

BUG: unable to handle kernel NULL pointer dereference in fbcon_cursor

2020-11-17 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:6dd65e60 Add linux-next specific files for 20201110 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1276af6250 kernel config: https://syzkaller.appspot.com/x/.config?x=4fab43daf5c54712 dashboard

[PATCH] drm/i915/selftests: Fix wrong return value of perf_request_latency()

2020-11-17 Thread Zhang Xiaoxu
If intel context create failed, the perf_request_latency() will return 0 rather than error, because we doesn't initialize the return value. Fixes: 25c26f18ea79 ("drm/i915/selftests: Measure dispatch latency") Reported-by: Hulk Robot Signed-off-by: Zhang Xiaoxu --- drivers/gpu/drm/i915/selftests

Re: [RESEND PATCH v2 4/5] drm/msm: add DRM_MSM_GEM_SYNC_CACHE for non-coherent cache maintenance

2020-11-17 Thread Jonathan Marek
On 11/16/20 12:50 PM, Rob Clark wrote: On Mon, Nov 16, 2020 at 9:33 AM Christoph Hellwig wrote: On Sat, Nov 14, 2020 at 03:07:20PM -0500, Jonathan Marek wrote: qcom's vulkan driver has nonCoherentAtomSize=1, and it looks like dma_sync_single_for_cpu() does deal in some way with the partial ca

Re: [PATCH] drm/mediatek: dsi: Calculate horizontal_backporch_byte by itself

2020-11-17 Thread Bilal Wasim
Hi CK, On Mon, 16 Nov 2020 07:12:55 +0800 Chun-Kuang Hu wrote: > Hi, Bilal: > > Bilal Wasim 於 2020年11月16日 週一 > 上午3:25寫道: > > > > Hi CK, > > > > On Sun, 15 Nov 2020 08:53:24 +0800 > > Chun-Kuang Hu wrote: > > > > > Hi, Bilal: > > > > > > Please help to test this patch on your Chromebook elm

[PATCH] drm/omap: dmm_tiler: fix return error code in omap_dmm_probe()

2020-11-17 Thread Yang Yingliang
Return -ENOMEM when allocating refill memory failed. Fixes: 71e8831f6407 ("drm/omap: DMM/TILER support for OMAP4+ platform") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/oma

Re: [PATCH 1/4] drm/meson: Free RDMA resources after tearing down DRM

2020-11-17 Thread Neil Armstrong
On 16/11/2020 21:07, Marc Zyngier wrote: > Removing the meson DRM module results in the following splat: > > [ 2179.451346] Hardware name: , BIOS 2021.01-rc2-00012-gde865f7ee1 11/16/2020 > [ 2179.458316] Workqueue: events drm_mode_rmfb_work_fn [drm] > [ 2179.463597] pstate: 80c9 (Nzcv daif +P

[PATCH v4] dt-bindings: display: panel: one file of all simple LVDS panels with dual ports

2020-11-17 Thread Liu Ying
To complement panel-simple.yaml, create panel-simple-lvds-dual-ports.yaml. panel-simple-lvds-dual-ports.yaml is for all simple LVDS panels that have dual LVDS ports and require only a single power-supply. The first port receives odd pixels, and the second port receives even pixels. Optionally, a ba

[PATCH] drm/i915/selftests: Fix wrong return value of perf_series_engines()

2020-11-17 Thread Zhang Xiaoxu
If intel context create failed, the perf_series_engines() will return 0 rather than error, because we doesn't initialize the return value. Fixes: cbfd3a0c5a55 ("drm/i915/selftests: Add request throughput measurement to perf") Reported-by: Hulk Robot Signed-off-by: Zhang Xiaoxu --- drivers/gpu/

Re: [RESEND PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder

2020-11-17 Thread Chunfeng Yun
Hi CK, On Tue, 2020-11-17 at 07:14 +0800, Chun-Kuang Hu wrote: > mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's > more suitable to place a phy driver into phy driver folder, so move > mtk_mipi_dsi_phy driver into phy driver folder. > > Signed-off-by: Chun-Kuang Hu You f

Re: [PATCH] drm/msm/dp: fix connect/disconnect handled at ir_hdp

2020-11-17 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-11-13 14:26:39) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index 27e7e27b8b90..4e84f500b721 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -279,13 +279,25 @@ static voi

Re: [PATCH 2/2] drm/ingenic: depend on COMMON_CLK to fix compile tests

2020-11-17 Thread Paul Cercueil
Hi Krzysztof, Le lun. 16 nov. 2020 à 18:53, Krzysztof Kozlowski a écrit : The Ingenic DRM uses Common Clock Framework thus it cannot be built on platforms without it (e.g. compile test on MIPS with RALINK and SOC_RT305X): /usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/ingenic/ingenic-drm-dr

Re: [PATCH v3] dt-bindings: display: panel: one file of all simple LVDS panels with dual ports

2020-11-17 Thread Liu Ying
On Mon, 2020-11-16 at 13:23 -0600, Rob Herring wrote: > On Thu, Nov 12, 2020 at 02:17:11PM +0800, Liu Ying wrote: > > To complement panel-simple.yaml, create panel-simple-lvds-dual- > > ports.yaml. > > panel-simple-lvds-dual-ports.yaml is for all simple LVDS panels > > that > > have dual LVDS ports

[PATCH] drm/msm/dpu: Fix error return code in dpu_mdss_init()

2020-11-17 Thread Chen Zhou
Fix to return a negative error code from the error handling case instead of 0 in function dpu_mdss_init(), as done elsewhere in this function. Fixes: 070e64dc1bbc ("drm/msm/dpu: Convert to a chained irq chip") Reported-by: Hulk Robot Signed-off-by: Chen Zhou --- drivers/gpu/drm/msm/disp/dpu1/dp

Re: [PATCH] drm/i915/selftests: Fix wrong return value of perf_series_engines()

2020-11-17 Thread Mika Kuoppala
Zhang Xiaoxu writes: > If intel context create failed, the perf_series_engines() will return 0 > rather than error, because we doesn't initialize the return value. > > Fixes: cbfd3a0c5a55 ("drm/i915/selftests: Add request throughput measurement > to perf") > Reported-by: Hulk Robot > Signed-off

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-17 Thread H. Nikolaus Schaller
Hi Tomi, I hope you had a good weekend. And I have added back the CC: list because I think we have progress after our internal discussion and only one issue remaining. > Am 13.11.2020 um 15:49 schrieb Tomi Valkeinen : > > On 13/11/2020 16:41, H. Nikolaus Schaller wrote: >> Hi Tomi, >> >>> Am 1

Re: [PATCH] drm/i915/selftests: Fix wrong return value of perf_request_latency()

2020-11-17 Thread Mika Kuoppala
Zhang Xiaoxu writes: > If intel context create failed, the perf_request_latency() will return 0 > rather than error, because we doesn't initialize the return value. > > Fixes: 25c26f18ea79 ("drm/i915/selftests: Measure dispatch latency") > Reported-by: Hulk Robot > Signed-off-by: Zhang Xiaoxu

Re: [PATCH RFC v6 4/6] drm/sprd: add Unisoc's drm display controller driver

2020-11-17 Thread Kevin Tang
Hi Sam, Here is feedback of RFC V7 Sam Ravnborg 于2020年7月29日周三 上午5:14写道: > > Hi Kevin. > > Some feedback in the following. > I lost track of thing for the atomic modesettting stuff and I hope other > will review that. > > Sam > > On Tue, Jul 28, 2020 at 06:07:57PM +0800, Kevin Tang wrote:

[PATCH] drm/msm: Fix error return code in msm_drm_init()

2020-11-17 Thread Wei Li
When it fail to create crtc_event kthread, it just jump to err_msm_uninit, while the 'ret' is not updated. So assign the return code before that. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Reported-by: Hulk Robot Signed-off-by: Wei Li --- drivers/gpu/drm/msm/msm_drv.c | 1 + 1 file

Re: [RESEND v7, PATCH 4/7] mtk-mmsys: add mt8183 mmsys support

2020-11-17 Thread Hsin-Yi Wang
On Sat, Aug 8, 2020 at 2:53 AM Yongqiang Niu wrote: > > add mt8183 mmsys support > > Signed-off-by: Yongqiang Niu > --- > drivers/soc/mediatek/mmsys/Makefile | 1 + > drivers/soc/mediatek/mmsys/mt8183-mmsys.c | 154 > ++ > drivers/soc/mediatek/mtk-mmsys.c

Re: [PATCH 2/4] drm/meson: Unbind all connectors on module removal

2020-11-17 Thread Neil Armstrong
On 16/11/2020 21:07, Marc Zyngier wrote: > Removing the meson DRM module results in the following splats: > > [ 42.689228] WARNING: CPU: 0 PID: 572 at drivers/gpu/drm/drm_irq.c:192 > drm_irq_uninstall+0x130/0x160 [drm] > [...] > [ 42.812820] Hardware name: , BIOS 2021.01-rc2-00012-gde865f7ee

Re: [PATCH 3/4] drm/meson: dw-hdmi: Register a callback to disable the regulator

2020-11-17 Thread Neil Armstrong
On 16/11/2020 21:07, Marc Zyngier wrote: > Removing the meson-dw-hdmi module results in the following splat: > > i[ 43.340509] WARNING: CPU: 0 PID: 572 at drivers/regulator/core.c:2125 > _regulator_put.part.0+0x16c/0x174 > [...] > [ 43.454870] CPU: 0 PID: 572 Comm: modprobe Tainted: G

Re: [PATCH 4/4] drm/meson: dw-hdmi: Ensure that clocks are enabled before touching the TOP registers

2020-11-17 Thread Neil Armstrong
On 16/11/2020 21:07, Marc Zyngier wrote: > Removing the meson-dw-hdmi module and re-inserting it results in a hang > as the driver writes to HDMITX_TOP_SW_RESET. Similar effects can be seen > when booting with mainline u-boot and using the u-boot provided DT (which > is highly desirable). > > The

Re: [PATCH 0/4] drm/meson: Module removal fixes

2020-11-17 Thread Marc Zyngier
Hi Neil, On 2020-11-17 08:49, Neil Armstrong wrote: Hi Marc, On 16/11/2020 21:07, Marc Zyngier wrote: Hi all, Having recently moved over to a top-of-the-tree u-boot on one of my VIM3L systems in order to benefit from unrelated improvements (automatic PCIe detection, EFI...), I faced the issue

Re: [PATCH] dt-bindings: display: Use OF graph schema

2020-11-17 Thread Laurent Pinchart
Hi Rob, Thank you for the patch. On Mon, Nov 16, 2020 at 07:37:03PM -0600, Rob Herring wrote: > Now that we have a graph schema, rework the display related schemas to use > it. Mostly this is adding a reference to graph.yaml and dropping duplicate > parts from schemas. > > Cc: Thierry Reding >

Re: [PATCH 0/4] drm/meson: Module removal fixes

2020-11-17 Thread Neil Armstrong
On 17/11/2020 10:19, Marc Zyngier wrote: > Hi Neil, > > On 2020-11-17 08:49, Neil Armstrong wrote: >> Hi Marc, >> >> On 16/11/2020 21:07, Marc Zyngier wrote: >>> Hi all, >>> >>> Having recently moved over to a top-of-the-tree u-boot on one of my >>> VIM3L systems in order to benefit from unrelated

Re: [PATCH] drm/qxl: Remove fbcon acceleration leftovers

2020-11-17 Thread Daniel Vetter
On Thu, Oct 29, 2020 at 02:33:47PM +0100, Daniel Vetter wrote: > These are leftovers from 13aff184ed9f ("drm/qxl: remove dead qxl fbdev > emulation code"). > > v2: Somehow these structs provided the struct qxl_device pre-decl, > reorder the header to not anger compilers. > > Acked-by: Gerd Hoffma

Re: [PATCH v3 30/56] drm/omap: dsi: move panel refresh function to host

2020-11-17 Thread Sebastian Reichel
Hi, On Mon, Nov 16, 2020 at 11:22:53AM +0200, Laurent Pinchart wrote: > On Thu, Nov 12, 2020 at 10:08:21AM +0200, Tomi Valkeinen wrote: > > On 11/11/2020 17:58, Laurent Pinchart wrote: > > > > diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > > b/drivers/gpu/drm/omapdrm/di

Re: [PATCH 02/30] include: drm: drm_atomic: Artificially use 'crtc' to avoid 'not used' warning

2020-11-17 Thread Daniel Vetter
On Fri, Nov 13, 2020 at 10:01:57PM +, Lee Jones wrote: > On Fri, 13 Nov 2020, 21:31 Daniel Vetter, wrote: > > > On Fri, Nov 13, 2020 at 9:53 PM Lee Jones wrote: > > > > > > > > > > > > On Fri, 13 Nov 2020, 20:50 Daniel Vetter, wrote: > > >> > > >> On Thu, Nov 12, 2020 at 09:25:16PM +0100, S

Re: [PATCH 02/30] include: drm: drm_atomic: Artificially use 'crtc' to avoid 'not used' warning

2020-11-17 Thread Lee Jones
Daniel, For some reason, you're not appearing in the recipents list when I reply to all. You're not in the Mail-Followup-To header. Any idea why this might be? Anyway, please see below: On Tue, 17 Nov 2020, Daniel Vetter wrote: > On Fri, Nov 13, 2020 at 10:01:57PM +, Lee Jones wrote: > > O

Re: [PATCH 02/30] include: drm: drm_atomic: Artificially use 'crtc' to avoid 'not used' warning

2020-11-17 Thread Daniel Vetter
On Tue, Nov 17, 2020 at 10:34:04AM +, Lee Jones wrote: > Daniel, > > For some reason, you're not appearing in the recipents list when I > reply to all. You're not in the Mail-Followup-To header. Any idea > why this might be? No idea either, could be my mutt not setting the reply headers lik

Re: [PATCH] drm/imx: depend on COMMON_CLK to fix compile tests

2020-11-17 Thread Philipp Zabel
On Mon, 2020-11-16 at 19:14 +0100, Krzysztof Kozlowski wrote: > The iMX DRM drivers use Common Clock Framework thus they cannot be built > on platforms without it (e.g. compile test on MIPS with RALINK and > SOC_RT305X): > > /usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/imx/imx-ldb.o: in functio

Re: [PATCH 02/30] include: drm: drm_atomic: Artificially use 'crtc' to avoid 'not used' warning

2020-11-17 Thread Lee Jones
On Tue, 17 Nov 2020, Daniel Vetter wrote: > On Tue, Nov 17, 2020 at 10:34:04AM +, Lee Jones wrote: > > Daniel, > > > > For some reason, you're not appearing in the recipents list when I > > reply to all. You're not in the Mail-Followup-To header. Any idea > > why this might be? > > No idea

Re: [PATCH] drm/imx: depend on COMMON_CLK to fix compile tests

2020-11-17 Thread Krzysztof Kozlowski
On Tue, 17 Nov 2020 at 11:56, Philipp Zabel wrote: > > On Mon, 2020-11-16 at 19:14 +0100, Krzysztof Kozlowski wrote: > > The iMX DRM drivers use Common Clock Framework thus they cannot be built > > on platforms without it (e.g. compile test on MIPS with RALINK and > > SOC_RT305X): > > > > /usr

Re: [PATCH 41/42] gpu/ipu-v3/ipu-di: Strip out 2 unused 'di_sync_config' entries

2020-11-17 Thread Philipp Zabel
Hi Lee, On Mon, 2020-11-16 at 17:41 +, Lee Jones wrote: > They're taking up too much space on the stack. > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/ipu-v3/ipu-di.c: In function ‘ipu_di_sync_config_noninterlaced’: > drivers/gpu/ipu-v3/ipu-di.c:391:1: warning: the f

[PATCH][next] drm/amd/pm: fix spelling mistakes in dev_warn messages

2020-11-17 Thread Colin King
From: Colin Ian King There are two spelling mistakes in dev_warn messages. Fix these. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/d

Re: [PATCH] dt-bindings: display: Use OF graph schema

2020-11-17 Thread Rob Herring
On Tue, Nov 17, 2020 at 3:43 AM Laurent Pinchart wrote: > > Hi Rob, > > Thank you for the patch. > > On Mon, Nov 16, 2020 at 07:37:03PM -0600, Rob Herring wrote: > > Now that we have a graph schema, rework the display related schemas to use > > it. Mostly this is adding a reference to graph.yaml a

[PATCH v3 1/2] drm/shmem-helper: Use cached mappings by default

2020-11-17 Thread Thomas Zimmermann
SHMEM-buffer backing storage is allocated from system memory; which is typically cachable. The default mode for SHMEM objects is writecombine though. Unify SHMEM semantics by defaulting to cached mappings. The exception is pages imported via dma-buf. DMA memory is usually not cached. DRM drivers

[PATCH v3 0/2] Default to cachable mappings for GEM SHMEM

2020-11-17 Thread Thomas Zimmermann
By default, SHMEM GEM helpers map pages using writecombine. Only a few drivers require this setting. Others revert it to default mappings flags. Some could benefit from caching, but don't care. Unify the behaviour by switching the SHMEM GEM code to use cached mappings (i.e., PAGE_KERNEL actually);

[PATCH v3 2/2] drm/shmem-helper: Removed drm_gem_shmem_create_object_cached()

2020-11-17 Thread Thomas Zimmermann
Cached page mappings are now the default for SHMEM GEM objects. Remove the obsolete create function for cached mappings. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_shmem_helper.c | 26 -- drivers/gpu/drm/mgag200/mgag200_drv.c | 1 - drivers/gpu/drm/udl

Re: [PATCH] drm/omap: dmm_tiler: fix return error code in omap_dmm_probe()

2020-11-17 Thread Thomas Zimmermann
Hi Am 17.11.20 um 07:10 schrieb Yang Yingliang: > Return -ENOMEM when allocating refill memory failed. > > Fixes: 71e8831f6407 ("drm/omap: DMM/TILER support for OMAP4+ platform") > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang > --- > drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 1 + >

Re: [RESEND PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder

2020-11-17 Thread Chun-Kuang Hu
Hi, Vinod: Chunfeng Yun 於 2020年11月17日 週二 上午11:36寫道: > > Hi CK, > On Tue, 2020-11-17 at 07:14 +0800, Chun-Kuang Hu wrote: > > mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's > > more suitable to place a phy driver into phy driver folder, so move > > mtk_mipi_dsi_phy drive

Re: [RESEND PATCH 3/3] MAINTAINERS: add files for Mediatek DRM drivers

2020-11-17 Thread Chun-Kuang Hu
Hi, Vinod: Chun-Kuang Hu 於 2020年11月17日 週二 上午7:14寫道: > > Mediatek MIPI DSI phy driver is moved from drivers/gpu/drm/mediatek to > drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' > information. > > Signed-off-by: Chun-Kuang Hu If you apply this patch, please add acked-by

[PATCH 2/3] drm/ttm: move memory accounting into vmwgfx

2020-11-17 Thread Christian König
This is just another feature which is only used by VMWGFX, so move it into the driver instead. I've tried to add the accounting sysfs file to the kobject of the drm minor, but I'm not 100% sure if this works as expected. Signed-off-by: Christian König --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gp

[PATCH 1/3] drm/ttm: rework ttm_tt page limit

2020-11-17 Thread Christian König
TTM implements a rather extensive accounting of allocated memory. There are two reasons for this: 1. It tries to block userspace allocating a huge number of very small BOs without accounting for the kmalloced memory. 2. Make sure we don't over allocate and run into an OOM situation during s

[PATCH 3/3] drm/ttm: make up to 90% of system memory available

2020-11-17 Thread Christian König
Increase the ammount of system memory drivers can use to about 90% of the total available. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index a958135

Re: [PATCH] drm/amdgpu: fix check oder in amdgpu_bo_move

2020-11-17 Thread Nirmoy
Tested-by: Nirmoy Das Tested on commit 96fb3cbef165db97c999a02efe2287ba4b8c1ceb (HEAD, drm-misc/drm-misc-next) On 11/16/20 8:14 PM, Christian König wrote: Reorder the code to fix checking if blitting is available. Signed-off-by: Christian König Fixes: f5a89a5cae81 drm/amdgpu/ttm: use multi

Re: [PATCH 08/10] drm/fb-helper: Restore damage area upon errors

2020-11-17 Thread Sebastian Reichel
Hi, On Mon, Nov 16, 2020 at 09:52:16PM +0100, Daniel Vetter wrote: > On Mon, Nov 16, 2020 at 09:04:35PM +0100, Thomas Zimmermann wrote: > > If the damage handling fails, restore the damage area. The next invocation > > of the damage worker will then perform the update. > > > > Signed-off-by: Thom

[PATCH] drm/ttm: fix DMA32 handling in the global page pool

2020-11-17 Thread Christian König
When we have mixed DMA32 and non DMA32 device in one system it could otherwise happen that the DMA32 device gets pages it can't work with. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_pool.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm

[PATCH 4.19 082/101] drm/gma500: Fix out-of-bounds access to struct drm_device.vblank[]

2020-11-17 Thread Greg Kroah-Hartman
From: Thomas Zimmermann commit 06ad8d339524bf94b89859047822c31df6ace239 upstream. The gma500 driver expects 3 pipelines in several it's IRQ functions. Accessing struct drm_device.vblank[], this fails with devices that only have 2 pipelines. An example KASAN report is shown below. [ 62.26768

[PATCH 4.14 54/85] drm/gma500: Fix out-of-bounds access to struct drm_device.vblank[]

2020-11-17 Thread Greg Kroah-Hartman
From: Thomas Zimmermann commit 06ad8d339524bf94b89859047822c31df6ace239 upstream. The gma500 driver expects 3 pipelines in several it's IRQ functions. Accessing struct drm_device.vblank[], this fails with devices that only have 2 pipelines. An example KASAN report is shown below. [ 62.26768

[PATCH 4.9 49/78] drm/gma500: Fix out-of-bounds access to struct drm_device.vblank[]

2020-11-17 Thread Greg Kroah-Hartman
From: Thomas Zimmermann commit 06ad8d339524bf94b89859047822c31df6ace239 upstream. The gma500 driver expects 3 pipelines in several it's IRQ functions. Accessing struct drm_device.vblank[], this fails with devices that only have 2 pipelines. An example KASAN report is shown below. [ 62.26768

[PATCH 5.9 230/255] drm/gma500: Fix out-of-bounds access to struct drm_device.vblank[]

2020-11-17 Thread Greg Kroah-Hartman
From: Thomas Zimmermann commit 06ad8d339524bf94b89859047822c31df6ace239 upstream. The gma500 driver expects 3 pipelines in several it's IRQ functions. Accessing struct drm_device.vblank[], this fails with devices that only have 2 pipelines. An example KASAN report is shown below. [ 62.26768

[PATCH 4.4 38/64] drm/gma500: Fix out-of-bounds access to struct drm_device.vblank[]

2020-11-17 Thread Greg Kroah-Hartman
From: Thomas Zimmermann commit 06ad8d339524bf94b89859047822c31df6ace239 upstream. The gma500 driver expects 3 pipelines in several it's IRQ functions. Accessing struct drm_device.vblank[], this fails with devices that only have 2 pipelines. An example KASAN report is shown below. [ 62.26768

[PATCH 5.4 134/151] drm/gma500: Fix out-of-bounds access to struct drm_device.vblank[]

2020-11-17 Thread Greg Kroah-Hartman
From: Thomas Zimmermann commit 06ad8d339524bf94b89859047822c31df6ace239 upstream. The gma500 driver expects 3 pipelines in several it's IRQ functions. Accessing struct drm_device.vblank[], this fails with devices that only have 2 pipelines. An example KASAN report is shown below. [ 62.26768

Re: [PATCH 01/10] drm/fb-helper: Call dirty helper after writing to fbdev

2020-11-17 Thread Ville Syrjälä
On Mon, Nov 16, 2020 at 09:04:28PM +0100, Thomas Zimmermann wrote: > If fbdev uses a shadow framebuffer, call the damage handler. Otherwise > the update might not make it to the screen. > > Signed-off-by: Thomas Zimmermann > Fixes: 222ec45f4c69 ("drm/fb_helper: Support framebuffers in I/O memory"

[PATCH 3/4] drm/ttm: add a debugfs file for the global page pools

2020-11-17 Thread Christian König
Instead of printing this on the per device pool. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_pool.c | 70 -- 1 file changed, 50 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.c index 24ae7c

[PATCH 1/4] drm/ttm/drivers: remove unecessary ttm_module.h include

2020-11-17 Thread Christian König
ttm_module.h deals with internals of TTM and should never be include outside of it. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 1 - drivers/gpu/drm/nouveau/nouveau_drv.h | 1 - drivers/gpu/drm/qx

[PATCH 4/4] drm/ttm: optimize ttm pool shrinker a bit

2020-11-17 Thread Christian König
Only initialize the DMA coherent pools if they are used. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_pool.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.c index 5daf812551

[PATCH 2/4] drm/ttm: replace sysfs with debugfs

2020-11-17 Thread Christian König
As far as I can tell this has never been used by any userspace application. The number of BOs in the system is far better suited in debugfs than sysfs and we now should be able to add other information here as well. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c

Re: [PATCH 3/3] drm/ttm: make up to 90% of system memory available

2020-11-17 Thread Michel Dänzer
On 2020-11-17 3:06 p.m., Christian König wrote: Increase the ammount of system memory drivers can use to about 90% of the total available. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/t

Re: [PATCH 08/10] drm/fb-helper: Restore damage area upon errors

2020-11-17 Thread Daniel Vetter
On Tue, Nov 17, 2020 at 04:14:46PM +0100, Sebastian Reichel wrote: > Hi, > > On Mon, Nov 16, 2020 at 09:52:16PM +0100, Daniel Vetter wrote: > > On Mon, Nov 16, 2020 at 09:04:35PM +0100, Thomas Zimmermann wrote: > > > If the damage handling fails, restore the damage area. The next invocation > > >

Re: [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-11-17 Thread Rob Clark
On Thu, Nov 5, 2020 at 11:16 PM Viresh Kumar wrote: > > On 05-11-20, 11:24, Rob Clark wrote: > > On Tue, Nov 3, 2020 at 7:04 PM Viresh Kumar wrote: > > > > > > On 03-11-20, 08:50, Rob Clark wrote: > > > > sorry, it didn't apply cleanly (which I guess is due to some other > > > > dependencies that

Re: [PATCH 3/3] drm/ttm: make up to 90% of system memory available

2020-11-17 Thread Daniel Vetter
On Tue, Nov 17, 2020 at 03:06:15PM +0100, Christian König wrote: > Increase the ammount of system memory drivers can use to about 90% of > the total available. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/ttm/ttm_bo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > dif

Re: [PATCH 03/42] drm/drm_dp_mst_topology: Remove set but never used variable 'len'

2020-11-17 Thread Daniel Vetter
On Mon, Nov 16, 2020 at 05:40:33PM +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/drm_dp_mst_topology.c: In function > ‘drm_dp_send_query_stream_enc_status’: > drivers/gpu/drm/drm_dp_mst_topology.c:3263:6: warning: variable ‘len’ set > but not us

Re: [PATCH 1/4] drm/ttm/drivers: remove unecessary ttm_module.h include

2020-11-17 Thread Daniel Vetter
On Tue, Nov 17, 2020 at 05:33:35PM +0100, Christian König wrote: > ttm_module.h deals with internals of TTM and should never > be include outside of it. > > Signed-off-by: Christian König Maybe also move it to drivers/gpu/drm/ttm/ttm_internal.h. We're using the _interal.h suffix in a few other p

[PATCH v1 5/6] dt-bindings: vendor-prefixes: Add ys vendor prefix

2020-11-17 Thread Guido Günther
Add prefix for Shenzhen Yashi Changhua Intelligent Technology Co., Ltd. Signed-off-by: Guido Günther --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree

[PATCH v1 0/6] drm/panel: mantix and st7703 fixes and additions

2020-11-17 Thread Guido Günther
This adds new panel type to the mantix driver as found on the Librem 5 and fixes a glitch in the init sequence (affecting both panels). The fix is at the start of the series to make backporting simpler. It also adds a patch to make st7703 use dev_err_probe(). Guido Günther (6): drm/panel: st7703

[PATCH v1 1/6] drm/panel: st7703: Use dev_err_probe

2020-11-17 Thread Guido Günther
Less code and easier probe deferral debugging. Signed-off-by: Guido Günther --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 24 +++ 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/drm/panel/panel-sitr

[PATCH v1 3/6] drm/panel: mantix: Allow to specify default mode for different panels

2020-11-17 Thread Guido Günther
This can be used to use different modes for differnt panels via OF device match. Signed-off-by: Guido Günther --- .../gpu/drm/panel/panel-mantix-mlaf057we51.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.

[PATCH v1 6/6] dt-binding: display: mantix: Add compatible for panel from YS

2020-11-17 Thread Guido Günther
This panel from Shenzhen Yashi Changhua Intelligent Technology Co uses the same driver IC but a different LCD. Signed-off-by: Guido Günther --- .../devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/

[PATCH v1 2/6] drm/panel: mantix: Tweak init sequence

2020-11-17 Thread Guido Günther
We've seen some (non permanent) burn in and bad white balance on some of the panels. Adding this bit from a vendor supplied sequence fixes it. Fixes: 72967d5616d3 ("drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel") Signed-off-by: Guido Günther --- drivers/gpu/drm/panel/panel-

[PATCH v1 4/6] drm/panel: mantix: Support panel from Shenzhen Yashi Changhua Intelligent Technology Co

2020-11-17 Thread Guido Günther
The panel uses the same driver IC and has the same resolution but a slightly different default mode. It seems it can work with the same init sequence. Signed-off-by: Guido Günther --- drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 16 1 file changed, 16 insertions(+) diff -

[PATCH] drm/mcde: Fix RGB/BGR bug

2020-11-17 Thread Linus Walleij
I was confused when the graphics came out with blue penguins on the DPI panel. It turns out that the so-called "packed RGB666" mode on the DSI formatter is incorrect: this mode is the actual RGB888 mode, and the mode called RGB888 is BGR888. The claims that the MCDE had inverse RGB/BGR buffer for

[PATCH 1/3] drm/panel: s6e63m0: Fix and extend MCS table

2020-11-17 Thread Linus Walleij
Fix up the format of the manufacturer command set table to be TAB-indented and lowercase. Add the MCS_TEMP_SWIRE command that we will make use of. Cc: Stephan Gerhold Cc: Paweł Chmiel Signed-off-by: Linus Walleij --- drivers/gpu/drm/panel/panel-samsung-s6e63m0.c | 17 + 1 file

[PATCH 2/3] drm/panel: s6e63m0: Implement 28 backlight levels

2020-11-17 Thread Linus Walleij
A later version of the s6e63m0 driver in the Samsung GT-I9070 vendor tree provides 28 different backlight levels making use of elaborate control of the ACL and ELVSS regulator. Implement this more fine-grained backlight control. Cc: Stephan Gerhold Cc: Paweł Chmiel Signed-off-by: Linus Walleij

[PATCH 3/3] drm/panel: s6e63m0: Fix init sequence

2020-11-17 Thread Linus Walleij
The init sequence consist of a number of unknown settings for the display controller. This patch achieves two things: - Fix an error that must have happened when the driver was converted from the backlight subsystem: the 0xb8 configuration command was lost and added as a tail to the previous

Re: [PATCH v4] Add power/gpu_frequency tracepoint.

2020-11-17 Thread Rafael J. Wysocki
On 11/16/2020 10:05 PM, Steven Rostedt wrote: On Mon, 16 Nov 2020 12:55:29 -0800 Peiyong Lin wrote: Hi there, May I ask whether the merge window has passed? If so is it possible to ask for a review? This is up to the maintainers of power management to accept this. Rafael? I'd say up to th

Re: [PATCH v4] Add power/gpu_frequency tracepoint.

2020-11-17 Thread Alex Deucher
On Tue, Nov 17, 2020 at 1:00 PM Rafael J. Wysocki wrote: > > On 11/16/2020 10:05 PM, Steven Rostedt wrote: > > On Mon, 16 Nov 2020 12:55:29 -0800 > > Peiyong Lin wrote: > > > >> Hi there, > >> > >> May I ask whether the merge window has passed? If so is it possible to > >> ask for a review? > > T

Re: [PATCH 03/42] drm/drm_dp_mst_topology: Remove set but never used variable 'len'

2020-11-17 Thread Lee Jones
On Tue, 17 Nov 2020, Daniel Vetter wrote: > On Mon, Nov 16, 2020 at 05:40:33PM +, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/drm_dp_mst_topology.c: In function > > ‘drm_dp_send_query_stream_enc_status’: > > drivers/gpu/drm/drm_dp_mst_topol

Re: [PATCH 03/42] drm/drm_dp_mst_topology: Remove set but never used variable 'len'

2020-11-17 Thread Lee Jones
On Tue, 17 Nov 2020, Lee Jones wrote: > On Tue, 17 Nov 2020, Daniel Vetter wrote: > > > On Mon, Nov 16, 2020 at 05:40:33PM +, Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/gpu/drm/drm_dp_mst_topology.c: In function > > > ‘drm_dp_send_query_stre

[PATCH v2] drm/imx: depend on COMMON_CLK to fix compile tests

2020-11-17 Thread Krzysztof Kozlowski
The iMX DRM LVDS driver uses Common Clock Framework thus it cannot be built on platforms without it (e.g. compile test on MIPS with RALINK and SOC_RT305X): /usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/imx/imx-ldb.o: in function `imx_ldb_encoder_disable': imx-ldb.c:(.text+0x400): undefined

Re: [PATCH v2 8/8] drm/amdgpu: Prevent any job recoveries after device is unplugged.

2020-11-17 Thread Andrey Grodzovsky
On 6/22/20 5:53 AM, Daniel Vetter wrote: On Sun, Jun 21, 2020 at 02:03:08AM -0400, Andrey Grodzovsky wrote: No point to try recovery if device is gone, just messes up things. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 16 drivers/gpu/drm

Re: [PATCH][next] drm/amd/pm: fix spelling mistakes in dev_warn messages

2020-11-17 Thread Alex Deucher
On Tue, Nov 17, 2020 at 8:11 AM Colin King wrote: > > From: Colin Ian King > > There are two spelling mistakes in dev_warn messages. Fix these. > > Signed-off-by: Colin Ian King Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 4 ++-- > 1 file changed, 2 inse

Re: [PATCH v2 8/8] drm/amdgpu: Prevent any job recoveries after device is unplugged.

2020-11-17 Thread Daniel Vetter
On Tue, Nov 17, 2020 at 01:38:14PM -0500, Andrey Grodzovsky wrote: > > On 6/22/20 5:53 AM, Daniel Vetter wrote: > > On Sun, Jun 21, 2020 at 02:03:08AM -0400, Andrey Grodzovsky wrote: > > > No point to try recovery if device is gone, just messes up things. > > > > > > Signed-off-by: Andrey Grodzov

Re: [PATCH 21/42] drm/nouveau/nvkm/core/firmware: Fix formatting, provide missing param description

2020-11-17 Thread Daniel Vetter
On Mon, Nov 16, 2020 at 05:40:51PM +, Lee Jones wrote: > ... and demote non-conformant kernel-doc header. > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:71: warning: Function parameter > or member 'subdev' not described in 'nvkm_firmwar

Re: [Freedreno] [PATCH 17/42] drm/msm/disp/mdp5/mdp5_ctl: Demote non-conformant kernel-doc headers

2020-11-17 Thread Rob Clark
On Mon, Nov 16, 2020 at 9:41 AM Lee Jones wrote: > > Very little attempt has been made to document these functions. > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c:227: warning: Function parameter or > member 'ctl' not described in 'mdp5_ctl_set_

Re: [PATCH 31/42] drm/ttm/ttm_bo: Fix one function header - demote lots of kernel-doc abuses

2020-11-17 Thread Daniel Vetter
On Mon, Nov 16, 2020 at 09:33:48PM +0100, Christian König wrote: > Am 16.11.20 um 18:41 schrieb Lee Jones: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/ttm/ttm_bo.c:51: warning: Function parameter or member > > 'ttm_global_mutex' not described in 'DEFINE_MUTEX' >

Re: [PATCH 03/42] drm/drm_dp_mst_topology: Remove set but never used variable 'len'

2020-11-17 Thread Daniel Vetter
On Tue, Nov 17, 2020 at 06:13:40PM +, Lee Jones wrote: > On Tue, 17 Nov 2020, Lee Jones wrote: > > > On Tue, 17 Nov 2020, Daniel Vetter wrote: > > > > > On Mon, Nov 16, 2020 at 05:40:33PM +, Lee Jones wrote: > > > > Fixes the following W=1 kernel build warning(s): > > > > > > > > driver

Re: [PATCH 32/42] drm/ttm/ttm_tt: Demote kernel-doc header format abuses

2020-11-17 Thread Daniel Vetter
On Tue, Nov 17, 2020 at 08:33:46AM +, Lee Jones wrote: > On Mon, 16 Nov 2020, Christian König wrote: > > > Am 16.11.20 um 18:41 schrieb Lee Jones: > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/gpu/drm/ttm/ttm_tt.c:45: warning: Function parameter or member > > >

Re: [PATCH v2 8/8] drm/amdgpu: Prevent any job recoveries after device is unplugged.

2020-11-17 Thread Andrey Grodzovsky
On 11/17/20 1:52 PM, Daniel Vetter wrote: On Tue, Nov 17, 2020 at 01:38:14PM -0500, Andrey Grodzovsky wrote: On 6/22/20 5:53 AM, Daniel Vetter wrote: On Sun, Jun 21, 2020 at 02:03:08AM -0400, Andrey Grodzovsky wrote: No point to try recovery if device is gone, just messes up things. Signed-o

Re: [PATCH] drm/mcde: Fix RGB/BGR bug

2020-11-17 Thread Sam Ravnborg
Hi Linus On Tue, Nov 17, 2020 at 06:54:13PM +0100, Linus Walleij wrote: > I was confused when the graphics came out with blue > penguins on the DPI panel. > > It turns out that the so-called "packed RGB666" mode > on the DSI formatter is incorrect: this mode is the > actual RGB888 mode, and the m

Re: [PATCH 38/42] drm/vc4/vc4_hdmi: Remove set but unused variable 'ret'

2020-11-17 Thread Daniel Vetter
On Mon, Nov 16, 2020 at 05:41:08PM +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/vc4/vc4_hdmi.c: In function ‘vc4_hdmi_set_audio_infoframe’: > drivers/gpu/drm/vc4/vc4_hdmi.c:334:6: warning: variable ‘ret’ set but not > used [-Wunused-but-set-vari

Re: [PATCH 42/42] include/drm/drm_atomic: Make use of 'new_crtc_state'

2020-11-17 Thread Daniel Vetter
On Mon, Nov 16, 2020 at 05:41:12PM +, Lee Jones wrote: > In the macro for_each_oldnew_crtc_in_state() 'crtc_state' is provided > as a container for state->crtcs[i].new_state, but is not utilised in > some use-cases, so we fake-use it instead. > > Fixes the following W=1 kernel build warning(s)

Re: [PATCH v2 8/8] drm/amdgpu: Prevent any job recoveries after device is unplugged.

2020-11-17 Thread Daniel Vetter
On Tue, Nov 17, 2020 at 02:18:49PM -0500, Andrey Grodzovsky wrote: > > On 11/17/20 1:52 PM, Daniel Vetter wrote: > > On Tue, Nov 17, 2020 at 01:38:14PM -0500, Andrey Grodzovsky wrote: > > > On 6/22/20 5:53 AM, Daniel Vetter wrote: > > > > On Sun, Jun 21, 2020 at 02:03:08AM -0400, Andrey Grodzovsky

Re: [PATCH] drm/msm: Fix error return code in msm_drm_init()

2020-11-17 Thread abhinavk
On 2020-11-16 18:36, Wei Li wrote: When it fail to create crtc_event kthread, it just jump to err_msm_uninit, while the 'ret' is not updated. So assign the return code before that. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Reported-by: Hulk Robot Signed-off-by: Wei Li Reviewed-

  1   2   >