Re: [PATCH 1/2] mm: mmap: fix fput in error path v2

2020-11-04 Thread Christian König
If nobody comes up with an objections I'm going to merge that through drm-misc-next. Thanks, Christian. Am 12.10.20 um 10:52 schrieb Christian König: Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..." adds a workaround for a bug in mmap_region. As the comment states ->mmap() callback can

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-04 Thread tiantao (H)
在 2020/11/3 15:56, Thomas Zimmermann 写道: Hi Thanks, the code looks good already. There just are a few nits below. Thanks for the help with the review code. Add the new api devm_drm_irq_install and himbc use the new interface as one patch or two? Am 03.11.20 um 03:10 schrieb Tian Tao: Ad

[patch V3 37/37] io-mapping: Remove io_mapping_map_atomic_wc()

2020-11-04 Thread Thomas Gleixner
No more users. Get rid of it and remove the traces in documentation. Signed-off-by: Thomas Gleixner --- V3: New patch --- Documentation/driver-api/io-mapping.rst | 22 +--- include/linux/io-mapping.h | 42 +--- 2 files changed, 9 insertion

[patch V3 36/37] drm/i915: Replace io_mapping_map_atomic_wc()

2020-11-04 Thread Thomas Gleixner
None of these mapping requires the side effect of disabling pagefaults and preemption. Use io_mapping_map_local_wc() instead, and clean up gtt_user_read() and gtt_user_write() to use a plain copy_from_user() as the local maps are not disabling pagefaults. Signed-off-by: Thomas Gleixner Cc: Jani

[patch V3 00/37] mm/highmem: Preemptible variant of kmap_atomic & friends

2020-11-04 Thread Thomas Gleixner
Following up to the discussion in: https://lore.kernel.org/r/20200914204209.256266...@linutronix.de and the second version of this: https://lore.kernel.org/r/20201029221806.189523...@linutronix.de this series provides a preemptible variant of kmap_atomic & related interfaces. This is achie

Re: [PATCH v4 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-11-04 Thread Andy Shevchenko
On Tue, Nov 03, 2020 at 03:34:00PM +0200, Sakari Ailus wrote: > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM > pixel formats denoted by fourccs. The fourcc encoding is the same for both > so the same implementation can be used. ... > +static noinline_for_stack > +char

[PATCH 0/3] cherry-pick missed patches to msm-next-staging

2020-11-04 Thread Kuogee Hsieh
cherry-pick 3 patches at chromeos-5.4 to msm-next-staging Kuogee Hsieh (2): FROMLIST: drm/msm/dp: return correct connection status after suspend FROMLIST: drm/msm/dp: fixes wrong connection state caused by failure of link train Stephen Boyd (1): FIXUP: FROMLIST: drm/msm/dp: return corr

Re: linux-next: build warning after merge of the drm-misc-fixes tree

2020-11-04 Thread Maxime Ripard
Hi Stephen, On Tue, Nov 03, 2020 at 11:31:21AM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the drm-misc-fixes tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > drivers/gpu/drm/vc4/vc4_drv.c: In function 'vc4_drm_unbind': > drivers/gpu/drm/vc4/vc4

[patch V3 17/37] xtensa/mm/highmem: Switch to generic kmap atomic

2020-11-04 Thread Thomas Gleixner
No reason having the same code in every architecture Signed-off-by: Thomas Gleixner Cc: Chris Zankel Cc: Max Filippov Cc: linux-xte...@linux-xtensa.org --- V3: Remove the kmap types cruft --- arch/xtensa/Kconfig |1 arch/xtensa/include/asm/fixmap.h |4 +-- arch/xtensa/i

[patch V3 21/37] Documentation/io-mapping: Remove outdated blurb

2020-11-04 Thread Thomas Gleixner
The implementation details in the documentation are outdated and not really helpful. Remove them. Signed-off-by: Thomas Gleixner --- V3: New patch --- Documentation/driver-api/io-mapping.rst | 22 -- 1 file changed, 22 deletions(-) --- a/Documentation/driver-api/io-mapping

[patch V3 23/37] sched: Make migrate_disable/enable() independent of RT

2020-11-04 Thread Thomas Gleixner
Now that the scheduler can deal with migrate disable properly, there is no real compelling reason to make it only available for RT. There are quite some code pathes which needlessly disable preemption in order to prevent migration and some constructs like kmap_atomic() enforce it implicitly. Maki

Re: [PATCH] drm/vc4: drv: Remove unused variable

2020-11-04 Thread Maxime Ripard
On Mon, Nov 02, 2020 at 09:45:38PM +0100, Daniel Vetter wrote: > On Mon, Nov 02, 2020 at 05:29:08PM +0100, Maxime Ripard wrote: > > The commit dcda7c28bff2 ("drm/vc4: kms: Add functions to create the state > > objects") removed the last users of the vc4 variable, but didn't remove > > that variable

Re: [PATCH v2 0/8] slab: provide and use krealloc_array()

2020-11-04 Thread Bartosz Golaszewski
On Tue, Nov 3, 2020 at 5:14 AM Joe Perches wrote: > > On Mon, 2020-11-02 at 16:20 +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > Andy brought to my attention the fact that users allocating an array of > > equally sized elements should check if the size multiplication does

[patch V3 11/37] csky/mm/highmem: Switch to generic kmap atomic

2020-11-04 Thread Thomas Gleixner
No reason having the same code in every architecture. Signed-off-by: Thomas Gleixner Cc: linux-c...@vger.kernel.org --- V3: Does not compile with gcc 10 --- arch/csky/Kconfig |1 arch/csky/include/asm/fixmap.h |4 +- arch/csky/include/asm/highmem.h |6 ++- arch/csky/m

Re: [PATCH v2] drm/nouveau/kms: Fix NULL pointer dereference in nouveau_connector_detect_depth

2020-11-04 Thread Alexander Kapshuk
On Tue, Oct 13, 2020 at 3:47 PM Alexander Kapshuk wrote: > > This oops manifests itself on the following hardware: > 01:00.0 VGA compatible controller: NVIDIA Corporation G98M [GeForce G 103M] > (rev a1) > > Oct 09 14:17:46 lp-sasha kernel: BUG: kernel NULL pointer dereference, > address: 00

[patch V3 09/37] arc/mm/highmem: Use generic kmap atomic implementation

2020-11-04 Thread Thomas Gleixner
Adopt the map ordering to match the other architectures and the generic code. Also make the maximum entries limited and not dependend on the number of CPUs. With the original implementation did the following calculation: nr_slots = mapsize >> PAGE_SHIFT; The results in either 512 or 1024 total

[patch V3 13/37] mips/mm/highmem: Switch to generic kmap atomic

2020-11-04 Thread Thomas Gleixner
No reason having the same code in every architecture Signed-off-by: Thomas Gleixner Cc: Thomas Bogendoerfer Cc: linux-m...@vger.kernel.org --- V3: Remove the kmap types cruft --- arch/mips/Kconfig |1 arch/mips/include/asm/fixmap.h |4 - arch/mips/include/asm/highm

[patch V3 30/37] highmem: Remove kmap_atomic_pfn()

2020-11-04 Thread Thomas Gleixner
No more users. Signed-off-by: Thomas Gleixner --- V3: New patch --- include/linux/highmem-internal.h | 12 1 file changed, 12 deletions(-) --- a/include/linux/highmem-internal.h +++ b/include/linux/highmem-internal.h @@ -99,13 +99,6 @@ static inline void *kmap_atomic(struct p

Re: [PATCH v7 0/6] Exynos: Simple QoS for exynos-bus using interconnect

2020-11-04 Thread Georgi Djakov
Hi Chanwoo and Sylwester, On 11/3/20 09:54, Chanwoo Choi wrote: > Hi Sylwester, > > When I tested this patchset on Odroid-U3, > After setting 0 bps by interconnect[1][2], > the frequency of devfreq devs sustain the high frequency > according to the pm qos request. > > So, I try to find the cause

[patch V3 32/37] drm/vmgfx: Replace kmap_atomic()

2020-11-04 Thread Thomas Gleixner
There is no reason to disable pagefaults and preemption as a side effect of kmap_atomic_prot(). Use kmap_local_page_prot() instead and document the reasoning for the mapping usage with the given pgprot. Remove the NULL pointer check for the map. These functions return a valid address for valid pa

[PATCH 1/3] FROMLIST: drm/msm/dp: return correct connection status after suspend

2020-11-04 Thread Kuogee Hsieh
At dp_pm_resume, reinitialize both dp host controller and hpd block so that hpd connection can be detected at realtime by reading hpd state status register. Also hpd plug interrupt can be generated accordingly. Changes in v2: -- use container_of to cast correct dp_display_private pointer at bot

[patch V3 16/37] sparc/mm/highmem: Switch to generic kmap atomic

2020-11-04 Thread Thomas Gleixner
No reason having the same code in every architecture Signed-off-by: Thomas Gleixner Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org --- V3: Remove the kmap types cruft --- arch/sparc/Kconfig |1 arch/sparc/include/asm/highmem.h|8 +- arch/sparc/include/asm/kma

Re: use of dma_direct_set_offset in (allwinner) drivers

2020-11-04 Thread Maxime Ripard
Hi Christoph, On Tue, Nov 03, 2020 at 10:55:38AM +0100, Christoph Hellwig wrote: > Linux 5.10-rc1 switched from having a single dma offset in struct device > to a set of DMA ranges, and introduced a new helper to set them, > dma_direct_set_offset. > > This in fact surfaced that a bunch of drivers

Re: [PATCH 2/3] drm: Use state helper instead of CRTC state pointer

2020-11-04 Thread Maxime Ripard
Hi Ville, On Mon, Nov 02, 2020 at 06:04:06PM +0200, Ville Syrjälä wrote: > On Mon, Nov 02, 2020 at 02:38:33PM +0100, Maxime Ripard wrote: > > Many drivers reference the crtc->pointer in order to get the current CRTC > > state in their atomic_begin or atomic_flush hooks, which would be the new > >

Re: [PATCH 1/3] drm/nouveau/kms/nv50-: Use state helper instead of crtc pointer

2020-11-04 Thread Maxime Ripard
On Mon, Nov 02, 2020 at 06:06:30PM +0200, Ville Syrjälä wrote: > On Mon, Nov 02, 2020 at 02:38:32PM +0100, Maxime Ripard wrote: > > dispnv50 references the crtc->state pointer in order to get the current > > CRTC state in its atomic_check hook, which would be the old CRTC state in > > the global at

[patch V3 05/37] asm-generic: Provide kmap_size.h

2020-11-04 Thread Thomas Gleixner
kmap_types.h is a misnomer because the old atomic MAP based array does not exist anymore and the whole indirection of architectures including kmap_types.h is inconinstent and does not allow to provide guard page debugging for this misfeature. Add a common header file which defines the mapping stac

Re: [PATCH v4 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-11-04 Thread Andy Shevchenko
On Tue, Nov 03, 2020 at 04:56:16PM +0200, Sakari Ailus wrote: > On Tue, Nov 03, 2020 at 04:47:47PM +0200, Andy Shevchenko wrote: > > On Tue, Nov 03, 2020 at 03:34:00PM +0200, Sakari Ailus wrote: > > > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM > > > pixel formats denot

[patch V3 25/37] mm/highmem: Provide kmap_local*

2020-11-04 Thread Thomas Gleixner
Now that the kmap atomic index is stored in task struct provide a preemptible variant. On context switch the maps of an outgoing task are removed and the map of the incoming task are restored. That's obviously slow, but highmem is slow anyway. The kmap_local.*() functions can be invoked from both

[patch V3 31/37] drm/ttm: Replace kmap_atomic() usage

2020-11-04 Thread Thomas Gleixner
There is no reason to disable pagefaults and preemption as a side effect of kmap_atomic_prot(). Use kmap_local_page_prot() instead and document the reasoning for the mapping usage with the given pgprot. Remove the NULL pointer check for the map. These functions return a valid address for valid pa

[PATCH 3/3] drm/msm/dp: promote irq_hpd handle to handle link training correctly

2020-11-04 Thread Kuogee Hsieh
Some dongles require link training done at irq_hpd request instead of plugin request. This patch promote irq_hpd handler to handle link training and setup hpd_state correctly. Fixes: fdaf9a5e3c15 (drm/msm/dp: fixes wrong connection state caused by failure of link training) Signed-off-by: Kuogee

[patch V3 01/37] mm/highmem: Un-EXPORT __kmap_atomic_idx()

2020-11-04 Thread Thomas Gleixner
Nothing in modules can use that. Signed-off-by: Thomas Gleixner Reviewed-by: Christoph Hellwig Cc: Andrew Morton Cc: linux...@kvack.org --- mm/highmem.c |2 -- 1 file changed, 2 deletions(-) --- a/mm/highmem.c +++ b/mm/highmem.c @@ -108,8 +108,6 @@ static inline wait_queue_head_t *get_pkm

[patch V3 33/37] highmem: Remove kmap_atomic_prot()

2020-11-04 Thread Thomas Gleixner
No more users. Signed-off-by: Thomas Gleixner --- V3: New patch --- include/linux/highmem-internal.h | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) --- a/include/linux/highmem-internal.h +++ b/include/linux/highmem-internal.h @@ -87,16 +87,11 @@ static inline void __kun

[PATCH 1/3] drm/msm/dp: deinitialize mainlink if link training failed

2020-11-04 Thread Kuogee Hsieh
DP compo phy have to be enable to start link training. When link training failed phy need to be disabled so that next link traning can be proceed smoothly at next plug in. This patch de-initialize mainlink to disable phy if link training failed. This prevent system crash due to disp_cc_mdss_dp_link

Re: [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-11-04 Thread Viresh Kumar
On 03-11-20, 08:50, Rob Clark wrote: > sorry, it didn't apply cleanly (which I guess is due to some other > dependencies that need to be picked back to v5.4 product kernel), and > due to some other things I'm in middle of debugging I didn't have time > yet to switch to v5.10-rc or look at what else

[patch V3 04/37] sh/highmem: Remove all traces of unused cruft

2020-11-04 Thread Thomas Gleixner
For whatever reasons SH has highmem bits all over the place but does not enable it via Kconfig. Remove the bitrot. Signed-off-by: Thomas Gleixner --- arch/sh/include/asm/fixmap.h |8 arch/sh/include/asm/kmap_types.h | 15 --- arch/sh/mm/init.c|8

Re: [PATCH] drm/msm/dp: promote irq_hpd handle to handle link trainign correctly

2020-11-04 Thread khsieh
On 2020-11-02 11:29, Stephen Boyd wrote: Subject has a typo in "training". Quoting Kuogee Hsieh (2020-10-30 16:23:24) Some dongles, such as Apple, required link training done at irq_hpd s/required/require/ request instead of plugin request. This patch promote irq_hpd hanlder s/hanlder/han

[patch V3 14/37] nds32/mm/highmem: Switch to generic kmap atomic

2020-11-04 Thread Thomas Gleixner
The mapping code is odd and looks broken. See FIXME in the comment. Also fix the harmless off by one in the FIX_KMAP_END define. Signed-off-by: Thomas Gleixner Cc: Nick Hu Cc: Greentime Hu Cc: Vincent Chen --- V3: Remove the kmap types cruft --- arch/nds32/Kconfig.cpu |1 arch

[patch V3 12/37] microblaze/mm/highmem: Switch to generic kmap atomic

2020-11-04 Thread Thomas Gleixner
No reason having the same code in every architecture. Signed-off-by: Thomas Gleixner Cc: Michal Simek --- V3: Remove the kmap types cruft --- arch/microblaze/Kconfig |1 arch/microblaze/include/asm/fixmap.h |4 - arch/microblaze/include/asm/highmem.h |6 ++ arch/micr

[patch V4 24/37] sched: highmem: Store local kmaps in task struct

2020-11-04 Thread Thomas Gleixner
Instead of storing the map per CPU provide and use per task storage. That prepares for local kmaps which are preemptible. The context switch code is preparatory and not yet in use because kmap_atomic() runs with preemption disabled. Will be made usable in the next step. The context switch logic i

[patch V3 20/37] io-mapping: Cleanup atomic iomap

2020-11-04 Thread Thomas Gleixner
Switch the atomic iomap implementation over to kmap_local and stick the preempt/pagefault mechanics into the generic code similar to the kmap_atomic variants. Rename the x86 map function in preparation for a non-atomic variant. Signed-off-by: Thomas Gleixner --- V2: New patch to make review easi

[patch V3 24/37] sched: highmem: Store local kmaps in task struct

2020-11-04 Thread Thomas Gleixner
Instead of storing the map per CPU provide and use per task storage. That prepares for local kmaps which are preemptible. The context switch code is preparatory and not yet in use because kmap_atomic() runs with preemption disabled. Will be made usable in the next step. The context switch logic i

[PATCH 0/3] fix dp link training failed at irq_hpd request

2020-11-04 Thread Kuogee Hsieh
Some dongle require link training be done at irq_hpd request. This serial patches address the issues so that DP/HDMI display can be lit up properlly. This serial Patch also fixes clock stuck at "off" state error caused by previous link training failed. Kuogee Hsieh (3): drm/msm/dp: deinitialize

[PATCH 2/3] FIXUP: FROMLIST: drm/msm/dp: return correct connection status after suspend

2020-11-04 Thread Kuogee Hsieh
From: Stephen Boyd During suspend, dp host controller and hpd block are disabled due to both ahb and aux clock are disabled. Therefore hpd plug/unplug interrupts will not be generated. At dp_pm_resume(), reinitialize both dp host controller and hpd block so that hpd plug/unplug interrupts will be

[patch V3 22/37] highmem: High implementation details and document API

2020-11-04 Thread Thomas Gleixner
Move the gory details of kmap & al into a private header and only document the interfaces which are usable by drivers. Signed-off-by: Thomas Gleixner --- V3: New patch --- include/linux/highmem-internal.h | 174 + include/linux/highmem.h | 270 ++---

[patch V3 08/37] x86/mm/highmem: Use generic kmap atomic implementation

2020-11-04 Thread Thomas Gleixner
Convert X86 to the generic kmap atomic implementation and make the iomap_atomic() naming convention consistent while at it. Signed-off-by: Thomas Gleixner Cc: x...@kernel.org --- V3: Remove the kmap_types cruft --- arch/x86/Kconfig |3 + arch/x86/include/asm/fixmap.h

[patch V3 29/37] ARM: mm: Replace kmap_atomic_pfn()

2020-11-04 Thread Thomas Gleixner
There is no requirement to disable pagefaults and preemption for these cache management mappings. Replace kmap_atomic_pfn() with kmap_local_pfn(). This allows to remove kmap_atomic_pfn() in the next step. Signed-off-by: Thomas Gleixner Cc: Russell King Cc: linux-arm-ker...@lists.infradead.org -

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-04 Thread Maxime Ripard
Hi! On Tue, Nov 03, 2020 at 11:55:08AM +0100, Daniel Vetter wrote: > On Tue, Nov 03, 2020 at 11:38:32AM +0100, Maxime Ripard wrote: > > On Tue, Nov 03, 2020 at 11:10:27AM +0100, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 03.11.20 um 10:52 schrieb Maxime Ripard: > > > > On Tue, Nov 03, 2020

[PATCH 3/3] FROMLIST: drm/msm/dp: fixes wrong connection state caused by failure of link train

2020-11-04 Thread Kuogee Hsieh
Connection state is not set correctly happen when either failure of link train due to cable unplugged in the middle of aux channel reading or cable plugged in while in suspended state. This patch fixes these problems. This patch also replace ST_SUSPEND_PENDING with ST_DISPLAY_OFF. Changes in V2: -

[patch V3 28/37] mips/crashdump: Simplify copy_oldmem_page()

2020-11-04 Thread Thomas Gleixner
Replace kmap_atomic_pfn() with kmap_local_pfn() which is preemptible and can take page faults. Remove the indirection of the dump page and the related cruft which is not longer required. Signed-off-by: Thomas Gleixner Cc: Thomas Bogendoerfer Cc: linux-m...@vger.kernel.org --- V3: New patch ---

[patch V3 27/37] x86/crashdump/32: Simplify copy_oldmem_page()

2020-11-04 Thread Thomas Gleixner
Replace kmap_atomic_pfn() with kmap_local_pfn() which is preemptible and can take page faults. Remove the indirection of the dump page and the related cruft which is not longer required. Signed-off-by: Thomas Gleixner --- V3: New patch --- arch/x86/kernel/crash_dump_32.c | 48

[patch V3 35/37] drm/nouveau/device: Replace io_mapping_map_atomic_wc()

2020-11-04 Thread Thomas Gleixner
Neither fbmem_peek() nor fbmem_poke() require to disable pagefaults and preemption as a side effect of io_mapping_map_atomic_wc(). Use io_mapping_map_local_wc() instead. Signed-off-by: Thomas Gleixner Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: no

Re: [patch V3 24/37] sched: highmem: Store local kmaps in task struct

2020-11-04 Thread Thomas Gleixner
On Tue, Nov 03 2020 at 10:27, Thomas Gleixner wrote: > +struct kmap_ctrl { > +#ifdef CONFIG_KMAP_LOCAL > + int idx; > + pte_t pteval[KM_TYPE_NR]; I'm a moron. Fixed it on the test machine ...

Re: [PATCH 5/5] drm/ingenic: Add option to alloc cached GEM buffers

2020-11-04 Thread Paul Cercueil
Hi Daniel, Le mar. 3 nov. 2020 à 11:17, Daniel Vetter a écrit : On Mon, Nov 02, 2020 at 10:06:51PM +, Paul Cercueil wrote: With the module parameter ingenic-drm.cached_gem_buffers, it is possible to specify that we want GEM buffers backed by non-coherent memory. This dramatically spee

[patch V3 06/37] highmem: Provide generic variant of kmap_atomic*

2020-11-04 Thread Thomas Gleixner
The kmap_atomic* interfaces in all architectures are pretty much the same except for post map operations (flush) and pre- and post unmap operations. Provide a generic variant for that. Signed-off-by: Thomas Gleixner Cc: Andrew Morton Cc: linux...@kvack.org --- V3: Do not reuse the kmap_atomic_i

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-04 Thread Maxime Ripard
On Tue, Nov 03, 2020 at 11:10:27AM +0100, Thomas Zimmermann wrote: > Hi > > Am 03.11.20 um 10:52 schrieb Maxime Ripard: > > On Tue, Nov 03, 2020 at 10:10:41AM +0800, Tian Tao wrote: > >> Add new api devm_drm_irq_install() to register interrupts, > >> no need to call drm_irq_uninstall() when the dr

[patch V3 07/37] highmem: Make DEBUG_HIGHMEM functional

2020-11-04 Thread Thomas Gleixner
For some obscure reason when CONFIG_DEBUG_HIGHMEM is enabled the stack depth is increased from 20 to 41. But the only thing DEBUG_HIGHMEM does is to enable a few BUG_ON()'s in the mapping code. That's a leftover from the historical mapping code which had fixed entries for various purposes. DEBUG_H

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-04 Thread Maxime Ripard
On Tue, Nov 03, 2020 at 10:10:41AM +0800, Tian Tao wrote: > Add new api devm_drm_irq_install() to register interrupts, > no need to call drm_irq_uninstall() when the drm module is removed. > > v2: > fixed the wrong parameter. > > Signed-off-by: Tian Tao > --- > drivers/gpu/drm/drm_drv.c | 23 ++

[patch V3 18/37] highmem: Get rid of kmap_types.h

2020-11-04 Thread Thomas Gleixner
The header is not longer used and on alpha, ia64, openrisc, parisc and um it was completely unused anyway as these architectures have no highmem support. Signed-off-by: Thomas Gleixner --- V3: New patch --- arch/alpha/include/asm/kmap_types.h | 15 --- arch/ia64/include/asm/kmap_t

[PATCH v2 0/2] cherry-pick miised DP related patches

2020-11-04 Thread Kuogee Hsieh
Cherry-pick two missed drm/msm/dp related patches to msm-next-staging Kuogee Hsieh (2): drm/msm/dp: return correct connection status after suspend drm/msm/dp: fixes wrong connection state caused by failure of link train drivers/gpu/drm/msm/dp/dp_catalog.c | 13 +++ drivers/gpu/drm/msm/d

[patch V3 10/37] ARM: highmem: Switch to generic kmap atomic

2020-11-04 Thread Thomas Gleixner
No reason having the same code in every architecture. Signed-off-by: Thomas Gleixner Cc: Russell King Cc: Arnd Bergmann Cc: linux-arm-ker...@lists.infradead.org --- V3: Remove the kmap types cruft --- arch/arm/Kconfig |1 arch/arm/include/asm/fixmap.h |4 - arch/a

[patch V3 15/37] powerpc/mm/highmem: Switch to generic kmap atomic

2020-11-04 Thread Thomas Gleixner
No reason having the same code in every architecture Signed-off-by: Thomas Gleixner Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-...@lists.ozlabs.org --- V3: Remove the kmap types cruft --- arch/powerpc/Kconfig |1 arch/powerpc/include/

[patch V3 34/37] drm/qxl: Replace io_mapping_map_atomic_wc()

2020-11-04 Thread Thomas Gleixner
None of these mapping requires the side effect of disabling pagefaults and preemption. Use io_mapping_map_local_wc() instead, rename the related functions accordingly and clean up qxl_process_single_command() to use a plain copy_from_user() as the local maps are not disabling pagefaults. Signed-o

Re: [patch V3 22/37] highmem: High implementation details and document API

2020-11-04 Thread Thomas Gleixner
On Tue, Nov 03 2020 at 09:48, Linus Torvalds wrote: > I have no complaints about the patch, but it strikes me that if people > want to actually have much better debug coverage, this is where it > should be (I like the "every other address" thing too, don't get me > wrong). > > In particular, instea

Re: [PATCH 3/5] drm: Add and export function drm_gem_cma_mmap_noncoherent

2020-11-04 Thread Paul Cercueil
Hi Christoph, Le mar. 3 nov. 2020 à 18:50, Christoph Hellwig a écrit : On Mon, Nov 02, 2020 at 10:06:49PM +, Paul Cercueil wrote: This function can be used by drivers that need to mmap dumb buffers created with non-coherent backing memory. Signed-off-by: Paul Cercueil --- drivers/

[PATCH v2 1/2] drm/msm/dp: return correct connection status after suspend

2020-11-04 Thread Kuogee Hsieh
During suspend, dp host controller and hpd block are disabled due to both ahb and aux clock are disabled. Therefore hpd plug/unplug interrupts will not be generated. At dp_pm_resume(), reinitialize both dp host controller and hpd block so that hpd plug/unplug interrupts will be generated and handle

Re: [PATCH v7 2/6] interconnect: Add generic interconnect driver for Exynos SoCs

2020-11-04 Thread Georgi Djakov
Hi Sylwester, Thank you for refreshing the patchset! On 10/30/20 14:51, Sylwester Nawrocki wrote: > This patch adds a generic interconnect driver for Exynos SoCs in order > to provide interconnect functionality for each "samsung,exynos-bus" > compatible device. > > The SoC topology is a graph (o

[PATCH v2 2/2] drm/msm/dp: fixes wrong connection state caused by failure of link train

2020-11-04 Thread Kuogee Hsieh
Connection state is not set correctly happen when either failure of link train due to cable unplugged in the middle of aux channel reading or cable plugged in while in suspended state. This patch fixes these problems. This patch also replace ST_SUSPEND_PENDING with ST_DISPLAY_OFF. Changes in V2: -

[patch V3 19/37] mm/highmem: Remove the old kmap_atomic cruft

2020-11-04 Thread Thomas Gleixner
All users gone. Signed-off-by: Thomas Gleixner --- include/linux/highmem.h | 63 +++- mm/highmem.c|7 - 2 files changed, 5 insertions(+), 65 deletions(-) --- a/include/linux/highmem.h +++ b/include/linux/highmem.h @@ -86,31 +86,1

Re: [patch V3 03/37] fs: Remove asm/kmap_types.h includes

2020-11-04 Thread David Sterba
On Tue, Nov 03, 2020 at 10:27:15AM +0100, Thomas Gleixner wrote: > Historical leftovers from the time where kmap() had fixed slots. > > Signed-off-by: Thomas Gleixner > Cc: Alexander Viro > Cc: Benjamin LaHaise > Cc: linux-fsde...@vger.kernel.org > Cc: linux-...@kvack.org > Cc: Chris Mason > C

Re: [PATCH v7 2/3] drm: Add support for the LogiCVC display controller

2020-11-04 Thread Maxime Ripard
On Mon, Nov 02, 2020 at 04:53:07PM +0100, Paul Kocialkowski wrote: > Introduces a driver for the LogiCVC display controller, a programmable > logic controller optimized for use in Xilinx Zynq-7000 SoCs and other > Xilinx FPGAs. The controller is mostly configured at logic synthesis > time so only a

[PATCH] dt-bindings: display: panel-simple: Allow optional 'ports' property

2020-11-04 Thread Liu Ying
Some simple panels have dual LVDS interfaces which receive even and odd pixels respectively, like 'nlt,nl192108ac18-02d' and 'koe,tx26d202vm0bwa'. So, let's allow optional 'ports' property so that pixel order can be got via drm_of_lvds_get_dual_link_pixel_order() if it's child nodes 'port@0' and 'p

Re: [PATCH 30/33] docs: ABI: cleanup several ABI documents

2020-11-04 Thread Bjorn Andersson
On Wed 28 Oct 09:23 CDT 2020, Mauro Carvalho Chehab wrote: [..] > .../ABI/testing/sysfs-class-remoteproc| 14 +- for this: Acked-by: Bjorn Andersson Thanks, Bjorn ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freede

[patch V3 02/37] highmem: Remove unused functions

2020-11-04 Thread Thomas Gleixner
Nothing uses totalhigh_pages_dec() and totalhigh_pages_set(). Signed-off-by: Thomas Gleixner --- V3: New patch --- include/linux/highmem.h | 10 -- 1 file changed, 10 deletions(-) --- a/include/linux/highmem.h +++ b/include/linux/highmem.h @@ -104,21 +104,11 @@ static inline void tota

[patch V3 03/37] fs: Remove asm/kmap_types.h includes

2020-11-04 Thread Thomas Gleixner
Historical leftovers from the time where kmap() had fixed slots. Signed-off-by: Thomas Gleixner Cc: Alexander Viro Cc: Benjamin LaHaise Cc: linux-fsde...@vger.kernel.org Cc: linux-...@kvack.org Cc: Chris Mason Cc: Josef Bacik Cc: David Sterba Cc: linux-bt...@vger.kernel.org --- fs/aio.c

[PATCH 2/3] drm/msm/dp: skip checking LINK_STATUS_UPDATED bit

2020-11-04 Thread Kuogee Hsieh
Some dongle will not clear LINK_STATUS_UPDATED bit after DPCD read which cause link training failed. This patch just read 6 bytes of DPCD link status from sink and return without checking LINK_STATUS_UPDATED bit. Only 8 bits are used to represent link rate at sinker DPCD. The really link rate is 2.

[patch V3 26/37] io-mapping: Provide iomap_local variant

2020-11-04 Thread Thomas Gleixner
Similar to kmap local provide a iomap local variant which only disables migration, but neither disables pagefaults nor preemption. Signed-off-by: Thomas Gleixner --- V3: Restrict migrate disable to the 32bit mapping case and update documentation. V2: Split out from the large combo patch and add

Re: [PATCH] drm/msm/dp: deinitialize mainlink if link training failedo

2020-11-04 Thread khsieh
On 2020-11-02 12:59, Stephen Boyd wrote: Quoting Kuogee Hsieh (2020-10-30 16:22:53) DP compo phy have to be enable to start link training. When link training failed phy need to be disabled so that next link trainng can be proceed smoothly at next plug in. This s/trainng/training/ patch de in

Re: [PATCH 3/3] drm: Use the state pointer directly in atomic_check

2020-11-04 Thread Maxime Ripard
On Mon, Nov 02, 2020 at 06:06:04PM +0200, Ville Syrjälä wrote: > On Mon, Nov 02, 2020 at 02:38:34PM +0100, Maxime Ripard wrote: > > Now that atomic_check takes the global atomic state as a parameter, we > > don't need to go through the pointer in the CRTC state. > > > > This was done using the fol

Re: [PATCH v5 11/15] PCI: Obey iomem restrictions for procfs mmap

2020-11-04 Thread Daniel Vetter
On Tue, Nov 3, 2020 at 11:09 PM Dan Williams wrote: > On Tue, Nov 3, 2020 at 1:28 PM Bjorn Helgaas wrote: > > On Fri, Oct 30, 2020 at 11:08:11AM +0100, Daniel Vetter wrote: > > > There's three ways to access PCI BARs from userspace: /dev/mem, sysfs > > > files, and the old proc interface. Two che

[PATCH V2] drm/tegra: sor: Don't warn on probe deferral

2020-11-04 Thread Jon Hunter
Deferred probe is an expected return value for tegra_output_probe(). Given that the driver deals with it properly, there's no need to output a warning that may potentially confuse users. Signed-off-by: Jon Hunter --- Changes since V1: - This time, I actually validated it! drivers/gpu/drm/tegra

Re: [PATCH 3/5] drm/amdgpu: Paper over the drm_driver mangling for virt

2020-11-04 Thread Daniel Vetter
On Tue, Nov 03, 2020 at 11:49:40AM -0500, Alex Deucher wrote: > On Sun, Nov 1, 2020 at 5:01 AM Daniel Vetter wrote: > > > > On Sat, Oct 31, 2020 at 2:57 PM Daniel Vetter > > wrote: > > > > > > On Fri, Oct 30, 2020 at 7:47 PM Alex Deucher > > > wrote: > > > > > > > > On Fri, Oct 30, 2020 at 6:1

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-04 Thread Daniel Vetter
On Tue, Nov 03, 2020 at 12:25:22PM +0100, Maxime Ripard wrote: > Hi! > > On Tue, Nov 03, 2020 at 11:55:08AM +0100, Daniel Vetter wrote: > > On Tue, Nov 03, 2020 at 11:38:32AM +0100, Maxime Ripard wrote: > > > On Tue, Nov 03, 2020 at 11:10:27AM +0100, Thomas Zimmermann wrote: > > > > Hi > > > > >

Re: [PATCH] drm/amdgpu/virt: fix handling of the atomic flag

2020-11-04 Thread Daniel Vetter
On Tue, Nov 03, 2020 at 04:54:50PM -0500, Alex Deucher wrote: > Use the per device drm driver feature flags rather than the > global one. This way we can make the drm driver struct const. > > Signed-off-by: Alex Deucher Reviewed-by: Daniel Vetter Can we merge this through drm-misc-next so I c

Re: [PATCH 0/2] amdgpu's drm_driver becomes const

2020-11-04 Thread Daniel Vetter
On Tue, Nov 03, 2020 at 10:11:27PM -0500, Luben Tuikov wrote: > Hi Daniel, > > These two patches follow up your latest > DRM work to make definitions of struct drm_driver > in DRM low-level drivers, constant, in amdgpu. > > This set doesn't descend from my previous patch > "drm/amdgpu: Convert to

Re: [PATCH 2/2] drm/amdgpu: Make struct drm_driver const

2020-11-04 Thread Daniel Vetter
On Tue, Nov 03, 2020 at 10:11:29PM -0500, Luben Tuikov wrote: > Make the definition of struct drm_driver > a constant, to follow the latest developments > in the DRM layer. > > Signed-off-by: Luben Tuikov > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 32 + > drivers/g

[PATCH 1/6] drm/radeon: Stop changing the drm_driver struct

2020-11-04 Thread Daniel Vetter
With only the kms driver left, we can fold this in. This means we need to move the ioctl table, which means one additional ioctl must be defined in headers. Also there's a conflict between the radeon_init macro and the module init function, so rename the module functions to avoid that. Reviewed-b

[PATCH 5/6] drm/: Constify struct drm_driver

2020-11-04 Thread Daniel Vetter
Only the following drivers aren't converted: - amdgpu, because of the driver_feature mangling due to virt support. Subsequent patch will address this. - nouveau, because DRIVER_ATOMIC uapi is still not the default on the platforms where it's supported (i.e. again driver_feature mangling) - vc4,

[PATCH 4/6] drm: Allow const struct drm_driver

2020-11-04 Thread Daniel Vetter
It's nice if a big function/ioctl table like this is const. Only downside here is that we need a few more #ifdef to paper over the differences when CONFIG_DRM_LEGACY is enabled. Maybe provides more motivation to sunset that horror show :-) v2: - Fix super important checkpatch warning (Sam) - Updat

[PATCH 2/6] drm: Compile out legacy chunks from struct drm_device

2020-11-04 Thread Daniel Vetter
This means some very few #ifdef in code, but it allows us to enlist the compiler to make sure this stuff isn't used anymore. More important, only legacy drivers change drm_device (for the legacy_dev_list shadow attach management), therefore this is prep to allow modern drivers to have a const driv

[PATCH 3/6] drm/amdgpu/virt: fix handling of the atomic flag

2020-11-04 Thread Daniel Vetter
From: Alex Deucher Use the per device drm driver feature flags rather than the global one. This way we can make the drm driver struct const. Signed-off-by: Alex Deucher Reviewed-by: Luben Tuikov Signed-off-by: Daniel Vetter --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 4 +++- 1 file chang

[PATCH 6/6] drm/amdgpu: Make struct drm_driver const

2020-11-04 Thread Daniel Vetter
From: Luben Tuikov Make the definition of struct drm_driver a constant, to follow the latest developments in the DRM layer. Signed-off-by: Luben Tuikov [danvet: Rebase onto devm_drm_dev_alloc patch and drop the freesync ioctl line again that escaped from internal trees.] Signed-off-by: Daniel V

Re: use of dma_direct_set_offset in (allwinner) drivers

2020-11-04 Thread Robin Murphy
On 2020-11-04 08:14, Maxime Ripard wrote: Hi Christoph, On Tue, Nov 03, 2020 at 10:55:38AM +0100, Christoph Hellwig wrote: Linux 5.10-rc1 switched from having a single dma offset in struct device to a set of DMA ranges, and introduced a new helper to set them, dma_direct_set_offset. This in fa

[PATCH v8 6/7] ARM: dts: exynos: Add interconnects to Exynos4412 mixer

2020-11-04 Thread Sylwester Nawrocki
From: Artur Świgoń This patch adds an 'interconnects' property to Exynos4412 DTS in order to declare the interconnect path used by the mixer. Please note that the 'interconnect-names' property is not needed when there is only one path in 'interconnects', in which case calling of_icc_get() with a

[PATCH v8 2/7] interconnect: Add generic interconnect driver for Exynos SoCs

2020-11-04 Thread Sylwester Nawrocki
This patch adds a generic interconnect driver for Exynos SoCs in order to provide interconnect functionality for each "samsung,exynos-bus" compatible device. The SoC topology is a graph (or more specifically, a tree) and its edges are described by specifying in the 'interconnects' property the int

[PATCH v8 1/7] dt-bindings: devfreq: Add documentation for the interconnect properties

2020-11-04 Thread Sylwester Nawrocki
Add documentation for new optional properties in the exynos bus nodes: interconnects, #interconnect-cells, samsung,data-clock-ratio. These properties allow to specify the SoC interconnect structure which then allows the interconnect consumer devices to request specific bandwidth requirements. Sign

[PATCH v8 5/7] ARM: dts: exynos: Add interconnect properties to Exynos4412 bus nodes

2020-11-04 Thread Sylwester Nawrocki
This patch adds the following properties for Exynos4412 interconnect bus nodes: - interconnects: to declare connections between nodes in order to guarantee PM QoS requirements between nodes, - #interconnect-cells: required by the interconnect framework, - samsung,data-clk-ratio: which allows

[PATCH v8 0/7] Exynos: Simple QoS for exynos-bus using interconnect

2020-11-04 Thread Sylwester Nawrocki
This patchset adds interconnect API support for the Exynos SoC "samsung, exynos-bus" compatible devices, which already have their corresponding exynos-bus driver in the devfreq subsystem. Complementing the devfreq driver with an interconnect functionality allows to ensure the QoS requirements of d

[PATCH v8 7/7] drm: exynos: mixer: Add interconnect support

2020-11-04 Thread Sylwester Nawrocki
This patch adds interconnect support to exynos-mixer. The mixer works the same as before when CONFIG_INTERCONNECT is 'n'. For proper operation of the video mixer block we need to ensure the interconnect busses like DMC or LEFTBUS provide enough bandwidth so as to avoid DMA buffer underruns in the

[PATCH v8 4/7] PM / devfreq: exynos-bus: Add registration of interconnect child device

2020-11-04 Thread Sylwester Nawrocki
This patch adds registration of a child platform device for the exynos interconnect driver. It is assumed that the interconnect provider will only be needed when #interconnect-cells property is present in the bus DT node, hence the child device will be created only when such a property is present.

[PATCH v8 3/7] MAINTAINERS: Add entry for Samsung interconnect drivers

2020-11-04 Thread Sylwester Nawrocki
Add maintainers entry for the Samsung interconnect drivers, this currently includes Exynos SoC generic interconnect driver. Signed-off-by: Sylwester Nawrocki --- Changes since v7: - new patch. --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS i

  1   2   >