[PATCH v3] drm/panfrost: Move the GPU reset bits outside the timeout handler

2020-11-03 Thread Boris Brezillon
We've fixed many races in panfrost_job_timedout() but some remain. Instead of trying to fix it again, let's simplify the logic and move the reset bits to a separate work scheduled when one of the queue reports a timeout. v3: - Replace the atomic_cmpxchg() by an atomic_xchg() (Robin Murphy) - Add S

[PATCH v2 3/8] vhost: vringh: use krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski Acked-by: Michael S. Tsirkin --- drivers/vhost/vringh.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --g

Re: [PATCH] drm/msm/dp: do not notify audio subsystem if sink doesn't support audio

2020-11-03 Thread Stephen Boyd
Quoting Abhinav Kumar (2020-10-29 13:55:09) > For sinks that do not support audio, there is no need to notify > audio subsystem of the connection event. > > This will make sure that audio routes only to the primary display > when connected to such sinks. > Does this need a Fixes tag? Or it's jus

[PATCH 4/6] drm/amdgpu/nbio: improve code indentation and alignment

2020-11-03 Thread Deepak R Varma
General code indentation and alignment changes such as replace spaces by tabs or align function arguments as per the coding style guidelines. Issue reported by checkpatch script. Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/nbio_v6_1.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/nbio_v7

[PATCH v2 5/8] edac: ghes: use krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski Acked-by: Borislav Petkov --- drivers/edac/ghes_edac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH 6/6] drm/amdgpu: improve code indentation and alignment

2020-11-03 Thread Deepak R Varma
General code indentation and alignment changes such as replace spaces by tabs or align function arguments as per the coding style guidelines. The patch covers various .c files for this driver. Issue reported by checkpatch script. Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/atom.

Re: [PATCH v3 0/3] Reduce context clear batch size to avoid gpu hang

2020-11-03 Thread rwright
On Mon, Nov 02, 2020 at 10:48:54AM +0100, Hans de Goede wrote: > Hi, > > On 11/1/20 6:41 PM, rwri...@hpe.com wrote: > > From: Randy Wright > > > > For several months, I've been experiencing GPU hangs when starting > > Cinnamon on an HP Pavilion Mini 300-020 if I try to run an upstream > > kerne

[PATCH 1/5] drm: Add and export function drm_gem_cma_create_noncoherent

2020-11-03 Thread Paul Cercueil
This function can be used by drivers that need to create a GEM object with non-coherent backing memory. Signed-off-by: Paul Cercueil --- drivers/gpu/drm/drm_gem_cma_helper.c | 71 +--- include/drm/drm_gem_cma_helper.h | 2 + 2 files changed, 56 insertions(+), 17 dele

Re: [PATCH v3 0/3] dt-bindings: Convert graph bindings to json-schema

2020-11-03 Thread Sameer Pujar
Hi Rob, Sameer, I wanted to experiment with what the interface for graph users looks like, so I've tweaked your patch a bit and converted 2 users. Thanks for the update and help. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://list

Re: [PATCH v2 1/8] mm: slab: provide krealloc_array()

2020-11-03 Thread Matthew Wilcox
On Mon, Nov 02, 2020 at 04:20:30PM +0100, Bartosz Golaszewski wrote: > +Chunks allocated with `kmalloc` can be resized with `krealloc`. Similarly > +to `kmalloc_array`: a helper for resising arrays is provided in the form of > +`krealloc_array`. Is there any reason you chose to `do_this` instead o

[PATCH v2 1/8] mm: slab: provide krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski When allocating an array of elements, users should check for multiplication overflow or preferably use one of the provided helpers like: kmalloc_array(). There's no krealloc_array() counterpart but there are many users who use regular krealloc() to reallocate arrays. Le

Re: [PATCH] drm/msm/dp: deinitialize mainlink if link training failedo

2020-11-03 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-10-30 16:22:53) > DP compo phy have to be enable to start link training. When > link training failed phy need to be disabled so that next > link trainng can be proceed smoothly at next plug in. This s/trainng/training/ > patch de initialize mainlink to disable phy if li

RE: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL

2020-11-03 Thread David Laight
From: Greg KH > Sent: 02 November 2020 20:11 > > On Mon, Nov 02, 2020 at 02:43:45PM -0500, Alex Deucher wrote: > > On Mon, Nov 2, 2020 at 1:42 PM Deepak R Varma wrote: > > > > > > Initializing global variable to 0 or NULL is not necessary and should > > > be avoided. Issue reported by checkpatch

Re: [PATCH v2 0/4] drm/bridge: ti-sn65dsi86: Support EDID reading

2020-11-03 Thread Stephen Boyd
Quoting Doug Anderson (2020-11-02 08:37:21) > Hi, > > On Sun, Nov 1, 2020 at 9:37 AM Sam Ravnborg wrote: > > > > Hi Stephen. > > > > On Thu, Oct 29, 2020 at 06:17:34PM -0700, Stephen Boyd wrote: > > > This patch series cleans up the DDC code a little bit so that > > > it is more efficient time wi

[PATCH v3 4/4] drm/bridge: ti-sn65dsi86: Update reply on aux failures

2020-11-03 Thread Stephen Boyd
We should be setting the drm_dp_aux_msg::reply field if a NACK or a SHORT reply happens. Update the error bit handling logic in ti_sn_aux_transfer() to handle these cases and notify upper layers that such errors have happened. This helps the retry logic understand that a timeout has happened, or to

Re: [PATCH v2 0/4] drm/bridge: ti-sn65dsi86: Support EDID reading

2020-11-03 Thread Stephen Boyd
Quoting Sam Ravnborg (2020-11-01 09:37:41) > Hi Stephen. > > On Thu, Oct 29, 2020 at 06:17:34PM -0700, Stephen Boyd wrote: > > This patch series cleans up the DDC code a little bit so that > > it is more efficient time wise and supports grabbing the EDID > > of the eDP panel over the aux channel.

[PATCH 2/6] drm/amdgpu/gfx: improve code indentation and alignment

2020-11-03 Thread Deepak R Varma
General code indentation and alignment changes such as replace spaces by tabs or align function arguments as per the coding style guidelines. Issue reported by checkpatch script. Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 10 +- drivers/gpu/drm/amd/amdgpu/

[PATCH 4/5] drm: Add and export function drm_gem_cma_sync_data

2020-11-03 Thread Paul Cercueil
This function can be used by drivers that use damage clips and have CMA GEM objects backed by non-coherent memory. Calling this function in a plane's .atomic_update ensures that all the data in the backing memory have been written to RAM. Signed-off-by: Paul Cercueil --- drivers/gpu/drm/drm_gem_

[PATCH v2 0/8] slab: provide and use krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Andy brought to my attention the fact that users allocating an array of equally sized elements should check if the size multiplication doesn't overflow. This is why we have helpers like kmalloc_array(). However we don't have krealloc_array() equivalent and there are man

Re: [PATCH v5 08/15] mm: Add unsafe_follow_pfn

2020-11-03 Thread Jason Gunthorpe
On Mon, Nov 02, 2020 at 05:42:20PM +0100, Daniel Vetter wrote: > > Need to hold the lock to check that and there are two ways to register > > notifiers these days, so it feels to expensive to me. > > Uh I mixed stuff up all along, struct mmu_notifier *subcription that > all the mmu notifier users

[PATCH v2] drm/bridge: tpd12s015: Fix irq registering in tpd12s015_probe

2020-11-03 Thread YueHaibing
gpiod_to_irq() return negative value in case of error, the existing code doesn't handle negative error codes. If the HPD gpio supports IRQs (gpiod_to_irq returns a valid number), we use the IRQ. If it doesn't (gpiod_to_irq returns an error), it gets polled via detect(). Fixes: cff5e6f7e83f ("drm/

Re: [PATCH v6 51/52] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree

2020-11-03 Thread Dmitry Osipenko
01.11.2020 18:57, Chanwoo Choi пишет: > On Mon, Nov 2, 2020 at 12:49 AM Dmitry Osipenko wrote: >> >> 01.11.2020 18:44, Chanwoo Choi пишет: OPP core will try to grab the clock reference for the table and it may cause EPROBE_DEFER. Although, it shouldn't happen here because we have de

Re: [PATCH v2 0/4] drm/bridge: ti-sn65dsi86: Support EDID reading

2020-11-03 Thread Stephen Boyd
Quoting Stephen Boyd (2020-11-02 17:15:24) > Quoting Sam Ravnborg (2020-11-01 09:37:41) > > Hi Stephen. > > > > On Thu, Oct 29, 2020 at 06:17:34PM -0700, Stephen Boyd wrote: > > > This patch series cleans up the DDC code a little bit so that > > > it is more efficient time wise and supports grabbi

[PATCH] drm/msm: a5xx: Make preemption reset case reentrant

2020-11-03 Thread Marijn Suijten
nr_rings is reset to 1, but when this function is called for a second (and third!) time nr_rings > 1 is false, thus the else case is entered to set up a buffer for the RPTR shadow and consequently written to RB_RPTR_ADDR, hanging platforms without WHERE_AM_I firmware support. Restructure the condi

Re: [PATCH v2 1/4] drm/bridge: ti-sn65dsi86: Combine register accesses in ti_sn_aux_transfer()

2020-11-03 Thread Stephen Boyd
Quoting Doug Anderson (2020-11-02 08:18:47) > Hi, > > On Thu, Oct 29, 2020 at 6:17 PM Stephen Boyd wrote: > > > > These register reads and writes are sometimes directly next to each > > other in the register address space. Let's use regmap bulk read/write > > APIs to get the data with one transfe

[PATCH v3 1/4] drm/bridge: ti-sn65dsi86: Combine register accesses in ti_sn_aux_transfer()

2020-11-03 Thread Stephen Boyd
These register reads and writes are sometimes directly next to each other in the register address space. Let's use regmap bulk read/write APIs to get the data with one transfer instead of multiple i2c transfers. This helps cut down on the number of transfers in the case of something like reading an

[PATCH 5/6] drm/amdgpu/amdgpu: improve code indentation and alignment

2020-11-03 Thread Deepak R Varma
General code indentation and alignment changes such as replace spaces by tabs or align function arguments as per the coding style guidelines. The patch corrects issues for various amdgpu_*.c files for this driver. Issue reported by checkpatch script. Signed-off-by: Deepak R Varma --- drivers/gpu

[PATCH] drm/vc4: drv: Remove unused variable

2020-11-03 Thread Maxime Ripard
The commit dcda7c28bff2 ("drm/vc4: kms: Add functions to create the state objects") removed the last users of the vc4 variable, but didn't remove that variable resulting in a warning. Fixes: dcda7c28bff2 ("drm/vc4: kms: Add functions to create the state objects") Reported-by: Daniel Vetter Signed

Re: [PATCH v2 8/8] dma-buf: use krealloc_array()

2020-11-03 Thread Andy Shevchenko
On Mon, Nov 02, 2020 at 04:20:37PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Use the helper that checks for overflows internally instead of manually > calculating the size of the new array. ... > + nfences = krealloc_array(fences, i, > +

[PATCH 4/6] drm/amdgpu/sdma: use "*" adjacent to data name

2020-11-03 Thread Deepak R Varma
When declaring pointer data, the "*" symbol should be used adjacent to the data name as per the coding standards. This resolves following issues reported by checkpatch script: ERROR: "foo * bar" should be "foo *bar" ERROR: "foo * bar" should be "foo *bar" ERROR: "foo*

Re: [PATCH v2 3/4] drm/bridge: ti-sn65dsi86: Read EDID blob over DDC

2020-11-03 Thread Stephen Boyd
Quoting Doug Anderson (2020-11-02 08:06:14) > On Sun, Nov 1, 2020 at 11:21 AM Laurent Pinchart > wrote: > > On Thu, Oct 29, 2020 at 06:17:37PM -0700, Stephen Boyd wrote: > > > @@ -265,6 +267,23 @@ connector_to_ti_sn_bridge(struct drm_connector > > > *connector) > > > static int ti_sn_bridge_conn

[PATCH 0/5] Add option to mmap GEM buffers cached, try 2

2020-11-03 Thread Paul Cercueil
Rework of my previous patchset which added support for GEM buffers backed by non-coherent memory to the ingenic-drm driver. For the record, the previous patchset was accepted for 5.10 then had to be reverted, as it conflicted with some changes made to the DMA API. This new patchset is pretty diff

[PATCH 2/2] drm/drm_vblank: set the dma-fence timestamp during send_vblank_event

2020-11-03 Thread Veera Sundaram Sankaran
The explicit out-fences in crtc are signaled as part of vblank event, indicating all framebuffers present on the Atomic Commit request are scanned out on the screen. Though the fence signal and the vblank event notification happens at the same time, triggered by the same hardware vsync event, the t

[PATCH v2 7/8] hwtracing: intel: use krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski --- drivers/hwtracing/intel_th/msu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing

[PATCH 5/5] drm/ingenic: Add option to alloc cached GEM buffers

2020-11-03 Thread Paul Cercueil
With the module parameter ingenic-drm.cached_gem_buffers, it is possible to specify that we want GEM buffers backed by non-coherent memory. This dramatically speeds up software rendering on Ingenic SoCs, even for tasks where write-combine memory should in theory be faster (e.g. simple blits). Lea

[PATCH 1/2] dma-fence: allow signaling drivers to set fence timestamp

2020-11-03 Thread Veera Sundaram Sankaran
Some drivers have hardware capability to get the precise timestamp of certain events based on which the fences are triggered. This allows it to set accurate timestamp factoring out any software and IRQ latencies. Move the timestamp parameter out of union in dma_fence struct to allow signaling drive

[PATCH v2 4/8] pinctrl: use krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

Re: [PATCH v6 51/52] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree

2020-11-03 Thread Dmitry Osipenko
01.11.2020 18:44, Chanwoo Choi пишет: >>> I recommend that you use dev_pm_opp_of_get_opp_desc_node(&pdev->dev) >>> to check whether a device contains opp-table or not. >> I'm not sure what are the benefits, this will make code less >> expressive/readable and we will need to add extra of_node_put(),

[PATCH 1/6] drm/amdgpu/dce: improve code indentation and alignment

2020-11-03 Thread Deepak R Varma
General code indentation and alignment changes such as replace spaces by tabs or align function arguments as per the coding style guidelines. Issue reported by checkpatch script. Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v11_0

[PATCH 2/6] drm/amdgpu/umc: use "*" adjacent to data name

2020-11-03 Thread Deepak R Varma
When declaring pointer data, the "*" symbol should be used adjacent to the data name as per the coding standards. This resolves following issues reported by checkpatch script: ERROR: "foo * bar" should be "foo *bar" ERROR: "foo * bar" should be "foo *bar" ERROR: "foo*

[PATCH] drm/msm/dpu: enable DSPP support on SM8[12]50

2020-11-03 Thread Dmitry Baryshkov
Add support for color correction sub block on SM8150 and SM8250. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 26 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c | 3 +-- 2 files changed, 22 insertions(+), 7 deletions(-) diff --git a/dri

[PATCH v3 0/4] drm/bridge: ti-sn65dsi86: Support EDID reading

2020-11-03 Thread Stephen Boyd
This patch series cleans up the DDC code a little bit so that it is more efficient time wise and supports grabbing the EDID of the eDP panel over the aux channel. I timed this on a board I have on my desk and it takes about 20ms to grab the EDID out of the panel and make sure it is valid. The firs

Re: [Freedreno] [PATCH] drm/msm/dp: do not notify audio subsystem if sink doesn't support audio

2020-11-03 Thread Stephen Boyd
Quoting abhin...@codeaurora.org (2020-11-02 14:43:33) > Hi Stephen > > Thanks for the review. > > On 2020-11-02 13:19, Stephen Boyd wrote: > > Quoting Abhinav Kumar (2020-10-29 13:55:09) > >> For sinks that do not support audio, there is no need to notify > >> audio subsystem of the connection ev

Re: [PATCH] drm/msm/dpu: fix clock scaling on non-sc7180 board

2020-11-03 Thread Bjorn Andersson
On Tue 27 Oct 05:23 CDT 2020, Dmitry Baryshkov wrote: > c33b7c0389e1 ("drm/msm/dpu: add support for clk and bw scaling for > display") has added support for handling bandwidth voting in kms path in > addition to old mdss path. However this broke all other platforms since > _dpu_core_perf_crtc_upda

[PATCH] Revert "drm/dp_mst: Retrieve extended DPCD caps for topology manager"

2020-11-03 Thread Koba Ko
This reverts commit ad44c03208e46b83e4ae3269e32c9e524aa71cf8. Currently DRM driver assume the source device caps is higher than the MST device caps. With this commit, this statement would be broken. e.g. the source device only support DP1.2 and the mst device support DP1.4. Signed-off-by: Koba K

[PATCH v2 2/8] ALSA: pcm: use krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski Reviewed-by: Takashi Iwai --- sound/core/pcm_lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 6/8] drm: atomic: use krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski Acked-by: Daniel Vetter --- drivers/gpu/drm/drm_atomic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --

[PATCH v3 3/4] drm/bridge: ti-sn65dsi86: Read EDID blob over DDC

2020-11-03 Thread Stephen Boyd
Use the DDC connection to read the EDID from the eDP panel instead of relying on the panel to tell us the modes. Reviewed-by: Douglas Anderson Reviewed-by: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: Sean Paul Acked-by: Sam Ravnborg Signed-off-by: Stephen Boyd --- drivers/gpu

Re: [PATCH v2] drm/msm/dp: skip checking LINK_STATUS_UPDATED bit

2020-11-03 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-10-30 16:23:10) > Some dongle will not clear LINK_STATUS_UPDATED bit after > DPCD read which cause link training failed. This patch $ git grep 'this patch' -- Documentation/process/submitting-patches.rst > just read 6 bytes of DPCD link status from sink and return > wit

Re: [PATCH] drm/msm/dp: promote irq_hpd handle to handle link trainign correctly

2020-11-03 Thread Stephen Boyd
Subject has a typo in "training". Quoting Kuogee Hsieh (2020-10-30 16:23:24) > Some dongles, such as Apple, required link training done at irq_hpd s/required/require/ > request instead of plugin request. This patch promote irq_hpd hanlder s/hanlder/handler/ > to handle link training and setup

[PATCH 3/6] drm/amdgpu/jpeg: use "*" adjacent to data name

2020-11-03 Thread Deepak R Varma
When declaring pointer data, the "*" symbol should be used adjacent to the data name as per the coding standards. This resolves following issues reported by checkpatch script: ERROR: "foo * bar" should be "foo *bar" ERROR: "foo * bar" should be "foo *bar" ERROR: "foo*

Re: [PATCH/RFC v2] video: fbdev: atari: Fix TT High video mode

2020-11-03 Thread Michael Schmitz
Hi Geert, On 2/11/20 9:39 PM, Geert Uytterhoeven wrote: Hi Andreas, On Sun, Nov 1, 2020 at 1:47 PM Andreas Schwab wrote: On Nov 01 2020, Sam Ravnborg wrote: On Sun, Nov 01, 2020 at 11:29:41AM +0100, Geert Uytterhoeven wrote: The horizontal resolution (640) for the TT High video mode (1280x9

Re: [PATCH v5 08/15] mm: Add unsafe_follow_pfn

2020-11-03 Thread Jason Gunthorpe
On Mon, Nov 02, 2020 at 02:23:58PM +0100, Daniel Vetter wrote: > On Mon, Nov 2, 2020 at 2:01 PM Jason Gunthorpe wrote: > > > > On Mon, Nov 02, 2020 at 01:56:10PM +0100, Daniel Vetter wrote: > > > On Mon, Nov 2, 2020 at 8:29 AM Christoph Hellwig > > > wrote: > > > > > > > > On Fri, Oct 30, 2020 a

[PATCH 3/5] drm: Add and export function drm_gem_cma_mmap_noncoherent

2020-11-03 Thread Paul Cercueil
This function can be used by drivers that need to mmap dumb buffers created with non-coherent backing memory. Signed-off-by: Paul Cercueil --- drivers/gpu/drm/drm_gem_cma_helper.c | 39 include/drm/drm_gem_cma_helper.h | 2 ++ 2 files changed, 41 insertions(+)

[PATCH] drivers: drm: fix msm_drv.h warning

2020-11-03 Thread dev god
Hi fix implicit declaration of function error. >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1229:7: error: implicit declaration of function 'msm_dp_display_pre_disable' [-Werror,-Wimplicit-function-declaration] if (msm_dp_display_pre_disable(priv->dp, drm_enc))

[PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL

2020-11-03 Thread Deepak R Varma
Initializing global variable to 0 or NULL is not necessary and should be avoided. Issue reported by checkpatch script as: ERROR: do not initialise globals to 0 (or NULL). Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 46 - drivers/gpu/drm/amd

Re: [PATCH 1/2] dt-bindings: drm/bridge: ti-sn65dsi86: Replace #pwm-cells

2020-11-03 Thread Bjorn Andersson
On Fri 02 Oct 15:42 CDT 2020, Doug Anderson wrote: > Hi, > > On Wed, Sep 30, 2020 at 3:40 PM Bjorn Andersson > wrote: > > > > While the signal on GPIO4 to drive the backlight controller indeed is > > pulse width modulated its purpose is specifically to control the > > brightness of a backlight.

[PATCH 6/6] drm/amdgpu: use "*" adjacent to data name

2020-11-03 Thread Deepak R Varma
When declaring pointer data, the "*" symbol should be used adjacent to the data name as per the coding standards. This resolves following issues reported by checkpatch script: ERROR: "foo * bar" should be "foo *bar" ERROR: "foo * bar" should be "foo *bar" ERROR: "foo*

[PATCH] drm/panfrost: Replace devm_reset_control_array_get()

2020-11-03 Thread Yejune Deng
devm_reset_control_array_get_optional_exclusive() looks more readable Signed-off-by: Yejune Deng --- drivers/gpu/drm/panfrost/panfrost_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_devi

[PATCH v3 2/4] drm/bridge: ti-sn65dsi86: Make polling a busy loop

2020-11-03 Thread Stephen Boyd
There's no reason we need to wait here to poll a register over i2c. The i2c bus is inherently slow and delays are practically part of the protocol because we have to wait for the device to respond to any request for a register. Let's rely on the sleeping of the i2c controller instead of adding any

[PATCH 1/6] drm/amdgpu/vcn: use "*" adjacent to data name

2020-11-03 Thread Deepak R Varma
When declaring pointer data, the "*" symbol should be used adjacent to the data name as per the coding style standards. This resolves following issues reported by checkpatch script: ERROR: "foo * bar" should be "foo *bar" ERROR: "foo * bar" should be "foo *bar" ERROR: "foo

[PATCH] drm: Add the new api to install irq

2020-11-03 Thread Tian Tao
Add new api devm_drm_irq_install() to register interrupts, no need to call drm_irq_uninstall() when the drm module is removed. Signed-off-by: Tian Tao --- drivers/gpu/drm/drm_drv.c | 23 +++ include/drm/drm_drv.h | 3 ++- 2 files changed, 25 insertions(+), 1 deletion(-)

Re: [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-11-03 Thread Viresh Kumar
On 27-10-20, 17:05, Viresh Kumar wrote: > It isn't that straight forward unfortunately, we need to make sure the > table doesn't get allocated for the same device twice, so > find+allocate needs to happen within a locked region. > > I have taken, not so straight forward, approach to fixing this is

Re: [PATCH v3 3/3] backlight: pwm_bl: Fix interpolation

2020-11-03 Thread Alexandru M Stan
On Wed, Oct 28, 2020 at 8:12 AM Daniel Thompson wrote: > > On Wed, Oct 21, 2020 at 10:04:45PM -0700, Alexandru Stan wrote: > > The previous behavior was a little unexpected, its properties/problems: > > 1. It was designed to generate strictly increasing values (no repeats) > > 2. It had quantizati

[PATCH v2 8/8] dma-buf: use krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski Acked-by: Christian König --- drivers/dma-buf/sync_file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 3/6] drm/amdgpu/vcn: improve code indentation and alignment

2020-11-03 Thread Deepak R Varma
General code indentation and alignment changes such as replace spaces by tabs or align function arguments as per the coding style guidelines. Issue reported by checkpatch script. Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/vcn_v2_5.

Re: [PATCH v2 1/8] mm: slab: provide krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
On Mon, Nov 2, 2020 at 4:41 PM Matthew Wilcox wrote: > > On Mon, Nov 02, 2020 at 04:20:30PM +0100, Bartosz Golaszewski wrote: > > +Chunks allocated with `kmalloc` can be resized with `krealloc`. Similarly > > +to `kmalloc_array`: a helper for resising arrays is provided in the form of > > +`kreall

Re: [PATCH v6 49/52] PM / devfreq: tegra20: Convert to EMC_STAT driver, support interconnect and device-tree

2020-11-03 Thread Dmitry Osipenko
01.11.2020 17:12, Dmitry Osipenko пишет: ... > We will probably move the Tegra20 EMC_STAT devfreq driver into the > memory driver and remove the older IMC_STAT driver in v7, like it was > suggested by Thierry Reding. This will be a much less invasive code change. > >> Also, if you want to get more

[PATCH v2] drm: Add the new api to install irq

2020-11-03 Thread Tian Tao
Add new api devm_drm_irq_install() to register interrupts, no need to call drm_irq_uninstall() when the drm module is removed. v2: fixed the wrong parameter. Signed-off-by: Tian Tao --- drivers/gpu/drm/drm_drv.c | 23 +++ include/drm/drm_drv.h | 3 ++- 2 files changed,

[PATCH 2/5] drm: Add and export function drm_gem_cma_dumb_create_noncoherent

2020-11-03 Thread Paul Cercueil
This function can be used by drivers to create dumb buffers with non-coherent backing memory. Signed-off-by: Paul Cercueil --- drivers/gpu/drm/drm_gem_cma_helper.c | 37 +--- include/drm/drm_gem_cma_helper.h | 4 +++ 2 files changed, 37 insertions(+), 4 deletions(-)

[PATCH 5/6] drm/amdgpu/amdgpu: use "*" adjacent to data name

2020-11-03 Thread Deepak R Varma
When declaring pointer data, the "*" symbol should be used adjacent to the data name as per the coding standards. This resolves following issues reported by checkpatch script: ERROR: "foo * bar" should be "foo *bar" ERROR: "foo * bar" should be "foo *bar" ERROR: "foo*

Re: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL

2020-11-03 Thread Christian König
Am 03.11.20 um 08:53 schrieb Greg KH: On Mon, Nov 02, 2020 at 09:48:25PM +0100, Christian König wrote: Am 03.11.20 um 07:53 schrieb Greg KH: On Mon, Nov 02, 2020 at 09:06:21PM +0100, Christian König wrote: Am 02.11.20 um 20:43 schrieb Alex Deucher: On Mon, Nov 2, 2020 at 1:42 PM Deepak R Varm

Re: [PATCH] drm/panfrost: Fix module unload

2020-11-03 Thread Tomeu Vizoso
Looks good, thanks! Reviewed-by: Tomeu Vizoso On Fri, 30 Oct 2020 at 15:59, Steven Price wrote: > When unloading the call to pm_runtime_put_sync_suspend() will attempt to > turn the GPU cores off, however panfrost_device_fini() will have turned > the clocks off. This leads to the hardware lock

Re: [PATCH v7 0/6] Exynos: Simple QoS for exynos-bus using interconnect

2020-11-03 Thread Chanwoo Choi
Hi Georgi, On 11/3/20 5:29 PM, Georgi Djakov wrote: > Hi Chanwoo and Sylwester, > > On 11/3/20 09:54, Chanwoo Choi wrote: >> Hi Sylwester, >> >> When I tested this patchset on Odroid-U3, >> After setting 0 bps by interconnect[1][2], >> the frequency of devfreq devs sustain the high frequency >> a

Re: [PATCH] drm/panfrost: Fix module unload

2020-11-03 Thread Boris Brezillon
On Fri, 30 Oct 2020 14:58:33 + Steven Price wrote: > When unloading the call to pm_runtime_put_sync_suspend() will attempt to > turn the GPU cores off, however panfrost_device_fini() will have turned > the clocks off. This leads to the hardware locking up. > > Instead don't call pm_runtime_p

Re: [PATCH] drm/panfrost: Fix a deadlock between the shrinker and madvise path

2020-11-03 Thread Boris Brezillon
On Mon, 2 Nov 2020 08:42:49 + Steven Price wrote: > On 01/11/2020 17:40, Boris Brezillon wrote: > > panfrost_ioctl_madvise() and panfrost_gem_purge() acquire the mappings > > and shmem locks in different orders, thus leading to a potential > > the mappings lock first. > > > > Fixes: bdefca2d

Re: [PATCH] drm/panfrost: Remove unused variables in panfrost_job_close()

2020-11-03 Thread Boris Brezillon
On Mon, 2 Nov 2020 08:39:29 + Steven Price wrote: > On 01/11/2020 17:38, Boris Brezillon wrote: > > Commit a17d609e3e21 ("drm/panfrost: Don't corrupt the queue mutex on > > open/close") left unused variables behind, thus generating a warning > > at compilation time. Remove those variables. >

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-03 Thread Thomas Zimmermann
Hi Am 03.11.20 um 09:57 schrieb tiantao (H): > > > 在 2020/11/3 15:56, Thomas Zimmermann 写道: >> Hi >> >> Thanks, the code looks good already. There just are a few nits below. >> > Thanks for the help with the review code. > Add the new api devm_drm_irq_install and himbc use the new interface as >

Re: [PATCH v7 2/6] interconnect: Add generic interconnect driver for Exynos SoCs

2020-11-03 Thread Chanwoo Choi
Hi Sylwester, On 10/30/20 9:51 PM, Sylwester Nawrocki wrote: > This patch adds a generic interconnect driver for Exynos SoCs in order > to provide interconnect functionality for each "samsung,exynos-bus" > compatible device. > > The SoC topology is a graph (or more specifically, a tree) and its >

Re: [PATCH v7 1/6] dt-bindings: devfreq: Add documentation for the interconnect properties

2020-11-03 Thread Chanwoo Choi
Hi Sylwester, This patch contains one typo. On 10/30/20 9:51 PM, Sylwester Nawrocki wrote: > Add documentation for new optional properties in the exynos bus nodes: > interconnects, #interconnect-cells, samsung,data-clock-ratio. > These properties allow to specify the SoC interconnect structure wh

[PATCH v7 01/10] drm/vram-helper: Remove invariant parameters from internal kmap function

2020-11-03 Thread Thomas Zimmermann
The parameters map and is_iomem are always of the same value. Removed them to prepares the function for conversion to struct dma_buf_map. v4: * don't check for !kmap->virtual; will always be false Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Reviewed-by: Christian König

[PATCH v7 05/10] drm/ttm: Add vmap/vunmap to TTM and TTM GEM helpers

2020-11-03 Thread Thomas Zimmermann
The new functions ttm_bo_{vmap,vunmap}() map and unmap a TTM BO in kernel address space. The mapping's address is returned as struct dma_buf_map. Each function is a simplified version of TTM's existing kmap code. Both functions respect the memory's location ani/or writecombine flags. On top TTM's

[PATCH v7 00/10] Support GEM object mappings from I/O memory

2020-11-03 Thread Thomas Zimmermann
DRM's fbdev console uses regular load and store operations to update framebuffer memory. The bochs driver on sparc64 requires the use of I/O-specific load and store operations. We have a workaround, but need a long-term solution to the problem. This patchset changes GEM's vmap/vunmap interfaces to

[PATCH v7 03/10] drm/etnaviv: Remove empty etnaviv_gem_prime_vunmap()

2020-11-03 Thread Thomas Zimmermann
The function etnaviv_gem_prime_vunmap() is empty. Remove it before changing the interface to use struct drm_buf_map. Signed-off-by: Thomas Zimmermann Acked-by: Christian König Tested-by: Sam Ravnborg --- drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1 - drivers/gpu/drm/etnaviv/etnaviv_gem.c

[PATCH v7 06/10] drm/gem: Use struct dma_buf_map in GEM vmap ops and convert GEM backends

2020-11-03 Thread Thomas Zimmermann
This patch replaces the vmap/vunmap's use of raw pointers in GEM object functions with instances of struct dma_buf_map. GEM backends are converted as well. For most of them, this simply changes the returned type. TTM-based drivers now return information about the location of the memory, either sys

[PATCH v7 04/10] drm/exynos: Remove empty exynos_drm_gem_prime_{vmap, vunmap}()

2020-11-03 Thread Thomas Zimmermann
The functions exynos_drm_gem_prime_{vmap,vunmap}() are empty. Remove them before changing the interface to use struct drm_buf_map. As a side effect of removing drm_gem_prime_vmap(), the error code changes from ENOMEM to EOPNOTSUPP. Signed-off-by: Thomas Zimmermann Acked-by: Christian König Teste

[PATCH v7 02/10] drm/cma-helper: Remove empty drm_gem_cma_prime_vunmap()

2020-11-03 Thread Thomas Zimmermann
The function drm_gem_cma_prime_vunmap() is empty. Remove it before changing the interface to use struct drm_buf_map. Signed-off-by: Thomas Zimmermann Reviewed-by: Christian König Tested-by: Sam Ravnborg --- drivers/gpu/drm/drm_gem_cma_helper.c | 17 - drivers/gpu/drm/vc4/vc4_bo

[PATCH v7 09/10] dma-buf-map: Add memcpy and pointer-increment interfaces

2020-11-03 Thread Thomas Zimmermann
To do framebuffer updates, one needs memcpy from system memory and a pointer-increment function. Add both interfaces with documentation. v5: * include to build on sparc64 (Sam) Signed-off-by: Thomas Zimmermann Reviewed-by: Sam Ravnborg Tested-by: Sam Ravnborg --- include/linux/dma-bu

[PATCH v7 08/10] drm/gem: Store client buffer mappings as struct dma_buf_map

2020-11-03 Thread Thomas Zimmermann
Kernel DRM clients now store their framebuffer address in an instance of struct dma_buf_map. Depending on the buffer's location, the address refers to system or I/O memory. Callers of drm_client_buffer_vmap() receive a copy of the value in the call's supplied arguments. It can be accessed and modi

[PATCH v7 10/10] drm/fb_helper: Support framebuffers in I/O memory

2020-11-03 Thread Thomas Zimmermann
At least sparc64 requires I/O-specific access to framebuffers. This patch updates the fbdev console accordingly. For drivers with direct access to the framebuffer memory, the callback functions in struct fb_ops test for the type of memory and call the rsp fb_sys_ of fb_cfb_ functions. Read and wri

[PATCH v7 07/10] drm/gem: Update internal GEM vmap/vunmap interfaces to use struct dma_buf_map

2020-11-03 Thread Thomas Zimmermann
GEM's vmap and vunmap interfaces now wrap memory pointers in struct dma_buf_map. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Tested-by: Sam Ravnborg --- drivers/gpu/drm/drm_client.c | 18 +++--- drivers/gpu/drm/drm_gem.c | 26 +- drive

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-03 Thread Sam Ravnborg
Hi Tian. Good to see more infrastructure support so one does not have to think about cleanup. On Tue, Nov 03, 2020 at 10:10:41AM +0800, Tian Tao wrote: > Add new api devm_drm_irq_install() to register interrupts, > no need to call drm_irq_uninstall() when the drm module is removed. > > v2: > fi

Re: [PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-11-03 Thread Neil Armstrong
On 03/11/2020 03:02, Rob Herring wrote: > On Mon, Nov 2, 2020 at 10:38 AM Neil Armstrong > wrote: >> >> On 02/11/2020 16:16, Rob Herring wrote: >>> On Fri, Oct 30, 2020 at 4:15 PM Sam Ravnborg wrote: Hi Neil. On Fri, Oct 30, 2020 at 09:31:36AM +0100, Neil Armstrong wrote: >>>

Re: [PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-11-03 Thread Neil Armstrong
On 02/11/2020 19:04, Sam Ravnborg wrote: > Hi Neil. > >>> --- >>> .../bindings/display/intel,keembay-display.yaml| 75 >>> ++ >>> 1 file changed, 75 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/display/intel,keembay-

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-03 Thread Thomas Zimmermann
Hi Am 03.11.20 um 10:52 schrieb Maxime Ripard: > On Tue, Nov 03, 2020 at 10:10:41AM +0800, Tian Tao wrote: >> Add new api devm_drm_irq_install() to register interrupts, >> no need to call drm_irq_uninstall() when the drm module is removed. >> >> v2: >> fixed the wrong parameter. >> >> Signed-off-b

Re: [resource] 22b17dc667: Kernel panic - not syncing: Fatal exception

2020-11-03 Thread Daniel Vetter
On Mon, Nov 02, 2020 at 10:15:40PM -0800, John Hubbard wrote: > On 11/2/20 10:06 PM, lkp wrote: > > Greeting, > > > > FYI, we noticed the following commit (built with gcc-9): > > > > commit: 22b17dc667d36418ccabb9c668c4b489185fb40a ("[PATCH v5 13/15] > > resource: Move devmem revoke code to reso

Re: [PATCH v7 0/6] Exynos: Simple QoS for exynos-bus using interconnect

2020-11-03 Thread Sylwester Nawrocki
Hi Chanwoo, Georgi On 03.11.2020 09:53, Chanwoo Choi wrote: > On 11/3/20 5:29 PM, Georgi Djakov wrote: >> On 11/3/20 09:54, Chanwoo Choi wrote: >>> When I tested this patchset on Odroid-U3, >>> After setting 0 bps by interconnect[1][2], >>> the frequency of devfreq devs sustain the high frequency

Re: [PATCH 5/5] drm/ingenic: Add option to alloc cached GEM buffers

2020-11-03 Thread Daniel Vetter
On Mon, Nov 02, 2020 at 10:06:51PM +, Paul Cercueil wrote: > With the module parameter ingenic-drm.cached_gem_buffers, it is possible > to specify that we want GEM buffers backed by non-coherent memory. > > This dramatically speeds up software rendering on Ingenic SoCs, even for > tasks where

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-03 Thread Daniel Vetter
On Tue, Nov 03, 2020 at 10:10:41AM +0800, Tian Tao wrote: > Add new api devm_drm_irq_install() to register interrupts, > no need to call drm_irq_uninstall() when the drm module is removed. > > v2: > fixed the wrong parameter. > > Signed-off-by: Tian Tao > --- > drivers/gpu/drm/drm_drv.c | 23 ++

Re: [PATCH v7 0/6] Exynos: Simple QoS for exynos-bus using interconnect

2020-11-03 Thread Chanwoo Choi
Hi Sylwester, On 11/3/20 7:12 PM, Sylwester Nawrocki wrote: > Hi Chanwoo, Georgi > > On 03.11.2020 09:53, Chanwoo Choi wrote: >> On 11/3/20 5:29 PM, Georgi Djakov wrote: >>> On 11/3/20 09:54, Chanwoo Choi wrote: > When I tested this patchset on Odroid-U3, After setting 0 bps by interco

  1   2   3   >