Re: [PATCH] RDMA: Fix software RDMA drivers for dma mapping error

2020-10-28 Thread kernel test robot
Hi Parav, Thank you for the patch! Yet something to improve: [auto build test ERROR on rdma/for-next] [also build test ERROR on v5.10-rc1 next-20201028] [cannot apply to hch-configfs/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH v6 46/52] opp: Put interconnect paths outside of opp_table_lock

2020-10-28 Thread Viresh Kumar
On 27-10-20, 23:26, Dmitry Osipenko wrote: > 27.10.2020 08:10, Viresh Kumar пишет: > > On 26-10-20, 01:17, Dmitry Osipenko wrote: > >> This patch fixes lockup which happens when OPP table is released if > >> interconnect provider uses OPP in the icc_provider->set() callback > >> and bandwidth of th

[PATCH 3/8] vhost: vringh: use krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski --- drivers/vhost/vringh.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/vringh.c b/

Re: [PATCH v6 1/4] RDMA/umem: Support importing dma-buf as user memory region

2020-10-28 Thread Jason Gunthorpe
On Fri, Oct 23, 2020 at 09:39:58AM -0700, Jianxin Xiong wrote: > +/* > + * Generate a new dma sg list from a sub range of an existing dma sg list. > + * Both the input and output have their entries page aligned. > + */ > +static int ib_umem_dmabuf_sgt_slice(struct sg_table *sgt, u64 offset, > +

[PATCH 5/8] edac: ghes: use krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski --- drivers/edac/ghes_edac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/edac/ghes_eda

[PATCH 7/8] hwtracing: intel: use krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski --- drivers/hwtracing/intel_th/msu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing

Re: [PATCH] drm/vc4: hdmi: Avoid sleeping in atomic context

2020-10-28 Thread Maxime Ripard
On Tue, Oct 27, 2020 at 11:15:58AM +0100, Maxime Ripard wrote: > When running the trigger hook, ALSA by default will take a spinlock, and > thus will run the trigger hook in atomic context. > > However, our HDMI driver will send the infoframes as part of the trigger > hook, and part of that proces

RE: WARNING in dma_map_page_attrs

2020-10-28 Thread Parav Pandit
> From: h...@lst.de > Sent: Tuesday, October 27, 2020 1:41 PM > > On Mon, Oct 26, 2020 at 05:23:48AM +, Parav Pandit wrote: > > Hi Christoph, > > > > > From: Jakub Kicinski > > > Sent: Saturday, October 24, 2020 11:45 PM > > > > > > CC: rdma, looks like rdma from the stack trace > > > > >

[PATCH] drm/msm/dpu: fix clock scaling on non-sc7180 board

2020-10-28 Thread Dmitry Baryshkov
c33b7c0389e1 ("drm/msm/dpu: add support for clk and bw scaling for display") has added support for handling bandwidth voting in kms path in addition to old mdss path. However this broke all other platforms since _dpu_core_perf_crtc_update_bus() will now error out instead of properly calculating ban

Re: [PATCH v6 41/52] memory: tegra124-emc: Use devm_platform_ioremap_resource()

2020-10-28 Thread Dmitry Osipenko
27.10.2020 13:27, Krzysztof Kozlowski пишет: > On Mon, Oct 26, 2020 at 01:17:24AM +0300, Dmitry Osipenko wrote: >> Use devm_platform_ioremap_resource() helper which makes code a bit >> cleaner. > > Such cleanups (and few other in this patchset) should be at beginning of > patchset or even as part

Re: [PATCH v6 29/52] memory: tegra-mc: Add interconnect framework

2020-10-28 Thread Dmitry Osipenko
27.10.2020 16:48, Thierry Reding пишет: ... >> +static struct icc_node_data * >> +tegra_mc_of_icc_xlate_extended(struct of_phandle_args *spec, void *data) >> +{ >> +struct icc_provider *provider = data; >> +unsigned int idx = spec->args[0]; >> +struct icc_node_data *ndata; >> +struc

Re: [PATCH v6 4/4] RDMA/mlx5: Support dma-buf based userspace memory region

2020-10-28 Thread Jason Gunthorpe
On Fri, Oct 23, 2020 at 09:40:01AM -0700, Jianxin Xiong wrote: > diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c > index b261797..3bc412b 100644 > +++ b/drivers/infiniband/hw/mlx5/mr.c > @@ -1,5 +1,6 @@ > /* > * Copyright (c) 2013-2015, Mellanox Technologies. All

Re: [PATCH v6 22/52] ARM: tegra: Add interconnect properties to Tegra30 device-tree

2020-10-28 Thread Dmitry Osipenko
27.10.2020 12:15, Krzysztof Kozlowski пишет: ...>> @@ -748,15 +770,18 @@ mc: memory-controller@7000f000 { >> >> #iommu-cells = <1>; >> #reset-cells = <1>; >> +#interconnect-cells = <1>; >> }; >> >> -memory-controller@7000f400 { >> +emc: memory-

Re: [PATCH v6 04/52] dt-bindings: memory: tegra20: emc: Document nvidia,memory-controller property

2020-10-28 Thread Dmitry Osipenko
27.10.2020 11:54, Krzysztof Kozlowski пишет: > On Mon, Oct 26, 2020 at 01:16:47AM +0300, Dmitry Osipenko wrote: >> Tegra20 External Memory Controller talks to DRAM chips and it needs to be >> reprogrammed when memory frequency changes. Tegra Memory Controller sits >> behind EMC and these controller

[PATCH -next] drm/tilcdc: fix platform_no_drv_owner.cocci warnings

2020-10-28 Thread Zou Wei
./drivers/gpu/drm/tilcdc/tilcdc_panel.c:402:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Fixes: 0d4bbaf9f3e5 ("drm/tilcdc: add support for LCD panels (v5)"

[PATCH 6/8] drm: atomic: use krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski --- drivers/gpu/drm/drm_atomic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm

Re: [PATCH v6 33/52] memory: tegra20: Support interconnect framework

2020-10-28 Thread Dmitry Osipenko
27.10.2020 17:11, Thierry Reding пишет: ... >> +static int emc_icc_set(struct icc_node *src, struct icc_node *dst) >> +{ >> +struct tegra_emc *emc = to_tegra_emc_provider(dst->provider); >> +unsigned long long peak_bw = icc_units_to_bps(dst->peak_bw); >> +unsigned long long avg_bw = icc

Re: [PATCH v6 32/52] memory: tegra20-emc: Continue probing if timings are missing in device-tree

2020-10-28 Thread Dmitry Osipenko
27.10.2020 16:52, Thierry Reding пишет: > On Mon, Oct 26, 2020 at 01:17:15AM +0300, Dmitry Osipenko wrote: >> EMC driver will become mandatory after turning it into interconnect >> provider because interconnect users, like display controller driver, will >> fail to probe using newer device-trees th

[PATCH 4/8] pinctrl: use krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pi

Re:Re: Re: [PATCH] gpu/drm/mgag200:remove break after return

2020-10-28 Thread Bernard
From: Sam Ravnborg Date: 2020-10-25 01:14:57 To: Bernard Cc: Thomas Zimmermann ,opensource.ker...@vivo.com,David Airlie ,linux-ker...@vger.kernel.org,dri-devel@lists.freedesktop.org,Dave Airlie Subject: Re: Re: [PATCH] gpu/drm/mgag200:remove break after return>Hi Bernard. > >On Fri, Oct 23

Re: [PATCH v6 00/52] Introduce memory interconnect for NVIDIA Tegra SoCs

2020-10-28 Thread Dmitry Osipenko
27.10.2020 11:52, Krzysztof Kozlowski пишет: > On Mon, Oct 26, 2020 at 10:14:10PM +0300, Dmitry Osipenko wrote: >> 26.10.2020 18:08, Krzysztof Kozlowski пишет: >>> On Mon, Oct 26, 2020 at 01:16:43AM +0300, Dmitry Osipenko wrote: Hello, This series brings initial support for memory in

Re: [PATCH v6 13/52] dt-bindings: memory: tegra124: emc: Document new interconnect property

2020-10-28 Thread Dmitry Osipenko
27.10.2020 13:25, Krzysztof Kozlowski пишет: > On Mon, Oct 26, 2020 at 01:16:56AM +0300, Dmitry Osipenko wrote: >> External memory controller is interconnected with memory controller and >> with external memory. Document new interconnect property which turns >> External Memory Controller into inter

Re: [PATCH v6 33/52] memory: tegra20: Support interconnect framework

2020-10-28 Thread Dmitry Osipenko
27.10.2020 13:09, Krzysztof Kozlowski пишет: ... >> +err_msg: >> +dev_err(emc->dev, "failed to initialize ICC: %d\n", err); > > You will print such errors on all existing DTBs. Since it is not a > failure of probe (it is actually quite expected, normal situation when > booting with older DTB),

Re: [PATCH 1/1] drm/vc4: drv: Add error handding for bind

2020-10-28 Thread Maxime Ripard
Hi, On Tue, Oct 27, 2020 at 01:14:42PM +0900, Hoegeun Kwon wrote: > There is a problem that if vc4_drm bind fails, a memory leak occurs on > the drm_property_create side. Add error handding for drm_mode_config. > > Signed-off-by: Hoegeun Kwon Applied, thanks! Maxime signature.asc Description:

Re: [PATCH 1/1] video: fbdev: fix divide error in fbcon_switch

2020-10-28 Thread Saeed Mirzamohammadi
Hi Greg, Sorry for the confusion. I’m requesting stable maintainers to cherry-pick this patch into stable 5.4 and 5.8. I’ll be more explicit. Commit: cc07057c7c88fb8eff3b1991131ded0f0bcfa7e3 ("video: fbdev: fix divide error in fbcon_pswitch”) Thanks, Saeed > On Oct 26, 2020, at 11:22 PM, Greg

Re: [PATCH v6 05/52] dt-bindings: memory: tegra20: mc: Document new interconnect property

2020-10-28 Thread Dmitry Osipenko
27.10.2020 11:55, Krzysztof Kozlowski пишет: > On Mon, Oct 26, 2020 at 01:16:48AM +0300, Dmitry Osipenko wrote: >> Memory controller is interconnected with memory clients and with the >> External Memory Controller. Document new interconnect property which >> turns memory controller into interconnec

Re: [PATCH 3/8] vhost: vringh: use krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
On Tue, Oct 27, 2020 at 5:50 PM Joe Perches wrote: > > On Tue, 2020-10-27 at 11:28 -0400, Michael S. Tsirkin wrote: > > On Tue, Oct 27, 2020 at 01:17:20PM +0100, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > Use the helper that checks for overflows internally instead of m

Re: [PATCH] drm/msm/a6xx: Add support for using system cache on MMU500 based targets

2020-10-28 Thread Sai Prakash Ranjan
On 2020-10-27 21:10, Robin Murphy wrote: On 2020-10-26 18:54, Jordan Crouse wrote: This is an extension to the series [1] to enable the System Cache (LLC) for Adreno a6xx targets. GPU targets with an MMU-500 attached have a slightly different process for enabling system cache. Use the compat

[PATCH 8/8] dma-buf: use krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski --- drivers/dma-buf/sync_file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma-buf/sy

Re: [PATCH v2 5/5] drm/mediatek: Add support for main DDP path on MT8167

2020-10-28 Thread Fabien Parent
Hi Chun-Kuang, On Fri, Oct 23, 2020 at 5:52 PM Chun-Kuang Hu wrote: > > Hi, Fabien: > > Fabien Parent 於 2020年10月23日 週五 下午9:31寫道: > > > > Add the main (DSI) drm display path for MT8167. > > > > Signed-off-by: Fabien Parent > > --- > > > > Changelog: > > > > V2: No change > > > > drivers/gpu/drm

Re: [PATCH v6 08/52] dt-bindings: memory: tegra20: emc: Document mfd-simple compatible and statistics sub-device

2020-10-28 Thread Dmitry Osipenko
27.10.2020 12:02, Krzysztof Kozlowski пишет: >> @@ -31,17 +32,34 @@ Example: >> ... >> }; >> >> +emc_bw_dfs_opp_table: emc_opp_table1 { > Hyphens for node name. We already use underscores for the Tegra CPU OPP table. https://elixir.bootlin.com/linux/v5.10-rc1/source/arch/a

Re: [PATCH v6 20/52] ARM: tegra: Correct EMC registers size in Tegra20 device-tree

2020-10-28 Thread Dmitry Osipenko
27.10.2020 12:10, Krzysztof Kozlowski пишет: > On Mon, Oct 26, 2020 at 01:17:03AM +0300, Dmitry Osipenko wrote: >> The Tegra20 EMC registers size should be twice bigger. This patch fixes >> the size. > > Don't use "This patch" (this appears here). Better to use: > "Fix the size of ..." or just "Th

Re: [PATCH v6 04/52] dt-bindings: memory: tegra20: emc: Document nvidia,memory-controller property

2020-10-28 Thread Dmitry Osipenko
27.10.2020 22:30, Krzysztof Kozlowski пишет: > On Tue, Oct 27, 2020 at 10:17:19PM +0300, Dmitry Osipenko wrote: >> 27.10.2020 11:54, Krzysztof Kozlowski пишет: >>> On Mon, Oct 26, 2020 at 01:16:47AM +0300, Dmitry Osipenko wrote: Tegra20 External Memory Controller talks to DRAM chips and it nee

[PATCH 2/8] ALSA: pcm: use krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the helper that checks for overflows internally instead of manually calculating the size of the new array. Signed-off-by: Bartosz Golaszewski --- sound/core/pcm_lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/core/pcm_lib.c b/so

[PATCH 0/8] slab: provide and use krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Andy brought to my attention the fact that users allocating an array of equally sized elements should check if the size multiplication doesn't overflow. This is why we have helpers like kmalloc_array(). However we don't have krealloc_array() equivalent and there are man

Re: [PATCH v3 19/20] drm/tegra: Implement new UAPI

2020-10-28 Thread Dmitry Osipenko
26.10.2020 12:11, Mikko Perttunen пишет: >> >> The first patches should be the ones that are relevant to the existing >> userspace code, like support for the waits. > > Can you elaborate what you mean by this? All features that don't have an immediate real use-case should be placed later in the s

Re: [PATCH 1/1] video: fbdev: fix divide error in fbcon_switch

2020-10-28 Thread Saeed Mirzamohammadi
Hi Greg, Sorry for the confusion. I’m requesting stable maintainers to cherry-pick this patch into stable 5.4 and 5.8. I’ll be more explicit. Commit: cc07057c7c88fb8eff3b1991131ded0f0bcfa7e3 ("video: fbdev: fix divide error in fbcon_pswitch”) Thanks, Saeed > On Oct 26, 2020, at 11:22 PM, Greg

Re: [PATCH v6 28/52] memory: tegra: Add and use devm_tegra_get_memory_controller()

2020-10-28 Thread Dmitry Osipenko
27.10.2020 12:42, Krzysztof Kozlowski пишет: > On Mon, Oct 26, 2020 at 01:17:11AM +0300, Dmitry Osipenko wrote: >> Multiple Tegra drivers need to retrieve Memory Controller and there is >> duplication of the retrieval code among the drivers. This patch removes >> the duplication and fixes put_devic

Re: [PATCH 0/3] Introduce devm_pm_opp_set_* API

2020-10-28 Thread Viresh Kumar
On 12-10-20, 21:55, Frank Lee wrote: > Hi, this patchset introduce devm_pm_opp_set_prop_name() and > devm_pm_opp_set_supported_hw(). > > Yangtao Li (3): > opp: Add devres wrapper for dev_pm_opp_set_supported_hw > opp: Add devres wrapper for dev_pm_opp_set_prop_name > drm/msm: Convert to devm

Re: [PATCH 3/3] drm/msm: Convert to devm_pm_opp_set_supported_hw

2020-10-28 Thread Viresh Kumar
On 12-10-20, 21:55, Frank Lee wrote: > From: Yangtao Li > > Use the devm_pm_opp_set_supported_hw() to avoid memory leaks in some cases. > > Signed-off-by: Yangtao Li > Signed-off-by: Yangtao Li > --- > drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH v6 08/52] dt-bindings: memory: tegra20: emc: Document mfd-simple compatible and statistics sub-device

2020-10-28 Thread Dmitry Osipenko
27.10.2020 22:44, Krzysztof Kozlowski пишет: > On Tue, Oct 27, 2020 at 10:22:19PM +0300, Dmitry Osipenko wrote: >> 27.10.2020 12:02, Krzysztof Kozlowski пишет: @@ -31,17 +32,34 @@ Example: ... }; + emc_bw_dfs_opp_table: emc_opp_table1 { >>> Hyphens for node

Re: [PATCH] drm/msm/a6xx: Add support for using system cache on MMU500 based targets

2020-10-28 Thread Sai Prakash Ranjan
On 2020-10-27 20:09, Jordan Crouse wrote: On Tue, Oct 27, 2020 at 12:38:02PM +0530, Sai Prakash Ranjan wrote: On 2020-10-27 00:24, Jordan Crouse wrote: >This is an extension to the series [1] to enable the System Cache (LLC) >for >Adreno a6xx targets. > >GPU targets with an MMU-500 attached have

Re: [PATCH v6 1/4] RDMA/umem: Support importing dma-buf as user memory region

2020-10-28 Thread Jason Gunthorpe
On Tue, Oct 27, 2020 at 05:32:26PM +, Xiong, Jianxin wrote: > > On Mon, Oct 26, 2020 at 09:26:37AM -0300, Jason Gunthorpe wrote: > > > On Sat, Oct 24, 2020 at 08:48:07AM +0100, Christoph Hellwig wrote: > > > > On Fri, Oct 23, 2020 at 03:20:05PM -0300, Jason Gunthorpe wrote: > > > > > The proble

[PATCH V2 Resend 2/2] drm/msm: Unconditionally call dev_pm_opp_of_remove_table()

2020-10-28 Thread Viresh Kumar
dev_pm_opp_of_remove_table() doesn't report any errors when it fails to find the OPP table with error -ENODEV (i.e. OPP table not present for the device). And we can call dev_pm_opp_of_remove_table() unconditionally here. While at it, also create a label to put clkname. Signed-off-by: Viresh Kuma

[PATCH] drm/vc4: hdmi: Avoid sleeping in atomic context

2020-10-28 Thread Maxime Ripard
When running the trigger hook, ALSA by default will take a spinlock, and thus will run the trigger hook in atomic context. However, our HDMI driver will send the infoframes as part of the trigger hook, and part of that process is to wait for a bit to be cleared for up to 100ms. To be nicer to the

Re: [RFC] clang tooling cleanups

2020-10-28 Thread Finn Thain
On Tue, 27 Oct 2020, t...@redhat.com wrote: > This rfc will describe > An upcoming treewide cleanup. > How clang tooling was used to programatically do the clean up. > Solicit opinions on how to generally use clang tooling. > This tooling is very impressive. It makes possible an idea that I ha

Re: [PATCH 3/3] drm/msm/dpu: add support for clk and bw scaling for display

2020-10-28 Thread Dmitry Baryshkov
Hello, On 04/08/2020 18:40, Rob Clark wrote: On Thu, Jul 16, 2020 at 4:36 AM Kalyan Thota wrote: This change adds support to scale src clk and bandwidth as per composition requirements. Interconnect registration for bw has been moved to mdp device node from mdss to facilitate the scaling. C

Re: [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-10-28 Thread Viresh Kumar
On 25-10-20, 10:39, Rob Clark wrote: > Nope, I suspect any creation of debugfs files will be problematic. Yeah, so it only fixed part of the problem. > (btw, _add_opp_dev_unlocked() looks like it should be called > _add_opp_dev_locked()?) > > It does look like 'struct opp_table' is already refcn

Re: [PATCH v6 08/52] dt-bindings: memory: tegra20: emc: Document mfd-simple compatible and statistics sub-device

2020-10-28 Thread Dmitry Osipenko
27.10.2020 16:22, Thierry Reding пишет: > On Mon, Oct 26, 2020 at 01:16:51AM +0300, Dmitry Osipenko wrote: >> External Memory Controller can gather various hardware statistics that >> are intended to be used for debugging purposes and for dynamic frequency >> scaling of memory bus. >> >> Document t

Re: [PATCH] dt-bindings: More whitespace clean-ups in schema files

2020-10-28 Thread Ulf Hansson
On Fri, 23 Oct 2020 at 21:23, Rob Herring wrote: > > Clean-up incorrect indentation, extra spaces, and missing EOF newline in > schema files. Most of the clean-ups are for list indentation which > should always be 2 spaces more than the preceding keyword. > > Found with yamllint (now integrated in

Re: [PATCH v6 13/52] dt-bindings: memory: tegra124: emc: Document new interconnect property

2020-10-28 Thread Dmitry Osipenko
27.10.2020 22:48, Krzysztof Kozlowski пишет: > On Tue, Oct 27, 2020 at 10:19:28PM +0300, Dmitry Osipenko wrote: >> 27.10.2020 13:25, Krzysztof Kozlowski пишет: >>> On Mon, Oct 26, 2020 at 01:16:56AM +0300, Dmitry Osipenko wrote: External memory controller is interconnected with memory controll

Re: [PATCH v6 33/52] memory: tegra20: Support interconnect framework

2020-10-28 Thread Dmitry Osipenko
27.10.2020 23:22, Dmitry Osipenko пишет: ... >>> + >>> + *agg_avg += avg_bw; >>> + *agg_peak = max(*agg_peak, peak_bw); >> >> I'm not very familiar with ICC, but shouldn't the aggregated peak value >> be the sum of the current aggregated peak and the new peak bandwidth? >> Currently you're sele

Re: [PATCH 1/1] video: fbdev: fix divide error in fbcon_switch

2020-10-28 Thread Saeed Mirzamohammadi
Hi Greg, Sorry for the confusion. I’m requesting stable maintainers to cherry-pick this patch into stable 5.4 and 5.8. commit cc07057c7c88fb8eff3b1991131ded0f0bcfa7e3 Author: Saeed Mirzamohammadi Date: Wed Oct 21 16:57:58 2020 -0700 video: fbdev: fix divide error in fbcon_switch Thanks,

[PATCH V2 Resend 1/2] drm/lima: Unconditionally call dev_pm_opp_of_remove_table()

2020-10-28 Thread Viresh Kumar
dev_pm_opp_of_remove_table() doesn't report any errors when it fails to find the OPP table with error -ENODEV (i.e. OPP table not present for the device). And we can call dev_pm_opp_of_remove_table() unconditionally here. Reviewed-by: Qiang Yu Signed-off-by: Viresh Kumar --- V2: Applied Reviewe

Re: [PATCH 3/8] vhost: vringh: use krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
On Tue, Oct 27, 2020 at 6:08 PM Joe Perches wrote: > > On Tue, 2020-10-27 at 17:58 +0100, Bartosz Golaszewski wrote: > > On Tue, Oct 27, 2020 at 5:50 PM Joe Perches wrote: > > > > > > On Tue, 2020-10-27 at 11:28 -0400, Michael S. Tsirkin wrote: > > > > On Tue, Oct 27, 2020 at 01:17:20PM +0100, Ba

[PATCH 1/8] mm: slab: provide krealloc_array()

2020-10-28 Thread Bartosz Golaszewski
From: Bartosz Golaszewski When allocating an array of elements, users should check for multiplication overflow or preferably use one of the provided helpers like: kmalloc_array(). There's no krealloc_array() counterpart but there are many users who use regular krealloc() to reallocate arrays. Le

Re: [PATCH v6 09/52] dt-bindings: memory: tegra30: mc: Document new interconnect property

2020-10-28 Thread Dmitry Osipenko
27.10.2020 12:05, Krzysztof Kozlowski пишет: > On Mon, Oct 26, 2020 at 01:16:52AM +0300, Dmitry Osipenko wrote: >> Memory controller is interconnected with memory clients and with the >> External Memory Controller. Document new interconnect property which >> turns memory controller into interconnec

Re: [PATCH v6 46/52] opp: Put interconnect paths outside of opp_table_lock

2020-10-28 Thread Dmitry Osipenko
27.10.2020 08:10, Viresh Kumar пишет: > On 26-10-20, 01:17, Dmitry Osipenko wrote: >> This patch fixes lockup which happens when OPP table is released if >> interconnect provider uses OPP in the icc_provider->set() callback >> and bandwidth of the ICC path is set to 0 by the ICC core when path >> i

Re: [PATCH libdrm] xf86drm.c: Use integer logarithm.

2020-10-28 Thread Pekka Paalanen
On Mon, 26 Oct 2020 16:11:20 +0300 Paul Gofman wrote: > log() is affected by FP control word and can provide inaccurate result. > > Fixes Killer Instinct under Wine not being able to find AMD vulkan > device. > > Signed-off-by: Paul Gofman > --- > With the rounding mode the application set

Re: [PATCH 2/5] Fonts: Make font size unsigned in font_desc

2020-10-28 Thread Daniel Vetter
On Wed, Oct 28, 2020 at 01:43:07AM -0400, Peilin Ye wrote: > On Tue, Oct 27, 2020 at 07:50:58PM +0100, Daniel Vetter wrote: > > On Tue, Oct 27, 2020 at 12:33:05PM -0400, Peilin Ye wrote: > > > It is improper to define `width` and `height` as signed in `struct > > > font_desc`. Make them unsigned. A

Re: [PATCH] drm/shme-helpers: Fix dma_buf_mmap forwarding bug

2020-10-28 Thread Boris Brezillon
On Tue, 27 Oct 2020 22:49:22 +0100 Daniel Vetter wrote: > When we forward an mmap to the dma_buf exporter, they get to own > everything. Unfortunately drm_gem_mmap_obj() overwrote > vma->vm_private_data after the driver callback, wreaking the > exporter complete. This was noticed because vb2_comm

Re: [PATCH 1/8] mm: slab: provide krealloc_array()

2020-10-28 Thread Mike Rapoport
On Tue, Oct 27, 2020 at 01:17:18PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > When allocating an array of elements, users should check for > multiplication overflow or preferably use one of the provided helpers > like: kmalloc_array(). > > There's no krealloc_array() count

Re: [PATCH 1/3] drm/ttm: replace last move_notify with delete_mem_notify

2020-10-28 Thread Daniel Vetter
On Wed, Oct 21, 2020 at 11:58:45AM +0200, Christian König wrote: > Am 21.10.20 um 06:40 schrieb Dave Airlie: > > From: Dave Airlie > > > > The move notify callback is only used in one place, this should > > be removed in the future, but for now just rename it to the use > > case which is to notif

Re: [PATCH 3/3] drm/ttm: avoid multihop moves in drivers.

2020-10-28 Thread Daniel Vetter
On Wed, Oct 21, 2020 at 02:40:31PM +1000, Dave Airlie wrote: > From: Dave Airlie > > Currently drivers get called to move a buffer, but if they have to > move it temporarily through another space (SYSTEM->VRAM via TT) > then they can end up with a lot of ttm->driver->ttm call stacks, > if the tem

Re: [PATCH 1/3] drm/ttm: replace last move_notify with delete_mem_notify

2020-10-28 Thread Christian König
Am 28.10.20 um 10:16 schrieb Daniel Vetter: On Wed, Oct 21, 2020 at 11:58:45AM +0200, Christian König wrote: Am 21.10.20 um 06:40 schrieb Dave Airlie: From: Dave Airlie The move notify callback is only used in one place, this should be removed in the future, but for now just rename it to the

Re: [PATCH v3 19/20] drm/tegra: Implement new UAPI

2020-10-28 Thread Mikko Perttunen
On 10/27/20 9:06 PM, Dmitry Osipenko wrote: 26.10.2020 12:11, Mikko Perttunen пишет: The first patches should be the ones that are relevant to the existing userspace code, like support for the waits. Can you elaborate what you mean by this? All features that don't have an immediate real use

Re: [Linaro-mm-sig] [PATCH] drm/shme-helpers: Fix dma_buf_mmap forwarding bug

2020-10-28 Thread Christian König
Am 27.10.20 um 22:49 schrieb Daniel Vetter: When we forward an mmap to the dma_buf exporter, they get to own everything. Unfortunately drm_gem_mmap_obj() overwrote vma->vm_private_data after the driver callback, wreaking the exporter complete. This was noticed because vb2_common_vm_close blew up

Re: [PATCH 1/5] fbdev/atafb: Remove unused extern variables

2020-10-28 Thread Geert Uytterhoeven
On Tue, Oct 27, 2020 at 6:12 PM Peilin Ye wrote: > Remove 6 unused extern variables to reduce confusion. It is worth > mentioning that lib/fonts/font_8x8.c and lib/fonts/font_8x16.c also > declare `fontdata_8x8` and `fontdata_8x16` respectively, and this file > has nothing to do with them. > > Sig

[PATCH libdrm 1/2] include: Factor out log2_int() function.

2020-10-28 Thread Paul Gofman
Signed-off-by: Paul Gofman --- radeon/radeon_surface.c | 20 +--- util_math.h | 14 ++ xf86drm.c | 16 3 files changed, 15 insertions(+), 35 deletions(-) diff --git a/radeon/radeon_surface.c b/radeon/radeon_surface.c index ea

[PATCH libdrm 2/2] include: Avoid potentially infinite loop in log2_int().

2020-10-28 Thread Paul Gofman
Signed-off-by: Paul Gofman --- util_math.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/util_math.h b/util_math.h index e2fa95f5..f6bbe192 100644 --- a/util_math.h +++ b/util_math.h @@ -38,6 +38,9 @@ static inline unsigned log2_int(unsigned x) if (x < 2) { return 0; }

Re: [PATCH libdrm] xf86drm.c: Use integer logarithm.

2020-10-28 Thread Paul Gofman
On 10/28/20 11:18, Pekka Paalanen wrote: > >> >> +static unsigned log2_int(unsigned x) >> +{ >> +unsigned l; >> + >> +if (x < 2) { >> +return 0; >> +} >> +for (l = 2; ; l++) { >> +if ((unsigned)(1 << l) > x) { > Hi, > > wouldn't this loop fail to end when x >= 0x80

Re: [PATCH] drm/shme-helpers: Fix dma_buf_mmap forwarding bug

2020-10-28 Thread Daniel Vetter
On Wed, Oct 28, 2020 at 09:44:15AM +0100, Boris Brezillon wrote: > On Tue, 27 Oct 2020 22:49:22 +0100 > Daniel Vetter wrote: > > > When we forward an mmap to the dma_buf exporter, they get to own > > everything. Unfortunately drm_gem_mmap_obj() overwrote > > vma->vm_private_data after the driver

Re: [PATCH 1/3] drm/ttm: replace last move_notify with delete_mem_notify

2020-10-28 Thread Daniel Vetter
On Wed, Oct 28, 2020 at 10:53 AM Christian König wrote: > > Am 28.10.20 um 10:16 schrieb Daniel Vetter: > > On Wed, Oct 21, 2020 at 11:58:45AM +0200, Christian König wrote: > >> Am 21.10.20 um 06:40 schrieb Dave Airlie: > >>> From: Dave Airlie > >>> > >>> The move notify callback is only used in

Re: [PATCH libdrm] xf86drm.c: Use integer logarithm.

2020-10-28 Thread Michel Dänzer
On 2020-10-28 11:09 a.m., Paul Gofman wrote: On 10/28/20 11:18, Pekka Paalanen wrote: +static unsigned log2_int(unsigned x) +{ +unsigned l; + +if (x < 2) { +return 0; +} +for (l = 2; ; l++) { +if ((unsigned)(1 << l) > x) { Hi, wouldn't this loop fail to end

Re: [PATCH 2/5] Fonts: Make font size unsigned in font_desc

2020-10-28 Thread Peilin Ye
On Wed, Oct 28, 2020 at 09:18:44AM +0100, Daniel Vetter wrote: > On Wed, Oct 28, 2020 at 01:43:07AM -0400, Peilin Ye wrote: > > On Tue, Oct 27, 2020 at 07:50:58PM +0100, Daniel Vetter wrote: > > > On Tue, Oct 27, 2020 at 12:33:05PM -0400, Peilin Ye wrote: > > > > It is improper to define `width` an

Re: [PATCH libdrm] xf86drm.c: Use integer logarithm.

2020-10-28 Thread Paul Gofman
On 10/28/20 13:30, Michel Dänzer wrote: > On 2020-10-28 11:09 a.m., Paul Gofman wrote: >> On 10/28/20 11:18, Pekka Paalanen wrote: >>>   +static unsigned log2_int(unsigned x) +{ +    unsigned l; + +    if (x < 2) { +    return 0; +    } +    for (l = 2; ;

[PATCH v2 2/5] Fonts: Make font size unsigned in font_desc

2020-10-28 Thread Peilin Ye
`width` and `height` are defined as unsigned in our UAPI font descriptor `struct console_font`. Make them unsigned in our kernel font descriptor `struct font_desc`, too. Also, change the corresponding printk() format identifiers from `%d` to `%u`, in sti_select_fbfont(). Signed-off-by: Peilin Ye

Re: [PATCH 1/1] drm/vc4: drv: Add error handding for bind

2020-10-28 Thread Daniel Vetter
On Tue, Oct 27, 2020 at 03:54:31PM +0100, Maxime Ripard wrote: > Hi, > > On Tue, Oct 27, 2020 at 01:14:42PM +0900, Hoegeun Kwon wrote: > > There is a problem that if vc4_drm bind fails, a memory leak occurs on > > the drm_property_create side. Add error handding for drm_mode_config. > > > > Signe

[PATCH] drm/ttm: Warn on pinning without holding a reference

2020-10-28 Thread Daniel Vetter
Not technically a problem for ttm, but very likely a driver bug and pretty big time confusing for reviewing code. So warn about it, both at cleanup time (so we catch these for sure) and at pin/unpin time (so we know who's the culprit). Signed-off-by: Daniel Vetter Cc: Christian Koenig Cc: Huang

RE: [PATCH 01/13] drm/ttm: nuke ttm_tt_set_(un)populated again

2020-10-28 Thread Chauhan, Madhav
[AMD Public Use] -Original Message- From: Chauhan, Madhav Sent: Tuesday, October 27, 2020 12:57 AM To: Koenig, Christian ; dri-devel@lists.freedesktop.org Cc: Huang, Ray Subject: RE: [PATCH 01/13] drm/ttm: nuke ttm_tt_set_(un)populated again [AMD Public Use] -Original Message-

Re: [PATCH] drm/ttm: Warn on pinning without holding a reference

2020-10-28 Thread Huang Rui
On Wed, Oct 28, 2020 at 07:31:20PM +0800, Daniel Vetter wrote: > Not technically a problem for ttm, but very likely a driver bug and > pretty big time confusing for reviewing code. > > So warn about it, both at cleanup time (so we catch these for sure) > and at pin/unpin time (so we know who's the

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

2020-10-28 Thread Vivi, Rodrigo
> On Oct 27, 2020, at 11:49 PM, Pandey, Hariom wrote: > > Hi Chris, > > Awaiting your kind response here… https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9208/fi-ehl-1/igt@i915_selftest@live@gt_pm.html "Did not enter RC6!" Chris already told that we need to get RC6 working on CI. If we need

RE: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

2020-10-28 Thread Pandey, Hariom
Ok, I have initiated the steps to upgrade the CI machine's silicon & BIOS. Thanks Hariom Pandey > -Original Message- > From: Vivi, Rodrigo > Sent: Wednesday, October 28, 2020 5:24 PM > To: Pandey, Hariom ; Szwichtenberg, Radoslaw > > Cc: Chris Wilson ; Ausmus, James > ; Nikula, Jani ; i

Re: [PATCH] drm/ttm: Warn on pinning without holding a reference

2020-10-28 Thread Christian König
Am 28.10.20 um 12:31 schrieb Daniel Vetter: Not technically a problem for ttm, but very likely a driver bug and pretty big time confusing for reviewing code. So warn about it, both at cleanup time (so we catch these for sure) and at pin/unpin time (so we know who's the culprit). Signed-off-by:

[PATCH][next] drm/amd/pm: fix out-of-bound read on pptable->SkuReserved

2020-10-28 Thread Colin King
From: Colin Ian King A recent change added two uint16_t elements to PPTable_t and reduced the uint32_t array down to 8 elements. This results in the dev_info printing of pptable->SkuReserved[8] accessing a value that is out-of-range on array SkuReserved. The array has been shrunk by 1 element, s

Re: [PATCH 10/65] drm/malidp: Annotate dma-fence critical section in commit path

2020-10-28 Thread Liviu Dudau
On Fri, Oct 23, 2020 at 02:21:21PM +0200, Daniel Vetter wrote: > Again needs to be put right after the call to > drm_atomic_helper_commit_hw_done(), since that's the last thing which > can hold up a subsequent atomic commit. > > No surprises here. > > Signed-off-by: Daniel Vetter > Cc: "James (Q

Re: [PATCH] drm/vc4: hdmi: Add a name to the codec DAI component

2020-10-28 Thread Dave Stevenson
Hi Maxime On Wed, 8 Jul 2020 at 15:46, Maxime Ripard wrote: > > Since the components for a given device in ASoC are identified by their > name, it makes sense to add one even though it's not strictly necessary. > > Signed-off-by: Maxime Ripard Reviewed-by: Dave Stevenson > --- > drivers/gpu/

[PATCH v3 1/3] drm/msm: Add support for GPU cooling

2020-10-28 Thread Akhil P Oommen
Register GPU as a devfreq cooling device so that it can be passively cooled by the thermal framework. Signed-off-by: Akhil P Oommen --- Changes in v3: 1. Minor fix in binding documentation (RobH) Changes in v2: 1. Update the dt bindings documentation drivers/gpu/drm/msm/msm_gpu.c

[PATCH v3 3/3] dt-bindings: drm/msm/gpu: Add cooling device support

2020-10-28 Thread Akhil P Oommen
Add cooling device support to gpu. A cooling device is bound to a thermal zone to allow thermal mitigation. Signed-off-by: Akhil P Oommen --- Documentation/devicetree/bindings/display/msm/gpu.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/display

[PATCH v3 2/3] arm64: dts: qcom: sc7180: Add gpu cooling support

2020-10-28 Thread Akhil P Oommen
Add cooling-cells property and the cooling maps for the gpu tzones to support GPU cooling. Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 30 +++--- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dt

Re: [PATCH] drm/vc4: hdmi: Block odd horizontal timings

2020-10-28 Thread Dave Stevenson
Hi Maxime On Fri, 25 Sep 2020 at 14:00, Maxime Ripard wrote: > > The FIFO between the pixelvalve and the HDMI controller runs at 2 pixels > per clock cycle, and cannot deal with odd timings. > > Let's reject any mode with such timings. > > Signed-off-by: Maxime Ripard It's unsupported due to th

Re: [PATCH] drm/vc4: Rework the structure convertion functions

2020-10-28 Thread Dave Stevenson
s/convertion/conversion in subject line On Wed, 28 Oct 2020 at 12:37, Maxime Ripard wrote: > > Most of the helpers to retrieve vc4 structures from the DRM base structures > rely on the fact that the first member of the vc4 structure is the DRM one > and just cast the pointers between them. > > Ho

[PATCH 19/33] docs: ABI: stable: make files ReST compatible

2020-10-28 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab Several entries at the stable ABI files won't parse if we pass them directly to the ReST output. Adjust them, in order to allow adding their contents as-is at the stable ABI book. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Mauro Carvalho Chehab --- Docume

[PATCH] drm/gma500: Remove GTT roll support

2020-10-28 Thread Patrik Jakobsson
GTT roll support was used to accelerate fb panning on some machines. Unfortunately this never worked properly with multiple monitors and caused issues on others where the framebuffer wouldn't fit in stolen memory. Let's remove it! Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/frameb

[PATCH v2 1/2] drm/msm: Implement shutdown callback for adreno

2020-10-28 Thread Akhil P Oommen
Implement the shutdown callback for adreno gpu platform device to safely shutdown it before a system reboot. This helps to avoid futher transactions from gpu after the smmu is moved to bypass mode. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/adreno_device.c | 6 ++ 1 file ch

[PATCH v2 2/2] drm/msm: Fix duplicate gpu node in icc summary

2020-10-28 Thread Akhil P Oommen
The dev_pm_opp_of_add_table() api initializes the icc nodes for gpu indirectly. So we can avoid using of_icc_get() api in the common probe path. To improve this, move of_icc_get() to target specific code where it is required. This patch helps to fix duplicate gpu node listed in the interconnect su

Re: [PATCH 4/4] drm/gma500: avoid Woverride-init warning

2020-10-28 Thread Patrik Jakobsson
On Tue, Oct 27, 2020 at 5:50 PM Arnd Bergmann wrote: > > On Tue, Oct 27, 2020 at 10:54 AM Patrik Jakobsson > wrote: > > On Tue, Oct 27, 2020 at 10:33 AM Daniel Vetter wrote: > > > On Mon, Oct 26, 2020 at 08:41:04PM +0100, Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > > > > > gcc -Wex

Re: [PATCH v3 3/3] backlight: pwm_bl: Fix interpolation

2020-10-28 Thread Daniel Thompson
On Wed, Oct 21, 2020 at 10:04:45PM -0700, Alexandru Stan wrote: > The previous behavior was a little unexpected, its properties/problems: > 1. It was designed to generate strictly increasing values (no repeats) > 2. It had quantization errors when calculating step size. Resulting in > unexpected ju

Re: [PATCH v6 03/52] dt-bindings: memory: tegra20: emc: Correct registers range in example

2020-10-28 Thread Rob Herring
On Mon, 26 Oct 2020 01:16:46 +0300, Dmitry Osipenko wrote: > There is superfluous zero in the registers base address and registers > size should be twice bigger. > > Signed-off-by: Dmitry Osipenko > --- > .../bindings/memory-controllers/nvidia,tegra20-emc.txt | 2 +- > 1 file changed, 1

Re: [PATCH v6 04/52] dt-bindings: memory: tegra20: emc: Document nvidia,memory-controller property

2020-10-28 Thread Rob Herring
On Tue, Oct 27, 2020 at 08:30:39PM +0100, Krzysztof Kozlowski wrote: > On Tue, Oct 27, 2020 at 10:17:19PM +0300, Dmitry Osipenko wrote: > > 27.10.2020 11:54, Krzysztof Kozlowski пишет: > > > On Mon, Oct 26, 2020 at 01:16:47AM +0300, Dmitry Osipenko wrote: > > >> Tegra20 External Memory Controller t

  1   2   >