Re: [PATCH] drm/stm: dsi: Use dev_ based logging

2020-10-13 Thread Yannick FERTRE
Hi Sam, thanks for the review. I'll send a new patch with the revert of function dsi_color_from_mipi. Best regards Yannick On 9/25/20 4:51 PM, Sam Ravnborg wrote: > Hi Yannick. > > On Fri, Sep 25, 2020 at 12:22:33PM +0200, Yannick Fertre wrote: >> Standardize on the dev_ based logging and drop

[PATCH] gpu/drm/mediatek: fix unused parameter warning

2020-10-13 Thread Bernard Zhao
Functions mtk_drm_crtc_atomic_flush & mtk_drm_crtc_atomic_enable & mtk_drm_crtc_atomic_disable don`t use the second parameter. So we may get warning like : warning: unused parameter '***' [-Wunused-parameter]. This change is to fix the compile warning with -Wunused-parameter. Signed-off-by: Bernar

[PATCH] drm/amd/display: remove no need return value

2020-10-13 Thread Bernard Zhao
Functions (disable_all_writeback_pipes_for_stream & dc_enable_stereo & dc_post_update_surfaces_to_stream) always return true, there is no need to keep the return value. This change is to make the code a bit more readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/dc/core/dc.c

Re: [PATCH RFC PKS/PMEM 22/58] fs/f2fs: Utilize new kmap_thread()

2020-10-13 Thread Matthew Wilcox
On Mon, Oct 12, 2020 at 09:28:29AM -0700, Dave Hansen wrote: > kmap_atomic() is always preferred over kmap()/kmap_thread(). > kmap_atomic() is _much_ more lightweight since its TLB invalidation is > always CPU-local and never broadcast. > > So, basically, unless you *must* sleep while the mapping

[PATCH] drm/ingenic: Fix bad revert

2020-10-13 Thread Paul Cercueil
Fix a badly reverted commit. The revert commit was cherry-picked from drm-misc-next to drm-misc-next-fixes, and in the process some unrelated code was added. Fixes: a3fb64c00d44 "Revert "gpu/drm: ingenic: Add option to mmap GEM buffers cached"" Signed-off-by: Paul Cercueil --- drivers/gpu/drm/i

Re: [PATCH v17 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP

2020-10-13 Thread Xin Ji
Hi all, would you please help to review my latest patch v17, thanks very much! Best Regards, Xin ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v1] drm/virtio: Use UUID API for importing the UUID

2020-10-13 Thread Andy Shevchenko
There is import_uuid() function which imports u8 array to the uuid_t. Use it instead of open coding variant. This allows to hide the uuid_t internals. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/virtio/virtgpu_vq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH 2/3] opp: Add devres wrapper for dev_pm_opp_set_prop_name

2020-10-13 Thread Frank Lee
From: Yangtao Li Add devres wrapper for dev_pm_opp_set_prop_name() to simplify driver code. Signed-off-by: Yangtao Li Signed-off-by: Yangtao Li --- drivers/opp/core.c | 39 +++ include/linux/pm_opp.h | 6 ++ 2 files changed, 45 insertions(+) diff

[PATCH 3/3] drm/msm: Convert to devm_pm_opp_set_supported_hw

2020-10-13 Thread Frank Lee
From: Yangtao Li Use the devm_pm_opp_set_supported_hw() to avoid memory leaks in some cases. Signed-off-by: Yangtao Li Signed-off-by: Yangtao Li --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c

Re: [PATCH v1] drm/virtio: Use UUID API for importing the UUID

2020-10-13 Thread David Stevens
Reviewed-by: David Stevens On Tue, Oct 13, 2020 at 2:18 AM Andy Shevchenko wrote: > > There is import_uuid() function which imports u8 array to the uuid_t. > Use it instead of open coding variant. > > This allows to hide the uuid_t internals. > > Signed-off-by: Andy Shevchenko > --- > drivers/

[PATCH 1/3] opp: Add devres wrapper for dev_pm_opp_set_supported_hw

2020-10-13 Thread Frank Lee
From: Yangtao Li Add devres wrapper for dev_pm_opp_set_supported_hw() to simplify driver code. Signed-off-by: Yangtao Li Signed-off-by: Yangtao Li --- drivers/opp/core.c | 41 + include/linux/pm_opp.h | 8 2 files changed, 49 insertions(+)

Re: [PATCH v2 08/17] s390/pci: Remove races against pte updates

2020-10-13 Thread Niklas Schnelle
... snip ... >>> Cc: linux-me...@vger.kernel.org >>> Cc: Niklas Schnelle >>> Cc: Gerald Schaefer >>> Cc: linux-s...@vger.kernel.org >>> -- >>> v2: Move VM_IO | VM_PFNMAP checks around so they keep returning EINVAL >>> like before (Gerard) >> >> I think the above should go before the CC/Signed-off

Re: [PATCH RFC PKS/PMEM 22/58] fs/f2fs: Utilize new kmap_thread()

2020-10-13 Thread Matthew Wilcox
On Mon, Oct 12, 2020 at 12:53:54PM -0700, Ira Weiny wrote: > On Mon, Oct 12, 2020 at 05:44:38PM +0100, Matthew Wilcox wrote: > > On Mon, Oct 12, 2020 at 09:28:29AM -0700, Dave Hansen wrote: > > > kmap_atomic() is always preferred over kmap()/kmap_thread(). > > > kmap_atomic() is _much_ more lightwe

[PATCH v2] drm/dp check aux_dev before use in drm_dp_aux_dev_get_by_minor()

2020-10-13 Thread zwane
I observed this when unplugging a DP monitor whilst a computer is asleep and then waking it up. This left DP chardev nodes still being present on the filesystem and accessing these device nodes caused an oops because drm_dp_aux_dev_get_by_minor() assumes a device exists if it is opened. This ca

[PULL] drm-misc-next-fixes

2020-10-13 Thread Maxime Ripard
Hi Dave, Here's the remaining patches we have in drm-misc-next-fixes Maxime drm-misc-next-fixes-2020-10-13: One fix for a bad revert in ingenic-drm, and one fix for panfrost to increase a timeout at power up. The following changes since commit 8ba0b6d196315f68c271f549e8585129caefce97: drm/vc

Re: [PATCH] drm/ingenic: Fix bad revert

2020-10-13 Thread Paul Cercueil
Le lun. 12 oct. 2020 à 16:10, Daniel Vetter a écrit : On Mon, Oct 12, 2020 at 12:25:09PM +0200, Paul Cercueil wrote: Fix a badly reverted commit. The revert commit was cherry-picked from drm-misc-next to drm-misc-next-fixes, and in the process some unrelated code was added. Fixes: a3

Re: [PATCH v4 1/2] Revert "drm/mediatek: dsi: Fix scrolling of panel with small hfp or hbp"

2020-10-13 Thread Bilal Wasim
Hi Jitao, On Sat, 10 Oct 2020 15:09:09 +0800 Jitao Shi wrote: > This reverts commit 35bf948f1edbf507f6e57e0879fa6ea36d2d2930. > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/

Re: [PATCH v2 08/17] s390/pci: Remove races against pte updates

2020-10-13 Thread Niklas Schnelle
Hi Daniel, freshly back from my vacation I've just taken a look at your patch. First thanks for this fix and the detailed commit description. Definitely makes sense to fix this and you can add my Acked-by: Niklas Schnelle Content wise it all looks sane and clear and since Gerald did the testing

[PATCH] gpu/drm/armada: fix unused parameter warning

2020-10-13 Thread Bernard Zhao
Functions armada_drm_crtc_atomic_flush & armada_drm_crtc_atomic_enable don`t use the second parameter. So we may get warning like : warning: unused parameter ‘***’ [-Wunused-parameter]. This change is to fix the compile warning with -Wunused-parameter. Signed-off-by: Bernard Zhao --- drivers/gpu

[PATCH 0/3] Introduce devm_pm_opp_set_* API

2020-10-13 Thread Frank Lee
Hi, this patchset introduce devm_pm_opp_set_prop_name() and devm_pm_opp_set_supported_hw(). Yangtao Li (3): opp: Add devres wrapper for dev_pm_opp_set_supported_hw opp: Add devres wrapper for dev_pm_opp_set_prop_name drm/msm: Convert to devm_pm_opp_set_supported_hw drivers/gpu/drm/msm/adre

Re: linux-next: build failure after merge of the drm-misc tree

2020-10-13 Thread Paul Cercueil
Hi Stephen, Le lun. 12 oct. 2020 à 15:24, Stephen Rothwell a écrit : Hi all, On Thu, 8 Oct 2020 15:42:02 +1100 Stephen Rothwell wrote: On Thu, 8 Oct 2020 14:09:03 +1100 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (x86_64 > allmodconfig) fai

Re: linux-next: build failure after merge of the iommu tree

2020-10-13 Thread Stephen Rothwell
Hi all, On Mon, 21 Sep 2020 14:09:01 +1000 Stephen Rothwell wrote: > > After merging the iommu tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/gpu/drm/msm/msm_iommu.c: In function 'msm_iommu_pagetable_unmap': > drivers/gpu/drm/msm/msm_iommu.c:46:2: error:

Re: [PATCH 3/3] drm/vkms: fbdev emulation support

2020-10-13 Thread Daniel Vetter
On Tue, Oct 13, 2020 at 8:14 AM Pekka Paalanen wrote: > > On Mon, 12 Oct 2020 16:23:35 +0200 > Daniel Vetter wrote: > > > On Mon, Oct 12, 2020 at 02:40:58PM +0200, Neil Armstrong wrote: > > > Hi, > > > > > ... > > > > It's weird because it the kernel is misconfigured and no console is > > > spec

[PATCH v2] drm/stm: dsi: Use dev_ based logging

2020-10-13 Thread Yannick Fertre
Standardize on the dev_ based logging. Signed-off-by: Yannick Fertre --- Changes in v2: - restore function dsi_color_from_mipi. - reword commit. drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 55 ++- 1 file changed, 29 insertions(+), 26 deletions(-) diff --git

Re: [PATCH v1] drm/virtio: Use UUID API for importing the UUID

2020-10-13 Thread Gerd Hoffmann
On Mon, Oct 12, 2020 at 08:18:26PM +0300, Andy Shevchenko wrote: > There is import_uuid() function which imports u8 array to the uuid_t. > Use it instead of open coding variant. > > This allows to hide the uuid_t internals. Doesn't apply to drm-misc-next, please rebase. thanks, Gerd _

[PATCH] drm/tegra: sor: Ensure regulators are disabled on teardown

2020-10-13 Thread Marc Zyngier
The Tegra SOR driver uses the devm infrastructure to request regulators, but enables them without registering them with the infrastructure. This results in the following splat if probing fails for any odd resaon (such as dependencies not being available): [8.974187] tegra-sor 1558.sor: ca

Re: [v4 PATCH 0/2] fix scrolling of panel with small hfp or hbp

2020-10-13 Thread Jitao Shi
On Mon, 2020-10-12 at 23:22 +0800, Chun-Kuang Hu wrote: > Hi, Jitao: > > Jitao Shi 於 2020年10月10日 週六 下午3:09寫道: > > > > Changes since v3: > > - Revert v2, for v2 will cause some bridge ic no output. the cause > >the video linetime doesn't match display mode from get mode. > > - Make sure the

[PATCH v5 0/1] fix scrolling of panel with small hfp or hbp

2020-10-13 Thread Jitao Shi
Changes since v4: - Merge revert path and fixup patch to on patch Changes since v3: - Revert v2, for v2 will cause some bridge ic no output. the cause the video linetime doesn't match display mode from get mode. - Make sure the horizontal_frontporch_byte and horizontal_backporch_byte are

[PATCH v5 1/1] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-10-13 Thread Jitao Shi
Replace horizontal_backporch_byte with vm->hback_porch * bpp to aovid flowing judgement negative number. if ((vm->hfront_porch * dsi_tmp_buf_bpp + horizontal_backporch_byte) > data_phy_cycles * dsi->lanes + delta) Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/mtk_dsi.c | 65

Re: [PATCH 3/3] drm/vkms: fbdev emulation support

2020-10-13 Thread Pekka Paalanen
On Tue, 13 Oct 2020 09:53:44 +0200 Daniel Vetter wrote: > On Tue, Oct 13, 2020 at 8:14 AM Pekka Paalanen wrote: > > > > On Mon, 12 Oct 2020 16:23:35 +0200 > > Daniel Vetter wrote: > > > > > On Mon, Oct 12, 2020 at 02:40:58PM +0200, Neil Armstrong wrote: > > > > Hi, > > > > > > > > ... > >

[PATCH v2 0/3] drm/panel: mantix panel reset fixes

2020-10-13 Thread Guido Günther
The first patch in this series fixes dereferencing a NULL mode in the error path. The second one extends the resets to not only reset RESX but also TP_RSTN since otherwise the display will stay completely blank. I didn't spot that before initial submission since the reset line was bound to the tou

[PATCH v2 2/3] drm/panel: mantix: Fix panel reset

2020-10-13 Thread Guido Günther
The mantix panel needs two reset lines (RESX and TP_RSTN) deasserted to output an image. Only deasserting RESX is not enough and the display will stay blank. Deassert in prepare() and assert in unprepare() to keep device held in reset when off. Signed-off-by: Guido Günther --- .../gpu/drm/panel/

[PATCH v2 1/3] drm/panel: mantix: Don't dereference NULL mode

2020-10-13 Thread Guido Günther
Don't dereference mode which was just NULL checked. Signed-off-by: Guido Günther Reported-by: Dan Carpenter --- drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/dr

[PATCH v2 3/3] dt-binding: display: Require two resets on mantix panel

2020-10-13 Thread Guido Günther
We need to reset both for the panel to show an image. Signed-off-by: Guido Günther --- .../bindings/display/panel/mantix,mlaf057we51-x.yaml | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml b/Documentation

Re: [PATCH v5 1/1] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-10-13 Thread Nicolas Boichat
On Tue, Oct 13, 2020 at 6:06 PM Jitao Shi wrote: > > Replace horizontal_backporch_byte with vm->hback_porch * bpp to aovid > flowing judgement negative number. > > if ((vm->hfront_porch * dsi_tmp_buf_bpp + horizontal_backporch_byte) > > data_phy_cycles * dsi->lanes + delta) > > Signed-off-

Re: [PATCH 3/3] drm/vkms: fbdev emulation support

2020-10-13 Thread Daniel Vetter
On Tue, Oct 13, 2020 at 01:19:38PM +0300, Pekka Paalanen wrote: > On Tue, 13 Oct 2020 09:53:44 +0200 > Daniel Vetter wrote: > > > On Tue, Oct 13, 2020 at 8:14 AM Pekka Paalanen wrote: > > > > > > On Mon, 12 Oct 2020 16:23:35 +0200 > > > Daniel Vetter wrote: > > > > > > > On Mon, Oct 12, 2020

Re: [PATCH v2 22/22] drm/msm: Don't implicit-sync if only a single ring

2020-10-13 Thread Daniel Vetter
On Mon, Oct 12, 2020 at 08:07:38AM -0700, Rob Clark wrote: > On Mon, Oct 12, 2020 at 7:40 AM Daniel Vetter wrote: > > > > On Sun, Oct 11, 2020 at 07:09:49PM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > Any cross-device sync use-cases *must* use explicit sync. And if there > > > is o

[PATCH] drm/vkms: Switch to shmem helpers

2020-10-13 Thread Daniel Vetter
Inspired by a patch by Chris Wilson for vgem. Plus this gives us vmap at the gem bo level, which we need for generic fbdev emulation. Luckily shmem also tracks ->vaddr, so we just need to adjust the code all over a bit to make this fit. Also wire up handle_to_fd, dunno why that was missing. v2:

[PATCH v6 74/80] gpu: docs: amdgpu.rst: get rid of wrong kernel-doc markups

2020-10-13 Thread Mauro Carvalho Chehab
As reported by kernel-doc: ./drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c:1: warning: no structured comments found ./drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1: warning: no structured comments found Those files only contain /** * DOC: */ markups, but they're includ

[PATCH v6 75/80] drm: kernel-doc: add description for a new function parameter

2020-10-13 Thread Mauro Carvalho Chehab
As reported by "make htmldocs": ./drivers/gpu/drm/drm_prime.c:808: warning: Function parameter or member 'dev' not described in 'drm_prime_pages_to_sg' Add a description for the new parameter. Fixes: 707d561f77b5 ("drm: allow limiting the scatter list size.") Signed-off-by: Mauro Carval

[PATCH v6 65/80] docs: amdgpu: fix a warning when building the documentation

2020-10-13 Thread Mauro Carvalho Chehab
As reported by Sphinx: Documentation/gpu/amdgpu.rst:200: WARNING: Inline emphasis start-string without end-string. Signed-off-by: Mauro Carvalho Chehab --- Documentation/gpu/amdgpu.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/gpu/amdgpu.rst

[PATCH v6 44/80] docs: gpu: i915.rst: Fix several C duplication warnings

2020-10-13 Thread Mauro Carvalho Chehab
As reported by Sphinx: ./Documentation/gpu/i915:646: ./drivers/gpu/drm/i915/i915_perf.c:1147: WARNING: Duplicate C declaration, also defined in 'gpu/i915'. Declaration is 'i915_oa_wait_unlocked'. ./Documentation/gpu/i915:646: ./drivers/gpu/drm/i915/i915_perf.c:1169: WARNI

[PATCH v6 56/80] dt-bindings: fix references to files converted to yaml

2020-10-13 Thread Mauro Carvalho Chehab
There were several files converted to yaml, but the .txt file is still referenced somewhere else. Update the references for them to point to the right file. Signed-off-by: Mauro Carvalho Chehab --- .../bindings/display/tilcdc/tilcdc.txt | 2 +- .../devicetree/bindings/mailbox/omap-ma

[PATCH v6 73/80] drm: kernel-doc: drm_dp_helper.h: fix a typo

2020-10-13 Thread Mauro Carvalho Chehab
Right now, kernel-doc generates a warning: ./include/drm/drm_dp_helper.h:1786: warning: Function parameter or member 'hbr2_reset' not described in 'drm_dp_phy_test_params' This is due to a typo: @hb2_reset -> @hbr2_reset Signed-off-by: Mauro Carvalho Chehab --- include/drm/drm

[PATCH v6 72/80] drm/amd/display: kernel-doc: document force_timing_sync

2020-10-13 Thread Mauro Carvalho Chehab
As warned when running "make htmldocs": ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:345: warning: Function parameter or member 'force_timing_sync' not described in 'amdgpu_display_manager' This new struct member was not documented at kernel-doc markup. Fixes: 3d4e52d0cf24 ("drm

[PATCH v6 79/80] drm: drm_edid: remove a duplicated kernel-doc declaration

2020-10-13 Thread Mauro Carvalho Chehab
It is not possible to create cross-references for duplicated symbols. While Sphinx always detected it, on Sphinx 3 it generates warnings like this: .../Documentation/gpu/drm-kms-helpers:326: ../drivers/gpu/drm/drm_edid.c:1626: WARNING: Duplicate C declaration, also defined in 'gpu/drm-km

Re: [PATCH v6 1/5] drm: Introduce plane and CRTC scaling filter properties

2020-10-13 Thread Simon Ser
On Monday, October 12, 2020 8:41 PM, Pankaj Bharadiya wrote: > +/** > + * DOC: CRTC scaling filter property > + * > + * SCALING_FILTER: > + * > + * Indicates scaling filter to be used for CRTC scaler > + * > + * The value of this property can be one of the following: > + * Default: > + *

Re: [PATCH v6 1/5] drm: Introduce plane and CRTC scaling filter properties

2020-10-13 Thread Simon Ser
> +/** > + * DOC: Plane scaling filter property > + * > + * SCALING_FILTER: > + * > + * Indicates scaling filter to be used for plane scaler > + * > + * The value of this property can be one of the following: > + * Default: > + * Driver's default scaling filter > + * Nearest Neigh

[PATCH v2 07/24] drm: amdgpu: kernel-doc: update some adev parameters

2020-10-13 Thread Mauro Carvalho Chehab
Running "make htmldocs: produce lots of warnings on those files: ./drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:177: warning: Excess function parameter 'man' description in 'amdgpu_vram_mgr_init' ./drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:177: warning: Excess function paramete

[PATCH v2 11/24] drm/dp: fix kernel-doc warnings at drm_dp_helper.c

2020-10-13 Thread Mauro Carvalho Chehab
As warned by kernel-doc: ./drivers/gpu/drm/drm_dp_helper.c:385: warning: Function parameter or member 'type' not described in 'drm_dp_downstream_is_type' ./drivers/gpu/drm/drm_dp_helper.c:886: warning: Function parameter or member 'dev' not described in 'drm_dp_downstream_mode'

[PATCH v2 12/24] drm/dp: fix a kernel-doc issue at drm_edid.c

2020-10-13 Thread Mauro Carvalho Chehab
The name of the argument is different, causing those warnings: ./drivers/gpu/drm/drm_edid.c:3754: warning: Function parameter or member 'video_code' not described in 'drm_display_mode_from_cea_vic' ./drivers/gpu/drm/drm_edid.c:3754: warning: Excess function parameter 'vic' descri

[PATCH v2 08/24] drm: kernel-doc: document drm_dp_set_subconnector_property() params

2020-10-13 Thread Mauro Carvalho Chehab
Changeset e5b92773287c ("drm: report dp downstream port type as a subconnector property") added a new function to the kAPI, but didn't add any documentation for the parameters for drm_dp_set_subconnector_property(). Fixes: e5b92773287c ("drm: report dp downstream port type as a subconnector prop

Re: [PATCH v2 07/24] drm: amdgpu: kernel-doc: update some adev parameters

2020-10-13 Thread Christian König
Am 13.10.20 um 14:14 schrieb Mauro Carvalho Chehab: Running "make htmldocs: produce lots of warnings on those files: ./drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:177: warning: Excess function parameter 'man' description in 'amdgpu_vram_mgr_init' ./drivers/gpu/drm/amd/amdgpu/amd

Re: [PATCH v2 7/8] dt-bindings: usb: convert mediatek,mtu3.txt to YAML schema

2020-10-13 Thread Rob Herring
On Tue, 13 Oct 2020 16:52:06 +0800, Chunfeng Yun wrote: > Convert mediatek,mtu3.txt to YAML schema mediatek,mtu3.yaml > > Signed-off-by: Chunfeng Yun > --- > v2: new patch > --- > .../devicetree/bindings/usb/mediatek,mtu3.txt | 108 - > .../bindings/usb/mediatek,mtu3.yaml | 227

Re: [PATCH] drm/amdgpu: fix semicolon.cocci warnings

2020-10-13 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Oct 12, 2020 at 5:21 PM kernel test robot wrote: > > From: kernel test robot > > drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c:608:2-3: Unneeded semicolon > > > Remove unneeded semicolon. > > Generated by: scripts/coccinelle/misc/semicolon.cocci > > Fixes: b4a7db71ea06

Re: [PATCH] drm/amd/display: remove no need return value

2020-10-13 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Oct 12, 2020 at 9:44 AM Bernard Zhao wrote: > > Functions (disable_all_writeback_pipes_for_stream & > dc_enable_stereo & dc_post_update_surfaces_to_stream) > always return true, there is no need to keep the return value. > This change is to make the code a bit more

Re: [PATCH v6 72/80] drm/amd/display: kernel-doc: document force_timing_sync

2020-10-13 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Oct 13, 2020 at 7:54 AM Mauro Carvalho Chehab wrote: > > As warned when running "make htmldocs": > > ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:345: warning: > Function parameter or member 'force_timing_sync' not described in > 'amdgpu_display_ma

Re: [PATCH v6 65/80] docs: amdgpu: fix a warning when building the documentation

2020-10-13 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Oct 13, 2020 at 7:54 AM Mauro Carvalho Chehab wrote: > > As reported by Sphinx: > > Documentation/gpu/amdgpu.rst:200: WARNING: Inline emphasis > start-string without end-string. > > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/gpu/amdgpu.rs

Re: [PATCH 2/3] drm/msm: add DRM_MSM_GEM_SYNC_CACHE for non-coherent cache maintenance

2020-10-13 Thread Robin Murphy
On 2020-10-07 07:25, Christoph Hellwig wrote: On Tue, Oct 06, 2020 at 09:19:32AM -0400, Jonathan Marek wrote: One example why drm/msm can't use DMA API is multiple page table support (that is landing in 5.10), which is something that definitely couldn't work with DMA API. Another one is being a

Re: [2/2] drm/msm: Add support for GPU cooling

2020-10-13 Thread Akhil P Oommen
On 10/12/2020 11:10 PM, m...@chromium.org wrote: On Mon, Oct 12, 2020 at 07:03:51PM +0530, Akhil P Oommen wrote: On 10/10/2020 12:06 AM, m...@chromium.org wrote: Hi Akhil, On Thu, Oct 08, 2020 at 10:39:07PM +0530, Akhil P Oommen wrote: Register GPU as a devfreq cooling device so that it can b

Re: [PATCH v3] drm: shmobile: Reduce include dependencies

2020-10-13 Thread Imre Deak
On Wed, Feb 26, 2020 at 03:44:06AM +0200, Laurent Pinchart wrote: > Hi Andy, > > Thank you for the patch, and sorry for the delay. > > On Mon, Feb 24, 2020 at 11:04:30AM +0200, Andy Shevchenko wrote: > > On Thu, Feb 06, 2020 at 01:12:32PM +0200, Andy Shevchenko wrote: > > > This file doesn't need

Re: [PATCH v6 0/5] Introduce drm scaling filter property

2020-10-13 Thread Simon Ser
On Monday, October 12, 2020 8:41 PM, Pankaj Bharadiya wrote: > Now, Sameer has implemented Integer scaling in Kodi Retro gaming > framework which demonstrate how Integer scaling gives distinctive > look to pixel art games when played on higher resolution monitors. > > Kodi patches are reviewed a

Re: [PATCH v9 1/5] dt-bindings: display: Add support for Intel KeemBay Display

2020-10-13 Thread Rob Herring
On Tue, Oct 13, 2020 at 12:24:38AM +, Chrisanthus, Anitha wrote: > Hi Neil, > > Thanks for your review, please see my reply inline. > > > -Original Message- > > From: Neil Armstrong > > Sent: Friday, October 9, 2020 2:10 AM > > To: Chrisanthus, Anitha ; dri- > > de...@lists.freedesk

Re: [PATCH 2/3] drm/msm: add DRM_MSM_GEM_SYNC_CACHE for non-coherent cache maintenance

2020-10-13 Thread Rob Clark
On Tue, Oct 13, 2020 at 6:42 AM Robin Murphy wrote: > > On 2020-10-07 07:25, Christoph Hellwig wrote: > > On Tue, Oct 06, 2020 at 09:19:32AM -0400, Jonathan Marek wrote: > >> One example why drm/msm can't use DMA API is multiple page table support > >> (that is landing in 5.10), which is something

Re: [Freedreno] [PATCH v2 22/22] drm/msm: Don't implicit-sync if only a single ring

2020-10-13 Thread Rob Clark
On Tue, Oct 13, 2020 at 4:08 AM Daniel Vetter wrote: > > On Mon, Oct 12, 2020 at 08:07:38AM -0700, Rob Clark wrote: > > On Mon, Oct 12, 2020 at 7:40 AM Daniel Vetter wrote: > > > > > > On Sun, Oct 11, 2020 at 07:09:49PM -0700, Rob Clark wrote: > > > > From: Rob Clark > > > > > > > > Any cross-de

Re: [2/2] drm/msm: Add support for GPU cooling

2020-10-13 Thread mka
On Tue, Oct 13, 2020 at 07:23:34PM +0530, Akhil P Oommen wrote: > On 10/12/2020 11:10 PM, m...@chromium.org wrote: > > On Mon, Oct 12, 2020 at 07:03:51PM +0530, Akhil P Oommen wrote: > > > On 10/10/2020 12:06 AM, m...@chromium.org wrote: > > > > Hi Akhil, > > > > > > > > On Thu, Oct 08, 2020 at 10

Re: [PATCH RFC PKS/PMEM 33/58] fs/cramfs: Utilize new kmap_thread()

2020-10-13 Thread Dan Williams
On Fri, Oct 9, 2020 at 12:52 PM wrote: > > From: Ira Weiny > > The kmap() calls in this FS are localized to a single thread. To avoid > the over head of global PKRS updates use the new kmap_thread() call. > > Cc: Nicolas Pitre > Signed-off-by: Ira Weiny > --- > fs/cramfs/inode.c | 10 +---

Re: [PATCH v2 11/24] drm/dp: fix kernel-doc warnings at drm_dp_helper.c

2020-10-13 Thread Lyude Paul
Reviewed-by: Lyude Paul On Tue, 2020-10-13 at 14:14 +0200, Mauro Carvalho Chehab wrote: > As warned by kernel-doc: > > ./drivers/gpu/drm/drm_dp_helper.c:385: warning: Function parameter or > member 'type' not described in 'drm_dp_downstream_is_type' > ./drivers/gpu/drm/drm_dp_helper.

Re: [2/2] drm/msm: Add support for GPU cooling

2020-10-13 Thread Akhil P Oommen
On 10/13/2020 11:10 PM, m...@chromium.org wrote: On Tue, Oct 13, 2020 at 07:23:34PM +0530, Akhil P Oommen wrote: On 10/12/2020 11:10 PM, m...@chromium.org wrote: On Mon, Oct 12, 2020 at 07:03:51PM +0530, Akhil P Oommen wrote: On 10/10/2020 12:06 AM, m...@chromium.org wrote: Hi Akhil, On Thu,

Re: [PATCH v2 12/24] drm/dp: fix a kernel-doc issue at drm_edid.c

2020-10-13 Thread Lyude Paul
Reviewed-by: Lyude Paul Thanks for the fixes! I will go ahead and push 11 and 12 to drm-misc-next. On Tue, 2020-10-13 at 14:14 +0200, Mauro Carvalho Chehab wrote: > The name of the argument is different, causing those warnings: > > ./drivers/gpu/drm/drm_edid.c:3754: warning: Function para

[PATCH V2] drm/i915/jsl: Split EHL/JSL platform info and PCI ids

2020-10-13 Thread Tejas Upadhyay
Recently we came across requirement to identify EHL and JSL platform to program them differently. Thus Split the basic platform definition, macros, and PCI IDs to differentiate between EHL and JSL platforms. Also, IS_ELKHARTLAKE is replaced with IS_JSL_EHL everywhere. Changes since V1 : -

Re: [PATCH RFC PKS/PMEM 33/58] fs/cramfs: Utilize new kmap_thread()

2020-10-13 Thread Dan Williams
On Tue, Oct 13, 2020 at 12:37 PM Matthew Wilcox wrote: > > On Tue, Oct 13, 2020 at 11:44:29AM -0700, Dan Williams wrote: > > On Fri, Oct 9, 2020 at 12:52 PM wrote: > > > > > > From: Ira Weiny > > > > > > The kmap() calls in this FS are localized to a single thread. To avoid > > > the over head

Re: [PATCH v2 12/24] drm/dp: fix a kernel-doc issue at drm_edid.c

2020-10-13 Thread Lyude Paul
wait, I think there's some confusion here. these patches have already been pushed On Tue, 2020-10-13 at 14:14 +0200, Mauro Carvalho Chehab wrote: > The name of the argument is different, causing those warnings: > > ./drivers/gpu/drm/drm_edid.c:3754: warning: Function parameter or member >

Re: [PATCH RFC PKS/PMEM 33/58] fs/cramfs: Utilize new kmap_thread()

2020-10-13 Thread Ira Weiny
On Tue, Oct 13, 2020 at 08:36:43PM +0100, Matthew Wilcox wrote: > On Tue, Oct 13, 2020 at 11:44:29AM -0700, Dan Williams wrote: > > On Fri, Oct 9, 2020 at 12:52 PM wrote: > > > > > > From: Ira Weiny > > > > > > The kmap() calls in this FS are localized to a single thread. To avoid > > > the over

Re: [PATCH RFC PKS/PMEM 33/58] fs/cramfs: Utilize new kmap_thread()

2020-10-13 Thread Ira Weiny
On Tue, Oct 13, 2020 at 09:01:49PM +0100, Al Viro wrote: > On Tue, Oct 13, 2020 at 08:36:43PM +0100, Matthew Wilcox wrote: > > > static inline void copy_to_highpage(struct page *to, void *vfrom, unsigned > > int size) > > { > > char *vto = kmap_atomic(to); > > > > memcpy(vto, vfrom, size

Re: [PATCH RFC PKS/PMEM 24/58] fs/freevxfs: Utilize new kmap_thread()

2020-10-13 Thread Ira Weiny
On Tue, Oct 13, 2020 at 12:25:44PM +0100, Christoph Hellwig wrote: > > - kaddr = kmap(pp); > > + kaddr = kmap_thread(pp); > > memcpy(kaddr, vip->vii_immed.vi_immed + offset, PAGE_SIZE); > > - kunmap(pp); > > + kunmap_thread(pp); > > You only Cced me on this particular patch, which mean

Re: [PATCH V2] drm/i915/jsl: Split EHL/JSL platform info and PCI ids

2020-10-13 Thread Matt Roper
On Wed, Oct 14, 2020 at 12:59:48AM +0530, Tejas Upadhyay wrote: > Recently we came across requirement to identify EHL and JSL > platform to program them differently. Thus Split the basic > platform definition, macros, and PCI IDs to differentiate > between EHL and JSL platforms. Also, IS_ELKHARTLAK

Re: [PATCH 2/3] drm/ingenic: Reset pixclock rate when parent clock rate changes

2020-10-13 Thread Stephen Boyd
Quoting Paul Cercueil (2020-09-25 05:29:12) > >> +static int ingenic_drm_update_pixclk(struct notifier_block *nb, > >> +unsigned long action, > >> +void *data) > >> +{ > >> + struct ingenic_drm *priv = drm_nb_get_priv(nb); > >>

RE: [PATCH v9 1/5] dt-bindings: display: Add support for Intel KeemBay Display

2020-10-13 Thread Paauwe, Bob J
> -Original Message- > From: dri-devel On Behalf Of Rob > Herring > Sent: Tuesday, October 13, 2020 8:43 AM > To: Chrisanthus, Anitha > Cc: devicet...@vger.kernel.org; Neil Armstrong ; > Dea, Edmund J ; dri-devel@lists.freedesktop.org; > Vetter, Daniel ; s...@ravnborg.org > Subject: Re: [

Re: [PATCH v2 2/2] drm/mediatek: mtk_hdmi: add MT8167 support for HDMI

2020-10-13 Thread Chun-Kuang Hu
Hi, Fabien: Fabien Parent 於 2020年10月14日 週三 上午2:19寫道: > > Add support for HDMI on MT8167. HDMI on MT8167 is similar to > MT8173/MT2701 execpt for the two registers: SYS_CFG1C and SYS_CFG20 > > Signed-off-by: Fabien Parent > --- > > Changelog: > v2: fix name of pdata structure > > drivers/gpu/drm

Re: [2/2] drm/msm: Add support for GPU cooling

2020-10-13 Thread mka
On Wed, Oct 14, 2020 at 12:51:55AM +0530, Akhil P Oommen wrote: > On 10/13/2020 11:10 PM, m...@chromium.org wrote: > > On Tue, Oct 13, 2020 at 07:23:34PM +0530, Akhil P Oommen wrote: > > > On 10/12/2020 11:10 PM, m...@chromium.org wrote: > > > > On Mon, Oct 12, 2020 at 07:03:51PM +0530, Akhil P Oom

Re: [PATCH v2 4/8] dt-bindings: phy: convert HDMI PHY binding to YAML schema

2020-10-13 Thread CK Hu
Hi, Chunfeng: On Tue, 2020-10-13 at 16:52 +0800, Chunfeng Yun wrote: > Convert HDMI PHY binding to YAML schema mediatek,ufs-phy.yaml > > Signed-off-by: Chunfeng Yun > --- > v2: fix binding check warning of reg in example > --- > .../display/mediatek/mediatek,hdmi.txt| 17 +--- > .../bin