Re: [PATCH 30/45] drm/ttm: add a new invalidate notify callback.

2020-09-29 Thread Christian König
Am 29.09.20 um 05:23 schrieb Dave Airlie: On Thu, 24 Sep 2020 at 22:25, Christian König wrote: Am 24.09.20 um 07:18 schrieb Dave Airlie: From: Dave Airlie Signed-off-by: Dave Airlie NAK, completely unnecessary. We should rather do the remaining accounting in the already existing release_n

Re: [PATCH 1/2] drm/bridge: sii902x: Enable I/O and core VCC supplies if present

2020-09-29 Thread Alex G.
On 9/26/20 1:49 PM, Sam Ravnborg wrote: Hi Alexandru On Thu, Sep 24, 2020 at 03:05:05PM -0500, Alexandru Gagniuc wrote: On the SII9022, the IOVCC and CVCC12 supplies must reach the correct voltage before the reset sequence is initiated. On most boards, this assumption is true at boot-up, so ini

Re: [PATCH v1 2/2] drm/rockchip: fix warning from cdn_dp_resume

2020-09-29 Thread Enric Balletbo i Serra
Hi Sam, Thank you for your patch. On 25/9/20 23:55, Sam Ravnborg wrote: > Commit 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make > cdn_dp_core_suspend/resume static") > introduced the following warning in some builds: > > cdn-dp-core.c:1124:12: warning: ‘cdn_dp_resume’ defined but not used > 11

Re: 5.9-rc7 null ptr deref in __i915_gem_userptr_get_pages_worker

2020-09-29 Thread Jason A. Donenfeld
Alright, the failing code seems to be in mm: if (flags & FOLL_PIN) atomic_set(¤t->mm->has_pinned, 1); Apparently you can't rely on current->mm being valid in this context; it's null here, hence the +0x64 for has_pinned's offset. This was added by 008cfe4418b3 ("mm: Introd

Re: [PATCHv5 5/6] iommu: arm-smmu-impl: Use table to list QCOM implementations

2020-09-29 Thread Sai Prakash Ranjan
On 2020-09-23 20:54, Robin Murphy wrote: On 2020-09-22 07:18, Sai Prakash Ranjan wrote: Use table and of_match_node() to match qcom implementation instead of multiple of_device_compatible() calls for each QCOM SMMU implementation. Signed-off-by: Sai Prakash Ranjan --- drivers/iommu/arm/arm-s

Re: [External] Re: [PATCH 2/2] sched: mark PRINTK_DEFERRED_CONTEXT_MASK in __schedule()

2020-09-29 Thread Chengming Zhou
在 2020/9/28 下午5:01, Peter Zijlstra 写道: > On Mon, Sep 28, 2020 at 04:54:53PM +0800, Chengming Zhou wrote: >> 在 2020/9/28 下午3:32, Peter Zijlstra 写道: >>> On Mon, Sep 28, 2020 at 12:11:30AM +0800, Chengming Zhou wrote: The WARN_ON/WARN_ON_ONCE with rq lock held in __schedule() should be defe

[PATCH] drm/msm/dpu: Add newline to printks

2020-09-29 Thread Stephen Boyd
Printk messages need newlines. Add it here. Cc: Abhinav Kumar Cc: Jeykumar Sankaran Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/g

Re: [PATCHv5 4/6] drm/msm/a6xx: Add support for using system cache(LLC)

2020-09-29 Thread Sai Prakash Ranjan
Hi Jordan, On 2020-09-23 20:33, Jordan Crouse wrote: On Tue, Sep 22, 2020 at 11:48:17AM +0530, Sai Prakash Ranjan wrote: From: Sharat Masetty The last level system cache can be partitioned to 32 different slices of which GPU has two slices preallocated. One slice is used for caching GPU buffe

Re: [PATCH] drm/amd/display: add debugfs entry for trigger_hotplug

2020-09-29 Thread Jason Yan
ping... 在 2020/9/12 10:22, Jason Yan 写道: The 'trigger_hotplug' entry in debugfs is defined but not wired up. This causes a gcc warning build with W=1. drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:2045:37: warning: ‘dp_trigger_hotplug_debugfs_fops’ defined but not used [-W

5.9-rc7 null ptr deref in __i915_gem_userptr_get_pages_worker

2020-09-29 Thread Jason A. Donenfeld
Seeing a new crash in 5.9-rc7 I didn't have in 5.9-rc6: [ 1311.596896] BUG: kernel NULL pointer dereference, address: 0064 [ 1311.596898] #PF: supervisor write access in kernel mode [ 1311.596899] #PF: error_code(0x0002) - not-present page [ 1311.596899] PGD 0 P4D 0 [ 1311.596901] Oops

Re: linux-next: build failure after merge of the drm tree

2020-09-29 Thread Paul Cercueil
Le lun. 28 sept. 2020 à 14:10, Christoph Hellwig a écrit : On Mon, Sep 28, 2020 at 01:46:55PM +0200, Paul Cercueil wrote: dma_mmap_attrs can only be used on allocations from dma_mmap_attrs with the same attrs. As there is no allocation using DMA_ATTR_NON_CONSISTENT in the drm core, so

Re: [PATCH RFC v7 5/6] dt-bindings: display: add Unisoc's mipi dsi&dphy bindings

2020-09-29 Thread Maxime Ripard
Hi! On Mon, Sep 28, 2020 at 02:27:39PM +0800, Kevin Tang wrote: > From: Kevin Tang > > Adds MIPI DSI Master and MIPI DSI-PHY (D-PHY) > support for Unisoc's display subsystem. > > RFC v7: > - Fix DTC unit name warnings > - Fix the problem of maintainers > > Cc: Orson Zhai > Cc: Chunyan Zha

Re: [PATCH] drm: bridge: adv7511: make adv7511_hdmi_hw_params() static

2020-09-29 Thread Jason Yan
ping... 在 2020/9/12 11:38, Jason Yan 写道: This eliminates the following sparse warning: drivers/gpu/drm/bridge/adv7511/adv7511_audio.c:58:5: warning: symbol 'adv7511_hdmi_hw_params' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/gpu/drm/b

[PATCH v3] drm/hisilicon: Deleted the drm_device declaration

2020-09-29 Thread Tian Tao
drm_framebuffer.h already declares struct drm_device, so there's no need to declare it in hibm_drm_drv.h v2: fixed spelling errors in commit message. v3: rewrite the commit message. Signed-off-by: Tian Tao Acked-by: Thomas Zimmermann --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 2 --

Re: linux-next: build failure after merge of the drm tree

2020-09-29 Thread Paul Cercueil
Le lun. 28 sept. 2020 à 13:34, Christoph Hellwig a écrit : On Mon, Sep 28, 2020 at 12:15:56PM +0200, Paul Cercueil wrote: Hi Christoph, Le lun. 28 sept. 2020 à 8:04, Christoph Hellwig a écrit : On Mon, Sep 28, 2020 at 01:54:05PM +1000, Stephen Rothwell wrote: Hi all, After merg

Re: [PATCH] vt_ioctl: make VT_RESIZEX behave like VT_RESIZE

2020-09-29 Thread Martin Hostettler
On Sun, Sep 27, 2020 at 08:46:30PM +0900, Tetsuo Handa wrote: > VT_RESIZEX was introduced in Linux 1.3.3, but it is unclear that what > comes to the "+ more" part, and I couldn't find a user of VT_RESIZEX. > It seems this is/was used by "svgatextmode" which seems to be at http://www.ibiblio.org/p

Re: 5.9-rc7 null ptr deref in __i915_gem_userptr_get_pages_worker

2020-09-29 Thread Jason A. Donenfeld
Increasing the CC list a bit, as i915 didn't really get much churn rc6->rc7, but mm/gup.c did, and mm has had a lot of recent changes. On Mon, Sep 28, 2020 at 11:39 AM Jason A. Donenfeld wrote: > > Seeing a new crash in 5.9-rc7 I didn't have in 5.9-rc6: > > [ 1311.596896] BUG: kernel NULL pointer

Re: 5.9-rc7 null ptr deref in __i915_gem_userptr_get_pages_worker

2020-09-29 Thread Jason A. Donenfeld
Oh, this is just a copy and paste error, when the code was originally pasted from internal_get_user_pages_fast, which assumes a current. I'll fix this up and send a patch shortly. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.fr

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-09-29 Thread Marcin Skarbek
Hi Deepak, I have tested your patch using Fedora 32 as a guest and Windows 10 Pro 1809 as host (Gen 2 VM). No issues with building or loading the kernel module and I have successfully run SwayWM inside VM using hyperv_drm. Unfortunately, I'm unable to change the resolution beyond FHD. I have a WQH

Re: [PATCH v2] drm/msm/dp: return correct connection status after suspend

2020-09-29 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-09-26 13:34:54) > At dp_pm_resume, reinitialize both dp host controller and hpd block dp_pm_resume() > so that hpd connection can be detected at realtime by reading hpd state > status register. Also hpd plug interrupt can be generated accordingly. Can you describe more

Re: [PATCH] mm: do not rely on mm == current->mm in __get_user_pages_locked

2020-09-29 Thread Jason Gunthorpe
On Mon, Sep 28, 2020 at 12:35:07PM +0200, Jason A. Donenfeld wrote: > It seems likely this block was pasted from internal_get_user_pages_fast, > which is not passed an mm struct and therefore uses current's. But > __get_user_pages_locked is passed an explicit mm, and current->mm is not > always val

[PATCH] drm/hisilicon: Using the to_hibmc_drm_private to convert

2020-09-29 Thread Tian Tao
Using the to_hibmc_drm_private to convert over all uses of dev_private over to the function, and fix a little formatting issue. Signed-off-by: Tian Tao --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 22 +++--- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 5 ++--- d

Re: [PATCH] dt-bindings: Fix 'reg' size issues in zynqmp examples

2020-09-29 Thread Michal Simek
Hi Rob, On 28. 09. 20 17:59, Rob Herring wrote: > The default sizes in examples for 'reg' are 1 cell each. Fix the > incorrect sizes in zynqmp examples: > > Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.example.dt.yaml: > example-0: dma-controller@fd4c:reg:0: [0, 4249616384,

Re: [PATCH v6] drm/i915: Init lspcon after HPD in intel_dp_detect()

2020-09-29 Thread Kai-Heng Feng
Hi Jani, > On Jul 10, 2020, at 23:48, Kai-Heng Feng wrote: > > > >> On Jun 30, 2020, at 16:37, Kai-Heng Feng wrote: >> >> >>> On Jun 10, 2020, at 15:55, Kai-Heng Feng >>> wrote: >>> >>> On HP 800 G4 DM, if HDMI cable isn't plugged before boot, the HDMI port >>> becomes useless and never

[PATCH v2 1/2] drm/bridge: sii902x: Enable I/O and core VCC supplies if present

2020-09-29 Thread Alexandru Gagniuc
On the SII9022, the IOVCC and CVCC12 supplies must reach the correct voltage before the reset sequence is initiated. On most boards, this assumption is true at boot-up, so initialization succeeds. However, when we try to initialize the chip with incorrect supply voltages, it will not respond to I2

Re: [PATCH] vt_ioctl: make VT_RESIZEX behave like VT_RESIZE

2020-09-29 Thread Tetsuo Handa
On 2020/09/29 2:59, Martin Hostettler wrote: > On Sun, Sep 27, 2020 at 08:46:30PM +0900, Tetsuo Handa wrote: >> VT_RESIZEX was introduced in Linux 1.3.3, but it is unclear that what >> comes to the "+ more" part, and I couldn't find a user of VT_RESIZEX. >> > > It seems this is/was used by "svgate

[PATCH v2] drm/hisilicon: Using the to_hibmc_drm_private to convert

2020-09-29 Thread Tian Tao
Using the to_hibmc_drm_private to convert over all uses of dev_private, and fix a little formatting issue. v2: fixed the commit message. Signed-off-by: Tian Tao Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 22 +++--- drivers/gpu/drm/hisi

Re: [PATCHv5 4/6] drm/msm/a6xx: Add support for using system cache(LLC)

2020-09-29 Thread Sai Prakash Ranjan
On 2020-09-28 21:41, Jordan Crouse wrote: On Mon, Sep 28, 2020 at 05:56:55PM +0530, Sai Prakash Ranjan wrote: Hi Jordan, On 2020-09-23 20:33, Jordan Crouse wrote: >On Tue, Sep 22, 2020 at 11:48:17AM +0530, Sai Prakash Ranjan wrote: >>From: Sharat Masetty >> >>The last level system cache can be

[PATCH v2 2/2] dt-bindings: display: sii902x: Add supply bindings

2020-09-29 Thread Alexandru Gagniuc
The sii902x chip family requires IO and core voltages to reach the correct voltage before chip initialization. Add binding for describing the two supplies. Signed-off-by: Alexandru Gagniuc --- Changes since v1: * Nothing. version incremented to stay in sync with sii902x regulator patch Docu

Re: linux-next: build failure after merge of the drm tree

2020-09-29 Thread Paul Cercueil
Hi Christoph, Le lun. 28 sept. 2020 à 8:04, Christoph Hellwig a écrit : On Mon, Sep 28, 2020 at 01:54:05PM +1000, Stephen Rothwell wrote: Hi all, After merging the drm tree, today's linux-next build (x86_64 allmodconfig) failed like this: The driver needs to switch do dma_alloc_noncohe

Re: [PATCH RFC v7 5/6] dt-bindings: display: add Unisoc's mipi dsi&dphy bindings

2020-09-29 Thread Kevin Tang
Hi maxime, Sorry, I forgot to describe ports subnode with my two port@X, i will be fix it. Thanks for reminding Maxime Ripard 于2020年9月28日周一 下午4:20写道: > > Hi! > > On Mon, Sep 28, 2020 at 02:27:39PM +0800, Kevin Tang wrote: > > From: Kevin Tang > > > > Adds MIPI DSI Master and MIPI DSI-PHY (D-PHY

Re: [PATCH RFC v7 1/6] dt-bindings: display: add Unisoc's drm master bindings

2020-09-29 Thread Maxime Ripard
Hi! On Mon, Sep 28, 2020 at 02:27:35PM +0800, Kevin Tang wrote: > From: Kevin Tang > > The Unisoc DRM master device is a virtual device needed to list all > DPU devices or other display interface nodes that comprise the > graphics subsystem > > RFC v7: > - Fix DTC unit name warnings > - Fix

[PATCH] mm: do not rely on mm == current->mm in __get_user_pages_locked

2020-09-29 Thread Jason A. Donenfeld
It seems likely this block was pasted from internal_get_user_pages_fast, which is not passed an mm struct and therefore uses current's. But __get_user_pages_locked is passed an explicit mm, and current->mm is not always valid. This was hit when being called from i915, which uses: pin_user_pages_

Re: [v3 PATCH] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-09-29 Thread Bilal Wasim
Hi Jitao, On Thu, 17 Sep 2020 11:30:09 +0800 Jitao Shi wrote: > Replace horizontal_backporch_byte with vm->hback_porch * bpp to aovid > flowing judgement negative number. > > if ((vm->hfront_porch * dsi_tmp_buf_bpp + horizontal_backporch_byte) > > data_phy_cycles * dsi->lanes + delta) >

[PATCH] drm/hisilicon: Delete the unused macro

2020-09-29 Thread Tian Tao
The macro PADDING is no longer used. Delete it. Signed-off-by: Tian Tao --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c index 4d57ec6..b3a81da

Re: [PATCH RFC v7 1/6] dt-bindings: display: add Unisoc's drm master bindings

2020-09-29 Thread Kevin Tang
Hi Rob, Component framework include master and component, here is master subnode. It seems that everyone else does it, why not me? Your comments on v6: "We generally try to avoid this virtual node as it doesn't represent any h/w. Can't you bind the driver to the DPU directly?" I'm sorry, maybe is

RE: [PATCH v2] ARM: dts: r8a7742-iwg21d-q7: Add LCD support

2020-09-29 Thread Prabhakar Mahadev Lad
Hi Geert, > -Original Message- > From: Geert Uytterhoeven > Sent: 28 September 2020 08:26 > To: Lad, Prabhakar > Cc: Prabhakar Mahadev Lad ; Magnus > Damm ; Rob Herring > ; DRI Development ; > Linux-Renesas ; open > list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS > ; LKML ; > La

Re: [PATCH] drm/bridge: analogix_dp: make analogix_dp_start_aux_transaction() static

2020-09-29 Thread Jason Yan
ping... 在 2020/9/12 11:38, Jason Yan 写道: This eliminates the following sparse warning: drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c:527:5: warning: symbol 'analogix_dp_start_aux_transaction' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: Jason Yan --- dr

Re: [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops

2020-09-29 Thread Sam Ravnborg
On Tue, Sep 29, 2020 at 08:53:06AM +0200, Thomas Zimmermann wrote: > Hi Sam > > Am 25.09.20 um 23:55 schrieb Sam Ravnborg: > > Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs") > > introduced the following build error: > > > > rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_

Re: [PATCH] drm/hisilicon: Delete the unused macro

2020-09-29 Thread Thomas Zimmermann
Am 29.09.20 um 02:45 schrieb Tian Tao: > The macro PADDING is no longer used. Delete it. > > Signed-off-by: Tian Tao Reviewed-by: Thomas Zimmermann > --- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/hisilicon/hib

Re: [PATCH] Revert "video: fbdev: amba-clcd: Retire elder CLCD driver"

2020-09-29 Thread Neil Armstrong
Hi, On 28/09/2020 22:08, Peter Collingbourne wrote: > Also revert the follow-up change "drm: pl111: Absorb the external > register header". > > This reverts commits 7e4e589db76a3cf4c1f534eb5a09cc6422766b93 > and 0fb8125635e8eb5483fb095f98dcf0651206a7b8. > > The fbdev driver is used by Android's

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-29 Thread Jani Nikula
On Mon, 28 Sep 2020, Matt Roper wrote: > On Mon, Sep 28, 2020 at 04:07:39PM -0700, Lucas De Marchi wrote: >> On Mon, Sep 28, 2020 at 08:15:29PM +0300, Jani Nikula wrote: >> > On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX" >> > wrote: >> > > This is a good example of a potential trap

Re: [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops

2020-09-29 Thread Thomas Zimmermann
Hi Sam Am 29.09.20 um 09:17 schrieb Sam Ravnborg: > On Tue, Sep 29, 2020 at 08:53:06AM +0200, Thomas Zimmermann wrote: >> Hi Sam >> >> Am 25.09.20 um 23:55 schrieb Sam Ravnborg: >>> Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs") >>> introduced the following build error: >>>

Re: [PATCH 8/9] drm: Add infrastructure for platform devices

2020-09-29 Thread Thomas Zimmermann
Hi Am 29.06.20 um 11:27 schrieb Daniel Vetter: > On Thu, Jun 25, 2020 at 02:00:10PM +0200, Thomas Zimmermann wrote: >> Platform devices might operate on firmware framebuffers, such as VESA or >> EFI. Before a native driver for the graphics hardware can take over the >> device, it has to remove any

Re: [patch 00/13] preempt: Make preempt count unconditional

2020-09-29 Thread Daniel Vetter
On Tue, Sep 29, 2020 at 10:19:38AM +0200, Michal Hocko wrote: > On Wed 16-09-20 23:43:02, Daniel Vetter wrote: > > I can > > then figure out whether it's better to risk not spotting issues with > > call_rcu vs slapping a memalloc_noio_save/restore around all these > > critical section which force-d

Re: [PATCH 0/3] Prevent out-of-bounds access for built-in font data buffers

2020-09-29 Thread Daniel Vetter
On Fri, Sep 25, 2020 at 11:35:09AM -0400, Peilin Ye wrote: > On Fri, Sep 25, 2020 at 03:25:51PM +0200, Daniel Vetter wrote: > > I think the only way to make this work is that we have one place which > > takes in the userspace uapi struct, and then converts it once into a > > kernel_console_font. Wi

Re: [PATCH v3 0/4] dma-buf: Flag vmap'ed memory as system or I/O memory

2020-09-29 Thread Daniel Vetter
On Mon, Sep 28, 2020 at 01:22:13PM +0200, Christian König wrote: > Am 28.09.20 um 09:37 schrieb Thomas Zimmermann: > > Hi > > > > Am 28.09.20 um 08:50 schrieb Christian König: > > > Am 27.09.20 um 21:16 schrieb Sam Ravnborg: > > > > Hi Thomas. > > > > > > > > > > struct simap { > > > > > >  

Re: [PATCH 1/9] drm/format-helper: Pass destination pitch to drm_fb_memcpy_dstclip()

2020-09-29 Thread Daniel Vetter
On Mon, Sep 28, 2020 at 11:13:06AM +0200, Thomas Zimmermann wrote: > Hi > > Am 28.09.20 um 10:53 schrieb Daniel Vetter: > > On Mon, Sep 28, 2020 at 9:22 AM Thomas Zimmermann > > wrote: > >> > >> Hi > >> > >> Am 26.09.20 um 18:42 schrieb Daniel Vetter: > >>> On Fri, Sep 25, 2020 at 4:55 PM Thomas

Re: [PATCH 8/9] drm: Add infrastructure for platform devices

2020-09-29 Thread Daniel Vetter
On Tue, Sep 29, 2020 at 10:59:10AM +0200, Thomas Zimmermann wrote: > Hi > > Am 29.06.20 um 11:27 schrieb Daniel Vetter: > > On Thu, Jun 25, 2020 at 02:00:10PM +0200, Thomas Zimmermann wrote: > >> Platform devices might operate on firmware framebuffers, such as VESA or > >> EFI. Before a native dri

Re: [PATCH v4 0/4] drm: panel: add support for TDO tl070wsh30 panel

2020-09-29 Thread Neil Armstrong
Hi Sam, Is there anything more to change ? Thanks, Neil On 15/09/2020 14:19, Neil Armstrong wrote: > This adds support bindings and support for the TDO TL070WSH30 TFT-LCD panel > module shipped with the Amlogic S400 Development Kit. > The panel has a 1024×600 resolution and uses 24 bit RGB per p

Re: [PATCH] Revert "video: fbdev: amba-clcd: Retire elder CLCD driver"

2020-09-29 Thread Daniel Vetter
On Tue, Sep 29, 2020 at 09:28:56AM +0200, Neil Armstrong wrote: > Hi, > > On 28/09/2020 22:08, Peter Collingbourne wrote: > > Also revert the follow-up change "drm: pl111: Absorb the external > > register header". > > > > This reverts commits 7e4e589db76a3cf4c1f534eb5a09cc6422766b93 > > and 0fb81

Re: [PATCH -next] drm/qxl: simplify the return expression of qxl_plane_prepare_fb()

2020-09-29 Thread Gerd Hoffmann
On Mon, Sep 21, 2020 at 09:10:22PM +0800, Qinglang Miao wrote: > Simplify the return expression. Pushed to drm-misc-next. thanks, Gerd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 01/19] drm/virtio: blob prep: refactor getting pages and attaching backing

2020-09-29 Thread Gerd Hoffmann
On Wed, Sep 23, 2020 at 05:31:56PM -0700, Gurchetan Singh wrote: > Useful for upcoming blob resources. Pushed to drm-misc-next (whole series). thanks, Gerd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailm

Re: [PATCH 1/9] drm/format-helper: Pass destination pitch to drm_fb_memcpy_dstclip()

2020-09-29 Thread Thomas Zimmermann
Hi Am 29.09.20 um 11:19 schrieb Daniel Vetter: > On Mon, Sep 28, 2020 at 11:13:06AM +0200, Thomas Zimmermann wrote: >> Hi >> >> Am 28.09.20 um 10:53 schrieb Daniel Vetter: >>> On Mon, Sep 28, 2020 at 9:22 AM Thomas Zimmermann >>> wrote: Hi Am 26.09.20 um 18:42 schrieb Daniel

Re: [PATCH v10 0/8] Asynchronous flip implementation for i915

2020-09-29 Thread Karthik B S
On 9/28/2020 5:48 PM, Ville Syrjälä wrote: On Mon, Sep 21, 2020 at 04:32:02PM +0530, Karthik B S wrote: Without async flip support in the kernel, fullscreen apps where game resolution is equal to the screen resolution, must perform an extra blit per frame prior to flipping. Asynchronous page

[PATCH v2 0/4] drm/qxl: fix stale mm entries on driver shutdown

2020-09-29 Thread Gerd Hoffmann
v2: repost, add a pin fix. Gerd Hoffmann (4): drm/qxl: use drmm_mode_config_init drm/qxl: release shadow on shutdown drm/qxl: handle shadow in primary destroy drm/qxl: use qxl pin function drivers/gpu/drm/qxl/qxl_display.c | 11 +-- drivers/gpu/drm/qxl/qxl_object.c | 2 +- 2 fi

[PATCH v2 3/4] drm/qxl: handle shadow in primary destroy

2020-09-29 Thread Gerd Hoffmann
qxl_primary_atomic_disable must check whenever the framebuffer bo has a shadow surface and in case it has check the shadow primary status. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b

[PATCH v2 4/4] drm/qxl: use qxl pin function

2020-09-29 Thread Gerd Hoffmann
Otherwise ttm throws a WARN because we try to pin without a reservation. Fixes: 9d36d4320462 ("drm/qxl: switch over to the new pin interface") Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl

[PATCH v2 2/4] drm/qxl: release shadow on shutdown

2020-09-29 Thread Gerd Hoffmann
In case we have a shadow surface on shutdown release it so it doesn't leak. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_display.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c index 5bef8f121e54..1d9c51

[PATCH v2 1/4] drm/qxl: use drmm_mode_config_init

2020-09-29 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/qxl/qxl_display.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c index 65de1f69af58..5bef8f121e54 100644 --- a/drivers/gpu/

Re: [PATCH v2 4/4] drm/qxl: use qxl pin function

2020-09-29 Thread Daniel Vetter
On Tue, Sep 29, 2020 at 11:51:15AM +0200, Gerd Hoffmann wrote: > Otherwise ttm throws a WARN because we try to pin without a reservation. > > Fixes: 9d36d4320462 ("drm/qxl: switch over to the new pin interface") > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/qxl/qxl_object.c | 2 +- > 1

[PATCH 4.4 36/85] drm/omap: fix possible object reference leak

2020-09-29 Thread Greg Kroah-Hartman
From: Wen Yang [ Upstream commit 47340e46f34a3b1d80e40b43ae3d7a8da34a3541 ] The call to of_find_matching_node returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: drivers/gpu/drm/omapdrm

Re: [PATCH v3 0/4] dma-buf: Flag vmap'ed memory as system or I/O memory

2020-09-29 Thread Christian König
Am 29.09.20 um 11:14 schrieb Daniel Vetter: On Mon, Sep 28, 2020 at 01:22:13PM +0200, Christian König wrote: Am 28.09.20 um 09:37 schrieb Thomas Zimmermann: Hi Am 28.09.20 um 08:50 schrieb Christian König: Am 27.09.20 um 21:16 schrieb Sam Ravnborg: Hi Thomas. struct simap {     union

Re: [PATCH v3 0/4] dma-buf: Flag vmap'ed memory as system or I/O memory

2020-09-29 Thread Thomas Zimmermann
Am 29.09.20 um 13:09 schrieb Christian König: > Am 29.09.20 um 11:14 schrieb Daniel Vetter: >> On Mon, Sep 28, 2020 at 01:22:13PM +0200, Christian König wrote: >>> Am 28.09.20 um 09:37 schrieb Thomas Zimmermann: Hi Am 28.09.20 um 08:50 schrieb Christian König: > Am 27.09.20 um

[PATCH 4.14 064/166] drm/omap: fix possible object reference leak

2020-09-29 Thread Greg Kroah-Hartman
From: Wen Yang [ Upstream commit 47340e46f34a3b1d80e40b43ae3d7a8da34a3541 ] The call to of_find_matching_node returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: drivers/gpu/drm/omapdrm

[PATCH] Revert "video: fbdev: amba-clcd: Retire elder CLCD driver"

2020-09-29 Thread Peter Collingbourne
Also revert the follow-up change "drm: pl111: Absorb the external register header". This reverts commits 7e4e589db76a3cf4c1f534eb5a09cc6422766b93 and 0fb8125635e8eb5483fb095f98dcf0651206a7b8. The fbdev driver is used by Android's FVP configuration. Using the DRM driver together with DRM's fbdev e

[PATCH 4.9 049/121] drm/omap: fix possible object reference leak

2020-09-29 Thread Greg Kroah-Hartman
From: Wen Yang [ Upstream commit 47340e46f34a3b1d80e40b43ae3d7a8da34a3541 ] The call to of_find_matching_node returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: drivers/gpu/drm/omapdrm

[PATCH] drm/qxl: fix usage of ttm_bo_init

2020-09-29 Thread Christian König
We need to use ttm_bo_init_reserved here to make sure that the BO is pinned before it becomes visible on the LRU. Signed-off-by: Christian König --- drivers/gpu/drm/qxl/qxl_object.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_object.c b/dri

Re: [PATCH v2 4/4] drm/qxl: use qxl pin function

2020-09-29 Thread Christian König
Am 29.09.20 um 12:53 schrieb Daniel Vetter: On Tue, Sep 29, 2020 at 11:51:15AM +0200, Gerd Hoffmann wrote: Otherwise ttm throws a WARN because we try to pin without a reservation. Fixes: 9d36d4320462 ("drm/qxl: switch over to the new pin interface") Signed-off-by: Gerd Hoffmann --- drivers/g

[PATCH 4.19 077/245] drm/omap: fix possible object reference leak

2020-09-29 Thread Greg Kroah-Hartman
From: Wen Yang [ Upstream commit 47340e46f34a3b1d80e40b43ae3d7a8da34a3541 ] The call to of_find_matching_node returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: drivers/gpu/drm/omapdrm

Re: [PATCH 1/9] drm/format-helper: Pass destination pitch to drm_fb_memcpy_dstclip()

2020-09-29 Thread Daniel Vetter
On Tue, Sep 29, 2020 at 11:39:21AM +0200, Thomas Zimmermann wrote: > Hi > > Am 29.09.20 um 11:19 schrieb Daniel Vetter: > > On Mon, Sep 28, 2020 at 11:13:06AM +0200, Thomas Zimmermann wrote: > >> Hi > >> > >> Am 28.09.20 um 10:53 schrieb Daniel Vetter: > >>> On Mon, Sep 28, 2020 at 9:22 AM Thomas

Re: [PATCH] drm/qxl: fix usage of ttm_bo_init

2020-09-29 Thread Daniel Vetter
On Tue, Sep 29, 2020 at 01:23:06PM +0200, Christian König wrote: > We need to use ttm_bo_init_reserved here to make sure > that the BO is pinned before it becomes visible on the LRU. > > Signed-off-by: Christian König Reviewed-by: Daniel Vetter But maybe let Gerd test this first before pushing

[PATCH 5.4 119/388] drm/omap: fix possible object reference leak

2020-09-29 Thread Greg Kroah-Hartman
From: Wen Yang [ Upstream commit 47340e46f34a3b1d80e40b43ae3d7a8da34a3541 ] The call to of_find_matching_node returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: drivers/gpu/drm/omapdrm

Re: [PATCH] drm/qxl: fix usage of ttm_bo_init

2020-09-29 Thread Gerd Hoffmann
On Tue, Sep 29, 2020 at 01:23:06PM +0200, Christian König wrote: > We need to use ttm_bo_init_reserved here to make sure > that the BO is pinned before it becomes visible on the LRU. > > Signed-off-by: Christian König Reviewed-by: Gerd Hoffmann # Tested-by: Gerd Hoffmann # ___

[PATCH v2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-29 Thread Tejas Upadhyay
JSL has update in vswing table for eDP BSpec: 21257 Changes since V1 : - IS_ELKHARTLAKE and IS_JASPERLAKE is replaced with HAS_PCH_MCC(EHL) and HAS_PCH_JSP(JSL) respectively - Reverted EHL/JSL PCI ids split change Signed-off-by: Tejas Upadhyay --- drivers/gpu/drm/i91

Re: remove alloc_vm_area v2

2020-09-29 Thread Joonas Lahtinen
Quoting Christoph Hellwig (2020-09-28 15:37:41) > On Mon, Sep 28, 2020 at 01:13:38PM +0300, Joonas Lahtinen wrote: > > I think we have a gap that after splitting the drm-intel-next pull requests > > into > > two the drm-intel/for-linux-next branch is now missing material from > > drm-intel/drm-int

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-29 Thread Ville Syrjälä
On Mon, Sep 28, 2020 at 08:20:59PM +0300, Jani Nikula wrote: > On Mon, 28 Sep 2020, Ville Syrjälä wrote: > > On Mon, Sep 28, 2020 at 07:15:43AM -0700, James Ausmus wrote: > >> On Mon, Sep 28, 2020 at 04:43:11PM +0300, Jani Nikula wrote: > >> > On Mon, 28 Sep 2020, Tejas Upadhyay > >> > wrote: >

Re: [PATCH v2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-29 Thread Ville Syrjälä
On Tue, Sep 29, 2020 at 05:41:27PM +0530, Tejas Upadhyay wrote: > JSL has update in vswing table for eDP > > BSpec: 21257 > > Changes since V1 : > - IS_ELKHARTLAKE and IS_JASPERLAKE is replaced with > HAS_PCH_MCC(EHL) and HAS_PCH_JSP(JSL) respectively What do vswing values have

RE: [PATCH v2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-29 Thread Surendrakumar Upadhyay, TejaskumarX
-Original Message- From: Ville Syrjälä Sent: 29 September 2020 18:23 To: Surendrakumar Upadhyay, TejaskumarX Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Ausmus, James ; Roper, Matthew D ; Souza, Jose ; De Marchi, Lucas ; Pandey, Hariom Subject: Re: [PATC

[PATCH v2] drm: bridge: cdns-mhdp8546: fix compile warning

2020-09-29 Thread Tomi Valkeinen
On x64 we get: drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:751:10: warning: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744073709551613' to '4294967293' [-Woverflow] The registers are 32 bit, so fix by casting to u32. Fixes: fb43aa0acdfd ("drm: bridge

Re: [PATCH v2 2/2] drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data

2020-09-29 Thread Tomi Valkeinen
On 20/09/2020 19:59, Jyri Sarha wrote: > We already have a private data member for maximum display width so > let's use it and get rid of the redundant tilcdc_crtc_max_width(). > > The LCDC version probing is moved to before reading the device tree > properties so that the version information is a

[Bug 209417] kernel-5.8*, amdgpu - Blank screen shortly after boot, "fixed" with suspend and wake up

2020-09-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209417 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

Re: [PATCH 0/3] Prevent out-of-bounds access for built-in font data buffers

2020-09-29 Thread Daniel Vetter
On Tue, Sep 29, 2020 at 2:34 PM Peilin Ye wrote: > > On Fri, Sep 25, 2020 at 03:25:51PM +0200, Daniel Vetter wrote: > > I think the only way to make this work is that we have one place which > > takes in the userspace uapi struct, and then converts it once into a > > kernel_console_font. With all

Re: [PATCH] drm/nouveau: Drop mutex_lock_nested for atomic

2020-09-29 Thread Daniel Vetter
On Thu, Sep 17, 2020 at 3:15 PM Daniel Vetter wrote: > > Ben, did you have a chance to look at this? Ping -Daniel > On Mon, Aug 3, 2020 at 1:22 PM Maarten Lankhorst > wrote: > > > > Op 02-08-2020 om 20:18 schreef Daniel Vetter: > > > Purely conjecture, but I think the original locking inversion

Re: [PATCH] dt-bindings: Fix 'reg' size issues in zynqmp examples

2020-09-29 Thread Rob Herring
On Tue, Sep 29, 2020 at 1:55 AM Michal Simek wrote: > > Hi Rob, > > On 28. 09. 20 17:59, Rob Herring wrote: > > The default sizes in examples for 'reg' are 1 cell each. Fix the > > incorrect sizes in zynqmp examples: > > > > Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.example.dt

[PATCH] drm: update todo.rst

2020-09-29 Thread Daniel Vetter
- debugfs cleanup has moved forward thanks to the cleanup Wambui has done Cc: Wambui Karuga Cc: Greg Kroah-Hartman Cc: Melissa Wen Signed-off-by: Daniel Vetter --- Documentation/gpu/todo.rst | 3 --- 1 file changed, 3 deletions(-) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu

Re: [External] Re: [PATCH 2/2] sched: mark PRINTK_DEFERRED_CONTEXT_MASK in __schedule()

2020-09-29 Thread Peter Zijlstra
On Tue, Sep 29, 2020 at 04:27:51PM +0200, Petr Mladek wrote: > Upstreaming the console handling will be the next big step. I am sure > that there will be long discussion about it. But there might be > few things that would help removing printk_deferred(). > > 1. Messages will be printed on consol

[PATCH v3 7/7] drm/todo: Update entries around struct dma_buf_map

2020-09-29 Thread Thomas Zimmermann
Instances of struct dma_buf_map should be useful throughout DRM's memory management code. Furthermore, several drivers can now use generic fbdev emulation. Signed-off-by: Thomas Zimmermann --- Documentation/gpu/todo.rst | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions

[PATCH v3 5/7] drm/gem: Store client buffer mappings as struct dma_buf_map

2020-09-29 Thread Thomas Zimmermann
Kernel DRM clients now store their framebuffer address in an instance of struct dma_buf_map. Depending on the buffer's location, the address refers to system or I/O memory. Callers of drm_client_buffer_vmap() receive a copy of the value in the call's supplied arguments. It can be accessed and modi

[PATCH v3 1/7] drm/vram-helper: Remove invariant parameters from internal kmap function

2020-09-29 Thread Thomas Zimmermann
The parameters map and is_iomem are always of the same value. Removed them to prepares the function for conversion to struct dma_buf_map. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_vram_helper.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --gi

[PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion

2020-09-29 Thread Thomas Zimmermann
The new helper ttm_kmap_obj_to_dma_buf() extracts address and location from and instance of TTM's kmap_obj and initializes struct dma_buf_map with these values. Helpful for TTM-based drivers. Signed-off-by: Thomas Zimmermann --- include/drm/ttm/ttm_bo_api.h | 24 include

[PATCH v3 0/7] Support GEM object mappings from I/O memory

2020-09-29 Thread Thomas Zimmermann
DRM's fbdev console uses regular load and store operations to update framebuffer memory. The bochs driver on sparc64 requires the use of I/O-specific load and store operations. We have a workaround, but need a long-term solution to the problem. This patchset changes GEM's vmap/vunmap interfaces to

[PATCH v3 4/7] drm/gem: Update internal GEM vmap/vunmap interfaces to use struct dma_buf_map

2020-09-29 Thread Thomas Zimmermann
GEM's vmap and vunmap interfaces now wrap memory pointers in struct dma_buf_map. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_client.c | 18 +++--- drivers/gpu/drm/drm_gem.c | 28 ++-- drivers/gpu/drm/drm_internal.h | 5 +++-- drivers/gpu/d

[PATCH v3 3/7] drm/gem: Use struct dma_buf_map in GEM vmap ops and convert GEM backends

2020-09-29 Thread Thomas Zimmermann
This patch replaces the vmap/vunmap's use of raw pointers in GEM object functions with instances of struct dma_buf_map. GEM backends are converted as well. For most GEM backends, this simply change the returned type. GEM VRAM helpers are also updated to indicate whether the returned framebuffer ad

[PATCH v3 6/7] drm/fb_helper: Support framebuffers in I/O memory

2020-09-29 Thread Thomas Zimmermann
At least sparc64 requires I/O-specific access to framebuffers. This patch updates the fbdev console accordingly. For drivers with direct access to the framebuffer memory, the callback functions in struct fb_ops test for the type of memory and call the rsp fb_sys_ of fb_cfb_ functions. For drivers

Re: [PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion

2020-09-29 Thread Christian König
Am 29.09.20 um 17:14 schrieb Thomas Zimmermann: The new helper ttm_kmap_obj_to_dma_buf() extracts address and location from and instance of TTM's kmap_obj and initializes struct dma_buf_map with these values. Helpful for TTM-based drivers. We could completely drop that if we use the same struct

Re: [PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion

2020-09-29 Thread Daniel Vetter
On Tue, Sep 29, 2020 at 5:35 PM Christian König wrote: > > Am 29.09.20 um 17:14 schrieb Thomas Zimmermann: > > The new helper ttm_kmap_obj_to_dma_buf() extracts address and location > > from and instance of TTM's kmap_obj and initializes struct dma_buf_map > > with these values. Helpful for TTM-ba

Re: [PATCH 2/2] drm/atomic: debug output for EBUSY

2020-09-29 Thread Daniel Stone
Hi, On Fri, 25 Sep 2020 at 09:46, Daniel Vetter wrote: > Hopefully we'll have the drm crash recorder RSN, but meanwhile > compositors would like to know a bit better why they get an EBUSY. Thanks a lot, this is super helpful! Both patches are: Reviewed-by: Daniel Stone Cheers, Daniel _

Re: [PATCH] drm: update todo.rst

2020-09-29 Thread Melissa Wen
On 09/29, Daniel Vetter wrote: > - debugfs cleanup has moved forward thanks to the cleanup Wambui has > done > > Cc: Wambui Karuga > Cc: Greg Kroah-Hartman > Cc: Melissa Wen > Signed-off-by: Daniel Vetter > --- > Documentation/gpu/todo.rst | 3 --- > 1 file changed, 3 deletions(-) > > diff

Re: [PATCH] drm: update todo.rst

2020-09-29 Thread Greg Kroah-Hartman
On Tue, Sep 29, 2020 at 05:03:33PM +0200, Daniel Vetter wrote: > - debugfs cleanup has moved forward thanks to the cleanup Wambui has > done > > Cc: Wambui Karuga > Cc: Greg Kroah-Hartman > Cc: Melissa Wen > Signed-off-by: Daniel Vetter > --- > Documentation/gpu/todo.rst | 3 --- > 1 file c

  1   2   >