Re: rfc/wip ttm get rid of binding branch

2020-09-23 Thread Dave Airlie
On Wed, 23 Sep 2020 at 16:27, Dave Airlie wrote: > > Spent today trying to straighten out some of the ideas I had for > dropping bind/unbind paths into drivers. > > https://github.com/airlied/linux/commits/ttm-no-more-bind > > I think it mostly trends to the right place, the bind/unbind paths all

Re: [PATCH] drm/rockchip: skip probed failed device

2020-09-23 Thread Heiko Stübner
Hi, Am Mittwoch, 23. September 2020, 08:59:00 CEST schrieb Jian-Hong Pan: > The cdn-dp sub driver probes the device failed on PINEBOOK Pro. > > kernel: cdn-dp fec0.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing > extcon or phy > kernel: cdn-dp: probe of fec0.dp failed with error -2

[PATCH 3/4] dt-bindings: phy: convert phy-mtk-ufs.txt to YAML schema

2020-09-23 Thread Chunfeng Yun
Convert phy-mtk-ufs.txt to YAML schema mediatek,ufs-phy.yaml Signed-off-by: Chunfeng Yun --- .../bindings/phy/mediatek,ufs-phy.yaml| 64 +++ .../devicetree/bindings/phy/phy-mtk-ufs.txt | 38 --- 2 files changed, 64 insertions(+), 38 deletions(-) create mode 100

Re: [PATCH 1/3] drm: rockchip: hdmi: remove vop_crtc_mode_fixup to fix clock handling【请注意,邮件由linux-rockchip-bounces+andy.yan=rock-chips....@lists.infradead.org代发】

2020-09-23 Thread crj
Hi, Douglas 在 2020/9/22 17:31, Vicente Bergas 写道: On Tue, Sep 22, 2020 at 11:24 AM crj wrote: Hello Vicente, 在 2020/9/22 15:40, Andy Yan 写道: Add our HDMI driver owner Algea to list. On 9/22/20 2:18 AM, Vicente Bergas wrote: Under certain conditions vop_crtc_mode_fixup rounds the clock Ma

Re: [PATCH 3/6] drm/i915: use vmap in shmem_pin_map

2020-09-23 Thread Matthew Wilcox
On Tue, Sep 22, 2020 at 04:39:06PM +0200, Christoph Hellwig wrote: > On Tue, Sep 22, 2020 at 12:21:44PM +0100, Matthew Wilcox wrote: > > Actually, vfree() will work today; I cc'd you on a documentation update > > to make it clear that this is permitted. > > vfree calls __free_pages, the i915 and a

Re: [PATCH 1/3] drm: rockchip: hdmi: remove vop_crtc_mode_fixup to fix clock handling【请注意,邮件由linux-rockchip-bounces+andy.yan=rock-chips....@lists.infradead.org代发】

2020-09-23 Thread Andy Yan
Add our HDMI driver owner Algea to list. On 9/22/20 2:18 AM, Vicente Bergas wrote: Under certain conditions vop_crtc_mode_fixup rounds the clock 14850 to 148501000 which leads to the following error: dwhdmi-rockchip ff94.hdmi: PHY configuration failed (clock 148501000) The issue was fou

[PATCH] gpu/drm/radeon: fix spellint typo in comments

2020-09-23 Thread Wang Qing
Modify the comment typo: "definately" -> "definitely". Signed-off-by: Wang Qing --- drivers/gpu/drm/radeon/radeon_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c index f60fae0..3d6e2cd --- a/drivers

[PATCH] drm/amd:fix typoes in comments

2020-09-23 Thread Bernard Zhao
Change the comment typo: "programm" -> "program". Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 2 +- drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 4 ++-- drivers/gpu/drm/amd/

Re: [Intel-gfx] [PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-23 Thread Kevin Chowski
Alrighty, I'll take everyone else's silence as tacit approval of Ville's opinions. (I didn't receive any email bounces this time, so I think my issue was transient.) I will start on inverting the quirk and making the most-significant-alignment matter for these registers by default. Who can help me

Re: [PATCH v2 0/3] drm: panfrost: Coherency support

2020-09-23 Thread Alyssa Rosenzweig
Series is: Acked-by: Alyssa Rosenzweig On Tue, Sep 22, 2020 at 03:16:47PM +0100, Robin Murphy wrote: > Hi all, > > Here's a quick v2 with the tags so far picked up and some inline > commentary about the shareability domains for the pagetable code. > > Robin. > > > Robin Murphy (3): >

[PATCH 2/4] dt-bindings: phy: convert phy-mtk-tphy.txt to YAML schema

2020-09-23 Thread Chunfeng Yun
Convert phy-mtk-tphy.txt to YAML schema mediatek,tphy.yaml Signed-off-by: Chunfeng Yun --- .../bindings/phy/mediatek,tphy.yaml | 260 ++ .../devicetree/bindings/phy/phy-mtk-tphy.txt | 162 --- 2 files changed, 260 insertions(+), 162 deletions(-) create mode 10

[PATCH v2] drm/nouveau/kms: Remove set but not used 'ret'

2020-09-23 Thread Tian Tao
This addresses the following gcc warning with "make W=1": drivers/gpu/drm/nouveau/dispnv50/disp.c: In function ‘nv50_mstm_prepare’: drivers/gpu/drm/nouveau/dispnv50/disp.c:1378:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Signed-off-by: Tian Tao Reviewed-by: Lyude Paul

Re: [PATCH 1/3] drm: rockchip: hdmi: remove vop_crtc_mode_fixup to fix clock handling

2020-09-23 Thread Vicente Bergas
On Tuesday, September 22, 2020 5:26:17 PM CEST, Doug Anderson wrote: Hi, On Tue, Sep 22, 2020 at 7:52 AM Vicente Bergas wrote: On Tue, Sep 22, 2020 at 4:28 PM Doug Anderson wrote: ... Here's the code: rate = clk_round_rate(vop->dclk, adjusted_mode->clock * 1000 + 999); adjusted_mode->c

[PATCH drm/hisilicon v3 1/2] drm/hisilicon: Support i2c driver algorithms for bit-shift adapters

2020-09-23 Thread Tian Tao
Adding driver implementation to support i2c driver algorithms for bit-shift adapters, so hibmc will using the interface provided by drm to read edid. Signed-off-by: Tian Tao Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/hisilicon/hibmc/Makefile| 2 +- drivers/gpu/drm/hisilicon/hib

Re: [PATCH v3] drm/bridge: add it6505 driver

2020-09-23 Thread Pi-Hsun Shih
On Fri, Sep 4, 2020 at 10:17 AM allen wrote: > > This adds support for the iTE IT6505. > This device can convert DPI signal to DP output. > > From: Allen Chen > Signed-off-by: Jitao Shi > Signed-off-by: Pi-Hsun Shih > Signed-off-by: Yilun Lin > Signed-off-by: Hermes Wu > Signed-off-by: Allen

[PATCH] drm/rockchip: skip probed failed device

2020-09-23 Thread Jian-Hong Pan
The cdn-dp sub driver probes the device failed on PINEBOOK Pro. kernel: cdn-dp fec0.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy kernel: cdn-dp: probe of fec0.dp failed with error -22 Then, the device halts all of the DRM related device jobs. For example, the operat

[PATCH -next] dma-buf: heaps: Remove unused variable ret

2020-09-23 Thread Zou Wei
This patch fixes below warnings reported by coccicheck ./drivers/dma-buf/heaps/heap-helpers.c:202:5-8: Unneeded variable: "ret". Return "0" on line 215 Signed-off-by: Zou Wei --- drivers/dma-buf/heaps/heap-helpers.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/

[PATCH] drm/nouveau/kms: Remove set but not used 'ret'

2020-09-23 Thread Tian Tao
This addresses the following gcc warning with "make W=1": drivers/gpu/drm/nouveau/dispnv50/disp.c: In function ‘nv50_mstm_prepare’: drivers/gpu/drm/nouveau/dispnv50/disp.c:1378:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Signed-off-by: Tian Tao --- drivers/gpu/drm/nou

Re: [PATCH 1/3] drm: rockchip: hdmi: remove vop_crtc_mode_fixup to fix clock handling【请注意,邮件由linux-rockchip-bounces+andy.yan=rock-chips....@lists.infradead.org代发】

2020-09-23 Thread crj
Hello Vicente, 在 2020/9/22 15:40, Andy Yan 写道: Add our HDMI driver owner Algea to list. On 9/22/20 2:18 AM, Vicente Bergas wrote: Under certain conditions vop_crtc_mode_fixup rounds the clock May I ask under what conditions that the clock of HDMI will be changed to 148501000?  In general,

[PATCH drm/hisilicon v3 0/2] support reading resolutions from EDID

2020-09-23 Thread Tian Tao
patch #1 add a new file to implements i2c adapters, #2 read the resolution from the edid, if that fails, set the resolution to fixed. and update the destroy callback function to release the i2c adapters Changes since v1: -merge patch #3 into patch #2. -add new function to_hibmc_drm_private, modify

Re: [PATCH 3/6] drm/i915: use vmap in shmem_pin_map

2020-09-23 Thread Matthew Wilcox
On Tue, Sep 22, 2020 at 08:22:49AM +0200, Christoph Hellwig wrote: > On Mon, Sep 21, 2020 at 08:11:57PM +0100, Matthew Wilcox wrote: > > This is awkward. I'd like it if we had a vfree() variant which called > > put_page() instead of __free_pages(). I'd like it even more if we > > used release_pag

[PATCH -next] drm/v3d: Remove set but not used variable

2020-09-23 Thread Li Heng
This addresses the following gcc warning with "make W=1": drivers/gpu/drm/v3d/v3d_drv.c:73:32: warning: ‘v3d_v3d_pm_ops’ defined but not used [-Wunused-const-variable=] Reported-by: Hulk Robot Signed-off-by: Li Heng --- drivers/gpu/drm/v3d/v3d_drv.c | 4 1 file changed, 4 deletions(-) di

Re: [Intel-gfx] [PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-23 Thread Puthikorn Voravootivat
+Lyude I notice that Lyude email was somehow dropped from the thread. Lyude was the person who submitted the patch for Thinkpad and should know the OUI of the panel. On Tue, Sep 22, 2020 at 11:47 AM Kevin Chowski wrote: > > Alrighty, I'll take everyone else's silence as tacit approval of > Ville'

[PATCH v2 2/3] drm: rockchip: hdmi: allow any clock that is within the range

2020-09-23 Thread Vicente Bergas
For a video mode to work it suffices that the available bandwidth is large enough. There is no need to have an exact match. This greatly expands the list of supported monitors. Signed-off-by: Vicente Bergas Tested-by: Vicente Bergas --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 2 +- 1 fil

[PATCH 4/4] dt-bindings: phy: convert HDMI PHY binding to YAML schema

2020-09-23 Thread Chunfeng Yun
Convert HDMI PHY binding to YAML schema mediatek,ufs-phy.yaml Signed-off-by: Chunfeng Yun --- .../display/mediatek/mediatek,hdmi.txt| 17 +--- .../bindings/phy/mediatek,hdmi-phy.yaml | 90 +++ 2 files changed, 91 insertions(+), 16 deletions(-) create mode 100644 Do

[PATCH -next] drm/amd/display: Remove set but not used variable

2020-09-23 Thread Li Heng
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/amd/display/dc/dcn30/dcn30_afmt.c: warning: variable speakers set but not used Reported-by: Hulk Robot Signed-off-by: Li Heng --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_afmt.c | 2 -- 1 file changed, 2 deletions(-) diff --git

RE: [PATCH v3] drm/bridge: lvds-codec: Add support for regulator

2020-09-23 Thread Biju Das
Hi Laurent, Thanks for the patch. > Subject: [PATCH v3] drm/bridge: lvds-codec: Add support for regulator > > From: Biju Das > > Add the support for enabling optional regulator that may be used as VCC > source. > > Signed-off-by: Biju Das > Reviewed-by: Laurent Pinchart > [Replaced 'error' var

[PATCH v2 1/3] drm: rockchip: hdmi: fix clock rounding code

2020-09-23 Thread Vicente Bergas
Under certain conditions vop_crtc_mode_fixup rounds the clock 14850 to 148501000 which leads to the following error: dwhdmi-rockchip ff94.hdmi: PHY configuration failed (clock 148501000) The issue was found on RK3399 booting with u-boot. U-boot configures the display at 2560x1440 and then

Re: [PATCH V4] drm/dp_mst: Retrieve extended DPCD caps for topology manager

2020-09-23 Thread Koba Ko
Thanks for the review. Sorry for that I thought the review tag should be appended by myself. One thing to confirm with you, will you or I push this patch to drm-misc-next ? Thanks a lot. On Wed, Sep 23, 2020 at 2:01 AM Lyude Paul wrote: > > One last change I realized we should do is print the na

[PATCH] video: use kobj_to_dev()

2020-09-23 Thread Wang Qing
Use kobj_to_dev() instead of container_of() Signed-off-by: Wang Qing --- drivers/video/fbdev/aty/radeon_base.c | 4 ++-- drivers/video/fbdev/udlfb.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty

Re: [PATCH 1/3] drm: rockchip: hdmi: remove vop_crtc_mode_fixup to fix clock handling【请注意,邮件由linux-rockchip-bounces+andy.yan=rock-chips....@lists.infradead.org代发】

2020-09-23 Thread Vicente Bergas
On Tue, Sep 22, 2020 at 11:24 AM crj wrote: > > Hello Vicente, > > 在 2020/9/22 15:40, Andy Yan 写道: > > Add our HDMI driver owner Algea to list. > > > > On 9/22/20 2:18 AM, Vicente Bergas wrote: > >> Under certain conditions vop_crtc_mode_fixup rounds the clock > > > May I ask under what conditions

Re: [PATCH 1/3] drm: rockchip: hdmi: remove vop_crtc_mode_fixup to fix clock handling【请注意,邮件由linux-rockchip-bounces+andy.yan=rock-chips....@lists.infradead.org代发】

2020-09-23 Thread Vicente Bergas
On Tue, Sep 22, 2020 at 4:28 PM Doug Anderson wrote: > > Hi, > > On Tue, Sep 22, 2020 at 3:13 AM crj wrote: > > > > Hi, Douglas > > > > 在 2020/9/22 17:31, Vicente Bergas 写道: > > > On Tue, Sep 22, 2020 at 11:24 AM crj wrote: > > >> Hello Vicente, > > >> > > >> 在 2020/9/22 15:40, Andy Yan 写道: > >

Re: [PATCH v2 1/3] drm: rockchip: hdmi: fix clock rounding code

2020-09-23 Thread crj
在 2020/9/23 4:31, Vicente Bergas 写道: Under certain conditions vop_crtc_mode_fixup rounds the clock 14850 to 148501000 which leads to the following error: dwhdmi-rockchip ff94.hdmi: PHY configuration failed (clock 148501000) The issue was found on RK3399 booting with u-boot. U-boot confi

[PATCH] drm/radeon:fix typoes in comments

2020-09-23 Thread Bernard Zhao
Change the comment typo: "programm" -> "program". Signed-off-by: Bernard Zhao --- drivers/gpu/drm/radeon/uvd_v1_0.c | 4 ++-- drivers/gpu/drm/radeon/uvd_v2_2.c | 2 +- drivers/gpu/drm/radeon/uvd_v4_2.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/

[PATCH v2 3/3] drm: rockchip: hdmi: add higher pixel clock frequencies

2020-09-23 Thread Vicente Bergas
In order to support video resolutions beyond FHD more bandwidth is needed. The new entry values have been taken from u-boot: https://gitlab.denx.de/u-boot/u-boot/-/blob/ba2a0cbb053951ed6d36161989d38da724696b4d/drivers/video/rockchip/rk_hdmi.c#L63 Signed-off-by: Vicente Bergas Tested-by: Vicente B

[PATCH 1/4] dt-bindings: phy: convert phy-mtk-xsphy.txt to YAML schema

2020-09-23 Thread Chunfeng Yun
Convert phy-mtk-xsphy.txt to YAML schema mediatek,xsphy.yaml Signed-off-by: Chunfeng Yun --- .../bindings/phy/mediatek,xsphy.yaml | 203 ++ .../devicetree/bindings/phy/phy-mtk-xsphy.txt | 109 -- 2 files changed, 203 insertions(+), 109 deletions(-) create mode 1

[PATCH drm/hisilicon v3 2/2] drm/hisilicon: Features to support reading resolutions from EDID

2020-09-23 Thread Tian Tao
Use drm_get_edid to get the resolution, if that fails, set it to a fixed resolution. Rewrite the desrtoy callback function to release resources. Signed-off-by: Tian Tao Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 38 +--- 1 file chan

[PATCH v2 0/3] drm: rockchip: hdmi: enable higher resolutions than FHD

2020-09-23 Thread Vicente Bergas
This patch series enable a QHD HDMI monitor to work at native resolution. Tested on a Sapphire board with RK3399 connected to a Q27q-10 monitor at 2560x1440@60 Changes since v1: Use alternative clock rounding code proposed by Doug Anderson Vicente Bergas (3): drm: rockchip: hdmi: fix clock rou

Re: [PATCH v4 11/23] device-dax: Kill dax_kmem_res

2020-09-23 Thread David Hildenbrand
On 08.09.20 17:33, Joao Martins wrote: > [Sorry for the late response] > > On 8/21/20 11:06 AM, David Hildenbrand wrote: >> On 03.08.20 07:03, Dan Williams wrote: >>> @@ -37,109 +45,94 @@ int dev_dax_kmem_probe(struct device *dev) >>> * could be mixed in a node with faster memory, causing >>>

Re: [PATCH] drm: document and enforce rules around "spurious" EBUSY from atomic_commit

2020-09-23 Thread Pekka Paalanen
On Tue, 22 Sep 2020 20:18:34 +0200 Daniel Vetter wrote: > When doing an atomic modeset with ALLOW_MODESET drivers are allowed to > pull in arbitrary other resources, including CRTCs (e.g. when > reconfiguring global resources). > > But in nonblocking mode userspace has then no idea this happened

Re: [patch RFC 00/15] mm/highmem: Provide a preemptible variant of kmap_atomic & friends

2020-09-23 Thread peterz
On Mon, Sep 21, 2020 at 09:27:57PM +0200, Thomas Gleixner wrote: > On Mon, Sep 21 2020 at 09:24, Linus Torvalds wrote: > > On Mon, Sep 21, 2020 at 12:39 AM Thomas Gleixner wrote: > >> > >> If a task is migrated to a different CPU then the mapping address will > >> change which will explode in colo

Re: [PATCH] drm: document and enforce rules around "spurious" EBUSY from atomic_commit

2020-09-23 Thread Daniel Vetter
On Wed, Sep 23, 2020 at 10:17 AM Pekka Paalanen wrote: > > On Tue, 22 Sep 2020 20:18:34 +0200 > Daniel Vetter wrote: > > > When doing an atomic modeset with ALLOW_MODESET drivers are allowed to > > pull in arbitrary other resources, including CRTCs (e.g. when > > reconfiguring global resources).

Re: [PATCH 0/6] drm/nouveau: Support sync FDs and sync objects

2020-09-23 Thread Thierry Reding
On Fri, Aug 28, 2020 at 12:40:10PM +0200, Thierry Reding wrote: > From: Thierry Reding > > Hi, > > This series implements a new IOCTL to submit push buffers that can > optionally return a sync FD or sync object to userspace. This is useful > in cases where userspace wants to synchronize operatio

Re: [PATCH] drm: document and enforce rules around "spurious" EBUSY from atomic_commit

2020-09-23 Thread Daniel Vetter
On Wed, Sep 23, 2020 at 11:16 AM Daniel Vetter wrote: > > On Wed, Sep 23, 2020 at 10:17 AM Pekka Paalanen wrote: > > > > On Tue, 22 Sep 2020 20:18:34 +0200 > > Daniel Vetter wrote: > > > > > When doing an atomic modeset with ALLOW_MODESET drivers are allowed to > > > pull in arbitrary other reso

Re: Why can't ttm_tt_swapout() handle uncached or WC BOs?

2020-09-23 Thread Hellstrom, Thomas
On Wed, 2020-09-23 at 13:17 +1000, Dave Airlie wrote: > On Fri, 18 Sep 2020 at 00:49, Christian König < > christian.koe...@amd.com> wrote: > > Am 17.09.20 um 16:44 schrieb Michel Dänzer: > > > On 2020-09-17 2:20 p.m., Christian König wrote: > > > > Hi guys, > > > > > > > > Michel once submitted a

Re: [PATCH] drm: document and enforce rules around "spurious" EBUSY from atomic_commit

2020-09-23 Thread Daniel Vetter
I'm really not awake yet ... On Wed, Sep 23, 2020 at 10:17 AM Pekka Paalanen wrote: > > On Tue, 22 Sep 2020 20:18:34 +0200 > Daniel Vetter wrote: > > > When doing an atomic modeset with ALLOW_MODESET drivers are allowed to > > pull in arbitrary other resources, including CRTCs (e.g. when > > rec

Re: Why can't ttm_tt_swapout() handle uncached or WC BOs?

2020-09-23 Thread Daniel Vetter
On Wed, Sep 23, 2020 at 11:24 AM Hellstrom, Thomas wrote: > > On Wed, 2020-09-23 at 13:17 +1000, Dave Airlie wrote: > > On Fri, 18 Sep 2020 at 00:49, Christian König < > > christian.koe...@amd.com> wrote: > > > Am 17.09.20 um 16:44 schrieb Michel Dänzer: > > > > On 2020-09-17 2:20 p.m., Christian

Re: [Intel-gfx] [PATCH 4/6] drm/i915: use vmap in i915_gem_object_map

2020-09-23 Thread Tvrtko Ursulin
On 18/09/2020 17:37, Christoph Hellwig wrote: i915_gem_object_map implements fairly low-level vmap functionality in a driver. Split it into two helpers, one for remapping kernel memory which can use vmap, and one for I/O memory that uses vmap_pfn. The only practical difference is that alloc_v

Re: [PATCH] drm: document and enforce rules around "spurious" EBUSY from atomic_commit

2020-09-23 Thread Pekka Paalanen
On Wed, 23 Sep 2020 11:26:39 +0200 Daniel Vetter wrote: > I'm really not awake yet ... > > On Wed, Sep 23, 2020 at 10:17 AM Pekka Paalanen wrote: > > > > On Tue, 22 Sep 2020 20:18:34 +0200 > > Daniel Vetter wrote: > > > > > When doing an atomic modeset with ALLOW_MODESET drivers are allowed

Re: [patch RFC 00/15] mm/highmem: Provide a preemptible variant of kmap_atomic & friends

2020-09-23 Thread peterz
On Mon, Sep 21, 2020 at 09:27:57PM +0200, Thomas Gleixner wrote: > Alternatively this could of course be solved with per CPU page tables > which will come around some day anyway I fear. Previously (with PTI) we looked at making the entire kernel map per-CPU, and that takes a 2K copy on switch_mm()

[PATCH v3 02/22] drm/armada: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in armada. Signed-off-by: Thomas Zimmermann Acked-by: Russell King --- drivers/gpu/drm/armada/armada_drv.c | 3 --- drivers/gpu/drm/

[PATCH v3 01/22] drm/amdgpu: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in amdgpu. The only exception is gem_prime_mmap, which is non-trivial to convert. v3: * remove amdgpu_object.c from patch (Chris

[PATCH v3 03/22] drm/etnaviv: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in etnaviv. The only exception is gem_prime_mmap, which is non-trivial to convert. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel

[PATCH v3 05/22] drm/gma500: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in gma500. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/gma500/framebuffer.c | 2 ++ drivers/gpu/

[PATCH v3 00/22] Convert all remaining drivers to GEM object functions

2020-09-23 Thread Thomas Zimmermann
The GEM and PRIME related callbacks in struct drm_driver are deprecated in favor of GEM object functions in struct drm_gem_object_funcs. This patchset converts the remaining drivers to object functions and removes most of the obsolete interfaces. Version 3 of this patchset mostly fixes drm_gem_pri

[PATCH v3 08/22] drm/mediatek: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in mediatek. The only exception is gem_prime_mmap, which is non-trivial to convert. Signed-off-by: Thomas Zimmermann Reviewed-by: Danie

[PATCH v3 06/22] drm/i915: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in i915. v2: * move object-function instance to i915_gem_object.c (Jani) Signed-off-by: Thomas Zimmermann Reviewed-by: Tvrtko

[PATCH v3 07/22] drm/imx/dcss: Initialize DRM driver instance with CMA helper macro

2020-09-23 Thread Thomas Zimmermann
The i.MX DCSS driver uses CMA helpers with default callback functions. Initialize the driver structure with the rsp CMA helper macro. The driver is being converted to use GEM object functions as part of this change. Two callbacks, .gem_prime_export and .gem_prime_import, were initialized to their

[PATCH v3 11/22] drm/omapdrm: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in omapdrm. v2: * make omap_gem_free_object() static (Tomi) Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Re

[PATCH v3 15/22] drm/tegra: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in tegra. Signed-off-by: Thomas Zimmermann Acked-by: Thierry Reding --- drivers/gpu/drm/tegra/drm.c | 4 drivers/gpu/drm/tegra/g

[PATCH v3 17/22] drm/vgem: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in vgem. The only exception is gem_prime_mmap, which is non-trivial to convert. Signed-off-by: Thomas Zimmermann Reviewed-by: Melissa W

[PATCH v3 14/22] drm/rockchip: Convert to drm_gem_object_funcs

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in rockchip. The only exception is gem_prime_mmap, which is non-trivial to convert. v3: * update documentation Signed-off-by: T

[PATCH v3 13/22] drm/radeon: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in radeon. v2: * move object-function instance to radeon_gem.c (Christian) * set callbacks in radeon_gem_object_create()

[PATCH v3 16/22] drm/vc4: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in vc4. The only exception is gem_prime_mmap, which is non-trivial to convert. Signed-off-by: Thomas Zimmermann Reviewed-by: Eric Anhol

[PATCH v3 10/22] drm/nouveau: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in nouveau. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/nouveau/nouveau_drm.c | 9 - d

[PATCH v3 09/22] drm/msm: Introduce GEM object funcs

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in msm. The only exception is gem_prime_mmap, which is non-trivial to convert. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vet

[PATCH v3 04/22] drm/exynos: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in exynos. The only exception is gem_prime_mmap, which is non-trivial to convert. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel

[PATCH v3 12/22] drm/pl111: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in pl111. The only exception is gem_prime_mmap, which is non-trivial to convert. v2: * use drm_gem_cma_create_object_default_fun

[PATCH v3 21/22] drm/xlnx: Initialize DRM driver instance with CMA helper macro

2020-09-23 Thread Thomas Zimmermann
The xlnx driver uses CMA helpers with default callback functions. Initialize the driver structure with the rsp CMA helper macro. The driver is being converted to use GEM object functions as part of this change. Two callbacks, .dumb_destroy and .gem_prime_import, were initialized to their default i

[PATCH v3 22/22] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver

2020-09-23 Thread Thomas Zimmermann
Several GEM and PRIME callbacks have been deprecated in favor of per-instance GEM object functions. Remove the callbacks as they are now unused. The only exception is .gem_prime_mmap, which is still in use by several drivers. What is also gone is gem_vm_ops in struct drm_driver. All drivers now us

[PATCH v3 20/22] drm/xen: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in xen. The only exception is gem_prime_mmap, which is non-trivial to convert. v2: * convert xen_drm_drv_free_object_unlocked()

[PATCH v3 19/22] drm/vkms: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in vkms. Signed-off-by: Thomas Zimmermann Reviewed-by: Melissa Wen --- drivers/gpu/drm/vkms/vkms_drv.c | 8 drivers/gpu/drm

[PATCH v3 18/22] drm/virtgpu: Set PRIME export function in struct drm_gem_object_funcs

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces virtgpu's per-driver PRIME export function with a per-object function. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_drv.c| 1 - driv

Re: linux-next: build warning after merge of the drm tree

2020-09-23 Thread Tomi Valkeinen
Hi Stephen, On 23/09/2020 06:36, Stephen Rothwell wrote: > Hi all, > > After merging the drm tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c: In function > 'cdns_mhdp_fw_activate': > drivers/gpu/drm/bridge/cad

Re: [PATCH] drm: document and enforce rules around "spurious" EBUSY from atomic_commit

2020-09-23 Thread Ville Syrjälä
On Tue, Sep 22, 2020 at 08:18:34PM +0200, Daniel Vetter wrote: > When doing an atomic modeset with ALLOW_MODESET drivers are allowed to > pull in arbitrary other resources, including CRTCs (e.g. when > reconfiguring global resources). > > But in nonblocking mode userspace has then no idea this hap

Re: [PATCH] drm: document and enforce rules around "spurious" EBUSY from atomic_commit

2020-09-23 Thread Daniel Vetter
On Wed, Sep 23, 2020 at 12:31 PM Ville Syrjälä wrote: > > On Tue, Sep 22, 2020 at 08:18:34PM +0200, Daniel Vetter wrote: > > When doing an atomic modeset with ALLOW_MODESET drivers are allowed to > > pull in arbitrary other resources, including CRTCs (e.g. when > > reconfiguring global resources).

[PATCH 2/2] drm/atomic: debug output for EBUSY

2020-09-23 Thread Daniel Vetter
Hopefully we'll have the drm crash recorder RSN, but meanwhile compositors would like to know a bit better why they get an EBUSY. Cc: Sean Paul Cc: Daniel Stone Cc: Pekka Paalanen Cc: Simon Ser Cc: Ville Syrjälä Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_atomic.c| 4 ++--

[PATCH 1/2] drm/atomic: document and enforce rules around "spurious" EBUSY

2020-09-23 Thread Daniel Vetter
When doing an atomic modeset with ALLOW_MODESET drivers are allowed to pull in arbitrary other resources, including CRTCs (e.g. when reconfiguring global resources). But in nonblocking mode userspace has then no idea this happened, which can lead to spurious EBUSY calls, both: - when that other CR

Re: [PATCH] drm: avoid spurious EBUSY due to nonblocking atomic modesets

2020-09-23 Thread Daniel Vetter
On Tue, Sep 22, 2020 at 3:36 PM Marius Vlad wrote: > > On Fri, Jan 31, 2020 at 07:34:00AM +, Daniel Stone wrote: > > On Thu, 5 Jul 2018 at 11:21, Daniel Vetter wrote: > > > When doing an atomic modeset with ALLOW_MODESET drivers are allowed to > > > pull in arbitrary other resources, includin

Re: [PATCH] drm/rockchip: skip probed failed device

2020-09-23 Thread Robin Murphy
On 2020-09-23 07:59, Jian-Hong Pan wrote: The cdn-dp sub driver probes the device failed on PINEBOOK Pro. kernel: cdn-dp fec0.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy kernel: cdn-dp: probe of fec0.dp failed with error -22 Wouldn't it make more sense to simply

Re: [PATCH] drm: avoid spurious EBUSY due to nonblocking atomic modesets

2020-09-23 Thread Marius Vlad
On Wed, Sep 23, 2020 at 12:58:30PM +0200, Daniel Vetter wrote: > On Tue, Sep 22, 2020 at 3:36 PM Marius Vlad wrote: > > > > On Fri, Jan 31, 2020 at 07:34:00AM +, Daniel Stone wrote: > > > On Thu, 5 Jul 2018 at 11:21, Daniel Vetter wrote: > > > > When doing an atomic modeset with ALLOW_MODESET

Re: [PATCH] drm: avoid spurious EBUSY due to nonblocking atomic modesets

2020-09-23 Thread Daniel Vetter
On Wed, Sep 23, 2020 at 1:14 PM Marius Vlad wrote: > > On Wed, Sep 23, 2020 at 12:58:30PM +0200, Daniel Vetter wrote: > > On Tue, Sep 22, 2020 at 3:36 PM Marius Vlad > > wrote: > > > > > > On Fri, Jan 31, 2020 at 07:34:00AM +, Daniel Stone wrote: > > > > On Thu, 5 Jul 2018 at 11:21, Daniel V

Re: [PATCH] drm/rockchip: skip probed failed device

2020-09-23 Thread Heiko Stübner
Am Mittwoch, 23. September 2020, 13:05:26 CEST schrieb Robin Murphy: > On 2020-09-23 07:59, Jian-Hong Pan wrote: > > The cdn-dp sub driver probes the device failed on PINEBOOK Pro. > > > > kernel: cdn-dp fec0.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* > > missing extcon or phy > > kernel: c

Re: [PATCH v3 07/22] drm/imx/dcss: Initialize DRM driver instance with CMA helper macro

2020-09-23 Thread Laurentiu Palcu
Hi Thomas, On Wed, Sep 23, 2020 at 12:21:44PM +0200, Thomas Zimmermann wrote: > The i.MX DCSS driver uses CMA helpers with default callback functions. > Initialize the driver structure with the rsp CMA helper macro. The > driver is being converted to use GEM object functions as part of > this chan

Re: [PATCH] drm: avoid spurious EBUSY due to nonblocking atomic modesets

2020-09-23 Thread Marius Vlad
On Wed, Sep 23, 2020 at 01:16:42PM +0200, Daniel Vetter wrote: > On Wed, Sep 23, 2020 at 1:14 PM Marius Vlad wrote: > > > > On Wed, Sep 23, 2020 at 12:58:30PM +0200, Daniel Vetter wrote: > > > On Tue, Sep 22, 2020 at 3:36 PM Marius Vlad > > > wrote: > > > > > > > > On Fri, Jan 31, 2020 at 07:34:

Re: [PATCH 2/4] video: fbdev: amba-clcd: Retire elder CLCD driver

2020-09-23 Thread Peter Collingbourne
On Mon, Sep 21, 2020 at 9:10 PM Peter Collingbourne wrote: > > On Mon, Sep 21, 2020 at 2:32 PM Linus Walleij > wrote: > > > > On Tue, Sep 15, 2020 at 3:10 AM Peter Collingbourne wrote: > > > On Tue, Jun 9, 2020 at 1:08 PM Linus Walleij > > > wrote: > > > > > > > > All the functionality in thi

Re: [PATCH] MAINTAINERS: move Milo Kim to credits

2020-09-23 Thread Dan Murphy
All On 9/22/20 4:36 AM, Mark Brown wrote: On Tue, Sep 22, 2020 at 09:08:37AM +0200, Krzysztof Kozlowski wrote: On Mon, 21 Sep 2020 at 23:06, Pavel Machek wrote: I believe normal way would be to mark the entries "orphaned", not to drop them altogether. Plus, I believe someone from TI is likely

Re: [PATCH v3 03/22] drm/etnaviv: Introduce GEM object functions

2020-09-23 Thread Lucas Stach
On Mi, 2020-09-23 at 12:21 +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in etnaviv. The only exception is gem_prime_mmap, > which is non-trivial

[PATCH] drm: bridge: cdns-mhdp8546: fix compile warning

2020-09-23 Thread Tomi Valkeinen
On x64 we get: drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:751:10: warning: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744073709551613' to '4294967293' [-Woverflow] The registers are 32 bit, so fix by casting to u32. Fixes: fb43aa0acdfd ("drm: bridge

[PATCH v2 3/3] dma-buf: Use struct dma_buf_map in dma_buf_vunmap() interfaces

2020-09-23 Thread Thomas Zimmermann
This patch updates dma_buf_vunmap() and dma-buf's vunmap callback to use struct dma_buf_map. The interfaces used to receive a buffer address. This address is now given in an instance of the structure. Users of the functions are updated accordingly. This is only an interface change. It is currently

[PATCH v2 2/3] dma-buf: Use struct dma_buf_map in dma_buf_vmap() interfaces

2020-09-23 Thread Thomas Zimmermann
This patch updates dma_buf_vmap() and dma-buf's vmap callback to use struct dma_buf_map. The interfaces used to return a buffer address. This address now gets stored in an instance of the structure that is given as an additional argument. The functions return an errno code on errors. Users of the

[PATCH v2 0/3] dma-buf: Flag vmap'ed memory as system or I/O memory

2020-09-23 Thread Thomas Zimmermann
Dma-buf provides vmap() and vunmap() for retrieving and releasing mappings of dma-buf memory in kernel address space. The functions operate with plain addresses and the assumption is that the memory can be accessed with load and store operations. This is not the case on some architectures (e.g., sp

[PATCH v2 1/3] dma-buf: Add struct dma-buf-map for storing struct dma_buf.vaddr_ptr

2020-09-23 Thread Thomas Zimmermann
The new type struct dma_buf_map represents a mapping of dma-buf memory into kernel space. It contains a flag, is_iomem, that signals users to access the mapped memory with I/O operations instead of regular loads and stores. It was assumed that DMA buffer memory can be accessed with regular load an

Re: [PATCH 1/2] drm/nouveau: stop using persistent_swap_storage

2020-09-23 Thread Christian König
Ping? Ben, Dave any comment on this? Am 17.09.20 um 16:29 schrieb Christian König: According to Ben this is most likely just a leftover. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_gem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouvea

Re: [PATCH -next] drm/v3d: Remove set but not used variable

2020-09-23 Thread Dave Stevenson
Hi On Wed, 23 Sep 2020 at 08:53, Li Heng wrote: > > This addresses the following gcc warning with "make W=1": > > drivers/gpu/drm/v3d/v3d_drv.c:73:32: warning: > ‘v3d_v3d_pm_ops’ defined but not used [-Wunused-const-variable=] > > Reported-by: Hulk Robot > Signed-off-by: Li Heng > --- > driver

Re: [Intel-gfx] [PATCH 4/6] drm/i915: use vmap in i915_gem_object_map

2020-09-23 Thread Tvrtko Ursulin
On 23/09/2020 14:41, Christoph Hellwig wrote: On Wed, Sep 23, 2020 at 10:52:33AM +0100, Tvrtko Ursulin wrote: On 18/09/2020 17:37, Christoph Hellwig wrote: i915_gem_object_map implements fairly low-level vmap functionality in a driver. Split it into two helpers, one for remapping kernel mem

Re: Why can't ttm_tt_swapout() handle uncached or WC BOs?

2020-09-23 Thread Christian König
Am 23.09.20 um 11:24 schrieb Hellstrom, Thomas: On Wed, 2020-09-23 at 13:17 +1000, Dave Airlie wrote: On Fri, 18 Sep 2020 at 00:49, Christian König < christian.koe...@amd.com> wrote: Am 17.09.20 um 16:44 schrieb Michel Dänzer: On 2020-09-17 2:20 p.m., Christian König wrote: Hi guys, Michel o

Re: [PATCH V4] drm/dp_mst: Retrieve extended DPCD caps for topology manager

2020-09-23 Thread Lyude Paul
On Wed, 2020-09-23 at 10:16 +0800, Koba Ko wrote: > Thanks for the review. > Sorry for that I thought the review tag should be appended by myself. > One thing to confirm with you, will you or I push this patch to drm-misc- > next ? I already pushed it with the change, so everything is all set > T

Re: [PATCH v2 1/3] dma-buf: Add struct dma-buf-map for storing struct dma_buf.vaddr_ptr

2020-09-23 Thread Christian König
Am 23.09.20 um 14:32 schrieb Thomas Zimmermann: The new type struct dma_buf_map represents a mapping of dma-buf memory into kernel space. It contains a flag, is_iomem, that signals users to access the mapped memory with I/O operations instead of regular loads and stores. It was assumed that DMA

Re: [PATCH v2 2/3] dma-buf: Use struct dma_buf_map in dma_buf_vmap() interfaces

2020-09-23 Thread Christian König
Am 23.09.20 um 14:32 schrieb Thomas Zimmermann: This patch updates dma_buf_vmap() and dma-buf's vmap callback to use struct dma_buf_map. The interfaces used to return a buffer address. This address now gets stored in an instance of the structure that is given as an additional argument. The funct

  1   2   3   >