Re: [PATCH v2 00/21] Convert all remaining drivers to GEM object functions

2020-09-17 Thread Thomas Zimmermann
Hi Am 15.09.20 um 17:25 schrieb Christian König: > Added my rb to the amdgpu and radeon patches. > > Should we pick those up through the amd branches or do you want to push > everything to drm-misc-next? > > I think the later since this should result in much merge clash. Yes, preferable, I'd me

Re: [Linaro-mm-sig] Changing vma->vm_file in dma_buf_mmap()

2020-09-17 Thread Christian König
Am 17.09.20 um 08:23 schrieb Daniel Vetter: On Wed, Sep 16, 2020 at 5:31 PM Christian König wrote: Am 16.09.20 um 17:24 schrieb Daniel Vetter: On Wed, Sep 16, 2020 at 4:14 PM Christian König wrote: Am 16.09.20 um 16:07 schrieb Jason Gunthorpe: On Wed, Sep 16, 2020 at 11:53:59AM +0200, Danie

Re: [PATCH 6/6] drm/meson: add support for MIPI-DSI transceiver

2020-09-17 Thread Neil Armstrong
On 08/09/2020 10:46, Daniel Vetter wrote: > On Tue, Sep 08, 2020 at 10:06:03AM +0200, Neil Armstrong wrote: >> Hi, >> >> On 07/09/2020 20:03, Daniel Vetter wrote: >>> On Mon, Sep 07, 2020 at 11:03:29AM +0200, Neil Armstrong wrote: On 07/09/2020 10:44, Daniel Vetter wrote: > On Mon, Sep 07,

Re: [RFC PATCH v2 13/17] gpu: host1x: Reset max value when freeing a syncpoint

2020-09-17 Thread Mikko Perttunen
On 9/17/20 12:37 AM, Dmitry Osipenko wrote: 16.09.2020 23:43, Mikko Perttunen пишет: ... Please note that the sync point state actually needs to be completely reset at the sync point request-time because both downstream fastboot and upstream u-boot [1] are needlessly enabling display VBLANK inte

Re: [PATCH 0/3] dma-buf: Flag vmap'ed memory as system or I/O memory

2020-09-17 Thread Thomas Zimmermann
Hi Christian and Thomas Am 16.09.20 um 15:37 schrieb Thomas Hellström (Intel): > > On 9/16/20 2:59 PM, Christian König wrote: >> Am 16.09.20 um 14:24 schrieb Daniel Vetter: >>> On Wed, Sep 16, 2020 at 12:48:20PM +0200, Thomas Zimmermann wrote: Hi Am 16.09.20 um 11:37 schrieb Daniel

[v2 PATCH] dt-bindings: display: mediatek: convert the dpi bindings to yaml

2020-09-17 Thread Jitao Shi
Convert display/mediatek/mediatek,dpi.txt to display/mediatek/mediatek,dpi.yaml and remove the old text bindings. Signed-off-by: Jitao Shi --- .../bindings/display/mediatek/mediatek,dpi.txt | 42 -- .../bindings/display/mediatek/mediatek,dpi.yaml| 97 ++ 2 fil

Re: [PATCH v2 01/21] drm/amdgpu: Introduce GEM object functions

2020-09-17 Thread Thomas Zimmermann
Hi Am 15.09.20 um 17:05 schrieb Christian König: > Am 15.09.20 um 16:59 schrieb Thomas Zimmermann: >> GEM object functions deprecate several similar callback interfaces in >> struct drm_driver. This patch replaces the per-driver callbacks with >> per-instance callbacks in amdgpu. The only exceptio

Re: [PATCH 1/7] drm/ttm: protect against reentrant bind in the drivers

2020-09-17 Thread Christian König
Am 17.09.20 um 06:30 schrieb Dave Airlie: From: Dave Airlie This moves the generic tracking into the drivers and protects against reentrancy in the drivers. It fixes up radeon and agp to be able to query the bound status as that is required. Signed-off-by: Dave Airlie If would prefer splitt

Re: [PATCH 2/7] drm/ttm: flip tt destroy ordering.

2020-09-17 Thread Christian König
Am 17.09.20 um 06:30 schrieb Dave Airlie: From: Dave Airlie Call the driver first and have it call the common code cleanup. This is useful later to fix unbind. Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 1 + drivers/gpu/dr

Re: [PATCH 3/7] drm/ttm: move unbind into the tt destroy.

2020-09-17 Thread Christian König
Am 17.09.20 um 06:30 schrieb Dave Airlie: From: Dave Airlie This moves unbind into the driver side on destroy paths. Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 1 + drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + drivers

Re: [PATCH 4/7] drm/ttm/drivers: call the bind function directly.

2020-09-17 Thread Christian König
Am 17.09.20 um 06:30 schrieb Dave Airlie: From: Dave Airlie Now the bind functions have all the protection explicitly the drivers can just call them directly, and the api can be unexported Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm

Re: [PATCH 5/7] drm/ttm: add a simple assign mem to bo wrapper

2020-09-17 Thread Christian König
Am 17.09.20 um 06:30 schrieb Dave Airlie: From: Dave Airlie This pattern is called in a few places, just clean it up. Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 18 ++ include/drm/ttm/ttm_bo_driver.h | 10 -

Re: [patch 00/13] preempt: Make preempt count unconditional

2020-09-17 Thread Daniel Vetter
On Thu, Sep 17, 2020 at 12:39 AM Paul E. McKenney wrote: > > On Wed, Sep 16, 2020 at 11:43:02PM +0200, Daniel Vetter wrote: > > On Wed, Sep 16, 2020 at 10:58 PM Paul E. McKenney > > wrote: > > > > > > On Wed, Sep 16, 2020 at 10:29:06PM +0200, Daniel Vetter wrote: > > > > On Wed, Sep 16, 2020 at

Re: [PATCH 6/7] drm/ttm: move ghost object creation to a common function

2020-09-17 Thread Christian König
Am 17.09.20 um 06:30 schrieb Dave Airlie: From: Dave Airlie Both accel cleanup and pipeline move had the same code, make a single function for it. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo_util.c | 105 -- 1 file changed, 43 insertions(+), 62 del

Re: [PATCH 7/7] drm/ttm: make common function for wait/free node path.

2020-09-17 Thread Christian König
Am 17.09.20 um 06:30 schrieb Dave Airlie: From: Dave Airlie The pipeline and accel cleansups has similiar paths here. Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 38 --- 1 file changed, 20 insertions(+), 1

Re: [PATCH 1/2] drm/ttm: drop special pipeline accel cleanup function.

2020-09-17 Thread Christian König
Am 17.09.20 um 08:41 schrieb Dave Airlie: From: Dave Airlie The two accel cleanup paths were mostly the same once refactored. Just pass a bool to say if the evictions are to be pipelined. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 5 +- drivers/gpu/drm/nouve

Re: [PATCH 2/2] drm/ttm: drop evicted from ttm_bo.

2020-09-17 Thread Christian König
Am 17.09.20 um 08:41 schrieb Dave Airlie: From: Dave Airlie This was unused. Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 4 include/drm/ttm/ttm_bo_api.h | 1 - 2 files changed, 5 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo

Re: [PATCH 0/3] dma-buf: Flag vmap'ed memory as system or I/O memory

2020-09-17 Thread Christian König
Am 17.09.20 um 09:16 schrieb Thomas Zimmermann: Hi Christian and Thomas Am 16.09.20 um 15:37 schrieb Thomas Hellström (Intel): On 9/16/20 2:59 PM, Christian König wrote: Am 16.09.20 um 14:24 schrieb Daniel Vetter: On Wed, Sep 16, 2020 at 12:48:20PM +0200, Thomas Zimmermann wrote: Hi Am 16.0

[PATCH] drm: fix spelling error in comments

2020-09-17 Thread Wang Qing
Change the comment typo: "manger" -> "manager". Signed-off-by: Wang Qing --- include/drm/drm_mm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_mm.h b/include/drm/drm_mm.h index a01bc6f..9b4292f --- a/include/drm/drm_mm.h +++ b/include/drm/drm_mm.h @@ -338,7

Re: [patch 00/13] preempt: Make preempt count unconditional

2020-09-17 Thread Matthew Wilcox
On Mon, Sep 14, 2020 at 11:55:24PM +0200, Thomas Gleixner wrote: > But just look at any check which uses preemptible(), especially those > which check !preemptible(): hmm. +++ b/include/linux/preempt.h @@ -180,7 +180,9 @@ do { \ #define preempt_enable_no_resched() sched_preempt_enable_no_resch

Re: [PATCH 0/3] drm: panfrost: Coherency support

2020-09-17 Thread Alyssa Rosenzweig
> So I get a performance regression with the dma-coherent approach, even if it's > clearly the cleaner. That's bizarre -- this should really be the faster of the two. signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.f

Re: [RFC PATCH v2 13/17] gpu: host1x: Reset max value when freeing a syncpoint

2020-09-17 Thread Dmitry Osipenko
05.09.2020 13:34, Mikko Perttunen пишет: > With job recovery becoming optional, syncpoints may have a mismatch > between their value and max value when freed. As such, when freeing, > set the max value to the current value of the syncpoint so that it > is in a sane state for the next user. > > Sig

Re: [RFC PATCH v2 13/17] gpu: host1x: Reset max value when freeing a syncpoint

2020-09-17 Thread Dmitry Osipenko
16.09.2020 23:43, Mikko Perttunen пишет: ... >> Please note that the sync point state actually needs to be completely >> reset at the sync point request-time because both downstream fastboot >> and upstream u-boot [1] are needlessly enabling display VBLANK interrupt >> that continuously increments

[PATCH -next] drm/tidss: use devm_platform_ioremap_resource_byname

2020-09-17 Thread Wang Xiaojun
Use the devm_platform_ioremap_resource_byname() helper instead of calling platform_get_resource_byname() and devm_ioremap_resource() separately. Signed-off-by: Wang Xiaojun --- drivers/gpu/drm/tidss/tidss_dispc.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers

[PATCH v1] powerplay:hwmgr - modify the return value

2020-09-17 Thread Xiaoliang Pang
modify the return value is -EINVAL Fixes: f83a9991648bb("drm/amd/powerplay: add Vega10 powerplay support (v5)") Fixes: 2cac05dee6e30("drm/amd/powerplay: add the hw manager for vega12 (v4)") Cc: Eric Huang Cc: Evan Quan Signed-off-by: Xiaoliang Pang --- drivers/gpu/drm/amd/powerplay/hwmgr/vega1

Re: [PATCH] drm/aspeed: Add sysfs for output settings

2020-09-17 Thread Andrew Jeffery
On Wed, 16 Sep 2020, at 18:04, Joel Stanley wrote: > These settings are used by an ASPEED BMC to determine when the host is > trying to drive the display over PCIe (vga_pw) and to switch the > output between PCIe and the internal graphics device (dac_mux). > > The valid values for the dac mux a

Re: [oss-drivers] [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-17 Thread Simon Horman
On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote: > fallthrough to a separate case/default label break; isn't very readable. > > Convert pseudo-keyword fallthrough; statements to a simple break; when > the next label is case or default and the only statement in the next > label block is

Re: [PATCH v5 00/80] drm/vc4: Support BCM2711 Display Pipeline

2020-09-17 Thread Maxime Ripard
On Mon, Sep 14, 2020 at 07:14:11PM +0900, Hoegeun Kwon wrote: > Hi Maxime, > > On 9/8/20 9:00 PM, Maxime Ripard wrote: > > Hi Hoegeun, > > > > On Mon, Sep 07, 2020 at 08:49:12PM +0900, Hoegeun Kwon wrote: > >> On 9/3/20 5:00 PM, Maxime Ripard wrote: > >>> Hi everyone, > >>> > >>> Here's a (pretty

Re: [PATCH v2 0/3] drm/panfrost: add Amlogic integration quirks

2020-09-17 Thread Alyssa Rosenzweig
series r-b, nice! On Wed, Sep 16, 2020 at 05:01:44PM +0200, Neil Armstrong wrote: > The T820, G31 & G52 GPUs integrated by Amlogic in the respective GXM, > G12A/SM1 & G12B > SoCs needs a quirk in the PWR registers at the GPU reset time. > > This serie adds the necessary quirks for the Amlogic int

Re: [Linaro-mm-sig] Changing vma->vm_file in dma_buf_mmap()

2020-09-17 Thread Daniel Vetter
On Thu, Sep 17, 2020 at 9:11 AM Christian König wrote: > > Am 17.09.20 um 08:23 schrieb Daniel Vetter: > > On Wed, Sep 16, 2020 at 5:31 PM Christian König > > wrote: > >> Am 16.09.20 um 17:24 schrieb Daniel Vetter: > >>> On Wed, Sep 16, 2020 at 4:14 PM Christian König > >>> wrote: > Am 16.0

Re: [PATCH] drm/ttm: fix incorrect TT->SYSTEM move handling

2020-09-17 Thread Christian König
Am 16.09.20 um 21:27 schrieb Dave Airlie: On Thu, 17 Sep 2020 at 00:24, Christian König wrote: When we move from the SYSTEM domain to the TT domain we still need to potentially change the caching state. This is most likely the source of a bunch of problems with AGP and USWC together with hiber

Re: [PATCH v1] powerplay:hwmgr - modify the return value

2020-09-17 Thread Christian König
Am 17.09.20 um 05:46 schrieb Xiaoliang Pang: modify the return value is -EINVAL Maybe better write something like "The correct return value should be -EINVAL." With that done feel free to add my acked-by. Christian. Fixes: f83a9991648bb("drm/amd/powerplay: add Vega10 powerplay support (v5

[PULL] drm-intel-fixes

2020-09-17 Thread Jani Nikula
Hi Dave & Daniel - Due to the separate feature pull we haven't picked up gem fixes until now. Here's the first batch; there's potentially a few more to come [1]. I also just received a gvt fixes pull that didn't make it this week, so there are still more fixes coming. BR, Jani. [1] http://lo

Re: [PATCH v3 02/19] drm/virtio: blob prep: make CPU responses more generic

2020-09-17 Thread Gerd Hoffmann
On Wed, Sep 16, 2020 at 05:08:21PM -0700, Gurchetan Singh wrote: > RESOURCE_MAP_BLOB / RESOURCE_UNMAP_BLOB can use this. > -#define UUID_INITIALIZING 0 > -#define UUID_INITIALIZED 1 > -#define UUID_INITIALIZATION_FAILED 2 > +#define STATE_INITIALIZING 0 > +#define STATE_OK 1 > +#define STATE_ERR 2

Re: [PATCH v3 09/19] drm/virtio: implement blob resources: probe for host visible region

2020-09-17 Thread Gerd Hoffmann
Hi, > + if (!devm_request_mem_region(&vgdev->vdev->dev, > + vgdev->host_visible_region.addr, > + vgdev->host_visible_region.len, > + dev_name(&vgdev->vdev->dev))

Re: [PATCH v3 12/19] drm/virtio: implement blob resources: implement vram object

2020-09-17 Thread Gerd Hoffmann
Hi, > + if (resp_type == VIRTIO_GPU_RESP_OK_MAP_INFO) { > + vram->map_info = resp->map_info; > + vram->map_state = STATE_OK; > + } else { > + vram->map_state = STATE_ERR; > + } Ah, found it, here. ok. take care, Gerd __

[PATCH] drm/ttm: remove superflous extern attribute from funcs

2020-09-17 Thread Christian König
Extern is the default attribute for functions anyway. Signed-off-by: Christian König --- include/drm/ttm/ttm_execbuf_util.h | 19 --- include/drm/ttm/ttm_memory.h | 25 - 2 files changed, 20 insertions(+), 24 deletions(-) diff --git a/include/drm/tt

[PATCHv2] dt-bindings: dp-connector: add binding for DisplayPort connector

2020-09-17 Thread Tomi Valkeinen
Add binding for DisplayPort connector. A few notes: * Similar to hdmi-connector, it has hpd-gpios as an optional property, as the HPD could also be handled by, e.g., the DP bridge. * dp-pwr-supply, which provides 3.3V on DP_PWR pin, is optional, as it is not strictly required: standard DP cab

Why is nouveau using a separate swap storage?

2020-09-17 Thread Christian König
Hi guys, just another TTM feature which is only used by nouveau. We have this bo->bo.persistent_swap_storage pointer which is only set by nouveau to the GEM filp and used when a BO is swapped to a shmem file. As far as I can see this doesn't make any sense at all? What is the background here

Re: [PATCH v2 2/3] drm/panfrost: add amlogic reset quirk callback

2020-09-17 Thread Steven Price
On 16/09/2020 16:01, Neil Armstrong wrote: The T820, G31 & G52 GPUs integratewd by Amlogic in the respective GXM, G12A/SM1 & G12B NIT: s/integratewd/integrated/ SoCs needs a quirk in the PWR registers at the GPU reset time. Since the Amlogic's integration of the GPU cores with the SoC is no

Re: [PATCH v2 3/3] drm/panfrost: add Amlogic GPU integration quirks

2020-09-17 Thread Steven Price
On 16/09/2020 16:01, Neil Armstrong wrote: This adds the required GPU quirks, including the quirk in the PWR registers at the GPU reset time and the IOMMU quirk for shareability issues observed on G52 in Amlogic G12B SoCs. Signed-off-by: Neil Armstrong Reviewed-by: Steven Price --- dri

Re: [PATCH v2 1/3] drm/panfrost: add support for vendor quirk

2020-09-17 Thread Steven Price
On 16/09/2020 16:01, Neil Armstrong wrote: The T820, G31 & G52 GPUs integratewd by Amlogic in the respective GXM, G12A/SM1 & G12B NIT: s/integratewd/integrated/ SoCs needs a quirk in the PWR registers after each reset. This adds a callback in the device compatible struct of permit this. Si

Re: [PATCH RESEND v10 0/4] Support DRM bridges on NVIDIA Tegra

2020-09-17 Thread Thierry Reding
On Fri, Aug 14, 2020 at 01:06:52AM +0300, Dmitry Osipenko wrote: > Hello, > > This series adds initial support for the DRM bridges to NVIDIA Tegra DRM > driver. This is required by newer device-trees where we model the LVDS > encoder bridge properly. In particular this series is needed in order to

Re: [PATCH 2/3] drm/panfrost: Support cache-coherent integrations

2020-09-17 Thread Steven Price
On 16/09/2020 00:51, Robin Murphy wrote: When the GPU's ACE-Lite interface is fully wired up and capable of snooping CPU caches, it may be described as "dma-coherent" in devicetree, which will already inform the DMA layer not to perform unnecessary cache maintenance. However, we still need to ens

Re: [PATCH 0/3] drm: panfrost: Coherency support

2020-09-17 Thread Steven Price
On 16/09/2020 18:46, Rob Herring wrote: On Wed, Sep 16, 2020 at 11:04 AM Alyssa Rosenzweig wrote: So I get a performance regression with the dma-coherent approach, even if it's clearly the cleaner. That's bizarre -- this should really be the faster of the two. Coherency may not be free. C

[PATCH 1/2] drm/dp: add subheadings to DPCD address definitions

2020-09-17 Thread Jani Nikula
Add the subheadings from the DP spec. No functional changes. Signed-off-by: Jani Nikula --- include/drm/drm_dp_helper.h | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 5c45195ced32..3d9900

[PATCH 2/2] drm/dp: add a number of DP 2.0 DPCD definitions

2020-09-17 Thread Jani Nikula
Prepare for future with DP 2.0 DPCD definitions, with a couple of related drive-by cleanups. No functional changes. Signed-off-by: Jani Nikula --- include/drm/drm_dp_helper.h | 52 - 1 file changed, 45 insertions(+), 7 deletions(-) diff --git a/include/drm/dr

Re: [PATCH 0/3] drm: panfrost: Coherency support

2020-09-17 Thread Tomeu Vizoso
On 9/17/20 12:38 PM, Steven Price wrote: On 16/09/2020 18:46, Rob Herring wrote: On Wed, Sep 16, 2020 at 11:04 AM Alyssa Rosenzweig wrote: So I get a performance regression with the dma-coherent approach, even if it's clearly the cleaner. That's bizarre -- this should really be the faster

Re: [PATCH 6/8] drm/vram-helper: don't use ttm bo->offset v4

2020-09-17 Thread Thomas Zimmermann
Hi Am 24.06.20 um 20:26 schrieb Nirmoy Das: > Calculate GEM VRAM bo's offset within vram-helper without depending on > bo->offset. > > Signed-off-by: Nirmoy Das > Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_gem_vram_helper.c | 11 ++- > 1 file changed, 10 insertions(+), 1 de

Re: Why is nouveau using a separate swap storage?

2020-09-17 Thread Ben Skeggs
On Thu, 17 Sep 2020 at 20:06, Christian König wrote: > > Hi guys, > > just another TTM feature which is only used by nouveau. > > We have this bo->bo.persistent_swap_storage pointer which is only set by > nouveau to the GEM filp and used when a BO is swapped to a shmem file. > > As far as I can se

Re: [PATCH v2 14/21] drm/tegra: Introduce GEM object functions

2020-09-17 Thread Thierry Reding
On Tue, Sep 15, 2020 at 04:59:51PM +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in tegra. > > Signed-off-by: Thomas Zimmermann > --- > driver

Re: [PATCH 0/3] drm: panfrost: Coherency support

2020-09-17 Thread Steven Price
On 17/09/2020 11:51, Tomeu Vizoso wrote: On 9/17/20 12:38 PM, Steven Price wrote: On 16/09/2020 18:46, Rob Herring wrote: On Wed, Sep 16, 2020 at 11:04 AM Alyssa Rosenzweig wrote: So I get a performance regression with the dma-coherent approach, even if it's clearly the cleaner. That's b

Re: drm/ast something ate high-res modes (5.3->5.6 regression)

2020-09-17 Thread Thomas Zimmermann
Hi Am 08.07.20 um 12:05 schrieb Ilpo Järvinen: > Hi, > > After upgrading kernel from 5.3 series to 5.6.16 something seems to > prevent me from achieving high resolutions with the ast driver. Are you able to build and run a test kernel? I'm seriously considering moving ast to the SHMEM memory m

Re: Why is nouveau using a separate swap storage?

2020-09-17 Thread Christian König
Am 17.09.20 um 12:51 schrieb Ben Skeggs: On Thu, 17 Sep 2020 at 20:06, Christian König wrote: Hi guys, just another TTM feature which is only used by nouveau. We have this bo->bo.persistent_swap_storage pointer which is only set by nouveau to the GEM filp and used when a BO is swapped to a sh

Re: [PATCH 6/8] drm/vram-helper: don't use ttm bo->offset v4

2020-09-17 Thread Christian König
Hi Thomas, Am 17.09.20 um 12:51 schrieb Thomas Zimmermann: Hi Am 24.06.20 um 20:26 schrieb Nirmoy Das: Calculate GEM VRAM bo's offset within vram-helper without depending on bo->offset. Signed-off-by: Nirmoy Das Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_gem_vram_helper.c | 11 +++

Re: [PATCHv2] dt-bindings: dp-connector: add binding for DisplayPort connector

2020-09-17 Thread Ville Syrjälä
On Thu, Sep 17, 2020 at 08:52:10AM +0300, Tomi Valkeinen wrote: > Add binding for DisplayPort connector. A few notes: > > * Similar to hdmi-connector, it has hpd-gpios as an optional property, > as the HPD could also be handled by, e.g., the DP bridge. > > * dp-pwr-supply, which provides 3.3V o

Re: [PATCH v2 18/21] drm/vkms: Introduce GEM object functions

2020-09-17 Thread Melissa Wen
Hi Thomas, On 09/15, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in vkms. > > Signed-off-by: Thomas Zimmermann Thanks! Looks fine. Reviewed-by: M

Re: [PATCH 6/6] drm/meson: add support for MIPI-DSI transceiver

2020-09-17 Thread Daniel Vetter
On Thu, Sep 17, 2020 at 09:14:33AM +0200, Neil Armstrong wrote: > On 08/09/2020 10:46, Daniel Vetter wrote: > > On Tue, Sep 08, 2020 at 10:06:03AM +0200, Neil Armstrong wrote: > >> Hi, > >> > >> On 07/09/2020 20:03, Daniel Vetter wrote: > >>> On Mon, Sep 07, 2020 at 11:03:29AM +0200, Neil Armstrong

Re: [PATCH v2 0/4] Enlarge tracepoints in the display component

2020-09-17 Thread Daniel Vetter
On Wed, Sep 16, 2020 at 11:27:27AM -0400, Kazlauskas, Nicholas wrote: > On 2020-09-16 5:12 a.m., Daniel Vetter wrote: > > On Fri, Sep 11, 2020 at 10:59:23AM -0400, Rodrigo Siqueira wrote: > > > Debug issues related to display can be a challenge due to the complexity > > > around this topic and diff

Re: [PATCH] drm: fix spelling error in comments

2020-09-17 Thread Daniel Vetter
On Thu, Sep 17, 2020 at 10:04:32AM +0800, Wang Qing wrote: > Change the comment typo: "manger" -> "manager". > > Signed-off-by: Wang Qing Pushed to drm-misc-next, thanks for your patch. -Daniel > --- > include/drm/drm_mm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] drm/ttm: remove superflous extern attribute from funcs

2020-09-17 Thread Daniel Vetter
On Thu, Sep 17, 2020 at 11:48:37AM +0200, Christian König wrote: > Extern is the default attribute for functions anyway. > > Signed-off-by: Christian König Reviewed-by: Daniel Vetter > --- > include/drm/ttm/ttm_execbuf_util.h | 19 --- > include/drm/ttm/ttm_memory.h | 25

Re: [PATCH] drm/ttm: remove redundant initialization of variable ret

2020-09-17 Thread Christian König
Am 17.09.20 um 13:42 schrieb Jing Xiangfeng: The variable ret is being initialized with '-ENOMEM' that is meaningless. So remove it. Signed-off-by: Jing Xiangfeng Stumbled over the same thing just a few days ago, so this is already fixed in my branch. --- drivers/gpu/drm/ttm/ttm_tt.c |

Re: [Linaro-mm-sig] Changing vma->vm_file in dma_buf_mmap()

2020-09-17 Thread Christian König
Am 17.09.20 um 13:31 schrieb Jason Gunthorpe: On Thu, Sep 17, 2020 at 10:09:12AM +0200, Daniel Vetter wrote: Yeah, but it doesn't work when forwarding from the drm chardev to the dma-buf on the importer side, since you'd need a ton of different address spaces. And you still rely on the core cod

Why can't ttm_tt_swapout() handle uncached or WC BOs?

2020-09-17 Thread Christian König
Hi guys, Michel once submitted a patch to fix triggering this BUG_ON in ttm_tt_swapout(): BUG_ON(ttm->caching_state != tt_cached); Now my question is does anybody know why we have that in the first place? The only problematic thing I can see is calling copy_highpage() and that one is just

Re: [Linaro-mm-sig] Changing vma->vm_file in dma_buf_mmap()

2020-09-17 Thread Christian König
Am 17.09.20 um 14:18 schrieb Jason Gunthorpe: On Thu, Sep 17, 2020 at 02:03:48PM +0200, Christian König wrote: Am 17.09.20 um 13:31 schrieb Jason Gunthorpe: On Thu, Sep 17, 2020 at 10:09:12AM +0200, Daniel Vetter wrote: Yeah, but it doesn't work when forwarding from the drm chardev to the dma

Re: [Linaro-mm-sig] Changing vma->vm_file in dma_buf_mmap()

2020-09-17 Thread Daniel Vetter
On Thu, Sep 17, 2020 at 02:24:29PM +0200, Christian König wrote: > Am 17.09.20 um 14:18 schrieb Jason Gunthorpe: > > On Thu, Sep 17, 2020 at 02:03:48PM +0200, Christian König wrote: > > > Am 17.09.20 um 13:31 schrieb Jason Gunthorpe: > > > > On Thu, Sep 17, 2020 at 10:09:12AM +0200, Daniel Vetter w

Re: [PATCH 6/8] drm/vram-helper: don't use ttm bo->offset v4

2020-09-17 Thread Thomas Zimmermann
Hi Christian Am 17.09.20 um 13:12 schrieb Christian König: > Hi Thomas, > > Am 17.09.20 um 12:51 schrieb Thomas Zimmermann: >> Hi >> >> Am 24.06.20 um 20:26 schrieb Nirmoy Das: >>> Calculate GEM VRAM bo's offset within vram-helper without depending on >>> bo->offset. >>> >>> Signed-off-by: Nirmoy

Re: [PATCH 6/8] drm/vram-helper: don't use ttm bo->offset v4

2020-09-17 Thread Christian König
Am 17.09.20 um 14:29 schrieb Thomas Zimmermann: Hi Christian Am 17.09.20 um 13:12 schrieb Christian König: Hi Thomas, Am 17.09.20 um 12:51 schrieb Thomas Zimmermann: Hi Am 24.06.20 um 20:26 schrieb Nirmoy Das: Calculate GEM VRAM bo's offset within vram-helper without depending on bo->offset

Re: drm/ast something ate high-res modes (5.3->5.6 regression)

2020-09-17 Thread Thomas Zimmermann
Hi Am 17.09.20 um 13:17 schrieb Ilpo Järvinen: > Hi, > > Yes, I can build custom kernels and test but I won't have time for that > before the end of September so I'll do it only then. No problem, that's still fine. Best regards Thomas > > And thanks a lot :-). > -- Thomas Zimmermann Graph

Re: [PATCH 0/3] drm: panfrost: Coherency support

2020-09-17 Thread Robin Murphy
On 2020-09-16 18:46, Rob Herring wrote: On Wed, Sep 16, 2020 at 11:04 AM Alyssa Rosenzweig wrote: So I get a performance regression with the dma-coherent approach, even if it's clearly the cleaner. That's bizarre -- this should really be the faster of the two. Coherency may not be free. C

Re: [PATCH v2 10/18] drm/dp: Add drm_dp_downstream_{min,max}_tmds_clock()

2020-09-17 Thread Ville Syrjälä
On Tue, Sep 08, 2020 at 02:04:56PM -0400, Lyude Paul wrote: > On Fri, 2020-09-04 at 14:53 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Add helpers to get the TMDS clock limits for HDMI/DVI downstream > > facing ports. > > > > Signed-off-by: Ville Syrjälä > > --- > > drivers/gpu/

Re: [PATCH 6/8] drm/vram-helper: don't use ttm bo->offset v4

2020-09-17 Thread Nirmoy
On 9/17/20 2:29 PM, Thomas Zimmermann wrote: Hi Christian Am 17.09.20 um 13:12 schrieb Christian König: Hi Thomas, Am 17.09.20 um 12:51 schrieb Thomas Zimmermann: Hi Am 24.06.20 um 20:26 schrieb Nirmoy Das: Calculate GEM VRAM bo's offset within vram-helper without depending on bo->offset.

Re: [PATCH] drm/nouveau: Drop mutex_lock_nested for atomic

2020-09-17 Thread Daniel Vetter
Ben, did you have a chance to look at this? -Daniel On Mon, Aug 3, 2020 at 1:22 PM Maarten Lankhorst wrote: > > Op 02-08-2020 om 20:18 schreef Daniel Vetter: > > Purely conjecture, but I think the original locking inversion with the > > legacy page flip code between flipping and ttm's bo move fun

Re: [PATCH 6/8] drm/vram-helper: don't use ttm bo->offset v4

2020-09-17 Thread Thomas Zimmermann
Hi Am 17.09.20 um 14:58 schrieb Nirmoy: > > On 9/17/20 2:29 PM, Thomas Zimmermann wrote: >> Hi Christian >> >> Am 17.09.20 um 13:12 schrieb Christian König: >>> Hi Thomas, >>> >>> Am 17.09.20 um 12:51 schrieb Thomas Zimmermann: Hi Am 24.06.20 um 20:26 schrieb Nirmoy Das: > Calc

Re: [PATCH] dma-resv: lockdep-prime address_space->i_mmap_rwsem for dma-resv

2020-09-17 Thread Daniel Vetter
On Thu, Jul 30, 2020 at 06:45:14PM +0200, Thomas Hellström (Intel) wrote: > > On 7/30/20 3:17 PM, Daniel Vetter wrote: > > On Thu, Jul 30, 2020 at 2:17 PM Thomas Hellström (Intel) > > wrote: > > > > > > On 7/28/20 3:58 PM, Daniel Vetter wrote: > > > > GPU drivers need this in their shrinkers, to

Re: [PATCH v2 16/21] drm/vgem: Introduce GEM object functions

2020-09-17 Thread Melissa Wen
Hi Thomas, On 09/15, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in vgem. The only exception is gem_prime_mmap, > which is non-trivial to convert. >

[PATCH] fbdev: mx3fb: remove unused variable 'irq'

2020-09-17 Thread Xiaofei Tan
Remove the variable 'irq' that is set but never used. Signed-off-by: Xiaofei Tan --- drivers/video/fbdev/mx3fb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c index 603731a..894617d 100644 --- a/drivers/video/fbdev/mx3fb.c +++ b/dr

Re: [Linaro-mm-sig] Changing vma->vm_file in dma_buf_mmap()

2020-09-17 Thread Jason Gunthorpe
On Thu, Sep 17, 2020 at 02:03:48PM +0200, Christian König wrote: > Am 17.09.20 um 13:31 schrieb Jason Gunthorpe: > > On Thu, Sep 17, 2020 at 10:09:12AM +0200, Daniel Vetter wrote: > > > > > Yeah, but it doesn't work when forwarding from the drm chardev to the > > > dma-buf on the importer side, si

[PATCH v16 0/2] Add initial support for slimport anx7625

2020-09-17 Thread Xin Ji
Hi all, The following series add support for the Slimport ANX7625 transmitter, a ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable device. This is the v16 version, any mistakes, please let me know, I will fix it in the next series. Change history: v16: Fix compile error -

[PATCH] drm/vc4: hvs: Pull the state of all the CRTCs prior to PV muxing

2020-09-17 Thread Maxime Ripard
The vc4 display engine has a first controller called the HVS that will perform the composition of the planes. That HVS has 3 FIFOs and can therefore compose planes for up to three outputs. The timings part is generated through a component called the Pixel Valve, and the BCM2711 has 6 of them. Thus

[PATCH -next v2] gpu: host1x: debug: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-17 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. drivers/gpu/host1x/debug.c | 28 1 file changed, 4 insertions(+), 24 deletions(-) diff --git a

[PATCH v16 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP

2020-09-17 Thread Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/Kconfig |9 + drivers/gpu/drm/bridge/analogix/Makefile |1 + drivers/gpu/drm/bridge/analog

[PATCH v16 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter DT schema

2020-09-17 Thread Xin Ji
anx7625: MIPI to DP transmitter DT schema Signed-off-by: Xin Ji Reviewed-by: Rob Herring --- .../bindings/display/bridge/analogix,anx7625.yaml | 95 ++ 1 file changed, 95 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/analogix,anx7625.ya

Re: [PATCH -next] drm/komeda: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-17 Thread miaoqinglang
27;t cause too many troubles. -Daniel Hi James & Daniel, I've sent v2 patch based on based on linux-next(20200917), and can be applied to mainline cleanly now. Thanks. > ​Thanks. Qinglang . Cheers, Daniel Thanks James #ifdef CONFIG_DEBUG_FS

[PATCH -next v2] drm/komeda: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-17 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff

[PATCH v1] fbdev: aty: remove CONFIG_PM container

2020-09-17 Thread Vaibhav Gupta
The changes made in below mentioned commit removed CONFIG_PM containers from drivers/video/fbdev/aty/atyfb_base.c but not from drivers/video/fbdev/aty/atyfb.h for respective callbacks. This resulted in error for implicit declaration for those callbacks. Fixes: 348b2956d5e6 ("fbdev: aty: use gener

Re: [PATCH -next] gpu: host1x: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-17 Thread miaoqinglang
l request for v5.9-rc1, so I'll just defer this to v5.10 since it doesn't look like it's anything urgent. Thierry Hi, Thierry I've sent a new patch against linux-next(20200917), and can be applied to mainline cleanly now. So I suggest you v2 patch. Thanks. ___

[PATCH] drm/ttm: remove redundant initialization of variable ret

2020-09-17 Thread Jing Xiangfeng
The variable ret is being initialized with '-ENOMEM' that is meaningless. So remove it. Signed-off-by: Jing Xiangfeng --- drivers/gpu/drm/ttm/ttm_tt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c index 3437711ddb4

[PATCH] fbcon: Remove the superfluous break

2020-09-17 Thread Jing Xiangfeng
Remove the superfuous break, as there is a 'return' before it. Signed-off-by: Jing Xiangfeng --- drivers/video/fbdev/core/fbcon.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index 0b49b0f44edf..623359aadd1e 100644 --- a

Re: [Linaro-mm-sig] Changing vma->vm_file in dma_buf_mmap()

2020-09-17 Thread Jason Gunthorpe
On Thu, Sep 17, 2020 at 10:09:12AM +0200, Daniel Vetter wrote: > Yeah, but it doesn't work when forwarding from the drm chardev to the > dma-buf on the importer side, since you'd need a ton of different > address spaces. And you still rely on the core code picking up your > pgoff mangling, which f

Re: [PATCH 0/3] drm: panfrost: Coherency support

2020-09-17 Thread Alyssa Rosenzweig
> The DDK blob has the ability to mark only certain areas of memory as > coherent for performance reasons. For simple things like kmscube I would > expect that it's basically write-only from the CPU and almost all memory the > GPU touches isn't touched by the CPU. I.e. coherency isn't helping and t

Re: [PATCH v2 1/2] drm/nouveau: return temperatures in temp_get() via parameter

2020-09-17 Thread Jeremy Cline
On Wed, Sep 16, 2020 at 10:03:22PM +0200, Karol Herbst wrote: > On Wed, Sep 16, 2020 at 10:01 PM Karol Herbst wrote: > > > > On Wed, Sep 16, 2020 at 9:47 PM Jeremy Cline wrote: > > > > > > The temp_get() function currently returns negative error numbers or a > > > temperature. However, the therma

[PATCH] drm/vgem: validate vgem_device before exit operations

2020-09-17 Thread Melissa Wen
This patch adds a check for the vgem_device before handling it. Signed-off-by: Melissa Wen --- drivers/gpu/drm/vgem/vgem_drv.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c index cb884c890065..119ca88

Re: [PATCH v2 1/2] drm/nouveau: return temperatures in temp_get() via parameter

2020-09-17 Thread Karol Herbst
On Thu, Sep 17, 2020 at 4:11 PM Jeremy Cline wrote: > > On Wed, Sep 16, 2020 at 10:03:22PM +0200, Karol Herbst wrote: > > On Wed, Sep 16, 2020 at 10:01 PM Karol Herbst wrote: > > > > > > On Wed, Sep 16, 2020 at 9:47 PM Jeremy Cline wrote: > > > > > > > > The temp_get() function currently returns

[PATCH 1/2] drm/nouveau: stop using persistent_swap_storage

2020-09-17 Thread Christian König
According to Ben this is most likely just a leftover. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_gem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c index 89adadf4706b..5945c663381d 100644

[PATCH 2/2] drm/ttm: remove persistent_swap_storage

2020-09-17 Thread Christian König
Not used any more. Cleanup the code as well while at it. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 2 +- drivers/gpu/drm/ttm/ttm_tt.c | 61 include/drm/ttm/ttm_bo_api.h | 4 --- include/drm/ttm/ttm_tt.h | 3 +- 4 files changed,

Re: [PATCH] drm/vgem: validate vgem_device before exit operations

2020-09-17 Thread Daniel Vetter
On Thu, Sep 17, 2020 at 4:21 PM Melissa Wen wrote: > > This patch adds a check for the vgem_device before handling it. > > Signed-off-by: Melissa Wen Seems reasonable. Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/vgem/vgem_drv.c | 9 - > 1 file changed, 8 insertions(+), 1 deletio

RE: [PATCH] drm/vgem: validate vgem_device before exit operations

2020-09-17 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Melissa Wen >Sent: Thursday, September 17, 2020 10:22 AM >To: Daniel Vetter ; David Airlie >Cc: dri-devel@lists.freedesktop.org >Subject: [PATCH] drm/vgem: validate vgem_device before exit operations > >This patch adds a check for the vge

Re: Why can't ttm_tt_swapout() handle uncached or WC BOs?

2020-09-17 Thread Michel Dänzer
On 2020-09-17 2:20 p.m., Christian König wrote: Hi guys, Michel once submitted a patch to fix triggering this BUG_ON in ttm_tt_swapout(): BUG_ON(ttm->caching_state != tt_cached); Now my question is does anybody know why we have that in the first place? The only problematic thing I can see

Re: Why can't ttm_tt_swapout() handle uncached or WC BOs?

2020-09-17 Thread Christian König
Am 17.09.20 um 16:44 schrieb Michel Dänzer: On 2020-09-17 2:20 p.m., Christian König wrote: Hi guys, Michel once submitted a patch to fix triggering this BUG_ON in ttm_tt_swapout(): BUG_ON(ttm->caching_state != tt_cached); Now my question is does anybody know why we have that in the first

  1   2   >