Re: [PATCH] drm/panfrost: Set DMA max segment size

2020-09-10 Thread Steven Price
On 03/09/2020 14:59, Robin Murphy wrote: Since all we do with scatterlists is map them in the MMU, we don't have any hardware constraints on how they're laid out. Let the DMA layer know so it won't warn when DMA API debugging is enabled. Signed-off-by: Robin Murphy Applied to drm-misc-next S

Re: [PATCH] drm/panfrost: Ensure GPU quirks are always initialised

2020-09-10 Thread Steven Price
On 09/09/2020 13:29, Steven Price wrote: The GPU 'CONFIG' registers used to work around hardware issues are cleared on reset so need to be programmed every time the GPU is reset. However panfrost_device_reset() failed to do this. To avoid this in future instead move the call to panfrost_gpu_init

Re: [PATCH v2 10/18] drm/dp: Add drm_dp_downstream_{min,max}_tmds_clock()

2020-09-10 Thread Ville Syrjälä
On Tue, Sep 08, 2020 at 02:08:17PM -0400, Lyude Paul wrote: > On Fri, 2020-09-04 at 14:53 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Add helpers to get the TMDS clock limits for HDMI/DVI downstream > > facing ports. > > > > Signed-off-by: Ville Syrjälä > > --- > > drivers/gpu/

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Robin Murphy
On 2020-09-09 21:06, Joe Perches wrote: fallthrough to a separate case/default label break; isn't very readable. Convert pseudo-keyword fallthrough; statements to a simple break; when the next label is case or default and the only statement in the next label block is break; Found using: $ grep

Re: [PATCH v2 -next] drm/amdkfd: Fix -Wunused-const-variable warning

2020-09-10 Thread Felix Kuehling
Am 2020-09-10 um 3:50 a.m. schrieb YueHaibing: > If KFD_SUPPORT_IOMMU_V2 is not set, gcc warns: > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device.c:121:37: warning: > ‘raven_device_info’ defined but not used [-Wunused-const-variable=] > static const struct kfd_device_info raven_device_info = {

Re: [PATCH] video: fbdev: fsl-diu-fb: remove unneeded variable 'res'

2020-09-10 Thread Gustavo A. R. Silva
On Thu, Sep 10, 2020 at 10:05:58PM +0800, Jason Yan wrote: > Eliminate the following coccicheck warning: > > drivers/video/fbdev/fsl-diu-fb.c:1428:5-8: Unneeded variable: "res". > Return "0" on line 1450 > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Acked-by: Gustavo A. R. Silva Tha

[Bug 209225] New: [AMDGPU] oops each boot: dc_link_set_backlight_level

2020-09-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209225 Bug ID: 209225 Summary: [AMDGPU] oops each boot: dc_link_set_backlight_level Product: Drivers Version: 2.5 Kernel Version: 5.8.7, 5.8.8 Hardware: x86-64 OS: Linux

Re: [PATCH v2 07/18] drm/dp: Pimp drm_dp_downstream_max_bpc()

2020-09-10 Thread Ville Syrjälä
On Tue, Sep 08, 2020 at 01:51:56PM -0400, Lyude Paul wrote: > On Fri, 2020-09-04 at 14:53 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Deal with more cases in drm_dp_downstream_max_bpc(): > > - DPCD 1.0 -> assume 8bpc for non-DP > > - DPCD 1.1+ DP (or DP++ with DP sink) -> allow an

[Bug 209091] i915: drm:fw_domains_get [i915] *ERROR* render: timed out waiting for forcewake ack request.

2020-09-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209091 Jani Nikula (jani.nik...@intel.com) changed: What|Removed |Added Status|NEW |RESOLVED Re

Re: [PATCH -next] drm/amd/display: Fix possible memleak in dp_trigger_hotplug()

2020-09-10 Thread Harry Wentland
On 2020-09-09 11:26 p.m., YueHaibing wrote: If parse_write_buffer_into_params() fails, we should free wr_buf before return. Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger debugfs entry") Signed-off-by: YueHaibing Reviewed-by: Harry Wentland Harry --- drivers/gpu/drm/am

Re: [PATCH -next] drm/amd/display: Create trigger_hotplug entry

2020-09-10 Thread Harry Wentland
On 2020-09-09 11:13 p.m., YueHaibing wrote: Add trigger_hotplug debugfs entry. Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger debugfs entry") Signed-off-by: YueHaibing Reviewed-by: Harry Wentland Harry --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 1 +

[Bug 209225] [AMDGPU] oops each boot: dc_link_set_backlight_level

2020-09-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209225 --- Comment #1 from Arthur Borsboom (arthurborsb...@gmail.com) --- Possibly related to this fix: https://bugzilla.kernel.org/show_bug.cgi?id=203905 If I looked well at kernel.org, it seemed that this fix is included in kernel 5.7.8 (the one in t

[Bug 209225] [AMDGPU] oops each boot: dc_link_set_backlight_level

2020-09-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209225 Arthur Borsboom (arthurborsb...@gmail.com) changed: What|Removed |Added See Also||https://bugzi

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Vitaly Prosyak
On 2020-09-10 6:56 a.m., Laurent Pinchart wrote: Hi Pekka, On Thu, Sep 10, 2020 at 01:28:03PM +0300, Pekka Paalanen wrote: On Thu, 10 Sep 2020 12:30:09 +0300 Laurentiu Palcu wrote: On Thu, Sep 10, 2020 at 11:50:26AM +0300, Pekka Paalanen wrote: On Thu, 10 Sep 2020 09:52:26 +0200 Daniel Vette

Re: [PATCH] V2: Currently, DRM get the capability of the mst hub only from DP_DPCD_REV and get the slower speed even the mst hub can run in the faster speed.

2020-09-10 Thread Lyude Paul
The commit message should be shorter and follow the format other commits for drm usually do, in this case something like: drm/dp_mst: Retrieve extended DPCD caps for topology manager On Thu, 2020-09-10 at 14:36 +0800, Koba Ko wrote: > As per DP-1.3, First check DP_EXTENDED_RECEIVER_CAP_FIELD_PRES

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Laurent Pinchart
Hi Vitaly, On Thu, Sep 10, 2020 at 01:09:03PM -0400, Vitaly Prosyak wrote: > On 2020-09-10 6:56 a.m., Laurent Pinchart wrote: > > On Thu, Sep 10, 2020 at 01:28:03PM +0300, Pekka Paalanen wrote: > >> On Thu, 10 Sep 2020 12:30:09 +0300 Laurentiu Palcu wrote: > >>> On Thu, Sep 10, 2020 at 11:50:26AM

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Vitaly Prosyak
On 2020-09-10 1:51 p.m., Laurent Pinchart wrote: Hi Vitaly, On Thu, Sep 10, 2020 at 01:09:03PM -0400, Vitaly Prosyak wrote: On 2020-09-10 6:56 a.m., Laurent Pinchart wrote: On Thu, Sep 10, 2020 at 01:28:03PM +0300, Pekka Paalanen wrote: On Thu, 10 Sep 2020 12:30:09 +0300 Laurentiu Palcu wrot

Re: [PATCH] drm: xlnx: remove defined but not used 'scaling_factors_666'

2020-09-10 Thread Hyun Kwon
Hi Jason, On Thu, Sep 10, 2020 at 07:06:30AM -0700, Jason Yan wrote: > This addresses the following gcc warning with "make W=1": > > drivers/gpu/drm/xlnx/zynqmp_disp.c:245:18: warning: > ‘scaling_factors_666’ defined but not used [-Wunused-const-variable=] > 245 | static const u32 scaling_facto

RE: [PATCH v3 6/7] drm: Validate encoder->possible_crtcs

2020-09-10 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: amd-gfx On Behalf Of > Daniel Vetter > Sent: Monday, September 7, 2020 3:15 AM > To: Jan Kiszka ; amd-gfx list g...@lists.freedesktop.org>; Wentland, Harry ; > Kazlauskas, Nicholas > Cc: dri-devel ; intel-gfx g...@lists.freedesktop.org>;

Re: [PATCH v4] gpu/drm: ingenic: Add option to mmap GEM buffers cached

2020-09-10 Thread Sam Ravnborg
Hi Paul. On Wed, Sep 09, 2020 at 03:26:52PM +0200, Paul Cercueil wrote: > Any love for my patch? I have more pending :) I have looked through the patch a few times. And I did not find any spelling errors. But the memory magic was beyond me so I hope someone more knowledgeable can chime in here.

Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-09-10 Thread Sam Ravnborg
Hi Daniel. > > + } > > + > > + /* Initialize MIPI DSI */ > > + ret = kmb_dsi_init(drm, adv_bridge); > > Split up isn't correct here, this won't compile since the dsi code isn't > in this patch yet. So you need to have this ordered the other way round. I have explicit asked for a simple fil

Re: [PATCH v9 0/5] Add support for iMX8MQ Display Controller Subsystem

2020-09-10 Thread Sam Ravnborg
Hi Laurentiu > > > I've tested this together with a hacked up eDP bridge driver stack on > > > my boards. The testing hasn't been really in-depth, but things seem to > > > work fine. I have now pushed the whole series into drm-misc-next. > > > > Something doesn't compile too well > > > > ERROR:

Re: [PATCH 4/4] drm/ttm: nuke memory type flags

2020-09-10 Thread Dave Airlie
I like it, For all 4, Reviewed-by: Dave Airlie On Thu, 10 Sep 2020 at 21:49, Christian König wrote: > > It's not supported to specify more than one of those flags. > So it never made sense to make this a flag in the first place. > > Nuke the flags and specify directly which memory type to use.

[PATCH v5 0/5] Add audio support for MSM DisplayPort driver

2020-09-10 Thread Abhinav Kumar
This series adds audio support for DP on MSM chipsets. It leverages the hdmi-codec interface [1] to communicate between the Display Port driver and the audio subsystem. These changes depend on the series [2] which adds Display Port support to MSM chipsets. [1] https://patchwork.kernel.org/project/

[PATCH v5 3/5] drm/msm/dp: add hook_plugged_cb hdmi-codec op for MSM DP driver

2020-09-10 Thread Abhinav Kumar
Add the hook_plugged_cb op for the MSM DP driver to signal connect and disconnect events to the hdmi-codec driver which in-turn shall notify the audio subsystem to start a new or teardown an existing session. Changes in v2: none Changes in v3: none Changes in v4: rebase on top of latest patchset o

[PATCH v5 1/5] drm/msm/dp: store dp_display in the driver data

2020-09-10 Thread Abhinav Kumar
Store the dp_display in the platform driver data instead of the dp_display_private. This is required to allow other sub-modules to reuse the platform driver data. Changes in v3: none Changes in v4: none Changes in v5: none Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_display.c |

[PATCH v5 5/5] drm/msm/dp: wait for audio notification before disabling clocks

2020-09-10 Thread Abhinav Kumar
In the current implementation, there is a very small window for the audio side to safely signal the hdmi_code_shutdown() before the clocks are disabled. Add some synchronization between the DP display and DP audio module to safely disable the clocks to avoid unclocked access from audio side. In a

[PATCH v5 2/5] drm/msm/dp: add audio support for Display Port on MSM

2020-09-10 Thread Abhinav Kumar
Introduce audio support for Display Port on MSM chipsets. This change integrates DP audio sub-module with the main Display Port platform driver. In addition, this change leverages hdmi_codec_ops to expose the operations to the audio driver. Changes in v2: fix up a compilation issue on drm-next br

[PATCH v5 4/5] drm/msm/dp: signal the hotplug disconnect in the event handler

2020-09-10 Thread Abhinav Kumar
Signal the hotplug disconnect event to the audio side in the event handler so that they are notified earlier and have more time to process the disconnect event. Changes in v2: none Changes in v3: none Changes in v4: rebase on top of latest patchset of dependency Changes in v5: rebase on top of lat

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Vitaly Prosyak
On 2020-09-10 2:07 p.m., Vitaly Prosyak wrote: On 2020-09-10 1:51 p.m., Laurent Pinchart wrote: Hi Vitaly, On Thu, Sep 10, 2020 at 01:09:03PM -0400, Vitaly Prosyak wrote: On 2020-09-10 6:56 a.m., Laurent Pinchart wrote: On Thu, Sep 10, 2020 at 01:28:03PM +0300, Pekka Paalanen wrote: On Th

Re: [PATCH v2 07/18] drm/dp: Pimp drm_dp_downstream_max_bpc()

2020-09-10 Thread Lyude Paul
On Thu, 2020-09-10 at 17:46 +0300, Ville Syrjälä wrote: > On Tue, Sep 08, 2020 at 01:51:56PM -0400, Lyude Paul wrote: > > On Fri, 2020-09-04 at 14:53 +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Deal with more cases in drm_dp_downstream_max_bpc(): > > > - DPCD 1.0 -> as

Re: [PATCH v2 10/18] drm/dp: Add drm_dp_downstream_{min,max}_tmds_clock()

2020-09-10 Thread Lyude Paul
On Thu, 2020-09-10 at 16:55 +0300, Ville Syrjälä wrote: > On Tue, Sep 08, 2020 at 02:08:17PM -0400, Lyude Paul wrote: > > On Fri, 2020-09-04 at 14:53 +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Add helpers to get the TMDS clock limits for HDMI/DVI downstream > > > faci

Re: [PATCH 2/3] arm64: dts: sc7180: add bus clock to mdp node for sc7180 target

2020-09-10 Thread Rob Clark
On Thu, Sep 10, 2020 at 3:00 PM Bjorn Andersson wrote: > > On Thu 16 Jul 11:35 UTC 2020, Kalyan Thota wrote: > > > From: Krishna Manikandan > > > > Move the bus clock to mdp device node,in order > > to facilitate bus band width scaling on sc7180 > > target. > > > > The parent device MDSS will not

RE: [PATCH v7 0/4] Add support for KeemBay DRM driver

2020-09-10 Thread Chrisanthus, Anitha
Hi Daniel, Thanks for your review. I have requested drm-next access here https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/291 Will address your comments in next emails. thanks, Anitha > -Original Message- > From: Daniel Vetter > Sent: Thursday, September 10, 2020 1:42 AM

Re: [PATCH v2 07/10] arm64: dts: renesas: r8a77961: Add DU device nodes

2020-09-10 Thread Kuninori Morimoto
Hi Geert > > From: Kuninori Morimoto > > > > This patch adds DU device nodes for R-Car M3-W+ (r8a77961) SoC. > > This patch was tested on R-Car M3-W+ Salvator-XS board. > > > > Signed-off-by: Kuninori Morimoto > > --- (snip) > > du: display@feb0 { > > +

Re: [PATCH v2 07/10] arm64: dts: renesas: r8a77961: Add DU device nodes

2020-09-10 Thread Laurent Pinchart
Hi Morimoto-san, On Fri, Sep 11, 2020 at 08:20:56AM +0900, Kuninori Morimoto wrote: > > > From: Kuninori Morimoto > > > > > > This patch adds DU device nodes for R-Car M3-W+ (r8a77961) SoC. > > > This patch was tested on R-Car M3-W+ Salvator-XS board. > > > > > > Signed-off-by: Kuninori Morimoto

Re: [PATCH v2 05/10] arm64: dts: renesas: r8a77961: Add FCP device nodes

2020-09-10 Thread Kuninori Morimoto
Hi Geert > > From: Kuninori Morimoto > > > > This patch adds FCP device nodes for R-Car M3-W+ (r8a77961) SoC. > > This patch was tested on R-Car M3-W+ Salvator-XS board. > > > > Signed-off-by: Kuninori Morimoto (snip) > Missing "iommus = <&ipmmu_vc0 16>;" (snip) > Missing "iommus = <&ipmmu_vi0

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-09-10 Thread Deepak Rawat
On Thu, 2020-09-10 at 08:19 +, Tang, Shaofeng wrote: > Hi Deepak, > > Do you have a new version of this patch now? > I take a try with it. and meet some typo and “incompatible pointer” > error. > If you have a new version, could you share it with us? > Hi Shaofeng, It seems you are running

[Bug 209015] Clocks are no longer reported for R9 390 GPU

2020-09-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209015 HenryJiM (henryjm11...@gmail.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Joe Perches
On Thu, 2020-09-10 at 15:21 +0100, Robin Murphy wrote: > On 2020-09-09 21:06, Joe Perches wrote: > > fallthrough to a separate case/default label break; isn't very readable. > > > > Convert pseudo-keyword fallthrough; statements to a simple break; when > > the next label is case or default and the

Re: [Intel-gfx][PATCH v2] drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid()

2020-09-10 Thread Zhenyu Wang
On 2020.09.08 20:11:21 +0200, Alejandro Sior wrote: > In the function intel_vgpu_reg_rw_edid of kvmgt.c, pos can be equal > to NULL for GPUs that do not properly support EDID. In those cases, when > pos gets passed to the handle_edid functions, it gets added a short offset > then it's dereferenced

<    1   2