Re: [PATCH] drm: ast: fix double __iomem sparse warning

2020-08-19 Thread Thomas Zimmermann
Hi Am 18.08.20 um 22:28 schrieb Randy Dunlap: > From: Randy Dunlap > > sparse complains about having 2 "__iomem" attributes on the same line > where only one is needed since the first one applies to everything > up to the ending ';'. > However, to make it clear(er) that both of these pointers ar

RE: [Intel-gfx] [PATCH v5 1/5] drm: Introduce plane and CRTC scaling filter properties

2020-08-19 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Pankaj > Bharadiya > Sent: Monday, August 3, 2020 10:00 AM > To: jani.nik...@linux.intel.com; dan...@ffwll.ch; > intel-...@lists.freedesktop.org; > dri-devel@lists.freedesktop.org; ville.syrj...@linux.intel.com; > dani...@collabora.co

RE: [PATCH v5 2/5] drm/drm-kms.rst: Add plane and CRTC scaling filter property documentation

2020-08-19 Thread Shankar, Uma
> -Original Message- > From: dri-devel On Behalf Of Pankaj > Bharadiya > Sent: Monday, August 3, 2020 10:00 AM > To: jani.nik...@linux.intel.com; dan...@ffwll.ch; > intel-...@lists.freedesktop.org; > dri-devel@lists.freedesktop.org; ville.syrj...@linux.intel.com; > dani...@collabora.co

RE: [PATCH v5 3/5] drm/i915: Introduce scaling filter related registers and bit fields.

2020-08-19 Thread Shankar, Uma
> -Original Message- > From: dri-devel On Behalf Of Pankaj > Bharadiya > Sent: Monday, August 3, 2020 10:00 AM > To: jani.nik...@linux.intel.com; dan...@ffwll.ch; > intel-...@lists.freedesktop.org; > dri-devel@lists.freedesktop.org; ville.syrj...@linux.intel.com; > dani...@collabora.co

RE: [Intel-gfx] [PATCH v5 4/5] drm/i915/display: Add Nearest-neighbor based integer scaling support

2020-08-19 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Pankaj > Bharadiya > Sent: Monday, August 3, 2020 10:00 AM > To: jani.nik...@linux.intel.com; dan...@ffwll.ch; > intel-...@lists.freedesktop.org; > dri-devel@lists.freedesktop.org; ville.syrj...@linux.intel.com; > dani...@collabora.co

RE: [PATCH v5 5/5] drm/i915: Enable scaling filter for plane and CRTC

2020-08-19 Thread Shankar, Uma
> -Original Message- > From: Laxminarayan Bharadiya, Pankaj > > Sent: Monday, August 3, 2020 10:00 AM > To: jani.nik...@linux.intel.com; dan...@ffwll.ch; > intel-...@lists.freedesktop.org; > dri-devel@lists.freedesktop.org; ville.syrj...@linux.intel.com; > dani...@collabora.com; Lattan

Re: [PATCH] drm/amd/display: remove unintended executable mode

2020-08-19 Thread Christian König
lwahn Reviewed-by: Christian König --- applies cleanly on current master and next-20200819 Alex, Christian, please pick this minor non-urgent cleanup patch. Alex is usually the one picking those up. If he misses something feel free to ping us once more. Thanks, Christian. Dennis, Jerry,

Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks

2020-08-19 Thread Michel Dänzer
On 2020-07-22 7:12 p.m., Alex Deucher wrote: > On Wed, Jul 22, 2020 at 10:25 AM Michel Dänzer wrote: >> On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote: >>> On 2020-07-22 8:51 a.m., Daniel Vetter wrote: On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer wrote: > > From: Michel Dänzer

Re: drm/bridge: Synopsys DW-HDMI bridge driver for the Ingenic JZ4780 (was Re: Specialising the Synopsys DW-HDMI bridge driver for the Ingenic JZ4780)

2020-08-19 Thread Ezequiel Garcia
Hello, First of all, I'd like to thank everyone for the great work on ingenic-drm. The driver is in very good shape and a pleasure to work with. Yesterday, I checked out branch "paulb-jz4780-ci20-hdmi-5.8-rc5", from git.goldelico.com/letux-kernel.git, rebased it on v5.9-rc1, and then run weston o

Re: [PATCH] video: backlight: sky81452-backlight: Fix refcount imbalance on error

2020-08-19 Thread Daniel Thompson
On Wed, Aug 19, 2020 at 11:04:56AM +0800, Dinghao Liu wrote: > When of_property_read_u32_array() returns an error code, a > pairing refcount decrement is needed to keep np's refcount > balanced. > > Fixes: f705806c9f355 ("backlight: Add support Skyworks SKY81452 backlight > driver") > Signed-off-

[PATCH 03/49] staging: hikey9xx/gpu: solve tearing issue of display

2020-08-19 Thread Mauro Carvalho Chehab
From: Liwei Cai The use of synchronization mechanisms to deal with the display of buffer, to solve the problem of display tearing. Signed-off-by: Wanchun Zheng Signed-off-by: Liwei Cai Signed-off-by: John Stultz Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/dw_drm_ds

[PATCH 02/49] staging: hikey9xx/gpu: port it to work with Kernel v4.9

2020-08-19 Thread Mauro Carvalho Chehab
From: John Stultz Update the driver to work with v4.9 kernels Signed-off-by: John Stultz Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/dw_drm_dsi.c | 4 +- drivers/staging/hikey9xx/gpu/kirin_dpe_reg.h | 1 + drivers/staging/hikey9xx/gpu/kirin_drm_drv.c | 3 +-

[PATCH 10/49] staging: hikey9xx/gpu: add debug prints for this driver

2020-08-19 Thread Mauro Carvalho Chehab
From: Xiubin Zhang Add some debug prints on adv7535 and kirin_drm_drv. Signed-off-by: Xiubin Zhang Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/hdmi/adv7535.c | 40 ++-- drivers/staging/hikey9xx/gpu/kirin_drm_drv.c | 2 +- 2 files changed, 37 inserti

[PATCH 29/49] staging: hikey9xx/gpu: add a possible implementation for atomic_disable

2020-08-19 Thread Mauro Carvalho Chehab
Currently, the method is empty. However, looking at the driver, it sounds it shouldn't be hard to implement it. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/staging/hik

[PATCH 24/49] staging: hikey9xx/gpu: fix the DRM setting logic

2020-08-19 Thread Mauro Carvalho Chehab
The logich which sets the MIPI parameters is currently wrong: it is using a value stored at cur_client, with actually points to the active location, and not to the one that it is about to be initialized. The entire logic sounds buggy, but for now let's just keep following it, by adding an extra va

[PATCH 09/49] staging: hikey9xx/gpu: Solve SR test reset problem for hikey970.

2020-08-19 Thread Mauro Carvalho Chehab
From: Xiubin Zhang Add HDMI/DSS power on&off in the SR flow. Signed-off-by: Xiubin Zhang Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/Makefile | 1 - drivers/staging/hikey9xx/gpu/dw_drm_dsi.c | 10 +-- .../staging/hikey9xx/gpu/kirin970_dpe_reg.h | 9 ++

[PATCH 06/49] staging: hikey9xx/gpu: Solve SR Cannot Display Problems.

2020-08-19 Thread Mauro Carvalho Chehab
From: Xiubin Zhang Add suspend and resume interface to solve SR Cannot Display Problems. Signed-off-by: Xiubin Zhang Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/dw_drm_dsi.c | 32 +++ drivers/staging/hikey9xx/gpu/hdmi/adv7535.c | 14 +- .../staging/hikey9xx/g

[PATCH 19/49] staging: hikey9xx/gpu: add a copy of set_reg() function there

2020-08-19 Thread Mauro Carvalho Chehab
This function has a too generic name to export it as a symbol. Also, we should likely use some other macro instead. So, for now, just copy it into the Kirin9xx dsi module, in order for the driver to build. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c

[PATCH 48/49] staging: hikey9xx/gpu: drop kirin9xx_pwm

2020-08-19 Thread Mauro Carvalho Chehab
This is part of support for a panel display. Those don't come with the Hikey 960 or 970 boards. As I don't have any of those for tests, and we didn't port another required driver for this to work, for now, let's drop it. This patch can be reversed later, if one would be adding support for it. Sig

[PATCH 14/49] staging: hikey9xx/gpu: get rid of kirin9xx_fbdev.c

2020-08-19 Thread Mauro Carvalho Chehab
We don't need to implement legacy fbdev support. Just use the FB emulation instead. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin9xx_drm_drv.c | 9 +- .../staging/hikey9xx/gpu/kirin9xx_drm_drv.h | 2 - drivers/staging/hikey9xx/gpu/kirin9xx_fb.c| 94 dr

[PATCH 23/49] staging: hikey9xx/gpu: Change the logic which sets the burst mode

2020-08-19 Thread Mauro Carvalho Chehab
The logic there is more complex than it needs. It also places the device with a wrong setting if the flags are missed. This currently happens on Kirin970 for HDMI, as there's a bug at the part of the driver which selects between PANEL or OUTPUT at encoder init code. Signed-off-by: Mauro Carvalho

[PATCH 15/49] staging: hikey9xx/gpu: get rid of some ifdefs

2020-08-19 Thread Mauro Carvalho Chehab
There are some #ifdefs there for non-existing CONFIG_ options (nor even at the downstream code). Let's get rid of those. It can be re-added later if ever needed. Signed-off-by: Mauro Carvalho Chehab --- .../hikey9xx/gpu/kirin9xx_drm_dpe_utils.c | 36 --- .../hikey9xx/gpu/kir

[PATCH 04/49] staging: hikey9xx/gpu: resolve the performance issue by interrupt mechanism

2020-08-19 Thread Mauro Carvalho Chehab
From: Liwei Cai There is an error at wait for vactive end flags, waiting vactive flag in 1ms maybe too rough, but it's not good to control the waiting grain size, there is no way to get the waiting unit, so the interrupt mechanism is the best way to solve this problem. Each frame would report ha

[PATCH 49/49] dt: display: Add binds for the DPE and DSI controller for Kirin 960/970

2020-08-19 Thread Mauro Carvalho Chehab
Add a description of the bindings used by Kirin 960/970 Display Serial Interface (DSI) controller and by its Display Engine (DPE). Signed-off-by: Mauro Carvalho Chehab --- .../display/hisilicon,hi3660-dpe.yaml | 99 + .../display/hisilicon,hi3660-dsi.yaml | 102 +

[PATCH 41/49] staging: hikey9xx/gpu: get rid of some unused data

2020-08-19 Thread Mauro Carvalho Chehab
There are some things inside struct dss_hw_ctx that are unused. Get rid of them. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h | 2 -- drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h | 3 --- drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c | 2 -- 3 fil

[PATCH 34/49] staging: hikey9xx/gpu: add support for enable/disable ldo3 regulator

2020-08-19 Thread Mauro Carvalho Chehab
This is needed for the DRM to work. Ok, right now, this is enabled on default fastboot logic, but, as soon as we enable the proper SPMI driver, such code is needed. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h | 4 +--- drivers/staging/hikey9xx/g

[PATCH 30/49] staging: hikey9xx/gpu: register connector

2020-08-19 Thread Mauro Carvalho Chehab
call drm_connector_register() when initializing the connector. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c b/drivers/staging/hikey9xx/gpu/kiri

[PATCH 11/49] staging: hikey9xx/gpu: Add support 10.1 inch special HDMI displays.

2020-08-19 Thread Mauro Carvalho Chehab
From: Xiubin Zhang Adjust pixel clock for compatibility with 10.1 inch special displays. Signed-off-by: Xiubin Zhang Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin_drm_dss.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/hikey9xx/gpu/kirin

[PATCH 20/49] staging: hikey9xx/gpu: get rid of ION headers

2020-08-19 Thread Mauro Carvalho Chehab
This is not used anymore on this version, so let's get rid of them. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h | 3 --- drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h | 3 --- drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.h | 2 -- 3 files changed,

[PATCH 45/49] dts: hikey970-pinctrl.dtsi: add missing pinctrl settings

2020-08-19 Thread Mauro Carvalho Chehab
There are several pinctrl settings that are missing at this DT file. Also, the entries are out of order. Add the missing bits, as they'll be required by the DRM driver - and probably by other drivers not upstreamed yet. Reorder the entres, adding the missing bits. Signed-off-by: Mauro Carvalho

[PATCH 16/49] staging: hikey9xx/gpu: rename the config option for Kirin970

2020-08-19 Thread Mauro Carvalho Chehab
Use the same standard as used on other Hisilicon DRM config vars for kirin9xx. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.c| 2 +- .../staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.h| 2 +- drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c

[PATCH 18/49] staging: hikey9xx/gpu: port driver to upstream kAPIs

2020-08-19 Thread Mauro Carvalho Chehab
There were several changes at the upstream kAPIs since Kernel 4.4. Update the driver for it to build with the upstream Kernel. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin9xx_drm_drv.c | 28 +++--- .../staging/hikey9xx/gpu/kirin9xx_drm_dss.c | 26 +++--- .../hikey9

[PATCH 40/49] staging: hikey9xx/gpu: get rid of input/output macros

2020-08-19 Thread Mauro Carvalho Chehab
The DPE headers define several macros for I/O. Get rid of them by replacing by the Linux ones. In the specific case of outp32(), I used this small coccinelle script to change them to writel(): @ rule1 @ expression addr, val; @@ -outp32(addr, val) +writel(va

[PATCH 31/49] staging: hikey9xx/gpu: fix driver name

2020-08-19 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c b/drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c index 09d035038c1a..99be8dfe05e6

[PATCH 13/49] staging: hikey9xx/gpu: rename the Kirin9xx namespace

2020-08-19 Thread Mauro Carvalho Chehab
There's already a driver with the same namespace for an older Kirin chipset. Rename this one, in order to make it clearer that this is the driver for Kirin 960/970. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/{kirin_dpe_reg.h => kirin9xx_dpe_reg.h} | 0 .../gpu/{kirin_drm_

[PATCH 07/49] staging: hikey9xx/gpu: Solve HDMI compatibility Problem.

2020-08-19 Thread Mauro Carvalho Chehab
From: Xiubin Zhang Modfiy pix_clk and dsi lanes to improve HDMI compatibility for hikey970. Signed-off-by: Xiubin Zhang Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/dw_drm_dsi.c | 53 ++- drivers/staging/hikey9xx/gpu/hdmi/adv7535.c | 9 +- .../hikey9xx/gp

[PATCH 36/49] staging: hikey9xx/gpu: solve most coding style issues

2020-08-19 Thread Mauro Carvalho Chehab
There are lots of coding style issues on this driver, as reported by checkpatch. Address most of them. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin960_dpe_reg.h | 340 +++-- .../staging/hikey9xx/gpu/kirin970_dpe_reg.h | 1199 - .../hikey9xx/gpu/ki

[PATCH 39/49] staging: hikey9xx/gpu: get rid of typedefs

2020-08-19 Thread Mauro Carvalho Chehab
There are a few typedefs inside this driver. Get rid of them. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin960_dpe_reg.h | 126 +- .../staging/hikey9xx/gpu/kirin970_dpe_reg.h | 117 .../hikey9xx/gpu/kirin9xx_drm_dpe_utils.c | 4

[PATCH 27/49] staging: hikey9xx/gpu: place vblank enable/disable at the right place

2020-08-19 Thread Mauro Carvalho Chehab
Those methods belong to crtc fops Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin9xx_drm_dss.c | 21 ++- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c b/drivers/staging/hikey9xx/gpu/kirin

[PATCH 22/49] staging: hikey9xx/gpu: cleanup encoder attach logic

2020-08-19 Thread Mauro Carvalho Chehab
Place both adv7535 and panel logic at the same routine, cleaning up things a little bit and fixing the includes. Signed-off-by: Mauro Carvalho Chehab --- .../hikey9xx/gpu/kirin9xx_dw_drm_dsi.c| 58 ++- 1 file changed, 31 insertions(+), 27 deletions(-) diff --git a/driver

[PATCH 38/49] staging: hikey9xx/gpu: add kirin9xx driver to the building system

2020-08-19 Thread Mauro Carvalho Chehab
Now that everything is in place, add the driver to the building system. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/Kconfig | 3 ++ drivers/staging/hikey9xx/Makefile | 1 + drivers/staging/hikey9xx/gpu/Kconfig | 52 ++- drivers/staging/hi

[PATCH 17/49] staging: hikey9xx/gpu: change the includes to reflect upstream

2020-08-19 Thread Mauro Carvalho Chehab
The includes there reflect a downstream version back on v4.4 times. change them to reflect the current upstream and to avoid the need of using a -I flag at the Makefile. Signed-off-by: Mauro Carvalho Chehab --- ...{kirin9xx_dpe_reg.h => kirin960_dpe_reg.h} | 3 +++ .../staging/hikey9xx/gpu/kiri

[PATCH 33/49] staging: hikey9xx/gpu: re-work the mode validation code

2020-08-19 Thread Mauro Carvalho Chehab
Do some cleanups at the mode validation code. Right now, there is a known issue with this driver which makes it to set up some invalid modes, depending on the display. We don't know yet what the issue is, so, instead, let's add a table with the modes which are known to work. Signed-off-by: Mauro

[PATCH 43/49] staging: hikey9xx/gpu: get rid of DRM_HISI_KIRIN970

2020-08-19 Thread Mauro Carvalho Chehab
There are lots of ifdefs checking if the SoC version is 960 or 970. Replace them all by runtime definitions. With that, the same DRM driver should work with both versions. The behavior will dynamically change depending on the OF compatible strings. Signed-off-by: Mauro Carvalho Chehab --- driv

[PATCH 08/49] staging: hikey9xx/gpu: Support MIPI DSI 3 lanes for hikey970.

2020-08-19 Thread Mauro Carvalho Chehab
From: Xiubin Zhang Modfiy mipi dsi lanes to improve HDMI compatibility. Signed-off-by: Xiubin Zhang Signed-off-by: Liuyao An Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/dw_drm_dsi.c | 24 --- drivers/staging/hikey9xx/gpu/hdmi/adv7535.c | 4 ---

[PATCH 47/49] dts: add support for Hikey 970 DRM

2020-08-19 Thread Mauro Carvalho Chehab
Add the needed bits for the DRM driver to work with the Hikey 970 board. Signed-off-by: Mauro Carvalho Chehab --- .../boot/dts/hisilicon/hi3670-hikey970.dts| 52 +++ arch/arm64/boot/dts/hisilicon/hi3670.dtsi | 6 + .../boot/dts/hisilicon/hikey970-drm.dtsi | 130 ++

[PATCH 21/49] staging: hikey9xx/gpu: add support for using a reserved CMA memory

2020-08-19 Thread Mauro Carvalho Chehab
Allocate the framebuffer memory via CMA, as otherwise the drm driver may not work properly with X11. Part of the changes here were based on a patch originally authored by: alik The original version can be found at: https://github.com/Bigcountry907/linux/commit/046e29834ef1c523c

[PATCH 25/49] staging: hikey9xx/gpu: do some code cleanups

2020-08-19 Thread Mauro Carvalho Chehab
- Get rid of a global var meant to store one of its priv structs; - Change the name of the driver, in order to not be confused with the kirin6220; - Remove some unneeded ifdef; - use drm_of.h helper. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin9xx_drm_drv.c | 81

[PATCH 28/49] staging: hikey9xx/gpu: remove an uneeded hack

2020-08-19 Thread Mauro Carvalho Chehab
At least on current upstream Kernels, forcing an event parse during init time isn't needed anymore. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.c b/

[PATCH 44/49] dts: hisilicon: hi3670.dtsi: add I2C settings

2020-08-19 Thread Mauro Carvalho Chehab
The I2C buses are not declared at the device tree. As this will be needed by further patches, add them, keeping all in disabled state. Per-board settings can override it. Signed-off-by: Mauro Carvalho Chehab --- arch/arm64/boot/dts/hisilicon/hi3670.dtsi | 71 +++ 1 file chang

[PATCH 12/49] staging: hikey9xx/gpu: get rid of adv7535 fork

2020-08-19 Thread Mauro Carvalho Chehab
The OOT had a fork of adv7535 with some changes for it to work with a failing EDID retrival I/O. Get rid of it, as we'll be using the upstream driver. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/hdmi/adv7535.c | 1678 - drivers/staging/hikey9xx/gpu/hd

[PATCH 32/49] staging: hikey9xx/gpu: get rid of iommu_format

2020-08-19 Thread Mauro Carvalho Chehab
Those aren't needed anymore. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h | 1 - drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h | 1 - drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.h | 2 -- 3 files changed, 4 deletions(-) diff --git a/drivers/stagin

[PATCH 46/49] dt: hisilicon: add support for the PMIC found on Hikey 970

2020-08-19 Thread Mauro Carvalho Chehab
Add a device tree for the HiSilicon 6421v600 SPMI PMIC, used on HiKey970 board. As we now have support for it, change the fixed regulators used by the SD I/O to use the proper LDO supplies. Signed-off-by: Mauro Carvalho Chehab --- .../boot/dts/hisilicon/hi3670-hikey970.dts| 22 +- .../boot

[PATCH 00/49] DRM driver for Hikey 970

2020-08-19 Thread Mauro Carvalho Chehab
This patch series port the out-of-tree driver for Hikey 970 (which should also support Hikey 960) from the official 96boards tree: https://github.com/96boards-hikey/linux/tree/hikey970-v4.9 Based on his history, this driver seems to be originally written for Kernel 4.4, and was later ported to

[PATCH 26/49] staging: hikey9xx/gpu: use default GEM_CMA fops

2020-08-19 Thread Mauro Carvalho Chehab
Instead of implementing it at the code, use the default methods from CMA helper Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/staging/hikey9xx/gpu/kirin9xx_drm_dr

[PATCH 37/49] staging: hikey9xx/gpu: don't use iommu code

2020-08-19 Thread Mauro Carvalho Chehab
While this driver apparently supports both IOMMU and no-IOMMU access, it always enable the IOMMU via some code, at the downstream version. Apparently, the downstream iommu is there just to get the physical address of the logical IOMMU address. Based on the downstream code, it sounds that the IOMMU

[PATCH 35/49] staging: hikey9xx/gpu: add SPMI headers

2020-08-19 Thread Mauro Carvalho Chehab
Use SPMI headers to identify the license of each file. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin960_dpe_reg.h | 1 + .../staging/hikey9xx/gpu/kirin970_dpe_reg.h | 1 + .../hikey9xx/gpu/kirin9xx_drm_dpe_utils.c | 4 ++- .../hikey9xx/gpu/kirin9xx_drm_dpe_ut

Re: [PATCH] drm/crc-debugfs: Fix memleak in crc_control_write

2020-08-19 Thread Laurent Pinchart
Hi Dinghao, Thank you for the patch. On Wed, Aug 19, 2020 at 04:22:28PM +0800, Dinghao Liu wrote: > When verify_crc_source() fails, source needs to be freed. > However, current code is returning directly and ends up > leaking memory. > > Fixes: c0811a7d5befe ("drm/crc: Cleanup crtc_crc_open func

Re: [PATCH v1] drm/i915/gt: convert tasklets to use new tasklet_setup() API

2020-08-19 Thread Chris Wilson
Quoting Andy Shevchenko (2020-08-19 12:53:53) > In preparation for unconditionally passing the struct tasklet_struct > pointer to all tasklet callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > > Signed-off-by: Andy Shevchenko Reviewed

Re: [PATCH] drm/omap: fix incorrect lock state

2020-08-19 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Wed, Aug 19, 2020 at 01:30:21PM +0300, Tomi Valkeinen wrote: > After commit 92cc68e35863c1c61c449efa2b2daef6e9926048 ("drm/vblank: Use > spin_(un)lock_irq() in drm_crtc_vblank_on()") omapdrm locking is broken: > > WARNING: inconsistent lock state > 5.8.0-rc2-

Re: [PATCH v1] drm/i915/gt: convert tasklets to use new tasklet_setup() API

2020-08-19 Thread Jani Nikula
On Wed, 19 Aug 2020, Chris Wilson wrote: > Quoting Andy Shevchenko (2020-08-19 12:53:53) >> In preparation for unconditionally passing the struct tasklet_struct >> pointer to all tasklet callbacks, switch to using the new tasklet_setup() >> and from_tasklet() to pass the tasklet pointer explicitly

Re: [PATCH 2/2] drm/virtio: Remove open-coded commit-tail function

2020-08-19 Thread Jiri Slaby
On 09. 07. 20, 14:33, Daniel Vetter wrote: > Exactly matches the one in the helpers. It's not that exact. The order of modeset_enables and planes is different. And this causes a regression -- no fb in qemu. So if I run drm-tip, no fb. If I revert 73f15a9, it works. If I then switch the two calls

Re: [PATCH v1] drm/i915/gt: convert tasklets to use new tasklet_setup() API

2020-08-19 Thread Chris Wilson
Quoting Jani Nikula (2020-08-19 13:34:41) > On Wed, 19 Aug 2020, Chris Wilson wrote: > > Quoting Andy Shevchenko (2020-08-19 12:53:53) > >> In preparation for unconditionally passing the struct tasklet_struct > >> pointer to all tasklet callbacks, switch to using the new tasklet_setup() > >> and f

Re: [PATCH 2/2] drm/virtio: Remove open-coded commit-tail function

2020-08-19 Thread Jiri Slaby
On 19. 08. 20, 14:43, Jiri Slaby wrote: > On 09. 07. 20, 14:33, Daniel Vetter wrote: >> Exactly matches the one in the helpers. > > It's not that exact. The order of modeset_enables and planes is > different. And this causes a regression -- no fb in qemu. > > So if I run drm-tip, no fb. > If I re

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-19 Thread Greg KH
On Wed, Aug 19, 2020 at 07:00:53AM -0600, Jens Axboe wrote: > On 8/18/20 1:00 PM, James Bottomley wrote: > > On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote: > >> On 8/17/20 12:48 PM, Kees Cook wrote: > >>> On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens Axboe wrote: > On 8/17/20 12:29 PM,

Re: [PATCH 0/3] Chunk Heap Support on DMA-HEAP

2020-08-19 Thread Brian Starkey
Hi KyongHo, On Wed, Aug 19, 2020 at 12:46:26PM +0900, Cho KyongHo wrote: > I have seriously considered CPA in our product but we developed our own > because of the pool in CPA. Oh good, I'm glad you considered it :-) > The high-order pages are required by some specific users like Netflix > app.

Re: [PATCH 2/2] drm/virtio: Remove open-coded commit-tail function

2020-08-19 Thread Gerd Hoffmann
On Wed, Aug 19, 2020 at 02:43:28PM +0200, Jiri Slaby wrote: > On 09. 07. 20, 14:33, Daniel Vetter wrote: > > Exactly matches the one in the helpers. > > It's not that exact. The order of modeset_enables and planes is > different. And this causes a regression -- no fb in qemu. Does https://patchwo

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-19 Thread Greg KH
On Wed, Aug 19, 2020 at 07:17:19AM -0600, Jens Axboe wrote: > On 8/19/20 6:11 AM, Greg KH wrote: > > On Wed, Aug 19, 2020 at 07:00:53AM -0600, Jens Axboe wrote: > >> On 8/18/20 1:00 PM, James Bottomley wrote: > >>> On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote: > On 8/17/20 12:48 PM, Kee

Re: [PATCH] drm/gma500: fix error check

2020-08-19 Thread Patrik Jakobsson
On Wed, Aug 5, 2020 at 10:59 PM wrote: > > From: Tom Rix > > Reviewing this block of code in cdv_intel_dp_init() > > ret = cdv_intel_dp_aux_native_read(gma_encoder, DP_DPCD_REV, ... > > cdv_intel_edp_panel_vdd_off(gma_encoder); > if (ret == 0) { > /* if this fails, presume the device is a

[PATCH] drm/ttm: fix broken merge between drm-next and drm-misc-next

2020-08-19 Thread Christian König
drm-next reverted the changes to ttm_tt_create() to do the NULL check inside the function, but drm-misc-next adds new users of this approach. Re-apply the NULL check change inside the function to fix this. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 2 +- drivers/gpu/drm/t

Re: [PATCH v3] drm: gma500: Convert to GPIO descriptors

2020-08-19 Thread Patrik Jakobsson
On Fri, Jul 3, 2020 at 3:01 PM Linus Walleij wrote: > > Finalize he conversion of GMA500 to use only GPIO descriptors. > The GPIO look-up-table is associated with the device directly > in the GMA500 Medfield chip driver since no explicit platform > type device (such as in x86/platform/intel-mid) e

Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks

2020-08-19 Thread Alex Deucher
On Wed, Aug 19, 2020 at 5:08 AM Michel Dänzer wrote: > > On 2020-07-22 7:12 p.m., Alex Deucher wrote: > > On Wed, Jul 22, 2020 at 10:25 AM Michel Dänzer wrote: > >> On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote: > >>> On 2020-07-22 8:51 a.m., Daniel Vetter wrote: > On Wed, Jul 22, 2020

[PATCH v8.5] drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message

2020-08-19 Thread Sean Paul
From: Sean Paul Used to query whether an MST stream is encrypted or not. Cc: Lyude Paul Reviewed-by: Anshuman Gupta Reviewed-by: Lyude Paul Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20200218220242.107265-14-s...@poorly.run #v4 Link: https://patchwork.fr

[PATCH] drm/omap: fix incorrect lock state

2020-08-19 Thread Tomi Valkeinen
After commit 92cc68e35863c1c61c449efa2b2daef6e9926048 ("drm/vblank: Use spin_(un)lock_irq() in drm_crtc_vblank_on()") omapdrm locking is broken: WARNING: inconsistent lock state 5.8.0-rc2-00483-g92cc68e35863 #13 Tainted: GW inconsistent {HARDIRQ-ON-W} -> {I

Re: [PATCH 10/20] drm/omapdrm: Introduce GEM object functions

2020-08-19 Thread Tomi Valkeinen
Hi, On 13/08/2020 11:36, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in omapdrm. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/omap

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-19 Thread James Bottomley
On Wed, 2020-08-19 at 07:00 -0600, Jens Axboe wrote: > On 8/18/20 1:00 PM, James Bottomley wrote: [...] > > Since both threads seem to have petered out, let me suggest in > > kernel.h: > > > > #define cast_out(ptr, container, member) \ > > container_of(ptr, typeof(*container), member) > > > >

Re: [RFC 09/20] drm/i915/dp: Extract drm_dp_has_mst()

2020-08-19 Thread Sean Paul
On Tue, Aug 11, 2020 at 04:04:46PM -0400, Lyude Paul wrote: > Just a tiny drive-by cleanup, we can consolidate i915's code for > checking for MST support into a helper to be shared across drivers. > Reviewed-by: Sean Paul > Signed-off-by: Lyude Paul > --- > drivers/gpu/drm/i915/display/intel_

Re: [Intel-gfx] [PATCH v1] drm/i915/gt: convert tasklets to use new tasklet_setup() API

2020-08-19 Thread kernel test robot
Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.9-rc1 next-20200819] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as

Re: [RFC 13/20] drm/i915/dp: Extract drm_dp_downstream_read_info()

2020-08-19 Thread Sean Paul
On Tue, Aug 11, 2020 at 04:04:50PM -0400, Lyude Paul wrote: > We're going to be doing the same probing process in nouveau for > determining downstream DP port capabilities, so let's deduplicate the > work by moving i915's code for handling this into a shared helper: > drm_dp_downstream_read_info().

Re: [RFC 15/20] drm/i915/dp: Extract drm_dp_has_sink_count()

2020-08-19 Thread Sean Paul
On Tue, Aug 11, 2020 at 04:04:52PM -0400, Lyude Paul wrote: > Since other drivers are also going to need to be aware of the sink count > in order to do proper dongle detection, we might as well steal i915's > DP_SINK_COUNT helpers and move them into DRM helpers so that other > dirvers can use them

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-19 Thread Sam Ravnborg
Hi Mauro. On Wed, Aug 19, 2020 at 01:45:28PM +0200, Mauro Carvalho Chehab wrote: > This patch series port the out-of-tree driver for Hikey 970 (which > should also support Hikey 960) from the official 96boards tree: > >https://github.com/96boards-hikey/linux/tree/hikey970-v4.9 > > Based on h

Re: [RFC 16/20] drm/i915/dp: Extract drm_dp_get_sink_count()

2020-08-19 Thread Sean Paul
On Tue, Aug 11, 2020 at 04:04:53PM -0400, Lyude Paul wrote: > And of course, we'll also need to read the sink count from other drivers > as well if we're checking whether or not it's supported. So, let's > extract the code for this into another helper. > > Signed-off-by: Lyude Paul > --- > drive

Re: [RFC 19/20] drm/i915/dp: Extract drm_dp_read_dpcd_caps()

2020-08-19 Thread Sean Paul
On Tue, Aug 11, 2020 at 04:04:56PM -0400, Lyude Paul wrote: > Since DP 1.3, it's been possible for DP receivers to specify an > additional set of DPCD capabilities, which can take precedence over the > capabilities reported at DP_DPCD_REV. > > Basically any device supporting DP is going to need to

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-19 Thread Laurent Pinchart
On Wed, Aug 19, 2020 at 05:21:20PM +0200, Sam Ravnborg wrote: > Hi Mauro. > > On Wed, Aug 19, 2020 at 01:45:28PM +0200, Mauro Carvalho Chehab wrote: > > This patch series port the out-of-tree driver for Hikey 970 (which > > should also support Hikey 960) from the official 96boards tree: > > > >

[PATCH v4 3/4] phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-08-19 Thread Chun-Kuang Hu
From: CK Hu mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's more suitable to place a phy driver into phy driver folder, so move mtk_hdmi_phy driver into phy driver folder. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu Reviewed-by: Chunfeng Yun Reviewed-by: Matthias B

[PATCH v4 0/4] Move Mediatek HDMI PHY driver from DRM folder to PHY folder

2020-08-19 Thread Chun-Kuang Hu
mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's more suitable to place a phy driver into phy driver folder, so move mtk_hdmi_phy driver into phy driver folder. Changes in v4: - Rebase onto 5.9-rc1 - Remove mtk_hdmi_conf_mt8173. Changes in v3: - Modify [PATCH v2 3/4] prefix.

[PATCH v4 1/4] drm/mediatek: Move tz_disabled from mtk_hdmi_phy to mtk_hdmi driver

2020-08-19 Thread Chun-Kuang Hu
From: CK Hu tz_disabled is used to control mtk_hdmi output signal, but this variable is stored in mtk_hdmi_phy and mtk_hdmi_phy does not use it. So move tz_disabled to mtk_hdmi where it's used. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_hdmi.c

[PATCH v4 2/4] drm/mediatek: Separate mtk_hdmi_phy to an independent module

2020-08-19 Thread Chun-Kuang Hu
From: CK Hu mtk_hdmi_phy is a part of mtk_hdmi module, but phy driver should be an independent module rather than be part of drm module, so separate the phy driver to an independent module. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu Reviewed-by: Chunfeng Yun --- drivers/gpu/drm/mediat

[PATCH v4 4/4] MAINTAINERS: add files for Mediatek DRM drivers

2020-08-19 Thread Chun-Kuang Hu
Mediatek HDMI phy driver is moved from drivers/gpu/drm/mediatek to drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' information. Signed-off-by: Chun-Kuang Hu Reviewed-by: Matthias Brugger --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/M

Re: [PATCH v4 3/4] phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-08-19 Thread Sam Ravnborg
Hi Chun-Kuang Two small details below. Sam On Wed, Aug 19, 2020 at 11:44:20PM +0800, Chun-Kuang Hu wrote: > From: CK Hu > > mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's > more suitable to place a phy driver into phy driver folder, so move > mtk_hdmi_phy driver

Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

2020-08-19 Thread Lee Jones
On Wed, 19 Aug 2020, Markus Elfring wrote: > > When of_property_read_u32_array() returns an error code, > > a pairing refcount decrement is needed to keep np's refcount balanced. > > Can another imperative wording be helpful for the change description? > https://git.kernel.org/pub/scm/linux/kerne

Re: [PATCH 10/20] dt-bindings: arm-smmu: Add compatible string for Adreno GPU SMMU

2020-08-19 Thread Doug Anderson
Hi, On Mon, Aug 17, 2020 at 3:03 PM Rob Clark wrote: > > From: Jordan Crouse > > Every Qcom Adreno GPU has an embedded SMMU for its own use. These > devices depend on unique features such as split pagetables, > different stall/halt requirements and other settings. Identify them > with a compatib

Re: [PATCH v5 3/7] drm/mediatek: disable tmds on mt2701

2020-08-19 Thread Matthias Brugger
On 19/08/2020 10:17, Frank Wunderlich wrote: From: chunhui dai disable tmds on phy on mt2701 to support other resolutions like 1280x1024 Isn't that worth a Fixes tag? Regards, Matthias Signed-off-by: chunhui dai Signed-off-by: Frank Wunderlich Tested-by: Frank Wunderlich --- drive

Re: [PATCH v5 5/7] drm/mediatek: dpi/dsi: change the getting possible_crtc way

2020-08-19 Thread Matthias Brugger
On 19/08/2020 10:17, Frank Wunderlich wrote: From: Jitao Shi For current mediatek dsi encoder, its possible crtc is fixed in crtc 0, and mediatek dpi encoder's possible crtc is fixed in crtc 1. In some SoC the possible crtc is not fixed in this case, so call mtk_drm_find_possible_crtc_by_com

Re: [RFC 13/20] drm/i915/dp: Extract drm_dp_downstream_read_info()

2020-08-19 Thread Lyude Paul
On Wed, 2020-08-19 at 11:15 -0400, Sean Paul wrote: > On Tue, Aug 11, 2020 at 04:04:50PM -0400, Lyude Paul wrote: > > We're going to be doing the same probing process in nouveau for > > determining downstream DP port capabilities, so let's deduplicate the > > work by moving i915's code for handling

Re: [PATCH 10/20] dt-bindings: arm-smmu: Add compatible string for Adreno GPU SMMU

2020-08-19 Thread Rob Clark
On Wed, Aug 19, 2020 at 10:03 AM Doug Anderson wrote: > > Hi, > > On Mon, Aug 17, 2020 at 3:03 PM Rob Clark wrote: > > > > From: Jordan Crouse > > > > Every Qcom Adreno GPU has an embedded SMMU for its own use. These > > devices depend on unique features such as split pagetables, > > different s

[RESEND PATCH 2/2] dma-buf: fence-chain: Document missing dma_fence_chain_init() parameter in kerneldoc

2020-08-19 Thread Krzysztof Kozlowski
Fix W=1 compile warnings (invalid kerneldoc): drivers/dma-buf/dma-fence-chain.c:233: warning: Function parameter or member 'seqno' not described in 'dma_fence_chain_init' Signed-off-by: Krzysztof Kozlowski --- drivers/dma-buf/dma-fence-chain.c | 1 + 1 file changed, 1 insertion(+) diff --

[RESEND PATCH 1/2] dma-buf: Fix kerneldoc of dma_buf_set_name()

2020-08-19 Thread Krzysztof Kozlowski
Fix W=1 compile warnings (invalid kerneldoc): drivers/dma-buf/dma-buf.c:328: warning: Function parameter or member 'dmabuf' not described in 'dma_buf_set_name' Signed-off-by: Krzysztof Kozlowski --- drivers/dma-buf/dma-buf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH drm/hisilicon v2 0/4] Use drm_err instead of DRM_ERROR in hibmc driver

2020-08-19 Thread Thomas Zimmermann
Hi Am 19.08.20 um 11:23 schrieb Tian Tao: > patch #1 is using the drm_err instead of DRM_ERROR in hibmc_ttm.c > patch #2 is using the drm_err instead of DRM_ERROR in hibmc_drm_vdac.c > patch #3 is using the drm_err and drm_dbg_atomic instead of DRM_ERROR > and DRM_DEBUG_ATOMIC in hibmc_drm_de.c >

Re: [PATCH] drm/panel: novatek,nt39016: Remove 'dev' field in priv struct

2020-08-19 Thread Sam Ravnborg
Hi Paul. On Wed, Aug 19, 2020 at 08:14:12PM +0200, Paul Cercueil wrote: > There is already a 'struct device' pointer in the drm_panel structure, > that we can access easily from our priv structure, so there's no need > for a separate 'dev' field there. > > This also allows drm_panel_of_backlight(

  1   2   >