Re: [PATCH drm/hisilicon v2 0/3] hibmc clean up and code refactoring

2020-08-12 Thread Thomas Zimmermann
Hi Am 03.08.20 um 02:38 schrieb Tian Tao: > patch #1 and #3 is clean up, patch #2 is for code refactoring Sorry for all my reviews taking so long. Please merge patch #3 into patch #2 and then the series is Reviewed-by: Thomas Zimmermann I noticed that hibmc use DRM_ERROR in several places. A g

[PATCH] drm/nouveau/gem: Use vmemdup_user() rather than duplicating its implementation

2020-08-12 Thread Markus Elfring
From: Markus Elfring Date: Tue, 11 Aug 2020 19:25:22 +0200 Reuse existing functionality from vmemdup_user() instead of keeping duplicate source code. Generated by: scripts/coccinelle/api/memdup_user.cocci Signed-off-by: Markus Elfring --- drivers/gpu/drm/nouveau/nouveau_gem.c | 12 +++

Fwd: [Virtual ppce500] virtio_gpu virtio0: swiotlb buffer is full

2020-08-12 Thread Christian Zigotzky
Hi All, I hope you are responsible for the virtio_gpu. Could you please test the virtio_gpu because it doesn't work anymore with the latest Git kernel (see below). Thanks, Christian Weitergeleitete Nachricht Betreff:[Virtual ppce500] virtio_gpu virtio0: swiotlb buf

Re: [PATCH v8 1/2] dt-binding: Add DSI/LVDS TC358775 bridge bindings

2020-08-12 Thread Vinay Simha B N
Sam, Thanks. On Mon, Aug 10, 2020 at 11:08 PM Sam Ravnborg wrote: > Hi Vinay. > > On Wed, Jul 29, 2020 at 06:01:21PM +0530, Vinay Simha B N wrote: > > Hi All, > > > > Please Review the patch > > > > On Fri, Jul 10, 2020 at 7:11 PM Vinay Simha BN > wrote: > > > > > - license modified to (GPL-2.

Re: [PATCH] MAINTAINERS: Change maintainer for hisilicon DRM driver

2020-08-12 Thread Xinliang Liu
Hi, On Tue, 11 Aug 2020 at 16:25, Tian Tao wrote: > > Remove Rongrong Zou and change tiantao as hisilicon DRM maintainer. > > Signed-off-by: Tian Tao Thanks Tian Tao, Tian Tao now is actively maintaining hibmc driver. Happy to hear this. Acked-by: Xinliang Liu -Xinliang > --- > MAINTAINERS

Re: [PATCH] drm: assure aux_dev is nonzero before using it

2020-08-12 Thread Zwane Mwaikambo
On Tue, 11 Aug 2020, Daniel Vetter wrote: > On Mon, Aug 10, 2020 at 10:11:50AM -0700, Zwane Mwaikambo wrote: > > Hi Folks, > > I know this thread eventually dropped off due to not identifying > > the underlying issue. It's still occuring on 5.8 and in my case it > > happened because the udev

RE: [PATCH v2 2/3] drm/bridge: lvds-codec: Add support for regulator

2020-08-12 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v2 2/3] drm/bridge: lvds-codec: Add support for > regulator > > Hi Biju, > > Thank you for the patch. > > On Mon, Aug 10, 2020 at 04:22:18PM +0100, Biju Das wrote: > > Add the support for enabling optional regulator that may be used as >

[PATCH] drm/rockchip: Require the YTR modifier for AFBC

2020-08-12 Thread Alyssa Rosenzweig
The AFBC decoder used in the Rockchip VOP assumes the use of the YUV-like colourspace transform (YTR). YTR is lossless for RGB(A) buffers, which covers the RGBA8 and RGB565 formats supported in vop_convert_afbc_format. Use of YTR is signaled with the AFBC_FORMAT_MOD_YTR modifier, which prior to thi

Re: [PATCH v8 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

2020-08-12 Thread Vinay Simha B N
Sam, I will look into this and send the patch ASAP. On Wed, Aug 12, 2020 at 12:47 AM Sam Ravnborg wrote: > Hi Vinay. > > > > > > > If Laurent or others identify further things to improve we can take > > > it in-tree. > > > > Just one thing, please see below. > > > > > > > >> + d2l_write(t

[PATCH] MAINTAINERS: Change maintainer for hisilicon DRM driver

2020-08-12 Thread Tian Tao
Remove Rongrong Zou and change tiantao as hisilicon DRM maintainer. Signed-off-by: Tian Tao --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index f12a868..f4e49e0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5694,7 +5694,7 @@ F:

Re: [PATCH v3] platform/x86: Add new vga-switcheroo gmux driver for ACPI-driven muxes

2020-08-12 Thread Daniel Dadap
On 8/10/20 10:43 PM, Lukas Wunner wrote: On Mon, Aug 10, 2020 at 01:44:58PM -0500, Daniel Dadap wrote: Would it be clearer to write it out as something like 0 << 4 & 1 << 0 for MUX_STATE_SET_IGPU and 1 << 4 & 1 << 0 for MUX_STATE_SET_DGPU? BIT(4) | BIT(0) might be clearer, but that gives you

Re: [PATCH v9 3/5] drm/msm/dp: add support for DP PLL driver

2020-08-12 Thread Randy Dunlap
On 8/11/20 12:49 PM, tan...@codeaurora.org wrote: > On 2020-08-07 13:28, Randy Dunlap wrote: >> On 8/7/20 1:24 PM, Stephen Boyd wrote: >>> Quoting Rob Clark (2020-08-07 08:51:48) On Fri, Aug 7, 2020 at 8:27 AM Randy Dunlap wrote: > > On 8/7/20 12:17 AM, Tanmay Shah wrote: >>

Re: [PATCH] vt: defer kfree() of vc_screenbuf in vc_do_resize()

2020-08-12 Thread Tetsuo Handa
On 2020/08/04 21:58, Greg Kroah-Hartman wrote: > On Tue, Aug 04, 2020 at 08:15:43PM +0900, Tetsuo Handa wrote: >> Do you think this approach is acceptable? Or, do we need to modify >> set_origin() ? >> > I think what you have here is fine, as cleaning up set_orgin() might be > hard to do at this p

Re: [PATCH v5] arm64: dts: qcom: sc7180: Add Display Port dt node

2020-08-12 Thread Stephen Boyd
Quoting Tanmay Shah (2020-08-10 19:15:53) > @@ -2440,6 +2447,71 @@ dsi_phy: dsi-phy@ae94400 { > > status = "disabled"; > }; > + > + msm_dp: displayport-controller@ae9 { > + status = "di

Re: [Intel-gfx] [PATCH v7 17/17] drm/i915: Add HDCP 1.4 support for MST connectors

2020-08-12 Thread Anshuman Gupta
On 2020-08-11 at 13:28:46 -0400, Sean Paul wrote: > On Thu, Jul 9, 2020 at 8:40 AM Anshuman Gupta > wrote: > > > > \snip > > > > > +static int > > > > +intel_dp_mst_hdcp_toggle_signalling(struct intel_digital_port > > > > *intel_dig_port, > > > > + enum transcoder

Re: [PATCH] MAINTAINERS: Change maintainer for hisilicon DRM driver

2020-08-12 Thread Thomas Zimmermann
Hi Am 11.08.20 um 10:23 schrieb Tian Tao: > Remove Rongrong Zou and change tiantao as hisilicon DRM maintainer. > > Signed-off-by: Tian Tao Acked-by: Thomas Zimmermann Thanks for looking after the hisilicon drivers. Best regards Thomas > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insert

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-12 Thread Jürgen Groß
On 11.08.20 11:44, Roger Pau Monne wrote: To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to create struct pages and kernel virtual mappings for the IOMEM areas of such devices. Note that on kernels with

Re: [PATCH 1/2 v1] dt-bindings: backlight: Add Kinetic KTD253 bindings

2020-08-12 Thread Linus Walleij
On Tue, Jul 21, 2020 at 1:28 PM Daniel Thompson wrote: > I'm a bit sceptical of having a max-brightness in the DT and a driver > defined lookup table in the driver itself. That doesn't make a whole lot > of sense to me since the maximum brightness here is basically relies on > knowing what scale

Re: [PATCH 1/2 v1] dt-bindings: backlight: Add Kinetic KTD253 bindings

2020-08-12 Thread Sam Ravnborg
Hi Linus. On Wed, Aug 12, 2020 at 08:48:42AM +0200, Linus Walleij wrote: > On Tue, Jul 21, 2020 at 10:32 AM Sam Ravnborg wrote: > > > > +description: | > > > + The Kinetic Technologies KTD253 is a white LED backlight that is > > > + controlled by a single GPIO line. If you just turn on the bac

Re: [RFC v2 03/11] tty: serial: qcom_geni_serial: Use OPP API to set clk/perf state

2020-08-12 Thread Rajendra Nayak
On 8/12/2020 1:05 PM, Amit Pundir wrote: Hi Rajendra, On Wed, 12 Aug 2020 at 11:18, Rajendra Nayak wrote: On 8/12/2020 7:03 AM, John Stultz wrote: On Tue, Aug 11, 2020 at 4:11 PM John Stultz wrote: On Wed, Mar 20, 2019 at 2:49 AM Rajendra Nayak wrote: geni serial needs to express a

Re: [PATCH] locking/rwsem: remove redundant semicolon of down_write_nest_lock

2020-08-12 Thread peterz
On Tue, Aug 11, 2020 at 01:18:52PM +0200, Christian König wrote: > From: Guchun Chen > > Otherwise, braces are needed when using it. > > Signed-off-by: Guchun Chen > Reviewed-by: Christian König Thanks! ___ dri-devel mailing list dri-devel@lists.fre

Re: [PATCH v1 4/4] drm/ast: Disable planes while switching display modes

2020-08-12 Thread Thomas Zimmermann
Hi Am 07.08.20 um 10:50 schrieb dan...@ffwll.ch: > On Wed, Aug 05, 2020 at 12:54:28PM +0200, Thomas Zimmermann wrote: >> The ast HW cursor requires the primary plane and CRTC to display at >> a valid mode and format. This is not the case while switching >> display modes, which can lead to the scre

Re: [Intel-gfx] [PATCH v7 15/17] drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message

2020-08-12 Thread Anshuman Gupta
On 2020-08-11 at 13:21:38 -0400, Sean Paul wrote: > On Thu, Jul 9, 2020 at 9:09 AM Anshuman Gupta > wrote: > > > > On 2020-07-02 at 20:07:36 +0530, Anshuman Gupta wrote: > > > On 2020-06-30 at 12:48:34 -0400, Sean Paul wrote: > > > > On Tue, Jun 30, 2020 at 10:21 AM Anshuman Gupta > > > > wrote:

Re: [PATCH drm/hisilicon v3 0/2] hibmc clean up and code refactoring

2020-08-12 Thread Thomas Zimmermann
Merged into drm-misc-next Am 12.08.20 um 09:42 schrieb Tian Tao: > patch #1 and #3 is clean up, patch #2 is for code refactoring > > Changes since v1: > - Rewrite the commits messages and patch name in #1 > - Rewrite the commits message in #2. > - Add the new patch #3 > > Changes since v2: > - m

Re: [PATCH] locking/rwsem: remove redundant semicolon of down_write_nest_lock

2020-08-12 Thread Christian König
Am 12.08.20 um 10:10 schrieb pet...@infradead.org: On Tue, Aug 11, 2020 at 01:18:52PM +0200, Christian König wrote: From: Guchun Chen Otherwise, braces are needed when using it. Signed-off-by: Guchun Chen Reviewed-by: Christian König Thanks! Do you pick it up or can I push it through drm

Re: [PATCH v8 0/3] drm: Add support for Cadence MHDP DPI/DP bridge and J721E wrapper.

2020-08-12 Thread Guido Günther
Hi, On Thu, Aug 06, 2020 at 01:34:29PM +0200, Swapnil Jakhade wrote: > This patch series adds new DRM bridge driver for Cadence MHDP DPI/DP > bridge. The Cadence Display Port IP is also referred as MHDP (Mobile High > Definition Link, High-Definition Multimedia Interface, Display Port). > Cadence D

Re: [PATCH] drm/ttm: revert "make TT creation purely optional v3"

2020-08-12 Thread Christian König
Am 11.08.20 um 21:34 schrieb Dave Airlie: On Wed, 12 Aug 2020 at 03:11, Christian König wrote: Am 11.08.20 um 18:42 schrieb Michel Dänzer: On 2020-08-11 2:53 p.m., Christian König wrote: Am 11.08.20 um 14:52 schrieb Christian König: Am 11.08.20 um 11:24 schrieb Christian König: This reverts

[PATCH 3/3 v2] backlight: Add Kinetic KTD253 backlight driver

2020-08-12 Thread Linus Walleij
The Kinetic KTD253 backlight driver is controlled with a single GPIO line, but still supports a range of brightness settings by sending fast pulses on the line. This is based off the source code release for the Samsung GT-S7710 mobile phone. Cc: Sam Ravnborg Signed-off-by: Linus Walleij --- Cha

[PATCH 1/3 v2] dt-bindings: backlight: Add some common backlight properties

2020-08-12 Thread Linus Walleij
Let's use a common.yaml include for the backlight like we do with the LEDs. The LEDs are inherently incompatible so their bindings cannot be reused for backlight. Cc: devicet...@vger.kernel.org Suggested-by: Sam Ravnborg Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - New patch as suggested

[PATCH 2/3 v2] dt-bindings: backlight: Add Kinetic KTD253 bindings

2020-08-12 Thread Linus Walleij
This adds device tree bindings for the Kinetic KTD253 white LED backlight driver. Cc: devicet...@vger.kernel.org Cc: Sam Ravnborg Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Create common.yaml for backlight as suggested by Sam and use that. - Rename the GPIO line "enable-gpios" --- .

Re: [PATCH] drm/ttm: revert "make TT creation purely optional v3"

2020-08-12 Thread Christian König
Am 12.08.20 um 05:02 schrieb Dave Airlie: On Wed, 12 Aug 2020 at 05:34, Dave Airlie wrote: On Wed, 12 Aug 2020 at 03:11, Christian König wrote: Am 11.08.20 um 18:42 schrieb Michel Dänzer: On 2020-08-11 2:53 p.m., Christian König wrote: Am 11.08.20 um 14:52 schrieb Christian König: Am 11.08

Re: [PATCH 1/2 v1] dt-bindings: backlight: Add Kinetic KTD253 bindings

2020-08-12 Thread Linus Walleij
On Wed, Aug 12, 2020 at 9:34 AM Sam Ravnborg wrote: > Hmm, I think I looked at leds/ when I wrote that comment about > common.yaml. > > Please consider Rob's comment in commit: > 44e1655a444fe7a1bd81994d34c6bbb5245b9e60 > ("dt-bindings: backlight: Convert common backlight bindings to DT > schema

Re: [PATCH] drm/panel-notatek-nt35510: Fix MTP read init

2020-08-12 Thread Linus Walleij
On Tue, Aug 11, 2020 at 10:58 PM Daniel Vetter wrote: > > BTW I need to merge v5.8 (final) into drm-misc-next so as to get > > a smallish fix from the late -rc:s back. It is currently at v5.8-rc2. > > Is that something you'd say I can be bold and attempt myself > > of should I stay off it? > > >

Re: [PATCH 2/6] drm: bridge: dw-hdmi: Implement connector atomic_begin/atomic_flush

2020-08-12 Thread Laurent Pinchart
Hi Algea, Thank you for the patch. On Wed, Aug 12, 2020 at 04:34:33PM +0800, Algea Cao wrote: > Introduce dw_hdmi_connector_atomic_begin() and > dw_hdmi_connector_atomic_flush() to implement connector > atomic_begin/atomic_flush. When enc_out_bus_format or > enc_in_bus_format changed, dw_hdmi_set

Re: [RFC v2 03/11] tty: serial: qcom_geni_serial: Use OPP API to set clk/perf state

2020-08-12 Thread Rajendra Nayak
On 8/12/2020 1:09 PM, Rajendra Nayak wrote: On 8/12/2020 1:05 PM, Amit Pundir wrote: Hi Rajendra, On Wed, 12 Aug 2020 at 11:18, Rajendra Nayak wrote: On 8/12/2020 7:03 AM, John Stultz wrote: On Tue, Aug 11, 2020 at 4:11 PM John Stultz wrote: On Wed, Mar 20, 2019 at 2:49 AM Rajendra Na

Re: [PATCH 4/6] drm/rockchip: dw_hdmi: Add vendor hdmi properties

2020-08-12 Thread Laurent Pinchart
Hi Algea, Thank you for the patch. On Wed, Aug 12, 2020 at 04:35:43PM +0800, Algea Cao wrote: > Introduce struct dw_hdmi_property_ops in plat_data to support > vendor hdmi property. > > Implement hdmi vendor properties color_depth_property and > hdmi_output_property to config hdmi output color d

Re: [PATCH 1/6] drm: Add connector atomic_begin/atomic_flush

2020-08-12 Thread Laurent Pinchart
Hi Algea, Thank you for the patch. On Wed, Aug 12, 2020 at 04:34:07PM +0800, Algea Cao wrote: > In some situations, connector should get some work done > when plane is updating. Such as when change output color > format, hdmi should send AVMUTE to make screen black before > crtc updating color fo

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-08-12 Thread Laurent Pinchart
Hi Vinay, Thank you for the patch. On Wed, Aug 12, 2020 at 12:55:50PM +0530, Vinay Simha BN wrote: > - bus formats read from drm_bridge_state.output_bus_cfg.format > and .atomic_get_input_bus_fmts() instead of connector > > Signed-off-by: Vinay Simha BN > > --- > v1: > * Laurent Pinchart r

Re: [PATCH 1/6] drm: Add connector atomic_begin/atomic_flush

2020-08-12 Thread kernel test robot
Hi Algea, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on linus/master drm-exynos/exynos-drm-next v5.8 next-20200812] [cannot apply to rockchip/for-next drm-intel/for-linux-next tegra-drm/drm/tegra/for-next drm/drm

Re: [git pull] drm for 5.8-rc1

2020-08-12 Thread Karol Herbst
On Wed, Aug 12, 2020 at 2:19 AM James Jones wrote: > > Sorry for the slow reply here as well. I've been in the process of > rebasing and reworking the userspace patches. I'm not clear my changes > will address the Jetson Nano issue, but if you'd like to try them, the > latest userspace changes a

Re: [PATCH] locking/rwsem: remove redundant semicolon of down_write_nest_lock

2020-08-12 Thread peterz
On Wed, Aug 12, 2020 at 10:36:14AM +0200, Christian König wrote: > Am 12.08.20 um 10:10 schrieb pet...@infradead.org: > > On Tue, Aug 11, 2020 at 01:18:52PM +0200, Christian König wrote: > > > From: Guchun Chen > > > > > > Otherwise, braces are needed when using it. > > > > > > Signed-off-by: Gu

Re: [git pull] drm for 5.8-rc1

2020-08-12 Thread Karol Herbst
On Wed, Aug 12, 2020 at 12:27 PM Karol Herbst wrote: > > On Wed, Aug 12, 2020 at 2:19 AM James Jones wrote: > > > > Sorry for the slow reply here as well. I've been in the process of > > rebasing and reworking the userspace patches. I'm not clear my changes > > will address the Jetson Nano issu

[PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-12 Thread Roger Pau Monne
To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to create struct pages and kernel virtual mappings for the IOMEM areas of such devices. Note that on kernels without support for ZONE_DEVICE Xen will fallbac

Re: [git pull] drm for 5.8-rc1

2020-08-12 Thread Karol Herbst
On Wed, Aug 12, 2020 at 12:43 PM Karol Herbst wrote: > > On Wed, Aug 12, 2020 at 12:27 PM Karol Herbst wrote: > > > > On Wed, Aug 12, 2020 at 2:19 AM James Jones wrote: > > > > > > Sorry for the slow reply here as well. I've been in the process of > > > rebasing and reworking the userspace patc

Re: [git pull] drm for 5.8-rc1

2020-08-12 Thread Ilia Mirkin
On Wed, Aug 12, 2020 at 8:24 AM Karol Herbst wrote: > > On Wed, Aug 12, 2020 at 12:43 PM Karol Herbst wrote: > > > > On Wed, Aug 12, 2020 at 12:27 PM Karol Herbst wrote: > > > > > > On Wed, Aug 12, 2020 at 2:19 AM James Jones wrote: > > > > > > > > Sorry for the slow reply here as well. I've b

Re: [PULL] drm-intel-next-fixes

2020-08-12 Thread Jani Nikula
On Mon, 10 Aug 2020, Dave Airlie wrote: > Like this stuff has been getting past me for years but I'm not happy > about it anymore, I'm going to just be grumpy asshole going forward. > If we introduced scheduler races in linux-next, I want to see reverts, > and reverts only until we stopped introdu

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-08-12 Thread Laurent Pinchart
Hi Vinay, On Wed, Aug 12, 2020 at 06:07:52PM +0530, Vinay Simha B N wrote: > On Wed, Aug 12, 2020 at 3:24 PM Laurent Pinchart wrote: > > On Wed, Aug 12, 2020 at 12:55:50PM +0530, Vinay Simha BN wrote: > > > - bus formats read from drm_bridge_state.output_bus_cfg.format > > > and .atomic_get_inpu

[PULL] drm-misc-fixes

2020-08-12 Thread Maarten Lankhorst
drm-misc-fixes-2020-08-12: drm-misc-fixes for v5.9-rc1: - Add missing dma_fence_put() in virtio_gpu_execbuffer_ioctl(). - Fix memory leak in virtio_gpu_cleanup_object(). The following changes since commit b5ac98cbb8e5e30c34ebc837d1e5a3982d2b5f5c: drm: Added orientation quirk for ASUS tablet mode

Re: [PATCH 4/6] drm/rockchip: dw_hdmi: Add vendor hdmi properties

2020-08-12 Thread Laurent Pinchart
Hi Algea, On Wed, Aug 12, 2020 at 07:08:10PM +0800, crj wrote: > 在 2020/8/12 17:33, Laurent Pinchart 写道: > > On Wed, Aug 12, 2020 at 04:35:43PM +0800, Algea Cao wrote: > >> Introduce struct dw_hdmi_property_ops in plat_data to support > >> vendor hdmi property. > >> > >> Implement hdmi vendor prop

Re: RFC: How to adjust the trace pid?

2020-08-12 Thread Christian König
Ping? Daniel, Dave any opinion on this? Christian. Am 07.08.20 um 15:36 schrieb Christian König: Hi everybody, in amdgpu we got the following issue which I'm seeking advise how to cleanly handle it. We have a bunch of trace points which are related to the VM subsystem and executed in either

Re: RFC: How to adjust the trace pid?

2020-08-12 Thread Daniel Vetter
On Wed, Aug 12, 2020 at 3:42 PM Christian König wrote: > > Ping? Daniel, Dave any opinion on this? Type patch, cc: tracing people, see what they say? tbh I have no idea, but they have been making unhappy noises about some of the tricks we've played in the past in i915 tracepoints. So not everythi

Re: [PATCH 3/7] drm/amd/display: Avoid using unvalidated tiling_flags and tmz_surface in prepare_planes

2020-08-12 Thread Daniel Vetter
On Tue, Aug 11, 2020 at 09:42:11AM -0400, Marek Olšák wrote: > There are a few cases when the flags can change, for example DCC can be > disabled due to a hw limitation in the 3d engine. Modifiers give the > misleading impression that they help with that, but they don't. They don't > really help wi

Re: [PATCH v8 0/3] drm: Add support for Cadence MHDP DPI/DP bridge and J721E wrapper.

2020-08-12 Thread Guido Günther
Hi, On Wed, Aug 12, 2020 at 01:47:42PM +0300, Tomi Valkeinen wrote: > Hi Guido, > > On 12/08/2020 11:39, Guido Günther wrote: > > Hi, > > On Thu, Aug 06, 2020 at 01:34:29PM +0200, Swapnil Jakhade wrote: > >> This patch series adds new DRM bridge driver for Cadence MHDP DPI/DP > >> bridge. The Cade

Re: [PATCH v1 4/4] drm/ast: Disable planes while switching display modes

2020-08-12 Thread Daniel Vetter
On Wed, Aug 12, 2020 at 10:25:25AM +0200, Thomas Zimmermann wrote: > Hi > > Am 07.08.20 um 10:50 schrieb dan...@ffwll.ch: > > On Wed, Aug 05, 2020 at 12:54:28PM +0200, Thomas Zimmermann wrote: > >> The ast HW cursor requires the primary plane and CRTC to display at > >> a valid mode and format. Th

Re: RFC: How to adjust the trace pid?

2020-08-12 Thread Christian König
Am 12.08.20 um 15:49 schrieb Daniel Vetter: On Wed, Aug 12, 2020 at 3:42 PM Christian König wrote: Ping? Daniel, Dave any opinion on this? Type patch, cc: tracing people, see what they say? Adding Ingo and Steven then. tbh I have no idea, but they have been making unhappy noises about some

Re: [PATCH] drm: assure aux_dev is nonzero before using it

2020-08-12 Thread Daniel Vetter
On Wed, Aug 12, 2020 at 12:16 AM Zwane Mwaikambo wrote: > > On Tue, 11 Aug 2020, Daniel Vetter wrote: > > > On Mon, Aug 10, 2020 at 10:11:50AM -0700, Zwane Mwaikambo wrote: > > > Hi Folks, > > > I know this thread eventually dropped off due to not identifying > > > the underlying issue. It's s

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2020-08-12 Thread Daniel Vetter
On Wed, Aug 12, 2020 at 08:31:54AM +0200, Greg KH wrote: > On Tue, Aug 11, 2020 at 04:26:31PM -0400, Alyssa Rosenzweig wrote: > > The AFBC decoder used in the Rockchip VOP assumes the use of the > > YUV-like colourspace transform (YTR). YTR is lossless for RGB(A) > > buffers, which covers the RGBA8

Re: [PATCH] drm/amdgpu: adjust the pid in the grab_id trace point

2020-08-12 Thread Steven Rostedt
On Fri, Aug 07, 2020 at 03:36:58PM +0200, Christian König wrote: > Trace something useful instead of the pid of a kernel thread here. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd

Re: [PATCH] drm/amdgpu: adjust the pid in the grab_id trace point

2020-08-12 Thread Christian König
Am 12.08.20 um 16:17 schrieb Steven Rostedt: On Fri, Aug 07, 2020 at 03:36:58PM +0200, Christian König wrote: Trace something useful instead of the pid of a kernel thread here. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH v8 0/3] drm: Add support for Cadence MHDP DPI/DP bridge and J721E wrapper.

2020-08-12 Thread Tomi Valkeinen
Hi Guido, On 12/08/2020 11:39, Guido Günther wrote: > Hi, > On Thu, Aug 06, 2020 at 01:34:29PM +0200, Swapnil Jakhade wrote: >> This patch series adds new DRM bridge driver for Cadence MHDP DPI/DP >> bridge. The Cadence Display Port IP is also referred as MHDP (Mobile High >> Definition Link, High

Re: [PATCH] drm/msm/a6xx: add module param to enable debugbus snapshot

2020-08-12 Thread Jordan Crouse
On Tue, Aug 11, 2020 at 04:36:57PM -0700, Rob Clark wrote: > From: Rob Clark > > For production devices, the debugbus sections will typically be fused > off and empty in the gpu device coredump. But since this may contain > data like cache contents, don't capture it by default. Reviewed-by: Jor

Re: [git pull] drm for 5.8-rc1

2020-08-12 Thread Thierry Reding
On Wed, Aug 12, 2020 at 12:43:17PM +0200, Karol Herbst wrote: > On Wed, Aug 12, 2020 at 12:27 PM Karol Herbst wrote: > > > > On Wed, Aug 12, 2020 at 2:19 AM James Jones wrote: > > > > > > Sorry for the slow reply here as well. I've been in the process of > > > rebasing and reworking the userspac

Re: [PATCH] drm/amdgpu: adjust the pid in the grab_id trace point

2020-08-12 Thread Steven Rostedt
On Wed, 12 Aug 2020 16:36:36 +0200 Christian König wrote: > Am 12.08.20 um 16:17 schrieb Steven Rostedt: > > On Fri, Aug 07, 2020 at 03:36:58PM +0200, Christian König wrote: > >> Trace something useful instead of the pid of a kernel thread here. > >> > >> Signed-off-by: Christian König > >> --

Re: [git pull] drm for 5.8-rc1

2020-08-12 Thread Karol Herbst
On Wed, Aug 12, 2020 at 5:05 PM Thierry Reding wrote: > > On Wed, Aug 12, 2020 at 12:43:17PM +0200, Karol Herbst wrote: > > On Wed, Aug 12, 2020 at 12:27 PM Karol Herbst wrote: > > > > > > On Wed, Aug 12, 2020 at 2:19 AM James Jones wrote: > > > > > > > > Sorry for the slow reply here as well.

[PATCH] drm/tidss: implement WA for AM65xx erratum i2000

2020-08-12 Thread Tomi Valkeinen
This patch implements WA for AM65xx erratum i2000, which causes YUV formats to show wrong colors. An earlier patch removed a partial WA: a8d9d7da1546349f18eb2d6b6b3a04bdeb38719d ("drm/tidss: remove AM65x PG1 YUV erratum code") The patch explains the reasoning for removal. The change in plans ha

Re: [PATCH] drm/amdgpu: adjust the pid in the grab_id trace point

2020-08-12 Thread Christian König
Am 12.08.20 um 17:19 schrieb Steven Rostedt: On Wed, 12 Aug 2020 16:36:36 +0200 Christian König wrote: Am 12.08.20 um 16:17 schrieb Steven Rostedt: On Fri, Aug 07, 2020 at 03:36:58PM +0200, Christian König wrote: Trace something useful instead of the pid of a kernel thread here. Signed-off-

Re: [PATCH] drm: assure aux_dev is nonzero before using it

2020-08-12 Thread Lyude Paul
On Wed, 2020-08-12 at 16:10 +0200, Daniel Vetter wrote: > On Wed, Aug 12, 2020 at 12:16 AM Zwane Mwaikambo wrote: > > On Tue, 11 Aug 2020, Daniel Vetter wrote: > > > > > On Mon, Aug 10, 2020 at 10:11:50AM -0700, Zwane Mwaikambo wrote: > > > > Hi Folks, > > > > I know this thread eventually dr

Re: [PATCH 1/3 v2] dt-bindings: backlight: Add some common backlight properties

2020-08-12 Thread Rob Herring
On Wed, Aug 12, 2020 at 2:58 AM Linus Walleij wrote: > > Let's use a common.yaml include for the backlight like we do with > the LEDs. The LEDs are inherently incompatible so their bindings > cannot be reused for backlight. > > Cc: devicet...@vger.kernel.org > Suggested-by: Sam Ravnborg > Signed-

Re: [git pull] drm for 5.8-rc1

2020-08-12 Thread Karol Herbst
On Wed, Aug 12, 2020 at 5:20 PM Karol Herbst wrote: > > On Wed, Aug 12, 2020 at 5:05 PM Thierry Reding > wrote: > > > > On Wed, Aug 12, 2020 at 12:43:17PM +0200, Karol Herbst wrote: > > > On Wed, Aug 12, 2020 at 12:27 PM Karol Herbst wrote: > > > > > > > > On Wed, Aug 12, 2020 at 2:19 AM James

Re: [PATCH 1/9] dt-bindings: display: renesas,du: Document r8a774e1 bindings

2020-08-12 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patch. On Wed, Aug 12, 2020 at 03:02:09PM +0100, Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > Document the RZ/G2H (a.k.a. r8a774e1) SoC in the R-Car DU bindings. > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar Reviewed

Re: [PATCH 2/9] drm: rcar-du: Add support for R8A774E1 SoC

2020-08-12 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patch. On Wed, Aug 12, 2020 at 03:02:10PM +0100, Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > Hookup RZ/G2H (R8A774E1) to DU driver. R8A774E1 has one RGB output, > one LVDS output and one HDMI output. > > Signed-off-by: Marian-Cristian Rotariu > >

Re: [PATCH 3/9] arm64: dts: renesas: r8a774e1: Populate DU device node

2020-08-12 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patch. On Wed, Aug 12, 2020 at 03:02:11PM +0100, Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > Populate the DU device node properties in R8A774E1 SoC dtsi. > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar Reviewed-by: La

Re: [PATCH 4/9] dt-bindings: display: renesas,lvds: Document r8a774e1 bindings

2020-08-12 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patch. On Wed, Aug 12, 2020 at 03:02:12PM +0100, Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > Document the RZ/G2H (R8A774E1) LVDS bindings. > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar > --- > .../devicetree/binding

Re: [PATCH 4/9] dt-bindings: display: renesas,lvds: Document r8a774e1 bindings

2020-08-12 Thread Laurent Pinchart
On Wed, Aug 12, 2020 at 07:17:59PM +0300, Laurent Pinchart wrote: > Hi Prabhakar, > > Thank you for the patch. > > On Wed, Aug 12, 2020 at 03:02:12PM +0100, Lad Prabhakar wrote: > > From: Marian-Cristian Rotariu > > > > Document the RZ/G2H (R8A774E1) LVDS bindings. > > > > Signed-off-by: Maria

Re: [PATCH 5/9] dt-bindings: display: renesas,dw-hdmi: Add r8a774e1 support

2020-08-12 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patch. On Wed, Aug 12, 2020 at 03:02:13PM +0100, Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > Document RZ/G2H (R8A774E1) SoC bindings. > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar Reviewed-by: Laurent Pinchart > -

Re: [PATCH 6/9] arm64: dts: renesas: r8a774e1: Populate HDMI encoder node

2020-08-12 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patch. On Wed, Aug 12, 2020 at 03:02:14PM +0100, Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > Populate HDMI node properties in R8A774E1 SoC dtsi. > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar Reviewed-by: Laurent Pin

Re: [PATCH 7/9] drm: rcar-du: lvds: Add support for R8A774E1 SoC

2020-08-12 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patch. On Wed, Aug 12, 2020 at 03:02:15PM +0100, Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > The LVDS encoder on RZ/G2H (R8A774E1) SoC is identical to R-Car Gen3 so > just reuse the rcar_lvds_gen3_info structure to hookup R8A774E1 to LVDS > encoder d

Re: [PATCH 8/9] arm64: dts: renesas: r8a774e1: Add LVDS device node

2020-08-12 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patch. On Wed, Aug 12, 2020 at 03:02:16PM +0100, Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > Add the LVDS device node to R8A774E1 to SoC dtsi and connect it with > the DU node. > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prab

Re: [PATCH 9/9] arm64: dts: renesas: r8a774e1-hihope-rzg2h: Setup DU clocks

2020-08-12 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patch. On Wed, Aug 12, 2020 at 03:02:17PM +0100, Lad Prabhakar wrote: > Setup up the required clocks for the DU to be functional. > > Signed-off-by: Lad Prabhakar > --- > arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dts | 11 +++ > 1 file changed, 1

Re: [PATCH 0/9] r8a774e1 add support for DU, HDMI and LVDS

2020-08-12 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patches. On Wed, Aug 12, 2020 at 03:02:08PM +0100, Lad Prabhakar wrote: > Hi All, > > This patch series adds support for DU, HDMI and LVDS to RZ/G2H SoC. I have added patches 1/9, 2/9, 4/9, 5/9 and 7/9 to my tree. I expect Geert to handle the rest. > Lad Prabhak

Re: [RESEND v7, PATCH 1/7] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display

2020-08-12 Thread Rob Herring
On Sat, Aug 08, 2020 at 10:53:45AM +0800, Yongqiang Niu wrote: > rdma fifo size may be different even in same SOC, add this > property to the corresponding rdma > > Change-Id: I67635ec7f3f59cf4cbc7737285e5e28ff0ab71c9 > Signed-off-by: Yongqiang Niu > --- > .../devicetree/bindings/display/mediate

Re: [git pull] drm for 5.8-rc1

2020-08-12 Thread James Jones
On 8/12/20 5:37 AM, Ilia Mirkin wrote: On Wed, Aug 12, 2020 at 8:24 AM Karol Herbst wrote: On Wed, Aug 12, 2020 at 12:43 PM Karol Herbst wrote: On Wed, Aug 12, 2020 at 12:27 PM Karol Herbst wrote: On Wed, Aug 12, 2020 at 2:19 AM James Jones wrote: Sorry for the slow reply here as well

Re: [git pull] drm for 5.8-rc1

2020-08-12 Thread Karol Herbst
On Wed, Aug 12, 2020 at 7:03 PM James Jones wrote: > > On 8/12/20 5:37 AM, Ilia Mirkin wrote: > > On Wed, Aug 12, 2020 at 8:24 AM Karol Herbst wrote: > >> > >> On Wed, Aug 12, 2020 at 12:43 PM Karol Herbst wrote: > >>> > >>> On Wed, Aug 12, 2020 at 12:27 PM Karol Herbst wrote: > > On

Re: [git pull] drm for 5.8-rc1

2020-08-12 Thread James Jones
On 8/12/20 10:10 AM, Karol Herbst wrote: On Wed, Aug 12, 2020 at 7:03 PM James Jones wrote: On 8/12/20 5:37 AM, Ilia Mirkin wrote: On Wed, Aug 12, 2020 at 8:24 AM Karol Herbst wrote: On Wed, Aug 12, 2020 at 12:43 PM Karol Herbst wrote: On Wed, Aug 12, 2020 at 12:27 PM Karol Herbst wrot

Re: [Intel-gfx] [PATCH v7 17/17] drm/i915: Add HDCP 1.4 support for MST connectors

2020-08-12 Thread Sean Paul
On Wed, Aug 12, 2020 at 3:15 AM Anshuman Gupta wrote: > > On 2020-08-11 at 13:28:46 -0400, Sean Paul wrote: > > On Thu, Jul 9, 2020 at 8:40 AM Anshuman Gupta > > wrote: > > > > > > > \snip > > > > > > > +static int > > > > > +intel_dp_mst_hdcp_toggle_signalling(struct intel_digital_port > > > >

Re: [PATCH] drm/tidss: implement WA for AM65xx erratum i2000

2020-08-12 Thread Jyri Sarha
On 12/08/2020 14:26, Tomi Valkeinen wrote: > This patch implements WA for AM65xx erratum i2000, which causes YUV > formats to show wrong colors. > > An earlier patch removed a partial WA: > > a8d9d7da1546349f18eb2d6b6b3a04bdeb38719d ("drm/tidss: remove AM65x PG1 YUV > erratum code") > > The pat

Re: [git pull] drm for 5.8-rc1

2020-08-12 Thread James Jones
On 8/12/20 10:40 AM, Alyssa Rosenzweig wrote: ...and in merging my code with Alyssa's new panfrost format modifier support, I see panfrost does the opposite of this and treats a format modifier list of only INVALID as "don't care". I modeled the new nouveau behavior on the Iris driver. Now I'm

Re: [git pull] drm for 5.8-rc1

2020-08-12 Thread Karol Herbst
in case you all were wondering, it works on xorg-server git because of this commit: https://gitlab.freedesktop.org/xorg/xserver/-/commit/9b8999411033c9473cd68e92e4690a91aecf5b95 On Wed, Aug 12, 2020 at 8:25 PM James Jones wrote: > > On 8/12/20 10:40 AM, Alyssa Rosenzweig wrote: > >> ...and in me

Re: [PATCH v5] arm64: dts: qcom: sc7180: Add Display Port dt node

2020-08-12 Thread Tanmay Shah
On 2020-08-11 12:30, Stephen Boyd wrote: Quoting Tanmay Shah (2020-08-10 19:15:53) @@ -2440,6 +2447,71 @@ dsi_phy: dsi-phy@ae94400 { status = "disabled"; }; + + msm_dp: displayport-controller@ae9 { +

Re: [PATCH V3 1/2] dt-bindings: Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge

2020-08-12 Thread Rob Herring
On Sun, 09 Aug 2020 12:57:04 +0200, Marek Vasut wrote: > Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge, this > one is used in the Raspberry Pi 7" touchscreen display unit. > > Signed-off-by: Marek Vasut > To: dri-devel@lists.freedesktop.org > Cc: Eric Anholt > Cc: Rob Herring > Cc: Sam

Re: [git pull] drm fixes for 5.9-rc1

2020-08-12 Thread pr-tracker-bot
The pull request you sent on Wed, 12 Aug 2020 14:53:17 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2020-08-12 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ea6ec774372740b024a6c27caac0d0af8960ea15 Thank you! -- Deet-doot-dot, I am a bot. https://ko

Re: [PATCH V3 1/2] dt-bindings: Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge

2020-08-12 Thread Sam Ravnborg
Hi Marek. On Sun, Aug 09, 2020 at 12:57:04PM +0200, Marek Vasut wrote: > Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge, this > one is used in the Raspberry Pi 7" touchscreen display unit. > > Signed-off-by: Marek Vasut > To: dri-devel@lists.freedesktop.org > Cc: Eric Anholt > Cc: Rob H

Re: [PATCH V3 2/2] drm/bridge: tc358762: Add basic driver for Toshiba TC358762 DSI-to-DPI bridge

2020-08-12 Thread Sam Ravnborg
Hi Marek. On Sun, Aug 09, 2020 at 12:57:05PM +0200, Marek Vasut wrote: > Add very basic driver for Toshiba TC358762 DSI-to-DPI bridge, derived > from tc358764 driver and panel-raspberrypi-touchscreen. This driver is > meant to replace the panel-raspberrypi-touchscreen too, as the bridge > connecti

[PATCH] drm/nouveau: Add fine-grain temperature reporting

2020-08-12 Thread Jeremy Cline
Commit d32656373857 ("drm/nouveau/therm/gp100: initial implementation of new gp1xx temperature sensor") added support for reading finer-grain temperatures, but continued to report temperatures in 1 degree Celsius increments via nvkm_therm_temp_get(). Rather than altering nvkm_therm_temp_get() to r

Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files

2020-08-12 Thread Sam Ravnborg
Hi Rob. On Wed, Aug 12, 2020 at 02:36:18PM -0600, Rob Herring wrote: > Clean-up incorrect indentation, extra spaces, long lines, and missing > EOF newline in schema files. Most of the clean-ups are for list > indentation which should always be 2 spaces more than the preceding > keyword. > > Found

[PATCH] drm: panel: Fix bus format for OrtusTech COM43H4M85ULC panel

2020-08-12 Thread Laurent Pinchart
The OrtusTech COM43H4M85ULC panel is a 18-bit RGB panel, set the bus format to MEDIA_BUS_FMT_RGB666_1X18. Fixes: 725c9d40f3fe ("drm/panel: Add support for OrtusTech COM43H4M85ULC panel") Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/panel/panel-simple.c | 2 +- 1 file changed, 1 insertion(

Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files

2020-08-12 Thread Joe Perches
On Wed, 2020-08-12 at 14:36 -0600, Rob Herring wrote: > Clean-up incorrect indentation, extra spaces, long lines, and missing > EOF newline in schema files. Most of the clean-ups are for list > indentation which should always be 2 spaces more than the preceding

Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files

2020-08-12 Thread Rob Herring
On Wed, Aug 12, 2020 at 3:34 PM Sam Ravnborg wrote: > > Hi Rob. > > On Wed, Aug 12, 2020 at 02:36:18PM -0600, Rob Herring wrote: > > Clean-up incorrect indentation, extra spaces, long lines, and missing > > EOF newline in schema files. Most of the clean-ups are for list > > indentation which shoul

Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files

2020-08-12 Thread Rob Herring
On Wed, Aug 12, 2020 at 4:32 PM Joe Perches wrote: > > On Wed, 2020-08-12 at 14:36 -0600, Rob Herring wrote: > > Clean-up incorrect indentation, extra spaces, long lines, and missing > > EOF newline in schema files. Most of the clean-ups are for list > > indentation which should always be 2 spaces

[RFC PATCH v1] dma-fence-array: Deal with sub-fences that are signaled late

2020-08-12 Thread Jordan Crouse
This is an RFC because I'm still trying to grok the correct behavior. Consider a dma_fence_array created two two fence and signal_on_any is true. A reference to dma_fence_array is taken for each waiting fence. When the client calls dma_fence_wait() only one of the fences is signaled. The client r

  1   2   >