Re: [PATCH 29/59] drm/vram_helper: call explicit mm takedown

2020-08-04 Thread Thomas Zimmermann
Am 04.08.20 um 04:56 schrieb Dave Airlie: > From: Dave Airlie > > Signed-off-by: Dave Airlie Reviewed-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_gem_vram_helper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c > b/drivers/gpu/drm/drm

Re: [PATCH 38/59] drm/vram-helper: use wrapper to access memory managers

2020-08-04 Thread Thomas Zimmermann
Am 04.08.20 um 04:56 schrieb Dave Airlie: > From: Dave Airlie > > Signed-off-by: Dave Airlie Reviewed-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_gem_vram_helper.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c >

Re: [RFC][PATCH] regulator: rpi-panel: Add regulator/backlight driver for RPi panel

2020-08-04 Thread Marek Vasut
On 8/3/20 9:48 PM, Mark Brown wrote: > On Mon, Aug 03, 2020 at 09:21:25AM +0200, Marek Vasut wrote: >> On 8/1/20 3:16 AM, Mark Brown wrote: > >>> I see, so this is the remaining bits. Perhaps the binding might help me >>> see how things fit together - I don't know anything about the system >>> re

Re: [PATCH 2/2] dmabuf/tracing: Add dma-buf trace events

2020-08-04 Thread Al Viro
On Mon, Aug 03, 2020 at 11:28:31PM +0100, Al Viro wrote: > IOW, what the hell is that horror for? You do realize, for example, that > there's > such thing as dup(), right? And dup2() as well. And while we are at it, how > do you keep track of removals, considering the fact that you can stick a

Re: [PATCH 2/2] dmabuf/tracing: Add dma-buf trace events

2020-08-04 Thread Al Viro
On Mon, Aug 03, 2020 at 09:22:53AM -0700, Suren Baghdasaryan wrote: > On Mon, Aug 3, 2020 at 9:12 AM Matthew Wilcox wrote: > > > > On Mon, Aug 03, 2020 at 09:00:00AM -0700, Suren Baghdasaryan wrote: > > > On Mon, Aug 3, 2020 at 8:41 AM Matthew Wilcox wrote: > > > > > > > > On Mon, Aug 03, 2020 at

Aw: Re: Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port

2020-08-04 Thread Frank Wunderlich
Hi > Gesendet: Montag, 03. August 2020 um 01:47 Uhr > Von: "Chun-Kuang Hu" > Now I just care about the bls to dpi. So in mediatek,disp.txt, you > just need to add a Optional properties - port (input and output), and > modify mediatek,dpi.txt for its input port. you mean something like this is en

Re: [PATCH 1/2] fs: Add fd_install file operation

2020-08-04 Thread Al Viro
On Mon, Aug 03, 2020 at 02:47:18PM +, Kalesh Singh wrote: > Provides a per process hook for the acquisition of file descriptors, > despite the method used to obtain the descriptor. No, with the side of Fuck, No. Driver has no possible reason to watch know the descriptors involved. Moreover, i

Re: [PATCH 2/2] dmabuf/tracing: Add dma-buf trace events

2020-08-04 Thread Matthew Wilcox
On Mon, Aug 03, 2020 at 09:00:00AM -0700, Suren Baghdasaryan wrote: > On Mon, Aug 3, 2020 at 8:41 AM Matthew Wilcox wrote: > > > > On Mon, Aug 03, 2020 at 02:47:19PM +, Kalesh Singh wrote: > > > +static void dma_buf_fd_install(int fd, struct file *filp) > > > +{ > > > + trace_dma_buf_fd_re

Re: [PATCH 2/2] dmabuf/tracing: Add dma-buf trace events

2020-08-04 Thread Matthew Wilcox
On Mon, Aug 03, 2020 at 02:47:19PM +, Kalesh Singh wrote: > +static void dma_buf_fd_install(int fd, struct file *filp) > +{ > + trace_dma_buf_fd_ref_inc(current, filp); > +} You're adding a new file_operation in order to just add a new tracepoint? NACK.

Re: Re: Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port

2020-08-04 Thread Frank Wunderlich
Am 3. August 2020 18:27:02 MESZ schrieb Chun-Kuang Hu : >But now I have a solution that you need not to modify binding document. >Because now mt7623 has a different routing than mt2701, and this >patch's approach is to use different port setting in each device tree. >My solution is that these t

[PATCH 0/2] Remove unused downstream bus scaling apis

2020-08-04 Thread Sai Prakash Ranjan
MSM bus scaling has moved on to use interconnect framework and downstream bus scaling apis are not present anymore. Remove them as they are nop anyways in the current code, no functional change. Sai Prakash Ranjan (2): drm/msm/mdp4: Remove unused downstream bus scaling apis drm/msm/mdp5: Remov

[PATCH 2/2] drm/msm/mdp5: Remove unused downstream bus scaling apis

2020-08-04 Thread Sai Prakash Ranjan
MSM bus scaling has moved on to use interconnect framework and downstream bus scaling apis are not present anymore. Remove them as they are nop anyways in the current code, no functional change. Signed-off-by: Sai Prakash Ranjan --- .../gpu/drm/msm/disp/mdp5/mdp5_cmd_encoder.c | 24 --- dri

Re: linux-next: manual merge of the hmm tree with the drm tree

2020-08-04 Thread Jason Gunthorpe
On Thu, Jul 30, 2020 at 10:31:45AM -0700, Ralph Campbell wrote: > > On 7/30/20 5:03 AM, Jason Gunthorpe wrote: > > On Thu, Jul 30, 2020 at 07:21:10PM +1000, Stephen Rothwell wrote: > > > Hi all, > > > > > > Today's linux-next merge of the hmm tree got a conflict in: > > > > > >drivers/gpu/dr

Re: linux-next: manual merge of the hmm tree with the drm tree

2020-08-04 Thread Jason Gunthorpe
On Tue, Aug 04, 2020 at 09:29:30AM +1000, Ben Skeggs wrote: > On Tue, Aug 4, 2020 at 9:19 AM Jason Gunthorpe wrote: > > > > On Thu, Jul 30, 2020 at 10:31:45AM -0700, Ralph Campbell wrote: > > > > > > On 7/30/20 5:03 AM, Jason Gunthorpe wrote: > > > > On Thu, Jul 30, 2020 at 07:21:10PM +1000, Steph

[PATCH 1/2] drm/msm/mdp4: Remove unused downstream bus scaling apis

2020-08-04 Thread Sai Prakash Ranjan
MSM bus scaling has moved on to use interconnect framework and downstream bus scaling apis are not present anymore. Remove them as they are nop anyways in the current code, no functional change. Signed-off-by: Sai Prakash Ranjan --- .../gpu/drm/msm/disp/mdp4/mdp4_dtv_encoder.c | 51

Re: [PATCH v5 06/16] pwm: lpss: Use pwm_lpss_apply() when restoring state on resume

2020-08-04 Thread Andy Shevchenko
On Sun, Aug 02, 2020 at 10:51:34PM +0200, Hans de Goede wrote: > On 7/29/20 10:12 AM, Andy Shevchenko wrote: ... > Ok, I've added the suggested/discussed helper in my personal tree. Is it ok > if I add your Reviewed-by with that change in place. Yes, go ahead! > This is the last unreviewed > bi

Re: [PATCH] vgacon: fix out of bounds write to the scrollback buffer

2020-08-04 Thread Greg KH
On Mon, Aug 03, 2020 at 10:08:43AM +0200, Jiri Slaby wrote: > Hi, > > On 31. 07. 20, 7:22, 张云海 wrote: > > Remove whitespace at EOL > > I am fine with the patch. However it should be sent properly (inline > mail, having a PATCH subject etc. -- see > Documentation/process/submitting-patches.rst). g

Re: [git pull] drm for 5.8-rc1

2020-08-04 Thread Karol Herbst
Hi James, I don't know if you knew, but on the Jetson nano we had the issue for quite some time, that GLX/EGL through mesa on X was broken due to some fix in mesa related to modifiers. And I was wondering if the overall state just caused the issue we saw here and wanted to know what branches/patc

Re: [PATCH 2/5] fbdev/core: Export framebuffer read and write code as cfb_ function

2020-08-04 Thread daniel
On Mon, Aug 03, 2020 at 08:46:34AM +0200, Thomas Zimmermann wrote: > Hi > > Am 02.08.20 um 22:01 schrieb Sam Ravnborg: > > On Fri, Jul 31, 2020 at 11:20:33AM +0200, dan...@ffwll.ch wrote: > >> On Wed, Jul 29, 2020 at 06:36:03PM +0200, Sam Ravnborg wrote: > >>> Hi Daniel. > >>> > >>> On Wed, Jul 29

Re: [PATCH v2 3/3] drm/ingenic: ipu: Only enable clock when needed

2020-08-04 Thread Daniel Vetter
On Thu, Jul 30, 2020 at 06:21:05PM +0200, Paul Cercueil wrote: > > > Le jeu. 30 juil. 2020 à 17:29, Sam Ravnborg a écrit : > > On Thu, Jul 30, 2020 at 04:48:30PM +0200, Paul Cercueil wrote: > > > Instead of keeping the IPU clock enabled constantly, enable and > > > disable > > > it on demand, wh

Re: [PATCH] drm/vkms: modify sequence disable/plane/enable in commit_tail

2020-08-04 Thread daniel
On Sat, Aug 01, 2020 at 04:30:23PM -0300, Melissa Wen wrote: > On Wed, Jul 29, 2020 at 12:22 PM Sidong Yang wrote: > > > > This patch modifies function call sequence in commit tail. This is for > > the problem that raised when kms_cursor_crc test is tested repeatedly. > > In second test, there is

Re: [PATCH 2/5] fbdev/core: Export framebuffer read and write code as cfb_ function

2020-08-04 Thread Thomas Zimmermann
Hi Am 04.08.20 um 11:27 schrieb dan...@ffwll.ch: > On Mon, Aug 03, 2020 at 08:46:34AM +0200, Thomas Zimmermann wrote: >> Hi >> >> Am 02.08.20 um 22:01 schrieb Sam Ravnborg: >>> On Fri, Jul 31, 2020 at 11:20:33AM +0200, dan...@ffwll.ch wrote: On Wed, Jul 29, 2020 at 06:36:03PM +0200, Sam Ravnb

Re: [PATCH] drm: Added orientation quirk for ASUS tablet model T103HAF

2020-08-04 Thread daniel
On Sat, Aug 01, 2020 at 03:34:46PM +0300, Marius Iacob wrote: > Signed-off-by: Marius Iacob Queued up for the 5.9 merge window. I also added cc: stable. -Daniel > --- > drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm

Re: [PATCH 39/49] drm/ttm: make ttm_bo_man_init/takedown take type + args

2020-08-04 Thread Christian König
Am 04.08.20 um 03:42 schrieb Dave Airlie: On Fri, 31 Jul 2020 at 23:32, Christian König wrote: Am 31.07.20 um 06:05 schrieb Dave Airlie: From: Dave Airlie This makes it easier to move these to a driver allocated system No, sorry that looks like going into the wrong direction to me. I alrea

Re: [PATCH 05/59] drm/ttm/amdgpu: consolidate ttm reserve paths

2020-08-04 Thread Christian König
Am 04.08.20 um 04:55 schrieb Dave Airlie: From: Dave Airlie Drop the WARN_ON and consolidate the two paths into one. Use the consolidate slowpath in the execbuf utils code. Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +-

Re: [PATCH 06/59] drm/ttm: use a helper for unlocked moves to the lru tail

2020-08-04 Thread Christian König
Am 04.08.20 um 04:55 schrieb Dave Airlie: From: Dave Airlie The pattern was repeated a few times, just make an inline for it. Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c| 8 ++-- drivers/gpu/drm/ttm/ttm_bo_vm.c | 4 +--- include/

Re: [PATCH 08/59] drm/ttm: export memory type debug entrypoint.

2020-08-04 Thread Christian König
Am 04.08.20 um 04:55 schrieb Dave Airlie: From: Dave Airlie As suggested on review, just export the memory type debug for drivers to use, while also making the debug callback optional (don't need to test for system as it won't init it). rename it to be more consistent with object name for now.

Re: [PATCH 04/59] qxl/ttm: drop the unusued no wait flag to reserve function

2020-08-04 Thread Gerd Hoffmann
On Tue, Aug 04, 2020 at 12:55:37PM +1000, Dave Airlie wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie Reviewed-by: Gerd Hoffmann ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-

Re: [PATCH 11/59] drm/qxl/ttm: call ttm manager debug (v2)

2020-08-04 Thread Gerd Hoffmann
On Tue, Aug 04, 2020 at 12:55:44PM +1000, Dave Airlie wrote: > From: Dave Airlie > > v2: use the new exported interface. > This code was poking inside a struct and assuming it was a drm_mm > at the start. Call the proper API. [ also adds some debug info about the ttm manager to the file ] Revie

Re: [PATCH 12/59] drm/vram-helper: call the ttm manager debug function

2020-08-04 Thread Gerd Hoffmann
On Tue, Aug 04, 2020 at 12:55:45PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This code was assuming there was a drm_mm here, don't do > that call the correct API. > > v2: use the new exported interface. Reviewed-by: Gerd Hoffmann ___ dri-dev

Re: [PATCH 17/59] drm/qxl/ttm: use new init path for manager

2020-08-04 Thread Gerd Hoffmann
On Tue, Aug 04, 2020 at 12:55:50PM +1000, Dave Airlie wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie Reviewed-by: Gerd Hoffmann ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-

Re: [PATCH 18/59] drm/vram_helper: use new ttm manager init function

2020-08-04 Thread Gerd Hoffmann
On Tue, Aug 04, 2020 at 12:55:51PM +1000, Dave Airlie wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie Reviewed-by: Gerd Hoffmann ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-

Re: [PATCH 40/59] drm/qxl/ttm: use wrapper to access memory manager

2020-08-04 Thread Gerd Hoffmann
On Tue, Aug 04, 2020 at 12:56:13PM +1000, Dave Airlie wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie Reviewed-by: Gerd Hoffmann ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-

Re: [PATCH 32/59] drm/qxl/ttm: use new takedown path

2020-08-04 Thread Gerd Hoffmann
On Tue, Aug 04, 2020 at 12:56:05PM +1000, Dave Airlie wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie Reviewed-by: Gerd Hoffmann ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-

Re: [PATCH 13/59] drm/ttm: split the mm manager init code (v2)

2020-08-04 Thread Christian König
Am 04.08.20 um 04:55 schrieb Dave Airlie: From: Dave Airlie This will allow the driver to control the ordering here better. Eventually the old path will be removed. v2: add docs for new APIs. rename new path to ttm_mem_type_manager_init/set_used(for now) Signed-off-by: Dave Airlie Reviewe

Re: [PATCH 13/59] drm/ttm: split the mm manager init code (v2)

2020-08-04 Thread Christian König
Am 04.08.20 um 04:55 schrieb Dave Airlie: From: Dave Airlie This will allow the driver to control the ordering here better. Eventually the old path will be removed. v2: add docs for new APIs. rename new path to ttm_mem_type_manager_init/set_used(for now) Signed-off-by: Dave Airlie --- dri

Re: [PATCH 16/59] drm/radeon: use new ttm man init path

2020-08-04 Thread Christian König
Am 04.08.20 um 04:55 schrieb Dave Airlie: From: Dave Airlie Use the new common manager init path. Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/radeon/radeon_ttm.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/

Re: [PATCH 15/59] drm/amdgpu/ttm: init managers from the driver side.

2020-08-04 Thread Christian König
Am 04.08.20 um 04:55 schrieb Dave Airlie: From: Dave Airlie Use new init calls to unwrap manager init Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 19 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 37 +++

Re: [PATCH 25/59] drm/ttm: make some inline helper functions for cleanup paths. (v2)

2020-08-04 Thread Christian König
Am 04.08.20 um 04:55 schrieb Dave Airlie: From: Dave Airlie The disable path is just temporary for now, it will be dropped once has_type is gone in a later patch. v2: add docs. rename to ttm_mem_type_manager namespace Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers

Re: [PATCH 26/59] drm/ttm: start allowing drivers to use new takedown path (v2)

2020-08-04 Thread Christian König
Am 04.08.20 um 04:55 schrieb Dave Airlie: From: Dave Airlie Allow the takedown path callback to be optional as well. v2: use fini for range manager Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 12 +++- drivers/gpu/drm/ttm/t

Re: [PATCH 36/59] drm/ttm: add wrapper to get manager from bdev.

2020-08-04 Thread Christian König
Am 04.08.20 um 04:56 schrieb Dave Airlie: From: Dave Airlie This will allow different abstractions later. Signed-off-by: Dave Airlie Acked-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 34 +++ drivers/gpu/drm/ttm/ttm_bo_util.c | 20 +--

Re: [PATCH 37/59] drm/amdgfx/ttm: use wrapper to get ttm memory managers

2020-08-04 Thread Christian König
Am 04.08.20 um 04:56 schrieb Dave Airlie: From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 ++

Re: [PATCH 2/6] drm/xen-front: Fix misused IS_ERR_OR_NULL checks

2020-08-04 Thread Oleksandr Andrushchenko
On 8/4/20 9:12 AM, Jürgen Groß wrote: > On 31.07.20 14:51, Oleksandr Andrushchenko wrote: >> From: Oleksandr Andrushchenko >> >> The patch c575b7eeb89f: "drm/xen-front: Add support for Xen PV >> display frontend" from Apr 3, 2018, leads to the following static >> checker warning: >> >> driver

Re: [PATCH 1/2] fs: Add fd_install file operation

2020-08-04 Thread Joel Fernandes
On Mon, Aug 3, 2020 at 10:47 AM 'Kalesh Singh' via kernel-team wrote: > > Provides a per process hook for the acquisition of file descriptors, > despite the method used to obtain the descriptor. > Hi, So apart from all of the comments received, I think it is hard to understand what the problem is

Re: [PATCH 2/2] dmabuf/tracing: Add dma-buf trace events

2020-08-04 Thread Kalesh Singh
On Mon, Aug 03, 2020 at 11:32:39AM -0400, Steven Rostedt wrote: > On Mon, 3 Aug 2020 14:47:19 + > Kalesh Singh wrote: > > > +DECLARE_EVENT_CLASS(dma_buf_ref_template, > > + > > + TP_PROTO(struct task_struct *task, struct file *filp), > > + > > + TP_ARGS(task, filp), > > + > > + TP_STR

Re: [PATCH 1/2] fs: Add fd_install file operation

2020-08-04 Thread Kalesh Singh
On Mon, Aug 03, 2020 at 05:34:29PM +0100, Christoph Hellwig wrote: > On Mon, Aug 03, 2020 at 02:47:18PM +, Kalesh Singh wrote: > > Provides a per process hook for the acquisition of file descriptors, > > despite the method used to obtain the descriptor. > > > > Signed-off-by: Kalesh Singh >

[PATCH v10 07/11] device-mapping: Introduce DMA range map, supplanting dma_pfn_offset

2020-08-04 Thread Jim Quinlan
The new field 'dma_range_map' in struct device is used to facilitate the use of single or multiple offsets between mapping regions of cpu addrs and dma addrs. It subsumes the role of "dev->dma_pfn_offset" which was only capable of holding a single uniform offset and had no region bounds checking.

Re: [PATCH v9 08/12] device core: Introduce DMA range map, supplanting dma_pfn_offset

2020-08-04 Thread Jim Quinlan
On Sat, Aug 1, 2020 at 1:17 PM Nicolas Saenz Julienne wrote: > > Hi Jim, here's some comments after testing your series against RPi4. > > On Fri, 2020-07-24 at 16:33 -0400, Jim Quinlan wrote: > > The new field 'dma_range_map' in struct device is used to facilitate the > > use of single or multiple

[PATCH v10 00/11] PCI: brcmstb: enable PCIe for STB chips

2020-08-04 Thread Jim Quinlan
Patchset Summary: Enhance a PCIe host controller driver. Because of its unusual design we are foced to change dev->dma_pfn_offset into a more general role allowing multiple offsets. See the 'v1' notes below for more info. v10: Commit: "device-mapping: Introduce DMA range map, supplantin

Re: [PATCH 41/59] drm/radeon/ttm: use wrapper to access memory manager

2020-08-04 Thread Christian König
Am 04.08.20 um 04:56 schrieb Dave Airlie: From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/radeon/radeon_gem.c | 2 +- drivers/gpu/drm/radeon/radeon_ttm.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/dr

Re: [PATCH 43/59] drm/ttm: rename manager variable to make sure wrapper is used.

2020-08-04 Thread Christian König
Am 04.08.20 um 04:56 schrieb Dave Airlie: From: Dave Airlie Other users of this should notice this change and switch to wrapper. Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c| 2 +- include/drm/ttm/ttm_bo_driver.h | 7 +-- 2 files ch

Re: [PATCH 44/59] drm/ttm: allow drivers to provide their own manager subclasses

2020-08-04 Thread Christian König
Am 04.08.20 um 04:56 schrieb Dave Airlie: From: Dave Airlie This will get removed eventually and all drivers will use this. Signed-off-by: Dave Airlie Reviewed-by: Christian König --- include/drm/ttm/ttm_bo_driver.h | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) di

Re: [PATCH 45/59] drm/amdgpu/ttm: use bo manager subclassing for vram/gtt mgrs

2020-08-04 Thread Christian König
Am 04.08.20 um 04:56 schrieb Dave Airlie: From: Dave Airlie Reviewed-by: Christian König Signed-off-by: Dave Airlie This one is already reviewed and can stay like this, but I had one more idea for further cleanups, see below. --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 35 +

Re: [PATCH 46/59] drm/ttm: make ttm_range_man_init/takedown take type + args

2020-08-04 Thread Christian König
Am 04.08.20 um 04:56 schrieb Dave Airlie: From: Dave Airlie This makes it easier to move these to a driver allocated system Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 15 +--- drivers/gpu/drm/drm_gem_vram_helper.c |

Re: [PATCH 54/59] drm/ttm: drop list of memory managers from device. (v2)

2020-08-04 Thread Christian König
Am 04.08.20 um 04:56 schrieb Dave Airlie: From: Dave Airlie The driver now controls these, the core just controls the system memory one. v2: init sysman explicitly and assign it as a driver manager to simplify the lookup sequence. Signed-off-by: Dave Airlie Reviewed-by: Christian König

Re: [PATCH 55/59] drm/ttm: drop type manager has_type

2020-08-04 Thread Christian König
Am 04.08.20 um 04:56 schrieb Dave Airlie: From: Dave Airlie under driver control, this flag isn't needed anymore, remove the API that used to access it, and consoldiate with the used api. Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_

Re: [PATCH 56/59] drm/ttm: add a wrapper for checking if manager is in use

2020-08-04 Thread Christian König
Am 04.08.20 um 04:56 schrieb Dave Airlie: From: Dave Airlie This converts vmwgfx over to using an interface to set the in use and check the in use flag. Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 1 - drivers/gpu/drm/ttm/ttm_bo

Re: [PATCH 57/59] drm/ttm: rename bo manager to range manager.

2020-08-04 Thread Christian König
Am 04.08.20 um 04:56 schrieb Dave Airlie: From: Dave Airlie The generic manager is called the range manager now, rename the file and some internals. Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/ttm/Makefile | 2 +- .../{ttm_bo_manager.c

Re: [PATCH 58/59] drm/ttm: rename ttm_mem_type_manager -> ttm_resource_manager.

2020-08-04 Thread Christian König
Am 04.08.20 um 04:56 schrieb Dave Airlie: From: Dave Airlie This name makes a lot more sense, since these are about managing driver resources rather than just memory ranges. Signed-off-by: Dave Airlie Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c| 2 +-

Re: [PATCH 59/59] drm/ttm: rename ttm_mem_reg to ttm_resource.

2020-08-04 Thread Christian König
Am 04.08.20 um 04:56 schrieb Dave Airlie: From: Dave Airlie This name better reflects what the object does. I didn't rename all the pointers it seemed too messy. Signed-off-by: Dave Airlie Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 6 +-- drivers/gp

Re: [PATCH 4/9] drm/msm/dsi: Add phy configuration for SDM630/636/660

2020-08-04 Thread Vinod Koul
On 03-08-20, 09:06, Rob Clark wrote: > On Mon, Aug 3, 2020 at 4:00 AM Vinod Koul wrote: > > > > On 26-07-20, 13:12, Konrad Dybcio wrote: > > > These SoCs make use of the 14nm phy, but at different > > > addresses than other 14nm units. > > > > > > Signed-off-by: Konrad Dybcio > > > --- > > > ...

Re: [PATCH v2] drm/omap: force runtime PM suspend on system suspend

2020-08-04 Thread Tomi Valkeinen
Hi, On 17/07/2020 19:28, Tony Lindgren wrote: > * Tomi Valkeinen [200618 09:53]: >> Use SET_LATE_SYSTEM_SLEEP_PM_OPS in DSS submodules to force runtime PM >> suspend and resume. >> >> We use suspend late version so that omapdrm's system suspend callback is >> called first, as that will disable al

Re: [PATCH] drm: omapdrm: Delete surplus GPIO includes

2020-08-04 Thread Tomi Valkeinen
On 27/06/2020 01:06, Linus Walleij wrote: > The OMAP DRM driver includes into the two > hdmi4.c and hdmi5.c files but does not use any symbols from > these files. Drop the includes. > > Cc: Tomi Valkeinen > Cc: Tony Lindgren > Cc: Jyri Sarha > Signed-off-by: Linus Walleij > --- > drivers/gpu

[PULL] drm-misc-fixes

2020-08-04 Thread Thomas Zimmermann
Hi Dave and Daniel, here's this week's PR for drm-misc-fixes. A number of small driver and HW fixes, one in TTM, one in docs. Three of the patches don't have a Fixes tag, which a find concerning. Best regards Thomas drm-misc-fixes-2020-08-04: * backmerge from drm-fixes at v5.8-rc7 * add orient

Re: [PATCH] vt: defer kfree() of vc_screenbuf in vc_do_resize()

2020-08-04 Thread Greg Kroah-Hartman
On Tue, Aug 04, 2020 at 08:15:43PM +0900, Tetsuo Handa wrote: > Do you think this approach is acceptable? Or, do we need to modify > set_origin() ? > > On 2020/07/29 23:57, Tetsuo Handa wrote: > > syzbot is reporting UAF bug in set_origin() from vc_do_resize() [1], for > > vc_do_resize() calls kf

Re: [PATCH 13/59] drm/ttm: split the mm manager init code (v2)

2020-08-04 Thread Christian König
Am 04.08.20 um 13:07 schrieb Christian König: Am 04.08.20 um 04:55 schrieb Dave Airlie: From: Dave Airlie This will allow the driver to control the ordering here better. Eventually the old path will be removed. v2: add docs for new APIs. rename new path to ttm_mem_type_manager_init/set_used(

[Bug 208333] Black screen with Kernel 5.8 rc1/2/3/4 with Nvidia Gtx 760 driver nouveau

2020-08-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208333 --- Comment #12 from Roberto Guerrini (robyguerr...@yahoo.it) --- With official Kernel 5.8 the bug is solved Good Work -- You are receiving this mail because: You are watching the assignee of the bug.

Re: [RFC][PATCH] regulator: rpi-panel: Add regulator/backlight driver for RPi panel

2020-08-04 Thread Mark Brown
On Tue, Aug 04, 2020 at 12:29:49AM +0200, Marek Vasut wrote: > On 8/3/20 9:48 PM, Mark Brown wrote: > > OK, basically I've got no real objection from a regulator point of view > > - it's not ideal but not the end of the world. > Then, how shall we proceed ? Submitting the patch properly with the

Re: [PATCH v2 10/24] virtio_gpu: correct tags for config space fields

2020-08-04 Thread Cornelia Huck
On Mon, 3 Aug 2020 16:59:18 -0400 "Michael S. Tsirkin" wrote: > Since gpu is a modern-only device, > tag config space fields as having little endian-ness. > > Signed-off-by: Michael S. Tsirkin > --- > include/uapi/linux/virtio_gpu.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(

Re: [PATCH v3 1/5] drm: mediatek: add ddp routing for mt7623

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月4日 週二 下午7:00寫道: > > From: Frank Wunderlich > > on BPi-R2/mt7623 main-path have to be routed to DPI0 (hdmi) instead of DSI0 > using compatible "mt7623-mmsys" already defined in dts > > Signed-off-by: Frank Wunderlich > --- > drivers/gpu/drm/mediatek/mtk_drm_

Re: [PATCH v3 3/5] drm: Add get_possible_crtc API for dpi, dsi

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月4日 週二 下午7:00寫道: > > From: Stu Hsieh > > For current mediatek dsi encoder, its possible crtc is fixed in crtc > 0, and mediatek dpi encoder's possible crtc is fixed in crtc 1. In > some SoC the possible crtc is not fixed in this case, so search > pipeline info

Re: [PATCH v3 4/5] drm/mediatek: dpi/dsi: change the getting possible_crtc way

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月4日 週二 下午7:00寫道: > > From: Jitao Shi > > For current mediatek dsi encoder, its possible crtc is fixed in crtc > 0, and mediatek dpi encoder's possible crtc is fixed in crtc 1. In > some SoC the possible crtc is not fixed in this case, so call > mtk_drm_find_po

Re: [PATCH 4/9] drm/msm/dsi: Add phy configuration for SDM630/636/660

2020-08-04 Thread Rob Clark
On Tue, Aug 4, 2020 at 5:09 AM Vinod Koul wrote: > > On 03-08-20, 09:06, Rob Clark wrote: > > On Mon, Aug 3, 2020 at 4:00 AM Vinod Koul wrote: > > > > > > On 26-07-20, 13:12, Konrad Dybcio wrote: > > > > These SoCs make use of the 14nm phy, but at different > > > > addresses than other 14nm units

Re: [PATCHv2 0/4] Subject: panel-dsi-cm: update bindings

2020-08-04 Thread Tomi Valkeinen
Hi Sebastian, On 16/07/2020 15:57, Sebastian Reichel wrote: > The cleanup series for omapdrm's DSI code got too big. Reviewing > this is not fun and the same goes for keeping track of the change > requests. Let's do the cleanup in smaller steps instead. This is > the first batch, which updates the

Re: [PATCH v3 5/5] arm: dts: mt7623: add display subsystem related device nodes

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月4日 週二 下午7:00寫道: > > From: Ryder Lee > > Add display subsystem related device nodes for MT7623. > > Cc: CK Hu > Signed-off-by: chunhui dai > Signed-off-by: Bibby Hsieh > Signed-off-by: Ryder Lee > Signed-off-by: Frank Wunderlich > Tested-by: Frank Wunderl

Re: Re: [PATCH v3 1/5] drm: mediatek: add ddp routing for mt7623

2020-08-04 Thread Chun-Kuang Hu
Frank Wunderlich 於 2020年8月4日 週二 下午10:44寫道: > > Hi, > > > Gesendet: Dienstag, 04. August 2020 um 16:34 Uhr > > Von: "Chun-Kuang Hu" > > > > -static const enum mtk_ddp_comp_id mt2712_mtk_ddp_main[] = { > > > +static enum mtk_ddp_comp_id mt2712_mtk_ddp_main[] = { > > > > Why do you remove 'const'? >

Re: [PATCH 3/3] drm/msm/dpu: add support for clk and bw scaling for display

2020-08-04 Thread Rob Clark
On Thu, Jul 16, 2020 at 4:36 AM Kalyan Thota wrote: > > This change adds support to scale src clk and bandwidth as > per composition requirements. > > Interconnect registration for bw has been moved to mdp > device node from mdss to facilitate the scaling. > > Changes in v1: > - Address armv7 com

Re: [PATCH 1/3] arm64: dts: sc7180: add interconnect bindings for display

2020-08-04 Thread Rob Clark
On Thu, Jul 16, 2020 at 4:36 AM Kalyan Thota wrote: > > From: Krishna Manikandan > > This change adds the interconnect bindings to the > MDSS node. This will establish Display to DDR path > for bus bandwidth voting. > > Changes in v2: > - Change in commit message(Matthias Kaehlcke) > > Ch

Re: [PATCH 2/3] arm64: dts: sc7180: add bus clock to mdp node for sc7180 target

2020-08-04 Thread Rob Clark
On Thu, Jul 16, 2020 at 4:36 AM Kalyan Thota wrote: > > From: Krishna Manikandan > > Move the bus clock to mdp device node,in order > to facilitate bus band width scaling on sc7180 > target. > > The parent device MDSS will not vote for bus bw, > instead the vote will be triggered by mdp device >

Re: Re: [PATCH v3 5/5] arm: dts: mt7623: add display subsystem related device nodes

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月4日 週二 下午11:23寫道: > > Hi > > Except mmsys (i added in Patch #1) all mt7623-compatibles are not defined in > code and fallback (mt2701-x/mt8173-x) is used. If i add it in dt-binding, it > should be added in code too, right? or should i remove mt7623 compatible

Re: [PATCH] drm: fix drm_dp_mst_port refcount leaks in drm_dp_mst_allocate_vcpi

2020-08-04 Thread Lyude Paul
Heh, I remember this being mentioned to me way back but completely forgot to ever go fix it. Thanks for the patch! Reviewed-by: Lyude Paul This is missing a Fixes: tag though: Fixes: 1e797f556c61 ("drm/dp: Split drm_dp_mst_allocate_vcpi") Cc: # v4.12+ So I will go ahead and add that, th

Re: [Intel-gfx] [PATCH 11/66] drm/i915: Preallocate stashes for vma page-directories

2020-08-04 Thread Daniel Vetter
On Tue, Aug 4, 2020 at 4:08 PM Chris Wilson wrote: > > Quoting Thomas Hellström (Intel) (2020-07-30 13:28:19) > > > > On 7/28/20 4:50 PM, Chris Wilson wrote: > > > > > > It's in the user critical path (the shortest path to perform their > > > sequence of operations), but it's before the dma-fence

Re: [PATCH] drm/vkms: guarantee vblank when capturing crc

2020-08-04 Thread daniel
On Sat, Aug 01, 2020 at 03:49:29PM -0300, Melissa Wen wrote: > VKMS needs vblank interrupts enabled to capture CRC. When vblank is > disabled, tests like kms_cursor_crc and kms_pipe_crc_basic getting stuck > waiting for a capture that will not occur until vkms wakes up. This > patch ensures that vb

Re: [PATCH v1 03/22] backlight: Add get/set operations for brightness/power properties

2020-08-04 Thread daniel
On Sun, Aug 02, 2020 at 01:06:17PM +0200, Sam Ravnborg wrote: > Add get and set operations to incapsualte access to backlight properties. > > One easy win is that the get/set operatiosn can be used when backlight > is not included in the configuration, resulting in simpler code with > less ifdef's

Re: [RFC PATCH v1 0/22] backlight: add init macros and accessors

2020-08-04 Thread daniel
On Sun, Aug 02, 2020 at 01:06:14PM +0200, Sam Ravnborg wrote: > The backlight drivers uses several different patterns when registering > a backlight: > > - Register backlight and assign properties later > - Define a local backlight_properties variable and use memset > - Define a const backlight_pr

Re: [PATCH v1 06/22] drm/panel: asus-z00t-tm5p5-n35596: Backlight update

2020-08-04 Thread daniel
On Sun, Aug 02, 2020 at 01:06:20PM +0200, Sam Ravnborg wrote: > Update backlight to use macro for initialization and the > backlight_get_brightness() operation to simply the update operation. > > Signed-off-by: Sam Ravnborg > Cc: Konrad Dybcio > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > .

Re: [PATCH v1 10/22] drm/panel: raydium-rm67191: Backlight update

2020-08-04 Thread daniel
On Sun, Aug 02, 2020 at 01:06:24PM +0200, Sam Ravnborg wrote: > - Replace direct access to backlight_properties with > backlight_get_brightness(). > - Use macro for initialization > > Signed-off-by: Sam Ravnborg > Cc: Robert Chiras > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > drivers/gpu

Re: [PATCH v1 15/22] drm/panel: sony-acx565akm: Backlight update

2020-08-04 Thread daniel
On Sun, Aug 02, 2020 at 01:06:29PM +0200, Sam Ravnborg wrote: > - Use backlight_get_brightness() helper > - Use backlight_is_blank() helper > - Use macro for initialization > - Drop direct access to backlight properties > - Use the devm_ variant for registering backlight device, and drop > all ex

Re: gma500: monitor-dependent failure to boot FB console (psbdrmfb)

2020-08-04 Thread daniel
On Tue, Aug 04, 2020 at 01:43:29AM +, Thierry Moreau wrote: > Dear kernel / GPU enthusiasts! > > This list is listed in the kernel MAINTAINERS file for GMA500 GPU kernel > module. Just to avoid disappointment later on: For the gma500 driver it's essentially unmaintained, but we do take patche

Re: [PATCH v4 1/6] dt-bindings: mediatek: add mt7623 display-nodes

2020-08-04 Thread Rob Herring
On Tue, Aug 4, 2020 at 11:19 AM Frank Wunderlich wrote: > > CC Rob Herring and devicetree-list Resend or it is not in my patchwork queue. But this is simple enough: Acked-by: Rob Herring > > > Gesendet: Dienstag, 04. August 2020 um 18:55 Uhr > > Von: "Frank Wunderlich" > > An: linux-media...

Re: [PATCH v4 6/6] arm: dts: mt7623: add display subsystem related device nodes

2020-08-04 Thread David Woodhouse
On Tue, 2020-08-04 at 18:55 +0200, Frank Wunderlich wrote: > From: Ryder Lee > > Add display subsystem related device nodes for MT7623. > > Cc: CK Hu > Signed-off-by: chunhui dai > Signed-off-by: Bibby Hsieh > Signed-off-by: Ryder Lee > Signed-off-by: Frank Wunderlich > Tested-by: Frank Wun

Re: [PATCH RFC v6 0/6] Add Unisoc's drm kms module

2020-08-04 Thread Rob Herring
On Tue, Jul 28, 2020 at 4:12 AM Daniel Vetter wrote: > > On Tue, Jul 28, 2020 at 12:08 PM Kevin Tang wrote: > > > > From: Kevin Tang > > Hm still no ack for dt bindings? We need that for merging. If it's not sent to the DT list so it gets into patchwork that's never going to happen. Nor are any

[PATCH][next] drm/amd/display: fix spelling mistake "Usupported" -> "Unsupported"

2020-08-04 Thread Colin King
From: Colin Ian King There are spelling mistakes in two DRM_ERROR error messages. Fix them. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_d

NAK: [PATCH][next] drm/amd/display: fix spelling mistake "Usupported" -> "Unsupported"

2020-08-04 Thread Colin Ian King
On 04/08/2020 18:34, Colin King wrote: > From: Colin Ian King > > There are spelling mistakes in two DRM_ERROR error messages. Fix them. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: Aw: Re: [PATCH v4 6/6] arm: dts: mt7623: add display subsystem related device nodes

2020-08-04 Thread David Woodhouse
On Tue, 2020-08-04 at 19:40 +0200, Frank Wunderlich wrote: > > Gesendet: Dienstag, 04. August 2020 um 19:24 Uhr > > Von: "David Woodhouse" > > > + mipi_tx0: mipi-dphy@1001 { > > > + compatible = "mediatek,mt7623-mipi-tx", > > > + "mediatek,mt2701-mipi-tx"; > > > +

Re: [PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE

2020-08-04 Thread daniel
On Thu, Jul 30, 2020 at 08:10:27AM +0200, Christoph Hellwig wrote: > If a TAINT_PROPRIETARY_MODULE exports symbol, inherit the taint flag > for all modules importing these symbols, and don't allow loading > symbols from TAINT_PROPRIETARY_MODULE modules if the module previously > imported gplonly sy

Re: [v1] drm/msm/dpu: update reservations in commit path

2020-08-04 Thread Rob Clark
On Tue, Aug 4, 2020 at 4:32 AM Kalyan Thota wrote: > > DPU resources reserved in the atomic_check path gets unwinded > during modeset operation before commit happens in a non seamless > transition. > > Update the reservations in the commit path to avoid resource > failures. Secondly have dummy res

Re: [PATCH v1 03/22] backlight: Add get/set operations for brightness/power properties

2020-08-04 Thread Sam Ravnborg
Hi Daniel et al. On Tue, Aug 04, 2020 at 06:43:30PM +0200, dan...@ffwll.ch wrote: > On Sun, Aug 02, 2020 at 01:06:17PM +0200, Sam Ravnborg wrote: > > Add get and set operations to incapsualte access to backlight properties. > > > > One easy win is that the get/set operatiosn can be used when backl

[Bug 203905] amdgpu:actual_brightness has unreal/wrong value

2020-08-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203905 --- Comment #11 from Alexander Monakov (amona...@gmail.com) --- v2 patch: https://lore.kernel.org/lkml/20200804201313.6464-1-amona...@ispras.ru/ -- You are receiving this mail because: You are watching the assignee of the bug. __

Re: [PATCH 2/2] dmabuf/tracing: Add dma-buf trace events

2020-08-04 Thread Daniel Vetter
On Tue, Aug 4, 2020 at 12:28 AM Al Viro wrote: > > On Mon, Aug 03, 2020 at 09:22:53AM -0700, Suren Baghdasaryan wrote: > > On Mon, Aug 3, 2020 at 9:12 AM Matthew Wilcox wrote: > > > > > > On Mon, Aug 03, 2020 at 09:00:00AM -0700, Suren Baghdasaryan wrote: > > > > On Mon, Aug 3, 2020 at 8:41 AM Ma

  1   2   >