Re: [PATCH 00/49] ttm mem manager refactoring.

2020-08-03 Thread Dave Airlie
On Fri, 31 Jul 2020 at 19:17, Christian König wrote: > > Am 31.07.20 um 06:04 schrieb Dave Airlie: > > I started pulling on a thread, and it led me down a hole. > > We might want to make that hole even bigger :) > > How about we rename the ttm_mem_reg into ttm_resource and > ttm_mem_type_manager i

Re: [PATCH v4 00/23] device-dax: Support sub-dividing soft-reserved ranges

2020-08-03 Thread David Hildenbrand
[...] > Well, no v5.8-rc8 to line this up for v5.9, so next best is early > integration into -mm before other collisions develop. > > Chatted with Justin offline and it currently appears that the missing > numa information is the fault of the platform firmware to populate all > the necessary NUMA

Re: [PATCH] vgacon: fix out of bounds write to the scrollback buffer

2020-08-03 Thread Jiri Slaby
Hi, On 31. 07. 20, 7:22, 张云海 wrote: > Remove whitespace at EOL I am fine with the patch. However it should be sent properly (inline mail, having a PATCH subject etc. -- see Documentation/process/submitting-patches.rst). git send-email after git format-patch handles most of it. There is also ques

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-08-03 Thread Leandro Ribeiro
Hello everybody! I'm currently working on a writeback connector screenshooter for Weston. In order to test it, I'm using VKMS with Rodrigo's writeback connector patch: https://lkml.org/lkml/2020/5/11/449 Here is the link with the MR in Weston with more details of how I've tested it: https:/

Re: [PATCH v2 2/5] drm/mediatek: fix boot up for 720 and 480 but 1080

2020-08-03 Thread Frank Wunderlich
Hi, Am 2. August 2020 02:08:44 MESZ schrieb Chun-Kuang Hu : >Hi, Frank: >> - disable tmds on phy on mt2701 >> - support other resolutions like 1280x1024 > >If this patch does two things, it should be broken into two patches. As far as i see,it only disable tmds and so fix specific resolutions like

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-08-03 Thread Leandro Ribeiro
Hello everybody! I'm currently working on a writeback connector screenshooter for Weston. In order to test it, I'm using VKMS with Rodrigo's writeback connector patch: https://lkml.org/lkml/2020/5/11/449 Here is the link with the MR in Weston with more details of how I've tested it: https://

[RFC PATCH 09/17] drm/i915/vga: Drop uses of pci_read_config_*() return value

2020-08-03 Thread Saheed O. Bolarinwa
The return value of pci_read_config_*() may not indicate a device error. However, the value read by these functions is more likely to indicate this kind of error. This presents two overlapping ways of reporting errors and complicates error checking. It is possible to move to one single way of chec

Re: [RFC PATCH 00/17] Drop uses of pci_read_config_*() return value

2020-08-03 Thread Saheed Bolarinwa
On 8/1/20 2:56 PM, Borislav Petkov wrote: On Sat, Aug 01, 2020 at 01:24:29PM +0200, Saheed O. Bolarinwa wrote: The return value of pci_read_config_*() may not indicate a device error. However, the value read by these functions is more likely to indicate this kind of error. This presents two ov

[PATCH drm/hisilicon v2 0/3] hibmc clean up and code refactoring

2020-08-03 Thread Tian Tao
patch #1 and #3 is clean up, patch #2 is for code refactoring Changes since v1: - Rewrite the commits messages and patch name in #1 - Rewrite the commits message in #2. - Add the new patch #3 Tian Tao (3): drm/hisilicon: Remove the unused include statements drm/hisilicon: Code refactoring for

Re: [PATCH v9 08/12] device core: Introduce DMA range map, supplanting dma_pfn_offset

2020-08-03 Thread Nicolas Saenz Julienne
Hi Jim, here's some comments after testing your series against RPi4. On Fri, 2020-07-24 at 16:33 -0400, Jim Quinlan wrote: > The new field 'dma_range_map' in struct device is used to facilitate the > use of single or multiple offsets between mapping regions of cpu addrs and > dma addrs. It subsum

Re: [PATCH v5 00/16] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

2020-08-03 Thread Andy Shevchenko
On Sat, Aug 01, 2020 at 04:38:16PM +0200, Hans de Goede wrote: > On 7/29/20 12:54 PM, Andy Shevchenko wrote: > > On Fri, Jul 17, 2020 at 03:37:37PM +0200, Hans de Goede wrote: ... > > One comment to consider, though. There are three channels in that PWM AFAIU. > > One of them is backlight control

Re: [PATCH v2 13/14] [DO NOT MERGE] arm64: dts: allwinner: h6: Add GPU OPP table

2020-08-03 Thread Clément Péron
Hi Maxime and All, On Sat, 4 Jul 2020 at 16:56, Clément Péron wrote: > > Hi Maxime, > > On Sat, 4 Jul 2020 at 14:13, Maxime Ripard wrote: > > > > Hi, > > > > On Sat, Jul 04, 2020 at 12:25:34PM +0200, Clément Péron wrote: > > > Add an Operating Performance Points table for the GPU to > > > enable

Re: [RFC][PATCH] regulator: rpi-panel: Add regulator/backlight driver for RPi panel

2020-08-03 Thread Marek Vasut
On 8/1/20 3:16 AM, Mark Brown wrote: > On Thu, Jul 30, 2020 at 09:37:48PM +0200, Marek Vasut wrote: >> On 7/30/20 9:13 PM, Mark Brown wrote: >>> On Thu, Jul 30, 2020 at 06:28:07PM +0200, Marek Vasut wrote: > about it ? I can over-complicate this and split it into multiple drivers, but I

Re: [PATCH v2 4/5] drm/mediatek: dpi/dsi: change the getting possible_crtc way

2020-08-03 Thread Frank Wunderlich
Am 2. August 2020 05:07:41 MESZ schrieb Chun-Kuang Hu : >I would like more information of why do this patch. For example: > >For current mediatek dsi encoder, its possible crtc is fixed in crtc >0, and mediatek dpi encoder's possible crtc is fixed in crtc 1. In >some SoC the possible crtc is no

Aw: Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port

2020-08-03 Thread Frank Wunderlich
> Gesendet: Sonntag, 02. August 2020 um 02:03 Uhr > Von: "Chun-Kuang Hu" > An: "Frank Wunderlich" > Cc: "Chun-Kuang Hu" , "Philipp Zabel" > , "David Airlie" , "linux-kernel" > , "DRI Development" > , "moderated list:ARM/Mediatek SoC support" > , "Daniel Vetter" , > "Matthias Brugger" , "Bibb

[PATCH drm/hisilicon v2 1/3] drm/hisilicon: Remove the unused include statements

2020-08-03 Thread Tian Tao
Remove some unused include statements. v2: edit patch name and commit message. Signed-off-by: Tian Tao --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 3 --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 5 - drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 2 -- 3 files chang

[PATCH drm/hisilicon v2 2/3] drm/hisilicon: Code refactoring for hibmc_drv_de

2020-08-03 Thread Tian Tao
The memory used to be allocated with devres helpers and released automatically. In rare circumstances, the memory's release could have happened before the DRM device got released, which would have caused memory corruption of some kind. Now we're embedding the data structures in struct hibmc_drm_pri

[PATCH] drm/panel: remove return value of function drm_panel_add

2020-08-03 Thread Bernard Zhao
The function "int drm_panel_add(struct drm_panel *panel)" always returns 0, this return value is meaningless. Also, there is no need to check return value which calls "drm_panel_add and", error branch code will never run. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/drm_panel.c

[v7] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings

2020-08-03 Thread Krishna Manikandan
MSM Mobile Display Subsytem (MDSS) encapsulates sub-blocks like DPU display controller, DSI etc. Add YAML schema for the device tree bindings for the same. Signed-off-by: Krishna Manikandan Changes in v2: - Changed dpu to DPU (Sam Ravnborg) - Fixed indentation issues (Sam Ravnborg) -

[PATCH] drm: Added orientation quirk for ASUS tablet model T103HAF

2020-08-03 Thread Marius Iacob
Signed-off-by: Marius Iacob --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index d00ea384dcbf..58f5dc2f6dd5 100644 --- a/drivers/gpu/drm/d

[PATCH drm/hisilicon v2 3/3] drm/hisilicon: Rename variables to represent the correct meaning

2020-08-03 Thread Tian Tao
Rename plane to primary_plane in the structure hibmc_drm_private. so it's clear which plane it represents. Signed-off-by: Tian Tao --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 2 +- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

[RFC PATCH 00/17] Drop uses of pci_read_config_*() return value

2020-08-03 Thread Saheed O. Bolarinwa
The return value of pci_read_config_*() may not indicate a device error. However, the value read by these functions is more likely to indicate this kind of error. This presents two overlapping ways of reporting errors and complicates error checking. It is possible to move to one single way of chec

Re: [PATCH][next] drm/rockchip: lvds: ensure ret is assigned before checking for an error

2020-08-03 Thread Miquel Raynal
Hello, Colin King wrote on Tue, 14 Jul 2020 20:00:03 +0100: > From: Colin Ian King > > Currently there are two places where the return status in ret is being > checked for an error however the assignment of ret has been omitted > making the checks redundant. Fix this by adding in the missing

[PATCH] drm/i915: Fix wrong return value

2020-08-03 Thread Tianjia Zhang
In function i915_active_acquire_preallocate_barrier(), not all paths have the return value set correctly, and in case of memory allocation failure, a negative error code should be returned. Cc: Chris Wilson Signed-off-by: Tianjia Zhang --- drivers/gpu/drm/i915/i915_active.c| 4 ++--

[PATCH] drm/amd/display: Fix wrong return value in dm_update_plane_state()

2020-08-03 Thread Tianjia Zhang
On an error exit path, a negative error code should be returned instead of a positive return value. Fixes: 9e869063b0021 ("drm/amd/display: Move iteration out of dm_update_planes") Cc: Leo Li Signed-off-by: Tianjia Zhang --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-- 1 file chan

[PATCH] drm/nouveau/acr: fix a coding style in nvkm_acr_lsfw_load_bl_inst_data_sig()

2020-08-03 Thread Jing Xiangfeng
This patch performs the following changes: 1. remove a redundant parentheses around the nvkm_acr_lsfw_add() calls 2. do assignment before this if condition, it is more readable Signed-off-by: Jing Xiangfeng --- drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 ++- 1 file changed, 2 insertions

[PATCH] drm/i915: Fix wrong return value in intel_atomic_check()

2020-08-03 Thread Tianjia Zhang
In the case of calling check_digital_port_conflicts() failed, a negative error code -EINVAL should be returned. Fixes: bf5da83e4bd80 ("drm/i915: Move check_digital_port_conflicts() earier") Cc: Ville Syrjälä Signed-off-by: Tianjia Zhang --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- 1

Re: [PATCH] dma-buf: heaps: Introduce dma_heap_add_cma() for non-default CMA heap

2020-08-03 Thread Kunihiko Hayashi
Hi John, Thank you for your comment. On 2020/07/29 4:17, John Stultz wrote: On Thu, Jul 16, 2020 at 6:10 PM Kunihiko Hayashi wrote: Current dma-buf heaps can handle only default CMA. This introduces dma_heap_add_cma() function to attach CMA heaps that belongs to a device. At first, the drive

Re: [PATCH v3 02/23] x86/numa: Add 'nohmat' option

2020-08-03 Thread Randy Dunlap
On 7/31/20 8:25 PM, Dan Williams wrote: > Disable parsing of the HMAT for debug, to workaround broken platform > instances, or cases where it is otherwise not wanted. > > --- > arch/x86/mm/numa.c |2 ++ > drivers/acpi/numa/hmat.c |8 +++- > include/acpi/acpi_numa.h |8 ++

Re: [PATCH] vgacon: fix out of bounds write to the scrollback buffer

2020-08-03 Thread Greg KH
On Mon, Aug 03, 2020 at 10:08:43AM +0200, Jiri Slaby wrote: > Hi, > > On 31. 07. 20, 7:22, 张云海 wrote: > > Remove whitespace at EOL > > I am fine with the patch. However it should be sent properly (inline > mail, having a PATCH subject etc. -- see > Documentation/process/submitting-patches.rst). g

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-08-03 Thread Leandro Ribeiro
Hello everybody! I'm currently working on a writeback connector screenshooter for Weston. In order to test it, I'm using VKMS with Rodrigo's writeback connector patch .Here is the link with the MR in Weston

drm: list_add corruption followed by BUG (stack guard page was hit)

2020-08-03 Thread Luis Henriques
Hi! I've just got the following WARNING followed by a BUG on rc7. Maybe it's already a known issue, but here it is anyway. Cheers, -- Luis [ 38.001304] [ cut here ] [ 38.001312] list_add corruption. prev->next should be next (8fe713397b88), but was

Re: [PATCH] vgacon: fix out of bounds write to the scrollback buffer

2020-08-03 Thread Daniel Vetter
On Mon, Aug 3, 2020 at 10:26 AM Greg KH wrote: > > On Mon, Aug 03, 2020 at 10:08:43AM +0200, Jiri Slaby wrote: > > Hi, > > > > On 31. 07. 20, 7:22, 张云海 wrote: > > > Remove whitespace at EOL > > > > I am fine with the patch. However it should be sent properly (inline > > mail, having a PATCH subjec

Re: [PATCH] vgacon: fix out of bounds write to the scrollback buffer

2020-08-03 Thread Greg KH
On Mon, Aug 03, 2020 at 10:45:07AM +0200, Daniel Vetter wrote: > On Mon, Aug 3, 2020 at 10:26 AM Greg KH wrote: > > > > On Mon, Aug 03, 2020 at 10:08:43AM +0200, Jiri Slaby wrote: > > > Hi, > > > > > > On 31. 07. 20, 7:22, 张云海 wrote: > > > > Remove whitespace at EOL > > > > > > I am fine with the

Re: [Nouveau] [PATCH] drm/nouveau/acr: fix a coding style in nvkm_acr_lsfw_load_bl_inst_data_sig()

2020-08-03 Thread Karol Herbst
Reviewed-by: Karol Herbst On Mon, Aug 3, 2020 at 5:46 AM Jing Xiangfeng wrote: > > This patch performs the following changes: > 1. remove a redundant parentheses around the nvkm_acr_lsfw_add() calls > 2. do assignment before this if condition, it is more readable > > Signed-off-by: Jing Xiangfe

Re: [PATCH 4/9] drm/msm/dsi: Add phy configuration for SDM630/636/660

2020-08-03 Thread Vinod Koul
On 26-07-20, 13:12, Konrad Dybcio wrote: > These SoCs make use of the 14nm phy, but at different > addresses than other 14nm units. > > Signed-off-by: Konrad Dybcio > --- > .../devicetree/bindings/display/msm/dsi.txt| 1 + > drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 ++ > drivers/

Re: [RFC][PATCH 2/2] dma-heap: Add a system-uncached heap

2020-08-03 Thread Robin Murphy
On 2020-07-29 06:16, John Stultz wrote: This adds a heap that allocates non-contiguous buffers that are marked as writecombined, so they are not cached by the CPU. This is useful, as most graphics buffers are usually not touched by the CPU or only written into once by the CPU. So when mapping th

Re: [PATCH] vgacon: fix out of bounds write to the scrollback buffer

2020-08-03 Thread Bartlomiej Zolnierkiewicz
On 8/3/20 11:47 AM, Greg KH wrote: > On Mon, Aug 03, 2020 at 10:45:07AM +0200, Daniel Vetter wrote: >> On Mon, Aug 3, 2020 at 10:26 AM Greg KH wrote: >>> >>> On Mon, Aug 03, 2020 at 10:08:43AM +0200, Jiri Slaby wrote: Hi, On 31. 07. 20, 7:22, 张云海 wrote: > Remove whitespace at E

Re: [PATCH 00/49] ttm mem manager refactoring.

2020-08-03 Thread Christian König
Am 03.08.20 um 09:12 schrieb Dave Airlie: On Fri, 31 Jul 2020 at 19:17, Christian König wrote: Am 31.07.20 um 06:04 schrieb Dave Airlie: I started pulling on a thread, and it led me down a hole. We might want to make that hole even bigger :) How about we rename the ttm_mem_reg into ttm_resou

Re: [PATCH] drm/nouveau: Drop mutex_lock_nested for atomic

2020-08-03 Thread Maarten Lankhorst
Op 02-08-2020 om 20:18 schreef Daniel Vetter: > Purely conjecture, but I think the original locking inversion with the > legacy page flip code between flipping and ttm's bo move function > shoudn't exist anymore with atomic: With atomic the bo pinning and > actual modeset commit is completely separ

Re: [PATCH] drm: fix drm_dp_mst_port refcount leaks in drm_dp_mst_allocate_vcpi

2020-08-03 Thread Nautiyal, Ankit K
Hi Xin Xong, I have seen insufficient vcpi ports issues with MST daisy chain. While running the IGT tests on MST, some times the vcpi ports are all used up. Due to this the atomic check fails and the flips start failing with ENOSPC. htt

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-08-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 --- Comment #115 from Duncan (1i5t5.dun...@cox.net) --- So 5.8.0 has been out for a few hours with the patch-fix, and I see Greg K-H has it applied to the 5.7 stable tree as well as 5.4 LTS (the bug was in 5.4 but latent, not exposed until develop

[PATCH] MAINTAINERS: enlist Greg formally for console stuff

2020-08-03 Thread Daniel Vetter
I did a few greps for main console data structures, and there's a few places outside of drivers/video/console: - a braille driver - a sisusbvga driver - fbcon, but I think that's fine if we leave that officially under fbdev maintainership - lots of stuff in drivers/tty/vt, which is already under

Re: [PATCH 2/2] dmabuf/tracing: Add dma-buf trace events

2020-08-03 Thread Steven Rostedt
On Mon, 3 Aug 2020 14:47:19 + Kalesh Singh wrote: > +DECLARE_EVENT_CLASS(dma_buf_ref_template, > + > + TP_PROTO(struct task_struct *task, struct file *filp), > + > + TP_ARGS(task, filp), > + > + TP_STRUCT__entry( > + __field(u32, tgid) > + __field(u32, pi

Re: [PATCH 4/9] drm/msm/dsi: Add phy configuration for SDM630/636/660

2020-08-03 Thread Rob Clark
On Mon, Aug 3, 2020 at 4:00 AM Vinod Koul wrote: > > On 26-07-20, 13:12, Konrad Dybcio wrote: > > These SoCs make use of the 14nm phy, but at different > > addresses than other 14nm units. > > > > Signed-off-by: Konrad Dybcio > > --- > > .../devicetree/bindings/display/msm/dsi.txt| 1 + > >

Re: Re: Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port

2020-08-03 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月3日 週一 下午6:43寫道: > > Hi > > Gesendet: Montag, 03. August 2020 um 01:47 Uhr > > Von: "Chun-Kuang Hu" > > > Now I just care about the bls to dpi. So in mediatek,disp.txt, you > > just need to add a Optional properties - port (input and output), and > > modify me

Re: [PATCH] omapfb/dss: Include the right header

2020-08-03 Thread Sam Ravnborg
On Mon, Jul 06, 2020 at 02:59:31PM +0200, Linus Walleij wrote: > The hdmi4.c and hdmi5.c files include the legacy GPIO > header but does not use any of the symbols > from this file. > > What it does use is the implicit inclusion of > leading to compile errors if we just drop this include. > > I

[PATCH v11 08/12] drm/msm: Set the global virtual address range from the IOMMU domain

2020-08-03 Thread Jordan Crouse
Use the aperture settings from the IOMMU domain to set up the virtual address range for the GPU. This allows us to transparently deal with IOMMU side features (like split pagetables). Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 13 +++-- drivers/gpu/drm/ms

[PATCH v11 00/12] iommu/arm-smmu: Add Adreno SMMU specific implementation

2020-08-03 Thread Jordan Crouse
This series adds an Adreno SMMU implementation to arm-smmu to allow GPU hardware pagetable switching. The Adreno GPU has built in capabilities to switch the TTBR0 pagetable during runtime to allow each individual instance or application to have its own pagetable. In order to take advantage of the

[PATCH v11 07/12] drm/msm: Add a context pointer to the submitqueue

2020-08-03 Thread Jordan Crouse
Each submitqueue is attached to a context. Add a pointer to the context to the submitqueue at create time and refcount it so that it stays around through the life of the queue. GPU submissions can access the active context via the submitqueue instead of requiring it to be passed around from functi

[PATCH v11 10/12] drm/msm: Add support for private address space instances

2020-08-03 Thread Jordan Crouse
Add support for allocating private address space instances. Targets that support per-context pagetables should implement their own function to allocate private address spaces. The default will return a pointer to the global address space. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/ms

[PATCH v11 11/12] drm/msm/a6xx: Add support for per-instance pagetables

2020-08-03 Thread Jordan Crouse
Add support for using per-instance pagetables if all the dependencies are available. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 53 +++ drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 + drivers/gpu/drm/msm/msm_ringbuffer.h | 1 + 3 files chang

[PATCH v11 09/12] drm/msm: Add support to create a local pagetable

2020-08-03 Thread Jordan Crouse
Add support to create a io-pgtable for use by targets that support per-instance pagetables. In order to support per-instance pagetables the GPU SMMU device needs to have the qcom,adreno-smmu compatible string and split pagetables enabled. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/msm

Re: [PATCH][next] fbdev: Use fallthrough pseudo-keyword

2020-08-03 Thread Sam Ravnborg
On Tue, Jul 07, 2020 at 04:05:39PM -0500, Gustavo A. R. Silva wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > [1] > https://www.kernel.org/doc/h

Re: [PATCH] video: fbdev: pvr2fb: initialize variables

2020-08-03 Thread Sam Ravnborg
Hi Tom, On Mon, Jul 20, 2020 at 12:18:45PM -0700, t...@redhat.com wrote: > From: Tom Rix > > clang static analysis reports this repesentative error > > pvr2fb.c:1049:2: warning: 1st function call argument > is an uninitialized value [core.CallAndMessage] > if (*cable_arg) > ^~

Re: [RFC][PATCH] regulator: rpi-panel: Add regulator/backlight driver for RPi panel

2020-08-03 Thread Mark Brown
On Mon, Aug 03, 2020 at 09:21:25AM +0200, Marek Vasut wrote: > On 8/1/20 3:16 AM, Mark Brown wrote: > > I see, so this is the remaining bits. Perhaps the binding might help me > > see how things fit together - I don't know anything about the system > > really. It's not doing anything that looks

Re: [PATCH][next] fbdev: Use fallthrough pseudo-keyword

2020-08-03 Thread Joe Perches
On Mon, 2020-08-03 at 21:41 +0200, Sam Ravnborg wrote: > On Tue, Jul 07, 2020 at 04:05:39PM -0500, Gustavo A. R. Silva wrote: > > Replace the existing /* fall through */ comments and its variants with > > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > > fall-through marking

Re: [PATCH][next] fbdev: Use fallthrough pseudo-keyword

2020-08-03 Thread Gustavo A. R. Silva
On 8/3/20 14:41, Sam Ravnborg wrote: > On Tue, Jul 07, 2020 at 04:05:39PM -0500, Gustavo A. R. Silva wrote: >> Replace the existing /* fall through */ comments and its variants with >> the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary >> fall-through markings when it is the c

Re: [PATCH][next] fbdev: Use fallthrough pseudo-keyword

2020-08-03 Thread Sam Ravnborg
On Mon, Aug 03, 2020 at 12:52:40PM -0700, Joe Perches wrote: > On Mon, 2020-08-03 at 21:41 +0200, Sam Ravnborg wrote: > > On Tue, Jul 07, 2020 at 04:05:39PM -0500, Gustavo A. R. Silva wrote: > > > Replace the existing /* fall through */ comments and its variants with > > > the new pseudo-keyword ma

[Bug 203905] amdgpu:actual_brightness has unreal/wrong value

2020-08-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203905 --- Comment #10 from Alexander Monakov (amona...@gmail.com) --- Proposed patch: https://lore.kernel.org/lkml/20200803200218.2167-1-amona...@ispras.ru/ -- You are receiving this mail because: You are watching the assignee of the bug.

[PATCH v5] Add support for KeemBay DRM driver

2020-08-03 Thread Anitha Chrisanthus
This is a new DRM driver for Intel's KeemBay SOC. The SoC couples an ARM Cortex A53 CPU with an Intel Movidius VPU. This driver is tested with the KMB EVM board which is the refernce baord for Keem Bay SOC. The SOC's display pipeline is as follows +--++-++-

[PATCH v2 10/24] virtio_gpu: correct tags for config space fields

2020-08-03 Thread Michael S. Tsirkin
Since gpu is a modern-only device, tag config space fields as having little endian-ness. Signed-off-by: Michael S. Tsirkin --- include/uapi/linux/virtio_gpu.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/uapi/linux/virtio_gpu.h b/include/uapi/linux/virtio_g

Re: linux-next: manual merge of the hmm tree with the drm tree

2020-08-03 Thread Ben Skeggs
On Tue, Aug 4, 2020 at 9:19 AM Jason Gunthorpe wrote: > > On Thu, Jul 30, 2020 at 10:31:45AM -0700, Ralph Campbell wrote: > > > > On 7/30/20 5:03 AM, Jason Gunthorpe wrote: > > > On Thu, Jul 30, 2020 at 07:21:10PM +1000, Stephen Rothwell wrote: > > > > Hi all, > > > > > > > > Today's linux-next me

Re: [PATCH 39/49] drm/ttm: make ttm_bo_man_init/takedown take type + args

2020-08-03 Thread Dave Airlie
On Fri, 31 Jul 2020 at 23:32, Christian König wrote: > > Am 31.07.20 um 06:05 schrieb Dave Airlie: > > From: Dave Airlie > > > > This makes it easier to move these to a driver allocated system > > No, sorry that looks like going into the wrong direction to me. > > I already wanted to suggest to g

gma500: monitor-dependent failure to boot FB console (psbdrmfb)

2020-08-03 Thread Thierry Moreau
Dear kernel / GPU enthusiasts! This list is listed in the kernel MAINTAINERS file for GMA500 GPU kernel module. My message is either a call for help (not a mission-critical issue) or troubleshooting information useful to fix an outstanding issue in the GMA500 kernel driver? This GMA3650-GP

Re: [PATCH 15/49] drm/ttm: make some inline helper functions for cleanup paths.

2020-08-03 Thread Dave Airlie
On Fri, 31 Jul 2020 at 23:07, Christian König wrote: > > Am 31.07.20 um 06:04 schrieb Dave Airlie: > > From: Dave Airlie > > > > Signed-off-by: Dave Airlie > > --- > > drivers/gpu/drm/ttm/ttm_bo.c| 6 ++ > > include/drm/ttm/ttm_bo_driver.h | 12 > > 2 files changed, 14

[00/59] ttm misc cleanups, mem refactoring, rename objects. (v2)

2020-08-03 Thread Dave Airlie
I've decided to repost the whole queue this time, it has a few driver patches up front that are just cleanups. I've reorodered things a little since the first posting, but not much. misc core/driver cleanups mem type manager debug callback cleanup (reordered) new mem type manager init path new me

[PATCH 05/59] drm/ttm/amdgpu: consolidate ttm reserve paths

2020-08-03 Thread Dave Airlie
From: Dave Airlie Drop the WARN_ON and consolidate the two paths into one. Use the consolidate slowpath in the execbuf utils code. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +- drivers/gpu/drm/ttm/ttm_execbuf_util.c | 12 +-- include/drm/ttm/ttm_bo_dri

[PATCH 04/59] qxl/ttm: drop the unusued no wait flag to reserve function

2020-08-03 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/qxl/qxl_cmd.c| 2 +- drivers/gpu/drm/qxl/qxl_ioctl.c | 2 +- drivers/gpu/drm/qxl/qxl_object.c | 4 ++-- drivers/gpu/drm/qxl/qxl_object.h | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 13/59] drm/ttm: split the mm manager init code (v2)

2020-08-03 Thread Dave Airlie
From: Dave Airlie This will allow the driver to control the ordering here better. Eventually the old path will be removed. v2: add docs for new APIs. rename new path to ttm_mem_type_manager_init/set_used(for now) Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c| 34 +++

[PATCH 16/59] drm/radeon: use new ttm man init path

2020-08-03 Thread Dave Airlie
From: Dave Airlie Use the new common manager init path. Signed-off-by: Dave Airlie --- drivers/gpu/drm/radeon/radeon_ttm.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index 0b07d8ed6ed

[PATCH 09/59] drm/nouveau/ttm: don't fill in blank ttm debug callback

2020-08-03 Thread Dave Airlie
From: Dave Airlie Acked-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c index b0012021ae12..6de762a0c229 100644 --

[PATCH 10/59] drm/vmwgfx/gmrid: don't provide pointless ttm debug callback

2020-08-03 Thread Dave Airlie
From: Dave Airlie Acked-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c b/drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c index 4a76fc7114ad..

[PATCH 12/59] drm/vram-helper: call the ttm manager debug function

2020-08-03 Thread Dave Airlie
From: Dave Airlie This code was assuming there was a drm_mm here, don't do that call the correct API. v2: use the new exported interface. Signed-off-by: Dave Airlie --- drivers/gpu/drm/drm_gem_vram_helper.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/

[PATCH 08/59] drm/ttm: export memory type debug entrypoint.

2020-08-03 Thread Dave Airlie
From: Dave Airlie As suggested on review, just export the memory type debug for drivers to use, while also making the debug callback optional (don't need to test for system as it won't init it). rename it to be more consistent with object name for now. (we may rename all the objects later.) Sig

[PATCH 15/59] drm/amdgpu/ttm: init managers from the driver side.

2020-08-03 Thread Dave Airlie
From: Dave Airlie Use new init calls to unwrap manager init Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 19 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 37 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 4 +-- drivers/gpu/dr

[PATCH 21/59] drm/vmwgfx/ttm: switch gmrid allocator to new init paths.

2020-08-03 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 17 --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 21 --- 3 files changed, 19 insertions(+), 21 deletions(-)

[PATCH 03/59] nouveau: use ttm populate mapping functions. (v2)

2020-08-03 Thread Dave Airlie
From: Dave Airlie Instead of rolling driver copies of them. v2: cleanup return handling (Ben) Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_bo.c | 38 ++-- 1 file changed, 2 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo

[PATCH 14/59] drm/ttm: provide a driver-led init path for range mm manager. (v2)

2020-08-03 Thread Dave Airlie
From: Dave Airlie This lets the generic range mm manager be initialised by the driver. v2: add docs. rename api to range_man_init for now. v1-Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo_manager.c | 23 --- include/drm/ttm/ttm_bo_

[PATCH 02/59] drm/vmwgfx: drop bo map/unmap dma functions.

2020-08-03 Thread Dave Airlie
From: Dave Airlie The map one was used once, just inline it, and drop them both. Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h| 2 - drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 46 +++--- 2 files changed, 6 insertions(+), 42 deletions(-) diff --g

[PATCH 06/59] drm/ttm: use a helper for unlocked moves to the lru tail

2020-08-03 Thread Dave Airlie
From: Dave Airlie The pattern was repeated a few times, just make an inline for it. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c| 8 ++-- drivers/gpu/drm/ttm/ttm_bo_vm.c | 4 +--- include/drm/ttm/ttm_bo_driver.h | 11 --- 3 files changed, 11 insertions(+), 12 d

[PATCH 01/59] drm/vmwgfx: consolidate ttm object creation and populate

2020-08-03 Thread Dave Airlie
From: Dave Airlie These two functions has the same code in them, create a common helper function instead. Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h| 4 ++ drivers/gpu/drm/vmwgfx/vmwgfx_mob.c| 60 ++ drivers/gpu/drm/vmwgfx/vmwgfx_ttm

[PATCH 19/59] drm/nouveau: use new memory manager init paths

2020-08-03 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 43 --- 1 file changed, 19 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c index 6de762a0c229..cfcbecd332e

[PATCH 17/59] drm/qxl/ttm: use new init path for manager

2020-08-03 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/qxl/qxl_ttm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c index 3e664bb58764..bfbd2c5c38a2 100644 --- a/drivers/gpu/drm/qxl/qxl_ttm.c +++ b/dr

[PATCH 07/59] drm/vram-helper: remove populate/unpopulate

2020-08-03 Thread Dave Airlie
From: Dave Airlie The default path for populate/unpopulate is already this. Signed-off-by: Dave Airlie --- drivers/gpu/drm/drm_gem_vram_helper.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c index 5f03c6137ef

[PATCH 20/59] drm/vmwgfx/ttm: convert vram mm init to new code paths

2020-08-03 Thread Dave Airlie
From: Dave Airlie Split out the vram thp init path vs the range manager init. Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 25 +++-- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 4 +--- drivers/gpu/drm/vmwgfx/vmwgfx_thp.c | 12 3 files changed

[PATCH 18/59] drm/vram_helper: use new ttm manager init function

2020-08-03 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/drm_gem_vram_helper.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c index c20aee2fddf3..d7c0fdf82eb6 100644 --- a/drivers/gpu/d

[PATCH 27/59] drm/amdgpu/ttm: use new takedown path

2020-08-03 Thread Dave Airlie
From: Dave Airlie Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 15 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu

[PATCH 24/59] drm/ttm: pass man around instead of mem_type in some places

2020-08-03 Thread Dave Airlie
From: Dave Airlie This makes it easier to cleanup things Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c inde

[PATCH 22/59] drm/ttm: convert system manager init to new code.

2020-08-03 Thread Dave Airlie
From: Dave Airlie Remove the exit path, since this can't fail now. Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drive

[PATCH 31/59] drm/radeon/ttm: use new takedown paths

2020-08-03 Thread Dave Airlie
From: Dave Airlie Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index 84c02b4529c0..76b409af9476

[PATCH 39/59] drm/nouveau/ttm: use wrapper to access memory managers

2020-08-03 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c index bb310719e3f5..cc6cf04553dd 100644 --- a/drivers

[PATCH 30/59] drm/nouveau: use new cleanup paths

2020-08-03 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 41 --- 1 file changed, 30 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c index cfcbecd332ef..bb310719e3f

[PATCH 11/59] drm/qxl/ttm: call ttm manager debug (v2)

2020-08-03 Thread Dave Airlie
From: Dave Airlie v2: use the new exported interface. This code was poking inside a struct and assuming it was a drm_mm at the start. Call the proper API. Signed-off-by: Dave Airlie --- drivers/gpu/drm/qxl/qxl_ttm.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a

[PATCH 40/59] drm/qxl/ttm: use wrapper to access memory manager

2020-08-03 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/qxl/qxl_ttm.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c index 0f7071829056..57c96f7271db 100644 --- a/drivers/gpu/drm/qxl/qxl_ttm.

[PATCH 33/59] drm/vmwgfx: fix gmrid takedown paths to new interface

2020-08-03 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 9 - drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 1 + drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 11 --- 3 files changed, 13 insertions(+), 8 deletions(-) diff --git a/dr

[PATCH 32/59] drm/qxl/ttm: use new takedown path

2020-08-03 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/qxl/qxl_ttm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c index bfbd2c5c38a2..0f7071829056 100644 --- a/drivers/gpu/drm/qxl/qxl_ttm.c +++ b/

[PATCH 42/59] drm/vmwgfx/ttm: use wrapper to access memory manager

2020-08-03 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 23 +++ drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_thp.c | 4 ++-- 3 files changed, 18 insertions(+), 13 deletions(-) diff --g

[PATCH 35/59] drm/ttm: make TTM responsible for cleaning system only.

2020-08-03 Thread Dave Airlie
From: Dave Airlie Drivers should all be cleaning up their memory managers themselves now, so let the core just clean the system one up. Remove the legacy cleaning interface. Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c| 54 +++--

[PATCH 37/59] drm/amdgfx/ttm: use wrapper to get ttm memory managers

2020-08-03 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 12 +-- drivers/gpu/d

  1   2   >