Re: [PATCH 8/8] drm/mgag200: Add support for G200 desktop cards

2020-07-20 Thread Thomas Zimmermann
Hi Am 17.07.20 um 00:43 schrieb Lyude Paul: > On Wed, 2020-07-15 at 16:59 +0200, Thomas Zimmermann wrote: >> This patch adds support for G200 desktop cards. We can reuse the whole >> memory and modesetting code. A few PCI and DAC register values have to >> be updated accordingly. >> >> The most si

Re: [PATCH] drm/i810: switch from 'pci_' to 'dma_' API

2020-07-20 Thread Daniel Vetter
On Sat, Jul 18, 2020 at 09:28:22AM +0200, Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. >

[bug report] drm/ingenic: Add support for the IPU

2020-07-20 Thread dan.carpenter
Hello Paul Cercueil, The patch fc1acf317b01: "drm/ingenic: Add support for the IPU" from Jul 16, 2020, leads to the following static checker warning: drivers/gpu/drm/ingenic/ingenic-drm-drv.c:232 ingenic_drm_crtc_atomic_check() error: potentially dereferencing uninitialized 'ipu_

Re: [bug report] drm/ingenic: Add support for the IPU

2020-07-20 Thread Dan Carpenter
On Mon, Jul 20, 2020 at 10:22:37AM +0300, dan.carpen...@oracle.com wrote: > Hello Paul Cercueil, > > The patch fc1acf317b01: "drm/ingenic: Add support for the IPU" from > Jul 16, 2020, leads to the following static checker warning: > > drivers/gpu/drm/ingenic/ingenic-drm-drv.c:232 > ingeni

[PATCH] drm/amd/powerplay: fix a crash when overclocking Vega M

2020-07-20 Thread Qiu Wenbo
Avoid kernel crash when vddci_control is SMU7_VOLTAGE_CONTROL_NONE and vddci_voltage_table is empty. It has been tested on Intel Hades Canyon (i7-8809G). Bug: https://bugzilla.kernel.org/show_bug.cgi?id=208489 Fixes: ac7822b0026f ("drm/amd/powerplay: add smumgr support for VEGAM (v2)") Signed-off-

[PATCH 1/5] drm: rockchip: add scaling for RK3036 win1

2020-07-20 Thread Alex Bee
This patch adds register definitions needed to make scaling work on RK3036's win1. Signed-off-by: Alex Bee --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm

[PATCH 4/4] [DO NOT MERGE] arm64: allwinner: dts: a64: enable K101-IM2BYL02 panel for PineTab

2020-07-20 Thread Icenowy Zheng
Newer PineTab may switch to K101-IM2BYL02. Signed-off-by: Icenowy Zheng --- arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pineta

[PATCH for v5.9] video: fbdev: Replace HTTP links with HTTPS ones

2020-07-20 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

[PATCH 2/5] drm: rockchip: add missing registers for RK3188

2020-07-20 Thread Alex Bee
This patch adds dither_up, dsp_lut_en, data_blank and dsp_data_swap registers to enable their respective functionality for RK3188's VOP. Signed-off-by: Alex Bee --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockch

Re: [PATCH 0/2] Fix st7703 panel initialization failures

2020-07-20 Thread Ondřej Jirman
Hello, On Sat, Jul 18, 2020 at 07:31:24PM +0200, Guido Günther wrote: > Hi, > On Thu, Jul 16, 2020 at 04:32:09PM +0200, Ondřej Jirman wrote: > > Hi Guido, > > > > On Thu, Jul 16, 2020 at 04:08:43PM +0200, Guido Günther wrote: > > > Hi Ondrej, > > > On Thu, Jul 16, 2020 at 02:37:51PM +0200, Ondrej

Re: [PATCH v2] drm/omap: force runtime PM suspend on system suspend

2020-07-20 Thread Tony Lindgren
* Tomi Valkeinen [200618 09:53]: > Use SET_LATE_SYSTEM_SLEEP_PM_OPS in DSS submodules to force runtime PM > suspend and resume. > > We use suspend late version so that omapdrm's system suspend callback is > called first, as that will disable all the display outputs after which > it's safe to forc

Re: [PATCH] RFC: ACPI / OSI: remove workarounds for hybrid graphics laptops

2020-07-20 Thread Alex Hung
On 2020-07-17 1:05 p.m., Karol Herbst wrote: > It's hard to figure out what systems are actually affected and right now I > don't see a good way of removing those... > > But I'd like to see thos getting removed and drivers fixed instead (which > happened at least for nouveau). > > And as mentione

[PATCH 3/5] drm: rockchip: add alpha support for RK3036, RK3066, RK3126 and RK3188

2020-07-20 Thread Alex Bee
With commit 2aae8ed1f390 ("drm/rockchip: Add per-pixel alpha support for the PX30 VOP") alpha support was introduced for PX30's VOP. RK3036, RK3066, RK3126 and RK3188 VOPs support alpha blending in the same manner. With the exception of RK3066 all of them support pre-multiplied alpha. This patch a

Re: [PATCH] drm: sun4i: hdmi: Fix inverted HPD result

2020-07-20 Thread Maxime Ripard
On Sat, Jul 11, 2020 at 09:10:30AM +0800, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai > > When the extra HPD polling in sun4i_hdmi was removed, the result of > HPD was accidentally inverted. > > Fix this by inverting the check. > > Fixes: bda8eaa6dee7 ("drm: sun4i: hdmi: Remove extra HPD polling")

[PATCH] drm/ingenic: Silence uninitialized-variable warning

2020-07-20 Thread Paul Cercueil
Silence compiler warning about used but uninitialized 'ipu_state' variable. In practice, the variable would never be used when uninitialized, but the compiler cannot know that 'priv->ipu_plane' will always be NULL if CONFIG_INGENIC_IPU is disabled. Silence the warning by initializing the value to

Re: [PATCH] RFC: ACPI / OSI: remove workarounds for hybrid graphics laptops

2020-07-20 Thread Alex Hung
On 2020-07-19 1:50 p.m., Karol Herbst wrote: > On Fri, Jul 17, 2020 at 9:52 PM Alex Hung wrote: >> >> On 2020-07-17 1:05 p.m., Karol Herbst wrote: >>> It's hard to figure out what systems are actually affected and right now I >>> don't see a good way of removing those... >>> >>> But I'd like to se

Re: [PATCH] drm/mxsfb: Make supported modifiers explicit

2020-07-20 Thread Daniel Vetter
On Sat, Jul 18, 2020 at 07:14:07PM +0200, Guido Günther wrote: > Hi, > On Mon, Mar 23, 2020 at 04:51:05PM +0100, Lucas Stach wrote: > > Am Montag, den 23.03.2020, 15:52 +0100 schrieb Guido Günther: > > > In contrast to other display controllers on imx like DCSS and ipuv3 > > > lcdif/mxsfb does not

[PATCH 0/4] Add support for Feixin K101-IM2BYL02 panel

2020-07-20 Thread Icenowy Zheng
The controller chip of Feixin K101-IM2BA02 is going to be discontinued, so Feixin start to provide K101-IM2BYL02 panel as a replacement, which utilizes Ilitek ILI9881C controller. Add support for K101-IM2BYL02 panel. By the way, is there a way that can try both kind of panels in the same kernel/D

[PATCH 5/5] drm: rockchip: use overlay windows as such

2020-07-20 Thread Alex Bee
As stated in the comment for rk3288_vop_win_data windows that are supposed to be an overlay window are missused as HWC windows due to the missing implementation of that window type in VOP driver. This is also true for RK3036, RK3126, RK3188 and RK3228 VOPs which all have at least one dedicated HWC

[PATCH v2] drm: core: Convert device logging to drm_* functions.

2020-07-20 Thread Suraj Upadhyay
Convert device logging with dev_* functions into drm_* functions. The patch has been generated with the coccinelle script below. The script focuses on instances of dev_* functions where the drm device context is clearly visible in its arguments. @@expression E1; expression list E2; @@ -dev_warn(E

[PATCH 4/5] drm: rockchip: set alpha_en to 0 if it is not used

2020-07-20 Thread Alex Bee
alpha_en should be set to 0 if it is not used, i.e. to disable alpha blending if it was enabled before and should be disabled now. fixes: 2aae8ed1f390 ("drm/rockchip: Add per-pixel alpha support for the PX30 VOP") Signed-off-by: Alex Bee --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 + 1

[PATCH for v5.9] dt-bindings: drm/bridge: Replace HTTP links with HTTPS ones

2020-07-20 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

Re: [PATCH] drm: core: Convert device logging to drm_* functions.

2020-07-20 Thread Suraj Upadhyay
On Sat, Jul 18, 2020 at 08:25:31PM +0530, Suraj Upadhyay wrote: > Convert device logging with dev_* functions into drm_* functions. > > The patch has been generated with the coccinelle script below. > The script focuses on instances of dev_* functions where the drm device > context is clearly visi

Re: [PATCH v11 0/4] Panel rotation patches

2020-07-20 Thread Dmitry Osipenko
18.06.2020 02:18, Dmitry Osipenko пишет: > Hello! > > This series adds support for display panel's DT rotation property. It's a > continuation of the work that was initially started by Derek Basehore for > the panel driver that is used by some Mediatek device [1]. I picked up the > Derek's patches

[PATCH for v5.9] drm: Replace HTTP links with HTTPS ones

2020-07-20 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

Re: [PATCH] drm/msm/dpu: fix/enable 6bpc dither with split-lm

2020-07-20 Thread Steev Klimaszewski
Hi, On 7/15/20 5:19 PM, Rob Clark wrote: > From: Rob Clark > > If split-lm is used (for ex, on sdm845), we can have multiple ping- > pongs, but only a single phys encoder. We need to configure dithering > on each of them. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_e

[PATCH 2/4] dt-bindings: ili9881c: add compatible string for Feixin K101-IM2BYL02

2020-07-20 Thread Icenowy Zheng
Feixin K101-IM2BYL02 is a drop-in replacement of K101-IM2BA02 panel (which is already supported by panel-feixin-k101-im2ba02 driver) with the same pinout. It utilizes an Ilitek ILI9881C controller chip, so its compatible string should be added to ilitek,ili9881c file. Add the compatible string for

Re: [PATCH] drm/ingenic: Silence uninitialized-variable warning

2020-07-20 Thread Paul Cercueil
Hi Sam, Le dim. 19 juil. 2020 à 12:23, Sam Ravnborg a écrit : Hi Paul. On Sun, Jul 19, 2020 at 11:38:34AM +0200, Paul Cercueil wrote: Silence compiler warning about used but uninitialized 'ipu_state' variable. In practice, the variable would never be used when uninitialized, but the compi

[PATCH 3/4] drm/panel: ilitek-ili9881c: add support for Feixin K101-IM2BYL02 panel

2020-07-20 Thread Icenowy Zheng
Feixin K101-IM2BYL02 is a new panel by Feixin designed as a replacement to their K101-IM2BA02 panel. This panel utilizes the Ilitek ILI9881C controller. Add this panel's initialzation sequence and timing to ILI9881C driver. Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/panel/panel-ilitek-ili

Re: [PATCH -next] drm/komeda: Convert to DEFINE_SHOW_ATTRIBUTE

2020-07-20 Thread miaoqinglang
在 2020/7/17 15:06, Daniel Vetter 写道: On Fri, Jul 17, 2020 at 8:40 AM james qian wang (Arm Technology China) wrote: On Thu, Jul 16, 2020 at 05:03:33PM +0800, Qinglang Miao wrote: From: Liu Shixin Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Liu Shixin --- driver

[PATCH for v5.9] drm/tilcdc: Replace HTTP links with HTTPS ones

2020-07-20 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

[PATCH] drm/i810: switch from 'pci_' to 'dma_' API

2020-07-20 Thread Christophe JAILLET
The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated in 'i810_dma_initialize()' GFP_KERNEL can be used becau

[PATCH 1/4] drm/panel: ilitek-ili9881c: prepare for adding support for extra panels

2020-07-20 Thread Icenowy Zheng
There're more panels with ILI9881C controller than the Bananapi one supported by this driver. Extract the mode and init sequence part, to prepare the driver for adding new panels. Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 56 --- 1 file cha

[PATCH 0/5] drm: rockchip: various ports for older VOPs

2020-07-20 Thread Alex Bee
This series mainly ports existining functionality to older SoCs - most importantly enables alpha blending for RK3036, RK3066, RK3126 and RK3188. Besides that, it also changes the window type from DRM_PLANE_TYPE_CURSOR to DRM_PLANE_TYPE_OVERLAY for VOPs that have only one overlay window. Alex Bee (

[PATCH for v5.9] ARM: dts: mxs: Replace HTTP links with HTTPS ones

2020-07-20 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

[PATCH] drm: core: Convert device logging to drm_* functions.

2020-07-20 Thread Suraj Upadhyay
Convert device logging with dev_* functions into drm_* functions. The patch has been generated with the coccinelle script below. The script focuses on instances of dev_* functions where the drm device context is clearly visible in its arguments. @@expression E1; expression list E2; @@ -dev_warn(E

Re: [PATCH v2 0/6] drm/ast: Managed MM

2020-07-20 Thread Thomas Zimmermann
Am 16.07.20 um 15:24 schrieb Sam Ravnborg: > Hi Thomas. > > On Thu, Jul 16, 2020 at 02:53:47PM +0200, Thomas Zimmermann wrote: >> This is the second patchset for converting ast to managed DRM interfaces. >> This one addresses memory management. There will be another, final round >> of patches fo

Re: [PATCH v2] drm: core: Convert device logging to drm_* functions.

2020-07-20 Thread Daniel Vetter
On Sat, Jul 18, 2020 at 08:39:55PM +0530, Suraj Upadhyay wrote: > Convert device logging with dev_* functions into drm_* functions. > > The patch has been generated with the coccinelle script below. > The script focuses on instances of dev_* functions where the drm device > context is clearly visi

Re: [PATCH for v5.9] video: fbdev: Replace HTTP links with HTTPS ones

2020-07-20 Thread Daniel Vetter
On Sun, Jul 19, 2020 at 10:37:14PM +0200, Alexander A. Klimov wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn

Re: [bug report] drm/ingenic: Add support for the IPU

2020-07-20 Thread Daniel Vetter
On Mon, Jul 20, 2020 at 10:22:37AM +0300, dan.carpen...@oracle.com wrote: > Hello Paul Cercueil, > > The patch fc1acf317b01: "drm/ingenic: Add support for the IPU" from > Jul 16, 2020, leads to the following static checker warning: > > drivers/gpu/drm/ingenic/ingenic-drm-drv.c:232 > ingeni

Re: [PATCH v5 14/19] backlight: cr_bllcd: introduce gpio-backlight semantics

2020-07-20 Thread Daniel Thompson
On Sun, Jul 19, 2020 at 10:07:38AM +0200, Sam Ravnborg wrote: > cr_bllcd can turn backlight ON or OFF. > Fix semantitics so they equals what we know from gpio-backlight. > brightness == 0 => backlight off > brightness == 1 => backlight on > > Use the backlight_get_brightness() helper to simpli

Re: [PATCH] drm/mxsfb: miss err handle in probe

2020-07-20 Thread Stefan Agner
On 2020-06-11 14:23, Bernard Zhao wrote: > There are three err return values in drm_fbdev_generic_setup. > In mxsfb_probe we called this function, but didn`t handle the > return value, this change is to add err handle, maybe make code > a bit more readable. This got recently changed, so I guess ch

Re: [PATCH] drm/mxsfb: Make supported modifiers explicit

2020-07-20 Thread Stefan Agner
On 2020-07-18 19:14, Guido Günther wrote: > Hi, > On Mon, Mar 23, 2020 at 04:51:05PM +0100, Lucas Stach wrote: >> Am Montag, den 23.03.2020, 15:52 +0100 schrieb Guido Günther: >> > In contrast to other display controllers on imx like DCSS and ipuv3 >> > lcdif/mxsfb does not support detiling e.g. vi

Re: [PATCH] drm/mxsfb: drop unused function parameter

2020-07-20 Thread Stefan Agner
On 2020-07-16 19:41, Uwe Kleine-König wrote: > flags is unused since the driver was introduced in commit 45d59d704080 > ("drm: Add new driver for MXSFB controller"). Applied to drm-misc-next. Thanks. -- Stefan > > Signed-off-by: Uwe Kleine-König > --- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 +

Re: [PATCH v5 14/19] backlight: cr_bllcd: introduce gpio-backlight semantics

2020-07-20 Thread Sam Ravnborg
On Mon, Jul 20, 2020 at 09:48:22AM +0100, Daniel Thompson wrote: > On Sun, Jul 19, 2020 at 10:07:38AM +0200, Sam Ravnborg wrote: > > cr_bllcd can turn backlight ON or OFF. > > Fix semantitics so they equals what we know from gpio-backlight. > > brightness == 0 => backlight off > > brightness == 1

Re: [PATCH v5 0/19] backlight: backlight updates

2020-07-20 Thread Lee Jones
On Sun, 19 Jul 2020, Sam Ravnborg wrote: > Hi all. > > Follow-up on v4 - with only a few changes listed below and > in the individual patches. > Thanks for all the reviews and the feedback on the patches! > > I am planning a follow-up on this patchset to update the > backlight drivers all over t

Re: SM750 : from which driver should I start to add a new transmitter ?

2020-07-20 Thread Sudip Mukherjee
HI Gilles, (Added fbdev and dri list) On Mon, Jul 20, 2020 at 10:18 AM Gilles Buloz wrote: > > Dear developers, > > > My company is manufacturing M2 graphics modules based on SM750. and I need to > add support for an ANX9404 transmitter (for DP). I'm wondering which driver > you would recommend

Re: [PATCH] drm/mxsfb: Make supported modifiers explicit

2020-07-20 Thread Guido Günther
Hi, On Mon, Jul 20, 2020 at 11:03:04AM +0200, Stefan Agner wrote: > On 2020-07-18 19:14, Guido Günther wrote: > > Hi, > > On Mon, Mar 23, 2020 at 04:51:05PM +0100, Lucas Stach wrote: > >> Am Montag, den 23.03.2020, 15:52 +0100 schrieb Guido Günther: > >> > In contrast to other display controllers o

Re: [PATCH] RFC: ACPI / OSI: remove workarounds for hybrid graphics laptops

2020-07-20 Thread Karol Herbst
On Mon, Jul 20, 2020 at 3:19 AM Alex Hung wrote: > > On 2020-07-19 1:50 p.m., Karol Herbst wrote: > > On Fri, Jul 17, 2020 at 9:52 PM Alex Hung wrote: > >> > >> On 2020-07-17 1:05 p.m., Karol Herbst wrote: > >>> It's hard to figure out what systems are actually affected and right now I > >>> don'

Re: [PATCH v5 0/19] backlight: backlight updates

2020-07-20 Thread Sam Ravnborg
Hi Lee. On Mon, Jul 20, 2020 at 10:36:01AM +0100, Lee Jones wrote: > On Sun, 19 Jul 2020, Sam Ravnborg wrote: > > > Hi all. > > > > Follow-up on v4 - with only a few changes listed below and > > in the individual patches. > > Thanks for all the reviews and the feedback on the patches! > > > > I

Re: [PATCH 2/8] drm/radeon: stop using TTM_MEMTYPE_FLAG_MAPPABLE

2020-07-20 Thread Christian König
Am 19.07.20 um 14:57 schrieb Chauhan, Madhav: [AMD Public Use] -Original Message- From: Christian König Sent: Thursday, July 16, 2020 6:21 PM To: dri-devel@lists.freedesktop.org Cc: Chauhan, Madhav Subject: [PATCH 2/8] drm/radeon: stop using TTM_MEMTYPE_FLAG_MAPPABLE The driver doesn'

Re: [PATCH 1/8] drm/ttm: remove TTM_MEMTYPE_FLAG_CMA

2020-07-20 Thread Christian König
Am 16.07.20 um 15:05 schrieb Thomas Zimmermann: Hi, this patchset could have benefited from a cover letter. Yeah, I didn't thought it would result in such an extensive patch set. Am 16.07.20 um 14:50 schrieb Christian König: The original intention was to avoid CPU page table unmaps when BOs

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-20 Thread Intel
Hi, On 7/9/20 2:33 PM, Daniel Vetter wrote: Comes up every few years, gets somewhat tedious to discuss, let's write this down once and for all. What I'm not sure about is whether the text should be more explicit in flat out mandating the amdkfd eviction fences for long running compute workloads

[PATCH] drm: fix drm_dp_mst_port refcount leaks in drm_dp_mst_allocate_vcpi

2020-07-20 Thread Xin Xiong
drm_dp_mst_allocate_vcpi() invokes drm_dp_mst_topology_get_port_validated(), which increases the refcount of the "port". These reference counting issues take place in two exception handling paths separately. Either when “slots” is less than 0 or when drm_dp_init_vcpi() returns a negative value, th

[PATCH v5 0/5] Asynchronous flip implementation for i915

2020-07-20 Thread Karthik B S
Without async flip support in the kernel, fullscreen apps where game resolution is equal to the screen resolution, must perform an extra blit per frame prior to flipping. Asynchronous page flips will also boost the FPS of Mesa benchmarks. v2: -Few patches have been squashed and patches have been

[PATCH v5 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-07-20 Thread Karthik B S
Add enable/disable flip done functions and the flip done handler function which handles the flip done interrupt. Enable the flip done interrupt in IER. Enable flip done function is called before writing the surface address register as the write to this register triggers the flip done interrupt F

[PATCH v5 2/5] drm/i915: Add support for async flips in I915

2020-07-20 Thread Karthik B S
Set the Async Address Update Enable bit in plane ctl when async flip is requested. v2: -Move the Async flip enablement to individual patch (Paulo) v3: -Rebased. v4: -Add separate plane hook for async flip case (Ville) v5: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni -

[PATCH v5 4/5] drm/i915: Do not call drm_crtc_arm_vblank_event in async flips

2020-07-20 Thread Karthik B S
Since the flip done event will be sent in the flip_done_handler, no need to add the event to the list and delay it for later. v2: -Moved the async check above vblank_get as it was causing issues for PSR. v3: -No need to wait for vblank to pass, as this wait was causing a 16ms delay once

[PATCH v5 5/5] drm/i915: Enable async flips in i915

2020-07-20 Thread Karthik B S
Enable asynchronous flips in i915 for gen9+ platforms. v2: -Async flip enablement should be a stand alone patch (Paulo) v3: -Move the patch to the end of the serires (Paulo) v4: -Rebased. v5: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/displ

[PATCH v5 3/5] drm/i915: Add checks specific to async flips

2020-07-20 Thread Karthik B S
Support added only for async flips on primary plane. If flip is requested on any other plane, reject it. Make sure there is no change in fbc, offset and framebuffer modifiers when async flip is requested. If any of these are modified, reject async flip. v2: -Replace DRM_ERROR (Paulo) -Add ch

Re: [PATCH v6 2/4] drm/imx: Add initial support for DCSS on iMX8MQ

2020-07-20 Thread Laurentiu Palcu
Hi Sam, On Fri, Jul 17, 2020 at 09:48:49PM +0200, Sam Ravnborg wrote: > Hi Laurentiu. > > On Fri, Jul 17, 2020 at 05:41:27PM +0300, Laurentiu Palcu wrote: > > From: Laurentiu Palcu > > > > This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS). > > Some of its capabilities i

[PATCH] drm/msm: dsi: dev_pm_opp_put_clkname() only when an opp_table exists

2020-07-20 Thread Rajendra Nayak
Its possible for msm_dsi_host_init() to fail early, before dev_pm_opp_set_clkname() is called. In such cases, unconditionally calling dev_pm_opp_put_clkname() in msm_dsi_host_destroy() results in a crash. Put an additional check so that dev_pm_opp_put_clkname() is called only when an opp_table exis

[PATCH] drm/msm/dpu: dev_pm_opp_put_clkname() only when an opp_table exists

2020-07-20 Thread Rajendra Nayak
Its possible that dpu_bind() fails early enough before dev_pm_opp_set_clkname() is called. In such cases, unconditionally calling dev_pm_opp_put_clkname() in dpu_unbind() can result in a crash. Put an additional check so that dev_pm_opp_put_clkname() is called only when an opp_table exists. Fixes:

[PATCH] drm/bridge/adv7511: set the bridge type properly

2020-07-20 Thread Laurentiu Palcu
From: Laurentiu Palcu After the drm_bridge_connector_init() helper function has been added, the ADV driver has been changed accordingly. However, the 'type' field of the bridge structure was left unset, which makes the helper function always return -EINVAL. Signed-off-by: Laurentiu Palcu --- Hi

[PATCH v2] drm: pl111: Update documentation

2020-07-20 Thread Linus Walleij
Remove notes about migrating from the old driver which is retired as all users are now migrated. Update the text to reflect that we support PL110 and PL111 alike. Drop the bullet on memory bandwidth scaling: this has been implemented. Cc: Russell King Signed-off-by: Linus Walleij --- ChangeLog

Re: [PATCH RESEND] drm/imx: imx-ldb: Disable both channels for split mode in enc->disable()

2020-07-20 Thread Philipp Zabel
On Thu, 2020-07-09 at 10:28 +0800, Liu Ying wrote: > Both of the two LVDS channels should be disabled for split mode > in the encoder's ->disable() callback, because they are enabled > in the encoder's ->enable() callback. > > Fixes: 6556f7f82b9c ("drm: imx: Move imx-drm driver out of staging") >

Re: [PATCH 1/2] drm/imx: fix use after free

2020-07-20 Thread Philipp Zabel
On Thu, 2020-06-11 at 14:43 +0200, Marco Felsch wrote: > From: Philipp Zabel > > Component driver structures allocated with devm_kmalloc() in bind() are > freed automatically after unbind(). Since the contained drm structures > are accessed afterwards in drm_mode_config_cleanup(), move the > allo

Re: [PATCH] drm/imx: imx-tve: Delete an error message in imx_tve_bind()

2020-07-20 Thread Philipp Zabel
On Sun, 2020-04-05 at 11:16 +0200, Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 5 Apr 2020 11:01:49 +0200 > > The function “platform_get_irq” can log an error already. > Thus omit a redundant message for the exception handling in the > calling function. > > This issue was detected b

[PATCH] drm/v3d: remove second free in v3d_submit_cl_ioctl

2020-07-20 Thread trix
From: Tom Rix clang static analysis reports this error v3d_gem.c:573:4: warning: Attempt to free released memory [unix.Malloc] kfree(bin); ^~ Problem is in the block of code if (ret) { kfree(bin); v3d_job_put(&render->base);

Re: [PATCH v5 0/6] Add support for GPU DDR BW scaling

2020-07-20 Thread Rob Clark
On Mon, Jul 20, 2020 at 3:01 AM Viresh Kumar wrote: > > On 15-07-20, 08:36, Rob Clark wrote: > > I can take the first two into msm-next, the 3rd will need to wait > > until dev_pm_opp_set_bw() lands > > You can base that on a8351c12c6c7 in linux-next, I will make sure not to > rebase > it anymore

[GIT PULL] drm/imx: error path fixes and cleanups

2020-07-20 Thread Philipp Zabel
Hi Dave, Daniel, The following changes since commit b3a9e3b9622ae10064826dccb4f7a52bd88c7407: Linux 5.8-rc1 (2020-06-14 12:45:04 -0700) are available in the Git repository at: git://git.pengutronix.de/pza/linux tags/imx-drm-next-2020-07-20 for you to fetch changes up to 408a85e31e3e5127c91

Re: [Freedreno] [PATCH] drm/msm/dpu: fix/enable 6bpc dither with split-lm

2020-07-20 Thread Rob Clark
On Mon, Jul 20, 2020 at 5:53 AM wrote: > > On 2020-07-16 03:49, Rob Clark wrote: > > From: Rob Clark > > > > If split-lm is used (for ex, on sdm845), we can have multiple ping- > > pongs, but only a single phys encoder. We need to configure dithering > > on each of them. > > > > Signed-off-by: R

[PATCH] drm/mxsfb: improve clk handling for axi clk

2020-07-20 Thread Uwe Kleine-König
Ignoring errors from devm_clk_get() is wrong. To handle not all platforms having an axi clk use devm_clk_get_optional() instead and do proper error handling. Also the clk API handles NULL as a dummy clk (which is also returned by devm_clk_get_optional() if there is no clk) so there is no need to c

[PATCH v10 10/13] drm/msm: Add support to create a local pagetable

2020-07-20 Thread Jordan Crouse
Add support to create a io-pgtable for use by targets that support per-instance pagetables. In order to support per-instance pagetables the GPU SMMU device needs to have the qcom,adreno-smmu compatible string and split pagetables enabled. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/msm

[PATCH v10 08/13] drm/msm: Add a context pointer to the submitqueue

2020-07-20 Thread Jordan Crouse
Each submitqueue is attached to a context. Add a pointer to the context to the submitqueue at create time and refcount it so that it stays around through the life of the queue. GPU submissions can access the active context via the submitqueue instead of requiring it to be passed around from functi

[PATCH v10 11/13] drm/msm: Add support for private address space instances

2020-07-20 Thread Jordan Crouse
Add support for allocating private address space instances. Targets that support per-context pagetables should implement their own function to allocate private address spaces. The default will return a pointer to the global address space. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/ms

[PATCH v10 09/13] drm/msm: Set the global virtual address range from the IOMMU domain

2020-07-20 Thread Jordan Crouse
Use the aperture settings from the IOMMU domain to set up the virtual address range for the GPU. This allows us to transparently deal with IOMMU side features (like split pagetables). Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 13 +++-- drivers/gpu/drm/ms

[PATCH v10 00/13] iommu/arm-smmu: Add Adreno SMMU specific implementation

2020-07-20 Thread Jordan Crouse
(reworded the summary to reflect ongoing changes in the code) This series adds an Adreno SMMU implementation to arm-smmu to allow GPU hardware pagetable switching. The Adreno GPU has built in capabilities to switch the TTBR0 pagetable during runtime to allow each individual instance or applicatio

[PATCH v10 12/13] drm/msm/a6xx: Add support for per-instance pagetables

2020-07-20 Thread Jordan Crouse
Add support for using per-instance pagetables if all the dependencies are available. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 53 +++ drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 + drivers/gpu/drm/msm/msm_ringbuffer.h | 1 + 3 files chang

Re: [PATCH v2] drm: pl111: Update documentation

2020-07-20 Thread Daniel Vetter
On Mon, Jul 20, 2020 at 03:03:27PM +0200, Linus Walleij wrote: > Remove notes about migrating from the old driver which is > retired as all users are now migrated. > > Update the text to reflect that we support PL110 and PL111 > alike. > > Drop the bullet on memory bandwidth scaling: this has bee

Re: [PATCH v6 4/4] dt-bindings: display: imx: add bindings for DCSS

2020-07-20 Thread Rob Herring
On Fri, 17 Jul 2020 17:41:29 +0300, Laurentiu Palcu wrote: > From: Laurentiu Palcu > > Add bindings for iMX8MQ Display Controller Subsystem. > > Signed-off-by: Laurentiu Palcu > --- > .../bindings/display/imx/nxp,imx8mq-dcss.yaml | 104 ++ > 1 file changed, 104 insertions(+) >

Re: [PATCH v6 4/4] dt-bindings: display: imx: add bindings for DCSS

2020-07-20 Thread Laurentiu Palcu
Hi Rob, On Mon, Jul 20, 2020 at 10:49:27AM -0600, Rob Herring wrote: > On Fri, 17 Jul 2020 17:41:29 +0300, Laurentiu Palcu wrote: > > From: Laurentiu Palcu > > > > Add bindings for iMX8MQ Display Controller Subsystem. > > > > Signed-off-by: Laurentiu Palcu > > --- > > .../bindings/display/imx

[GIT PULL] etnaviv-next for 5.9

2020-07-20 Thread Lucas Stach
Hi Dave, Daniel, please pull the following etnaviv updates for 5.9. Nothing too exciting: - a cleanup of our clock handling and improved error handling in this area from Lubomir - conversion to pin_user_pages for long page references from John - fixed PM runtime API error handling from Navid Reg

[PATCH 3/5] drm/vblank: Use spin_(un)lock_irq() in drm_legacy_vblank_post_modeset()

2020-07-20 Thread Lyude Paul
This function is only ever called from ioctl context, so we're guaranteed to have interrupts enabled. Stop using the irqsave/irqrestore variants of spin_(un)lock_irq() to make this more obvious. Signed-off-by: Lyude Paul Cc: Daniel Vetter --- drivers/gpu/drm/drm_vblank.c | 5 ++--- 1 file chang

[Bug 208589] amdgpu screen corruption with DRI_PRIME on external monitor at resolution 2560x1440 and more then 60hz

2020-07-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208589 --- Comment #2 from d...@rodler-keller.de --- no the screen corutpion still exists -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel mailing list dri-devel

[PATCH 0/5] drm/vblank: Cleanup spin_(un)lock_irqsave() calls

2020-07-20 Thread Lyude Paul
This is a follow-up series for finishing the work that we started here: https://patchwork.freedesktop.org/patch/373107/?series=74805&rev=8 tl;dr many of the drm_vblank functions only get called within irq-enabled contexts, so we go through those and convert them over to using spin_(un)lock_irq()

[PATCH 1/5] drm/vblank: Use spin_(un)lock_irq() in drm_crtc_vblank_reset()

2020-07-20 Thread Lyude Paul
All of the drivers in the kernel tree only call this from one of the following contexts: * drm_crtc_funcs->reset * During initial module load Since both of these contexts are guaranteed to have interrupts enabled beforehand, there's no need to use the irqsave/irqrestore variants of spin_(un)lock(

[PATCH 5/5] drm/vblank: Use spin_(un)lock_irq() in drm_crtc_queue_sequence_ioctl()

2020-07-20 Thread Lyude Paul
This is an ioctl callback, so we're guaranteed to have IRQs enabled when calling this function. Use the plain _irq() variants of spin_(un)lock() to make this more obvious. Signed-off-by: Lyude Paul Cc: Daniel Vetter --- drivers/gpu/drm/drm_vblank.c | 7 +++ 1 file changed, 3 insertions(+),

[PATCH 4/5] drm/vblank: Use spin_(un)lock_irq() in drm_queue_vblank_event()

2020-07-20 Thread Lyude Paul
This one's easy - we're already calling kzalloc() in this function, so we must already be guaranteed to have IRQs enabled when calling this. So, use the plain _irq() variants of spin_(un)lock() to make this more obvious. Signed-off-by: Lyude Paul Cc: Daniel Vetter --- drivers/gpu/drm/drm_vblank

[PATCH 2/5] drm/vblank: Use spin_(un)lock_irq() in drm_crtc_vblank_on()

2020-07-20 Thread Lyude Paul
This is only called from: * Atomic modesetting hooks * Module probing routines * Legacy modesetting hooks All of which have IRQs enabled, so we can also get rid of irqsave/restore here to make the IRQ context of this function more obvious. Signed-off-by: Lyude Paul Cc: Daniel Vetter --- driver

Re: [PATCH v6 4/4] dt-bindings: display: imx: add bindings for DCSS

2020-07-20 Thread Rob Herring
On Mon, Jul 20, 2020 at 10:55 AM Laurentiu Palcu wrote: > > Hi Rob, > > On Mon, Jul 20, 2020 at 10:49:27AM -0600, Rob Herring wrote: > > On Fri, 17 Jul 2020 17:41:29 +0300, Laurentiu Palcu wrote: > > > From: Laurentiu Palcu > > > > > > Add bindings for iMX8MQ Display Controller Subsystem. > > > >

[PATCH] video: fbdev: pvr2fb: initialize variables

2020-07-20 Thread trix
From: Tom Rix clang static analysis reports this repesentative error pvr2fb.c:1049:2: warning: 1st function call argument is an uninitialized value [core.CallAndMessage] if (*cable_arg) ^~~ Problem is that cable_arg depends on the input loop to set the cable_arg[0]

Re: [PATCH 8/8] drm/mgag200: Add support for G200 desktop cards

2020-07-20 Thread Lyude Paul
On Mon, 2020-07-20 at 09:04 +0200, Thomas Zimmermann wrote: > Hi > > Am 17.07.20 um 00:43 schrieb Lyude Paul: > > On Wed, 2020-07-15 at 16:59 +0200, Thomas Zimmermann wrote: > > > This patch adds support for G200 desktop cards. We can reuse the whole > > > memory and modesetting code. A few PCI an

Re: [PATCH] video: fbdev: pvr2fb: initialize variables

2020-07-20 Thread Arnd Bergmann
On Mon, Jul 20, 2020 at 9:19 PM wrote: > > From: Tom Rix > > clang static analysis reports this repesentative error > > pvr2fb.c:1049:2: warning: 1st function call argument > is an uninitialized value [core.CallAndMessage] > if (*cable_arg) > ^~~ > > Problem is that

Re: [PATCH 8/8] drm/mgag200: Add support for G200 desktop cards

2020-07-20 Thread Sam Ravnborg
On Mon, Jul 20, 2020 at 03:18:56PM -0400, Lyude Paul wrote: > On Mon, 2020-07-20 at 09:04 +0200, Thomas Zimmermann wrote: > > Hi > > > > Am 17.07.20 um 00:43 schrieb Lyude Paul: > > > On Wed, 2020-07-15 at 16:59 +0200, Thomas Zimmermann wrote: > > > > This patch adds support for G200 desktop cards

[Bug 208589] amdgpu screen corruption with DRI_PRIME on external monitor at resolution 2560x1440 and more then 60hz

2020-07-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208589 --- Comment #3 from d...@rodler-keller.de --- "echo high > /sys/class/drm/card0/device/power_dpm_force_performance_level" hm fixes the screen coruption -- You are receiving this mail because: You are watching the assignee of the bug. __

Re: [PATCH] drm: panel: simple: Delay HPD checking on boe_nv133fhm_n61 for 15 ms

2020-07-20 Thread Doug Anderson
Hi, On Thu, Jul 16, 2020 at 1:21 PM Douglas Anderson wrote: > > On boe_nv133fhm_n62 (and presumably on boe_nv133fhm_n61) a scope shows > a small spike on the HPD line right when you power the panel on. The > picture looks something like this: > > +--

[PATCH 2/2 v1] backlight: Add Kinetic KTD253 backlight driver

2020-07-20 Thread Linus Walleij
The Kinetic KTD253 backlight driver is controlled with a single GPIO line, but still supports a range of brightness settings by sending fast pulses on the line. This is based off the source code release for the Samsung GT-S7710 mobile phone. Signed-off-by: Linus Walleij --- MAINTAINERS

[PATCH 1/2 v1] dt-bindings: backlight: Add Kinetic KTD253 bindings

2020-07-20 Thread Linus Walleij
This adds device tree bindings for the Kinetic KTD253 white LED backlight driver. Cc: devicet...@vger.kernel.org Signed-off-by: Linus Walleij --- .../leds/backlight/kinetic,ktd253.yaml| 48 +++ 1 file changed, 48 insertions(+) create mode 100644 Documentation/devicetree

[PATCH] drm/nouveau/kms/nv50-: Fix CRC-related compile errors with debugfs disabled

2020-07-20 Thread Lyude Paul
Looks like I made the mistake of forgetting to check whether or not this would build without CONFIG_DEBUG_FS, as the Kbuild bot reported some issues building with tegra_defconfig: In file included from drivers/gpu/drm/nouveau/nouveau_display.c:47: ./drivers/gpu/drm/nouveau/dispnv50/crc.h: In funct

  1   2   >