Re: linux-next: build failure after merge of the drm-misc tree

2020-06-17 Thread Stephen Rothwell
Hi Thomas, On Wed, 17 Jun 2020 08:33:24 +0200 Thomas Zimmermann wrote: > > We recently dropped the _unlock() suffix from drm_gem_object_put(). This > patch should be ok. Yes, but what it shows is that the drm-misc tree is still based on v5.7-rc1 and v5.8-rc1 has about 16000 more commits for you

Re: [PATCH 1/3] drm/ast: Remove unused code paths for AST 1180

2020-06-17 Thread Thomas Zimmermann
Hi Emil Am 16.06.20 um 01:21 schrieb Emil Velikov: > Hi Thomas, > > On Thu, 11 Jun 2020 at 09:28, Thomas Zimmermann wrote: > >> --- a/drivers/gpu/drm/ast/ast_drv.c >> +++ b/drivers/gpu/drm/ast/ast_drv.c >> @@ -59,7 +59,6 @@ static struct drm_driver driver; >> static const struct pci_device_id

Re: [Linaro-mm-sig] [PATCH 04/18] dma-fence: prime lockdep annotations

2020-06-17 Thread Jason Gunthorpe
On Tue, Jun 16, 2020 at 02:07:19PM +0200, Daniel Vetter wrote: > > > I've pinged a bunch of armsoc gpu driver people and ask them how much this > > > hurts, so that we have a clear answer. On x86 I don't think we have much > > > of a choice on this, with userptr in amd and i915 and hmm work in nouv

[PATCH 1/2] drm/bridge: dw-hdmi: Don't cleanup i2c adapter and ddc ptr in __dw_hdmi_probe() bailout path

2020-06-17 Thread Liu Ying
It's unnecessary to cleanup the i2c adapter and the ddc pointer in the bailout path of __dw_hdmi_probe(), since the adapter is not added and the ddc pointer is not set. Fixes: a23d6265f033 (drm: bridge: dw-hdmi: Extract PHY interrupt setup to a function) Cc: Andrzej Hajda Cc: Neil Armstrong Cc

Re: [RFC PATCH 0/4] DSI/DBI and TinyDRM driver

2020-06-17 Thread Paul Cercueil
Hi Emil, Le mar. 16 juin 2020 à 18:47, Emil Velikov a écrit : Hi all, Allow me to compare this approach with some work Linus W [1] did a while back, which I've just noticed. Pauls' approach: - Perhaps the shortest one possible Porting an existing DSI panel to DBI is 3 lines of code - compa

Re: [PATCH 1/2] drm/amdgpu/debugfs: fix memory leak when pm_runtime_get_sync failed

2020-06-17 Thread chentao (AS)
Ok, i will modify it in v2 patch. On 2020/6/16 14:50, Christian König wrote: Probably better to remove the duplication of result and r here and then use "goto err". ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.o

Re: [PATCH v2] dma-buf: Move dma_buf_release() from fops to dentry_ops

2020-06-17 Thread Charan Teja Kalla
Thanks Sumit for the fix. On 6/11/2020 5:14 PM, Sumit Semwal wrote: > Charan Teja reported a 'use-after-free' in dmabuffs_dname [1], which > happens if the dma_buf_release() is called while the userspace is > accessing the dma_buf pseudo fs's dmabuffs_dname() in another process, > and dma_buf_rele

Re: [Freedreno] [PATCH v6 0/5] Add support for DisplayPort driver on

2020-06-17 Thread Stephen Boyd
Quoting tan...@codeaurora.org (2020-06-15 16:36:52) > On 2020-06-15 16:04, Jeffrey Hugo wrote: > >> > > >> > I've never seen a block diagram for a driver before... > >> > > >> It is here for v5. https://patchwork.freedesktop.org/series/74312/ > > > > I think Stephen is nitpicking your wording, and

Re: [PATCH v7 1/6] of_graph: add of_graph_get_local_port()

2020-06-17 Thread Dmitry Osipenko
16.06.2020 04:25, Laurent Pinchart пишет: > On Tue, Jun 16, 2020 at 04:21:12AM +0300, Laurent Pinchart wrote: >> Hi Dmitry, >> >> Thank you for the patch. >> >> On Sun, Jun 14, 2020 at 08:22:29PM +0300, Dmitry Osipenko wrote: >>> In some case, like a DRM display code for example, it's useful to sil

[RESEND PATCH v2 4/4] drm/etnaviv: Simplify clock enable/disable

2020-06-17 Thread Lubomir Rintel
All the NULL checks are pointless, clk_*() routines already deal with NULL just fine. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 53 ++- 1 file changed, 19 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b

[RESEND PATCH v2 0/4] drm/etnaviv: Tidy up clocks handling

2020-06-17 Thread Lubomir Rintel
Hi, please consider applying patches that are chained to this message. They make getting/enabling the clocks in the etnaviv driver slightly nicer, first two also fix potential problems. Compared to v1, patch 2/4 was fixed and patch 3/4 was added. As it was pointed out in response to v1, the clo

[PATCH v4 0/5] Add support for PinePhone LCD panel

2020-06-17 Thread Ondrej Jirman
This patchset adds support for the LCD panel of PinePhone. The first 3 patches are for the panel itself, and the last 2 patches are for enabling it on PinePhone. I've tested this on PinePhone 1.0 and 1.2. Please take a look. thank you and regards, Ondrej Jirman Changes in v4: - use ->type fr

[PATCH v4 5/5] arm64: dts: sun50i-a64-pinephone: Add touchscreen support

2020-06-17 Thread Ondrej Jirman
Pinephone has a Goodix GT917S capacitive touchscreen controller on I2C0 bus. Add support for it. Signed-off-by: Ondrej Jirman --- .../dts/allwinner/sun50i-a64-pinephone.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pineph

[PATCH 2/2] drm/bridge: dw-hdmi: Always add the bridge in the global bridge list

2020-06-17 Thread Liu Ying
It doesn't hurt to add the bridge in the global bridge list also for platform specific dw-hdmi drivers which are based on the component framework. This can be achieved by moving the drm_bridge_add() function call from dw_hdmi_probe() to __dw_hdmi_probe(). Moreover, putting the drm_bridge_add() fu

[PATCH] drm/amd/powerplay: Fix NULL dereference in lock_bus() on Vega20 w/o RAS

2020-06-17 Thread Ivan Mironov
I updated my system with Radeon VII from kernel 5.6 to kernel 5.7, and following started to happen on each boot: ... BUG: kernel NULL pointer dereference, address: 0128 ... CPU: 9 PID: 1940 Comm: modprobe Tainted: GE 5.7.2-200.im0.fc32.x

Re: [PATCH v6 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-06-17 Thread Stephen Boyd
Quoting tan...@codeaurora.org (2020-06-11 13:07:09) > On 2020-06-09 19:15, Stephen Boyd wrote: > > Quoting Tanmay Shah (2020-06-08 20:38:18) > >> diff --git > >> a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > >> b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > >>

Re: [PATCH 1/5] drm/omap: Fix suspend resume regression after platform data removal

2020-06-17 Thread Tony Lindgren
* Tomi Valkeinen [200616 13:02]: > On 11/06/2020 17:00, Grygorii Strashko wrote: > > I think, suspend might be fixed if all devices, which are now child of > > ti-sysc, will do > > pm_runtime_force_xxx() calls at noirq suspend stage by adding: > > > > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtim

Re: [PATCH v2] drm/tegra: Add zpos property for cursor planes

2020-06-17 Thread Dmitry Osipenko
16.06.2020 15:17, Thierry Reding пишет: > From: Thierry Reding > > As of commit 4dc55525b095 ("drm: plane: Verify that no or all planes > have a zpos property") a warning is emitted if there's a mix of planes > with and without a zpos property. > > On Tegra, cursor planes are always composited o

[RESEND PATCH v2 2/4] drm/etnaviv: Don't ignore errors on getting clocks

2020-06-17 Thread Lubomir Rintel
There might be good reasons why the getting a clock failed. To treat the clocks as optional we're specifically only interested in ignoring -ENOENT, and devm_clk_get_optional() does just that. Note that this preserves the original behavior of all clocks being optional. The binding document mandates

[PATCH v4 1/5] dt-bindings: vendor-prefixes: Add Xingbangda

2020-06-17 Thread Ondrej Jirman
From: Icenowy Zheng Shenzhen Xingbangda Display Technology Co., Ltd is a company which produces LCD modules. It supplies the LCD panels for the PinePhone. Add the vendor prefix of it. Signed-off-by: Icenowy Zheng Signed-off-by: Ondrej Jirman Acked-by: Rob Herring --- Documentation/devicetre

Re: [PATCH v2] drm/tegra: Add zpos property for cursor planes

2020-06-17 Thread Dmitry Osipenko
16.06.2020 19:13, Thierry Reding пишет: > On Tue, Jun 16, 2020 at 06:54:35PM +0300, Dmitry Osipenko wrote: >> 16.06.2020 15:17, Thierry Reding пишет: >>> From: Thierry Reding >>> >>> As of commit 4dc55525b095 ("drm: plane: Verify that no or all planes >>> have a zpos property") a warning is emitte

[PATCH] gpu/drm: remove drm_modeset_lock protection for drm_error

2020-06-17 Thread Bernard Zhao
In function drm_atomic_helper_shutdown, maybe there is no need to protect DRM_ERROR log in DRM_MODESET_LOCK_ALL_BEGIN & DRM_MODESET_LOCK_ALL_END. This change is to make code run a bit fast. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/drm_atomic_helper.c | 4 +--- 1 file changed, 1 insertion(

Re: [PATCH v2 5/5] drm/tegra: plane: Support 180° rotation

2020-06-17 Thread Dmitry Osipenko
16.06.2020 00:47, Emil Velikov пишет: > Hi all, > > Perhaps a silly question: > > On Mon, 15 Jun 2020 at 08:28, Dmitry Osipenko wrote: >> >> Combining horizontal and vertical reflections gives us 180 degrees of >> rotation. >> >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/gpu/drm/tegra/d

Re: [PATCH v3 033/105] drm/vc4: crtc: Assign output to channel automatically

2020-06-17 Thread Maxime Ripard
Hi Eric, On Wed, May 27, 2020 at 10:23:23AM -0700, Eric Anholt wrote: > On Wed, May 27, 2020 at 8:50 AM Maxime Ripard wrote: > > static int > > vc4_atomic_check(struct drm_device *dev, struct drm_atomic_state *state) > > { > > - int ret; > > + unsigned long unassigned_channels = GE

Re: [PATCH v2 0/5] 180 degrees rotation support for NVIDIA Tegra DRM

2020-06-17 Thread Dmitry Osipenko
16.06.2020 01:26, Emil Velikov пишет: > Hi Dmitry, > > On Mon, 15 Jun 2020 at 08:28, Dmitry Osipenko wrote: >> >> Hello! >> >> This series adds 180° display plane rotation support to the NVIDIA Tegra >> DRM driver which is needed for devices that have display panel physically >> mounted upside-do

Re: [linux-sunxi] Re: [PATCH v3 3/5] drm: panel: Add Xingbangda XBD599 panel (ST7703 controller)

2020-06-17 Thread Ondřej Jirman
Hello Linus, On Tue, May 26, 2020 at 01:32:25PM +0200, Linus Walleij wrote: > Hi Ondrej, > [...] > > + dsi_dcs_write_seq(dsi, ST7703_CMD_SETGIP1, > > + 0x82, 0x10, 0x06, 0x05, 0xA2, 0x0A, 0xA5, 0x12, > > + 0x31, 0x23, 0x37, 0x83, 0x04, 0xBC,

Re: [PATCH 1/2] drm/amdgpu/debugfs: fix memory leak when pm_runtime_get_sync failed

2020-06-17 Thread Markus Elfring
> Fix memory leak in amdgpu_debugfs_gpr_read not freeing data when > pm_runtime_get_sync failed. * Would you like to improve the exception handling any more for this software module? * How do you think about calling the function “pm_runtime_put_noidle”? Regards, Markus _

[RESEND PATCH v2 1/4] drm/etnaviv: Fix error path on failure to enable bus clk

2020-06-17 Thread Lubomir Rintel
Since commit 65f037e8e908 ("drm/etnaviv: add support for slave interface clock") the reg clock is enabled before the bus clock and we need to undo its enablement on error. Fixes: 65f037e8e908 ("drm/etnaviv: add support for slave interface clock") Signed-off-by: Lubomir Rintel --- drivers/gpu/drm

[RESEND PATCH v2 3/4] drm/etnaviv: Make the "core" clock mandatory

2020-06-17 Thread Lubomir Rintel
It is always present. It was documented as mandatory prior to commit 90aeca875f8a ("dt-bindings: display: Convert etnaviv to json-schema"). Signed-off-by: Lubomir Rintel --- Changes since v1: - Add this patch drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH v4 2/5] dt-bindings: panel: Add binding for Xingbangda XBD599 panel

2020-06-17 Thread Ondrej Jirman
From: Icenowy Zheng Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel. It is based on Sitronix ST7703 LCD controller. Add its device tree binding. Signed-off-by: Icenowy Zheng Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij Reviewed-by: Rob Herring --- .../display/panel/sitr

Re: [PATCH v6 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-06-17 Thread Stephen Boyd
Quoting Tanmay Shah (2020-06-11 18:50:26) > diff --git a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > new file mode 100644 > index ..5fdb9153df00 > --- /dev/null > +++ b/Documentation/devicetree/bindings

Re: [PATCH v7 2/6] drm/of: Make drm_of_find_panel_or_bridge() to check graph's presence

2020-06-17 Thread Dmitry Osipenko
16.06.2020 04:26, Laurent Pinchart пишет: > Hi Dmitry, > > Thank you for the patch. > > On Sun, Jun 14, 2020 at 08:22:30PM +0300, Dmitry Osipenko wrote: >> When graph isn't defined in a device-tree, the of_graph_get_remote_node() >> prints a noisy error message, telling that port node is not foun

Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders

2020-06-17 Thread Maxime Ripard
On Sun, Jun 14, 2020 at 06:16:56PM +0200, Stefan Wahren wrote: > Am 11.06.20 um 15:34 schrieb Maxime Ripard: > > Hi Stefan, > > > > On Sat, Jun 06, 2020 at 10:06:12AM +0200, Stefan Wahren wrote: > >> Hi Maxime, > >> > >> Am 05.06.20 um 16:35 schrieb Maxime Ripard: > >>> Hi Stefan, > >>> > >>> On We

Re: [PATCH v7 1/6] of_graph: add of_graph_get_local_port()

2020-06-17 Thread Dmitry Osipenko
16.06.2020 16:56, Dmitry Osipenko пишет: > 16.06.2020 04:25, Laurent Pinchart пишет: >> On Tue, Jun 16, 2020 at 04:21:12AM +0300, Laurent Pinchart wrote: >>> Hi Dmitry, >>> >>> Thank you for the patch. >>> >>> On Sun, Jun 14, 2020 at 08:22:29PM +0300, Dmitry Osipenko wrote: In some case, like

Re: [PATCH v2 0/5] 180 degrees rotation support for NVIDIA Tegra DRM

2020-06-17 Thread Dmitry Osipenko
16.06.2020 21:54, Emil Velikov пишет: > On Tue, 16 Jun 2020 at 18:20, Dmitry Osipenko wrote: >> >> 16.06.2020 18:48, Emil Velikov пишет: >>> On Tue, 16 Jun 2020 at 12:40, Dmitry Osipenko wrote: 16.06.2020 01:26, Emil Velikov пишет: > Hi Dmitry, > > On Mon, 15 Jun 2020 at 08:

[PATCH v4 3/5] drm: panel: Add Xingbangda XBD599 panel (ST7703 controller)

2020-06-17 Thread Ondrej Jirman
From: Icenowy Zheng Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI IPS LCD panel made by Xingbangda, which is used on PinePhone final assembled phones. It is based on Sitronix ST7703 LCD controller. Add support for it. Signed-off-by: Icenowy Zheng Signed-off-by: Ondrej Jirman --- drivers/gp

Re: [RFC PATCH 0/4] DirectX on Linux

2020-06-17 Thread Pavel Machek
On Tue 2020-06-16 09:28:19, Sasha Levin wrote: > On Tue, Jun 16, 2020 at 12:51:13PM +0200, Pavel Machek wrote: > > Hi! > > > > > > The driver creates the /dev/dxg device, which can be opened by user mode > > > > application and handles their ioctls. The IOCTL interface to the driver > > > > is def

[PATCH v5 1/2] dt-bindings: mfd: Add ENE KB3930 Embedded Controller binding

2020-06-17 Thread Lubomir Rintel
Add binding document for the ENE KB3930 Embedded Controller. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v4: - Collected Rob's Reviewed-by Changes since v1: - Addressed binding validation failure .../devicetree/bindings/mfd/ene-kb3930.yaml | 55

Re: [PATCH v3] drm/tegra: Add zpos property for cursor planes

2020-06-17 Thread Dmitry Osipenko
16.06.2020 21:14, Thierry Reding пишет: > From: Thierry Reding > > As of commit 4dc55525b095 ("drm: plane: Verify that no or all planes > have a zpos property") a warning is emitted if there's a mix of planes > with and without a zpos property. > > On Tegra, cursor planes are always composited o

[PATCH v5 0/2] mfd: Add ENE KB3930 Embedded Controller driver

2020-06-17 Thread Lubomir Rintel
Hi, please consider applying the patches chained to this message. It's the fifth version of the driver for the ENE KB3930 Embedded Controller. This version is essentially a resend of v4. The only actual change is the addition of the Rob's Reviewed-by tag which I failed to do previously. Detailed

Re: [PATCH] dmabuf: use spinlock to access dmabuf->name

2020-06-17 Thread Charan Teja Kalla
Thanks Michael for the comments.. On 6/16/2020 7:29 PM, Ruhl, Michael J wrote: >> -Original Message- >> From: dri-devel On Behalf Of >> Ruhl, Michael J >> Sent: Tuesday, June 16, 2020 9:51 AM >> To: Charan Teja Kalla ; Sumit Semwal >> ; open list:DMA BUFFER SHARING FRAMEWORK >> ; DRI mail

Re: [PATCH v2 0/5] 180 degrees rotation support for NVIDIA Tegra DRM

2020-06-17 Thread Dmitry Osipenko
16.06.2020 20:45, Laurent Pinchart пишет: > On Tue, Jun 16, 2020 at 08:20:57PM +0300, Dmitry Osipenko wrote: >> 16.06.2020 18:48, Emil Velikov пишет: >>> On Tue, 16 Jun 2020 at 12:40, Dmitry Osipenko wrote: 16.06.2020 01:26, Emil Velikov пишет: > Hi Dmitry, > > On Mon, 15 Jun

Re: [PATCH v2 0/5] 180 degrees rotation support for NVIDIA Tegra DRM

2020-06-17 Thread Dmitry Osipenko
16.06.2020 18:48, Emil Velikov пишет: > On Tue, 16 Jun 2020 at 12:40, Dmitry Osipenko wrote: >> >> 16.06.2020 01:26, Emil Velikov пишет: >>> Hi Dmitry, >>> >>> On Mon, 15 Jun 2020 at 08:28, Dmitry Osipenko wrote: Hello! This series adds 180° display plane rotation support to t

[PATCH v5 2/2] mfd: ene-kb3930: Add driver for ENE KB3930 Embedded Controller

2020-06-17 Thread Lubomir Rintel
This driver provides access to the EC RAM of said embedded controller attached to the I2C bus as well as optionally supporting its slightly weird power-off/restart protocol. A particular implementation of the EC firmware can be identified by a model byte. If this driver identifies the Dell Ariel p

Re: [PATCH v2 0/5] 180 degrees rotation support for NVIDIA Tegra DRM

2020-06-17 Thread Dmitry Osipenko
16.06.2020 01:26, Emil Velikov пишет: ... > Although I see that this series, alike Derek's, has a couple of issues: > - only a single panel driver is updated I'll separate this series into two patchsets. One will add orientation support to the panel drivers and I'll include the Derek's tv101wum-

[PATCH v4 4/5] arm64: dts: sun50i-a64-pinephone: Enable LCD support on PinePhone

2020-06-17 Thread Ondrej Jirman
From: Icenowy Zheng PinePhone uses PWM backlight and a XBD599 LCD panel over DSI for display. Backlight levels curve was optimized by Martijn Braam using a lux meter. Add its device nodes. Signed-off-by: Icenowy Zheng Signed-off-by: Martijn Braam Signed-off-by: Ondrej Jirman --- .../allwin

Re: [Linaro-mm-sig] [PATCH 04/18] dma-fence: prime lockdep annotations

2020-06-17 Thread Daniel Vetter
On Wed, Jun 17, 2020 at 9:27 AM Jason Gunthorpe wrote: > > On Tue, Jun 16, 2020 at 02:07:19PM +0200, Daniel Vetter wrote: > > > > I've pinged a bunch of armsoc gpu driver people and ask them how much > > > > this > > > > hurts, so that we have a clear answer. On x86 I don't think we have much > >

[PATCH v2 3/4] drm/ast: Upcast from DRM device to ast structure via to_ast_private()

2020-06-17 Thread Thomas Zimmermann
All upcasting from struct drm_device to struct ast_private is now performed via to_ast_private(). Using struct drm_device.dev_private is deprecated. The ast variable in ast_crtc_helper_atomic_check() is unused, so removed it. v2: * fix typo in commit message Signed-off-by: Thomas Zimmerma

[PATCH v2 2/4] drm/ast: Remove test for device from ast_pm_freeze()

2020-06-17 Thread Thomas Zimmermann
The driver cannot suspend before it has loaded completely. So the test for device pointers is not required. Remove them. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/as

[PATCH v2 0/4] ast cleanups

2020-06-17 Thread Thomas Zimmermann
Ast still has to be converted to managed initialization, and embed the DRM device in the ast structure. In preparation of these changes, add some cleanups to the driver. Tested on ast HW. v2: * remove device tests from ast_pm_freeze() (Daniel) * convert WARN_*() (Sam) * ty

[PATCH v2 1/4] drm/ast: Remove unused code paths for AST 1180

2020-06-17 Thread Thomas Zimmermann
The ast driver contains code paths for AST 1180 chips. The chip is not supported and the rsp code has never been tested. Simplify the driver by removing the AST 1180 code. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Reviewed-by: Emil Velikov --- drivers/gpu/drm/ast/ast_drv.c |

[PATCH v2 4/4] drm/ast: Use per-device logging macros

2020-06-17 Thread Thomas Zimmermann
Converts the ast driver to drm_info(), drm_err() and drm_WARN_*(). No functional changes are made. v2: * also convert WARN_*() macros Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Reviewed-by: Emil Velikov --- drivers/gpu/drm/ast/ast_main.c | 34 +

[PATCH][next] drm/i915/selftests: fix spelling mistake "submited" -> "submitted"

2020-06-17 Thread Colin King
From: Colin Ian King There is a spelling mistake in a pr_err message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_

Re: [PATCH v5 0/2] mfd: Add ENE KB3930 Embedded Controller driver

2020-06-17 Thread Lucas Stach
Hi Lubomir, Am Mittwoch, den 17.06.2020, 00:44 +0200 schrieb Lubomir Rintel: > Hi, > > please consider applying the patches chained to this message. It's the > fifth version of the driver for the ENE KB3930 Embedded Controller. > > This version is essentially a resend of v4. The only actual chan

Re: [PATCH] drm/mgag200: Don't set in MISC

2020-06-17 Thread Rong Chen
On Wed, Jun 17, 2020 at 08:28:02AM +0200, Thomas Zimmermann wrote: > Hi Emil > > Am 16.06.20 um 17:14 schrieb Emil Velikov: > > Hi Thomas, > > > > On Tue, 16 Jun 2020 at 15:26, Thomas Zimmermann wrote: > >> > >> The original modesetting code set MISC to 0x2d, which is , > >> and > >> > >> With

Re: [PATCH 2/2] drm: rockchip: add NV15 and NV20 support

2020-06-17 Thread Heiko Stübner
Am Sonntag, 7. Juni 2020, 22:25:26 CEST schrieb Jonas Karlman: > Add support for displaying 10-bit 4:2:0 and 4:2:2 formats produced by the > Rockchip Video Decoder on RK322X, RK3288, RK3328, RK3368 and RK3399. > > Signed-off-by: Jonas Karlman Reviewed-by: Heiko Stuebner > --- > drivers/gpu/dr

Re: [PATCH v2 0/5] 180 degrees rotation support for NVIDIA Tegra DRM

2020-06-17 Thread Daniel Stone
Hi, On Tue, 16 Jun 2020 at 22:16, Dmitry Osipenko wrote: > The panel's orientation could be parsed by any panel driver and then > assigned as the connector's property in order to allow userspace/FB-core > to decide what to do with the rotated display. Apparently upstream > kernel supports only th

[PATCH v4 1/4] dt-bindings: display: ti,tfp410.txt: convert to yaml

2020-06-17 Thread Ricardo Cañuelo
Convert the DT binding documentation for the TI TFP410 DPI-to-DVI encoder to json-schema. Signed-off-by: Ricardo Cañuelo Reviewed-by: Laurent Pinchart --- .../bindings/display/bridge/ti,tfp410.txt | 66 - .../bindings/display/bridge/ti,tfp410.yaml| 130 ++ 2 fil

[PATCH v4 3/4] drm/bridge: tfp410: fix de-skew value retrieval from DT

2020-06-17 Thread Ricardo Cañuelo
The tfp410 has a data de-skew feature that allows the user to compensate the skew between IDCK and the pixel data and control signals. In the driver, the setup and hold times are calculated from the de-skew value. This retrieves the deskew value from the DT using the proper datatype and range chec

[PATCH v4 2/4] dt-bindings: display: ti, tfp410.yaml: Redefine ti, deskew property

2020-06-17 Thread Ricardo Cañuelo
This changes how the 'ti,deskew' property is defined. It's now an unsigned value from 0 to 7 instead of a signed value from -4 to 3. Until the dtc carries the integer sign through to the yaml output it's easier to define signed types as unsigned. Signed-off-by: Ricardo Cañuelo Reviewed-by: Lauren

[PATCH v4 0/4] dt-bindings: display: ti,tfp410.txt: convert to yaml

2020-06-17 Thread Ricardo Cañuelo
This series converts the DT binding for the TI TFP410 DPI-to-DVI encoder to json-schema. It also fixes a minor bug in the ti-tfp410 driver that causes a wrong calculation of the setup and hold times when the de-skew feature is enabled. The retrieval of the de-skew value from the DT has also been u

[PATCH v4 4/4] drm/bridge: tfp410: Fix setup and hold time calculation

2020-06-17 Thread Ricardo Cañuelo
This fixes a bug in the calculation of the setup and hold times based on the deskew configuration. Signed-off-by: Ricardo Cañuelo Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/bridge/ti-tfp410.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/t

Re: [PATCH v2] drm/etnaviv: fix ref count leak via pm_runtime_get_sync

2020-06-17 Thread Lucas Stach
Hi Navid, Am Montag, den 15.06.2020, 01:12 -0500 schrieb Navid Emamdoost: > in etnaviv_gpu_submit, etnaviv_gpu_recover_hang, etnaviv_gpu_debugfs, > and etnaviv_gpu_init the call to pm_runtime_get_sync increments the > counter even in case of failure, leading to incorrect ref count. > In case of fa

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-06-17 Thread Daniel Vetter
On Wed, Jun 10, 2020 at 03:33:06PM -0700, Paulo Zanoni wrote: > Em qui, 2020-05-28 às 11:09 +0530, Karthik B S escreveu: > > Add enable/disable flip done functions and the flip done handler > > function which handles the flip done interrupt. > > > > Enable the flip done interrupt in IER. > > > > En

Re: [PATCH 1/5] drm/omap: Fix suspend resume regression after platform data removal

2020-06-17 Thread Tomi Valkeinen
On 16/06/2020 19:56, Grygorii Strashko wrote: On 16/06/2020 18:30, Tony Lindgren wrote: * Tomi Valkeinen [200616 13:02]: On 11/06/2020 17:00, Grygorii Strashko wrote: I think, suspend might be fixed if all devices, which are now child of ti-sysc, will do pm_runtime_force_xxx() calls at noi

[Bug 206017] Kernel 5.4.x unusable with GUI due to crashes (some hard)

2020-06-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206017 pr...@ww.ee (pr...@ww.ee) changed: What|Removed |Added CC||pr...@ww.ee --- Comment #18 f

Re: [PATCH] drm/rockchip: Add per-pixel alpha support for the PX30 VOP

2020-06-17 Thread Heiko Stuebner
On Thu, 16 Apr 2020 16:05:26 +0200, Paul Kocialkowski wrote: > Compared to its predecessors, the PX30 VOP has a different register layout > for enabling per-pixel alpha. Instead of src_alpha_ctl and dst_alpha_ctl, > there is a single alpha control register. This register takes some fields > from sr

[PATCH v3 0/3] Add LT9611 DSI to HDMI bridge

2020-06-17 Thread Vinod Koul
Hi, This series adds driver and bindings for Lontium LT9611 bridge chip which takes MIPI DSI as input and HDMI as output. This chip can be found in 96boards RB3 platform [1] commonly called DB845c. [1]: https://www.96boards.org/product/rb3-platform/ Changes in v3: - fix kbuild reported error

[PATCH v3 1/3] dt-bindings: vendor-prefixes: Add Lontium vendor prefix

2020-06-17 Thread Vinod Koul
Add prefix for Lontium Semiconductor Corporation Acked-by: Rob Herring Signed-off-by: Vinod Koul --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bi

[PATCH v3 3/3] drm/bridge: Introduce LT9611 DSI to HDMI bridge

2020-06-17 Thread Vinod Koul
Lontium Lt9611 is a DSI to HDMI bridge which supports two DSI ports and I2S port as an input and HDMI port as output Co-developed-by: Bjorn Andersson Signed-off-by: Bjorn Andersson Co-developed-by: Srinivas Kandagatla Signed-off-by: Srinivas Kandagatla Signed-off-by: Vinod Koul --- drivers/g

[PATCH v3 2/3] dt-bindings: display: bridge: Add documentation for LT9611

2020-06-17 Thread Vinod Koul
Lontium LT9611 is a DSI to HDMI bridge which supports 2 DSI ports and I2S port as input and one HDMI port as output Reviewed-by: Rob Herring Signed-off-by: Vinod Koul --- .../display/bridge/lontium,lt9611.yaml| 176 ++ 1 file changed, 176 insertions(+) create mode 10064

Re: [PATCH 1/5] drm/omap: Fix suspend resume regression after platform data removal

2020-06-17 Thread Grygorii Strashko
On 16/06/2020 18:30, Tony Lindgren wrote: * Tomi Valkeinen [200616 13:02]: On 11/06/2020 17:00, Grygorii Strashko wrote: I think, suspend might be fixed if all devices, which are now child of ti-sysc, will do pm_runtime_force_xxx() calls at noirq suspend stage by adding: SET_NOIRQ_SY

[PATCH v5 00/12] PCI: brcmstb: enable PCIe for STB chips

2020-06-17 Thread Jim Quinlan
Patchset Summary: Enhance a PCIe host controller driver. Because of its unusual design we are foced to change dev->dma_pfn_offset into a more general role allowing multiple offsets. v5: Commit "device core: Introduce multiple dma pfn offsets" -- in of/address.c: "map_size = 0" => "*map_

[PATCH v5 08/12] device core: Introduce multiple dma pfn offsets

2020-06-17 Thread Jim Quinlan
The new field in struct device 'dma_pfn_offset_map' is used to facilitate the use of single or multiple pfn offsets between cpu addrs and dma addrs. It subsumes the role of dev->dma_pfn_offset -- a uniform offset. The function of_dma_get_range() has been modified to take two additional arguments:

Re: [PATCH] drm/mgag200: Don't set in MISC

2020-06-17 Thread Thomas Zimmermann
Hi Am 17.06.20 um 11:22 schrieb Rong Chen: > On Wed, Jun 17, 2020 at 08:28:02AM +0200, Thomas Zimmermann wrote: >> Hi Emil >> >> Am 16.06.20 um 17:14 schrieb Emil Velikov: >>> Hi Thomas, >>> >>> On Tue, 16 Jun 2020 at 15:26, Thomas Zimmermann wrote: The original modesetting code set MIS

Re: [PATCH v5 08/12] device core: Introduce multiple dma pfn offsets

2020-06-17 Thread Robin Murphy
Hi Jim, Thanks for taking this on! On 2020-06-16 21:55, Jim Quinlan wrote: The new field in struct device 'dma_pfn_offset_map' is used to facilitate the use of single or multiple pfn offsets between cpu addrs and dma addrs. It subsumes the role of dev->dma_pfn_offset -- a uniform offset. This

[Bug 206017] Kernel 5.4.x unusable with GUI due to crashes (some hard)

2020-06-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206017 --- Comment #19 from udo (udo...@xs4all.nl) --- Appears to work OK for me: AMD Ryzen 5 3400G with Radeon Vega Graphics on Gigabyte X570 AORUS PRO, Fedora 31, git mesa, kernel.org 5.6.x, etc amdgpu.gttsize=8192 amdgpu.lockup_timeout=1000 amdgpu.g

Re: [PATCH v3] drm/tegra: Add zpos property for cursor planes

2020-06-17 Thread Thierry Reding
On Tue, Jun 16, 2020 at 09:39:19PM +0300, Dmitry Osipenko wrote: > 16.06.2020 21:14, Thierry Reding пишет: > > From: Thierry Reding > > > > As of commit 4dc55525b095 ("drm: plane: Verify that no or all planes > > have a zpos property") a warning is emitted if there's a mix of planes > > with and

Re: [PATCH v3] drm/panfrost: Reduce the amount of logs on deferred probe

2020-06-17 Thread Krzysztof Kozlowski
On Wed, May 27, 2020 at 04:43:34PM -0400, Alyssa Rosenzweig wrote: > Reviewed-by: Alyssa Rosenzweig > > On Wed, May 27, 2020 at 10:05:44PM +0200, Krzysztof Kozlowski wrote: > > There is no point to print deferred probe (and its failures to get > > resources) as an error. Also there is no need to

Re: [PATCH v3] drm/panfrost: Reduce the amount of logs on deferred probe

2020-06-17 Thread Steven Price
On 17/06/2020 15:15, Krzysztof Kozlowski wrote: On Wed, May 27, 2020 at 04:43:34PM -0400, Alyssa Rosenzweig wrote: Reviewed-by: Alyssa Rosenzweig On Wed, May 27, 2020 at 10:05:44PM +0200, Krzysztof Kozlowski wrote: There is no point to print deferred probe (and its failures to get resources)

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-06-17 Thread Kazlauskas, Nicholas
On 2020-06-17 5:58 a.m., Daniel Vetter wrote: On Wed, Jun 10, 2020 at 03:33:06PM -0700, Paulo Zanoni wrote: Em qui, 2020-05-28 às 11:09 +0530, Karthik B S escreveu: Add enable/disable flip done functions and the flip done handler function which handles the flip done interrupt. Enable the flip

Re: [PATCH v2 02/22] drm: mxsfb: Use drm_panel_bridge

2020-06-17 Thread Stefan Agner
On 2020-05-30 05:09, Laurent Pinchart wrote: > Replace the manual connector implementation based on drm_panel with the > drm_panel_bridge helper. This simplifies the mxsfb driver by removing > connector-related code, and standardizing all pipeline control > operations on bridges. > > A hack is nee

Re: [PATCH v2 6/6] drm/i915/dp_mst: Ensure the DPCD ACT sent flag is cleared before waiting for it

2020-06-17 Thread Lyude Paul
Reviewed-by: Lyude Paul Thanks for all the subtle fixes for broken MST displays, these are always my favorite to find :) On Wed, 2020-06-17 at 00:11 +0300, Imre Deak wrote: > Atm, we clear the ACT sent flag in the sink's DPCD before updating the > sink's payload table, along clearing the payload

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-06-17 Thread Ville Syrjälä
On Wed, Jun 17, 2020 at 11:58:10AM +0200, Daniel Vetter wrote: > On Wed, Jun 10, 2020 at 03:33:06PM -0700, Paulo Zanoni wrote: > > Em qui, 2020-05-28 às 11:09 +0530, Karthik B S escreveu: > > > Add enable/disable flip done functions and the flip done handler > > > function which handles the flip do

Re: [PATCH v6 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-06-17 Thread Rob Herring
On Tue, Jun 16, 2020 at 5:15 AM Stephen Boyd wrote: > > Quoting Tanmay Shah (2020-06-11 18:50:26) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > > b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > > new file mode 100644 > > index ..5fdb9

[PATCH][next] drm/mm/selftests: fix unsigned comparison with less than zero

2020-06-17 Thread Colin King
From: Colin Ian King Function get_insert_time can return error values that are cast to a u64. The checks of insert_time1 and insert_time2 check for the errors but because they are u64 variables the check for less than zero can never be true. Fix this by casting the value to s64 to allow of the ne

Re: [PATCH v2 22/22] drm: mxsfb: Support the alpha plane

2020-06-17 Thread Stefan Agner
On 2020-05-30 05:10, Laurent Pinchart wrote: > The LCDIF in the i.MX6SX and i.MX7 have a second plane called the alpha > plane. Support it. > > Signed-off-by: Laurent Pinchart Looks good to me. Reviewed-by: Stefan Agner -- Stefan > --- > Changes since v1: > > - Split whitespace cleanup to a

Re: [PATCH v3] drm/tegra: Add zpos property for cursor planes

2020-06-17 Thread Thierry Reding
On Wed, Jun 17, 2020 at 05:20:14PM +0300, Dmitry Osipenko wrote: > 17.06.2020 17:10, Thierry Reding пишет: > > On Tue, Jun 16, 2020 at 09:39:19PM +0300, Dmitry Osipenko wrote: > >> 16.06.2020 21:14, Thierry Reding пишет: > >>> From: Thierry Reding > >>> > >>> As of commit 4dc55525b095 ("drm: plane

[PATCH v3 01/22] drm: mxsfb: Remove fbdev leftovers

2020-06-17 Thread Laurent Pinchart
Commit 8e93f1028d74 ("drm/mxsfb: Use drm_fbdev_generic_setup()") replaced fbdev handling with drm_fbdev_generic_setup() but left inclusion of the drm/drm_fb_cma_helper.h header. Remove it. Fixes: 8e93f1028d74 ("drm/mxsfb: Use drm_fbdev_generic_setup()") Signed-off-by: Laurent Pinchart Reviewed-by

[PATCH v3 04/22] drm: mxsfb: Remove unused macros from mxsfb_regs.h

2020-06-17 Thread Laurent Pinchart
mxsfb_regs.h defines macros related to register bits. Some of them are not used and don't clearly map to any particular register, so their purpose isn't known. Remove them. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner Reviewed-by: Emil Velikov --- drivers/gpu/drm/mxsfb/mxsfb_regs.

[PATCH v3 03/22] drm: mxsfb: Use BIT() macro to define register bitfields

2020-06-17 Thread Laurent Pinchart
Using BIT() is preferred over manual shifts as it's more readable, handles the 1 << 31 case properly, and avoids other mistakes as shown by the DEBUG0_HSYNC and DEBUG0_VSYNC bits (that are currently unused). Use it. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner Reviewed-by: Emil Veli

[PATCH v3 00/22] drm: mxsfb: Add i.MX7 support

2020-06-17 Thread Laurent Pinchart
Hello, This patch series adds i.MX7 support to the mxsfb driver. The eLCDIF instance found in the i.MX7 is backward-compatible with the already supported LCDC v4, but has extended features amongst which the most notable one is a second plane. The first 10 patches (01/22 to 10/22) contain miscella

[PATCH v3 07/22] drm: mxsfb: Use LCDC_CTRL register name explicitly

2020-06-17 Thread Laurent Pinchart
The LCDC_CTRL register is located at address 0x. Some of the accesses to the register simply use the mxsfb->base address. Reference the LCDC_CTRL register explicitly instead to clarify the code. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner Reviewed-by: Emil Velikov --- drivers

[PATCH v3 08/22] drm: mxsfb: Remove register definitions from mxsfb_crtc.c

2020-06-17 Thread Laurent Pinchart
mxsfb_crtc.c defines several macros related to register addresses and bit, which duplicates macros from mxsfb_regs.h. Use the macros from mxsfb_regs.h instead and remove them. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner Reviewed-by: Emil Velikov --- drivers/gpu/drm/mxsfb/mxsfb_cr

[PATCH v3 06/22] drm: mxsfb: Pass mxsfb_drm_private pointer to mxsfb_reset_block()

2020-06-17 Thread Laurent Pinchart
The mxsfb_reset_block() function isn't special, pass it the mxsfb_drm_private pointer instead of a pointer to the base address. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner Reviewed-by: Emil Velikov --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 12 ++-- 1 file changed, 6 insert

[PATCH v3 10/22] drm: mxsfb: Rename mxsfb_crtc.c to mxsfb_kms.c

2020-06-17 Thread Laurent Pinchart
The mxsfb_crtc.c file doesn't handle just the CRTC, but also the other KMS objects. Rename it accordingly. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner Reviewed-by: Emil Velikov --- drivers/gpu/drm/mxsfb/Makefile | 2 +- drivers/gpu/drm/mxsfb/{mxsfb_crtc.c =>

[PATCH v3 05/22] drm: mxsfb: Clarify format and bus width configuration

2020-06-17 Thread Laurent Pinchart
Replace the convoluted way to set the format and bus width through difficult to read macros with more explicit ones. Also remove the outdated comment related to the limitations on bus width setting as it doesn't apply anymore (the bus width can be specified through the display_info bus format). Si

[PATCH v3 11/22] drm: mxsfb: Stop using DRM simple display pipeline helper

2020-06-17 Thread Laurent Pinchart
The DRM simple display pipeline helper only supports a single plane. In order to prepare for support of the alpha plane on i.MX6SX and i.MX7, move away from the helper. No new feature is added. Signed-off-by: Laurent Pinchart Reviewed-by: Emil Velikov Reviewed-by: Stefan Agner --- Changes since

[PATCH v3 13/22] drm: mxsfb: Don't touch AXI clock in IRQ context

2020-06-17 Thread Laurent Pinchart
The driver attempts agressive power management by enabling and disabling the AXI clock around register accesses. This results in attempts to enable and disable the clock in the IRQ handler, which is a no-go as preparing or unpreparing the clock may sleep. On the other hand, the driver enables the

[PATCH v3 14/22] drm: mxsfb: Enable vblank handling

2020-06-17 Thread Laurent Pinchart
Enable vblank handling when the CRTC is turned on and disable it when it is turned off. This requires moving vblank init after the KMS pipeline initialisation, otherwise drm_vblank_init() gets called with 0 CRTCs. Signed-off-by: Laurent Pinchart Reviewed-by: Emil Velikov Reviewed-by: Stefan Agne

  1   2   >