Re: [PATCH 1/2] drm/shmem: add support for per object dma api operations

2020-06-15 Thread Thomas Zimmermann
Hi Am 12.06.20 um 20:54 schrieb Gurchetan Singh: > On Fri, Jun 12, 2020 at 3:17 AM Gerd Hoffmann wrote: >> >> On Fri, Jun 12, 2020 at 11:47:55AM +0200, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 12.06.20 um 03:36 schrieb Gurchetan Singh: This is useful for the next patch. Also, should we on

Re: [PATCH 1/2] drm/shmem: add support for per object dma api operations

2020-06-15 Thread Gerd Hoffmann
On Fri, Jun 12, 2020 at 11:54:54AM -0700, Gurchetan Singh wrote: > Plus, I just realized the virtio dma ops and ops used by drm shmem are > different, so virtio would have to unconditionally have to skip the > shmem path. Perhaps the best policy is to revert d323bb44e4d2? Reverting d323bb44e4d2

Re: [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit

2020-06-15 Thread Markus Elfring
> in panfrost_job_hw_submit, … * Can the term “reference count” become relevant also for this commit message besides other possible adjustments? * Would you like to add the tag “Fixes”? … > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c … > @@ -184,6 +183,9 @@ static void panfrost_job_hw_subm

Re: [RFC PATCH 0/4] DSI/DBI and TinyDRM driver

2020-06-15 Thread Paul Cercueil
Hi Noralf, Le dim. 14 juin 2020 à 18:36, Noralf Trønnes a écrit : Den 07.06.2020 15.38, skrev Paul Cercueil: Hi, Here's a follow-up on the previous discussion about the current state of DSI/DBI panel drivers, TinyDRM, and the need of a cleanup. This patchset introduces the followin

[PATCH] drm/noveau: fix reference count leak in nouveau_fbcon_open

2020-06-15 Thread Aditya Pakki
nouveau_fbcon_open() calls calls pm_runtime_get_sync() that increments the reference count. In case of failure, decrement the ref count before returning the error. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) di

[PATCH v7 0/6] Support DRM bridges on NVIDIA Tegra

2020-06-15 Thread Dmitry Osipenko
Hello, This series adds initial support for the DRM bridges to NVIDIA Tegra DRM driver. This is required by newer device-trees where we model the LVDS encoder bridge properly. Changelog: v7: - Removed the obscure unused structs (which GCC doesn't detect, but CLANG does) in the patch "Wrap

[PATCH] drm/exynos: fix ref count leak in mic_pre_enable

2020-06-15 Thread Navid Emamdoost
in mic_pre_enable, pm_runtime_get_sync is called which increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/exynos/exynos_drm_mic.c | 2 +- 1 file changed,

[PATCH v1 3/6] drm/panel: lvds: Set up panel orientation

2020-06-15 Thread Dmitry Osipenko
The panel orientation needs to parsed from a device-tree and assigned to the panel's connector in order to make orientation property available to userspace. That's what this patch does for the generic LVDS panel. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/panel/panel-lvds.c | 6 ++ 1

Re: [PATCH] drm/amdgpu: fix ref count leak in amdgpu_display_crtc_set_config

2020-06-15 Thread Markus Elfring
> in amdgpu_display_crtc_set_config, … * Can the term “reference count” become relevant also for this commit message besides other possible adjustments? * Can it be nicer to combine proposed updates for this software module as a patch series (with a cover letter)? * Would you like to add the

[PATCH] drm/vc4: fix ref count leak in vc4_vec_encoder_enable

2020-06-15 Thread Navid Emamdoost
in vc4_vec_encoder_enable, the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/vc4/vc4_vec.c | 8 +--- 1 file changed,

Re: [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit

2020-06-15 Thread Markus Elfring
> in panfrost_job_hw_submit, … * Can the term “reference count” become relevant also for this commit message besides other possible adjustments? * Would you like to add the tag “Fixes”? … > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c … > @@ -184,6 +183,9 @@ static void panfrost_job_hw_subm

[PATCH] drm/nouveau: fix multiple instances of reference count leaks

2020-06-15 Thread Aditya Pakki
On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the ref count before returning the error. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/nouveau/nouveau_drm.c | 8 ++-- drivers/gpu/drm/nouveau/nouveau_gem.c | 4 +++- 2 files c

Re: [PATCH] drm/vc4: fix ref count leak in vc4_dsi_encoder_enable

2020-06-15 Thread Navid Emamdoost
On Sun, Jun 14, 2020 at 7:32 AM Andy Shevchenko wrote: > > On Sun, Jun 14, 2020 at 9:55 AM Navid Emamdoost > wrote: > > > > in vc4_dsi_encoder_enable, the call to pm_runtime_get_sync increments > > the counter even in case of failure, leading to incorrect > > ref count. In case of failure, decrem

Re: [PATCH v3 0/6] Add support for GPU DDR BW scaling

2020-06-15 Thread Viresh Kumar
On 06-06-20, 09:55, Sharat Masetty wrote: > This is a respin of [1]. Incorported review feedback and fixed issues observed > during testing. Picked up the Georgi's series from opp/linux-next [2], and > this > series is also dependent on a helper function needed to set and clear ddr > bandwidth vot

[PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit

2020-06-15 Thread Navid Emamdoost
in panfrost_job_hw_submit, pm_runtime_get_sync is called which increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/panfrost/panfrost_job.c | 8 +--- 1

[PATCH] drm/i915: remove unnecessary conversion to bool

2020-06-15 Thread Bernard Zhao
In function perform_bb_shadow, bb->ppgtt is bool, so maybe there is no need to convert the bool condition to bool. This change is to make the code a bit readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH 00/29] Documentation fixes

2020-06-15 Thread Mauro Carvalho Chehab
Hi Jon, That's a bunch of files I have to be applied on the top of v5.8-rc1 fixing documentation warnings. I already removed some duplicated stuff. Regards, Mauro Mauro Carvalho Chehab (29): mm: vmalloc.c: remove a kernel-doc annotation from a removed parameter net: dev: add a missing kernel

[PATCH] drm/radeon: Fix reference count leaks caused by pm_runtime_get_sync

2020-06-15 Thread Aditya Pakki
On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/radeon/radeon_display.c | 4 +++- drivers/gpu/drm/radeon/radeon_drv.c | 4 +++- dri

[PATCH v1 4/6] drm/tegra: plane: Rename bottom_up to reflect_y

2020-06-15 Thread Dmitry Osipenko
This makes the naming consistent with the DRM core. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/dc.c| 10 +- drivers/gpu/drm/tegra/dc.h| 2 +- drivers/gpu/drm/tegra/plane.c | 2 +- drivers/gpu/drm/tegra/plane.h | 2 +- 4 files changed, 8 insertions(+), 8 deletions

[PATCH] drm/radeon: fix multiple reference count leak

2020-06-15 Thread Aditya Pakki
On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/radeon/radeon_connectors.c | 20 +++- 1 file changed, 15 insertions(+),

[PATCH v1 0/6] 180° rotation support for NVIDIA Tegra DRM

2020-06-15 Thread Dmitry Osipenko
Hello! This series adds 180° display plane rotation support to the NVIDIA Tegra DRM driver which is needed for devices that have display panel physically mounted upside-down, like Nexus 7 tablet device for example [1]. Since DRM panel rotation is a new thing for a userspace, currently only Openteg

[PATCH] drm/noveau: fix reference count leak in nv50_disp_atomic_commit

2020-06-15 Thread Aditya Pakki
nv50_disp_atomic_commit() calls calls pm_runtime_get_sync and in turn increments the reference count. In case of failure, decrement the ref count before returning the error. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 +++- 1 file changed, 3 insertions(+), 1 delet

[PATCH] drm/amd/display: fix ref count leak in amdgpu_drm_ioctl

2020-06-15 Thread Navid Emamdoost
in amdgpu_drm_ioctl the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2

[PATCH v2 0/5] 180 degrees rotation support for NVIDIA Tegra DRM

2020-06-15 Thread Dmitry Osipenko
Hello! This series adds 180° display plane rotation support to the NVIDIA Tegra DRM driver which is needed for devices that have display panel physically mounted upside-down, like Nexus 7 tablet device for example [1]. Since DRM panel rotation is a new thing for a userspace, currently only Openteg

[PATCH v2 5/5] drm/tegra: plane: Support 180° rotation

2020-06-15 Thread Dmitry Osipenko
Combining horizontal and vertical reflections gives us 180 degrees of rotation. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/dc.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c index f31bca27cd

[PATCH 3/3] drm/tiny: add support for tft displays based on ilitek, ili9488

2020-06-15 Thread Kamlesh Gurudasani
This adds support fot ilitek,ili9488 based displays with 4 wire spi interface. In 4 wire spi mode, ili9488 only supports 18 bit per pixel. Eastrising,er-tft035-6 is a display based on ilitek,ili9488 with 4 wire spi interface. Signed-off-by: Kamlesh Gurudasani --- MAINTAINERS

[PATCH] drm/vc4: fix ref count leak in vc4_v3d_pm_get

2020-06-15 Thread Navid Emamdoost
in vc4_v3d_pm_get, the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/vc4/vc4_v3d.c | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit

2020-06-15 Thread Markus Elfring
> in panfrost_job_hw_submit, … * Can the term “reference count” become relevant also for this commit message besides other possible adjustments? * Would you like to add the tag “Fixes”? … > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c … > @@ -184,6 +183,9 @@ static void panfrost_job_hw_subm

[PATCH] drm/v3d: fix reference count leaks due to pm_runtime_get_sync

2020-06-15 Thread Aditya Pakki
On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/v3d/v3d_debugfs.c | 8 ++-- drivers/gpu/drm/v3d/v3d_drv.c | 4 +++- drivers/gpu

[PATCH] drm/panfrost: perfcnt: fix ref count leak in panfrost_perfcnt_enable_locked

2020-06-15 Thread Navid Emamdoost
in panfrost_perfcnt_enable_locked, pm_runtime_get_sync is called which increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/panfrost/panfrost_perfcnt.c | 10

[PATCH] drm/nouveau: Fix reference count leak in nouveau_connector_detect

2020-06-15 Thread Aditya Pakki
nouveau_connector_detect() calls pm_runtime_get_sync and in turn increments the reference count. In case of failure, decrement the ref count before returning the error. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/nouveau/nouveau_connector.c | 4 +++- 1 file changed, 3 insertions(+), 1 deleti

[PATCH v7 6/6] drm/tegra: output: rgb: Wrap directly-connected panel into DRM bridge

2020-06-15 Thread Dmitry Osipenko
Currently Tegra DRM driver manually manages display panel, but this management could be moved out into DRM core if we'll wrap panel into DRM bridge. This patch wraps RGB panel into a DRM bridge and removes manual handling of the panel from the RGB output code. Suggested-by: Laurent Pinchart Acked

[PATCH v7 4/6] drm/tegra: output: Support DRM bridges

2020-06-15 Thread Dmitry Osipenko
Newer Tegra device-trees will specify a video output graph which involves a bridge. This patch adds initial support for the DRM bridges to the Tegra DRM output. Acked-by: Sam Ravnborg Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/drm.h| 2 ++ drivers/gpu/drm/tegra/output.c | 12

[PATCH 0/3] Support for tft displays based on ilitek,ili9488

2020-06-15 Thread Kamlesh Gurudasani
The goal of this series is to get the displays based on ilitek,ili9488 working. Eastrising,er-tft035-6 is a display based on ilitek,ili9488 Kamlesh Gurudasani (3): dt-bindings: add vendor prefix for EastRising Technology Co.,Ltd dt-bindings: add binding for Ilitek ili9488 based display panels

[PATCH v2] drm/exynos: fix ref count leak in mic_pre_enable

2020-06-15 Thread Navid Emamdoost
in mic_pre_enable, pm_runtime_get_sync is called which increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- Changes in v2: - reuse the unlock label and call pm_runti

Re: [PATCH] mtd: rawnand: brcmnand: force raw OOB writes

2020-06-15 Thread Kamal Dasu
Alvaro, On Sat, Jun 13, 2020 at 5:01 AM Álvaro Fernández Rojas wrote: > > Hi Kamal, > > > El 12 jun 2020, a las 20:47, Kamal Dasu escribió: > > > > On Fri, Jun 5, 2020 at 1:07 PM Álvaro Fernández Rojas > > wrote: > >> > >> MTD_OPS_AUTO_OOB is writting OOB with ECC enabled, which changes all E

[PATCH v2 3/5] drm/tegra: plane: Rename bottom_up to reflect_y

2020-06-15 Thread Dmitry Osipenko
This makes the naming consistent with the DRM core. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/dc.c| 10 +- drivers/gpu/drm/tegra/dc.h| 2 +- drivers/gpu/drm/tegra/plane.c | 2 +- drivers/gpu/drm/tegra/plane.h | 2 +- 4 files changed, 8 insertions(+), 8 deletions

[PATCH v1 5/6] drm/tegra: plane: Support horizontal reflection mode

2020-06-15 Thread Dmitry Osipenko
Support horizontal reflection mode which will allow to support 180° rotation mode when combined with the vertical reflection. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/dc.c| 24 drivers/gpu/drm/tegra/dc.h| 1 + drivers/gpu/drm/tegra/plane.c | 1 +

[PATCH v2 1/5] drm/panel: Add helper for reading DT rotation

2020-06-15 Thread Dmitry Osipenko
From: Derek Basehore This adds a helper function for reading the rotation (panel orientation) from the device tree. Signed-off-by: Derek Basehore Reviewed-by: Sam Ravnborg Tested-by: Dmitry Osipenko Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/drm_panel.c | 43

Re: [PATCH] drm/vc4: fix ref count leak in vc4_dsi_encoder_enable

2020-06-15 Thread Markus Elfring
> in vc4_dsi_encoder_enable, the call to pm_runtime_get_sync increments > the counter even in case of failure, leading to incorrect > ref count. In case of failure, decrement the ref count before returning. * Can the term “reference count” become relevant also for this commit message besides oth

[PATCH] drm/amdkfd: Fix reference count leaks.

2020-06-15 Thread wu000273
From: Qiushi Wu kobject_init_and_add() takes reference even when it fails. If this function returns an error, kobject_put() must be called to properly clean up the memory associated with the object. Signed-off-by: Qiushi Wu --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 20 +++

[PATCH] drm/amdgpu: fix ref count leak in amdgpu_display_crtc_set_config

2020-06-15 Thread Navid Emamdoost
in amdgpu_display_crtc_set_config, the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 5 +++-

[PATCH v2 4/5] drm/tegra: plane: Support horizontal reflection mode

2020-06-15 Thread Dmitry Osipenko
Support horizontal reflection mode which will allow to support 180° rotation mode when combined with the vertical reflection. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/dc.c| 24 drivers/gpu/drm/tegra/dc.h| 1 + drivers/gpu/drm/tegra/plane.c | 1 +

Re: [PATCH] drm/exynos: fix ref count leak in mic_pre_enable

2020-06-15 Thread Navid Emamdoost
On Sun, Jun 14, 2020 at 7:47 PM Inki Dae wrote: > > Hi, > > 20. 6. 14. 오후 3:23에 Navid Emamdoost 이(가) 쓴 글: > > in mic_pre_enable, pm_runtime_get_sync is called which > > increments the counter even in case of failure, leading to incorrect > > ref count. In case of failure, decrement the ref count b

Re: [PATCH v1 2/6] drm/panel: Set display info in panel attach

2020-06-15 Thread Dmitry Osipenko
14.06.2020 22:03, Dmitry Osipenko пишет: > From: Derek Basehore > > Devicetree systems can set panel orientation via a panel binding, but > there's no way, as is, to propagate this setting to the connector, > where the property need to be added. > To address this, this patch sets orientation, as

[PATCH 2/3] dt-bindings: add binding for Ilitek ili9488 based display panels

2020-06-15 Thread Kamlesh Gurudasani
This adds binding for ilitek,ili9488 based display panels Signed-off-by: Kamlesh Gurudasani --- .../bindings/display/ilitek,ili9488.yaml | 71 ++ 1 file changed, 71 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9488.yaml dif

[PATCH] drm/bridge: fix reference count leaks due to pm_runtime_get_sync()

2020-06-15 Thread Aditya Pakki
On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/bridge/cdns-dsi.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff -

[PATCH v7 1/6] of_graph: add of_graph_get_local_port()

2020-06-15 Thread Dmitry Osipenko
In some case, like a DRM display code for example, it's useful to silently check whether port node exists at all in a device-tree before proceeding with parsing the graph. This patch adds of_graph_get_local_port() which returns pointer to a local port node, or NULL if graph isn't specified in a de

[PATCH v1 6/6] drm/tegra: plane: Support 180° rotation

2020-06-15 Thread Dmitry Osipenko
Combining horizontal and vertical reflections gives us 180 degrees of rotation. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/dc.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c index f31bca27cd

[PATCH] drm/amdgpu: fix ref count leak in amdgpu_driver_open_kms

2020-06-15 Thread Navid Emamdoost
in amdgpu_driver_open_kms the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 3 ++- 1 file chang

Re: [PATCH] mtd: rawnand: brcmnand: force raw OOB writes

2020-06-15 Thread Álvaro Fernández Rojas
Hi Kamal, > El 13 jun 2020, a las 17:16, Kamal Dasu escribió: > > Alvaro, > > > On Sat, Jun 13, 2020 at 5:01 AM Álvaro Fernández Rojas > wrote: >> >> Hi Kamal, >> >>> El 12 jun 2020, a las 20:47, Kamal Dasu escribió: >>> >>> On Fri, Jun 5, 2020 at 1:07 PM Álvaro Fernández Rojas >>> wrot

[PATCH v7 5/6] drm/tegra: output: rgb: Support LVDS encoder bridge

2020-06-15 Thread Dmitry Osipenko
Newer Tegra device-trees will specify a video output graph, which involves LVDS encoder bridge. This patch adds support for the LVDS encoder bridge to the RGB output, allowing us to model the display hardware properly. Reviewed-by: Laurent Pinchart Acked-by: Sam Ravnborg Signed-off-by: Dmitry Os

[PATCH v1 2/6] drm/panel: Set display info in panel attach

2020-06-15 Thread Dmitry Osipenko
From: Derek Basehore Devicetree systems can set panel orientation via a panel binding, but there's no way, as is, to propagate this setting to the connector, where the property need to be added. To address this, this patch sets orientation, as well as other fixed values for the panel, in the drm_

[PATCH 1/3] dt-bindings: add vendor prefix for EastRising Technology Co., Ltd

2020-06-15 Thread Kamlesh Gurudasani
Add vendor prefix for display manufacturer company EastRising Technology Co.,Ltd [1]https://eastrising.en.ec21.com/ Signed-off-by: Kamlesh Gurudasani --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/binding

[PATCH] omapfb: fix multiple reference count leaks due to pm_runtime_get_sync

2020-06-15 Thread Aditya Pakki
On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Aditya Pakki --- drivers/video/fbdev/omap2/omapfb/dss/dispc.c | 7 +-- drivers/video/fbdev/omap2/omapfb/dss/dsi.c

Re: [PATCH] drm/etnaviv: fix ref count leak via pm_runtime_get_sync

2020-06-15 Thread Navid Emamdoost
On Sun, Jun 14, 2020 at 4:48 AM Andy Shevchenko wrote: > > On Sun, Jun 14, 2020 at 9:48 AM Navid Emamdoost > wrote: > > ... > > > + if (ret < 0) { > > > + pm_runtime_put(gpu->dev); > > Please, in all your patches fix this to be _put_noidle(). We wouldn't > bear

[PATCH] drm/amdgpu/display: fix ref count leak when pm_runtime_get_sync fails

2020-06-15 Thread Navid Emamdoost
The call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 16 1 file changed, 1

[PATCH v2 2/5] drm/panel: lvds: Set up panel orientation

2020-06-15 Thread Dmitry Osipenko
The panel orientation needs to parsed from a device-tree and assigned to the panel's connector in order to make orientation property available to userspace. That's what this patch does for the generic LVDS panel. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/panel/panel-lvds.c | 8

[PATCH] drm/vc4: fix ref count leak in vc4_dsi_encoder_enable

2020-06-15 Thread Navid Emamdoost
in vc4_dsi_encoder_enable, the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/vc4/vc4_dsi.c | 10 ++ 1 file change

[PATCH v7 3/6] drm/tegra: output: Don't leak OF node on error

2020-06-15 Thread Dmitry Osipenko
The OF node should be put before returning error in tegra_output_probe(), otherwise node's refcount will be leaked. Reviewed-by: Laurent Pinchart Reviewed-by: Sam Ravnborg Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/output.c | 9 - 1 file changed, 4 insertions(+), 5 deleti

[PATCH] drm/etnaviv: fix ref count leak via pm_runtime_get_sync

2020-06-15 Thread Navid Emamdoost
in etnaviv_gpu_submit, etnaviv_gpu_recover_hang, etnaviv_gpu_debugfs, and etnaviv_gpu_init the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost -

[PATCH] drm/noveau: fix reference count leak in nouveau_debugfs_strap_peek

2020-06-15 Thread Aditya Pakki
nouveau_debugfs_strap_peek() calls pm_runtime_get_sync() that increments the reference count. In case of failure, decrement the ref count before returning the error. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[PATCH v1 1/6] drm/panel: Add helper for reading DT rotation

2020-06-15 Thread Dmitry Osipenko
From: Derek Basehore This adds a helper function for reading the rotation (panel orientation) from the device tree. Signed-off-by: Derek Basehore Reviewed-by: Sam Ravnborg Tested-by: Dmitry Osipenko Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/drm_panel.c | 43

[PATCH v7 2/6] drm/of: Make drm_of_find_panel_or_bridge() to check graph's presence

2020-06-15 Thread Dmitry Osipenko
When graph isn't defined in a device-tree, the of_graph_get_remote_node() prints a noisy error message, telling that port node is not found. This is undesirable behaviour in our case because absence of a panel/bridge graph is a valid case. Let's check presence of the local port in a device-tree bef

[PATCH v2] drm/etnaviv: fix ref count leak via pm_runtime_get_sync

2020-06-15 Thread Navid Emamdoost
in etnaviv_gpu_submit, etnaviv_gpu_recover_hang, etnaviv_gpu_debugfs, and etnaviv_gpu_init the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost -

Re: [PATCH 14/29] dt: Fix broken references to renamed docs

2020-06-15 Thread Philipp Zabel
On Mon, 2020-06-15 at 08:46 +0200, Mauro Carvalho Chehab wrote: > Some files got renamed. Those were all fixed automatically by > > ./scripts/documentation-file-ref-check --fix > > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt |

[PATCH 26/38] vt: use newly defined CUR_* macros

2020-06-15 Thread Jiri Slaby
We defined macros for all the magic constants in the previous patch. So let us use the macro in the code now. No functional change intended. Signed-off-by: Jiri Slaby Cc: Thomas Winischhofer Cc: Bartlomiej Zolnierkiewicz Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: linux-...@vger.kernel.o

[PATCH 25/38] vt: redefine world of cursor macros

2020-06-15 Thread Jiri Slaby
The cursor code used to use magic constants, ANDs, ORs, and some macros. Redefine all this to make some sense. In particular: * Drop CUR_DEFAULT, which is CUR_UNDERLINE. CUR_DEFAULT was used only for cur_default variable initialization, so use CUR_UNDERLINE there to make obvious what's the def

[Bug 208179] New: [amdgpu] black screen after exiting X

2020-06-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208179 Bug ID: 208179 Summary: [amdgpu] black screen after exiting X Product: Drivers Version: 2.5 Kernel Version: 5.7.2 Hardware: All OS: Linux Tree: Mainline

Re: [PATCH 9/9] drm/shmem-helpers: Simplify dma-buf importing

2020-06-15 Thread Thomas Zimmermann
Hi Daniel this patch causes a segmentation fault. Am 11.05.20 um 11:35 schrieb Daniel Vetter: > - Ditch the ->pages array > - Make it a private gem bo, which means no shmem object, which means > fireworks if anyone calls drm_gem_object_get_pages. But we've just > made sure that's all covered.

Re: [PATCH] drm/ttm: Fix dma_fence refcnt leak when adding move fence

2020-06-15 Thread Christian König
Am 13.06.20 um 14:30 schrieb Xiyu Yang: ttm_bo_add_move_fence() invokes dma_fence_get(), which returns a reference of the specified dma_fence object to "fence" with increased refcnt. When ttm_bo_add_move_fence() returns, local variable "fence" becomes invalid, so the refcount should be decreased

Re: [PATCH v3 5/5] dt-bindings: display: ti,tfp410.yaml: make the ports node optional

2020-06-15 Thread Ricardo Cañuelo
Hi Laurent, Thanks for reviewing the patch On Thu, 2020-06-11 at 19:08 +0300, Laurent Pinchart wrote: > Hi Ricardo, > > Thank you for the patch. > > On Thu, Jun 11, 2020 at 12:23:56PM +0200, Ricardo Cañuelo wrote: > > Make the ports node optional, since there are some DTs that don't define > >

Re: [PATCH 14/29] dt: Fix broken references to renamed docs

2020-06-15 Thread Mark Brown
On Mon, Jun 15, 2020 at 08:46:53AM +0200, Mauro Carvalho Chehab wrote: > Some files got renamed. Those were all fixed automatically by > > ./scripts/documentation-file-ref-check --fix Acked-by: Mark Brown signature.asc Description: PGP signature __

Re: [PATCH 13/29] dt: fix broken links due to txt->yaml renames

2020-06-15 Thread Mark Brown
On Mon, Jun 15, 2020 at 08:46:52AM +0200, Mauro Carvalho Chehab wrote: > There are some new broken doc links due to yaml renames > at DT. Developers should really run: I also previously acked this one in 20200504100822.ga5...@sirena.org.uk. Has anything changed here to cause the ack to be dropped?

[PATCH] drm/ttm: Fix dma_fence refcnt leak when adding move fence

2020-06-15 Thread Xiyu Yang
ttm_bo_add_move_fence() invokes dma_fence_get(), which returns a reference of the specified dma_fence object to "fence" with increased refcnt. When ttm_bo_add_move_fence() returns, local variable "fence" becomes invalid, so the refcount should be decreased to keep refcount balanced. The reference

[PATCH] drm/ttm: Fix dma_fence refcnt leak in ttm_bo_vm_fault_reserved

2020-06-15 Thread Xiyu Yang
ttm_bo_vm_fault_reserved() invokes dma_fence_get(), which returns a reference of the specified dma_fence object to "moving" with increased refcnt. When ttm_bo_vm_fault_reserved() returns, local variable "moving" becomes invalid, so the refcount should be decreased to keep refcount balanced. The r

[PATCH] drm/vc4: Fix an error code vc4_create_object()

2020-06-15 Thread Dan Carpenter
The vc4_create_object() needs to return NULL on error, not error pointers. If it returns an error pointer then that will lead to an Oops in the callers. Fortunately, in current kernels small allocations always succed so this will never happen. Fixes: c826a6e10644 ("drm/vc4: Add a BO cache.") Sig

Re: [PATCH 13/29] dt: fix broken links due to txt->yaml renames

2020-06-15 Thread Mauro Carvalho Chehab
Hi Mark, Em Mon, 15 Jun 2020 12:19:27 +0100 Mark Brown escreveu: > On Mon, Jun 15, 2020 at 08:46:52AM +0200, Mauro Carvalho Chehab wrote: > > There are some new broken doc links due to yaml renames > > at DT. Developers should really run: > > I also previously acked this one in 20200504100822

Re: [PATCH] drivers/video/backlight: Use kobj_to_dev() instead

2020-06-15 Thread Daniel Thompson
On Mon, Jun 15, 2020 at 04:54:02PM +0800, Wang Qing wrote: > Use kobj_to_dev() instead of container_of() > > Signed-off-by: Wang Qing Reviewed-by: Daniel Thompson > --- > drivers/video/backlight/lm3533_bl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > mode change 100644 => 10075

Re: [PATCH 13/29] dt: fix broken links due to txt->yaml renames

2020-06-15 Thread Mark Brown
On Mon, Jun 15, 2020 at 01:57:39PM +0200, Mauro Carvalho Chehab wrote: > Mark Brown escreveu: > > On Mon, Jun 15, 2020 at 08:46:52AM +0200, Mauro Carvalho Chehab wrote: > > > There are some new broken doc links due to yaml renames > > > at DT. Developers should really run: > > I also previously

[PATCH v6 4/6] drm/msm: dsi: Use OPP API to set clk/perf state

2020-06-15 Thread Rajendra Nayak
On SDM845 DSI needs to express a perforamnce state requirement on a power domain depending on the clock rates. Use OPP table from DT to register with OPP framework and use dev_pm_opp_set_rate() to set the clk/perf state. Signed-off-by: Rajendra Nayak Cc: Rob Clark Cc: Sean Paul Cc: dri-devel@li

[PATCH v6 3/6] drm/msm/dpu: Use OPP API to set clk/perf state

2020-06-15 Thread Rajendra Nayak
On some qualcomm platforms DPU needs to express a performance state requirement on a power domain depending on the clock rates. Use OPP table from DT to register with OPP framework and use dev_pm_opp_set_rate() to set the clk/perf state. Signed-off-by: Rajendra Nayak Reviewed-by: Rob Clark Revie

[Bug 205497] Attempt to read amd gpu id causes a freeze

2020-06-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205497 Sling Shot (sling-s...@gmx.com) changed: What|Removed |Added CC||sling-s...@gmx.com ---

[PATCH] drm/panel-simple: fix connector type for LogicPD Type28 Display

2020-06-15 Thread Adam Ford
The LogicPD Type28 display used by several Logic PD products has not worked since v5.5. The connector type for the LogicPD Type 28 display is missing and drm_panel_bridge_add() requires connector type to be set. Signed-off-by: Adam Ford CC: sta...@vger.kernel.org #v5.5+ diff --git a/drivers/gpu

Re: [PATCH] drm/mediatek: remove unnecessary conversion to bool

2020-06-15 Thread Chun-Kuang Hu
Joe Perches 於 2020年6月15日 週一 上午4:41寫道: > > On Fri, 2020-06-12 at 20:40 +0800, Bernard Zhao wrote: > > In function mtk_dsi_clk_hs_state, remove unnecessary conversion > > to bool return, this change is to make the code a bit readable. > [] > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > > b/d

Re: [PATCH v2 1/4] drm/bridge: ti-sn65dsi86: Don't compile GPIO bits if not CONFIG_OF_GPIO

2020-06-15 Thread Doug Anderson
Hi, On Fri, Jun 12, 2020 at 12:31 PM Douglas Anderson wrote: > > The kernel test robot noted that if "OF" is defined (which is needed > to select DRM_TI_SN65DSI86 at all) but not OF_GPIO that we'd get > compile failures because some of the members that we access in "struct > gpio_chip" are only d

Re: [PATCH] drm/panel-simple: fix connector type for LogicPD Type28 Display

2020-06-15 Thread Fabio Estevam
On Mon, Jun 15, 2020 at 10:19 AM Adam Ford wrote: > > The LogicPD Type28 display used by several Logic PD products has not > worked since v5.5. Maybe you could tell which commit exactly and then put a Fixes tag? ___ dri-devel mailing list dri-devel@list

Re: [PATCH] drm/panel-simple: fix connector type for LogicPD Type28 Display

2020-06-15 Thread Adam Ford
On Mon, Jun 15, 2020 at 9:46 AM Fabio Estevam wrote: > > On Mon, Jun 15, 2020 at 10:19 AM Adam Ford wrote: > > > > The LogicPD Type28 display used by several Logic PD products has not > > worked since v5.5. > > Maybe you could tell which commit exactly and then put a Fixes tag? I honestly don't

[PATCH 1/3] drm/mm: remove unused rb_hole_size()

2020-06-15 Thread Christian König
Just some code cleanup. Signed-off-by: Christian König --- drivers/gpu/drm/drm_mm.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c index 82d2888eb7fe..425fcd3590e8 100644 --- a/drivers/gpu/drm/drm_mm.c +++ b/drivers/gpu/drm/drm_mm.c @@

[PATCH 2/3] drm/mm: optimize find_hole() as well

2020-06-15 Thread Christian König
Abort early if there isn't enough space to allocate from a subtree. Signed-off-by: Christian König --- drivers/gpu/drm/drm_mm.c| 11 +++ drivers/gpu/drm/selftests/test-drm_mm.c | 11 --- 2 files changed, 7 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/d

[PATCH 3/3] drm/mm: cleanup and improve next_hole_*_addr()

2020-06-15 Thread Christian König
Skipping just one branch of the tree is not the most effective approach. Instead use a macro to define the traversal functions and sort out both branch sides. This improves the performance of the unit tests by a factor of more than 4. Signed-off-by: Christian König --- drivers/gpu/drm/drm_mm.c

[PATCH] drm/shmem-helper: Fix obj->filp derefence

2020-06-15 Thread Daniel Vetter
I broke that in my refactoring: commit 7d2cd72a9aa3df3604cafd169a2d4a525afb68ca Author: Daniel Vetter Date: Fri May 29 16:05:42 2020 +0200 drm/shmem-helpers: Simplify dma-buf importing Reported-by: Thomas Zimmermann Fixes: 7d2cd72a9aa3 ("drm/shmem-helpers: Simplify dma-buf importing") Cc

Re: [PATCH 1/2] drm: mcde: Fix display initialization problem

2020-06-15 Thread Daniel Vetter
On Sun, Jun 14, 2020 at 11:29 PM Linus Walleij wrote: > > On Sun, Jun 14, 2020 at 9:44 AM Sam Ravnborg wrote: > > > Hi Linus. > > > > On Sun, Jun 14, 2020 at 12:30:26AM +0200, Linus Walleij wrote: > > > The following bug appeared in the MCDE driver/display > > > initialization during the recent m

Re: [PATCH v16 1/1] dt-bindings: display: mediatek: convert the dpi bindings to yaml

2020-06-15 Thread Rob Herring
On Sun, 14 Jun 2020 15:30:36 +0800, Jitao Shi wrote: > Convert display/mediatek/mediatek,dpi.txt to > display/mediatek/mediatek,dpi.yaml > and remove the old text bindings. > > Signed-off-by: Jitao Shi > --- > .../display/mediatek/mediatek,dpi.txt | 42 > .../display/mediatek/m

Re: [Intel-gfx] [PATCH] drm/i915/dp: DP PHY compliance for JSL

2020-06-15 Thread Ville Syrjälä
On Fri, Jun 12, 2020 at 12:38:59PM -0700, Manasi Navare wrote: > On Fri, Jun 12, 2020 at 10:21:31PM +0300, Ville Syrjälä wrote: > > On Fri, Jun 12, 2020 at 12:12:25PM -0700, Manasi Navare wrote: > > > On Fri, Jun 12, 2020 at 10:01:19PM +0300, Ville Syrjälä wrote: > > > > On Fri, Jun 12, 2020 at 11:

Re: [PATCH 1/3] drm/mm: remove unused rb_hole_size()

2020-06-15 Thread Nirmoy
Reviewed-by: Nirmoy Das On 6/15/20 4:54 PM, Christian König wrote: Just some code cleanup. Signed-off-by: Christian König --- drivers/gpu/drm/drm_mm.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c index 82d2888eb7fe..425fcd3590e

Re: [PATCH 3/3] drm/mm: cleanup and improve next_hole_*_addr()

2020-06-15 Thread Nirmoy
Reviewed-by: Nirmoy Das On 6/15/20 4:54 PM, Christian König wrote: Skipping just one branch of the tree is not the most effective approach. Instead use a macro to define the traversal functions and sort out both branch sides. This improves the performance of the unit tests by a factor of more

Re: [PATCH 2/3] drm/mm: optimize find_hole() as well

2020-06-15 Thread Nirmoy
Acked-by: Nirmoy Das On 6/15/20 4:54 PM, Christian König wrote: Abort early if there isn't enough space to allocate from a subtree. Signed-off-by: Christian König --- drivers/gpu/drm/drm_mm.c| 11 +++ drivers/gpu/drm/selftests/test-drm_mm.c | 11 --- 2 file

Re: [PATCH v2 5/5] drm/tegra: plane: Support 180° rotation

2020-06-15 Thread Ville Syrjälä
On Sun, Jun 14, 2020 at 11:01:21PM +0300, Dmitry Osipenko wrote: > Combining horizontal and vertical reflections gives us 180 degrees of > rotation. > > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/drm/tegra/dc.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > di

Re: [PATCH v2 1/2] drm: vmwgfx: remove drm_driver::master_set() return typ

2020-06-15 Thread Emil Velikov
On Fri, 5 Jun 2020 at 15:07, Emil Velikov wrote: > > On Wed, 3 Jun 2020 at 19:37, Roland Scheidegger wrote: > > > > Looks like a nice cleanup to me. (No idea if at some point there > > actually was a reason for a return value...) > > > It was required up-to quite recently actually: > > commit 9c8

  1   2   >