[RFC PATCH linux-next] drm/msm/dpu: dpu_setup_dspp_pcc() can be static

2020-05-21 Thread kbuild test robot
Fixes: 4259ff7ae509 ("drm/msm/dpu: add support for pcc color block in dpu driver") Signed-off-by: kbuild test robot --- dpu_hw_dspp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.

[RFC PATCH linux-next] drm/msm/a6xx: a6xx_hfi_send_start() can be static

2020-05-21 Thread kbuild test robot
Fixes: 8167e6fa76c8 ("drm/msm/a6xx: HFI v2 for A640 and A650") Signed-off-by: kbuild test robot --- a6xx_hfi.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_hfi.c b/drivers/gpu/drm/msm/adreno/a6xx_hfi.c index f9db69e771214..9921e632f

Re: [PATCH] drm/i915/hdcp: Avoid duplicate HDCP enables

2020-05-21 Thread Anshuman Gupta
On 2020-05-21 at 10:27:21 +0530, Ramalingam C wrote: > On 2020-05-20 at 15:47:44 -0400, Sean Paul wrote: > > From: Sean Paul > > > > If userspace sets the CP property to DESIRED while it's already ENABLED, > > the driver will try to re-enable HDCP. On some displays, this will > > result in R0' mi

Re: [PATCH 1/3] arm64: dts: mt8183: Add gce setting in display node

2020-05-21 Thread Matthias Brugger
On 14/02/2020 11:06, Matthias Brugger wrote: > > > On 14/02/2020 05:49, Bibby Hsieh wrote: >> In order to use GCE function, we need add some information >> into display node (mboxes, mediatek,gce-client-reg, mediatek,gce-events). >> >> Signed-off-by: Bibby Hsieh >> Signed-off-by: Yongqiang Niu

[PATCH] drm/i915/gt: Initialize reserved and unspecified MOCS indices

2020-05-21 Thread Ayaz A Siddiqui
In order to avoid functional breakage of mis-programmed applications that have grown to depend on unused MOCS entries. It has been decided to program those entries to be equal to fully cached ("L3 + LLC") entry. These reserved and unspecified entries should not be used as they may be changed to le

Re: [PATCH] drm/i915/gt: Initialize reserved and unspecified MOCS indices

2020-05-21 Thread Chris Wilson
Quoting Ayaz A Siddiqui (2020-05-21 11:41:52) > In order to avoid functional breakage of mis-programmed applications that > have grown to depend on unused MOCS entries. It has been decided to > program those entries to be equal to fully cached ("L3 + LLC") entry. "It has been" appears to be you ha

Re: [PATCH v5, 32/32] drm/mediatek: add support for mediatek SOC MT8183

2020-05-21 Thread Matthias Brugger
On 29/08/2019 16:50, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add support for mediatek SOC MT8183 > 1.ovl_2l share driver with ovl > 2.rdma1 share drive with rdma0, but fifo size is different > 3.add mt8183 mutex private data, and mmsys private data > 4.add mt8183

Re: [PATCH 1/3] arm64: dts: mt8183: Add gce setting in display node

2020-05-21 Thread Bibby Hsieh
On Thu, 2020-05-21 at 12:10 +0200, Matthias Brugger wrote: > On 14/02/2020 11:06, Matthias Brugger wrote: > > > > > > On 14/02/2020 05:49, Bibby Hsieh wrote: > >> In order to use GCE function, we need add some information > >> into display node (mboxes, mediatek,gce-client-reg, mediatek,gce-event

[PATCH v2] drm: add docs for standard CRTC properties

2020-05-21 Thread Simon Ser
This patch adds docs for the ACTIVE and MODE_ID CRTC properties. Signed-off-by: Simon Ser Cc: Daniel Vetter Cc: Ville Syrjala Cc: Pekka Paalanen Cc: Michel Dänzer Cc: Daniel Stone --- Thanks for the review Daniel! I rejiggered your suggestions a little to move some ACTIVE bits into the ACTI

Re: [PATCH v2 2/2] drm/udl: Use GEM vmap/mmap function from SHMEM helpers

2020-05-21 Thread Noralf Trønnes
Den 19.05.2020 10.04, skrev Thomas Zimmermann: > The udl driver contains an implementation of GEM vmap and mmap > operations that is identical to the common SHMEM helper; except > that udl's code uses cached pages by default. > > Convert udl to regular SHMEM helper functions. There's no reason

Re: [PATCH 1/3] arm64: dts: mt8183: Add gce setting in display node

2020-05-21 Thread Matthias Brugger
On 21/05/2020 12:47, Bibby Hsieh wrote: > On Thu, 2020-05-21 at 12:10 +0200, Matthias Brugger wrote: >> On 14/02/2020 11:06, Matthias Brugger wrote: >>> >>> >>> On 14/02/2020 05:49, Bibby Hsieh wrote: In order to use GCE function, we need add some information into display node (mboxes,

Re: [PATCH] drm/amd/amdkfd: Fix large framesize for kfd_smi_ev_read()

2020-05-21 Thread Aurabindo Pillai
On 05/20, Felix Kuehling wrote: > Am 2020-05-20 um 9:53 a.m. schrieb Aurabindo Pillai: > > The buffer allocated is of 1024 bytes. Allocate this from > > heap instead of stack. > > > > Also remove check for stack size since we're allocating from heap > > > > Signed-off-by: Aurabindo Pillai > > Test

Re: [PATCH v1 13/25] dma-buf: Use sequence counter with associated wound/wait mutex

2020-05-21 Thread Christian König
Am 21.05.20 um 02:09 schrieb Ahmed S. Darwish: On Wed, May 20, 2020, Christian König wrote: Am 19.05.20 um 23:45 schrieb Ahmed S. Darwish: A sequence counter write side critical section must be protected by some form of locking to serialize writers. If the serialization primitive is not disabli

Re: [PATCH] drm/i915/hdcp: Avoid duplicate HDCP enables

2020-05-21 Thread Sean Paul
On Thu, May 21, 2020 at 5:36 AM Anshuman Gupta wrote: > > On 2020-05-21 at 10:27:21 +0530, Ramalingam C wrote: > > On 2020-05-20 at 15:47:44 -0400, Sean Paul wrote: > > > From: Sean Paul > > > > > > If userspace sets the CP property to DESIRED while it's already ENABLED, > > > the driver will try

[PATCH] staging: fbtft: fb_st7789v: make HSD20_IPS numeric and not a string

2020-05-21 Thread Colin King
From: Colin Ian King Currently HSD20_IPS is defined as "true" and will always result in a non-zero result even if it is defined as "false" because it is an array and that will never be zero. Fix this by defining it as an integer 1 rather than a literal string. Addessses-Coverity: ("Array compare

Re: [PATCH v1 2/4] arm: dts: mt7623: add display subsystem related device nodes

2020-05-21 Thread Matthias Brugger
Hi Frank, On 16/04/2019 16:58, Frank Wunderlich wrote: > From: Ryder Lee > > Add display subsystem related device nodes for MT7623. > > Cc: CK Hu > Signed-off-by: chunhui dai > Signed-off-by: Bibby Hsieh > Signed-off-by: Ryder Lee > > additional fixes: > > [hdmi,dts] fixed dts-warnings >

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-21 Thread Ira Weiny
On Tue, May 19, 2020 at 12:42:15PM -0700, Guenter Roeck wrote: > > On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > > > as do the nosmp sparc32 boot tests, > > > but sparc32 boot tests with SMP enabled still fail with lots of messages > > > such as: > > > > > > BUG: Bad page state

[Bug 201539] AMDGPU R9 390 automatic fan speed control in Linux 4.19/4.20/5.0

2020-05-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201539 --- Comment #54 from michael (lkb...@deegan.id.au) --- It seems that since kernel 5.6 (or at least Debian's version thereof), I no longer need to fiddle with /sys/class/drm/card0/device/hwmon/hwmon3/pwm1_enable. The default value (1) seems to do t

Re: [GIT PULL v2] mediatek drm next for 5.8

2020-05-21 Thread Chun-Kuang Hu
Hi, Dave: Dave Airlie 於 2020年5月20日 週三 下午1:44寫道: > > On Mon, 18 May 2020 at 10:06, Chun-Kuang Hu wrote: > > > > Hi, Dave & Daniel: > > > > This include dpi pin mode swap, config mipi_tx current and impedance, > > and some fixup. I drop drm_bridge patches in this version. > > > > The following cha

Re: [GIT PULL v2] mediatek drm next for 5.8

2020-05-21 Thread Chun-Kuang Hu
Hi, Dave: Dave Airlie 於 2020年5月20日 週三 下午1:47寫道: > > On Wed, 20 May 2020 at 15:44, Dave Airlie wrote: > > > > On Mon, 18 May 2020 at 10:06, Chun-Kuang Hu wrote: > > > > > > Hi, Dave & Daniel: > > > > > > This include dpi pin mode swap, config mipi_tx current and impedance, > > > and some fixup.

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-21 Thread Ira Weiny
On Thu, May 21, 2020 at 09:05:41AM -0700, Guenter Roeck wrote: > On 5/19/20 10:13 PM, Ira Weiny wrote: > > On Tue, May 19, 2020 at 12:42:15PM -0700, Guenter Roeck wrote: > >> On Tue, May 19, 2020 at 11:40:32AM -0700, Ira Weiny wrote: > >>> On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wro

[Bug 207833] New: Brightness control not working on ASUS TUF FA506IU (AMD Ryzen 7 4800H / Nvidia GTX 1660 Ti)

2020-05-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207833 Bug ID: 207833 Summary: Brightness control not working on ASUS TUF FA506IU (AMD Ryzen 7 4800H / Nvidia GTX 1660 Ti) Product: Drivers Version: 2.5 Kernel Version: 5.6.12-1

Re: [PATCH 2/2] dt-bindings: arm-smmu: Add sc7180 compatible string

2020-05-21 Thread Will Deacon
On Mon, May 18, 2020 at 01:59:49PM -0700, Doug Anderson wrote: > On Mon, May 18, 2020 at 7:39 AM Will Deacon wrote: > > On Fri, May 15, 2020 at 12:05:39PM -0700, Doug Anderson wrote: > > > On Fri, May 1, 2020 at 3:30 AM Sharat Masetty > > > wrote: > > > > > > > > This patch simply adds a new com

Re: [PATCH 0/4] mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-21 Thread Chris Wilson
Quoting John Hubbard (2020-05-19 01:21:20) > This needs to go through Andrew's -mm tree, due to adding a new gup.c > routine. However, I would really love to have some testing from the > drm/i915 folks, because I haven't been able to run-time test that part > of it. CI hit <4> [185.667750] WARNIN

Re: [PATCH 0/4] mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-21 Thread John Hubbard
On 2020-05-21 11:57, Chris Wilson wrote: Quoting John Hubbard (2020-05-19 01:21:20) This needs to go through Andrew's -mm tree, due to adding a new gup.c routine. However, I would really love to have some testing from the drm/i915 folks, because I haven't been able to run-time test that part of

Solved: [PATCH 0/4] mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-21 Thread John Hubbard
On 2020-05-21 12:11, John Hubbard wrote: On 2020-05-21 11:57, Chris Wilson wrote: Quoting John Hubbard (2020-05-19 01:21:20) This needs to go through Andrew's -mm tree, due to adding a new gup.c routine. However, I would really love to have some testing from the drm/i915 folks, because I haven'

[PATCH] drm/vblank: Fix -Wformat compile warnings on some arches

2020-05-21 Thread Lyude Paul
On some architectures like ppc64le and aarch64, compiling with -Wformat=1 will throw the following warnings: In file included from drivers/gpu/drm/drm_vblank.c:33: drivers/gpu/drm/drm_vblank.c: In function 'drm_update_vblank_count': drivers/gpu/drm/drm_vblank.c:273:16: warning: format '%llu'

Re: [PATCH] drm/vblank: Fix -Wformat compile warnings on some arches

2020-05-21 Thread Sam Ravnborg
On Thu, May 21, 2020 at 04:46:47PM -0400, Lyude Paul wrote: > On some architectures like ppc64le and aarch64, compiling with > -Wformat=1 will throw the following warnings: > > In file included from drivers/gpu/drm/drm_vblank.c:33: > drivers/gpu/drm/drm_vblank.c: In function 'drm_update_vblank

[pull] amdgpu drm-fixes-5.7

2020-05-21 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.7. The following changes since commit 5a3f610877e9d08968ea7237551049581f02b163: drm/edid: Add Oculus Rift S to non-desktop list (2020-05-20 12:56:49 +1000) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux tags/amd-drm-fixes-5.7-

RE: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-21 Thread Weiny, Ira
> On 5/21/20 10:42 AM, Ira Weiny wrote: > > On Thu, May 21, 2020 at 09:05:41AM -0700, Guenter Roeck wrote: > >> On 5/19/20 10:13 PM, Ira Weiny wrote: > >>> On Tue, May 19, 2020 at 12:42:15PM -0700, Guenter Roeck wrote: > On Tue, May 19, 2020 at 11:40:32AM -0700, Ira Weiny wrote: > > On Tue

[PATCH] mm/gup: fixup gup.c for "mm/gup: refactor and de-duplicate gup_fast() code"

2020-05-21 Thread John Hubbard
ko Ursulin Signed-off-by: John Hubbard --- Hi Andrew, Chris, Andrew: This is a fixup that applies to today's (20200521) linux-next. In that tree, this fixes up: commit dfb8dfe80808 ("mm/gup: refactor and de-duplicate gup_fast() code") Chris: I'd like to request another CI run fo

[PATCH] drm/radeon/dpm: Replace one-element array and use struct_size() helper

2020-05-21 Thread Gustavo A. R. Silva
The current codebase makes use of one-element arrays in the following form: struct something { int length; u8 data[1]; }; struct something *instance; instance = kmalloc(sizeof(*instance) + size, GFP_KERNEL); instance->length = size; memcpy(instance->data, source, size); but the preferre

[PULL] nouveau-next 5.8

2020-05-21 Thread Ben Skeggs
Hey Dave, Daniel, - HD audio fixes on recent systems - vGPU detection (fail probe if we're on one, for now) - Interlaced mode fixes (mostly avoidance on Turing, which doesn't support it) - SVM improvements/fixes - NVIDIA format modifier support - Misc other fixes. Thanks, Ben. The following chan

Re: [PATCH] mm/gup: fixup gup.c for "mm/gup: refactor and de-duplicate gup_fast() code"

2020-05-21 Thread Chris Wilson
c: Matthew Auld > Cc: Matthew Wilcox > Cc: Rodrigo Vivi > Cc: Souptick Joarder > Cc: Tvrtko Ursulin > Signed-off-by: John Hubbard > --- > > Hi Andrew, Chris, > > Andrew: This is a fixup that applies to today's (20200521) linux-next. > In that tree, this fixe

Re: [PATCH] mm/gup: fixup gup.c for "mm/gup: refactor and de-duplicate gup_fast() code"

2020-05-21 Thread John Hubbard
tthew Auld Cc: Matthew Wilcox Cc: Rodrigo Vivi Cc: Souptick Joarder Cc: Tvrtko Ursulin Signed-off-by: John Hubbard --- Hi Andrew, Chris, Andrew: This is a fixup that applies to today's (20200521) linux-next. In that tree, this fixes up: commit dfb8dfe80808 ("mm/gup: refactor and d

[PATCH 2/2] video: fbdev: convert get_user_pages() --> pin_user_pages()

2020-05-21 Thread John Hubbard
This code was using get_user_pages*(), in a "Case 2" scenario (DMA/RDMA), using the categorization from [1]. That means that it's time to convert the get_user_pages*() + put_page() calls to pin_user_pages*() + unpin_user_pages() calls. There is some helpful background in [2]: basically, this is a

[PATCH 1/2] video: fbdev: fix error handling for get_user_pages_fast()

2020-05-21 Thread John Hubbard
Dealing with the return value of get_user_pages*() variants has a few classic pitfalls, and this driver found one of them: the return value might be zero, positive, or -errno. And if positive, it might be fewer pages than were requested. And if fewer pages than requested, then the caller should ret

[PATCH 0/2] video: fbdev: fix error handling, convert to pin_user_pages*()

2020-05-21 Thread John Hubbard
Hi, Note that I have only compile-tested this series, although that does also include cross-compiling for a few other arches. I'm hoping that this posting will lead to some run-time testing. Also: the proposed fix does not have a "Fixes:" tag, nor does it Cc stable. That's because the issue has b

[PATCH v2 0/4] mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-21 Thread John Hubbard
The purpose of posting this series is to launch a test in the intel-gfx-ci tree. (The patches have already been merged into Andrew's linux-mm tree.) This applies to today's linux.git (note the base-commit tag at the bottom). Changes since V1: * Fixed a bug in the refactoring patch: added FOLL_FA

[PATCH v2 3/4] mm/gup: introduce pin_user_pages_fast_only()

2020-05-21 Thread John Hubbard
This is the FOLL_PIN equivalent of __get_user_pages_fast(), except with a more descriptive name, and gup_flags instead of a boolean "write" in the argument list. Signed-off-by: John Hubbard --- include/linux/mm.h | 2 ++ mm/gup.c | 36 2 files chan

[PATCH v2 1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c

2020-05-21 Thread John Hubbard
This is in order to avoid a forward declaration of internal_get_user_pages_fast(), in the next patch. This is code movement only--all generated code should be identical. Signed-off-by: John Hubbard --- mm/gup.c | 112 +++ 1 file changed, 56 in

[PATCH v2 4/4] drm/i915: convert get_user_pages() --> pin_user_pages()

2020-05-21 Thread John Hubbard
This code was using get_user_pages*(), in a "Case 2" scenario (DMA/RDMA), using the categorization from [1]. That means that it's time to convert the get_user_pages*() + put_page() calls to pin_user_pages*() + unpin_user_pages() calls. There is some helpful background in [2]: basically, this is a

[PATCH v2 2/4] mm/gup: refactor and de-duplicate gup_fast() code

2020-05-21 Thread John Hubbard
There were two nearly identical sets of code for gup_fast() style of walking the page tables with interrupts disabled. This has lead to the usual maintenance problems that arise from having duplicated code. There is already a core internal routine in gup.c for gup_fast(), so just enhance it very s

[PATCH] drm/exynos: Properly propagate return value in drm_iommu_attach_device()

2020-05-21 Thread Marek Szyprowski
Propagate the proper error codes from the called functions instead of unconditionally returning 0. Reported-by: kbuild test robot Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos_drm_dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/e

Re: [PATCH] drm/vblank: Fix -Wformat compile warnings on some arches

2020-05-21 Thread Thomas Zimmermann
Am 21.05.20 um 22:46 schrieb Lyude Paul: > On some architectures like ppc64le and aarch64, compiling with > -Wformat=1 will throw the following warnings: > > In file included from drivers/gpu/drm/drm_vblank.c:33: > drivers/gpu/drm/drm_vblank.c: In function 'drm_update_vblank_count': > driv

[PATCH 1/1] drm: check for NULL pointer in drm_gem_object_put

2020-05-21 Thread Nirmoy Das
drm_gem_fb_destroy() calls drm_gem_object_put() with NULL obj causing: [ 11.584209] BUG: kernel NULL pointer dereference, address: [ 11.584213] #PF: supervisor write access in kernel mode [ 11.584215] #PF: error_code(0x0002) - not-present page [ 11.584216] PGD 0 P4D 0 [ 1

[PATCH 2/2] serial: stm32: Use generic DT binding for announcing RTS/CTS lines

2020-05-21 Thread Erwan Le Ray
Add support of generic DT binding for annoucing RTS/CTS lines. The initial binding 'st,hw-flow-control' is not needed anymore since generic binding is available, but is kept for backward compatibility. Signed-off-by: Erwan Le Ray diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial

[PATCH 1/2] dt-bindings: serial: add generic DT binding for announcing RTS/CTS lines

2020-05-21 Thread Erwan Le Ray
Add support of generic DT binding for annoucing RTS/CTS lines. The initial binding 'st,hw-flow-control' is not needed anymore since generic binding is available, but is kept for backward compatibility. Signed-off-by: Erwan Le Ray diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uar

[PATCH v3] drm/exynos: Remove dev_err() on platform_get_irq() failure

2020-05-21 Thread Tamseel Shams
platform_get_irq() will call dev_err() itself on failure, so there is no need for the driver to also do this. This is detected by coccinelle. Signed-off-by: Tamseel Shams --- - Changes since v2: * Addressed Inki Dae comments drivers/gpu/drm/exynos/exynos_drm_g2d.c | 1 - 1 file changed, 1 delet

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-21 Thread Al Viro
On Thu, May 21, 2020 at 03:20:46PM -0700, Guenter Roeck wrote: > On 5/21/20 10:27 AM, Al Viro wrote: > > On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > >> On Mon, May 18, 2020 at 11:48:43AM -0700, ira.we...@intel.com wrote: > >>> From: Ira Weiny > >>> > >>> The kunmap_atomic clea

Re: [PATCH 1/5] drivers/powerpc: Replace _ALIGN_UP() by ALIGN()

2020-05-21 Thread Michael Ellerman
On Mon, 20 Apr 2020 18:36:34 + (UTC), Christophe Leroy wrote: > _ALIGN_UP() is specific to powerpc > ALIGN() is generic and does the same > > Replace _ALIGN_UP() by ALIGN() Applied to powerpc/next. [1/5] drivers/powerpc: Replace _ALIGN_UP() by ALIGN() https://git.kernel.org/powerpc/c/7

[Bug Report] drivers/video/fbdev/kyro/fbdev.c: unsigned integer wrap-around might cause unexpected behavior

2020-05-21 Thread Changming Liu
Hi Bartlomiej, Greetings, I'm a first-year PhD student who is interested in the usage of UBSan for linux. And after some experiments, I found that in drivers/video/fbdev/kyro/fbdev.c function kyro_dev_overlay_viewport_set, there is an unsigned integer overflow that might cause unexpected behavio

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-05-21 Thread Michael Ellerman
Arnd Bergmann writes: > +On Wed, Apr 8, 2020 at 2:04 PM Michael Ellerman wrote: >> Benjamin Herrenschmidt writes: >> > On Fri, 2020-04-03 at 15:59 +1100, Michael Ellerman wrote: >> >> Benjamin Herrenschmidt writes: >> > IBM still put 40x cores inside POWER chips no ? >> >> Oh yeah that's true.

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-05-21 Thread Christophe Leroy
Le 21/05/2020 à 09:02, Michael Ellerman a écrit : Arnd Bergmann writes: +On Wed, Apr 8, 2020 at 2:04 PM Michael Ellerman wrote: Benjamin Herrenschmidt writes: On Fri, 2020-04-03 at 15:59 +1100, Michael Ellerman wrote: Benjamin Herrenschmidt writes: IBM still put 40x cores inside POWER

[PATCH] drm/etnaviv: fix runtime pm imbalance on error

2020-05-21 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 3 +++ 1 file changed, 3 insertion

Re: Re: [PATCH] drm/panfrost: fix runtime pm imbalance on error

2020-05-21 Thread dinghao . liu
Hi Steve, There are two bailing out points in panfrost_job_hw_submit(): one is the error path beginning from pm_runtime_get_sync(), the other one is the error path beginning from WARN_ON() in the if statement. The pm imbalance fixed in this patch is between these two paths. I think the caller

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-05-21 Thread Michal Simek
On 21. 05. 20 15:53, Michael Ellerman wrote: > Christophe Leroy writes: >> Le 21/05/2020 à 09:02, Michael Ellerman a écrit : >>> Arnd Bergmann writes: +On Wed, Apr 8, 2020 at 2:04 PM Michael Ellerman wrote: > Benjamin Herrenschmidt writes: >> On Fri, 2020-04-03 at 15:59 +1100

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-05-21 Thread Michael Ellerman
Christophe Leroy writes: > Le 21/05/2020 à 09:02, Michael Ellerman a écrit : >> Arnd Bergmann writes: >>> +On Wed, Apr 8, 2020 at 2:04 PM Michael Ellerman >>> wrote: Benjamin Herrenschmidt writes: > On Fri, 2020-04-03 at 15:59 +1100, Michael Ellerman wrote: >> Benjamin Herrenschmi

Re: [PATCH v1 13/25] dma-buf: Use sequence counter with associated wound/wait mutex

2020-05-21 Thread Ahmed S. Darwish
On Wed, May 20, 2020, Christian König wrote: > Am 19.05.20 um 23:45 schrieb Ahmed S. Darwish: > > A sequence counter write side critical section must be protected by some > > form of locking to serialize writers. If the serialization primitive is > > not disabling preemption implicitly, preemption

[PATCH] drm/nouveau/dispnv50: fix runtime pm imbalance on error

2020-05-21 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 +++- 1 file changed, 3 insert

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-21 Thread Guenter Roeck
On Fri, May 22, 2020 at 02:35:23AM +0100, Al Viro wrote: > On Fri, May 22, 2020 at 02:29:50AM +0100, Al Viro wrote: > > On Thu, May 21, 2020 at 06:11:08PM -0700, Guenter Roeck wrote: > > > > > Mainline, with: > > > > > > qemu-system-sparc -M SS-4 -kernel arch/sparc/boot/zImage -no-reboot \ > > >

[PATCH v2] drm/fourcc: Add bayer formats and modifiers

2020-05-21 Thread Niklas Söderlund
Bayer formats are used with cameras and contain green, red and blue components, with alternating lines of red and green, and blue and green pixels in different orders. For each block of 2x2 pixels there is one pixel with a red filter, two with a green filter, and one with a blue filter. The filters

[PATCH] drm/nouveau: fix runtime pm imbalance on error

2020-05-21 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/gpu/drm/nouveau/nouveau_gem.c | 2 +- 1 file changed, 1 insertion(

[PATCH v2 1/1] drm: check for NULL pointer in drm_gem_object_put

2020-05-21 Thread Nirmoy Das
drm_gem_fb_destroy() calls drm_gem_object_put() with NULL obj causing: [ 11.584209] BUG: kernel NULL pointer dereference, address: [ 11.584213] #PF: supervisor write access in kernel mode [ 11.584215] #PF: error_code(0x0002) - not-present page [ 11.584216] PGD 0 P4D 0 [

[PATCH] drm/v3d: fix runtime pm imbalance on error

2020-05-21 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/gpu/drm/v3d/v3d_gem.c | 4 +++- 1 file changed, 3 insertions(+), 1

RE: [PATCH v2] drm/exynos: Remove dev_err() on platform_get_irq() failure

2020-05-21 Thread M Tamseel Shams
> -Original Message- > From: Inki Dae > Sent: Wednesday, May 20, 2020 11:08 AM > To: Tamseel Shams ; jy0922.s...@samsung.com; > sw0312@samsung.com; kyungmin.p...@samsung.com; airl...@linux.ie; > dan...@ffwll.ch > Cc: dri-devel@lists.freedesktop.org; linux-arm-ker...@lists.infradead.

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-21 Thread Guenter Roeck
On 5/21/20 10:27 AM, Al Viro wrote: > On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: >> On Mon, May 18, 2020 at 11:48:43AM -0700, ira.we...@intel.com wrote: >>> From: Ira Weiny >>> >>> The kunmap_atomic clean up failed to remove one set of pagefault/preempt >>> enables when vaddr i

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2020-05-21 Thread Shengjiu Wang
Hi On Wed, May 20, 2020 at 5:42 PM Lucas Stach wrote: > > Am Mittwoch, den 20.05.2020, 16:20 +0800 schrieb Shengjiu Wang: > > Hi > > > > On Tue, May 19, 2020 at 6:04 PM Lucas Stach wrote: > > > Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu Wang: > > > > There are two requirements tha

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-21 Thread Al Viro
On Thu, May 21, 2020 at 06:11:08PM -0700, Guenter Roeck wrote: > Mainline, with: > > qemu-system-sparc -M SS-4 -kernel arch/sparc/boot/zImage -no-reboot \ > -snapshot -drive file=rootfs.ext2,format=raw,if=scsi \ > -append "panic=-1 slub_debug=FZPUA root=/dev/sda console=ttyS0" >

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-21 Thread Guenter Roeck
On 5/19/20 10:13 PM, Ira Weiny wrote: > On Tue, May 19, 2020 at 12:42:15PM -0700, Guenter Roeck wrote: >> On Tue, May 19, 2020 at 11:40:32AM -0700, Ira Weiny wrote: >>> On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: On Mon, May 18, 2020 at 11:48:43AM -0700, ira.we...@intel.com

Re: [RFC PATCH 0/4] DirectX on Linux

2020-05-21 Thread Jan Engelhardt
On Tuesday 2020-05-19 22:36, Sasha Levin wrote: > >> - Why DX12 on linux? Looking at this feels like classic divide and > > There is a single usecase for this: WSL2 developer who wants to run > machine learning on his GPU. The developer is working on his laptop, > which is running Windows and tha

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2020-05-21 Thread Shengjiu Wang
On Wed, May 20, 2020 at 8:38 PM Mark Brown wrote: > > On Wed, May 20, 2020 at 07:22:19PM +0800, Shengjiu Wang wrote: > > > I see some driver also request dma channel in open() or hw_params(). > > how can they avoid the defer probe issue? > > for example: > > sound/arm/pxa2xx-pcm-lib.c > > sound/so

Re: [RFC PATCH 0/8] Qualcomm Cloud AI 100 driver

2020-05-21 Thread Jeffrey Hugo
On 5/20/2020 9:59 AM, Greg Kroah-Hartman wrote: On Wed, May 20, 2020 at 08:48:13AM -0600, Jeffrey Hugo wrote: On 5/20/2020 2:34 AM, Daniel Vetter wrote: On Wed, May 20, 2020 at 7:15 AM Greg Kroah-Hartman wrote: On Tue, May 19, 2020 at 10:41:15PM +0200, Daniel Vetter wrote: On Tue, May 19, 2

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-21 Thread Guenter Roeck
On 5/21/20 10:42 AM, Ira Weiny wrote: > On Thu, May 21, 2020 at 09:05:41AM -0700, Guenter Roeck wrote: >> On 5/19/20 10:13 PM, Ira Weiny wrote: >>> On Tue, May 19, 2020 at 12:42:15PM -0700, Guenter Roeck wrote: On Tue, May 19, 2020 at 11:40:32AM -0700, Ira Weiny wrote: > On Tue, May 19, 20

[PATCH 0/2] add generic DT binding for RTS/CTS

2020-05-21 Thread Erwan Le Ray
Add support of generic DT binding for annoucing RTS/CTS lines. The initial binding 'st,hw-flow-control' is not needed anymore since generic binding is available, but is kept for backward compatibility. Erwan Le Ray (2): dt-bindings: serial: add generic DT binding for announcing RTS/CTS lines

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2020-05-21 Thread Shengjiu Wang
Hi On Tue, May 19, 2020 at 6:04 PM Lucas Stach wrote: > > Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu Wang: > > There are two requirements that we need to move the request > > of dma channel from probe to open. > > How do you handle -EPROBE_DEFER return code from the channel request

[PATCH] drm/nouveau/debugfs: fix runtime pm imbalance on error

2020-05-21 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 5 - 1 file changed, 4 ins

Re: [PATCH v2 20/91] clk: bcm: rpi: Discover the firmware clocks

2020-05-21 Thread Nicolas Saenz Julienne
Hi Maxime, On Fri, 2020-05-15 at 10:19 +0200, Maxime Ripard wrote: > Hi Nicolas, > > On Mon, May 04, 2020 at 02:05:47PM +0200, Nicolas Saenz Julienne wrote: > > Hi Maxime, as always, thanks for the series! > > Some extra context, and comments below. > > > > On Fri, 2020-04-24 at 17:34 +0200, Max

[PATCH v2 1/1] drm: check for NULL pointer in drm_gem_object_put

2020-05-21 Thread Nirmoy Das
drm_gem_fb_destroy() calls drm_gem_object_put() with NULL obj causing: [ 11.584209] BUG: kernel NULL pointer dereference, address: [ 11.584213] #PF: supervisor write access in kernel mode [ 11.584215] #PF: error_code(0x0002) - not-present page [ 11.584216] PGD 0 P4D 0 [

Re: [RFC] Deprecate AGP GART support for Radeon/Nouveau/TTM

2020-05-21 Thread Rui Salvaterra
Hi, Christian, On Wed, 20 May 2020 at 16:00, Christian König wrote: > > So I've used an ancient system (32bit) to setup a test box for this. > > > The first GPU I could test is an RV280 (Radeon 9200 PRO) which is easily > 15 years old. Oh, I have one of those in box somewhere, but no AGP machine

[PATCH] drm/nouveau: fix runtime pm imbalance on error

2020-05-21 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/gpu/drm/nouveau/nouveau_gem.c | 4 +++- 1 file changed, 3 insertio

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-21 Thread Guenter Roeck
On 5/21/20 5:46 PM, Al Viro wrote: > On Thu, May 21, 2020 at 11:46:12PM +0100, Al Viro wrote: >> On Thu, May 21, 2020 at 03:20:46PM -0700, Guenter Roeck wrote: >>> On 5/21/20 10:27 AM, Al Viro wrote: On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > On Mon, May 18, 2020 at 1

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-21 Thread Al Viro
On Thu, May 21, 2020 at 11:46:12PM +0100, Al Viro wrote: > On Thu, May 21, 2020 at 03:20:46PM -0700, Guenter Roeck wrote: > > On 5/21/20 10:27 AM, Al Viro wrote: > > > On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > > >> On Mon, May 18, 2020 at 11:48:43AM -0700, ira.we...@intel.com

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-21 Thread Al Viro
On Fri, May 22, 2020 at 02:29:50AM +0100, Al Viro wrote: > On Thu, May 21, 2020 at 06:11:08PM -0700, Guenter Roeck wrote: > > > Mainline, with: > > > > qemu-system-sparc -M SS-4 -kernel arch/sparc/boot/zImage -no-reboot \ > > -snapshot -drive file=rootfs.ext2,format=raw,if=scsi \ > > -app

Re: [PATCH 2/3] drm/etnaviv: Don't ignore errors on getting clocks

2020-05-21 Thread Lubomir Rintel
On Thu, May 14, 2020 at 09:53:08AM +0100, Russell King - ARM Linux admin wrote: > On Thu, May 14, 2020 at 10:40:58AM +0200, Lucas Stach wrote: > > Am Donnerstag, den 14.05.2020, 09:27 +0100 schrieb Russell King - ARM Linux > > admin: > > > On Thu, May 14, 2020 at 10:18:02AM +0200, Lucas Stach wrot

[Bug Report] drivers/video/fbdev/da8xx-fb.c: undefined behavior when left shifting

2020-05-21 Thread Changming Liu
Hi Bartlomiej, Greetings, it's me again, I sent you a bug report yesterday, I hope that find you well. This time I found that in /drivers/video/fbdev/da8xx-fb.c function lcd_cfg_vertical_sync, there might be an undefined result by left shifting. More specifically, in function lcd_cfg_vertical_s

[PATCH] drm/panfrost: fix runtime pm imbalance on error

2020-05-21 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/gpu/drm/panfrost/panfrost_job.c | 4 +++- 1 file changed, 3 insert

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-21 Thread Al Viro
On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > On Mon, May 18, 2020 at 11:48:43AM -0700, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > The kunmap_atomic clean up failed to remove one set of pagefault/preempt > > enables when vaddr is not in the fixmap. > > > > Fixes: b

Re: [RFC PATCH 0/8] Qualcomm Cloud AI 100 driver

2020-05-21 Thread Jeffrey Hugo
On 5/20/2020 2:34 AM, Daniel Vetter wrote: On Wed, May 20, 2020 at 7:15 AM Greg Kroah-Hartman wrote: On Tue, May 19, 2020 at 10:41:15PM +0200, Daniel Vetter wrote: On Tue, May 19, 2020 at 07:41:20PM +0200, Greg Kroah-Hartman wrote: On Tue, May 19, 2020 at 08:57:38AM -0600, Jeffrey Hugo wrote